Prepare step: -vv should be more verbose

At least for recommends. The whole output, from prepare step:
    prepare
        how: install
        summary: Install required packages
        name: requires
        package: beakerlib
        how: install
        summary: Install recommended packages
        name: recommends
        package: rubygems, rubygem-jbuilder, rubygem-puma and 21 more
        summary: 2 preparations applied

It doesn't even list all the packages that were installed.
TMT Version:
Source       : tmt-0.21-1.fc34.src.rpm
Repository   : @System
From repo    : copr:copr.fedorainfracloud.org:psss:tmt

Commandline (run in root of this repo+branch):
$ tmt run -avv provision -h container execute -h beakerlib

@psss Ping?
It's really frustrating, when I run with -vvv:
$ tmt run -avvv prepare -h install -p '*/bin/gem' provision -h container discover -h fmf --filter tag:rubygems
/var/tmp/tmt/run-010
Found 1 plan.

/plans/default
    discover
        how: fmf
        order: 50
        directory: /home/lpcs/lpcsf-new/test/fedora/packages/ruby/tests
        filter: tag:rubygems
        summary: 1 test selected
            /example-test
    provision
        how: container
        order: 50
        image: fedora
        name: tmt-var-tmp-tmt-run-010-plans-default
        distro: Fedora 32 (Container Image)
        kernel: 5.8.0-0.rc5.20200714git0dc589da873b.1.fc33.x86_64
        summary: 1 guest provisioned
    prepare
        how: install
        order: 50
        package: 1 package requested
            */bin/gem
        how: install
        summary: Install required packages
        name: requires
        order: 70
        package: 1 package requested
            beakerlib
        summary: 2 preparations applied
    execute
        how: tmt
        order: 50
            test: Concise summary describing what the test does
                out:
                out: ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
                out: ::   Setup
                out: ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
                out:
                out: :: [ 16:56:18 ] :: [  BEGIN   ] :: Creating tmp directory :: actually running 'tmp=$(mktemp -d)'
                out: :: [ 16:56:18 ] :: [   PASS   ] :: Creating tmp directory (Expected 0, got 0)
                out: :: [ 16:56:18 ] :: [  BEGIN   ] :: Running 'pushd /tmp/tmp.TOl4d5Pdkx'
                out: /tmp/tmp.TOl4d5Pdkx /var/tmp/tmt/run-010/plans/default/discover/default/tests/example-test
                out: :: [ 16:56:18 ] :: [   PASS   ] :: Command 'pushd /tmp/tmp.TOl4d5Pdkx' (Expected 0, got 0)
                out: :: [ 16:56:18 ] :: [  BEGIN   ] :: Running 'set -o pipefail'
                out: :: [ 16:56:18 ] :: [   PASS   ] :: Command 'set -o pipefail' (Expected 0, got 0)
                out: ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
                out: ::   Duration: 1s
                out: ::   Assertions: 3 good, 0 bad
                out: ::   RESULT: PASS (Setup)
                out:
                out:
                out: ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
                out: ::   Test
                out: ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
                out:
                out: :: [ 16:56:18 ] :: [  BEGIN   ] :: Check help message :: actually running 'gem list | tee output'
                out: /usr/share/beakerlib/testing.sh: line 891: gem: command not found

there's no failure for prepare
there's no useful message for the installation of */usr/bin/gem.

I do not get info what was actually run, even with max verbosity+debug:
$ tmt run -a prepare -h install -vvvddd -p '*/bin/gem' provision -h container discover -h fmf --filter tag:rubygems login --when fail --when error --step execute
/var/tmp/tmt/run-024

/plans/default
        Read file '/var/tmp/tmt/run-024/plans/default/prepare/step.yaml'.
        Step data not found.
        Using the 'PrepareInstall' plugin for the 'install' method.
        status: todo
        Write file '/var/tmp/tmt/run-024/plans/default/prepare/step.yaml'.
    discover
        how: fmf
        directory: /home/lpcs/lpcsf-new/test/fedora/packages/ruby/tests
        filter: tag:rubygems
        summary: 1 test selected
    provision
        how: container
        image: fedora
        distro: Fedora 32 (Container Image)
        summary: 1 guest provisioned
    prepare
        workdir: /var/tmp/tmt/run-024/plans/default/prepare
        Using the 'PrepareInstall' plugin for the 'install' method.
        how: install
        order: 50
            Check if sudo is necessary.
            Check if dnf is available.
            Using 'dnf' for all package operations.
        package: 1 package requested
            */bin/gem
        how: install
        summary: Install required packages
        name: requires
        order: 70
            Check if sudo is necessary.
            Check if dnf is available.
            Using 'dnf' for all package operations.
        package: 1 package requested
            beakerlib
        summary: 2 preparations applied
        status: done
        Write file '/var/tmp/tmt/run-024/plans/default/prepare/step.yaml'.
    execute
        how: tmt
        login: Starting interactive shell
[root@3fd8bec7d675 execute]# gem
bash: gem: command not found

Note: the fix would be f.e. to install /usr/bin/gem, but that's not the point. Isn't this a bug as well though?


Added a time out for the market data semaphore in the client

Added a time out for the semaphore in the client using the same structure as found in the Hawkes client.

I don’t recall why the code was written like that, so I think it is best to make the change on your code first before updating the hawkes client code.

On 16 May 2022, at 4:14 pm, matthewdicks98 @.***> wrote:
@matthewdicks98 commented on this pull request.
In ClientSimulator/src/main/java/client/Client.java https://github.com/dharmeshsing/CoinTossX/pull/8#discussion_r873353653:

@@ -153,7 +153,15 @@ public void close() {
System.out.println("Logged out.");
}

public void waitForMarketDataUpdate() { while(!mktDataUpdateSemaphore.acquire()){} }

public void waitForMarketDataUpdate() {

   long startTime = System.currentTimeMillis();

   while(!mktDataUpdateSemaphore.acquire()){

No problem. This was the implementation in the Hawkes client so does that need to be changed to use a tryAquire as well?
—
Reply to this email directly, view it on GitHub https://github.com/dharmeshsing/CoinTossX/pull/8#discussion_r873353653, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSXZWLUBP65NQDLFERKWPLVKHRTDANCNFSM5VYAOY2A.
You are receiving this because you commented.


FIX-#9999: test unicode_escape param

Signed-off-by: Anatoly Myachev<EMAIL_ADDRESS>
What do these changes do?

[ ] commit message follows format outlined here
[ ] passes flake8 modin
[ ] passes black --check modin
[ ] signed commit with git commit -s
[ ] Resolves #?
[ ] tests added and passing

it seems that tests are passing, however modin can't read cvs with encoding="unicode_escape"
if __name__ == "__main__":
    import modin.pandas as pd
    import pandas
    from modin.pandas.test.test_io import (
        create_test_pandas_dataframe,
        TEST_CSV_FILENAME,
        df_equals,
    )

    create_test_pandas_dataframe().to_csv(TEST_CSV_FILENAME, encoding="unicode_escape")

    pd_df = pandas.read_csv(TEST_CSV_FILENAME, encoding="unicode_escape")
    md_df = pd.read_csv(TEST_CSV_FILENAME, encoding="unicode_escape")

    print(df_equals(md_df, pd_df)) # False (no AssertionError)

    assert len(md_df) == len(pd_df) # AssertionError: 0 != 4

this happens because of a bug in df_equals, I've filled it in an issue #2249

Blocked by #2249.

it seems that tests are passing, however modin can't read cvs with encoding="unicode_escape"
if __name__ == "__main__":
    import modin.pandas as pd
    import pandas
    from modin.pandas.test.test_io import (
        create_test_pandas_dataframe,
        TEST_CSV_FILENAME,
        df_equals,
    )

    create_test_pandas_dataframe().to_csv(TEST_CSV_FILENAME, encoding="unicode_escape")

    pd_df = pandas.read_csv(TEST_CSV_FILENAME, encoding="unicode_escape")
    md_df = pd.read_csv(TEST_CSV_FILENAME, encoding="unicode_escape")

    print(df_equals(md_df, pd_df)) # False (no AssertionError)

    assert len(md_df) == len(pd_df) # AssertionError: 0 != 4

this happens because of a bug in df_equals, I've filled it in an issue #2249

I see

Still investigating io-part of modin and pandas codebase.

Closed in favor of #2309.


oidc_proto_authorization_request not set after mod_headers

I run an apache with mod_auth_oid behind a LoadBalancer that works in pass-through mode which can not add the X-Forwarded- headers. As the Load-Balancer listens on port 443 and the apache is listening on port 8443, I have to add the X-Forwarded-Port to 443 using the RequestHeader directive to the apache configuration to get the correct URL redirect after authentication, see: https://github.com/pingidentity/mod_auth_openidc/blob/6581138b61147a3001f030193e528cd1a1d54930/src/util.c#L390
Environment

mod_auth_openidc-2.3.2 - init - cjose 0.5.1, OpenSSL 1.0.2k-fips 26 Jan 2017, EC=yes, GCM=yes, Redis=yes, JQ=no
mod_ssl/2.4.6 compiled against Server: Apache/2.4.6, Library: OpenSSL/1.0.2k
CentOS Linux release 7.4.1708 (Core) docker image

Expected behaviour
The module can see the header X-Forwarded-Port as part of the request without early option.
Actual behaviour
The module can not see the header X-Forwarded-Port as part of the request without early option
Minimized example
Works:
RequestHeader set X-Forwarded-Port 443 early

Doesn't work:
RequestHeader set X-Forwarded-Port 443

Recommendation from apache documentation:

Early mode is designed as a test/debugging aid for developers. Directives defined using the early keyword are set right at the beginning of processing the request. This means they can be used to simulate different requests and set up test cases, but it also means that headers may be changed at any time by other modules before generating a Response.

The text also mentions:

mod_headers can be applied either early or late in the request. The normal mode is late, when Request Headers are set immediately before running the content generator

But the content generator is, by nature, triggered only after the authentication/authorization phase so the normal header setting is too late for that. This behavior cannot be changed by mod_auth_openidc.The fact that this is used for testing/debugging usually and that other headers may change it afterwards is not important here, it is not unsafe/insecure or anything. In your case it is used as a stop-gap for something that a Load Balancer could/should have done and that is OK.
In summary: there's nothing mod_auth_openidc can do about it, it's not a problem in itself and there's no alternative for you.


Only last task's score is visible

I have a competition with 10 tasks. In the submission panel, ingestion and scoring programs are executed successfully but I can only see the last task's score only
Competition link: https://www.codabench.org/competitions/1162/?secret_key=44be2900-ada6-4b67-ade0-e4e5896c0720
Leaderboard screenshot:

It looks like the score is there in the submission panel (first score) but shows n/a in leaderboard
here is a screenshot:

Edit:
weird but it is fixed for new submissions after I changed the leaderboard rule from Force Last to Force Last Multiple. See the last 2 submissions in the below screenshot

Edit 2:
I have three submissions on leaderboard but on submission panel it says 2 are on leaderboard

Closing this as n/a scores were because of scoring program failing for some tasks


Fixes dark model color schema

when I choose "dark mode" I see the buttons and dr

opdowns like this:
Originally posted by @cristiam86 in https://github.com/yeagerai/genlayer-simulator/issues/113#issuecomment-2093070152

fixed now in the PR https://github.com/yeagerai/genlayer-simulator/pull/113


Move ingress yaml to manifest folder when azd cli is fixed

Issue https://github.com/Azure/azure-dev/issues/2390 required ingress yaml to be deployed via hook script.  Move to manifests for auto deployment once it is fixed.

Fixed and tested https://github.com/Azure/azure-dev/pull/2405 with branch cq-fix-ingress.  Will submit PR once azd fix is available publicly.


5 month ago

code released.

Please see the response in other issues.
"This paper is not accepted, we are working on improving it. We would consider releasing the code after the acceptance."


feat: translate madara article to chinese

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

Documentation content changes

What is the current behavior?

Resolves: #922
What is the new behavior?
madara beast article.md is translated to chinese.
Does this introduce a breaking change?
No

@windrider0227 can u fix the linters errors please?

@windrider0227 can u fix the linters errors please?

sorry,let me check it

@CharlesP-aul good?


Shared drive support

can you please add shared drive support ? right now its not working.

its working make sure your structure of shared drive
for more see wiki : structure

its working make sure your structure of shared drive
for more see wiki : structure

if you want to see example just DM me on telegram Empathiz

its working make sure your structure of shared drive
for more see wiki : structure
if you want to see example just DM me on telegram Empathiz

check telegram,i texted there

Shared drives definitely work. To point to a team drive folder in the category_list config item, set the id field to the folder ID, you can get it from the last part of the URL when you open the folder in a browser


ByteArray fixes for HTML5/JS - Fixes issue #5474

Let's keep our eyes on this one, please let me know if you have a test case that fails with the latest version of ByteArray, and we can work together on a solution. Thank you! :smile:


Customized rules not being executed properly

If a function in the external rule module has a parameter called $abcast, then the Engine would tries to find all the ast that is of the type abcast to runs this rule on. This is a bug because the Engine should look at the type of the parameter instead of the name of the parameter because the name of the parameter does not have to match the name of any existing ast type.

I think we are getting the type of the parameter but not the name of the parameter Ast.

returning a null diagnostic record results in Engine crash:
Invoke-ScriptAnalyzer : Object reference not set to an instance of an object.
At line:1 char:1

Invoke-ScriptAnalyzer -Path .\test.ps1 -CustomizedRulePath .\rule.psm ...

  + CategoryInfo          : NotSpecified: (:) [Invoke-ScriptAnalyzer], NullReferenceException
  + FullyQualifiedErrorId : System.NullReferenceException,Microsoft.Windows.Powershell.ScriptAnalyzer.Commands.Invok
 eScriptAnalyzerCommand

Line 265:
Dictionary<string, List> astRuleGroups = rules
.Where(item => item.GetParameter().EndsWith("ast", true, CultureInfo.CurrentCulture))
.GroupBy<ExternalRule, string>(item => item.GetParameter())
.ToDictionary(item => item.Key, item => item.ToList());
The astRuleGroups has the key as the name of the parameter. Later on in line 313, we have:
IEnumerable childAsts = ast.FindAll(new Func<Ast, bool>((testAst) =>
(testAst.GetType().Name.ToLower(CultureInfo.CurrentCulture) == astRuleGroup.Key.ToLower(CultureInfo.CurrentCulture))), false);
So we are actually using the name of the parameter as an ast type.

Thanks Quoc.
Noticed that we store the parameter name as the parameter when we first create ExternalRule:
ParameterMetadata param = funcInfo.Parameters.Values.First(item => item.Name.EndsWith("ast", StringComparison.OrdinalIgnoreCase) ||                                                            item.Name.EndsWith("token", StringComparison.OrdinalIgnoreCase));
Will change that.

Will also update the StringComparison in all the string comparison method..

Shall we silently capture the null diagnostic record or just make it non-terminating error?

I would prefer non-terminating error.

+1 for non-terminating err

Fixes merged in BugFixes branch.


feat: use package-table vs custom script

@jonahweissman This change might be of interest of you as you implemented the original table.


pc run doesn't work - Got exception: can't create new thread at interpreter shutdown

I run the command 'pc run' but I got the error message: 'Node.js version 16.8.0 or higher is required to run Pynecone' even though node was successfully installed.
After researching this bug, I found that it was because:
if not check_node_version():

in pynecone\utils\prerequisites.py.get_package_manager() -  line 79, returns False.
This occurs when this is called in pynecone\utils\exec.py.run_frontend - line 86:
    run_process_and_launch_url(
        [prerequisites.get_package_manager(), "run", "dev"], loglevel
    )

And then:
result = subprocess.run(
            ["node", "-v"], stdout=subprocess.PIPE, stderr=subprocess.PIPE
        )

which is inside check_node_version function (- called by get_package_manager) raises the exception of: can't create new thread at interpreter shutdown....
this happens immediately after:
    console.rule("[bold green]App Running")
    os.environ["PORT"] = get_config().frontend_port if port is None else port

executed.
Is there a way to solve this problem? Or maybe it's related to the new version of python 12 and it's thread management?

Python Version: 3.12
Reflex Version: pynecone last
OS: windows 11
Thanks.

Hey @MenachemBerkovich, Pynecone is now shipped and maintained as reflex, I would advice you install reflex(pip install reflex). You can also check out the docs for more.

@ElijahAhianyo I went back to Python 3.11 and now it's fine,
This may be related to the fact that in Python 3.12 GIL became optional for threads


fix: preMint with forwarder

needs https://github.com/bosonprotocol/boson-protocol-contracts/pull/552

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@4856ecd). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 1c2bf7e differs from pull request most recent head a73b24c. Consider uploading reports for the commit a73b24c to get more accurate results

@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage        ?   53.70%
=======================================
  Files           ?       78
  Lines           ?     2700
  Branches        ?      468
=======================================
  Hits            ?     1450
  Misses          ?     1250
  Partials        ?        0

Flag
Coverage Δ

core-sdk
53.70% <0.00%> (?)

unittests
53.70% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Move handler creation to onAttachedToWindow() instead of the constructor

Detaching and reattaching a PDFView causes an NPE. This is due to creating a handler in the constructor, but setting it to null in onDetachedFromWindow(). The fix is to create the handler on onAttachedToWindow() instead of the constructor.
This allows the view to be detached and re-attached without loss of functionality.

+1
https://github.com/barteksc/AndroidPdfViewer/issues/822

@barteksc could you merge this fix and create a new release please? It's a big blocker for people using your library in React Native: https://github.com/wonday/react-native-pdf 😿

Is this update added in V3.2.0-beta.1? I am getting crash for this issue.

Please add new feature for autoCropPageMargin on bitmap blank space


FEATURE: move plugin call and post hooks into plugins.lua

After I separate the plugin definition into partial file, plugins.lua is clean. So it is time to move all the plugins related function into the plugins.lua file. Also this can help improving the code chains readability.

Implement in b39526ce3b2d7861638509257398bfab84acb9f7.


feat: Export ObjectSchema

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request?
Export ObjectSchema from the package. I'm working on some changes in the core where I need an instance of ObjectSchema, and even though the package is a dependency of @eslint/config-array, @eslint/object-schema isn't listed in package.json, which fails our lint check.
What changes did you make? (Give an overview)
Exported ObjectSchema as a passthrough from @eslint/object-schema.
Related Issues

Is there anything you'd like reviewers to focus on?

@aladdin-add just a reminder, when you approve a PR and don't merge it, please leave a message as to why you didn't merge it.

I didn't merge it as I would like another review before merging. :)


Support Weaviate Auto Schema

Currently the class has to be precreated in Weaviate for the Spark Connector to work. However, it might be possible to rely on auto schema creation instead, but this would require some changes to how inferSchema works in the Spark Connector: https://weaviate.io/developers/weaviate/current/schema/schema-configuration.html#auto-schema

This would be a great addition still in 2024, could someone look at this again?

auto schema is might not be a good idea. what if the doc to be ingested has an unexpected field?


Add history of validator's withdrawal credentials

This PR implements the changes proposed in https://github.com/wealdtech/chaind/issues/78#issuecomment-1423810954
We did not do extensive testing of these changes, but they seem to be working fine when indexing zhejiang. Let us know if there's anything we got wrong or that we can improve.

@mcdee should be good to go.

hmm I might have screwed the commit history (hopefully only that..) by rebasing and force-pushing to my repo.
Your requested changes are done though, this should be good to go.

There is one outstanding issue picked up by linting, please could you address that?  After that it should be good to go.

I'll merge this and fix it up, to allow running against sepolia.

My bad was busy this morning. Thank you for fixing this.
On Mon, 27 Feb 2023 at 13.29 Jim McDonald @.***> wrote:

Merged #82 https://github.com/wealdtech/chaind/pull/82 into master.
—
Reply to this email directly, view it on GitHub
https://github.com/wealdtech/chaind/pull/82#event-8620513684, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACHI4PGU33V7XAA37VJSHITWZUMFFANCNFSM6AAAAAAU37M2JE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Promocodes to be added

Promocodes to be added as a functionallity.

Pull request #61

Pull request #63

Pull request #68


How  to use AutoAugment

Hello, I want to use autoaugment in Mask RCNN, but I don't know how to use it, because there are several enhancement strategies. My mmdet = 2.16

Please refer to https://github.com/open-mmlab/mmdetection/blob/master/configs/detr/detr_r50_8x2_150e_coco.py#L80

Well, thank you. Another question is, the current mosaic enhancements and mixup enhancements don't support instance segmentation?

Well, thank you. Another question is, the current mosaic enhancements and mixup enhancements don't support instance segmentation?

Yes

OK, thanks. Maybe I should try to realize this function by myself.


Build fails with many “No such module” errors

Build fails on macOS Sonoma 14.2.1 with Xcode 15.2 building for iOS/iPadOS 17.2 device with many repeated “No such module” many repeated errors looking for modules “DOM”, “ECMAScript”, & “JavaScriptEventLoop”.  Issues seem to occur both on main (77889f0) and latest version tag (0.1.2) via both this repo and the GateEngineDemos repo (which pulls down GateEngine 0.1.2).  Fresh git clone (I've never used GateEngine before today).

This is related to changes made by the SwiftWASM project for their Swift 5.9 release.
Due to Xcode not fully supporting Swift Packages, JavaScriptKit is built for macOS targets.
I'll submit a patch for JavaScriptKit to fix these build errors.

I missed the targeting iOS part of this. Those modules are all for HTML5. The package manifest is likely throwing these errors out due to a previous build failure.
When building for iOS, you cannot use Swift Package Manager executables directly, you must wrap them in an Xcode project.
You must do this because Apple doesn't allow side loading on iOS, so every executable must mimic an App Store App including in-development apps.
This is not the case for macOS.
GateEngineDemos has an "Xcode" folder in it with an example of how you could wrap a Swift Package Manager executable into an Xcode project. Open the workspace file (white Xcode file).


TFLite Micro, bugfix for MicroAllocator::AllocateTensors()

Latest master:
tensorflow/lite/experimental/micro/micro_allocator.cc
MicroAllocator::AllocateTensors()
    for (size_t n = 0; n < op->outputs()->size(); ++n) {
      const int tensor_index = op->outputs()->Get(n);
      TensorInfo* current = &tensor_info[tensor_index];
      if ((current->first_created == -1) || (current->first_created > i)) {
        current->first_created = i;
      }

The operations list is iterated in reverse so need to change:
(current->first_created > i)
to
(current->first_created < i)

The latest copy of the file has the updated fix -- tensorflow/lite/experimental/micro/micro_allocator.cc
Closing the issue as it seems to be resolved.

I am sorry but I don't follow your logic on why the largest number for first_created should win, the search order shouldn't make any difference. As far as I can tell we are looking for the first operator using the tensor (minimum) which recommends "ifirst_created". Additionally I think that a similar mistake was made in the last_used logic - here you look for the largest number. I feel confirmed by testing a complex graph with the logic in master versus my reversed implementation.

I was testing mobilenetv2 and found that the model didn't work without the suggested change.
It was clear that RAM was incorrectly being shared by concurrent tensors.
From what I can tell, the logic is trying the find the very first operation and the very last operation the tensor is used. Thus, we want to find the smallest operation index (i.e. smallest current->first_created) and the largest operation index (i.e. largest current->last_used)
With this logic, the search order makes a difference as (current->first_created > i) causes lower operation ids to not be considered.

I see a similar problem (wrong comparison) with the calculation of last_used (here the code in master wrongly looks for the minimum). I was quite surprised to see inputs with a first_used of greater than zero and outputs with a last_use smaller than the maximum. I agree to your description of what this code should do (find the min of first and the max of last). [My test case is an unrolled RNN with parallel paths, early outputs and inputs into late operators]
Still I don't see why the order of comparison makes any difference to the end result as to me this clearly is a min/max search (random order should also be fine here).
Honestly I have a hard time reading it expressed as "if (first>i) first=i" instead of "if (i<first) first=i" . My understanding of your patch is that it changes it to calculate first as the maximum of candidates "if (i>first) first=i". (I swapped the sides for better readability (according to my feelings))

From what I can tell there is a regression in the latest master:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/micro/micro_allocator.cc#L177
The inverted logic is back.


Hub details further style adjustments

Link to subfeature: https://jinaai.productboard.com/feature-board/planning/features/8035166


Parsing lightweight markup (non-markdown)

Is your feature request related to a problem? Please describe.
Yes.  Markdown is limited in capability and utility.  Almost all other lightweight markup systems are superior in these regards.
Describe the solution you'd like
I would like to be able to upload asciidoc and/or org-mode markup documents and have them render properly in Desktop and also at Odysee.  Actually, LaTeX would be even better.
Describe alternatives you've considered
Blogging outside of LBRY because the current long-form text situation is pretty awful.  This FR is a first-step in improving the text problem on the LBRY content platform and, in particular, the available and relative-popular front-ends.
Additional context
For parsing libraries to use in code see -- https://orgmode.org/tools.html
As I am an emacser, I am obviously biased toward org-mode.  There are parsers available for other markups (RST, asciidoc, etc.)  I have simply not bothered to take the time to search for and link to them.
Of course, see also Pandoc (https://pandoc.org), for which numerous web libraries exist.  Pandoc is particularly interesting for a back-end as it supports also common word-processor doc-types for those creators who wish to use LibreOffice or the MS Office suites.

I think I can half way support this. I would absolutely support being able to embed LaTeX, but there are already Markdown implementations which fold in that possibility. In fact, I don't see a reason to throw Markdown out because it is so well-known and so supported by many tools to write already – but I would definitely support the contention that at least the Desktop app should look at more Markdown extensions in order to provide access to some advanced features.
And about 5 to 10 pages of additional documentation on the implementation that they are using, so everybody could be on board with what the system is capable of.

I never suggested throwing out markdown.  It has its uses for structurally simple documents.
I suggested adding support for more markups and, possibly, even word processor doc-types (via pandoc).

Technically, all of those things can be stored and displayed on the Desktop app as is. There may not be a native display mechanism, but nothing keeps you from storing any kind of file whatsoever and making reference to it.
Odysee in particular does some high-level filtering and excludes a number of file formats from any kind of display. In fact, I'm not even sure they get surfaced unless you are specifically following that particular creator. Sadly, I wouldn't expect that to change anytime soon.
Finding people interested in web parsing document formats for online display are relatively in short supply. It's a nontrivial operation. (All you have to do is point Pandoc at your average Word file and target HTML output to see exactly how nontrivial that can be.)
Somebody might want to do it, but I'm not sure who would like to.
I think it would be a lot easier to convince people to add in more Markup add-ons as modules to the Desktop app because most of that work is already done, the interface for doing the presentation already exists, and it's mostly just hooking up hoses.


Exceptions coming from env['action_dispatch.exception'] are not caught by Raven::Rack

Hi, we're currently using Sentry Raven 2.5.3 on a Rails 4.2.8 application with pretty much no configuration for the gem other than the automatic one it provides. We're noticing that some exceptions are not caught by the Raven::Rack middleware.
Here's how our middleware stack looks like in production:
use Raven::Rack
# ...
use ActionDispatch::ShowExceptions
# ...
run Rails::Application.routes

In production, Rails.configuration.action_dispatch.show_exceptions is set to true by default, which means the ActionDispatch::ShowExceptions middleware catches and stops any exceptions. It is graceful enough to leave the exception in the env under the name of 'action_dispatch.exception', though.
However, Raven then fails to look at that part of the env, even though it does look at some parts of the env for "hidden" exceptions.
We wonder if it's that we're using the gem in a way that it's not designed for or if it's that the gem should be also looking at that part of the env. Could you tell us which direction to go through? We'd be happy to submit better reproduction steps or a patch for the gem.
Thank you!

some exceptions

Can you expand on what you mean by that?

Sorry about the ambiguity. We have our application to rescue errors at the ApplicationController level so we explicitly handle most errors, like:
class ApplicationController < ActionController::Base
  rescue_from StandardError do |exception|
    Raven::Rack.capture_exception(exception)
  end
end

In this particular case, the error was being generated in the routes, so the controller wasn't able to catch it. That's why I said "some" exceptions, I should have said all exceptions.
Now, I went ahead and created a brand new Rails app and followed these steps for reproduction:

Create a controller and an action which just raises an exception.
Add the sentry-raven gem to the project.
Add a key in config/secrets.yml to be able to boot in production mode.
Using bundle open sentry-raven, I threw a puts error if error right at the end of the Raven::Rack middleware.
I booted up the app and hit the homepage and saw the 500 page, but nothing in the console.
I then did bundle open sentry-raven again and changed the line where it catches errors from other frameworks and added || env['action_dispatch.exception'].
I hit the homepage again and confirmed that in console the error is captured this time.

I hope that helps reproducing what we're experiencing. Thanks!

OK. I'll look at this later, but the reason we don't look in action_dispatch.exception is because we override render_exception.. See also here.

@Ferdy89 Following your instructions, I added an additional puts exception right here - https://github.com/getsentry/raven-ruby/blob/master/lib/raven/integrations/rails/overrides/debug_exceptions_catcher.rb#L6. When I hit the homepage, I see the output from this statement in the logs. I think render_exception is being successfully overridden by Raven and your issue is coming from somewhere else, possibly configuration.

@Ferdy89 IIRC our rack middlewares sometimes interfact poorly with custom exception applications, if you have one of those configured.

@nateberkopec This issue can be closed, The true cause of our issue is described and fixed in #722


Add DPDK sample app 'l2fwd' to 'dpdk-app-centos' docker image.

Add comments to substitute shell scripts descriping what mods
are being performed.
Add vhost patch to 'dpdk-app-centos' docker image.
Signed-off-by: Billy McFall<EMAIL_ADDRESS>

/lgtm


envyable install error - Cannot load  ./lib/envyable/cli

Ran envyable install got the following error:
/Users/michael/.rvm/gems/ruby-2.3.1/gems/envyable-1.1.0/bin/envyable:4:in `require': cannot load such file -- ./lib/envyable/cli (LoadError)
	from /Users/michael/.rvm/gems/ruby-2.3.1/gems/envyable-1.1.0/bin/envyable:4:in `<top (required)>'
	from /Users/michael/.rvm/gems/ruby-2.3.1/bin/envyable:23:in `load'
	from /Users/michael/.rvm/gems/ruby-2.3.1/bin/envyable:23:in `<main>'
	from /Users/michael/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `eval'
	from /Users/michael/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `<main>'

Changed file bin/envyable to require_relative "../lib/envyable/cli" (had been require "./lib/envyable/cli")
envyable install now working...
Not sure why this happened, because when I cloned the repo and went to edit the code to fix it, it seems someone has very sensibly put require File.expand_path('../lib/envyable/cli', __dir__)
Is gem install envyable installing an old version of the gem?? Confused...

Seems that way. You need envyable version 1.1.1 which fixed that issue.
Are you installing via bundler? Do you need to run bundle update envyable?


Redesign explore page

Add more details to the explore page

Here's a Loom for Discover/Explore page concept:
https://www.loom.com/share/183df7f784354201b71ec9a7778a20fb?sid=ba2080bb-8221-4e89-a48a-0bd26f197056

And screenshot:

Here's another option that does not introduce new package modules (aside from top banner & editorial graphics).
Screenshot:

Figma:
https://www.figma.com/proto/UZJ2CrxsoX0pkhEY4NZE5j/GUI-Master?page-id=10%3A372&type=design&node-id=563-2676&viewport=-3175%2C-2344%2C0.43&t=13ZhbIEPEwULXFjX-1&scaling=min-zoom&starting-point-node-id=117%3A4639&mode=design
Loom:
https://www.loom.com/share/d7e63f8ef0164c028158609ea56019d2?sid=d7684b1f-9437-43e3-ac11-ed7646b9a211

Note: this should not move into development until @mxcl has gotten eyes on it.

I prefer the first, but I fear it won't look as good after our generated images are sub’d.
we should pause on this and rethink after we have more “apps” since we will want to consider how to focus those.


Project Links

Team mates for this Project @Bornittah and @Tamunokuro
Project Link: Recipe app

Hi @Tamunokuro and @Bornittah ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✔ Good description and correct info.
✔  Good design
Required Changes ♻

[ ] @Tamunokuro and @Bornittah great work on your kanban board, however, you forgot to add a task for ensuring there are no N+1 problems, also kindly ensure your number of points allocated to the task is equal to the amount of time required to solve the problem.

Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Idefics2 full fine-tuning getting RuntimeError: shape mismatch

I'm working on fine-tuning Idefics2 with multiple images in instruction
I follow this script for full fine-tuning: https://github.com/TIGER-AI-Lab/Mantis/blob/89d34077bd87b66eaadc13117add553e3a3d4c0b/mantis/train/scripts/train_idefics2_full.sh
Here is the command
NCCL_DEBUG=WARN accelerate launch --config_file=./accelerate_configs/accelerate_config_zero3.yaml \
    --machine_rank 0 --main_process_ip <IP_ADDRESS> --main_process_port 12956 \
    --num_machines 1 --num_processes 8 \
    train_idefics2.py \
    --model_name_or_path HuggingFaceM4/idefics2-8b \
    --data_config_file custom_data_config.yaml \
    --data_format chat \
    --run_name 240523_idefics2_mantis \
    --output_dir 240523_idefics2_mantis \
    --num_train_epochs 3 \
    --per_device_train_batch_size 1 \
    --per_device_eval_batch_size 1 \
    --gradient_accumulation_steps 2 \
    --evaluation_strategy "steps" \
    --save_strategy "steps" \
    --save_steps 200 \
    --eval_steps 200 \
    --save_total_limit 5 \
    --learning_rate 2e-5 \
    --weight_decay 0.01 \
    --warmup_ratio 0.03 \
    --lr_scheduler_type "cosine" \
    --logging_steps 10 \
    --gradient_checkpointing True \
    --dataloader_num_workers 5 \
    --report_to wandb \
    --do_train \
    --lora_enabled False \
    --qlora_enabled False \
    --dora_enabled False \
    --max_seq_len 512 \
    --fp16 \
    --attn_implementation eager

Error i got is
[rank0]:     result = forward_call(*args, **kwargs)
[rank0]:   File "/home/user/Mantis/mantis/models/idefics2/modeling_idefics2.py", line 1677, in forward
[rank0]:     inputs_embeds = self.inputs_merger(
[rank0]:   File "/home/user/Mantis/mantis/models/idefics2/modeling_idefics2.py", line 1564, in inputs_merger
[rank0]:     new_inputs_embeds[special_image_token_mask] = reshaped_image_hidden_states
[rank0]: RuntimeError: shape mismatch: value tensor of shape [256, 4096] cannot be broadcast to indexing result of shape [192, 4096]

Any suggestions how to fix it?
Thanks in advance

Seems like 192 = 63 * 4, and 256 = 64 * 4. Judging from the error codes, it seems like there was a missing <image> placeholder in the text. You probably need to check your input data for debugging, ensuring that the number of input <image> tokens in the text has the same number of the images.

Thank you for your reply @jdf-prog . It's likely the error. I have resolved it by using cpu_offload. I think truncation actually cuts off  tokens and lead to this problem. I increase max_seq_len but that leads to OOM, hence cpu_offload, and it's training fine but very slow.
Sorry for my newbie question as I'm new to VLM. Do you have any rule of thumb to estimate VRAM usage for idefics2-8b with multiple images (I'm using 4 for each prompt) ?


add support for --use-orchestrator

Fixes #63
Adds support for the test orchestrator. Can be enabled by the use-orchestrator flag in the config.properties file.

Looks good. Thanks for contributing.


Typedefinitions

Are there any plans to add typescript type definition to this great library?

This is a good idea, I don't have time to implement this now but would happily accept a PR.

Any thoughts on how to do it? Just add the declarations file or upgrade the project to typescript?

I have not done it before so not sure what are the implications for each options. Does one of them force every library user to use typescript? Are they both backward compatible for all consumers?

If you compile the project to JjavaScript before publishing and only publish the js files nobody else has to use TypeScript.
For compiling before publishing you could use prepublish under scripts in package.json. This way everything is compiled before publishing. During this process you also could generate the TypeScript .d.ts files. The creating of .d.ts files is a simple setting in the configs from TypeScript.
You also have to add the JavaScript output folder under files in the package.json
This way everybody can use the package, TypeScript or JavaScript.

None of them force the user to use TypeScript.
If we rewrite the blessed-contrib in TypeScript, we will do a tsc to compile TypeScript into JavaScript before publishing to NPM, and every user will continue to use JavaScript and without noticed any changes.
And for TypeScript users, we can benefit from the d.ts definition files.
I just have a look into the lib source, I'll vote for rewrite the library to TypeScript, if possible. Because that will always keep the definitions file sync with the source code.

I play a little with the type definition today, it should look like this:
// index.d.ts
import {
  widget,
  Widgets,
}             from 'blessed'

declare namespace BlessedContrib {

  export interface GridOptions {
    rows: number,
    cols: number,
    screen: Widgets.Node,
  }

  export class Grid {
    constructor(options: GridOptions)

    set<T>(
      row: number,
      col: number,
      rowSpan: number,
      colSpan: number,
      widget: T,
      options?: Widgets.BoxOptions
              | Widgets.FileManagerOptions
              | Widgets.ImageOptions
              | any,
    ): T
  }

  export class tree extends Widgets.BoxElement {}

}

export = BlessedContrib

In order to get started, I'd like to suggest we just put an index.d.ts with a declare any for blessed-contrib, then we could do import * as contrib from 'blessed-contrib in TypeScript.
Will do a pull request to demo that.

i made a definition file that covers most of the library. #127

Awesome, good job @RobinRadic !


Don't make IRequestHandler<TRequest, TResponse> variant

Currently, the IRequestHandler abstraction is defined as variant (with in and out keywords):
interface IRequestHandler<in TRequest, out TResponse> { }

The use of in and out keywords implies that multiple implementations are applicable to one single request message, but this usually doesn't make sense for request handlers. For request handlers, there is always a one-to-one-to-one mapping (from request to response with one handler implementation). If there is a ShipOrder request object with a ShipOrderRequestHandler implementation, it wouldn't make much sense to have a ShipSpecialOrder type that derives from ShipOrder that can be handled by the same ShipOrderRequestHandler.
There are places where variant interfaces make a lot of sense. IValidator<in T> for instance and IEventHandler<in TEvent>. These are abstractions that are usually registered as collection, meaning that there can be multiple validators for a single object or multiple handlers that can process a particular event. For instance, when a SpecialOrderShipped : OrderShipped event is published, it would be fine when it is picked up by an IEventHandler<OrderShipped> implementation.
In other words, the use of in and out keywords in the abstraction is confusing to anyone who reads or maintains it when used when it will not be used. I often see developers use variant interfaces because Resharper suggests this. Don't listen to Resharper! It doesn't know anything about your application design; it only looks at the particular interface.
Same holds for the IRequest<out TResponse> interface.

Indeed, subtle but important!
Thx for the tip, I will adapt the code.


[Mobile] - Responsive UI, Gameplay Screens

Responsive UI for gameplay screens, phase result screens, and leaderboard

We are going to put this items on hold to focus on the ReactJS mobile app development. Responsive UI will be incorporated in this development process. I am closing this item and opening a new ReactJS-focused item


get_version returns None when not in the root of the repository

I have projects that use hgtools to load the version when building Sphinx docs. Sphinx expects the docs to be built with docs/ as the current directory. Therefore, when using setuptools_scm with a conf file like this one is executed, it always returns None for the version.
I suggest that setuptools_scm should operate even if the cwd is not in the root of the repository. Hgtools did this by setting the cwd to the repository root when invoking the commands.

Bitbucket: https://bitbucket.org/pypa/setuptools_scm/issue/25
Originally reported by: Jason R. Coombs
Originally created at: 2015-03-18T14:52:24.781

needs docs tho

Original comment by: Ronny Pfannschmidt

there is the root parameter (which defaults to '.') that is intended or that
the automated upward traversal was disabled because people reported bugs in situations where a pacakge is build in a sibdirectory of a repository that is unrelated

Original comment by: Ronny Pfannschmidt

Aah. That's an easy fix, then. I've added root='..' to the sphinx conf when building.

Original comment by: Jason R. Coombs

What about keeping automatic upwards traversal when root is set e.g. to CLOSEST or FURTHEST (some magic constants with the meaning you can guess), or even just UP (throw an error in case of nested repos)?  There should be more people trying to build something from a subdir of a repo than people trying to build something from a subdir of a repo that happens to be a subrepo...

Original comment by: Antony Lee

use_scm_version is the way to go for setup.py
use_scm_version={'root': '..'} is for passing additional roots
inferrence via __main_ is incorrect

Original comment by: Ronny Pfannschmidt

An additional problem is that if you keep setup.py in a sub-directory under repository, setuptools-scm will not detect the version. My setup.py:
setup(
    ...
    use_scm_version=True
    ...

Should I use get_version in this case? As in:
setup(
    ...
    version = get_version(root='..')
    ...

Original comment by: Tuukka Mustonen

Duplicate of #24.

Original comment by: Ronny Pfannschmidt

Couldn't setuptools_scm infer the correct root with os.path.dirname(sys.modules['main'].file) instead of relying on the cwd?

Original comment by: Markus Unterwaditzer

@RonnyPfannschmidt Do you have recommendation on using use_scm_version vs. directly invoking get_version()?

Original comment by: Tuukka Mustonen


Set status_time when jobs get submitted in BossAir - wmagent version

wmagent branch version of #7878

 Fix #7886 - Set status_time when jobs get submitted in BossAir

Tests are also Ok and Pending timeouts now kick a job kill in JobStatusLite.


Update Gentoo gmock dependency

It seems gmock was absorbed by gtest.
# equery belongs /usr/lib64/libgmock.so
 * Searching for /usr/lib64/libgmock.so ...
dev-cpp/gtest-1.8.0-r1 (/usr/lib64/libgmock.so)

I'm not exactly sure how the other distributions are affected, but the Ubuntu gtest version seems to be up to date (at 1.8.0).

My understanding it that the 2 projects merged in v1.8.0.
now google-mock and libgtest-dev are just placeholders for backward compatibility that are wrapping the googletestpackage that contains both


Request: No empty link rule

When working on large documents, sometimes placeholder links are added with the expectation they will be defined later. For example:
[foo]()

[bar](#)

Such links are somewhat difficult to spot in big documents. The rule would warn against those patterns.
Note: A # link is sometimes used to jump to top of document, however similar effect can be achieved by linking to main heading or a html anchor tag.

A bit tangential, but this is starting to veer pretty close to an existing check-pages feature:
https://github.com/DavidAnson/check-pages#noemptyfragments
No objection to adding to markdownlint, however. :)

Been away due to RL issues, but great to see this feature implemented - many thanks!


decide if openjml should be added to the project

See OpenJML
It would increase the confidence that the code is correct and complement the test.
Currently openjml requires java 8, but this project uses version 14 and will (probably) stay on a somewhat up to date version.
This raises 2 questions which need to be answered:

Is java 8 only required for running openjml or is the project required to java 8 too?
If it is only for running openjml, is it ok to require 2 jdks?

IMO it is not worth it atm, because staying on a somewhat up to date jvm version outweighs the profit of openjml


Extracted deeplinks from Yatlib into Deeplink processor, fixed creation flow

Extracted deeplinks logic into a separate class
Fixed creation straight and aborting flows

https://user-images.githubusercontent.com/84122352/121891652-6449b180-cd24-11eb-8613-79ed2579374a.mp4


[SPARK-35233][2.4][BUILD] Switch from bintray to scala.jfrog.io for SBT download in branch 2.4 and 3.0

What changes were proposed in this pull request?

Move SBT download URL from https://dl.bintray.com/typesafe to https://scala.jfrog.io/artifactory.
Why are the changes needed?

As bintray is sunsetting, we should migrate SBT download location away from it.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Tested manually and it is working, while previously it was failing because SBT 0.13.17 can't be found:
Attempting to fetch sbt
Our attempt to download sbt locally to build/sbt-launch-0.13.17.jar failed. Please install sbt manually from http://www.scala-sbt.org/

cc @viirya

Test build #137968 has started for PR 32352 at commit 930611b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42488/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42488/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42488/

Test build #137968 has finished for PR 32352 at commit 930611b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137968/

Thanks @sunchao! Merging to 2.4.

+1, LGTM.


chat - track most recent code editor as context

fix https://github.com/microsoft/vscode-copilot/issues/9410

Also, if I have a chat editor, I wanted to find the most recently focused editor.

I think I previously tried to use getEditors for this but I think there's no way to get the selection or visible region, is there?

Running this, I see that if some visible but not focused editor is being used for implicit context, and I click the x to close that tab, then implicit context still shows that closed file. What event do we have to listen to in order to update in that case?

@roblourens good catch, we need to use onDidVisibleEditorsChange in that case, I have a new PR: https://github.com/microsoft/vscode/pull/233173

Also, if I have a chat editor, I wanted to find the most recently focused editor.
I think I previously tried to use getEditors for this but I think there's no way to get the selection or visible region, is there? Where is that stored when the editor is not open?

@roblourens yes, getEditors gives you all opened tabs, either visible or not. But tabs that are not active will just carry their URI, but no model because we only ever have 1 model for the visible editor (if its a text editor). So if we have support for implicit context that is just URI based, we could adopt this.
One somewhat hacky way we could do is to peek into the view state that is associated with an editor, because we do keep the selection as state in the editor memento, do you think that would be feasable?

because we do keep the selection as state in the editor memento, do you think that would be feasable?

No clue 😅 where is that stored, is it even readable externally? Or I could try to cache all of this for previous tabs externally, or fall back to just doing the URI without selection/viewport info.

Yeah, its currently not accessible but with some engineering could probably be made accessible. A fallback to just Uri would be a good intermediate step.

Yeah. I can do the Uri for now


Initial Creation of Azure.Health.Deidentification Dataplane SDK

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

Related: https://github.com/Azure/azure-rest-api-specs/pull/29012

You need a tests.yml file as well as CI.yml

/azp run prepare-pipelines

/azp run net - healthdataaiservices

API change check
APIView has identified API level changes in this PR and created following API reviews.


clean up README.md file

Summary
The main README.md file still includes some material that is obsolete and some information that belongs in the main documentation set where it is searchable rather than in the README.md file.  This issue is to review the contents of the README.md file and modify it accordingly.
DoD
### Tasks
-  [ ] https://github.com/keptn/lifecycle-toolkit/issues/3201
-  [ ] https://github.com/keptn/lifecycle-toolkit/issues/3202
-  [ ] https://github.com/keptn/lifecycle-toolkit/issues/3203
-  [ ] https://github.com/keptn/lifecycle-toolkit/issues/3206
-  [ ] https://github.com/keptn/lifecycle-toolkit/issues/3185
-  [ ] https://github.com/keptn/lifecycle-toolkit/issues/3207
-  [ ] https://github.com/keptn/lifecycle-toolkit/issues/3208
-  [ ] https://github.com/keptn/lifecycle-toolkit/issues/3255

closing this since all subtasks are done


LIP-A1 configuration / testing

This microscope is driving GRBL support. Currently on 3018 branch
TODO:

Scan offsets seem wrong. Investigate field of view, etc to why scan isn't working correctly
Calibrate for different zoom levels on knob. How to clearly communicate to end user?
How many zoom levels do we need? ~30% is a good overlap, but there is some tolerance. Start with supporting min max for MVP

This was done a while back


VS Code doesn't resolve new flutter plugins

Issue Type: Bug
When using flutter pub get to install packages mentioned in pubspec.yaml, the exit code comes as 0, which means, everything went right. The same can be confirmed in looking at the packages file, which reflects the said success in  installing a new plugin.
However, when importing the installed plugin, the editor fails to recognise it as a valid path. This has happened several times. To reproduce, create a new flutter project and install a few plugins from pub.dev/flutter. Try importing them in the project. If the editor says, the URI doesn't exist, try checking the packages file, right near the pubspec.yaml file. Most certainly the installed plugin will be found in the packages file.
VS Code version: Code 1.38.1 (b37e54c98e1a74ba89e03073e5a3761284e3ffb0, 2019-09-11T13:35:15.005Z)
OS version: Windows_NT x64 10.0.14393
Extensions (8)

Extension
Author (truncated)
Version

dart-code
Dar
3.4.1

flutter
Dar
3.4.1

vsc-material-theme
Equ
30.0.0

prettier-vscode
esb
2.2.2

vscode-styled-components
jpo
0.0.26

cpptools
ms-
0.25.1

cmake
twx
0.0.17

vscode-icons
vsc
9.3.0

(2 theme extensions excluded)

Please file the issue against the Flutter extension. Thank you!


Document Portfolio service API in component-test module

Hey @pembemiriam
There was no need to close PR #9 as you just needed to update it with a commit.
Aside from that, you need to do the following ;

Fix this error by documenting the parts of the payload which you haven't yet done in PatternApiDocumentation.java
License your code by running ./gradlew licenseFormat
Read through @awasum 's review of Customer-PR7 to adjust the coding style by editing the projet's settings in IntelliJ IDEA as you can see here.
Commit your changes and push to your fineract-cn-portfolio .There's no need to create a new PR!

Courage with the work !


Indicate the name of sub-buttons on action button from index.html

Current:

Goal:

In this case, all actions are described for words and not icons.
Do you think I must add both?

Yes, as I showed up previously , the standard followed by Google Material design rule is when the button refers to a non "straight forward" icon, we possibly should describe it using few words.
The example in the picture is from Google Classroom.

I updated the repository for a new version using only buttons, but as Materialize does not support using toasts side by side with floating button what I'm thinking about is implement that and also contribute to Materialize CSS oficial repository

Final result:

I saw the description of  buttons dont appear in mobile.


Add support for stackdump on 18.09 and below docker engine

With moby/moby#38741, the event name for goroutine stack was changed to include stackdumps for consistency, but 18.09 and below branches still use docker-daemon.
Adding a -legacy flag to re-enable capture of goroutine stacks on downlevel engines.
Signed-off-by: Ameya Gawde<EMAIL_ADDRESS>

I'm fine with this change as is. Note that this also works against other programs, not just the docker daemon. But one alternate might be to lookup the process name of the PID in question. If matches dockerd, you can pretty much guarantee that the REST call equivalent to docker version will always return (at least I have never seen it deadlocked where version doesn't return ever), so you could make a legacy call that way based on the calls return. But it's rather involved, probably would require some kind of timeout in case the situation were that the REST call didn't actually return and so on. I'd just keep it simple - ultimately this is a very simple debugging tool for the rare occasion you need to get the stacks out of the daemon.


Arithmetic overflow in SDL samples

All SDL samples are raising Unhandled exception: Arithmetic overflow (OverflowError).
$ crystal samples/sdl/fire.cr
Unhandled exception: Arithmetic overflow (OverflowError)
  from samples/sdl/fire.cr:284:19 in 'put_pixel'
  from samples/sdl/fire.cr:452:5 in '__crystal_main'
  from /usr/local/Cellar/crystal/0.31.1/src/crystal/main.cr:97:5 in 'main_user_code'
  from /usr/local/Cellar/crystal/0.31.1/src/crystal/main.cr:86:7 in 'main'
  from /usr/local/Cellar/crystal/0.31.1/src/crystal/main.cr:106:3 in 'main'

$ crystal samples/sdl/raytracer.cr
Unhandled exception: Arithmetic overflow (OverflowError)
  from samples/sdl/sdl/surface.cr:27:57 in '[]='
  from samples/sdl/raytracer.cr:196:7 in 'render'
  from samples/sdl/raytracer.cr:236:10 in '__crystal_main'
  from /usr/local/Cellar/crystal/0.31.1/src/crystal/main.cr:97:5 in 'main_user_code'
  from /usr/local/Cellar/crystal/0.31.1/src/crystal/main.cr:86:7 in 'main'
  from /usr/local/Cellar/crystal/0.31.1/src/crystal/main.cr:106:3 in 'main'

$ crystal samples/sdl/tv.cr
Rects: 234
Unhandled exception: Arithmetic overflow (OverflowError)
  from samples/sdl/sdl/surface.cr:27:57 in '[]='
  from samples/sdl/sdl/surface.cr:31:5 in '[]='
  from samples/sdl/tv.cr:140:11 in '__crystal_main'
  from /usr/local/Cellar/crystal/0.31.1/src/crystal/main.cr:97:5 in 'main_user_code'
  from /usr/local/Cellar/crystal/0.31.1/src/crystal/main.cr:86:7 in 'main'
  from /usr/local/Cellar/crystal/0.31.1/src/crystal/main.cr:106:3 in 'main'

All examples in https://github.com/asterite/crystal_sdl2_examples with SDL2 work just fine for me BTW.

Crystal 0.31.1 on MacOS 10.13.6
$ crystal --version
Crystal 0.31.1 (2019-10-02)

LLVM: 8.0.1
Default target: x86_64-apple-macosx

sdl: stable 1.2.15
$ brew info sdl
sdl: stable 1.2.15 (bottled), HEAD
Low-level access to audio, keyboard, mouse, joystick and graphics
https://www.libsdl.org/
/usr/local/Cellar/sdl/1.2.15_1 (225 files, 1.4MB) *
  Poured from bottle on 2019-10-15 at 17:32:48
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/sdl.rb
==> Options
--HEAD
	Install HEAD version
==> Analytics
install: 5,175 (30 days), 16,102 (90 days), 74,318 (365 days)
install_on_request: 2,178 (30 days), 6,984 (90 days), 33,221 (365 days)

Note
There is a bunch of unrelated warnings similar to this one ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking..
Run this to fix them (taken from this Stackoverflow answer):
export SDKROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk"

I think we should remove the SDL examples because they no longer work, regardless of the overflow error.

Hi, I created #10470  to fix the SDL tv and fire examples. raytracer example seems to work fine here.

Resolved by #10470.


Python 3 support for facebook-app backend

Addresses Issue #670. The problem was that unicode strings are default in Python 3, but the base64 and hmac libraries require byte strings. The fix was to explicitly encode and decode the strings as necessary. I tested this patch in Python 2.7.6 and 3.4.0.

Thanks!


Moving etcd topic to Concepts.

This change is

@iphutch I added the Storage section to the Concepts ToC in a previous PR, which is why there's a conflict. :( Looks good otherwise, so if you just merge master into your branch and resolve the conflict, I can merge this. Thanks again for helping out!

@iphutch, Because there's a parallel effort in the 1.6 branch, let's hold off on this until after the 1.6 launch.

FYI, 1.6 is live now.

@iphutch, As part of this PR, let's also move the new file docs/admin/etcd_upgrade. I think this new file could be moved to docs/concepts/storage.
Also, could you take a look at these two file and see whether you think they should be separate or combined:

docs/admin/etcd
docs/admin/etcd_upgrade

bump


Resolve truncated normal issues

Attempt to implement the fix for the issue with truncated normal as discussed in #8048

Changing the documentation of the backend functions would be a good idea indeed (this is also how tensorflow handled this issue), because, in my eyes, the option to provide standard deviation as a parameter to a distribution, implies that the returned distribution has the given standard deviation.
In the case that keras.backend.truncated_normal is really supposed to have a lower standard deviation than the one provided as argument to the function, the correct Theano function to use, would be rng.normal(shape, mean, stddev, dtype, truncate=True).
In order for the initializers to finally work correctly, I do think it is important to fix keras.initializers.VarianceScaling. Currently, it does not provide distributions with the given standard deviation when using distribution='normal', breaking the entire foundations of most initializers.
See #9963 for this alternative fix


Is that package maintained and in active development?

I assume you mean this package. Yes it's maintained.


Feature: aliases and keyword distribution specification in the model macro

This PR adds aliases feature to model specification (@model macro):
See https://github.com/biaslab/ReactiveMP.jl/issues/1 and #17
In the first version the following aliases are available:
a || b: alias for OR(a, b) node
a && b: alias for AND(a, b) node
a -> b: alias for IMPLY(a, b) node
¬a or !a: alias for NOT(a) node
a + b + c: alias for (a + b) + c
Normal(μ|m|mean = ..., σ²|τ⁻¹|v|var|variance = ...) alias for NormalMeanVariance(..., ...) node
Normal(μ|m|mean = ..., τ|σ⁻²|w|p|prec|precision = ...) alias for NormalMeanVariance(..., ...) node
MvNormal(μ|m|mean = ..., Σ|V|Λ⁻¹|cov|covariance = ...) alias for MvNormalMeanCovariance(..., ...) node
MvNormal(μ|m|mean = ..., Λ|W|Σ⁻¹|prec|precision = ...) alias for MvNormalMeanPrecision(..., ...) node
Example
@model function mymodel()

    x1 ~ MvNormal(μ = zeros(2), Σ⁻¹ = diageye(2))
    x2 ~ MvNormal(μ = zeros(2), Λ = diageye(2))
    x3 ~ MvNormal(mean = zeros(2), W = diageye(2))
    x4 ~ MvNormal(μ = zeros(2), prec = diageye(2))
    x5 ~ MvNormal(m = zeros(2), precision = diageye(2))

    y1 ~ MvNormal(mean = zeros(2), Σ = diageye(2))
    y2 ~ MvNormal(m = zeros(2), Λ⁻¹ = diageye(2))
    y3 ~ MvNormal(μ = zeros(2), V = diageye(2))
    y4 ~ MvNormal(mean = zeros(2), cov = diageye(2))
    y5 ~ MvNormal(mean = zeros(2), covariance = diageye(2))

    x ~ x1 + x2 + x3 + x4 + x5
    y ~ y1 + y2 + y3 + y4 + y5

    d = datavar(Vector{Float64})
    d ~ MvNormal(μ = x + y, covariance = diageye(2))
end

@model function mycoolmodel()
    a ~ Bernoulli(0.5)
    b ~ Bernoulli(0.5)
    c ~ Bernoulli(0.5)

    y = datavar(Float64)

    o ~ ¬a || b && !c
    o ~ Bernoulli(y)

end

TODO:

[ ] add Gamma distributions aliases

Looks great!
Perhaps we could also add γ for the univariate precision parameter, and ∨ and ∧ for and and or (or the other way around)?

Thanks @bartvanerp ! I will add γ.
Initially this PR implemented ∨ and ∧ for or and and respectively. However, it turned out, that Julia does not have any precedence priority for those. In contrast, && and || have the correct precedence (&& exectues first then ||). I decided not to use ∨ and ∧ because it might be confusing for a user and may potentially create wrong models. We could add only if we explicitly state that these do not have precedence and a user must use brackets. But that is not that natural as && and ||.

@wmkouw This feature also enables this
y ~ x1 + x2 + x3 + x4

But only static sum can be unrolled at a parse time, e.g. this is still not possible
y ~ ∑(x) # not possible
# or
y ~ +(x...) # not possible

I am happy with these aliases: I think they really add to the user-friendliness of RMP. But the feature to add multiple variables at once, i.e.,
y ~ x1 + x2 + x3 + x4

does not solve the issue with unnecessary loops being constructed.
Perhaps I just need a custom node that implements a linear combination. Something along the lines of:
y ~ lincomb(A, x1, x2, ...)

which implements y = A'x. I'll work on a PR for RMP.


Provide examples for how to use rule parameters

As far as I can see, there is currently no clear description on how to configure rules using different parameters. I've also asked how to do that on Stack Overflow.
It would be great if some example(s) could be included in the README.md or a separate file.
Sebastian

Thanks @SebastianZ .   There is some documentation in the new README
https://github.com/cflint/CFLint/tree/dev

Thank you for the quick reply here and on Stack Overflow, @ryaneberly! That already helps a lot!
This may be improved by some more examples in the future and cross linking to the built-in rule set, but that's already good enough for me, so I'll close this issue.
Sebastian

@SebastianZ - it'd be great if you could contribute a few more examples from your end and how you're actually using it in practice.


DOCS-10430 missing feature

DOCS-10430 missing feature troubleshooting

@ferferrarazzo thank you! I updated this slightly to reflect the change. I created https://www.mulesoft.org/jira/browse/DOCS-10449 to change "communities" to "digital experiences" throughout the ACM docs in the next sprint. Would you please check this version and see if this is correct? Specifically, is the error message output accurate, or should "communities" change to "digital experiences" in the error message output?


Cherry pick some bug fixes

We could merge this, but then we'd also need to update this PR to point to v0.17.
This is mostly here to make it easier to review what's going on in patch-user-callbacks.

Just for context if any historians come looking: this is the PR that introduced the device.valid field in the code I commented out:
https://github.com/gfx-rs/wgpu/pull/4212


Techdocs without docker-in-docker

We're deploying backstage to GKE and have had issues getting techdocs
volume mount logic to work because of mixing paths between the host and
the container running the backend. So we added a condition where if
mkdocs is found in the backend container it will use that to generate
the docs rather than spinning it up in a docker container.
Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ x ] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ x ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

Hey @perrymanuk ! Thank you so much for creating this PR and helping out with this problem.

So we added a condition where if
mkdocs is found in the backend container it will use that to generate
the docs rather than spinning it up in a docker container.

I believe this will causes few issues in future. The TechDocs container, not only runs vanilla mkdocs, but uses lots of essential plugins. Running mkdocs alone will miss these configurations and thus techdocs may not render as expected.
(The current entry point of the container is just mkdocs, but as you can see here, we will soon be using all these fundamental extensions.)

We're deploying backstage to GKE and have had issues getting techdocs
volume mount logic to work because of mixing paths between the host and
the container running the backend.

I am very much interested in this problem, if you can describe it for us. We will take it into consideration and hopefully work out a solution.
@emmaindal and @hooloovooo please add anything I missed or correct me if I am wrong. :)

@OrkoHunter if you check the docker build file for the backend, you can see we do install the mkdocs-techdocs-core package too.

WORKDIR /usr/src/app

# Copy repo skeleton first, to avoid unnecessary docker cache invalidation.
# The skeleton contains the package.json of each package in the monorepo,
# and along with yarn.lock and the root package.json, that's enough to run yarn install.
ADD yarn.lock package.json skeleton.tar ./

RUN apt update && apt install -y git build-essential zlib1g-dev libncurses5-dev libgdbm-dev libnss3-dev libssl-dev libsqlite3-dev libreadline-dev libffi-dev curl libbz2-dev curl

RUN cd /tmp && curl -O https://www.python.org/ftp/python/3.8.2/Python-3.8.2.tar.xz && \
    tar -xvf Python-3.8.2.tar.xz && \
    cd Python-3.8.2 && \
    ./configure --enable-optimizations && \
    make -j 4 && \
    make altinstall

RUN apt install -y mkdocs

RUN pip3.8 install mkdocs-techdocs-core

RUN pip3.8 install cookiecutter && \
    apt remove -y build-essential zlib1g-dev libncurses5-dev libgdbm-dev libnss3-dev libssl-dev libsqlite3-dev libreadline-dev libffi-dev libbz2-dev g++ python-pip python-dev && \
    rm -rf /var/cache/apt/* /tmp/Python-3.8.2

RUN yarn install --frozen-lockfile --production

# This will copy the contents of the dist-workspace when running the build-image command.
# Do not use this Dockerfile outside of that command, as it will copy in the source code instead.
COPY . .

CMD ["node", "packages/backend"]

@OrkoHunter I hit the same problem when deploying Backstage to kubernetes today. I described my problem in Discord. I can't say if this is the right solution or not but the problem definitely exists.

@ebarriosjr the modified Dockerfile doesn't appear to be in the commit. Should it be there or are you leaving it up to the user to decide how the mkdocs binary is supplied?

@dtuite we thought maybe this should be left for the user to decide. But we are more than happy to share the Dockerfile.

@dtuite The main reason I didn't include the dockerfile was that it feels to me like bundling all of this inside of one container isn't the right approach in the long run, we're basically turning backstage into a monolithic deployment with this method. This has the downside of increasing the build times and since debian doesn't supply the needed python version in stable you either have to switch to sid/unstable or install it from source like we've done.
I would think in the long run having a separate service as you had described in discord is probably the correct way to go about this. I just wasn't sure about some of the mechanics of the generation/storage of techdocs and how the team at spotify wanted to approach this long term. However maybe a better short term fix would be to fix the volume mounting by spawning the docker-in-docker, from what I can tell it clones the repo into the backend container but then when it goes to mount it mounts the path from the host rather than the container itself. A volume mount that is shared could solve this or starting the backend with a mount from the host already in place so when it clones the repo it will be on the host and accessible to the techdocs container when it spins up.
@OrkoHunter like @ebarriosjr said we have replicated everything you're doing in the separate container so I wouldn't imagine this will be a problem, but if you guys would like to provide some feedback on the above options and what you'd prefer to have as a solution then @ebarriosjr and I would be happy to dig in and help to contribute something that's inline with the pulp-fiction team's vision for the setup here. The tricky part will be making something generic enough to be used across various deployment environments. I think the entirely separate service without utilizing volume mounts would be the most generic but perhaps the most complicated.

Nice! I think something like this could be a good idea. I'd like to make sure it includes checks for having mkdocs-techdocs-core, plantuml and graphviz installed before going the local install route though. It would cause a lot of confusion if someone had mkdocs installed already, but don't have it set up in a way that allows techdocs to build.

Nice! I think something like this could be a good idea. I'd like to make sure it includes checks for having mkdocs-techdocs-core, plantuml and graphviz installed before going the local install route though. It would cause a lot of confusion if someone had mkdocs installed already, but don't have it set up in a way that allows techdocs to build.

@hooloovooo sounds reasonable to me :grin: I'm not sure exactly how to do the check for the core package but I'll look into it and update the PR

Merging this now to unblock all the people waiting for it. Will add some more checks soon. Thanks for your contribution! :)


Pass on input file's pageId

See https://github.com/OCR-D/core/issues/245#issuecomment-504015855

Solved in #11 and #16


CAMEL-17894: minor cleanups to the build plugins

41 minutes to run the actions. Hoping it's not just a fast node, but an improvement 🙏🏽


[ENH] fixed sqr error

Reference Issues/PRs
fixes: #1234

What does this implement/fix? Explain your changes.
we do not need to calculate the square.

Does your contribution introduce a new dependency? If yes, which one?

Any other comments?

PR checklist

For all contributions

[x] I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
[x] The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

For new estimators and functions

[ ] I've added the estimator to the online API documentation.

For developers with write access

[x] Optionally, I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

holding this off for now till we discuss about it in a couple of weeks

I think we could put this in, as you said @hadifawaz1999 it is currently incorrect. what do you think?

I think we could put this in, as you said @hadifawaz1999 it is currently incorrect. what do you think?

i prefer if we dig deeper and see if its even done elsewhere, because i think it is given it does  not only affect the KNN classifier

@hadifawaz1999, after changing :
        if self.weights == "distance":
            ws = distances[closest_idx]
            ws = ws**2 # removing this

            # Using epsilon ~= 0 to avoid division by zero

the output changed drastically :
Actual predictions: [-144.41037008  -25.55876587 -229.9764678 ]
Expected predictions: [-216.06541863   -4.54133078 -324.7624233 ]
how should we tackle this?


[BYOC][ACL] ACL migrated to v21.02

This PR switches ACL* version from v20.11 to v21.02
*ACL stands for Compute Library for the Arm® Architecture.

For now it was decided to stick only the latest version of ACL. There are no checks in runtime

Please could you just use the tag instead ? v21.02 would probably be better to use here.
Amended
We need to request regeneration of the ci_cpu and ci_arm images.
@zhiics, @tqchen, @thierrymoreau Could the ci images be regenerated, please?

@zhiics , @tqchen , @tmoreau89
Ping. Could the related ci-images be recreated, please?

Ping. @zhiics , @tqchen is there anything we can help to get this patch landed?

Hi @d-smirnov  - looks like we have this request coming through. https://github.com/apache/tvm/pull/7745 which should handle it when things land.

just to clarify--seems like we have two options:

merge #7745 today, then rebuild ci-cpu and ci-arm again and merge a new PR to bump them again
rebuild ci-cpu and ci-arm again and push a new patch to #7745 to bump versions including this patch.

I had built from origin/main when I created ci-cpu and ci-arm for #7745, which didn't have what you want, I believe.

@areusch The PR is still relevant. Could we help somehow to let it in?

@d-smirnov @u99127 @lhutton1 thank you the PR has been merged.

@d-smirnov @u99127 @lhutton1 ok so now we need to do a ci-arm container rebuild, correct?


fix: return type for createTheme

fixes #713, which was previously fixed in #714
Unfortunately, the fix was reverted here: https://github.com/modulz/stitches/commit/066bf69db523cd7167e7f9557447e9a00a57491e#diff-f616198a03e95b0c1089cfaaf95c6dfefc2d0e3da584cdba2c14d7656ef3f3d8
Additionally, the original fix was for core/types/stitches.d.ts but this code also exists in react/types/stitches.d.ts

@jonathantneal @hadihallak can you guys review? Curious why this was reverted, in case it was related to a fix of something else.


Canont use vw as font resize technique like in the other project

In the other project, this worked because the content stretched with the window, but that's not going to work here.

Going to close this since this is a known issue. Will move to using a fixed width design.


expose user identities to the session

This information should be accessible in the session.
There is an ermrest function _ermrest.current_attributes() that is supposed to return all user identities. @karlcz is that right?

Expose plurality of client identities in context.attributes so that services can perform authorization tests by intersecting context.attributes against an ACL. Presence of any of client's identities in ACL is sufficient to authorize access.
Expose plurality of client identities  so that services can record provenance or ownership. Instead of being a single scalar ID, ownership can be treated like an ACL to complement the context.attributes tests above.

With the above features, web resources can be managed before, during, and after a period of account linkage with fewer surprises.

I don't remember whether we ever specified what to do with linked identities, but given the confusion we've seen around them, I think it makes sense to include them in the attributes. That way, things like ownership/provenance ACLs have a better chance of matching to the current client no matter what crazy history they have had of using accounts before and after linking them.

One thing I wonder is whether we actually want to expose the identities set as well so that an application can use it instead of primary identity when recording provenance?  I.e. this record created by set of identities rather than an arbitrarily chosen member of the set.
This would require either changing the webauthn.context.client to allow a set, or adding an extra field to the context like client_identities.

This would seem to make sense to me.  If we have the potential to get a set of identities, it would seem to me that we would like to be robust in the use of that set rather then having to pick just one.
Carl

Dr. Carl Kesselman
Dean’s Professor, Epstein Department of Industrial and Systems Engineering
Fellow, Information Sciences Institute
Viterbi School of Engineering
Professor, Preventive Medicine
Keck School of Medicine
University of Southern California
4676 Admiralty Way, Suite 1001, Marina del Rey, CA  90292-6695
Phone:  +1<PHONE_NUMBER>
Email:  carl<EMAIL_ADDRESS>Web: http://www.isi.edu/~carl
On Oct 4, 2016, at 9:03 PM, Karl Czajkowski <notifications<EMAIL_ADDRESS>wrote:
I don't remember whether we ever specified what to do with linked identities, but given the confusion we've seen around them, I think it makes sense to include them in the attributes. That way, things like ownership/provenance ACLs have a better chance of matching to the current client no matter what crazy history they have had of using accounts before and after linking them.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/webauthn/issues/52#issuecomment-251481677, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbjXo65Fxx1_a5aDiE0i3TmgUyDul61ks5qwqLqgaJpZM4KOCBD.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/informatics-isi-edu/webauthn","title":"informatics-isi-edu/webauthn","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/informatics-isi-edu/webauthn"}},"updates":{"snippets":[{"icon":"PERSON","message":"@karlcz in #52: I don't remember whether we ever specified what to do with linked identities, but given the confusion we've seen around them, I think it makes sense to include them in the attributes. That way, things like ownership/provenance ACLs have a better chance of matching to the current client no matter what crazy history they have had of using accounts before and after linking them."}],"action":{"name":"View Issue","url":"https://github.com/informatics-isi-edu/webauthn/issues/52#issuecomment-251481677"}}}

It turns out we actually do include these in the attribute list (something I'd explicitly added, along with all groups from all alternate identities, the last time this came up, and then forgot about). Do we want to put these into a separate identities set instead of / in addition to the attribute set?

Like I said above, I think we want to know the client identities so applications can store them as provenance/ownership. This means we need to make them available in a way that can be distinguished from non-identity attributes (while they should continue to appear in attributes too).
I think we should add a field  context.client_identities which is a list and has members in it of the same kind as context.client which should remain the primary identity for backward-compatibility. I think we could refactor the internal client provider API to provision just client_identities and declare that the first element of the list will be considered the primary identity.

The client structure now has an "identities" field (with all identities, including the primary one).

Related commit was 4405082ec547a5395d55ad86c94264c6446e8c55

I confirm that I see an identities sub-field on the client object within a fresh session.  I don't have linked accounts so cannot verify that I actually get more than one identity listed in there...

@hongsudt  do you have a linked account to test with?  or should I just close this now?


force gdal to use Gtiff by default and test Complex writes

Codecov Report

Merging #351 (2d00484) into main (0133cd8) will decrease coverage by 0.03%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   79.24%   79.20%   -0.04%
==========================================
  Files          38       38
  Lines        3117     3121       +4
==========================================
+ Hits         2470     2472       +2
- Misses        647      649       +2

Impacted Files
Coverage Δ

src/sources/gdal.jl
84.35% <77.77%> (-0.48%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


WIP: Naming refactor and tests, part 2

Following up on #1112, this:

Adds similar tests to the other half of the pullImage heuristics. (As before, they document the existing practice and allow noticing changes; they don’t claim that the existing practice is correct.)
Explicitly codifies the “docker-archive: pulls copy all names” and “when using search registries, error messages point to the config file” behaviors at the time these features are directly used, instead of adding extraordinary redundant logic in the core pull loop.
Stops passing around so many redundant parameters when constructing CopyOptions values.
Avoids some redundant string formatting + parsing roundtrips.
Finally, some notable payoff: podman load and podman save use well-typed types.ImageReference instead of constructing strings which may be heuristically misinterpreted.

Still only small steps to untangling ImageName and imageParts I’m afraid…
Behavior changes, aside from outright bug fixes, should be very slight (changed error message here and there), apart from podman pull docker-archive:…, which now treats the input as a docker-archive: transport reference, without involving the Docker-like reference parsers and heuristics (e.g. for input like docker-archive:latest).
Please see individual commit messages for details; pay particular attention to the RFC ones.
This adds a few FIXMEs to the non-test code, I hope to clean that up soonish.
(Also, is there a convenient way to set up a containers-storage: store as a completely non-privileged user (not root, no user namespaces, works on macOS)? I’d love to get rid of pullRefName and test the real values.)

I'll do a more thorough review on monday, but initial pass looks good.
I'm a little discouraged that references have started to enter the API - the original intent was to try and insulate people from the large amount of potentially-confusing reference types as much as possible. But it doesn't seem like it can be avoided - attempting to do this with strings is like pulling teeth.

WIP notes to self:

c/image/storage/storageTransport tests run as non-root, reuse that here and drop refNamePair
Add c/image/docker/archive.NewReference to remove two more string parsing cases.

I'm a little discouraged that references have started to enter the API - the original intent was to try and insulate people from the large amount of potentially-confusing reference types as much as possible. But it doesn't seem like it can be avoided - attempting to do this with strings is like pulling teeth.

Yeah; using strings avoids the potentially-confusing reference types, but not the potentially-confusing reference semantics – and it adds the potentially-confusing reference syntax.
E.g. cmd/podman/save.go now calls more APIs, but embeds exactly the knowledge about the subject of OCI archives in
		dst = libpod.OCIArchive + ":" + output
…
 		// prepend = …
 		dest = fmt.Sprintf("%s:%s%s", dst, prepend, source)

vs.
		destImageName := …
 		destRef, err = ociarchive.NewReference(output, destImageName) // destImageName may be ""

; but it now does not need to know about the : separator, and worry about misinterpreting extra : characters (after docker/archive is fixed, it should be possible to drop the validateFileName call which embeds another specific knowledge about the transports).

Or do you perhaps mean that you want to keep libpod as a reusable library, and not to expose its reliance on c/image to users? I could add wrappers for the API (libpod.ImageReference and libpod.NewOCIArchiveReference, or whatever you want); as long as we get rid of the string concatenation and parsing.

@mtrmac The original intent was to try and insulate users from c/image, but I think we're tightly coupled enough that it's not worth wrapping c/image API types.
The original goal was to create a situation where you would pass in an easy string, ideally straight from the user, and all the work of translating that into a reasonable input to c/image in the library. However, like you said, we just ended up with equally confusing string semantics, so it really did not help any.

The original goal was to create a situation where you would pass in an easy string, ideally straight from the user, and all the work of translating that into a reasonable input to c/image in the library.

That still exists, e.g. as (using the proposed naming) PushImageToHeuristicDestination; but code that does not take an input straight from the user and knows more about what the input is should not throw that knowledge away and subject the known input to heuristics.

Code LGTM

@mtrmac Please remove the WIP and we can merge.

@rh-atomic-bot r+


Reduce size of binary

This reduces the size of the youki release binary by 51% from 7019736 bytes to 3449632 bytes. This is achieved by using link time optimization (reduction of ~2MB) and pruning the dependencies (removal of regex crate and restricting the features from clap to what we actually use).
I also tried codegen-units=1 but the size reduction is negligible. Stripping the symbols from the binary on the other hand cuts the size in half again to about 1.6 MB, but this is not included in this PR as we would lose readable stack traces.

Very nice.


I have been using ExcelDataReader and want to use it in a free plug-in.

This is not an issue but more of a question.
I think this is Ok to use in non-commercial (free) stuff but I just wanted to check in.
I also wanted to know if there is an option to eliminate the ExcelDataReader.xml and ExcelDataReader.DataSet.xml files that go along with the build. I am only using ExcelDataReader to return data and not looking further into the excel sheet for formatting information. I would like to release my entire package into one dll to make it as easy as possible for end users.
Please let me know if you need any further info.
Best;
Steve

https://stackoverflow.com/questions/10564336/whats-the-xml-file-that-comes-together-with-a-net-assembly-file

Thanks a bunch.
Best
Steve


Should use a refresh token when renewing a token.

In the current implementation, when renewing a token, NGSI Go gets a token using user,.password and client_id and client_secret without using a refresh token or a token that was gotten first time.

Taking into account the feedback at https://github.com/lets-fiware/ngsi-go/issues/123#issuecomment-823803861

You should retrieve a new token using user/pass instead of using previous token in order to get a new token with full expiration time reset, otherwise you will retrieve a new token which will expires at the same time that previous token.

So maybe this issue is not needed (at least for the Keystone IDM case... I don't know if other IDMs works the same way)

I understood that the process to get a token for keystone is fine with the current implementation. But, I keep this issue open for other IDMs to renew a token with a refresh token.

This issue has been solved by #166. However, it does not affect the procedure for getting a token for Keystone.


MMLU evaluation crashed with FP8 model

We converted the ckpt trained by fp8 to huggingface model, and did some mmlu benchmark (bf16), found that the result was really bad but the loss is normal (compared with bf16). This issue is met after about 400B tokens training.
We tried to continue train steps with bf16 precision (critical loss spike at first few steps), and solved the problem of benchmark crash.  But it is not a good way to benchmark models as we need more GPUs to train the bf16 model.
Can the TE team provide any tools or practices to help benchmark the ckpt saved by fp8 training?

Hi @jingjie01ai, could you confirm that I understand your issue correctly:

You trained a model in FP8 for 400B tokens <- could you share the framework you used for that (NeMo, Megatron-LM, HF Accelerate etc.)?
Took the checkpoint, converted to BF16 and did mmlu benchmark in BF16 <- this gave bad results, even though the loss curve during training was large
You took the BF16 converted checkpoint and trained a bit with that
loss spike happened at the beginning but then it recovered and this recovered the results on MMLU benchmark <- how long did you have to train in BF16 for that?

The fact that you see the spike in the loss after converting from FP8 to BF16 is very unexpected - BF16 should be able to pretty much perfectly emulate the FP8 behavior. This suggests that the conversion from FP8 checkpoint to the BF16 checkpoint was not correct somehow.
Did the BF16 part of the training was done with the HF checkpoint or did you do that with the same codebase (just without turning FP8) as the original FP8 training? If the former - could you try loading the FP8 checkpoint into TE but with the fp8_autocast turned off and see if you see the same loss spike?


Maybe start a mailing list

I wanted to share this video about teaching git but it didn't seem worth opening an issue about. I understand the Software Carpentry folks like to set up a mailing list for each workshop so contributors have somewhere to communicate — maybe worth doing here?

Saw that. Interesting video
Good idea. Are you thinking 'contributors' in terms of those working on the lessons?

Yup, that's what I was thinking.

Okay. I'll be back on all this proper next week, so consider this added to my list!


nbtcrafting 2.1.3 via ciif makes the game crash (conflicts with latest version of Fabric API)

I'm guessing because CIIF is bundled with an outdated version of NBT Crafting (2.1.3 instead of 2.2.2), the mod conflicts with the latest Fabric API (0.67.0). Disabling CIIF solves the issue.

Logfile: here

same here
latest.log


MLDBFB-558 need to cast ts issue demo

Désolé pour le diff, mon vim semble avoir fait le ménage.

Oh I had already created MLDB-1706 ticket with test cases in the issue... Also, I don't think I agree that horizontal_avg should work, or that strings should auto-cast to timestamps :)

Ok misunderstanding. I'll rewrite the test.

Updated.

can you add the TIMESTAMP keyword before the timestamps plz? Otherwise the tests are the same: string comparisons. We don't auto-cast ISO strings as timestamps

Comme SELECT TIMESTAMP '2015-01-01T00:00:00Z' ?

@FinchPowers oui ajouter TIMESTAMP avant chaque string ayant un timestamp, de manière à le caster, et tester le horizontal_min sur un timestamp et non une string. C'était ça ta question?


issues  solarthing-main  | Exception while reading: /config/usb_id.json

solarthing-main  | Exception while reading: /config/usb_id.json
Hi,
tried to migrate from solarthing server to docker isntallation
moved  same base.json and usb.json to new location in main/config
but now have this error: solarthing-main  | Exception while reading: /config/usb_id.json
-rwxr-xr-x 1 pi pi  112 Dec 14 15:06 usb_id.json
check command was fine
`   sudo docker run --rm --privileged -v /dev:/dev ghcr.io/wildmountainfarms/solarthing check --port /dev/serial/by-id/usb-1a86_USB2.0-Ser_-if00-port0 --type rover --modbus 17
Going to open serial port using default serial configuration...
Successfully opened serial port...
Checking on address: 17
Success! Battery Voltage: 14.4
`
what am I missing?

can be closed
error was in config path to usb device config


Re-render Calendar When Event is Submitted

Please provide a summary of the feature
Currently, when a user submits an event using the Add Event Form, they must navigate to the landing page and back in order to see their created event on the calendar.
Make it so that when a user submits an event using the Add Event Form, Together re-renders Calendar.js, allowing Calendar.js to make a new getAll() request to the server, which should include the newly added event.
Are there any potential issues you foresee with this feature
Is this feature related to any current or past issues? Please provide the
No
Additional context
Add any other context or screenshots about the feature request here.
Which Branch should this fix be Pulled into?
PR into development
If you're interested in working on this feature, please comment so you can be assigned

@Caleb-Cohen I can take this on tomorrow during the demo if that's cool

@Caleb-Cohen I can take this on tomorrow during the demo if that's cool

all yours!


[cherry-pick] ci: check analysis status in vuln scan script (#960)

Some images may fail to be scanned for various reasons. At the moment this leads to a silent failure where the fixable_total is reported as zero. This change checks the analysisStatus and treats any non-success status as a failure.

/assign @haiyanmeng


Some README.md fixes and improvements

Signed-off-by: Julius Volz<EMAIL_ADDRESS>

thanks :) I appreciate it a lot !