How to use with radio inputs?

The demo page does not have an example using radio inputs.  It's not clear from the documentation that it's even possible.

Hey @AaronATX, sorry for late reply and thanks for reporting this issue. We are working on it. I'll inform you on this page.

Would be great to have this working for a group of checkboxes or radios!


Implementing pagination for _cat/indices API

Description
Changes include:

Introducing new _list/indices API which will display paginated results.
Since, for paginated responses, next_token and what element is getting paginated will also have to be displayed, RestTable and Table classes have been extended to accommodate pagination related metadata
New RestListAction (similar to RestCatAction), to output all _list APIs.
Support of paginationStrategies and PageTokens. Different Pagination Strategies can implement PaginationStragety interface. The interface has been kept very open, considering the strategies can greatly vary in terms of what all parameters they might require to parse a token and generate a list of page from a data store (for e.g. ClusterState is a data store for IndexBasedPaginationStrategy, which has been added as part of this PR).

Functional Testing on a local cluster:
_list API:

gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list"
:‑|
/_list/indices
/_list/indices/{index}

All the indices in the cluster
gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_cat/indices"
green open test-index  FclPNwqmQie3RnpoOYpLTg 2 3 0 0 1.6kb 416b
green open test-index2 k5FNOQcvSV679Hcs1g-OwQ 2 3 0 0 1.6kb 416b
green open index4-test s2AJ5CoYRru-8lbB871pWA 2 3 0 0 1.6kb 416b

Retrieving indices in pages of size=1, using _list API, in plain text format:
gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list/indices?size=1"
green open index4-test s2AJ5CoYRru-8lbB871pWA 2 3 0 0 1.6kb 416b
next_token MSQxNzE5NDI3NDk3NDQ0JDE3MTk0Mjc1NTYzODEkaW5kZXg0LXRlc3Q=

gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list/indices?size=1&next_token=MSQxNzE5NDI3NDk3NDQ0JDE3MTk0Mjc1NTYzODEkaW5kZXg0LXRlc3Q="
green open test-index2 k5FNOQcvSV679Hcs1g-OwQ 2 3 0 0 1.6kb 416b
next_token MiQxNzE5NDI3NTM3MzcwJDE3MTk0Mjc1NTYzODEkdGVzdC1pbmRleDI=

gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list/indices?size=1&next_token=MiQxNzE5NDI3NTM3MzcwJDE3MTk0Mjc1NTYzODEkdGVzdC1pbmRleDI="
green open test-index FclPNwqmQie3RnpoOYpLTg 2 3 0 0 1.6kb 416b
next_token null

Retrieving indices in pages of size=1, using _list API, in JSON format:
gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list/indices?size=1&format=json&pretty"
{
  "next_token" : "MSQxNzE5NDI3NDk3NDQ0JDE3MTk0Mjc1NTYzODEkaW5kZXg0LXRlc3Q=",
  "indices" : [
    {
      "health" : "green",
      "status" : "open",
      "index" : "index4-test",
      "uuid" : "s2AJ5CoYRru-8lbB871pWA",
      "pri" : "2",
      "rep" : "3",
      "docs.count" : "0",
      "docs.deleted" : "0",
      "store.size" : "1.6kb",
      "pri.store.size" : "416b"
    }
  ]
}
gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list/indices?size=1&format=json&pretty&next_token=MSQxNzE5NDI3NDk3NDQ0JDE3MTk0Mjc1NTYzODEkaW5kZXg0LXRlc3Q="
{
  "next_token" : "MiQxNzE5NDI3NTM3MzcwJDE3MTk0Mjc1NTYzODEkdGVzdC1pbmRleDI=",
  "indices" : [
    {
      "health" : "green",
      "status" : "open",
      "index" : "test-index2",
      "uuid" : "k5FNOQcvSV679Hcs1g-OwQ",
      "pri" : "2",
      "rep" : "3",
      "docs.count" : "0",
      "docs.deleted" : "0",
      "store.size" : "1.6kb",
      "pri.store.size" : "416b"
    }
  ]
}
gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list/indices?size=1&format=json&pretty&next_token=MiQxNzE5NDI3NTM3MzcwJDE3MTk0Mjc1NTYzODEkdGVzdC1pbmRleDI="
{
  "next_token" : null,
  "indices" : [
    {
      "health" : "green",
      "status" : "open",
      "index" : "test-index",
      "uuid" : "FclPNwqmQie3RnpoOYpLTg",
      "pri" : "2",
      "rep" : "3",
      "docs.count" : "0",
      "docs.deleted" : "0",
      "store.size" : "1.6kb",
      "pri.store.size" : "416b"
    }
  ]
}

Related Issues
Resolves https://github.com/opensearch-project/OpenSearch/issues/14258

Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This looks like a great start.
I would wrap additional metadata into metadata to support other fields like total count.
{
  "metadata": {
      "next_token" : "MSQxNzE5NDI3NDk3NDQ0JDE3MTk0Mjc1NTYzODEkaW5kZXg0LXRlc3Q=",
      "total_count": 200
   },
  "indices" : [
    {
      "health" : "green",
      "status" : "open",
      "index" : "index4-test",
      "uuid" : "s2AJ5CoYRru-8lbB871pWA",
      "pri" : "2",
      "rep" : "3",
      "docs.count" : "0",
      "docs.deleted" : "0",
      "store.size" : "1.6kb",
      "pri.store.size" : "416b"
    }
  ]
}

From the implementation POV, can we build RestIndicesListAction to be a lot thinner where all pagination parts are generic except data fetching? I think a goal should be that to opt into _list/* one adds a ListAction interface to some existing classes and fills out the parts that actually fetch a page of data given a token and that's it.  Otherwise it's too easy to accidentally start returning a different object from a non-paginated API vs. a paginated API, which I think is a red flag.

Failing test testFailoverWithSearchReplica_WithoutWriterReplicas is unrelated to changes in this PR and is passing locally. Might be flaky.

@gargharsh3134 @shwetathareja please don't forget https://github.com/opensearch-project/opensearch-api-specification!

@gargharsh3134 @shwetathareja please don't forget https://github.com/opensearch-project/opensearch-api-specification!

Sure @dblock. I'm already tracking this. Once _list/shards changes are merged, will immediately follow those up with a combined PR for both _list/indices and _list/shards specs

Is there any tracking of documentation updates? I don't see anything on https://opensearch.org/docs/latest/api-reference, and don't see any open PRs on the website repo.

Is there any tracking of documentation updates? I don't see anything on https://opensearch.org/docs/latest/api-reference, and don't see any open PRs on the website repo.

Looks like the checklist on the PR template wasn't completed.

@ohltyler @dbwiddis Sorry for the inconvenience, I'm working on adding API specs for now. Let me open the respective Github issues for public documentation in parallel.

Is there any tracking of documentation updates? I don't see anything on https://opensearch.org/docs/latest/api-reference, and don't see any open PRs on the website repo.

As for this, it would be made available from 2.18 in opensource/public documentation.


Dont working buttons in RPC

https://youtu.be/pvoa1B4OBwM
Buttons "View channel" and "Watch Video" for RPC don't working

Hey, sorry for the late reply! I'll look into the issue and update you if I find a fix.

I thought you had solved the problem. Since this bug has disappeared

If that's the case, then great! Let me know if anything else comes up.


🤖 Add stub files to all exercises

In this PR, we created (empty) stub files for all exercises that didn't yet have them.
The lack of stub file generates an unnecessary pain point within Exercism, contributing a significant proportion of support requests, making things more complex for our students, and hindering our ability to automatically run test-suites and provide automated analysis of solutions.
The original discussion for this is at exercism/discussions#238.
We will automatically merge this PR in two week's time if it has not been merged by track maintainers at that point :slightly_smiling_face:
Tracking
https://github.com/exercism/v3-launch/issues/33

Here is the point of view of an ordinary non-maintainer citizen, which may be heeded or ignored at your choice:
This track already has stub files for all exercises; here is a link to the stub file for each exercise:
https://github.com/exercism/ceylon/blob/main/exercises/practice/anagram/source/anagram/Anagram.ceylon
https://github.com/exercism/ceylon/blob/main/exercises/practice/hamming/source/hamming/Hamming.ceylon
https://github.com/exercism/ceylon/blob/main/exercises/practice/largest-series-product/source/largestseriesproduct/Series.ceylon
https://github.com/exercism/ceylon/blob/main/exercises/practice/leap/source/leap/Leap.ceylon
https://github.com/exercism/ceylon/blob/main/exercises/practice/matching-brackets/source/matchingbrackets/Brackets.ceylon
https://github.com/exercism/ceylon/blob/main/exercises/practice/react/source/react/Reactor.ceylon
https://github.com/exercism/ceylon/blob/main/exercises/practice/rna-transcription/source/rnatranscription/RNA.ceylon
https://github.com/exercism/ceylon/blob/main/exercises/practice/sieve/source/sieve/Sieve.ceylon

@petertseng Ah, it is the solution key that contains incorrect paths. See https://github.com/exercism/ceylon/blob/main/exercises/practice/leap/.meta/config.json. I'll fix those.

Closed in favor of https://github.com/exercism/ceylon/pull/126


Migration to core-java 0.8.0

Summary:

Fix event store example.
Migrate to core-java 0.8.0.
Add Hello, World! sample.

@dmytro-grankin please fix the issues reported by Codacy. We need this check to pass as well.

@armiol PTAL.

@armiol PTAL.

@armiol PTAL.


consider generate webpack.config.[env].js?

webpack is powerful and has many options , plugins  ,loaders... I think It is very hard to cover all situations just  by limited options in cli.
for example:

i want to  use externals config for cdn
i  use webpack-dev-middleware not webpack-dev-server
i dont want to use html-webpack-plugin, i use template engine(like pug/jade) to generate html.

generated files (webpack.config.[env].js ) and some npm scripts might be better

Can you describe your feature proposal in detail, @jzlxiaohei? Can you produce a PR?

See #1656

Dupe of https://github.com/angular/angular-cli/issues/1656


I am running Botium-cli and Selenium in docker and when running the tests against my Chatbot, i am getting the below issue .

I am running Botium-cli and Selenium in docker and when running the tests against my Chatbot, i am getting the below issue .
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
I used the command
botium-cli run --convos convoname.
I am using docker on windows machine.
I tired to install botium-cli on my local machine (windows 10).but still getting similar kind of issues.
I used the command
npm install -g botium-cli

botium-cli init
botium-cli run
The sample tests works fine but when i use my own botium.json file in the project directory and try to run i get this error.
Please help me on this.

attaching the logs of Selenium webdriver
botium-selenium_1  | 05:28:12.046 INFO [ActiveSessionFactory.lambda$apply$11] - Matched factory org.openqa.selenium.grid.session.remote.ServicedSession$Factory (provider: org.openqa.selenium.chrome.ChromeDriverService)
botium-selenium_1  | Starting ChromeDriver 76.0.3809.68 (420c9498db8ce8fcd190a954d51297672c1515d5-refs/branch-heads/3809@{#864}) on port 8070
botium-selenium_1  | Only local connections are allowed
botium-selenium_1  | Please protect ports used by ChromeDriver and related test frameworks to prevent access by malicious code.
botium-selenium_1  | [1568093292.051][SEVERE]: bind() failed: Cannot assign requested address (99)
botium-selenium_1  | 05:28:12.188 INFO [ProtocolHandshake.createSession] - Detected dialect: OSS
botium-selenium_1  | 05:28:12.228 INFO [RemoteSession$Factory.lambda$performHandshake$0] - Started new session cea02b772257e9505e1342d830b2b9db (org.openqa.selenium.chrome.ChromeDriverService)
botium-selenium_1  | 05:29:12.122 INFO [ActiveSessions$1.onStop] - Removing session cea02b772257e9505e1342d830b2b9db (org.openqa.selenium.chrome.ChromeDriverService)

I think this is more of a Selenium problem

attaching the logs of Selenium webdriver
botium-selenium_1 | 05:28:12.046 INFO [ActiveSessionFactory.lambda$apply$11] - Matched factory org.openqa.selenium.grid.session.remote.ServicedSession$Factory (provider: org.openqa.selenium.chrome.ChromeDriverService)
botium-selenium_1 | Starting ChromeDriver 76.0.3809.68 (420c9498db8ce8fcd190a954d51297672c1515d5-refs/branch-heads/3809@{#864}) on port 8070
botium-selenium_1 | Only local connections are allowed
botium-selenium_1 | Please protect ports used by ChromeDriver and related test frameworks to prevent access by malicious code.
> botium-selenium_1 | [1568093292.051][SEVERE]: bind() failed: Cannot assign requested address (99)
botium-selenium_1 | 05:28:12.188 INFO [ProtocolHandshake.createSession] - Detected dialect: OSS
botium-selenium_1 | 05:28:12.228 INFO [RemoteSession$Factory.lambda$performHandshake$0] - Started new session cea02b772257e9505e1342d830b2b9db (org.openqa.selenium.chrome.ChromeDriverService)
botium-selenium_1 | 05:29:12.122 INFO [ActiveSessions$1.onStop] - Removing session cea02b772257e9505e1342d830b2b9db (org.openqa.selenium.chrome.ChromeDriverService)

my botium.json looks like this
"botium": {
"Capabilities": {
"PROJECTNAME": "My Botium Project",
"CONTAINERMODE": "webdriverio",
"WEBDRIVERIO_OPTIONS": {
"desiredCapabilities": {
"browserName": "chrome",
"chromeOptions": {
"w3c": false,
"args": ["--headless", "--disable-gpu", "--no-sandbox", "--disable-dev-shm-usage" ]
},
"acceptSslCerts":true,
"acceptInsecureCerts":true
},
"protocol":"http",
"host":"selenium",
"port":"4444",
"path":"/wd/hub"
Is anything required to be changed here ??

I tried with botium-cli init-dev  command, then my tests starts running .

what botium-cli init dev command does??
please tell how to run the tests with docker / local installation of Botium-cli  in browser and headless way.

botium-cli init-dev is for generating boilerplate projects for developing Botium extensions: https://botium.atlassian.net/wiki/spaces/BOTIUM/pages/24477705/Developing+Custom+Asserters
You can find documentation for all Botium capabilities you need in the Webdriver connector repository: https://github.com/codeforequity-at/botium-connector-webdriverio
For how to use Webdriver.io for launching a headless chrome browser, there are other sources of information (https://webdriver.io/docs/options.html, https://medium.com/@mannyluvstacos/using-headless-chrome-for-your-selenium-tests-with-webdriverio-ce99b09d564), but I think your WEBDRIVERIO_OPTIONS settings are ok.

Thanks for the help !!


Constants improvements

Coverage increased (+0.7%) to 98.797% when pulling c0003a5121015dfc7fb55d82128ce0b0461fcb76 on constants_improvements into 1cfbb7cc8d61d559503d95fe173e6c80d3e74593 on master.


ReferenceError: RQ is not defined - when running example

Current Behavior
When attempting to run examples:

examples/WithRedux via yarn start, bundle builds successfully

Then, run application on qtCreator 4.7.0 / Qt 5.11.1 on MacOS

Application logs:

19:42:09: Starting /Users/rcheung/dev/react-qml/examples/WithRedux/build-WithRedux-Desktop_Qt_5_11_1_clang_64bit-Debug/WithRedux.app/Contents/MacOS/WithRedux...
QML debugging is enabled. Only use this in a safe environment.
qrc:/loader_dev.qml:71:9: QML Button: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qml: HMR WebSocker connected: ws://localhost:8081/hot
http://localhost:8081/macos.bundle.js:20829: ReferenceError: RQ is not defined
http://localhost:8081/main.qml?t=1534473730187:13: TypeError: Cannot call method 'init' of undefined

Expected Behavior
Bundle should run with no exceptions.
Configuration (react-qml.config.js)
const path = require('path');

module.exports = ({ root, platform }) => ({
  entry: './main.js',
  output: {
    path: path.join(root, 'qt/dist'),
    filename: `${platform}.bundle.js`,
    library: 'Bundle',
  },
});

Your Environment
MacOS
qtCreator 4.7.0
Qt 5.11.1

software
version

react-qml-cli
0.2.11

react-qml-renderer
0.2.2

qt-react
2.2.13

node
6.11.5

npm or yarn
yarn

Fixed. Also note that examples are moved to /packages. Please check and let me know if the issue persists

@longseespace Yes, the latest examples on master now run. Thank you.


C++ member function ABI on Windows is not compatible with COM member functions.

This manifests itself if you attempt to call COM functions or provide your own. Every argument after this is mangled due to mismatching ABI. COM-aware bindings generators (like ClangSharpPInvokeGenerator) will use Slang's choice of calling convention, but at this time there is a mismatch between Slang's IUnknown and the actual IUnknown that is masked by the fact neither have any member functions with arguments.
On Windows, the C++ instance member function calling convention for cdecl and stdcall is not the same as the non-member function calling convention.

It seems like we need to remove all the SLANG_MCALL declarations on the COM interface types. Is this something you can help us clean up?
Btw, if you are working on creating a C# binding, would you mind upstream your work to this repo?

It seems like we need to remove all the SLANG_MCALL declarations on the COM interface types. Is this something you can help us clean up?
Btw, if you are working on creating a C# binding, would you mind upstream your work to this repo?

I don't have slang's build environment set up locally at this time and I'm focused on another project (the one that lead to me finding these issues). Bindings were being produced as part of that project.
I will definitely consider upstreaming the bindings at some future point given I work out all the issues.

How can we help get you unblocked? It shouldn't take too much effort to make all the interfaces COM compatible, is this enough? The C binding part is more involved and I am not sure we have capacity to get to that soon and that would be something we could really appreciate community help.

How can we help get you unblocked? It shouldn't take too much effort to make all the interfaces COM compatible, is this enough? The C binding part is more involved and I am not sure we have capacity to get to that soon and that would be something we could really appreciate community help.

At this time I'm just not interested in working further on it. I will likely give it another shot at some future (undetermined) date, but I'm focused on pushing my current project forward as my main priority right now. As for which issues I consider blockers on any future work, they are this issue and #5562. The C header issue is not pressing due to the binding generator(s) being used being capable of understanding C++, but may impact other integrators.

Thank you for sharing this feedback. We will prioritize fixing this and 5562 accordingly. Let us know if you decide to give the c# binding another try in the future!

@moonheart08 what calling convention specifically are you expecting to see for these functions? I was under the impression that on x86_64 we are already doing the correct thing. Would changing it to whatever STDMETHODCALLTYPE expands to be sufficient for you?

@moonheart08 what calling convention specifically are you expecting to see for these functions? I was under the impression that on x86_64 we are already doing the correct thing. Would changing it to whatever STDMETHODCALLTYPE expands to be sufficient for you?

This sounds correct.

@moonheart08 Currently all the com methods are marked as SLANG_MCALL, which IIRC is equivalent to STDMETHODCALLTYPE: stdcall on x86, and cdecl on x64. Are we missing anything here?

COM instance methods are notably not just STDCALL but rather a hybrid of THISCALL+STDCALL
For the most part these look and operate identically, but actual instance functions on Windows have a slightly different behavior when it comes to struct returns. In particular, int and struct Wrapper { int value; } are considered distinct for THISCALL+STDCALL where-as they are treated the same for just STDCALL.
Historically this has surfaced to users for APIs where the C++ definition is returning a struct that contains a singular primitive field, such as for D3D12_GPU_DESCRIPTOR_HANDLE. This resulted in developers needing to manually fix some COM APIs to handle the hidden return buffer parameter that is part of the underlying ABI. However, while this generally worked for x86/x64, it was incorrect in some cases for Arm64 or other platforms.
.NET added CallConvMemberFunction as a way to properly handle the ABI for COM like functions. However, since it handles this properly and struct wrappers are not equivalent it means that if you've defined your own "helper wrappers" on the .NET side, there will be a signature mismatch as well. This most commonly comes about due to defining something like struct HRESULT { int value; } where-as the C++ definition is strictly typedef int HRESULT; and thus is actually a primitive int.
ClangSharp will handle it downlevel by assuming you're only targeting x86/x64 and will do the relevant fixups using STDCALL. Likewise on newer versions of .NET where CallConvMemberFunction exists it will do the right thing here as well, including adding helper functions to allow wrapper types to be exposed for managed users while still allowing the underlying vtbl entries to be correct and take the raw primitives. An example of this would be for ID3D12DescriptorHeap where it has functions handling both types of cases: https://source.terrafx.dev/#TerraFX.Interop.Windows/DirectX/d3d12/d3d12/ID3D12DescriptorHeap.cs,e93a6a41a828d77a,references

Seems to have managed to be a me issue, thankfully!
I apologize for the wasted time here, ABIs are hard.
Underlying issue: In a few places, in place of returning int32_t for slangresult, I instead inserted my wrapper struct, which is not equivalent ABI wise as noted above! Good insights all around, I'm going to pull my slang wrappers back up from my work branch and see what I can do with them given this has been figured out.


[CARBONDATA-1543] Supported DataMap chooser and expression for supporting multiple datamaps in single query

This is a rebased PR for #1510 to trigger CI run

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3755/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2515/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3768/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2524/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3555/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3771/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2526/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3557/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2528/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3559/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3773/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3776/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2531/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3562/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2532/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3777/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3563/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2535/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3780/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3565/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3566/


Fixed mesh trasnfer optimization not worth breaking griffin test

refs #46

Job VTB Documentation on c68e146 wanted to post the following:
View the site here
This comment will be updated on new commits.


Don't build libstd as a dylib

This commit forcibly prevents Cargo from building the std crate as a
dylib, even though libstd upstream lists a dylib crate type. We
ideally want a first-class feature for doing this one day, but for now
we can just hack around with the manifests to ensure that the dylib
crate type never shows up. Note that this is only supported for libstd,
and it's also all part of the unstable details of building std.
Closes rust-lang/wg-cargo-std-aware#35

r? @ehuss
(rust_highfive has picked a reviewer for you, use r? to override)

Should be fine for now.
@bors r+

:pushpin: Commit 70bea01b870829dd00b9185a1dc4547d8d8b4664 has been approved by ehuss

:hourglass: Testing commit 70bea01b870829dd00b9185a1dc4547d8d8b4664 with merge 4a582556e8fc1df99d082eed4be279d909e10127...

:sunny: Test successful - checks-azure
Approved by: ehuss
Pushing 4a582556e8fc1df99d082eed4be279d909e10127 to master...

Could this be used by xargo somehow? We'd also be interested in rlib-only builds.
Cc https://github.com/rust-lang/rust/issues/56443


LowerCamelCase vs snake_case

Current practice in the config table is not consistent.
I am leaning towards snake_case.
This would need a migration and making sure that each key used in the code are actually also converted.
For someone interested in doing this, generate the migration file by doing:
php artisan make:migration Lower_To_Snake
This will create a file in database/migrations in which you will find 2 methods: up() and down().
In the up() method you can add:
Configs::where('key', 'checkForUpdates')->update([
	'key' => 'check_for_updates'
]);
Configs::where('key', 'deleteImported')->update([
	'key' => 'delete_imported'
]);
...

and of course in the down() method the other way around:
Configs::where('key', 'check_for_updates')->update([
	'key' => 'checkForUpdates'
]);
...

Once you have the migration ready, you can check files in app/... and replace the previous config keys by the snake_cased ones.
Beware this change may also have some impacts on Lychee-front.

lowerCamelCase looks to be how we started (also here). I'm not sure where snake slipped in :P But yeah, consistency is good!

I guess it started at image_overlay :joy: Sorryyyy.


Addition: ASP-Core-2

Even though "Answer Set Programming" is not widely used, I would like to track requests for adding it, specifically ASP-Core-2 (spec with grammar) as a language to Linguist.
A corresponding entry in languages.yml might look similar to
ASP-Core-2:
  type: programming
  extensions:
  - ".lp"
  interpreters:
  - clingo
  - alpha
  ace_mode: prolog

We also have an ANTLR-style grammar floating around.

Even though "Answer Set Programming" is not widely used

Do you have a search result page on GitHub to estimate the number of ASP-Core-2 files? How many are there?

It's hard to estimate that, because these files are not easy to distinguish from Prolog code:

Answer Set Programming syntax is very close to Prolog. Rules like reachable(A,C) :- connected(A,B), connected(A,C). are valid both in Prolog and ASP-Core-2.
ASP-Core-2 does not actually define a file name extension, so you get .lp ("logic program", clashes with Prolog), .dl ("disjunctive logic (program)") and sometimes also .asp (clashes with Active Server Pages).

So I tried to search by these extensions, but that's too rough as an upper bound for estimating the number of ASP-Core-2 files. I then tried to combine my search with the keyword ":-" which should be contained multiple times in most ASP-Core-2 files, but I did not manage to get GitHub actually search for those two characters.
Any suggestions?

Sorry for the long delay here.
I'd really like to address this, at least by estimating the number of ASP-Core-2 files for each candidate extension. As you noticed, we can't use special characters for github.com searches. Any idea of common keywords we could use to get a (lower-bound) estimate?

Flagging as stale.


Support per-function requierments with shared code

Is there an existing issue for this?

[ ] I have searched existing issues, it hasn't been reported yet

Use case description
See: https://github.com/serverless/serverless-python-requirements/issues/734
Besides it being a bug report, it describes the use case, also see:
https://github.com/serverless/serverless-python-requirements/issues/168
https://github.com/serverless/serverless-python-requirements/issues/435
Currently I find the behavior of per function requirements odd, because to me it seems it;s basically a more performant? implementation of https://www.serverless.com/framework/docs/guides/compose
As it uses the module as the entry point and thus you can not use shared code.
Project structure:
- serverless.yml
- application/**
- domain/**
- infrastructure/**
- web
  - api.py
  - requirements.txt
- events
  - handler.py
  - requirements.txt

serverless.yml:
service: service

provider:
  name: aws
  runtime: python3.9

functions:
  RESTAPI:
    handler: api.handler
    module: web
    package:
      patterns:
        - 'web/**'
  EventConsumer:
    handler: handler
    module: events
    package:
      patterns:
        - 'events/**'

package:
  individually: true
  patterns:
    - '!*'
    - '!*/**'
    - 'application/**'
    - 'domain/**'
    - 'infrastructure/**'

plugins:
  - serverless-python-requirements

So currently packaging this results in the following artifacts:
- events
  - requirements/**
  - requirements.txt
- web
  - requirements/**
  - requirements.txt
- cloudformation-template.json
- events-service-stage-EventConsumer.zip
- EventConsumer.zip
- RESTAPI.zip
- serverless-state.json
- web-service-stage-RESTAPI.zip

The RESTAPI zip file contains:
- application/**
- domain/**
- infrastructure/**
- web/**

so the files and folderz defined in package patterns.
and the web-service-stage-RESTAPI zip file contains the web requirements and the contents of the web folder in our project.
When deploying the zips with the fully qualified name get deployed. Thus you can not share code, because as it is specified in the documentation, the module folder becomes the root of the zip of the function.
Currently there is a workaround that people are using the vendor option if only one folder is shared, but this approach does not work for multiple folders
Proposed solution (optional)
So a general idea would be to combine the zip named as the fully qualified function name and the zip named as the function excluding the folder named as the module. But here there could be an issue if there would be no patterns supplied in the root package field.
So I would propose that the merging/copying would only happen if there are patterns defined in the root package field and also including an extra field in custom pythonRequirements or maybe inside the function definitions, something along the lines of includeNonModuleFiles to ensure no breaking changes.
I'm wondering if this is possible or if there are any issues with this approach? Have not looked at the code yet, so no idea if my approach would be feasible. Also is this a use case that this plugin would even want to support?

So having had a look at the code, extending this behavior should be quite trivial. The existing code already copies files from the function.zip, but it filters based on the module, and moves the module to the root.
/**
 * Remove all modules but the selected module from a package.
 * @param {string} source path to original package
 * @param {string} target path to result package
 * @param {string} module module to keep
 * @return {Promise} the JSZip object written out.
 */
function moveModuleUp(source, target, module) {
  const targetZip = new JSZip();

  return fse
    .readFileAsync(source)
    .then((buffer) => JSZip.loadAsync(buffer))
    .then((sourceZip) =>
      sourceZip.filter(
        (file) =>
          file.startsWith(module + '/') ||
          file.startsWith('serverless_sdk/') ||
          file.match(/^s_.*\.py/) !== null
      )
    )
    .map((srcZipObj) =>
      zipFile(
        targetZip,
        srcZipObj.name.startsWith(module + '/')
          ? srcZipObj.name.replace(module + '/', '')
          : srcZipObj.name,
        srcZipObj.async('nodebuffer')
      )
    )
    .then(() => writeZip(targetZip, target));
}

The moveModuleUp function could take in a new parameter, and if true it would return Object.values(sourceZip.files) instead of filtering.

+1

+1

+1


[BUG] Cannot find file at '..\lib\ssh-copy-id\tools\ssh-copy-id.cmd'

Please confirm these before moving forward

[X] I have searched for my issue and have not found a work-in-progress/duplicate/resolved issue.
[X] I have tested that this issue has not been fixed in the latest (beta or stable) release.
[X] I have checked the FAQ section for solutions.
[X] This issue is about a bug (if it is not, please use the correct template).

UniGetUI Version
3.1.1 beta
Windows version, edition, and architecture
win11
Describe your issue
Cannot find file at '..\lib\ssh-copy-id\tools\ssh-copy-id.cmd' (C:\Users\Acker Liu\AppData\Local\UniGetUI\Chocolatey\lib\ssh-copy-id\tools\ssh-copy-id.cmd). This usually indicates a missing or moved file.
Steps to reproduce the issue
No response
UniGetUI Log
Cannot find file at '..\lib\ssh-copy-id\tools\ssh-copy-id.cmd' (C:\Users\Acker Liu\AppData\Local\UniGetUI\Chocolatey\lib\ssh-copy-id\tools\ssh-copy-id.cmd).

Package Managers Logs
Cannot find file at '..\lib\ssh-copy-id\tools\ssh-copy-id.cmd' (C:\Users\Acker Liu\AppData\Local\UniGetUI\Chocolatey\lib\ssh-copy-id\tools\ssh-copy-id.cmd).

Relevant information
No response
Screenshots and videos
No response

Please attempt to reinstall the missing/broken package and see if it helps

Cannot find file at '..\lib\ssh-copy-id\tools\ssh-copy-id.cmd' (C:\Users\Acker Liu\AppData\Local\UniGetUI\Chocolatey\lib\ssh-copy-id\tools\ssh-copy-id.cmd). This usually indicates a missing or moved file.

Please attempt to reinstall the missing/broken package and see if it helps

how

It happens again


Buildkite: Remove .ci  folder

What does this PR do?
Remove ci-folder
Why is it important?
Buildkite should be used in the first place

:green_heart: Build Succeeded

Buildkite Build
Commit: c2c32287ba90307ea8c427d6dee9ddfa72036ab6

:broken_heart: Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-08-22T09:30:20.906+0000

Duration: 11 min 9 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
791

Skipped
25

Total
816

Steps errors
Expand to view the steps failures

Load a resource file from a library

Took 0 min 0 sec . View more details here
Description: approval-list/elastic/elastic-agent-libs.yml

go test

Took 0 min 17 sec . View more details here
Description: go test -v ./...

:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


x64: Add rudimentary support for some AVX instructions

I was poking around Spidermonkey's wasm backend and saw that the various assembler functions used are all v*-prefixed which look like they're intended for use with AVX instructions. I looked at Cranelift and it currently doesn't have support for many AVX-based instructions, so I figured I'd take a crack at it!
The support added here is a bit of a mishmash when viewed alone, but my general goal was to take a single instruction from the SIMD proposal for WebAssembly and migrate all of its component instructions to AVX. I, by random chance, picked a pretty complicated instruction of f32x4.min. This wasm instruction is implemented on x64 with 4 unique SSE instructions and ended up being a pretty good candidate.
Further digging about AVX-vs-SSE shows that there should be two major benefits to using AVX over SSE:

Primarily AVX instructions largely use a three-operand form where two input registers are operated with and an output register is also specified. This is in contrast to SSE's predominant one-register-is-input-but-also-output pattern. This should help free up the register allocator a bit and additionally remove the need for movement between registers.

As #4767 notes the memory-based operations of VEX-encoded instructions (aka AVX instructions) do not have strict alignment requirements which means we would be able to sink loads and stores into individual instructions instead of having separate instructions.

So I set out on my journey to implement the instructions used by f32x4.min. The first few were fairly easy. The machinst backends are already of the shape "take these inputs and compute the output" where the x86 requirement of a register being both input and output is postprocessed in. This means that the inst.isle creation helpers for SSE instructions were already of the correct form to use AVX. I chose to add new rule branches for the instruction creation helpers, for example x64_andnps. The new rule conditionally only runs if AVX is enabled and emits an AVX instruction instead of an SSE instruction for achieving the same goal. This means that no lowerings of clif instructions were modified, instead just new instructions are being generated.
The VEX encoding was previously not heavily used in Cranelift. The only current user are the FMA-style instructions that Cranelift has at this time. These FMA instructions have one extra operand than vandnps, for example, so I split the existing XmmRmRVex into a few more variants to fit the shape of the instructions that needed generating for f32x4.min. This was accompanied then with more AVX opcode definitions, more emission support, etc.
Upon implementing all of this it turned out that the test suite was failing on my machine due to the memory-operand encodings of VEX instructions not being supported. I didn't explicitly add those in myself but some preexisting RIP-relative addressing was leaking into the new instructions with existing tests. I opted to go ahead and fill out the memory addressing modes of VEX encoding to get the tests passing again.
All-in-all this PR adds new instructions to the x64 backend for a number of AVX instructions, updates 5 existing instruction producers to use AVX instructions conditionally, implements VEX memory operands, and adds some simple tests for the new output of f32x4.min. The existing runtest for f32x.min caught a few intermediate bugs along the way and I additionally added a plain target x86_64 to that runtest to ensure that it executes with and without AVX to test the various lowerings. I'll also note that this, and future support, should be well-fuzzed through Wasmtime's fuzzing which may explicitly disable AVX support despite the machine having access to AVX, so non-AVX lowerings should be well-tested into the future.
It's also worth mentioning that I am not an AVX or VEX or x64 expert. Implementing the memory operand part for VEX was the hardest part of this PR and while I think it should be good someone else should definitely double-check me. Additionally I haven't added many instructions to the x64 backend yet so I may have missed obvious places to tests or such, so am happy to follow-up with anything to be more thorough if necessary.
Finally I should note that this is just the tip of the iceberg when it comes to AVX. My hope is to get some of the idioms sorted out to make it easier for future PRs to add one-off instruction lowerings or such.

Oh I should note that the total encoding size of f32x4.min was reduced from 45 to 35 bytes with this change. (less movdqa necessary)


Set codename differently based on BUILD_RELEASE

Maybe we should have a different codename / suite for the tip releases?

I wrote this thinking that we would add all .debs we produce, even for tip releases etc to the apt repo. I've thought a bit more about that and think we should not. I don't want to encourage people running tip releases and making it very simple, like through an apt repo, to grab the latest tip makes it a little too easy - to the level that I feel we're sort of encouraging it. I want our normal releases to be frequent enough that no one should really feel the need to run tip unless they are looking to confirm a bug fix or similar.
Since I don't want the tip releases in the apt repo, it doesn't matter what the codename is set to in the .deb.
Closing for now. We might revisit this in the future if we think it's a good idea to have more folks test the tip releases.


Sprint2

For this sprit there was some confusion regarding the two design tasks assigned to Kemal. For future sprints I will be sure to provide more detailed task descriptions and make sure that team members are all on the same page regarding tasks.

For my tasks everything went smoothly. For the group as a whole I felt everyone is on track with what they need to do.

I tried dual booting which gave me a lot of trouble and set back my progress on the scraper a bit.  I have a working draft of the program that will find urls on PCmag. The group seems to be making good progress toward our minimum goals.

I was able to add decent responsiveness to the website. The HTML for the review/manufacturers page should be coming along shortly. The only issue was waiting for the design before I could get to work.


Custom Content-Type for JSON Middleware

The json middleware always adds application/json as content type here
Using Tesla.Middleware.Headers to set a custom content-type , and Tesla.Middleware.JSON results in duplicate content-type headers.
[debug]
>>> REQUEST >>>
(no query)
content-type: application/json
content-type: application/vnd.api+json

My use cases revolves around http://jsonapi.org/ which requires the use of the application/vnd.api+json content-type.
with the decode_content_types option this middleware is open that format on the decode side, but not on the encode side of things
rather then removing content-type: application/json and then adding content-type: application/vnd.api+json in an extra step the JSON  middleware could accept an encode_content_type and set that as a content-type header
would such a PR be welcome?

Yes! I makes sense to have encode_content_type 👍

closing issue as PR was merged, thanks


Have different background color (or otherwise highlight) stage vs development

Since stage is currently undifferentiated from dev, this could help reduce confusion when you have both opened in tabs at the same time.

+1.  To be explicit, this is for barkeep's background, not the sites?

Yup, barkeep's background.

+1 would have made this morning less exciting though.

i like this idea!

The motivation for this is that Kevin, Thijs and I were at my machine trying various code changes for about 10 minutes that weren't working, and eventually someone realized that I was on stage so of course my code changes didn't make any difference.

While we're at it, would it be overkill to mark master and maybe current with their own special color?  It's not uncommon that I'll compare those against another stage branch to look for regressions.


Web – Chat – Edit mode doesn’t open when Press ArrowUp in DM if delete message using keyboard

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Intenral Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Log in with any account
Navigate to the conversation between user A and B in both devices
Send two messages to user B
As user A press ArrowUp in the DM. Verify that the last message user A sent in the chat enters edit mode
Delete all the text while editing the comment and press Enter
Press ArrowUp in the DM

Expected Result:
The first message sent in step 4 enters edit mode
Actual Result:
Focus is losted. Nothing happenes. Last message edit mode doesn’t open when Press ArrowUp in the DM if delete the previous message using keyboard
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] Windows: Chrome
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/c49d0ffc-531e-487f-a537-3b22628a08a5
View all open jobs on GitHub

This is regression from #32474
@tylerkaraszewski if we end up reverting approach, feel free to merge #33133 since it's straight revert

I can reproduce but this is only occuring on web/desktop and is a minor issue. Removing blocker label

@s-alves10 can you please handle this as regression?

@situchan Yes, I'll

@s-alves10 thanks! If you don't mind, should I assign this issue to you?

yes

@dukenv0307

This is regression from this PR #32474 which makes composer doesn't re-focus after deleting the message

What do you think is the root cause of not-focusing? Can you make it more clear?

@MonilBhavsar
PR is ready for review https://github.com/Expensify/App/pull/33162

Please assign me here for PR review

There was a suspicion that PR linked to this issue has caused a regression https://github.com/Expensify/App/issues/34419
@s-alves10 @situchan anyone of you can please confirm, thank you!

There was a suspicion that PR linked to this issue has caused a regression #34419 @s-alves10 @situchan anyone of you can please confirm, thank you!

Straight revert failing so not able to confirm. But I don't think so as this was the actual fix and other codes are just revert of previous PR.

@MonilBhavsar @tylerkaraszewski just to confirm, there's no regression here right?
Here's a payment summary for everyone's review:

Contributor: @s-alves10 $500
C+: @situchan

are you meant to be hired or are you just reviewing the PR?

This is follow-up of https://github.com/Expensify/App/issues/31637.
The work is done already and I reviewed 2nd PR.
@s-alves10's was already fully paid here for the work of first PR.

Oh hmm...so to clarify: I don't need to pay anyone?

I am still eligible based on I was not involved in first PR which caused this regression

Thanks for clearing this up, I will withdraw the offer for Sangar and hire you @situchan

Paid and job closed.


move codecoverage-tools to common package

Description: Move codecoverage-tools to shared npm package instead of common folder. Source code
Documentation changes required: N
Added unit tests: N
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

Did we intend to move those typings files? Can we get rid of them? Also not opposed to doing that in separate PR.

Yeah, definitely would like to get rid of them at some point - was trying to scope that outside of this pr though


ARROW-3905: [Ruby] Add StructDataType#[]

Codecov Report

Merging #3053 into master will increase coverage by 1.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3053      +/-   ##
==========================================
+ Coverage   86.94%   88.06%   +1.12%
==========================================
  Files         487      429      -58
  Lines       68610    64892    -3718
==========================================
- Hits        59652    57148    -2504
+ Misses       8857     7744    -1113
+ Partials      101        0     -101

Impacted Files
Coverage Δ

cpp/src/plasma/thirdparty/ae/ae.c
72.03% <0%> (-0.95%)
:arrow_down:

go/arrow/array/table.go

go/arrow/math/uint64_amd64.go

go/arrow/internal/testing/tools/bool.go

go/arrow/internal/bitutil/bitutil.go

go/arrow/memory/memory_avx2_amd64.go

go/arrow/array/null.go

go/arrow/datatype_nested.go

go/arrow/array/string.go

go/arrow/math/uint64_avx2_amd64.go

... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c70b0...aef063f. Read the comment docs.

+1


rclone removing excluded files when 'pulling' the sync

I set up rclone on my main computer to sync a folder to Amazon Cloud Drive:
rclone sync --checksum --bwlimit=400k --filter-from="rclone-filters.txt" ~/sites acd:sites

And another on my laptop to 'pull' the folder:
rclone sync --checksum --bwlimit=1M --filter-from="rclone-filters.txt" acd:sites ~/sites

rclone-filters.txt excludes .gir directories, node_modules, etc so the version on ACD doesn't have these folders.
When syncing to the laptop, rclone deletes these directories on the laptop if they already existed. (Or tries to in the case of .git directories which just spams the terminal with operation not permitted errors) Shouldn't using --filter-from on the 'pull' command prevent that?

I seem what you mean.  Here is my reproduction
$ mkdir a
$ mkdir b
$ touch a/one.jpg
$ rclone -v sync --exclude "*.jpg" b a
2015/11/09 07:40:50 Local file system at /tmp/a: Modify window is 1ns
2015/11/09 07:40:50 Local file system at /tmp/a: Building file list
2015/11/09 07:40:50 Local file system at /tmp/a: Waiting for checks to finish
2015/11/09 07:40:50 Local file system at /tmp/a: Waiting for transfers to finish
2015/11/09 07:40:50 Waiting for deletions to finish
2015/11/09 07:40:50 one.jpg: Deleted

one.jpg shouldn't have been deleted unless --delete-excluded was passed in.
Can you tell me make me a reproduction like the above which shows rclone trying to delete .git directories and spamming the terminal?  I haven't been able to do that.
Thanks

Like this?   Can you tell me what you've got in your  rclone-filters.txt file and I'll try to reproduce that problem too.

- _gsdata_/**
- _saved_/**
- node_modules/**
- bower_components/**
- **.git/**
- .DS_Store
- Thumbs.db
- .vagrant/**
- .sass-cache/**
- **.bower**
- .debris/**
- *.com*
- Icon?
- .otto/**
- files/cache/**
- files/tmp/**
+ .gitignore

Thanks for doing that.  I think the .git spam is just because you don't have permission to delete those files rather than a problem with rclone.
It will go away when I fix the underlying issue.

My issue is that I don't want rclone to delete these excluded directories.  It also deleted node_modules, bower_components, etc.  It shouldn't even know they exist if using the --filter-from option, right?
To reiterate, I uploaded the directory using the --filter-from option on the first computer:
rclone sync --checksum --bwlimit=400k --filter-from="rclone-filters.txt" **~/sites** acd:sites

Then on another computer, which already had the sites directory but an outdated one, I used the below command to pull/update the sites directoryr:
rclone sync --checksum --bwlimit=1M --filter-from="rclone-filters.txt" acd:sites **~/sites**

It then proceeded to delete all the directories on the second computer that the remote version didn't have despite the inclusion of the --filter-from command.
Perhaps it's just because I'm doing it wrong? How can I get rclone to completely ignore directories?

Sorry, disregard my last comment. I skimmed over the last part of your comment referencing the underlying issue!

I've fixed this in v1.25.
I've spent some time thinking about the algorithm and writing unit tests, but I'd appreciate a second opinion!  If you find a problem then please open another issue.
Thanks
Nick


Spaces -> Tabs, and make reusable by module system

[ ] CR by @chanind

Also would be good to recompile the JS in the main dir


Sortable not working in firefox

Hi everybody.
We are using react-sortable in the admin UI of a project.
The client reports that tool is unusable in firefox (>=49.0.0 both win and linux). After sortEnd it always redirect the browser to about:blank.
I'm still looking at the code to determine the cause, but it is visible also on official demos here http://webcloud.se/react-sortable/
How to reproduce:

Go to http://webcloud.se/react-sortable/ with FF
reorder an item in the list
you are being redirected to about:blank

Strange thing is that if you try to drag an item outside the list (either as first or last element), sorting works well.
As soon as I find the problem (and if im able to fix it) I will fork and submit a merge request.
Cheers,
Stefano

I can see, this is possible to fix by setting an onDrop callback that will call preventDefault() function.
Like this:
 <Component
          ....
          onDragOver={this.dragOver}
          onDragStart={this.sortStart}
          onDragEnd={this.sortEnd}
          onDrop={function(e){e.preventDefault();}}
           ....
          />

I have already pushed a fix to master branch, I will release it at some point today.

it seems to be related to this: http://stackoverflow.com/questions/14541775/html5-drag-and-drop-firefox-is-being-redirected

Nice, I was looking at the wrong point (onDragEnd) and it didnt work.
Thank you!


Data loss on kick + reinvite to guild

Possibly caused by platform data being hard reinitialized to the default on guild entry.

This is part of intended regulated behavior for data security.


feat: btc chain adapters and unchained

Nitpick: BIP32Params should be renamed BIP44Params before we make the wrong thing official -- I'm eating but will do the needful in a few

bip32 describes the path. the purpose can either be in reference to bip44/ or bip84 in that example case.  This lib project should also absolutely keep the same nomenclature as HDwallet that uses bip32path to describe to entire path string.


Using problem

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:32:36.023Z)
OS Version: Windows_NT x64 10.0.16299
Extensions:

Extension
Author (truncated)
Version

html-snippets
abu
0.1.0

view-in-browser
qin
0.0.5

When I use the VS Code , I find that I can`t use ctrl and enter at the same time.
I do not know how to solve this problem.

Steps to Reproduce:

I checked a word , and I use ctrl+shfit+enter at the same time.
Then I find out ctrl+shift+enter can not used. I also find that ctrl + enter  can not use ,too,

Reproduces without extensions: Yes/No

This is probably an issue with your extension. Please try reporducing with all extensions disabled and let us know if you can still reproduce the issue.
Also if you can please provide more details as to what is going on and what you are expecting ( a picture or viedo helps)

I just installed two extensions ，HTML snippets and View In browser；
My computer maybe can not use ctrl and enter at the same time Now…
It is happen this thing(or bug) last time, I used reload the computer to save this problem. I Think it maybe my pcs problem last time . but this time it is happen again. My English is so terrible. I cant express what I want to express.
I  express it again by Chinese：
我再选定了一个单词的时候（在选定的情况下），按了ctrl+shift+enter 想换到上一行，结果就不行了，然后我试了一下ctrl +enter这两个键也不行了，不知道是不是和什么冲突了，在我产生以上操作之前，VS code都是正常的。
就导致了电脑的使用VS code的时候ctrl和enter两个键不能同时使用，（但是不知道自己电脑能不能同时使用这两个建了，因为我还没有找到尝试这两个键同时使用的事件）
<EMAIL_ADDRESS>发送自 Windows 10 版邮件https://go.microsoft.com/fwlink/?LinkId=550986应用

发件人: Isidor Nikolic<EMAIL_ADDRESS>发送时间: Wednesday, December 6, 2017 7:15:13 PM
收件人: Microsoft/vscode
抄送: douya_1995; Author
主题: Re: [Microsoft/vscode] Using problem (#39768)
This is probably an issue with your extension. Please try reporducing with all extensions disabled and let us know if you can still reproduce the issue.
Also if you can please provide more details as to what is going on and what you are expecting ( a picture or viedo helps)
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vscode/issues/39768#issuecomment-349608940, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfPf0gPH79WpQ0VSshdk2Qs_a0IgHWZFks5s9ndAgaJpZM4Q3l5X.

Unfortunetly my Chinese is not that good. So I would recmomend that you ask this question on a chinese stack overflow as we currently can not help. Sorry


Copy original specification, and convert it to markdown then

Get the best (textual) specification you can get, and derive from it a first readable markdown version. This is finished when the Github markdown parser shows a nice looking result automatically. The reference is the Saremba HTML version of it.

Seems to work, TOC is working well, layout is "ok" (could be improved over time).


Update lodash

In issue https://github.com/oleksiyk/kafka/issues/124 the lodash version was fixed at 4.5.0 to avoid a regression in merge (https://github.com/lodash/lodash/issues/2699).
This has now been fixed, and testing no-kafka with 4.16.4 confirms this.

Its better to fix lodash at some version (=4.16.4 if it works fine) because its not the first time its causing problems.

Thanks!


Dynamic pages generates wrong url with sub path

Version
nuxt-i18n: lastest
nuxt: latest
Nuxt configuration
mode:

[x] universal
[] spa

Steps to reproduce
Create a link with localePath({name: 'slug', params:{slug: 'path-1/path-2'}})
What is Expected?
Generated url should be
http://localhost:3000/path-1/path-2
What is actually happening?
If i create a link to a dynmaic page with a sub directory the generated url is wrong:
page.slug = 'path-1/path-2';
localePath({name: 'slug', params:{slug: page.slug}})
Generated url is
http://localhost:3000/path-1%2Fpath-2

This behavior is specific to VueRouter and not this module.
See https://codesandbox.io/s/nuxt-dynamic-route-lsqvm?file=/pages/_slug.vue which reproduces without using this module.


Scrolling Option inside the twitter column

This "Tweets from mesheryio" box should occupy just a certain height and width, and there should be a scrolling option right inside the box.

Can I try this Issue

Hey! Can i also work on this issue

Hey can you assign this issue to me, I have the perfect solution for this.

@Prathamesh-Shanbhag 🚀


Move Abseil code in s2geometry to an isolated namespace.

This builds on #891 so merge that first.
This PR moves the Abseil functionality embedded in the s2geometry library into an isolated namespace (cesium_s2geometry_absl). This avoids linker errors when packaging an Unreal Engine 5.4 game that includes both the Cesium for Unreal and Pixel Streaming plugins, because the Pixel Streaming plugin also embeds some Abseil code.
Fixes CesiumGS/cesium-unreal#1420

Hi @kring, with the update. Is there a way we can integrate or access? Thanks

Yep, just grab a build from this PR:
https://github.com/CesiumGS/cesium-unreal/pull/1431
Instructions here:
https://github.com/CesiumGS/cesium-unreal/blob/main/Documentation/using-prerelease-packages.md

I agree it could be worth upgrading @csciguy8, but I don't think either of those s2geometry PRs will help us. They would allow us to use an external Abseil, but I don't think that helps.
We can't supply our own Abseil, because Unreal will still have its own, and we'd still have the conflict.
We can't use Unreal's Abseil (even if using libraries from Unreal in cesium-native were easy, which it's not) because Unreal doesn't appear to include headers and an independent library for it. It's just baked into the WebRTC library. In theory we could figure out what version of Abseil Unreal uses, and use the headers for the same version. But we'll still have challenges at link time. In a packaged build where WebRTC and Cesium for Unreal are baked into a single executable, webrtc.lib includes Abseil, and so as long as we're compiled against the right version, everything is fine. However, in a regular Editor build, WebRTC and Cesium for Unreal are in separate DLLs, and the Abseil symbols are almost certainly not exported from the WebRTC DLL. So even if we made Cesium for Unreal depend on WebRTC (which we don't want to do), we'd still need to somehow link against Abseil in a non-packaged build in order to avoid undefined symbol linker errors.
So I think the approach in this PR is the best available. Using the preprocessor to rename a namespace is a little hacky, sure, but it's simple and effective, and tightly scoped to just s2geometry (the #define absl doesn't exist except while we're building s2geometry). Theoretical problems we might have with it in the future (such as an unrelated symbol named absl getting inadvertently renamed) are likely to manifest as compiler or linker errors, so it should be relatively safe as well.


Add cake day icon for comments

Surprisingly, this is not possible with the Reddit API

Done actually it doesn't exist unless it is your cakeday


fix(tabs): Add role to mat-tab-nav-bar and mat-tab-link

This is already correctly set on the main tab component:
https://material.angular.io/components/tabs/overview
mat-tab-group has role="tablist"
https://github.com/angular/material2/blob/abc3d38c57146443c848d5ba26fd2fab8ca185d6/src/lib/tabs/tab-header.html#L11
mat-tab has role="tab"
https://github.com/angular/material2/blob/abc3d38c57146443c848d5ba26fd2fab8ca185d6/src/lib/tabs/tab-group.html#L6
But the standalone version mat-tab-nav-bar and mat-tab-link do not have role set.
This is a potential breaking change insofar as someone was already setting role explicitly (test
added for this case to verify it doesn't break), but the impact is low and should be rare: I have
found no examples on github and only two examples in google3 of role being set, and at worse it sets
role="tablist" on mat-tab-nav-bar, which would result in a duplicate role="tablist" nested one layer
below, but which is not that harmful and is easy to fix. Existing code that directly sets role on
mat-tab-link will have that role overridden, but I don't know that this is currently happening.

LGTM for a11y

Thank you! Rebased and ready for further review.

@stevenyxu FYI this is being reverted in #11657. The nav-tabs follows the pattern of nav with anchors by design as opposed to a full tablist pattern.

@jelbourn that's fine thank you. nav-tabs is still missing current status indicator. I've adjusted my other PR https://github.com/angular/material2/pull/11409 to do this.


Add AAAI2021_SSAN

Add AAAI2021_SSAN.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


comparison with cmakelang?

Hi @marzer, I happily stumbled over this project in a PyPi search.
I'm currently using [cmakelang](https://github.com/cheshirekow/cmake_format) (which hasn't been updated for a while) for my CMake linting needs. Are you aware of that project?
If yes, can you say anything on feature comparison?
Obviously you're not also targetting formatting. From a quick glance at their checks you seem to be mostly covering other areas?

Hi there, good question :) No, I was not familiar with that project, but from a cursory glance it appears as though this one is similar to the cmake-lint subproject within it, albeit somewhat less mature.
I can't comment too much on the feature comparsion, other than to suggest you give both a try. Mine is largely focused on finding overtly "bad CMake" and telling you how to fix/modernize (with a keen focus on finding non-target-based bits and nudging you towards targets instead).
The story behind check-cmake is: I started a new job and found myself needing to fix the CMake for an entire department who'd all gotten it wrong, so it's calibrated towards that use-case.

Gotcha. Thanks for the info.
I will definitely try this out too. Might be a while though.
Would you generally be open to getting some contributions porting over checks?

Would you generally be open to getting some contributions porting over checks?

Yep, sure, though be mindful that check-cmake is pretty coarse. It doesn't do a full CMake parse, expand variables, et cetera. It's mostly regex-based. Not all checks will work in that context.


How can i send a videp to test the perfomance?

very excited about ur code, im trying to test this model in a video to test its performance,but i dont konw how to or where to send the vide in, i have read the issue about the webcamera use, it has to record a video,and process, Does it means i have to process my test video by the same method,such as generate .npy file and generate rawframes and extract skeleton features and so on? Thanks for answering.Appreciate!

Yes. You need to process the video into RGB frames or skeleton following the preprocessing guide [data_process/readme.md], and load the provided pretrained model to test it.


[ci] release

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#2009 1e8bfe4 Thanks @delucis! - Updates Docsearch packages to 3.6.0

size-limit report 📦

Path
Size

/index.html
5.78 KB (0%)

/_astro/*.js
21.95 KB (0%)

/_astro/*.css
13.62 KB (0%)


Include local dev dependencies

We have a problem where we have a few shared, local dependencies, but they are dev dependencies, which get packaged into a production library.
With the current version of npm-link-shared, they were not included in the linking chain. I believe this to be a fairly common approach, so I created a pull request with a suggested solution to include a new option --includeDev to also include dev dependencies to recurse down the dependency tree, but not to include in the npm link [module] call (--production is still used).
This includes an update to the test which adds a dev dependency and checks if it is correctly linked.
Using an extra option to prevent existing logic to break.

@orendin Thanks for the PR - I will review it tonight.

Thanks, published as 0.3.4


Add Flavia as TL of Green Reviews WG

Adding @locomundo who is now a TL for the Green Reviews WG https://github.com/cncf/tag-env-sustainability/issues/513 🎉

thank you @guidemetothemoon!!


Unable to create keys

I'm trying to use this module but get the below error:
New-MimecastAPIKeys
cmdlet New-MimecastAPIKeys at command pipeline position 1
Supply values for the following parameters:
AppId: XXXXXXXXXXXXXXXXXXX
Credentials
New-MimecastAPIKeys : Unable to create keys
At line:1 char:1

New-MimecastAPIKeys

  + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
  + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,New-MimecastAPIKeys

Thanks, if there is anything I can try my end just let me know :)

I updated the New-MimecastAPIKey function by calling Message parameter explicitly. I do not think this was the cause of the issue, but is the first obvious thing to try and change. Did you install the module from the Powershell Gallery? I also added the message returned from Mimecast to the error that should tell why an API key was not created, so this should shine light on the error as well. Please note there are 2 authentication methods for Mimecast, Basic-Cloud and Basic-AD. If you have MFA enabled you will need to use Basic-Cloud authtype (now the default).

Hey - this was installed from the Powershell Gallery, has it been updated on there?

I think the issue i'm getting is the get-credential command on the new-mimecastapikeys line doesn't prompt for MFA which is why it fails

Yeah I updated the PSGallery module. I actually ran into a similar issue when we enabled MFA at my company. I had to to use the cloud password instead of my AD credentials. I actually changed the default authentication method to use the "Basic-Cloud" authentication. You specify the auth method using the parameter "-AuthType" , but the default is now Basic-Cloud. I am unaware of a way to get MFA to work with AD authentication unfortunately.

I ended up turning 2FA off temporarily and still had the same error come up which is odd.
I'll see if Mimecast have any ideas

Ok, I think we are getting somewhere.
The URL used https://us-api.mimecast.com/api/login/login is the incorrect region for my account. The correct region is https://eu-api.mimecast.com/api/login/login.
How can I change that?

Ohhh! Dang, I am so sorry I wish I would have caught that. I will make an update so that you can chose which region to use as a parameter when setting up the API key.

I have updated the module. I fixed a couple other bugs as well. You can now chose your region when setting api keys. I just tested it out and appears to be working now. Thank you for bringing this to my attention!


Set default disk driver io mode for VMI

Since Kernel Async IO threads perform better in most of the cases - they
perform I/O faster and they are cheaper in CPU, we set this to be the
default value if the user did not specify anything else.
Signed-off-by: Daniel Belenky<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

KubeVirt now sets a default value for disk device's driver I/O mode to 'native' which will use Kernel async I/O threads.

/hold

/retest

Closing this PR for now because this is not the direction that we want to take at this point.


Extra next_type property causes an error in dev mode

Here's what I get:
Server Error
Error: Additional keys were returned from `getServerSideProps`. Properties intended for your component must be nested under the `props` key, e.g.:

	return { props: { title: 'My Title', content: '...' } }

Keys that need to be moved: size, timeout, __next_type__.
Read more: https://nextjs.org/docs/messages/invalid-getstaticprops-value
This error happened while generating the page. Any console logs will be displayed in the terminal window.
Call Stack
Object.renderToHTML
<EMAIL_ADDRESS>(464:23)
async doRender
<EMAIL_ADDRESS>(1144:38)
async
<EMAIL_ADDRESS>(1236:28)
async
<EMAIL_ADDRESS>(64:36)

If extra metadata is needed on the response, would a symbol key work? Unless it needs to be serializable, then I'm not sure 🤔

Ah, this happened when I tried to use a next-runtime handler outside of a handle() handler. I guess that should be documented against?

Correct, I'll update the docs today. In v1, I mentioned that those helpers can be used outside the handle function in standard getServersideProps functions.
That's no longer true. I used async_hooks before to support that, but hooks are buggy and have a performance impact. That's why we now return a Response from those helpers, and unwrap them in a later stage.
When not using handle you'll be returning new Response() from your getServersideProps. Next doesn't support that.
We no longer support those handlers outside of next. Those utils were really, really, simple. So I'm not sure if it's worth it to maintain a copy of those in this project, just for the sake of those that want to use json but not handle.
I'm curious about the use case tho. Why not just turn it into a handle with only a get method?
https://github.com/smeijer/next-runtime/commit/f1a5e328a560924bc051ce6a4111296bb5515e4c#diff-db79f1a9685fdf233bd1b68d6ed14d7e39c9224756a817af7bdc15cedf687907

Regarding the extra property I'm adding on Response, I think it should be refactored and be a custom header (x-next-runtime-type. That header can be stripped out later.
Here we currently set the prop, could be the header instead:
https://github.com/smeijer/next-runtime/blob/cbf27f9685d6fcc2a8e8205c29677040fe2f66e1/src/responses.ts#L11-L19
And here we could just not transfer the custom header
https://github.com/smeijer/next-runtime/blob/cbf27f9685d6fcc2a8e8205c29677040fe2f66e1/src/handle.ts#L67-L69

For searchers, I've pushed the change. This error will now be like:
Error: Error serializing props returned from `getServerSideProps` in "/".
Reason: Props must be returned as a plain object from getServerSideProps: `{ props: { ... } }` (received: `[object Undefined]`).

Done https://next-runtime.meijer.ws/api/response-helpers#common-mistakes

I'm curious about the use case tho. Why not just turn it into a handle with only a get method?

Yeah, that's what I ended up doing, I think it was just a mistake 🙃


Force the body parameter of Patch operations to be required

Fixes https://github.com/Azure/autorest.csharp/issues/1968
Description
Add your description here!
Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

Please preview the changes of this PR here: https://github.com/Azure/azure-sdk-for-net/pull/27299/files


Typo in Caution Box

Issue description
At the bottom of the page, inside the box which is headlined with 'Caution' there is a typo. I believe it should say 'The tutorial group' instead of 'The turorial group'.
Feedback Type (Optional)
spelling or grammar
Page Title on SAP Help Portal (prefilled)
Developing and Operating SaaS Applications
Page URL on SAP Help Portal (prefilled)
https://help.sap.com/docs/btp/sap-business-technology-platform/developing-and-operating-saas-applications

@hottek, Thank you for your feedback! We'll look into it and keep you updated on the progress.

@hottek Thanks for the contribution. You will be able to see the change on SAP Help Portal after the next content update.

https://people.sap.com/lukaspr


Add email functionality

Motivation and Context
We should be able to send emails, either in a batch (action rule) or individually ad-hoc (fulfilment).
What has changed
Added EMAIL action rule type implementation, and also listen for internal messages requesting email fulfilment, and events coming from Notify Service, recording that a fulfilment has happened against a case.
How to test?
Run the ATs. Try sending in some events on topic rm-internal-email-fulfilment. Check the integration with Notify Service by requesting some email fulfilments in the Support Tool.
Links
Trello: https://trello.com/c/OPYjtKwf

 Use Email for Action Rules and Fulfilments (13)


[BUG] Longhorn Fails to List CIFS Backups on Ubuntu 24.04 Cluster,  kernel is 6.8.0-31-generic.

Describe the bug
When I create a cluster with Ubuntu 24.04, Longhorn cannot list CIFS backups and shows an error.

error listing backup volume names: failed to execute: /var/lib/longhorn/engine-binaries/longhornio-longhorn-engine-v1.5.x-head/longhorn [/var/lib/longhorn/engine-binaries/longhornio-longhorn-engine-v1.5.x-head/longhorn backup ls --volume-only cifs://longhorn-test-cifs-svc.default/backupstore], output cannot mount CIFS share longhorn-test-cifs-svc.default/backupstore, options [soft]: mount failed: exit status 32 Mounting command: mount Mounting arguments: -t cifs -o soft,<masked>,<masked> //longhorn-test-cifs-svc.default/backupstore /var/lib/longhorn-backupstore-mounts/longhorn-test-cifs-svc_default/backupstore Output: mount error: cifs filesystem not supported by the system mount error(19): No such device Refer to the mount.cifs(8) manual page (e.g. man mount.cifs) and kernel log messages (dmesg) , stderr time="2024-05-21T09:16:32Z" level=warning msg="Trying reading mount point /var/lib/longhorn-backupstore-mounts/longhorn-test-cifs-svc_default/backupstore to make sure it is healthy" func=util.EnsureMountPoint file="util.go:309" pkg=cifs time="2024-05-21T09:16:32Z" level=info msg="Mounting CIFS share cifs://longhorn-test-cifs-svc.default/backupstore on mount point /var/lib/longhorn-backupstore-mounts/longhorn-test-cifs-svc_default/backupstore with options [soft]" func="cifs.(*BackupStoreDriver).mount" file="cifs.go:115" pkg=cifs E0521 09:16:32.337446 2368 mount_linux.go:236] Mount failed: exit status 32 Mounting command: mount Mounting arguments: -t cifs -o soft,<masked>,<masked> //longhorn-test-cifs-svc.default/backupstore /var/lib/longhorn-backupstore-mounts/longhorn-test-cifs-svc_default/backupstore Output: mount error: cifs filesystem not supported by the system mount error(19): No such device Refer to the mount.cifs(8) manual page (e.g. man mount.cifs) and kernel log messages (dmesg) time="2024-05-21T09:16:32Z" level=error msg="cannot mount CIFS share longhorn-test-cifs-svc.default/backupstore, options [soft]: mount failed: exit status 32\nMounting command: mount\nMounting arguments: -t cifs -o soft,<masked>,<masked> //longhorn-test-cifs-svc.default/backupstore /var/lib/longhorn-backupstore-mounts/longhorn-test-cifs-svc_default/backupstore\nOutput: mount error: cifs filesystem not supported by the system\nmount error(19): No such device\nRefer to the mount.cifs(8) manual page (e.g. man mount.cifs) and kernel log messages (dmesg)\n" func=main.ResponseLogAndError file="main.go:47" : exit status 1

To Reproduce

Create cluster on ubuntu 24.04
Deploy the CIFS backup tore serverkubectl create -f https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/backupstores/cifs-backupstore.yaml

Create cifs://longhorn-test-cifs-svc.default/backupstore
Add backup target cifs://longhorn-test-cifs-svc.default/backupstore
Add backup target credential secret cifs-secret
Click Backup in the main menu
Observe the error

Expected behavior

Support bundle for troubleshooting
supportbundle_f0c5df65-c4a2-4680-89e4-b45f53b41b4d_2024-05-21T09-17-29Z.zip
Environment

Longhorn version: v1.5.x-head
Impacted volume (PV): n/a
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): kubectl
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: k3s

Number of control plane nodes in the cluster:
Number of worker nodes in the cluster:

Node config

OS type and version: ubuntu 24.04
Kernel version: 6.8.0-31-generic #31-Ubuntu SMP PREEMPT_DYNAMIC Sat Apr 20 00:40:06 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
CPU per node:
Memory per node:
Disk type (e.g. SSD/NVMe/HDD):
Network bandwidth between the nodes (Gbps):

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): digitalocean
Number of Longhorn volumes in the cluster: 0

Additional context

Does it work in ubuntu 22.04?

Does it work in ubuntu 22.04?

it works normally on Ubuntu 22.04

In yamls/namespaced/longhorn-system/longhorn.io/v1beta2/backuptargets.yaml it tells us  ... Output: mount error: cifs filesystem not supported by the system ... which indicates a missing cifs-utils package.


[FEATURE] Merge Peft Adapter to base model

Could AutoGPTQ support the merge model from adapter and base model?

Thank you for your suggestion! Will look into this!

Bump. I'd love this feature so that I can run vLLM with my quantized model.
Thanks.


Bug fix: appbridge_version incorrectly casting to boolean

Spotted a typo in the new appbridge_version config incorrectly casting to a boolean, resulting in the URL to app bridge always returning a 1 or a 0 rather than the actual config value.

Coverage remained the same at 99.768% when pulling a3a98a2603217f5860d05754e13563c26af8aa78 on jedimdan:bugfix-appbridge-version into b6dde2f935c6ede7ee555b465c9a5f902b571cc5 on ohmybrew:master.

Thanks


uninstall leaves server extension

to reproduce:

install beakerx conda package into a fresh env.
"conda remove beakerx"
"jupyter notebook"

result:
$ jupyter notebook
[W 19:02:52.952 NotebookApp] Error loading server extension beakerx
    Traceback (most recent call last):
      File "/Users/spot/anaconda/envs/beakerx/lib/python3.6/site-packages/notebook/notebookapp.py", line 1451, in init_server_extensions
        mod = importlib.import_module(modulename)
      File "/Users/spot/anaconda/envs/beakerx/lib/python3.6/importlib/__init__.py", line 126, in import_module
        return _bootstrap._gcd_import(name[level:], package, level)
      File "<frozen importlib._bootstrap>", line 978, in _gcd_import
      File "<frozen importlib._bootstrap>", line 961, in _find_and_load
      File "<frozen importlib._bootstrap>", line 948, in _find_and_load_unlocked
    ModuleNotFoundError: No module named 'beakerx'

because:
$ cat /Users/spot/anaconda/envs/beakerx/etc/jupyter/jupyter_notebook_config.json
{
  "NotebookApp": {
    "nbserver_extensions": {
      "beakerx": true
    }
  },

How to fix this? thanks.

for future travelings:
(plan2vec) ➜  zdoom git:(master) ✗ jupyter labextension disable beakerx
(plan2vec) ➜  zdoom git:(master) ✗ jupyter labextension disable beakerx-jupyterlab
(plan2vec) ➜  zdoom git:(master) ✗ jupyter labextension uninstall beakerx-jupyterlab


Product labels new and sale use an incorrect boolean type

Current behavior

The vue-storefront/core/modules/catalog/components/ProductTile.ts component looks for two fields in the ElasticSearch product record to decide if the new and sale labels should be displayed on each product.
The checks for these fields assumes the fields to be of type string with an exact value of '1'.

Expected behavior

The fields should accept the standard true / false boolean types as input.
Steps to reproduce the issue

Repository

https://github.com/DivanteLtd/vue-storefront/blob/release/v1.11/core/modules/catalog/components/ProductTile.ts#L37
Can you handle fixing this bug by yourself?

[X] YES
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[X] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser:
OS:
Node:
Code Version:

Additional information

thanks for reporting @themreza, actually we've fixed something similar, looks like easy to fix

It has been fixed along with the product display on latest option. :)

Just changed the default sort to

"sort": "updated_at",
instead of

"sort": "updated_at:desc",

Just changed the default sort to

"sort": "updated_at",
instead of

"sort": "updated_at:desc",

What does the sort order have to do with new and special labels?
If it was fixed, would you please share the link to the new ProductTile.ts?

@WaleedTikken we've fixed issue with the sorting functionality on the category page and nothing else, this is about the isOnSale or isNew - it won't work if the value is different than '1' @themreza is right.


feat: remove extended resolve extensions

Summary

Test Plan

Require Documentation?

[ ] No
[ ] Yes, the corresponding rspack-website PR is __

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

0.5.0

PR #5185

PR #5184   👈

This stack of pull requests is managed by Graphite.


Disable browser cache appropriately

I keep getting an issue (particularly on Android) where I publish an update to the site but the browser doesn't seem to load the latest version of the JavaScript. Something like https://stackoverflow.com/questions/42855187/how-to-add-version-number-to-html-file-not-only-to-css-and-js-files might help (might not have to do the HTML part, might just be able to version the JS instead).

Now versioning by appending a query parameter based on the hash of the file.


Rewrite global search component

Rewrote the search component.

Renamed it to Global Search which is more appropriate
Added SWR to have client-side query caching

Debounce the queries to avoid hitting the backend too frequently

Store search term in the URL to rehydrate the search input on refresh
Store search results in sessionStorage

rehydrate search results from the stored ones
aggregate newly searched results with ones stored in storage. This enables offline and client-first searching.

add fuse.js to enable fuzzy searching on aggregated results to get a better match
add fuzzy highlighting of the search results
restyle the search component to be just a ul > li [] > a
Create a new "View All Results" link that could navigate to a fully detailed search page
Removed the "categories" / "runs" section since the info wasn't easy to grok as far as which run you're really selecting since times weren't associated yet.

added TODO around this.

Added TODOs for incremental improvement around adding server components for the global search since the results list can be SSR.

https://www.loom.com/share/82b2da68e0bf466d88e04a797efa4e83?sid=0cf0c4d3-f5fe-448b-be5a-c5d615578661

Related to #4

@florence-wolfe
I did a few changes in 3370d1dbbe217917972030bdbf5d49b5117e68eb

I used description lists rather than abusing the list-group-item from bootstrap to correctly distinguish between games and users
I completely dropped the inline-styles, we don't need them as we already had the input-group + dropdown-menu-combo before. All of your custom classes and inline-styles ain't needed, they are provided by Boostrap.
I introduced the bootstrap utilities last year for stuff like min/max width/height and whatever <3 - I made sure to add the max-height of 400px into that

Thank you @florence-wolfe <3


[firebase_auth] Add signInType parameter in FirebaseUser.

My situtation: I want to check if sign-in type of FirebaseUser object is Email&Password type, so that I can send email verification to their email. But I don't want to send for other sign-in types.

My workaround for now:

=> You can see that it's very ugly.

My sugesstion: There is a need for a parameter named 'signInType' in FirebaseUser object which contains an enum like this
'enum SignInType {
PHONE,
EMAIL,
GOOGLE,
FACEBOOK,
TWITTER,
GITHUB,
OTHER,
}'

Hey @dungnv2602 - I think this is already possible using the auth provider classes, e.g.
if (firebaseUser.providerData[1].providerId == EmailAuthProvider.providerId) {
 // ..
}

https://github.com/FirebaseExtended/flutterfire/blob/master/packages/firebase_auth/firebase_auth/lib/src/auth_provider/email_auth_provider.dart#L8


Add previous feedback to recent posts API

Adds feedbacks.feedback_type to the returns from the recent posts API (/posts/recent.json).
Fair warning: this may break things. I'm a Rails hacker, not a Rails developer.

@Undo1 My breakages in the recent posts API are removed, but here's a load of new stuff. It's in this PR because I forgot it would automatically add to an existing request.
Tested in an Ubuntu VM, all works fine for me.


Feat/pact plugin detect musl

Create musl based variants of

pact-plugin-cli

Tracking issue:- https://github.com/pact-foundation/devrel/issues/30
Follows on from https://github.com/pact-foundation/pact-reference/pull/372
Updates jvm and rust drivers

check for musl presence

compile time flag for rust
ldd lookup jvm

download musl variants, prefixed with -musl
fallback to non musl variant, if not provided and warn the user that issues may occur.

Additionally

pins cross to 0.2.5 to ensure we build against the correct version of glib, issue from pact-ref
fix #52  - there was an error before building (I believe it was linked to a path path = "../drivers/rust/driver" in the docker builder, but this context wasn't passed available. I switched it out to use cross 0.2.5 for consistency

Testing notes
Have tested out the pact-plugin-cli with the rust driver in pact-php and pact-go forked workflows. Haven't tested the jvm drivers post the update to fallback to non musl variants but will test it out.

I've tested this against various forks of our pact projects (pact-php, pact-js, pact-go), pact-ruby-ffi, and my project hello_ffi it is working well under alpine.
Failures are due to not having relevant access to tokens to publish pacts
Sample builds are available on my fork release which point to an updated repo index which points to my forks, to pull the musl builds.
https://github.com/YOU54F/pact-plugins/releases/tag/pact-plugin-cli-v0.1.2
Happy to take any feedback to get this merged @rholshausen, I could refactor some bits to make it a bit cleaner

this PR will be reapproached to consider building only a musl variant for linux, and providing it with the name of the existing glibc based executable.
The resulting binary should work for all, and simplifies any musl or os detection requirements for linux

this PR will be reapproached to consider building only a musl variant for linux, and providing it with the name of the existing glibc based executable.
The resulting binary should work for all, and simplifies any musl or os detection requirements for linux


From swift 2.3 to 3.0 - Each of my Struct saying " " does not conform to protocol 'Decodable' or 'Encodable'

Hi @hkellaway ,
My code was working fine when I was using Gloss - 0.8.0 Version for my swift 2.3 project. Now I am converting my code to swift 3.0 and I am using Gloss version 1.0.0.
In each model class, I am getting does not conform to the protocol.
Sample Code
`
import Gloss
struct myRequest: Encodable, CustomDebugStringConvertible {
let first: String
let second: Bool
let third: Double
var debugDescription: String {
    return "~myRequest~"
}

init(first: String, second: Bool = false, third: Double) {
    self.first = first
    self.second = second
    self.third = third

}

func toJSON() -> JSON? {
    return jsonify([
            "first" ~~> self.first,
            "second" ~~> self.second,
            "third" ~~> self.third,
    ])
}

}
`
Am I doing something wrong?
Need help @hkellaway

i copy/pasted your model there using the latest Gloss version as well as the version you say you're using (1.0.0) and i am not getting any message about not conforming to a protocol, sorry.
usually Xcode will help you out by allowing you to insert whatever function it is you're missing.

Hi @hkellaway
Actually, In my project, I was also using public typealias JSON = [String: AnyObject],
which was creating a problem because in Gloss same name type alias is used.
But compiler was giving me an error regarding protocol compliance. That was quite weird.
Thanks for your quick reply.
I am closing this issue.


Egress rules integration tests

What this PR does / why we need it:
Added tests for egress rules.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

@vadimeisenbergibm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
a83538aa63be19a19f89edbc55ce3e21d5bc2236
link
/test pilot-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test pilot-e2e-smoketes

Thanks for the e2e test!.


NPE if classpath element directory is not created

[main] WARN org.reflections.Reflections - could not create Dir using directory from url file:/Users/jonnyzzz/Work/vcs-hosting/src/grpc-protobuf-codegen/build/resources/main. skipping.
java.lang.NullPointerException
at org.reflections.vfs.Vfs$DefaultUrlTypes$3.matches(Vfs.java:239)
at org.reflections.vfs.Vfs.fromURL(Vfs.java:98)
at org.reflections.vfs.Vfs.fromURL(Vfs.java:91)
at org.reflections.Reflections.scan(Reflections.java:237)
at org.reflections.Reflections.scan(Reflections.java:204)
at org.reflections.Reflections.(Reflections.java:129)
at org.reflections.Reflections.(Reflections.java:170)
I use gradle generated classpath. By default it includes a number of entitied that does not exist. It's Ok for JVM, but makes org reflections spamming errors to logs

We are having the same problem. I would love to have an interface to handle such exceptions. Example:

ClasspathScanExceptionHandler {

     onScanError(ClasspathScanException e) throws CriticalClasspathScanException;

}

Reflections.setExceptionHandler(ClasspathScanExceptionHandler e);

Instead of printing the error the exception handler will be called. If this do not throw a critical exception the scan continues. Otherwise the scan will stop / fail and the Reflections.scan method throws a runtime exception.
I would love to provide a PR for this if you think that this is a good solution.
About the gradle problem: We only have this on some setups and I think that it is related to gradle / intelliJ since on some setups an empty "main" folder will be created a application start (by gradle or intelliJ) and on other system the "main" folder will not be created :( So the only think how this can be solved by reflections is a better exception handling.

Manually merged. Thanks!


[1ES Manage Images] base-images to 1es managed images

move base-images to 1es managed images using bicep

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

I started working on this and I created a draft pr with these changes: https://dev.azure.com/dnceng/internal/_git/dotnet-helix-machines/pullrequest/34409
I am unassigning this issue to me as I will not continue working on this issue, but I want to provide a quick summary of what is going on around this, the main question is if we are going to use bicep of arm template Json.
the advantages that I see for bicep are:

we can divide the definition of the resources into small bicep modules, which makes things a lot more organized, easy to read, understand and update as we can have a file per image
there are tools that makes easier to write templates using bicep, such as bicep extension for vs code
the bicep cli facilitates converting the bicep files to arm template Json if this is needed, so is not difficult to obtain the Json version
it is what 1ES is promoting to use

the advantages that have been observed for arm template Json are:

we know Json already, so there is not learning curve in this aspect
the azure resources show the arm template Json view so is going to be easier to compare and we are going to be more familiar with it if we keep use arm templates

this is something that probably need more discussion so I just wanted to summarize the discussion so far and I am letting my draft in case is used and to give an example of bicep

Thanks @AlitzelMendez, this is good groundwork. Even if we don't go with bicep, having them already written that way should even allow us to use the cli and just end up committing the json view instead.


Missing Generation IX Pokemons in graphql

I'm using graphql and in my query all pokemons only have up to 905. The next one is 1001 and it's a variation. Is that so, is the data still being entered or am I querying it wrong?
thank you!

I think we need to update the data there

I'll try

Hi, I updated the service and the data
I checked and data should be there :)

Hi, I updated the service and the data
I checked and data should be there :)

Yes, I saw it now and the data is there!
Thank you very much!!!!


Fix MSI version logic

Fixes the bug introduced via this PR.

API change check
API changes are not detected in this pull request.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2856

Questions ?
Please refer to the Backport tool documentation


ci: consolidate Windows test jobs

The Windows CI test jobs are now contained within one e2e-cli-win job. This removes the need to start up multiple jobs to initialize Windows as well as store and retrieve the saved workspace.
The parallelism is increased to 8 and the Windows test job is started earlier in the workflow to decrease the total time for the workflow.
This change also removes the partial double Windows testing currently present on release branches due to the previous test-win and e2e-cli-win jobs.
NOTE: This requires the removal of test-win from the required Github checks and the addition of e2e-cli-win.

Removed test-win, added e2e-cli-win to GitHub checks