Keeps rebooting in a loop

Hi when using this for RDS deployment on windows 2016 it enters an state of a reboot loop after i states "The deployment was successful" in an "xRDSessionDeployment". Then i hangs in that state, and never continues to the Collection or CollectionConfiguration???
Any ideas?
VERBOSE: Performing the operation "Start-DscConfiguration: SendMetaConfigurationApply" on target "MSFT_DSCLocalConfigurationManager".
VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = SendMetaConfigurationApply,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' = root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer 2016DSC02 with user sid S-1-5-21-662093251-837600086-2983080374-500.
VERBOSE: [2016DSC02]: LCM:  [ Start  Set      ]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [MSFT_DSCMetaConfiguration]
VERBOSE: [2016DSC02]: LCM:  [ Start  Set      ]  [MSFT_DSCMetaConfiguration]
VERBOSE: [2016DSC02]: LCM:  [ End    Set      ]  [MSFT_DSCMetaConfiguration]  in 0.0140 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [MSFT_DSCMetaConfiguration]
VERBOSE: [2016DSC02]: LCM:  [ End    Set      ]
VERBOSE: [2016DSC02]: LCM:  [ End    Set      ]    in  0.0420 seconds.
VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Set-DscLocalConfigurationManager finished in 0.274 seconds.
VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = TestConfiguration,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' = root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer 2016DSC02 with user sid S-1-5-21-662093251-837600086-2983080374-500.
VERBOSE: [2016DSC02]: LCM:  [ Start  Compare  ]
VERBOSE: [2016DSC02]:                            [DSCEngine] Importing the module C:\Windows\system32\WindowsPowerShell\v1.0\Modules\PSDesiredStateConfiguration\DscResources\MSFT_RoleResource\MSFT_RoleResource.psm1 in force mode.
VERBOSE: [2016DSC02]:                            [DSCEngine] Importing the module C:\Program Files\WindowsPowerShell\Modules\xRemoteDesktopSessionHost\<IP_ADDRESS>\DscResources\MSFT_xRDSessionDeployment\MSFT_xRDSessionDeployment.psm1 in force mode.
VERBOSE: [2016DSC02]:                            [DSCEngine] Importing the module C:\Program Files\WindowsPowerShell\Modules\xRemoteDesktopSessionHost\<IP_ADDRESS>\DscResources\MSFT_xRDSessionCollection\MSFT_xRDSessionCollection.psm1 in force mode.
VERBOSE: [2016DSC02]:                            [DSCEngine] Importing the module C:\Program Files\WindowsPowerShell\Modules\xRemoteDesktopSessionHost\<IP_ADDRESS>\DscResources\MSFT_xRDSessionCollectionConfiguration\MSFT_xRDSessionCollectionConfiguration.psm1 in force mode.
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[WindowsFeature]Remote-Desktop-Services]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[WindowsFeature]Remote-Desktop-Services]
VERBOSE: [2016DSC02]:                            [[WindowsFeature]Remote-Desktop-Services] Importing the module MSFT_RoleResource in force mode.
VERBOSE: [2016DSC02]:                            [[WindowsFeature]Remote-Desktop-Services] The operation 'Get-WindowsFeature' started: Remote-Desktop-Services
VERBOSE: [2016DSC02]:                            [[WindowsFeature]Remote-Desktop-Services] The operation 'Get-WindowsFeature' succeeded: Remote-Desktop-Services
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[WindowsFeature]Remote-Desktop-Services] True in 0.2600 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[WindowsFeature]Remote-Desktop-Services]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[WindowsFeature]RDS-RD-Server]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[WindowsFeature]RDS-RD-Server]
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-RD-Server] Importing the module MSFT_RoleResource in force mode.
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-RD-Server] The operation 'Get-WindowsFeature' started: RDS-RD-Server
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-RD-Server] The operation 'Get-WindowsFeature' succeeded: RDS-RD-Server
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[WindowsFeature]RDS-RD-Server] True in 0.2030 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[WindowsFeature]RDS-RD-Server]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[WindowsFeature]RSAT-RDS-Tools]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[WindowsFeature]RSAT-RDS-Tools]
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] Importing the module MSFT_RoleResource in force mode.
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' started: RSAT-RDS-Tools
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' succeeded: RSAT-RDS-Tools
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' started: RSAT-RDS-Gateway
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' succeeded: RSAT-RDS-Gateway
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' started: RSAT-RDS-Licensing-Diagnosis-UI
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' succeeded: RSAT-RDS-Licensing-Diagnosis-UI
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' started: RDS-Licensing-UI
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' succeeded: RDS-Licensing-UI
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[WindowsFeature]RSAT-RDS-Tools] True in 0.6660 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[WindowsFeature]RSAT-RDS-Tools]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[WindowsFeature]RDS-Connection-Broker]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[WindowsFeature]RDS-Connection-Broker]
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Connection-Broker] Importing the module MSFT_RoleResource in force mode.
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Connection-Broker] The operation 'Get-WindowsFeature' started: RDS-Connection-Broker
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Connection-Broker] The operation 'Get-WindowsFeature' succeeded: RDS-Connection-Broker
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[WindowsFeature]RDS-Connection-Broker] True in 0.2040 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[WindowsFeature]RDS-Connection-Broker]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[WindowsFeature]RDS-Web-Access]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[WindowsFeature]RDS-Web-Access]
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Web-Access] Importing the module MSFT_RoleResource in force mode.
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Web-Access] The operation 'Get-WindowsFeature' started: RDS-Web-Access
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Web-Access] The operation 'Get-WindowsFeature' succeeded: RDS-Web-Access
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[WindowsFeature]RDS-Web-Access] True in 0.2020 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[WindowsFeature]RDS-Web-Access]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[WindowsFeature]RDS-Licensing]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[WindowsFeature]RDS-Licensing]
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Licensing] Importing the module MSFT_RoleResource in force mode.
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Licensing] The operation 'Get-WindowsFeature' started: RDS-Licensing
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Licensing] The operation 'Get-WindowsFeature' succeeded: RDS-Licensing
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[WindowsFeature]RDS-Licensing] True in 0.2060 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[WindowsFeature]RDS-Licensing]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[xRDSessionDeployment]Deployment]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[xRDSessionDeployment]Deployment]
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Importing the module MSFT_xRDSessionDeployment in force mode.
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Importing the module MSFT_xRDSessionDeployment in force mode.
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Checking RDSH role is deployed on this node.
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Getting list of RD Server roles.
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[xRDSessionDeployment]Deployment] False in 1.2290 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[xRDSessionDeployment]Deployment]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[xRDSessionCollection]Collection]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[xRDSessionCollection]Collection]
VERBOSE: [2016DSC02]:                            [[xRDSessionCollection]Collection] Importing the module MSFT_xRDSessionCollection in force mode.
VERBOSE: [2016DSC02]:                            [[xRDSessionCollection]Collection] Importing the module MSFT_xRDSessionCollection in force mode.
VERBOSE: [2016DSC02]:                            [[xRDSessionCollection]Collection] Checking for existance of RDSH collection.
VERBOSE: [2016DSC02]:                            [[xRDSessionCollection]Collection] Getting information about RDSH collection.
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[xRDSessionCollection]Collection] False in 0.7110 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[xRDSessionCollection]Collection]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[xRDSessionCollectionConfiguration]CollectionConfiguration]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[xRDSessionCollectionConfiguration]CollectionConfiguration]
VERBOSE: [2016DSC02]:                            [[xRDSessionCollectionConfiguration]CollectionConfiguration] Importing the module MSFT_xRDSessionCollectionConfiguration in force mode.
VERBOSE: [2016DSC02]:                            [[xRDSessionCollectionConfiguration]CollectionConfiguration] Importing the module MSFT_xRDSessionCollectionConfiguration in force mode.
VERBOSE: [2016DSC02]:                            [[xRDSessionCollectionConfiguration]CollectionConfiguration] Testing DSC collection properties
VERBOSE: [2016DSC02]:                            [[xRDSessionCollectionConfiguration]CollectionConfiguration] Getting currently configured RDSH Collection properties
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[xRDSessionCollectionConfiguration]CollectionConfiguration] False in 2.9200 seconds.
VERBOSE: [2016DSC02]: LCM:  [ FAILEDCompare  ]     Completed processing compare operation. The operation returned False.
VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 7.443 seconds
VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = SendConfigurationApply,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' = root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer DESKTOP-DOOA2AM with user sid S-1-5-21-662093251-837600086-2983080374-500.
VERBOSE: [2016DSC02]: LCM:  [ Start  Set      ]
VERBOSE: [2016DSC02]:                            [DSCEngine] Importing the module C:\Windows\system32\WindowsPowerShell\v1.0\Modules\PSDesiredStateConfiguration\DscResources\MSFT_RoleResource\MSFT_RoleResource.psm1 in force mode.
VERBOSE: [2016DSC02]:                            [DSCEngine] Importing the module C:\Program Files\WindowsPowerShell\Modules\xRemoteDesktopSessionHost\<IP_ADDRESS>\DscResources\MSFT_xRDSessionDeployment\MSFT_xRDSessionDeployment.psm1 in force mode.
VERBOSE: [2016DSC02]:                            [DSCEngine] Importing the module C:\Program Files\WindowsPowerShell\Modules\xRemoteDesktopSessionHost\<IP_ADDRESS>\DscResources\MSFT_xRDSessionCollection\MSFT_xRDSessionCollection.psm1 in force mode.
VERBOSE: [2016DSC02]:                            [DSCEngine] Importing the module C:\Program Files\WindowsPowerShell\Modules\xRemoteDesktopSessionHost\<IP_ADDRESS>\DscResources\MSFT_xRDSessionCollectionConfiguration\MSFT_xRDSessionCollectionConfiguration.psm1 in force mode.
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[WindowsFeature]Remote-Desktop-Services]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[WindowsFeature]Remote-Desktop-Services]
VERBOSE: [2016DSC02]:                            [[WindowsFeature]Remote-Desktop-Services] Importing the module MSFT_RoleResource in force mode.
VERBOSE: [2016DSC02]:                            [[WindowsFeature]Remote-Desktop-Services] The operation 'Get-WindowsFeature' started: Remote-Desktop-Services
VERBOSE: [2016DSC02]:                            [[WindowsFeature]Remote-Desktop-Services] The operation 'Get-WindowsFeature' succeeded: Remote-Desktop-Services
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[WindowsFeature]Remote-Desktop-Services]  in 0.2080 seconds.
VERBOSE: [2016DSC02]: LCM:  [ Skip   Set      ]  [[WindowsFeature]Remote-Desktop-Services]
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[WindowsFeature]Remote-Desktop-Services]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[WindowsFeature]RDS-RD-Server]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[WindowsFeature]RDS-RD-Server]
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-RD-Server] Importing the module MSFT_RoleResource in force mode.
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-RD-Server] The operation 'Get-WindowsFeature' started: RDS-RD-Server
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-RD-Server] The operation 'Get-WindowsFeature' succeeded: RDS-RD-Server
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[WindowsFeature]RDS-RD-Server]  in 0.2100 seconds.
VERBOSE: [2016DSC02]: LCM:  [ Skip   Set      ]  [[WindowsFeature]RDS-RD-Server]
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[WindowsFeature]RDS-RD-Server]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[WindowsFeature]RSAT-RDS-Tools]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[WindowsFeature]RSAT-RDS-Tools]
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] Importing the module MSFT_RoleResource in force mode.
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' started: RSAT-RDS-Tools
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' succeeded: RSAT-RDS-Tools
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' started: RSAT-RDS-Gateway
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' succeeded: RSAT-RDS-Gateway
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' started: RSAT-RDS-Licensing-Diagnosis-UI
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' succeeded: RSAT-RDS-Licensing-Diagnosis-UI
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' started: RDS-Licensing-UI
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RSAT-RDS-Tools] The operation 'Get-WindowsFeature' succeeded: RDS-Licensing-UI
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[WindowsFeature]RSAT-RDS-Tools]  in 0.6780 seconds.
VERBOSE: [2016DSC02]: LCM:  [ Skip   Set      ]  [[WindowsFeature]RSAT-RDS-Tools]
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[WindowsFeature]RSAT-RDS-Tools]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[WindowsFeature]RDS-Connection-Broker]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[WindowsFeature]RDS-Connection-Broker]
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Connection-Broker] Importing the module MSFT_RoleResource in force mode.
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Connection-Broker] The operation 'Get-WindowsFeature' started: RDS-Connection-Broker
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Connection-Broker] The operation 'Get-WindowsFeature' succeeded: RDS-Connection-Broker
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[WindowsFeature]RDS-Connection-Broker]  in 0.2030 seconds.
VERBOSE: [2016DSC02]: LCM:  [ Skip   Set      ]  [[WindowsFeature]RDS-Connection-Broker]
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[WindowsFeature]RDS-Connection-Broker]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[WindowsFeature]RDS-Web-Access]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[WindowsFeature]RDS-Web-Access]
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Web-Access] Importing the module MSFT_RoleResource in force mode.
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Web-Access] The operation 'Get-WindowsFeature' started: RDS-Web-Access
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Web-Access] The operation 'Get-WindowsFeature' succeeded: RDS-Web-Access
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[WindowsFeature]RDS-Web-Access]  in 0.2060 seconds.
VERBOSE: [2016DSC02]: LCM:  [ Skip   Set      ]  [[WindowsFeature]RDS-Web-Access]
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[WindowsFeature]RDS-Web-Access]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[WindowsFeature]RDS-Licensing]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[WindowsFeature]RDS-Licensing]
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Licensing] Importing the module MSFT_RoleResource in force mode.
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Licensing] The operation 'Get-WindowsFeature' started: RDS-Licensing
VERBOSE: [2016DSC02]:                            [[WindowsFeature]RDS-Licensing] The operation 'Get-WindowsFeature' succeeded: RDS-Licensing
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[WindowsFeature]RDS-Licensing]  in 0.2060 seconds.
VERBOSE: [2016DSC02]: LCM:  [ Skip   Set      ]  [[WindowsFeature]RDS-Licensing]
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[WindowsFeature]RDS-Licensing]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[xRDSessionDeployment]Deployment]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[xRDSessionDeployment]Deployment]
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Importing the module MSFT_xRDSessionDeployment in force mode.
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Importing the module MSFT_xRDSessionDeployment in force mode.
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Checking RDSH role is deployed on this node.
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Getting list of RD Server roles.
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[xRDSessionDeployment]Deployment]  in 1.1990 seconds.
VERBOSE: [2016DSC02]: LCM:  [ Start  Set      ]  [[xRDSessionDeployment]Deployment]
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Importing the module MSFT_xRDSessionDeployment in force mode.
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Importing the module MSFT_xRDSessionDeployment in force mode.
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Initiating new RDSH deployment.
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] The deployment was successful.
VERBOSE: [2016DSC02]: LCM:  [ End    Set      ]  [[xRDSessionDeployment]Deployment]  in 44.9160 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[xRDSessionDeployment]Deployment]
VERBOSE: [2016DSC02]:                            [] A reboot is scheduled to progress further. Configuration will be continued after the reboot.
WARNING: [2016DSC02]:                            [] A reboot is scheduled to progress further. Configuration will be continued after the reboot.
VERBOSE: [2016DSC02]: LCM:  [ End    Set      ]
VERBOSE: [2016DSC02]: LCM:  [ End    Set      ]    in  48.4900 seconds.
VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 48.816 seconds

@SimonRousingBerg Could you share your configuration script so we can analyze this a bit better.
The message given by xRDSessionDeployment is that the computer has a pending reboot. It could be something external to your configuration. I would suggest inspecting the registry keys on this node that deal with pending reboot logic.

HKLM:\Software\Microsoft\Windows\CurrentVersion\Component Based Servicing\RebootPending
HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Auto Update\RebootRequired
HKLM:\SYSTEM\CurrentControlSet\Control\Session Manager\PendingFileRenameOperations

Especially the last one can have lingering stuff in my experience and could need some manual cleaning.
You could also introduce the xPendingReboot resource in your configuration and have the xRDSessionDeployment take a dependency on it.

Hi bgelens
Sure.
It keeps rebooting before reaching the xRDSessionCollection Collection
If i stop my powershell script and then start it again, then when it runs my configuration again its completing without any reboot... ???
#region Remote Desktop Session Host Config
#region Remote Desktop Session Host ConfigData
$ConfigData_RemoteDesktopSessionHost = @{
AllNodes = @(
@{
NodeName = $RemoteServerIPAddress
ComputerNameFQDN = "$($RemoteServerName).$($DomainFQDN)"
ConnectionBrokerFQDN = $RDConnectionBrokerFQDN
WebAccessServerFQDN = $RDWebAccessServerFQDN
CollectionName = $RDCollectionName
Credential = $DomainAdminCredentials
PSDscAllowPlainTextPassword = $true
PSDscAllowDomainUser = $true
}
)
}
#endregion
    Configuration RemoteDesktopSessionHost
    {
        Import-DscResource -ModuleName PSDesiredStateConfiguration, xRemoteDesktopSessionHost

        Node $AllNodes.NodeName
        {
            LocalConfigurationManager {
                RebootNodeIfNeeded = $true
            }

            WindowsFeature Remote-Desktop-Services
            {
                Ensure = "Present"
                Name = "Remote-Desktop-Services"
            }

            WindowsFeature RDS-RD-Server
            {
                Ensure = "Present"
                Name = "RDS-RD-Server"
            }

            WindowsFeature RSAT-RDS-Tools
            {
                Ensure = "Present"
                Name = "RSAT-RDS-Tools"
                IncludeAllSubFeature = $true
            }

            If($Node.ComputerNameFQDN -ieq $Node.ConnectionBrokerFQDN)
            {
                WindowsFeature RDS-Connection-Broker
                {
                    Ensure = "Present"
                    Name = "RDS-Connection-Broker"
                }
            }

            If($Node.ComputerNameFQDN -ieq $Node.WebAccessServerFQDN)
            {
                WindowsFeature RDS-Web-Access
                {
                    Ensure = "Present"
                    Name = "RDS-Web-Access"
                }
            }

            If($Node.ComputerNameFQDN -ieq $Node.ConnectionBrokerFQDN)
            {
                WindowsFeature RDS-Licensing
                {
                    Ensure = "Present"
                    Name = "RDS-Licensing"
                }
            }

            xRDSessionDeployment Deployment
            {
                SessionHost = $Node.ComputerNameFQDN
                ConnectionBroker = $Node.ConnectionBrokerFQDN
                WebAccessServer = $Node.WebAccessServerFQDN
                PsDscRunAsCredential = $Node.Credential
                DependsOn = "[WindowsFeature]Remote-Desktop-Services", "[WindowsFeature]RDS-RD-Server"
            }

            xRDSessionCollection Collection
            {
                CollectionName = $Node.CollectionName
                CollectionDescription = "RDS Collection deployed $((Get-Date).ToString())"
                SessionHost = $Node.ComputerNameFQDN
                ConnectionBroker = $Node.ConnectionBrokerFQDN
                PsDscRunAsCredential = $Node.Credential
                DependsOn = "[xRDSessionDeployment]Deployment"
            }
            xRDSessionCollectionConfiguration CollectionConfiguration
            {
                CollectionName = $Node.CollectionName
                ConnectionBroker = $Node.ConnectionBrokerFQDN
                TemporaryFoldersDeletedOnExit = $true
                SecurityLayer = "SSL"
                PsDscRunAsCredential = $Node.Credential
                DependsOn = "[xRDSessionCollection]Collection"
            }
        }
    }

    RemoteDesktopSessionHost -ConfigurationData $ConfigData_RemoteDesktopSessionHost -OutputPath $MOF_Step4_InstallRemoteDesktopServices
    Set-DscLocalConfigurationManager -Path $MOF_Step4_InstallRemoteDesktopServices -CimSession $CIMSession -Force -Verbose

    While((Test-DscConfiguration -Path $MOF_Step4_InstallRemoteDesktopServices -CimSession $CIMSession -Verbose -ErrorAction SilentlyContinue).InDesiredState -ne $true)
    {
        Start-DscConfiguration -ComputerName $RemoteServerIPAddress -Path $MOF_Step4_InstallRemoteDesktopServices -Credential $RemoteServerCreds -Force -Verbose -Wait
        Start-Sleep -Seconds 30

        Get-DscConfigurationStatus -CimSession $CIMSession -Verbose
        Start-Sleep -Seconds 5
    }

    Get-DscConfigurationStatus -CimSession $CIMSession -Verbose -ErrorAction SilentlyContinue
#endregion

VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[xRDSessionDeployment]Deployment]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[xRDSessionDeployment]Deployment]
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Checking RDSH role is deployed on this node.
VERBOSE: [2016DSC02]:                            [[xRDSessionDeployment]Deployment] Getting list of RD Server roles.
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[xRDSessionDeployment]Deployment] True in 1.8140 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[xRDSessionDeployment]Deployment]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[xRDSessionCollection]Collection]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[xRDSessionCollection]Collection]
VERBOSE: [2016DSC02]:                            [[xRDSessionCollection]Collection] Checking for existance of RDSH collection.
VERBOSE: [2016DSC02]:                            [[xRDSessionCollection]Collection] Getting information about RDSH collection.
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[xRDSessionCollection]Collection] True in 0.9660 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[xRDSessionCollection]Collection]
VERBOSE: [2016DSC02]: LCM:  [ Start  Resource ]  [[xRDSessionCollectionConfiguration]CollectionConfiguration]
VERBOSE: [2016DSC02]: LCM:  [ Start  Test     ]  [[xRDSessionCollectionConfiguration]CollectionConfiguration]
VERBOSE: [2016DSC02]:                            [[xRDSessionCollectionConfiguration]CollectionConfiguration] Testing DSC collection properties
VERBOSE: [2016DSC02]:                            [[xRDSessionCollectionConfiguration]CollectionConfiguration] Getting currently configured RDSH Collection properties
VERBOSE: [2016DSC02]: LCM:  [ End    Test     ]  [[xRDSessionCollectionConfiguration]CollectionConfiguration] True in 6.4750 seconds.
VERBOSE: [2016DSC02]: LCM:  [ End    Resource ]  [[xRDSessionCollectionConfiguration]CollectionConfiguration]
VERBOSE: [2016DSC02]: LCM:  [ End    Compare  ]     Completed processing compare operation. The operation returned True.
VERBOSE: [2016DSC02]: LCM:  [ End    Compare  ]    in  11.2380 seconds.
VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 11.474 seconds
VERBOSE: <IP_ADDRESS>: An LCM method call arrived from computer 2016DSC02 with user sid S-1-5-21-662093251-837600086-2983080374-500.
DurationInSeconds          : 14
Error                      :
HostName                   : 2016DSC02
IPV4Addresses              : {<IP_ADDRESS>, <IP_ADDRESS>}
IPV6Addresses              : {fe80::9cc1:7165:bc68:8abb%6, ::2000:0:0:0, ::1, ::2000:0:0:0}
JobID                      : {2A77E825-5532-11E7-AB4E-005056893AF8}
LCMVersion                 : 2.0
Locale                     : da-DK
MACAddresses               : {00-50-56-89-3A-F8, 00-00-00-00-00-00-00-E0}
MetaConfiguration          : MSFT_DSCMetaConfiguration
MetaData                   : Author: Simon; Name: RemoteDesktopSessionHost; Version: 2.0.0; GenerationDate: 06/19/2017 22:59:07; GenerationHost: DESKTOP-DOOA2AM;
Mode                       : PUSH
NumberOfResources          : 9
RebootRequested            : False
ResourcesInDesiredState    : {[WindowsFeature]Remote-Desktop-Services, [WindowsFeature]RDS-RD-Server, [WindowsFeature]RSAT-RDS-Tools, [WindowsFeature]RDS-Connection-Broker...}
ResourcesNotInDesiredState :
StartDate                  : 19-06-2017 22:59:21
Status                     : Success
Type                       : Initial
PSComputerName             : <IP_ADDRESS>
VERBOSE: <IP_ADDRESS>: [2016DSC02]: LCM:  [ End    GetStatus]    in  0.0180 seconds.

When using Get-DscLocalConfigurationManager it keeps saying it has an PendingConfiguration

Sorry I didn't respond earlier.. Very busy with normal day job :)
If it is still PendingConfiguration, it means that the desired state was never achieved.
Just to exclude a couple of things, could you try preparing all nodes by installing roles and features separately , run windows update until fully patched, have all of them rebooted as many times as needed and than try to send the config to the nodes.
From my experience with this module is that you're chasing your own tail more than you want to. Especially if nodes are capable of internet connectivity.
See my video on these resources from PSConfEU where I'm battling this behavior by accident.
Let me know if this gets you anywhere!

Hi I know the feeling :)
I made it work in an simple use case.
I specified the same server as Session Host, Web Access Server and Connection Broker.
Then i researched the use of the New-RDSessionDeployment cmdlet, wich i can see is used in the Set-TargetResource in the "Deployment" resource.
Because what i did not post in this thread, is that in my initial Configuration i specified other servers for the specific roles like this. By the way the configuration was applied to Server1.
$ConfigData_RemoteDesktopSessionHost = @{
AllNodes = @(
@{
NodeName = $RemoteServerIPAddress
ComputerNameFQDN = Server2
ConnectionBrokerFQDN = Server1
CollectionName = Server1
Credential = $DomainAdminCredentials
PSDscAllowPlainTextPassword = $true
PSDscAllowDomainUser = $true
}
)
}
But research tells me that, when running the New-RDSessionDeployment cmdlet, you must run it on the server you specify as the Connection Broker !
So I made som changes and know I am applying the configuration to Server1.
BUT, think i found a bug in this DSC resource, because when applying it know, i fails during the [[xRDSessionCollectionConfiguration]CollectionConfiguration] Testing DSC collection properties
I believe the bug is in line 39, 101 and 140 caused by this code.
$collectionName = Get-RDSessionCollection | % {Get-RDSessionHost $_.CollectionName} | ? {$_.SessionHost -ieq $localhost} | % {$_.CollectionName}
The $localhost contains the name of Server1 which in this case only has the Connection Broker and Web Access Server roles installed.
In the xRDSessionCollection there is only this line of code when getting the RDSessionCollection data.
$Collection = Get-RDSessionCollection -ErrorAction SilentlyContinue
Does this make any sense to who ever made this DSC Resource?
/Best regards Simon

I've just made the change in the resource and then its working :)
Is this on purpose or do I might have misinterpreted the use of this DSC Resource?

The resource assumes it is running on the Connectionbroker and that the Connectionbroker is also a Sessionhost. Not sure why this where is in place. This is IMO a flaw in the design. Great you got it working! I will put my attention on this Repo some more in a little while (working through a lot of backlog on a couple  of other modules with more open PRs / issues first)

+1 on this.
On a fresh install from original 2016 RTM media and after applying 09/2017 cumulative updates, this resource doesn't seem to be working properly at all.
I tried doing a deployment with this resource with everything being installed on the same server and running the configuration locally. It fails to set up the connection broker role properly and the server ends up in a reboot loop and never finishes configuration.
If you can get PowerShell open between reboots and Stop-DscConfiguration, you can clearly see it's stuck on the collection configuration.

Looking at this issue, I think this was fixed here:
https://github.com/PowerShell/xRemoteDesktopSessionHost/commit/316e32f923592e523c918a209b9e85f23eea67bf#diff-2b5b10bd6b3aeef410e8864fd2569cc9R184
When modifying the code I had the same issue as @SimonRousingBerg, so fixed it by just doing a lookup of the collection, the whole logic before did not make any sense to me.
@johlju, I think it's ok to close this one.

Closing this as per previous comment. If this was closed in error then please reopen or comment on this issue.


Clarify and unify docs

Hey folks, I've been getting more familiar with the lib lately and I think that the docs are one of Ramda's most valuable assets. For the most part they're very clear, but at parts they get a bit technical (which is fine, but the technical points should accompany simpler explanations).
In particular I've found several examples which would be much clearer if they used slightly different input. There are also several examples that require knowledge of advanced concepts which shouldn't be a requirement to learn that particular function.
To remedy some of this, I've been going through the docs one at a time and have been trying to clarify the docs wherever possible. As I go I'm also adding parameter annotations where they're missing and have been standardizing a few things like capitalization, etc.
Each example is open for debate, I've done each doc as a separate commit for easy editing/exclusion, but once I've finished I'll squash it down. I'm still adding on (I'm going through alphabetically) but feel free to comment along the way.

Thanks, this looks mostly very good to me, subject to a few small notes

More edits coming, I'm going to try to get through the whole set of docs. Would you prefer for me to make multiple small PRs as I go or to pack it up into this PR as a large changeset?

I'm going to try to get through the whole set of docs. Would you prefer for me to make multiple small PRs as I go or to pack it up into this PR as a large changeset?

I think a middle path may be best; batch 'em up into medium-sized chunks, more or less as you have done here. Then we won't hold up everything because of a typo here or there; but we won't have a zillion pr's to handle either

Okay, I addressed the feedback and rebased, should be good to go @buzzdecafe

LGTM.  Anyone else want to chime in before this is merged?

I'll take the silence as an all clear?

i think so, thanks for the ping


Get basic form comm_pref form working, need to handle mandatory fields still

Coverage decreased (-0.3%) to 92.156% when pulling 6434fb5fcd9d5c79cadc85ee475087258e70da1b on comm-prefs-settings-page into fc1c3a5495cd4e7182b1bc3f8c67cf320c241c06 on master.

Coverage decreased (-0.3%) to 92.185% when pulling<PHONE_NUMBER>a32dbd3cc08cec00549e39d89b53bc on comm-prefs-settings-page into fc1c3a5495cd4e7182b1bc3f8c67cf320c241c06 on master.

Coverage decreased (-0.3%) to 92.185% when pulling<PHONE_NUMBER>a32dbd3cc08cec00549e39d89b53bc on comm-prefs-settings-page into fc1c3a5495cd4e7182b1bc3f8c67cf320c241c06 on master.

Coverage decreased (-0.3%) to 92.239% when pulling 83044ebb426ebc065b3d662ca3cb1508f1efe1bf on comm-prefs-settings-page into fc1c3a5495cd4e7182b1bc3f8c67cf320c241c06 on master.

UX: description of each communication type

UX: no bullet point

@marcua where do you suggest to store the descriptions? The should we put it in the model with the ChoicesEnum? is there a way for the enum to support tuples?

Coverage decreased (-0.3%) to 92.185% when pulling 131f8ec533cf62c59bb42b16831d3da39c05abe4 on comm-prefs-settings-page into fc1c3a5495cd4e7182b1bc3f8c67cf320c241c06 on master.

Coverage decreased (-0.3%) to 92.185% when pulling bbe1c80524e361134303f680aafd8cef77820ca8 on comm-prefs-settings-page into fc1c3a5495cd4e7182b1bc3f8c67cf320c241c06 on master.

This is something like what @meredithblumenstock suggested.  She mentioned making the active tab white, but I think it's OK to ask her about this in the morning and merge it sooner after you do these changes.

Description text can be:
When a task status changes (e.g., moved from in review to returned from reviewer), you will automatically be alerted in a project slack group.  You can optionally receive email alerts.

lgtm aside from the UX changes

will discuss further UX changes with @meredithblumenstock

Coverage decreased (-0.3%) to 92.225% when pulling 756cdd6a0d8e59539ceadd7fcda2307e57b01c6d on comm-prefs-settings-page into e11c4bd60f816467fdd76c7215fbe4a233505a36 on master.

Coverage decreased (-0.3%) to 92.218% when pulling 247f59da4a4e6c630ee3c3cbe6ab52a7b7264c6a on comm-prefs-settings-page into e11c4bd60f816467fdd76c7215fbe4a233505a36 on master.


not seeing my client.chat_postMessage messages

I sent message to a thread using the code below:
Code:
client.chat_postMessage(channel=slack_user_id, thread_ts=thread_id, text=message, blocks=blocks)
where slack_user_id was my slack user, thread_id was my ts and the block  was None, the message was a string

I got no error but  it not sent to slack.

I also tried using this: client.chat_postMessage(channel=slack_user_id, text = message)

I still go no error nor  was it sent to my slack dm

Please what did I do wrong

Hi @suavelad, thanks for asking the question. Perhaps, any of the parameters you passed might be wrong. Please try your parameters using the API tester page and see how it goes: https://api.slack.com/methods/chat.postMessage/test I don't think this is a Python SDK specific one.


Minor fix to osdctl unarchiving

Minor bugfix to the osdctl tooling logic allowing the downloaded tarballs to be unarchived

/lgtm


[Question] Could You Provide More Details About Pixel Controller?

Hi, the authers, thanks for sharing this great work!
I have some questions about the Pixel Controller.
As you mentioned in the paper, the pixel controller is responsible for integrating the fine-grained object appearance, the image latent of the reference image (named "ip_img" in your code) is introduced by concatenating it with other view images along the "batch" dimension. To the best of my knowledge, the new added "batch item" still need "noise" to achieve mse loss. Could you give more explanation about how to train this pixel controller module?
I will be very grateful for your. Looking forward to your reply!

I am curious about it, also. Unlike Wonder3D and MVDream that leverages multi-view attention without an explicit reference image latent, this pixel controller does need an appropriate process about the predicted noise over ref img latent during training.

It is very simple, We may just ignored the loss over the last frame.


removed escape function from getBoundValue

fixes Call to undefined method Propaganistas\LaravelTranslatableBootForms\Form\FormBuilder::escape() error after adamwathan/form release v.0.8.13

Thanks for reporting!

Unfortunately still having issues with letters like ÇĞİŞÖÜ as they are not converted with html_entities anymore...

@jnbn This should be fixed in adamwathan/form as they removed the html_entities() call in the last update.


Force Feedback Support?

Have you checked the GP2040-CE documentation HERE to confirm this feature doesn't already exist?
Yes
Which problem is this feature request solving?
I would like to build a racing wheel using this project which supports force feedback. Incidentally I am building this with my open source brushless motor controller: https://github.com/Twisted-Fields/rp2040-motor-controller
Describe the solution you would like to see
I would like to be able to define a force feedback device with this project for a racing wheel, joystick, or other FFB device (not just rumble).
Describe alternatives you've considered
I cannot find any RP2040 library which supports FFB.
Can you submit a pull request?
It seems tricky to code this, but I can certainly submit a PR if I get some help writing the code.
Are you planning on working on this feature yourself?
Ideally no, but perhaps I can find some time. I need guidance though.

Here is an arduino library with force feedback support. I currently am not sure I have the time to learn enough about this stuff to do a proper integration, but perhaps it is helpful for someone:
https://github.com/sgtnoodle/ArduinoJoystickWithFFBLibrary

Hi @tlalexander ,
Currently we don't have anyone focused on force feedback / wheel implementation but that may change in the future if someone joins that wants to work on it or we get a PR for it.
I will leave this open for now.

Hi @tlalexander ,
We spoke about this again internally and do not believe this will be in our roadmap anytime soon.  We will be closing this as not currently planned however anyone is free to work on it if they choose and submit a PR


Drawing Energy levels

It's not a issue, rather it's a question. Is it possible to plot energy levels like the figure given below for different potentials like harmonic, square well, wood ?

Can you add few examples on this if it's possible?

Hi, thank you for opening an issue on ShellModel.jl

Is it possible to plot energy levels like the figure given below for different potentials like harmonic, square well, Woods-Saxon?
The answer is yes. I would like to clarify your question a bit more.
Do you need functions to calculate one-body potentials under arbitrary parameters (e.g. LS-splitting or Woods-Saxon diffuseness parameter), and to plot them?

If so, I will consider to implement it.
Actually, visualization codes (for energy spectrum, EM transitions, etc.) is one of the many TODOs 😄

Yes... Actually I was writing an article for my college project and there I have to analyse the LS splitting or energy levels for different potentials and to show the formation of magic numbers. But can't find any proper tool to do so. So I was wondering if we can do that using shell.jl😅... It will be really helpful

I see.
Finding one-body potentials is much simpler than what is done in ShellModel.jl, i.e., solving many-body eigenvalue problems etc.
You can find a much simpler codes to solve e.g. WS potentials https://github.com/search?q=Woods-saxon, and detailed information on these from Lecture note by B.Alex Brown @MSU
👍


Add personalization_storage setting

Hi, thanks for your template! I added this new setting. Note that there are also two other settings that are compatible with the Tag Consent Mode but I haven't added them because they're de facto useless (security and functionality are considered necessary so don't need consent)

@sahava  would you consider merging this? Would be helpful for us as well.

Updated in 6c8e7d03790f449a45e58ef97e5efd51dc8b9b29


node/npm command not found after quitting terminal (El Capitan)

Hello,
When using nvm to install node in OS X El Capitan, node/npm errors with a "command not found" after quitting the terminal. In order to be able to use node/nvm after quitting and launching the terminal you must issue the "nvm use " command each time.
NVM itself works fine when launching the terminal (from both .profile as well as .bash_profile), so I'm not sure why the above issue is happening -- unless the nvm use command attempts to create symlinks in /usr/bin which is no longer accessible in El Capitan, but I doubt it's that since there's no sudo requirement.
Also, this issue is new with El Capitan, never had any such trouble with Yosemite or earlier.

@cjhmdm By default, this is how nvm works. If you want a node version to be used automatically, do nvm alias default 5 or nvm alias default node etc. I'm not sure why an OS upgrade would change this behavior, though.
Can you try setting a default alias and let me know if that fixes your problem?

@Ijarb setting the default resolves the issue. Oddly enough, I don't recall having to do this before, but al the same, the stars have aligned and all is right again.
Thanks for the info

Thanks for confirming!


How to specify account when running tests

I have been trying to make tests on Crusher, a slurm cluster but running into an error that it is missing my slurm Account info. Typically srun takes a command line argument with -A to set Account but I am not sure where psij is supposed to get that info from. As a best guess, I added my account info to test.conf as custom_attributes = "slurm.account": "myaccname"  and reran make tests but it did not change the outcome. The error message is as follows:
E           psij.exceptions.SubmitException: sbatch: error: 2 ERRORS FOUND:
E           sbatch: error:
E           sbatch: error: You must specify an account with the -A flag. Valid accounts are:

Any suggestions how I should tell tests about my slurm Account?

Sorry for the delay. What you are doing should work. I  will try to work on figuring out what is going on.

Wait, sorry, I didn't carefully read your post.
make tests invokes pytest. It does not use testing.conf. That's for the automated/ci tests.
You have two options. Run tests directly, like you are doing. Unfortunately, make is funny about processing command line arguments, so you'll have to do it like this:
 PYTHONPATH=${CWD}/src:${CWD}/tests/plugins1:${PWD}/tests/plugins2:${PYTHONPATH} python3 -m pytest -v --custom-attributes='"slurm.account":"myaccname"'
(pay close attention to the single and double quotes above).
The easier option is to invoke ./psij-ci-run. That will pick up things in testing.conf.

@ketancmaheshwari Did this work for you?

Yes, closing.


Update Rust version in Dockerfile

Description of changes:
Update Rust version in Dockerfile and add a comment to warn people to keep the Rust version in sync.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This has been done 👍🏻


feat(icons): add whatsapp icon

@guastallaigor This is too pixelated. can we do better? It doesn't feel right 🙏

@evexoio Not sure what to do.. I grab the idea from here. But I will think of something or do some research on it.

@guastallaigor I think that one you linked works a little better because the phone handle is thicker and the circle seems more smoothed out, specifically the top right corner. Any reason we can't just use that design?

@guastallaigor I think that one you linked works a little better because the phone handle is thicker and the circle seems more smoothed out, specifically the top right corner. Any reason we can't just use that design?

None, I just didn't want to make a copy :smile: but that's fine I will do it.

Now I think it looks like the image I provided:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Migrated] ResourceNotFoundException: An error occurred (ResourceNotFoundException) when calling the DescribeLogStreams

Originally from: https://github.com/Miserlou/Zappa/issues/1652 by 4lph4-Ph4un
When attempting to tail logs on dev the tailing is succesfull, however tailing environment on another account fails with:
Traceback (most recent call last):
  File "/opt/kidday/env/lib/python3.6/site-packages/zappa/cli.py", line 2693, in handle
    sys.exit(cli.handle())
  File "/opt/kidday/env/lib/python3.6/site-packages/zappa/cli.py", line 504, in handle
    self.dispatch_command(self.command, stage)
  File "/opt/kidday/env/lib/python3.6/site-packages/zappa/cli.py", line 595, in dispatch_command
    force_colorize=self.vargs['force_color'] or None,
  File "/opt/kidday/env/lib/python3.6/site-packages/zappa/cli.py", line 1064, in tail
    filter_pattern=filter_pattern,
  File "/opt/kidday/env/lib/python3.6/site-packages/zappa/core.py", line 2745, in fetch_logs
    orderBy='LastEventTime'
  File "/opt/kidday/env/lib/python3.6/site-packages/botocore/client.py", line 320, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/opt/kidday/env/lib/python3.6/site-packages/botocore/client.py", line 623, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.errorfactory.ResourceNotFoundException: An error occurred (ResourceNotFoundException) when calling the DescribeLogStreams operation: The specified log group does not exist.

Checking the deployment with status (zappa status prod) yields:
No Lambda src-prod detected in eu-west-1 - have you deployed yet?
Although the deployment has been succesful and the Lambda name can be found on AWS console itself.
Possible Fix
Send in jneves! :D

I had this same issue. For me, my Lambda's role did not have the AWSLambdaBasicExecutionRole policy attached. Zappa needs permission to create the log group. After attaching the policy, I did a zappa update my-env and all was resolved.


[live] parentchain sync stopped with BadParentchainBlock

Incognitee testnet 0.12.7-dev2
primary validateer
2023-12-19T07:40:05Z ERROR enclave_runtime::error] Returning error Consensus(VerificationError(BadParentchainBlock(0x2cb47b699c099190e28ee3c41336a3a8221241373860e07f569699258094407c, "Invalid parentchain head"))) as sgx unexpected.
full log of SCV1 (running alone now)
sidechain-rococo-1-0-0-bad-parentchain-block.log

no recovery by waiting:
parentchain HEAD is at 3,719,767
[2023-12-21T07:23:24Z INFO  aura] Claiming slot<PHONE_NUMBER>)
[2023-12-21T07:23:24Z INFO  its_consensus_slots] Proposing sidechain block (number: 144158, hash: 0x0786…0f95) based on integritee parentchain block (number: 3703792, hash: 0x2cb47b699c099190e28ee3c41336a3a8221241373860e07f569699258094407c)
[2023-12-21T07:23:24Z INFO  integritee_service::ocall_bridge::sidechain_ocall] Enclave produced sidechain blocks: [144158]
[2023-12-21T07:23:24Z INFO  its_rpc_handler::import_block_api] Add block 144158 to import queue
[2023-12-21T07:23:25Z INFO  its_consensus_common::peer_block_sync] Successfully imported broadcast sidechain block (number: 144158, author: 0xa26ad684039c978b68957f3f42ac0d9dadd6ba5b132d30c9b14b87eea0677fa8), based on parentchain block 3703792
[2023-12-21T07:23:26Z INFO  aura] Claiming slot<PHONE_NUMBER>)
[2023-12-21T07:23:26Z INFO  its_consensus_slots] Proposing sidechain block (number: 144159, hash: 0x0cbb…afeb) based on integritee parentchain block (number: 3703792, hash: 0x2cb47b699c099190e28ee3c41336a3a8221241373860e07f569699258094407c)
[2023-12-21T07:23:26Z INFO  integritee_service::ocall_bridge::sidechain_ocall] Enclave produced sidechain blocks: [144159]
[2023-12-21T07:23:26Z INFO  its_rpc_handler::import_block_api] Add block 144159 to import queue
....
[2023-12-21T07:23:34Z INFO  aura] Claiming slot<PHONE_NUMBER>)
[2023-12-21T07:23:34Z ERROR itc_parentchain_light_client::light_validation] header ancestry mismatch! last imported was block nr 3703792 with hash 0x2cb47b699c099190e28ee3c41336a3a8221241373860e07f569699258094407c, attempting to import nr 3719714 with hash 0x02a3f2549ceb9e6914a8f3b2f05c7717db7477d708844eb1f813f3249409b757 and ancestor 0xd1c101d406196d1fd559744e579d68f071798dd345f20bc39df8ff368764c285
[2023-12-21T07:23:34Z ERROR itc_parentchain_block_importer::block_importer] [Integritee] Header submission to light client failed for block number 3719714 and hash 0x02a3f2549ceb9e6914a8f3b2f05c7717db7477d708844eb1f813f3249409b757: HeaderAncestryMismatch
[2023-12-21T07:23:34Z INFO  integritee_service::ocall_bridge::sidechain_ocall] Enclave produced sidechain blocks: [144163]
[2023-12-21T07:23:35Z ERROR its_block_verification] Author verification for block (number: 144163) failed, block will be discarded
[2023-12-21T07:23:35Z ERROR enclave_runtime::error] Returning error Consensus(VerificationError(BadParentchainBlock(0x2cb47b699c099190e28ee3c41336a3a8221241373860e07f569699258094407c, "Invalid parentchain head"))) as sgx unexpected.
[2023-12-21T07:23:35Z ERROR integritee_service::sidechain_setup] Sgx(SGX_ERROR_UNEXPECTED)

after restarting the service with v0.12.7-dev3:
sidechain-rococo-1-0-0-bad-parentchain-block-after-restart.log
the startup has issues

good: the worker starts syncing correctly
a huge amount of parentchain confirmations is sent:https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frococo.api.integritee.network#/explorer/query/0x8e9904cf6fb9452d7e932c674cf3cb2e5ca3ae725e830dfcf258f1c3caf68cb4

(can't always send confirmation extrinsics):
[2023-12-21T08:03:38Z DEBUG integritee_service::ocall_bridge::worker_on_chain_ocall] Enclave wants to send 1000 extrinsics to parentchain: Integritee. await each inclusion: false
[2023-12-21T08:03:39Z INFO  integritee_service::parentchain_handler] [Integritee] Synced 3714792 out of 3719851 finalized parentchain blocks
[2023-12-21T08:03:41Z INFO  integritee_service::parentchain_handler] [Integritee] Found 1000 block(s) to sync in this chunk. immediate import=true
[2023-12-21T08:03:41Z INFO  integritee_service::parentchain_handler] [Integritee] Found 1000 event vector(s) to sync in this chunk
[2023-12-21T08:03:42Z INFO  enclave_runtime] Validating events, events_proofs_length: 1000, blocks_merkle_roots_lengths: 1000
[2023-12-21T08:03:42Z TRACE enclave_runtime] [Integritee] Dispatching Import of 1000 blocks and 1000 events
[2023-12-21T08:03:53Z DEBUG integritee_service::ocall_bridge::bridge_api] Requesting WorkerOnChain OCall API instance
[2023-12-21T08:03:53Z DEBUG integritee_service::ocall_bridge::worker_on_chain_ocall] Enclave wants to send 1000 extrinsics to parentchain: Integritee. await each inclusion: false
[2023-12-21T08:03:54Z ERROR integritee_service::ocall_bridge::worker_on_chain_ocall] Could not send extrinsic to Integritee: Ok("\"0x3d038400a26ad684039c978b68957f3f42ac0d9dadd6ba5b132d30c9b14b87eea0677fa800bb034c2fe7ffe757f42773e4ec6599f3be7ec257f759ad86b5936868704dc132ad8f552220eeab5ba7ad04f4a17a9d30b92090bd6a4946fba4d46880918fc60a0072790400003601496e636f676e69746565546573746e6574303030303030303030303030303031792f51eb1af181245baf34e24d61ea46cdd5ee3ba530bbee64828366534b401e9eb138000000000000000000000000000000000000000000000000000000000000000000\""), error: RpcClient(SerdeJson(Error("invalid type: null, expected a (both 0x-prefixed or not) hex string or byte array containing 32 bytes", line: 1, column: 4)))

one problem was #1548: WrongFingerprintForShard
after updating the ShardConfig:

no sidechain blocks confirmed on L1
no "claiming slot" in the log. strange

sidechain block production seems to continue
Syncing Parentchains: Integritee: 3719935 TargetA: None, TargetB: None, Sidechain: 145545
Syncing Parentchains: Integritee: 3719936 TargetA: None, TargetB: None, Sidechain: 145551

had to restart again and now all works as expected again. therefore, this issue can be worked around by simply restarting the service.
It will create downtime, however. and I didn't check for inconsistencies. (don't expect any)


limitToFilter() handles Infinity incorrectly

If the limit argument is Infinity, it's parsed to NaN by int()
limit should remain Infinity

I think a better solution for this issue would be using array's length instead of Infinity.
Example: I wanted to show a paginated table with a search input and when input's value is different from '' pagination should be disabled so that it can show all filtered items in the same view.

...


How to use snappy-java with Android?

I've the following string added to my build.gradle
compile 'org.xerial.snappy:snappy-java:1.1.4-M3'

but whenever I try to run my application it it fails with
org.xerial.snappy.SnappyError: [FAILED_TO_LOAD_NATIVE_LIBRARY] no native library

I'm using Android studio with the Android NDK installed.

我也想把它用到android上，同样提示找不到本地库，不知道怎么搞才好

@spaghetti- snappy-1.1.4-M3 should show an error message like:
[FAILED_TO_LOAD_NATIVE_LIBRARY] no native library is found for os.name=xxx and os.arch=xxx

It seems another version of snappy-java is contained in your classpath.

@xerial I use snappy-java-1.1.4 in android and it also fails with
org.xerial.snappy.SnappyError: [FAILED_TO_LOAD_NATIVE_LIBRARY] no native library is found for os.name=Linux and os.arch=aarch64
   at org.xerial.snappy.SnappyLoader.findNativeLibrary(SnappyLoader.java:342)
   at org.xerial.snappy.SnappyLoader.loadNativeLibrary(SnappyLoader.java:176)
   at org.xerial.snappy.SnappyLoader.loadSnappyApi(SnappyLoader.java:154)
   at org.xerial.snappy.Snappy.<clinit>(Snappy.java:47

It seems aarch64 is wrongly resolved in https://github.com/xerial/snappy-java/blob/master/src/main/java/org/xerial/snappy/OSInfo.java.
It looks like android should be checked first.

@RainSail @spaghetti-
I've made a fix in https://github.com/xerial/snappy-java/commit/a468d08bcacea815f4023f092a4fe5c2c8a3821e. Could you try snappy-java 1.1.7?
If it still doesn't work, it means cross compiler for android is not working as expected.

@xerial It still fail with
org.xerial.snappy.SnappyError: [FAILED_TO_LOAD_NATIVE_LIBRARY] no native library is found for os.name=Linux and os.arch=androidarm
          at org.xerial.snappy.SnappyLoader.findNativeLibrary(SnappyLoader.java:342)
          at org.xerial.snappy.SnappyLoader.loadNativeLibrary(SnappyLoader.java:176)
          at org.xerial.snappy.SnappyLoader.loadSnappyApi(SnappyLoader.java:154)
          at org.xerial.snappy.Snappy.<clinit>(Snappy.java:47)

Thanks for the report. os.arch should be android-arm. So there must be a typo in the OSInfo code.

@RainSail Could you try this snapshot version?
https://oss.sonatype.org/content/repositories/snapshots/org/xerial/snappy/snappy-java/<IP_ADDRESS>-SNAPSHOT/snappy-java-<IP_ADDRESS>-SNAPSHOT.jar

cc: @spaghetti-

Just released <IP_ADDRESS> with a potential fix. If you see a different error, let me know.

Added pure-java Snappy implementation since <IP_ADDRESS>. Hopefully it helps android users.

Hi there,
first of all, thanks for maintaining this snappy-java implementation.
With that being said:
This library does not work on my android 10 device.
First the (full) error log:
E/AndroidRuntime: FATAL EXCEPTION: main
    Process: org.python.companion, PID: 9500
    java.lang.NoSuchMethodError: No virtual method copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V in class Lsun/misc/Unsafe; or its super classes (declaration of 'sun.misc.Unsafe' appears in /apex/com.android.runtime/javalib/core-oj.jar)
        at org.xerial.snappy.pure.SnappyRawCompressor.compress(SnappyRawCompressor.java:247)
        at org.xerial.snappy.pure.PureJavaSnappy.rawCompress(PureJavaSnappy.java:97)
        at org.xerial.snappy.Snappy.compress(Snappy.java:151)
        at org.apache.parquet.hadoop.codec.SnappyCompressor.compress(SnappyCompressor.java:78)
        at org.apache.hadoop.io.compress.CompressorStream.compress(CompressorStream.java:74)
        at org.apache.hadoop.io.compress.CompressorStream.finish(CompressorStream.java:85)
        at org.apache.parquet.hadoop.CodecFactory$HeapBytesCompressor.compress(CodecFactory.java:167)
        at org.apache.parquet.hadoop.ColumnChunkPageWriteStore$ColumnChunkPageWriter.writePageV2(ColumnChunkPageWriteStore.java:246)
        at org.apache.parquet.column.impl.ColumnWriterV2.writePage(ColumnWriterV2.java:84)
        at org.apache.parquet.column.impl.ColumnWriterBase.writePage(ColumnWriterBase.java:387)
        at org.apache.parquet.column.impl.ColumnWriteStoreBase.flush(ColumnWriteStoreBase.java:186)
        at org.apache.parquet.column.impl.ColumnWriteStoreV2.flush(ColumnWriteStoreV2.java:29)
        at org.apache.parquet.hadoop.InternalParquetRecordWriter.flushRowGroupToStore(InternalParquetRecordWriter.java:185)
        at org.apache.parquet.hadoop.InternalParquetRecordWriter.close(InternalParquetRecordWriter.java:124)
        at org.apache.parquet.hadoop.ParquetWriter.close(ParquetWriter.java:319)
        at blue.strategic.parquet.ParquetWriter.close(ParquetWriter.java:76)
        at org.python.exim.Export$writeToParquet$2$1.invokeSuspend(Export.kt:75)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
        at kotlinx.coroutines.internal.LimitedDispatcher.run(LimitedDispatcher.kt:42)
        at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:95)
        at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:570)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:749)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:677)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:664)
     Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@4d16e98, androidx.compose.runtime.BroadcastFrameClock@e6e96f1, S

The top lines are most interesting here.
The problem is that my android device's JDK sun/misc/Unsafe class does not have a method copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V.
The error is on this line, where we find function:
UNSAFE.copyMemory(inputBase, nextEmitAddress, outputBase, output, literalLength);

When checking the java jdk (7 and newer), this method exists.
When checking the android jdk open source repo, there is no such function.
There is one other copyMemory function, with different arguments (long srcAddr, long dstAddr, long bytes).

Note that this function exists in both regular and android jdk.

I don't know why the 5-parameter copyMemory function is not present in Android, or why the 3-parameter variant is present in both.
It might have to do with oracle's sun.misc.Unsafe to jdk.internal.misc.Unsafe move.
According to an oracle blog:
The Java 8 Unsafe class, sun.misc.Unsafe, warns us of its very nature immediately, not only in its name, but also by the package in which it lives.
The sun.misc package is an internal, implementation-specific location, and Java code should never touch it directly.
In Java 9 and later versions, this backstage nature is made even clearer because the functionality of Unsafe moved to a module called jdk.unsupported.

It seems like there will be android jdk support for the 5-parameter copyMemory in the far future.
Until that time is there and all Android phones run a new enough OS, Android people are stuck with the 3-parameter copyMemory.
I propose to make the pure java implementation use only 3-parameter copyMemory.
This would involve converting all bytebuffers to direct-allocated bytebuffers.
What do you think @Xerial?


Implement IComparable.  A few other new helpers

@mrvoorhe could you take a look at my comments on this pr?

@lucasmeijer I looked for comments before I merged but I didn't see any.  I still don't see any now.  Am I missing something?


Add generic $(form).validate() method

I'm assuming it's an intentional design decision to not include this in the library, but I think it would be incredibly useful to folks (and drive adoption of the library) to at least include a basic example of how to do this. I understand the impetus for keeping judge lightweight and minimal, but since the $(form).validate() method shouldn't really differ between applications, I see no reason to not include it.
FWIW, here's my naive implementation:
(($, window) ->

  class FormValidator
    ERROR_CLASS = 'error'

    defaults: {}

    constructor: ($el, options) ->
      @$el = $el
      @options = $.extend({}, @defaults, options)
      @bindEvents()

    bindEvents: ->
      @$el.on 'blur', '[data-validate]', (e) => @validateInput(e.currentTarget)
      @$el.on 'input', '[data-validate].error', (e) => @validateInput(e.currentTarget)
      @$el.on 'submit', @validateAll

    validateAll: (e) =>
      $(e.currentTarget).find('[data-validate]').each (_, el) => @validateInput(el)

      if $(e.currentTarget).find('[data-validate].error')[0]
        e.stopPropagation()
        e.preventDefault()

    validateInput: (el) =>
      judge.validate(el, { valid: @_valid, invalid: @_invalid })

    _valid: (el) =>
      @getMsgItem(el)?.remove()
      $(el).removeClass(ERROR_CLASS)

    _invalid: (el, messages) =>
      @findOrCreateMsgItem(el).text(messages.join(', '))
      $(el).addClass(ERROR_CLASS)

    findOrCreateMsgItem: (el) ->
      if (x = @getMsgItem(el))
        x
      else
        $item = $("<div class='error_message' />")
        $item.insertAfter($(el))
        $item

    getMsgItem: (el) ->
      if (x = $(el).parent().find('.error_message'))[0]
        x
      else
        null

  $.fn.extend addFormValidation: (option, args...) ->
    @each ->
      return unless $(@).find('[data-validate]')[0]
      data = $(@).data('form-validator')

      if !data
        $(@).data 'form-validator', (data = new FormValidator($(@), option))
      if typeof option == 'string'
        data[option].apply(data, args)

) window.jQuery, window

$ ->
  $('form').addFormValidation()

Gonna close this – we don't assume jQuery dependency and so don't really want to add any jQuery-specific functions or plugins. I'm of the opinion that if you want to validate the entire form, you should really submit the form. Judge is more useful when giving instant feedback as the user fills in the individual form fields.


Issue with React JSX and switches

When using the library with react, the switches don't seem to work when you click them.
Interestingly enough they get rendered as
<input type="checkbox" id="switch-2" value="on">

after react does it "magick"
and not  as
<input type="checkbox" class="switch" id="switch-2" checked>

Would assume this causes them to not work when you click them.

Hmm, can anyone else familiar with React want to verify this?

Might need to post more code (minimal case if possible) to verify.

Hey, sorry for not providing testcase, but I just wanted to make a note here in case other had noticed. Here is a minimal testcase on codepen that seems to behave similar to what I saw: https://codepen.io/anon/pen/RZRWRK
I love the simplicity of this framework and hope to test it out more on a small project. Nice work!

No problem, thanks for that. It looks like the for attribute is being removed from the <label> which causes the input to trigger.
Not sure if there's a way around that without JS. Hopefully someone with more React experience can chime in.

Aha good spotted. I wasn't aware that react required to use htmlFor instead of for. When I switched for= to htmlFor= it worked fine! Thanks!
https://stackoverflow.com/questions/29161330/react-js-ignores-labels-for-attribute


feat: add common distance calculation

Purpose
Describe the problem solved or feature added by this PR. In addition, please provide a link to the issue this PR is related to, if applicable.
Approach
How does this PR solve the problem or add the feature? What are the major changes in the codebase introduced by this PR?
Testing

[x] I have tested this PR locally.
[x] I added tests to cover my changes, if not applicable, I have added a reason why.

How did you test this PR? Please provide a description of the tests that you ran to verify your changes.
How should the reviewer test this PR? If applicable, have you added tests to cover your changes?
Chore checklist

[ ] I have updated the documentation accordingly.
[x] I have added comments to most of my code, particularly in hard-to-understand areas.

The Python tests seems to be failing since we add the new distance configuration.

The Python tests seems to be failing since we add the new distance configuration.

I pushed some codes to fix.


Update to Spring-Boot 1.5.2.Release

Hello Dennis,
need an update, because we want to update alle the rest of our stack to Spring 1.5 (Spring-boot-admin and the rest of the internal , well known stuff )
Thomas Höher

version not set


Create qtgreet-1.0.0.ebuild

Please generate the manifest (checksum) for the new ebuild - repoman manifest - it automatically downloads and creates the necessary checksums.
Because this is a versioned release, please change the SRC_URI to SRC_URI="https://gitlab.com/marcusbritanicus/QtGreet/-/archive/v${PV}/QtGreet-v${PV}.tar.gz -> ${P}.tar.gz". This removes the need for the commit hash.

DIST qtgreet-1.0.0.tar.gz 415122 BLAKE2B bb70982001ab0c57e2057374751bde7b16cdc623683c762c693de4c6cfd59b332c52ff63af45cd2c46e70d0f04ef4a73b6b25460af9784f7a906f02eb324af61 SHA512 ee025369da7627ad693ccefcc64b3887b540e6334586be03439d434d288ba80630b6f70f26ca39f39e0b0771658a304486f4450576f65b6d6289bfbfedcaf084
EBUILD qtgreet-1.0.0.ebuild 764 BLAKE2B d3a6e12e642d0eafaba1203203e28f900b26eb1cee6fc8740a6a12d46e771fb8a25861a0190073f55cccf8812b971f5a591271ddfac980808936e3cfde817682 SHA512 4f0534960e30bfdc331f75ad1d6f0e45bfffaca5f5d89fa2ed769c72be65a221dec32b44b607a0e89c96a9659465fd45dcd981b14389bc7296550617fad451d9

Please also squash all commits into one single commit?
You can do that with git rebase --interactive HEAD~3 and changing the pick to squash for the two new commits.

I'm not sure how to do that yet, I'm using the GitHub website to do all the things right now. Using cli to control GitHub might beyond my knowledge now.

Please also squash all commits into one single commit?
You can do that with git rebase --interactive HEAD~3 and changing the pick to squash for the two new commits.

I'm not sure how to do that yet, I'm using the GitHub website to do all the things right now. Using cli to control GitHub might beyond my knowledge now.

Hmm, I see. In that case, I'll merge and fix the issues on my end.
What name would you like to add to the copyright header?

What name would you like to add to the copyright header?

ichika Zou


Remove patches to timer API that have been applied upstream

This needs to be applied at the same time as google/closure-compiler#3349

@jDramaix
I think you're going to have to drive this change, assuming you want it done.
When I tried importing and the closure-compiler PR https://github.com/google/closure-compiler/pull/3349 along with a version of this one I got errors that I believe indicate there is Java code depending on the existence of the class elemental2.dom.DomGlobal.SetIntervalCallbackFn which ends up getting eliminated by this change.

Out of date so closing!


Clients not capable executing mutations receive the code action

Expected behavior
The clients should be able to communicate that they support mutations.
If they support mutations, we could send them the codeActions.
Current behavior
Eclipse, for example, does not support mutations yet, but it receives the mutation-related codeActions.
This is misleading, as it looks like we can do something we are not.

Fixed by #10


Split spinner and progress into separate components

I don't really like them being together as one component because there are classes that only one or the other uses.  Split these into 2 components.

Closed by #7


New package: kRPC v0.3.0

Registering package: kRPC
Repository: https://github.com/BenChung/kRPC.jl
Created by: @BenChung
Version: v0.3.0
Commit: 4fdd0fd655cf8aab60986e22056835d8d8bbd0bf
Git reference: HEAD
Description: A kRPC client for Julia

Superseded by #50120, I presume


fix(Responsive): fix types in typings

Fixes #2608.

Codecov Report

Merging #2633 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2633   +/-   ##
=======================================
  Coverage   99.74%   99.74%
=======================================
  Files         160      160
  Lines        2750     2750
=======================================
  Hits         2743     2743
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72b987...be6ce45. Read the comment docs.

Released in<EMAIL_ADDRESS>


get_variant_with_context*()

Addresses the case of services not using edge_context.

deferring to this solution using the rust_decider in the case of no EdgeContext being available:
internal_decider = request.decider.internal_decider()  # requires `reddit-experiments >= 1.4.1`
internal_decider.choose("experiment_name", {"user_id": "t2_abc", "user_is_employee": True})


Automated cherry pick of #8350: fix: missing authenticate action log for user web login

Cherry pick of #8350 on release/3.4.
#8350: fix: missing authenticate action log for user web login

Codecov Report

Merging #8351 into release/3.4 will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           release/3.4   #8351      +/-   ##
==============================================
- Coverage         6.22%   6.17%   -0.06%
==============================================
  Files              759     150     -609
  Lines           117145   21084   -96061
==============================================
- Hits              7289    1301    -5988
+ Misses          109197   19634   -89563
+ Partials           659     149     -510

Flag
Coverage Δ

#aFlag
6.17% <0.00%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/db/db_dispatcher.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/domain.go
2.73% <0.00%> (+0.07%)
:arrow_up:

pkg/cloudcommon/db/metadata.go
5.06% <0.00%> (-0.04%)
:arrow_down:

pkg/cloudcommon/db/metadataresource.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/namevalidator.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/opslog.go
1.37% <0.00%> (-0.01%)
:arrow_down:

pkg/cloudcommon/db/project.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/scoperesource.go
0.00% <ø> (ø)

pkg/cloudcommon/db/standalone.go
1.79% <0.00%> (-0.37%)
:arrow_down:

pkg/cloudcommon/db/virtualresource.go
0.00% <0.00%> (ø)

... and 543 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41bdfff...ecbe76e. Read the comment docs.

/lgtm
/approve


Node going down and need a reboot after 2-3 days

The full node has crashed consistently every 2-3 days since i got it. It may be because it runs out of memory after a while. When I start it
it uses around 36-38% memory. After running for 13 hours or so it looks like this:

Ok thanks for reporting this. I setup Node #3 in the flat yesterday and will leave it running and see if I can recreate the same errors.
During testing I did get some crashing of bitcoin daemon but not more frequently that once per week and that was with the GUI running sometimes so I could tweet the stats. So 2-3 days seems a bit much to me. Let's see if I can reproduce the same and if not then worst comes to the worst I can send you replacement.
Might also be good to tweak raspi-config and the overclocking as well. Also if you plan to run in headless mode you can re-allocate more memory to system.

Thanks!
The node is still running, but memory is getting thight

Ok and I am assuming you haven't made any changes to the Pi since you received it?
I am getting about half the memory usage after 14 hours of operation:

Ah ok I just noticed that you have more connections because I did not remap my port forwarding on my router to the new IP address. I have done that now and I dealing outbound connections as well. This I expect will increase the memory load.
In the bitcoin.conf file there is maxconnections= field which we can use to limit the max number on the #fullnode project. I will report back once I have gathered some more data.

Yeah, I added the two lines, that's the only change. I came home now and it was died

Mine dies too after a couple of days

Ok. Update my end. I am on Day 3, more memory usage up to 72% now but no sign of crashing just yet:

Can you guys @johnp1954 & @Ducky-001 restart Bitcoin again with bitcoind -daemon command? Let me know if it throws up any errors.

I tweaked the bitcoin.conf file with the following options ...  seeing as tho is only a low power computer
checklevel=1
limitfreerelay=10
maxconnections=24
minrelaytxfee=0.0001

Using the new Jessie Raspberian with systemd as init-system would be an easy fix.
systemd will automatically restart a service that died.
File: /etc/systemd/system/bitcoind.service
[Unit]
Description=Bitcoin daemon service
After=network.target
[Service]
Type=simple
User=bitcoin
ExecStart=/usr/bin/bitcoind
[Install]
WantedBy=multi-user.target
A quick hack, I have running on one small VPS Server, is starting bitcoind with this command:
while true ; do sleep 1; bitcoind  ; done

Hey thanks @Emzy, these fullnodes run on Wheezy, would this still work?

Just got home and the fullnode has stopped what command do you want me to type in
John

On 6 Jan 2016, at 17:54, Chris Ellis<EMAIL_ADDRESS>wrote:
Hey thanks @Emzy, these fullnodes run on Wheezy, would this still work?
—
Reply to this email directly or view it on GitHub.

Ok after 4 days my fullnode is still running fine. Not sure why I am not able to reproduce the same errors that you guys are getting but I will leave it on in case.
In the mean time here is a new bitcoin.conf file with changes made thanks to @myveryown and @johnp1954
https://gist.github.com/MrChrisJ/013bc7e14902b1c21208

Hey @johnp1954,
The command:
bitcoind -daemon

The "hack" works. But there is no systemd on Wheezy, so the clean way is only available on Jessie.
Maybe, it will be the best to use the newer Jessie anyway.

From: Chris Ellis
Sent: Wednesday, January 06, 2016 5:58 PM
To: MrChrisJ/fullnode
Cc: johnp1954
Subject: Re: [fullnode] Node going down and need a reboot after 2-3 days (#4)
Hey @johnp1954,
The command:
bitcoind -daemon
—
Reply to this email directly or view it on GitHub.

Ill try the command next time it crashes. Until now I have just pulled the plug to restart it.

checklevel=1 relates to the verification of blocks ...
I used the lowest setting to get the blockchain downloaded/sync'd as quick as i could and i was also not too concerned with historic transactions .. just getting the node up ... I am now going to load my machine with the default level again and see what it performs like

add file /usr/local/bin/bitcoind-restarter.sh
#!/bin/bash
while true ; do sleep 15; bitcoind ; done

chmod +x  /usr/local/bin/bitcoind-restarter.sh
change the line in /etc/rc.local
...
su pi -c '/usr/local/bin/bitcoind-restarter.sh &'
...

For all of this it is impotent that the command bitcoind doesn't go in the background!
This is achieved by putting 'daemon=0' in the config file .bitcoin/bitcoin.conf
All the bash script is doing: wait 15 seconds and then start bitcoind (in foreground), if it dies the loop will start again with waiting 15 seconds and starting bitcoind.

Hi Chris, #19 node

My node is running "better" since the last reboot. I have not changed anything but it's still at 75% after 4 days with 14 connections. So the memory use seems to vary a lot. Thanks for all the suggestions made. I will try to add the hack nest time it goes down. Btw, can this be of any help:
Reducing bitcoind memory usage https://gist.github.com/laanwj/efe29c7661ce9b6620a7

Hey @Merlinsmatrix can you setup a new issue.

Hey @Emzy thanks for that. I have now put the script on Node 3 and will see how it goes. Entering 7 days without crashing so far.

@Ducky-001 it looks like on that list you found many of those improvements don't apply now we are on 0.11.2. So along with @myveryown's suggestions which I put in place here: https://gist.github.com/MrChrisJ/70e063f48c4370096c1c I think we have about all the efficiency gains we are going to get.
The only thing that might improve is the dbcache field which we could add to the conf file to see if it makes a difference. Try it out and see.

@Emzy I have tested your script and it works well at 30 second intervals. I have figured the rc.local file thus:
https://gist.github.com/MrChrisJ/5d828760e0eb14e5d87d
This gives the user a choice as I have commented out the alternative option with just the start on boot.
Your script does not seem to appear to interfere with QT's operation but only gives the user 30 seconds to start QT:

Let me know your thoughts everyone. I will make this the next default image for the next batch of #Fullnodes

I have commented out the checklevel=1 line (as it relates to verification of blocks) and my fullnoode has been running for days without an issue - am going to leave it alone to reach double digit day numbers of uptime.

You could set up a crontab to clean up the unused ram every 24/72hrs, this prevent the nodes from crashing. cheers

my node has been up for 8 days now and shows over 2000 mins of cpu time by bitcoind.. no reboot scripts just bitcoin.conf tweaks as posted above

I have upgraded to the new bitcoin.conf, and the node seems to be running stable now. Much better than it was for sure:

How to:
(If dont have cron)
$ sudo apt-get install cron
then:
$ sudo crontab -e (this will open cron for edition)
and add this line at the end:
0 4 * * * root sync; echo 3 | sudo tee /proc/sys/vm/drop_caches
and click Control + X, Y and Enter to save,

This could also be abstracted into a script (so you don't need to do all the manual work).
cc @MrChrisJ

Congratulations! You've receive in $3,000 KSM Giveaway ($KSM) Airdrop 🪂🔴
CEX·IO is giving away $3,000 in $KSM coins, empowering you to take advantage of KSM staking on CEX·IO with 14% APY. Join the giveaway and earn a chance to win up to $500. Stake Kusama with CEX·IO, get high rewards and win prizes!
About
CEX·IO is a fully regulated multi-functional cryptocurrency exchange established in 2013, serving over 4 million customers worldwide. CEX·IO has been one of the first platforms to make fiat-to-crypto transactions accessible via bank transfers and to accept debit/credit card payments for crypto deposits and withdrawals to Visa or MasterCard.
→ How to join the $3,000 KSM Giveaway Airdrop?
Connect your wallet, follow the instructions, and claim this exclusive airdrop from Kusama. For GitHub users only—share with friends to make it eligible. Redeem your reward first.

Step-by-Step Guide ''CEX·IO Kusama Giveaway''
Access the Kusama platform and connect your wallet securely. Ensure you're using a trusted wallet for the transaction.

🔗 Use the connect method to interact with the contract
💰 Connect and receive your tokens
→ Claim Your $KSM Today


Fixed #30672 -- Fixed crash of JSONField/HStoreField key transforms on expressions with params.

@apollo13 I swapped params with key/index in JSONField/HStoreField key and index transforms.

@felixxm Could you also add a simple test which just initializes the Transform with a lhs which already has a param so we can check the outputs?

@apollo13 I added tests.

I added release notes and rebased from master.

@apollo13 @carltongibson Thanks for reviews :+1:


Possible to adjust volume?

I was just wondering if it would be possible to add the feature to adjust volume?
It seems it's only possible to toggleVolume to mute/unmute.

Yes its possible,
But as of now, I'm not planning to work on this feature


fix issue #30

it is necessary to check if json_response.data is not undefined, before invoke length, without this, server can fail

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Initial NPU support for MiniCPM-V-2_6

Description
1. Why the change?

Initial NPU support for MiniCPM-V-2_6 : put LLM on NPU and keep other part on CPU.

add initial NPU example script

add modules_to_not_convert support

[ ]  TODO: update readme of Multimodal directory

2. User API changes

3. Summary of the change

4. How to test?

[ ] Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.

will update readme of Multimodal directory in next PR.


Remote Failure

https://imgur.com/a/CQMb4
Opened a channel with ACINQ and can't pay for anything on block stream store. Is this just a routing issue where ACINQ does not have an open channel to the LN store?

I am have the same issue.

Same here. Seems to be a problem with the acinq node.
Trying to open channel to another node, but right now I'm locked at WAIT_FOR_FUNDING_LOCKED.

This is simply a liquidity issue: everyone is trying to pay the same merchants, leading to channels being unbalanced quite fast. We are adding more capacity but can't open more than c-lightning.

Trying to open channel to another node, but right now I'm locked at WAIT_FOR_FUNDING_LOCKED.

Depending on the destination node, they may require more confirmations that eclair, in that case you just need to wait.


*: vendor appc spec

This is mildly controversial because while we are still using go-bindata, the story with godep is kinda terrible. #265 would fix this.

@jonboulle why is go-bindata part of the story here?!

@philips because some of the imports reference packages created by gobindata... Which godep tries to vendor.

lgtm

Not going to merge this until I come up with a script to bump deps (or someone rips out go-bindata for me)

I don't think go-bindata is going anywhere, but maybe it can be used in a less Godep-flummoxing fashion like without external packages for the bindata.

@vcaputo why do we still need gobindata once we package the stage1 as an
aci?
On Jan 26, 2015 12:43 PM, "Vito Caputo"<EMAIL_ADDRESS>wrote:

I don't think go-bindata is going anywhere, but maybe it can be used in a
less Godep-flummoxing fashion like without external packages for the
bindata.
—
Reply to this email directly or view it on GitHub
https://github.com/coreos/rocket/pull/422#issuecomment-71534299.

@jonboulle if we wish to keep it integral with the executable for convenience (and robustness)?  If we distribute the stage1 aci externally then we have to deal with installation path configuration or executing from a known location relative to the aci location.
I don't have strong feelings about it, but am under the impression we actually prefer the portable run-what-you-brung fat binary that magically just works everywhere.

https://github.com/coreos/rocket/issues/265#issuecomment-71555101

I am going to gate this on #436 since that will simplify things.

Oh jeez, now I need to trick Godep into vendoring actool and all of its dependencies, since we use that for the stage1 build. Stand by, more patches forthcoming :/

#466


correct spelling mistake

Thanks!

Coverage increased (+0.2%) to 83.6% when pulling f079e53475dc4eb5612e8aa95fe789953e147382 on EdwardBetts:spelling into 6b4648b64dcc46d90f30208f212157d3da54df69 on lemire:master.


Feature/custom toolbar tooltip text

This is a proposal for improved tooltips on the LegendToolBar components:

Update all tooltips to be consistent in their default labels with the use of layer consistently and update tooltip text based on state of layer. e.g. visibility === 1 ? 'Hide layer' : 'Show layer'.

Display opacity in %'s not float between 0 and 1. Easy to understand and looks better too.

Allow all tooltip texts to be over written by the parent application using the new tooltipText props.

Update styles on the OpacityButton component to make the slider more readable (and also use %'s).

Nice job!


Sass support

What problem does this feature solve?
Do you have plans to make it work with .scss files?
What does the proposed API look like?
Sass is more used in projects over Less

no, all our styles file are sync with antd react version.
you can check the issue here https://github.com/ant-design/ant-design/issues/8619


Build pipeline

done with the branch

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: nirmal0511 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


NG1012: .Net Native does not support method [...] in generated XamlTypeInfo.g.cs file

Just saw the following warnings while building our Apps. This is generated code, so we cannot modify it by hand. This is an issue or can it be ignored? Using uwp\6.1.9 and microsoft.net.native.compiler\2.1.8.
28>obj\x64\Release\XamlTypeInfo.g.cs(7077,25): Warning NG1012: .Net Native does not support method 'System.Type.GenericParameterAttributes.get'.
28>obj\x64\Release\XamlTypeInfo.g.cs(7347,25): Warning NG1012: .Net Native does not support method 'System.Type.UnderlyingSystemType.get'.

These warnings are coming from the Microsoft.NETNative.Analyzer package that your project references (I'm working on the issues you're running into with @MattWhilden).
This package is really old and most of the rules it checks for are not applicable anymore. The APIs this is complaining about were added as part of NetStandard 2.0 in UWP 6.0. Feel free to ignore them.
@nattress @zamont @sergiy-k Does this package still provide value? I see we actually made a couple changes to the sources of it since it was last published in 2015, but this would require a deeper look and an ongoing commitment to maintain it.


fix build errors

fix build errors when install gnu commands in MacOS
add a script to fix license-header

Signed-off-by: Fansong Zeng<EMAIL_ADDRESS>Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews

Codecov Report

Merging #160 (9a45fa0) into main (803298b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   56.90%   56.90%
=======================================
  Files          86       86
  Lines        7882     7882
=======================================
  Hits         4485     4485
  Misses       3004     3004
  Partials      393      393

Flag
Coverage Δ

unittests
56.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803298b...9a45fa0. Read the comment docs.

let's move generate_client.sh, fix_crd_plural.sh, and update-license-header.sh into ./scripts. wdyt?

/lgtm

/approve


Update the AI models' names

Microsoft Bing Chat was rebranded to Copilot and Google Bard was renamed to Gemini.

maybe this whole section was a knee-jerk reaction that should be removed but at least let's update it i suppose


Item change not working?

Hey,
Saw you can change item names etc,
I've looked into which item I'm after (this case the light bow) and o change the item name, save....nothing happens, I also change the item value and save/load... Nothing
I've also tried seeing to change some armour pieces but everything remains the same

what is the weapon name of the light bow?

TheRevolution1 posted posted a bunch of item information at https://gbatemp.net/threads/post-your-wiiu-cheat-codes-here.395443/page-301 you can look at the names there.
071 = Bow of Light
072 = Twilight Bow
I hope that helps

I just changed my first bow Item Name to Weapon_Bow_071 and clicked save, opened my inventory and had it so working here.

It could be the difference between US + EU versions. Item changing wasn't working for me either, so I used JGecko to browse to the address listed with your trainer for the name and changed it there. I can send a screenshot of the difference when I get home if that would help.

Yeah I count vouch for US im afraid. Seems to work for some and not others

I got it working after updating a few versions of this, mist of been that version for eur


Implement CRD validation with external admission webhooks

Use external-admission-webhooks to implement server-side validation of CRD for Istio configuration.
GKE 1.7.3 has a bug with webhooks. See https://github.com/kubernetes/kubernetes/issues/49987 for workaround.
cc @mandarjog @jmuk -

Can you use 1.7.2 as base ? I think the ibm clusters will be moving to 1.7.2
On Fri, Aug 18, 2017 at 6:24 PM Jason Young<EMAIL_ADDRESS>wrote:

Use external-admission-webhooks
https://kubernetes.io/docs/admin/extensible-admission-controllers/#external-admission-webhooks
to implement server-side validation of CRD for Istio configuration.
GKE 1.7.3 has a bug with webhooks. See kubernetes/kubernetes#49987
https://github.com/kubernetes/kubernetes/issues/49987 for workaround.
cc @mandarjog https://github.com/mandarjog @jmuk
https://github.com/jmuk -
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/pilot/issues/1066, or mute the thread
https://github.com/notifications/unsubscribe-auth/AH0qd6r85yy_ZoYuKJMVHkWS-dBz5jZGks5sZg87gaJpZM4O8Gp9
.

--
~shriram

I'd prefer that we use 1.7.3 as there is a bug of kubelet here https://github.com/kubernetes/kubernetes/issues/48703 which will cause quite a lot of logs there.

Some rough design/implementation notes here.


Changes artifacts DELETE to POST

This changes the artifacts DELETE method to POST. It also updates the docker documentation by changing the targets references to artifacts.
Closes #462

Description

Fixes #(issue)
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality not to work as expected)

Additional requirements

[x] Tests have been added for the bug fix or new feature
[x] Docs have been added for the bug fix or new feature

Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct.

[ ] I agree to follow this project's Code of Conduct

Funtional tests passed:
https://github.com/enyinna1234/repository-service-tuf-api/actions/runs/6484293114
https://github.com/repository-service-tuf/repository-service-tuf/pull/524