Pass user object as parameter for refresh token

Instead of reading the user from the database twice (one time for the access token, one time for the refresh token), pass the user object as parameter to the createRefreshToken method.
As there should be no difference in the behavior (only difference being less calls to the database), I included no additional tests in this PR.

Coverage decreased (-0.001%) to 86.502% when pulling 11e84642cb3d8f99d4d64dd73014c930629b6c67 on tack-sap:refreshToken into b329541936aa2d832af902eac9e2bba9ff6524d9 on cloudfoundry:develop.


Investigate 2 tracks overlapping playback

Sudara thinks this has happened when hitting "back" and playing a track.
Ben has noticed it happening as well, related at all to edited uploads?

https://alonetone.com/search/short
I was just replicating this 100% on Safari with the 2nd three tracks.
But I first noticed it somewhere on the homepage accordions in casual listening.
Have Track A playing
[ switch tabs in current window or minimize safari window ]
Track A finishes
Track B Auto-starts
Track B Finishes
Track C Auto-starts
[ switch back to alonetone tab, and playback of Track B restarts while Track C continues to play ]


fixes #136 due to sign error, adds additional testing for accounting

Description
Fixes issues with position accounting and reporting
Checklist

[x] Linter status: 100% pass
[x] Changes don't break existing behavior
[x] Tests coverage hasn't decreased

Testing
more testing added!
Refers/Fixes
fixes #136

Pull Request Test Coverage Report for Build 515

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.178%

Totals

Change from base Build 512:
0.0%

Covered Lines:
371

Relevant Lines:
616

💛  - Coveralls


OnTokenRefresh() when app is closed

Hello, first of all thank you for the plugin, it is working very well and helped me alot in my project. I just have one small issue: I believe my token is refreshing after some weeks but that happens when the app is closed then my app doesn't know that the token has refreshed so it can't pass it to the server resulting in the app stopping to receive notifications. What is the correct way to deal with this issue?
Im using an Android device with the initialization set false to ResetToken.
Thanks

Hi, you need to have a service where save the token associated to user(taken from login if you have it), and call it in the OnTokenRefresh. At least this is my way and works. If the token it's refreshed or not don't really care, because the notification it's sent to the user(with associate token).
Regards!


Refactor useNativeAssetAsWrappedAmountIn into wethIsEth

Closes #227

Nice!
Yeap, I split initially to reduce complexity of each commit and forgot about swaps 😅
It makes total sense to update that in this PR as well - will do that now 👍

After discussing with the team, Daniel suggested we kept wethIsEth for consistency with smart contracts and also across all interfaces (add/remove/swap).
Current changes already take that into account.


swift-inspect: correct some escaping binding for RemoteMirror

Adjust the pointer handling for the callback and adjust the code to ensure that we properly form memory references to the function for the callback.

@swift-ci please test


[rampup] Stop txn/network after slot feature

Merge #14516 into rampup.

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!approved-for-mainnet


Wrangler app bad substitution error

Bug Description
In #26, we implemented checks to ensure that arguments passed to the wrangler app had no spaces in them. Our solution relies on parameter expansion. Crucially, this is a non-POSIX feature. While our container does run using bash, this error would indicate that the parameter expansion is not working properly.
Reported by @iek.

Not being able to perform parameter expansions causes errors in other places as well. The lines that need to be fixed are:
https://github.com/bailey-lab/MIPTools/blob/d3e613ccababf5526f106039a07e3f9f9aa3c00c/MIPTools.def#L409-L420


[NEXT-6109] Add supportText to theme config

1. Why is this change necessary?
To provide and display the supportText inside the theme
2. What does this change do, exactly?
Add possibility to fill and display the supportText
3. Describe each step to reproduce the issue or behaviour.
Try to add supportText
4. Please link to the relevant issues (if any).
#812
Video: https://vimeo.com/418392136/0bd1eb2d46
5. Checklist

[ ] I have written tests and verified that they fail without my change

Is this needed? There aren't any

[x] I have squashed any insignificant commits
[x] I have written or adjusted the documentation according to my changes

Due to the missing helpText-Field in the documentation I didn't adjust those

[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

I'll fix the tests right now

QA approved, as soon as you remove the duplicates for testing purposes :+1:

@jinnoflife can you please resolve your conflicts :)?

@pantrtxp done
@leichteckig which duplicates do you mean?

@jinnoflife please add the fixes #123 hint to your commit message

@jinnoflife please reabase your branch :blush: there are merge conflicts

Hi @jinnoflife, could you please rebase this onto master and resolve @tobiasberge's comment?

@pweyck Sorry my bad this was auto generated by jest snapshot. It just looked weird.


flutter debug_adapter  ## exception  _Exception: Exception: lookupResolvedPackageUris result contained more results than the request. See https://github.com/dart-lang/sdk/issues/52632

Steps to reproduce
Flutter crash report.
Please report a bug at https://github.com/flutter/flutter/issues.
command
flutter debug_adapter
exception
_Exception: Exception: lookupResolvedPackageUris result contained more results than the request. See https://github.com/dart-lang/sdk/issues/52632

flutter doctor
[✓] Flutter (Channel stable, 3.22.3, on Microsoft Windows [Version 10.0.22631.4169], locale en-US)
    • Flutter version 3.22.3 on channel stable at C:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b0850beeb2 (10 weeks ago), 2024-07-16 21:43:41 -0700
    • Engine revision 235db911ba
    • Dart version 3.4.4
    • DevTools version 2.34.3

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at C:\Users\ThusithaDeepal\AppData\Local\Android\sdk
    • Platform android-34, build-tools 33.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✗] Visual Studio - develop Windows apps
    ✗ Visual Studio not installed; this is necessary to develop Windows apps.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[✓] Android Studio (version 2022.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)

[✓] VS Code (version 1.93.1)
    • VS Code at C:\Users\ThusithaDeepal\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.96.0

[✓] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 14 (API 34) (emulator)
    • Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [Version 10.0.22631.4169]
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 128.0.6613.138
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 129.0.2792.52

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Expected results
Not working emulator crash
Actual results
Need to start normally
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

Hi @ThusithaDeepal, can you try https://github.com/dart-lang/sdk/issues/52632#issuecomment-2274899885 to see if it helps?
Do any of your file names contain a comma that could have been inserted by accident?

@danagbemava-nc I have checked no issue with
'," s. I have checked

Closing this as solved


JSON schema outdated?

i think the JSON schema is outdated: https://github.com/tamasfe/taplo/issues/294#issuecomment-1200476690

@frederikhors thanks for updating me. ya, i'm not the one who originally wrote it and I do not maintain it.
However, if you could push a PR to that repo to update it, it would be appreciated :)
since the code is not hosted in this repo, i'll be closing this issue since its not actionable here.

The repo I linked is not who maintains the json schema.
Do you know which is the repo? I can PR if we know which is.

Sorry we can PR here: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/cargo-make.json.

Done https://github.com/tamasfe/taplo/issues/294#issuecomment-1200476690.

thanks a lot @frederikhors


Try to simplify our bot setup. (NOT FOR REVIEW)

I'm testing to see how Travis handles this.

I don't understand why flutter test hangs here. Maybe we're missing a dependency that the engine wants? (I removed dart, ubuntu-toolchain-r-test, and gcc/g++.) Trying something simpler in https://github.com/flutter/flutter/pull/3989.

Well disappointingly this doesn't save any time on Travis at all.
I'll clean it up and post it for real review tomorrow. It'll require a corresponding change to the infra bots.

https://codereview.chromium.org/1993843002 has the corresponding infra patch.

Ok this is ready for review now.


Update snapshot workflow

What
Workflow to update snapshots whenever there is a UI change
Why
If a PR has a UI change, a label "ui change" should be added. It will trigger this workflow which will update the snapshots required for E2E testing
How Tested
Forked the repo and tested there
Workflow run : https://github.com/tejaswip-msft/Sample/runs/6928184675?check_suite_focus=true
Workflow added a commit to the branch with updated screenshot : https://github.com/tejaswip-msft/Sample/pull/1/commits/cab5428d1651bc0f1ef19e68a232fa90d3e6663e
Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

Looks great!
I can't find it in the workflow, but are we also going to add the automation of this comment? Or is it going to be in a separate PR? - https://github.com/Azure/communication-ui-library/pull/1960#issuecomment-1156181864
Saying "Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot."

Looks great!
I can't find it in the workflow, but are we also going to add the automation of this comment? Or is it going to be in a separate PR? - Azure/communication-ui-library#1960 (comment)
Saying "Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot."

Yes this will be added in a separate PR


Crowdin PR do not merge

The last few crowdin automated PR did not get merged in the last snapshot version.
Two exemples from yesterday that are not reflecting on the UI
https://github.com/snapshot-labs/snapshot/commit/e24c91fec2fd020269cc34d55a95c42cfc88a685
https://github.com/snapshot-labs/snapshot/commit/007bafb9bfdb12b2f6b83ecaa7c63da25c06da57

@metrox-eth I am not sure what you mean. There is an open PR which is not merged, so the changes wont reflect https://github.com/snapshot-labs/snapshot/pull/1046/files
Unless this PR is merged, the changes wont show.

Gotcha thx


chore: update deploy yamls

Pull Request Description
Describe what this PR does / why we need it
Update deploy yamls
Does this pull request fix one issue?

NONE
Describe how you did it
NONE
Describe how to verify it
NONE
Special notes for reviews

Codecov Report

Merging #25 (bebfecd) into main (5caac01) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   15.77%   15.77%
=======================================
  Files          26       26
  Lines        2105     2105
=======================================
  Hits          332      332
  Misses       1724     1724
  Partials       49       49

Flag
Coverage Δ

unittests
15.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5caac01...bebfecd. Read the comment docs.


(youtube,invidious,twitch): fix categories

"Social" doesn't really work well for them

Makes sense to me.


Throttling mechanism does not allow to cancel timers.

Describe the bug
lack of possibility to stop timer behind throttling mechanism may lead to failing of strict tests like in napari by keep objects alive
https://github.com/napari/napari/runs/8043907763?check_suite_focus=true#step:8:377
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
There should be option to stop timer on close.
Screenshots
Screenshots and GIFS are much appreciated when reporting visual bugs.
Desktop (please complete the following information):

OS with version [e.g macOS 10.15.7]
Qt Backend [e.g PyQt5, PySide2]
Python version

how would you fix this @Czaki?  we could just  make the _timer public?

I would rather change flush to have signature: flush(self, restart_timer=True)
https://github.com/pyapp-kit/superqt/blob/599dff7d029ce0499f73d52b61769358fb7ae346/src/superqt/utils/_throttler.py#L142
To allow flush all events and stop timer.

That works for me!


[WIP] Support Envoy to fetch certificate validation context using SDS service.

Description: Refactor SdsApi to support dynamic certificate validation context, and support Envoy to fetch certificate validation context from remote server via SDS API.
Risk Level: Low
Testing: Unit tests and integration tests.
Fixes #1194
Signed-off-by: Jimmy Chen<EMAIL_ADDRESS>

I am adding unit tests and integration tests to cover this change.

LGTM


npx: not found when building Blazor WASM on GitHub Actions

Before filing this issue, please ensure you're using the latest CLI by running swa --version and comparing to the latest version on npm.
ℹ NOTE: Make sure to enable debug logs when running any swa commands using --verbose=silly
Describe the bug
When building my Blazor WASM application using the default GitHub Action template, I get the following error:
App Directory Location: 'Blazor' was found.
No Api directory specified. Azure Functions will not be created.
Looking for event info
Starting to build app with Oryx
Azure Static Web Apps utilizes Oryx to build both static applications and Azure Functions. You can find more details on Oryx here: https://github.com/microsoft/Oryx
---Oryx build logs---
Operation performed by Microsoft Oryx, https://github.com/Microsoft/Oryx
You can report issues at https://github.com/Microsoft/Oryx/issues
Oryx Version: 0.2.20220401.1, Commit: afed4f696a08bfd4c8e4109704a082bf9fb20515, ReleaseTagName: 20220401.1
Build Operation ID: |xrf2qm5foks=.203f2b07_
Repository Commit : f1f53864c65e57818ae78323cb3974f119d04073
Detecting platforms...
Detected following platforms:
  dotnet: 6.0.6
Version '6.0.6' of platform 'dotnet' is not installed. Generating script to install it...
Detected the following frameworks: blazor
Source directory     : /github/workspace/Blazor
Destination directory: /bin/staticsites/ss-oryx/app
Downloading and extracting 'dotnet' version '6.0.301' to '/opt/dotnet/6.0.301'...
Downloaded in 3 sec(s).
Verifying checksum...
Extracting contents...
performing sha5[12](https://github.com/tdashworth/name-badge-automater/runs/7405789091?check_suite_focus=true#step:6:13) checksum for: dotnet...
Done in 8 sec(s).
image detector file exists, platform is dotnet..
Using .NET Core SDK Version: 6.0.301
Running 'dotnet workload install wasm-tools'...
Welcome to .NET 6.0!
---------------------
SDK Version: 6.0.301
Telemetry
---------
The .NET tools collect usage data in order to help us improve your experience. It is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.
Read more about .NET CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry
----------------
Installed an ASP.NET Core HTTPS development certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only).
Learn about HTTPS: https://aka.ms/dotnet-https
----------------
Write your first app: https://aka.ms/dotnet-hello-world
Find out what's new: https://aka.ms/dotnet-whats-new
Explore documentation: https://aka.ms/dotnet-docs
Report issues and find source on GitHub: https://github.com/dotnet/core
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli
--------------------------------------------------------------------------------------
Skipping NuGet package signature verification.
Skipping NuGet package signature verification.
Skipping NuGet package signature verification.
Installing workload manifest microsoft.net.sdk.maui version 6.0.408…
Installing workload manifest microsoft.net.sdk.maccatalyst version [15](https://github.com/tdashworth/name-badge-automater/runs/7405789091?check_suite_focus=true#step:6:16).4.315…
Installing workload manifest microsoft.net.sdk.macos version 12.3.315…
Installing workload manifest microsoft.net.workload.mono.toolchain version 6.0.7…
Installing workload manifest microsoft.net.sdk.ios version 15.4.315…
Installing workload manifest microsoft.net.sdk.android version 32.0.424…
Installing workload manifest microsoft.net.sdk.tvos version 15.4.315…
Installing pack Microsoft.NET.Runtime.WebAssembly.Sdk version 6.0.7...
Writing workload pack installation record for Microsoft.NET.Runtime.WebAssembly.Sdk version 6.0.7...
Installing pack Microsoft.NETCore.App.Runtime.Mono.browser-wasm version 6.0.7...
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.Mono.browser-wasm version 6.0.7...
Installing pack Microsoft.NETCore.App.Runtime.AOT.Cross.browser-wasm version 6.0.7...
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.AOT.Cross.browser-wasm version 6.0.7...
Installing pack Microsoft.NET.Runtime.MonoAOTCompiler.Task version 6.0.7...
Writing workload pack installation record for Microsoft.NET.Runtime.MonoAOTCompiler.Task version 6.0.7...
Installing pack Microsoft.NET.Runtime.MonoTargets.Sdk version 6.0.7...
Writing workload pack installation record for Microsoft.NET.Runtime.MonoTargets.Sdk version 6.0.7...
Installing pack Microsoft.NET.Runtime.Emscripten.Node version 6.0.4...
Writing workload pack installation record for Microsoft.NET.Runtime.Emscripten.Node version 6.0.4...
Installing pack Microsoft.NET.Runtime.Emscripten.Sdk version 6.0.4...
Writing workload pack installation record for Microsoft.NET.Runtime.Emscripten.Sdk version 6.0.4...
Garbage collecting for SDK feature band(s) 6.0.300...
Successfully installed workload(s) wasm-tools.
  Determining projects to restore...
  Restored /github/workspace/Blazor/NameBadgeAutomater.csproj (in 1.71 sec).
Publishing to directory /bin/staticsites/ss-oryx/app...
Microsoft (R) Build Engine version 17.2.0+41abc5629 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
  Determining projects to restore...
  All projects are up-to-date for restore.
  NameBadgeAutomater -> /github/workspace/Blazor/bin/Release/net6.0/NameBadgeAutomater.dll
  NameBadgeAutomater (Blazor output) -> /github/workspace/Blazor/bin/Release/net6.0/wwwroot
  /bin/sh: 2: /tmp/tmpbc22db7e754d4225b00c2f15c09d7f80.exec.cmd: npx: not found
/github/workspace/Blazor/NameBadgeAutomater.csproj([16](https://github.com/tdashworth/name-badge-automater/runs/7405789091?check_suite_focus=true#step:6:17),5): error MSB3073: The command "npx tailwindcss -i ./Styles/app.css -o ./wwwroot/css/app.css" exited with code 1[27](https://github.com/tdashworth/name-badge-automater/runs/7405789091?check_suite_focus=true#step:6:28).

I also tried adding node setup and install steps beforehand but no luck.
      - uses: actions/checkout@v2
        with:
          submodules: true
      - name: Setup Node JS
        uses: actions/setup-node@v1
      - name: Install Tailwind CLI
        run: npm install -g tailwindcss
      - name: Build And Deploy
        id: builddeploy
        uses: Azure/static-web-apps-deploy@v1
        with:
          azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN_POLITE_SAND_091221803 }}
          repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for Github integrations (i.e. PR comments)
          action: "upload"
          ###### Repository/Build Configurations - These values can be configured to match your app requirements. ######
          # For more information regarding Static Web App workflow configurations, please visit: https://aka.ms/swaworkflowconfig
          app_location: "Blazor" # App source code path
          api_location: "" # Api source code path - optional
          output_location: "wwwroot" # Built app content directory - optional
          ###### End of Repository/Build Configurations ######

To Reproduce
Steps to reproduce the behavior:

Create a Blazor WASM app
Follow these steps to setup tailwindcss https://chrissainty.com/adding-tailwind-css-v3-to-a-blazor-app/#integrating-using-the-tailwind-cli-via-npm
Try to build via swa cli on GitHub actions

Expected behavior
Build to success, npx to be available.
Additional context
I realise this might not be a swa problem but looking for guidance as to the next steps, please.

I am having same issue.

A workaround is to manually build the app first (before the SWA step) using dotnet publish. Then, you can use the generated artifacts in the SWA step (don't forget skip_app_build: true). This way you can skip the SWA's magic build.
The yml should look like the following:
jobs:
  build_website:
    runs-on: ubuntu-20.04
    steps:
    - uses: actions/checkout@v3
    - name: Setup .NET Core
      uses: actions/setup-dotnet@v2

    - name: Build Site
      run: dotnet publish --output output

    - name: Deploy
      uses: Azure/static-web-apps-deploy@v1
      with:
        azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN }}
        repo_token: ${{ secrets.GITHUB_TOKEN }}
        action: "upload"
        app_location: "output"
        output_location: ''
        skip_app_build: true

Thanks @meziantou.

Thanks for the solution @meziantou.
@tdashworth, we're closing this issue, please feel free to raise concerns or re-open this if you're facing any technical difficulties.

Thanks! This really helped me out a full year later! I've spent a full three hours on this now 😂


Add support for crun --log-level

What type of PR is this?
/kind feature
What this PR does / why we need it:
We now support the new crun log level flags.
Which issue(s) this PR fixes:

Refers to https://github.com/containers/crun/issues/1525
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

Added support for crun log level flags, which requires at least crun v1.16.2.

@kwilczynski PTAL

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.59%. Comparing base (4e0f474) to head (ae1e773).
Report is 702 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2401       +/-   ##
===========================================
+ Coverage   37.53%   47.59%   +10.05%
===========================================
  Files          15      121      +106
  Lines        1268     4007     +2739
  Branches      414      830      +416
===========================================
+ Hits          476     1907     +1431
- Misses        526     1591     +1065
- Partials      266      509      +243

/approve
/lgtm

@kwilczynski I invited you to become a collaborator to this project. Do you mind accepting and trying an /lgtm again?

/approve
/lgtm

@kwilczynski PTAL again


Can't use with relative urls in a browser context

The following fails with Uncaught Error: "/some/endpoint" is not a valid URL:
const request = getIt([jsonResponse()])

request('/some/endpoint')

Is there any way configure get-it to allow both relative urls and absolute urls?

Closing as this doesn't seem to be a huge issue in practice


Vector tile link

on this wiki page, http://maps.esri.com/AGSJS_Demos/templates/VectorBasemapStyleEditor/index.html is a dead link - I believe the updated link is https://maps.esri.com/jg/VectorBasemapStyleEditor/index.html

Closing issue because we're retiring this wiki.


About Pointer value compare

Hey Amit Itzkovitch!
I have a struct value is pointer values , by obtan a set of value,  two set of Struct with goset conpare value,  owing to two struct property is different pointer, but the pointer value is equal, so goset.Contains(item) always false. Can have conpare Struct Pointer values?
The data struct is two way

package: `github.com/haproxytech/models
datastruct: models.Server

Phenomenon: goset.Contains() conpare the pointer address, not pointer value.

Hi @cylonchau!
Why won't you make the Set contain the actual value instead of a pointer to the value?
The Set object is designed to allow O(1) access, for both Contains() and Add(). It is implemented using a map, and all the values are stored as map keys. What you are asking for requires iterating over all the items, which kind of loses the main feature of the Set.
So I suggest you just store the values inside set set.Add(*item), and then do goset.Contains(*item)

Hi @cylonchau! Why won't you make the Set contain the actual value instead of a pointer to the value?
The Set object is designed to allow O(1) access, for both Contains() and Add(). It is implemented using a map, and all the values are stored as map keys. What you are asking for requires iterating over all the items, which kind of loses the main feature of the Set.
So I suggest you just store the values inside set set.Add(*item), and then do goset.Contains(*item)

It's not this scenes, it is this scenes
the data struct is
type a struct {
   a1 int
   b1 *int64
}

goset opreation
type_a := getAstruct()  // a1 = 1; b1= 2; but b1 pointer address = 0x0001
p = int64(1) suppose the variable p address is 0x0002
type_b := a{a1: 1, b1:&p}

goset.Add(type_b)

goset.Contains(type_a) // false, because 0x0001 != 0x0002, the goset.Contains conpare pointer address, not pointer value

Thanks for clarifying the issue @cylonchau.
I feel your pain, as although logically the two instances have the same values, they are not equal because of the pointer to a different memory address. The thing is, this is how pointers work, and there's not much to do about that...
If you take a look at goset's implementation, you can see it is implemented using a map, where the keys of the map are the items of the Set. goset doesn't really implement any comparison itself, it just adds/deletes keys from the map. And because of how structs are handled as map keys, pointer fields are considered by the memory address and not by the value they are pointing to.
This makes this issue not trivial to solve. It requires providing a way to define a custom hash function for that struct you are using and requires changing the Set implementation in a way that will make it heavier performance-wise.
Having said all that, I am interested to hear what are your suggestions for this pointer-fields problem. How do you imagine such a solution to look like?

Thank you @amit7itz
I used other unpointer type resoved this problem, but pointer nature so. compare pointer value maybe is the goset point of improvement


1816: getNextTask will get wrong task if DO_WHILE task is embed in FORK or DECISION

Patch for #1816 .
What I changed
If the last inner task of DO_WHILE was completed and call getNextTask() in decide(), I return the DO_WHILE task (In current code, it will return the next task of DO_WHILE).
And then, in DeciderService.getNextTask(), I check if the DO_WHILE task already exists in the workflow's tasks. If it exists, just ignore it.

Pull Request Test Coverage Report for Build 4424

7 of 8 (87.5%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.005%) to 69.378%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/src/main/java/com/netflix/conductor/common/metadata/workflow/WorkflowTask.java
3
4
75.0%

Files with Coverage Reduction
New Missed Lines
%

core/src/main/java/com/netflix/conductor/core/execution/mapper/DoWhileTaskMapper.java
1
97.5%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java
2
59.59%

Totals

Change from base Build 4417:
0.005%

Covered Lines:
12617

Relevant Lines:
18186

💛  - Coveralls

@alex-fu Thanks for the contribution. Can you please also add an integration test for this here. Could you also add an integration test which would handle a failure and automated retry in one of the forked branches within the do_while?
@manan164 We would appreciate it if you could help with reviewing this PR.

Hi ,
I have embedded the DO_WHILE in a decision task and I am facing a similar issue where the task outside the loop task is getting executed.Any timeline by which this PR will be merged?

@alex-fu Are you available to continue working on this PR? Thanks

@apanicker-nflx  Sorry for the late reply since I was stuck in some things last month. I'll add the integration test ASAP.

Please rebase against dev, seems like the build failure is due to a conflict.
https://travis-ci.com/github/Netflix/conductor/builds/186799651

Also, while unit tests look good, please also add an integration test for this here

@apanicker-nflx  I've rebased against dev and submitted some code according to @manan164's review and some integration test, please review again.


handle the use api/emit relationship in a cleaner way

ideally anything on the api produces an event on the emit bus without needing to do it manually

closing because required behavior cannot be generalized


Version 3: provide a wrapper for canvas since Chart.js hardly relies on parentNode

Chart.js adds a hidden iframe to parentNode in helpers.addResizeListener method and calculates maximum width / height depending on styles of parent node in helpers.getMaximumWidth and getMaximumHeight methods.
In Microsoft edge there are cases (propably connected to destroy) in which parentNode is null and therefore chart.js throws an error Unable to get property 'currentStyle' of undefined or null in getStyle method called by getMaximumWidth and getMaximumHeight.
Related to: https://github.com/aomran/ember-cli-chart/pull/54#issuecomment-239636751

@aomran Thank's for merging #54 and #59. Would love if you merge this one also and release.


Create state management wrapper to abstract implementation (local store, server side)

See for requirements:  https://github.com/epam/ai-dial-core/issues/33

Considered done. Stateful implementation will be done as part of #165


'Couldn't find any package by regex'

Though the machine says, ubuntu, its actually Debian 8.3 x64 with DigitalOcean. I tried to do this under ubuntu, but that also didn't work.
https://gist.github.com/Cyken-Zeraux/aecf0e3a9b30e2ae40968781c371e450
Following the 'https://github.com/paragonie/airship-docs/blob/master/en-us/01-intro/2-Installing.md' guide.

https://github.com/paragonie/airship-docs/commit/97cb9578dc80787d7e8731f510e67571f661f67d
Does that help?

Yep, that gets PHP installed, however same issue with Postgre. 'deb http://apt.postgresql.org/pub/repos/apt/ jessie-pgdg main' is not a command, its supposed to be put into the sources list, but its listed as if its a command.
When that is added to the sources list, this error occurs on apt-get update
W: GPG error: http://apt.postgresql.org jessie-pgdg InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 7FCC7D46ACCC4CF8

Okay, this should be fixed with https://github.com/paragonie/airship-docs/commit/15e0350007d1294875ed7b2ec04fe01174634c66
Thank you for the feedback. :)


Add examples to handle Workflow Definitions as Kubernetes objects

What would you like to be added:
Add examples of a CRD/CR being parsed by the SDK, so implementations based on Kubernetes could use it as inspiration to build their own.
Why is this needed:
Most of the Kubernetes environment is built around Golang. This example could be useful for implementations based on Kubernetes operators written in Golang.

Hello @ricardozanini.
I could possibly help with that.

@iwita go ahead :)

Already handled by #146


Unable to initialize row height when loading a table

On the https://bossanova.uk/jexcel/v3/docs/getting-started page, there is an example of how to set row heights when initializing a table. However, the existing solution appears to be an associative array with incorrect syntax and it creates an error on loading the page. I have tried correcting the syntax but have been unable to get this feature to work. This is the instruction and example from the page:
"The inital row height can be defined in the height property include in the rows directive.
"

Sorry, it seems there is an error in the documentation. This would do the trick, I will fix the documentation.
var options = {
    data: [[1,2,3,4,5,6,7,8,9,10]],
    minDimensions:[10,10],
    rows:{ 2:{height:'100px'} },
}

Perfect, thank you!


feature: nodepool controller

Ⅰ. Describe what this PR does
This PR implements the nodepool controller, which will

group nodes based on the label
manage nodepool related attributes (labels/annotations/taints) for corresponding nodes

Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
NONE
Ⅳ. Describe how to verify it
This PR doesn't need to be verified.
Ⅴ. Special notes for reviews
This PR only includes the main logic of node controller, and it can't be compiled yet. Makefile rules and other configuration files will be added in the next PR.

Nits. Otherwise, LGTM.
Btw, are you going to add UT for the controller later?

Yeah. I will add UT in an independent PR.

Nits. Otherwise, LGTM.
Btw, are you going to add UT for the controller later?

Yeah. I will add UT in an independent PR.

LGTM

LGTM


logging: fix getSampleRate to work with error spans

getSampleRate would fail because error spans would not have a response object set,
which results in a Cannot read properties of undefined (reading 'status') error. Fix this
by inverting the logic. Also, make sure we return a number instead of a boolean when the
exception property is set.

Hey @mcuelenaere.. thanks for the PR. The only issue I could see is that sampleRates.exception is already a number, not a boolean. So simplified the else statement.


Reimplement text focusing

A new PR to work on the text focusing in the context of the nyt demo (also to test the new netlify test site build on PR 😉 )

@jimjam-slam We've got two implementations up that we can test out!
Transform approach: https://closeread.netlify.app/gallery/demos/poem-1/
Font scaling approach: https://closeread.netlify.app/gallery/demos/poem-2/
If you have a moment, please let me know your thoughts!
Two strange things that I've noticed about the font scaling approach: 1. the "path" it takes while zooming to the span is more awkward than the transform path, 2. when viewed on mobile, it's very jittery the change in font size, as if it's only going through like 3 intermediate sizes.
Note: I still haven't been able to get the layout to flip to overlay-center on a mobile device. A work in progress...

When I test this on mobile Safari on landscape, it scales up with more intermediate stages - but it's based on integer pixel sizes, it could be very size-dependent 🤔 When so try it on portrait, the change is so slight that I really only see the translation, and that does seem to pop!
It really would be easier and nicer if we went with the transform approach... 😮💨

I'm going to go ahead and move forward with what we've got here (the transform approach works better on safari now that I've added back in your font-size: 300%; trick). One a future PR where I'm working on documentation I'll remove the font scaling demo but mention the approach in the Guide part of the docs.


Can MediaPipe running both face mesh and hand detection at the same time on Android device?

Issue Description

Hi, I'm currently trying to build an Android App that can both detect hands and faces. Is this feasible?
Thanks in advance.

holistic = face + hand + pose

holistic = face + hand + pose

Thank you very much!

holistic = face + hand + pose

Can somebody help me use Mp Holistics on android
I find it very tough to open and use the prebuilt APK example by google here


fix: use exp package for contain functionality [LUM-572]

[ ] Tests written and linted ℹ
[ ] Documentation written ℹ
[x] Commit history is tidy ℹ

What this does
Use the exp go package to have contains functionality as the CLI isn't using Go 1.21 with the native slices support
More information

Jira ticket

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Client.dataset is deprecated

Raised on this line: https://github.com/mxmzdlv/pybigquery/blob/master/pybigquery/sqlalchemy_bigquery.py#L380
Client.dataset is deprecated and will be removed in a future version.
Use a string like 'my_project.my_dataset' or a "
cloud.google.bigquery.DatasetReference object, instead.

We can use client.get_table("dataset.table") directly.
I wanted to create a PR but looks lite writes are restricted in this repo.

Thanks for bringing this up. I agree that using get_table with a string (and project argument) is the most straightforward solution, but might actually need to use TableReference.from_string("dataset.table", default_project=project) to support project overrides.
@dimkonko you should be able to create a PR from a fork

Thank you for a quick response. Make sense. I'll take a look later today.

PR with a fix was merged so closing the issue. Thank you for support.


NIFI-13534: Only reloading the flow when the browser tab is visible. …

…This prevents attempts to re-render the SVG when the browser tab is hidden.

While troubleshooting the issues addressed in this PR I discovered that the application still is affected by [1]. Once the fix has been released and we'll want to upgrade to it as well.
[1] https://github.com/angular/components/issues/29696

will review...


Can't set filename for downloaded image

It would be very useful to have a option to set filename for downloaded image.

Hi @otsir,
Yes, sounds like a good thing to have.
Any suggestion on how to implement this? Maybe you can fork the repo and code the solution in separate branch and link it here?

I too would love to have this feature added as my image filenames are sometimes much too long and obnoxious.

Please do, been trying to edit this library to name files but not much luck

Hey guys!
Finally got some time to do this.
Check the latest lib version.


Linux crashed mid update , now instances won't start .

Hello @dasisdormax  ,
I started the update process by command : cs2-server update
it said the base installation needs updating but my OS crashed after that .
Now that server is back up , when I issue command " cs2-server update " , it says the base installation is up to date but it's not .
Also when I open instances consoles , I see this message :

I can't run any instances . How should I solve this issue ?

Nevermind . After reading cs2-server help , I noticed there is an option called cs2-server validate that fixes broken files . Thanks for the great script once again .


improve protoc-gen-go-ghttp plugin

Support for generating http methods and structures from proto files

the file template

Codecov Report
Base: 76.54% // Head: 78.12% // Increases project coverage by +1.57% :tada:

Coverage data is based on head (69379d0) compared to base (33fdde6).
Patch coverage: 46.42% of modified lines in pull request are covered.

:exclamation: Current head 69379d0 differs from pull request most recent head c3039d3. Consider uploading reports for the commit c3039d3 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##           feature/grpcx    #2292      +/-   ##
=================================================
+ Coverage          76.54%   78.12%   +1.57%
=================================================
  Files                581      580       -1
  Lines              48318    48108     -210
=================================================
+ Hits               36983    37582     +599
+ Misses              9312     8527     -785
+ Partials            2023     1999      -24

Flag
Coverage Δ

go-1.15-amd64
78.12% <46.42%> (?)

go-1.17-amd64
?

go-1.18-386
?

go-1.18-amd64
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

os/gtime/gtime_time.go
82.06% <31.57%> (-3.66%)
:arrow_down:

contrib/config/nacos/nacos.go
50.76% <50.76%> (ø)

os/gcron/gcron_schedule_fix.go
87.50% <0.00%> (-12.50%)
:arrow_down:

errors/gerror/gerror_api.go
85.93% <0.00%> (-4.69%)
:arrow_down:

os/gfsnotify/gfsnotify_filefunc.go
70.12% <0.00%> (-3.90%)
:arrow_down:

net/gtcp/gtcp_pool.go
72.22% <0.00%> (-2.78%)
:arrow_down:

os/gfsnotify/gfsnotify_watcher_loop.go
80.67% <0.00%> (-2.53%)
:arrow_down:

os/glog/glog_logger_rotate.go
61.99% <0.00%> (-1.36%)
:arrow_down:

net/ghttp/ghttp_request.go
83.45% <0.00%> (-1.28%)
:arrow_down:

net/goai/goai_shema_ref.go
77.21% <0.00%> (-0.84%)
:arrow_down:

... and 94 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Closed due to another code generating design in command gen ctrl.


Enable Autoreleases

This PR enables autoreleases as discussed in #92. It kicks in a release (fully automated, no human interaction is required, including promoting staging artifacts in Sonatype) when a version is updated to a non-SHAPSHOT in version.sbt. So anyone with a push access to a repository can cut releases now.
When release is performed, it bumps a version to a next one and commits the changes.
NOTE: We had to give up the build matrix. All PRs are kicking in a single job now that runs tests for cross-version Scala.
The credentials I used (everything is encrypted and can only be decrypted by Travis CI):

I generated a new deploy_key and added that to the repo (Github doesn't allow you to share them)
I used both secring and pubring gpg keys I generated for Finch releases (finagle-oauth2, finch-oauth2 use them too)
I used credentials.sbt with my Sonatype credentials (I have write access to all Finagle Org) and the GPG passphrase
I generated an ENC password used with aes-256 encoding via 1Password

Turns out my write access was limited to com.github.finagle, while finagle-posgres is published under io.github.finagle. I asked for new write access here: https://issues.sonatype.org/browse/OSSRH-44411. It was granted and the build should be green once new credentials are propagated. I will keep restarting it in the meantime.

Going to try changing the group id to see if that's about me no having access to io.github or about credentials not loading correctly.

So changing the group id helps. I'm going to reach out to Sonatype people and ask them double-check my credentials again.

Should be green now.


Allow text-indent to be specified for paragraphs

Long prose works tend to use leading indentation for paragraphs to visually separate them instead of a paragraph gap. Allow the text-indent property to be set on the prose key (or perhaps the paragraph key) in the theme.
The key part of implementing this feature is getting paragraph indentation to work so that it respects the line spacing (a known issue in Prawn).

+1

+1

This could also help cut down on the page count.

Any update on this? I think this is the number one limitation of asciidoctor for us right now, considering that I don’t know of any workaround to this, even ugly. Producing a one-page document is much more difficult when forced to vertically separate paragraphs. (And having no possibility to indent them effectively forces us to separate them.)

I'm currently using a fork that applies an updated version of #192 on top of current master, seems to do the job! The commit I'm running is https://github.com/jstasiak/asciidoctor-pdf/commit/80c5ce01c5d3819dbf1e042114d35a5c6ca0dedd if anyone's interested

There are two challenges we have to solve in order to implement this correctly:

our custom text formatter causes the indentation provided by Prawn to stop working
the space between paragraphs needs to be removed if the text indent is set
an option to override this behavior on a per-paragraph basis in cases when indentation is the wrong behavior

@rainboyan Have you been able to address these issues in your proposal?

To be clear, the PR #192 is incomplete, which is why it has never been merged.

our custom text formatter causes the indentation provided by Prawn to stop working

This no longer seems to be the case.

an option to override this behavior on a per-paragraph basis in cases when indentation is the wrong behavior

I think this should be handled in a follow-up issue.

the space between paragraphs needs to be removed if the text indent is set

My proposal is to add prose_margin_inner to control the margin between paragraphs. If we try to reuse margin_top and margin_bottom, we introduce all sorts of formatting edge cases that will be too big to solve as part of this change.

It would be nice to be able (in supplement?) to indicate intent (“I want to indent paragraphs rather than vertically separate them”) rather than fine formatting details (how large should the margin be).
I, for example, have no idea how much the margin should be if I choose to indent, and I’d be happy that Asciidoctor chooses reasonable defaults for me, once I have told it that I want “some” indent. (The intent being that the indentation should be visible but not huge, I suppose, and follow best practices known by typographers if any.) (Haha, intent of indent.)

You will have to provide a value. You can use variables to grab a value from somewhere else in the theme, but Asciidoctor will not guess.

Sorry, I just realized you were talking about themes. That’s fine, I suppose.
(My point was about document writers, not theme writers. I suppose this is a different issue.)

Yes, this is a theme issue. The writer won't do anything different. The publisher can now apply traditional paragraph indentation in the theme.


bug in gen types in Supabase CLI

Bug report
I have encountered a problem generating types with the CLI
supabase gen types typescript --db-url postgresql://postgres[PASSWORD]@db.[DB-ID].supabase.co:5432/postgres
First this fails with
Error: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
Why would Docker need to be running to generate types from a remote db? Fair enough if it does.. but this requirement is not in the docs:

And these docs are in any case incorrect. There are no --project-id or schema flags..
If I start Docker and Supabase and run supabase gen types typescript --db-url postgresql://postgres[PASSWORD]@db.[DB-ID].supabase.co:5432/postgres
then the error is: Error: error running container
System information

OS: macOS13
Version of supabase-cli: 1.6.0
Version of Node.js: 18.12.0

Additional context
Overall the Supabase Docs are letting the product down badly. They are inconsistent on don't exist at all. I urge you to please hire someone to maintain the docs full-time. It's no good building a fantastic product if we can't quickly figure out how to use it.

Hello @fergusmeiklejohn, could you try updating the CLI to the latest version? I will also update the docs to include the min supported CLI version as a prerequisite.
closed as duplicate #566

Right thanks very much! So the first problem is with Homebrew! I installed the supabase cli with brew, and there is some very weird bug in homebrew where it's requiring me to install a version of XCode which hasn't been released. See screengrab.

Maybe we should remove reference to HomeBrew in the docs and replace with npx ? https://supabase.com/docs/guides/cli
I'm a fan of npx, we get the latest version and we don't need to bother with global installs

I'm getting there with this but it's still in error.
First if I try to use the --db-url flag I get an error: Error: URL is not a valid Supabase connection string. but the docs don't indicate what a valid connection string should look like.
But then I realised that I can use --project-id anyway which is much better than --db-url, but there I'm getting a long way along the path but still getting an error:
Error: failed to retrieve generated types: {"message":"Failed to generate TypeScript types: permission denied for schema graphql","errorEventId":"4e76f0e66de8413683f1ea42c4d5b2ff"}

Maybe we should remove reference to HomeBrew in the docs and replace with npx ?

Yeah, I think we can add npm/npx as one of the installation options in that page.

but still getting an error

Hmm this looks like a bug in our Management API - I'll take a look at this and loop back here.

Local works:
npx supabase gen types typescript --local > DatabaseTypes.ts
🥳
Interesting that I'm using fig in the terminal which gives me autocomplete and --project-id is not offered isn't only
--db-url
--debug
--help
--local

npx supabase is installing Supabase CLI 1.11.3

Hey @fergusmeiklejohn! Sorry to follow up on an old issue - we've since updated the docs to default to using npm/npx as the installation method.
Regarding the permission denied for schema graphql error, this looks like an issue with that specific project - feel free to file a support ticket if you're still hitting into that and we'll get right on it.


Joystick not start after instalation

root@kali:/home/volt# git clone --recursive https://github.com/mitre-attack/joystick.git
Cloning into 'joystick'...
remote: Enumerating objects: 153, done.
remote: Counting objects: 100% (153/153), done.
remote: Compressing objects: 100% (92/92), done.
remote: Total 153 (delta 55), reused 147 (delta 49), pack-reused 0
Receiving objects: 100% (153/153), 1.04 MiB | 1.61 MiB/s, done.
Resolving deltas: 100% (55/55), done.
root@kali:/home/volt# cd joystick/
root@kali:/home/volt/joystick# pip3 install -r requirements.txt
Requirement already satisfied: aiohttp_jinja2 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 1)) (1.2.0)
Requirement already satisfied: pyaml in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 2)) (20.4.0)
Requirement already satisfied: pandas in /usr/lib/python3/dist-packages (from -r requirements.txt (line 3)) (0.25.3)
Requirement already satisfied: jinja2>=2.10.1 in /usr/local/lib/python3.8/dist-packages (from aiohttp_jinja2->-r requirements.txt (line 1)) (2.10.3)
Requirement already satisfied: aiohttp>=3.2.0 in /usr/lib/python3/dist-packages (from aiohttp_jinja2->-r requirements.txt (line 1)) (3.6.2)
Requirement already satisfied: PyYAML in /usr/lib/python3/dist-packages (from pyaml->-r requirements.txt (line 2)) (5.3.1)
Requirement already satisfied: MarkupSafe>=0.23 in /usr/lib/python3/dist-packages (from jinja2>=2.10.1->aiohttp_jinja2->-r requirements.txt (line 1)) (1.1.1)
root@kali:/home/volt/joystick# python joystick.py
File "joystick.py", line 24
async def init(address, port, services):
^
SyntaxError: invalid syntax
root@kali:/home/volt/joystick#

Admin note: closing all remaining issues and pull requests prior to archiving the repository


Relation with feathers-authentication

Sorry for not following the contribution guidelines but this issue is a question.
This project seems to be a new one, I'm wondering what is the relation of this module with the already existing https://github.com/feathersjs/feathers-authentication ?

Not a problem.  There used to be a client folder in the feathers-authentication repo.  It has been moved instead to this repo.  It's undergoing a refactor before we publish it as a separate module, though.  So, for now, you can just continue to access the client authentication plugin like this:
import authentication from 'feathers-authentication/client';

Once this module is complete and published, you'll do
import authentication from 'feathers-authentication-client';

OK I see, thanks!


[Bug]:

Is there an existing issue for this?

[X] I have searched the existing issues

In which area is the issue?
User Interface
In a specific sample?
appwidgets
What happened?
Hello there
I can't get a unique datastore per widget with Glance beta01. In your samples, there is a mention to it, but could you clarify how to inject the key in the datastore name ?
Question asked on SO (feel free to close this issue) : https://stackoverflow.com/questions/76563756/android-datastore-how-to-create-it-with-a-dynamic-filename/76564053
Thanks
From https://github.com/android/platform-samples/blob/main/samples/user-interface/appwidgets/src/main/java/com/example/platform/ui/appwidgets/glance/weather/WeatherInfoStateDefinition.kt :
/**
 * Use the same file name regardless of the widget instance to share data between them
 *
 * ====>>>>>If you need different state/data for each instance, create a store using the provided fileKey<<<<<<=====
 */
private val Context.datastore by dataStore(DATA_STORE_FILENAME, WeatherInfoSerializer)

override suspend fun getDataStore(
    context: Context,
    fileKey: String
): DataStore<SingleWidgetInfo> {
    return context.datastore // How to use fileKey while creating the datastore ?
}

Relevant logcat output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

With the new glance release the concept of glance state is no needed anymore you should use recomposition and/or standard storage patterns with data store, DB or others


Icon-button: size inconsistency

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
The size of the icon-button was inconsistent with and without an href.
To fix it, I adjusted the box-sizing of both elements.

📦 Published PR as canary version: 20.34.5--canary.739.9f967884e958b4daa233994ae4ca27585414f482.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Actually I think the icon-button users will experience the same issue that was raised for the Status component. That when the tertiary variant is used, the padding stays the same. We should add some conditional logic here, so it gets removed, when there is no border (as the case in the tertiary variant)

Actually I think the icon-button users will experience the same issue that was raised for the Status component. That when the tertiary variant is used, the padding stays the same. We should add some conditional logic here, so it gets removed, when there is no border (as the case in the tertiary variant)

Can you clarify the issue? Why should the padding not stay? If you're talking about the fact that on tertiary variant, because of the padding, it feels like the user clicks a bit outside the visible icon itself, then I already spoke with Benedikt and designers a long time ago about this, and I remember them saying that it should stay this way because the component is always used in combination with other components/elements, and this spacing is needed.

Actually I think the icon-button users will experience the same issue that was raised for the Status component. That when the tertiary variant is used, the padding stays the same. We should add some conditional logic here, so it gets removed, when there is no border (as the case in the tertiary variant)

Can you clarify the issue? Why should the padding not stay? If you're talking about the fact that on tertiary variant, because of the padding, it feels like the user clicks a bit outside the visible icon itself, then I already spoke with Benedikt and designers a long time ago about this, and I remember them saying that it should stay this way because the component is always used in combination with other components/elements, and this spacing is needed.

see this issue: https://github.com/Infineon/infineon-design-system-stencil/issues/765

Actually I think the icon-button users will experience the same issue that was raised for the Status component. That when the tertiary variant is used, the padding stays the same. We should add some conditional logic here, so it gets removed, when there is no border (as the case in the tertiary variant)

Can you clarify the issue? Why should the padding not stay? If you're talking about the fact that on tertiary variant, because of the padding, it feels like the user clicks a bit outside the visible icon itself, then I already spoke with Benedikt and designers a long time ago about this, and I remember them saying that it should stay this way because the component is always used in combination with other components/elements, and this spacing is needed.

see this issue: #765

Does this issue exists on this PR?

Actually I think the icon-button users will experience the same issue that was raised for the Status component. That when the tertiary variant is used, the padding stays the same. We should add some conditional logic here, so it gets removed, when there is no border (as the case in the tertiary variant)

Can you clarify the issue? Why should the padding not stay? If you're talking about the fact that on tertiary variant, because of the padding, it feels like the user clicks a bit outside the visible icon itself, then I already spoke with Benedikt and designers a long time ago about this, and I remember them saying that it should stay this way because the component is always used in combination with other components/elements, and this spacing is needed.

see this issue: #765

Does this issue exists on this PR?

what do you mean?
its the same case with using the tertiary variant. The border gets hidden, the spacing stays.

what do you mean? its the same case with using the tertiary variant. The border gets hidden, the spacing stays.

But this is how it is in the design, and this is how I was told to do it.
I also think it's not exactly the same case. In the case of the status, there's only a padding-left, wheres in the icon-button, the padding is on all sides.
Let's clarify with the designers to be sure.

what do you mean? its the same case with using the tertiary variant. The border gets hidden, the spacing stays.

But this is how it is in the design, and this is how I was told to do it. I also think it's not exactly the same case. In the case of the status, there's only a padding-left, wheres in the icon-button, the padding is on all sides. Let's clarify with the designers to be sure.

Yes, can you please clarify this? because I agree with Matthias, this is not great when used in rows

@radikantchris reviewed it, and gave the approval.


[MSI-Installers] JavaSoft keys not removed at uninstall

To reproduce:

install Temurin 8 after that install Temurin 11 or 17
uninstall Temurin 11/17 and after that uninstall Temurin 8 : the registry "SOFTWARE\JavaSoft\Java Runtime Environment" keys remains on the system

If you uninstall Temurin 8 and after that uninstall Temurin 11/17 : the registry "SOFTWARE\JavaSoft\JRE" keys remains on the system
Normal behavior should be these keys to be removed after uninstall.
This happens because the component GUID for the JavaSoft keys are the same for all Temurin versions. This is a bug, because the registry keys are different for Temurin 8 and Temurin 11 or 17. ("SOFTWARE\JavaSoft\JRE" vs "JavaSoft\Java Runtime Environment")
Solution: the MSI component GUIDs should be different in Temurin 8 than in Temurin 11 or 17.

Hi,

This happens because the component GUID for the JavaSoft keys are the same for all Temurin versions.

I don't think component GUID will be the same as "Guid" is specified as "*" to generate random value.
https://github.com/adoptium/installer/blob/ce1b4858058ff90ca5866db66274d05f780170f7/wix/Main.wxs.template#L138
https://github.com/adoptium/installer/blob/ce1b4858058ff90ca5866db66274d05f780170f7/wix/Main.wxs.template#L142

Normal behavior should be these keys to be removed after uninstall.

Wix don't suppress the key because there are shared keys by multiple MSI.
https://github.com/adoptium/installer/blob/ce1b4858058ff90ca5866db66274d05f780170f7/wix/Main.wxs.template#L207
As you can read here : https://github.com/adoptium/installer/issues/64 :
And just one note to everyone :

MSI Installer works as is: If a registry key is handled by many installers, it will be removed only when the last installer is uninstalled.

So if we replace the JavaSoft (created by Oracle) key value with an Adopt value it will not delete the JavaSoft key when Adopt is uninstalled and will let the value CurrentVersion (Adopt Value which is missing) as is

See https://github.com/adoptium/installer/issues/124 too
You have probably other installer who have write to this registry keys before you started to install Temurin 8/11/17 ..

@douph1 Did you even tried to reproduce using the steps I provided?
Look in the latest installers, same GUID for JRE 8 and JRE 11:

Maybe wix is creating the GUIDs automatically from the key path name which is the same. The problem is having the same shared GUID for 2 different registry paths:
SOFTWARE\JavaSoft\Java Runtime Environment
and
SOFTWARE\JavaSoft\JRE
So, JRE 11 and 17 having the same GUID is ok, because they have the same registry path. But JRE 8 should have a different GUID because it has a totally different registry path. The issue can be easily reproduced by using a clean Windows installation and following the steps from the 1st post.

No, sorry I'm not on Windows now.
So it is probably for the same reason as this :
https://sourceforge.net/p/wix/mailman/message/28483068/
  ```

For a Component the Guid is related to the KeyPath.
The KeyPath is this reg key
wich is different for both installer you checked

=> SOFTWARE\JavaSoft\JRE\11
=> SOFTWARE\JavaSoft\Java Runtime Environment\1.8

But as explain in the link bellow :
>Properties in the registry path will only be resolved at runtime which means
that the property name is being used for guid generation.

I assume now that the Key for the KeyPath is literaly "SOFTWARE\JavaSoft\[ORACLE_JAVASOFT_BASE_KEY]\[ORACLE_VERSION_KEY]"

Have you time to propose a PR to fix this ?

Deleting
    <Property Id="ORACLE_VERSION_KEY" Value="$(var.OracleVersionKey)" />
    <Property Id="ORACLE_JAVASOFT_BASE_KEY" Value="$(var.OracleJavasoftBaseKey)" />
and
Replacing everywhere
[ORACLE_JAVASOFT_BASE_KEY] with $(var.OracleJavasoftBaseKey)
[ORACLE_VERSION_KEY] with $(var.OracleVersionKey)

Thanks

Yes, that could be a fix.
No one changes the value of ORACLE_JAVASOFT_BASE_KEY at runtime.
msiexec.exe /i "OpenJDK8U-jre_x64_windows_hotspot_8u392b08.msi" ORACLE_JAVASOFT_BASE_KEY=xxx.xxx.xxx

Even the Oracle msi doesn't use properties for these values, which aren't changing at runtime.

I just checked how Correto is doing it. They also don't use runtime properties in the msi installer

Yes it is a misunderstanding about variable vs property usage. I agree. It is not needed.

@adipiciu can you check that the change merged has fix the bug in latest build please ? if yes we can close the issue.
Thanks

@douph1 Yes, it fixes the problem for newer builds.


Make the Rust toolchain version user configurable

Adds a rust_toolchain (defaults to stable) to allow users to configure their preferred toolchain to use when building Rust binaries.
Change-type: minor

Created draft PR: https://github.com/balena-io/balena-cli/pull/2588

Created draft PR: https://github.com/product-os/environment-staging/pull/473

Created draft PR: https://github.com/balena-io/docs/pull/2502

Created draft PR: https://github.com/balenaltd/handbook/pull/68

Created draft PR: https://github.com/balena-io/balena-api/pull/4080

Created draft PR: https://github.com/balena-os/balena-supervisor/pull/2112

Created draft PR: https://github.com/balena-io/environment-staging/pull/1086

Created draft PR: https://github.com/balena-os/balena-engine/pull/333

I self-certify!


CMake fixes

A few minor fixes to CMake builds:

suppress warnings in Boost
remove ineffective CMake flag
select C++20 in CMake Actions job

OK. So this PR is now cycling on CI.
In the constexpr PR, however, I found a timeout. Is that anything you can control, John.

@johnmcfarlane the cmake build timed out twice on CI, so i added -O2 to your CXX flags, not knowing if that was exactly what you want or not. I had to do something like either that or cut out the cmake build from CI entirely. Or, which is often the cas for me, i missed somehing and had a misunderstanding.
Anyway, running in CI now OK with -O2

Yes release mode will fix this. I've been off the computer all day. Will get to this in an hour or so

release mode will fix this

OK. Thank you.

If you do decide to plow on with that, i would actually like to see an MSVC build on CMake, if that fits within your design it might be nice to have one of those for reference as we trudge on forward.

https://github.com/johnmcfarlane/wide-integer/pull/2


Bulk Loading Algorithm(s)

B-Trees have efficient algorithm(s) to populate a tree for later modification from a set of entries already in-order (or in-reverse order).  The algorithm is fast both in constant factors and asymptotically and creates a dense tree.  https://en.wikipedia.org/wiki/B-tree has details.

Well, I have an impl over in https://github.com/c-blake/adix of this.  The usual B-Tree invariants are violated in the course of this initial phase and require a final touch up at the end.  So, for example in Unix shell script-ese (I use Zsh , but it would probably work in Bash, too) you can do:
cd adix/tests
nim c ppss
nim c btshell
(for i in {1..100}; do echo A1 $i 0; done; echo D1 0; echo c; echo p)| ./ppss | ./btshell | less -R  # -R for color structure highlighting

The A1 $i 0s do the initial phase bulk add (with zero extra slots) while the D1 0 does the finalization/B-Tree invariant restoring part.  You can also do A1 $i 1 and D1 1 to do only 18, not 19.  (The default is a 10..20 link tree.)  That could help avoid some splits if you think you might add a few elements here & there after initial construction but still get you 18/19 = 95% utilization.  I suspect, but do not know for sure, that this algorithm can be generalized to allow any valid amount of spare space (well, less than half to satisfy the B-tree invariants anyway).
You'd need >~ 19*19=361 objects to start to see a third level which actually isnt' so bad if you pipe to a pager like less, but you could also just compile btshell with -d:btTall to get more structure sooner.  Tall is often more useful for debugging than benchmarking/actual use.


Fix demo/welcome-developer

For the reference of anyone checking this.
The generateKeypair() used inside of createDid() method and generateKeys used to generate the Keys in the application should both use same algorithm to get the scripts working.


2 extra func color

Hi again @s-n-g,
If you're happy with the change referenced in #2 I'll merge this? :)

I did not have the chance to test this one...
But, it's ok, I will and we can always revert, or... whatever :wink:

Hah I guess! It looked better than whatever color it was originally to my eyes at least. ;)

Ah, perhaps I misunderstood your previous comment and merged this anyway :sweat_smile:
I did test that one as well, as base08 is the color that we use for a few of the ui elements already. I think it's a safe bet - it stands out more than base0D since it's different from the statusbar so it's easier to notice that something is happening.
I don't like base0B as it's quite nice to leave the URL as the only element with that color (imo).
So are we good on base08?

Sure!
Go ahead!


[Accessibility] Adds built-in support for Screen Reader announcements

Summary
New Features
If data-autoselect is "true" on the auto-complete-element, pressing the "Enter" key will select the first option available, even if the input is focused and not the first option.
Reference Slack thread on this established pattern
Accessibility
If a <listbox_id>-feedback element is detected, the following screen-reader updates are announced:

when the options are loaded, how many are available
what the first option is and that pressing Enter will select it (if data-autoselect is true)
when an option is selected, that the option is selected
when the options are hidden, that they have been hidden

Some set up work was also done for client-side options, but that work will be tackled whenever #52 is prioritized.
cc @github/accessibility

I see the Action only defines Ubuntu and MacOS -- let me know if I should be adding Windows or if the settings should be updated to not require Windows.


df: fix "Size" header for multiples of 1000 & 1024

This PR fixes an issue with the "Size" header for block sizes that are multiples of both 1000 and 1024. So far, such block sizes were handled as multiples of 1024 with the corresponding suffixes (e.g. "K", "M", "G"). Now they are handled as multiples of 1000 with suffixes like "kB", "MB", and "GB", in the same way as is done by GNU df.
Example: 128_000 now becomes 128kB instead of 125K.

@jfinkels Feel free to merge these PRs if you think they're good!

I'll consider that in the future, thanks.


sendmmsg usage could drop UDPs unnecessarily

I'm not sure how much this can happen in practice, but handling of the count returned from sendmmsg() syscall seems not ideal.  Notably:

If only some of the packets were sent, the code acts as if all were sent (npkts is only tested for negative values).  Ideally it should call again on the remaining packets.  Some error happened in that case, but the sendmmsg() API doesn't provide it.
If no packets were sent, I'd consider failing just the first packet and retrying with the rest.  For some of the return codes at least:

EAGAIN etc. seem already handled;
I can imagine some specific return codes causing immediate failure for the whole batch, though I'm not sure it's worth writing a special case.

Yes, sendmmsg() API is cumbersome.

Following up from #3249, @santigimeno it seems to me that simply changing pkts to npkts here would fix at least the buggy aspect of this completely (which is dropping packets unnecessarily and silently). It would remove only sent packets from the queue and eventually loop around, send 0 packets and return.
Any chance we can get a patch release with just this fix?

it seems to me that simply changing pkts to npkts here would fix at least the buggy aspect of this completely (which is dropping packets unnecessarily and silently on partial sends). It would remove only sent packets from the queue and eventually loop around, send 0 packets and return.

@roshanr95 I think this is a sensible solution. Can you send a PR with that change?

@roshanr95 @santigimeno Please refer: https://github.com/libuv/libuv/pull/3265 for PR regarding the same.

Partially fixed by https://github.com/libuv/libuv/commit/6530ea2ff243161b4208aed9549fe2e4c6acc563


[AIRFLOW-1912] airflow.processor should not propagate logging

Make sure you have checked all steps below.
JIRA

[X] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1912

Description

[X] Here are some details about my PR, including screenshots of any UI changes:
The root logger will write to stdout. If redirection is used
which is the case for processors and task runs (not runners)
this can end up in an endless loop in case propagation is True.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Config dependent.
Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

[=X] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@TrevorEdwards @jgao54 @Fokko

Codecov Report

Merging #2871 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2871      +/-   ##
==========================================
- Coverage   74.04%   73.96%   -0.09%
==========================================
  Files         160      160
  Lines       12157    12157
==========================================
- Hits         9002     8992      -10
- Misses       3155     3165      +10

Impacted Files
Coverage Δ

airflow/config_templates/airflow_local_settings.py
100% <ø> (ø)
:arrow_up:

airflow/task_runner/bash_task_runner.py
93.33% <0%> (-6.67%)
:arrow_down:

airflow/utils/helpers.py
53.44% <0%> (-2.88%)
:arrow_down:

airflow/jobs.py
79.44% <0%> (-0.45%)
:arrow_down:

airflow/executors/dask_executor.py
81.39% <0%> (+2.32%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 683a27f...19a00ff. Read the comment docs.

lgtm! good catch.


docs: Use definition lists for parameter descriptions to enable full markdown support be

Fixes #900
This PR brings full markdown support for parameter descriptions in the py-shiny docs. We originally tried using a grid table for writing the parameters table (and just for the parameters table), but I think definition lists are much easier to read.
This PR also adds some CSS to the dev docs to nudge the spacing of the definition list. We'll need to make sure similar rules are applied to the primary docs when we do our next release.
Updated documentation

[x] ui.layout_columns()
[x] ui.layout_column_wrap()
[x] Other functions...?

cc: check this out, @machow!

I'm super curious about the lingering character quarto is adding?! I'm going to work on bringing in support for list-style parameter tables, similar to https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.html#pandas.DataFrame
WDYT of that style for parameters / table-y things? (obv for down the road, this PR is beautiful)

Oh wow, that was fast! @has2k1 has definition lists implemented in plotnine for his quarto migration too: https://has2k1.github.io/plotnine/reference/geom_bar.html#plotnine.geoms.geom_bar
I'll try and add an option for these in the next few days in quartodoc, based on all y'all's work!

@schloerke thanks to Michael's suggestion, I tried definition lists and think they're a big improvement. The custom writer here works and this PR is ready to merge after your review.
I did try upgrading to quartodoc 0.7.2 and griffe 0.33 to see if we could use DefinitionList from quartodoc.pandoc. It would be very nice and it'd be as simple as replacing our custom dl renderer with all of str(DefinitionList(rows)).
That said, I ran into issues trying to render the docs with the newer package versions. If you see an easy fix that'd be great, but we could just as easily merge this now and come back to a quartodoc upgrade later.

In a followup PR, please look at how the styling for the code in the definition term has changed from before to the new look. It also looks like all of the fonts are of a heavier weight

That's the difference between the dev docs and the released/published docs


Calls to find_dependency with package name 'glew' fail.

Describe the bug
Calls to find_dependency with package name glew fail even when the library is installed.
Environment

OS: Windows 10 64 bit, OS build 19042.804
Compiler: MSVC 19.28.29337.0
Vcpkg package management program version 2021-01-13-d67989bce1043b98092ac45996a8230a059a2d7e

To Reproduce
Steps to reproduce the behavior:

./vcpkg install glew:x64-windows
call find_dependency(glew) in a package config file
should report that dependency glew could not be found
OR
./vcpkg install glew:x64-windows
call find_package(glew)
variable glew_FOUND will be undefined

Expected behavior
Call to find_dependency(glew) should succeed.
Additional context
I'm not entirely sure why this is happening, but I do know what the problem is. It seems that for some reason the call to
find_package(glew) does not set glew_FOUND, but instead sets GLEW_FOUND . Both variations of the find_package call
do successfully find the package, but they only report under the package name GLEW. This is different from the behavior of
of other libraries, for example find_package(fmt) sets fmt_FOUND and find_package(FMT) sets FMT_FOUND, in both
instances correctly locating the library.
This is clearly not a serious issue, and even if it can't be fixed I'd like this issue report to exist in case someone else stumbles across the same issue.

@errata-c
Thanks for reporting this issue to us. About the Step #2: call find_dependency(glew) in a package config file, could you please provide us with a demo repro(cmake project)?

Ok, I have a minimal reproduction here, fails to build on my system.

Thnanks for your reply. I could reproduce this issue in my side, and I'm trying to fix it.
BTW, If you have any suggestions to fix this issue, please let me know. Thank you!

I've managed to fix this issue on my end, but using a method I'm not sure is reliable.
It seems the issue is in the vcpkg-cmake-wrapper.cmake file, inside that file there is a call to _find_package using the uppercase name GLEW. This explains why it always reported found with the upper case name. The way I fixed it was using the ${PACKAGE_NAME} variable defined in the find_package function in vcpkg.cmake. However, I'm not sure if I can rely on this variable always being available. This also shows that its possible any other vcpkg-cmake-wrapper.cmake file could also have a hard-coded package name, and thus also have this exact same issue.

@errata-c Thanks for looking into this issue.
I think the key point we discuss here is why we use GLEW here instead of how to fix it. As you can see here https://github.com/microsoft/vcpkg/pull/7967#issue-312273877.
@Neumann-A
Could you please help comment something here?
Thanks.

Just do:
set(glew_FOUND ${GLEW_FOUND}) in the cmake wrapper?

That will work for the lower case name. The cmake docs say that names in find_package calls will be treated as case-insensitive (https://cmake.org/cmake/help/latest/command/find_package.html#search-procedure). In order to support this, without changing anything else in the cmake wrapper, I recommend adding set(${PACKAGE_NAME}_FOUND ${GLEW_FOUND}). This guarantees the right name is reported back, not just the uppercase and lowercase. This will not  break anything in PR #7967.

The cmake docs say that names in find_package calls will be treated as case-insensitive

that is incorrect. This only applies to <lowercasepackagename>-config.cmake. Everything else will be case sensitive.
So the question here is does glew install its own config as  glew-config.cmake.

You can try it yourself, call find_package with a random set of upper and lower case letters for a package name. It works, I just tried it since you made me doubt myself. While yes, the config file can only be one of two forms, the find_package function is much more lenient. The docs I just linked say: "In all cases the  is treated as case-insensitive and corresponds to any of the names specified ( or names given by NAMES)."

You can try it yourself, call find_package with a random set of upper and lower case letters for a package name. It works, I just tried it since you made me doubt myself. While yes, the config file can only be one of two forms, the find_package function is much more lenient. The docs I just linked say: "In all cases the is treated as case-insensitive and corresponds to any of the names specified ( or names given by NAMES)."

Platform? Probably Windows or WSL

Okay, I've tried it on Windows 10, and Ubuntu 5.8.0. Works on both.

Sorry, I misinterpreted what you meant by "This only applies to -config.cmake. Everything else will be case sensitive." I assumed you were talking about the naming required for package config files themselves. After reading the CMake source (https://github.com/Kitware/CMake/blob/master/Source/cmFindPackageCommand.cxx lines 625 to 629) I see what you mean. It just so happens that all the packages I tried were the <lowercasepackagename>-config.cmake variety. Regardless, looking the installed package files for glew, it does have a glew-config.cmake, so using set(${PACKAGE_NAME}_FOUND ${GLEW_FOUND}) is still valid.

you mean: set(${CMAKE_FIND_PACKAGE_NAME}_FOUND ${GLEW_FOUND})

Well the cmake wrapper calls the actual find_package function internally, which changes the CMAKE_FIND_PACKAGE_NAME variable. The PACKAGE_NAME variable defined by vcpkg itself is still valid at that point.

If you use the module mode in find_package, according to the cmake docs, you should use find_package(GLEW REQUIRED), please note the upper-case.
And, the var GLEW_FOUND is set to ON when glew was found.

Thanks for posting this issue. This issue hasn’t been updated in five months. Please reopen this issue if this is still a problem for you.


Features & Issues draft

-Appwise : fix Perfomance issues (delay on loading), design, fluidity, error/bug handling, test, sessions, cookies, security, refactor dbb,
-Account settings and specifications
-Blogs/Journals
-Profile Page : redo server request to fit page demand, modify url/endpoint to reach backend,
-Game Page :initiate server request to fit page demand
-Team Page: initiate server request to fit page demand
-Leagues ?

Layout Implementation
method : As I go.
Current stage : Profile page.


Saved image via C# on Linux is not the same as in realsense viewer

Required Info

Camera Model
D415

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 18.04.2 LTS

Kernel Version (Linux Only)
4.14.107-157

Platform
Odroid XU4

SDK Version
2.20

Language
C# dotnet core 2.2

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
The images that are saved are not what I except on Windows and that is showed on Realsense Viewer.
The image looks like this in my program

but looks like this in Realsense-Viewer

Here is the important code
pipe = new Pipeline();
            colorizer = new Colorizer();
            colorizer.Options[Option.MaxDistance].Value = 2.3f;
            var cfg = new Config();
            cfg.EnableStream(Stream.Depth, 1280, 720, Format.Z16, 30);
            var profile = pipe.Start(cfg);

using (var frames = pipe.WaitForFrames())
{
	using (var depth = frames.DepthFrame)
	{
		VideoFrame img = colorizer.Process<VideoFrame>(depth).DisposeWith(frames);
		bmp = new Bitmap(img.Width, img.Height, img.Stride, PixelFormat.Format24bppRgb, img.Data);
		bmp.Save(DateTime.Now.ToString("yyyyMMddHHmmss")+".png");
	}
}

As extra info as what is wrong with the picture. There is only one pole on the left corner as seen in the jet color image, however on the image that is saved there are 2 poles. The image is thinner and partly duplicated when converting the image to a BMP.

If you just want to display a black and white image in the RealSense Viewer, simply go to the drop down menu Stereo Module/Depth Visualization/Color Scheme and pick White to Black or Black to White instead of Jet.

@AntoineWefit That is not the issue here. The issue is that I want it reversed. In Windows the same application gives a Jet colorized image. The image from the application on Linux is hard to explain whats wrong with it but it is squized and partly duplicated on the right side.

Hi @StarlightNL,
Per the description, your C# program is running on Odroid XU4 + Ubuntu 18.04, right?
I don't observe this issue on Win10 + librealsense 2.21.0 + D415 firmware <IP_ADDRESS> + .NetFramework 4.5.2.

@RealSenseCustomerSupport
That is right. The only thing is that the application is running on .net core 2.2 and not on the standard .netframework, however after searching I am going to try to compile libgdiplus that is used with System.Drawing on the odroid and see if that fixes the drawing problems.
The following info will also be included in the original post.
As extra info as what is wrong with the picture. There is only one pole on the left corner as seen in the jet color image, however on the image that is saved there are 2 poles. The image is thinner and partly duplicated when converting the image to a BMP.

Hi @StarlightNL,
Any good news to resolve the issue?

I don't observe this issue based on opencv on Odroid XU4 to display the depth image. It should be related to .NetCore.

Hi @StarlightNL,
Still need any support for this issue? Did you also check with Odroid forum to see if any help?

If no further questions, will close this.


Fixes typo in themes/_index.md

Corrects misspelling of sync (synch)

FTR, “synch” is an acceptable variant of “sync” and is not a misspelling.

“Synch” isn’t commonly used, at least in general writing. Check the Oxford English Dictionary or Merrimack-Webster and you’ll see they list “sync” instead.


Dev: Invalid module "node_modules/bin/vite-ssr" on Windows

Okay, I know Windows sucks for development, but we're building some things that must also run on Windows 😞

npm run dev on Windows 10 brokes with the error:
TypeError [ERR_INVALID_MODULE_SPECIFIER]: Invalid module "~/node_modules/.bin/vite-ssr"

node_modules/.bin/vite-ssr file exists but is not a JS module (and shouldn't be I guess).
Any ideas? May be an issue of https://github.com/antfu/vitesse itself?

Using node v14.17.3 and npm 6.14.13

@leomp12 Can you try modifying node_modules/.bin/vitedge, line 66 from args.unshift('node_modules/.bin/vite-ssr') to args.unshift('./node_modules/.bin/vite-ssr') (adding ./)?
I don't use windows so I'm not sure if that will fix it 🤔

@frandiox sorry for the delay, I was not using Windows past days.
Now I can't because the line doesn't exists here 😄
$ cat node_modules/.bin/vitedge
#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*|*MINGW*|*MSYS*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  "$basedir/node"  "$basedir/../vitedge/bin/cli.js" "$@"
  ret=$?
else
  node  "$basedir/../vitedge/bin/cli.js" "$@"
  ret=$?
fi
exit $ret

node_modules/.bin/vitedge is also not a JS module here, it's a shell script 😐

@leomp12 Oh wow, some NPM/Windows magic. In that case, please check node_modules/vitedge/bin/cli.js.

I have downloaded this repository and am having this problem as well. The system I am using is MacOS.


Send mail with bash script using SMTP

Classification

[X] Question

Description
Hi ,
I have a question (maybe dumb one), how i can send an email direcly from console ?
i can't figure how to send email with docker with my script
`#!/bin/bash
MAX=80
<EMAIL_ADDRESS>PART=sda1
USE=df -h |grep $PART | awk '{ print $5 }' | cut -d'%' -f1
if [ $USE -gt $MAX ]; then
echo "Percent used: $USE" | mail -s "Espace disque insuffisant" $EMAIL
fi`
Thank you

You can use MSMTP or SSMTP.
https://github.com/hardware/mailserver/issues/162

Thank you !
installed MSMTP and i work great!
here the config you need to get it work with mailserver ;
nano ~/.msmtprc
account default
host mail.domain.tld
port 587
from<EMAIL_ADDRESS>tls on
tls_certcheck on
tls_starttls on
tls_trust_file /etc/ssl/certs/ca-certificates.crt
auth on
user<EMAIL_ADDRESS>password XXXXXXXXXX
account default: default

chmod 600 ~/.msmtprc
then send mail with;
printf "Subject:Hello\n,This is message" | msmtp -a default<EMAIL_ADDRESS>(printf better than echo, to avoid spam reject 500)


live session

A live session could be implemented as a variation on the attack model, such as:

"canary in the coalmine" (see TAPAS): add unique record $canary$ (outside of domain?!) and guess if synthetic data is trained on $train \cap {target}$ XOR $train \cap {canary}$
pickled: a pickled version of the synthetic generator is shared with the task

Any other suggestion?

EKANS?


Start writing encounter system

Still needs plenty of work, I started making the SlopScoreEncounter inherit from Reptile.Encounter, but that might wanna be changed. We also probably wanna look into how to use the notification UI for telling players a score battle was requested or something like that

I'll merge this and play around a bit - thanks!


Authentication Solution

I was having the same authentication issues as everyone has been reporting recently, but I solved them by enabling 2FA on my Google account and creating an app password for Raccoon. I think they view signing in from a strange application as less suspicious with a dedicated app password than with your normal password. You might consider updating the documentation to suggest this process if other people can replicate my results.

oh, thanks so much, you help me alot.
1000 like :)

Made a note of this in my blogpost: https://raccoon.onyxbits.de/blog/bad-authentication-google-account-blocked/
Though I'm still looking for a better way. My current working theory is that Google partially rolled out an account manager update (A/B testing) that either dropped support for Jelly Bean (Raccoon mimics the JB TLS stack) or factors in something from the environment ("what else came from that IP address?") that results in blocked login attempts.

this kind of solution seems pretty unstable.
way before, when i openet the first ticket about this problem i did try to auth using app password with no success.
now it works
very unpredicted behaviour...

Looks like google has fixed it. Is there any other way? plz.

Looks like google has fixed it. Is there any other way? plz.

Looks like google has fixed it. Is there any other way? plz.

yup, create app password not work anymore.

Any news about this? App passwords stopped working for me as well.

Please try the latest (v4.19.0) version. It might solve the problem.

v4.19.0 solved the problem for me, thanks.

@babyquin
fixed

@onyxbits
thanks, waiting update login method for DummyDroid. :)

@babyquin
fixed

Thank you so much! you are the best 👍

Let us see how long the version increase to API level 17 (Android 4.2) will work.
After disabling Google services for pre 4.x devices Google seems to prepare the next step, now focusing on devices up to Android 4.3: https://www.androidauthority.com/android-jelly-bean-eol-1641403

Do I need to generate new profile to make it work with 4.19.0? I tried logging in with older profile and still get same error:
raccoon -Draccoon.playprofile=d***r --gp-auth
org.apache.http.client.ClientProtocolException: BadAuthentication
	at com.akdeniz.googleplaycrawler.Identity.doPost(Identity.java:192)
	at com.akdeniz.googleplaycrawler.Identity.signIn(Identity.java:153)
	at com.akdeniz.googleplaycrawler.GooglePlayAPI.login(GooglePlayAPI.java:319)
	at de.onyxbits.raccoon.cli.Play.auth(Play.java:371)
	at de.onyxbits.raccoon.cli.Router.main(Router.java:137)
	at de.onyxbits.raccoon.Main.main(Main.java:59)

It is on website & github long ago…  still does not work for me

v4.19.0 is available on the website as .jar and .exe files (https://raccoon.onyxbits.de/apk-downloader/), but the most current version on Github is still v4.18.0 (https://github.com/onyxbits/raccoon4/releases).

@acornsirup
Forgot to push the tags.
Fixed
Thanks.


Proper Way to deploy with MDT

I wanted to know what is the proper way to deploy this script during a MDT deployment, right now I have it running as soon as possible, so as soon as admin is logged into windows and starts running tasks, is there a better way to implement this before the admin user is even created?
Regards

I used to have it run during image generation, as last step before capturing, but after some recent complications (calculator gone and can't get it back) I've changed it to be done after deployment, as one of the last steps, after importing my custom start menu layout. That seems to work fine.
I don't think this script can work on offline Windows installations, which might allow running it before creating any user profiles on the deployed image. Maybe that could be done with Remove-AppxProvisionedPackage -Path F:\oo?

@abruening-iwt  You can run it during the Reference Image MDT Process and works perfectly

This is how i cave the script running under the Task Sequence.

I have it as one of the last things in my task sequence during deployment. Never had a problem.


documentation for amino encoding

https://github.com/scrtlabs/secret.js/blob/master/DEVELOPERS.md

@assafmo my guess is that, there is no standard for timestamp (date) or duration?

Timestamp is a string of nanoseconds since unix epoch (UTC+0).
https://github.com/scrtlabs/secret.js/blob/7c5b302bc35b81fd7848fa4c18ddc8860fe65d8a/src/tx/ibc_transfer.ts#L62

My guess is that duration is also a string of nanoseconds... Is there a Msg with a duration typed field?

https://github.com/scrtlabs/secret.js/blob/7c5b302bc35b81fd7848fa4c18ddc8860fe65d8a/src/tx/ibc_transfer.ts#L62

do you think there's a reason it's just toString() here?
https://github.com/cosmos/cosmjs/blob/main/packages/stargate/src/modules/ibc/aminomessages.ts#L88

My guess is that duration is also a string of nanoseconds... Is there a Msg with a duration typed field?

In osmosis:
https://github.com/osmosis-labs/osmojs/blob/main/packages/osmojs/src/proto/osmosis/lockup/tx.amino.ts#L48
https://github.com/osmosis-labs/osmojs/blob/main/packages/osmojs/src/proto/osmosis/lockup/tx.amino.ts#L62-L65
but I'm not sure it's a standard... I'm trying to figure out what other chains are doing. If they're not yet using it, perhaps osmosis' way should be so we can standardize the amino.

My guess is that duration is also a string of nanoseconds... Is there a Msg with a duration typed field?

In osmosis: https://github.com/osmosis-labs/osmojs/blob/main/packages/osmojs/src/proto/osmosis/lockup/tx.amino.ts#L48 https://github.com/osmosis-labs/osmojs/blob/main/packages/osmojs/src/proto/osmosis/lockup/tx.amino.ts#L62-L65
but I'm not sure it's a standard... I'm trying to figure out what other chains are doing. If they're not yet using it, perhaps osmosis' way should be so we can standardize the amino.

Duration & Amino are defined in cosmos-sdk, so I imagine what's working for Osmosis will work everywhere else

Okay so Duration in proto leads here which leads here, so Duration is int64 which is a string

Re timeout_timestamp in MsgTransfer, specifically here it's uint64 and not google.protobuf.Timestamp. I beleive that google.protobuf.Timestamp converts to an RFC 3339 string with a timezone of UTC+0 (example).

Updated DEVELOPERS.md: https://github.com/scrtlabs/secret.js/commit/a1d3636b81278b20da4ef122b7c54182ea622d36 :grimacing:

Is this working? From the docs this has to be "0" if undefined ("0" is working for me in production).

I've only tried it by specifying timeoutTimestamp. https://github.com/cosmology-tech/cosmology/blob/main/packages/cli/src/commands/ibc-transfer.ts#L218-L224
I'll be testing this more: https://github.com/osmosis-labs/telescope/issues/141

thank you so much @assafmo your knowledge and research is greatly appreciated! this thread is GOLD!


BENDRClassifier Error

Hello, I'm trying to follow the basic.ipynb walkthrough with the use of BENDR model provided from the bendr branch . The problem is on the process.fit() method and more specifically, on models.py line 116:
def forward(self, *x):
        features = self.features_forward(*x)
        if self.return_features:
            return self.classifier_forward(features), features
        else:
            return self.classifier_forward(features)

By adding the .t() pytorch method  on the
return self.classifier_forward(features.t()), features

the error seems to be solved. I believe this may occur somewhere else also.
Moreover, the BENDR model seems to not apply the batch size configuration from .yml file. I set a batch size of 4 and an error occured.  When setting to 11 (magic number) the model is training.
Thank you in advance for your time and the incorporation of BENDR on dn3 library!

Yup, those are some strange errors... Thanks for bringing this to my attention. I've managed to use this module without problems before somehow, but despite that there was a blatant bug in the BENDRClassifier code.
I think I've fixed it now in the attached PR, but it doesn't explain how you get it working with the magic number...
Would you mind running the following test before I merge (from within dn3/tests) python3 -m unittest testTrainables.TestIncludedModels


Look forward to seeing a more detailed readme file soon

Look forward to seeing a more detailed readme file soon，Thank you very much

I'm looking forward to it, too


How to reduce line height (gap between lines) in left and right panes to 1 or 2 empty pixel lines?

I want to see as many lines in left and right panes WITHOUT having to scroll.
Therefore I want to reduce line height or more precisely:
Reduce the space gap between two lines.
1 or 2 empty white pixel rows are enough.
How can I achieve this?

Hi! You cannot reduce only the line height. If it will help, you can zoom the font size in and out by pressing Ctrl and rolling the mouse wheel on the left and right pane.