Random "Error: no such type" errors on creating tasks

Environment details

OS:  Google Cloud Functions
Node.js version: 10
@google-cloud/tasks version: 2.3.6

Randomly, the creation of a task will generate the following error and fail:
Error: no such type: google.rpc.ErrorInfo
    at Root.lookupType (/workspace/node_modules/@google-cloud/tasks/node_modules/protobufjs/src/namespace.js:383:15)
    at FallbackErrorDecoder.decodeProtobufAny (/workspace/node_modules/@google-cloud/tasks/node_modules/google-gax/build/src/fallbackError.js:35:32)
    at result.details.status.details.map.detail (/workspace/node_modules/@google-cloud/tasks/node_modules/google-gax/build/src/fallbackError.js:50:56)
    at Array.map (<anonymous>)
    at FallbackErrorDecoder.decodeRpcStatus (/workspace/node_modules/@google-cloud/tasks/node_modules/google-gax/build/src/fallbackError.js:50:37)
    at FallbackErrorDecoder.decodeErrorFromBuffer (/workspace/node_modules/@google-cloud/tasks/node_modules/google-gax/build/src/fallbackError.js:63:46)
    at fetch.then.then (/workspace/node_modules/@google-cloud/tasks/node_modules/google-gax/build/src/fallback.js:357:57)
    at process._tickCallback (internal/process/next_tick.js:68:7)

This is my code for task creation:
const { v2beta3 } = require("@google-cloud/tasks");
const client = new v2beta3.CloudTasksClient({ fallback: true });
const config = require('./config');
const admin = require("firebase-admin");
const {sendErrorOrder} = require('./mailer.js');

const queue_order = async (payload) => {
    return new Promise(async function (resolve, reject) {
        const serviceAccountEmail = config.default.serviceAccount;
        const project = config.default.projectID;
        const queue = "order-queue";
        const location = "us-central1";
        const url = config.default.processQueueURL;
        const formattedParent = client.queuePath(project, location, queue);
        const task = {
          httpRequest: {
            httpMethod: "POST",
            url: url,
            body: Buffer.from(JSON.stringify(payload)).toString("base64"),
            headers: {
              "Content-Type": "application/json"
            },
            oidcToken: {
              serviceAccountEmail
            }
          }
        };

        const request = {
          parent: formattedParent,
          task: task
        };

        var newTask;
        const call_options = {
          timeout: 200000 // millis
        }
        try {
            newTask = await client.createTask(request, call_options);
            resolve('Success');
        } catch (error) {
            console.log(error);
            console.log('Task creation failed, trying again.');
            try {
                newTask = await client.createTask(request, call_options);
                resolve('Success');
            } catch (error) {
              console.log(error);
              console.log('Task creation failed again, trying one more time.');
              try {
                  newTask = await client.createTask(request, call_options);
                  resolve('Success');
              } catch (error) {
                  console.log('Task creation for order ID ' + payload.id + ' failed, giving up.');
                  await sendErrorOrder(payload.id);
                  reject('Failed');
              }
            }
        }
    });
}

I added the retries to try to address the failures, but sometimes it will still fail all 3 in a row.

Hi @ericalderman-emilio , can you update to v2:
- const { v2beta3 } = require("@google-cloud/tasks");
+ const {CloudTasksClient} = require('@google-cloud/tasks');

- const client = new v2beta3.CloudTasksClient({ fallback: true });
+ const client = new CloudTasksClient();

Also do you need to set fallback to true?

OK I will try that and watch to see if it still happens.
I'm setting fallback to true because of earlier encountering DEADLINE EXCEEDED errors, and this was a suggestion on one of the forums about that.  Do you not recommend it?  Same with setting a timeout in call_options.
Thanks!

I see. Did updating the library help solve the no such type problem? If it did then you can try adding back in the timeout and fallback.

So far I've upgraded the library and left in the timeout and fallback.  So far I haven't seen any errors, but the issue was only happening every few days, so I'll give it some more time.  Do you recommend removing the timeout and fallback?

The fallback and timeout should be fine if you aren't experiencing the "no such type" error.

OK I'll leave them for now then.  Thanks again for the help!


isin method not founf in dataframe  object

python 3.5, dask 0.14.0
I get the following error when trying to use:
dask_dataframe[['col1', 'col2']].isin(pandas_Series).all(axis=1)
AttributeError                            Traceback (most recent call last)
<ipython-input-21-64b84af10254> in <module>()
----> 1 II_mask = PaxData_filtered[['Origin Name', 'Destination Name']].isin(KeyStations).all(axis=1)

C:\Users\jabellan\AppData\Local\Continuum\Anaconda3\lib\site-packages\dask\dataframe\core.py in __getattr__(self, key)
   2121             return new_dd_object(merge(self.dask, dsk), name,
   2122                                  meta, self.divisions)
-> 2123         raise AttributeError("'DataFrame' object has no attribute %r" % key)
   2124
   2125     def __dir__(self):

AttributeError: 'DataFrame' object has no attribute 'isin'

However, 'isin' method is implemented according to the documentation:
http://dask.pydata.org/en/latest/dataframe-api.html
Thanks for your help!

The isin method is implemented for Series, but not for DataFrame (if you look, you'll see that isin is in the docs only for Series). Implementing it for DataFrame wouldn't be too hard, if you'd care to make a pull request.

Thanks for the clarification. I will give it a try, but it is probably above my skill level.


Warp Support

I was wondering if you'd consider adding support for Warp.
Using this operator, we could allow the tunnel to be created and configured in K8s. Maybe it could function as data a ClusterTunnel's TunnelSpec? Adding a string type for a private CIDR would also allow the operator to use cloudflare-go's CreateTunnelRoute API - which is also a part of routing traffic to a  warp-enabled tunnel.
Lastly, I see it as part of the struct in cloudflare_configuration.go but I think it would need to be written into the ConfigMap for the tunnel pods to use.

That can be done, yes. As you note, the tunnel spec can contain the warp enable flag. But for adding the actual routes; tunnel spec could be extended to include the routes, but checking the diff with the routes already added to the tunnel might be a bit of a pain. Any idea to make that easier?

I was thinking about this some more. We can likely manage diffs / what's owned by the operator via the Comments section of the Tunnel Route. https://pkg.go.dev/github.com/cloudflare/cloudflare-go#TunnelRoutesCreateParams. Similar to some of the code which reconciles using data in the TXT record.
In the past I've set them up using the following steps:

Create a tunnel
Add warp-routing.enabled = true to the tunnel's configuration file
Call cloudflared tunnel route ip add <IP/CIDR> <Tunnel NAME or UUID>

Warp Instructions
As for the design, I had some thoughts. The Warp feature is a facet of the tunnel. It aligns with the TunnelBinding CR.
The operator could support an additional Kind in the TunnelBindingSubject part of a TunnelBinding resource:
apiVersion: networking.cfargotunnel.com/v1alpha1
kind: TunnelBinding
metadata:
  name: example
tunnelRef:
  kind: ClusterTunnel
  name: my-tunnel
subjects:
  - name: my-service
    spec:
      fqdn: example.org
      target: http://my-service.default.svc.cluster.local:8080
  # New!
  - name: new-example
    kind: CIDR # a new type of kind
    spec:
      # required
      network: "<IP_ADDRESS>/8"
      # optional
      virtualNetworkID: ""

The values inside the new Kind could represent the two things we don't know about which make up the CreateTunnelRoute  function of cloudflare-go.
What do you think?
Also, there are instructions and an API for updating the Split Tunnels list of your account, but I think these are better left to the user to manipulate. Last I checked, the two PUT routes (https://developers.cloudflare.com/api/operations/devices-set-split-tunnel-exclude-list and https://developers.cloudflare.com/api/operations/devices-set-split-tunnel-include-list) needed the whole list (ie submitting just a list with 1 entry would result in the dropping of any other entries). Seems like an weird race condition to me.

The Comments section seems like a nice place to keep track of the stuff from the operator (as long as the user does not have any of their own comments to add). I had forgotten that the Kind exists in the TunnelBinding! That will work well for CIDR with the format you show.
Since the warp-routing.enabled is a tunnel level parameter, it makes sense for it to be enabled by the Tunnel, rather than the TunnelBinding. Only CreateTunnelRoute can be called by the Binding reconciler.
Yeah, as you note, I agree messing with the Split Tunnels is not a good idea.

Awesome! When I get some time next week, I’ll take a stab at implementing and see how it goes.

Will it work? Isn't WARP mode mutually exclusive with ingress mode?


Update OmniSharp to latest build: v1.9-beta20

Merging this without a review as the real changes aren't part of this PR. Those changes have already been reviewed over in the omnisharp-roslyn repo.


Compose motion layout how Header will work?

I have gone through the motion layout wiki, https://github.com/androidx/constraintlayout/wiki/Compose-MotionLayout-JSON-Syntax#header , but could not found Header usage sample, concept, etc. Are there any resource from where I can find its usage? Thanks in advance

It is used with Link. https://github.com/androidx/constraintlayout/wiki/How-to-use-Link
Link is an experimental mechanism to remote access and control MotionLayout Compose
It will be used in the future for debug flags, optimization flags

Great, thanks a lot.


chore: release 1.3.0

:robot: I have created a release *beep* *boop*
1.3.0 (2022-07-28)
Features

#8: Support a different service.name for the tests (#10) (cbe58fa), closes #8

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/inception-health/otel-upload-test-artifact-action/releases/tag/v1.3.0 :sunflower:


[Packaging] Bump embedded Python to 3.8.11 for deb package

Context
Python 3.6 has reached its End of Life on 2021-12-23 (https://www.python.org/downloads/).
Change
This PR bumps Python to 3.8.11 for deb packages.
Question: Should we use Python 3.9 or even Python 3.10? Windows MSI currently contains Python 3.8.9.
Related PRs

https://github.com/Azure/azure-cli/issues/19858
https://github.com/Azure/azure-cli/pull/13565

CI fails on jobs:

Build Deb Packages Trusty (Ubuntu 14.04)
Build Deb Packages Jessie (Debian 8)

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1267742&view=logs&j=1c081627-a4dd-57ff-b320-9981b0ff7f6f&t=fab9ebe1-3cad-5c96-61ed-c5bfa2e064ad&l=9616
2021-12-29T08:25:58.3150877Z Could not build the ssl module!
2021-12-29T08:25:58.3151326Z Python requires an OpenSSL 1.0.2 or 1.1 compatible libssl with X509_VERIFY_PARAM_set1_host().
2021-12-29T08:25:58.3152432Z LibreSSL 2.6.4 and earlier do not provide the necessary APIs, https://github.com/libressl-portable/portable/issues/381

This is because LibreSSL on These distributions are too old. It turns out that building Python 3.7+ on old distributions like these is complex, as we need to manually build openSSL as well:

https://jameskiefer.com/posts/installing-python-3.7-on-debian-8/
https://bugs.python.org/issue34028
https://stackoverflow.com/questions/53543477/building-python-3-7-1-ssl-module-failed

Per https://wiki.ubuntu.com/Releases, Ubuntu 14.04.6 Trusty has reached its End of Standard Support in April 2019.
Per https://wiki.debian.org/DebianReleases, Debian 8 Jessie has reached its EOL LTS on 2020-06-30.
Perhaps it is time to drop support for Ubuntu 14.04.6 Trusty and Debian 8 Jessie as well.


weave-kube should run in 'guaranteed' mode

Currently it is in 'burstable' mode.  Link to description of modes
Background: we set CPU "requests" in the Yaml, and we set them very low. If we set them higher then the pod won't start at all on a typical test cluster where api-server, kube-dns, etc., take up so much of the available resource.
But now the pod is classed as "burstable", and on a big cluster using more than we asked for, it's a favourite for Kubelet to kill ("evict").
It seems the Launch generator would be a good place to provide options for this, but in the short term we should at least document the issue and consider raising the default.  We could tell people it needs a 2-core master minimum.

The main problem here is that it is so darn difficult to notice this is happening. In Scope, we and our users have lost many days to this :(

It is raised as a Kubernetes event:
anager: pod weave-net-4ozht_kube-system(546acee0-ee25-11e6-8965-068f417b4097) evicted successfully

The "main problem" for me is I didn't realise playing fast and loose with requests would make it more likely to get killed.

The event is one of many, and gives no indication that something bad has happened.

Raised in https://github.com/weaveworks/launch-generator/issues/86; this issue should be just to update the docs

Closed by #2884


Create specs

FYI I highly recommend using mermaid to create those ER diagrams
Example: https://github.com/catalystneuro/ndx-microscopy/pull/11/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R25
The 'code' for it can then live in the README or some other .md on GitHub so anyone can else modify it if they want

FYI I highly recommend using mermaid to create those ER diagrams

Not to mention the current extension is a lot more modular than most others - I'd recommend separate ER diagrams per related group; e.g., you could define a base OpticalFilter that adds filter_type and then separates into Band vs. Edge specific attributes

Overall looks good - made first round of comments

FYI I highly recommend using mermaid to create those ER diagrams
Example: https://github.com/catalystneuro/ndx-microscopy/pull/11/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R25
The 'code' for it can then live in the README or some other .md on GitHub so anyone can else modify it if they want

Yes, thank you for the suggestion. I was planning to do it in Mermaid once I finished this first step. I started with draw.io because it was a simple copy-paste from previous diagrams, and I just wanted to have a reference for this specific PR.

1 question about simplifying the ER diagrams, otherwise looks good!


abort() can't be combined with printf()

Trying to emulate aborting with an error message in device code, combining abort() with printf() seems to be a natural idea.
However, calling abort() or __assertfail makes all output that would normally be generated by printf disappear. Thus, for an assert, one currently has to decide between either aborting or printing the error.
There doesn't seem to be a way to flush the buffer and print to stdout (or preferably stderr) before.
Also, see https://github.com/kokkos/kokkos/pull/2894.
On a related note, it would be helpful if printf wouldn't require setting any environment variables.

Close this ticket as the latest HIP has device-side printf and assert support available. Let us know if you have any issues while using them.


error when build

So, I`m trying to get this to work. Installed Docker on my Win10 computer. And then started to follow the steps.
When i run the npm run build in the folder i just get this output:
`> DOCKER_REPO=hfreire NAME=$npm_package_name ./share/docker/hooks/build

'DOCKER_REPO' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `DOCKER_REPO=hfreire NAME=$npm_package_name ./share/docker/hooks/build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?`

So, what am I doing wrong to get this to run?

same


0.9.5 fails due to undefined sassPath (and cssPath)

express.js server error
$ DEBUG=myapp npm start

><EMAIL_ADDRESS>start /home/me/myapp
> node ./bin/www

  read: undefined
GET / 500 489.753 ms - 1119
Error: Can't set headers after they are sent.
    at ServerResponse.OutgoingMessage.setHeader (_http_outgoing.js:335:11)
    at ServerResponse.header (/home/me/myapp/node_modules/express/lib/response.js:718:10)
    at ServerResponse.send (/home/me/myapp/node_modules/express/lib/response.js:163:12)
    at done (/home/me/myapp/node_modules/express/lib/response.js:957:10)
    at Object.exports.renderFile (/home/me/myapp/node_modules/jade/lib/index.js:374:12)
    at View.exports.__express [as engine] (/home/me/myapp/node_modules/jade/lib/index.js:417:11)
    at View.render (/home/me/myapp/node_modules/express/lib/view.js:126:8)
    at tryRender (/home/me/myapp/node_modules/express/lib/application.js:639:10)
    at EventEmitter.render (/home/me/myapp/node_modules/express/lib/application.js:591:3)
    at ServerResponse.render (/home/me/myapp/node_modules/express/lib/response.js:961:7)

express.js client error
TypeError: path must be a string
    at TypeError (native)
    at Object.fs.exists (fs.js:210:11)
    at compile (/home/me/myapp/node_modules/node-sass-middleware/middleware.js:223:10)
    at sass (/home/me/myapp/node_modules/node-sass-middleware/middleware.js:248:14)
    at Layer.handle [as handle_request] (/home/me/myapp/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/home/me/myapp/node_modules/express/lib/router/index.js:312:13)
    at /home/me/myapp/node_modules/express/lib/router/index.js:280:7
    at Function.process_params (/home/me/myapp/node_modules/express/lib/router/index.js:330:12)
    at next (/home/me/myapp/node_modules/express/lib/router/index.js:271:10)
    at cookieParser (/home/me/myapp/node_modules/cookie-parser/index.js:48:5)

This problem occurred without any changes to my project's code. I only did npm update.
Further, I was able to reproduce this issue with a new express js project.
Steps:

mkdir test-nsm
cd ./test-nsm
npm init (all defaults)
npm install express --save
npm install express-generator -g
cd ../
express test-nsm
cd ./test-nsm
npm install
npm install node-sass-middleware --save
edit ./app.js to add:

var express = require('express');
var sassMiddleware = require('node-sass-middleware');

app.use(cookieParser());
// sass compiling
app.use(sassMiddleware({
	src: path.join(__dirname, 'public', 'stylesheets'),
	dest: path.join(__dirname, 'public', 'stylesheets'),
	debug: true,
	outputStyle: 'compressed'
}));

DEBUG=test-nsm npm start
open localhost:3000 in a browser

Thanks for reporting this. Some recent refactoring is the cause, but undetectable by our tests.
Could you submit a test case which test this scenario; in order to avoid such regression in future?

This is pretty urgent to get merged and pushed to NPM.  It prevented all assets from rendering in my app until I tracked it down to this module and reverted to 0.9.0.  Teaches me for using the ^

v0.9.6 is released with the fix.
@vanm, :)

Thanks! ;)

Thanks very much for the quick fix!


Conversion of Jpg files to webp

Loading Time of website is getting increased by loading large Jpg file  , if we could reduce the heavy bandwidth consuming item then performance will be improved .

convert all Jpg to webp modern Image format , can reduce the file size to 80% . Result in overall performance gain.

I have used in my previous project and no compatibility problem with old device .
Plz assign it to me

I am interested to work on this issue under GSSoC 2023 as a contributor


The pre-commit hook executes the existing npm run format:fix script to lint code.
Related Issue
Relates to https://github.com/defenseunicorns/pepr/issues/1105
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Other (security config, docs update, etc)

Checklist before merging

[ ] Unit, Journey, E2E Tests, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

@samayer12 added lint staged.

Looks like there's an issue with running husky in CI, based off this job log.

RUN npm run build && \     npm ci --omit=dev --omit=peer && \     npm cache clean --force && \     # Remove @types
In this line of Docker file , it seems that in the npm ci command we are omitting the the devDependecies. That might be the reason behind the job failure @samayer12.
The result of npm ci --omit=dev --omit=peer:

The result of npm ci --omit=peer:

The result of npm run test:journey:image after removing --omit=dev flage from npm ci

@itsarijitray, good catch! The cause of that error makes sense. We don't want to add DevDependencies to the image that gets shipped (see #1103).
As a workaround, I've used grep to regenerate the package.json file when buliding an image in the Dockerfile. I believe this will still support local developers without breaking CI workflows.

While working through issues running grep in the Dockerfile, I found that you can set HUSKY=0 to disable husky for a given command or environment. Here's a snippet from the job logs. This is odd, and leads me to wonder if our environment changes partway through the Dockerfile when it runs in CI?
#8 7.615 ><EMAIL_ADDRESS>prepare
#8 7.615 > husky install
#8 7.615
#8 7.649 husky - HUSKY env variable is set to 0, skipping install

However, later on in the file we see this:
#12 12.34 ><EMAIL_ADDRESS>prepare
#12 12.34 > husky install
#12 12.34
#12 12.35 sh: husky: not found

While working through issues running grep in the Dockerfile, I found that you can set HUSKY=0 to disable husky for a given command or environment. Here's a snippet from the job logs. This is odd, and leads me to wonder if our environment changes partway through the Dockerfile when it runs in CI?
#8 7.615 ><EMAIL_ADDRESS>prepare
#8 7.615 > husky install
#8 7.615
#8 7.649 husky - HUSKY env variable is set to 0, skipping install

However, later on in the file we see this:
#12 12.34 ><EMAIL_ADDRESS>prepare
#12 12.34 > husky install
#12 12.34
#12 12.35 sh: husky: not found

@samayer12 May be. I was thinking one thing, If we are not including dev dependencies the we would also need not to run  husky install in the npm ci command. Let me check if we can add some flags to remove npm prepare

@samayer12 @cmwylie19
Pushed a possible fix. Can you approve this PR? Would have to test the ci

other than the Dockerfile change which I am not sure we needed even though it probably wouldn't hurt, I think we can approve this to run in CI.

Some package updates were missed. Pushed them. Can you approve this? @samayer12 @cmwylie19
Will not merge untill the CI passes.

Seems like the PR passed all checks. Updating this branch with main as it was out sync. Can you re-approve last time? @cmwylie19 🙏 😅

This is looking good, we will give it a final review after we release today. Nice work @itsarijitray !

@itsarijitray , this is good, it can be merged when all the commits are signed

@itsarijitray once commit-signing is configured, you should be able to re-sign your old commits with something like this workflow that I found on stackoverflow:
git filter-branch --commit-filter 'if [ "$GIT_COMMITTER_EMAIL" =<EMAIL_ADDRESS>];
  then git commit-tree -S "$@";
  else git commit-tree "$@";
  fi' HEAD

@itsarijitray once commit-signing is configured, you should be able to re-sign your old commits with something like this workflow that I found on stackoverflow:
git filter-branch --commit-filter 'if [ "$GIT_COMMITTER_EMAIL" =<EMAIL_ADDRESS>];
  then git commit-tree -S "$@";
  else git commit-tree "$@";
  fi' HEAD

@itsarijitray do you mind going ahead and signing those commits so we can get this PR merged?

@cmwylie19 Sorry for the delay. Currently in the middle of a medical emergency. Give me sometime to configure the sign keys.

Closing this PR and raising a fresh one. The history got corrupted for the branch. 🥲
New PR: https://github.com/defenseunicorns/pepr/pull/1160
@cmwylie19 @samayer12


Version bump to 0.6.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi @aobo-y @sugatoray, this is ready for review/merge :)

LGTM.


[Feature Request] image preview element，can't close by click mask

Existing Component
是
Component Name
el-image
Description
image preview element，can't close by click mask.actually,It is easy to add an event in the mask layer

Already fixed, please upgrade the latest version

Already fixed, please upgrade the latest version


redo (ticdc): make FlushLogs in manager asynchronously

What problem does this PR solve?

Issue Number: ref #4222
What is changed and how it works?
Check List
Tests
Code changes

Has exported function/method change

Side effects

Increased code complexity

Related changes
Release note
None

/run-integrarion-tests

/run-verify

Codecov Report

Merging #4301 (2cf3bc6) into master (08da001) will increase coverage by 0.2079%.
The diff coverage is 52.0883%.

Flag
Coverage Δ

cdc
59.2327% <63.0866%> (+0.5879%)
:arrow_up:

dm
52.1508% <39.5897%> (-0.1038%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #4301        +/-   ##
================================================
+ Coverage   55.1722%   55.3801%   +0.2079%
================================================
  Files           485        495        +10
  Lines         59829      60937      +1108
================================================
+ Hits          33009      33747       +738
- Misses        23484      23799       +315
- Partials       3336       3391        +55

/merge


ROM size increase due Zephyr compile options not stripping unused functions

When building 3rd party libraries for A101, when CMake file uses  zephyr_get_compile_options_as_string(options) to include compile options, it seemed the it has changed and no longer include some of the flags to strip out unused functions, and therefore, the final ROM image size is increased.
For example,
with latest master, the compile options returned is:
-Os -g -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wno-main -ffreestanding -include /home/jimmy/projects/zephyrjs/zephyr.js/outdir/arduino_101/zephyr/include/generated/autoconf.h -nostdinc
But with an ealier commit b678895a6 is:
-Os -g -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wno-main -ffreestanding -include /home/jimmy/projects/zephyrjs/zephyr.js/outdir/arduino_101/zephyr/include/generated/autoconf.h -fno-asynchronous-unwind-tables -fno-pie -fno-pic -fno-strict-overflow -Wno-pointer-sign -fno-stack-protector -Wno-unused-but-set-variable -fno-reorder-functions -fno-defer-pop -nostdinc -Werror=implicit-int -ffunction-sections -fdata-sections -mpreferred-stack-boundary=2 -mno-sse -march=lakemont -mtune=lakemont -msoft-float

tl;dr;
This is a regression from f71c3fa6 that is fixed in PR https://github.com/zephyrproject-rtos/zephyr/pull/5229. You can either cherry-pick the PR or wait until it is merged.
The longer story ...
A patch was introduced that increased the use of COMPILE_LANGUAGE generator expressions. COMPILE_LANGUAGE generator expressions were not supported by the zephyr_get_* API until
PR https://github.com/zephyrproject-rtos/zephyr/pull/5229
In hindsight I should have done both patches at the same time.

If you have CONFIG_CPLUSPLUS enabled then this can be closed as a duplicate of https://github.com/zephyrproject-rtos/zephyr/issues/5152
grep CONFIG_CPLUSPLUS build_directory/zephyr/.config

Oh, and it is necessary to port to a new interface:
https://github.com/zephyrproject-rtos/zephyr/pull/5229/files#diff-c31c4dbe0e95f5d6cc91df73faf59217R17

@SebastianBoe Yeah, I do indeed have CONFIG_CPLUSPLUS set,  thanks.

We have MicroPython build fail for arduino_101 https://ci.linaro.org/view/lite-iot-ci/job/lite-aeolus-micropython/189/PLATFORM=arduino_101,ZEPHYR_GCC_VARIANT=zephyr,label=docker-xenial-amd64-13/console due to:

00:01:28.150 /home/buildslave/srv/toolchain/zephyr-sdk-0.9.2/sysroots/x86_64-pokysdk-linux/usr/libexec/i586-zephyr-elfiamcu/gcc/i586-zephyr-elfiamcu/6.2.0/real-ld: region `ROM' overflowed by 61800 bytes

This didn't happen before. Let me reopen this ticket for further investigation.

CONFIG_CPLUSPLUS is not used.

IMHO one shouldn't open issues in Zephyr when external projects have build failures.
A build failure after an update could be due to many reasons ...
Example: https://github.com/zephyrproject-rtos/zephyr/issues/5297

Really? Indeed, it could be due to many reasons, and 90% of those reasons are regressions in the Zephyr build system.

So, Makefile.exports has:

CC="/home/pfalcon/opt/zephyr-sdk-0.9.2/sysroots/x86_64-pokysdk-linux/usr/bin/i586-zephyr-elfiamcu/i586-zephyr-elfiamcu-gcc"
Z_CFLAGS=-isystem/mnt/hdd/opt/zephyr-sdk-0.9.2/sysroots/x86_64-pokysdk-linux/usr/lib/i586-zephyr-elfiamcu/gcc/i586-zephyr-elfiamcu/6.2.0/include -isystem/mnt/hdd/opt/zephyr-sdk-0.9.2/sysroots/x86_64-pokysdk-linux/usr/lib/i586-zephyr-elfiamcu/gcc/i586-zephyr-elfiamcu/6.2.0/include-fixed-I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/kernel/include -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/arch/x86/include -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/arch/x86/soc/intel_quark/quark_se -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/arch/x86/soc/intel_quark/quark_se/include -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/arch/x86/soc/intel_quark/include -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/boards/x86/arduino_101 -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/include -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/include/drivers -I/home/pfalcon/projects-3rdparty/micropython/ports/zephyr/outdir/arduino_101/zephyr/include/generated -I/mnt/hdd/opt/zephyr-sdk-0.9.2/sysroots/x86_64-pokysdk-linux/usr/lib/i586-zephyr-elfiamcu/gcc/i586-zephyr-elfiamcu/6.2.0/include -I/mnt/hdd/opt/zephyr-sdk-0.9.2/sysroots/x86_64-pokysdk-linux/usr/lib/i586-zephyr-elfiamcu/gcc/i586-zephyr-elfiamcu/6.2.0/include-fixed -I/home/pfalcon/opt/zephyr-sdk-0.9.2/sysroots/iamcu-zephyr-elfiamcu/usr/include -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/ext/hal/qmsi/include -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/ext/hal/qmsi/drivers/include -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/ext/hal/qmsi/soc/quark_se/include-DKERNEL -D__ZEPHYR__=1 -D_FORTIFY_SOURCE=2 -DENABLE_EXTERNAL_ISR_HANDLING -DQM_LAKEMONT -DSOC_SERIES=quark_se-Os -g -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wno-main -ffreestanding -include /home/pfalcon/projects-3rdparty/micropython/ports/zephyr/outdir/arduino_101/zephyr/include/generated/autoconf.h -std=c99 -fno-asynchronous-unwind-tables -fno-pie -fno-pic -fno-strict-overflow -Wno-pointer-sign -Wno-unused-but-set-variable -fno-reorder-functions -fno-defer-pop -nostdinc -Werror=implicit-int -ffunction-sections -fdata-sections -mpreferred-stack-boundary=2 -mno-sse -march=lakemont -mtune=lakemont -msoft-float

I.e., both -ffunction-sections -fdata-sections are there, and actually used when compiling both app and Zephyr code.
And link is:

ccache /home/pfalcon/opt/zephyr-sdk-0.9.2/sysroots/x86_64-pokysdk-linux/usr/bin/i586-zephyr-elfiamcu/i586-zephyr-elfiamcu-gcc    CMakeFiles/zephyr_prebuilt.dir/misc/empty_file.c.obj  -o zephyr_prebuilt.elf -T/home/pfalcon/projects-3rdparty/micropython/ports/zephyr/outdir/arduino_101/zephyr/linker.cmd -Wl,-Map=/home/pfalcon/projects-3rdparty/micropython/ports/zephyr/outdir/arduino_101/zephyr/zephyr.map -u_OffsetAbsSyms -u_ConfigAbsSyms -e__start -Wl,--start-group -Wl,--whole-archive ../libapp.a libzephyr.a lib/libc/newlib/liblib__libc__newlib.a boards/x86/arduino_101/libboards__x86__arduino_101.a ext/hal/qmsi/libext__hal__qmsi.a -Wl,--no-whole-archive kernel/libkernel.a CMakeFiles/offsets.dir/arch/x86/core/offsets/offsets.c.obj -Wl,--end-group -L/home/pfalcon/opt/zephyr-sdk-0.9.2/sysroots/iamcu-zephyr-elfiamcu/usr/lib/i586-zephyr-elfiamcu/6.2.0 -L/home/pfalcon/projects-3rdparty/micropython/ports/zephyr/outdir/arduino_101/zephyr -lgcc /home/pfalcon/projects-3rdparty/micropython/ports/zephyr/libmicropython.a -nostartfiles -nodefaultlibs -nostdlib -static -no-pie -Wl,-X -Wl,-N -Wl,--gc-sections -Wl,--build-id=none -lm -lc -L/home/pfalcon/opt/zephyr-sdk-0.9.2/sysroots/iamcu-zephyr-elfiamcu/usr/lib/. -lgcc

I.e.  -Wl,--gc-sections is there too. Weird.

Prooflink that it worked just 2 days ago: https://ci.linaro.org/view/lite-iot-ci/job/lite-aeolus-micropython/186/PLATFORM=arduino_101,ZEPHYR_GCC_VARIANT=zephyr,label=docker-xenial-amd64-13/console

I guess it doesn't link, and therefore you can't run rom_report to find out what is using so much space?
Perhaps you could compare what -size says before and after the update.

@SebastianBoe : I'm on it (and not asking you to look into it), just appreciate being able to investigate within the scope of the upstream project, and within existing ticket, to keep other parties in loop. (Of course, will appreciate your attention when I have come to some results where I can't easily proceed forward - like you always helped so far, thanks!)

@SebastianBoe : It was smart to change this line: https://github.com/zephyrproject-rtos/zephyr/pull/5229/files#diff-c31c4dbe0e95f5d6cc91df73faf59217R20 , and I hope you'd agree it's easy to overlook ;-). Thanks for you patience!


Error: Cannot find a differ supporting object [vaadin-combo-box]

I created a small project to test the integration of Polymer in Angular2. When I select an item from the combo box gives me the errror "Can not find something to differ supporting object" but I can not understand what the reason.
Attach the test project
angular2-polymer.zip

@mmenik your project does not include a bower.json. I couldn't test it

Sorry for my mistake, i have attach the bower.json
angular2-polymer.zip

Hmm, seems like a problem with angular for me. Based on this: https://github.com/angular/angular/issues/6392
Does this help?

Closing until @mmenik is providing more feedback...


[WIP] Zinc 250k dataset support

Implementation almost done, but I'm final checking the function behavior.

Codecov Report

Merging #276 into master will decrease coverage by 6.83%.
The diff coverage is 84.03%.

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   89.13%   82.29%   -6.84%
==========================================
  Files         116      118       +2
  Lines        5834     5953     +119
==========================================
- Hits         5200     4899     -301
- Misses        634     1054     +420

Thanks!


o1 Agent Error on Complex Types

We're failing on o1 agents because of a complex types error:
 NotImplementedError: Complex types are not yet supported. Failed on: FunctionInfo(name='paper_search', description='Search for papers to increase the paper count.\n\nRepeat previous calls with the same
           query and years to continue a search. Only repeat a maximum of twice.\nThis tool can be called concurrently.\nThis tool introduces novel papers, so invoke this tool when just beginning or when
           unsatisfied with the current evidence.', parameters=Parameters(type='object', properties={'query': {'description': "A search query, which can be a specific phrase, complete sentence, or general
           keywords, e.g. 'machine learning for immunology'. Also can be given search operators.", 'title': 'Query', 'type': 'string'}, 'min_year': {'anyOf': [{'type': 'integer'}, {'type': 'null'}],
           'description': 'Filter for minimum publication year, or None for no minimum year. The current year is 2024.', 'title': 'Min Year'}, 'max_year': {'anyOf': [{'type': 'integer'}, {'type': 'null'}],
           'description': 'Filter for maximum publication year, or None for no maximum year. The current year is 2024.', 'title': 'Max Year'}}, required=['query', 'min_year', 'max_year']))

We could either (1) just drop year for now or (2) give our React parsing some love and come up with a solution for this

Oh the solution here is to use JSON or XML parsing. Our STR template has this vulnerability. You would place {"tool_description_method": ToolDescriptionMethods.JSON} in the agent_config

Got it - we should get this as default somehow so we use o1 on CLI:
pqa --agent.agent_llm=o1-mini --agent.agent_type=ldp.agent.ReActAgent ask "How are quantum computing and MD related?"


Revert "[requirements] Bumpy Celery (#9277)"

This reverts commit c0f0d453778e282ab961f20298dcaf3f10788b30.
CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
Deploying this change resulted in issues where celery workers double run some tasks. This resolved the issue locally, so reverting the original bump here
TEST PLAN
CI
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
to: @john-bodley @villebro @mistercrunch

Sounds pretty serious. It appears there was a new patch release yesterday (4.4.2), but in the absence of a changelog update since 4.4.0 I'm inclined to revert back to 4.4.0.


feat: allow to strip ANSI for the result of formatMessage

import { formatMessage } from 'publint/utils'
import fs from 'node:fs/promises'

const pkg = JSON.parse(
  await fs.readFile('./path/to/package/package.json', 'utf8')
)

for (const message of messages) {
  console.log(formatMessage(message, pkg)) // Color
}

I'm creating a eslint plugin eslint-plugin-publint. I don't need ANSI in the result of formatMessage. Support an option to strip ANSI. Otherwise, I have to use (or copy the code of) strip-ansi to strip it. :)

I guess it's not hard to add a noColor option to disable colors, feel free to send a PR for that if you'd like. But at the same time, I'm not sure if eslint-plugin-publint makes sense to me. publint is mean to run of published files, not source code, which eslint covers. So you'd usually run publint separately as its own process.

It does currently only reports on the package.json, but I'd like to expand it towards more files as well, particularly on published files (something I'm working on in the next version). So while you could make it work as an ESLint plugin today, it might not be suitable to do so in the future.

i use it to replace colors
// inspired by https://github.com/chalk/ansi-regex/blob/main/index.js#L1
export const ANSI_COLORS_REGEXP =
	/[\u001B\u009B][[\]()#;?]*(?:(?:(?:(?:;[-a-zA-Z\d\/#&.:=?%@~_]+)*|[a-zA-Z\d]+(?:;[-a-zA-Z\d\/#&.:=?%@~_]*)*)?\u0007)|(?:(?:\d{1,4}(?:;\d{0,4})*)?[\dA-PR-TZcf-nq-uy=><~]))/g;

But then i just replace functions which add ANSI colors
picocolors: {
					default: `{
						bold: (s) => s,
						yellow: (s) => s
					}`,
				},

Glad to see that now i can just color: false with https://github.com/bluwy/publint/pull/110


⚠ Bofrost.at has degraded performance

In 5dfc19c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2090 ms

Resolved: Bofrost.at performance has improved in d2fe6ea.


Add some generative FsCheck tests for ImmMap

Hey, not sure if this is useful, or if you already got this covered with other tests, but I made a function to test persistent maps for another project so I thought I'd try on ImmMap too.
It generates a random FSharp.Core.Map, then a random set of actions to do on it (Add | Remove), maintains both an ImmMap and FSharp Map, and then after all the actions are completed, checks that all the intermediate ImmMaps and FSharp Maps are equal.
You can see the input it generates if you change Property to Property(Verbose=True) and then click output in the visual studio test runner. Both ImmMap and ImmSortedMap pass this test.
I had to add some dependencies to the test project, not sure if that is an issue. I also had to drop some references to FSharp.Core to get things to compile on my machine.
If you are open to this kind of thing, I can make some tests for ImmList too.

Thanks. Once I get back to working on the project (not sure when exactly) I'll look into building the existing tests into some kind of framework too. Right now it's all custom.
Thanks for the tip about FSharp.Core. I'll have to look into that too.
I've written this kind of test code already. You can see it here. The comparison step happens after the tests.
I wrap each collection in a wrapper that also performs unit tests after every operation (like checking that Length grows by 1 after an addition when appropriate).


Use websocket to VM/CT updates

Display VM creation in full updates at the time it was created, not waiting until full update occurs

#176


Don't install explore plugin twice

kolibri_explore_plugin is already installed via p4a's --requirements, so installing the package again in src duplicates it. The only reason we need to manually download it is to populate the loadingScreen web components in assets. Do that separately into a temporary directory.

Looks good! Another option is to remove the loadingScreen from PyPi and distribute it through Github releases, just like the apps-bundle.zip https://github.com/endlessm/kolibri-explore-plugin/releases/tag/v2.0.25 (see the release apps workflow https://github.com/endlessm/kolibri-explore-plugin/actions/runs/3024086248/workflow). Then on the Makefile do the same as with apps-bundles, wget it and unzip it to the corresponding location.

Oh, that would be pretty nice. I'm going to merge this for now and maybe we can go back and clean that up.


start() never resolves if locale is not English

Firstly thank you for your efforts on this repo!
In the start() method there's this guard that resolves the promise once the instance has successfully started:
                // GUARD: Check for the right message to determine server start
                if (message.includes('database system is ready to accept connections')) {
                    resolve();
                }

but if your PC is not using an English locale and you don't specify an English locale manually by using
process.env.LC_MESSAGES = 'en_US.UTF-8';

then Postgres will log in your PC's locale, which means database system is ready to accept connections is never logged and the promise is never resolved.
It's easily solved by forcing Postgres into an English locale - but is there any other implementation that could remove the need for a specific log line? Or a README update to highlight this would be useful! Thanks!

I've created a pull request with that particular fix. If you could try it out and confirm the fix, I'll try and get it merged.

Ah amazing thank you. I can't really think of any other approach honestly so that looks sensible.


ATM9 to the sky THE MARID CRUSHER Achievement Bug

In ATM9 to the Sky i am following the questbook of All the Mods 9 for Occultism and one Achievement is "The Marid Crusher" which i successfully did (the demon spawned). But after successfully summoning the Demon i saw that i didnt get the Achievement in the ATM9 book, which prevents me from goint further with the mod. I Summoned it again but still no success with the Achievement.
To Reproduce
Steps to reproduce the behavior:

Create Block of Iesnium
Create Book of Binding: Marid (Bound) "can be used to summon the marid Holmurkyr" (i'ts the green book)
Create Block of Diamond
Create Emerald Block
Create the Ritual "Fatmas's Incentivized Attraction" by using the right colours of chalk, candles and mob heads like in the discription
Placing Iesnium Block, Diamond Block, Emerald Block and ghast tear in the Sacrificial Bowls
Placing Book of Binding: Marid (Bound) in the Golden Sacrificial Bowls
Waiting for Demon to Spawn

Expected behavior
Demon Spawned successfully which can crush ores and giving me 6x the dust. But not getting the achievement in ATM9
Screenshots
If applicable, add screenshots to help explain your problem.

System (please complete the following information):

Occultism Version: occultism-1.20.1-1.132.2
OS: Windows
Minecraft Version: Minecraft Forge 1.20.1
Forge Version: 47.2.20
Modpack Link and Version, or list of mods: https://www.curseforge.com/minecraft/modpacks/all-the-mods-9-to-the-sky

I think The Problem is that the Book that i should be using says below "Can be used to summon the marid Aldmyld" But when i look for the same green book it only shows me the one that says below " Can be used to summon the marid Lukrondthyre" See pictures below:

@olaquiensoy I just tested, the advancement for marid miners exists (albeit hidden to the player) and gets unlocked.
Have you reported this to the ATM team? Maybe there is a typo in the quest and it is listening to the wrong advancement?
If not please report this as a bug on their end and maybe ping me in the issue so I can talk with them in case it is something on my end after all.
The name of the marid is not relevant, that is just "eye candy" and not counted in the advancement

Closed as stale


Not compatible with onetbb-2021.6.0

Reporting a bug
numba/np/ufunc/tbbpool.cpp:238:45: error: call to non-static member function without an object argument
                tbb::task_scheduler_handle::release(tsh);
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
numba/np/ufunc/tbbpool.cpp:263:43: error: no member named 'get' in 'tbb::detail::d1::task_scheduler_handle'
        tsh = tbb::task_scheduler_handle::get();
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
numba/np/ufunc/tbbpool.cpp:301:39: error: no member named 'get' in 'tbb::detail::d1::task_scheduler_handle'
    tsh = tbb::task_scheduler_handle::get();
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
3 errors generated.

[x] I have tried using the latest released version of Numba (most recent is
visible in the change log (https://github.com/numba/numba/blob/main/CHANGE_LOG).
[ ] I have included a self contained code sample to reproduce the problem.
i.e. it's possible to run as 'python bug.py'.

numba currently do not support tbb-devel>2021.5. a patch has been made to restrict our buildscripts: https://github.com/numba/numba/pull/8486

i'm marking this issue as a feature-request to get support for newer tbb

The FreeBSD package for onetbb was updated to 2021.6.0 and this makes Numba broken.

If there's no option to obtain a supported version of TBB, TBB support can be disabled at compile time via setting the environment variable NUMBA_DISABLE_TBB to non-zero, i.e. export NUMBA_DISABLE_TBB=1.

#8856 fixes and will be in Numba 0.57.0.


Anchors are lost when their position is assigned a Node value

Describe the bug
When a node with an anchor is replaced by a different node, the anchor is lost and any aliases referring to it will fail to stringify properly.
To Reproduce
const doc = YAML.parseDocument('foo: &a A\nbar: *a\n')

// This modifies the existing Scalar
doc.set('foo', 'B')
String(doc)
// → 'foo: &a B\nbar: *a\n'

// This replaces the Scalar
doc.set('foo', doc.createNode('C'))
String(doc)
// → Uncaught Error: Alias node must be after source node

Expected behaviour
Either anchors should be automatically re-assigned, or it should bepossible/easy to ensure that happens.
Versions (please complete the following information):

yaml: all

Additional context
This is effectively a different expression of the "Fix self-referential aliases on custom collections" todo item on #203, as a good solution to this will also provide a good solution to that.

The original buggy part of this is getting fixed by #248, so I'm going to close this for now. The wontfix label is here for the surprising-behaviour part, because I don't think there's a good API change for it that wouldn't either be really clumsy, or be actually less surprising.


202 (Accepted) HTTP response; backoff and retry

Hi, I've been getting the following error for the past couple of days, I originally thought it was because I was hitting the GitHub API limit for the API key I'm using but I no longer think thats the case (you see an actual message from GitHub telling you you hit the API limit for the day)
Here is what I'm seeing:
This 1st part has taken a couple of days to get past the GitHub API limit and is now cached and appears to work as expected:
I160616 22:28:43.982757 cmd/fetch.go:53  fetching GitHub data for repository repo/repo

I160616 22:28:43.983038 fetch/query.go:258  querying stargazers of repository repo/repo
*** 1,687 stargazers

I160616 22:28:45.206165 fetch/query.go:278  querying user info for each of 1,687 stargazers...
*** user info for 1,687 stargazers

I160616 22:28:45.926333 fetch/query.go:292  querying followers for each of 1,687 stargazers...
*** 68,389 followers (43,406 unique) for 1,687 stargazers

I160616 22:28:48.995858 fetch/query.go:320  querying starred repos for each of 1,687 stargazers...
*** 363,191 starred repos (90,747 unique) for 1,687 stargazers

I160616 22:29:43.917686 fetch/query.go:352  querying subscribed repos for each of 1,687 stargazers...
*** 85,739 subscribed repos (80,406 unique) for 1,687 stargazers

Now, this is what I see everytime I get to the point of retrieving the commits for each stargazer:
I160616 22:29:58.653527 fetch/query.go:384  querying contributions to subscribed repos for each of 1,687 stargazers...
*** 5,432 commits from 360 repos (376 qual, 2,331 total) for 24 stargazers
E160616 22:30:01.925974 fetch/fetch.go:117  202 (Accepted) HTTP response; backoff and retry
E160616 22:30:03.852227 fetch/fetch.go:117  202 (Accepted) HTTP response; backoff and retry
E160616 22:30:05.772839 fetch/fetch.go:117  202 (Accepted) HTTP response; backoff and retry
E160616 22:30:07.251432 fetch/fetch.go:117  202 (Accepted) HTTP response; backoff and retry
E160616 22:30:08.789207 fetch/fetch.go:117  202 (Accepted) HTTP response; backoff and retry
E160616 22:30:11.659565 fetch/fetch.go:117  202 (Accepted) HTTP response; backoff and retry
E160616 22:30:13.708287 fetch/fetch.go:117  202 (Accepted) HTTP response; backoff and retry
E160616 22:30:17.708606 fetch/fetch.go:117  202 (Accepted) HTTP response; backoff and retry
E160616 22:30:20.987420 fetch/fetch.go:117  202 (Accepted) HTTP response; backoff and retry
E160616 22:30:25.068810 fetch/fetch.go:117  202 (Accepted) HTTP response; backoff and retry

Occasionally it will throw the following:
E160616 22:30:26.070563 fetch/fetch.go:127  unable to fetch "https://api.github.com/repos/whatwg/html/stats/contributors"

Apologies, if anything here is n00bish, I installed Go for the 1st time to play with this repo 😄

No, not noobish. I've gotten similar errors. Something weird going on with GitHub's API Not sure what the cause is...I mostly just ignored them.

Thanks, I've fired it up again and I'll let it run and see what happens 😬


Fix broken links to installation guide

Signed-off-by: Parthvi Vala<EMAIL_ADDRESS>
What type of PR is this:
/kind bug
/area documentation

What does this PR do / why we need it:
Which issue(s) this PR fixes:

Fixes #
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[x] Documentation

How to test changes / Special notes to the reviewer:

/lgtm

      ⚠  Failed to pull image "registry.access.redhat.com/ubi8/nodejs-12:1-36": rpc error: code = Unknown desc = pinging container registry registry.access.redhat.com: Get "https://registry.access.redhat.com/v2/": dial tcp <IP_ADDRESS>:443: i/o timeout
       ⚠  Error: ErrImagePull
       ⚠  Error: ImagePullBackOff

/override ci/prow/v4.10-integration-e2e
Tests are passing on IBM Cloud.


Fix 1805

This grab's @antgonza's code and fixes it so the download through nginx works correctly.
@antgonza @ElDeveloper are you able to do a review?

Coverage increased (+0.01%) to 91.595% when pulling d96da86689f76a3675a11518a65a2cb20d61d891 on josenavas:fix-1805 into 27950465f44a5e945bf4001ddb40bde805789f8d on biocore:master.

👍

Coverage increased (+0.07%) to 91.653% when pulling e90ad508fca01d86117e4540a70e3ae08970e29a on josenavas:fix-1805 into 27950465f44a5e945bf4001ddb40bde805789f8d on biocore:master.

Coverage increased (+0.07%) to 91.655% when pulling 587e5bf05ee89093d3720c2cc9a49c398f10085f on josenavas:fix-1805 into 27950465f44a5e945bf4001ddb40bde805789f8d on biocore:master.

Is there anything else needed in this PR?

Just to keep everyone in the loop: We realized that in some occasions the zip downloaded will not open in Macs because due to the size of the files it requires unzip >= 6.00. Thus, we decided to host a Mac version of unzip 6.00 in the FTP (cause the only way to install it is via brew), and add a GUI line under the button pointing to new documentation explaining the issue and fix.

Closing as I'm gonna create another PR with the requested fixes as @josenavas requested it.

Oh, I think I have seen this before, what about using gzip?
My past experience was that large zip files could not be opened unless I used jar xvf files.zip or something like that.

mod_gzip for nginx doesn't really work like mod_zip. In other words, we can't use mod_gzip for what we are doing here ...


sessions don't advance with certain options

either:

'no join' in session config OR
not having the same number of entrants as max clients

causes sessions to not advance

Definitely no join

hide is open option in booking
hide wait time option in booking, practice and qualify


Validation error template is missing from DatePicker

While a TextBox uses a nice stylized validation error template, DatePicker would display the standard validation error indication: a red rectangle surrounding the DatePicker.
I would suggest DatePicker using the same validation error styling, as say TextBox.
See also issue #284.

Done


Increase our z-indexs

Some users are still experiencing our components being hidden due to "low" z-index relative to what they are using.
Suggest updating our values to match that of mui's z-indexes as this is what most people are either coming from or using instead. These values should be no high enough to account for anything else people might use.

The previous overhaul of this: #883

The previous overhaul of this: #883

hmm, does chip need z-indexs? Can't remember why we have this.
Menu and popover should have the same z-index i think?

The previous overhaul of this: #883

* hmm, does chip need z-indexs? Can't remember why we have this.

* Menu and popover should have the same z-index i think?

The previous value for chip appears to have been 999 set by you 2 years ago at its creation


Add CSS for better appearance #6 has been solved

Add CSS for better appearance #6  has been solved

Add CSS for better appearance #6 has been solved

@strivedi4u please merge my PR


fixed race condition in COPY FROM

that could cause a wrong row count when inserting into a partition that does not exist yet

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@275d2bd). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #6356   +/-   ##
=========================================
  Coverage          ?   83.27%
  Complexity        ?    12822
=========================================
  Files             ?     1481
  Lines             ?    48520
  Branches          ?     5911
=========================================
  Hits              ?    40407
  Misses            ?     5367
  Partials          ?     2746

Impacted Files
Coverage Δ
Complexity Δ

...e/operation/projectors/ShardingUpsertExecutor.java
88.12% <100%> (ø)
32 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 275d2bd...02fbe13. Read the comment docs.

@mxm can you have another look? also @andreidan

Looks good to me @chaudum
Great catch!

@mxm updated with your suggestion about synchronizing only the method call addToRequests()


offline usuage

Is it possible to run this in a local network?
I've tried but exceptions are poping on my terminal.
If connected to the internet it works fine.

I don't think Chromecast will work offline at all. The apps running on chromecast are basicly Internet websites. This means, also the video-player is just a  tag on some website in the end.

I don't think Chromecast will work offline at all. The apps running on chromecast are basicly Internet websites. This means, also the video-player is just a  tag on some website in the end.

But if you are streaming locally it should work? Or is the default media player app hosted externally?

The default media player app is hosted externally. It's located here:
https://www.gstatic.com/eureka/player/player.html?skin\u003dhttps://www.gstatic.com/eureka/player/0000/skins/cast/skin.css

Yeah, chromecast loads the receiver app everytime it receives a cast order.
I Know that for google is easier to keep the receiver up-to-date if it's hosted remotely but as a chromecast user I would except it to have some configuration option where i could decide either I want to keep the default receiver in memory or load it everytime a cast starts.

Is there any way to change that default media player? I'd like to add a custom background.
Thanks,

@savesthedale you must create your own receiver application
There's an example here: https://github.com/googlecast/cast-custom-receiver
You must host your application with https otherwise it won't work


clean up recipe and rerender

Takes the fixes from #11 without the version bump, just to make sure that the build failures there aren't actually related to changing the version.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This doesn't actually change anything from the previous build other than the license metadata, so closing in favor of #11.


add quality mongodb, mongoose course to courses/free-courses-vi.md

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

this seems like a random playlist from a channel rather than a course. Because why start with a screencast with just music? if it was a course, it would start with some sort of introduction. But I've only skimmed it, what do you think?

this seems like a random playlist from a channel rather than a course. Because why start with a screencast with just music? if it was a course, it would start with some sort of introduction. But I've only skimmed it, what do you think?
I believe the creator of this course does not particularly focus on the UI of this playlist, but instead focuses structure and story to assist newbies have a larger and deeper vision. I'd already watched and I confirmed it really helpful for pepple, who want to dig deep, is it ok sir?


Follow up: Renaming more ProjectReunion -> WindowsAppSDK

Follow-up from PR: https://github.com/microsoft/WindowsAppSDK/pull/1041
This change addresses this issue (called out in the above PR):

#1 build\Helix\RunTestsInHelix.proj
pr/reunion/$(BUILD_SOURCEBRANCH)/ references a backend artifact (branch?)

I also fixed a few other/additional remaining places where the ProjectReunion term was used, and replaced with WindowsAppSDK or "Windows App SDK".

/azp run

/azp run

/azp run


more pictures examples maybe more helping

Thanks for youre great job. But it is a bit diffcult for me to draw picture with your guide in https://scanpy.readthedocs.io/en/latest/basic_usage.html

Hi,
You may find the tutorials more helpful. You can find them here:
https://scanpy.readthedocs.io/en/latest/examples.html


Resolve SentenceTransformer resetting devices after moving a SetFitModel

Hello!
Pull Request overview

Resolve bug that moved a SentenceTransformer instance back to its original device after encode or fit is called on it.
Add passing test that fails on main to prevent this bug from reappearing.

Note
I want to first point out that this PR is cherry-picked from a bugfix that I applied in #265. I believe it is best to merge that PR to create a v1.0.0 version, and merge this PR in preparation for a v0.6.0 version. That way, we'll have a version out there without breaking changes that includes some important bug fixes (i.e. v0.6.0).
However, if we choose to include #265 in the next release already, then that PR would supersede this one, and this one could be closed.
Details
The bug in question is most conveniently showcased with some code:
from setfit import SetFitModel
import torch

print(f"{torch.cuda.is_available()=}")

model: SetFitModel = SetFitModel.from_pretrained("sentence-transformers/paraphrase-albert-small-v2")
print(f"{model.model_body.device=} after loading")

model.to("cpu")
print(f"{model.model_body.device=} after moving to cpu")

model.model_body.encode("Arbitrary sentence to convert to embeddings")
print(f"{model.model_body.device=} after encoding some inputs")

With the following outputs on a CUDA-supported device:
torch.cuda.is_available()=True
model.model_body.device=device(type='cuda', index=0) after loading
model.model_body.device=device(type='cpu') after moving to cpu
model.model_body.device=device(type='cuda', index=0) after encoding some inputs

As you can see, after calling model.model_body.encode, the SentenceTransformer has moved back to cuda:0.
This is a bug/flaw originating from the SentenceTransformer library. When initializing a ST, it will set an attribute self._target_device = device here, and then it will continuously move the ST to that original device in the encode and fit methods. This would be fine if calling to on such an ST would update this target device, but it does not.
I would create a PR over on the SentenceTransformer repository, but I'm afraid that repository hasn't seen any maintenance is 2 months, with issues and PRs piling up. As a result, I believe it's prudent to solve this on the SetFit side, sadly.
Tests
I've created a simple test very much alike the snippet from above. It will only run on CUDA-enabled devices, as with CPU-only devices there is no second device to move a model to.

Tom Aarsen

Great!


Add Borders Around your Elements

code is almost correct but unable to run with code  only with pixcel and class

CatPhotoApp

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.
Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.

@anilt104 you can use the tickin order to style text to be like code in MD (markdown)like this`

@anilt104 Thank you for reporting this issue.
This is a standard message notifying you that this issue seems to be a request for help. Instead of asking for help here, please click the "help" button on the challenge on freeCodeCamp, which will take you to the help chatroom for that specific challenge. You can also view our full list of official chatrooms.
If you think I'm wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding!


The Outline client v <IP_ADDRESS> totaly not works on windows 10 22H2 build 19045.2846

Perform clear install on clear Windows 10 setup, results:
Outline is starting
loading web app from file:///c:/Program%20Files%20(x86)/Outline/resources/app.asar/www/index_electron.html?
debug=true&appName=Outline
Could not load active tunnel:  [Error: ENOENT: no such file or directory, open 'C:\Users\Alexandr\AppData\Roaming\Outline\connection_store'] {
errno: -4058,
code: 'ENOENT',
syscall: 'open',
path: 'C:\Users\Alexandr\AppData\Roaming\Outline\connection_store'
}
connecting to 4e48d09e-ef66-4e4d-bf0a-2aadca74882a...
using tun2socks to check connectivity
[EXIT - tun2socks.exe]: Exited with code 0
UDP support: true
starting routing daemon
Routing daemon socket setup failed Error: connect ENOENT \.\pipe\OutlineServicePipe
at PipeConnectWrap.afterConnect [as oncomplete] (node:net:1157:16) {
errno: -4058,
code: 'ENOENT',
syscall: 'connect',
address: '\\.\pipe\OutlineServicePipe'
}
could not connect: w (routing daemon is not running)
[EXIT - tun2socks.exe]: Killed by signal SIGTERM
tun2socks terminated due to Error: Process terminated by signal: SIGTERM
disconnected from 4e48d09e-ef66-4e4d-bf0a-2aadca74882a
installing outline routing service...
connecting to 4e48d09e-ef66-4e4d-bf0a-2aadca74882a...
using tun2socks to check connectivity
[SC] DeleteService SUCCESS
[SC] CreateService SUCCESS
The OutlineService service is starting.
The OutlineService service is not started.
More help is available by typing NET HELPMSG 3521.
The OutlineService service could not be started.
The service did not report an error.
More help is available by typing NET HELPMSG 3534.
outline routing service installed successfully
[EXIT - tun2socks.exe]: Exited with code 0
UDP support: true
starting routing daemon
Routing daemon socket setup failed Error: connect ENOENT \.\pipe\OutlineServicePipe
at PipeConnectWrap.afterConnect [as oncomplete] (node:net:1157:16) {
errno: -4058,
code: 'ENOENT',
syscall: 'connect',
address: '\\.\pipe\OutlineServicePipe'
}
could not connect: w (routing daemon is not running)
[EXIT - tun2socks.exe]: Killed by signal SIGTERM
tun2socks terminated due to Error: Process terminated by signal: SIGTERM
disconnected from 4e48d09e-ef66-4e4d-bf0a-2aadca74882a
installing outline routing service...
[SC] DeleteService SUCCESS
[SC] CreateService SUCCESS
The OutlineService service is starting.
The OutlineService service is not started.
More help is available by typing NET HELPMSG 3521.
The OutlineService service could not be started.
The service did not report an error.
More help is available by typing NET HELPMSG 3534.
outline routing service installed successfully
... and so on cyclically...
In other words, the client constantly reinstalls the service, and the service does not start, while not reporting anything at all about the error.

Hi @Alexandr2021i , thanks for reporting the issue.
The log message indicates that something is preventing the OutlineService from starting:
The OutlineService service is starting.
The OutlineService service is not started.
More help is available by typing NET HELPMSG 3521.
The OutlineService service could not be started.
The service did not report an error.
More help is available by typing NET HELPMSG 3534.

Can you manually start the service in Task Manager or services.msc, and then retry connecting in Outline Client?

Manual starts & stop immediately. Logs does nothing.

Run service exe from console - same result, no any info in console, just exit..

Hi @Alexandr2021i , could you please take a look at the Windows Event Logs to see whether there are any error reports from the service?

Also, if you have installed any Anti-Virus software, that might block our service from running, too.

How do I even check outline logs? There is no way in the client to display the logs!

Hi @ruslaniv , you need to launch Outline through PowerShell. "Right click start button" -> "Terminal", then run the following command
& 'C:\Program Files (x86)\Outline\Outline.exe'

You might need to change C:\Program Files (x86) if your system folder is different.


After Running "Scan and AF all Steps", running a Protocol, even with long duration and capture, cycles back

Protocol behaves like duration and capture is too short and cycles back from 5 or 6 wells to 1.  This seems to only happen after a Scan And AF all steps" is run

Could this be caused by issue #149

yes, caused by #149


Warning existing folder does not exist

System Health details
System Information

version
core-2024.12.3

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.13.0

os_name
Linux

os_version
6.6.51-haos-raspi

arch
aarch64

timezone
Europe/Prague

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

HACS Data
ok

GitHub API Calls Remaining
5000

Installed Version
2.0.1

Stage
running

Available Repositories
1486

Downloaded Repositories
46

Home Assistant Cloud

logged_in
true

subscription_expiration
3. května 2025 v 02:00

relayer_connected
true

relayer_region
eu-central-1

remote_enabled
true

remote_connected
true

alexa_enabled
false

google_enabled
true

cloud_ice_servers_enabled
true

remote_server
eu-central-1-5.ui.nabu.casa

certificate_status
ready

instance_id
3e42f135b8e94cceac25531ec6bd3d97

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 14.0

update_channel
stable

supervisor_version
supervisor-2024.11.4

agent_version
1.6.0

docker_version
27.2.0

disk_total
109.3 GB

disk_used
17.8 GB

healthy
true

supported
true

host_connectivity
true

supervisor_connectivity
true

ntp_synchronized
true

virtualization

board
rpi4-64

supervisor_api
ok

version_api
ok

installed_addons
Samba share (12.3.2), File editor (5.8.0), Terminal & SSH (9.16.0), Home Assistant Google Drive Backup (0.112.1), Mosquitto broker (6.4.1), Samba Backup (5.2.0), openWakeWord (1.10.0), Piper (1.5.2), Uptime Kuma (0.12.4), ESPHome Device Compiler (2024.11.3), Zigbee2MQTT (1.42.0-2)

Dashboards

dashboards
4

resources
30

views
13

mode
storage

Recorder

oldest_recorder_run
9. prosince 2024 v 18:40

current_recorder_run
15. prosince 2024 v 10:13

estimated_db_size
106.05 MiB

database_engine
sqlite

database_version
3.45.3

Sonoff

version
3.8.1 (ffa7e22)

cloud_online
11 / 14

local_online
9 / 9

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
I don't know if I missed something, but after updating to v1.2.0 I get a warning while playing. Everything works fine.

folder exists

Reproduction steps

...
update to v1.2.0
Debug logs
Tato chyba pochází z vlastní integrace.

Logger: custom_components.chime_tts.helpers.filesystem
Zdroj: custom_components/chime_tts/helpers/filesystem.py:54
integrace: Chime TTS (dokumentace, problémy)
První výskyt: 11:00:03 (1 výskyty)
Naposledy logováno: 11:00:03

Error: The directory '/www/tony' was not found.

Diagnostics dump
No response

Hi @pepe59,
This error relates to looking up the folder on your filesystem. I don't quite understand the conext of this error, and it might be nothing given that it doesn't seem to effect the process - but could you please enable debug logging and provide me with the debug logs?

Here is the error log. I hope I downloaded it correctly.
Nothing has changed in my HA since the last beta, I just updated Chime
chime_tts.txt

Thank you. What was the YAML that you used when you called chime_tts.say?

I only use the action in automation nothing else
target:
  entity_id: media_player.picoretts
data:
  chime_path: /config/www/tony/zvonek.mp3
  offset: 450
  tts_speed: 107
  volume_level: 0.5
  message: |-
    Aktuální čas je {{states('sensor.time')}}. Pokojová teplota {{
    states('sensor.teplota_byt') | replace('.',',') }} stupňů. Venku {{
    states('sensor.venkovni_teplota') | round(0) | replace('-','mínus') }}
  tts_platform: cloud
  cache: true
action: chime_tts.say

I have released a new beta version, v1.2.2-beta1 with a fix for this issue.

Yes I can confirm that the error no longer appears.
Thank you very much


Make it possible to run analysis in C# without so many rows of code

It confuses and seems a bit unneccessary

Please specify :)

//Run analysis
Calculate.Analysis analysis = new Calculate.Analysis(null, null, null, null, true, false, false, false, false, false, false, false, false, false, false, false, false);
FemDesign.Calculate.FdScript fdScript = FemDesign.Calculate.FdScript.Analysis(outPathIndividual, analysis, bscPaths, "", true);
Calculate.Application app = new Calculate.Application();
app.RunFdScript(fdScript, false, true, true);
The part about creating an analysis, creating an fdscript, creating an app and then running the app should be possible to make more efficient. So that it works more like the GH component

Duplicate of #223


[sailfish-secrets] Make opensslcrypto plugin to link with libcrypt.

The previous PR from @rainemak missed the plugin in crypto ;)

Fix for openssl crypto plugin test plugin went in as part of https://github.com/sailfishos/sailfish-secrets/pull/60.
Though hide_symbols was missing from there. If you like to amend this a bit I'll land this as well. Thanks @dcaliste

Ok, for inclusion with #60, good, good. I've ammended the commit as suggested just to add the hide_symbols part.

LGTM


migrated dependencies, ran migrate helper

In progress PR for migrating to Null Safety.
@synw I had an API design question: should users be able to create data frames with:

some columns unspecified in some rows?
some column values explicitly set to null?
Eg is the following the intended behavior:

    final rows = <Map<String, dynamic>>[
      <String, dynamic>{'col1': 'a', 'col2': 1, 'col3': 1.0, 'col4': date},
      <String, dynamic>{'col1': 'b', 'col2': 2, 'col3': 2.0, 'col4': date},
      // col3 is null and col4 is unspecified
      <String, dynamic>{'col1': 'c', 'col2': 3, 'col3': null},
    ];
    df = DataFrame.fromRows(rows);
    expect(df.dataset, <dynamic>[
      <dynamic>['a', 1, 1.0, date],
      <dynamic>['b', 2, 2.0, date],
      // null value is passed through, unspecified value is converted to null
      <dynamic>['c', 3, null, null],
    ]);

@synw  (theoretically) all done! I'll spend a day or two spiffing it up and adding some unit tests to further verify proper null handling. Separate idea, let me know your thoughts:
Maybe df should have a constructor argument for nullable vs non-nullable. If a user doesn't want to allow null values, we should throw any time they add a row with an omitted column or add a value with a null value.

Oof this has become a huge refactor. All tests currently passing but the sort test. It's not passing because the old behavior (and the test) assumed greatest-to-least sort order. I've updated it to use the default dart sort implementation which assumes least-to-greatest sort order. Do we want to:
a. Update the test to expect least-to-greatest sort order
b. Update the implementation to maintain greatest-to-least sort order
or
c. Add a sort order argument where the user can specify their desired sort order

Maybe df should have a constructor argument for nullable vs non-nullable

Good idea, so that the user can control this behavior. I am pretty much ignorant about null safety migration as I don't do much Dart these days and have never migrated any libs to null safety yet. You are doing an excellent work on this lib, thanks to you. Do you want to be maintainer?

Being a maintainer would be great, thanks!
Once this PR's in I'll make a follow up to enable users to construct a non-nullable DataFrame.

Hi guys, can you say when we might get a null safety for this plugin?

@marchelo Hey! Sorry for the late response. I'll aim to have a prerelease out by Friday!

@synw this PR is done and I'm going to merge it. I've set the version to 0.4.0-nullsafety.0 to indicate that this is a prerelease-though I don't expect any major bugs. In addition to the unit tests passing, I've updated my personal project that depends on DF to use it and haven't had any issues.
Once it's merged could you update the pub.dev package? Or if you don't mind adding me as an uploarder to the pub.dev package, I'm happy to update it myself.

fyi @marchelo this PR is done. It's not launched yet on pub.dev, but if you'd like to migrate to null safety sooner you can fork this repo and depend on it via a path dependency. Assuming you download df to the same parent directory as your project:
  df:
    path: '../df'

Thank You! @caseycrogers


Incorrect JSON value rendered for inherited objects

Given following blueprint / MSON
# MSON Playground

# GET /1
+ response 200 (application/json)
    + attributes (B)

# Data Structures
# A
- type: a

# B (A)
- type: b

The output application/json for B is incorrectly
{
  "type": "a"
}

instead of:
{
  "type": "b"
}

Also related https://github.com/apiaryio/mson/issues/28

Didn't dig deeper, but is this Boutique's bug or Drafter's? Because Boutique doesn't know anything about inheritance and completely relies on expanded AST it gets from Drafter.

Going to close this issue since Boutique has been replaced with Drafter. This bug has been resolved (or never existed) in Drafter.


Check attribute defaults

Check that formatting attribute defaults are working as expected, and that column_defaults and define functions are overriding as expected.

Added several test cases to check all combinations of defaults.  Working good.  No changes.


DAX intelliSense is one of the nicest feature is missing in Tabular editor. is it possible to get them added

Duplicate of #64

It’s in the works but I can’t provide an ETA at this time.

Hi Daniel,
Thanks for quick response and great to hear that it is in the works.
On Fri, Jul 24, 2020 at 10:01 AM Daniel Otykier<EMAIL_ADDRESS>wrote:

It’s in the works but I can’t provide an ETA at this time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/otykier/TabularEditor/issues/550#issuecomment-663553647,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHXYCA35HNEVXX2WTTJ67P3R5GH5JANCNFSM4PF6WRKQ
.


Slack integration broken

OS version: W10
Browser version: Chrome 67
Extension version: 1.40.1

Relevant integration (if any):
Slack
🐛 Describe the bug
Toggl Button doesn't appear in Slack
Expected behaviour
Toggl Button should appear next to channel actions and message actions
Steps to reproduce

Go to Slack
Look for the button 🔎

Other details or context
This class doesn't seem to exist any more, no idea about the message actions though 🤷♀
User report

User report


Prefix and suffix feature

Closes #25

This change is

Reviewed 16 of 16 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

Nice, you made it work with floating labels as well 👍
But why the use of id’s in the template elements? We aren’t even using the Polymer convenience accessor for those (this.$), and it just pollutes the DOM with multiple same id’s in polyfilled browsers. I think it would have been future-proof to use the part="suffix" syntax already, as we need to change to that anyway before releasing the first version.

Using part of course means we need to decide which parts to actually expose, so it was probably quicker to implement this way.

We use id’s pretty much overall in templates to mark unique elements. There were some in this template also before this ticket and those of the new ones are mostly derived from <paper-input-container>. Didn’t consider switching to using the part markers as part of this specific ticket. But sure it should be done before 1.0.

Sure, no problem :) I’ve just always wondered this pattern, as I feel the id’s are so “heavy-weight” because of their CSS specificity and the fact that you should only have unique id’s in the DOM (we might be breaking someone’s app if they happen use the same exact id for their app specific element, right?).


Is it possible not to generate a snapshot if the file has not changed?

Output of restic version
restic 0.15.2 compiled with go1.20.3 on linux/amd64
What should restic do differently? Which functionality do you think we should add?
Is it possible not to generate a snapshot if the file has not changed?
What are you trying to do? What problem would this solve?
I automatically execute scheduled tasks. If the file has not changed, a snapshot will also be generated, which makes it impossible for me to tell which snapshot is useful, and many unnecessary empty snapshots are kept.
Did restic help you today? Did it make you happy in any way?
restic is very nice，thank you all

Duplicate of #662. Please upvote that issue if you're interested in the feature.


Fix a bug of reusable cell

Cell's attributes should be refreshed in each reuse. :-)

Seems good, I will try for my assignment, thanks guys !


Closing PRs older than 1 month and without activity

As proposed here: http://cloudstack.markmail.org/search/?q=#query:+page:1+mid:rkptskqvajs7n7zj+state:results
This will close these PRs:
https://github.com/apache/cloudstack/pull/577
https://github.com/apache/cloudstack/pull/566
https://github.com/apache/cloudstack/pull/562
https://github.com/apache/cloudstack/pull/561
https://github.com/apache/cloudstack/pull/556
https://github.com/apache/cloudstack/pull/555
https://github.com/apache/cloudstack/pull/554
https://github.com/apache/cloudstack/pull/548
https://github.com/apache/cloudstack/pull/544
https://github.com/apache/cloudstack/pull/540
https://github.com/apache/cloudstack/pull/384
https://github.com/apache/cloudstack/pull/372
If you want a PR to stay open, comment to the PR and let me know.

https://github.com/apache/cloudstack/pull/508 was worked on 14 days ago by @resmo and @wilderrodrigues

@DaanHoogland That's true. Although @wilderrodrigues will take over the PR and needs to create a new one. But let's stick to the proposal indeed. I'll remove #508 from the list.

I did not send a :-1: to<EMAIL_ADDRESS>I did not omit that mail by mistake (sorry for the double negative). the proposal seems radical (17 july is phased out on 17  August) but house cleaning is needed. let's make a PR like this on a weekly basis.

@DaanHoogland Weekly basis is OK with me!

All, let's not do this for multiple reasons;

by closing a PR which has not got attention we risk forgetting about it and losing the contribution
generally those of us who have worked for long in the community or have dayjob colleagues working in the community, have better chances in getting their PRs merged; for new contributors this pattern is not encouraging and certainly not welcoming if their PRs get closed just because it did not caught any attention in one month's time
our community works on the premise that everyone is a contributor working as per their convenience, interest and time, on top of this the developer community is not very large to ensure that all PRs will get attention or review within a months time of its arrival
the requirement of 2 LGTM on each review makes it too much process-oriented that costs time and efforts, sometimes fixes are small but getting them merged has taken more time

@bhaisaab OK, let's leave it for now and discuss later. I will close the PR.

@bhaisaab @remibergsma : Rohit has some good points there and some that can be avoided. Noticably a PR that hasn't gotten any attention from the community should not be closed. But when several people have given feedback and the author does not respond it is of a different case. Let's revisit if the present backlog groth continues.


Update README.md

Fixing markdown and beautification.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ShashwatNigam99 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

README.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Switch to floating-ui

@tippyjs/react was last updated 2 years ago. It's also fun to try new things, and pop over UI is changing all the time (see: CSS overflow-anchor)
https://floating-ui.com/docs/react

This was already done!


Incorrect English construction

In the section on Runtime Safety, the last sentence of the first paragraph begins "Users are strongly recommended to develop and test ....". This is not grammatically correct. Suggested fix: "It is strongly recommended that users develop and test ...."

I personally feel that making users consistently the subject of sentences in this document is preferable to "we" or "it"...

There are several examples of the use of "we" in the website, for example: Here, we allocate 100 bytes as a []u8.. Either way, a consistent style should ideally be stuck to.


Optional, INTERNAL_APPLICATION 1<<11 extension

Decide yourself whether to include that, but from experimenting with different account packages and the users flags, the added description makes sense.

if you can prove the tests then it's a worthy addition

Sure, imma provide it later

Hihi, should I consider this as not being merged anytime in the near future?

yeah i can't give any proof


Error moving to GPU

Hi,
I am testing your great package. After trying yesterday to do one epoch on my CPU with my own dataset, it took about 16 hours so I figured the package worked but I needed some GPU acceleration. :-)
I installed OpenCL for my GeForce GT 330M (please don't laugh, I am still testing the fundamentals before scaling up). Then I added a config file to the build folder specifying which device and platform I wanted to use. I recompiled the package with the OpenCL flag on in ccmake. When I trained the network again, I get the error:
ERR [ Tensor::MoveToGPU(407) ] FATAL: Error moving to GPU: -4
terminate called after throwing an instance of 'std::runtime_error'
The full output:
ruud@computer:~/CN24/cn24/build$ ./trainNetwork application/config.set application/test.net
INF [ System::Init(68) ] CN24 version 06206bfbe88095f4dca46506a7fe06ee497d6e76 refs/heads/stable
INF [ System::Init(69) ] Copyright (C) 2015 Clemens-Alexander Brust
INF [ System::Init(70) ] For licensing information, see the LICENSE file included with this project.
DBG [ System::Init(75) ] Executable path: /home/ruud/CN24/cn24/build/
INF [ System::Init(89) ] Loading config file: /home/ruud/CN24/cn24/build/config
INF [ CLHelper::Init(200) ] Using OpenCL device: GeForce GT 330M
INF [ CLHelper::Init(201) ] Image support: Yes
INF [ CLHelper::Init(202) ] Max work group size:<PHONE_NUMBER>
INF [ CLHelper::Init(213) ] Creating OpenCL context...
INF [ CLHelper::Init(224) ] Creating OpenCL command queue...
DBG [ CLHelper::CreateProgram(350) ] Compiling kernels/crossCorrelation.cl
DBG [ CLHelper::CreateProgram(350) ] Compiling kernels/biasedConvolution.cl
DBG [ CLHelper::CreateProgram(350) ] Compiling kernels/fullConvolution.cl
DBG [ CLHelper::CreateProgram(350) ] Compiling kernels/foldWeights.cl
DBG [ CLHelper::CreateProgram(350) ] Compiling kernels/biasedMatrixVector.cl
DBG [ CLHelper::CreateProgram(350) ] Compiling kernels/biasGradient.cl
DBG [ CLHelper::CreateProgram(350) ] Compiling kernels/matrixMatrix.cl
DBG [ CLHelper::CreateProgram(350) ] Compiling kernels/maximumPooling.cl
DBG [ CLHelper::CreateProgram(350) ] Compiling kernels/nonLinearFunctions.cl
DBG [ TensorViewer::TensorViewer(57) ] Instance created.
DBG [ ConfigurableFactory::ConfigurableFactory(57) ] Adding convolutional layer to receptive field (7,7)
DBG [ ConfigurableFactory::ConfigurableFactory(64) ] Convolutional layer
DBG [ ConfigurableFactory::ConfigurableFactory(66) ] Adding maxpooling layer to receptive field (2,2)
DBG [ ConfigurableFactory::ConfigurableFactory(57) ] Adding convolutional layer to receptive field (5,5)
DBG [ ConfigurableFactory::ConfigurableFactory(57) ] Adding convolutional layer to receptive field (5,5)
DBG [ main(78) ] Optimal settings: LR: 0.0001, GM: 0.003, EX: 0.75, SB: 10, PB: 2, L1: 0.001, L2: 0.0005, MM: 0.9
INF [ main(84) ] Using fully convolutional training
DBG [ TensorStreamDataset* Conv::TensorStreamDataset::CreateFromConfiguration(328) ] Loading dataset with 6 classes
DBG [ TensorStreamDataset* Conv::TensorStreamDataset::CreateFromConfiguration(329) ] Training tensor: /home/ruud/CN24/cn24/build/pepper/pepper_train.Tensor
DBG [ TensorStreamDataset* Conv::TensorStreamDataset::CreateFromConfiguration(330) ] Testing tensor: /home/ruud/CN24/cn24/build/pepper/pepper_test.Tensor
DBG [ TensorStreamDataset::TensorStreamDataset(32) ] Instance created.
DBG [ TensorStreamDataset::TensorStreamDataset(54) ] 1 training tensors
DBG [ TensorStreamDataset::TensorStreamDataset(73) ] 1 testing tensors
DBG [ DatasetInputLayer::DatasetInputLayer(31) ] Instance created.
DBG [ DatasetInputLayer::DatasetInputLayer(41) ] Using loss sampling probability: 0.25
DBG [ DatasetInputLayer::DatasetInputLayer(47) ] Total samples: 2
DBG [ Net::AddLayer(59) ] Layer 0 output 0: (2s@1000x752x3m)
DBG [ Net::AddLayer(59) ] Layer 0 output 1: (2s@1000x752x6m)
DBG [ Net::AddLayer(59) ] Layer 0 output 2: (2s@1000x752x2m)
DBG [ Net::AddLayer(59) ] Layer 0 output 3: (2s@1000x752x1m)
DBG [ Net::AddLayer(73) ] Layer 0 added.
DBG [ Net::AddLayer(77) ] Layer 0 is OpenCL aware
DBG [ Net::AddLayer(87) ] Layer 0 added as training layer.
DBG [ ResizeLayer::ResizeLayer(23) ] Instance created, border size: (22, 22)
DBG [ Net::AddLayer(37) ] Layer 1 input: layer 0, output 0
DBG [ Net::AddLayer(59) ] Layer 1 output 0: (2s@1022x774x3m)
DBG [ Net::AddLayer(73) ] Layer 1 added.
DBG [ Net::AddLayer(77) ] Layer 1 is OpenCL aware
DBG [ ConfigurableFactory::AddLayers(147) ] Parsing layer: convolutional kernels=16 size=7x7
DBG [ ConfigurableFactory::AddLayers(157) ] Parsed dropout fraction: 0
DBG [ ConvolutionLayer::ConvolutionLayer(48) ] Instance created. 16 output maps with 7x7 kernels.
DBG [ ConvolutionLayer::ConvolutionLayer(50) ] Dropout fraction: 0
DBG [ ConfigurableFactory::AddLayers(162) ] LLR factor: 1, RFX: 24
DBG [ Layer::SetLocalLearningRate(76) ] Setting local learning rate to 1
DBG [ Net::AddLayer(37) ] Layer 2 input: layer 1, output 0
DBG [ Net::AddLayer(59) ] Layer 2 output 0: (2s@1016x768x16m)
DBG [ ConvolutionLayer::Connect(113) ] Local learning rate is now 1
DBG [ Net::AddLayer(73) ] Layer 2 added.
DBG [ Net::AddLayer(77) ] Layer 2 is OpenCL aware
DBG [ ConfigurableFactory::AddLayers(147) ] Parsing layer: maxpooling size=2x2
DBG [ MaxPoolingLayer::MaxPoolingLayer(22) ] Instance created: 2x2 pooling.
DBG [ Net::AddLayer(37) ] Layer 3 input: layer 2, output 0
DBG [ Net::AddLayer(59) ] Layer 3 output 0: (2s@508x384x16m)
DBG [ Net::AddLayer(73) ] Layer 3 added.
DBG [ Net::AddLayer(77) ] Layer 3 is OpenCL aware
DBG [ ConfigurableFactory::AddLayers(147) ] Parsing layer: tanh
DBG [ TanhLayer::TanhLayer(54) ] Instance created, nl: Tanh
DBG [ Net::AddLayer(37) ] Layer 4 input: layer 3, output 0
DBG [ Net::AddLayer(59) ] Layer 4 output 0: (2s@508x384x16m)
DBG [ Net::AddLayer(73) ] Layer 4 added.
DBG [ Net::AddLayer(77) ] Layer 4 is OpenCL aware
DBG [ ConfigurableFactory::AddLayers(147) ] Parsing layer: convolutional size=5x5 kernels=12
DBG [ ConfigurableFactory::AddLayers(157) ] Parsed dropout fraction: 0
DBG [ ConvolutionLayer::ConvolutionLayer(48) ] Instance created. 12 output maps with 5x5 kernels.
DBG [ ConvolutionLayer::ConvolutionLayer(50) ] Dropout fraction: 0
DBG [ ConfigurableFactory::AddLayers(162) ] LLR factor: 1, RFX: 24
DBG [ Layer::SetLocalLearningRate(76) ] Setting local learning rate to 1
DBG [ Net::AddLayer(37) ] Layer 5 input: layer 4, output 0
DBG [ Net::AddLayer(59) ] Layer 5 output 0: (2s@504x380x12m)
DBG [ ConvolutionLayer::Connect(113) ] Local learning rate is now 1
DBG [ Net::AddLayer(73) ] Layer 5 added.
DBG [ Net::AddLayer(77) ] Layer 5 is OpenCL aware
DBG [ ConfigurableFactory::AddLayers(147) ] Parsing layer: tanh
DBG [ TanhLayer::TanhLayer(54) ] Instance created, nl: Tanh
DBG [ Net::AddLayer(37) ] Layer 6 input: layer 5, output 0
DBG [ Net::AddLayer(59) ] Layer 6 output 0: (2s@504x380x12m)
DBG [ Net::AddLayer(73) ] Layer 6 added.
DBG [ Net::AddLayer(77) ] Layer 6 is OpenCL aware
DBG [ ConfigurableFactory::AddLayers(147) ] Parsing layer: convolutional size=5x5 kernels=64
DBG [ ConfigurableFactory::AddLayers(157) ] Parsed dropout fraction: 0
DBG [ ConvolutionLayer::ConvolutionLayer(48) ] Instance created. 64 output maps with 5x5 kernels.
DBG [ ConvolutionLayer::ConvolutionLayer(50) ] Dropout fraction: 0
DBG [ ConfigurableFactory::AddLayers(162) ] LLR factor: 1, RFX: 24
DBG [ Layer::SetLocalLearningRate(76) ] Setting local learning rate to 1
DBG [ Net::AddLayer(37) ] Layer 7 input: layer 6, output 0
DBG [ Net::AddLayer(59) ] Layer 7 output 0: (2s@500x376x64m)
DBG [ ConvolutionLayer::Connect(113) ] Local learning rate is now 1
DBG [ Net::AddLayer(73) ] Layer 7 added.
DBG [ Net::AddLayer(77) ] Layer 7 is OpenCL aware
DBG [ ConfigurableFactory::AddLayers(147) ] Parsing layer: tanh
DBG [ TanhLayer::TanhLayer(54) ] Instance created, nl: Tanh
DBG [ Net::AddLayer(37) ] Layer 8 input: layer 7, output 0
DBG [ Net::AddLayer(59) ] Layer 8 output 0: (2s@500x376x64m)
DBG [ Net::AddLayer(73) ] Layer 8 added.
DBG [ Net::AddLayer(77) ] Layer 8 is OpenCL aware
DBG [ ConfigurableFactory::AddLayers(147) ] Parsing layer: convolutional size=1x1 kernels=192
DBG [ ConfigurableFactory::AddLayers(157) ] Parsed dropout fraction: 0
DBG [ ConvolutionLayer::ConvolutionLayer(48) ] Instance created. 192 output maps with 1x1 kernels.
DBG [ ConvolutionLayer::ConvolutionLayer(50) ] Dropout fraction: 0
DBG [ ConfigurableFactory::AddLayers(162) ] LLR factor: 1, RFX: 24
DBG [ Layer::SetLocalLearningRate(76) ] Setting local learning rate to 1
DBG [ Net::AddLayer(37) ] Layer 9 input: layer 8, output 0
DBG [ Net::AddLayer(59) ] Layer 9 output 0: (2s@500x376x192m)
DBG [ ConvolutionLayer::Connect(113) ] Local learning rate is now 1
DBG [ Net::AddLayer(73) ] Layer 9 added.
DBG [ Net::AddLayer(77) ] Layer 9 is OpenCL aware
DBG [ ConfigurableFactory::AddLayers(147) ] Parsing layer: tanh
DBG [ TanhLayer::TanhLayer(54) ] Instance created, nl: Tanh
DBG [ Net::AddLayer(37) ] Layer 10 input: layer 9, output 0
DBG [ Net::AddLayer(59) ] Layer 10 output 0: (2s@500x376x192m)
DBG [ Net::AddLayer(73) ] Layer 10 added.
DBG [ Net::AddLayer(77) ] Layer 10 is OpenCL aware
DBG [ ConfigurableFactory::AddLayers(147) ] Parsing layer: convolutional size=1x1 kernels=6
DBG [ ConfigurableFactory::AddLayers(157) ] Parsed dropout fraction: 0
DBG [ ConvolutionLayer::ConvolutionLayer(48) ] Instance created. 6 output maps with 1x1 kernels.
DBG [ ConvolutionLayer::ConvolutionLayer(50) ] Dropout fraction: 0
DBG [ ConfigurableFactory::AddLayers(162) ] LLR factor: 1, RFX: 24
DBG [ Layer::SetLocalLearningRate(76) ] Setting local learning rate to 1
DBG [ Net::AddLayer(37) ] Layer 11 input: layer 10, output 0
DBG [ Net::AddLayer(59) ] Layer 11 output 0: (2s@500x376x6m)
DBG [ ConvolutionLayer::Connect(113) ] Local learning rate is now 1
DBG [ Net::AddLayer(73) ] Layer 11 added.
DBG [ Net::AddLayer(77) ] Layer 11 is OpenCL aware
DBG [ ConfigurableFactory::AddLayers(147) ] Parsing layer: sigm
DBG [ SigmoidLayer::SigmoidLayer(55) ] Instance created, nl: Sigmoid
DBG [ Net::AddLayer(37) ] Layer 12 input: layer 11, output 0
DBG [ Net::AddLayer(59) ] Layer 12 output 0: (2s@500x376x6m)
DBG [ Net::AddLayer(73) ] Layer 12 added.
DBG [ Net::AddLayer(77) ] Layer 12 is OpenCL aware
DBG [ UpscaleLayer::UpscaleLayer(18) ] Instance created: 2x2 upscaling.
DBG [ Net::AddLayer(37) ] Layer 13 input: layer 12, output 0
DBG [ Net::AddLayer(59) ] Layer 13 output 0: (2s@1000x752x6m)
DBG [ Net::AddLayer(73) ] Layer 13 added.
WRN [ Net::AddLayer(79) ] Layer 13 is NOT OpenCL aware
DBG [ ConfigurableFactory::AddLayers(236) ] Added upscaling layer for FCN
DBG [ main(127) ] Output layer id: 13
DBG [ ErrorLayer::ErrorLayer(17) ] Instance created.
DBG [ Net::AddLayer(37) ] Layer 14 input: layer 13, output 0
DBG [ Net::AddLayer(37) ] Layer 14 input: layer 0, output 1
DBG [ Net::AddLayer(37) ] Layer 14 input: layer 0, output 3
DBG [ Net::AddLayer(73) ] Layer 14 added.
WRN [ Net::AddLayer(79) ] Layer 14 is NOT OpenCL aware
DBG [ Net::AddLayer(123) ] Layer 14 added as loss function layer.
DBG [ ConfusionMatrixLayer::ConfusionMatrixLayer(17) ] Instance created, 6 classes.
DBG [ Net::AddLayer(37) ] Layer 15 input: layer 13, output 0
DBG [ Net::AddLayer(37) ] Layer 15 input: layer 0, output 1
DBG [ Net::AddLayer(37) ] Layer 15 input: layer 0, output 3
DBG [ Net::AddLayer(73) ] Layer 15 added.
WRN [ Net::AddLayer(79) ] Layer 15 is NOT OpenCL aware
DBG [ Net::AddLayer(111) ] Layer 15 added as confusion matrix layer.
DBG [ ConvolutionLayer::OnLayerConnect(695) ] Updating weights: 192 -> 0
DBG [ ConvolutionLayer::OnLayerConnect(695) ] Updating weights: 64 -> 192
DBG [ ConvolutionLayer::OnLayerConnect(695) ] Updating weights: 300 -> 64
DBG [ ConvolutionLayer::OnLayerConnect(695) ] Updating weights: 400 -> 300
DBG [ ConvolutionLayer::OnLayerConnect(695) ] Updating weights: 147 -> 100
DBG [ Trainer::Trainer(22) ] Instance created
DBG [ Trainer::Trainer(37) ] Optimizing 10 sets of parameters.
DBG [ Trainer::Trainer(57) ] Weights: 40082
INF [ Trainer::Trainer(60) ] Training settings: LR: 0.0001, GM: 0.003, EX: 0.75, SB: 10, PB: 2, L1: 0.001, L2: 0.0005, MM: 0.9
INF [ main(247) ] Enter "help" for information on how to use this program

train epochs=1

DBG [ Net::SetTestOnlyStatDisabled(174) ] Confusion matrix layer disabled: 0
DBG [ Trainer::Epoch(162) ] Epoch: 0, it: 100, bsize: 20, lr0: 0.0001
ERR [ Tensor::MoveToGPU(407) ] FATAL: Error moving to GPU: -4
terminate called after throwing an instance of 'std::runtime_error'
what():  See log for details.
Aborted (core dumped)

Hi,
fully convolutional training uses a lot of memory. Error -4 is OpenCL's code for "not enough". You may want to try hybrid training:
https://github.com/cvjena/cn24/wiki/Hybrid-Training
But I'm not sure the shared memory for your integrated GPU is sufficient. Consider using one of the supported BLAS libraries for CPU training, they should be fast enough.

That makes a lot of sense, thanks!