error creating customized resource map for kustomize

What happened:
while extending an operator and including more steps/tasks I'm seeing the error in KUDO controller logs
2019/12/11 10:22:02 InstanceController: Error during execution: fatal error: default/kafka failed in deploy.deploy-cruise.deploy-cruise.cruise-control-deploy: error creating customized resource map for kustomize: <nil> is expected to be map[string]interface {}

What you expected to happen:
Give more information about the error, so operator developers can fix the issue or further debug the issue.
How to reproduce it (as minimally and precisely as possible):
use this branch https://github.com/kudobuilder/operators/tree/issue-1161 to install KUDO Kafka
kubectl kudo plan status  --instance=kafka
Plan(s) for "kafka" in namespace "default":
.
└── kafka (Operator-Version: "kafka-1.0.2" Active-Plan: "deploy")
    ├── Plan deploy (serial strategy) [FATAL_ERROR]
    │   ├── Phase deploy-kafka [COMPLETE]
    │   │   └── Step deploy (COMPLETE)
    │   └── Phase deploy-cruise [FATAL_ERROR]
    │       └── Step deploy-cruise (FATAL_ERROR)
    └── Plan not-allowed (serial strategy) [NOT ACTIVE]
        └── Phase not-allowed (serial strategy) [NOT ACTIVE]
            └── Step not-allowed (serial strategy) [NOT ACTIVE]
                └── not-allowed [NOT ACTIVE]

Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version): 1.16.3
Kudo version (use kubectl kudo version): 0.8.0
Operator:
operatorVersion:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

the issue was caused by empty annotations
https://github.com/kubernetes-sigs/kustomize/issues/1017
leaving this open, so we can close after

bumping kustomize depdendency
having more verbose logs to help operator developers to debug this


Reconnection doesn't work

The call for a reconnect doesnt work properly. Probably a restart of the reactor is needed, which needs a restart of the worker loop.

With v.0.2.0 twisted will be removed anyway from the client. Therefore this won't be fixed.


feat: add codeql workflow

Related Issue
Closes #58
Files added

.github/workflows/codeql.yml

Checklist

[x] Changes done by me have not introduced any new warnings.
[x] I have conducted a self-review of my code.

Please review this PR.
Thanks

I think multiple workflows in single file is not supported. It would be better to have single workflow per yaml file.


Speed comparison with calibrator

I'm trying to get at least as fast as calibrator by @MartinHinz (discussion started in https://github.com/ISAAKiel/calibrator/issues/1)
So far it's not looking good:
$ time ./calibrator -i ../data/input_test.csv > /dev/null

real	0m0,171s
user	0m0,162s
sys	0m0,009s

$ time currycarbon calibrate "1000+200;2000+200;3000+200;4000+200;5000+200;6000+200;7000+200;8000+200" --densityFile /dev/null
Loading calibration curve
Calibrating
Writing density file
Done

real	0m0,675s
user	0m4,261s
sys	0m0,433s

But now I realised that calibrator only returns a 5-year resolution. That's a crucial difference. If I did this as well, I'm sure I could bring the runtime down a lot!
But I don't know if I want to go there. Year-wise resolution can be useful for many applications. Maybe this should be an option to be set by the user.

See the point. Although, it is more than the order of a magnitude. Is this really only the resolution? BtW, worth, writing an article comparing the calibration solutions in existence? Speed, and accuracy, in term of mututal agreement?

Right - probably there's way more that makes currycarbon slow.
But the yearly resolution has a number of consequences: Interpolation of intermediate calCurve values, 5 times more calls to dnorm (where the program spends 30-40% of its runtime), and also 5 times more vector-matrix multiplications (10% of the runtime).


Install wifi module

Getting it physically connected should be easy.  Getting it to connect to wifi should be hard


Typo in 3-command get of Steam example script

You wrote this:
wget -Osteam.sh https://raw.githubusercontent.com/ruanformigoni/flatimage/refs/heads/master/examples/steam.sh
While this should be written:
wget -O steam.sh https://raw.githubusercontent.com/ruanformigoni/flatimage/refs/heads/master/examples/steam.sh

Thanks for the heads up, does the first command fail on your side? I haven't found an issue with the version without the extra space.

@ruanformigoni Interestingly, it doesn't
I assumed it will fail, but it didn't

I have updated the command for it to be easier to understand. Thanks!


python310Packages.glances-api: 0.4.1 -> 0.4.2

Diff: https://github.com/home-assistant-ecosystem/python-glances-api/compare/0.4.1...0.4.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 233212 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.glances
python310Packages.glances-api
python310Packages.glances-api.dist
python311Packages.glances-api
python311Packages.glances-api.dist


docs: try to shed light on L1, L2 keys usage in nightfall

What does this implement/fix? Explain your changes.

Attemp to clarify keys usage in SDK by updating README and tweaking documentation
Add util createZkpKeys to generate zkpKeys from passed/new bip39 mnemonic
Move getContractAddress from User, add as util
Update repo exports so that new utils are available from published packages
Deprecate tokenErcStandard, and remove all semantic-release stuff (not used, adding vulnerability)

Does this close any currently open issues?
Closes #5
What commands can I run to test the change?

See package.json for scripts
Test the package with npm pack

Any other comments?
n/a

Thanks @israelboudoux for the review!!


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 16:24:29 on 2023.07.19
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 2, errors out: 0
Original problem ID: 32756
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=32756

Problem has been resolved in 9m 0s at 16:33:29 on 2023.07.19
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 32756


Possibility of redirecting http to https

Is there a simple way, through scotty with ScottyTLS, to have http://example.com automatically redirect to https://example.com? If so (or if this is available as a wai middleware that I could not find), can it be added to the documentation? And if not, how hard would this be to add for the next release?

So then… that's a “No”? :P

Sorry, closed this is as I thought it was related to a separate pull request. I'm not sure how to do what you described off-hand using scotty-tls. But if I were you I'd use nginx as a load-balancer and have url rewrite urls do it for you. nginx could also terminate your SSL as well.

Not a problem. I kind of did not think this would be possible without digging pretty deeply into Warp. Thanks!


Replace all instances of pnpx with pnpm dlx

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)

Description

What does this PR change? Give us a brief description.
In places when the docs show examples using npx and yarn, they showed pnpx for PNPM, which is deprecated and replaced by pnpm dlx (or pnpm exec if the package is already installed--maybe the PR should use that instead?)

Hi @skra-pa-pa — thanks so much for your contribution! We’re actually about to migrate away from recommending npx/pnpx entirely in favour of pnpm run astro add ..., so I’m going to close this, but I really appreciate you taking the time nevertheless! 🙌


union  types are not strict enough

TypeScript Version:  2.4.0/2.2.1
Code
type A = {type: "a", aValue: "foo"};
type B = {type: "b", bValue: "bar"};

type C = A | B;

const foobar = (param: C) => console.log(param);

foobar({type: "a", bValue: 3, aValue: "foo"});

const testValue : C = {type: "a", bValue: 3, aValue: "foo"};

Expected behavior:
Invocation of foobar is wrong, since {type: "a", bValue: 3, aValue: "foo"} is neither a valid A nor a valid B
Assignment of testValue declared as C to {type: "a", bValue: 3, aValue: "foo"} should also be wrong, but it is not.
Actual behavior:
Union types apparently allow any field of the union members to be present, and their type is not even checked but interpreted as any (bValue should only allow "bar" value, but you can pass 3 or any other value and it won't complain).
Similarly, it would be really great if, after typing 'type: "a",', the autocomplete would start suggesting only the fields compatible (in this case, aValue) instead of all the ones in the union.
I thought that this might have something to do with function parameters being bivariant in typescript, but I would at least expect the assignment "const testValue : C = {type: "a", bValue: 3, aValue: "foo"};" to fail because it really looks wrong...

Invocation of foobar is wrong, since {type: "a", bValue: 3, aValue: "foo"} is neither a valid A nor a valid B

That value is definitely a valid A - it has a matching type property and a matching aValue property. It happens to be a subtype of A due to the extra property, but it's a structural type system and you are allowed to have other properties.
You can make an explicitly disjoint union by declaring that A and B can't have those properties:
type A = {type: "a", aValue: "foo", bValue?: never };
type B = {type: "b", bValue: "bar", aValue?: never };

Assuming that this is correct, I found really confusing that this:
const testValue : C = {type: "a", anotherUnmentionedField: 3, aValue: "foo"};
won't work, since according to the rule, is supposed to also be a valid A.
I would assume that either the compiler should be strict about only allowing known properties of the type it is infering, or instead it should always allow other additional properties to be present.
This rule about allowing other properties to be present, but only if they happen to come from other members of the union, even disregarding their type (treating them as any), doesn't make much sense to me in this case.
However for my specific use-case, your workaround would actually work

I created #16759 to deal with the autocomplete issue since I think it's a separate and independent one.
I still think thought that this issue should not be "working as intended" for the reason described above:
either we should be allowed to specify any additional field as long as the required interface is satisfied, or we shouldn't be allowed to specify anything more than the interface.
The fact that for unions we are allowed to specify fields of the other types composing the union feels wrong to me. Any comments on that @RyanCavanaugh  ?

Ref: #12936

I was not aware of the discussion around exact types.
In that discussion it is mentioned that

For the most part where people want exact types, we'd prefer to fix that by making EPC smarter. A key area here is when the target type is a union type - we want to just take this as a bug fix (EPC should work here but it's just not implemented yet).

That seems to be describing the issue here: EPC working with normal types but not with union types.
If exact types would be added to the language I guess my use cases for this issue should be covered.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Heatmap Layer

I'm wondering if there is any layer like below in CartoDB MobileSDK:
Photos are captured from Mapbox Demo android app

I think it can be achieved by custom styling on clustered layers.
If it's possible, how can I do that?
If it's not, is there any plan for such a feature?
Thanks

Hi. Currently SDK does not support heatmaps. The easiest way to implement them would be via custom raster data source that uses point cloud or vector tile as an input and produces raster as an output. This can be quite a lot of work, though.
Heatmaps have come up a few times before and I think it makes sense to implement them as core part of the SDK. Can not give ETA for this, though. Marking this issue as 'idea-maybe-future' for now.

I'm waiting for that
Thanks for your attention :D


GetClusterManifest 503 error

http://localhost:19080/$/GetClusterManifest?api-version=3.0&_cacheToken=1591619884960
{"Error":{"Code":"E_ABORT","Message":"Operation canceled."}}
standalone setup beta interface

was this a recurring issue and only happened with the beta version?

A series of uninstall/reinstall seems to have resolved this.


Font Family Issue

On Chrome only Arial and Courier New show as options (Helvetica is shown as the selected option by default, but does not show up in the drop down options)
On Firefox only Arial, Courier New, and Times New Roman show up as options.
On IE there are more font family options available.

Thank you for reporting.
However, As same as your previous issue, font-family issues are up to summernote, not django-summernote. Ref : https://github.com/summernote/summernote/issues?utf8=✓&q=font-family


radar module broken (5.3)

Description
Radar isn't working post 5.3. Tried resetting (?) minimum distance, changing zones and checking again on a B rank and nothing (no notification sound for S rank or SS rank so might be an issue of changes to determining actor location). Tried clean replacement of files (with release) and nothing. Other modules work (raid module) ok
Additional information

reload overlay on changes is disabled, no errors in overlay plugin log

Should be fixed now via #1680


Autopkg 2 Issues - GoogleTalkPlugin - MunkiPkginfoReceiptsEditor

I receive the following error in Autopkg 2.
WARNING: /Users/munki/Library/AutoPkg/RecipeRepos/com.github.autopkg.keeleysam-recipes/GoogleTalkPlugin/MunkiPkginfoReceiptsEditor.py: cannot import name 'readPlist' from 'FoundationPlist' (/Library/AutoPkg/FoundationPlist/__init__.py)
Traceback (most recent call last):
  File "/Library/AutoPkg/autopkglib/__init__.py", line 820, in get_processor
    _tmp = imp.load_source(processor_name, processor_filename)
  File "/Library/AutoPkg/Python3/Python.framework/Versions/Current/lib/python3.7/imp.py", line 171, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 696, in _load
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/Users/munki/Library/AutoPkg/RecipeRepos/com.github.autopkg.keeleysam-recipes/GoogleTalkPlugin/MunkiPkginfoReceiptsEditor.py", line 6, in <module>
    from FoundationPlist import readPlist, writePlist
ImportError: cannot import name 'readPlist' from 'FoundationPlist' (/Library/AutoPkg/FoundationPlist/__init__.py)
  File "/Library/AutoPkg/autopkglib/__init__.py", line 820, in get_processor
    _tmp = imp.load_source(processor_name, processor_filename)
Failed.

This appears to have been resolved by d097018.


Check if Module Exists When Reading

Summary
What:
Inside getModuleDataFromDepsFile, check if the module name already resides inside modules. If so, continue, else carry on adding it.
Why:
Theres no need to run all the logic to collate the module data, if we already have it. Take for example, pulling stuff from std/http but different files (so 2 separate import statements), we have all the information needed after the first one, so this will reduce the total time taken to run the commands
Pseudo-code For Implementation
// src/services/module_services.ts

// Whilst looping through the dep content data inside `constructModulesDataFromDeps`:
...
    ...
    // easier to do when we have the github or deno.land url
    const alreadyAggregated = modules.find(module => {
        return module.gitHubUrl === githubUrl
    }) !== undefined
    if (alreadyAggregated) {
        return
    }
...

Taking on this issue? Read this before you get started.
If you take on this issue and the acceptance criteria does not make sense, post comments on this issue with your questions. Also, you can always hop in the Discord channel at https://discord.gg/c5R3sYuR to get help quickly.
Please read the Contributing Guidelines before starting this issue.

Need to make sure that if there are two export lines, that both are updated, so pserudo code:
for each line in deps.ts
  if  modules contains line: continue
  push line data ot module

...

for module in modules
  depscontent = depscontent.replace(the regex WITH GLOBAL, content with new version
  console.log(updated)

Too many edge cases
one being if module exists in array, continue, BUT what if that deps version is up to date, and the other imports aren't, it wont update


EKS Cluster credentials expiration

Credentials in EKS are based on creating a token that has a max life of 15 minutes. We need to consider whether we should be integrating at kubeconfig credentials, instead of ClientConfig(token,CA).
The kubeconfig integration would have the baggage of supporting gcloud auth, and aws iam authenticator binaries.
Alternatively, we could likely create service accounts that were long lived for the same purpose, but this seems less ideal.

@negz can we close this with continuous secret propagation?

@lukeweber  we renew the secret in every reconcile loop - close the issue - feel free to reopen if we have problems with this implementation


Change worker pool instance type from m5.4xlarge to m5.2xlarge

### Tasks
- [x] update the workerpool type in all places both IaC and Docs
- [x] run the tests to make sure deployment goes through as expected
- [ ] analyze the run results for any issues

https://github.com/kami619/keycloak-benchmark/actions/runs/11217372907 - deployment tests are underway.

Based on the run there are a few observations,

We can set the worker pool to m5.2xlarge ec2 type but we need to increase the --min-replicas to 4 as the deployment failed to wait to get enough CPU cores for our current deployment with -min-replicas set to 3.

The pricing would still be 50% less for 4 x m5.2xl than the 3 x m5.4xl nodes, while satisfying the vCPU core count requirement for our deployment.
For 4 m5.2xlarge instances: 4 × $0.384/hour=$1.536/hour

For 3 m5.4xlarge instances: 3 x $0.768/hour=$2.304/hour

There was another worker pool which has no auto-scaling enabled with the m5.xlarge ec2 type node and that seems like something we could do away with, not sure why we need a second type of worker pool to begin with.

Hi Kamesh, thank you for the analysis. Doing the math again, I think it would save us 33% on the worker node costs.
I would have hoped the cluster would scale fast enough for the deployment to complete without changing the min-nodes. Maybe there is a timeout you can tweak?
Still, let's proceed with the change, and change the min number of nodes to 4 as you suggested, as it will speed up the overall deployment. You might want to change the max nodes from 10 to 15 in case someone does another deployment on that cluster to be on the safe side.

@kami619 @ahus1 Should we also update this: https://github.com/keycloak/keycloak/blob/316e00bb98fd33bac0af5fdbaf7caac4481bee82/docs/guides/high-availability/concepts-memory-and-cpu-sizing.adoc?plain=1#L130 as part of this issue

Good point @mhajas, we could do that once we review the results from nightly, and let's propagate that change.


OAP strategies currently don't work in spark-shell, spark-submit

OapStrategies is embedded in OAP through OapSessionState, nevertheless it currently only works in spark-sql & Thriftserver. See #841 for more details.

now config spark session extensions can solve this prpblem


mxnet: allow to compile without sse/f16c

Motivation for this change
fix "illegal instruction" errors
some hardware is missing the f16c CPU feature
$ cat /proc/cpuinfo | grep ^flags | head -n1 | tr ' ' '\n' | grep -x -e sse -e f16c
sse

usage:
{
  buildInputs = [
    (mxnet.override { f16cSupport = false; })
  ];

background:
illegal instruction is thrown by mxnet (cmake config)
$ nix-shell -p gdb python3Packages.mxnet python3
$ gdb --args python3 -c 'import mxnet'
(gdb) run
Program received signal SIGILL, Illegal instruction.
(gdb) bt full
#0  0x00007fffd182d6c8 in dmlc::Registry<nnvm::Op>::Get() ()
   from /nix/store/amd0warvadsc8g02h7ra8fmmry24cffs-python3.9-mxnet-1.6.0/lib/python3.9/site-packages/mxnet/libmxnet.so

fix: build mxnet with -DUSE_F16C=OFF
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

user was banned https://github.com/NixOS/moderation/blob/main/moderation-log.md


Allow execute request with simple action tag

The Dynamics server we are interacting with has some custom methods that don't conform to the same format as the execute_request method uses. This PR adds the ability to exclude the action name from the request tag.
The specs seem to be failing because psavtest.crm.powerobjects.net doesn't resolve.

Thanks @thomas0087 . I'll check out the test issue and get back to you.  Can you give me some details on the Dynamics server? What version? Is it hosted or on-premise?

Hi @jheth, It's an on-premise hosted server, here are the version details

@thomas0087 Can you re-base to see if the build issue is resolved?

Hi @jheth, I've split the if statement and the specs are all green after the rebase 😀


SessionUser protection against nil pointer dereference

SessionUser should be protected against passing sess = nil to avoid
PANIC: runtime error: invalid memory address or nil pointer dereference

in
https://github.com/go-gitea/gitea/pull/18452/files#diff-a215b82aadeb8b4c4632fcf31215dd421f804eb1c0137ec6721b980136e4442aR69
after upgrade from gitea v1.16 to v1.17.
Related: https://github.com/go-gitea/gitea/pull/18452
Author-Change-Id: IB#1126459

Please send backport

PR with backport: #21358


[Server] Support multiple subscriptions (> 20 circles)

Issue requires review and rearrangement. Close it.


instance.admin.(email for example) returns the last user created

Hi,
That's probably a "gorm magic" issue and I really have no idea how to solve it. Check my test server (https://none.com/api/v1/instance/). You'll see that email, contact_account is myself although the serializer processes the i.Admin (admin@).
When I check instances and accounts in Mariadb, this confirms that it holds the right info (see below).
Any hint/solution would be great.
thank you.
Frédéric
select admin_id from instances;
+--------------------+
| admin_id           |
+--------------------+
|<PHONE_NUMBER>84505771 |
+--------------------+

select id, actor_id, email from accounts;
+--------------------+--------------------+--------------------+
| id                 | actor_id           | email              |
+--------------------+--------------------+--------------------+
|<PHONE_NUMBER>84505771 |<PHONE_NUMBER>84200435 |<EMAIL_ADDRESS> |

select id,name from actors where id=109694405584200435;
+--------------------+-------+
| id                 | name  |
+--------------------+-------+
|<PHONE_NUMBER>84200435 | admin |
+--------------------+-------+

thanks for spotting that; back in the day the instance admin was a total hack which was just finding a random account with a matching domain. I suspect that logic is still lurking around.

I was under the impression the gorm magic wasn't working as before adding a LocalUser account, the correct info were returned but if you think that's "intentional", I'm gonna find this culprit ;)

@davecheney I hope my PR will satisfy you ; I was really frustrated by this problem. I found 2 other occurrences (hoping I caught them all.)
Something puzzles me though: gorm documentation describes
type instance struct {
…
AdminID          *snowflake.ID
Admin            *Account
}

type Account {
snowflake.ID
}

as a Belong To association, "the instance belongs to the admin account".
Shouldn't this be instead an Has One, "the instance has one admin account"? If so, one should take a look the the many associations in your schema.
my 2¢

Damnit, did I break that again?

It never worked (I found this when I first played with pub) as it never could (and I bet that's also true with Relationship & Status.)
gorm is tricky (I almost rewrote with sqlc ;) here as its "convention" isn't "the previous field is named like the association field+primarykey". That's very subtle…
Regarding BelongsTo vs HasOne, I don't know if that changes anything today but isn't this a bet that gorm won't do things differently in the future?

I get very confused by HasOne vs BelongsTo in gorm.

you, me and a million people.


Publish v6.0.3

Publishes v6.0.3

Publishes fixes for all v.6.0.3 milestone issues

ran across this when I toggled theme...is correct with the white-ish?

@jeffvg for that section it's supposed to be a random image. It's just not rendering for you for some reason so I think this is ok for now. There's no styles or anything doing that. I assume that's just what happens when an image doesn't render.


[fleet] Add back dd-updater user

What does this PR do?

add back dd-updater user
rm commands now pass through the helper to avoid permission issues when removing a package
agent packages are chown to dd-agent
fixed purge to not delete /opt/datadog-packages, only the nested elements

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Error when compiling:  Subsequent property declarations must have the same type.  Property 'contentRect' must be of type 'DOMRectReadOnly', but here has type 'DOMRectReadOnly'.

I am getting below error when installing and using resize-observer-polyfill  library!
ERROR

node_modules/resize-observer-polyfill/src/index.d.ts:19:18 - error TS2717: Subsequent property declarations must have the same type.  Property 'contentRect' must be of type 'DOMRectReadOnly', but here has type 'DOMRectReadOnly'.

19         readonly contentRect: DOMRectReadOnly;
                    ~~~~~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:11595:14
    11595     readonly contentRect: DOMRectReadOnly;
                       ~~~~~~~~~~~
    'contentRect' was also declared here.

I found the following fixes:
Add "skipLibCheck": true, to tsconfig.json
  "compilerOptions": {
    "skipLibCheck": true,
  },

It works fine for most people who encounter it but this is not what I want. I hope there is a better way?


fix: Add missing participantId in Catalog response

What this PR changes/adds
Add participantId in Catalog response.
Why it does that
participantId is required by the consumer in order to initiate the contract negotiation with the provider.

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (ac0dadc) 64.45% compared to head (874265d) 64.46%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3104   +/-   ##
=======================================
  Coverage   64.45%   64.46%
=======================================
  Files         936      936
  Lines       19167    19169    +2
  Branches     1029     1029
=======================================
+ Hits        12355    12357    +2
  Misses       6424     6424
  Partials      388      388

Impacted Files
Coverage Δ

...nnector/service/ControlPlaneServicesExtension.java
100.00% <100.00%> (ø)

...or/service/catalog/CatalogProtocolServiceImpl.java
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


SSL Error After Upgrading Application To Node 18

We have an application that connects to vault that we are trying to upgrade from Node 14 to Node 18. Node 18 introduced a change in the ssl library that is causes SSL issues with our instance of vault. The error we are seeing is:
Error: write EPROTO 389B736FE57F0000:error:0A000152:SSL routines:final_renegotiate:unsafe legacy renegotiation disabled:../deps/openssl/openssl/ssl/statem/extensions.c:921:

Recommended solutions when searching that error is to change the SSL configuration at the endpoint (which we can't do easily at this time) or implement SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION or SSL_OP_LEGACY_SERVER_CONNECT as described here: https://github.com/nodejs/node/issues/45378
I found an example of adding securityOptions in pass_request_options.js and tried adding multiple variations (secureOptions, securityOptions, agentOptions, etc.) of that to the options section in the application:
    const options = {
      apiVersion: "v1",
      endpoint: "<SANITIZED>",
      token: process.env.VAULT_TOKEN,
      secureOptions: 'SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION',
      agentOptions: {
        secureOptions: 'SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION',
      },
    };

Can someone confirm what the correct option should be for this package and if this is the correct location to try and implement it?

This is not a node or node-vault issue. The latest version of OpenSSL, which apparently the latest node container is using requires the destination to not have unsafe renegotiation. There are workarounds (configurations you can put into the openssl config), or you can get the target web service to secure itself properly.

@tcs-cclaflin - heya! sorry you bump into that;
I'd follow @TJM 's recommendation on upgrading the other server as it makes less sense to unsecure this app in order for it to be backward compatible;
That being said - it's not always easy.
Please feel free to open a PR to this bug once finding the appropriate location for these configurations

Thank you for the replies, unfortunately we don't control the vault endpoint so will have to coordinate with multiple other teams (infrastructure, security, etc.) to try and get it changed.
seeing this in example/pass_request_options.js made me think it was possible to just override it in this library somehow.
    agentOptions: {
        cert: 'mycert',
        key: 'mykey',
        passphrase: 'password',
        securityOptions: 'SSL_OP_NO_SSLv3',
    },

openssl isn't even installed in the image so unsure if creating a custom openssl config would work and was hoping to not have to go that route.

Any updates on how to resolve this issue ?


ImageNet example lacks necessary steps to run

The current imagenet example lacks how to prepare the dataset to pass to the scripts. It is based on Caffe's dataset format, though nowadays I don't think it is reasonable to assume the experience on Caffe for new users. This information is definitely needed to let ImageNet newbies easily try large-scale visual classification with Chainer.

Could you give me some hints about what would be interesting to cover in a simple example? I'm currently learning Chainer (I'm new to it) so I could try to make an example.

Are you talking about adding a new example and not about imagenet, which is the main topic of this issue?

Sorry, I'm not sure if I understood properly the topic of the issue. I was talking about preparing some code to run  models from imagenet, preparing the dataset, optimizer, trainer, etc

Ah, ok, my explanation was not clear. This issue aims at how to run the imagenet example itself. It lacks how to prepare the training and validation datasets to feed to train_imagenet.py. Sorry for confusion.

Hi. I'd love to contribute but I'm new to chainer and deep learning.

I'll fix this issue by changing the example itself to use the ImageNet-1K dataset hosted by Kaggle.

Bump

It will lack backward compatibility, but it would be more user-friendly if L.Classifier is used in training because :meth:forward of models in current examples/imagenet take (x, t) as input and return loss.
This way of implementing is easier to train but it sometimes bothers users when it comes to inference.
Users would assume one model takes x as its input and returns prediction (label or some value) as its output.
So, in my opinion, models should implement forward method in a way that they take x as their input and return prediction.
In training, before setting up an optimizer, we wrap a model by L.Classifier.
In this case, the big picture of train_imagenet.py would look like the below snippet.
class MyModel(chainer.Chain):
    ...
    def forward(self, x):
        ...
        return y

...

model = L.Classifier(MyModel(...))
optimizer = SomeOptimizer(...)
optimizer.setup(model)

...

Bump

@mitmul Do you have any progress?


Why not change the name to Awesome-Datacenter-Networks?

Similar to the following repos:
https://github.com/HuaizhengZhang/Awesome-System-for-Machine-Learning
https://github.com/chaoyanghe/Awesome-Federated-Learning

After including actual awesome stuff, I will add an awesome badge in this list ^_^.


Restore support for Python < 3.12

According to the docs, onexc was introduced in 3.12, so this will need to stay around for quite a while longer.
Fixes #40

We should merge this after #44 and #46 so that CI can actually check that this works across all supported Python versions.

Yay green CI!


Problemas

VSCode Version: Code 1.9.1 (f9d0c687ff2ea7aabd85fb9a43129117c0ecf519, 2017-02-09T00:26:45.394Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.1.0

npm-intellisense
christian-kohler
1.2.1

vscode-eslint
dbaeumer
1.2.6

xml
DotJoshJohnson
1.7.0

tslint
eg2
0.8.1

vscode-npm-script
eg2
0.1.8

vscode-npm
fknop
3.3.0

icon-fonts
idleberg
1.6.1

ionic2-vscode
jgw9617
1.0.0

ionic1-snippets
justinjames
1.0.1

vs-color-picker
lihui
0.4.0

debugger-for-chrome
msjsdiag
2.5.3

ionic2-snippets
oudZy
1.0.0

ionic2
Thavarajan
2.3.5

ionic2-snippets
uqutub
0.0.4

cordova-tools
vsmobile
1.2.6

Steps to Reproduce:

Sorry, we don't have a crystal ball and don't know what you have meant by this issue. Please update the issue with steps to reproduce and we will reopen it.


Doors will no longer be pried open once the doafter finishes if they shouldn't.

About the PR

I fix another bug of my own creation where doors which had their prying doafter start would be pried unconditionally even if the conditions were no longer suitable.
For example people could pry doors open if the power had gone out and the power had come back by the time they were finished.
Why / Balance

It bug. I fix.
Technical details

I just made it so the function that fires once the doafter finished checks if it can still pry the door.
Also that function no longer uses PlayPredicted. Because prediction does not exist for airlocks the prying check on the client will always fail. As a result the sound cannot be predicted.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

fix: You can no longer pry powered/bolted airlocks if you started prying before they were powered/bolted.

the great tider 2 man break in is truly joever


Remove limitation for React client support

We'll soon release version 1.9.0 of the PDF Document Generation module, which will add support for React client. This PR removes the limitation on React client support from the limitations section to reflect this.
Note: This PR should only be merged after the version 1.9.0 has been released to the marketplace, we expect to release this version later today. We will send an update whenever the version is published.

We've published version 1.9.0 of the module in the marketplace. This PR is ready for review and can be merged, thank you in advance!


Improved sentence about teams deletion in teams-usage-report.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/8464.
I have tried to remove a team:

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

reviewed + confirmed


Scav Mode Client

Implementation of Scav mode for the client. Feedback and testing would be appreciated.

Hi @privateryann1 . Thank you for this. It's on my todo list to review! I will look at it when I get some time after we resolve our new networking stuff.

Awesome, I really appreciate all the work you do here!


flutter_driver: add a feature to assert the code's print log

when I run the test_driver/xxx_test.dart like this:
void main() {

  group('disable mips test', () {
    FlutterDriver driver;

    setUpAll(() async {
      driver = await FlutterDriver.connect();

      await driver.waitUntilFirstFrameRasterized();
    });

    tearDownAll(() async {
      if (driver != null)
        driver.close();
    });

    test('big_image_verify_test', () async {
      final SerializableFinder btn = find.byValueKey(big_image_verify);
      expect(btn, isNotNull);
      await driver.tap(btn);

      ...// how to verify the code's log

      await Future<void>.delayed(const Duration(seconds: 3));
    });

  });
}

l want to assert the code's log to verify my personal new feature.

@HungerDeng
There's similar open issue describing your case, 65952.
Please follow-up there for updates.
Closing this as duplicate.


TypeError when trying to open app via localhost:3000

Describe the bug
When i am trying to open http://localhost:3000, after following the setup guide in next-forge docs step by step, i am met with an "Internal Server Error" in my browser, and the following logs in console:

web:dev: ✦Aj WARN Using <IP_ADDRESS> as IP address in development mode
web:dev:  ○ Compiling / ...
web:dev:  ✓ Compiled / in 6.5s
web:dev:  GET / 200 in 7938ms
web:dev: (node:29924) [DEP0060] DeprecationWarning: The util._extend API is deprecated. Please use Object.assign() instead.
web:dev: (Use node --trace-deprecation ... to show where the warning was created)
app:dev:  ○ Compiling / ...
app:dev:  ✓ Compiled / in 8.2s
app:dev: TypeError: The "payload" argument must be of type object. Received null
app:dev:     at frame (....\node_modules.pnpm\next@15.0.3_@babel+core@7.26.0_@opentelemetry+api@1.9.0_react-dom@18.3.1_react@18.3.1\node_modules\next\src\server\patch-error-inspect.ts:89:42)
app:dev:     at getSourcemappedFrameIfPossible (....\node_modules.pnpm\next@15.0.3_@babel+core@7.26.0_@opentelemetry+api@1.9.0_react-dom@18.3.1_react@18.3.1\node_modules\next\src\server\patch-error-inspect.ts:179:32)
app:dev:     at parseAndSourceMap (....\node_modules.pnpm\next@15.0.3_@babel+core@7.26.0_@opentelemetry+api@1.9.0_react-dom@18.3.1_react@18.3.1\node_modules\next\src\server\patch-error-inspect.ts:234:23)
app:dev:     at exit (....\node_modules.pnpm\next@15.0.3_@babel+core@7.26.0_@opentelemetry+api@1.9.0_react-dom@18.3.1_react@18.3.1\node_modules\next\src\server\patch-error-inspect.ts:224:32)
app:dev:     at apply (webpack://next/dist/compiled/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js:569:32)
app:dev:     at apply (webpack://next/dist/compiled/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js:593:32)
app:dev:     at error (....\node_modules.pnpm\next@15.0.3_@babel+core@7.26.0_@opentelemetry+api@1.9.0_react-dom@18.3.1_react@18.3.1\node_modules\next\src\server\lib\router-server.ts:586:18)
app:dev:     at async Server.requestListener (....\node_modules.pnpm\next@15.0.3_@babel+core@7.26.0_@opentelemetry+api@1.9.0_react-dom@18.3.1_react@18.3.1\node_modules\next\src\server\lib\start-server.ts:146:6) {
app:dev:   code: 'ERR_INVALID_ARG_TYPE'
app:dev: }
app:dev:  GET / 500 in 9462ms

Additionally, i have encountered that navigating to /sign-up works in the browser (page renders), but the console still outputs the same error.
Upgraded node and pnpm, also tried pnpm update in monorepo root, none fixes the error.
next-forge version
I am using version 2.18.24
To Reproduce
Steps to reproduce the behavior:

Install next-forge template as per https://docs.next-forge.com/setup
Run pnpm dev
Open localhost:3000

Expected behavior
Seeing the app without this error, only apps/app seems to be encountering this error, apps/web, apps/api, apps/studio etc. works
Screenshots

Desktop (please complete the following information):

OS: Windows 11 23H2 (sadly)
Browser Chrome v131, same Behaviour in Opera, Firefox and Microsoft Edge

Just tried the same setup on a MacOS-based machine, and on there it works. Also spun up a windows VM, works fine on there too. Seems to be an issue on my end, so closing this issue! :)


Ability to exclude specific transformers

I find that I am always having to do some post-processing of the files generated by helm-convert. For example, I almost never want to use namePrefix and I often want to skip the configmap and secret transformers. It would be useful to have a way to specify a list of transformers to skip during the conversion process.

I feel like this should be closed now.


Support for authorization code flow

Because of my application structure, I'm looking to use authorization code flow and pass the code to a backend server which will take over from there.
Does this library have any way to support that? Or ideas of a different one you played with?
Thanks,
B Wins

Hi
There already exit an issue about this topic. https://github.com/manfredsteyer/angular-oauth2-oidc/issues/19
I have implemented a solution for supporting authorization code flow.
There is a pull request for it, https://github.com/manfredsteyer/angular-oauth2-oidc/pull/195, which have been waiting for approval since December 2017.
@manfredsteyer, any plans for merging PR's anytime soon?

+1

+1

+1

+1 - would be good to get this PR integrated

Sorry, I don't manage to support such many variation. I will focus on Implicit Flow which is the most suitable one for browser-based SPA.
Feel free to fork this library for other flows.

Hi
I think this great library need to include the authorization code flow to be complete, and I think its sad it can’t be part of this package. I personally prefer to use the authorization code flow as I think the silent refresh mechanism of the implicit flow is a dirty hack.
I have forked this repository and added support for the authorization code flow. PKCE is currently not implemented.
Go check it out at https://www.npmjs.com/package/angular-oauth2-oidc-codeflow
(Name, versioning, structure, etc. might change in the future)

Sorry, I don't manage to support such many variation. I will focus on Implicit Flow which is the most suitable one for browser-based SPA.
Feel free to fork this library for other flows.

The fact that is the most used does not invalidate that is the more insecure way of doing this.
Please have a read on these links, from https://oauth.net/2/grant-types/implicit/

It is generally not recommended to use the implicit flow (and some servers prohibit this flow entirely). In the time since the spec was originally written, the industry best practice has changed to recommend that public clients should use the authorization code flow with the PKCE extension instead.

ory hydra is a complete implementation of oauth2 RFC authorization server based on best practices and security focused:
https://www.ory.sh/oauth2-for-mobile-app-spa-browser

Hi bechhansen!
I want to build an angular 7 web aplication protected with OAuth2-oidc-Authorization code flow,i'm traying to use your project but it is the same of manfredsteyer I mean it is implimented with the implicit-flow?

Hi @bechhansen !
I want to build an angular 7 web aplication protected with OAuth2-oidc-Authorization code flow,i'm traying to use your project but it is the same of manfredsteyer I mean it is implimented with the implicit-flow?

Hi @bechhansen !
I want to build an angular 7 web aplication protected with OAuth2-oidc-Authorization code flow,i'm traying to use your project but it is the same of manfredsteyer I mean it is implimented with the implicit-flow?

Hi @RFIhism
My project is a fork of this one, but I have added support for authorization code flow.
Recently manfredsteyer have uttered interest in merging the authorization code flow implementation back to the upstream branch. It has not happened yet though. Currently I'm not doing any work on my fork as I am not using it at the moment.

Hi @bechhansen !
Thank you for your response. I understand and I wich that @manfredsteyer merge the authorization code flow to the upstream branch. But I want know if your fork project works correctly
with the authorization code flow? Because je l'ai besion at the moment when I'm working in this flow.

Hi @bechhansen !
Thank you for your response. I understand and I wich that @manfredsteyer merge the authorization code flow to the upstream branch. But I want know if your fork project works correctly
with the authorization code flow? Because je l'ai besion at the moment when I'm working in this flow.

It should work. I have currently a solution running using it. PKCE is currently not implemented though.

In my project,I Don't need to use the PKCE when I'm developping a web application with angular 7 and my server run in HTTPs(are secured). please can i take a look to your solution when can help me. Thanks a lot for your interest and your help.

In my project,I Don't need to use the PKCE when I'm developping a web application with angular 7 and my server run in HTTPs(are secured). please can i take a look to your solution when can help me. Thanks a lot for your interest and your help.

Sorry, my app is not public so I can not share it. Also I might be about to stop using the library as I'm not happy with my IDP (Amazon Cognito).
Have a look at the example at https://github.com/bechhansen/angular-oauth2-oidc. This is pretty much how I use the library.

Hi @bechhansen !
Thanks for your response. I looked your fork but you still use the implicit flow also! When you are difined it in the file "oauth-service.ts" #1066

Hi @bechhansen !
Thanks for your response. I looked your fork but you still use the implicit flow also! When you are difined it in the file "oauth-service.ts" #1066

@RFIhism the implicit flow is still available in the fork, but it is extended with functionality for code flow.
At the time I implemented it, the goal was to have it merged to the upstream branch.


DeveloperGuide: Add implementation details for SaveState

I have updated the UML diagrams and rephrased some of the implementation details, but i have yet to implement the actual refactoring of the statestorage functions that I have indicated in the UML diagrams. Will submit a new PR with updated implementation after submission of DG draft!


Azure SQL Migration Extension in Disconnected Environment

Issue Type: Bug
Attempting to run the Azure SQL Migration Extension in Azure Data Studio on an Azure VM in a restricted environment (no internet access) and witnessing the following behavior:
Steps:
Connect to Source Server
Right-click -> Manage
General -> Azure SQL Migration
Error in notification popup:
Failed to start Sql Migration Service: Error: Request error: Error
at ClientRequest. (c:\Users<userfolder>.azuredatastudio\extensions\microsoft.sql-migration-1.4.2\dist\main.js:2:7448)
at ClientRequest.emit (node:events:538:35)
at TLSSocket.socketErrorListener (node:_http_client:442:9)
at TLSSocket.emit (node:events:526:28)
at emitErrorNT (node:internal/streams/destroy:157:8)
at emitErrorCloseNT (node:internal/streams/destroy:122:3)
at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
Close tab, repeat
Connect to Source Server
Right-click -> Manage
General -> Azure SQL Migration
Azure SQL Migration tab now has content
New Migration (or, "Migrate to Azure SQL" link in welcome screen)
Hangs with "Waiting for SqlMigrationProvider component to start." in the notification popup.  Never resolves or times-out.
Is this extension supported in a disconnected environment?  If not, is there an available list of hostnames/domains that I can request from my network team to allow access?  I am interested in the assessment information, including SKU recommendations.  TIA.
Extension version: 1.4.2
Azure Data Studio version: azuredatastudio 1.42.0 (22f384e569bc90d8b3231cc8c8cff99ea16c5052, 2023-03-17T18:15:48.982Z)
OS version: Windows_NT x64 10.0.17763
Restricted Mode: No
Preview Features: Enabled

System Info

Item
Value

CPUs
Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz (4 x 2594)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_softwarewebgpu: disabled_off

Load (avg)
undefined

Memory (System)
32.00GB (11.22GB free)

Process Argv

Screen Reader
no

VM
0%

Just to add to the above, I'm seeing the same behaviour in my environment.
We have:

Dev VMs on premise
SQL instances on premise
Azure SQL MI
Private routes from on prem into Azure.
Proxy between the Dev VMs and the wider internet, but not between the Dev VMs and everything else mentioned.

Default behaviour throws an exception (different to above) because I'm not authenticating to the proxy. If I fully disable the proxy in Settings > Proxy Support > Off, I get the above exception encountered by pvandermaas-apriva. I got it to load the Azure SQL Migration window once (Proxy Support off, but I think the main app was successfully communicating with the proxy), but then I hung on 'Waiting for SqlMigrationProvider component to start.'
Note: sorry for the brand new account. I made it specifically to comment on this.

@alanrenmsft Have we tested the service downloader in a proxy environment? The comment from @cap-dm sounds like a separate issue where they have their proxy set up but it still doesn't download the service binaries.
@cap-dm Can you confirm that other parts of ADS function with the proxy settings you have - a specific example would be the extension gallery loading and displaying the marketplace extensions.

so just to confirm, the issue is resolved now, right?

@cap-dm Can you confirm that other parts of ADS function with the proxy settings you have - a specific example would be the extension gallery loading and displaying the marketplace extensions.

Oh I know I'm having proxy issues! It was more that I was seeing the same errors as pvandermaas-apriva while experiencing them, so I was throwing some weight behind the SQL Migration Extension (SME) having issues when it was in a disconnected environment.
Now I'm going to have to apologise because I can't quite remember the sequence of events before finding this ticket.

I know I was able to browse to and download the (SME). I don't think I changed any proxy settings prior to this
Once it was down and I launched it I encountered the problems as described above
I have tried many proxy settings, but I was finding either ADS or SME would work correctly not both. I finally managed to get both ADS and SME work by nuking all http.proxy* settings in settings.json and restarting the application. I'm actually astounded this works, but here we are.

I would suggest that both ADS and SME get some more graceful handling of connectivity and proxy issues, it was a pain to debug as those traces don't really tell the end user much.

We're working on making this experience better, but for the time being these steps should work for getting the extension functioning:

Open ADS and run the "Extensions: Open Extensions Folder" command
Look for the latest "microsoft.sql-migration-*" folder (e.g. microsoft.sql-migration-1.4.2)
In there look for a config.json file and open it
Get the version from the "version": "*.*.*.*", line (e.g. "version": "<IP_ADDRESS>")
Download the zip/tar.gz that corresponds to your OS and replace the *.*.*.* in the links below with that version and copy it to the machine that ADS is installed on.

Windows: https://github.com/Microsoft/sqltoolsservice/releases/download/.../microsoft.sqltools.migration-win-x64-net7.0.zip
Windows (x86): https://github.com/Microsoft/sqltoolsservice/releases/download/.../microsoft.sqltools.migration-win-x86-net7.0.zip
OSX: https://github.com/Microsoft/sqltoolsservice/releases/download/.../microsoft.sqltools.migration-osx-x64-net7.0.tar.gz
Linux: https://github.com/Microsoft/sqltoolsservice/releases/download/.../microsoft.sqltools.migration-rhel-x64-net7.0.tar.gz
e.g. for Windows with version <IP_ADDRESS> it would be https://github.com/Microsoft/sqltoolsservice/releases/download/<IP_ADDRESS>/microsoft.sqltools.migration-win-x64-net7.0.zip
6. Unzip the contents
7. Back in the extension folder make sure the following path exists <Path to Extension Folder>/migrationService/<Platform>/<Version> (e.g. %USERPROFILE%\.azuredatastudio\extensions\microsoft.sql-migration-1.4.2\migrationService\Windows\<IP_ADDRESS>)
8. Copy the unzipped contents from above into this new folder. Verify the path is correct by checking that <Path to Extension Folder>/migrationService/<Platform>/<Version>/MicrosoftSqlToolsMigration.exe exists (e.g. %USERPROFILE%\.azuredatastudio\extensions\microsoft.sql-migration-1.4.2\migrationService\Windows\<IP_ADDRESS>\MicrosoftSqlToolsMigration.exe
9. Reload ADS - the Migration extension should start up correctly
Note that you'll need to do this each time a new version of the service is available - so if you hit the error again follow the instructions above (there will likely be a new version you have to download but the rest of the steps are the same)

@AkshayMata @alanrenmsft are we tracking any pending work for the May release with this issue?  Or should we move or close it?

I have a follow up work item.

We're working on making this experience better, but for the time being these steps should work for getting the extension functioning:

Open ADS and run the "Extensions: Open Extensions Folder" command
Look for the latest "microsoft.sql-migration-*" folder (e.g. microsoft.sql-migration-1.4.2)
In there look for a config.json file and open it
Get the version from the "version": "*.*.*.*", line (e.g. "version": "<IP_ADDRESS>")
Download the zip/tar.gz that corresponds to your OS and replace the *.*.*.* in the links below with that version and copy it to the machine that ADS is installed on.

Windows: https://github.com/Microsoft/sqltoolsservice/releases/download/.../microsoft.sqltools.migration-win-x64-net7.0.zip Windows (x86): https://github.com/Microsoft/sqltoolsservice/releases/download/.../microsoft.sqltools.migration-win-x86-net7.0.zip OSX: https://github.com/Microsoft/sqltoolsservice/releases/download/.../microsoft.sqltools.migration-osx-x64-net7.0.tar.gz Linux: https://github.com/Microsoft/sqltoolsservice/releases/download/.../microsoft.sqltools.migration-rhel-x64-net7.0.tar.gz
e.g. for Windows with version <IP_ADDRESS> it would be https://github.com/Microsoft/sqltoolsservice/releases/download/<IP_ADDRESS>/microsoft.sqltools.migration-win-x64-net7.0.zip

Unzip the contents
Back in the extension folder make sure the following path exists <Path to Extension Folder>/migrationService/<Platform>/<Version> (e.g. %USERPROFILE%\.azuredatastudio\extensions\microsoft.sql-migration-1.4.2\migrationService\Windows\<IP_ADDRESS>)
Copy the unzipped contents from above into this new folder. Verify the path is correct by checking that <Path to Extension Folder>/migrationService/<Platform>/<Version>/MicrosoftSqlToolsMigration.exe exists (e.g. %USERPROFILE%\.azuredatastudio\extensions\microsoft.sql-migration-1.4.2\migrationService\Windows\<IP_ADDRESS>\MicrosoftSqlToolsMigration.exe
Reload ADS - the Migration extension should start up correctly

Note that you'll need to do this each time a new version of the service is available - so if you hit the error again follow the instructions above (there will likely be a new version you have to download but the rest of the steps are the same)

Hi , I have tried the above method but , still i am not able to use the migration extension. i have internet on VM. Cloud you please help me.

@raymondtruong @brian-harris is this issue planned for the July release? Please move it out of the July milestone if it isn't. Thanks!

@raymondtruong @brian-harris any updates on this issue? I'll move it to the backlog if there aren't any plans to work on this

is there anything that can be done on the SQL-Migration extension side? or is this all ADS?

@brian-harris the issue Alan linked above is completed. Is there anything else that needs to be done for this issue?

I will assign to someone to verify it is fixed.

@Ramudaykumar I moved this issue to November. Please close if this is complete or add details on what else needs to be done

If source is in local/reachable from the machine ADS is running, we can do assessment and SKU recommendation without internet connection.


HikariCP config fix

Add a PR title
Fixes maxLifetime settings for HikariCP.
Issue
Add a link to the issue here.  Consider using
closing keywords
if the this PR isn't for a story (stories will be closed through different means).
Checklist

[ ] I have added tests to cover my changes
[ ] I have added logging where useful (with appropriate log level)
[ ] I have added JavaDocs where required
[ ] I have updated the documentation accordingly

Note: You may remove items that are not applicable

Nice, but I would address the CodeQL notice.

Fixed that and added some test coverage with @luis-pabon-tf


[SPARK-30230][SQL] Like ESCAPE syntax can not use '_' and '%'

What changes were proposed in this pull request?

Since 25001, spark support like escape syntax.
But '%' and '_' is the reserve char in Like expression. We can not use them as escape char.
Why are the changes needed?

Avoid some unexpect problem when using like escape syntax.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Add UT.

cc @beliefer @cloud-fan @maropu @gengliangwang

Can one of the admins verify this patch?

ok to test

Can one of the admins verify this patch?

ok to test

add to whitelist

Test build #115224 has started for PR 26860 at commit 20532d2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20039/
Test PASSed.

Sorry for a mistake.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20045/
Test PASSed.

Test build #115236 has started for PR 26860 at commit 3def8ff.

Test build #115224 has finished for PR 26860 at commit 20532d2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115224/
Test PASSed.

Test build #115236 has finished for PR 26860 at commit 3def8ff.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115236/
Test PASSed.

Thanks, merging to master

Thanks.

@ulysses-you @maropu @cloud-fan @gengliangwang
I checked postgreSQL, it supports as below:
SELECT 'abC' LIKE 'ab%C' ESCAPE '%';

@beliefer you are right. I run the following in PostgreSQL:
> SELECT 'abcd' LIKE 'ab%_d';
true
> SELECT 'abcd' LIKE 'ab%_d' escape '%';
false

I should not merge it without checking on PostgreSQL. I am going to revert this one.
Any thoughts? @maropu @cloud-fan

Can we check more systems? it does look weird to support % and _ as escape chars.

If '%' and '_' as escape, how to use the real pattern.
Like this ?
SELECT 'abcd' LIKE 'ab%%' escape '%';

But actually StringUtils.escapeLikeRegex will do this check.
while (in.hasNext) {
      in.next match {
        case c1 if c1 == escapeChar && in.hasNext =>
          val c = in.next
          c match {
            case '_' | '%' => out ++= Pattern.quote(Character.toString(c))
            case c if c == escapeChar => out ++= Pattern.quote(Character.toString(c))
            case _ => fail(s"the escape character is not allowed to precede '$c'")
          }
        case c if c == escapeChar => fail("it is not allowed to end with the escape character")
        // we will never run these code path
        case '_' => out ++= "."
        case '%' => out ++= ".*"
        case c => out ++= Pattern.quote(Character.toString(c))
      }
    }

>SELECT 'abcd' LIKE 'ab%%';
true
>SELECT 'abcd' LIKE 'ab%%' ESCAPE '%';
false

@gengliangwang let's revert this.

+1 for the revert, thanks for taking care, @gengliangwang !

OK,  I see.  Thanks for reverting.


Read-only fields for records

Old Djinni Version:
Record's property can read-write for Objective C/Java/JNI code.
New Djinni Version:
Record's property can only read for Objective C/Java/JNI code.

my_record = record {
id: i32;
info: string;
store: set;
hash: map<string, i32>;
values: list<another_record>;

# Comments can also be put here

# Constants can be included
const string_const: string = "Constants can be put here";
const min_value: another_record = {
    key1 = 0,
    key2 = ""
};

}
I think no 'const' keyword can read-write, and 'const' keyword can only read.
Change semantic cause our project hard to maintain.

I don't understand whether you are claiming that something has changed in a way you dislike, or you are proposing a change.  Is this an issue you're seeing in production code, or just a theoretical question from looking at documentation and examples.  Can you clarify?  If Can you give sample code with expected behavior?
The const keyword in a Djinni record is for global constants, not constant fields.  It's equivalent to a "static const" or "constexpr" in C++.  Records have never had const fields in C++, because adding them would disable the ability to assign or move a record.  A record in C++ is intended to just be a bare struct with public fields and trival ctor/copy/move/dtor.  Note that records are always passed through Djinni calls by value (i.e. copied) so there's no risk of unexpected changes across the language boundary.  If you want an object with hidden data which you can control yourself, you can use an interface.  If you want a record not to be modified, you can declare the record variable const.

In Djinni Example[handwritter]:
Previous Version:
item_list = record {
items: list;
}
@interface TXSItemList : NSObject

(id)initWithItemList:(TXSItemList *)itemList;
@property (nonatomic) NSMutableArray *items;
@end

public final class ItemList {
public ArrayList mItems;
public ItemList(
ArrayList items,
String name) {
this.mItems = items;
}
}
Current Version:
item_list = record {
items: list;
}
@interface TXSItemList : NSObject

(nonnull instancetype)initWithItems:(nonnull NSArray<NSString *> *)items;

(nonnull instancetype)itemListWithItems:(nonnull NSArray<NSString *> *)items;

@property (nonatomic, readonly, nonnull) NSArray<NSString *> * items;
@end
public final class ItemList {
/*package*/ final ArrayList<String> mItems;

public ItemList(
        @Nonnull ArrayList<String> items) {
    this.mItems = items;
}

@Nonnull
public ArrayList<String> getItems() {
    return mItems;
}

@Override
public String toString() {
    return "ItemList{" +
            "mItems=" + mItems +
    "}";
}

}
Now, we can not assign a value to property

I'm interpreting this as a feature-request for read-only fields in records.  I don't think there's an issue with doing that for Java or ObjC, though it doesn't really impact the safety of the Djinni interface, so it seems like more a matter of style/preference.  I think the feature would be more questionable if applied to C++, due to the loss of ability to assign/move records.

Thank you Artwyman.
Because of our project use old version for record's property read-write, when we upgraded to new version, the code can not anymore, so i need to change record to interface & use accessor method to do that. Huge task.

I'm sorry, we seem to be miscommunicating.  You're saying you want the properties to be read/write, and they used to be, but they're not anymore?  I don't recall that changing, but it may've been before I was maintainer.  Can you identify the "old version" you're referring to?  I thought you meant that was the current version, but you were asking for a new version to be created.  If that's incorrect, please clarify exactly which versions (identified by commit hash or date) you're referring to.

Discussed on Slack and I think we cleared up the misunderstanding here.  Going to close out this issue, but feel free to re-open if after clarification you think there's a feature request you want tracked.

Hahaha, Kingle, it's you!


setupFiles do not transform by babel-jest

🐛 Bug Report
To Reproduce
when i config in jest.config.js, i set setupFiles is ["<rootDir>/test/setup"]
such as:
module.exports = {
  setupFiles: ["<rootDir>/test/setup"],
  moduleFileExtensions: ["js", "vue", "jsx", "json"],
  ...
}

but i see the setup.js do not transfer by es6, so i can't use 'import'

Yeah I had to add my file to transformIgnorePatterns which felt weird to me. 🤷♂

This seems like a potential regression. After bumping from 24.8.0 to 24.9.0, I began receiving the following error:
/Users/kyle/dev/stax/api/db/migrations/20180128104235_initial.ts:1
import Knex from 'knex';
       ^^^^

SyntaxError: Unexpected identifier
    at Module._compile (internal/modules/cjs/loader.js:872:18)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:947:10)
    at Module.load (internal/modules/cjs/loader.js:790:32)
    at Function.Module._load (internal/modules/cjs/loader.js:703:12)
    at Module.require (internal/modules/cjs/loader.js:830:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at FsMigrations.getMigration (/Users/kyle/dev/stax/api/node_modules/knex/src/migrate/sources/fs-migrations.js:84:12)
    at /Users/kyle/dev/stax/api/node_modules/knex/src/migrate/Migrator.js:82:69
    at arrayFilter (/Users/kyle/dev/stax/api/node_modules/lodash/lodash.js:582:11)
    at filter (/Users/kyle/dev/stax/api/node_modules/lodash/lodash.js:9175:14)
    at /Users/kyle/dev/stax/api/node_modules/knex/src/migrate/Migrator.js:81:13
...

Downgrading back to 24.8.0 removes the issue. Trying to get a small reproduction together.

Simmilar problem on 24.9.0
.../src/database/seeds/1-dropTables.js:2
export const seed = async (knex) => {
^^^^^^

SyntaxError: Unexpected token export
    at Module._compile (internal/modules/cjs/loader.js:721:23)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:690:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Seeder._validateSeedStructure (/Users/dries/Code/pencil/packages/server/node_modules/knex/lib/seed/Seeder.js:97:16)
    at wrapper (/Users/dries/Code/pencil/packages/server/node_modules/lodash/lodash.js:4929:19)
    at arrayMap (/Users/dries/Code/pencil/packages/server/node_modules/lodash/lodash.js:639:23)
    at map (/Users/dries/Code/pencil/packages/server/node_modules/lodash/lodash.js:9554:14)
    at Seeder._runSeeds (/Users/dries/Code/pencil/packages/server/node_modules/knex/lib/seed/Seeder.js:86:23)
    at Seeder._seedData.bind.then (/Users/dries/Code/pencil/packages/server/node_modules/knex/lib/seed/Seeder.js:37:19)
    at Seeder.tryCatcher (/Users/dries/Code/pencil/packages/server/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/dries/Code/pencil/packages/server/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/Users/dries/Code/pencil/packages/server/node_modules/bluebird/js/release/promise.js:604:18)

No fix yet?

For me, 24.8.0 also doesn't work.  The latest version to work is 24.1.0.
Related: #5164

No reproduction has been provided, the parts asking for it in the template was just deleted.
Please provide a minimal reproduction when opening issues

This is still an issue


Swift 3 branch dropping iOS 8 support

With the coming release of Xcode 8/iOS 10/Swift 3 a lot of developers will probably move to the new Swift syntax when updating their apps, but this will most likely also include apps that still require iOS 8 compatibility. By making the Swift 3 branch iOS9+-only this will make it not easy for developers to switch over, especially since Apple is using a very aggressive iOS release cycle:
iOS 8: Sep 17, 2014
iOS 9: Sep 16, 2015
iOS 10: Sep 2016(?)
Is there a big reason to drop iOS 8 support now? I understand the need to keep the code clean and up-to-date, but I don't think iOS 8 compatibility is something that will disappear overnight for most developers (I am aware that all iOS 8 devices can be updated to iOS 9, but that's not something everyone does).
It would be very nice to have at least an initial release using Swift 3 that's compatible with iOS 8 and then moving away from iOS 8 for next releases (or make the Swift 3 branch require iOS 8.4 if it's mostly related to bugs in 8.1 and 8.2).
FWIW: the current head in the swift3 branch still compiles for iOS 8.

The same problem .
Anyone has the idea?

Thank you for all the reasoning you put together in this issue @tieleman.
While we completely understand you point of view (believe me, we have discussed this at great length), we respectfully disagree with this approach. Apple recommends that developers always support the two latest operating systems. With a library as large and widely used as Alamofire, we need to make sure we are continually re-evaluating our tech debt and moving the needle forward while maintaining the best test suite possible. Because of this, Alamofire 4.x (Swift 3 only) will support iOS 9.0+, macOS 10.11+, tvOS 9.0+ and watchOS 2.0+. This allows us to continue to clean up our tech debt and run our test suite against all supported versions.
With that said, we're absolutely committed to still supporting iOS 8.x for some time. The Alamofire 3.x releases will fully support both Swift 2.2 AND 2.3 for the foreseeable future. The Alamofire 3.x versions will continue to receive bug fixes and security patches while the main focus of the team will be on Alamofire 4.x from here until the GM drops. When app developers are ready to embrace Swift 3, we feel that the majority of apps will be leaving behind support for iOS 8 deployment targets (mixpanel currently reports iOS 9 adoption at over 92%). Now we realize that not everyone will do this, but we strongly believe that the majority of Alamofire users will. Even if you're one of the few, you do still have options.

You can continue to use Alamofire 3.x with Swift 2.3 until you're ready to drop iOS 8.x support. (this is our recommendation)
You could fork Alamofire 4.x and drop the deployment target until you're ready to move.

Alamofire is already segmented across three versions of Swift and 2-3 major versions of 4 different platforms spread over 3 different libraries. This is a tremendous amount of logic to support as well as keep the test suites up and running day-to-day while we try to iterate on Alamofire 4. With our small team, we need to draw the line eventually. There are always trade offs, and we've tried to make the best decisions for the community.
We're also working on publishing an Alamofire 4 evolution document with the proposals we'd like to see make it in over the next few weeks. Hopefully between the info provided in this response alongside the evolution doc, our team will have provided enough transparency and guidance to help the community move between Swift and Alamofire versions successfully and without difficulty.
Cheers. 🍻

Thanks for the explanation, I'm sure I'll find a suitable workaround (currently I'm fixed on the commit just before the version bump), my main concern was that the move to Swift 3 doesn't mandate moving to iOS9+, so it might be an issue for other developers as well.
Also, can you link to something that shows that Apple recommends supporting only the current and previous iOS version. I did a quick Google but came out empty (might be useful to help convince clients).
Hopefully this will all be a thing of the past soon(ish):
https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20160725/002520.html

To make this more concrete, suppose an application is written to use Swift 4, but uses packages via SwiftPM that are written using Swift 3. A single compiler would build both the app and the packages — thus ensuring that all the compiled sources are binary compatible. It would not be the case that a framework built with the Swift 3 compiler could be used by an app built using the Swift 4 compiler. That kind of library binary stability (ABI) will be a key goal of the Swift 4 release.

The recommendation came from Apple in "I believe" WWDC 2014 in one of the bigger talks. I searched around ASCIIWWDC, but I couldn't find what I was looking for.
If I do end up tracking it down, I'll be sure to post the link here. If anyone else in the community was at the same talk I was and knows which one it was and could post the info here, it would be much appreciated.

The same recommendation was made by Woody Lidstone in WWDC 2016 Session 213, "Improving Existing Apps with Modern Best Practices":

What are some things that you can start doing to get ready for the fall?
First of all, if you were to support a deployment target of iOS 8 and 9, you would cover 95% of the devices.
So, there's really no need any more to have any of those deployment targets set to 7.
Let's get rid of that.
In fact, the general idea is that you take the current shipping version, so 9.3, and then set your deployment target to one version back, maybe 8.4.
But don't go to 8.3 or 8.2 anymore because then you and your customers don't benefit from the improvements that we've implemented under the hood in that 8.4 release.
When we come out with iOS X in the fall for the public, set your deployment target to 9.3.

Also note that iOS 9 adoption was at 86% on 18 July 2016 (not > 90% per mixpanel).

Adding my voice to this discussion, I'd like to say that I strongly disagree with the decision to no longer support iOS 8.  In particular, you state:
When app developers are ready to embrace Swift 3, we feel that the majority of apps will be leaving behind support for iOS 8 deployment targets

With iOS 9 support at 86% as @jamesk-au states, why would you assume major developers would be willing to make the switch so early. Dropping support for 14% of a large userbase is likely to have a huge impact on revenues.  I understand what you're saying about supporting two versions at a time, but iOS 10 isn't even out yet until later this fall. It seems reasonable to maintain iOS 8 support for a few months at minimum.

iOS 10 will be released one week from today. Additionally, anyone running iOS 8 can upgrade to iOS 9 for free, which they should be doing anyway, due to the rather severe security issues patched in 9.3.5. Finally, you can continue using Alamofire with the upcoming 3.5.0 release which will support iOS 8 - 10 by use of Swift 2.3.

OK cool thought iOS 10 was coming out in October. Thanks for that update.
I have one question: For Alamofire 3.x with Swift 2.3, if I'm on Cocoapods, will this play nicely with my other pods (and my main project) that do use Swift 3? If so, I can't find any good documentation on whether I need to do anything explicit in my Podfile to support different versions of swift for my different Pods.  I currently have this at the end of my Podfile to avoid having to do Xcode > Edit > Convert > To Current Swift Syntax... every time I run pod install:
post_install do |installer|
    installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            config.build_settings['SWIFT_VERSION'] = '3.0'
        end
    end
end

I'm assuming this will need to change in some way to support some Swift 3 pods and other Swift 2.3 pods. Any guide or reference you can point us to @jshier @cnoon ? Thanks in advance.

No, targets must be all 2.3 or all 3, due to ABI incompatibility. I think you may be able to run a Swift 2.3 app with a Swift 3 watch app but not within the same app.

Just in case anyone is interested, I have forked and created a brach that adds back iOS 8 support. I had to remove support to URLSessionStream* for that tho.
https://github.com/Homely/Alamofire/tree/ios8

@vfn If you're going to maintain a fork with iOS 8 compatibility, you should also port over the various bug fixes and workarounds that were put in for bugs in for 8.1 and 8.2, as well as proper testing support for them as well.

@jshier I don't have any plans to actively maintain that fork. I created it to postpone the need to drop support to iOS 8 on the app I'm working at the moment, although I'll be doing that in the near future.
I shared it here so other devs can use it as well, without having to do the same work I had already done.
I think I'll update the README file on that branch to make it clear.

@cnoon Why can't we prefix the classes / methods using iOS9+ API with #available() check?
I believe https://github.com/Homely/Alamofire/commit/a0608c2db96c7d98d066f8fd72c5f19b89339fc2
only the streaming classes are affected? or Do we depend on iOS9+ API for basic functionality?

I'm going to lock this thread down. We've given many justifications as to why the deployment targets have been set to what they were in several different tickets. Please read through the justifications of all the tickets linked to this one if you're having issues.


fix: move v-on to div that has focus (#1270)

Related issue
Closes #1270 [BUG] Can't put @blur for validation purposes on SfSelect
Scope of work
Move v-on to the div that has focus.
Checklist

[x] No commented blocks of code left
[x] Run tests and docs
[x] Self code-reviewed

If applicable:

[x] I followed composition rules for my component
[x] I tested the component in most common device sizes (can be tested in Storybook from viewport addon in top menu)
[x] I accept Individual Contributor License Agreement

Thanks Eddie!


Cannot add files to drop in Group Edit

Tried to add files by dropping them into the area at the bottom of the page on http://<IP_ADDRESS>:8000/groups/update_group/ but nothing happened. I'm using Chrome.

It means that somehow javascript is not loading. I will look.

Well it looks like the same javascript loading issue. Also the change of the form structure was causing the issue.


Create different flavours for landing page to match different projects

orphaned issue?

@JamesSmartCell might become a thing again with new projects that use magic links


Fixed unnecessary gap in between sliders and products in mobile view (Default Theme) #4500

BUGS:
Link: https://github.com/bagisto/bagisto/issues/4500

done

done


Hotfix/action callback onclick type

Just onClick hint type - should be callable[] so as array ... PHPStan is helping here.
I hope that this second attempt will not show you any conflicts as in #901 :-D

thanks


Hope i can get help

java modules project => openjdk 15 + spring boot 2.4 + gradle 2.22.3
reference ==> https://docs.gradle.org/current/samples/sample_java_modules_multi_project.html
build task error
build.gradle
buildscript {
repositories {
maven{ url 'http://maven.aliyun.com/nexus/content/groups/public/'}
}
}
plugins {
id 'org.springframework.boot' version '2.4.0'
id 'io.spring.dependency-management' version '1.0.10.RELEASE'
id "org.beryx.jlink" version "2.22.3"
id 'java'
id 'application'
}
repositories {
maven { url 'http://maven.aliyun.com/nexus/content/groups/public/' }
jcenter()
}
java {
sourceCompatibility = JavaVersion.VERSION_15
targetCompatibility = JavaVersion.VERSION_15
modularity.inferModulePath = true
}
version = '0.0.1-SNAPSHOT'
group = 'com.demo'
tasks.compileJava {
// use the project's version or define one directly
options.javaModuleVersion = provider { project.version }
}
dependencies {
testImplementation 'junit:junit:4.13'
implementation 'com.google.guava:guava:29.0-jre'
implementation group: 'org.springframework.boot', name: 'spring-boot-starter'
//implementation group: 'org.springframework.boot', name: 'spring-boot-starter-security'
implementation (group: 'org.springframework.boot', name: 'spring-boot-starter-web'){
exclude(module: 'spring-boot-starter-tomcat')
}
implementation group: 'org.springframework.boot', name: 'spring-boot-starter-undertow', version: '2.4.0'
}
application {
mainClass = 'com.demo/com.demo.App'
}
src/main/java/module-info.java
module com.demo {
requires spring.boot;
requires spring.boot.autoconfigure;
opens com.demo to spring.core;
exports com.demo;
}
src/main/java/com/demo/App.class
package com.demo;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
@SpringBootApplication
public class App {
public static void main(String[] args) {
SpringApplication.run(App.class,args);
}
}
build task
Configure project :app
Using insecure protocols with repositories has been deprecated. This is scheduled to be removed in Gradle 7.0. Switch Maven repository 'maven(http://maven.aliyun.com/nexus/content/groups/public/)' to a secure protocol (like HTTPS) or allow insecure protocols. See https://docs.gradle.org/6.7.1/dsl/org.gradle.api.artifacts.repositories.UrlArtifactRepository.html#org.gradle.api.artifacts.repositories.UrlArtifactRepository:allowInsecureProtocol for more details.
Task :app:compileJava UP-TO-DATE
Task :app:processResources UP-TO-DATE
Task :app:classes UP-TO-DATE
Task :app:bootJarMainClassName UP-TO-DATE
Task :app:bootJar FAILED
4 actionable tasks: 1 executed, 3 up-to-date
FAILURE: Build failed with an exception.
What went wrong:
Execution failed for task ':app:bootJar'.
Failed to calculate the value of task ':app:bootJar' property 'mainClass'.
Main class name has not been configured and it could not be resolved
Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
Get more help at https://help.gradle.org
BUILD FAILED in 1s

Thank you for your interest in Gradle!
Please ask such a usage question on https://discuss.gradle.org or https://stackoverflow.com where to get answers by the community of Gradle users.
If, after investigation, it turns out to be a Gradle bug or missing feature, please file another issue describing the problem or use case and add a reproducer.

I would create a reproducer instead of pasting contents here.
Also the error message at the end indicates that the mainClass property is not seen by the Spring Boot plugin. I would use the -s command line flag to see the full stack trace. It might give you a better idea of what is happening.

Thank you for your interest in Gradle!
Please ask such a usage question on https://discuss.gradle.org or https://stackoverflow.com where to get answers by the community of Gradle users.
If, after investigation, it turns out to be a Gradle bug or missing feature, please file another issue describing the problem or use case and add a reproducer.
I would create a reproducer instead of pasting contents here.
Also the error message at the end indicates that the mainClass property is not seen by the Spring Boot plugin. I would use the -s command line flag to see the full stack trace. It might give you a better idea of what is happening.

thank you for your reply
Current problem;

Add module-info.java
Modify and refresh build.gradle;
compileJava task or build task;
Clesses cannot be generated correctly; (class files can occasionally appear)

reference https://docs.gradle.org/current/samples/sample_java_modules_multi_project.html
add  "java {modularity.inferModulePath = true }" to build.gradle

Duplicate of #
Current problem;
Add module-info.java
Modify and refresh build.gradle;
compileJava task or build task;
Clesses cannot be generated correctly; (class files can occasionally appear)
reference https://docs.gradle.org/current/samples/sample_java_modules_multi_project.html
add "java {modularity.inferModulePath = true }" to build.gradle

@ljacomet
Current problem;
Add module-info.java
Modify and refresh build.gradle;
compileJava task or build task;
Clesses cannot be generated correctly; (class files can occasionally appear)
reference https://docs.gradle.org/current/samples/sample_java_modules_multi_project.html
add "java {modularity.inferModulePath = true }" to build.gradle #

As mentioned above, please use other channels for asking question. Use this only for defects and feature requests.

This my configuration, it's work fine.
project(":springbootModuleA") {
    apply(plugin = "org.springframework.boot")
    tasks.withType<org.springframework.boot.gradle.tasks.bundling.BootJar>{
        enabled = true
    }
}

you shoule replace the kotlin script to groovy script.


Feature request : first order low pass filter

How would I implement a first order low pass filter using JDSP ? Is it possible yet ?
Also is it possible to apply a bilinear transform using JDSP ?

I open this in "discussion", maybe it's a better place  :)

Moved to discussion.
https://github.com/psambit9791/jdsp/discussions/78


windows issues

I want to ask, can you install it under Windows? How to generate an exe executable?

See: https://github.com/exaloop/codon/issues/69


Do more validation on webhook.Until

https://github.com/xmidt-org/webpa-common/blob/179b0f36052587995ad5927313fbec7b6e14be9c/webhook/webhook.go#L117
We should make sure this isn't in the past or too far in the future

This was done when https://github.com/xmidt-org/ancla/issues/14 was closed.


Initial dockerfile

For running:
Build with docker build .
Note image hash, start with docker run -d -p 8008:80 *hash*
Find running container hash with docker container ls
And stop with docker container stop *hash from ls*

Thanks man :D
Will try this out tonight.
Can you please integrate the docker information you provided into a section in README.md?


Typing error in generated client when response attribute use reserved keywords

Describe the bug
I am using this library to generate a Python client for Jira using their OpenAPI spec.
I get a strange bug at import time:
  File "D:\Repos\jira_generated\the-jira-cloud-platform-rest-api-client\the_jira_cloud_platform_rest_api_client\models\json_node.py", line 38, in JsonNode
    int_value: Union[Unset, int] = UNSET
  File "C:\Apps\Python38\lib\typing.py", line 261, in inner
    return func(*args, **kwds)
  File "C:\Apps\Python38\lib\typing.py", line 358, in __getitem__
    parameters = tuple(_type_check(p, msg) for p in parameters)
  File "C:\Apps\Python38\lib\typing.py", line 358, in <genexpr>
    parameters = tuple(_type_check(p, msg) for p in parameters)
  File "C:\Apps\Python38\lib\typing.py", line 149, in _type_check
    raise TypeError(f"{msg} Got {arg!r:.100}.")
TypeError: Union[arg, ...]: each arg must be a type. Got <the_jira_cloud_platform_rest_api_client.types.Unset object at 0x0000018CF4EEA070>.

After investigating for a while, I came to the conclusion that it's because the JsonNode object has an attribute named "int". The attribute shadows the built-in name int and causes type hinting to fail:
@attr.s(auto_attribs=True)
class JsonNode:
    """  """

    ... # Other attributes
    int: Union[Unset, bool] = UNSET
    ... # Other attributes
    int_value: Union[Unset, int] = UNSET  # Breaks here!
    ... # Other attributes

To Reproduce
Steps to reproduce the behavior:

Generate the client for Jira: openapi-python-client generate --url https://developer.atlassian.com/cloud/jira/platform/swagger-v3.v3.json
cd to the generated directory and open a Python shell
Import get_changelogs: from the_jira_cloud_platform_rest_api_client.api.issues import get_change_logs or anything else indirectly using JsonNode

Expected behavior
A different name may need to be used here like int_ or similar.
OpenAPI Spec File
https://developer.atlassian.com/cloud/jira/platform/swagger-v3.v3.json
Desktop (please complete the following information):

OS: Windows 10
Python Version: 3.8.8
openapi-python-client version: 0.8.0

Additional context
Thanks for the great tool!

Thanks for reporting! We currently have utilities for stripping out keywords as well as some custom reserved words in openapi_python_client/utils.py . This doesn't check for builtins just yet, my guess is we need to do something like:
import builtins

RESERVED_WORDS = set(dir(builtins))


Suggestion: month calendar with week numbers when clicked

It would be great if app would show a month calendar with week numbers when clicked on the taskbar. Also be able to go back and forth in the months

This is out of scope
If you need a more advanced calendar, you can probably check https://github.com/White-Tiger/T-Clock which is probably more what you're looking for.


Issue parsing tx

The transaction in the test case here will fail unless this code in NewTxFromStream is removed. Not sure if this is appropriate, but after removing it the test will pass.

Codecov Report

Merging #7 (79f8e3d) into master (7ff5471) will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   76.01%   76.20%   +0.18%
==========================================
  Files          16       16
  Lines         809      807       -2
==========================================
  Hits          615      615
+ Misses        135      134       -1
+ Partials       59       58       -1

Impacted Files
Coverage Δ

tx.go
76.25% <ø> (+0.94%)
:arrow_up:

varint.go
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff5471...79f8e3d. Read the comment docs.


Browser stuck when using input with icon

Example code:
<x-bladewind.input         name="fullname"         placeholder="John T. Doe"         prefix="user"         prefix_is_icon="true" />
Info in DevTools:

It appears that the script positionPrefix has created too many eventListeners on blur and focus.

I face similar problems as well

Ooops.. this is a no no.
Will address this as high priority.


Ionic CORS

What is the best way to implement PDF.js in a cordova app like Ionic since CORS is not supported?

Not tried myself, but it seems that you can get Cordova to request data from sources other than file: https://github.com/apache/cordova-plugin-whitelist

I don't think that any of the PDF.js developers/contributors are experts in that particular framework, so we'll not be able to provide much assistance here. It'd probably be better to ask for help from the Ionic community.
Closing, since this isn't an issue with PDF.js.


Latest Update Not Installing

i keep clicking the reinstall button but nothing changes and the version is still 2.0.9

Try uninstalling and installing...


hypergraph

I propose to move Spider to the hypergraph module, making it a subclass of compact.Box.
In a second step we will have to rethink the interaction between the two representations of hypergraph diagrams:

as monoidal diagrams with swaps and spiders
as cospans of labeled hypergraphs

Addressed in https://github.com/discopy/discopy/pull/129


crypto price change % should be *100

https://github.com/cs-discord-at-ucf/lion/blob/8a8edf08db25499673a0c534513292ab81896201/src/app/plugins/price.plugin.ts#L86
Is this not what it should be?

Perhaps the change is misleading because I’ve only ever seen it be very small. Idk what time frame it is about


Default setting for showMM

First of all: awesome little function, thanks!
Small bug: in the violinPlot documentation, it says the default option for showMM is 1: mean and median are shown as red crosses and green squares. In reality, showMM defaults to 7, which plots a compact black box plot with the median indicated as a target (bulls-eye). See line 257 :-)

Corrected it, thanks!


medDatabaseImporter::ensureUniqueSeriesName prevents duplicate series names even between unrelated studies or patients

When importing new data in medAbstractDatabaseImporter::importData, the function medDatabaseImporter::ensureUniqueSeriesName is called. In that function, if the series name of the new data already exists anywhere in the database, then a prefix is added to it. This constraint should have been limited to the same study.
This is an issue with medAbstractDatabaseImporter::importData, not medAbstractDatabaseImporter::importFile, and so will only appear when data is imported from within medInria (output of a toolbox for example). You can reproduce this by creating a new data inside medInria (from any toolbox). While it is still a temporary data, rename it to a series name that already exists in the DB (from a different patient). Now save the new data, and it will have a prefix added to it.

Tested, i can see at some cases. Between each test case, this is needed to remove each study used:
Import of multiple studies with "saved in the database" import

Import study A with series aa and bb
Import study B with series aa and bb
-> there is no suffixes to aa or bb. This behavior seems fine because it can happen to have data with the same name in separated studies and it's not a problem

Removal of a series

Import study A with series aa and bb -> remove aa

Then you have two cases:

Import study A with series aa and bb, or just aa -> the data is called "aa" -> no problems
Temporary import of aa -> the data us called "aa_1" even if there is only 1 "aa" data in the study :no_entry_sign:

Moving data from one study to an other

Import study A with series aa and bb
Import study C with a data
Move aa to C

Then you have two cases:

Import aa in A -> aa is called aa, no problems
Temporary Import aa in A -> save -> aa is called "aa_1" whereas the original aa has been moved to C :no_entry_sign:

Outputs from toolbox

Import A with aa and bb -> rename bb in "aa (painted)"
Draw a ROI on aa in PaintToolBox for instance and use the "Save" button in the tlbx -> a temporary "pact (painted)" data  is created
Save the temporary data -> it's called "pact (painted)_1" which is fine

Outputs with data in an other study

Import study A with series aa and bb
Import study B with series aa and bb
Rename aa in B as "aa (painted)"
Draw a ROI on aa from A in PaintToolBox for instance and use the "Save" button in the tlbx -> a temporary "pact (painted)" data  is created
Save the temporary data -> it's called "pact (painted)_1" which is NOT fine, since the false painted one is in B :no_entry_sign:

It could be a problem with the import or saving of temporary data.

Just to clarify, when I say it involves imports from inside medInria, I mean when data is imported through medDataManager::importData, which is what happens when you save temporary data, and so why it appears in all the tests where that is done.


Batch processing notes

You can keep multiple threads within the same window by using stringIO instead of the usual stdout, and then report everything combined. That means I can use Python and I don't have to resort to Powershell or Batch scripts like I did last time.

Since I've got multiple thread support working now (minus small stdout issue/s), I'll close this issue.


Add property params to Route

Unlike props, params are visible to all components. There should be a way to spefify custom params.

Done in 0.6.0


Applying issue repository template

This PR applies the "issue-only" template to the various files:

Approved Creative Commons LICENSE
Simplified README
Adds a boilerplate SUPPORT file, feel free to customize from here

@jeffwilcox,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot