Post-Production Fixes

Summary of changes:

All typos fixed.
All functions now have docstrings.
Imports are now in alphabetical order.
#TODO done: CheckExercise1 ~ Assert for error handling
Section 1 and 2 descriptions slightly changed for clarity
Discuss 2.4 - Solution added!
Exercise 3.3 - Solution added!
Bonus, Questions - Solution added!

Discuss 2.4 - Solution added!
Exercise 3.3 - Solution added!

When we add text-based explanation, the keyword should be # to_remove explanation.

3. Imports are now in alphabetical order.

I suggest keeping the imports simple, and use the length of the lines as a reference. So that it will be easier for the reader.


Missing trait impls with Diesel 1.4.8 and Postgres

I made an example repo to show the issue: benthillerkus/diesel-enum-trouble.

Please take a look at https://github.com/adwhit/diesel-derive-enum/issues/62, your fix is the same

Thank you


Improve binary classification's metrics by supporting customizing positive class

Previously, AutoMM always used label 1 as the positive label in computing the roc_auc and average_precision metrics in binary classification. However, 1, corresponding to class name label_encoder.classes_[1], may not always be the semantically positive class's label for specific tasks. For example, users provide string class names a and b, and wants a to be the semantically positive class. This PR makes it possible for users to customize their positive classes.
Related discussions:
https://github.com/scikit-learn/scikit-learn/issues/15303
https://github.com/scikit-learn/scikit-learn/pull/15405

Add a hyper-parameter positive_class in data config.
Add a util to infer positive_label from positive_class.
Add the positive_label choice in several functions related to computing binary classification's metrics.
Make it backward compatible.

Why not simply set the positive class to be 1 in the label transformation stage to internal representation?
Aka if 'Dog' is positive instead of 'Cat' 'Dog' = 1 0, and then tell roc_auc that 0 is positive, instead:
'Cat' 'Dog' = 0 1, don't need to tell roc_auc anything.
This is what is done in Tabular and works fine, no need to worry about specifying arguments to metrics.

Why not simply set the positive class to be 1 in the label transformation stage to internal representation?
Aka if 'Dog' is positive instead of 'Cat' 'Dog' = 1 0, and then tell roc_auc that 0 is positive, instead:
'Cat' 'Dog' = 0 1, don't need to tell roc_auc anything.
This is what is done in Tabular and works fine, no need to worry about specifying arguments to metrics, and automatically works for custom metrics from the user. I would strongly encourage the strategy I mention instead of what is done in this PR.
For more details on how to do this, please run a debugger on Tabular when specifying positive label explicitly to see how the code logic works. You can see the main logic here: https://github.com/awslabs/autogluon/blob/master/core/src/autogluon/core/data/label_cleaner.py#L175

Thanks for giving the suggestions!
After looking into the details of label cleaner, I think it may not be fully compatible with sklearn's LabelEncoder's APIs. Changing from the current LabelEncoder to label cleaner would result in other API changes in AutoMM, which can potentially bring new bugs. The current way is simpler and safer to handle this issue. In future, we can discuss the API alignment and maybe refactor core's code to make it easier to support other modules.

Job PR-1753-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1753/2/index.html

Job PR-1753-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1753/3/index.html

Job PR-1753-4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1753/4/index.html

Job PR-1753-5 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1753/5/index.html

We may add another test-case and it looks good overall. @Innixma I think relying on LabelEncoder is sufficient for now. Depending on LabelCleaner may cause overhead when we are going to later revise the label encoding mechanism (e.g, supporting other types of labels like text, image, bounding boxes, entities)


Email error: "Unexpected CFBundleExecutable Key"

Hi, I'm getting an error with the Info.plist when uploading my iOS app to App Store. The error comes via email right after the upload to App Store finishes.
The deployment target of the app is iOS 10.0 and I'm using the latest version of the SDK -> 3.0.0.
This are the errors:

Unexpected CFBundleExecutable Key - The bundle at '/Payload/APP_NAME.app/Target Support Files/Alamofire/Info.plist' does not contain a bundle executable. If this bundle intentionally does not contain an executable, consider removing the CFBundleExecutable key from its Info.plist and using a CFBundlePackageType of BNDL. If this bundle is part of a third-party framework, consider contacting the developer of the framework for an update to address this issue.
Unexpected CFBundleExecutable Key - The bundle at '/Payload/APP_NAME.app/Target Support Files/AlamofireImage/Info.plist' does not contain a bundle executable. If this bundle intentionally does not contain an executable, consider removing the CFBundleExecutable key from its Info.plist and using a CFBundlePackageType of BNDL. If this bundle is part of a third-party framework, consider contacting the developer of the framework for an update to address this issue.

If I do what is described in the error and erase the CFBundleExecutable Key, the app doesn't run in Xcode, and that's the only solution I have found in forums. I have also tried only changing the CFBundlePackageType to BNDL and setting Enable Bitcode to NO in my Project Settings, but it doesn't work.
I use CocoaPods to manage the library.
Any thoughts on what it can be?

Hi @mafer-bc,
I'd suggest you open a question on Stack Overflow and tag alamofire. We use our GitHub project for bug reports and feature requests.
Best of luck! 🍻

From our Contribution Guidelines
Asking Questions
We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.

Thanks, actually I found the solution:
The "Target Support Files" folder generated by CocoaPods was added to the "Copy Bundle Resources" in the "Build Phases" of the app, therefore all the Info.plist files of the libraries. Removing it solved the issue and I can submit the app at last!

Awesome!


Add additional config to skip violation check when the changes are less than a threshold

When there are fewer changes, very often we don't cover all the possible instructions for these changes in the test cases. And in such cases, we should have the option to avoid the violation error by defining the threshold for fewer changes (number of instructions, lines, branches, etc.)

Hi @praveen-kumar85
Workaround
I solved the issue you discribed in the next way:

Declare a property in pom.xml:

...
    <properties>
        <failOnDiffCoverageViolation>true</failOnDiffCoverageViolation> <!-- fail by default -->
    </properties>
...

Setup the plugin to use the property:

            <plugin>
                <groupId>com.github.surpsg</groupId>
                <artifactId>diff-coverage-maven-plugin</artifactId>
                <version>0.3.2</version>
                <configuration>
                    ...
                    <violations>
                        <failOnViolation>${failOnDiffCoverageViolation}</failOnViolation>  <!-- consume the property -->
                        <minCoverage>0.9</minCoverage>
                    </violations>
                </configuration>
                ...
            </plugin>

Then invoke the plugin with overriding property value

mvn install -DfailOnDiffCoverageViolation=false

CI usage
Github Actions
Suppose you are using Github Actions:

Create a custom label (let's say ignore-diff-coverage).
Update your github action:

      - name: Build with Maven
        run: mvnw install -DfailOnDiffCoverageViolation=${{ !contains(github.event.pull_request.labels.*.name, 'ignore-diff-coverage') }}

OR
# in this case failOnDiffCoverageViolation maven property is not used for passing to maven
# but it still would be handy for local run

      - name: Build with Maven
        continue-on-error: ${{ contains(github.event.pull_request.labels.*.name, 'ignore-diff-coverage') }}
        run: mvnw install

Apply the label to your pull request that requires skipping of diff coverage check

Another CIs
You can apply the similar approach to Gitlab or Jenkins piplines for sure. Also, I belive you can use the approach for CIs like Travis or Circle.
Real example

Pull request: https://github.com/SurpSG/diff-coverage-maven-plugin/pull/41 with label ignore-diff-coverage
Logs where we can see that diff coverage was suppressed but by default the plugin fails a build if coverage violated.

Summary
Advantuges:

You intetionally suppress diff coverage failure. Small change in code doesn't mean that the coverage check should be omitted. So you can decide whether ignore diff coverage check per particular PR.

Disadvantuges:

You must manually suppress diff coverage failure if required 🙃

Yeah, it depends on your strategy.

If the approach above doesn't suitable for you then await few days(up to 2 weeks) while I implement the feature you ask.

@SurpSG thanks a lot for the response. This is quite useful for manually adjusting the failure setting without having to touch the code. For our current use cases, it is good enough. But still, I think we should have a configurable parameter to skip the violations just the way how sonar does it.

@praveen-kumar85
Going to implement the feature you requested. Here example how it could be configured:
https://github.com/SurpSG/diff-coverage-maven-plugin/pull/50/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R62
I would be pleased to receive feedback


add pingdom script to each app

pingdom script to add monitoring

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against a3e8ffff33de2360ee9578d827e658b725e410df


Need an FAQ

As we see frequent questions, put those questions and answers somewhere.

Maybe also a quick reference for channel configuration, pattern matching, and the Javascript environment.

Maybe also a quick reference for channel configuration, pattern matching, and the Javascript environment.


add cog validation with rio-cogeo

Closes #37
It would be sweet to update rio-cogeo to return warnings and errors (ref https://github.com/cogeotiff/rio-cogeo/issues/142)

Codecov Report

Merging #63 into master will decrease coverage by 4.74%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   95.43%   90.68%   -4.75%
==========================================
  Files          21       21
  Lines         941      945       +4
==========================================
- Hits          898      857      -41
- Misses         43       88      +45

Impacted Files
Coverage Δ

titiler/endpoints/cog.py
95.16% <100.00%> (+0.10%)
:arrow_up:

titiler/endpoints/stac.py
67.29% <0.00%> (-28.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6c8132...14ce9d9. Read the comment docs.

done in #68


Review has_role: Should it not have a mapped id?

[Typedef]
id: has_role
name: has role

In simple

This doesn't seem to be used for anything in dpo, so not sure why it is there. It might be the same has_role used in FBcv, which has xref: RO:0000087.
@dosumis - can we delete this from dpo? or add xref: RO:0000087?


Update scores programmatically

I would like to update certain scores with JS after the bracket is initialized. Is this possible?

You can reinitialize the bracket with updated init data. There is no API to help updating the score though.


Able to enter characters, special characters and negative numbers under Age field in feedback screen [DESKTOP] [MOBILE]

Environment: https://staging.fightpandemics.work/
Steps to reproduce:

Click the feedback icon top right when not signed in or the feedback option under hamburger menu when signed in

Select options and enter values in screen 1 and screen 2 .

Under screen 3  What is your age ? question . I am able to enter  only  the below other than numbers strangely.

" e " character
" - "  hyphen
"+ " plus
" . "  period

In addition I am able to enter:
0, -1,-2  zero and negative numbers
Actual results:
Able to enter other than only numbers.
Expected Results:
Should be able to enter only numbers
Attached screenshots in the file below:
Feedback - AGE ISSUE.docx

Update : After submitting a value other than a number or just leaving the age field blank ONLY for the first time I am thrown the error saying " Could not submit feedback reason: body.age should be integer. While submitting a feedback for the second time or more on the same device if i follow the same procedure I am not getting the error message.

Hi @bittricky is this work in progress?

I am currently working on this issue.

Hey @pooji02, are you able to reproduce these? Could you please take a video? I am trying to either merge the PR for this issue or request changes.


Fix: Action not called when value cleared out

On the TypeAhead Date if not model is selected then display value should be undefined rather then an empty string '' to get the action to be called. Fixes #62

@jackmatt2 any idea when this will get merged? Thx

Yep, done.

Thanks can you please do a release.

2.3.3


[DataTable] on_selection_change called but checkbox is not updated neither selected attribute of DataRow

Description
I have created a DataTable with show_checkbox_column=True and all rows has on_select_changed set to a simple callback. When the user clicks the checkbox or the row, the callback is called, but the checkbox is not updated, also DataRow.selected value is not updated.

Code example to reproduce the issue:
        self.data = ft.DataTable(
            show_checkbox_column=True,
            columns=[col.build_header() for col in self.columns],
            rows=create_rows(),
        )

Rows are created like this:
    def build_row(self, row):
        row_control = ft.DataRow(cells=[col.build_cell(row) for col in self.columns])
        def toggle(x):
            print(x.control.data, x.control.selected)
        row_control.on_select_changed=toggle
        row_control.data = row
        return row_control

Describe the results you received:
toggle (on_select_changed) callback is called whenever the user clicks the row or the checkbox, but the DataRow.selected value never changes and the row does not reflect the state (obviously because no change)

Describe the results you expected:
the toggle callback should be called (as it is) but also the DataRow.selected must reflect selected state and the UI must reflect the state.

Additional information you deem important (e.g. issue happens only occasionally):
Flet version (pip show flet):
Name: flet
Version: 0.3.2

Operating system:

Linux Mint 21
Additional environment details:

You have to set the state yourself.
Implement this in your callback:
def select_changed(e):
    e.control.selected = not e.control.selected
    e.page.update()  # or page.update() directly

Close?


feat: 検索機能

Codecov Report

Merging #344 (70edfe2) into main (8e4b436) will increase coverage by 0.17%.
The diff coverage is 54.62%.

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   52.98%   53.15%   +0.17%
==========================================
  Files         121      128       +7
  Lines        1274     1411     +137
  Branches      208      240      +32
==========================================
+ Hits          675      750      +75
- Misses        588      650      +62
  Partials       11       11

Impacted Files
Coverage Δ

src/components/hooks/useEvents.ts
0.00% <0.00%> (ø)

src/components/hooks/useGenres.ts
0.00% <0.00%> (ø)

src/components/hooks/useLivers.ts
0.00% <0.00%> (ø)

src/components/ui/User/User.tsx
100.00% <ø> (ø)

src/pages/index.tsx
0.00% <0.00%> (ø)

src/pages/livers.tsx
0.00% <0.00%> (ø)

src/pages/tags.tsx
0.00% <0.00%> (ø)

...c/components/app/UpcomingEvents/UpcomingEvents.tsx
50.00% <20.00%> (ø)

src/components/app/Search/useFuzzySearch.ts
26.08% <26.08%> (ø)

src/components/ui/Timetable/useTimetable.ts
37.14% <26.66%> (+8.11%)
:arrow_up:

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e4b436...70edfe2. Read the comment docs.


Equivalent Java Log Parser

Hi Scott Hoover,
I've wrote a similar project on Java covering all features as you + some additional features like check-pointing, write-ahead-logging, persisting in memory and/or disk etc. I've already tested the project. Instead of pushing as a new project, I would like to contribute on this project.
Please let me know what you're thinking.
Regards,
Kaidul

@kaidul That'd be great! Now, as you can see, I haven't really done much here since the original work. This was largely an effort to make a public example of a webinar I gave while at Looker. With that said, if this is something you want to contribute to, I'm more than happy to maintain this project.

@githoov I am very glad for having your approval :) I am going to fork your project and will send you the pull request.


Nexus 5 Ignoring ckMethod

In my own testing I noticed that my Nexus 5 was ignoring my ckMethod setting and only using 'still'. I downloaded the CameraKit demo app and confirmed it also ignores the 'standard' setting there, so app pictures are taken in 1080p as opposed to 8mp. Can anyone else confirm this issue? This is not occurring on my s8.

For me its ignoring the ckmethod still..its always using the standard method..


ISPN-12048 Improve Cross-Site statistics

Includes formatting fixes for ISPN-12478
https://issues.redhat.com/browse/ISPN-12048

@oraNod can you review the changes to JMX MBeans for Cross-Site Replication and to the attributes/operation description?

@oraNod updated! thank you!


Reduce confusion for "magic" binding expressions

We've had several people get confused by these (example 1, 2, 3). I think the main problem is that these are hard-coded string values that basically perform magic under the covers and the documentation is hard-to-find. Would be nice if we could add some Intellisense or helper methods to make it easier to understand.
Example binding expression:
const blobOutput = output.storageBlob({
  connection: "AzureWebJobsStorage",
  path: "helloworld/{DateTime:MM-dd-yyyy H:mm:ss}.json",
});

Example route parameter:
app.http('httpTrigger1', {
    methods: ['GET', 'POST'],
    authLevel: 'anonymous',
    route: 'httpTrigger1/{id}',
    handler: httpTrigger1
});

I think it would be also good to note in docs that is not posible to set any of those values on runtime, you can only use binding parameters declared in the input, or binding expressions.


ponyc: 0.22.3 -> 0.22.5

Motivation for this change
https://github.com/ponylang/ponyc/issues/2746
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ponyc

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: ponyc
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: ponyc
Partial log (click to expand)
Verifying
Writing ./examples.o
Linking ./examples1
All examples compile!
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fg222bh4nw2lw1ac12hwxzl116lkpia5-ponyc-0.22.5
shrinking /nix/store/fg222bh4nw2lw1ac12hwxzl116lkpia5-ponyc-0.22.5/lib/pony/0.22.5/bin/ponyc
patching script interpreter paths in /nix/store/fg222bh4nw2lw1ac12hwxzl116lkpia5-ponyc-0.22.5
checking for references to /build in /nix/store/fg222bh4nw2lw1ac12hwxzl116lkpia5-ponyc-0.22.5...

Success on x86_64-darwin (full log)
Attempted: ponyc
Partial log (click to expand)
copying path '/nix/store/yyak5sjv68n9vdgnkd2cb5djk1l9sqj5-cctools-binutils-darwin' from 'https://cache.nixos.org'...
copying path '/nix/store/h8k0imphghk6im88jyznwgzbhpwmaixk-libressl-2.7.3' from 'https://cache.nixos.org'...
copying path '/nix/store/bslr59a9r6ygzmkjnap06gqfn751p37g-llvm-3.9.1-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/q6b0jyp25h40srv59ckank52ax974nd9-pcre2-10.23' from 'https://cache.nixos.org'...
copying path '/nix/store/6zknvic2wi25qg7ha39mm8wb3x0ppwn9-cctools-binutils-darwin-wrapper' from 'https://cache.nixos.org'...
copying path '/nix/store/bvrz6gfvmgb620knx2d9nr8kvz4l21i7-llvm-5.0.2' from 'https://cache.nixos.org'...
copying path '/nix/store/cjqwnzxl7wzgrf51ai6sr3mv82jk1gz9-clang-5.0.2' from 'https://cache.nixos.org'...
copying path '/nix/store/1raxjnnz5fzjl216r6w9bffprqqxw3jr-clang-wrapper-5.0.2' from 'https://cache.nixos.org'...
copying path '/nix/store/qhc41fnlh9dnm4iibkfg947n6d7qlhbc-ponyc-0.22.5' from 'https://cache.nixos.org'...
/nix/store/qhc41fnlh9dnm4iibkfg947n6d7qlhbc-ponyc-0.22.5


Feature/truststore

What changes were proposed in this pull request?
Generated structure to deal with  TrustStores

LGTM


Files are removed when app is (force) closed

I have the issue, that recently downloaded files are getting "removed" when i kick the app. (remove the app from recents)
so i start downloading some files. the files are present in their destination directory. then i kick the app and the files are gone in the directory. BUT i have the *.temp version in the destination directory.
i'm using process.non-separate=true, could it affect this?

nope. process.non-separate=true is only used for when you want FileDownloader service running in the main process.

I don't understand very clear about your point, If you start downloading some files and files all in the downloading state, they must be in *.temp version, it doesn't care about whether the downloading process is alive. That is it.

Maybe i was not clear enough. Files are downloaded correctly (download is
complete). If i kick the app AFTER the download finished, i end up with
.temp files for the last 5-6 Files i downloaded.
Jacksgong<EMAIL_ADDRESS>schrieb am Fr., 23. Sep. 2016, 17:05:

nope. process.non-separate=true is only used for when you want
FileDownloader service running in the main process.
I don't understand very clear about your point, If you start downloading
some files and files all in the downloading state, they must be in *.temp
version, it doesn't care about whether the downloading process is alive.
That is it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lingochamp/FileDownloader/issues/327#issuecomment-249217444,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEV5Ytd7W8kLvZFcAgLi4QP4krH8Kadtks5qs-qqgaJpZM4KEu38
.

If all downloaded correctly files transmit from "completed" version to *.temp version when you kick the app, that is a bug, but I check this in the demo project, I can't meet it:

Enter the "Single task test" Activity
Start download "Normal Task", and wait for it finish downloading. After it complete, it settle download in the folder /sdcard/Android/data/com.liulishuo.filedownloader.demo/cache, and it's file name is "tmp2" .
Start the first one in the "Single task test", and when it is in downloading state, I kick the app.
Finally, I find it is expected, there is the "tmp2" file still in the /sdcard/Android/data/com.liulishuo.filedownloader.demo/cache folder, and also the "LLS-v4.0-595-20160908-143200.apk.temp" in the /sdcard/Android/data/com.liulishuo.filedownloader.demo/cache/tmpdir1 folder.

After complete download "Normal Task" in "Single task test":

After kick the app when "Normal Task" had already completed downloaded, and the first one task in "Single task test" page has been started, and in downloading state now:

it doesn't apply for all files. i downloaded 30 files in parallel and 5-6 (i guess the most recent downloaded) of those have this issue.
i checked the download directory and all files were properly stored. (so no *.temp files). but if i kick the app then, these recent downloads get somehow "renamed" to their *.temp version
i will try to setup a demo project

Okey, thanks. Wait for your testing result in the demo project.
And welcome PR, if you find any problem and fix it.

i'm sorry. it seems that it wasn't related to the library. cannot reproduce it any longer.
therefore no issue here.

Okey.


Multiple certificates with docker-flow-proxy

I have *.company.com ssl certificate, which I can use to serve all xxx.company.com sites. But I also have some sites which do not go under this.
in one certificate from digicert
ex1.company.com service1
ex2.company.com service2
Then I have another certificate from Comodo
example.com service3
Can I accomplish this with docker secrets? When I use servicedomain, I get error from second certificate and proxy stops working. I have tested, that from within container the certificate works, but not trough proxy.
I have Docker 17.06.0-ce, swarm, and I am using stack mode and docker-compose files.
I have tried to read documentation and google problem, but have to been able to resove this. Aso fast test with letsencrypt certificates did not worked, maybe because I have not yet transferred dns yet. The old version of service is still in production use.

Can you post your commands and stacks? That would help me replicate the problem.
Also, it would be useful to get configs from one of the proxy replicas. Can you please enter into a node whether one of the proxy replicas is running, find its ID, and execute...
docker container exec -it [PROXY_CONTAINER_ID] cat /cfg/haproxy.cfg

docker container exec -it [PROXY_CONTAINER_ID] cat /cfg/crt-list.txt

Since the proxy stops working when I'll try to install second certificate I do not have now installed. My proxy stack docker-compose.yml is basically just original what you have done.
version: "3.1"
services:
proxy:
image: vfarcic/docker-flow-proxy
ports:
- 80:80
- 443:443
networks:
- proxy
environment:
- LISTENER_ADDRESS=swarm-listener
- MODE=swarm
- TIMEOUT_CLIENT=90s
- TIMEOUT_SERVER=90s
- TIMEOUT_QUEUE=120s
secrets:
- cert-star_tek_fi.pem
- cert-tukoke_fi.pem
deploy:
  replicas: 1
  placement:
    constraints: [node.hostname == dca.tek.fi]

swarm-listener:
image: vfarcic/docker-flow-swarm-listener
networks:
- proxy
volumes:
- /var/run/docker.sock:/var/run/docker.sock
environment:
- DF_NOTIFY_CREATE_SERVICE_URL=http://proxy:8080/v1/docker-flow-proxy/reconfigure
- DF_NOTIFY_REMOVE_SERVICE_URL=http://proxy:8080/v1/docker-flow-proxy/remove
deploy:
placement:
constraints: [node.hostname == dca.tek.fi]
networks:
proxy:
external: true
secrets:
cert-star_tek_fi.pem:
file: /etc/docker/certs.d/star_tek_fi.pem
cert-tukoke_fi.pem:
file: /etc/docker/certs.d/tukoke_fi.pem
All sites are basically based to https://hub.docker.com/r/richarvey/nginx-php-fpm/ almost without modifications.
docker-compose.yml of one site is as follows:
version: '3.3'
services:
web:
image: dp7yhteiso
volumes:
- type: volume
source: yhteiso-webroot
target: /var/www/html
volume:
nocopy: false
networks:
- proxy
- mariadb
environment:
WEBROOT: /var/www/html
ERRORS: 1
RUN_SCRIPTS: 1
deploy:
replicas: 1
labels:
- com.df.notify=true
- com.df.distribute=true
- com.df.serviceDomain=yhteiso.tek.fi
- com.df.port=8003
- com.df.httpsOnly=true
networks:
proxy:
external: true
mariadb:
external: true
volumes:
yhteiso-webroot:
external: true
All sites basically same. I also tried the second certificate in my local system with these settings:
labels:
- com.df.notify=true
- com.df.distribute=true
- com.df.pathType="req_ssl_sni -i -m reg"
- com.df.servicePath="www.tukoke.fi"
- com.df.srcPort=443
- com.df.reqMode=sni
- com.df.port=443
Sending distribution request to http://<IP_ADDRESS>:8080/v1/docker-flow-proxy/reconfigure?distribute=false&pathType="req_ssl_sni+-i+-m+reg"&port=443&replicas=1&reqMode=sni&serviceName=test_web&servicePath="www.tukoke.fi"&srcPort=443
Result:
proxy_proxy.1.xrwmyssv4x7w@moby    | 2017/10/27 13:39:52 Creating configuration for the service test_web
proxy_proxy.1.xrwmyssv4x7w@moby    | 2017/10/27 13:39:52 Reloading the proxy
proxy_proxy.1.xrwmyssv4x7w@moby    | 2017/10/27 13:39:52 Validating configuration
proxy_proxy.1.xrwmyssv4x7w@moby    | 2017/10/27 13:39:52 Config validation failed. Will try again...
And error repeats maybe 20 times. I have not found any more exact error msg.

Can you try the same setup with only the second certificate? Something like:
...
    secrets:
#      - cert-star_tek_fi.pem
      - cert-tukoke_fi.pem
...

If that fails, the problem might be in a certificate itself. If it doesn't, it means that DFP has a problem with two certs and is a bug I should fix.

In local environment I have original docker-flow-proxy running. I did:
Artos-MacBook-Pro:tukoke ale$ docker secret create cert-tukoke.fi.pem tukoke.fi.pem
9wxhnko2137wnn9tfdhmukar3
Artos-MacBook-Pro:tukoke ale$ docker service update --secret-add cert-tukoke.fi.pem proxy_proxy
proxy_proxy
Service docker compose is:
version: '3.3'
services:
web:
image: richarvey/nginx-php-fpm
networks:
- proxy
environment:
ERRORS: 1
RUN_SCRIPTS: 1
deploy:
  replicas: 1
  labels:
    - com.df.notify=true
    - com.df.distribute=true
    - com.df.serviceDomain=www.tukoke.fi
    - com.df.port=80
    - com.df.httpsOnly=true

networks:
proxy:
external: true
And it works with only one certificate.

Proxy stops working if I add second certificate:
Artos-MacBook-Pro:tukoke ale$ docker secret create cert-star.tek.fi.pem star.tek.fi.pem
7ivqkgfooqac866x004jjoo1j
Artos-MacBook-Pro:tukoke ale$ docker service update --secret-add cert-star.tek.fi.pem proxy_proxy
proxy_proxy
Should I somehow tell, which certificate is to be used with what service?

Are those certificates for different domains? If they are, the proxy should be able to distinguish them without any additional setting. From the output I can see that the first certificate (the one that works) is tied to the www.tukoke.fi domain. It'll work only for www (not without). Can you send the info about the second cert? Did you check whether the second works when the first one is removed? If it doesn't, we'll know that the problem is with the certificate.
Can you please execute the commands I wrote previously and send the output?
docker container exec -it [PROXY_CONTAINER_ID] cat /cfg/haproxy.cfg

docker container exec -it [PROXY_CONTAINER_ID] cat /cfg/crt-list.txt

Both certs work If they are only ones. Other domain is TEK.fihttp://TEK.fi, other tukoke.fihttp://tukoke.fi. And it offered TEK.fihttp://TEK.fi certificate for tukoke.fihttp://tukoke.fi, when I had only that.
Arto.Leskinen<EMAIL_ADDRESS>On 1 Nov 2017, at 21.00, Viktor Farcic <notifications<EMAIL_ADDRESS>wrote:
Are those certificates for different domains? If they are, the proxy should be able to distinguish them without any additional setting. From the output I can see that the first certificate (the one that works) is tied to the www.tukoke.fihttp://www.tukoke.fi domain. It'll work only for www (not without). Can you send the info about the second cert? Did you check whether the second works when the first one is removed? If it doesn't, we'll know that the problem is with the certificate.
Can you please execute the commands I wrote previously and send the output?
docker container exec -it [PROXY_CONTAINER_ID] cat /cfg/haproxy.cfg
docker container exec -it [PROXY_CONTAINER_ID] cat /cfg/crt-list.txt
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/vfarcic/docker-flow-proxy/issues/352#issuecomment-341206023, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AG0atuwgoXwP7YqueUnz22m4GwhnD5Atks5syL_MgaJpZM4QJLZS.

Can the problem be because one cert is wild char *.tek.fihttp://tek.fi?
Arto.Leskinen<EMAIL_ADDRESS>On 1 Nov 2017, at 21.00, Viktor Farcic <notifications<EMAIL_ADDRESS>wrote:
Are those certificates for different domains? If they are, the proxy should be able to distinguish them without any additional setting. From the output I can see that the first certificate (the one that works) is tied to the www.tukoke.fihttp://www.tukoke.fi domain. It'll work only for www (not without). Can you send the info about the second cert? Did you check whether the second works when the first one is removed? If it doesn't, we'll know that the problem is with the certificate.
Can you please execute the commands I wrote previously and send the output?
docker container exec -it [PROXY_CONTAINER_ID] cat /cfg/haproxy.cfg
docker container exec -it [PROXY_CONTAINER_ID] cat /cfg/crt-list.txt
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/vfarcic/docker-flow-proxy/issues/352#issuecomment-341206023, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AG0atuwgoXwP7YqueUnz22m4GwhnD5Atks5syL_MgaJpZM4QJLZS.

Artos-MacBook-Pro:npf ale$ ./swarm_sh proxy_proxy 1
Executing in moby proxy_proxy.1.lrvtw2igwhs065geozy8vf97d
/ # cat /cfg/haproxy.cfg
global
pidfile /var/run/haproxy.pid
tune.ssl.default-dh-param 2048
# disable sslv3, prefer modern ciphers
ssl-default-bind-options no-sslv3
ssl-default-bind-ciphers ECDH+AESGCM:DH+AESGCM:ECDH+AES256:DH+AES256:ECDH+AES128:DH+AES:RSA+AESGCM:RSA+AES:!aNULL:!MD5:!DSS

ssl-default-server-options no-sslv3
ssl-default-server-ciphers ECDH+AESGCM:DH+AESGCM:ECDH+AES256:DH+AES256:ECDH+AES128:DH+AES:RSA+AESGCM:RSA+AES:!aNULL:!MD5:!DSS

resolvers docker
nameserver dns <IP_ADDRESS>:53
defaults
mode    http
balance roundrobin
option  dontlognull
option  dontlog-normal
option  http-keep-alive
option  forwardfor
option  redispatch

errorfile 400 /errorfiles/400.http
errorfile 403 /errorfiles/403.http
errorfile 405 /errorfiles/405.http
errorfile 408 /errorfiles/408.http
errorfile 429 /errorfiles/429.http
errorfile 500 /errorfiles/500.http
errorfile 502 /errorfiles/502.http
errorfile 503 /errorfiles/503.http
errorfile 504 /errorfiles/504.http

maxconn 5000
timeout connect 5s
timeout client  20s
timeout server  20s
timeout queue   30s
timeout tunnel  3600s
timeout http-request 5s
timeout http-keep-alive 15s

frontend services
bind *:80
bind *:443 ssl crt-list /cfg/crt-list.txt
mode http
acl url_test_web80_0 path_beg /
acl domain_test_web80_0 hdr(host) -i www.tukoke.fi
use_backend test_web-be80_0 if url_test_web80_0 domain_test_web80_0

backend test_web-be80_0
mode http
http-request add-header X-Forwarded-Proto https if { ssl_fc }
http-request redirect scheme https if !{ ssl_fc }
server test_web test_web:80/ #
/ # cat /cfg/crt-list.txt
/run/secrets/cert-star.tek.fi.pem
/run/secrets/cert-tukoke.fi.pem/ #
/ #

Can you combine those two PEM files into one and use only one secret?
The PEM would would something like:
-----BEGIN CERTIFICATE-----
CERTIFICATE_CONTENT!!!
-----END CERTIFICATE-----
-----BEGIN CERTIFICATE-----
CERTIFICATE_CONTENT!!!
-----END CERTIFICATE-----

If that works we'll know that there's a problem with multiple certs (and I'll fix it). If it doesn't, we'll know that the problem is in your certs.

If I combine certs, it does not give any errors, but offers always first cert. I have in other proxy star_tek_fi first and it offers always that. On another proxy I have tukoe.fi cert first and it offers that always. Is it ok to have two key files also there?

Having two key files is in one is very common. I have it in my personal cluster and quite a few customers. On the other hand, that's not functionally different than having separate files (one for each cert). What I wanted to confirm is that the problem is not in the way proxy is configured to read multiple files with certs. I am convinced now that the problem is with certs themselves, more likely with the other one. I saw that one of the certs is tied to the domain www.tukoke.fi. That one will work only with that exact domain (NOT tukoke.fi, NOR something.tukoke.fi). Can you share the screenshot with the other cert? Judging from your info, the other cert should work with tek.fi and one level of subdomains (e.g., something.tek.fi).
Judging by the proxy logs (Config validation failed. Will try again...), those certs are in conflict somehow. The problem (from the proxy side) is that it does not output what that problem is. I corrected that. Can you update the proxy to the release vfarcic/docker-flow-proxy:17.11.03-53? Once you do and repeat the steps, you'll see Config validation failed. Will try again... 20 times (it repeats it in case the error is temporary). After that, it will output the error message passed to DFP by HAProxy. It will say Config validation failed followed with HAProxy error and the offending configuration. Can you post that?

star_tek_fi is wildchar cert, valid for anything ending tek.fi. Como cert is normal, but it is adverticed to work both www and non www on one domain. Many cheaper cert providers have these double certs. See: https://ssl.comodo.com/comodo-ssl-certificate.php You can get free 90 day cert from comodo if you want to test. I'll check if tukoke.fi is the problem.

On local test environment where I have installed in same file both certs and tehir keys, firt cert which in here is tukke.fi works, second cert star.tek.fi does not work. No errors on proxy log. yhteiso.tek.fi is offered tukoke.fi cert, which is first cert.
proxy_proxy.1.5zt410iwsbvs@moby    | 2017/11/06 08:21:14 Starting "Docker Flow: Proxy"
proxy_proxy.1.5zt410iwsbvs@moby    | 2017/11/06 08:21:19 Got configuration from http://swarm-listener:8080.
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:13 Sending distribution request to http://<IP_ADDRESS>:8080/v1/docker-flow-proxy/reconfigure?distribute=false&httpsOnly=true&port=80&replicas=1&serviceDomain=www.tukoke.fi%2Ctukoke.fi&serviceName=test2_web
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:13 Creating configuration for the service test2_web
proxy_proxy.1.5zt410iwsbvs@moby    | 2017/11/06 08:21:19 Creating configuration for the service test2_web
proxy_proxy.1.5zt410iwsbvs@moby    | 2017/11/06 08:21:19 Creating configuration for the service test3_web
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:13 Sending distribution request to http://<IP_ADDRESS>:8080/v1/docker-flow-proxy/reconfigure?distribute=false&httpsOnly=true&port=8000&replicas=1&serviceDomain=yhteiso.tek.fi&serviceName=test3_web
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:13 Reloading the proxy
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:13 Validating configuration
proxy_proxy.1.5zt410iwsbvs@moby    | 2017/11/06 08:21:19 Reloading the proxy
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:13 Proxy config was reloaded
proxy_proxy.1.5zt410iwsbvs@moby    | 2017/11/06 08:21:19 Validating configuration
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:13 Creating configuration for the service test3_web
proxy_proxy.1.5zt410iwsbvs@moby    | 2017/11/06 08:21:19 Proxy config was reloaded
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:13 Reloading the proxy
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:13 Validating configuration
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:13 Proxy config was reloaded
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:16 Got configuration from http://swarm-listener:8080.
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:16 Creating configuration for the service test2_web
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:16 Creating configuration for the service test3_web
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:16 Reloading the proxy
proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:16 Validating configuration

proxy_proxy.1.rgpww590ad2h@moby    | 2017/11/06 08:20:16 Proxy config was reloaded

I'm not sure what the problem is. I'm inclined to say that the problem is not with DFP/HAProxy since no one else complained about multiple certs. I use it myself in quite a few clusters with a problem. Judging by the screenshot, the problem is in the certificate itself. It's as if tukoke.fi is used instead yhteiso.tek.fi. HAProxy always serves a certificate related to the domain of the request so either the domain information is somehow lost before entering DFP or there's something wrong with tukoke.fi.
I'm not sure how to reproduce the issue myself. One option would be to try it out with your certificates but I guess you wouldn't want to send them to me. The alternative is to try to construct HAProxy config yourself with those certs. Please let me know if you see a third alternative to reproduce the issue.

Is the problem our wildchar cert? Does anyone has tried multiple certs when one of them is wildchar cert? Since the cert has multiple names, maybe haproxy can not check the domain. I can try if letsencrypt helps with this one. Is it possible manually tell haproxy what cert it should use for tukoke.fi?

I haven't tried multiple certs with wildcard myself (only multiple certs with specific domains).
The idea to try it with LetsEncrypt is good. If it works with LE, we'll know that the problem is with the certs you're currently using.
I did some digging in HAProxy and, as far as I understood, it does not have an option to specify a domain for a cert. It reads that information from certs themselves.

There was no activity (responses) on this issue for over a month. Can you please let me know whether it can be closed.


Select statement not showing whitespace

Describe the bug
Select statement doesn't include leading blanks in character field, for example if the field has value '        X' then the select and generated insert statement becomes 'X'-
To Reproduce
Insert leading blanks into a character field, then do select from DB2 for i Extension.
Expected behavior
Would expect the return statement to include leading blanks and be '        X'
Screenshots
VSC:
select

insert

STRSQL:

Environment

OS:  Windows 10
Extension Version 1.7.0

Other
Thought it might be a setting for the job but couldn't find it so apologies if I'm just blind

Similar to #256.
@ThePrez is there something in the Mapepire that is trimming spaces from string fields?

I think there are two reasons why we don't see those whitespaces:
1/ It looks like Mapepire does trim white spaces, I suspect it is the .trim() on the cellDataForResponse = cellData.toString().trim(); line in BlockRetrievableRequest.java.
Trimming trailing whitespaces might make sense for fixed length fields since they convey no information. I think they should be kept for varying length fields (even if SQL ignores them for comparisons, they are technically different values).
Leading whitespaces should never be trimmed.
2/ Even if the whitespaces were not trimmed by Mapepire, the result is displayed in a div in a td where the default html behavior will be to trim leading whitespaces (and collapse multiple whitespaces for that matter). This can be solved here with css (white-space: pre;).


MRG, ENH: MNI Fiducials in mne coreg

Taking over parts of #6693.
Todo:

[x] Add test
[x] Avoid np.matrix
[x] Incorporate into mne coreg
[x] Update testing dataset to include fiducial
[x] Use MNE standards for transforms

On master:
mne coreg -d ~/mne_data/MNE-sample-data/subjects -s sample -f ~/mne_data/MNE-sample-data/MEG/sample/sample_audvis_raw.fif

Produces:

On this PR:

cc @jhouck

@jhouck FYI it looks like the transform calculations you did are equivalent to those in _read_talxfm:
https://github.com/mne-tools/mne-python/blob/master/mne/source_space.py#L1273-L1336
Except that here we just need to invert it to get mni_mri_t instead of the typical mri_mni_t.

whats_new.rst updated and commits squashed to two for rebase+merge w/proper changes/blame credit

This looks great!  And you managed it slightly faster than I could have.  ;)

Excellent! This is exactly what I was asking for also in the previous PR :) Now it's clear

Okay a couple of +1's, let's merge and keep going on this stuff

I think fsaverage doesn't ship with the talairach_with_skull.lta -- at least, none of mine has it -- but worth a try

These are fairly easily to manually do using tkmedit IIRC, too

This PR keeps fiducials as digpoints. What wre yor thoughts in having a fiducial object? we keep finding it in digitization stuff everywhere aswell.
Any thoughts?

let's avoid objects when we can


may be a fd leak?

When porting https://github.com/kata-containers/agent/pull/371/files to 2.0, I noticed that the epoll fd is not closed.
cc @lifupan

This issue is being automatically closed as Kata Containers 1.x has now reached EOL (End of Life). This means it is no longer being maintained.

Important:
All users should switch to the latest Kata Containers 2.x release to ensure they are using a maintained release that contains the latest security fixes, performance improvements and new features.

This decision was discussed by the @kata-containers/architecture-committee and has been announced via the Kata Containers mailing list:

http://lists.katacontainers.io/pipermail/kata-dev/2020-November/001601.html
http://lists.katacontainers.io/pipermail/kata-dev/2021-April/001843.html
http://lists.katacontainers.io/pipermail/kata-dev/2021-May/001896.html

If you believe this issue still applies to Kata Containers 2.x, please open an issue against the Kata Containers 2.x repository, pointing to this one, providing details to allow us to migrate it.


Use K8s Garbage Collection

Set owner references on all resources created for TfJob.

Garbage collection was inherited from the etcd-operator which we copied.
Prior to K8s 1.8 I don't think K8s fully supported Garbage Collection for CRD.
But with K8s 1.8 GC should be fully supported so we can rely on K8s GC rather
than implementing our own.

I did a oneoff test to verify K8s GC works.
I created a TfJob and ensured all the resources were created.
Then I deleted the TfJob controller operator.
I then deleted the TfJob and verified that all resources (Job controllers, services, etc...) were garbage collected. Since the TfJob operator was no longer running this had to be due to K8s GC.
We should probably turn this into an E2E test.


Add option to not load Google visualization library

The Google visualization library as loaded by Keen is pretty big - 259 kb in transfer size. I use the keen client for loading data, but I don't need the visualization library. Is there any way to prevent Keen from loading the library?

@JamiesonWarner next on my todo list :) This definitely needs to happen. In the meantime, perhaps the tracking-only build of the library would be a better option.. it's gzipped at just under 10kb:
https://d26b395fwzu5fz.cloudfront.net/3.2.0/keen-tracker.min.js

Cool! You rock @dustinlarimer!

:+1: +1 Looking forward to this, using another library for visualizations.

:+1: for not loading the library at all unless you have the read key supplied

:+1: Any updates on this?
I'll submit a PR if no one else if working on it

@andrehjr if you would like to tackle this, that would be most awesome! maybe worth discussing implementation ideas first?
/cc @aroc

@dustinlarimer I just took quick look around the code, the simplest idea would be to not require any drawing related stuff when a given option is passed to Keen-js.
In my case, I just need to use the Keen.Query and nothing related to building charts :)

@andrehjr clean and simple, i dig it.. perhaps something like Keen.someOption that's true by default but can be overridden?

I was thinking the same @dustinlarimer. I'll wrap up some code, and I'll let you know

After some digging, I'm not sure my idea with Keen.someOption would work out as is.
I think that the best solution would be to pass along the loader which modules to load (query/tracker/charts), which is something like Google visualization library does.
So, the easiest thing to do, would be to write something like the keen-tracker.js(i.e: keen-query.js), which just loads the modules required for that.
What do you guys think?

@andrehjr I would be open to a keen-query.js build. It would also be possible to do for yourself by copying and mod'ing your own /src/keen-query.js entry point and including it in a gulp task. However, I agree it would have wider value to everyone, if it were provided.

Makes sense @dustinlarimer!
I'm already using a keen-query.js I built on my fork. Without problems so far.. going to use it on production on the next few days.
If you're willing to accept that as PR, I'd happy to open one.
https://github.com/andrehjr/keen-js/blob/add_keen_query_js/src/keen-query.js

+1  We ran into an issue earlier today with this. We're using Keen for tracking while independently using Google's visualization API to provide some charting for our users. We were loading in corechart and geochart, which was effectively being overwritten by keen's call to the API, causing all sorts of havoc (and crippling our charts). Using keen-tracking for tracking-only works for us for the moment.
Side note, I noticed Keen is using v1.1 for google charts-- 1.1 is reserved for RC's/dev, and isn't guaranteed to be stable.

@andrehjr sounds good to me – fire away!
A few notes to run with:

setGlobalProperties can probably be removed
Async loading (w/ our loading script) can be omitted. That functionality is intended for tracking, so that our lib can be loaded from the CDN w/out interrupting normal page/script loading. Not sure that need still applies in the query/viz-only use case. This means the domready dep can also be removed, and L44-51 could be replaced with a single Keen.emit("ready"); line.

Does that all sound reasonable? Lemme know if/how I can help!

Thanks for your comments @dustinlarimer ! I just opened a PR :)

Looking forward to this as well. Are the failing tests blocking the pull request?

@psirenny yes, and general short-handedness..

I'll get this merged and released w/ v3.2.5 next week!

Looks like the tests were failing saucelabs because certain device/platform configs won't initialize. I suspect a simple config change on SL's side might be to blame. I'll get this straightened out so we can move forward. Sorry for the delay, and thank you all for being so patient!
ERROR [launcher.sauce]: Can not start iPhone 8.1 (OS X 10.9)
  Failed to start Sauce Connect:
  Could not start Sauce Connect. Exit code 1 signal: null
ERROR [launcher.sauce]: Can not start android 4.4 (Linux)
  Failed to start Sauce Connect:
  Could not start Sauce Connect. Exit code 1 signal: null
ERROR [launcher.sauce]: Can not start internet explorer 11 (Windows 8.1)
  Failed to start Sauce Connect:
  Could not start Sauce Connect. Exit code 1 signal: null
ERROR [launcher.sauce]: Can not start internet explorer 10 (Windows 8)
  Failed to start Sauce Connect:
  Could not start Sauce Connect. Exit code 1 signal: null
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

Released: https://github.com/keen/keen-js/releases/tag/v3.2.5
Thanks again for your help @andrehjr!


Add portuguese translation to the different-languages email template

Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:
Adds portuguese as an optional language to the different-languages email template.
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[WIP] feat: new split discovery and push down

What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
NOTICE This PR is currently under development
Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

as mentioned in #2862, if a Source with source_id_1 changes, the source manager on meta should send a mutation to all related actors about what splits they will read.
lets suppose
source_1 (split_1, split_2, split_3) -> [actor_1, actor_2, actor_3]
and assignments are: (actor_1, [split_1]), (actor_2, [split_2]), (actor_3, [split_3])

then source_1 adds a split, the mutation should contain
(actor_1, [split_1, split_4]), (actor_2, [split_2]), (actor_3, [split_3])


run tests with gotestsum, list slow tests

gotestsum is a helper providing a nicer output than go test plus a tool for printing the slowest tests:

Should make it easier to see which ones are the bad apples and optimize our test suite over time.
Note: we used to run with -v before, and we also used to print the full stdout. I removed both; iirc gotestsum prints a summary of failed tests at the end, which should include all the info we need. And we shouldn't need to print stdout since it already shows up in the progress stream.

I am just running the tests locally for https://github.com/dagger/dagger/pull/5149 and this change makes a huge positive difference. Thank you @vito 🙌


Analyzed & Increased Website SEO & Performance

Summary

Fixes #142
Fixes SEO & Web performance issues.
List of changes proposed in this PR (pull-request)

Added Meta Description tags to increase web crawlers
Changed generic link texts to descriptive link texts to web crawlers and indexing.
Added a Font face display to fonts to reduce the load time, and ensure invisible text during loading.
*Increase web performance by optimizing images to webp format from png & jpg *

What should a reviewer concentrate their feedback on?

[x] *Try to replicate the error, you can see steps in issue #142 *

Screenshots of changes
####SEO STATS (Previous & Current Respectively)

####WEB PERFORMANCE (Previous & Current Respectively)

This looks fanatic, thank you @anslemkelechi!

I resolved the conflicts and will merge it now!


Pass down an optimization level to the Clang linker invocation

Resolves rdar://105261863

cc @dmcyk.

@swift-ci test

Does this allow arbitrary -Oxxx ? (e.g. -O, -O1, -Oz)?
Looks like it, but I want to double check.

Does this allow arbitrary -Oxxx ? (e.g. -O, -O1, -Oz)?
Looks like it, but I want to double check.

It doesn't, because Swift (driver or frontend) does not have such flags.
Swift only has:
-O                   - Compile with optimizations
-Osize               - Compile with optimizations and target small code size
-Ounchecked          - Compile with optimizations and remove runtime safety checks
-Oplayground         - Compile with optimizations appropriate for a playground

So the mapping that myself and @dmcyk came up with is:
-O and -Ounchecked -> -O3
-Onone             -> -O0
-Osize             -> -Os
-Oplayground       -> -O0 (that's what it maps to in swift-frontend)

sounds good.

Users can override this with a more fine-grained Clang flag if they wish to, adding to their swiftc command:
-Xclang-linker -O2

@swift-ci test

@swift-ci test Windows platform


🐞 fix: Invalid default parameter provided for node setup

fixes #12

@stdevMac could you review it as well?

I deleted the fork, not knowing this was still pending. Let me PR this again.


Allow non-async createContext

Solve #120

Hi @icflorescu, could this little change be merged please?
My linter makes me go to the dark side to bypass this.

Apologies for taking so long to pull this, but due to some family issues I've had virtually no spare time over the last couple of months.


Make repo for Tor.framework

I can provide the initial commit when it's ready. Will take a little bit of work.

:+1: :beer:

https://github.com/iCepa/Tor.framework


Download and Import

How do I get the files to import in the format that is shown in your helper videos? When I go to import the modules are core, firebase login, firebase file storage etc. (as is in the repo), rather than country picker, firebase plugin etc. which is what is shown in the tutorials?
Apologies if this is really basic knowledge, I'm new to open source.
Any help would be really appreciated

Ok thanks. I was using the video on your wiki page for Add Chat SDK to an existing project, but I can now see that was from February.


Integrate TNS

Added:

reverse name resolution to show the TNS domain instead of the address on the header
use a tns domain as destination address

I found a problem in the async address validation, I will fix it


Bad line endings

When installing with -g, it won't work on Mac. The problem seems to be the file is using CRLF instead of LF. I converted the file and it worked again.

Thanks for point it out. I can't believe I've been doing this to people 😂

Fixed in release 0.2.1


add cname

Can we set cname?
https://docusaurus.io/docs/en/site-config#cname-string

Added. Now the site is published through babydegu.com


ApiKey and UsagePlan objects do not support attribute Tags

Hi,
I'm getting the following errors when trying to tag an ApiKey or a UsagePlan:
AWS::ApiGateway::ApiKey object does not support attribute Tags
AWS::ApiGateway::UsagePlan object does not support attribute Tags
Here's an example code:
self.template.add_resource(
    ApiKey(
        'ApiKey',
        Name='ApiKey',
        Enabled=True,
        GenerateDistinctId=False,
        StageKeys=[
            StageKey(
                RestApiId=api_id,
                StageName=stage_name
            )
        ],
        Tags=Tags(
            Customer='CompanyX',
            Plan='Professional'
        )
    )
)

self.template.add_resource(
    UsagePlan(
        'UsagePlan',
        ApiStages=[
            ApiStage(
                ApiId=api_id,
                Stage=stage_name
            )
        ],
        UsagePlanName='UsagePlan',
        Tags=Tags(
            Customer='CompanyX',
            Plan='Professional'
        )
    )
)

According to the AWS documentation, both API keys and usage plans can be tagged: https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-tagging-supported-resources.html
Any plans for supporting tags?
Thanks!
Great job BTW! Troposphere saves me a tons of time. 👍

CloudFormation does not yet support tags for ApiKey and UsagePlan.
We need to wait until CloudFormation adds these properties.

CloudFormation does not yet support tags for ApiKey and UsagePlan.
We need to wait until CloudFormation adds these properties.

Any news on this ?


Multiple Calendars for 1 event?

Hey,
I have for example 3 calendars (it's like 3 layers).
And Layers are named:

Mike (id: mike)
Tom (id: tom)
Spike (id: spike)

And I want to add only 1 event with 3 layers, so the that data-calendar-id="mike|tom|spike" and make the bar as 3 colors (I could achieve that with gradient).
So when choosing CALENDAR (now we have a dropdown) I would replace it with some MultiSelect field etc.
Is that somehow achieveable?

Hey,
I achieved it as attached.
You can click on left and hide the calendars you need.
When you have event with 3 calendars and so there are 3 striped colors, one of the colors will vanish and the rest stay. The event will be hidden when all 3 calendars will be hidden.
And I did it by providing the the calendarId with values like 12|43|23 where the numbers are the calendar ids.
And in creation popup I replaced the current dropdown replacing it with multi select field.

Hello, I would like to accomplish the same, but I´m having difficulties with just passing to calendarId '1|2|3'. I´d really appreciate if you can point me in the right direction


Add Noted Layout

The tool seems to support the various layouts of the Neo family. Would it be possible to add support for the newest entry in the neo family, the Noted layout?

I created a pr #7

Thats right. The cvs file is a dictionary and way to large, also i dont know if i have the right to upload it here. Maybe i can link it somewhere. Sorry for the confusion.
The other part of adding a layout is extending the Layout type inside Types.elm. The resulting compiler errors should lead you to the relevant code parts. Was that helpfull?

Thanks for the pointers. I added it and published the PR in case you want to merge it like this and just run the convert script yourself.

The 'j' char was missing from the Noted layout in the convert.py. I fixed this and deployed. Nicely done ^^ Thank you


Email account gets suspended

Hi there,
I am trying to run a POC for the email channel. The email I use is a generic outlook.com email.
The bot works fine for few days, but then the email account gets suspended.
Is there any specific email service we should use?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 33730573-544b-0933-3d4f-1a1ef80be8e1
Version Independent ID: 57b21c32-8769-9713-98d6-3bd68da0ce77
Content: Connect a bot to Office 365 email - Bot Service
Content Source: articles/bot-service-channel-connect-email.md
Service: bot-service
Product: bot-framework
GitHub Login: @RobStand
Microsoft Alias: kamrani

You might want to post this question on Stackoverflow using the  using the botframework tag.

Hey, I dont think this question is relevent for Stackoverflow. This is not a how-to question, but requires documentation and/or explanation from the team.
The problem is not that i don't know how to activate email channel, or how to build the bot. The problem is the email used gets suspended. This is because email channel logs into email from multiple geographic locations and Outlook detects it as an anomaly.
If outlook email is not supported, or, there is some configuration required in the mail itself, then this should be a part of documentation.


build: drop support for python 3.7

There are several CVE vulnerabilities that exist in this repo today.
Just looking at all the packages installed in my virtual-env, not all of these are direct dependencies
Name         Version   ID                  Fix Versions
------------ --------- ------------------- -------------
black        22.8.0    PYSEC-2024-48       24.3.0
certifi      2022.12.7 PYSEC-2023-135      2023.7.22
gitpython    3.1.32    PYSEC-2024-4        3.1.41
gitpython    3.1.32    PYSEC-2023-161      3.1.33
gitpython    3.1.32    PYSEC-2023-165      3.1.35
idna         3.4       GHSA-jjg7-2v4v-x38h 3.7
jinja2       3.1.2     GHSA-h5c8-rqwp-cp95 3.1.3
jinja2       3.1.2     GHSA-h75v-3vvj-5mfj 3.1.4
pydantic     1.10.2    GHSA-mr82-8j83-vxmv 1.10.13,2.4.0
pygments     2.14.0    PYSEC-2023-117      2.15.1
requests     2.31.0    GHSA-9wx4-h78v-vm56 2.32.0
tornado      6.2       PYSEC-2023-75       6.3.2
tornado      6.2       GHSA-qppv-j76h-2rpx 6.3.3
tqdm         4.64.1    GHSA-g7vv-2v7x-gj9p 4.66.3
transformers 4.25.1    GHSA-282v-666c-3fvg 4.30.0
transformers 4.25.1    GHSA-3863-2447-669p 4.36.0
transformers 4.25.1    GHSA-v68g-wm8c-6x7j 4.36.0
transformers 4.25.1    GHSA-37q5-v5qm-c9v8 4.38.0
urllib3      1.26.15   PYSEC-2023-192      1.26.17,2.0.6
urllib3      1.26.15   PYSEC-2023-212      1.26.18,2.0.7

There have been pr's to start to address these such as
https://github.com/protectai/nbdefense/pull/55
https://github.com/protectai/nbdefense/pull/50
but have not made been merged due to python 3.7 + poetry upgrade needing to be completed first.
This PR

[x] removes python 3.7 support
[x] upgrades to poetry 1.8
[x] upgrades outdated github actions
[x] adds support for dependabot to keep actions up to date

@chrisking any chance we can get movement on this?

I have removed hard requirement for signed commits.

Thanks very much @CandiedCode !


new category spaces validation

@Andrew-Sem
I can only enter spaces and not get a message that I entered the wrong category name

Same here

Same here


BaseEmbeddingExtractor - Use params for chunk overlap size

This pr updates BaseEmbeddingExtractor to use EmbeddingInputParams for chunk overlap size

Looks good, just remove this also - https://github.com/diptanu/indexify/blob/main/run_tests.sh#L27


Add multiple icons - Pop project

Duplicates ❌

[X] I have searched the existing icons or assets and requests.

Which Figma library is concerned?
Vitamin Icons
Remix icon check (only for icons)

[X] I have searched if the icon is already available on Remix.

Icon or Asset name
/
Icon or Asset description
template icon: used to delimit a number of areas. help users understand how many areas they are working on.
designs icon: used to illustrate a library of components, illustrations and logos. help users understand that they will find a component library to import.
jersey-number icon: used to represent jersey markings, in particular numbers. help users understand that they will be able to add a number.
text-curved icon: used to curve text. help users understand that they will be able to curve a text
Icons-Pop.zip
Icon or Assets keywords
template, designs, jersey-number, text-curved
Icon or Asset author
No response
Icon or Asset SVG code
<svg>...</svg>

Are there any other important details?
No response

Design and templates icons have been deleted to this contribution because there aren't agnostic of a product.
Italic have been directly added from remix.


openspace: 0.11.1 -> 0.14.0

Motivation for this change
Upgrading from OpenSpace 0.11.1 to 0.14.0, and cleaning up the package.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@timjrd do you mind rebasing this?

Hi :) I rebased this branch on my local copy, but I'm now unable to successfully compile the package, presumably due to an upgrade of freeimage. I'm facing the following error at the end of the build (linking stage):
ld: libfreeimage.so: undefined reference to `std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char><EMAIL_ADDRESS>
I came across this thread, where it is suggested to set CXXFLAGS='-D_GLIBCXX_USE_CXX11_ABI=0'. I tried to enforce this flag by various means without any success.
Any clue ?

Closing this as it's largely outdated. I would rather re-package the latest version when I have some time.


How to click on the head of a child view?

How to click on the head of a child view?

What are you asking? Do you want to click on a section header?

I don't know what functionality you're asking for, but I just implemented collapsing sections, where you can call SectioningAdapter::setSectionIsCollapsed to collapse/expand sections.
https://github.com/ShamylZakariya/StickyHeaders/commit/a07ffcbd11e959ca403cac0290bbdcad60030ada
I'm assuming this is what you are asking for, so I'm closing this.


Images are not displayed propely in IE

Can you please provide any workaround can be done for this or let us know the root cause of issue.
Link to PDF file (or attach file here):

http://hosted-stage.rightprospectus.com/Wasatch/Fund.aspx?cu=936772201&dt=SAR
2.http://hosted-stage.rightprospectus.com/documents/Wasatch/SEMI_Wasatch.pdf

Configuration:
Web browser and its version: Internet Explorer , version:11
Operating system and its version:Windows7
PDF.js version:1.1.469
Is an extension:

Steps to reproduce the problem:

Go to the given links with PDFJs Viewer both in Chrome and IE.
2.Compare the first page in IE with Chrome.
3.We can find the the picture on the front cover is not displayed properly.

What is the expected behavior? (add screenshot)

What went wrong? (add screenshot)

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):http://hosted-stage.rightprospectus.com/Wasatch/Fund.aspx?cu=936772201&dt=SAR
PDF Document:
SEMI_Wasatch.pdf

Closing as duplicate of issue #7375; which in itself is a duplicate of issue #5264.
Please take a moment to read through issue #5264 carefully, and you will see that this is caused by Internet Explorer not supporting Blend Modes. This is a limitation of the browser, and not something that we can fix!
Given that Blend Modes are not something that can be easily poly-filled, it should come as no surprise that the simple workarounds posted in various issues doesn't really work.
For future reference, please do not open multiple issues for the same PDF file!

Have logged the same for #7375 ,  verified the codes for Issues #5264 , #3900 this didn't help us.

Thanks a lot !!
Here are some questions from my side.

Can we recreate the pdf so that it did not break with this issue ?
2.If we can do the above and how it can be achievable ?
3.Reason why this pdf is breaking in IE ? (Is something wrong with PDF)

Hi @gsampath127 . I'm not sure you are reading the referenced bugs.

Can we recreate the pdf so that it did not break with this issue ?

Use tools to optimize PDF for web and performance. See https://helpx.adobe.com/acrobat/using/optimizing-pdfs-acrobat-pro.html (see Transparency options?)

2.If we can do the above and how it can be achievable ?

See https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#what-types-of-pdf-files-are-slow-in-pdfjs-can-i-optimize-a-pdf-file-to-make-pdfjs-faster
Or you can polyfill blend mode functionality for HTML5 canvas for IE9,10,11. It works for IE Edge.

3.Reason why this pdf is breaking in IE ? (Is something wrong with PDF)

See conversation above -- IE11 and below does not support blending modes and was addressed by IE team is IE Edge.
See also https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#what-browsers-are-supported


Test PR for git lfs cache key

Description of work:
Check all that apply:

[ ] added release notes
(if not, provide an explanation in the work description)
[ ] updated documentation
[ ] Source added/refactored
[ ] Added unit tests
[ ] Added integration tests

References:

Links to IBM EWM items:
Links to related issues or pull requests:

Manual test for the reviewer
(instructions to set up the environment)
Check list for the reviewer

[ ] release notes updated,
or an explanation is provided as to why release notes are unnecessary
[ ] best software practices

[ ] clearly named variables (better to be verbose in variable names)
[ ] code comments explaining the intent of code blocks

[ ] All the tests are passing
[ ] The documentation is up to date
[ ] code comments added when explaining intent

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.74%. Comparing base (6751a4d) to head (e738283).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #114   +/-   ##
=======================================
  Coverage   60.74%   60.74%
=======================================
  Files          33       33
  Lines        6535     6535
=======================================
  Hits         3970     3970
  Misses       2565     2565

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


make istio-ca-root-cert in namespaces respect revision

currently, namespace controller will create the fixed istio-ca-root-cert in namespace even if you install istio with --revision.
This PR will support we have multi istio mesh in a single cluster.
gateway need special logic. one way is  to let istiod create istio-ca-root-cert with revision in system namespace by default.  Will address this later.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
6f279841a9ad80336e77cd1f5672b951a0c2ceca
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks @shankgan as he pointed out this issue to me.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
6f279841a9ad80336e77cd1f5672b951a0c2ceca
link
/test release-notes_istio

integ-operator-controller-tests_istio
6f279841a9ad80336e77cd1f5672b951a0c2ceca
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
6f279841a9ad80336e77cd1f5672b951a0c2ceca
link
/test release-notes_istio

integ-operator-controller-tests_istio
6f279841a9ad80336e77cd1f5672b951a0c2ceca
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
6f279841a9ad80336e77cd1f5672b951a0c2ceca
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
387cf6d83cfc126f45bf92a5c32be433705cacfa
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Agree with @howardjohn. Also, could this PR could be tracked as part of a larger github issue to allow all IstiodCA related  components (The ca certs it depends on etc) to be revisioned? Given that this isn't a small change, I would recommend an  accompanying RFC to gather comments from the community.

Thanks for the suggestions.  I will submit a design doc for this.  Let's me mark this PR on-hold for now until we sorted the design out.

@irisdingbj: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test integ-pilot-k8s-tests_istio

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
387cf6d83cfc126f45bf92a5c32be433705cacfa
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-tests_istio

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
387cf6d83cfc126f45bf92a5c32be433705cacfa
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
387cf6d83cfc126f45bf92a5c32be433705cacfa
link
/test integ-pilot-k8s-tests_istio

integ-security-multicluster-tests_istio
b254b79bd61be7c7978d3c867992f430c530e21a
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
b254b79bd61be7c7978d3c867992f430c530e21a
link
/test integ-security-multicluster-tests_istio

integ-pilot-k8s-tests_istio
b254b79bd61be7c7978d3c867992f430c530e21a
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn @shankgan @costinm  design doc is ready, PTAL : https://docs.google.com/document/d/1aLDfouW962hf8FP3poGOPOAlzBmiBYWrwoUhO9nD9hs/edit#  and looking forward to your comments!

@irisdingbj: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Feat/merge-fork-source-18-april-2024

Sorry, this was an accident.. I meant to merge into my fork.. Sorry


Undefined behaviour for F and M commands

Hi, I love your language! I'm writing an implementation of it over at https://github.com/mademast/fxyt and I noticed two areas where the spec leaves behaviour undefined: using M to increment the mode more than twice and using F to set different frame intervals for different spatial coordinates. From looking at your reference implementation, it looks like overincrementing the mode is an error, and the only frame interval that matters is the final pixel (all others are ignored). I may have misread, though.
I agree with the first behaviour, but maybe having F set different values based on the grid coordinates should be an error? Otherwise different implementations could behave differently depending on what order they render the image in. Each pixel could also set its own frame interval (could be visually interesting!), but that would significantly increase the complexity of a FXYT interpreter and introduce the issue of synchronization.
It would work to let F set different values based on the T coordinate; that makes intuitive sense to me.
(maybe setting the frame interval to a negative value should also be an error?)
Thanks for making this project! It's been a lot of fun throwing together a simple parser and interpreter for it.

Hi @novedevo, Thank you for taking a close look at this project. I am glad you like it and you are making a Rust implementation of it! You are right about both things. I have pushed two commits to address the problems you identified.

Commit a4cd667 to clarify in the documentation that it is an error to increment the mode number to 3.
Commit e85c929 to consider negative frame intervals to be an error and also to only consider the frame interval set during the evaluation of the cell (0, 0) as the frame interval for the next frame.

The fixes are now available as part of version 0.2.0 at https://susam.net/fxyt.html. Thanks once again for identifying these issues and for sharing your recommendations for fixing them.


Implement client for default permission endpoints

Currently, we have kept the default permission endpoints as fixed paths. Instead, we should probably focus on adding a client for the default API, and for that, we know the routes. Users might still be able to reuse that client if they host a /permissions API at the expected base path (if all they are doing is modifying the behavior of the default endpoints). And if they wanna add a completely different API, then they would also need to implement the client along with it.
Hence, we need to implement a client for the default permission endpoints, which then can be used in the controller logic of a FOCA app.

Just to note that the default client should be passed the base path of course, i.e., everything before /permissions

#157


Fetch html element from DataServlet

As per instructions from
step-portfolio/walkthroughs/week-3-server/step-2-fetch-walkthrough.md

It was just a part of the walk-through and json branch is overwriting these changes anyway. So closing this pull request.
Please refer to the overwritten changes at
https://github.com/Prashantneu8848/step-portfolio/pull/9


SetWindowLong vs SetWindowLongPtr

For x86 SetWindowLongPtr is just a macro substitution for SetWindowLong, and user32-sys declares SetWindowLongPtr only for x64, because x86 user32.dll has no Ptr version.
But what about SetWindowLongPtr usage? We can implement it in user32-sys, but winapi-rs prefers no executable code as mentioned in #218. Or we can write the portable stub for x86/x64 in every rusty crate, which tries to use the user32.
Any better solutions for this?

For winapi 0.3 functions will be defined in file corresponding to the header they are from since I will be getting rid of the -sys crate nonsense. Thus you'd also be able to reexport functions under different names (as well as defining shim functions that call functions) since everything would be in the same crate.

I meeting plans about 0.3 from time to time, but is any roadmap and dates about it? Just to be aware of it.

There have never been any dates or roadmaps for winapi. It'll happen once I catch up on all the PRs, get the license situation squared away (I want to make all the copyrights consistent and switch to dual licensing MIT/apache), and then finally start overhauling stuff. It'll happen in bursts whenever I feel sufficiently motivated.

I have added re-exports for these functions so you can now use SetWindowLongPtrW even on i686-pc-windows.


fix(usefilters): fix userFilterTypes alias in setFilter action

Fix to correctly alias filterTypes to userFilterTypes in set filter action, so that the filter
autoremove method is called correctly
fix #1831

Nice!


Add to object conversion for tuple.

What
Tuples are already implemented as Vec and converts RawVal. By definition, this should also convert to Object (since Vec is an object).
Why
Needed for https://github.com/stellar/rs-soroban-sdk/pull/469
Known limitations
[TODO or N/A]

Turns out this is not needed with the solution adopted in https://github.com/stellar/rs-soroban-sdk/pull/469#discussion_r953242174


Expose seeds in JS SqLambda API

Discussion in Discord: https://discord.com/channels/1130609991993274510/1223854334761238601
I'll copy my main comment from it here:
Observations:

Squiggle functions are not exactly pure because they act as generators when they produce randomness; f() = (2 to 3) -> sample; f() == f() is false
in JS land, f.call() will give you the same number both times
I don't like this; we should have parity between evaluating Squiggle scripts and calling same Squiggle builtins from JS
so I guess in JS it should be [result, rngState] = f.call(params, rngState)?
otherwise things won't be nice in React land, e.g. const value = useMemo(() => f.call(), [f]) won't work
btw one more complication is that rngState is not a seed; seed -> rngState is kinda slow, and also irreversible
maybe rngState could be a reducer instance, same as in our common function registry APIs
but, anyway, right now reducer is not an SqProject, because reducer objects short-lived
also note that in some cases we'll want to invoke f.call() in multiple code locations, e.g. by passing f to multiple React components; so there should be something for "splitting out RNG into multiple sub-RNGs with unique predictable states" (we'll also need it for parallel execution of Squiggle programs)
bottom line, we should be explicit about rng state in more places than we expected, and also we'll have to spend more effort on educating users about this if "calling Squiggle from JS" ever becomes popular

See also:  #3168


chore: remove deprecated rollup-watch

Merging this PR will publish the following release:
2.2.1 (2020-02-01)
Bug Fixes

add link to npmjs and release rollup peerep (c85ec68)
update lodash to fix critical vulnerability warning (6850aaf)

:tada: This PR is included in version 2.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fixes prompt to overwrite resource templates. Refactors UpdateResourc…

…eModal as functional component.
closes #1577


New package: Lenovo.ThinkPadUtilityforDOS version 4.44.7IU601US

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/113297&drop=dogfoodAlpha

I'm not able to determine if this package installed successfully. It added no files of any kind, nor any entry in the Settings Apps page. Is this expected?

I'm not able to determine if this package installed successfully. It added no files of any kind, nor any entry in the Settings Apps page. Is this expected?

Try running in a normal PC, and see the results.

Supporting custom hardware in validation is "Not Planned".

https://github.com/microsoft/winget-pkgs/issues/199504


camera_id scan limit 2 -> 8 (Support many cameras plugged in)

I was trying to figure out why my Rigel wasn't being detected and found out it was just because the test script wasn't reaching its id in the device enumeration.

I haven't been updating the librealuvc master frequently.  I have a develop branch which is used
for merging current development from feature branches, and most of my feature work (sometimes unstable) is on viewer1.  If we're getting to the point where it's useful for others to try this, getting it from develop (and creating feature branches off develop) is best.  This fits with the GitFlow/HubFlow methodology described here https://datasift.github.io/gitflow/


Parallelize bundle install and allow retrying

These parameters and the values used appear to be de facto standards.

I considered making a bundle_options parameter, but decided that's a premature optimization.


Android 8 battery drain

Describe the bug
After some time, Outline on Android started to heavily consume battery.
To Reproduce
Steps to reproduce the behavior:

Install Outline client
Connect to server on DigitalOcean
Get battery drained

Expected behavior
Not to consume battery like crazy
Screenshots

Smartphone (please complete the following information):

Device: Samsung Galaxy S7
OS: Android 8.0

Submit Feedback
Done

This is normal. The percentage of battery drained by Outline equals to the sum of all networking activities on your phone, not just Outline itself.
To address this issue, please download Greenify and see what app is constantly "waking up" your phone while the screen is locked. Then, limit their background activities to save battery. In China, for example, Telegram and Google Sync are likely the main sources of battery drain.
However, it is still possible that Outline is causing the problem. Please try to download shadowsocks-android, which is the app that uses the same shadowsocks protocols as Outline. If this helps, then it would be Outline.


AA0211 should error for standard, non-FlowField/Blob passed to SetAutoCalcFields(), etc.

This rule correctly catches non-FlowField/-Blob fields passed to CalcFields(), but it does not warn for SetAutoCalcFields(), instead resulting in a runtime error. It should warn for both, thus stopping developers from publishing a wrong SetAutoCalcFields() and only finding out later.
Saying that: if the current diagnosed case is a runtime error, why is it only a compile-time warning? If that code cannot possibly work at runtime, don't let devs think they can ignore the 'warning', because it will just be transmuted into an error later, thus again wasting our time. That is: make any such attempt to calc a non-flowfield be a compile error
Edit: This should also apply to other places where one can specify CalcFields, e.g. in a Report dataitem. Please ensure that it does.

Thanks for reporting this issue. Sorry we haven’t completed it yet, but we’ve had to prioritize elsewhere. We’re planning to give the CodeCop engine and its rules an overhaul in a future major release. Thanks for your patience.


Improve windows support

Add a interface description string to the CMSIS-DAP v1 Interface and DFU interface
Don't use fixed endpoints for the CMSIS-DAP v1 and v2 interface, so that they can be reordered.
Use interface association descriptors, so that Windows works properly with the USB serial port.
Setup Microsoft OS 2.0 Descriptors
With these descriptors, Windows will automatically use the WinUSB driver, without needing Zadig.

Fix #23 and fix #25 .

Very nice!!! I'll give these a try as well with the rusty-probe and the dap-rs extraction I made. Hopefully we can bundle so the descriptors there later and have everything working across multiple MCUs :D

I was able to install this on an HS-Probe which was using Zadig-WinUSB, then removed all the existing drivers for its interface, and now it works straight away. Thanks!


Rewrite plugin index pages

This rewrites each of the plugin index pages to make them more easily readable. It also makes the plugin listings more responsive.
Closes #800

Wow - this looks SO nice!

There's a problem with the page links at bottom of page - rending white text on light grey background. Either moving the next page links into the blue background area, or darkening the text color should remedy.

@cjohnhanson looks like a great iteration. My notes:

the pagination issue AJ already mentioned
The height of each of the grids is dependent on a row based on the largest icon on that row. I think it's most noticeable on the loaders page where the shift in the cards between rows is more obvious https://deploy-preview-809--meltano-hub-gridsome.netlify.app/loaders/ I think just using the same size across the board would be cleanest?
Is there a setting to have an incomplete row be centered? https://deploy-preview-809--meltano-hub-gridsome.netlify.app/orchestrators feels weird


Razor editor does not respect automatic brace completion setting

Create a new or open existing cshtml file (can be isolated or in project).
Ensure Automatic brace completion is disabled in Options > Editor > HTML/C# > General.
Type @{ and hit Enter.

Version used: 15.0.25148.1
Actual: } is automatically inserted
Expected: no brace inserted as per the setting
This breaks the typing flow when users are used to manually enter the closing brace (as it works for @for etc.).

@NTaylorMullen @ToddGrun any idea where this bug ultimately goes?

Definitely on the tooling side. I'll move it.

This issue was moved to aspnet/Tooling#712

Thanks @Elion and @NTaylorMullen, I was wondering whether it belongs here or to the tooling.


ADD solutions to the questions

Is your feature request related to a problem? Please describe.
Add solutions to the physics questions (MCQs and numericals).

Hello can I work on this under GSSOC'22?

@piyusha2001 u can work. For any doubts u can ask in discord.

I would like to work on this issue. Please assign me as a GSSOC 2022 Contributor.

@SHRUTI-SINGH16 u can work. Just add proper step wise solution to math or physics questions in the editorial section.

please assign this issue to me

Please assign this to me.

@Sampurankishoresrivastava @akanksha0812 u can work on adding solutions to both math and physics questions

Please assign me this issue. I would like to add editorial for Physics Question.

@jatin00000 r u a part of any open source event?

Yes, Want to contribute under Hacktoberfest.

@jatin00000 u can work. U need to add the solutions to the physics questions and not physics quiz.

Facing this issue in running
npm start

I had gone through the code, and understood where to add the required code but not able to execute the code in my local machine.

@jatin00000 have u gone through the procedure in the readme file

There is a section in the readme file of how to start. Go through it


IPP Everywhere driver not passing correct finishing options to clients

Describe the bug
Using cups to allow chromebooks to print. If i use the ppd file on chromebook config i'm missing some options for the printer (not this issue). If i use ipp Everywhere > cups and ipp everywhere > client  which chromebooks do with cups 2.4.7 im missing tray options I can do PPD > cups > ipp everywhere but i get a different set of missing options.
To Reproduce
Steps to reproduce the behavior:
Ive run ipptool -tv ipp://...:631/****** get-printer-attributes.test three different ways and seem to get different results
I have a CUPS 2.4.1 and a CUPS 2.4.6 I seem to get different attributes
Ipptool to printer IPP> i get hole punch options
Ipptool to cups 2.4.1 PPd printer > no hole punch options
IPPtool to cups 2.4.6 ipp everywhere printer > no hole punch options
Expected behavior
I assume ipp get attributes would return the same options all the way to the client ( Printer > Cups > Client)
Screenshots
If applicable, add screenshots to help explain your problem.
System Information:

ubuntu 22.04 cups 2.4.1 ubuntu 23.10 cups 24.6
Ricoh printer ipp and ppd > cups servers > chromebook clients running cups 2.4.7

Il make a feature request if this may be a thing but using cups to filter the number of options being passed to the chromebook ipp everywhere clients would be awesome.

Upload your ppd file and the results of ipptool.

Ricoh8300s.ppd.test.txt
cups.Ricoh8300s.ppd.test.txt
Copyroom1ipptest.ppd.txt
Since we used ipp everywhere I never specified a ppd file. I grabbed this one from my production cups server that currently dosn't show punching options to end user.

OK, so the direct IPP ipptool output shows that the printer supports both punch and staple (top-left, top-right, and edge stitch variants). The CUPS queue shows a staple option but not punch, but punch finishing support has been in there since 2.3.3op2 at least. The PPD file you attached shows comments that wouldn't ordinarily be from the default IPP Everywhere generator...
Can you run the following command - it will produce a machine-readable version of the attributes from your printer which I can use to simulate your printer in my office to test the PPD generator:
ipptool --ippserver ricoh-pro-8300s.conf ipp://HOST-OR-IP/ipp/print get-printer-attributes.test

Then attach the "ricoh-pro-8300s.conf" file to this issue and I'll continue to investigate.
Thank you!

I had to rename to txt so GitHub would let me attach it.
ricoh-pro-8300s.txt

OK, I've reproduced and assigned to 2.5. Depending on the changes needed, we may be able to backport to 2.4.

OK, I've fixed the punch finisher support:
[master 2bc9a48b9] Fix support for simple punch finisher (Issue #821)
For the finishing template support, this particular printer seems to put all of the templates in a single collection value - this is a printer bug and needs to be reported to Ricoh...

[2.4.x a994c7318] Fix support for simple punch finisher (Issue #821)

Also, I've passed the finishings-col-database issue to my contact at Ricoh...


vimeo-loop recommendation 🎞  (AutoPlay dont work on first load if not muted.)

Hey! Thanks a lot for your wonderful public template.
I recommend to add "&muted=1" inside the vimeo url, so we can automatically play video on homepage.
This was a issue for me, so i wanted to notice you ✅

Hey @FRIKKern thank you! 🙏
That's interesting... according to the vimeo docs you shouldn't have to add that since &background=1 mutes the video automatically for you: https://vimeo.zendesk.com/hc/en-us/articles/115011183028-Embed-background-and-chromeless-videos

Adding this parameter will have the following effect:

All player toggles and elements will be turned off (including the play/pause button!)
The video will automatically loop.
The video will be set to autoplay.
The video will be muted.

Nonetheless, I've added it for posterity. 🤘