FHIR authentication POC

From the discussion on hapi FHIR Authentication refer to document here
We need to extend the hapi fhir Authorization Interceptor to allow us talk to keycloak and obtain  a login attempt response

@manutarus is this something you're working on? please reassign if not

@rehammuzzamil @dubdabasoduba  We also need to add an endpoint that provides information about the practitioner based on the authentication headers so that the client has the current user identity(Practitioner/PractitionerRole).

@rehammuzzamil @dubdabasoduba We also need to add an endpoint that provides information about the practitioner based on the authentication headers so that the client has the current user identity(Practitioner/PractitionerRole).

Could you please point me to the current end-point on OpenSRP exposed for this purpose? @ekigamba

@rehammuzzamil Here is the endpoint source code https://github.com/opensrp/opensrp-server-web/blob/8e456e20d73f6c2d8b8d6c5d660bad40c43805f2/src/main/java/org/opensrp/web/controller/UserController.java#L194


Some preview models cut out if they go too far back

Describe the bug
A clear and concise description of what the bug is.
The cosmetic preview player model can be cut off in some cases, making parts of it look odd.
To Reproduce
Steps to reproduce the behaviour:

Go to any screen where the cosmetic preview appears
Drag the player around - upward tends to work best
! Parts of the preview model will be cut off

Expected behaviour
A clear and concise description of what you expected to happen.
The player model would not be cut off.
Screenshots & Logs
If applicable, add screenshots or log snippets to help explain your problem.
Bugged:

(there should be a second antenna thing)
Normal:

Problem without any cosmetics:

System & Version Information
(This can usually be found in the F3 Menu)

Java Version: Java 17.0.8
Minecraft Version: 1.20.1
IslandUtils Version: 1.6.1
OS: Windows 10
CPU: Ryzen 5 3600

Additional context
Add any other context about the problem here.
This is most obvious if using very big cosmetics (such as Flower Umbrella) and/or other cosmetic mods such as Figura, but it can happen with just the base player if dragged enough.

This is a problem with how minecraft renders things and there's not much i can do about it


Export TrialView to Python

So far, the summary of the conversion-related issues is as follows:

PythonSample -> Sample<T...> worked seamlessly (using the custom constructor), while Sample<T...> -> PythonSample did not. I solved this by using runtime type registration on Sample<T...> exports. Conversions Sample<T...> <-> PythonSample now work seamlessly both ways.
ListTrial<S> and ListTrial<PythonSample> are not convertible. I tend to believe it is not an issue, because different Trials represent different approaches to storing samples, and so do C++ samples vs PythonSample. Providing such conversions would impose much extra work for exporting every single possible Trial, while TrialView is already there to view different Trials in a uniform way. Having said that, I would skip on ListTrial<S> <-> ListTrial<PythonSample> conversions, and the same for any new Trials (except TrialView).
TrialView is essentially a way to feed any Trial into a Model. That said, it should support all possible conversions. There are two ways: create a single custom PythonTrialView that accepts any Trial (including C++ Sample and PythonSample variants), or to export TrialView<S> and TrialView<PythonSample> separately and make them convertible. The latter is a bit more canonical, though it requires a bit more work and imposes more constraints. In short, I would need to downgrade TrialView<S>::ConstIterator to a (random access) input iterator. It is not a big issue as of now since Model, being the only user of TrialView, uses those iterators as input iterators anyway. Please let me know if I should proceed with this option.

Push what you have so far and I'll take a look at it either later today or
tomorrow.
On Tue, Apr 23, 2019 at 5:23 PM andrei-sa<EMAIL_ADDRESS>wrote:

So far, the summary of the conversion-related issues is as follows:

PythonSample -> Sample<T...> worked seamlessly (using the custom
constructor), while Sample<T...> -> PythonSample did not. I solved
this by using runtime type registration on Sample<T...> exports.
Conversions Sample<T...> <-> PythonSample now work seamlessly both
ways.
ListTrial and ListTrial are not convertible. I
tend to believe it is not an issue, because different Trials represent
different approaches to storing samples, and so do C++ samples vs
PythonSample. Providing such conversions would impose much extra work for
exporting every single possible Trial, while TrialView is already there to
view different Trials in a uniform way. Having said that, I would skip on ListTrial
<-> ListTrial conversions, and the same for any new
Trials (except TrialView).
TrialView is essentially a way to feed any Trial into a Model. That
said, it should support all possible conversions. There are two ways:
create a single custom PythonTrialView that accepts any Trial (including
C++ Sample and PythonSample variants), or to export TrialView and
TrialView separately and make them convertible. The
latter is a bit more canonical, though it requires a bit more work and
imposes more constraints. In short, I would need to downgrade
TrialView::ConstIterator to a (random access) input iterator. It is
not a big issue as of now since Model, being the only user of TrialView,
uses those iterators as input iterators anyway. Please let me know if I
should proceed with this option.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/eidolonsystems/rover/pull/23#issuecomment-485980319,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD6MKGP7YDQVGV72TRJXWXTPR546LANCNFSM4HG6TTSQ
.

--
Kamal Mansouri
Computer Programmer
+1<PHONE_NUMBER>

I decided not to proceed with the "concept forwarding" in TrialView (const Sample& treated as stable references, Sample-by-copy to a temporary reference) due to the lack of utility (TrialView users still have to factor in the possibility of temporary references) and the fundamental asymmetry: TrialView representing a TrialView is no longer a valid use case.
The code for TrialView conversions is somewhat complicated but it has to mess up with the lifetime of Python objects. In fact, if such workarounds relying on the interfacing of the garbage collector by Pybind were not possible, it would not be possible to convert one TrialView to another without changing the C++ code.
For ListTrial conversions (those will be explicit only), I will create a separate task so that different matters are kept separately.

Pushed fb1447_iterator

Done integration with TrialIterator. One thing to note about TrialIterator is that code for begin(), end(), and the Iterator alias itself is the same for all Trials, as long as the operator [] is provided. CRTP can be used to move those pieces of code to a common base.

Coding standard.
On Wed, May 1, 2019 at 4:38 PM andrei-sa<EMAIL_ADDRESS>wrote:

@andrei-sa commented on this pull request.
In Python/Include/TrialView.hpp
https://github.com/eidolonsystems/rover/pull/23#discussion_r280207504:

   Sample operator [](std::size_t index) const {

     auto python_sample = m_view[index];

     auto result = sample_cast<Sample>(python_sample);

     return result;

   }

   Iterator begin() const {

     return Iterator(*this, 0);

   }

   Iterator end() const {

     return Iterator(*this, size());

   }

 private:

   const TrialView<PythonSample>& m_view;

Just wondering, is it a part of the coding standard or anything else?
Instances of this class are never supposed to be copied.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/eidolonsystems/rover/pull/23#discussion_r280207504,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD6MKGKAJQF77XVD4VQGFMDPTH5WDANCNFSM4HG6TTSQ
.

--
Kamal Mansouri
Computer Programmer
+1<PHONE_NUMBER>


Streaming API

Are there any plans for a streaming API? The ability to serialize/deserialize impl Read and impl Write.
I want to be able to deserialize from a TCPStream.
bincode and postcard both support this.

Are there any plans for a streaming API? The ability to serialize/deserialize impl Read and impl Write.

For our use case we don't need this feature so I am hesitant to add and maintain it.
From an API perspective it would involve duplicating encode into encode_into(w: &mut impl Write, t: &impl Encode) -> Result<(), Error> and decode into decode_from<T: Decode>(r: &mut impl Read) -> Result<T, Error>.
From an internal code perspective it would need to avoid regressing the current performance without duplicating too much code.

I want to be able to deserialize from a TCPStream.

Can you read from the TCPStream into a Vec<u8> and pass that to bitcode?
Are your messages too large that they would consume too much memory? I kind of doubt this because serialized bitcode typically consumes less memory than the deserialized type does.

Can you read from the TCPStream into a Vec and pass that to bitcode?

Yes but that vector could include multiple structs. Postcard has a method take_from_bytes which returns the slice of unused bytes.

From an internal code perspective it would need to avoid regressing the current performance without duplicating too much code.

I was worried that streaming wasn't possible because bitcode relied on knowing where the serialized data ends. In hindsight I realize that doesn't make sense.

that vector could include multiple structs

We work exclusively with WebSockets which provide their own framing of messages. The easiest way to use bitcode on a raw TcpStream might be to transmit the length (e.g. a 4 byte unsigned integer in network endian) and then the bytes from bitcode.

that vector could include multiple structs

We work exclusively with WebSockets which provide their own framing of messages. The easiest way to use bitcode on a raw TcpStream might be to transmit the length (e.g. a 4 byte unsigned integer in network endian) and then the bytes from bitcode.

Yes, that's a good solution thanks. But first I might take a crack at modifying the bitcode codebase to allow for reading a slice partially or reading from a stream.

I think having a way to pack multiple types into one big packet is quite an essential feature, when encoding I guess we can just .extend_from_slice() on the slice from Buffer::encode. But there seems to currently be no way to read multiple messages packed together without including the length of each message (which afaict would be redundant information).
In my usecase (sending game data in UDP packets) I currently use a Cursor and decode messages (using bincode) in a loop until it consumed the entire packet, but even something as simple as getting (T, usize) as a return value, where usize is the number of bytes that were decoded, would be enough.

but even something as simple as getting (T, usize) as a return value, where usize is the number of bytes that were decoded, would be enough.
This would still result in redundant information since each message would be padded to the nearest byte.

Well that's a bummer

Well that's a bummer

To be clear, a streaming API in the sense of impl Read + Write is not planned due to performance and compatibility issues.
We're considering an API that allows you to:

append messages without padding or 'length' field
decode the prefix of received data as a message and know where the decoder left off

This would slightly reduce the overhead of using bitcode in a stream-like context.

decode the prefix of received data as a message and know where the decoder left off

❤

New version of bitcode https://github.com/SoftbearStudios/bitcode/pull/19 has the potential to add streaming without high overhead.

Looks like the code actually would work great with streaming APIs, if only the codec mod was publicly available. Or, rather, the View and Decoder traits for decoding.
I'd have a loop with roughly this:

Try T::populate(1) on the buffer;
Fails? Read and buffer more data;
Works? Decode and return the value, advance the buffer to match what T::populate did to the slice we gave it.

Note that this way bitcode crate does not do any IO itself - external code would be responsible for that. This is the way I'd recommend doing it, as async exists and there everyone has their own traits for read/write ops.

I'd have a loop with roughly this:

Try T::populate(1) on the buffer;
Fails? Read and buffer more data;
Works? Decode and return the value, advance the buffer to match what T::populate did to the slice we gave it.

You could achieve the same effect by length prefixing your messages. If your messages are long, this shouldn't add much overhead. If your messages are short and you encode them one at a time, bitcode won't provide any benefit over bincode.
Note: If your use-case is packing multiple small messages into a UDP packet see bitcode_packet_packer. It's able to encode multiple messages at once, but produces discrete packets that don't exceed a limit. Included is a benchmark of various techniques including encoding messages one at a time.

This is, obviously, a workaround that is universal and well know, and it what I'm using currently. I'm interested in specifically bitcode to provide this functionality - not because there's no other way but rather because bitcode already has everything that is required to do it.
Thanks for sharing the bitcode_packet_packer.
My use case is passing data over WebTransport streams - and currently it is for an example app. It is, basically, sending a packet and waiting for a reply, very old fashioned state machine on both ends without the need to pack multiple messages at once.
I'm currently using the tokio_util::codec::length_delimited::LengthDelimitedCodec - but just that, without the rest of FramedCodec infrastructure, as we don't use tokio io types.


broccoli serve with mergeTrees runs out of memory

When using a mergeTrees (v1.1.1) of funnels (v1.0.0 or v1.0.1), broccoli serve runs out of memory and crashes.
Simplest Brocfile.js:
var funnel = require('broccoli-funnel');
var mergeTrees = require('broccoli-merge-trees');

module.exports = mergeTrees([
  funnel('.', { include: [ 'tests/**/*.js' ] })
]);

When I run broccoli build dist, everything works fine. When I run broccoli serve, I get
Serving on http://localhost:4200

Warning: failed to stat tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/node_modules/broccoli-babel-transpiler/node_modules/babel-core/node_modules/regenerator/node_modules/defs/node_modules/yargs/node_modules/cliui/node_modules/center-align/node_modules/align-text/node_modules/kind-of/node_modules

<--- Last few GCs --->

   20320 ms: Scavenge 1402.9 (1457.7) -> 1402.9 (1457.7) MB, 9.3 / 0 ms (+ 34.5 ms in 1 steps since last GC) [allocation failure] [incremental marking delaying mark-sweep].
   21740 ms: Mark-sweep 1402.9 (1457.7) -> 1401.6 (1457.7) MB, 1420.3 / 0 ms (+ 295.9 ms in 1199 steps since start of marking, biggest step 34.5 ms) [last resort gc].
   23137 ms: Mark-sweep 1401.6 (1457.7) -> 1401.5 (1457.7) MB, 1397.5 / 0 ms [last resort gc].

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x43f935e3ac1 <JS Object>
    2: keysForTree(aka keysForTree) [/Users/jamesarosen/Desktop/graphs/node_modules/broccoli/node_modules/broccoli-kitchen-sink-helpers/index.js:49] [pc=0x1d274e92b223] (this=0x43f93504189 <undefined>,fullPath=0x6d8b44e2d19 <String[983]: tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv1.tmp/0/tmp/funnel-input_base_path-DF6uadv...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - process out of memory
Abort trap: 6

The warning seems to have some sort of infinite loop in the path, which suggests a reason for the out-of-memory error.
I've tried this on node v0.12.0 and v5.7.1.

You can't watch the directory that contains 'tmp'. If you do, it will trigger recursive rebuilds as each file in tmp is also triggering a rebuild.
Change '.' to use 'tests' and update your includes to accommodate.

I assumed the include (which does not include tmp/) would have prevented that.
I'll try funnel('tests', { destDir: 'tests' })

Include is only restricting what is used, not what is watched.

Success. Thanks :)


[BUG] react-hotkeys increases bundle size with ~900kB

Describe the bug
Maybe it's a stretch calling this a bug, but react-hotkeys increased my app bundle size significantly, adding about 900kB unminified and uncompressed. I did not expect such a large size. Is there something that can be done to address this?
How are you using react hotkeys components? (HotKeys, GlobalHotKeys, IgnoreKeys etc)
GlobalHotKeys.
I'm importing it like so:
import {GlobalHotKeys} from "react-hotkeys"

I'm using browserify with uglifyify and common-shakeify.
Expected behavior
That the bundle size would not increase so much.
Platform (please complete the following information):

Version: 2.0.0-pre5
Browser: Not relevant here.
OS: MacOS.

Are you willing and able to create a PR request to fix this issue?
Maybe, depends if there's a clear fix (like doing tree-shaking of the source or similar).

It looks like the library links to cjs/react-hotkeys.production.min.js when in the production environment, and that is only 60kB. Maybe I was too quick to file an issue and it's a problem with my build system. However, this problem doesn't appear with other libraries, so maybe there's something to be done to make it easier to integrate react-hotkeys without the size jump.

My full build command is:
browserify -t babelify -t envify -t uglifyify -p common-shakeify sources/app.js | uglifyjs -m -c -o build/app-${VERSION}.js

Hey @markuswustenberg, thanks for expressing your concern.
I have tried to be diligent with the package size to keep it as small as possible, including stripping out comments and minifying/uglifying the code in the production builds. You can find out (not much) more in the Production optimizations section of the Readme.
I am also using rollup, which - as I understand it - provides the ability for ES6 tree shaking for ES6 applications. However, there is definitely the possibility that this has been configured incorrectly, or has since regressed in some way. It has been a long time since I set this up, that I no longer have any reliable recollection of the process or the behaviour. I would have to look back into it.
It's also been a long time since I worked with browserify and I dare say the tooling has moved on considerably from then. So I can be of little assistance on particulars of configuring your build system to pick up correct build.
I especially appreciate your feedback because I have not had much that relates to bundle size or how it is fitting into people's applications.
You didn't mention whether it was your application's development or production build that was absorbing the development build of react-hotkeys. This would be a helpful starting point. Also, I would be very grateful to hear your experience with using other packages and how that differs from react-hotkeys.
Finally, I am curious if the intent is to absorb the react-hotkeys production bundle into your application's production bundle (recommended) or whether you are trying to absorb the development build of react-hotkeys and then use your build chain to minify it (not recommended).

Thank you for the detailed answer! Maybe the solution is to use a different bundler than browserify. I've been reluctant to switch because I set it up once at project start and it's been working okay since then, but perhaps now is the time to try something different. The web world tools move fast…

You didn't mention whether it was your application's development or production build that was absorbing the development build of react-hotkeys. This would be a helpful starting point. Also, I would be very grateful to hear your experience with using other packages and how that differs from react-hotkeys.

The development build becomes 900kB bigger, the minified and compressed bundle gains only 150kB. But actually, I would expect packages to come in their source form, and that it's then up to the final application bundler to compress and minify as they see fit, and the library author shouldn't have to deal with that. The exception, of course, is when the library needs to go onto CDNs etc., but that is a different matter. Do you agree with this view?

Finally, I am curious if the intent is to absorb the react-hotkeys production bundle into your application's production bundle (recommended) or whether you are trying to absorb the development build of react-hotkeys and then use your build chain to minify it (not recommended).

In this case I would expect the production build to become part of my production bundle. But again, I don't understand why there is a production bundle in the library in the first place, see above. I may be completely wrong though, as I've never written a javascript library for distribution.
Again, thank you for having taken the time to answer me! It's much appreciated.

A small update: I've switched to webpack, and now the production bundle size only increases with 40kB. In development the size difference is still significant, but I can definitely live with that. I think we can close this issue now, but I'll leave that up to you to decide.

I would expect packages to come in their source form, and that it's then up to the final application bundler to compress and minify as they see fit, and the library author shouldn't have to deal with that

I'm afraid we disagree here. If I can summarise my understanding of the community conventions, it's the responsibility of the publishing libraries to do their own optimizations - because there is considerable variance between packages and the build tools they use, so it would be impossible for the consuming application to reliably build let alone meaningfully optimize all its dependencies. What is published by each library should instead be only what may need to be consumed. For react-hotkeys, this includes production-ready and development builds (that still include logging, comments and unminified code) for ES5 and ES6 (which should support tree shaking, if all is well).
However, this is definitely an area in whicih I still have much to learn. The different module systems and the best ways to build, optimize and deliver them can be a great deal to manage. I appreciate all feedback and guidance on improvements to the process and the documentation around it, to make it easier for people to get the library with the smallest footprint possible.
I'm pleased you found a resolution to your problem. I'll be closing this thread for now, but I welcome further discussion or future issues with more actionable suggestions.


[Flutter/Fuschia] Flutter/Fuschia build failing with the null safety flag flip CL

Running the CL to flip the null safety flag on the flutter-engine-linux-try bot  I'm seeing build failures.  From a quick look, my guess is that there are standalone scripts that will need to be opted out of null safety until the can be ported (e.g. by marking them with // @dart = 2.9.  Note that I have a script to automatically do this available here.
cc @zanderso @jakemac53

@chaselatta will take a look at this.

Added a fix in https://github.com/flutter/engine/pull/22009.

This has been fixed but I don't seem to be able to close the issue.

Thanks!  Closing out.


Loop requests to json file

I've noticed that the json stream config is requesting continually, is there a reason ?

Yes. If you generate the config file dynamically, hlsclient will handle new streams automatically.

this is a good Thing,  but several requests by second is a waste of bandwidth , is there a way to regulate this ?


require.extensions deprecated usage

Thanks for the module, it is simple to use and very useful.
The code internally uses require.extensions but it is actually deprecated and has been for quite a while.
In my case, this behavior conflicts with jest, that replaces require.extensions by an empty object.
Instead of having to use require.extensions, it would be nice to be able to pass an object (an array?) in the options to describe the extensions we would like to require. It would have two benefits, first partially remove the usage of a deprecated feature, and second allow to easily ignore files based on their extensions.
Its not hard, but if you're open for it, I can work on a PR.

@mt-richard-garnier I'm open to it - a PR adding an optional extensions option that would be used instead of require.extensions when provided sounds fine.
BTW - require.extensions may be deprecated but I highly doubt it will ever be removed, as too many things rely on it and nothing better was ever introduced to replace it. Most modules (like babel-register, for example) are using pirates which does this: https://github.com/ariporad/pirates/blob/master/src/index.js#L43

Thanks
I made a PR for this, you can find it here.

Published as 1.2.0 - thanks!

Thanks for your time !


CIV-4407 Not authorised to view the claim

JIRA link
https://tools.hmcts.net/jira/browse/CIV-4407
Change description
Develop 'You are not authorised to view the claim!' screen: /first-contact/access-denied
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

I am not sure whether this is complete. the idea is that we show this page every time we have 401 Not Authorise. similar to when we show 404 page not found and similar to error page. So the idea is that we show this page from whenever. And I don't see this in here. also there won't be authentication because just like in 404 and error page we don't need authentication to show this and we don't need a controller for this page.

This is the first AC though:
Given citizen has input security code
And The PIN is incorrect
And has the right format
When 'Continue' is selected
Then display 'You are not authorised to view the claim!' screen (first-contact/access-denied)

Yes, but during refinement we discussed that we are going to ensure that this page is shown whenever we have 401 so there is no logic in the controller that it will redirect or display the view. similar to how we do with errors. we story pointed it according to what we discussed and agreed with Sanpan


OCPBUGS-35918: fix: make lvms report a proper go.mod version

/test all

/test lvm-operator-e2e-aws-sno

/test lvm-operator-e2e-aws-sno

/jira refresh

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.00%. Comparing base (7d3ceed) to head (0e2188c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
+ Coverage   57.74%   58.00%   +0.26%
==========================================
  Files          53       53
  Lines        4215     4215
==========================================
+ Hits         2434     2445      +11
+ Misses       1536     1530       -6
+ Partials      245      240       -5

Files
Coverage Δ

api/v1alpha1/lvmcluster_webhook.go
84.36% <ø> (ø)

cmd/main.go
0.00% <ø> (ø)

cmd/operator/operator.go
0.00% <ø> (ø)

cmd/vgmanager/vgmanager.go
0.00% <ø> (ø)

internal/controllers/lvmcluster/controller.go
64.47% <ø> (+3.94%)
:arrow_up:

...ernal/controllers/lvmcluster/controller_watches.go
75.32% <ø> (ø)

...controllers/lvmcluster/resource/lvm_volumegroup.go
81.25% <ø> (ø)

...s/lvmcluster/resource/lvm_volumegroupnodestatus.go
77.50% <ø> (ø)

internal/controllers/lvmcluster/resource/scc.go
89.04% <ø> (ø)

...trollers/lvmcluster/resource/topolvm_csi_driver.go
76.00% <ø> (+4.00%)
:arrow_up:

... and 22 more

/override snyk-deps

/lgtm


Add DocumentEditor feature

Created a feature similar to Notes that allows users to edit the job document directly in the dashboard.
To Do:

[x] Clean up error message HTML (so it wraps)
[x] Mark saving errors in red!

@glotzerlab/signac-developers I'd appreciate some thoughts on the user interface for this Job Document Editor module. It uses ast.literal_eval to ensure that lists and dicts are preserved in the document.

Aren't there existing DOM elements for the modification of tree-like structures? As a user I would expect something more along these lines: http://www.htmldrive.net/items/show/203/CSS-and-Javascript-Style-your-Sitemaps-tree-menu

@csadorf Thanks for the feedback! It would be possible (but rather difficult) to do something like what you linked. There aren't really DOM elements made for this. It takes a considerable amount of customizing nested <ul> structures with JS/CSS since you have to deal with dynamic hiding/showing, and that's before we even add form fields. Hierarchical dynamic forms are super messy to write, from my experience. In general I prefer to stick to elements included in Bulma, for simplicity: https://bulma.io/documentation/

@bdice Got it. I think that the elements you are presenting are much better than nothing and I'm all for moving forward with that, I just think that they will be hard to work with when it comes to non-trivial hierarchical documents.


Disable barrier_3792 test when networking is disabled

The test doesn't make much sense with only one locality (and it hangs) so we disable it.

@hkaiser I don't think so, although they're a bit inconsistent. Some tests just "work" (usually do nothing) with networking disabled, and some are explicitly disabled. That could of course be cleaned up as well, but I'll leave that for another time. This one (barrier_3792) is causing pycicle builder with networking disabled to time out, so if it still times out there's probably more (that also means please don't merge before we see that that one is back).

All right, pycicle looks good for this (now I just need to figure out what's wrong with the clang 4 build...).


Allow co.vaicore.site and int.vaicore.site - Paramount+ Chromecast is broken as result

The domains co.vaicore.site and int.vaicore.site should be allowed, otherwise media casted from the Paramount+ app to a Chromecast will not load, as the player UI never loads.

Thank you for this Andrew @andritolion.
I've written this before here, several times.
It doesn't matter if listing a domain interferes with fundraising by the Holy Sisters relict of Mother Theresa of Calcutta. If the domain vehicles tracking, adware, or worse, it gets listed here. This project serves people who value privacy and online safety.
Now that said, those vaicore.site domains come to us from the AdAway list which is mostly dormant. We operate with a cached version of that list now.
I'm gonna remove those domains from our cache.  One of the other active curators will pick up this domain if it's still problematic.

Andrew @andritolion this will be active in the next release, coming shortly.

CC @sjhgvr

CC @sjhgvr

oisd sourced from: https://raw.githubusercontent.com/bigdargon/hostsVN/master/source/adservers-all.txt
Fixed. Thanks 👍

CC @hagezi

vaicore.site is tracking and belongs to Kochava (Measure Everything with Kochava): https://www.kochava.com/
It is used by Paramount, the blocking did not lead to problems so far, unfortunately I cannot test Chromcast. But someone who has the possibility to test it should verify this.
More Kochava Domains:
co.akisinn.info
co.dewrain.life
co.vaicore.site
co.vaicore.xyz
int.akisinn.info
int.akisinn.me
int.akisinn.site
int.dewrain.life
int.dewrain.site
int.dewrain.world
int.vaicore.site
int.vaicore.store
int.vaicore.xyz
int.vlancaa.site
int.vlancaa.fun
tok.vaicore.xyz
...

co.vaicore.site is also blocked in Cloudflare Secure DNS, for whatever reason.
ping @bigdargon @bongochong @Alex-302 (||co.vaicore.site^/ ||int.vaicore.site^)

I refer to blocking domain tracking elsewhere
https://github.com/AdguardTeam/AdguardFilters/issues/93230
https://github.com/AdAway/adaway.github.io/issues/281
https://github.com/r-a-y/mobile-hosts/issues/16

Thank you everybody.
I am adding the domains co.vaicore.site and int.vaicore.site to my ad-hoc list.

@hagezi we already have https://github.com/AdguardTeam/AdguardFilters/commit/c8f210061cbc2ce1c075f880a02d05b33520209c


Build Process

Hi, sorry for asking such a general question here, but since my Twitter-account is not confirmed on twitter you will probably not see my notifications there.
How is your development process in regards of flow-typing? To you directly type any annotation out as a comment or do you use "regular" flow-syntax and then use something like babel-plugin-transform-flow-comments before you publish to GitHub?
Also: You forgot do disable issues, again.


Mb collections

:books: Documentation preview :books:: https://mrmoe--137.org.readthedocs.build/en/137/

Codecov Report

Merging #137 (63d90aa) into master (7a459c8) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   98.55%   98.63%   +0.08%
==========================================
  Files          60       60
  Lines        3589     3802     +213
==========================================
+ Hits         3537     3750     +213
  Misses         52       52

Flag
Coverage Δ

network
37.06% <57.91%> (+2.73%)
:arrow_up:

unit
97.71% <87.50%> (-0.71%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


Scrollable Code Blocks?

I saw an issue where there were undesired scrollbars on code blocks (that's now fixed).
We're looking in the documentation, but can't find, for a way to enable scrollbars at a certain point. Like, maybe when the code goes over 20 lines, bam, institute a scrollbar.
Is this possible is the current state and we simply don't know how to find the documentation?
Or should this be a feature request, instead?
Thanks!


Create Chatbot Integrations: Fix issue #1269

Before

After

Can you review please? and merge PR? @SurajPratap10

Can you review please? and merge PR? @SurajPratap10

and assign with label gssoc and hacktoberfest??

It's not working @mansiruhil13 , you can check on the preview site

its' working

??


Getting Bounding Boxes

Hi
I want to get the coordinates of bounding boxes which I think is the value stored in y_true in data_generator.
But since it is a generator I am a bit confused.
How can I get only the bounding boxes coordinates after preproccess?
Thank you @qqwweee

Hi. Did you find a solution for saving the bounding boxes in one single file like a .h5 file or a mat file?


Export map with labels

@MikeTschudi the only thing I see is the mismatch with the t9n files

Thanks for checking. Can you review this PR, and then stomp on the strings via #210?

Thank you, @jmhauck


Use --stringify in remarshal

I've got this error: Error: Cannot convert data to JSON (Object of type datetime is not JSON serializable), coming from remarshal. Fixed it in this commit. Fix was tested in local environment

@Mr-Andersen Do you have an example of your stack.yaml / stack.yaml.lock that is triggering this problem?
I didn't realize this, but it appears there is some notion of dates within yaml files? https://yaml.org/spec/1.2.2/#tags  And by default remarshal tries to parse these and output actual dates in the resulting JSON, but fails because JSON doesn't have a concept of a date?
The --stringify option on remarshal has the following documentation (https://github.com/remarshal-project/remarshal):
  -k, --stringify       turn into strings: boolean and null keys and date-time
                        keys and values for JSON; boolean, date-time, and null
                        keys and null values for TOML

From this definition it sounds like in addition to turning date-time keys and values in strings, it also turns boolean and null keys into strings?  I guess this is alright and wouldn't cause a problem anywhere?

Do you have an example of your stack.yaml / stack.yaml.lock that is triggering this problem?

Here is the file: https://github.com/commercialhaskell/stackage-snapshots/blob/master/nightly/2024/11/9.yaml. I guess this is the problematic line.

I guess this is alright and wouldn't cause a problem anywhere?

YAML doesn't have non-string keys, as far as I know, so it should be OK.

Oh, to be clear: my stack.yaml was just resolver: nightly-2024-11-09. That's the important part :) You can reproduce it locally, I'm sure.

Oh, I tried switching back to LTS (lts-22.41) and your branch and it happens with LTS too. I'm guessing stackage adds this date now everywhere?

@Mr-Andersen Thanks a lot for fixing this and giving an example where it fails!
I submitted a bug upstream to remarshal, since it seems quite surprising that this --stringify option isn't the default: https://github.com/remarshal-project/remarshal/issues/53

Hmm, so it looks like remarshal only got this new --stringify argument starting in 0.17.0, so we'll have to put in a conditional to only include the --stringify argument in newer versions.  This is quite annoying.  I should really just rip out remarshal and go with a better tool.

@Mr-Andersen I pushed a commit only conditionally using --stringify if remarshal is new enough.  Can you confirm this works for your setup?

Yep, it works :)

Thanks!  I've released this as https://github.com/cdepillabout/stacklock2nix/releases/tag/v4.1.0

Thank you for making such simple and well-documented tool! A breath of fresh air after haskell.nix :)


Guard should implement StatefulGuard

correct me if I'm mistaken, but it seems to me the Guard class implements the Guard contract but it's effective implementation seems to be that of StatefulGuard. This prevents the StatefulGuard from being instantiated (I don't seem to find it's implementation either).
Is this intentional or is this a small mistake? As I see it, the Guard class could easily implement the StatefulGuard as it extends the Guard interface that the Guard class implements.

Thanks. Feel free to ask on slack and/or send a PR. Our issues aren't a direct contact to the core.

seems there's an issue in the documentation, it still mentions the Guard class in the dev and 5.2 documentation but that class has been renamed to SessionGuard, which does implement the StatefulGuard. That's probably what caused my confusion

If this is a bug, it needs to be open @GrahamCampbell

Related https://github.com/laravel/framework/issues/11465

This is not a bug, since Illuminate\Auth\SessionGuard already implements Illuminate\Contracts\Auth\StatefulGuard in 5.2. Maybe it should be fixed in 5.1.

I don't think we need to backport the auth changes to 5.1.

So the option to inject interfaces for authentication is simply removed since 5.2? What's the reasoning behind that decision?

It's because there are now multiple instances of the implementation in 5.2, so we can't guess which ones you want.

Shouldn't the system be somehow capable of figuring that out? Usually there's only a session auth and an API auth (I can't think of a scenario where there'd be more than one of each) and then you should be able to inject StatefulGuard for session auth for example.
It'd make it a lot more fluent to use than having to inject a factory as Taylor already suggested.


Add ability to reset serializer builder back to initial state

This just adds a static Reset() method to the serializer builder class. That method will clear all dictionaries and reset all properties to their initial state. The static constructor now calls Reset() so we can be sure the initialization logic is consistent.
I also added unit tests & updated the line refs in the documentation.
To verify the ability of the serializer builder to "Reset" I mostly just duplicated the tests that verify the functionality, but then Reset() the builder prior to running the approver. Then verified the ignore was not applied.
I also needed to add SerializerBuilder.Reset() at the beginning of each test run (in the test class constructor) otherwise it doesn't really target resetting the individual thing being reset. This part is a bit questionable so it may be appropriate to remove it.
Thank you for time and for taking a look at this!

@paulsavides thanks for this

This is now deployed. NuGet may take some time to make it available for download.

thank you for merging this @SimonCropp!


num pad on the keyboard does not work in VSCode when Chrome browser displays a notification

VSCode Version: Code 1.7.2 (7ba55c5860b152d999dda59393ca3ebeb1b5c85f, 2016-11-21T22:06:37.428Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

csharp
ms-vscode
1.5.3

Steps to Reproduce:

have google calendar opened in the Chrome browser (Version 54.0.2840.99 m (64-bit))
have a notification displayed by the Chrome browser, for example a meeting reminder
notice that in VSCode the num pad does not work, pressing any keys on the num pad results in moving the cursor around, just like the numlock would be off; at the same time, the num lock keys are working properly in other applications (notepad, word, edge browser)
close the Chrome notification, then switch to VSCode, now the num pad works properly.

@five70apps This is most weird.
Please open an issue against electron at https://github.com/electron/electron , as we don't deal with interpreting numlock on/off at our level, it could be an Electron or a Chromium issue.

This is an upstream issue (possibly within Chromium), and there are no known workarounds that we could implement on our side. This means there is no possible code change for us to do in VS Code sources to improve things.
To keep the number of issues in our inbox at a manageable level, we’re closing issues that have been on the backlog for a long time but haven’t gained traction or that are not actionable. Thank you for your time and understanding.


[Test Suite] rearrange error test cases to correct file

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

102 of 102 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 97.943%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
31051

Relevant Lines:
31703

💛  - Coveralls


docs: add doctesting to userguides

What I did
Add doctesting to the documentation userguides.

fixes: #657
How I did it

How to verify it

Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

side note: makes it a little harder to review since github does not render the markdowns as well, would be helpful to see a generated html file

side note: makes it a little harder to review since github does not render the markdowns as well, would be helpful to see a generated html file

you just have to build the docs locally and look at them! we could have docs get build and deployed on PRs, maybe by special command, or maybe if it detect changes to any docs file... that is cool but a bit over-the-top imo, just build them python build_docs.py and then pythom -m something something it is in the contrib.

side note: makes it a little harder to review since github does not render the markdowns as well, would be helpful to see a generated html file

you just have to build the docs locally and look at them! we could have docs get build and deployed on PRs, maybe by special command, or maybe if it detect changes to any docs file... that is cool but a bit over-the-top imo, just build them python build_docs.py and then pythom -m something something it is in the contrib.

punt this down the road, but would be nice to have a temporary render of each PR's docs updates to see it. can just deploy to a bucket


(fix): Navbar Active Element

Description
Currently, there is an issue with the navigation bar where the active element is not correctly highlighted based on the page the user is on. Specifically, when the user is on the Home page, the "Home" navigation item is not active, and when the user is on the Features page, the "Features" navigation item is also not active.
This creates confusion for users trying to determine their current location within the website
Expected Behavior:
The expected behavior is that the navigation bar should accurately reflect the page the user is on. When the user is on the Home page, the "Home" navigation item should be active, and when the user is on the Features page, the "Features" navigation item should be active.
This visual cue helps users understand their current position within the website's structure.
Additional Information:

The website is built using Next.js and utilizes NextUI components.
The issue should be resolved in a way that is compatible with NextUI components.

Hi, I have experience in nextjs but never using the NextUI components. Is it possible that i looked into this issue? thanks

Hey @fandok ! It's completely okay!
Basically, NextUi provides on prop isActive for the NavItems.
But you can do it manually as well, So Go ahead!

Hey @fandok ! It's completely okay!
Basically, NextUi provides on prop isActive for the NavItems.
But you can do it manually as well, So Go ahead!

Thank you so much ! I'll see what I can do

By the way, do you want for each navbar redirects to another page or another sections the same page?

It should redirect to another section of the same page.
You can skip Dashboard one! As we haven't decided much about that!

Hi I finished the solution. Lmk if it is expected or not for that. Thank you

assign me if still not done yet


Getting Illegal instruction (core dumped) after trying to run the application

I build a bundle for the x86_64 architecture here. After installing the bundle locally, I get the aforementioned error when trying to run it (with flatpak run --command=sh <ID>, then calling the binary from /app/bin; plain flatpak run outputs nothing).

Does a local build with flatpak-builder work as expected?

Yes.

Would you mind trying the latest version and enable the new verbose mode?

Here's the run and here's the bundle.


When things are playing, this module just decides that there is nothing playing.

Can you check the console to see any problems? Depending on which device are you using the Spotify API reports a "transition" state, were it is playing, but whats playing is not in the response. There I needed to decide between the module retaining the last media item or changing state.Still, it almost never an issue, since its just a momentary thing. If you manage to catch anything in the web console or the backend console please send it here


SEPG Automated Release - v3.0.0

SEPG Details
Release Build Link: http://sou-jenkins2.swinfra.net:8080/job/Auto-Release/328/
Build Token: github.com/CAFapi/buildenv-dotnet-image/master/a87383a7520b9b3b9f6105082bfecc60f92a91d5
Versioning Behaviour: Roll on to next minor
Artifacts For Release
Docker

cafapi/buildenv-dotnet:3.0.0 (Static Tag)
cafapi/buildenv-dotnet:3.0 (Dynamic Tag)
cafapi/buildenv-dotnet:3 (Dynamic Tag)
cafapi/buildenv-dotnet:latest (Dynamic Tag)

Dependent Downstream Repositories
The following jobs contain have a dependency on the repository being release:

CAFapi/buildenv-dotnet-mono-image:US361030

 Build Stage
Action
Status

Release Checks
completed
:heavy_check_mark:

Gather Release Data

:white_small_square:

QA Documentation Site Deployment

:white_small_square:

QA Deployment Branch Promotion

:white_small_square:

Docker Image Promotion

:white_small_square:

Maven Artifact Promotion (Closed Source)

:white_small_square:

NuGet Artifact Promotion

:white_small_square:

Artifactory Release Artifact Tagging

:white_small_square:

Generic Artifact Promotion

:white_small_square:

Maven Artifact Promotion (Open Source)

:white_small_square:

Maven Staging Repository Removal (Open Source)

:white_small_square:

Git Tagging

:white_small_square:

Git Release

:white_small_square:

Git Release Asset Deployment

:white_small_square:

Pull Request Merge

:white_small_square:

Release Branch Deletion

:white_small_square:

view the build log here


Travis CI Integration

Similar to the .travis.yml here we want CI integration.
Compiling libsweep is be a good start, properly testing all sub-projects would be even better.
Tasks:

[ ] enable Travis for this repository
[ ] add a .travis.yml config
[ ] compile libsweep.so
[ ] build dummy libsweep.so (make dummy) and test projects against

repo public
travis enabled


Why can't find  the class? "kernel = new JavaKernel();"

Exception in thread "main" java.lang.NoClassDefFoundError: jdk/jshell/EvalException
at io.github.spencerpark.ijava.IJava.main(IJava.java:104)
Caused by: java.lang.ClassNotFoundException: jdk.jshell.EvalException
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(Unknown Source)
at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
... 1 more

This is very strange. Is this error preventing you from starting the kernel or does it appear when you are running some code in the kernel that is trying to start up a new kernel. I am not sure why you are getting an EvalException if the situation is the former.
If this is indeed code in a notebook or similar, could you include the code here along with the version of the kernel that is causing the exception? Thanks!

Seeing the same error after installing from source, jupyter hangs indefinitely:
alenb@ALEN-BOOK ~
03:46:34 7> java -version
java version "10.0.2" 2018-07-17
Java(TM) SE Runtime Environment 18.3 (build 10.0.2+13)
Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.2+13, mixed mode)
alenb@ALEN-BOOK ~
03:46:38 8> python --version
Python 3.6.5 :: Anaconda, Inc.
alenb@ALEN-BOOK ~
03:46:44 9> jupyter --version
4.4.0
alenb@ALEN-BOOK ~
03:46:53 10> jupyter kernelspec list
Available kernels:
  java       C:\Users\alenb\AppData\Roaming\jupyter\kernels\java
  python3    C:\Users\alenb\Anaconda3\share\jupyter\kernels\python3
alenb@ALEN-BOOK ~
03:47:06 11> jupyter console --kernel=java
Exception in thread "main" java.lang.NoClassDefFoundError: jdk/jshell/EvalException
        at io.github.spencerpark.ijava.IJava.main(IJava.java:104)
Caused by: java.lang.ClassNotFoundException: jdk.jshell.EvalException
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(Unknown Source)
        at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
        ... 1 more

Ah my apologies, I read the original stacktrace wrong. The exception was a NoClassDefFoundError not an EvalException. This is the case when using the jre and not the jdk as jshell is in the jdk.jshell module.
On your original (broken) setup, if you still have everything ready to go, would you mind running java --list-modules | findstr "jdk.jshell" and assert that it indeed outputs<EMAIL_ADDRESS>If not that would imply that you have the jre 10 in your path and not jdk.

Please, How to use the jdk as jshell instead of jre

@cyrillemidingoyi The you can get a jdk build from https://jdk.java.net/ (which looks like jdk 11 is the general release at the time of writing this). Then find where it is installed and make sure to add the bin folder in the installation to the front of your PATH.
For example on windows I have jdk 10 installed in C:\Program Files\Java\jdk-10.0.1 so to make sure I am using that one I can permanently set the PATH via editing the system environment variables (Google this part if you aren't sure) or in cmd before running jupyter notebook, set the path with set PATH="C:\Program Files\Java\jdk-10.0.1\bin";%PATH%.
On some unix like environment it should be very similar but use export PATH=<path to jdk>/bin:$PATH instead.
You want to make sure that the java command you are running is the one in that bin folder for the correct jdk.

Thanks SpencerPark. It's working now.

On macos. It solved for me by adding this to ~/.bash_profile
export JAVA_HOME="$(/usr/libexec/java_home)"
export PATH=$JAVA_HOME/bin:$PATH

If there is specific version like to use
export JAVA_HOME="$(/usr/libexec/java_home -v 11)"
export PATH=$JAVA_HOME/bin:$PATH


 This gives us 100% confidence that the images in use have been validated (by us), and gives us the facility to scan all images for vulnerabilities using the "clair" integration with harbor.io
For example, check this out:
root@cn1:~# kubectl get pods --all-namespaces -o jsonpath="{..image}" |tr -s '[[:space:]]' '\n' |sort |uniq -c
     28 registry-internal.elpenguino.net/library/calico-cni:v3.8.0
      2 registry-internal.elpenguino.net/library/calico-kube-controllers:v3.8.0
     14 registry-internal.elpenguino.net/library/calico-node:v3.8.0
     14 registry-internal.elpenguino.net/library/calico-pod2daemon-flexvol:v3.8.0
      8 registry-internal.elpenguino.net/library/ceph:v14.2.2-20190722
      2 registry-internal.elpenguino.net/library/cert-manager-cainjector:v0.8.1
      2 registry-internal.elpenguino.net/library/cert-manager-controller:v0.8.1
      2 registry-internal.elpenguino.net/library/cert-manager-webhook:v0.8.1
      6 registry-internal.elpenguino.net/library/coredns:1.3.1
      2 registry-internal.elpenguino.net/library/external-dns:latest
      8 registry-internal.elpenguino.net/library/fluent-bit:1.2.1
     32 registry-internal.elpenguino.net/library/hyperkube:v1.14.2
      2 registry-internal.elpenguino.net/library/kubelet-rubber-stamp-amd64:latest
      2 registry-internal.elpenguino.net/library/metallb-controller:master
      8 registry-internal.elpenguino.net/library/metallb-speaker:master
      4 registry-internal.elpenguino.net/library/nginx-ingress-controller:0.24.1
      2 registry-internal.elpenguino.net/library/rook-ceph:master
      6 registry-internal.elpenguino.net/library/rook-ceph:v1.0.4
root@cn1:~#

This PR introduces optional params and logic which allow the operator to explicitly override the container images for all of the core KRIB elements, so that these can be pulled from a local registry. (We maintain an ansible playbook responsible for pulling down images based on sha, retagging, and pushing them into a local harbor.io registry in preparation)
Cheers!
D

@funkypenguin - you will need to rebase on the latest tree.  I've been addressing some issues for the simple just run me clusters.  For example, kris-dev-reset wouldn't run unless you had consul, vault, and others configured.  The krib-config wouldn't work because krib/master-vip-address or whatever isn't really a determiner of HA - master-count is.
Please rebase these on top of the latest master.


Stage 4 connections part 1 (take 2)

This replaces #522. I messed up my git history by cherrypicking commits onto a new branch without rebasing correctly, so I ended up with some duplicated commits that had different commit hashes that git thought were different. @Carifio24 kindly helped sort this all out.
This updates the Stage 4 Line Draw Viewer & the Layer Toggle. We're working towards making available and displaying specific layers and buttons at the right times. This also adds the best fit galaxy.

There are still a few duplicated commits here - I will take a stab at recreating my commits manually onto main..

This is replaced by #524.


Pen Tablet: can't click on menu items

Tested versions

Reproducible in 4.1, 4.2.x, and 4.3dev5; XP-PEN  Artist Pro 16TP

System information
XP-Pen Tablet Artist Pro 16TP - Godot v4.3.dev5 - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; <IP_ADDRESS>26) - Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 Threads)
Issue description
The buttons and the items in the menu lists cannot be clicked
Note that the issue is solved when disabling Windows Ink. But then the Viewport Navigation Gizmo is unusable.
I took some videos here, so you can better see what is happening:
https://github.com/godotengine/godot/assets/10520249/a2893e43-3bf0-4297-a7ce-ae531774c995
Steps to reproduce
Open editor, click on a "Editor", try to click on any menu items (see video).
Minimal reproduction project (MRP)
You just need to open godot on an empty project.

CC @bruvzg


mikro-orm dependency needed?

I don't see it used on the code, is it from a past experiment before typeorm?

As you said, mikro-orm is not necessary to be devDependencies this moment. I am putting it there just for future experimentation.


Can you put g2plot.min.js in the nuget package

In this way, users can directly use  to reference

+1


[flutter_test] bump meta version

Steps to Reproduce

add to pubspec any package that depend from

  meta: ^1.8.0

run flutter pub get

Expected results:
flutter_test dependencies should be up-to-date
Actual results:
Running "flutter pub get" in <APP>...
Because every version of flutter_test from sdk depends on meta 1.7.0 and <PACKAGE> >=0.1.0+4 depends on meta ^1.8.0, flutter_test from sdk is incompatible with <PACKAGE> >=0.1.0+4.
So, because <APP> depends on both <PACKAGE> ^1.0.0 and flutter_test from sdk, version solving failed.
pub get failed (1; So, because <APP> depends on both <PACKAGE> ^1.0.0 and flutter_test from sdk, version solving failed.)
exit code 1

workaround
 dependency_overrides:
   meta: ^<some version>

note that does not work with packages published on pub.dev
Package validation found the following error:
* Your pubspec.yaml must not override non-dev dependencies.
  This ensures you test your package against the same versions of its dependencies
  that users will have when they use it.
Sorry, your package is missing a requirement and can't be published yet.
For more information, see: https://dart.dev/tools/pub/cmd/pub-lish.

doctor
[✓] Flutter (Channel stable, 3.0.5, on macOS 12.4 21F79 darwin-arm, locale en-EE)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.69.1)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

• No issues found!

removing flutter_test dependency (for science)
reveals
Resolving dependencies in ... (1.7s)
Because <PACKAGE> >=0.1.0+4 depends on meta ^1.8.0 and every version of flutter from sdk depends on meta 1.7.0, <PACKAGE> >=0.1.0+4 is incompatible with flutter from sdk.
So, because yak_tween depends on both flutter from sdk and <PACKAGE> ^1.0.0, version solving failed.

retitlying the issue

please consider the misleading error message part of the issue

It already has been. It's best to test version conflicts against the latest master, not stable, as dependencies are rolled often. (Almost every issue that I've seen requesting a dependency update was already obsolete when it was filed.)

please consider the misleading error message part of the issue

Requests for changes to pub resolver output (such as showing all sources of a conflict instead of just one, which I assume is what you are looking for here) would need to be filed against pub, not Flutter.


Create your own Fiori Launchpad

Tutorial URL: https://developers.sap.com/tutorials/teched-2017-fiori-create.html
Please specify the step you are referring to - Step 8 - Update the SAPUI5 version
After selection "Custom" - and waiting for minutes - the field for selecting 1.40.18 is blank / there are no values to select.
What to do?

This specific issue appears to be a Portal bug which will require opening a SAP ticket to be addresses.  I'm assigning this to Marius for further investigation.

Hi @mts2605,
thanks for your patience. As you might have noticed, this tutorial is outdated.
We're currently evaluating if we should update it or simply remove it for good.
For now, I would suggest that you just skip this step. It seems that this step was added as a workaround for an issue in SAPUI5. This issue might have been resolved by now as the most recent SAPUI5 version is 1.65.
Thanks,
Marius

@IObert I am closing the issue, since @mts2605 can proceed, but has the tutorial been updated?

We haven't prioritized this issue yet. Not sure when we're going to aim for the update as it is a larger task


Custom dataset

Hi there!
I was wondering a bit more about the custom dataset part. I am currently working with molecules and the intensities that they are emitting in certain wavelengths. At my disposal, I have the SMILES, wavelengths, and intensities. I have checked with other models that use a .csv method of representing the input data, where the header is smiles,200,201,...,500 for instance and each row starts with a SMILES, followed up by the intensities at the corresponding wavelengths.
My question is if we could implement something similar or how we could use personal data? This is mostly due to the lack of NIST data and the personal interest to apply on own data.

Hi itaha01,
Are you trying to train a model on your own MS/MS data, or make predictions using a pretrained model?
If it's the former, there isn't really code in the repo supporting this use case. You could pretty easily modify the code to support this though.
If it's the latter, we do provide weights for a model that is trained on open-source data from MoNA (MassBank of North America), however the performance will be a lot worse than what we report in the paper. This use case is demonstrated in the README (Section "Using a Pretrained Model to Make Predictions"). NIST prohibits the release of parameters for models trained on its spectral libraries, so unfortunately we cannot release the checkpoints that were used in our experiments.

Hi and thanks for your quick reply!
Yes indeed, I am trying to train a model on my own MS/MS data. I was more or less wondering what was required from my side to ensure what the input data had. My goal is to predict UV-spectra given SMILES and intensities for specific wavelengths.
I had a look at your repo and noticed the usage of MoNA and NIST and was wondering if my data had to be formated like those.
Best regards,
itaha01

I'm not sure how similar UV-Vis spectra are to MS/MS spectra. For example, with modern instruments MS/MS spectra tend to have really sharp peaks, which makes a centroided representation more reasonable. This representation might not be suitable for UV-Vis.
I would look at projects that are about UV-Vis prediction, for example this one (just the first on that I found off Google).

I see, thank you very much for you expert input!


Roadmap

Readme.md
These should all be in the main readme file
Required

[x] A title header of one depth: # example-header
[ ] Buttons

[ ] All repos: irc, made by Protocol Labs, IPFS project
[ ] Language repos: langdoc references, code style, dependencies, coverage
[ ] Discussion repos: TODO

[ ] Contribute banner with link to  global contribute.md
[ ] A clear description in the GitHub description field, of over 150 characters.
[ ] A license section which references and/or copies the license file
[ ] A contribute section, with a link to a contribute.md if there are more specialized instructions (for instance, language styles, which should link to a language contribution guide in ipfs/community.

Options

[ ] Usage section
[ ] Link to questions
[ ] Travis
[ ] CI

Repository requirements

[ ] License file
[ ] Contribute.md
[ ] GitHub description

Title can now be validated using wooorm/remark and RichardLitt/remark-title.

Note: Keep up to date and check with https://github.com/ipfs/project-repos/issues/1.

After looking through my/other people's repos i think

A clear description in the GitHub description field, of over 150 characters.

Should be changed to

A clear description in the GitHub description field

Changed. Working on a module for getting and setting that.

Created remark-lint-appropriate-heading to make sure that the heading matches the dir name of the Readme. Works for top level readmes.

I am going to track the Linter and the Generator in their appropriate issues. Since the spec is done, and those are the main things to do, I am going to close this issue for now. Reopen to discuss.

I have edited the Roadmap in the first comment. Let's go!


Coloured handseals

Coloured versions for the twelve handseals currently in use. The .zip files include separate versions for Geisha and Shadow Ribbon layouts. If they are accepted for use, I can convert them to suit current Blue Scroll (and possibly Classic Blue if it's not obsolete). Is it possible to have each layout use a separate set?
Geisha.zip
Shadow Ribbon.zip

A little rough around the edges but. 🐱

Ooh I like this. We need to update the Battle UI to be more layout-configurable but then this is totally doable


Add update informer

Problem
Add update information logic so that users will get notified about new project releases.
Proposed Solution
Perhaps https://github.com/mgrachev/update-informer
Notes
No response

We have decided this doesn't make a lot of sense, given how many things depend on particular Scarb versions


Usage instruction isn't correct

Android Studio shows error in the line:
        ...
        app:ilp_entryImages="@array/array_name"/>

error: unbound prefix.

I removed "app:" prefix and now I'm getting runtime error:
android.view.InflateException: Binary XML file line #36: Error inflating class fragment

I removed "app:" prefix to compile it. And now I don't see any images.


Bump vitest peerDependency

Currently it's https://github.com/vitest-dev/vitest: "^0.16.0" which fails when trying to install together with latest vitest 0.29.x

It might be good to bump it to "^0.16" so it automatically accepts any 0.16 <= version < 1.0. It seems like Vitest updates pretty frequently - I just started using it a couple weeks ago and it's already gone up a minor version and two patch versions.

Created PR for this: https://github.com/chaance/vitest-dom/pull/3

Resolved in #3, I'll cut a release now.


About custom dataset

Hi, thank you for sharing source code, it's a fancy work!
I have a question about using custom dasaset. Since I have some RGBD dataset, I composed it to .sens file like BundleFusion (e.g. apt0.sens). But it couldn't work well using render_scan.py.
Any suggestion or is  there a detail about how your .sens file composed?
Thank you~

https://github.com/ScanNet/ScanNet/tree/master/SensReader/c%2B%2B


Add rule for changed_when:False

Add rule for changed_when:False

This is not error. changed_when: False is usable for some cases like asynchronous tasks run.


There are 2 outline button section in the website . They both are same .

can you please review that one ????

Can you assign me this task?

Thank you for noticing that @dsnehasish74 .
Yes @SARVESHKHANDELWAL you can work on it.

Can you please help ,as i didin't find the sidenav bar HTML code ,can you tell me in which file/folder contains that code.

This side nav is not hard coded ................ you just go to assests/buttons-examples.js and there you will find a list where all the button types are mentioned there you can see outline button types will be 2 times remove one of them .................... thats all .................. Hope you understand

Yes, I got it. Thanks.

I have made the PR :+1: #859 .

I have made the PR +1 #888 .


unicharset_extractor : undefined symbol

Hi,
I am getting the below error in the tesseract training process
unicharset_extractor:symbol lookup error:unicharset_extractor:undefined symbol: _ZNK10UNICHARSET12save_to_fileEP8_IO_FILE
Can someone please help me with this issue?

Please provide detail (OS detail, tesseract version, how you compile, logs...)

ubuntu version 15
tesseract version 3.03
i just gave the command
unicharset_extractor eng.Arial.exp0.box
as mentioned in the guide

use the current version. Before compiling from source remove all other version of tesseract.

I installed ubuntu only yesterday on my virtual machine just to work on tesseract.I downloaded tesseract from Github and built from source according to the instructions on Github.

Ubuntu has recent tesseract packages
3.03 version is old - not officially produced version. Nobody will look at it.

Ok i removed tesseract and rebuilt it from source.It's working now thanks


Foreign quotes support?

It would be nice if Options::ENABLE_SMART_PUNCTUATION: turned ' and " into localized quotes.
An additional way to switch this on (Options::ENABLE_LOCALISED_QUOTES?) and select a supported language would be needed too, I guess.
No need to add detection of primary/secondary. The Markdown author itself should have control over this implcitly by using single/double quotes.

This is a relatively big feature, and I think it is out of the scope of the basic pulldown-cmark renderer.
Note the aim of this crate is basically parse Markdown, and the renderer is only a basic utility showing what can be do. An external renderer using pulldown-cmark is welcome, and this feature would be useful there, check #645.


Cannot generate java binding code

-replace -example CMake    -flat-output-dir  -d idl\ -language java    D:\workspace-sim\Fast-DDS-Gen\idl\sonsor.idl
when I user these params to generate for java code.there is a lot of errors, did this program support for java?

the .idl file content is
module SensorDataModule {
    struct TemperatureReading {
        string location;
        double degreesCelsius;
    };

    struct HumidityReading {
        string location;
        double percentHumidity;
    };
    struct PressureReading {
        string location;
        double millibars;
    };

};

Closing in favor of
https://github.com/eProsima/Fast-DDS/discussions/5022


(PUP-6738) Update version to 4.7.1 post release of 4.7.0

After the agent 1.7 release, the version for the next puppet needs to be
bumped

:+1:


Repository on shaman.ceph.com

What is needed to add new tcmu-runner 1.4.0-rc1 to the repository at shaman.ceph.com?
If possible, please add a new release to the repository.
There's only version 1.3.0 = (

How soon?

End of August at the latest.

@mikechristie thanks for answer

@mikechristie august is over, but there is no news about the new release :(

We are still working on fixes.
Specifically the majors ones are:

https://github.com/open-iscsi/tcmu-runner/pull/452
https://github.com/open-iscsi/tcmu-runner/pull/477

I am hoping to be done in 2 weeks.


 So we're going to hoist our data-fetching higher up in the tree and do two fetches: 1 for unauthenticated data like Language, Phrase, and Translation; and 2 for user data like Deck, Card, and Review.
I was originally trying to do this with prefetchQueries, using an invisible client-side component in the layout, and the queryFn would fetch the data and then loop through it and populate all these other query cache entries, but then I read this blog post suggesting to use context as a dependency injection tool and I thought... that sounds good. And the example is right there... so I'm doing it this way now.
Let's see how it goes!

This is only 1/3 of the way done, but it works, it does data dependency injection in a client side comonent loaded in the language-specific layout. Meanwhile, the work is kind of necessitating some changes, or just making some little improvements obvious, so I'm going to merge this into main and keep working in smaller increments so that main and other branches also get the little bonuses sprinkled throughout this ongoing work.


docs(video-player): add story

Related Ticket(s)
Refs #4096.
Changelog
New

Storybook story for <dds-video-player>.
CodeSandbox example for <dds-video-player>.

Thank you @asudoh !
We may want to add a percy: { skip: true } to the video player story, so we don't introduce any false positives there. We do the same for the VideoPlayer for React.

Good point @jeffchew - Updated.


Replacement for load_from_csv?

Hi!
Thanks for a great pacakage.
I notice that StatsManager.load_from_csv now has a deprectation warning. What is now the recommended way to avoid re-running the costly (20 minutes on my 1h20 x265 video) scene detection, please?
I have a stats file created with the CLI:
scenedetect --input myfile.mkv --stats adaptive-stats.csv detect-adaptive

and I would  like to load that adaptative-stats.csv file into a SceneManager to do the actual scene detection.   load_from_csv sounded promising :)
Thanks for any help, and a great tool!
Environment:
[PySceneDetect] PySceneDetect 0.6.2

System Info
------------------------------------------------------------
OS           macOS-13.4.1-arm64-arm-64bit
Python       3.11.4

Packages
------------------------------------------------------------
av           Not Installed
click        8.1.6
cv2          4.8.0
moviepy      Not Installed
numpy        1.25.1
platformdirs 3.9.1
scenedetect  0.6.2
tqdm         4.65.0

Tools
------------------------------------------------------------
ffmpeg       6.0
mkvmerge     v77.0 ('Elemental') 64-bit

I am seeing in the deprecation commit the notes:

Equivalent functionality with much better performance could be obtained for most use cases by seeking instead.

Is this seeking alternative something that I can already use, please (and how?), or am I better (in the current moment) to use load_from_csv ?
Thanks for any pointer!

Mm, reading AdaptiveDetector.process_frame I now understand that the stats CSV is not used to speed things up anymore anyway.
But the commit introducing online calculation (smart!) mentions the ability to skip/seek, as did the deprecation commit mentioned above.
How could I use that new skip/seek trick, based on saved CSV of the stats, please?

(and yes, I think I'm absolutely spending an hour diving into the code just to avoid waiting 20 minutes again to parse my video 😅 )

@jucor unfortunately I don't have a replacement planned for this at this time.  The main reason for removing this feature was that it just wasn't well thought out before I introduced it - it became very difficult to scale the CSV format as a cache for detector calculations as the number of dimensions/parameters per detector rose.  This led to a bunch of weird bugs and edge cases that for a long time went unnoticed, so felt it was time to rework how this caching happens.
The latest version made a lot of performance improvements to scanning - are you disabling downscaling in your case, or is most of the time processing the video spent just decoding each frame?
I do apologize for the current status quo regarding loading/caching frame metrics.  In the long term, I want to look into having each detector itself be responsible for caching calculations, and reserve the statsfile purely for statistical/human readable analysis.   That was the intended purpose, but it kind of unravelled when attempting to re-use the same format as a cache for detection calculations.

Regarding seeking/skipping, I don't think that applies for your particular use case since you want to re-process the entire video.  Instead it might be worth just hacking a ContentDetector to load frame scores from a specified CSV file instead of calculating them.  I do apologize for this making things slower for you in the interim - if you end up making any progress on that, feel free to submit a PR for it, we did something similar for using the output of list-scenes recently by creating a pseudo-detector (SceneLoader).
You could do this pretty easily by creating a new detector that derives from ContentDetector, and override the _calculate_frame_score method to return the score for that frame loaded from disk instead of re-calculating it.
In the long run, I think you raise some great points.  I want to look into having ContentDetector allow specifying a file to use as a cache, just not sure what the correct format would be.  The statsfile would effectively be derived from the cache, instead of being the cache.

Please don't apologize! It's a terrific tool :) :)
Most of the time is spent processing the frames, in this example. But I've just bit the bullet and waited 20 minutes, and it was good enough for what I needed to do, so no problem on my end any more!

Taking a look at this with a fresh set of eyes it's probably unwise to pursue re-adding this until a well thought out API is in place.  The issue is how the current interface for a SceneDetector is defined.  If this continues to become a burden for some workflows it can be re-prioritized.  The v0.7 API definitely needs to take this into account, so that's where I would ideally like to target this for.

Pleasure! Thanks for the hard work and for keeping thinking about it. Makes sense to prioritize as you did :)


Windows support - help doesn't work

Running elm-make --help in Windows doesn't do anything, since it's shelling out to man, which is a *nix program.

Thanks for reporting! Do you use cmd or a Unix-flavored shell like Git Bash or cygwin?
While I don’t have a windows box to test this, I remember calling git help … or npm help … in Git Bash (which is basically msys) on friends’ computers. Both commands worked by displaying the manpage rendered as HTML in a browser. Both commands spawn man under the hood
A Windows alternative to man compatible with manpage files seems to be the best path forward. But since the manpage is just rendered from the readme, we could also render a plain text fallback from the same source.

I typically use PowerShell, but even using the bash or mintty shells that come with Git, I get an error that "man" is not recognized.
I believe git help just opens pre-rendered HTML, I don't think it's processing a manfile in real time.

Alright, I believe the only reasonable thing is to render a plain text fallback then. I’ll try to tackle this on Wendesday – I’m afraid I won’t have time before then.


Some events returned to Splunk have a semicolon and random string appended to the file name

There are some events getting returned to Splunk that have a semicolon and a random string appended to the file name.

The object_path parameter comes from the pathname field in pulsar.

So have we decided these are not real filenames?

I don't know. I would suspect not, but it's certainly possible.

This issue was moved to hubblestack/hubble-salt#23


Event time info not showing when event starts at midnight

Hi @nature-li,
Please share your code and develop your question.
I don't know what you are talking about right now.

Hi @antoniandre ,
Sorry for the unclear issue. I mean when I make time-from = 0,  time-to = 24 * 60, time-step=30, time=true. And I have 48 events every 30 minutes in a whole day.  In the week view I expect I can get 00:00 - 00:30 in the first row, 00:30 - 01:00 in the second row,  01:00-01:30 in the third row. But the first row is empty. From the second row on, it works like 00:30 - 01:00, 01:00 - 01:30 ...

Hi @nature-li,
Thanks for reporting this bug.
I have fixed it in version 1.50.3
Here is a working codepen after fix with the initial same issue you reported.
https://codepen.io/antoniandre/pen/gyXdar?editors=1010
Hope it helps. Please close if solved.

Hi @antoniandre,
I installed the 1.50.3 version and it works for me. Thank you fix the bug.


auto_reset=True produces environment without randomness

Currently, when creating an environment, auto_reset defaults to True. However, when digging into the AutoResetWrapper class, I found that the auto_reset behavior simply resets the environment to first_qp and first_obs, which is the initial state after the last manual reset. Thus, auto_reset repeats the same initial state for every episode, which may have a negative impact on training. I wonder if such behavior is intended, or did I misunderstand something?

Interesting! Could you provide a repro of this behavior?  If you're referring to these lines:
def reset(self, rng: jp.ndarray) -> brax_env.State:
    state = self.env.reset(rng)
    state.info['first_qp'] = state.qp
    state.info['first_obs'] = state.obs
    return state

All that is happening here is that state is recording the first qp of the trajectory and the first observation of the trajectoryi n the info dict so that it can be used elsewhere.  state is properly being reset here, as far as I can tell

Thanks for your reply. But actually, my question concerns the step method. In my understanding, AutoReset means that when a Brax env is done, it is automatically reset, so that a user does not need to call reset manually (except for the initial reset). For a vectorized env, AutoReset is a very convenient wrapper. However, instead of properly resetting env with randomness, the step method simply reset the environment to first_qp and first_obs you mentioned in the reset method, and the wrapped env's reset method is never called.
A minimal repro would be
>>> import brax.envs
>>> env = brax.envs.create_gym_env('inverted_pendulum', episode_length=3)
>>> env.seed(0)
>>> env.reset()
DeviceArray([ 1.000000e-01,  1.000000e+00,  0.000000e+00,  0.000000e+00,
              0.000000e+00,  9.823757e-03,  0.000000e+00,  0.000000e+00,
              0.000000e+00, -6.298446e-04], dtype=float32)
>>> env.reset()  # Different from above, as expected
DeviceArray([ 0.1       ,  1.        ,  0.        ,  0.        ,
              0.        , -0.0015702 ,  0.        ,  0.        ,
              0.        ,  0.00274388], dtype=float32)
>>> env.step(env.action_space.sample() * 0.0)[0]
DeviceArray([ 1.0000000e-01,  1.0000000e+00,  0.0000000e+00,
              0.0000000e+00,  0.0000000e+00, -1.6629273e-03,
              3.5764193e-04,  0.0000000e+00, -0.0000000e+00,
              2.1486760e-03], dtype=float32)
>>> env.step(env.action_space.sample() * 0.0)[0]
DeviceArray([ 1.0000000e-01,  1.0000000e+00,  0.0000000e+00,
              0.0000000e+00,  0.0000000e+00, -1.7784013e-03,
              3.0605256e-04,  0.0000000e+00, -0.0000000e+00,
              3.9656470e-03], dtype=float32)
>>> env.step(env.action_space.sample() * 0.0)[0]  # episode_length reaches, auto reset, observation identical to last reset
DeviceArray([ 0.1       ,  1.        ,  0.        ,  0.        ,
              0.        , -0.0015702 ,  0.        ,  0.        ,
              0.        ,  0.00274388], dtype=float32)

Hi @jjyyxx !  Yes indeed, this is by design.  Because our environments are vectorized, each step sets some variable number of environments to done.  Calculating new reset states at each step would be very expensive, so we compromise by reusing reset states.
For RL use cases with large batch sizes that we use, this does not impact training performance at all.  2048 randomly initialized environments produces enough initial randomness that it's OK if we sometimes revisit those states.
Let us know if you find evidence otherwise.  We could always introduce a mechanism to "refresh" reset states every now and then during training - like in between evals - but I doubt we need such a thing.

Thanks for your clarification. The point about batch randomness makes sense. When experimenting with halfcheetah though, reset takes much less time than step, which may not be that "expensive" (but it's on CPU device). Nevertheless, I will close the issue for now.


Feature.implement pool methods 9

@mattgreene
Fixes: #9
This code was necessary for the test of pool creation and deletion in the f5-openstack-lbaasv2-driver repo.   Please run the tests in that repo to see the new utility code in this repo in action.

Close the other PR first, if this is merged both will close.


Make indentationRules case-insensitive (#81)

indentationRules determine if the next line is indented whenever you press enter. These are case sensitive by default (triggering on lower-case only), which does not work well if you write VHDL with upper-case keywords. VHDL itself is not case sensitive.
This pull requests makes the rules case-insensitive.

LGTM. Thanks for the nice addition!


Add degree attribute to nodes

That way, we can proportion the sizes of the nodes on their degree, which SecureHIVTrace does by default.

Resolved by 75b162ae841e258bc53f530e967bec17adbe517d


Explicitly disable libpsl for curl

Risk: Low
Testing: test/dependencies/curl_test.cc tests that libpsl is disabled
On my workstation (running Arch Linux) I had a linker error:
ld.lld: error: undefined symbol: psl_is_cookie_domain_acceptable
>>> referenced by cookie.c
>>>               cookie.c.o:(Curl_cookie_add) in archive bazel-out/k8-opt/bin/external/envoy/bazel/foreign_cc/curl/lib/libcurl.a
...

In test/dependencies/curl_test.cc I see that it is expected that curl does not use libpsl.
Apparently did curl somehow compile with libpsl support but failed to link against it since it is not included in Envoy. Explicitly disabling libpsl fixed my problem.
Signed-off-by: Jonatan Vela<EMAIL_ADDRESS>

add --linkopt='-lpsl' to bazel build works for me.


Serialization variant hpp

Drawbacks:

requires n+1 instantiations of load_helper (n - amount of template parameters for variant)
all types in variant should be serializable;
all types should have default ctor.

Those commit messages don't add anything meaningful.Git already tracks information on added and modified files for us.

Just noticed the Drawbacks:

requires n+1 instantiations of load_helper (n - amount of template parameters for variant)

Number of instantiations has been an insignificant measure for quite some years, since compilers fixed the superlinear lookup on instantiations. Now there's a similar yet worse situation triggered by the length of symbols, which also comes with traditional recursion. Fortunately serializing a variant doesn't need recursion, all it takes is mapping a discriminator to a function that does the serialization, almost like a visitor.

all types in variant should be serializable;
all types should have default ctor.

These two are reasonably expected, as they are imposed by serialization itself.

What about this PR? Can we merge it?

What about this PR? Can we merge it?

This PR still makes use of implementation details. The use of boost::detail::void_ as a default argument to variant is known to be a transient workaround until non-variadic support is dropped, so we know that eventually this is going to be problematic.
@AntonBikineev: Furthermore, you mentioned on IRC that you did not addressed some review comments that could not be understood. Please do ask for clarification when needed, as otherwise the effect is that of simply ignoring reviews.

If the use of boost::detail::void_ is needed only for the non-variadics version of variant we might be fine. Nobody will go back and change anything there.

@stevenrbrandt said this worked for him

@AntonBikineev: What's missing here?

LGTM now.

I would like to see a clean history for this PR, but nevertheless LGTM.


Adjust limit Parameter

Right now, the limit parameter type is defined by an int32. This allows to request up to 2^32 list entries which are way more than would ever exist for a single user (e.g. payments of last year). This potentially inserts a security flaw like Heartbleed, if the API's backend is not able to handle that big numbers.
To avoid this (theoretic) risk one could strip this parameter to a usable max value. For example, the limit parameter could be extended by a maximum: 1000 value, which prevents this kind of attack.
The specific usable value, that is aligned to everyday use case, needs to be discussed with @SIX and other TPPs.

Feedback on behalf of UBS: If reliable, realistic values can be provided for the minimum and the maximum, then they should be specified for a matter of principle. However, we don’t see a concrete added value in terms of security.


Roll Flutter Engine from 9409b75e8f35 to a3d43775723b (1 revision)

https://github.com/flutter/engine/compare/9409b75e8f35...a3d43775723b
2024-02-23<EMAIL_ADDRESS>Remove timeouts from CountdownLatch.await in tests (flutter/engine#50930)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


RSS feeds do not appear in chronological order

Hi!
The RSS feed generated at https://readrust.net/all/feed.rss does not sort the posts in chronological order.
I think that is causing some issues with my feed reader Netvibes.
Can you please ensure the feeds are sorted by date?
Thanks.

Hi Siddhartha,
Thanks for reporting your issue. I've changed the feeds to be sorted by date_published. I hope that helps.

Ok, I reversed the post order.

Nice! My feed reader is working fine now.
But, there seems to be some other issue now in the RSS files. If you try to click on the RSS feed link (such as https://readrust.net/all/feed.rss), the browser tries to download the RSS as a file rather than open the feed reader (it was working fine earlier). I checked on both Firefox and Chrome. I'm not sure why and I could not spot anything in your commits.

I don' think the feeds downloading is a new issue, but it should be fixed. I don't think the aws-cli is setting the MIME type properly when it uploads the feeds. I'll open an issue to fix it.

Ah I see. Okay then. Thanks again for looking into this.
Cheers,
Sid


Fluid also with height size

Could we set the heigth at 100% like width and grid area would be calculate to fill all the area without blank ?

I am going to leave this open because I think this is interesting and a possibility. Would need to work through how things would work...

Now that 2.0 has been released I am going to start working on an enhancements branch and see about getting this functionality in there.

I'm interested in a similar possibility. I would like it to fill the height of the screen and be able to scroll horizontally through more photos.

Drew - Should I check out 2.0 then? I am having a similar issue. I am finding the grid is redrawing all fillerboxes, when a new grid container is appended with boxes and mason is ran on another container. I made an addition. I randomly make the grid container float left or float right to change which side of the container the boxes align. It makes it slightly more randomized.. I wonder if this is making it redraw the fillers. Also, opening developer tools causes a window resize vertically, which redraws the fillers, but it doesn't need to because the height doesn't change the number of fillers, just width. Is that in 2.0?
I see that width is important, in re redrawing fillers, but is there a way to limit it to only when its needed, as in, only when the grid container changes width? Is that in 2.0?
Lazy loading with posts inside is SUPER HARD! Especially if you need to maintain any sort of order throughout each of the grid containers in the lazy load. It took quite a bit of AJAX. I am nearly there. Counting the fillers and getting the right amount of posts, and skipping the right amount of posts for non-fillers, is pretty darn hard.
dickendd - I recommend using the lazy load/infinite scroll demo, which is inside the project. Then adjust your "grid containers" to stack left to right, instead of top to bottom. Then the first grid container, match your page wrapper width and set a height, and make every grid container thereafter match that width and height. Rerun that on resize. Then setup whatever scroll functionality you need on the wrapper surround all grid containers.. i.e. allow yourself to scroll through grid containers.

http://www.localnationalnews.com/url-test/

thanks unaomnia, I will try that. for now I actually ended up setting the classes of the boxes for their image background via JavaScript and changing it every 15 seconds to filter through some different images and different layouts automatically. of course this requires destroying aand setting up the mason again each time.

Wow.. that is actually a really good idea! Empty and fill the same grid container and trigger resize! I love it. You wouldn't have scrolling in that case right? Height would change but not width?
I.E. Showing more or less pictures depending on the boxes inside the grid container?
For example if you use promoted sizes, the fillers change depending on the position of the promoted sizes.
Also, as I was trying to suggest to Drew earlier, you could try to randomize the promoted sized boxes dimensions as well. As in randomly sized promoted boxes. You could combine the two, achieving randomly placed and randomly sized boxes. But that goes all over the place with counting divs etc.
Also resize of grid container always triggers redrawing of the custom fillers. I.E. anything that causes the grid container to change size or position seems to be causing a resize. I am not 100% sure about this. But I did notice that floating the grid containers causes a lot of resizing. I am not sure if anyone else is seeing that?

Counting boxes and filling posts didn't work well for me.. I switched to putting post IDs  (WordPress) into value attributes on hidden inputs, and then using JS to make arrays of those IDs, then turning those arrays into strings and sending them over AJAX via $.post ... With $.post I use 2 seperate PHP files containing WP loops.. one for my randomly sized promoted box, dependent on images and excerpts, and one for filler boxes, one size fits all... then exclude posts in these loop by exploding the posted JS strings into arrays in PHP  and using those arrays as the parameter for "post__not_in" for my 2 WP Query loops in my two seperate PHP files use in my AJAX $.post calls.
I am not 100% sure how I could keep them in perfect order on window resize, when the columns change from 4 column to 3 column to 2 column to 1 column wide on the parent containers. The number of filler boxes and therefore number of posts would have to change, and the AJAX calls ran again - I suppose. For now I think I will let posts be duplicated (if more fillers are needed on resize) or skipped (if less fillers are needed on resize)...

I am noticing an issue on larger tablets such as the ipad when swiping downward. There is image flickering and it seems link the blocks themselves are shuffling positions.
Also is there a way to change the block sizes on a media query range like how you can set columns:  for example [780,1080,3] and add 1,1 image sizes after the 3?
Thanks and let me know if I can clear anything up.

Hey @KTPH That is something I have noticed as well and it's how iOS7+ seems to change the viewport size so it's triggering a window resize, even thought it isn't. I am thinking about adding something that maybe sniffs this out and puts a hold on resize events for iOS devices until a full rotation is done which would fix this issue... I think ;)...
As for the ratio change / media query - this is actually very doable and an elegant solution would be to bundle it with the array that get's passed in so -

columns: [
        [0,480,1],
        [480,780,2],
        [780,1080,3],
        [1080,1320,4],
        [1320,1680,5]
    ],

would become

columns: [
        [0, 480, 1, 1.5],
        [480, 780, 2, 1.5],
        [780, 1080, 3, 2],
        [1080, 1320, 4, 3],
        [1320, 1680, 5, 3.5]
    ],

and if a ratio isn't supplied it would default to using the originally given ratio.
I am going to do some playing around and see about this and any issues that might come up from it.

Hey Drew that was fast. A desk warrior I assume! For the first part I will watch this git and see what you come up with, thank you and happy coding! As for the second part, I was more talking about adding the size values not the ratio.
So for example [480,780,2] I have 2 columns, and I would like to change all image sizes to 100% width of the grid so I would want to set is 2,2 at that point....  [480,780,2,2,2]
Does that make sense? Thanks again!

@KTPH ha you caught me at the perfect timing :)
I might be missing it, and correct me if I am wrong - but what if you set it to '[480, 780, 1]' that would mean that it's technically a 1 col grid and all elements will fall into that, or do you have a mixed use grid and not all elements are images?

I misspoke, I edited my previous comment.

Ahh so you're using promoted as well?

Speed in general could be better.. it is very slow loading overall for me..
Ted
312-292-6931
<EMAIL_ADDRESS>unaomnia.com
On Wed, Jun 3, 2015 at 12:33 PM, Drew Dahlman<EMAIL_ADDRESS>wrote:

Ahh so you're using promoted as well?
—
Reply to this email directly or view it on GitHub
https://github.com/DrewDahlman/Mason/issues/30#issuecomment-108538316.

Speed is on you, and your assets - the script is very small 4.573 kB

I find the callback sometimes fires when I don't want it to. That could
also be the "flickering" folks talk about. So, I think my goal has been to
use the destroy method. But can you should an example of how you would do a
lazy load that "destroys" the callback on the previously loaded grids, BUT
STILL allows for the fluid re-sizing effect?
That has been my main speed issue. The script is small but all it does is
make boxes, therefore I need to add more to make it useful at all. Loading
posts into the boxes, and adding any other styling or effects, is where
most my speed issue comes in. Mostly, I have to make scripts wait for other
scripts to finish, and usually the lazy load versus redrawing versus
resizing versus destroy etc, is where my timing gets confusing. So, I guess
an example that address the lazy load, resizing, and destroy method would
be cool.
Ted
312-292-6931
<EMAIL_ADDRESS>unaomnia.com
On Wed, Jun 3, 2015 at 12:38 PM, Drew Dahlman<EMAIL_ADDRESS>wrote:

Speed is on you, and your assets - the script is very small 4.573 kB
—
Reply to this email directly or view it on GitHub
https://github.com/DrewDahlman/Mason/issues/30#issuecomment-108540114.

+1