Would an additional platform check GHC version for Windows Subsystem for Linux make sense?

Issue description
Currently, if a user tries to use GHC8+ in WSL, when using the versions provided by nixpkgs or by Stackage, it simply fails on compile anything as it tried to allocate more memory than it is able to (1TB+).
This is because GHC 8.0's new block-structured heap for 64-bit platforms. From the GHC 8.0.1 release notes:

We have a shiny new two-step memory allocator for 64-bit platforms (see Trac #9706). In addition to simplifying the runtime system’s implementation this may significantly improve garbage collector performance. Note, however, that Haskell processes will have an apparent virtual memory footprint of a terabyte or so. Don’t worry though, most of this amount is merely mapped but uncommitted address space which is not backed by physical memory.

There is a whole Github thread for discussing this on MS BashOnWindows repo.
Would it make sense for nixpkgs to include a "fixed" version of GHC8, so one is able to run it from WSL?
This is solved easily, as described in this comment:
git clone -b ghc-8.0.2-release --recursive git://git.haskell.org/ghc.git ghc-8.0.2
cd ghc-8.0.2
./boot
./configure --disable-large-address-space #can set --prefix=... here
make -j8 #-j(number-of-threads)
sudo make install

As I can see, it is already being checked for iOS in this file for ghc-8.0.2.
Would it make sense to add another check for WSL here?
Steps to reproduce
Try to compile any project that depends on GHC8+ on WSL.
Technical details

System: WSL

$ cat /proc/version
Linux version 4.4.0-43-Microsoft<EMAIL_ADDRESS>(gcc version 5.4.0 (GCC) ) #1-Microsoft Wed Dec 31 14:42:53 PST 2014

Nix version: nix-env (Nix) 1.11.13
Nixpkgs version: "17.09pre112229.e619ace733"
Sandboxing enabled: grep: /etc/nix/nix.conf: No such file or directory

/cc @peti.
To me personally, WSL itself doesn't seem worth building all Haskell stuff twice on Hydra, and having --disable-large-address-space for everyone would decrease GC performance by ~8 %.  I wonder if this would be a good candidate for some hack replacing the runtime without recompiling, e.g. via pkgs.replaceDependency.

I don't understand the technical details behind this request. What is WSL? Is that a separate platform in Nixpkgs? And if so, what is it called?

@peti: it's about the linux-inside-windows situation: https://msdn.microsoft.com/en-us/commandline/wsl/install_guide  Using linux binaries should usually just work.

So it's not a separate platform in Nixpkgs?

Yes, my understanding is that it doesn't need to be a separate platform, in general.  (I don't use Windows, so I've never really tried WSL...)

Yes, a different platform is kinda overkill. The way to currently detect if the user is running Linux or not is by inpecting the /proc/version file and see if it contains the string Microsoft in it.
I was thinking about adding a check for GHC8+

I think it would be feasible to add a boolean argument to the GHC Nix expression that enables/disables use of large-address-space at compile-time so that people who want that can override the default choice easily. Disabling it for all of Linux by default doesn't sound like a good idea to me.
@NickSeagull, does this answer your question?

Definitely, disabling it for all of Linux is not feasible at all.
The situation that I'm thinking of is:

User wants to create package A which depends on package B
The package B depends on GHC8+, but its author didnt enable the large-address-space flag.

How the user would proceed on enabling that flag, and furthermore, could they dynamicly enable it in their default.nix file? I think it would be interesting if the check was automatic @peti

I think you'll find that https://nixos.org/nixpkgs/manual/#sec-overrides and https://nixos.org/nixpkgs/manual/#users-guide-to-the-haskell-infrastructure provide a wealth of information towards that end. If you have any specific questions, then it's probably best to ask on the nix-devel mailing list of -- even better -- in the #nixos IRC channel. The bug tracker seems like it's the wrong place for that kind of conversation.

In case someone comes from Google looking for a working version of GHC for WSL, I've created a repository with overrides for different packages that are meant to be "patched" somehow for working properly in WSL. https://github.com/NickSeagull/wsl-nixpkgs


Examples link in Migration docs is broken

Describe the bug
In the first document in the Migration folder, kit/documentation/migrating/01-migrating.md, the link to view examples leads to a github 404 page.
Reproduction

Go to https://github.com/sveltejs/kit/blob/master/documentation/migrating/01-migrating.md
Click link labeled "examples"

Logs
No response
System Info
n/a

Severity
annoyance
Additional Information
thanks for all your good work :) love the framework

Thanks for the report, I think we've moved all of them to the sites monorepo, so I've updated the link to point there instead.


add option for index and icon

Looks great! I only have some small comments, but I will merge this when you fix this!

@seblj fixed.

Looks good! Thanks!


🍱 Revise pipelines screenshots

This is a follow up PR to #1645 tweak Pipelines page's screenshots. Changes as follows:

[x] 🍏 Recreate screenshots from macOS Safari so they have consistent look and typography with all the other screenshots
[x] 🐛 Fixed screenshots showing experimental/featured-flagged UI
[x] 📐 Consistent image dimensions
[x] 📱 Use @2x retina image sizing (not the perfect srcset implementation yet, that's for a future scope)
[x] 🔍 Change focal point styling
[x] 🍱 Add a new screenshot for pipeline filtering
[x] 🔥 Remove unused image
[x] 📄 Updated screenshot styleguide documentation

Screenshot

One non-blocking addition to this for the future is that I'd love to create a Demo organization that we always use to take screenshots, partly as an added layer of consistency, and party as a guarantee that we're not leaking feature flagged screenshots.
We can use the same organization when we get around to automating REST requests as well. Maybe a daily cron job on a public repo, such as the Docs itself would be sufficient. Suggestions for the name of the organization on a postcard please. Must include an emoji.


Sorry, Kirino-san. I made a wrong PR repo.


rename get_intrinsic_gas method to _get_intrinsic_gas

What was wrong?
addreses https://github.com/ethereum/py-evm/pull/1832#discussion_r317845185
How was it fixed?
renamed get_intrinsic_gas method to _get_intrinsic_gas
To-Do

[x] Clean up commit history

[ ] Add entry to the release notes(Don't think its worthwile writing release notes for this simple change )

Cute Animal Picture

cc @carver


Feature/417 integrate file upload page with use cases

What this PR does / why we need it:
Integrates the file upload page UI from #366 with the js-dataverse use cases implemented on PR-153.
Which issue(s) this PR closes:
Closes #417
Special notes for your reviewer:
Follow-up issues still need to be created. Some things that are still missing:

file description is not passed to the API yet, use case does not foresee it yet
file name, label and description need to be editable
maybe a table for listing of the uploaded files, like it is in the JSF frontend now, i.s.o. a simple list like it is now?
adding multiple files at once API call, i.s.o. adding files one-by-one (addUploadedFilesToDataset call)
handling of the duplicate files having either an identical content or label+name
use case needed for installations not supporting S3 tagging, but also useful for other installations: cleanup storage of a dataset
menu actions: restrict, unrestrict and tags

Suggestions on how to test this:
You can find the generated npm version from the PR-153 at this link and replace it in the package.json (if it is not merged yet). You need to edit the FileJSDataverseRepository.ts file in order to use the new use cases i.s.o. the dummy code (this change is not committed yet as the use case is not yet merged).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation:

I am still working on it. This PR is created as an early demo to show where it is going. I think that some of the things that still need more work and are listed in the followup issues are out of the scope of this PR. The things I will still do within this PR:

debugging, making sure everything works as intended
fixing tests and improving coverage
using translations for buttons and other text
better analysis of the remaining work and creation of the followup issues

coverage: 98.403% (+0.9%) from 97.547%
when pulling 53e6bca481f46a26cfe696d57bf75f69f8dc2d8a on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 3159a8bf9af69a2dd90aeae39704f8556550f367 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 5831706f0b77d302097dfde9f81a8959f4f19180 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 5831706f0b77d302097dfde9f81a8959f4f19180 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.548% (+0.001%) from 97.547%
when pulling ab49fe091d0c8eca0b1da74966e2e0b9932e2eef on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.581% (+0.03%) from 97.547%
when pulling ab49fe091d0c8eca0b1da74966e2e0b9932e2eef on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling b5d04fb866d1de1951184283b5c1969ba5653c4f on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 5228ce955460ae886df7e469c0362ba93ba111a9 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 1d163e7922bf249cd983ddcac976b609b2072380 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 1d163e7922bf249cd983ddcac976b609b2072380 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling<PHONE_NUMBER>52bad9b2f1f73c8e3ee7624f0199dc on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling<PHONE_NUMBER>52bad9b2f1f73c8e3ee7624f0199dc on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling fda7c639ebee437ed05192764c1f05852dce96ed on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling fda7c639ebee437ed05192764c1f05852dce96ed on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 046f0161098a12365049c3b4483f399414c23062 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 8ebeda7d90f989c6cd1acb2a3f1281e8732c5b42 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling f73c9a57c0b11fc34263b827d6a9ae977cc9412c on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling f73c9a57c0b11fc34263b827d6a9ae977cc9412c on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 9e2bd2a758807913aa07b3e6d2d6c45f6d4ce7fc on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 9e2bd2a758807913aa07b3e6d2d6c45f6d4ce7fc on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 9e2bd2a758807913aa07b3e6d2d6c45f6d4ce7fc on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 91f744d2968f305310903f67261e08d5c1b7f3c2 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling af9a0d9c242a1adb2b6ff001b54da7ec42824379 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 7c90fbf70b364ac797d534d6d4ea170e47fbfda0 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling f19d7a14bc5cff2b0cba1412bdcccb762fcd55e3 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 4e535a69ec4b0018f46fe0e8c7ab0853f8487104 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 4e535a69ec4b0018f46fe0e8c7ab0853f8487104 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 8364d7a087a2b0c6d6ed0b7341ddb126ec80e307 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 79ec76a1d79f75d26524390824e8b603e686c85c on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 79ec76a1d79f75d26524390824e8b603e686c85c on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 79ec76a1d79f75d26524390824e8b603e686c85c on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 79ec76a1d79f75d26524390824e8b603e686c85c on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling d15592274825536458909512820f5cc126732a19 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling d15592274825536458909512820f5cc126732a19 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling d15592274825536458909512820f5cc126732a19 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling d15592274825536458909512820f5cc126732a19 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling d15592274825536458909512820f5cc126732a19 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling d15592274825536458909512820f5cc126732a19 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 211ba8a6a76e7b9c643daf00cc55ec9bbedc967a on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 211ba8a6a76e7b9c643daf00cc55ec9bbedc967a on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 211ba8a6a76e7b9c643daf00cc55ec9bbedc967a on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 211ba8a6a76e7b9c643daf00cc55ec9bbedc967a on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 211ba8a6a76e7b9c643daf00cc55ec9bbedc967a on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 683ede22a665c86ef30a97450569a2fc5c807c8e on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 683ede22a665c86ef30a97450569a2fc5c807c8e on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 683ede22a665c86ef30a97450569a2fc5c807c8e on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling fb8b4aae2356c3e5395239df3011d446f0f02bf2 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling fb8b4aae2356c3e5395239df3011d446f0f02bf2 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling fb8b4aae2356c3e5395239df3011d446f0f02bf2 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling fb8b4aae2356c3e5395239df3011d446f0f02bf2 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling fb8b4aae2356c3e5395239df3011d446f0f02bf2 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling fb8b4aae2356c3e5395239df3011d446f0f02bf2 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 7b8e7270be58684e76dc66a1a7d02d77fdcc9c35 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 7b8e7270be58684e76dc66a1a7d02d77fdcc9c35 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 98.403% (+0.9%) from 97.547%
when pulling 7b8e7270be58684e76dc66a1a7d02d77fdcc9c35 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.346% (-0.2%) from 97.547%
when pulling 9231f2d498be4ac9a9dfc2a7ab42ebad4803835d on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.346% (-0.2%) from 97.547%
when pulling 9231f2d498be4ac9a9dfc2a7ab42ebad4803835d on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.346% (-0.2%) from 97.547%
when pulling 9231f2d498be4ac9a9dfc2a7ab42ebad4803835d on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.407% (-0.1%) from 97.547%
when pulling 9231f2d498be4ac9a9dfc2a7ab42ebad4803835d on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.407% (-0.1%) from 97.547%
when pulling 9231f2d498be4ac9a9dfc2a7ab42ebad4803835d on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.407% (-0.1%) from 97.547%
when pulling 9231f2d498be4ac9a9dfc2a7ab42ebad4803835d on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.407% (-0.1%) from 97.547%
when pulling 9231f2d498be4ac9a9dfc2a7ab42ebad4803835d on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.407% (-0.1%) from 97.547%
when pulling 9231f2d498be4ac9a9dfc2a7ab42ebad4803835d on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.407% (-0.1%) from 97.547%
when pulling 9231f2d498be4ac9a9dfc2a7ab42ebad4803835d on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.405% (-0.1%) from 97.547%
when pulling caf1a3e87ee23583a7228e55bc0b3ba5ff861011 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.405% (-0.1%) from 97.547%
when pulling caf1a3e87ee23583a7228e55bc0b3ba5ff861011 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.405% (-0.1%) from 97.547%
when pulling caf1a3e87ee23583a7228e55bc0b3ba5ff861011 on feature/417-integrate-file-upload-page-with-use-cases
into fa7497a34a62248f95be9f0475078d36af2ac624 on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling 7a5322280c2ec95b08bcbca15146226c197bdf06 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling 7a5322280c2ec95b08bcbca15146226c197bdf06 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling 7a5322280c2ec95b08bcbca15146226c197bdf06 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling 8b87197632e17d34ba6bee7e8f9753f811de65f5 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling 8b87197632e17d34ba6bee7e8f9753f811de65f5 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling 8b87197632e17d34ba6bee7e8f9753f811de65f5 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling a44e4dbfb00247fe4df6ca94924a87f1ed9147b0 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling a44e4dbfb00247fe4df6ca94924a87f1ed9147b0 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling a44e4dbfb00247fe4df6ca94924a87f1ed9147b0 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling a44e4dbfb00247fe4df6ca94924a87f1ed9147b0 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling a44e4dbfb00247fe4df6ca94924a87f1ed9147b0 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

Hi @ErykKul could you please solve the lint typecheck problems?
I fixed thhose issues while working on my feature branch, here is the commit for you to see it on the src/dataset/infrastructure/mappers/DatasetDTOMapper.ts file.

Thanks! I cherry-picked it to this PR. I also had some feedback from our team, I will push some more commits to this PR, the review can wait, I will change the status to in progress.

coverage: 97.448% (-0.1%) from 97.581%
when pulling 0a99c592ce110f33a03d2c387eedc81c56c3e99b on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling 0a99c592ce110f33a03d2c387eedc81c56c3e99b on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.448% (-0.1%) from 97.581%
when pulling 0a99c592ce110f33a03d2c387eedc81c56c3e99b on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 938793407c82a734f8b269f6c3f884fcb54f8509 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 938793407c82a734f8b269f6c3f884fcb54f8509 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 938793407c82a734f8b269f6c3f884fcb54f8509 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling a13cdc25dc9364ea989cfdf3d519afe102ff26a4 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling a13cdc25dc9364ea989cfdf3d519afe102ff26a4 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling a13cdc25dc9364ea989cfdf3d519afe102ff26a4 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling a13cdc25dc9364ea989cfdf3d519afe102ff26a4 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling a13cdc25dc9364ea989cfdf3d519afe102ff26a4 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling e1402b387e7c6e04982fa793648e91c7f670e243 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling e1402b387e7c6e04982fa793648e91c7f670e243 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling e1402b387e7c6e04982fa793648e91c7f670e243 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 8c0c6cee7e7a5587f540ae196395b5a555b25600 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 8c0c6cee7e7a5587f540ae196395b5a555b25600 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 8c0c6cee7e7a5587f540ae196395b5a555b25600 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 8c0c6cee7e7a5587f540ae196395b5a555b25600 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 8c0c6cee7e7a5587f540ae196395b5a555b25600 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 8c0c6cee7e7a5587f540ae196395b5a555b25600 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling<PHONE_NUMBER>92562273934cb1ee699378aaf02346 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling<PHONE_NUMBER>92562273934cb1ee699378aaf02346 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling<PHONE_NUMBER>92562273934cb1ee699378aaf02346 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.397% (-0.2%) from 97.581%
when pulling<PHONE_NUMBER>92562273934cb1ee699378aaf02346 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.397% (-0.2%) from 97.581%
when pulling<PHONE_NUMBER>92562273934cb1ee699378aaf02346 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.397% (-0.2%) from 97.581%
when pulling<PHONE_NUMBER>92562273934cb1ee699378aaf02346 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling f458d79f8ee6c1d6c4812ddcb759d96e1ac517cd on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling f458d79f8ee6c1d6c4812ddcb759d96e1ac517cd on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling f458d79f8ee6c1d6c4812ddcb759d96e1ac517cd on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling f458d79f8ee6c1d6c4812ddcb759d96e1ac517cd on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling f458d79f8ee6c1d6c4812ddcb759d96e1ac517cd on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling f458d79f8ee6c1d6c4812ddcb759d96e1ac517cd on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling d786d9c96df96c7052c9cb3d9855b231407ff5e7 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling d786d9c96df96c7052c9cb3d9855b231407ff5e7 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling d786d9c96df96c7052c9cb3d9855b231407ff5e7 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling d786d9c96df96c7052c9cb3d9855b231407ff5e7 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling d786d9c96df96c7052c9cb3d9855b231407ff5e7 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling d786d9c96df96c7052c9cb3d9855b231407ff5e7 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

I added the changes as suggested. There is still a problem with the SelectMultiple component, but I think it is not related to this PR. There is also one test failing that does pass locally (scrolling in dataset files). I think that it can be reviewed now, and that the remaining issues can be addressed in the follow-up PRs.

coverage: 98.403% (+0.8%) from 97.581%
when pulling be645cdf8e2fd02837e54e81a1b56de849e8e694 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling be645cdf8e2fd02837e54e81a1b56de849e8e694 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling be645cdf8e2fd02837e54e81a1b56de849e8e694 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.483% (-0.1%) from 97.581%
when pulling be645cdf8e2fd02837e54e81a1b56de849e8e694 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.483% (-0.1%) from 97.581%
when pulling be645cdf8e2fd02837e54e81a1b56de849e8e694 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.483% (-0.1%) from 97.581%
when pulling be645cdf8e2fd02837e54e81a1b56de849e8e694 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.484% (-0.1%) from 97.581%
when pulling 2ddb63e005ee260571733cd0731ef9e54faf9847 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.484% (-0.1%) from 97.581%
when pulling 2ddb63e005ee260571733cd0731ef9e54faf9847 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.484% (-0.1%) from 97.581%
when pulling 2ddb63e005ee260571733cd0731ef9e54faf9847 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 2ddb63e005ee260571733cd0731ef9e54faf9847 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 2ddb63e005ee260571733cd0731ef9e54faf9847 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 2ddb63e005ee260571733cd0731ef9e54faf9847 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 2ddb63e005ee260571733cd0731ef9e54faf9847 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.503% (-0.08%) from 97.581%
when pulling 3867fa7893250704b729eaf0e6d79472bf1fed4f on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.503% (-0.08%) from 97.581%
when pulling 3867fa7893250704b729eaf0e6d79472bf1fed4f on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.503% (-0.08%) from 97.581%
when pulling 3867fa7893250704b729eaf0e6d79472bf1fed4f on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.503% (-0.08%) from 97.581%
when pulling 2dcea45be2e7e20024413ecd5592c2deb9011a8a on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.503% (-0.08%) from 97.581%
when pulling 2dcea45be2e7e20024413ecd5592c2deb9011a8a on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 804bbfde94475757cfd99b2684c5f5c8ec6a840a on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 804bbfde94475757cfd99b2684c5f5c8ec6a840a on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 804bbfde94475757cfd99b2684c5f5c8ec6a840a on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 400cefcaf81033b01cf0b72c99a8fe69b8365c76 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 400cefcaf81033b01cf0b72c99a8fe69b8365c76 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 400cefcaf81033b01cf0b72c99a8fe69b8365c76 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling e5e95ab00d6c148800d181c84f2fc6b630e8b6e0 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling e5e95ab00d6c148800d181c84f2fc6b630e8b6e0 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling e5e95ab00d6c148800d181c84f2fc6b630e8b6e0 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling ecafcbbcc049d2c87a734b225c9dd861c72f057b on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling ecafcbbcc049d2c87a734b225c9dd861c72f057b on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling ecafcbbcc049d2c87a734b225c9dd861c72f057b on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 429b1ca108468950807a463ec816fc249e861f20 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 429b1ca108468950807a463ec816fc249e861f20 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 429b1ca108468950807a463ec816fc249e861f20 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 429b1ca108468950807a463ec816fc249e861f20 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 429b1ca108468950807a463ec816fc249e861f20 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 98.403% (+0.8%) from 97.581%
when pulling 429b1ca108468950807a463ec816fc249e861f20 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.508% (-0.07%) from 97.581%
when pulling b63bfb827c5696161fba12b0fb69192cdc616797 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.508% (-0.07%) from 97.581%
when pulling b63bfb827c5696161fba12b0fb69192cdc616797 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

coverage: 97.508% (-0.07%) from 97.581%
when pulling b63bfb827c5696161fba12b0fb69192cdc616797 on feature/417-integrate-file-upload-page-with-use-cases
into 107aaca3f3197a228feb02f4d99f6b8124b96ebd on develop.

I updated #431 to keep track of the remaining work.

Approving! Ready for QA. 👍🏼

Since there was still a lot of functionality missing, I focused in this PR on adding an uploaded files list, buttons, modals, etc. It already got very big. I did split up the remaining work in smaller peaces. I think before writing the integration tests, the interface of upload file needs to be finalized first, so I created this issue:
https://github.com/IQSS/dataverse-client-javascript/issues/163
Most weird thing is the add uploaded file expects the file to be passed again? The API it supposed to call looks very differently from that. I also do not see the hashes of the files in there? Are they calculated while the files are uploaded? I thought that js-dataverse was stateless? I can pick it up next and have deeper look at what is happening there, but I think that both calls would need some tweaking before having a full end-to-end functionality.
Once that part is finalized, we can write the integration tests:
#441
The overview of the remaining work can be found here: #431
In the short run, I can make the current js-dataverse implementation work by ignoring the uploaded files list and letting the files be added directly after upload.

@GPortas ,
I implemented a workaround to better fit the current implementation in js-dataverse. Does it work for you now?

@ErykKul
Yes, you are right that it is unnecessary to send the file again to AddUploadedFileToDataset use case.
In AddUploadedFileToDataset, the file blob is only used to extract and calculate properties to build the UploadedFileDTO object that is sent to the API.
But actually, this object can be pre-created and sent to the use case by the caller (the SPA in this case). Along with the rest of the enhancements that need to be added to the use case, I will also improve this part.
So I am going to merge this PR, but I will not close the associated issue yet, as the integration is still uncompleted.
Thank you!


Karpenter IRSA Policy does not contain permissions to work with  IAM Instance Profile

Description
After upgrading our Karpenter setup to v0.32.0, we noticed that the IAM Instance profile was not getting created by Karpenter using the spec.role field introduced in the EC2NodeClass in this release.
The logs from the Karpenter pods show the following error -
{"level":"ERROR","time":"2023-11-09T10:22:08.767Z","logger":"controller","message":"Reconciler error","commit":"3a61217","controller":"nodeclass","controllerGroup":"karpenter.k8s.aws","controllerKind":"EC2NodeClass","EC2NodeClass":{"name":"nodeclass"},"namespace":"","name":"nodeclass","reconcileID":"d0173c52-78f1-44e8-840f-0f86562dca2f","error":"resolving instance profile, getting instance profile \"<redacted>\", AccessDenied: User: arn:aws:sts::<redacted>:assumed-role/KarpenterIRSA-<redacted>/<redacted> is not authorized to perform: iam:GetInstanceProfile on resource: instance profile <redacted> because no identity-based policy allows the iam:GetInstanceProfile action\n\tstatus code: 403, request id: <redacted>"}

I manually added the permissions to the policy via the AWS console and was able to get this working.  However, we would like to implement this through Terraform.
Can the module be updated to include these permissions in the Karpenter IRSA policy or is there a way to customize this policy?

[ y] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]: v19.19.0

Terraform version: 1.1.7

Provider version(s):
Terraform v1.1.7
on darwin_amd64
provider registry.terraform.io/hashicorp/aws v5.23.1
provider registry.terraform.io/hashicorp/cloudinit v2.3.2
provider registry.terraform.io/hashicorp/helm v2.11.0
provider registry.terraform.io/hashicorp/kubernetes v2.23.0
provider registry.terraform.io/hashicorp/local v2.4.0
provider registry.terraform.io/hashicorp/null v3.2.1
provider registry.terraform.io/hashicorp/template v2.2.0
provider registry.terraform.io/hashicorp/tls v4.0.4
provider registry.terraform.io/hashicorp/vault v3.21.0
provider registry.terraform.io/rancher/rancher2 v1.25.0

Reproduction Code [Required]
Module Code
module "karpenter" {
  count   = var.karpenter ? 1 : 0
  source  = "terraform-aws-modules/eks/aws//modules/karpenter"
  version = "19.19.0"

  cluster_name = module.aws-eks.cluster_id

  irsa_oidc_provider_arn          = module.aws-eks.oidc_provider_arn
  irsa_namespace_service_accounts = ["karpenter:karpenter"]

  create_iam_role = false
  iam_role_arn    = module.aws-eks.eks_node_iam_role_arn
}

Karpenter Helm Release
resource "helm_release" "karpenter" {
  count            = var.karpenter ? 1 : 0
  namespace        = "karpenter"
  create_namespace = true

  name       = "karpenter"
  repository = "oci://public.ecr.aws/karpenter"
  chart      = "karpenter"
  version    = "v0.32.0"

  set {
    name  = "settings.aws.clusterName"
    value = var.cluster_name
  }

  set {
    name  = "settings.aws.clusterEndpoint"
    value = module.aws-eks.cluster_endpoint
  }

  set {
    name  = "serviceAccount.annotations.eks\\.amazonaws\\.com/role-arn"
    value = module.karpenter[count.index].irsa_arn
  }

  set {
    name  = "settings.aws.defaultInstanceProfile"
    value = module.karpenter[count.index].instance_profile_name
  }

  set {
    name  = "settings.aws.interruptionQueueName"
    value = module.karpenter[count.index].queue_name
  }

}

Steps to reproduce the behavior:

Deploy Karpenter via the Terraform module on the EKS cluster
Create the NodeClass and NodePool in the cluster for Karpenter to use
Check the 'status' field in the NodeClass YAML after creation or
Check the Karpenter pod logs for errors as shown above

Expected behavior

Karpenter is able to create an IAM Instance Profile from the role specified and the 'status' field in the NodeClass YAML gets updated with that value as shown here - https://karpenter.sh/v0.32/concepts/nodeclasses/#statusinstanceprofile

Actual behavior

Karpenter fails to create the IAM Instance Profile due to lack of permissions as shown in the following logs -

{"level":"ERROR","time":"2023-11-09T10:22:08.767Z","logger":"controller","message":"Reconciler error","commit":"3a61217","controller":"nodeclass","controllerGroup":"karpenter.k8s.aws","controllerKind":"EC2NodeClass","EC2NodeClass":{"name":"nodeclass"},"namespace":"","name":"nodeclass","reconcileID":"d0173c52-78f1-44e8-840f-0f86562dca2f","error":"resolving instance profile, getting instance profile \"<redacted>\", AccessDenied: User: arn:aws:sts::<redacted>:assumed-role/KarpenterIRSA-<redacted>/<redacted> is not authorized to perform: iam:GetInstanceProfile on resource: instance profile <redacted> because no identity-based policy allows the iam:GetInstanceProfile action\n\tstatus code: 403, request id: <redacted>"}

since this was a recent change that adds new permissions that are required starting on v0.32, you'll need to opt into these additional permissions by setting enable_karpenter_instance_profile_creation = true

@bryantbiggs I actually did set that value but I am getting the following error - happens only when I set the value.
╷
│ Error: Missing required argument
│
│   with helm_release.karpenter[0],
│   on main.tf line 113, in resource "helm_release" "karpenter":
│  113: resource "helm_release" "karpenter" {
│
│ The argument "set.5.value" is required, but no definition was found.

the reproduction code you provided above does not have this argument. I would suggest you take a look at the example we have provided https://github.com/terraform-aws-modules/terraform-aws-eks/tree/master/examples/karpenter


Add options for trailing commas in match expressions

:+1:

Note we should have options for adding the trailing commas to single line branches and also for removing them from block arms.

CC me

Fixed by https://github.com/rust-lang-nursery/rustfmt/issues/663.


Add IEditableObject interface and behavior

Add IEditableObject Interface and update methods to the EntryViewModel to close #38.
For compatibility reasons the direct access to the value of the Entry property is maintained. Therefore, the update mechanism requires a helper variable.
Also the ObservableCollectionWrapper is removed, as it is used in the EntryViewModel exclusively and its functionality can be replaced with a single Select statement.

I like it, downwards compatible fix :-)


Work around Chrome implementing w3c's DOM Level3 Events section B.2.4 on Mac

Chromium decided to implement section B.2.4 of DOM Level3 Events only on Mac.
Given the German (Swiss) keyboard layout:

This means that it is very difficult to figure out what actual physical key was pressed. E.g.:

when pressing 7, the keydown event we receive has keyCode:55
this is OK
when pressing Shift+7, the keydown we receive has shiftKey:true and keyCode: 191
this is unexpected, we should receive shiftKey:true and keyCode:55

To investigate if we can use the keyIdentifier and native-keymap to reverse their "helpful" keyCode massaging.

fyi @weinand


Debugging cofiguration

Hi, thanks for the wrapper gem. Would it be possible to create configuration variable and include the production version of Vue library, so people can configure environments, where they want Vue debugging turned off?

+1

👍

+1

@adambutler will you accept a PR implementing it?

👍  Sure


Redundant generic method

The generic type TNotification seems redundant in this method as you can as well just use INotification as notification type, is there any reason to have it this way?
https://github.com/jbogard/MediatR/blob/b3b819f05bed0da789791fec1d8b8a0168a85606/src/MediatR/Mediator.cs#L43

I can't remember tbqh


Build and release linux artifacts on tags

Resolves #36
Tested on my fork: https://github.com/alpe/mesh-security-sdk/releases

Added another commit to enable CGO for the e2e artifact. We need it for running the wasm contracts


Fetch random items to feed - shuffle

Now magic wand (no that one 18+ tool 😄) shuffles between pages which is good and we would add functionality that it would shuffle from the whole set of NFTs new feed.
It could be expanded with an existing magic wand
Implement it for

gallery feed
collection detail
collections
profile

@yangwao Can you explain more? You mean now the magic random button should shuffle nfts by staying on page 1 only?

@yangwao Can you explain more? You mean now the magic random button should shuffle nfts by staying on page 1 only?

It should fetch random NFTs, not just pages. that mean to have more variance.
let me draft on explainer.
when I click on random button now, I see NFTs in fixed range of 12, so I land either on [24-36] [36-48] [48-60]
but with shuffle I would like to have NFTs on page fetched from page 25, page 46, page 56, and so on.
So you can randomize page and order of NFTs and then assemble whole new "page"
Probably we can think of putting the address of that NFTs into address bar so that your shuffle roll is shareable

@yangwao by new page, you mean user should go the nft detail route? /rmrk/detail this one, with the random nft ?
Also, where should the shuffle button show up? near the magic wand?

@yangwao by new page, you mean user should go the nft detail route? /rmrk/detail this one, with the random nft ? Also, where should the shuffle button show up? near the magic wand?

Oh, actually that's a good idea as well.
Let's add a random button to the item detail if possible.
Yes, on gallery feed next to the magic wand.

@yangwao also when we do shuffle, like suppose in gallery, what happens to the pagination in gallery? is it hidden?

@yangwao do let me know more on this, thank you

@yangwao also I have two more doubts:

How are we suppose to fetch random nfts from different pages because we have pagination, so we don't really have all the data initially?

Good question! Probably it will be heavy, let's summon @vikiival if have idea how to do it efficiently.

when we do shuffle, like suppose in gallery, what happens to the pagination in gallery? is it hidden?

Yeah, pagination will be effectively gone because pagination from my point is something comparing to known index/position where in shuffle you are creating new "index" on your own.


Fitting function reconstruct

Fitting function reconstruct for K diversity image stack.

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


v3.10

Description of the PR
aplus-courses-3.10.zip
Manual testing:

Windows: @Taikelenn
Linux: @OlliKiljunen

Tested with Windows 10, works fine


INFLUXDB_META_CONFIG_PATH does not source properly

INFLUXDB_META_CONFIG_PATH will not source properly since the config parameter in "/usr/lib/systemd/system/influxdb-meta.service" gets hardcoded
Despite setting the environment variable and adding the same entry to /etc/default/influxdb-meta it does not take the variable
Changes to be done should be ExecStart=/usr/bin/influxd-meta -config ${INFLUXDB_META_CONFIG_PATH} ${INFLUXD_OPTS} instead /usr/bin/influxd-meta -config /etc/influxdb/influxdb-meta.conf ${INFLUXD_OPTS}

@wookdark looks like you're using an unsupported version of Influx? What version are you running?


[bug] Useless features not written to database

Tested with binary selection.

does this still happen?
are there special steps needed to provoke this behaviour?
currently I can't reproduce this

in case this was in respect to skip round, this is fixed as of
93568195a1380f7eb47baa542f975d8860ea776c


”Răcăștia”, ”Boș”, ”Groș”, ”Hășdat”, ”Peștișu Mare” are listed in the drop-down menu

Description:
When user writes ”Răcăștia”, ”Boș”, ”Groș”, ”Hășdat”, ”Peștișu Mare” the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Răcăștia"

Expected results
The location appears in the drop-down menu as "Sat Răcăștia, HUNEDOARA (HUNEDOARA)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Boș"

Expected results
The location appears in the drop-down menu as "Sat Boș, HUNEDOARA (HUNEDOARA)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Groș"

Expected results
The location appears in the drop-down menu as "Sat Groș, HUNEDOARA (HUNEDOARA)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Hășdat"

Expected results
The location appears in the drop-down menu as "Sat Hășdat, HUNEDOARA (HUNEDOARA)".

Step 8
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 9
Write in the search bar "Peștișu Mare"

Expected results
The location appears in the drop-down menu as "Sat Peștișu Mare, HUNEDOARA (HUNEDOARA)".

Fixed! Poti sa retestezi


When you use math symbols instead of tf.math, tensorflow.keras.load_model does not properly load model for stuff like not equal

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): on mac 10.14.6  but on colab
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): default colab install
TensorFlow version (use command below): 2.5
Python version: 3.7
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
When I used some stuff such as != or == in code and save graph, I am not able to load the graph
but when I use tf.math I am able too.
Describe the expected behavior
I expect to be able to use that behavior and load the model.
Contributing

Do you want to contribute a PR? (yes/no): no
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
https://colab.research.google.com/drive/1gm5DujworX-7X1z01qUToOlzE8qLbfPO?usp=sharing
Please toggle on and off the commented line
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

Was able to reproduce the issue  in TF 2.5. Please find the gist here.Thanks!

As of now Tensorflow does not support those operations directly, adding == or != would break lot of code, instead it's  suggested to use Tensorflow symbols like tf.math.not_equal.


Build updates

So it seems Bundler 1.12 is still broken for us, I expect us to be able to remove the version select at some point, but currently we can't install json on 2.3.1 on travis, and it also seems to break appveyor with warnings.

See bundler/bundler#4558


L515 Unstable Frame Rate

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
L515

Firmware Version
<IP_ADDRESS>

Operating System & Version
Linux

Kernel Version (Linux Only)
5.4.0-122-generic

Platform
PC

SDK Version
2.50.0

Language
C++

Segment
Robot

Issue Description
<Describe your issue / question / feature request / etc..>
L515 wait_for_frames() sometimes (52ms-60ms) sometimes under 10ms, cannot reach the preset 30 frames.
When run on same code with other camera D435/D455 (60FPS), it's fine.
here is the time cout by L515:
wait time:0.014355
update time:0.100019
time:0.340201
-------------------程序总时间:1.52427
wait time:61.1373
update time:61.2394
time:61.4984
-------------------程序总时间:63.3608
wait time:0.429982
update time:0.499923
time:0.700047
-------------------程序总时间:1.8975
wait time:61.1578
update time:61.258
time:61.5415
-------------------程序总时间:63.0588
wait time:2.03914
update time:2.14394
time:2.45241
-------------------程序总时间:4.00483
wait time:59.0686
update time:59.1937
time:59.4571
-------------------程序总时间:60.8233
wait time:3.79388
update time:3.87624
time:4.12769
-------------------程序总时间:5.37105
wait time:58.0602
update time:58.1426
time:58.3969
-------------------程序总时间:60.457
Here is my code:
TickMeter tk;
tk.start();
  frameSet = pipe.wait_for_frames();											//等待相机数据
tk.stop();
cout << "wait time:" << tk.getTimeMilli() << endl;
tk.start();

  rs2::video_frame colorFrame = frameSet.get_color_frame();					//获取彩色帧
  rs2::depth_frame alignedDepthFrame = frameSet.get_depth_frame();			//获取深度帧

  srcImage = cv::Mat(cv::Size(IMAGE_WIDTH, IMAGE_HEIGHT), CV_8UC3, (void*)colorFrame.get_data(), cv::Mat::AUTO_STEP);				//将彩色图像数据存储在Mat矩阵中
  depthImage = cv::Mat(cv::Size(DEPTH_WIDTH, DEPTH_HEIGHT), CV_16UC1, (void*)alignedDepthFrame.get_data(), cv::Mat::AUTO_STEP);	//将深度图像数据存储在Mat矩阵中
memcpy(data, alignedDepthFrame.get_data(), DEPTH_WIDTH * DEPTH_HEIGHT * 2);

#ifdef PCL
rs2Points = rs2Cloud.calculate(alignedDepthFrame);
rs2Cloud.map_to(colorFrame);
cloudByRS2 = PointsToPointCloud(rs2Points, colorFrame);
#endif

tk.stop();
cout << "update time:" << tk.getTimeMilli() << endl;

Hi @FeiSong123  Could you test please whether performance improves if you unplug the micro-sized end of the USB cable from the base of the L515 camera, turn the connector around the other way and re-insert it into the base of the camera (USB Type-C cables are two way insertion at the micro-sized end).

I repeated the operation several times and found that improved to 30ms-40ms for once only.

Next, please try disabling the auto-exposure priority RGB option.  When auto-exposure is enabled and auto-exposure priority is disabled, this should force the RealSense SDK to try to maintain depth and color FPS at the same rate instead of allowing it to vary.  The code below can be inserted in the line after the second tk.start instruction and queries the color sensor (which has index number '1', whilst the depth sensor is index number '0').
auto sensor = pipe_profile.get_device().query_sensors()[1];
sensor.set_option(RS2_OPTION_AUTO_EXPOSURE_PRIORITY, 0);

I added it to the initialization configuration, but it still unstable (30ms-60ms)
rs2::pipeline_profile selection = pipe.start(cfg);
cout << "start cfg Ok ..\n";
#ifdef IFCAMERA
auto colorSensors = selection.get_device().query_sensors()[1];
colorSensors.set_option(RS2_OPTION_AUTO_EXPOSURE_PRIORITY, 0);
// colorSensors.set_option(RS2_OPTION_ENABLE_AUTO_EXPOSURE, 0); //zero is turn off
// colorSensors.set_option(RS2_OPTION_EXPOSURE, 650);
// colorSensors.set_option(RS2_OPTION_GAIN, 300);    										//设置曝光时间
// colorSensors.set_option(RS2_OPTION_WHITE_BALANCE, 4500);									//设置白平衡
cout << "set exposure OK ..\n";

If you have disabled auto-exposure and are setting a manual exposure value then it could be causing the FPS to lag.  This effect is described at https://github.com/IntelRealSense/librealsense/issues/1957#issuecomment-400715579
The constant FPS rate provided by disabling auto-exposure priority will also not work if auto-exposure is disabled.

I used auto exposure and turned off auto exposure priority as described at https://github.com/IntelRealSense/librealsense/issues/1957#issuecomment-400715579 and FPS is now stable.
Thanks for your help very much!

That's great, @FeiSong123 - thanks very much for the update  :)

Hi, I want to know how to set RS2_OPTION_AUTO_EXPOSURE_MODE, but I couldn't find the corresponding usage in the repository.

When I set up my camera as follows, I encountered a strange problem:
    auto colorSensors = profiles.get_device().query_sensors()[1];
colorSensors.set_option(RS2_OPTION_AUTO_EXPOSURE_PRIORITY, 0);

Below are four consecutive images taken by the camera, which appear to suddenly increase and then decrease in light intensity:

Then I wondered if there was a problem with the auto exposure settings, so I went to check the auto exposure related settings.


New version: MintplexLabs.AnythingLLM version 1.6.10

Created by 🥟 Dumplings in workflow run #9697.

Log
Updated: 1.6.9 → 1.6.10
404: This page could not be foundbody{color:#000;background:#fff;margin:0}.next-error-h1{border-right:1px solid rgba(0,0,0,.3)}@media (prefers-color-scheme:dark){body{color:#fff;background:#000}.next-error-h1{border-right:1px solid rgba(255,255,255,.3)}}404This page could not be found.{"props":{"pageProps":{"statusCode":404}},"page":"/_error","query":{},"buildId":"3FxyvRno5zVwfrM790xQA","nextExport":true,"isFallback":false,"gip":true,"scriptLoader":[]}
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
The manifests for the last version 1.6.9 will be removed. Reason: No installer URL is changed compared with the last state while the version is updated
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

URL: https://s3.us-west-1.amazonaws.com/public.useanything.com/latest/AnythingLLMDesktop.exe
Status Code: 200
(Automated message - build 899)


Disable log ingestion test on macOS

In  #42134 and #42135, the LogsIngestionAsyncClientTest.testUploadLogsInBatchesConcurrently test fails with the macoslatest_18_False_False_surefiretestfailsafeintegrationtestfailsafeverify build (see for example: https://dev.azure.com/azure-sdk/public/_build/results?buildId=4192172&view=logs&j=8b6ce078-9252-5859-2eab-25597345a671&t=2a829ff0-21e6-5645-6029-72db302ab93f). For both PRs, I have tried to restart macoslatest_18_False_False_surefiretestfailsafeintegrationtestfailsafeverify several times, without success.
With a PR we could bypass the CI check, but it won't work to do a new release of the OTel Java exporter.

API change check
API changes are not detected in this pull request.

Also disable LogsIngestionAsyncClientTest.testUploadLogsInBatches on macOS: two consecutive failures


Merge v1.39 into vector tiles

Merge the newly released v1.39 into vector tiles.
This merge allows people relying on the vector-tiles branch to publish their own packages.
This is similar to #5875 and #5810.

@gberaudo, thanks for the pull request! Maintainers, we have a signed CLA from @gberaudo, so you can review this at any time.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

Thanks @bagnell.


GxE study status indicator on each study page

GxE study status should be indicated on each study page e.g. https://www.ebi.ac.uk/gwas/studies/GCST004800. This could be presented alongside “Full summary statistics” and “Terms/License”. Could be yes/no or would be nice to have an icon like the sumstats.  An icon could also be displayed in the search snippet, similar to sumstats and targeted arrays (but this is lower priority).

looks good, although I've only seen the "X" for non-GxE studies. Could you give an example with the "yes" icon?

waiting for DR to confirm


feat: amend resolvers deployment to declare own resources in values

amend tekton-remote-resolvers-deployment with yq to add templating
This will helps to declare own deployment resources for the pod

/cc @msvticket @tomhobson

@mentlak0 Is it possible to just template the entire resources block? I imagine we'll want to be able to increase requests as well as limits.


errors on individual jobs are not getting recorded back to the cron_schedule table

there's a disconnect someplace between writing the error output to the pid files and getting the data back to the db

fixed in https://github.com/magemojo/m2-ce-cron/commit/bd433ae292f25abccb63bae1fb21c94cdbbf2f75


Update URL in error message to use issue templates

The Github issue tracker URL in error messages should be updated to use issue templates
Originally posted by @esc in https://github.com/numba/numba/pull/7223#discussion_r679858426

Closing as requested.


Add support for custom UDP connection identifiers

Description
Adds support for custom UDP connection identifiers. If a ConnIDFn is
provided, the result will be used as the identifier of a connection
rather then the remote address. If a connection already exists for the
remote address, its identifier will be updated to the connection ID. If
the remote address for packets associated with a connection identifier
changes, the remote address of the connection will also be updated.
Signed-off-by: Daniel Mangum<EMAIL_ADDRESS>Adds unit testing to ensure that a custom UDP connection identifier
results in expected behavior. Testing adheres to the following steps:

Initiate 5 connections using remote address as identifier.
Send message on each connection that results in migration from remote
address identifier to custom identifier.
Spawn 20 clients, each assigned to send one message on one of the
connections (total of 4 messages on each connection).
Spawn 5 servers and ensure that each receives the first initiation
and set messages, then 4 messages, each originating from a different
remote address.

Signed-off-by: Daniel Mangum<EMAIL_ADDRESS>Reference issue
Part of https://github.com/pion/dtls/issues/256

I agree with @Sean-Der here. Thats a functionality which is better implememented in pion/dtls in my opinion.

@hasheddan Can we close this PR?

@stv0g sure 👍🏻


Remove version: DominikReichl.KeePass version 2.52.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/keepass/files/KeePass 2.x/2.52/KeePass-2.52.msi/download
Status Code: 200
(Automated message - build 902)

Close with reason: Duplicate;


Title doesn't work properly

The title has a template string;

I'd like to take this one

I'd like to take this one

Sorry, already submitted PR.


Remove --skip-*-ports from CLI

With our new Proxy Transparency feature landing, we no longer need the --skip-inbound-port and --skip-outbound-port options in the CLI. We should remove and/or deprecate them.

Per @wmorgan's previous comment, I'm going to close this.


Added isBetween validator similar to iz.js

Coverage decreased (-0.26%) to 98.68% when pulling 50a09a0d1ab5cee13b314f65c4d7e01300652fff on freak4pc:master into 443ed44dae746439b075ac8bc446c7754933de3a on chriso:master.

Thanks for the PR.
A previous version had this, but it was removed since there are many possible variations and the validator is quite simple and hence easy to add yourself with extend():

should the function handle floats/decimals, integers/whole numbers, or both?
should the min/max be inclusive?
should one of the min/max be optional?
how should non-numeric input be handled? what about partially non-numeric input?

Hey @chriso ,
Thanks for the reply. There are indeed many possible variations, but - other validators answer your questions as such

Yes, it can - if that's what we want it to do.
Yes, Exactly like isLength is inclusive
Definitely could be. That way it could be either str >= min, str <= max , or both.
Non-numeric or partially non-numeric values should be ignored.

What're your thoughts on this?
Clearly people could just extend() this but this seems like a minor fix that could greatly benefit users of validator. I know I've been adding it manually for projects for the past year or so, which is why I added this PR.
Cheers :)

I've thought about this some more and I think a better course of action would be to pass an optional options object to the isInt() and isFloat() validators. This allows people to specify what functionality they want, similar to how the isEmail and isURL validators currently work.
Some examples:
validator.isInt('123'); => true
validator.isInt('123', {min: 100}); => true
validator.isInt('123', {min: 200}); => false
validator.isInt('123', {max: 200}); => true
validator.isInt('123', {min: 100, max: 110}); => false

validator.isFloat('3.14', {min: 3.1, max: 3.2}); => true
// etc

I'd be happy to accept a PR that adds these features.

Seem like a good way to go at it. I'll send a PR soon :)
:+1:

Awesome, thanks.

Pushed PR #392 , waiting for Travis ;)


KOGITO-5157: Temporarily hiding the import-java-classes button

Extension of https://github.com/kiegroup/kogito-tooling/pull/751
As the current status of the functionality is still in progress and the results from LSP extensions are mocked, I disabled the rendering of the import-java-classes button, to be restored in KOGITO-6276

The (build) kogito-tooling-stunner-editors check has failed. Please check the logs.

@tiagobento can you please merge it?


[WIP]: Creating test before release

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d0e2614). Click here to learn what that means.
The diff coverage is 0%.

@@          Coverage Diff           @@
##             master   #14   +/-   ##
======================================
  Coverage          ?    0%
======================================
  Files             ?     1
  Lines             ?    11
  Branches          ?     0
======================================
  Hits              ?     0
  Misses            ?    11
  Partials          ?     0

Impacted Files
Coverage Δ

src/Retriever.jl
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e2614...899d5e0. Read the comment docs.


Add prototype of sample for review

@driskull  can you review this sample and provide feedback

Can we import calcite-web as an NPM package? https://esri.github.io/calcite-web/documentation/#npm

Can we have a .ts file for this example too?

@driskull yep but I want to get the JS one reviewed and tested before duplicating it in TS.

Maybe this sample needs a different name? It doesn't work with a group right? It just queries a user's items.

@driskull  I should probably re-work it so it uses a group in both cases. I'll have to think about it.

Ok. if you want to use a group the ApplicationBase has a method to query items from a group.

yeah I just need to find a scenario that makes sense - maybe switch to groups and query for users groups instead of public groups once they sign-in

Is this PR still valid @kellyhutchins? If so, reopen.


Drop bluebird for native Promises?

You are using bluebird for .map but this should be pretty trivial to write with native promises, would you be open to this? 🍝 💀
--
cc @paulirish

@samccone sounds goods. I am more than happy to get rid of this dependency. 😄
--
I am using it especially for Promise.props. https://github.com/pmdartus/speedline/blob/17d37efa18adffec82917239681a5d995137c77d/src/speed-index.js#L12

Great, more than willing to open a PR to do this for you... feel free to assign me to this ticket.
👏

These two are basic polyfills, and do not have any of their own deps:
https://www.npmjs.com/package/promise-props
https://www.npmjs.com/package/promise.map

we can just roll our own here, no need for any deps really.


Terminology

Within the docs, we refer to https://app.rkvst.io/ as the "app", "portal", "UI", and "dashboard"
Updates to the contributing & styles docs (#671) are helping with the consistency.
What do we want to actually use?
cc: @beekman33

Portal and dashboard are definitely wrong.
The choice of 'app' or 'UI' should be context dependent. Generally it should be 'UI' as that contrasts better with the alternatives of 'API' or 'Python', and it's hard to say we really have an 'app'.

TODO: update #671 to include terminology references.

Going with App in PR #669. Might want to review to see how it looks

I tend to use UI for app.rkvst.io
If I use "portal" I'm most likely to be talking about the Zendesk Support portal knowledgebase.


Feature/home design

📄  Description:
This pr contains the layout of Home Screen. Also deletes unused styles and assets.

📌  Notes:

✔  Performed Tasks:

Design Home Screen
Delete assets and unused styles

⏯  Demo:
Video or image.

Siempre squash & merge. Cuidado con el nombre del "squash and merge" commit


Ability to stop/restart services

Hi,
Nice project!
Is it possible/will you add the ability to stop/restart services from the interface?
I've no experience with go, but since keymetrics require a LOT of money for one extra process that I need, I'd offer to help out with your project on the web interface side of things.
Cheers

Hi @dbvcode
I've just added support for start, stop, restart in go:
https://github.com/doorbash/pm2-web/compare/start-stop-restart
You can now do your thing on the web interface side :)

/command?op=[start, stop, restart]&id=[app id]
Here is an example for stopping process with id 1000:
/command?op=stop&id=1000

Cheers,
Pull request sent. Kept the update to a minimum.

I've just merged the PR and made some minor changes to it myself.
Thanks @dbvcode


integrated (s)ftp-server as alternative for mount

Output of restic version
latest?
What should restic do differently? Which functionality do you think we should add?
As an addition to the mount-command an integrated (s)ftp-server would be nice.
What are you trying to do? What problem would this solve?
Windows does not support the mount command and maybe not all own linux-installations have fuse installed.
With an integrated (s)ftp-server we could use different ftp clients and therefore have simple gui to access backups on all platforms.

There are plans to add FUSE support for windows #2862 . There's also an issue to add support for WebDAV #485 which is likely more useful.
On Linux installations I don't see any benefit from (s)ftp support, just install fuse and use the regular sftp support there.

I'll keep this issue open for now to see whether there's interest in the feature. But we'll likely rather add WebDAV support.

This would also help on linux if you are not the owner of the system and cannot install fuse.
e.g. if you backup to a server at work or school.
webdav may also be an option.

btw. kopia mounts the snapshots as network-drive on windows

closed in favor of #485


Air temperature doesn't refresh on Eurotronics Spirit radiator valves

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?
NO, my problem is NOT within Home Assistant or the ZWave JS integration
Is your problem within ZWaveJS2MQTT?
NO, my problem is NOT within ZWaveJS2MQTT
Checklist

[X] I have checked the troubleshooting section and my problem is not described there.

[X] I have read the changelog and my problem was not mentioned there.

Describe the bug
What causes the bug?
I use those devices since about 2 years and hadn’t much troubles yet. About 6 month ago I did migrate from Open Z-Wave to Z-Wave JS (V0.1.45 currently) in combination with Z-Wave JS to MQTT.
I’m not quite sure if the problem exists since the migration, or if it is caused by an update.
What do you observe?
When I started to use my heating again I noticed that the air temperature wasn’t accurate anymore. In fact my HA Z-Wave setup does not refresh those values anymore. When I go to to the Z-Wave JS to MQTT Dashboard I can manually refresh the values and they get accurate then.
What did you expect to happen?
The sensor data should get updated regularly.
Steps to reproduce the behavior:

Go to 'MQTT Z-Wave Dashboard'
Click on 'a Eurotronic Valve'
Scroll down to 'Multilevel Sensor' and refresh the Air Temperture
See that the value gets updated now.

Device information
Manufacturer: Eurotronics (Manufacturer ID: 0x0148)
Model name: Spirit
Node ID in your network:  7 (example dump)
How are you using node-zwave-js?

[X] zwavejs2mqtt Docker image (latest)
[ ] zwavejs2mqtt Docker image (dev)
[ ] zwavejs2mqtt Docker manually built (please specify branches)
[ ] ioBroker.zwave2 adapter (please specify version)
[X] HomeAssistant zwave_js integration  (please specify version)
[ ] pkg
[ ] node-red-contrib-zwave-js (please specify version, double click node to find out)
[ ] Manually built from GitHub (please specify branch)
[ ] Other (please describe)

Which branches or versions?
version:
node-zwave-js branch:  HA version: 0.1.45,  version 8.4.1
zwavejs2mqtt branch: : HA 0.27.0  version 8.4.1
Did you change anything?
no
If yes, what did you change?
No response
Did this work before?
Yes (please describe)
If yes, where did it work?
It did work with Open Z-Wave beta, but I'm not sure if it did with Z-Wave JS in a previous version.
Attach Driver Logfile
{
  "id": 7,
  "name": "Tstat Salon Entree",
  "loc": "Salon",
  "values": [
    {
      "id": "7-49-0-Air temperature",
      "nodeId": 7,
      "commandClass": 49,
      "commandClassName": "Multilevel Sensor",
      "endpoint": 0,
      "property": "Air temperature",
      "propertyName": "Air temperature",
      "type": "number",
      "readable": true,
      "writeable": false,
      "label": "Air temperature",
      "ccSpecific": {
        "sensorType": 1,
        "scale": 0
      },
      "stateless": false,
      "unit": "°C",
      "list": false,
      "value": 21.58,
      "lastUpdate":<PHONE_NUMBER>858,
      "newValue": 21.58
    },

  "productLabel": "Spirit",
  "productDescription": "Thermostatic Valve",
  "manufacturer": "Eurotronics",
  "firmwareVersion": "0.15",
  "protocolVersion": 3,
  "zwavePlusVersion": 1,
  "zwavePlusNodeType": 0,
  "zwavePlusRoleType": 7,
  "nodeType": 1,
  "endpointsCount": 0,
  "endpointIndizes": [],
  "isSecure": "unknown",
  "supportsSecurity": false,
  "supportsBeaming": true,
  "isControllerNode": false,
  "isListening": false,
  "isFrequentListening": "1000ms",
  "isRouting": true,
  "keepAwake": false,
  "maxDataRate": 100000,
  "deviceClass": {
    "basic": 4,
    "generic": 8,
    "specific": 6
  },
  "deviceId": "328-1-3",
  "status": "Alive",
  "interviewStage": "NodeInfo",
  "statistics": {
    "commandsTX": 95,
    "commandsRX": 75,
    "commandsDroppedRX": 0,
    "commandsDroppedTX": 0,
    "timeoutResponse": 0
  },
  "lastActive":<PHONE_NUMBER>260,
  "batteryLevel": 95,
  "_name": "Tstat Salon Entree (Salon)"
}

Here the log file plus some debug logs about node 7. It shows that the regular polling includes Air temp but does not update the value. But after a manual refresh it does it.
log_MQTT_21-07.txt
zwavejs_2021-10-25.log

Ok could update the Z-Wave (zwavejs2mqtt) version in the meantime and after re-interviewing the problems seems to be resolved.
zwavejs2mqtt: 5.10.1
zwave-js: 8.6.1

Also the new security level feature does show up correctly now.
I did as well had a look at the associations but couldn't figure out how to do it. For my understanding a association is between z-wave nodes and not between a node and the server, except the lifeline as it is setup by default. But I might be wrong here.

except the lifeline as it is setup by default

And that one is sometimes wrong or missing :)

Frankly I don't have a clue about how I can handle those associations in zwavejs2mqtt.

And if I look at another z-wave climate thermostat (Heltun); it has the same association and works perfectly well in updating the air temp. BTW after an hour or so HA doesn't show the actual temps anymore.

That looks like it is already set up correctly. If not, check out the driver logs if anything is coming in at all.

Here's the log of the Air temp section.
   {
      "id": "7-49-0-Air temperature",
      "nodeId": 7,
      "commandClass": 49,
      "commandClassName": "Multilevel Sensor",
      "endpoint": 0,
      "property": "Air temperature",
      "propertyName": "Air temperature",
      "type": "number",
      "readable": true,
      "writeable": false,
      "label": "Air temperature",
      "ccSpecific": {
        "sensorType": 1,
        "scale": 0
      },
      "stateless": false,
      "unit": "°C",
      "list": false,
      "value": 20.78,
      "lastUpdate":<PHONE_NUMBER>143,
      "newValue": 20.78
    },

It seems the node is only active when the setpoint is getting changed from the HA scheduler.

That's the same log if the Heltung sensor that works fine:
The difference are   "stateless": false, and  "list": false on the spirit are not listed on the Heltung.  List seems to be the interesting one.
   {
      "id": "2-49-0-Air temperature",
      "nodeId": 2,
      "commandClass": 49,
      "commandClassName": "Multilevel Sensor",
      "endpoint": 0,
      "property": "Air temperature",
      "propertyName": "Air temperature",
      "type": "number",
      "readable": true,
      "writeable": false,
      "label": "Air temperature",
      "ccSpecific": {
        "sensorType": 1,
        "scale": 0
      },

I think I did find the final step of the solution. While browsing again to the manual I stumbled on the parameter 5, which defines the threshold (Delta) when the air temp is going to be send. This was still on the default value of 0.5 °C. So small temp changes, which are required for my automation are not transmitted at all. In a heating steps of 0.5 °C are often used but before the upgrade to the latest version even those haven't been transferred. The history was a string also at night when my room temp goes down by 2  °C .

Now it works as it should:

That parameter setting according to the manual should be a multiple of 0.1, 5 (default) being .05 degree and 1 being 0.1 degree change. Mine automatically reports the temp when it is set to 1 (0.1) but not when it is set to the default 5 (0.5) and temperature report only changes if I manually poll it.

Good catch - I've opened https://github.com/zwave-js/node-zwave-js/pull/3659

That parameter setting according to the manual should be a multiple of 0.1, 5 (default) being 0.5 degree and 1 being 0.1 degree change. Mine automatically reports the temp when it is set to 1 (0.1) but not when it is set to the default 5 (0.5) and temperature report only changes if I manually poll it.

My thermostat did stop polling again (with param set to 0.2 degree). What do you mean with manual polling exactly @stellavision.

Polling means sending a GET request to the device so it responds with a report. Z-Wave JS doesn't do that automatically, except for verification after a SET. For modern devices like this one, it shouldn't be necessary to poll.
It could also be that the device tries to send an update but the reports are getting lost due to a bad connection to the controller.

You mean automatic reporting, not polling 😉

I just fixed another issue with not reported states on nodes and could fix it with downgrade of the Z-Wave JS to MQTT HA Addon.
That the versions will rise the different problems:
zwavejs2mqtt: 5.10.1
zwave-js: 8.6.1

Z-Wave JS to MQTT: 0.28.0

Z-Wave JS to MQTT: 0.27.0 with the same other versions will fix all the issues including the Eurotronic not reporting Air temperature changes above 0.1 degree.

Ok seems to be fixed in the newest version.
Z-Wave JS to MQTT, V 0.30.0
zwavejs2mqtt: 5.12.0
zwave-js: 8.7.6

Sorry for gravedigging. I've got the problem on the most current version of everything (since I reinstalled everything just this week).
While I'm able to set heat/off and so on, the current temperature measured at the thermostat is only updated when actively hitting refresh in zjsui.
Was there a setting you changed, which helped with the auto reporting?

No issues here with.
zwave-js-ui: 8.2.2
zwave-js: 10.3.0
home id:

So I have actually one out of 5 thermostats that is working, while all the others do not.
Pastebin debug.log of the working node
and of one not working node
Has anyone any ideas, how this could be? As I've said, this is on a fresh installation.
Help would be really appreciated, as it's getting colder and colder :)

Did you play around with the Temp report threshold? That's the only method so far to fix it.

I think i'm seeing something very familiar with the CometZ valves - rendering them almost useless to control heating

@AlCalzone could you please let me know exactly where to report it. I feel directed to report in HA core issues after looking through the checklists in, but i'm using JSUI. I'll post where you suggest best. Thanks

@cadwizzard if the device is reporting unreliably, and you've excluded connectivity issues [1] [2], then I'm afraid the correct place to report it is<EMAIL_ADDRESS>🤷♂
Z-Wave JS can't do anything about the device not sending the reports.

@cadwizzard if the device is reporting unreliably, and you've excluded connectivity issues [1] [2], then I'm afraid the correct place to report it is<EMAIL_ADDRESS>🤷♂
Neither Z-Wave JS nor HA can do anything about the device not sending the reports.

I think that it's maybe not the TRV itself the more I look into this. Every one behaves the same, it's not connectivity as I have several dispersed in a very well connected mesh (most of 60 nodes are powered, except the trvs).
After interview they can be fine for a while in JSUI, reporting every .5 degree then seemingly intermittent with a manual sensor refresh getting the right info straight away.
Other people in other posts are seeing this weirdness. Re-interview seems to solve it for a while each time. The symptoms are almost exactly the same as were fixed for the spirit.
Maybe they are sending messages that are being misinterpreted?
(I posted here too also help anyone searching the same for the CometZ)
I have these (4) currently in use in a house with nearly 20 spirits.
I'd really like to submit in the right place and have someone who knows what they are looking at to check logs etc..  or I'll simply have to just remove them all (this behaviour just leaves the boiler on forever with all the valves closed)

Maybe they are sending messages that are being misinterpreted?

If that's maybe the case, here is the right place. I'll need some additional info to go with the logs, e.g. some timestamps where you expected a change but got none. Note that it may be a while until I can look at it.

Thanks. I'll post as much info as possible and leave one of these included
in a room that has two TRVs (so I can use a spirit to reliably run the
boiler there).
That way the timing works to your schedule and commitments ;)
Thanks again.
On Mon, 22 Jan 2024, 20:59 AlCalzone, @.***> wrote:

Maybe they are sending messages that are being misinterpreted?
If that's maybe the case, here
https://github.com/zwave-js/node-zwave-js/discussions/new?category=request-support-investigate-issue
is the right place. I'll need some additional info to go with the logs,
e.g. some timestamps where you expected a change but got none. Note that it may
be a while https://github.com/zwave-js/node-zwave-js/issues/6521 until
I can look at it.
—
Reply to this email directly, view it on GitHub
https://github.com/zwave-js/node-zwave-js/issues/3593#issuecomment-1904806944,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2VEALZVVTHDR3DHPASODTYP3HL5AVCNFSM5GVNI7RKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJQGQ4DANRZGQ2A
.
You are receiving this because you were mentioned.Message ID:
@.***>

@AlCalzone and to point others in the right direction in relation to CometZ --> https://github.com/zwave-js/node-zwave-js/discussions/6634


Fix get all clients method

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.92%. Comparing base (5915c71) to head (ce1f5ab).

Files with missing lines
Patch %
Lines

lib/timely-app/client/clients.rb
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   78.92%   78.92%
=======================================
  Files          21       21
  Lines         299      299
=======================================
  Hits          236      236
  Misses         63       63

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ci: merge staging to master

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

Pipeline Succeeded on<PHONE_NUMBER> for 8ee46ae4c1065e2c0944ae33751c6021b7a77658
https://gitlab.com/MatrixAI/open-source/js-mdns/-/pipelines/1037746077

Pipeline Attempt on<PHONE_NUMBER> for cbee3c732858be01d798b7b90a4aef71e4222479
https://gitlab.com/MatrixAI/open-source/js-mdns/-/pipelines/1037784329

Pipeline Succeeded on<PHONE_NUMBER> for cbee3c732858be01d798b7b90a4aef71e4222479
https://gitlab.com/MatrixAI/open-source/js-mdns/-/pipelines/1037784329


Cloning problem when installing project

I have a big problem with cloning the guzzle project by composer.
always the command will die when i wanna install guzzle
Whats wrong ??!
[Symfony\Component\Process\Exception\ProcessTimedOutException]
The process "git clone --no-checkout 'https://github.com/guzzle/guzzle.git' '/var/www/html/project/vendor/guzzlehttp/guzzle' && cd '/var/www/html/project/vendor/guzzlehttp/guzzle' && git remote add composer 'https://github.com/guzzle/guzzle.git' && git fetch composer" exceeded the timeout of 300 seconds.

What happens when you issue this command manually?

I have still same error when i call manually the command. @Konafets
i just have the problem with this package :(

I doubt this has anything todo with guzzle itself. Could be a setting in your PHP env, composer or your internet connection.

Is there any differences when you clone via SSH or via HTTPS?
$ git clone git@github.com:guzzle/guzzle.git

$ git clone https://github.com/guzzle/guzzle.git

Permission denied !!!!
@Konafets

As @Konafets says. This is not related to Guzzle.
Have a look at the github help pages: https://help.github.com/articles/error-permission-denied-publickey/
Google is your friend here.


Empty Zip Folder

I sent stickers from the Bubo the Scarfcat pack (and the whole pack) to it and it only sends back empty zip files. I tried with one from a different pack and it worked fine.

fixed

fixed


Renaming blacklist/whitelist

From the code of conduct

Using welcoming and inclusive language

In the light of recent current events, many projects are moving to more inclusive language. Since it's dubious to keep a name that could be problematic when alternatives exist--especially when a name has the opportunity to be more clear--it's probably a good idea if this project joins the ranks.
It seems most projects from Chromium, to Drupal, to Rails, to et.al. have chosen whitelist → allowlist and blacklist → blocklist.

Hi @toastal, thank you for this.
This would be a breaking change affecting a lot of things.  We could only do something like this in the context of a major version release.  In other words, this would not be a patch, or a minor change.
At minimum we would need to enumerate all the plausible issues in userland, and provide automated means to deal with this including supporting both, for a time, with deprecation notices.
This won't happen unless it becomes a priority.  And it certainly won't happen soon.

If I can add something. I'm not personally offended by the terms blacklist, whitelist and master.
And technically speaking, those terms are already present everywhere. It's like the recent discussion about changing the master branch name to something else because of the "recent current events". Most of us can probably do the difference between a technical word and a non-inclusive language.
If we really want to change that, let's start with the TV series The Blacklist, the whole list of RFC regarding the DNS specification, the policies of each countries in the world and let's not forget the Linux Kernel!
I do understand that Android / Google Chrome, Drupal, Rails [etc.] renamed those words. But the context and the way those changes can be applied and deployed are way easier than what we do here.
I do understand the "why" and I know it's not a bad idea at all as it makes it more inclusive. But changing a whole bunch of technical words is not going to change the world regarding the "recent current events". If we would want to, we will need to contact all list maintainers in the world and that's impossible.
I do understand the why those discussions are starting only now. But it's kinda hypocrite as those discussions could have started years ago when the RFCs were written or when those denominations where chosen in the technical fields.
I'm sure that most of us can do the difference.
My opinion.

Let's talk about the change itself.
This change is hard to apply as this project is not a program itself. We are here talking about an incalculable scale. Changing the name of the whitelist file alone will cause some drastic change across the globe. This list is used by so many infrastructures, machines, systems that such change can become really painful.
Let's take the example of the recent discussion about renaming the name of the master branch to something else. That will break a lot of things for a repository of this size and reputation as everybody is writing his own script or infrastructure based on what we have here. It's not that easy to deploy such change.
That will probably apply to the modification of the terms.

and if we think like this does we have to rename our css too from color : black to color : #000000 ?, no you can't just ask for changing our variable name, and list name in the technical code.

But Certainly not everywhere !

Would it be a problem to make the name of the generated files configurable ? I'm not seeing a lot of code involved in the blacklist/whitelist filenames. Similar to what was done in git for the default branch name. that would help with deprecating the default filenames and software that do rely on keeping those outdated names can still configure this script to output the name they expect.

@theodoreb Political matter have no place in technical development and list code, you can't just ask to redo all code just because the actual political problem.
Whitelist and Blacklist is used in thousand of software who turn on server, and the time to rename all of that code will cost too much money to be done.
So yes black live matters and all of that BUT political problem have no place in Technical World

I'm talking about adding feature to the software here.

I am surprised about some statements here. This is about a language that implies that white is good and black is bad. There is no doubt that this language is not inclusive. And this is not about changing the world or changing the history, historical documents as such. This is about changing the future. Using different words from now on. Stop using blacklist as a word. Start using blocklist from now on. I do not understand how somebody could be against that approach.

I'm going to close lock this because we've had enough input on this.  We aren't changing it.