flags aren't working on terminal.

qrrs "testing" --invert_colors
error: Found argument '--invert_colors' which wasn't expected, or isn't valid in this context
If you tried to supply --invert_colors as a value rather than a flag, use -- --invert_colors
Is it just been deleted?

This is probably due to the fact that the binaries in releases were last time updated a long time ago, I pushed new tag with latest changes from master so version that resides on crates.io/precombiled binaries must include latest features.


Add Navigation Arrows to Wiki

I was just toying around with the Wiki, and I think some navigation arrows would be beneficial. Check out A  for an example.

Done as of automation #305


Linux: No input file

I compiled with WSL yesterday on Ubuntu 18.04, and when it finished compiling I installed the package. I got nothing really from it, just aborted a second later.

Do you have the dependencies installed: https://github.com/dotnet/corert/blob/master/samples/prerequisites.md#ubuntu-1404?

Yes I have installed .NET Core SDK, and clang-3.9 zlib1g-dev libkrb5-dev.

Can you write down your exact steps for compiling? I don't know what you mean by "when it finished compiling I installed the package". It sounds like an important thing for me to understand.

I'm sorry for the lack of information.
IDE: Jetbrains Rider
I have followed the provided tutorial in the Hello World example. I installed CoreRT, and so on. It builds perfectly for Windows. When I go onto compile for Linux, it compiles perfectly fine, but the package returns packagename: No input file once you install it on Linux.

Scratch what I said about Windows, now it's throwing an exception of not being able to find mscorlib

Try again with the latest CoreRT build. I think the mscorlib failure should be fixed by #7709.


Remove max_pipelines parameter from AutoMLSearch

Closes #1201
Codecov fails because there are some lines in automl_search.py that are not tested and I'm decreasing the total number of lines in the file.

@dsherry I cleaned up the merge conflict but will need you to merge since codecov is failing 😢

@angela97lin thanks for updating branch, merging shortly

Ok, merging!


[FEATURE REQ] Need add request in TokenCredential.getToken

Is your feature request related to a problem? Please describe.
In Fluent Java, we use host to determine which token we would get from server. Thus, we can't just use scopes as the only parameter for TokenCredential. I think the HttpRequest could be added in TokenRequestContext or in the parameter of TokenCredential.getToken.
Describe the solution you'd like
Solution as above.
Describe alternatives you've considered
Additional context
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Description Added
[x] Expected solution specified

@g2vinay is this still an unresolved issue?

The Identity sdk uses MSAL underneath, which only accepts scopes, it would not be appropriate to parse the scopes from an HttpRequest at the Identity SDK level as that should be done at the higher level where TokenCredential is being used.
The recommended approach would be to parse the scopes according to the host on your end and then pass that to TokenRequestConrext in the getToken API call.
You can see an example here


Add BackGround MapItem

Issue

close #346

Overview (Required)

Added background to Preview. Used Surface.

Looks great! Thanks!


Tar files open too slowly and have no busy indicator

Description
When I open large tar file such as an export of WSL (~1.3GB) it takes very long time to open:

about 10s to open new tab

new tab is empty and there is no busy indicator

about minute for files to show up

Meanwhile any other app such as 7-zip can open it instantly (less than a second).
PS. Your bug template says to use "Win" + "Pause/Break" to get windows version but many modern keyboards don't have "Pause/Break" button anymore. You might wanna give alternative instructions such as Start -> System.
Steps To Reproduce

wsl --export Ubuntu ubuntu.tar
Open ubuntu.tar in Files

Expected behavior
Tar files open instantly. List view is populated incrementally as the tar file is parsed since it is a streaming format after all.
Use busy indicator when busy.
Files Version
Version: <IP_ADDRESS> OS Version: 10.0.22000.918
Windows Version
Windows 11 21H2 22000.918
Relevant Assets/Logs
debug.log
debug_fulltrust.log

Merging with #9495

Reopening to keep track of the fact that archives don't load item incrementally like folders.

Is that something we can change with wasdk?


Transliterate library

Transliterate library for first and last name in the DGC
The JSON schema imposes a transliterated string of the name, only using certain chars ('^[A-Z<]*$')
I would appreciate a method that can transform names having non latin characters to that char set.
I believe all DGC issuers could use that same method.

@Steffen, please discuss in scope definition

+1 vote for this after our mistake in https://github.com/eu-digital-green-certificates/dgc-testdata/issues/220


how to fix xiwi scrolling?

sudo edit-chroot -all
kali
My Problem is in a xiwi server (i knew this before) that my scrolling is not working and also this error when i add touch command
"touch is not available in debian"
audio is working after all; and when i look at connected devices it show no mouse,touchpad

Me too have had problems with mouse & two-finger scrolling in xiwi and it has been months that I have to use xorg for crouton. I like xiwi and I really hope that I can continue to use it. It was reported that Chrome 89.0.4389.95 brought it back momentarily, but shortly after that, 90.0.4430.86 again made scrolling impossible in xiwi.

sudo edit-chroot -all
kali
My Problem is in a xiwi server (i knew this before) that my scrolling is not working and also this error when i add touch command
"touch is not available in debian"
audio is working after all; and when i look at connected devices it show no mouse,touchpad

A quick search told me that there has been a work-around for this. Just set AutoAddDevices to true in /etc/X11/xorg-dummy.conf
https://github.com/dnschneid/crouton/issues/4448#issuecomment-834069293


simulate rsvps for realtime quickstart

The feed http://stream.meetup.com/2/rsvps was retired. As an external dependency, this should not be used to fail builds.

Codecov Report

Merging #8180 (21540d6) into master (5fa4737) will decrease coverage by 57.25%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #8180       +/-   ##
=============================================
- Coverage     71.41%   14.16%   -57.26%
+ Complexity     4302       81     -4221
=============================================
  Files          1623     1578       -45
  Lines         84312    82431     -1881
  Branches      12639    12435      -204
=============================================
- Hits          60213    11675    -48538
- Misses        19974    69888    +49914
+ Partials       4125      868     -3257

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
14.16% <ø> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa4737...21540d6. Read the comment docs.

We want to have some real data in the quick-start instead of random values for demo purposes. Is there a replacement for the retired stream? If not, we should probably consider changing it to use the github events stream

We want to have some real data in the quick-start instead of random values for demo purposes. Is there a replacement for the retired stream? If not, we should probably consider changing it to use the github events stream

I don't think depending on a third party stream to gate PRs is a good idea, because they tend to change or can even be removed.

I don't think depending on a third party stream to gate PRs is a good idea, because they tend to change or can even be removed.

Agree. We can probably add a quick-start to use this random event generator for testing purpose.


Respect  in .csproj

Environment data
dotnet --info output:
.NET Command Line Tools (1.0.1)

Product Information:
 Version:            1.0.1
 Commit SHA-1 hash:  005db40cd1

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.12
 OS Platform: Darwin
 RID:         osx.10.11-x64
 Base Path:   /usr/local/share/dotnet/sdk/1.0.1

VS Code version: 1.11.2
C# Extension version: 1.9.0-beta3
Steps to reproduce
Create project with single class. In .csproj add line:
<NoWarn>$(NoWarn);CS1591;CS1573</NoWarn>

Expected  behavior
There should be no warnings in "Problems" output.
Actual behavior

This issue was fixed for project.json (https://github.com/OmniSharp/omnisharp-roslyn/pull/734), but new .csproj still does not respect nowarn.

OmniSharp does support NoWarn for csproj, it's just a little finicky about it. Don't include the "CS" -- just the raw numbers.
<NoWarn>$(NoWarn);1591;1573</NoWarn>
I've filed https://github.com/OmniSharp/omnisharp-roslyn/issues/826 to improve the support here. Thanks!

@DustinCampbell thank you! It works!


Add option to enable brotli nginx plugin

What's the purpose of this pull request?
Allow the nginx plugin to enable brotli encoding in the generated configuration.
ngx_brotli -> https://github.com/google/ngx_brotli
How it works?

Set NGINX_BROTLI env var to true when building the gatsby site
A set of directives enabling brotli compression will be added to the generated config
Launch nginx with the generated config - the nginx must have the brotli plugin installed, otherwise launch will fail (this is the reason why the feature is opt-in)
The response to any requests which Accept-Encoding header contains br will be brotli-encoded.

How to test it?
see previous topic and then one might use the following nginx image https://hub.docker.com/r/fholzer/nginx-brotli/ which has brotli installed statically instead of the original docker image in the docker:serve npm script.
References

reinforcing what @tlgimenes said, why not receive this flag becomes options for the plugin?

reinforcing what @tlgimenes said, why not receive this flag becomes options for the plugin?

@emersonlaurentino gimenes and I discussed offline. In the end we decided to have it enabled by default, and the config disables it. It's already an option for the plugin as well, however env var takes precedence (it isn't set in our pipelines, but a client may choose to disable it via their plugin option). env var NGINX_DISABLE_BROTLI > plugin option disableBrotliEncoding which is by default false.

@emersonlaurentino gimenes and I discussed offline. In the end we decided to have it enabled by default, and the config disables it. It's already an option for the plugin as well, however env var takes precedence (it isn't set in our pipelines, but a client may choose to disable it via their plugin option). env var NGINX_DISABLE_BROTLI > plugin option disableBrotliEncoding which is by default false.

but having two ways of doing the same thing doesn't seem to me scalable. But how nice that via plugin is already agreed.

but having two ways of doing the same thing doesn't seem to me scalable. But how nice that via plugin is already agreed.

but having two ways of doing the same thing doesn't seem to me scalable. But how nice that via plugin is already agreed.

Isn't this kind of a pattern, though? You configure things in a JSON or .env file, but they might be overwritten by environment variables (i.e yarn and NODE_ENV, not sure which one takes preference for yarn, though)

but having two ways of doing the same thing doesn't seem to me scalable. But how nice that via plugin is already agreed.

Isn't this kind of a pattern, though? You configure things in a JSON or .env file, but they might be overwritten by environment variables (i.e yarn and NODE_ENV, not sure which one takes preference for yarn, though)


0.4.1 release Vinyl error

I'm getting the following error, when using gulp-html2js with the latest release. Upgraded from 0.3.1
\node_modules\gulp-html2js\node_modules\vinyl\index.js:120
    if (!this.path) throw new Error('No path specified! Can not get relative.');
                    ^

Error: No path specified! Can not get relative.
    at File.Object.defineProperty.get (\node_modules\gulp-html2js\node_modules\vinyl\index.js:120:27)
    at DestroyableTransform.bufferContents [as _transform] (\node_modules\gulp-concat\index.js:70:20)
    at DestroyableTransform.Transform._read (\node_modules\gulp-concat\node_modules\readable-stream\lib\_stream_transform.js:184:10)
    at DestroyableTransform.Transform._write (\node_modules\gulp-concat\node_modules\readable-stream\lib\_stream_transform.js:172:12)
    at doWrite (\node_modules\gulp-concat\node_modules\readable-stream\lib\_stream_writable.js:237:10)
    at writeOrBuffer (\node_modules\gulp-concat\node_modules\readable-stream\lib\_stream_writable.js:227:5)
    at DestroyableTransform.Writable.write (\node_modules\gulp-concat\node_modules\readable-stream\lib\_stream_writable.js:194:11)
    at PassThrough.ondata (_stream_readable.js:529:20)
    at emitOne (events.js:90:13)
    at PassThrough.emit (events.js:182:7)

Hi @duluca I'm guessing it's because this upgrade also changes the api(as it's from v0.3 to 0.4). Can you refer to the usage section and check what changes you need to make to make your code work?

Thanks, I'll try out the angular adapter. For any breaking change, I'd recommend upping the major release version (per semver) so npm doesn't automatically update.

npm will only update when it's from v0.3.1 to v0.3.2 but not v0.4.1, no?

By default npm installs packages with ^, the behavior you're describing
happens with ~, which not many people bother to change. But furthermore
semver does describe the last number as a patch, second number for
non-breaking improvements and the first number for major breaking changes.
This why we are at Node 5.6.0 in less than a year :)
On Wed, Feb 17, 2016 at 6:15 PM Fraser Xu<EMAIL_ADDRESS>wrote:

npm will only update when it's from v0.3.1 to v0.3.2 but not v0.4.1, no?
—
Reply to this email directly or view it on GitHub
https://github.com/fraserxu/gulp-html2js/issues/20#issuecomment-185452265
.

--
Best,
Doguhan Uluca
540-257-5143

FYI, the rule is applied to ^ differently if the version is 0.x.x.
https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004

Good to know. Thanks a bunch. Since then I've started using npm-shrinkwrap, it helps avoid surprises.

@duluca I agree that npm-shrinkwrap works great for mission-critical systems. Anyway I noticed the breaking change at this issue. Thanks for opening it!

Just in case this helps anyone in the future, I upgraded my gulp-html2js version and had to change how I used it from:
html2js({
          outputModuleName: 'templates'
        })
.concat('templates.js')

html2js('templates.js', {
          outputModuleName: 'templates'
        })


Add multiwallet configuration to config file

This commit sets up the config file for use in the multiwallet refactor.
Each coin has its own config added with the idea that, abset the config, the
defaults will be used.
This commit does not change the existing wallet config object which will be
deprecated when the full refactor is complete.

Coverage increased (+0.2%) to 31.921% when pulling 7463d8b388e20cec8eb90feec1594d564c06eff8 on multiwallet into e4f4bee1b02715565265a6d85aa5d3ce8f6e19de on master.


fix(resizable): get class name

Currently, nested columns do not have a width.
Changed to have width by changing class name.

Codecov Report

Merging #375 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   63.83%   63.83%
=======================================
  Files          21       21
  Lines         459      459
  Branches      102      102
=======================================
  Hits          293      293
  Misses        145      145
  Partials       21       21

Impacted Files
Coverage Δ

packages/reactabular-resizable/src/helper.js
90.32% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89bfbc0...78587fd. Read the comment docs.


Disable functionality and warn if caches are not yet built

Some IDEs can have a long caching phase, we need to disable the plugin functionality and warn the user about it (otherwise he can't use any of IDE features).

Will make a separate branch to avoid problems with my master


Unable to start the app as per the instructions in the documentation

Note: this is the technical bug tracker, please use other platforms for getting support and starting a (non technical) discussion. See the getting help page for details.
I'm submitting a ...
[O] bug report
[ ] question about the decisions made in the repository
Action taken (what you did)
I have executed the command node gekko --ui on my ubuntu 16.04 with node version 10.4.x
Expected result (what you hoped would happen)
Open up the UI(I assume this based on the documentation instructions)
Actual result (unexpected outcome)
Got the below Error

gekko/node_modules/promisify-node/utils/args.js:9
var args = func.toString().match(/function\s.?(([^)]))/)[1];
^

TypeError: Cannot read property '1' of null
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)
Stack Trace:

TypeError: Cannot read property '1' of null
at module.exports (<HOME_PATH>/gekko/node_modules/promisify-node/utils/args.js:9:63)
at processExports (<HOME_PATH>/gekko/node_modules/promisify-node/index.js:61:29)
at module.exports (<HOME_PATH>/gekko/node_modules/promisify-node/index.js:164:10)
at Object. (<HOME_PATH>/gekko/web/routes/scanDateRange.js:4:14)
at Module._compile (internal/modules/cjs/loader.js:702:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
at Module.load (internal/modules/cjs/loader.js:612:32)
at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
at Function.Module._load (internal/modules/cjs/loader.js:543:3)
at Module.require (internal/modules/cjs/loader.js:650:17)
at require (internal/modules/cjs/helpers.js:20:18)
at Object. (<HOME_PATH>/gekko/web/server.js:56:26)
at Module._compile (internal/modules/cjs/loader.js:702:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
at Module.load (internal/modules/cjs/loader.js:612:32)
at tryModuleLoad (internal/modules/cjs/loader.js:551:12)

Node Version 10.4.x

I am more comfortable with python and exploring Gekko to see if I can write my python codes on gekko setup and do backtesting. So, I am not sure what I am missing. May be this can be a small mistake but I am not so much into JS tech stack at the moment. So, please help me with this bug / error.

please install bot exactly like it is said in the documentation : https://gekko.wizb.it/docs/installation/installing_gekko.html
before starting the bot you need to run  : npm install --only=production

This bug has been reported but I have not been able to reproduce. However I think this has been fixed since the 0.6 release. Can you please redownload the latest version and try again? Thanks!


Fix bug in prefix enforcement when no subpackages are present

A bug in package prefix enforcement (see attached failing test) prevents us from catching certain mis-packaged names when no sub-packages are present. This PR fixes that bug.
Motivation

Bugfix.
Test plan

See included automated tests. Tested on Stripe codebase.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_LtCKn1RfaFB3jZ
→ https://go/builds/bui_LtCK6yp8247Jk3

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_LtD5dkt5lAu6uN
→ https://go/builds/bui_LtD5K8LWRK5srU

@ngroman Fixed, thanks!


Test for MDVI should probably be a multichain problem

Currently it is a unichain problem b/c I created the test before knowing what these different algorithms were for.

This is now done in #33!


Fix RPC ledger synchronization requirements:

Improve rules for determining when a requested ledger is available.
Reviewers: @JoelKatz @ximinez
This PR supersedes #1039:
Added call to ledger.reset() at https://github.com/ripple/rippled/pull/1041/files#diff-99441c0d4fe37887d54d1c2f2c0939b0R81, and cleaned up trailing whitespace.

Nice catch! :+1:


README.md: Fix 'wit' -> 'with' typo

This snuck in with 9f35e49f (Updating README to sync with Makefile
deletions, 2015-05-19, #284).

Thanks!

Nice catch.


Feat- created the volume button in the header so its accessible acros…

created a volume slider button which controls the volume of the game audio. also added a minute screen so you can see the value of the volume you are using.
This resolves #28

just updated the design and now its done


Add WKNavigationDelegate AuthenticationChallenge support

add WKNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler: support

Thanks!

This breaks if no _webViewDelegate is set with an exception that the completion handler must be called. I think just adding the else below should fix it
 else {
        completionHandler(NSURLSessionAuthChallengePerformDefaultHandling, nil);
    }
}

@marcuswestin  please merge this request. We need this fix, thanks a lot


[Bug]: JSON response gets stringified by server

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Slack Conversation
Error in JSON format returned by users' API server gets stringified by Appsmith server.
Steps To Reproduce

Create a REST API e.g. Api1
Enter https://mock.codes/500 in the URI
Drag and drop a text widget and use {{Api1.data.description}} in the Text field

You will notice that the evaluated value doesn't show anything because the response is coming as stringified.
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud / Self Hosted

Issue with Airtable
The data returned by Airtable is in valid JSON format but after deserialization happens in Appsmith the body in ActionExecutionResult contains stringified JSON.
cURL request shows that the response is in valid JSON format
curl --location 'https://api.airtable.com/v0/{baseID}/{tableName}' \
--header 'Authorization: Bearer API_KEY'

{
  "records": [
    {
      "id": "rec3dVlLB33uR0PEE",
      "createdTime": "2022-08-08T10:54:29.000Z",
      "fields": {
        "Name": "test patch",
        "Status": "Todo",
        "Notes": "nice"
      }
    },
    {
      "id": "rec7ZO0YX4wdQRt8Z",
      "createdTime": "2022-08-16T09:45:20.000Z",
      "fields": {
        "Name": "latest id ",
        "Status": "Todo",
        "Notes": "PRAPULLA12@#$%"
      }
    },
    {
      "id": "recB4rdvSYFrIWFsp",
      "createdTime": "2021-11-09T09:07:18.000Z",
      "fields": {
        "Name": "test patch",
        "Status": "Todo",
        "Notes": "nice"
      }
    },
    {
      "id": "recGuJsxd69IeUQ8g",
      "createdTime": "2022-08-08T10:53:09.000Z",
      "fields": {
        "Name": "test patch",
        "Status": "Todo",
        "Notes": "nice"
      }
    },
    {
      "id": "recMSLsSWhz6XLeYa",
      "createdTime": "2021-11-09T09:22:52.000Z",
      "fields": {
        "Name": "Closed",
        "Status": "In progress",
        "Notes": "hi"
      }
    },
    {
      "id": "recZIfsrHIAIEvHkD",
      "createdTime": "2021-11-09T09:07:18.000Z",
      "fields": {}
    },
    {
      "id": "recdfdrpukvoALby9",
      "createdTime": "2021-11-26T06:11:35.000Z",
      "fields": {
        "Name": "test",
        "Notes": "hi"
      }
    },
    {
      "id": "recjBOC8Scg4vTLgo",
      "createdTime": "2021-11-26T06:11:35.000Z",
      "fields": {
        "Name": "test",
        "Notes": "hi"
      }
    },
    {
      "id": "reckB49idYGo3hDdP",
      "createdTime": "2021-11-09T10:29:35.000Z",
      "fields": {
        "Name": "test",
        "Status": "Todo",
        "Notes": "hi"
      }
    },
    {
      "id": "recrPq8EST7K0Soo5",
      "createdTime": "2021-11-09T10:29:35.000Z",
      "fields": {
        "Name": "test",
        "Status": "Done",
        "Notes": "hi"
      }
    },
    {
      "id": "recraPx0luOphnfgM",
      "createdTime": "2021-11-09T09:22:52.000Z",
      "fields": {
        "Name": "Closed",
        "Status": "Done",
        "Notes": "hi"
      }
    }
  ]
}

Solution
The first deserialization is done by this piece of code
ActionExecutionResult result = saasObjectMapper.readValue(body, ActionExecutionResult.class);
Airtable query results can be found as stringified JSON in the body (type object) field of ActionExecutionResult object. The data type of the body field is checked with String and it's a string type that might contain stringified JSON. Later, the body is attempted to convert to a JSON node. In case it failed with a JSON processing error, string type is retained as the fallback type.

Issue with RestApi and GraphQL plugins
If the HTTP status code returned by the user's API server doesn't belong to 2xx then an error response is generated with plugin-specific code, Appsmith error message, and downstream error message. In this conversion, the actual response body gets stored in the downstreamErrorMessage field which is a string type. Thus a valid JSON response will get converted to stringified JSON if the HTTP status code doesn't belong to 2xx.
Solution
This extra piece of code is removed. Thus it ensures that the response returned by the user's API server will propagate to the front-end as is.

So many users have already reported their apps aren't working as expected. Either they need to use JSON.parse in all the occurrences or they have to wait for a fix.
Considering the above scenario I have added the critical label.

Tested with Twilio
Found that the response body in Twilio is basically a Hashmap in Java after the deserialization happens. So in this case the following deserialization suffices.
ActionExecutionResult result = saasObjectMapper.readValue(body, ActionExecutionResult.class);

Regarding Airtable Issue
Looking at the source code it seems we haven't made any changes recently. The last change was made almost 2 years ago. The Cypress test cases are also written in a way so that it expects stringified JSON and therefore, it uses JSON.parse. Now if we make it a valid JSON from the backend before rendering it to the client, there's a chance it might break existing apps of the users that are built on the Airtable plugin. Because in order to access the data returned by the Airtable queries they must have used JSON.parse.
And JSON.parse expects stringified JSON as its input. If we provide a valid JSON to JSON.parse it will error out.
Risk
If make ship the changes regarding making the Airtable query result as valid JSON, that is going to be a breaking change for the aforementioned user group.

Airtable user here (cloud).
The airtable integration stopped working with Appsmith v1.9.15-SNAPSHOT.
.data is now a string and not an object as before. But I'm pretty sure it was an object, since all the binding in my app were working as .data.fields[<field_name>] - and my custom JS objects too.
It's true that if I JSON.parse .data I have the correct object, but it means replacing .data with JSON.parse( .data ) everywhere in my app (tens of instances)
Let's take a text field as an example. In my app I have something like {{ .data.fields[<field_name>]}} and it used to work until v1.9.15-SNAPSHOT. I believe all airtable user did the same, since no JSON.parse was needed to get the .data content.
I noticed the JSON.parse in the tests you are mentioning, and I found it weird too (and probably this is the reason this behaviour found its way to production: it passed the tests).
Hope this helps!

@lelesrc
Thank you very much for sharing your thoughts on this.
I tried Airtable queries with the following versions of Appsmith. And I found the response as stringified JSON in each of them.

Version
Release Date

v1.9.15 (Latest)
April 6, 2023

v1.9.8
Feb 21, 2023

v1.9.2
Jan 6, 2023

Am I missing something?

removed tags related to integrations pod since @subrata71  is looking into this

Can't explain this. Really.
Basically, all of my bindings and functions were working until last update (1.9.15).
I checked the doc (https://docs.appsmith.com/reference/datasources/airtable) and seems that no JSON.parse is involved in the binding example:
// binding response data to a Table widget
{{
  AirtableQuery.data.records.map(row => {
    return {
      "Name": row.fields.name,
      "Employee ID": row.fields.employee_id
    }
  })
}}

So, no clue! I don't have any valid explanation about how my code used to work until 1.9.15 (but I'm sure it did, since I had many end users using my app).
The bottom line is that It's not a big deal to update my app code to JSON.parse .data - as long as this won't change back in the future.
As a side consideration, under a UX perspective, using JSON.parse in every binding dialogue could be sub-optimal in terms of clarity (and probably not immediate for most users). I only use airtable as a datasource, so I don't know if parsing is needed when binding using other integrations. In this case, consistency would be the best design choice.
Thank you for tackling this issue, I'm available for testing if you need!

@lelesrc
Thank you very much for your valuable input. We don't have any clue either 😕 Seems really weird.
However, while we are trying to come up with the best solution can you please check whether the Airtable query result is giving the expected output in the following deploy-preview?
https://ce-22498.dp.appsmith.com (Note: You need to sign up)
Would really appreciate your feedback!

Update
Although we have tried with different versions of Appsmith, the cloud-services remains to the latest version. And that’s where the problem was hiding.
Later, we have run the cloud-services locally and figured out that in cloud-services the response body wasn’t coming out as JSON due to the content-type mismatch.
The way we match the content type in cloud-services is through equality check
MediaType.APPLICATION_JSON.equals(contentType)
In case the contentType holds an additional charset information like application/json; charset=utf-8 then the above equality check fails and the response is coming out as String from cloud-services to Appsmith server.
Solution
contentType.includes(MediaType.APPLICATION_JSON)
Next course of action
We will be creating 3 PRs.

The current PR should exclude the changes made for Airtable plugin and include the fix for RestAPI and GraphQL plugins only
A PR to fix the content-type matching in cloud-services repository
A PR to fix Airtable Cypress tests

Update
The fix is now available on Appsmith cloud i.e. app.appsmith.com with Appsmith Version: v1.9.17.
cc: @lelesrc

Closing this out as per discussions.


Spectroscopy and asl post processing tools

ASL (ARTERIAL spin labelling) and Spectroscopy is important for neuroimaging and other areas
community: it wil make ohif viewer stand alone one stop solution for neuroimaging and other advance imaging and would make the imaging less vendor dependant.

Could you kindly provide the data if it has been anonymized and you can confirm that there is no patient health information present in any of the headers or embedded within the pixel data?

@sedghi Sorry about delay. How many cases you would want? I can share them as anonymised cases through email.

Anything would be helpful


Update ldap.rb to allow unencrypted LDAP Access

The code is failing when connecting to an LDAP with no encryption enabled
vendor/gems/ruby/3.1.0/gems/net-ldap-0.17.1/lib/net/ldap/connection.rb:72:in `open_connection': unsupported encryption method  (Net::LDAP::Error)

The "nil" encryption method doesn't exist, to not use encryption, we can just omit the encryption key in the options hash
See https://www.rubydoc.info/gems/net-ldap/Net%2FLDAP:initialize for more info

@Shaeli do you have a Rubygems account? I'll need to give you push access before you can run scripts/release

@DanHoerst I don't have one but I can create one

I have some changes coming up and would like to get this merged for you so I don't leave this PR in a state of wild merge conflicts.
@DanHoerst I have a RubyGems account and can merge this, then run script/release to get this over the finish line.
My account is: https://rubygems.org/profiles/GrantBirki

@GrantBirki I added you as an owner to https://rubygems.org/gems/entitlements, https://rubygems.org/gems/entitlements-app, https://rubygems.org/gems/entitlements-github-plugin and https://rubygems.org/gems/entitlements-gitrepo-auditor-plugin


Csse pyd2 model convert classes

Description

~currently atop #349~

[x] main Input/Result classes and FailedOperation gained a convert_v(<ver>) function to transform to other version. transformation trivial at this point b/c this is pydantic's purpose, but functions will differentiate at the rearrangement milestone. Needed to actually validate schema_version field so it would overwrite at conversion.
[x] added model_dump, model_dump_json, copy_model to v1 so easier to write code that can take both model types. Levi had done the reverse and added dict, json, copy to v2, but I'm thinking this is the better way. Haven't removed Levi's fns.

Changelog description

Status

[x] Code base linted
[x] Ready to go

Requesting review @davidbrownell, @krachwal, @rfievet, @ketanbj, @varun646, @jyoung3131


Possibility of Table-level ordering in TiCDC

Before asking a question, make sure you have

[X] Searched existing Stack Overflow questions
[X] Googled your question
[X] Searched open and closed GitHub issues
[X] Read the documentation

What is your question?
We have a downstram app that incorporates aggregation operations on the event stream.
For example, given the source table
create table table_source (
id bigint primary key,
a varchar(20)
)

we need to aggregate the cdc data by column a and fill the data into the destination table
create table table_destination (
final_id bigint,
a varchar(20) primary key
)

However, as TiCDC does not guarentee table-level ordering, the aggregated data can be inaccurated.
I wonder if there is any possibility to implement table-level ordering in TiCDC.
Or is there any hints on implementing the reordering of events in downstream apps?
Thanks very much.

Taking canal-json[1] as an example, TiCDC also outputs watermark[2] events to notify data integrity while outputting data change events.
When the consumer needs strong ordering guarantee, watermark can be used to achieve data sorting and deduplication.
for example
(2,'b', ts2)
(1,'a', ts1)
(watermark ts2)
(2,'b', ts2)
(3,'b', ts3)
(watermark ts3)
(watermark ts3)
(4,'b', ts4)

ts2 stands for ts = 2.
The consumer needs to implement a cache for events that outputs before a watermark. After receiving a watermark, the consumer uses the watermark ts to sort the cached events.
For example, (1,'a', ts1) and (2,'b', ts2) can be sorted after receiving watermark ts2; (2,'b', ts2) can be deduplicated after receiving watermark ts3.
Note that the watermark itself may be duplicated, and the consumer also needs to record the largest watermark ts seen.
[1]: TiCDC Canal-JSON Protocol | PingCAP Docs
[2]: Streaming 102: The world beyond batch – O’Reilly (oreilly.com)


Add missing slack values

This adds missing values to the puppet class to stop job builder failing

Is there a reason not to make these class params with the current values as defaults? Just in case we need to change any of them for testing.

Will this actually send notifications?

@deanwilson I don't think there's any particular reason not to but it's not been done anywhere else
@issyl0 to confirm, this can later have notifications re-enabled but right now, for testing, they're disabled.


git-url-parse took org name for repo name when given https://github.com/sphinx-doc/sphinx

>>> import giturlparse
>>> giturlparse.parse("https://github.com/sphinx-doc/sphinx.git")
Parsed(pathname='/sphinx-doc/sphinx.git', protocols=['https'], protocol='https', href='https://github.com/sphinx-doc/sphinx.git', resource='github.com', user=None, port=None, name='sphinx', owner='sphinx-doc')
>>> giturlparse.parse("https://github.com/sphinx-doc/sphinx")
Parsed(pathname='/sphinx-doc', protocols=['https'], protocol='https', href='https://github.com/sphinx-doc/sphinx', resource='github.com', user=None, port=None, name='sphinx-doc', owner=None)

Here is our issues:
https://github.com/moremoban/moban/issues/226

@sks444 @jayvdb can you guys take a look at this since implemented as part of #4.

/cc @sks444 @jayvdb

@chfw this was corrected, sorry it took so long.  I see you moved off my library already.  My apologies.

Thanks for the update. I can move back too. One thing I noticed is both library share the same module name space which makes library switching troublesome for user.

@chfw Yeah, that's my bad.  I probably should have named it something else.

Would you like to update your module namespace? I think it is not that difficult to change.


sections management

It will make my life much easier if the test generator will stop using .pushsection/.popsection and use
just .section statements.
the same section name can be used multiple times in the test source - assembler will combine the pieces to one continuous section
We may need to put code to various locations, not necessary continuous to be able to test fetch unit and instruction caches..

regarding multiple text sections:
Our CPU has Instruction RAM and Instruction Cache, to test combined operation and ability to run code from both we need tests, where the code is placed in specific locations.
As now all test code is placed in one code section ..

Do you use generated data sections in your simulation?  .pushsection/.popsection was added to ensure a separate section for each data region, so that you can easily link them to match the actual memory map.
For text sections, seems like you prefer to have multiple sections? One easy way I can do is to divide the main program and other subprograms to two separate sections.

I do use the data sections, but I don't like .push/popsections commands - our simulation environment doesn't understand them. We do process .sections, which we extended to setup their addresses and thus we generate linker command file automatically.
So please, use just .section commands.
The multiple test sections are needed to test icache, branch, BTB  and fetch units to create address bits aliasing.
What we really need is randomly created multiple text sections, to  make CPU jump between them in pseudo random manner as an option/or test parameter

I created a PR to use .section for all data sections, please add +use_push_data_section=0 to enable it. My original intention of using push/pop section is to allow linking each data section to different memory space, so that you can test load/store from different memories. This is not possible if all data pages are placed in a single data section.

“
I created a PR to use .section for all data sections, please add +use_push_data_section=0 to enable it. My original intention of using push/pop section is to allow linking each data section to different memory space, so that you can test load/store from different memories. This is not possible if all data pages are placed in a single data section.
“
I don’t see any correlation between pushsection/popsection usage vs .section  and “single data section” . Both .pushsection and .section create/continue a section, but the last doesn’t require .popsection statement and more common to use …

Hi,
Look like the new config removes data sections altogether .. I just asked to replace .pushsection/.popsection by .section

Hi,
I don't like the change - there is no separate data sections at all - everything is in section .data now.
As I asked before we need to execute L/S mixes targeted to different types of memory. We have normal external memory, we have I/O type external memory,  we have internal RAM. We have shared memory regions . Now we can't map data spaces to where we want.
I just asked not to use .pushsection/popsection commands and use .section instead!
Also .align 12 is too excessive for stack sections, I think. Initial SP can  be maximum aligned to DW ( 8bytes)
can I get .sections back ?

Ok, I use  +use_push_data_section=1 to restore previous behavior

Ok, I use  +use_push_data_section=1 to restore previous behavior

This is solved now, please check if solves the issue.

Please comment if anything else needs to be addressed for this issue.

I think we are done for now, but we will need to return to the section management later -

generate random text sections and jump between them;
program PMP  regions and permissions randomly and create sections to exercise these permissions for code and data,  machine mode and user mode.  Permissions exercise may include jumps to not valid addresses and crossing the regions boundaries sequentially, etc ..

Sounds good, I am closing this issue for now. We can discuss other issues in a separate thread.


fix spell: stoped

What type of PR is this?
/kind flake
What this PR does / why we need it:
spell fix
Which issue(s) this PR fixes:
Fixes # N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/lgtm Thanks


Add Quest to quest screenshots

Add Quest to quest screenshots so all screenshots of quest completions are grouped

Windows no like :.

This doesn't exactly look the best, but it kind of follows the current naming scheme and should be fine on all platforms 🤷♀

Yeah with Quest() it is fine I guess


refactor!: replace string types with force-validated pydantic types

What I did
All the types used in EIP712 contracts are now using Pydantic annotated types with built-in validation
fixes: #22
Fixes: APE-1782
How I did it
This PR is being developed in coordination with an overhaul of the eth_pydantic_types library here: https://github.com/ApeWorX/eth-pydantic-types/pull/11
How to verify it
Checklist

[ ] All changes are completed
[ ] New test cases have been added
[x] Documentation has been updated

@antazoey 2 tests are broken but will be good to talk about tomorrow and get into how heavy to enforce the pydantic types


Flutter modules don't support custom build types

Steps to Reproduce

Create a new Flutter module project: flutter create --androidx -t module -a kotlin -i swift project_name
Add an additional build type to the build types of the host app, e.g. staging
Try to do a gradle sync or a build

You will receive the following error:
ERROR: Unable to resolve dependency for ':app@staging/compileClasspath': Could not resolve project :flutter.
Show Details
Affected Modules: app

The root cause here is that the flutter jar is only being added as a dependency on a fixed set of build types.

A work around for this is to specify matching fallbacks within the build type:
buildTypes {
	staging {
	    matchingFallbacks = ['debug', 'release']
	}
}

Merging into #30916 as well


Update Methodologies to be string entry OR picklist

Methodologies list is very incomplete, and could have 100s of entries if made complete.  May need to have them be entered by user.  Is there a way to allow both manual entry and selection from a list?  Is there a way to provide a search function in the list?

@ccornick please test this and move to done if complete. Thank you


Please provide a way to disable discarding of response body based on req.fresh evaluation

It is possible to disable the behind-the-scenes logic around the Etag header via app.set("etag", false), but the same cannot be done against its counterpart, If-Modified-Since and Express silently discards a fully rendered response based on just evaluating Last-Modified vs. If-Modified-Since. RFC 7232 says that the 304 response SHOULD be sent in this case, but doesn't say it MUST be sent, which means that some configuration, similar to etag is needed to control this behavior.
In practical terms, I may have a listing of items and Last-Modified in this list would be the time stamp of the last item. Some of the items may be edited, which doesn't change the last modified date of the whole list, but may benefit from intermediate items displayed in their most up-to-date form. This is just an example, though, the req.fresh logic shouldn't enforce this behavior as if it's mandated by the RFC.
Here's an example:
const express = require("express");
const app = express();
const port = 3000;

function index_get(req, res)
{
  // ... evaluates If-Modified-Since, decides to render a new response ...

  // keep the modified date (e.g. listing item was updated, but no new items added)
  res.set("Last-Modified", new Date(2021, 10, 14, 0, 0, 0).toUTCString());

  // runs database queries and generates a slightly different response, which is thrown away because of req.fresh
  res.send("Hello World!");
}

app.set("etag", false);
app.get("/", index_get);
app.listen(port);

console.log("Listening on port %d", port);

Hit F5 a few times and after the first 200 response, all subsequent responses will be 304, even though nothing in the script generates those.
In response.js, in res.send = function send(body) this code calls req.fresh, which evaluates If-Modified-Since vs. Last-Updated and if the latter is the same as the former, it drops the response and a few headers:
  // freshness
  if (req.fresh) this.statusCode = 304;

  // strip irrelevant headers
  if (204 === this.statusCode || 304 === this.statusCode) {
    this.removeHeader('Content-Type');
    this.removeHeader('Content-Length');
    this.removeHeader('Transfer-Encoding');
    chunk = '';
...
    this.end(chunk, encoding);
  }

It would be nice if discarding responses based on req.fresh could be disabled via application settings, similar to how etag generation and evaluation may be disabled.
If you choose not to consider this change, it would be useful if the current behavior is documented. I spent some time trying to figure out why Express silently drops a fully rendered response.

Hi @gh-andre sorry you are having trouble. We can certainly consider adding a setting to control yhe freshness support. There are various ways to disable it today, of course, just not though a setting.
As for the documentation, the res.send docs do currently state that res.send does "HTTP cache freshness support". If you do not feel like that is jot adequate or have any other feedback, please open an issue or pull request against the website repository so the documentation team can addrss it.

As for your last-modified date, you may want to take a lool at https://datatracker.ietf.org/doc/html/rfc7232#section-2.2.1 , namely the following statement which seems to be where your problem lies according to your example:

A representation is typically the sum of many parts behind the
resource interface.  The last-modified time would usually be the most
recent time that any of those parts were changed.

As for the default behavior, I understand your fustration, but SHOULD has aa specific meaning in RFCs:

SHOULD   This word, or the adjective "RECOMMENDED", mean that there
may exist valid reasons in particular circumstances to ignore a
particular item, but the full implications must be understood and
carefully weighed before choosing a different course.

It means that not following something that is a SHOULD is an exception that needs to be weighed carefully. By default, Express is following the proper procol, but performing things that are SHOULD by default. But as you stated, we can certainly add a setting to disable this, so users of the framework who carefully concider they they want to deviate from the standard behavior can do so as they like. You can currently do this in Express today, but just not though a single setting; you can override the fresh behavior with your own (for example just always return stale).

It might be difficult to figure out which of those multiple changed parts are significant and which are not. For example, item description excerpts may not contain visible changes from updates in the list, so their last updated date isn't relevant, but to figure it out is quite a technical challenge. Sending back the 200 response makes it easier and doesn't go against the grain of the RFC because SHOULD is a synonym for RECOMMENDED and is described as a best practice to follow, not as a standard behavior and in cases like this example it makes code more manageable.
Anyway, thank you for looking into this. Much appreciated.  Hopefully this post will provide enough description for somebody who may come across of the same issue.

Sorry, there's some overlap in my response. I didn't notice your last edit.

because SHOULD is a synonym for RECOMMENDED and is described as a best practice to follow, not as a standard behavior

Hm, interesting. Can you link to where that definition of SHOULD is written? The one I quoted (link is https://datatracker.ietf.org/doc/html/rfc2119) seems to indicate otherwise. You seem to me to be describing the MAY keyword, is that right?

Hi @gh-andre it looks like there is already a method to disable the freshness check: add res.set('Cache-Control', 'no-cache'). This is more flexible than a setting like app.set since it can be controlled at a much finer level, but can still be added blanket with the use of a middleware. This would also solve the issue with web browsers and other intermediates incorrectly evaluating against your last-modified response header as well since they have received the instruction not to cache the response.
Please let me know if this works for you or not. If it does not, please be specific in why it does not work and we can further evaluate adding something to better control this.

Can you link to where that definition of SHOULD is written?

It's in the excerpt you mentioned - I read it as if SHOULD and RECOMMENDED describe best practices that should be followed for most cases. As long as it's understood and documented, I read it as it may be used. I do try to follow SHOULD whenever possible, but in the case I described it's quite challenging.
As for browsers sending the request, they are supposed to send a conditional request whenever max-age or any equivalent (Expires, s-maxage, etc) suggests that the response must be revalidated. They could render the old response, indeed - Firefox seems to race cached and rendered responses, but seems to render updated ones in my tests. Chrome seems to do the same.
For no-cache, it's not quite the same. A cached response is controlled by either ETag or Last-Modified and no-cache means just that, so the response always rendered. So, if one wanted response revalidated the last modified time is the most optimal. The ETag requires a full response hashed or a cache of responses, which is harder to enforce with multiple servers.
Having said that, Last-Modified is far from the silver bullet and FireFox seems to ignore max-age in favor of heuristics a lot, so maybe I will resort to no-cache eventually, but for now I'm still trying to figure out how to send conditional requests reliably.
Thanks again for your insights. Very helpful.

It's in the excerpt you mentioned - I read it as if SHOULD and RECOMMENDED describe best practices that should be followed for most cases. As long as it's understood and documented, I read it as it may be used. I do try to follow SHOULD whenever possible, but in the case I described it's quite challenging.

I think you are mostly understanding it, but if your source is the same quote, you can see that SHOULD means that any implementer (like Express) needs to follow it by default. To deviate from SHOULD "the full implications must be understood and carefully weighed before choosing a different course.". I'm confused on why you would expect a SHOULD to not be the default behavior. Can you ellaborate on what, specifically, I am missing from the RFC quote?

For no-cache, it's not quite the same. A cached response is controlled by either ETag or Last-Modified and no-cache means just that, so the response always rendered. So, if one wanted response revalidated the last modified time is the most optimal. The ETag requires a full response hashed or a cache of responses, which is harder to enforce with multiple servers.

I'm not really following here. Can you explain a different way or perhaps, can you link to where you are looking in https://datatracker.ietf.org/doc/html/rfc7234 ?

I'm honestly surprised that I need to elaborate on the difference between no-cache and caching behaviors with ETag and Last-Modified. One disables the cache and the other one makes caching conditional. Using no-cache just to work around a caching implementation that examines fully rendered responses is not quite the same as using it for responses that are intended to be not cacheable by design.

I think you are mostly understanding it

Perhaps it's time to just close this issue. Thanks for giving it a consideration.


Fix classes used for detecting threads

Testing that almost kinda works, but not completely.
If you do like this, this kinda works:
gmail.observe.on("view_thread", (domThread) => {
    console.log("Looking at thread:", domThread);
}

But if you try to chain it into gmail.new.get.thread_data() it seems to fail:
gmail.observe.on("view_thread", (domThread) => {
    console.log("Looking at thread:", domThread);
    const threadData = gmail.new.get.thread_data(domThread);
    console.log("Thread data:", threadData); // reports null!
}

Not sure if fixing that is within the scope of this PR or not though.

I guess either way, it's an improvement, so why not merge it :smile:

FWIW, I am not sure this has worked recently:
gmail.observe.on("view_thread", (domThread) => {
    console.log("Looking at thread:", domThread);
    const threadData = gmail.new.get.thread_data(domThread);
    console.log("Thread data:", threadData); // reports null!
}

I have:
gmail.observe.on('view_thread', function (obj) {
  console.log('view_thread', obj);
  const threadJQElem = obj.dom();
  const threadElem = threadJQElem[0].querySelector<HTMLElement>(
    '[data-thread-perm-id]'
  );
  if (threadElem) {
    const threadId: string | undefined = threadElem.dataset['threadPermId'];
    if (threadId) {
      const threadData = gmail.new.get.thread_data(threadId);

      console.log('view_thread. obj:', obj, threadId, threadData);

     // ....
    }
  }
});

Oh well. It works with email, so IMO it should work with threads too for API consistency.
But that's another issue.


bump grpc to 1.65.0 wrt OCPBUGS-38376

Which issue this PR addresses:
fixes https://issues.redhat.com/browse/ARO-11060
What this PR does / why we need it:
the fix for OCPBUGS-38376 is to upgrade google.golang.org/grpc to v1.65.0, and ARO_RP is still on a lower version of grpc, so bump it too
Test plan for issue:
existing unit and e2e tests
Is there any documentation that needs to be updated for this PR?
NA
How do you know this will function as expected in production?
existing unit and e2e tests

/azp run ci, e2e

/azp run ci

looks like grpc bump has been done in another PR, withdrawing this.


Split ObsDetails tablet landscape orientation in half instead of thirds

This will provide more space for photos and make the non-photo content more closely-resemble the phone layout.

Here is the updated design.
Key changes:

[ ] change the width of the image area to be half the screen instead of a third
[ ] Now, the image area functions exactly as it does on mobile, just with different dimensions. Photos should "fit" inside of the black rectangular area, and a user should be able to swipe left and right inside the left side of the screen to view additional photos in that observation.
[ ] move the fave button to the bottom right corner of the image area, and add back in the carousel of dots indicating what photo a user is viewing


curl: add patch for the HTTP/2 issue

Description of changes
See upstream issue https://github.com/curl/curl/issues/10525

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Diff LGTM (if it isn't merged by the time I'm able to test, I'll test).
Nit: maybe mention that the bump caused this regression in the commit message/why it's not desirable? Though maybe the issue link is sufficient. 🤷♀

My (quick) reading of the upstream issue is that we also need this patch?  https://github.com/curl/curl/commit/87ed650d04dc1a6f7944a5d952f7d5b0934a19ac


WIP: Metadata support in client

Not meageable yet.
This PR adds a new tab in the exercise interface which shows the metadata.
It shows the description of the exercise, with the required and trained skills, and the forward and backward exercises. Information about these exercises and skills are retrieved on demand using the API.
Another addition is the aggregation of trained and required skills into two distinct maps: these associate a skill with the exercises that focus on (or require) it.
For now, consider it as a proof of concept: data are displayed simply, and minimal effort has been done on CSS now (as you will see). Skill names and exercise names are clickable.
One interesting feature would be to compute some simple form of dependency graph of an exercise : which exercises should be done first according to specified backward exercises and skills required.

The PR is clearly not complete, for now it only contains some form of proof of concept. I plan on refactorize and think of better names before considering merging it ;-)

Sorry, I thought you still wanted some feedback. But I now understand you want a more high-level one.
I think it is a good idea to create these pages to describe exercises and to make them available to students while they are learning: this increases, what researchers in education call cognitive clarity.
It is also important to make this description available to the teachers when they are trying to find the right exercise to assign to a student. Would that be possible to link this description to the items of the exercise list shown in the teacher page?
Also, I do not understand the exact purpose of the two new files. Can you extend the PR description to explain that?

Sorry, I am used to create PR for work in project stuff (mainly for tracking purpose and for general features/comments), it was not really clear :-)
I agree with your points, these information are valuable for a teacher and a student, and should be integrated in their respective UI.
The two new files are mainly used as database: they associate for each skill the exercises that require it (or focus on it). This avoids to scan the entire index each time we need to compute the set of exercises to train a particular skill.

So these two files will be computed by learn-ocaml build, right? (Maybe they already are computed in your PR and I missed that part.)

Yes, exactly (https://github.com/ocaml-sf/learn-ocaml/pull/89/files#diff-c8c9cb3c3069ebec9cb911df0ade8372R201).

It took a bit of time but I think the PR is ready. It also adds skills into the teacher tab, but only as a way to review the entire skill base. A future PR will add filtering and more importantly the ability to generate a set of exercises to train a given skill (or as requirement of an exercise). A really naive algorithm is already included into Learnocaml_data, but I'm currently working on it to be more precise.
I've updated the translations and names, I hope it will be clearer this way :)

OK, so I removed the skill tree part since it is not used in this specific PR, and I'll add it with a newer version of the algorithm later. It should be mergeable :) (the "id not found" error we had earlier was due to an inconsistent opam environment).


Fix in build script

Fix to run the script in linux, otherwise it will fail as soon as the script run the package manager and stops.

I propose using #177 instead.


Swift - Cannot get Items Pressed even with conforming YALTabBarViewDelegate

We have two issues after inserting The Folding Tab Bar

The Tab Bar Life cycle functions and the extra button items aren't triggered
The tab bar isn't curved

Me too. I am using Swift and in my UIViewController, I already subscribed to both YALTabBarInteracting,YALTabBarViewDelegate.
I am not getting any responses from extraLeftItemDidPressInTabBarView or extraRightItemDidPressed.
HELP!

Check our update))


5.0.0

@jonathantneal should we merge this in and release a new version of the package? postcss-normalize seems to break because of one of the .replace we have here

I didn’t know that. Yes, I think this is ready for release. Doing one more review of the whole codebase, first.

Not sure if the issue is even related at all but since all tests are passing…

I don’t know how to resolve this, but I noticed that removing these lines from test/postcss-tape.config.js does not cause the test to fail.
		warnings: {
			text: /should warn/
		},

A fix is coming. Found more bugs.

5.0.0 is published! :tada:


Spinner svg

Cannot find if it supports spinner svg (animated)?

You can use css to due with it

First, I'm very glad to find so wonderful  plugin. Second, there's still have a problem when i use it. The Ploygon tag will be converted into path tag. I'm confused.

@victorting SVG content is compressed using SVGO during SVG icon generation.


Edit view for content undefined method error - acts_as_list

NoMethodError in Admin/pages#edit
Showing /Users/tmb/.rvm/gems/ruby-1.8.7-p334/gems/radiant-1.0.0.rc2/vendor/extensions/clipped/app/views/admin/pages/_assets.html.haml where line #5 raised:
undefined method `acts_as_list' for #Class:0x10314b758
Extracted source (around line #5):
2: - include_javascript 'admin/assets'
3:
4: #attachment_list.assets
5:   %ul#attachment_fields{:class => @page.page_attachments.empty? ? 'empty' : ''}
6:     = render :partial => 'admin/page_attachments/attachment', :collection => @page.page_attachments
7:   %p.note
8:     = link_to t('clipped_extension.assets'), '#attach_asset', :class => 'popup'
Trace of template inclusion: /Users/tmb/.rvm/gems/ruby-1.8.7-p334/gems/radiant-1.0.0.rc2/app/views/admin/pages/_fields.html.haml, /Users/tmb/.rvm/gems/ruby-1.8.7-p334/gems/radiant-1.0.0.rc2/app/views/admin/pages/edit.html.haml
RAILS_ROOT: /Users/tmb/radiant/coffee
Application Trace | Framework Trace | Full Trace
Request
Parameters:
{"format"=>"html",
"id"=>"1"}
Show session dump

Response
Headers:
{"Content-Type"=>"text/html",
"Cache-Control"=>"no-cache"}

@jayroh is this still an issue in rc3 or master? @saturnflyer you mentioned config.gem so i'm guessing this was pre-bundler? i just setup a new instance and it runs fine in development and production.

I've not run into this. Bundler should have fixed this. I'll close this, but if it's still a problem, please re-open.

As far as I know this should be ok in RC3.  I've set up a handful of instances of Radiant using RC3 and I can't recall having run into this at all since RC2.
Probably safe to close this one back out.  Thanks for raising it back up, John.


[TACHYON-646] Use createNewClassInstance to improve Allocator factory

https://tachyon.atlassian.net/browse/TACHYON-646

use createNewClassInstance to implement new Allocator$Factory
remove unreferenced AllocatorFactory class and AllocatorType class

Can one of the admins verify this patch?

ok to test

Mostly look good to me with two minor comments left. Thanks for the patch!

@gpang, please review this PR

We can’t automatically merge this pull request.

Sorry, i have just rebased this PR on top of latest master and fixed the review commits after this weekend breaks, it should be available for automatically merge now

Could you update the configuration docs to include the new changes from this PR? Thanks.

I just have a minor comment, but overall looks good. Thanks for the PR!

@gpang  It's OK, thanks for your review comments, I have push a fix about that.

LGTM

+1 LGTM


Configuration flag for image persistency of imported Wild VMs or VM Templates

Description
All Wild VMs disks are imported as persistent images, and all VM Template disks are imported as non persistent images. Some scenarios require changing this defaults
Progress Status

[x] Branch created
[x] Code committed to development branch
[ ] Testing - QA
[x] Documentation
[x] Release notes - resolved issues, compatibility, known issues
[x] Code committed to upstream release/hotfix branches
[x] Documentation committed to upstream release/hotfix branches

needs testing

code: 3c8a517699a5a655e0c0b619f64c1686c9b02203
doc: 0313164da8c58b3f1e7d90f4dc7cd15888634780 and 0baf77125016d9bf16c983e1ee7327e84897ecb6

duplicated by #5711


GH-373: Add size/alignment checks to BindBufferMemory and BindImageMemory

In addition to the new VU checks/tests for #373, this PR refactors Insert*MemoryRange() into pre/post-call format, and fixes some copy-paste errors in existing BindBufferMemory log_msg() calls.

Hey Cort, first character after the : in commit messages should be capitalized and the subject line should be right at 50 characters.


bumped up org.kie to next 8.20.0-SNAPSHOT

Many thanks for submitting your Pull Request :heart:!

https://github.com/kiegroup/drools/pull/4286
https://github.com/kiegroup/optaplanner/pull/1907
https://github.com/kiegroup/optaplanner-quickstarts/pull/316
https://github.com/kiegroup/optaweb-employee-rostering/pull/784
https://github.com/kiegroup/optaweb-vehicle-routing/pull/674
https://github.com/kiegroup/kogito-apps/pull/1291
https://github.com/kiegroup/kogito-examples/pull/1205
https://github.com/kiegroup/kogito-runtimes/pull/2121

Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Your code is properly formatted according to this configuration
[ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

Run all builds
Please add comment: Jenkins retest this

Run (or rerun) specific test(s)
Please add comment: Jenkins (re)run [kogito-runtimes|optaplanner|kogito-apps|kogito-examples|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] tests

Quarkus LTS checks
Please add comment: Jenkins run LTS

Run (or rerun) LTS specific test(s)
Please add comment: Jenkins (re)run [kogito-runtimes|optaplanner|kogito-apps|kogito-examples|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] LTS

Native checks
Please add comment: Jenkins run native

Run (or rerun) native specific test(s)
Please add comment: Jenkins (re)run [kogito-runtimes|optaplanner|kogito-apps|kogito-examples|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] native

Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

(tests) - kogito-examples job #1488 was: UNSTABLE
Possible explanation: This should be test failures
Test results:

PASSED: 452
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.outbox.OutboxIT.testSendProcessEvents
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a lambda expression in org.kie.kogito.quarkus.outbox.OutboxIT 1 expectation failed.Expected status code <200> but was <404>. within 1 minutes.	at org.kie.kogito.quarkus.outbox.OutboxIT.testSendProcessEvents(OutboxIT.java:129)Caused by: java.lang.AssertionError: 1 expectation failed.Expected status code <200> but was <404>.	at org.kie.kogito.quarkus.outbox.OutboxIT.lambda$testSendProcessEvents$1(OutboxIT.java:136)

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-runtimes.tests.downstream.kogito-examples/1488/display/redirect

Jenkins rerun kogito-examples tests


environment var BASE_URL isn't working

Describe the bug
The env-var "BASE_URL" isn't working in the docker image. So the website doesn't works behind a reverse proxy in a subdir.
Version
Exact version in the top right area: 0.42
To Reproduce
Steps to reproduce the behavior:
I start the container with
docker run -d
--name changedetectionio \
--restart unless-stopped \
--link selenium \
--link browserless \
-p 5000:5000 \
-e WEBDRIVER_URL="http://selenium:4444/wd/hub" \
-e PLAYWRIGHT_DRIVER_URL="ws://browserless:3000/?stealth=1&--disable-web-security=true" \
-e USE_X_SETTINGS=1 \
-e BASE_URL="https://domain/changeio/" \
-v datastore-volume:/datastore \
dgtlmoon/changedetection.io

All vars are working, but BASE_URL.
If I check on settings -> Base URL
I get an empty var Default value is the ENV var 'BASE_URL' (Currently "")
Expected behavior
The var should be set.

this one is only for the notifications..


Fatal error: Call to undefined method AppBundle\Controller\DefaultController::getParameter()

Hello! I am a newguy in symfony. Am I something missing, but now cause DefaultController extends AbstractController, so in symfony-standard/src/AppBundle/Controller/DefaultController.php line
18  --> 'base_dir' => realpath($this->getParameter('kernel.project_dir')).DIRECTORY_SEPARATOR,
throws exception in issue title, I guess AbstractController doesnt have getParameter method
Thanks

@nicolas-grekas what is intended that getParameter stayed in Controller only rather than being in ControllerTrait to be there also in AbstractController ?

AbstractController does gives access to a scoped PSR11 container, which doesn't have getParameter ().

Why just change the extend and do it on Controller ?

I can confirm this issue after installing Symfony 3.3.3 using the Symfony installer.

#1082 was reverted in c4c2ef5d383fd0a39adbb1eb5c8840a412fd4335.


Disable loggin for HTTP calls

I am frustrated at the amount of logs dumped when we make a call to azure container to download blobs. There are tens of thousands of blobs and the logs for each request is more than 10 lines which is crashing my server.
[2021-04-28 05:26:20,544] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,544] {_universal.py:420} INFO - Request method: '\x1b[1mGET\x1b[0m'
[2021-04-28 05:26:20,544] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,544] {_universal.py:421} INFO - Request headers:
[2021-04-28 05:26:20,545] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,545] {_universal.py:424} INFO -     '\x1b[1mx-ms-version\x1b[0m': '\x1b[1mREDACTED\x1b[0m'
[2021-04-28 05:26:20,545] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,545] {_universal.py:424} INFO -     '\x1b[1mAccept\x1b[0m': '\x1b[1mapplication/xml\x1b[0m'
[2021-04-28 05:26:20,545] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,545] {_universal.py:424} INFO -     '\x1b[1mUser-Agent\x1b[0m': '\x1b[1mazsdk-python-storage-blob/12.8.1 Python/3.7.10 (Linux-5.4.0-1039-aws-x86_64-with-debian-10.9)\x1b[0m'
[2021-04-28 05:26:20,545] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,545] {_universal.py:424} INFO -     '\x1b[1mx-ms-date\x1b[0m': '\x1b[1mREDACTED\x1b[0m'
[2021-04-28 05:26:20,545] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,545] {_universal.py:424} INFO -     '\x1b[1mx-ms-client-request-id\x1b[0m': '\x1b[1m43b6c0c8-a7e2-11eb-8bc4-0242ac140004\x1b[0m'
[2021-04-28 05:26:20,545] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,545] {_universal.py:424} INFO -     '\x1b[1mAuthorization\x1b[0m': '\x1b[1mREDACTED\x1b[0m'
[2021-04-28 05:26:20,546] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,545] {_universal.py:437} INFO - No body was attached to the request
[2021-04-28 05:26:20,628] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,628] {_universal.py:452} INFO - Response status: 200
[2021-04-28 05:26:20,629] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,629] {_universal.py:453} INFO - Response headers:
[2021-04-28 05:26:20,629] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,629] {_universal.py:456} INFO -     '\x1b[1mTransfer-Encoding\x1b[0m': '\x1b[1mchunked\x1b[0m'
[2021-04-28 05:26:20,629] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,629] {_universal.py:456} INFO -     '\x1b[1mContent-Type\x1b[0m': '\x1b[1mapplication/xml\x1b[0m'
[2021-04-28 05:26:20,629] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,629] {_universal.py:456} INFO -     '\x1b[1mServer\x1b[0m': '\x1b[1mWindows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0\x1b[0m'
[2021-04-28 05:26:20,629] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,629] {_universal.py:456} INFO -     '\x1b[1mx-ms-request-id\x1b[0m': '\x1b[1mcedfae07-a01e-0004-6def-3b5bb6000000\x1b[0m'
[2021-04-28 05:26:20,630] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,629] {_universal.py:456} INFO -     '\x1b[1mx-ms-client-request-id\x1b[0m': '\x1b[1m43b6c0c8-a7e2-11eb-8bc4-0242ac140004\x1b[0m'
[2021-04-28 05:26:20,630] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,630] {_universal.py:456} INFO -     '\x1b[1mx-ms-version\x1b[0m': '\x1b[1mREDACTED\x1b[0m'
[2021-04-28 05:26:20,630] {logging_mixin.py:112} INFO - [2021-04-28 05:26:20,630] {_universal.py:456} INFO -     '\x1b[1mDate\x1b[0m': '\x1b[1mWed, 28 Apr 2021 05:26:19 GMT\x1b[0m'```

Is it possible to suppress these logs unless required? I undestand that this issue may have been voiced out by someone else, but it has not been resolved so far.

@Roohiya  Thanks for reporting this concern! We'll investigate this asap

Thank you!
FYI,
I have tried a few things to suppress the logs.
Switching off Logging
Tried with "azure-storage" & "azure-storage-blob" too
logger = logging.getLogger("azure")#
logger.setLevel(logging.WARNING)

service = BlobServiceClient.from_connection_string(
    conn_str=connection_string, logger=logger
)

and
logger = logging.getLogger("azure")#
logger.setLevel(logging.WARNING)

service = BlobServiceClient.from_connection_string(
    conn_str=connection_string, enable_logging=True
)

and
logger = logging.getLogger("azure")#
logger.setLevel(logging.WARNING)

service = BlobServiceClient.from_connection_string(
    conn_str=connection_string
)

The above do not seem to be working.

Hi @Roohiya
Thanks for reaching out! I tested using this and it works for me. If I set level to logging.DEBUG the logs will appear again.
bsc = BlobServiceClient("accounturl", credential=key, logging_enable=True)
self.logger = logging.getLogger('azure')
self.logger.setLevel(logging.WARNING)
self.logger.propagate = True

Let me know if you still have the problem.

Thank you @xiafu-msft for the prompt reply.
And this actually works!
I wonder if its the way I have instantiated the BlobServiceClient. 🤔
But this will do for now. Thanks again!


Endpoint that deactivates a users third-party (Google/Github/Twitter) account from atlas admin

-Updated User model with new field
-Added endpoint to set and store new field

Tests?

lgtm


Remove WithDocsCustom from tabs examples

I don't think it's doing anything and we don't do it anywhere else
Fixes #635

Codecov Report

Merging #790 (2e35d92) into master (82a73de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #790   +/-   ##
=======================================
  Coverage   99.42%   99.42%
=======================================
  Files         121      121
  Lines         866      866
  Branches      248      248
=======================================
  Hits          861      861
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a73de...2e35d92. Read the comment docs.


Animation player method track cannot pick methods from built in script

Godot version:
3.2.3 stable
OS/device including version:
linux
Issue description:
If you have a built-in script, when you select a method track for an animation player it does not list or find any script functions you have written.
Here we have built in script:

Here we change built in to external and repeat:

Can I be honest and say, for Godot 4, why don't you drop built-in scripts. They're really not much use for any body, they're full of obscure editing bugs, much more than the one I've listed, and they're very bad practise. They might originally have been there as a good intent, but not now...
Steps to reproduce:

create a node and select built in script
create simple function
create animation player and add a track and select the top level node
insert a key

Bugsquad edit (keywords for easier searching): builtin

Great minds think alike ;)
But I did have a reason for using it, and it was more out of laziness for testing a bug to publish the zip.

Great minds think alike ;)
But I did have a reason for using it, and it was more out of laziness for testing a bug to publish the zip.

But it's still a bug if it's not going to be dropped...

But it's still a bug if it's not going to be dropped...


10.8 AGS & Portal install error

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request

Module Version

3.0.2

Affected Resource(s)

ArcGIS_Server
ArcGIS_Portal

Configuration Files

1 BaseDeployment_STG_DataStore_Server_Portal_WA_DNS_MK_Github.json.txt
Expected Behavior

ArcGIS Servers & Portal are configured and federated with IWA.
Actual Behavior

4 ArcGIS Servers & a Portal configured and federated

Steps to Reproduce

Invoke-ArcGISConfiguration -ConfigurationParametersFile D:\Scripts\script.json -Mode InstallLicenseConfigure
Important Factoids

Hi,
I am trying to install 10.8 data store, 4 servers & a portal with federation on 8 VMs with Windows Server 2019 but getting the following error.

I am trying to install 4 different web adapters for 4 AGSs on one web server.
How do you configure a system with multiple AGSs?  Is it possible?
Any advice would be appreciated.
Mina
References

Hello @minagim
To achieve this you will need to generate separate json files (4 total). One that installs the web adaptor and server, and then a second one that contains an identical copy of the server information but has new information for the second web adaptor node name, ServerContext, and AdminAccess. Then repeat this for the third and fourth web adaptors.
Thanks,
Cameron K.

@cameronkroeker Thanks for your prompt response.  After reading #134, I thought it would be possible.  Thanks for confirming it.  I will close the case.

I am getting a couple of new errors while running the modified script.
First error is about the server license.

Second error is about the the portal default role.
PowerShell DSC resource ArcGIS_Portal  failed to execute Set-TargetResource functionality with error message: [Error] - Set-PortalUserDefaults Response:- Invalid values for role and/or user license type parameters.
The SendConfigurationApply function did not succeed.

I have the following parameters set in the script.
"EnableAutomaticAccountCreation": "true",
"DefaultRoleForUser": "account_user",
"DefaultUserLicenseTypeIdForUser": "viewerUT",

I am getting a couple of new errors while running the modified script.
First error is about the server license.

Second error is about the the portal default role.
PowerShell DSC resource ArcGIS_Portal failed to execute Set-TargetResource functionality with error message: [Error] - Set-PortalUserDefaults Response:- Invalid values for role and/or user license type parameters.
The SendConfigurationApply function did not succeed.

I have the following parameters set in the script.
"EnableAutomaticAccountCreation": "true",
"DefaultRoleForUser": "account_user",
"DefaultUserLicenseTypeIdForUser": "viewerUT",

Hello @minagim ,
The first error is indicating that the ArcGIS Server Authorization Wizard is returning an error when attempting to authorize the license. I recommend checking the license file to ensure it is valid (correct version, contains all necessary info like email, address, etc), and even perhaps attempt to manually authorize to see if it gives the same error.
The second error, try modifying "EnableAutomaticAccountCreation": "true", to "EnableAutomaticAccountCreation": true,. Boolean (true|false) should be all lowercase and not contain quotes.

Hi, @cameronkroeker,
Thanks for your answers.  I just tried to validate the license manually on the server and it worked.  What could it the issue?

Also, for the "EnableAutomaticAccountCreation" parameter, the double quotes around the boolean values in the sample script threw me off.  I am new to Powershell and have a lot to learn.
I made the change and still got the same error.

Hi @minagim ,
Hm I'm not quite sure what could be wrong with the ArcGIS Server authorization. Two other suggestions I have are, 1. Try moving the authorization file to another location, 2. Try to manually authorize it silently, as this is how the PowerShell Module does it:
https://enterprise.arcgis.com/en/server/latest/install/windows/authorize-arcgis-server.htm#ESRI_SECTION1_2EF08A7261D248F596B749D3ED825460
For the second issue, try a combination of things. For example:
"DefaultRoleForUser": "org_user",
"DefaultUserLicenseTypeIdForUser": "viewerUT",

or
"DefaultRoleForUser": "account_user",
"DefaultUserLicenseTypeIdForUser": "editorUT",

I suspect the issue here is these user types must be compatible with the defaultRoleForUser that has been specified.
Values: fieldWorkerUT | GISProfessionalStdUT | GISProfessionalBasicUT | GISProfessionalAdvUT | creatorUT | editorUT | insightsAnalystUT
https://developers.arcgis.com/rest/enterprise-administration/portal/update-security-configuration.htm
https://developers.arcgis.com/rest/users-groups-and-items/set-user-default-settings.htm

Hello @minagim were you able to make any progress on this issue?

Hi, Cameron.
I am so sorry for the delay in reply.   I wasn’t able to make it work for both issues.
For the first issue, I moved the location around to see if it had any affect but couldn’t make it work. I am planning to test it a little more for PROD environment as I am done with our base deployment in STG.
For the second issue, I was wondering if it was a version-related issue as I was installing 10.8.  I tried different combinations but nothing worked.
I downloaded 10.8.1 versions this week and am excited  to test upgrading to 10.8.1 sometime next week.
I will go ahead and upload my answers for the open case and close it.
Thanks for all your help.
Mina
From: Cameron Kroeker<EMAIL_ADDRESS>Sent: Thursday, July 30, 2020 6:00 PM
To: Esri/arcgis-powershell-dsc<EMAIL_ADDRESS>Cc: Kim, Mina (Parks<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Esri/arcgis-powershell-dsc] 10.8 AGS & Portal install error (#276)
Hello @minagimhttps://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fminagim&data=02|01|mina.kim%40parks.nyc.gov|b7e0e1332e7046ea457d08d834d3e191|32f56fc75f814e22a95b15da66513bef|0|0|637317431927026999&sdata=CRGXKl%2Fp4fcCRvpjsL1USQNhatg7jBTM9PP2GX7HEAE%3D&reserved=0 were you able to make any progress on this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FEsri%2Farcgis-powershell-dsc%2Fissues%2F276%23issuecomment-666731931&data=02|01|mina.kim%40parks.nyc.gov|b7e0e1332e7046ea457d08d834d3e191|32f56fc75f814e22a95b15da66513bef|0|0|637317431927036993&sdata=nToyfBkc65FrvJjkEaFgAypBCTVLkgljFQvvAo%2FUO%2Bw%3D&reserved=0, or unsubscribehttps://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAORJUUJSTN5NZLOJE7TPT7LR6HUNBANCNFSM4OG2MVPQ&data=02|01|mina.kim%40parks.nyc.gov|b7e0e1332e7046ea457d08d834d3e191|32f56fc75f814e22a95b15da66513bef|0|0|637317431927036993&sdata=r3DX5Szz4bKCAgMOXy2OzbMSRNvAEnyYqCU3Ag3nr2o%3D&reserved=0.


C#: scriptcs not found when trying to run code

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.64.2
OS Version: Linux Mint 20.3 Cinnamon

Steps to Reproduce:

Write code in C#
Click on Run Code

`[Running] scriptcs "/home/pc/MyApplication/tempCodeRunnerFile.csharp"
/bin/sh: 1: scriptcs: not found
[Done] exited with code=127 in 0.005 seconds`

/extC#


tf.repeat memory consumption and performance

Windows 10
TF 2.5.0
Python 3.8
CUDA 11.2
RTX 3060 6 GB
tf.repeat consumes much more memory with axis=0 in comparison if I create the same array with tf.gather.
D = 4000
a = tf.ones((D, 20))
Ns = tf.repeat([1000], D)
b = tf.repeat(a, Ns, axis=0)
tf.config.experimental.get_memory_info('GPU:0')
# {'current': 320337920, 'peak': 676338176}

D = 4000
a = tf.ones((D, 20))
Ns = tf.repeat([1000], D)
Ns_r = tf.range(0, D, dtype=tf.int64)
Ns_r = tf.repeat(Ns_r, Ns)
c = tf.gather(a, Ns_r, axis=0)
tf.config.experimental.get_memory_info('GPU:0')
# {'current': 352337920, 'peak': 352337920}

Also my code ( I might share it, but is quite huge) runs 58 sec when I use tf.gather on each iteration and 73 sec when I use repeat, that is a bit strange (as tf.repeat is just a particular case of gather in this case).
When I add creration of Ns_r on each it too, the time is same, but I do not consider tf.gather as optimal - the elements are ordered and just repeated, while gather does not use this assumption

@denix56 Was able to reproduce the issue in TF 2.5 Please find the gist here. Thanks!


Problem on console without support of color.

Hi, I'm a user of Win 7 x64 and with cmd I have to use the "--color never" option, but it get bypassed when there's an error and shows:
←[31mError:←[0m undefined filter    ←[38;5;246m╭←[0m←[38;5;246m─←[0m←[38;5;246m[←[0m<unknown>:1:14←[38;5;246m]←[0m    ←[38;5;246m│←[0m  ←[38;5;246m1 │←[0m ←[38;5;249m.←[0m←[38;5;249m[←[0m←[38;5;249m]←[0m←[38;5;249m ←[0m←[38;5;249m|←[0m ←[38;5;249m ←[0m←[38;5;249m.←[0m←[38;5;249mn←[0m←[38;5;249ma←[0m←[38;5;249mm←[0m←[38;5;249me←[0m←[38 ;5;249m,←[0m←[38;5;249m ←[0m←[31me←[0m←[31mv←[0m←[31me←[0m←[31mn←[0m←[31mt←[0m←[31ms←[0m←[38;5;249m[ ←[0m←[38;5;249m]←[0m  ←[38;5;240m  │←[0m              ←[31m─←[0m←[31m─←[0m←[31m─←[0m←[31m┬←[0m←[31m─←[0m←[31m─←[0m  ←[38;5;240m  │←[0m                 ←[31m╰←[0m←[31m─←[0m←[31m─←[0m←[31m─←[0m←[31m─←[0m undefined fil ter ←[38;5;246m───╯←[0m
Cheers.

This happens here: https://github.com/01mf02/jaq/blob/1699a7d1fc7ede6f728fcaa243f011137fcc220a/jaq/src/main.rs#L489-L500
Sadly this is part of a trait implementation for std::process::Termination and I can't find a neat way of propagating the --color cli option to this call. Making the cli options global would do it (as in using OnceCell) but that's a big change. Another path would be to try the supports_color crate.

Another path would be to try the supports_color crate.

That would be fine, I do have the NO_COLOR variable included on my environment, because a lot of CLI out there use it.

@hellishvictor, thanks for your bug report. This should be corrected by my latest PR.
@kklingenberg, the way I took to propagate color settings was to call yansi::enable.

I've compiled it and now it works like a charm. Thanks to you!

I've compiled it and that fixes the #183, but when I added a plus sign by accident on the filter (curl -s http://programminghistorian.org/assets/jq_rkm.json | jaq --color never  .[]+), it showed here:
←[31mError:←[0m Unexpected end of input, expected {, if, try, -, ", ., [, .., (                                                                                3 8;5;246m╭←[0m←[38;5;246m─←[0m←[38;5;246m[←[0m<unknown>:1:5←[38;5;246m]←[0m    ←[38;5;246m│←[0m  ←[38;5;240m  │←[0m ←[38;5;246m───╯←[0m

I've compiled it and that fixes the #183, but when I added a plus sign by accident on the filter (curl -s http://programminghistorian.org/assets/jq_rkm.json | jaq --color never .[]+), it showed here:
←[31mError:←[0m Unexpected end of input, expected {, if, try, -, ", ., [, .., ( 3 8;5;246m╭←[0m←[38;5;246m─←[0m←[38;5;246m[←[0m<unknown>:1:5←[38;5;246m]←[0m ←[38;5;246m│←[0m ←[38;5;240m │←[0m ←[38;5;246m───╯←[0m

I believe that you are not using the newest version on Git, because the newest version does never color the starting "Error:" string, yet in the output you posted, we can see ←[31mError:←[0m, which indicates that it is colored.
Can you confirm my hypothesis?

Ok, I've downloaded the master again and compiled it, and this time it works fine:

Thank you very much!

Great, I'm happy to hear it! :)


all gray tiles on both iPhone and Android

I tried on both platforms, cordova builds just fine for both android and ios.  My cordova version is 5.2.0.  Any idea where I can look for the issue?

Can't really say without more information. Are you positive that your tile URLs are correct, that they make a valid map using plain L.TileLayer ? Does anything come up in your debugger's log?

I just took everything out-of-the-box ( ) and this is what I got for logs
2015-09-11 15:29:47.501 HelloCordova[8338:4176826] DiskCookieStorage changing policy from 2 to 0, cookie file: file:///private/var/mobile/Containers/Data/Application/58BD0721-3EAC-45E3-B9BB-83BE6C55BAA3/Library/Cookies/Cookies.binarycookies
2015-09-11 15:29:47.628 HelloCordova[8338:4176826] Apache Cordova native platform version 3.8.0 is starting.
2015-09-11 15:29:47.629 HelloCordova[8338:4176826] Multi-tasking -> Device: YES, App: YES
2015-09-11 15:29:47.632 HelloCordova[8338:4176826] Unlimited access to network resources
2015-09-11 15:29:47.637 HelloCordova[8338:4176826]

Started backup to iCloud! Please be careful.
Your application might be rejected by Apple if you store too much data.
For more information please read "iOS Data Storage Guidelines" at:
https://developer.apple.com/icloud/documentation/data-storage/
To disable web storage backup to iCloud, set the BackupWebStorage preference to "local" in the Cordova config.xml file

2015-09-11 15:29:47.769 HelloCordova[8338:4176826] [CDVTimer][file] 39.713979ms
2015-09-11 15:29:47.769 HelloCordova[8338:4176826] [CDVTimer][TotalPluginStartup] 40.095985ms
2015-09-11 15:29:48.214 HelloCordova[8338:4176826] Resetting plugins due to page load.
2015-09-11 15:29:48.511 HelloCordova[8338:4176826] Finished load of: file:///private/var/mobile/Containers/Bundle/Application/8D2FA2FF-948E-4BCC-B56B-B8FA32FB3D56/HelloCordova.app/www/index.html
2015-09-11 15:29:48.656 HelloCordova[8338:4176826] Opening filesystem
2015-09-11 15:29:48.660 HelloCordova[8338:4176826] requestFileSystem OK LTileLayerCordovaExample
2015-09-11 15:29:48.663 HelloCordova[8338:4176826] getDirectory OK LTileLayerCordovaExample

I did the same thing with Android and the results are same, here's an image on iPhone:


Panic with unterminated comment

The following two-character file causes Lean to panic, both in command-line as well as server mode:
/-

Relevant stacktrace:
PANIC at Lean.Parser.SyntaxStack.back Lean.Parser.Types:168:4: SyntaxStack.back: element is inaccessible
backtrace:
/home/gebner/lean4/build/release/stage1/bin/../lib/lean/libleanshared.so(+0x35b30d1)[0x7fb3d39b30d1]
/home/gebner/lean4/build/release/stage1/bin/../lib/lean/libleanshared.so(lean_panic_fn+0xcd)[0x7fb3d39b354d]
/home/gebner/lean4/build/release/stage1/bin/../lib/lean/libleanshared.so(l_Lean_Parser_parseHeader+0x3b2)[0x7fb3d36e5a62]

Related to #1525, but a different issue.

I thought this was already in the test suite?

I believe we have a test for unterminated doc comments, but not for unterminated comments.


introducing nx agents

Playing with Nx agents here.
Here's what I'm seeing:

We can do a bit better by bumping up the agent count from 3 => 12 (free and not as restrictive as github seems to be when asking for a bunch of machine), and reducing the parallel option from 5 => 3 to not overload any one machine. Looks like now we're getting 3.5 minutes for a full run. We might try for more agents here, it's worth exploring!

A downside from the legacy DTE setup to Nx agents is in legacy, we could setup workers and main machines all in parallel, now we have to setup the main job and then setup all other agents. We're losing about 20s here with cached node_modules - looks like this is made up for by bumping up agent counts though. When we launch Nx Workflows, we should be able to get that 20s back.

There's some more optimizations we could try later, adding in small/med/large agent loads could help here for getting the full swarm when we need to run everything, and not get overly excited for smaller PRs

Potentially we can add in the format and knip tasks to the swarm. This is probably trivial for perf, but it could help in the sense that all tasks can be run the same way (instead of setting up specific machines for the format and knip tasks), and we could see it in the nx cloud task list instead of spelunking github action logs!

Nx Agents can be used for the main job as well - looks like those workflows are growing up to ~10 minutes now. I think now it's solid enough that we can use it reliably for the releases, while using the --skip-cache option to ensure we're running all checks before publishing!

@lachlancollins / @TkDodo let me know thoughts here, I'll clean this up a bit so we can merge if you like!

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7c91e1a) 41.81% compared to head (3b60eeb) 58.73%.
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6863       +/-   ##
===========================================
+ Coverage   41.81%   58.73%   +16.91%
===========================================
  Files         179      118       -61
  Lines        7021     4507     -2514
  Branches     1421     1123      -298
===========================================
- Hits         2936     2647      -289
+ Misses       3722     1629     -2093
+ Partials      363      231      -132

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@lachlancollins / @TkDodo we're in a merge-able state now

@ZackDeRose regarding the optimisations you mentioned above, how difficult would it be to implement agents for the ci.yml workflow? As you mentioned, CI times are now 9+ mins as we're testing examples too.


Increase test coverage for EditCommand

Codecov Report

Merging #274 (4ae3fdd) into master (53e838f) will increase coverage by 0.36%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #274      +/-   ##
============================================
+ Coverage     69.77%   70.13%   +0.36%
- Complexity      866      871       +5
============================================
  Files           111      111
  Lines          3593     3593
  Branches        345      345
============================================
+ Hits           2507     2520      +13
+ Misses          987      976      -11
+ Partials         99       97       -2

Impacted Files
Coverage Δ

...rc/main/java/seedu/address/model/ModelManager.java
88.57% <0.00%> (+4.28%)
:arrow_up:

...java/seedu/address/logic/commands/EditCommand.java
95.32% <0.00%> (+9.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e838f...4ae3fdd. Read the comment docs.


Rewrite read_data_file() to take sep

I know you have assigned this to someone. But I already wrote the code yesternight.
Please keep this.
You can choose whichever version to merge.
I have tested this function. Works for all edge cases.
This is for #8

There is one whitespace issue. Please see into it.

Thanks for this, but @errpv78 has already finished working on it and I've merged his changes. He did a really good job there, and I'm going to have to close this PR now. Thanks both of you!

@hot9cups you're welcome, and I would love to do more work with you in the future.


add audio filter

This pull request adds the capability to specify audio filters using SetAudioFilter as it is already possible for video filters using SetFilter.

As you suggested there's now a SetVideoFilter method with the SetFilter marked deprecated.

@xfrr care to merge?