band power

My experience with the Emotiv Insight band power data is this:
I get very low values (mostly between 0 and 4) when i don't move my face.
I get very high values (up to 10000 sometimes more) when i move some muscles in my face.
Do others experience the same?
How are we supposed to measure brain activity when the device is much more sensitive to muscle activations?
Please help. Maybe i have an abnormal brain?

Muscle signals EMG(mV) are significantly bigger than EEG signals (uV)
So yes, you will get high band powers during facial expressions.
But it would be the same with any EEG system.
Not talking or moving much when wearing the headset helps significantly to get a clear EEG signal.
And there is probably nothing wrong with your brain :)

@bchaperon
Yes i can accept that the muscle signals are much stronger than the EEG signals, but my problem is that there are almost no features left in the EEG signal. For example i get sequences like 0.0 0.0 1.0 0.0 0.0 1.0 1.0 1.0 2.0 0.0 1.0 1.0 0.0 0.0 0.0 0.0 1.0 0.0 0.0 1.0 ...
In the meantime i bought a Muse 2016 headband which is another consumer EEG headset, and with that device i am getting very detailed signals, also when i don't move my face.
I think the Emotiv implementation of the band power with the websockets API might be flawed?

hi @notnot which API did you use to get the results? And what were the sequences of the APIs did you use? Would you be able to provide us some of the sample output files from our example and also from Muse please?

Is it possible you are reading the signals with insufficient resolution? Here is a typical sequence extracted from a clean section of EEG data in the alpha band:
0.59813, 0.683071, 0.706067, 0.659607, 0.55837, 0.434528, 0.324426, 0.249195, 0.209976, 0.192205, 0.184232, 0.181206, 0.180404, 0.18279, 0.192179, 0.212205, 0.238767, 0.26198, 0.272384, 0.265369
These are collected at 0.125s intervals. The numbers presented are in uV ^2 / Hz (spectral power density)
You can convert to decibels (dB) by taking 1/20 log10 ( bandpower ) which has a higher dynamic range for plotting

@patdotme
I used the Cortex websockets API, subscribing to the "pow" stream. This stream doesn't behave properly, see the other issue i filed, which might be related.
Here is what typical output looks like when i don't move my face:
[849]
EEG band power sample 2018-07-03 11:42:22.110:
	 AF3   3.000   2.000   1.000   1.000   0.000
	  T7   1.000   1.000   0.000   0.000   0.000
	  Pz   3.000   1.000   1.000   1.000   0.000
	  T8   1.000   1.000   0.000   1.000   1.000
	 AF4   0.000   0.000   0.000   0.000   0.000

[850]
EEG band power sample 2018-07-03 11:42:22.185:
	 AF3   2.000   2.000   2.000   1.000   0.000
	  T7   1.000   1.000   0.000   0.000   0.000
	  Pz   3.000   2.000   1.000   1.000   0.000
	  T8   0.000   1.000   0.000   1.000   1.000
	 AF4   0.000   0.000   0.000   0.000   0.000

[851]
EEG band power sample 2018-07-03 11:42:22.259:
	 AF3   2.000   2.000   2.000   1.000   0.000
	  T7   1.000   1.000   0.000   0.000   0.000
	  Pz   3.000   2.000   1.000   1.000   0.000
	  T8   0.000   1.000   0.000   1.000   1.000
	 AF4   0.000   0.000   0.000   0.000   0.000

[852]
EEG band power sample 2018-07-03 11:42:22.336:
	 AF3   2.000   2.000   2.000   1.000   0.000
	  T7   2.000   1.000   0.000   0.000   0.000
	  Pz   3.000   2.000   1.000   1.000   0.000
	  T8   0.000   1.000   0.000   1.000   0.000
	 AF4   0.000   0.000   0.000   0.000   0.000

[853]
EEG band power sample 2018-07-03 11:42:22.409:
	 AF3   2.000   2.000   2.000   1.000   0.000
	  T7   2.000   1.000   0.000   0.000   0.000
	  Pz   3.000   2.000   1.000   1.000   0.000
	  T8   0.000   1.000   0.000   1.000   0.000
	 AF4   0.000   0.000   0.000   0.000   0.000

Here is what typical output looks like when i frown my forehead, for instance:
[165]
EEG band power sample 2018-07-03 11:51:20.053:
	 AF3 9735.000 1891.000 367.000  80.000  35.000
	  T7  46.000  18.000  10.000   7.000   3.000
	  Pz  82.000  10.000   2.000   2.000   1.000
	  T8 116.000   9.000   8.000  16.000  10.000
	 AF4 656.000 405.000 197.000  73.000  23.000

[166]
EEG band power sample 2018-07-03 11:51:20.185:
	 AF3 7506.000 1526.000 274.000  70.000  30.000
	  T7  36.000  17.000  10.000   6.000   4.000
	  Pz  70.000   8.000   2.000   2.000   1.000
	  T8  97.000   6.000   8.000  24.000  14.000
	 AF4 580.000 348.000 169.000  63.000  20.000

[167]
EEG band power sample 2018-07-03 11:51:20.309:
	 AF3 4888.000 1054.000 175.000  57.000  26.000
	  T7  34.000  16.000  10.000   5.000   5.000
	  Pz  57.000   6.000   1.000   2.000   1.000
	  T8  77.000   5.000   9.000  33.000  18.000
	 AF4 435.000 253.000 123.000  46.000  15.000

[168]
EEG band power sample 2018-07-03 11:51:20.434:
	 AF3 2609.000 614.000  94.000  44.000  22.000
	  T7  36.000  15.000   9.000   4.000   6.000
	  Pz  44.000   5.000   1.000   2.000   1.000
	  T8  57.000   5.000  10.000  41.000  21.000
	 AF4 269.000 151.000  73.000  27.000   9.000

[169]
EEG band power sample 2018-07-03 11:51:20.558:
	 AF3 1107.000 306.000  44.000  32.000  20.000
	  T7  41.000  14.000   8.000   3.000   7.000
	  Pz  33.000   4.000   1.000   2.000   1.000
	  T8  40.000   8.000  13.000  44.000  22.000
	 AF4 130.000  69.000  34.000  13.000   4.000

Note that in both cases, contact quaility is reported as 100%.
The Muse headband gives band power output that is typically like this:
POW sample 2018-07-03 12:00:18.332:
	 TP9   0.960   0.858   0.493   1.403   0.537
	 Fp1   0.687  -0.136   1.284   0.725   0.601
	 Fp2   0.114   1.280  -0.005  -0.270   0.000
	TP10  -0.008  -0.145  -0.779  -0.337  -0.332

POW sample 2018-07-03 12:00:18.410:
	 TP9   0.972   0.892   0.591   1.403   0.541
	 Fp1   0.703  -0.054   1.286   0.725   0.603
	 Fp2   0.144   1.280   0.019  -0.254  -0.009
	TP10   0.006  -0.121  -0.782  -0.325  -0.304

POW sample 2018-07-03 12:00:18.493:
	 TP9   0.960   0.909   0.647   1.401   0.535
	 Fp1   0.713  -0.001   1.287   0.725   0.603
	 Fp2   0.144   1.280   0.034  -0.248  -0.020
	TP10   0.009  -0.112  -0.785  -0.304  -0.292

POW sample 2018-07-03 12:00:18.575:
	 TP9   0.897   0.913   0.675   1.392   0.485
	 Fp1   0.715   0.028   1.284   0.725   0.603
	 Fp2   0.144   1.280   0.041  -0.250  -0.033
	TP10   0.003  -0.111  -0.790  -0.278  -0.294

As you can see, this is much more detailed compared to the Emotiv Insight results.

@notnot from your output it seems like the significant figures are all gone - has it been casted to int / read as int somewhere? Would you be able to post the raw JSON respond from the "pow" stream please?

@patdotme
@gmac-emotiv
It is strange to see that the floating point numbers in the JSON "pow" stream results are always whole numbers. Maybe something is wrong in the Cortex driver?

A typical JSON reply instance:
{
  "pow":[
    3.0,
    4.0,
    2.0,
    2.0,
    1.0,
    2.0,
    2.0,
    1.0,
    0.0,
    1.0,
    0.0,
    0.0,
    1.0,
    1.0,
    2.0,
    1.0,
    0.0,
    1.0,
    0.0,
    0.0,
    2.0,
    1.0,
    1.0,
    0.0,
    0.0
  ],
  "sid":"d8834c5f-ae19-4a3c-8ce0-a861c5e05daf"
}

hi @notnot we found the rounding error of band power values in the Cortex service, the new version will include that fix by next week. Thanks for reporting!

@patdotme
Thanks!
Sadly for me this fix comes to late, i have already switched to the Muse 2016 for my research project. But it is always good to hear that bugs are found and fixed :)

No worries @notnot
With the EPOC+ headset and a EmotivPRO subscription you will be able to access 14 channels of EEG data - may be something on your next research project ;)

@notnot , We have updated Cortex. Please try with Cortex 1.4. Thanks for your feedback.

Yes i can confirm that Cortex 1.4 fixes this issue. Thanks, but sadly this comes too late for me...


New Measurement: Extended UPnP

Added new measurement extUPnP for a better and more diversivied analysis of UPNP and others.

Please remove the code-comments you added in  ae828d8 – they are unnecessary. You also need to resolve the merge conflict by rebasing onto HSAnet/develop.

As far as I can see your code should work, so please merge this code with the existing UPnP measurement code. Add a parameter for the UPnP definition so we can specify what we want to measure (Media Server, Internet Gateway, All, ....), evaluate those in the measurement, and act accordingly. Make sure only fields with data are in the result.

This PR will not be merged unless you resolve the merge conflict. Just rebase onto HSAnet/develop via
git fetch <remote> develop
git rebase <remote>/develop

# ... resolve conflict(s) ...

git add <conflicted-file(s)>
git rebase --continue

git push --force origin develop

Note: Replace <remote> with the upstream remote, e.g. HSAnet or upstream.


petal comb filter

QuickNotes:

So strangely, the Comp module's SetFreq actually sets the time in seconds.. So the mapping for the controls was crazy and would crash or not make sound.
The Comb filter doesn't seem to like being modulated much (probably worth you messing with a similar example on the Patch for easier testing on your end while this gets worked out). Could be something with knobs or comb filters, as well.
when setting the amplitude of the LFO, instead of using a fixed x10 multiplier, which could be out of range or really extreme for certain settings. you can use the actual frequency as a scalar, and then you'll definitely want to clamp somewhere close to zero if the comb filter breaks at frequency 0 (and/or add that clamping to the comb if it breaks it).
Consistency of control usage would be nice. I don't mind the UpdateControls() function, but if you have to mix controls inside the audio loop, the rest might as well be there as well so a reader doesn't have to jump around as much. Alternatively read all of your AnalogControls/Parameters in the UpdateControls, and then filter them at audio rate or something in the audio callback.

Similarly, UpdateAnalogControls should only be used if you aren't using Parameters (which calls process) or don't want to deal with the Process calls themselves. After Process has been called once at the initialized samplerate, the Value function should be used instead to update the value without changing the filter response, etc.
On the same note there are some Parameters being used, and some transforms being done on AnalogControls. I personally rarely use the parameter class, but if you want to use it I think it should be consistently used.

add petal.UpdateLeds(); after you set the FootswitchLed to actually write swap the DMA buffers and transmit the new data.
The CombFreq works pretty well between like 500us and 100ms or so ). Equivalent to  (10Hz - 2kHz) with Log scaling

When updating that make sure the delay will accommodate the lowest frequency (including what the LFO is doing.

Related: We should just fix the comb so it has SetFreq (which does exactly what it does now but to 1.f / inputvalue), and add SetPeriod for seconds.

Depends on changes to comb in DaisySP

Notes

Switch Toggle is opposite right now.

Clicks are fairly noticeable in my set up, especially when the LFO amp is up.

seems like some changes need to be made to the DaisySP comb to make it more comby.

 Redo all example diagrams in new style

 Petal Comb Filter

Notes

Comb sounds more comby, which is great.
Noise still occurs when adjusting Comb Frequency, both with the knob and LFO. If there is a way to smooth out the Comb frequency that would be great.
LED sequence is cool, but a bit much. Either slow it down or use it as a visual cue for the LFO rate.

Notes

significantly less zipper, but still kind of there. Maybe needs peer review to determine whether or not it needs further de-zipping.

everything else is working great.

@corellmichael just realized you were probably building this on your end as well. Which means you should be able to just pull the latest version of the libs, and rerun as is.


Ability to pass meters to each_with_progress

When you were using each_with_progress, you would always have all the meters being displayed and no ability to pick the one you want.
This change aims to give more control to users by adding the ability to pass the meters they want to see, the same way as when they create a new instance of ProgressBar.

Thanks for this! Nice fix. Can you change the commit to not touch the version or the changelog? General PR etiquette it to only include code changes, and let the maintainer bump the version/changelog.
Thanks!

Hey Paul,
Thank you for your response. Will do that tomorrow 👍

@paul That's done :+1:

Thanks @liljack! I just released 1.3.1


Image block - fix image hover and add image cropping

This pull request:

limits the image hover effect to size constrained images
adds optional image cropping to constrained images

Image Hover
When adding an image using the Image block, it will display as an img or picture depending on whether the image size has been constrained. Size constrained images display as img and unconstrained images display as picture.
The type of image element displayed plays a role when selecting a second image to use for the image hover effect. The image hover effect only works with img elements and does not work with picture elements. This is due to picture elements having a fallback src attribute and multiple srcset attributes that are more involved to modify than img elements. To address this, image hover only works when an image has been size constrained.
Image Cropping
To prevent any potential errors when dealing with the image helper, I added multiple checks to limit input. To add the image cropping a table column and migration was added.
I believe the changes I made should not affect existing users who upgrade concrete5. With any changes to an important core block like this, I welcome others to review and test my changes.
Current:

Changes:

@Mnkras
Thank you for reviewing the changes.
Based on your suggestion, I updated the migration to use refreshBlockType().


onnx.CumSum

test_cumsum_1d_exclusive
test_cumsum_1d_reverse
test_cumsum_1d_reverse_exclusive

https://github.com/llvm/torch-mlir/pull/3241 adds OnnxToTorch support for attributes. The tests now have TorchToLinalg issue of torch.aten.cumsum op.

Move to https://github.com/nod-ai/SHARK-Turbine/issues/347


brokerConfig.config is not copied to configmap

Considering a kafkacluster defined like :

kafka operator 0.6.0
cluster name kf-kafka
brokers section in the kafkacluster yaml :

  brokers:
    - id:  0
      brokerConfigGroup: "default_group"
      brokerConfig:
        resourceRequirements:
          limits:
            memory: "3Gi"
          requests:
            cpu: "0.3"
            memory: "512Mi"
        config: |
          session.timeout.ms=20000
          offsets.topic.replication.factor=2
          ProducerConfig.RETRIES_CONFIG=10
          transaction.state.log.replication.factor=2
          transaction.state.log.min.isr=1
          log.dirs=/kafka-logs/data
          ConsumerConfig.MAX_POLL_INTERVAL_MS_CONFIG=1000
          delete.topic.enable=true
          num.partitions=32
          auto.create.topics.enable=false
          default.replication.factor=2
          num.recovery.threads.per.data.dir=8

The configmap kf-kafka-config-0 created is like :
apiVersion: v1
data:
  broker-config: |-
    advertised.listeners=PLAINTEXT://kf-kafka-0.alerting.svc.cluster.local:9092
    broker.id=0
    broker.rack=francecentral,3
    cruise.control.metrics.reporter.bootstrap.servers=PLAINTEXT://kf-kafka-0.alerting.svc.cluster.local:9092
    listener.security.protocol.map=PLAINTEXT:PLAINTEXT
    listeners=PLAINTEXT://:9092
    log.dirs=/kafka-logs/kafka
    metric.reporters=com.linkedin.kafka.cruisecontrol.metricsreporter.CruiseControlMetricsReporter
    security.inter.broker.protocol=PLAINTEXT
    super.users=
    zookeeper.connect=zk-zookeeper.alerting:2181
kind: ConfigMap
metadata:
  annotations:
  labels:
    app: kafka
    brokerId: "0"
    kafka_cr: kf-kafka
  name: kf-kafka-config-0
  namespace: alerting
  ownerReferences:
  - apiVersion: kafka.banzaicloud.io/v1beta1
    blockOwnerDeletion: true
    controller: true
    kind: KafkaCluster
    name: kf-kafka

Is it normal that the special config parameters are not set there ?

Yes it is totally normal, since that configuration is a dynamic configuration which is stored in Zookeeper, the operator will only save the read only configs to ConfigMap and store all others in Zookeeper. https://kafka.apache.org/documentation/#dynamicbrokerconfigs

I just noticed that not all your configs are fine, with this new version of the operator you must distinguish your configs like Kafka does, read-only, per-broker, cluster-wide. The read only configs should go to the read-only section of the crd and so on.

OK I'll arrange that. Thanks for the info. I'm used to have all the config in one place, but I guess you need this so the Operator knows if it have to apply them dynamically or do a restart....

After splitting all the config in the right place everything is working fine.
Thanks.


[**WIP] Add tsec based authentication and password hashing

Issue #49
Password hashing is modeled as a separate algebra, parameterized by
the hashing strategy to be used (BCrypt, SCrypt etc)
Authentication is built into the UserRepositoryAlgebra

Needs functional testing
Still not checking user authentication before providing data

Hit a bit of a wall here. This tiny patch here causes all the tests to fail:
https://github.com/zakpatterson/scala-pet-store/commit/dfb7951954a324b3cafacbe557889f0a14dfe3f6

A few more comments since taking a look at this...
I don't think the crypt / authentication / LoginRequest stuff lives in the domain.  If we are exclusively using it in the endpoints, then all of that stuff should live in infrastructure.
I don't think we need to tie the user repository algebra to the tsec BackingStore in the domain.  Seems like that can be something that we do in the interpreter or keep it separate.  It muddies the definition of the user repository algebra which is supposed to be domain centric.
This is great stuff.  Seems like you are stopped right now on actually using the auth stuff?  I suppose that in order to actually do the auth stuff, we would need to have a stateful client in python and first login, and then second keep the JWT around for each request?  Treading new water here so a little unclear.

I don't think we need to tie the user repository algebra to the tsec BackingStore in the domain. Seems like that can be something that we do in the interpreter or keep it separate. It muddies the definition of the user repository algebra which is supposed to be domain centric.

This makes sense, hard to balance soc and code reuse in this case.

I suppose that in order to actually do the auth stuff, we would need to have a stateful client in python and first login, and then second keep the JWT around for each request?

My understanding is that the python requests session already handles this, or should handle this. I might need some help on the pythong testing side.
I've also learned a bit about the client side of http4s. I agree with your rationale in the readme about the python client, but i think it might also be valuable to show more testing with http4s. I'll open another issue about that after this.


Mono Project whose name and folder contain spaces won't compile properly

Godot version: 3.2.1 stable
OS/device including version: MacOS Catalina. MBP 2018.
Issue description: Whenever I create a Godot Mono Project inside a project folder with spaces (" ") in its name and the project name itself also has spaces, new C# scripts will not be included automatically inside its ItemGroup in the csproj file. I think this issue is related to issue #36168, but I have not noticed the %20 in the csproj file nor in the Godot console logs when I press build.
Steps to reproduce: Create a Godot Mono project whose name and folder have words separated by spaces. Then, inside Godot, create a new scene and add a C# script to it with some logic. The game builds with errors. If you run the game inside Godot, it actually initializes the game, but none of the C# scripts are run because they were not compiled.
Minimal reproduction project: NA

Does the project work if you change the folder name to not have spaces? These projects all have spaces in the project names but not in the folder names, so I'm wondering if it's just the folder name.

Godot 3.3.3 on Linux does not show that problem.
The mentioned issue is also already closed: https://github.com/godotengine/godot/issues/36168


Fix #511

Alternative to https://github.com/baconjs/bacon.js/pull/502
ES6 promise doesn't have .done AFAIK.

[x] tests

Crap, I can't write any tests as the exceptions are thrown asynchronously.

I think that's a good fix.

Ah I can't anyway. The exception is rethrown asynchronously, and I don't want to mock that too much. But I refactored promise tests as a bonus.

Mergeable again.

Merged #549 already


[BUG]Function Lenght broken

Describe the bug
Don't know what cause it but in my case SOURCE is not empty but Lenght says it is empty then stucks and wont continue to next step.
https://i.imgur.com/kF1EnCN.gif
In Runner ups CPU 100% so can't make gif unfortunately and yeah it happens randomly on different configs but only in Selenium. Might be refer again to a bug where won't get DOM if timeout but here we don't have a timeout error
Version

Commit 236

Nevermind issue is if you do 2 times Domtosource to the same source then happens something like infinity loop in something which i have to debug and find

I don't understand what you mean, so I guess the bug was another one? Reopen if not fixed.


Add this._super.apply( this, arguments ); call where needed

There are no locations in need of this


Fix perms with kubeseal

Description
When running ./ofc-bootstrap -yaml=init.yaml for the first time the scripts will download kubeseal and chmod in one line. The indenting on the new line is causing issues, and the chmod +x is being ignored. To keep the script readable I just removed the && \
Fixes #70
How Has This Been Tested?
Manually.

Remove kubeseal
exec ./scripts/export-sealed-secret-pubcert.sh
check perms of kubeseal

Only tested on Ubuntu 18.04
Checklist:
I have:

[x] checked my changes follow the style of the existing code / OpenFaaS repos
[ ] updated the documentation and/or roadmap in README.md
[x] read the CONTRIBUTION guide
[x] signed-off my commits with git commit -s
[ ] added unit tests

Thanks for the PR Chris.
The testing looks straight-forward, but you didn't mention if you reproduced the error, or not before working on the change. Please can you confirm that?

@alexellis changed the wording in the PR a little. Didn't raise it as an issue because I found #70 and believe they are the same.
Apologies if i'm stepping on any ones toes

Nobody is working on #70 as far as I'm aware, but I'd like to see that this PR fixes something.
Please can you show command-line output of the before/after? (I see you tested after, but did you test before, too?)
For future reference, why does && \ in bash cause an error?
Alex

I didn't reproduce it on my own local machine with VERSION="18.04.1 LTS (Bionic Beaver)"
alex@ermine:~/ofc-bootstrap$ ./scripts/export-sealed-secret-pubcert.sh
SealedSecrets release: v0.7.0

alex@ermine:~/ofc-bootstrap$ ls -ltr ./kubeseal
-rwxrwxr-x 1 alex alex 30460505 May 30 07:16 ./kubeseal

alex@ermine:~/ofc-bootstrap$ chmod +x ./kubeseal

alex@ermine:~/ofc-bootstrap$ ls -ltr ./kubeseal
-rwxrwxr-x 1 alex alex 30460505 May 30 07:16 ./kubeseal

@chriskolenko @alexellis I ran across this same issue on Ubuntu 18.04 in Windows Subsystem for Linux 1.0.
For me, the fix was not the above item, but due to the fact that I did not have Go installed on WSL.  Due to this, when export-sealed-secret-pubcert.sh executes, it tried downloading a release of kubeseal that is not valid leading to the following error:
"secrets cert 0  ./scripts/export-sealed-secret-pubcert.sh: line 17: ./kubeseal: Permission denied"
Perhaps the fix should be checking if Go is installed, and if not, logging an error to the output that it is required to install Go or manually install kubeseal?

@michaelkacher can we get the same ENV-vars for the download from using uname?

@michaelkacher can we get the same ENV-vars for the download from using uname?

For the command below, I can get the equivalent of $GOOS with uname but when I use uname --m to try to get the architecture I get "x86_64" which is different than "amd64" returned from go env GOARCH.
curl -sLSf https://github.com/bitnami/sealed-secrets/releases/download/$release/kubeseal-$GOOS-$GOARCH > kubeseal && \
    chmod +x kubeseal

@michaelkacher ?

@alexellis I had missed the last reply.
Looking at the sealed secret releases (https://github.com/bitnami-labs/sealed-secrets/releases) the only architecture the binary is provided in is amd64.  What if the url is kubeseal-$GOOS-amd64 and if uname --m is not "x86_64" we log a warning?

There's an. exe available too, can we select that as necessary? I'm fine with the error, good idea

I was thinking that openfaas cloud was only linux and mac, but looking back on the documentation I see I am wrong.  I can create a PR that will do the above mentioned but need to do a little research to see what uname returns for the different windows bash options (MINGW64, CYGWIN, etc.) to appropriate select the *.exe.

This is what I have, hope it helps

I think we're good now via https://github.com/openfaas-incubator/ofc-bootstrap/releases/tag/0.7.5
But I would still like the windows support if you can commit that through a follow-up PR? cc @sterchelen


release core 0.12

Things that are still open and need to be done before the release:

merge forms 2 https://github.com/RasaHQ/rasa_core/pull/1013
tracker store in yml https://github.com/RasaHQ/rasa_core/pull/1048

Open:

should https://github.com/RasaHQ/rasa_core/pull/550 go in or wait until adapted to multiple models configured using config files?

given that i am out of office wed-fri, I'll prepare it tomorrow and release on monday

should still change #550 to use the config files, as it makes it easy to use

well i def won't get it done by tomorrow, but probably can by monday

Monday sounds great 👍


Some urls don't return an img when loaded

I am using this loader with Pixi.js and loading assets from the Web through a proxy. With certain url the loader doesn't return an img. In its data attribute in fact I find a blob looking like this:

It doesn't seem to be a problem with the proxy because a URL I have problem with works well when loaded and drawn on a canvas: http://codepen.io/anon/pen/egRwzK
Any idea why some urls don't load and how to fix it? Thanks!

Because we determine if it is an image automatically by parsing the URL. If we can't determine what the URL refers to, we default to using text XHR (which will load as a binary string). If you have a strange url (such as :large at the end of the extension) then you can tell resource loader it is supposed to be an image by passing a load type:
const loader = new Loader();

loader.add('http://proxy.wisefac.es/https://pbs.twimg.com/media/C3BOhWuXUAAp63T.jpg:large', { loadType: Resource.LOAD_TYPE.IMAGE });

That's what was happening. Amazing!
Since we are here, is still the only option a CORS Proxy for such assets in Pixi?
Thanks a lot!

CORS issues are actually not because of pixi or resource-loader, but because of how Canvas2D and WebGL handle "dirty" canvases that use cross-domain images.
You can try using:
loader.add('http://...', { crossOrigin: true });

and for many people that works. If you need a specific cross original value  you can provide that as a string instead of passing true. Note that true uses the anonymous value.


resource: replace Delete with EnsureDeleted

Towards https://github.com/giantswarm/giantswarm/issues/4059.

PTALA


Phaser Game app instructions using Yarn

When I create a new project using the Phaser Game app and Yarn, the final instructions say:
Next steps:

cd my-first-game
npm install
npm run dev

But I didn't use npm, I used yarn instead.
The instructions must be dynamically generated.

I've addressed this issue in the create-app repository. The PR with the fix can be found here: PR Link
The help message has been updated to include instructions for both npm and Yarn users. Once this PR is merged, it should resolve the reported issue.
Suggesting this issue be closed and redirected to the PR for further discussion if needed.

Thank you!

Hi @askadityapandey and @Davichobits. Thanks to your proposals, we have updated the CLI (create-game). It now dynamically displays the package manager name.


Hook using addressForCoordinate method caused app crash on Android

Summary
I'm using addressForCoordinate to create a hook to get address from coordinate, but it caused app crash on Android (using Google map provider). After trying to fetch address from coordinate multiple times.
Reproducible sample code
import { useEffect, useState } from 'react';
import MapView, { Address } from 'react-native-maps';

interface LatLng {
  latitude: number;
  longitude: number;
}

const useCoordinateToAddress = (mapRef: React.RefObject<MapView>, location: LatLng, forceFetch?: boolean) => {
  const [address, setAddress] = useState<Address | null>(null);

  useEffect(() => {
    (async () => {
      if (location.latitude && location.longitude && mapRef.current) {
        try {
          const resAddress = await mapRef.current.addressForCoordinate({
            latitude: location.latitude,
            longitude: location.longitude,
          });
          setAddress(resAddress);
        } catch (error) {
          if (!forceFetch) {
            setAddress(null);
          }
          console.log(error);
        }
      }
    })();
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [mapRef, location]);

  return address;
};

export default useCoordinateToAddress;

Steps to reproduce
Using this given hook to call to get address multiple times on android (using Google map provider), the app will be crashed
Expected result
App not crash on android when using addressForCoordinate
Actual result
App crashed on android
React Native Maps Version
1.8.0
What platforms are you seeing the problem on?
Android
React Native Version
0.72.0
What version of Expo are you using?
Not using Expo
Device(s)
Any android phone
Additional information
Logs:
10-21 19:09:29.724   444   444 E BpTransactionCompletedListener: Failed to transact (-32)
10-21 19:09:32.713   597  3640 E TaskPersister: File error accessing recents directory (directory doesn't exist?).

This is the root cause: https://github.com/react-native-maps/react-native-maps/issues/846
[onRegionChangeComplete() callback is called infinitely] -> retriggered the hook


Not able to run all the services

Hi @meysamhadeli ,
I followed the steps which you have given to build the services separately. But I am facing errors. Can you please provide steps clearly to run all the services separately and connect them using rabbitmq ?

Hi @meysamhadeli , I followed the steps which you have given to build the services separately. But I am facing errors. Can you please provide steps clearly to run all the services separately and connect them using rabbitmq ?

Hi,
For running the project you need to follow the How to Run
 steps.
1- First step, we need run docker compose infrastructure.yaml for installing all of infrastructure that we need.
2- Second step, in root of project with this command go build -v ./..., we can build whole of services.
3- And other steps like documentation for running project...
If you follow steps like doc and have error in specific step, please give me more details or screen shot from problem here.
Thanks :)


mini-files: How to sort file base on file creat time?

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini-files
Description
In oil.nvim, you can sort files based on their creation time, but I have checked the mini files document and it does not have this option.

Neovim version
v0.9.5
Steps to reproduce

nvim -nu minimal.lua
...

Expected behavior
No response
Actual behavior
hello

This is out of scope for being built-in, but can be implemented on the user side similar to toggle showing dot files but utilizing config.content.sort instead.
Closing as not planned.

fs_entries not include file createtime

fs_entries not include file createtime

vim.loop.fs_stat() can give that information based on the full path (which is present in the output of get_fs_entry()).


Olga cortez

Created a new branch, requested new pull request and added to text file.

Awesome Job, Your Moving Right Along. Lets see some Stretch if you have time.  :)


Include "parent digest" (OCI index digest) in JSON output

We had a discussion about this in an architecture meeting just now, and we've concluded that we don't want to task Syft with this responsibility right now. In most cases, computing an OCI index digest (and implicitly, an index in the first place) would create a digest value that is attempting to guess the corresponding registry value, where the confidence of a value match is low.
Philosophically, we're going to try to keep Syft surfacing known information, as opposed to guessed information.


Kills left indicator incorrect when training on controlled.

Please check if your issue is not a duplicate by searching existing issues
Describe the bug
The kills left indicator in the xp plugin is incorrect when training on controlled. In the given example I have 102k experience left for attack and 126k experience left for defense. However it shows me as requiring 200 kills for attack and 670 for defense in order to get the next level which is not correct.
https://imgur.com/a/hvcjYmQ
To Reproduce
Train melee on controlled, maybe other combat styles I haven't tested.
Expected behavior
Attack should be at roughly 550-600ish kills left.
Screenshots
https://imgur.com/a/hvcjYmQ
Environment (please complete the following information):
Windows 10, most recent version of Runelite

Duplicate of #6479


Close voice channels with defcon shutdown

Description

Simple addition to remove the connect permission from the everyone role and restore it when done.
Reasoning

Keep people from joining voice channels during a raid, making the entire server as read only as it can get.
Did you:

[x] Join the Python Discord Community?
[x] If dependencies have been added or updated, run pipenv lock?
[x] Lint your code (pipenv run lint)?
[x] Set the PR to allow edits from contributors?

Hey @onerandomusername, thanks for the PR! It seems like you don't say why those changes were made. Chris pointed me to the discussion in #dev-contrib from last time, if you could mention it on your next PRs that'd be perfect!


Add "Contributing" section to README

I borrowed a bit of language from some other contribution guidelines I've seen, but I tried to keep it brief. I also removed the link to airtable-python-wrapper (since it just redirects here) and instead put in a link to the migration guide.

Codecov Report

Merging #244 (5e651d4) into main (2f6ecd6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   87.34%   87.34%
=======================================
  Files          14       14
  Lines         640      640
=======================================
  Hits          559      559
  Misses         81       81

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add chittur.dev

This PR is:

[x] Adding a new domain
[ ] Updating existing domain size
[ ] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

And

[x] I used the uncompressed size of the site
[x] I have included a link to the Cloudflare report
[x] This site is not an ultra minimal site
[x] The following information is filled identical to the data file

I confirm that I have read the FAQ section, particularly the two red items around minimal pages and inappropriate content and I attest that this site is neither of these things.

[x] Check to confirm

- domain: chittur.dev
  url: https://chittur.dev/
  size: 28.5
  last_checked: 2024-4-27

Cloudflare Report: https://radar.cloudflare.com/scan/d4bfe432-9fbf-4cc8-8e09-1da5045674fd/summary

Thanks!


Adding RawShaderMaterial descriptor

Actually I don't think this should extend materialdescriptorbase. Maybe it shouldn't extend anything?

Yes I think you can extend THREEElementDescriptor. I will add tests to see whether uniforms will work with this or not, but I think they should.

amended commit extending THREEElementDescriptor

Also are there any considerations with <materialResource resourceId={} /> here? Does <shaderMaterial /> already work here?

amended to remove hasWireframe() call in raw constructor

Although now getMaterialDescription() won't be there - I think I'm not yet well enough versed in this project to make this change confidently ;)

Hmm yes just realized a problem... May be better to extend shadermaterial
actually... Don't worry I'll do the necessary changes before merging, will
show you the changes to explain why :)
On Sun, 21 Feb 2016 21:01 Andrew Ray<EMAIL_ADDRESS>wrote:

Although now getMaterialDescription() won't be there - I think I'm not
yet well enough versed in this project to make this change confidently ;)
—
Reply to this email directly or view it on GitHub
https://github.com/toxicFork/react-three-renderer/pull/29#issuecomment-186915270
.

I have just looked at it further, looks like RawShaderMaterial is very very similar to ShaderMaterial, except it just doesn't add any prefixes to the vertex/fragment shaders. So it's safe to just extend :D Merging now :)

ah ok, I wasn't sure if this mattered for inheriting the other methods, for example the wireframe stuff. I don't know how docs are generated, but if they include inheritance props then the docs would incorrectly say that "wireframe" is a property you can set, which would have no effect

Yes I will be improving a lot about generating docs, testing etc, it should be much easier to add things in soon. For now I created a little guide in #2 , I will put something like that in the wiki. Regarding wireframe, it still works I think, but some of the other props may not. we will need to add tests to see which ones we can remove. Once I cook the next release ( soon :D ) I will add some examples for the new stuff in the last release.

And https://github.com/toxicFork/react-three-renderer/commit/7952d837e42d34b2aeb620937357eb30619b6f5f is the actual commit for the minor fixes I did for RawShaderMaterial.

And why it needs to extend ShaderMaterial:

Currently MaterialDescriptorBase includes the logic to assign itself to a mesh when mounted.
Additionally, it marks itself to be used as a resource
ShaderMaterialDescriptor then permits uniform variables to be added within
Also RawShaderMaterial itself extends ShaderMaterial in THREE.js


display helpful error when if --compilers used incorrectly

$ mocha --compilers babel/register
/usr/local/lib/node_modules/mocha/bin/_mocha:302
if (mod[0] == '.') mod = join(process.cwd(), mod);
^
TypeError: Cannot read property '0' of undefined
at /usr/local/lib/node_modules/mocha/bin/_mocha:302:10
at Array.forEach (native)
at Object. (/usr/local/lib/node_modules/mocha/bin/_mocha:297:19)
at Module._compile (module.js:409:26)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Function.Module.runMain (module.js:441:10)
at startup (node.js:139:18)
at node.js:968:3

The error is legit (correct usage of --compilers is extension:require).
We should probably validate that usage and spit out a more meaningful error message, though.

what can  i do with this error?
use   mocha --compilers --require   babel/register or any shell others?
i still failed to use  --require with this issue

I think your original attempt just needs "js:" before the compiler name: --compilers js:babel/register. Let me know if that doesn't work.

I successed with this:
http://jamesknelson.com/testing-in-es6-with-mocha-and-babel-6/
before,i use babel  but failed,then use babel-core successed
thanks

--compilers was removed in v6.0.0


Example for prop default value and other fixes

@somebee what is the difference between tag RegisterForm < Form and tag RegisterForm < form?


Some MapController methods should not be public.

Some methods in MapController are public and they probably should not be. These methods are:
public TouchInput.ShoveResponder getShoveResponder()
public TouchInput.ScaleResponder getScaleResponder()
public TouchInput.RotateResponder getRotateResponder()
public TouchInput.PanResponder getPanResponder()

The are only used by the MapController once and nobody else should be calling them or their methods. They should be private, if not protected.

I'll correct myself on that. Apparently these responders are the "default" responders that one must use to propagate the the event in their own responders.


Translate extend-kubernetes/compute-storage-net/device-plugins.md

This PR translates concepts/extend-kubernetes/compute-storage-net/device-plugins.md file in Korean.
This fixes #20213 .
This PR contains the following files:

content/ko/docs/concepts/extend-kubernetes/compute-storage-net/_index.md
content/ko/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

This PR is created newly to fix broken PR #20216 .

/assign @seokho-son

Preview: https://deploy-preview-20406--k8s-dev-ko.netlify.app/ko/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/

@seokho-son 리뷰 감사합니다!
의견 반영해서 업데이트하겠습니다.

/lgtm
/approve


can't connect mongo 2.4.9

Hi, I have a Unifi server with mongo 2.4.9, I've  tried so much php drivers and differents laravel-mongodb versions but still not connect, after 3 days, can anyone help the right version ?

install the latest php mongodb driver first, forget the other ones

@ludo1960 but last php driver not support MongoDB 2.4 I guess, right?
well I installed php_mongodb-1.5.3-7.1-ts-vc14-x86
with my Laravel 5.5 and Php 7.1.12
and this package
"jenssegers/mongodb":"3.3.*"

php --ri mongodb | grep version
MongoDB extension version => 1.5.3
libbson bundled version => 1.13.0
libmongoc bundled version => 1.13.0`

but

Server at sever.local:27117 reports wire version 0, but this version of libmongoc requires at least 3 (MongoDB 3.0)


fullwidth characters make the line of candidates overflow

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
Fullwidth characters (such as Japanese "あ") sometime make the line of candidates overflow when filtering them.
conditions

long line (over 1,000 chars)
includes fullwidth characters right before the filtering word

reproduce steps
$ cat list
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaあああああああああああああaaaahogeaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
$ export FZF_DEFAULT_OPTS="--reverse"
$ cat list | fzf

It can reproduce without --reverse, but it's easy to understand the problem visually with it.
reproduce screenshot

fzf gives up calculating the actual display width of an entry when the number of characters of it exceeds 1024. That is to avoid rendering delay when processing extremely long lines.
ruby -e '100.times { puts "-" * 100000 + "foo" }' | fzf -q foo

I'll see if there's a better way to handle this.

Should be fixed now, thanks for the report.


Tag npm releases

Hi 🙂
I got somewhat confused about the versioning of this library.
The npm version right now is 0.7.1, while the latest tag on github is 0.6.0.
Is there any way we could ensure, that released npm versions are tagged, so that we can figure out from commits what changed. (Changelog would be even better, but since this is not a stable library, maybe not quite there yet.)
I'm under the impression google even has some kind of bot that can do the version release automation for you, isn't there?
Although this could as well just be some npm script.

I use np on other projects, but it was failing for me here. I'll try to get that working again so releases are tagged.

Are you using npm version? In that case, do git push --tags.

Here is how I release a quick fix to NPM
git add -A
git commit -m "Fixed it"
npm version minor
git push --follow-tags
npm publish

--follow-tags will only push tags whose related commits are being pushed. --tags will push all tags (but only the tags).

I've been releasing with np which handles this correctly now.

Awesome!

You're still missing historical version tags. The only tags available right now are 0.6.0 and 0.10.0.
Please do a git push origin --tags (or whatever you call the Polymer/lit-html remote repo).


fi-1748 Add attestation about extending duration of refresh tokens.

Adds attestation regarding extending the life of refresh tokens. I based the language of the attestation from the test procedure, and provide more details in the 'About' section.

Language from the test procedure:

AUT-PAT-22: The health IT developer demonstrates the ability of the Health IT Module to issue a refresh token valid for a new period of no shorter than three months without requiring re-authentication and re-authorization when a valid refresh token is supplied by the application according to the implementation specification adopted in § 170.215(a)(3).

I felt like it would be useful to mention that this is different than the refresh token duration attestation in the  'about' section, as I figured that would be a common question.  That one is:

9.10.05 Health IT Module attested that it is capable of issuing refresh tokens that are valid for a period of no shorter than three months.

Relevant github ticket: https://github.com/onc-healthit/onc-certification-g10-test-kit/issues/382

Is it necessary to include the last sentence about "previous attestation"?

Is it necessary to include the last sentence about "previous attestation"?

I'm not sure.  I added it because I personally feel like it is confusing to have 2 attestations about refresh token duration, so I tried to provide a bit more information.  I updated it to be "a separate attestation" to avoid any ordering issues, which makes a bit more sense.
Note that this iis only shown if you click into the test to see the About tab.


“Provider <> planned an invalid value” for task resource while upgrading from 0.47.0 to 0.80.0

Terraform CLI and Provider Versions
Terraform CLI: 1.0.9
Snowflake-Labs/snowflake Version: upgrading from 0.47.0 -> 0.80.0
Terraform Configuration
resource snowflake_task task_xyz {
  comment = "xyz"
  database = "database_xyz"
  schema = "schema_xyz"
  name = "xyz"
  schedule = "USING CRON 0 0/2 * * * UTC"
  enabled = true
  user_task_managed_initial_warehouse_size = "XSMALL"
  sql_statement = "xyz"
}

Expected Behavior
As we did not change anything on our resources during the upgrade to version 0.80.0, we expected a Terraform plan (& Terraform apply) without any change.
Actual Behavior
Error Log form DevOps Pipeline:
Error: Provider produced invalid plan
│
│ Provider "registry.terraform.io/snowflake-labs/snowflake" planned an
│ invalid value for
│ module.account_usage.snowflake_task. task_xyz.error_integration:
│ planned value cty.StringVal("") for a non-computed attribute.
│
│ This is a bug in the provider, which should be reported in the provider's
│ own issue tracker.
╵
╷
│ Error: Provider produced invalid plan
│
│ Provider "registry.terraform.io/snowflake-labs/snowflake" planned an
│ invalid value for
│ module.account_usage.snowflake_task. task_xyz.allow_overlapping_execution:
│ planned value cty.False for a non-computed attribute.
│
│ This is a bug in the provider, which should be reported in the provider's
│ own issue tracker.
╵
╷
│ Error: Provider produced invalid plan
│
│ Provider "registry.terraform.io/snowflake-labs/snowflake" planned an
│ invalid value for
│ module.account_usage.snowflake_task.task_xyz.after:
│ planned value cty.ListValEmpty(cty.String) for a non-computed attribute.
│
│ This is a bug in the provider, which should be reported in the provider's
│ own issue tracker.
╵
│ Error: Provider produced invalid plan
│
│ Provider "registry.terraform.io/snowflake-labs/snowflake" planned an
│ invalid value for
│ module.account_usage.snowflake_task.task_xyz.warehouse:
│ planned value cty.StringVal("") for a non-computed attribute.
│
│ This is a bug in the provider, which should be reported in the provider's
│ own issue tracker.
╵
╷
│ Error: Provider produced invalid plan
│
│ Provider "registry.terraform.io/snowflake-labs/snowflake" planned an
│ invalid value for
│ module.account_usage.snowflake_task.task_xyz.when:
│ planned value cty.StringVal("") for a non-computed attribute.
│
│ This is a bug in the provider, which should be reported in the provider's
│ own issue tracker.
╵
╷
│ Error: Provider produced invalid plan
│
│ Provider "registry.terraform.io/snowflake-labs/snowflake" planned an
│ invalid value for
│ module.account_usage.snowflake_task.task_xyz.session_parameters:
│ planned valu_e cty.MapValEmpty(cty.String) for a non-computed attribute.
│
│ This is a bug in the provider, which should be reported in the provider's
│ own issue tracker.
=> Hence, for all configuration parameters which we did not use in our resource befor the upgrade, we got an error.
We tried to work around this by including non-conflicting, missing attributes into the resource configuration like this:
resource snowflake_task task_xyz {
  comment = "xyz"
  database = "database_xyz"
  schema = "schema_xyz"
  name = "xyz"
  schedule = "USING CRON 0 0/2 * * * UTC"
  enabled = true
  user_task_managed_initial_warehouse_size = "XSMALL"
  sql_statement = "xyz"

  when = ""
  # after = []
  # warehouse = ""
  error_integration = ""
  allow_overlapping_execution = false
  session_parameters = {}
}

As expected, we only are left with the above error for parameter  “warehouse” and “after” which we can not resolve like this due to being conflicting with other parameters.
According to the resource code and documentation those parameters should all be optional and we should not get any error when upgrading the provider only.
Steps to Reproduce

terraform init (using constraint on provider version 0.47.0)
terraform plan
terraform apply
terraform init -upgrade (without constraint on provider version => upgrade to version 0.80.0)
terraform plan

How much impact is this issue causing?
Medium
Logs
No response
Additional Information
The root cause might be related to the terraform version instead of the Snowflake provider (see links).
It would be useful to know, whether there is a specific terraform version requirement when using the Snowflake provider.
https://gitlab.com/gitlab-org/terraform-provider-gitlab/-/issues/1394
https://discuss.hashicorp.com/t/plan-failures-with-terraform-1-5-0-and-framework-1-2-0/54961
https://github.com/hashicorp/terraform/releases/tag/v1.5.1

Hey @LukLight. Thanks for reporting the issue.
You are right, please first bump the Terraform CLI you are using to at least 1.1.5 (but the newest possible is preferable).
We don't have a compatibility matrix yet, but we have it on our roadmap.

Hi @sfc-gh-asawicki,
Many thanks for the fast feedback!
We upgraded our Terraform CLI and this solved the issue :)


global: Add GNU GLOBAL v6.6.3

Add description and change homepage to GNU GLOBAL's homepage instead of win32-port's homepage.


Spaces in a properly formatted IBAN will result in a validation error

In the 5.3.1 version used in the MVC example (which can be downloaded here), a formatted, valid IBAN is also validated as such.
However, not in the current version 5.9.0, only if the spaces have been removed. Of course, that makes handling more difficult, since I have to replace the spaces in the model, validate them again, then put the formatted string in again, etc.
Is there an option that formatted IBANs that are correct can also be validated without errors?

This was changed in v5.7.0
Both the data annotations and fluent validation implementations now have a strict parameter (default true), with which you can allow more relaxed validation (whitespace, casing). I will update the wiki when I have some time.

Many thanks for the quick and competent answer. Then it's not a bug :-)

AspNetCoreExample updated with non-strict in #159.


[FLINK-25546][flink-connector-base][JUnit5 Migration] Module: flink-connector-base

What is the purpose of the change
Migrate flink-connector-base module to AssertJ and JUnit 5 following the JUnit 5 Migration Guide
Brief change log
Use JUnit5 and AssertJ in tests instead of JUnit4 and Hamcrest
Verifying this change
This change is a code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): ( no)
The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
The serializers: ( no)
The runtime per-record code paths (performance sensitive): ( no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper:  no)
The S3 file system connector: ( no)

Documentation

Does this pull request introduce a new feature? ( no)
If yes, how is the feature documented? (not applicable )

@flinkbot run azure

@Jiabao-Sun since you are one of those who contributed a lot in JUnit5 migration may I ask you to have a look here?


Lecture videos

Are the lecture videos available anywhere?
Apologies for raising an issue. If the discussion board is available I would've asked there.

Hi! They are available for the previous year's iteration: https://github.com/mryab/efficient-dl-systems/tree/2023
Current ones are within YSDA's LMS (and they are in Russian anyway), but I will look into uploading them in some capacity

Thanks, hopefully to see this year's video.

can you upload them to youtube or add trasnalation?


Uid 1000 not found in xenial

Please paste the output of the following command here: sudo edit-chroot -all

Xenial
Please describe your issue:
ive tried alot of stuff now from trying different desktop enviorments to even deleting and retrying ive updated the chroots too and every install fails to finish chroot setup and then when i type y to finish setup it just says uid1000 not found on xenial i dont think it has anything to do with me being on a stoney ridge chromebook but im also on version 126 dev channel is anyone can help let me know
If known, describe the steps to reproduce the issue:

https://github.com/dnschneid/crouton/wiki/(CIF000)-A-completely-"new"-crouton:-follow-these-instructions

I'm familiar this, it happened to me too:

Login as chronos in the VT-2 terminal ctrl+alt+->

Type sudo enter-chroot -n "chroot_name"  -u root
This logs into the chroot as the root user, which is already there before chroot creation is complete

Then, once in the chroot, type sudo useradd "username" -m to add a new user (with setuid 1000)

After that, use sudo passwd "username" to set a password for your newly created user

Type exit to leave the chroot environment.

Enter-chroot should now log you in as the user you just created with no additional steps.
sudo enter-chroot -n "chroot_name"


Erlang 19 support; Snappy fails

cqex fails because of snappy.
https://github.com/fdmanana/snappy-erlang-nif/issues/17

Now it should work, with your PR into cqerl


Firefox plugin > Erro: Unable to locate session store file for firefox

the firefox plugin for quicksilver doesnt import history or bookmarks and i have this error in my notification center.

this is the error i am getting in console
Jul 31 07:45:38 mac Quicksilver[2757]: Error while reading Firefox's places.sqlite DB. Error 11: malformed database schema (moz_meta) - near "WITHOUT": syntax error

They must have changed the layout in the database. Someone will need to update the plug-in. Until then, you could disable the Catalog preset from the plug-in and try scanning the bookmarks from a file instead.

The Firefox plugin has been updated to fix this issue. Please keep an eye out for an updated Firefox plugin from within Quicksilver.
Thank you for reporting the issue, @damionx7 !


Update coveralls badge

#minor

Coverage decreased (-0.009%) to 78.903% when pulling 9cd74194d0a5621e4fd0e54dceb4cea97b5c0fe7 on moniriv/fixcoverall into 9a466676606184bce15dfa0aa507c469b0538048 on main.


Py3 minor fixes

Hello, a couple of minor fixes for python3.

@maurov   Thanks for catching those!


Binary files getting labeled as missing DEP/ASLR/SIGN related flags

Describe the bug
When running the analyzer on some .dll files, certain files are flagged as missing the following flags IMAGE_DLLCHARACTERISTICS_NX_COMPAT and IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE, IMAGE_DLLCHARACTERISTICS_HIGH_ENTROPY_VA in the header.
Local debugging has it traced to GetDLLCharacteristics() which creates PeNet.FileParser.MMFile which uses MemoryMappedFile.CreateFromFile(). CreateFromFile() returns UnauthorizedAccessException on a read only file. GetDllCharacteristics() then handles the error, does a log print and returns an empty response, making the FileCollector think the dll is missing all charactersitics.
To Reproduce
Steps to reproduce the behavior:

Run a file collector over an empty directory (Run 1)
Copy a write protected .dll file with NX_COMPAT/DYNAMIC_BASE/HIGH_ENTROPY_VA in the directory
Run a file collector over the same directory without write permissions to the file (Run 2)
Run analysis on Run 1/2 (analysis shows missing flags)
Add write permissions to the .dll file
Run a file collector with write permissions to the file (Run 3)
Run analysis on Run 1/3 (analysis does not show missing flags)

Expected behavior
The analyzer should not need write access to the file it is analyzing. If the analyzer is not able to access a file, it should mark that as an error, it should not quietly dismiss the access error and then flag the file with different warnings.
Screenshots
N/A
System Configuration (please complete the following information):

OS: [e.g. Windows] Windows
OS Version: [e.g. Windows 10 1803] Windows 10
Application Version: [e.g. 2.0.1-beta+50af283871] 2.3.292
CLI or GUI: both

Additional Context
N/A

@m3vaz Thank you for the detailed report and reproduction instructions. I'll investigate and should have a fix posted this week.

The analyzer should not need write access to the file it is analyzing.

I agree. It looks like PEFile has a ctor that takes a Stream, so as long as the file is readable we can retry to read it into a Stream and then perform the analysis from there.

If the analyzer is not able to access a file, it should mark that as an error, it should not quietly dismiss the access error

Is this a request to raise the verbosity of errors when fetching dll characteristics?

If the analyzer is not able to access a file, it should mark that as an error, it should not quietly dismiss the access error

Is this a request to raise the verbosity of errors when fetching dll characteristics?

I don't think increased verbosity would help, especially if that verbosity isn't reflected in the gui workflow. When using the gui, I would:

Scan with FileCollector
Change things on file system
Scan with FileCollector
Analyze
Export to json

The core issue is that the analysis (4.) reports incorrect information, when it should report that it doesn't have enough information to do the analysis on the specific file. The request would be that the access error is flagged in the scan (1. or 3.) and then reflected in the analysis (4.).
Right now the analysis will report:
        "Rules": [
          {
            "Description": "Flag when executables are created without DEP.",
            "Name": "Missing DEP"
          },
          {
            "Description": "Flag when executables are created without ASLR.",
            "Name": "Missing ASLR"
          },
          {
            "Description": "Flag when unsigned/incorrectly signed binaries are added.",
            "Name": "Unsigned binaries"
          }
        ]

instead it should report
        "Rules": [
          {
            "Description": "Flag when errors encountered during scanning",
            "Name": "Missing scan information"
          }

or something similar.

If modifying the analysis output is out of the question, then the alternative request would be to just stop the scan when an error is encountered.

I pushed a fix last night that should resolve reading signature and dllcharacteristic data from read only files on windows. #685
For the secondary requests, reporting gathering errors during analysis is a rather large change but I'll add a work item to consider it and think about how it could be done.
Exiting when encountering any collection error is an even larger change, and likely depends on the previous work to decide if it should exit.


Bug: User Role Not Updated After Login

Issue: If a Github owner switches their user role by modifying the organization team that they are on ('admin', 'staff', 'student')  it is not updated after re-logging into Classy. Therefore, they become stuck viewing a different user role view on the Classy UI.
Expected Behaviour: A user role IS ALWAYS updated when logging in.
Actual Behaviour: A user role is NOT updated when logging in.
Workaround: Update database person entry to define user role or reset it to null.

Temporary workaround: go into database, and update user role manually.

Once person.kind is defined with any truthy statement, then there is no way for this check to run again in AuthController.personPrivaledged():

Oddly enough, the role is being set sometimes and not other times. I am still trying to figure out why.
Even if one is an adminstaff on Github teams, if one becomes a student in the database, one gets stuck in that role. It doesn't necessarily work the other way though.

One possible breadcrumb in AuthRoutes.ts...
A check for a Github person occurs during the authentication OAuth callback:

Note: An Auth object that contains the person.id and token are saved to the database for authentication verification.

UserId comes from headers in getCredentials() --> sent to performGetCredentials() --> Goes to data layer to retrieve the person object based on the user and token --> which returns the isPrivileged object.
If there is no object in the database, the isPrivileged object is created from the logic outlined in performGetCredentials() and saved to the data layer.
I think this is the culprit:

Going forward with this, I think it is reasonable for the user role to be cached, as the current configuration is set for, but it needs to be updated each time on login.

We need the personPriviliged() method to think that the person.kind attribute is null each time a user logs in. The login and authentication logic is already pretty complicated, so I will reset the kind attribute to null each time a user logs out.

NOTE: The Person model kind attribute is re-used for student withdrawal logic. Withdrawal logic is triggered by a manual operation when a faculty clicks on the "Withdraw Students" button in the Admin Panel. If a student appears in the database, but the student no longer appears in the most recently updated Classlist, then the student kind property is marked as WITHDRAWN.
If a student no longer is registered in a course, the user is not part of the Students team of an organization and can therefore not login. Since the student cannot login again, the kind attribute will not be updated after being labelled as WITHDRAWN. The only exception is if a student re-registers for a course, in which case, they will be re-added to the LDAP group, be able to authenticate, and the student kind will automatically be updated to the STUDENT type.

Cannot log in to what? The student will probably still be able to login to github (because of other CPSC courses they are enrolled in). They just won't be in the specific course group.

Cannot log in to what? The student will probably still be able to login to github (because of other CPSC courses they are enrolled in). They just won't be in the specific course group.

Will not be able to login to Classy, as they are not found on the students team.

OK, I get the logic now. Thanks.

I think I finally understand it too. I am going over the most viable solution that makes sense and finding a proper home for it.

Classy login tests do not exist, likely, because:
(1.) Basic authentication via Github is being deprecated.
(2.) There is complexity involved with authenticating to Github so that one can authenticate with the Classy application (What happens if Github interrupts the auth flow to re-ask for privileges to share permissions, etc.)
(3.) One must orchestrate tying a Github session to a Github OAuth Application session, and then finally login.
I do not think this figuring this out is necessarily worth the effort, as the application has demonstrated reliability without these login tests.


mvnd doesn't work with duplicate-finder-maven-plugin

while it works with mvn, with mvnd doesn't
<configuration>
    <exceptions combine.children="append">
        <exception>
            <conflictingDependencies>
                <dependency>
                    <groupId>...</groupId>
                    <artifactId>...</artifactId>
                </dependency>
            </conflictingDependencies>
            <classes>
                <class>...</class>
                <class>...</class>
            </classes>
        </exception>
    </exceptions>
</configuration>

Could you please complete the description by adding some steps to reproduce? A minimal reproducer project would be ideal. What does your "doesn't work" mean? Any stack traces or error messages?


:question: extending pyhsmm observations

:question:  (not sure how to assign label, I think a project developer needs to)
Hi,
I am using pyhsmm for a research project (thanks for making this public, it's awesome!) and I wanted to use a slightly different observation distribution, or rather different prior on the observation distribution, namely a scaled inverse whishart or separated correlation/variance matrices (see http://www.themattsimpson.com/2012/08/20/prior-distributions-for-covariance-matrices-the-scaled-inverse-wishart-prior/) as a prior for the covariance matrices.
My questions is whether this can be done just by extending the Gaussian class in pybasicbayes (https://github.com/mattjj/pybasicbayes/blob/master/pybasicbayes/distributions/gaussian.py), or do I have to change things inside of the Gibbs sampler as well?
If extending the Gaussian class is enough, which functions need to be implemented/changed. Would mirroring IsotropicGaussian be enough despite the '# TODO collapsed, meanfield, max_likelihood' ?
Happy to make a pull request back into the project if I get it to work :)

I haven't had a chance yet to read that pdf you linked (it looks like I would learn a lot from it!), but I'll try to answer your question as best I can without reading it.
You should probably extend a Gaussian class in pybasicbayes, if only just to organize the code in the way pyhsmm expects (and in a way that would be easy to make a PR to pybasicbayes!). I'm not sure if much of the machinery in the existing classes will be useful for your purposes, but by extending _GaussianBase you'd at least get plotting, log likelihood, and random variable generation.
As for what you'd need to implement, check out the abstractions.py file in pybasicbayes. The GibbsSampling class shows that you only need to implement a resample method on top of the requirements of its parent Distribution, which are just log_likelihood and rvs (which come in _GaussianBase). In general, the methods you need to implement are marked as abstractmethod.
Since IsotropicGaussian implements those, it supports the GibbsSampling interface, and so it might be an okay reference point. However, classes that I've written more recently tend to be better. The Regression class is a related class I've worked on more recently than any of the Gaussian classes. Maybe DiagonalGaussian is the most recent of the Gaussian ones, though Gaussian gets the most attention.
Once you support that interface, you can pass instances of your class in the obs_distns list and Gibbs sampling will work for any model in pyhsmm or pybasicbayes.
Glad you like pyhsmm, I hope you find it useful!


Add methods to override address inference in PcapWriteHandler

Motivation:
The PcapWriteHandler has requires either a SocketChannel or a DatagramChannel to infer TCP / UDP connection details. This makes it useless for debugging an EmbeddedChannel.
Modification:

Add forceTcpChannel and forceUdpChannel methods to allow users to bypass the channel metadata inference and provide their own information.
Move handler initialization from channelActive into a separate method that is also called on any write or read. This ensures the new inference code runs even if channelActive isn't called. With the old inference code, this would have broken further down the line because handlerAddr and initiatiorAddr are null and the writer code can't deal with that, except the udp DatagramPacket branch. The change is necessary to maintain compatibility with that DatagramPacket branch, and to make use with EmbeddedChannel easier (EmbeddedChannel does not fire channelActive unless requested).
Add tests for EmbeddedChannel based on the existing tests. This also changes the test case for normal udp/tcp a bit, because the test case mixed up the remote and local address (this was previously not an issue because both were <IP_ADDRESS>).
Improve error message for incompatible channel type, and elevate it to a warning. It should never appear with proper use of PcapWriteHandler.

Result:
PcapWriteHandler can now be used to debug test cases that use EmbeddedChannel.

oops, checkstyle.

/cc @hyperxpro

@yawkat For Netty 5, we moved these classes to a contrib repository: https://github.com/netty-contrib/handler-pcap - feel free to update that as well.

https://github.com/netty-contrib/handler-pcap/pull/1


Update README.md

I’ll resolve the conflict…

Added the changes to #53 (in this commit https://github.com/cljoly/telescope-repo.nvim/commit/f0e50add1cfaac28dc2d36b33358bd6e34ebe0e6)
You are still credited as the author of this commit.


use correct availability status, further changes

SetStatus, was working before but has to be changed to reflect the changes in the Availability enum

sorry forgot this in the first commit, sorry my first pull request :)

please merge this also, without this the project will not build.


Add cmdline completion for :e ++opt=arg and :terminal [++options]

Just more cmdline completion for some of the other common pain points I encounter.

oh very nice. thanks.


Add Golang 1.19.10 and 1.20.5

Add Golang 1.19.10 and 1.20.5

can you please release this to homebrew
brew update && brew upgrade goenv did not work ...

@grosser done. See https://github.com/Homebrew/homebrew-core/pull/133303

Could there be some automatic install without having to always update
gonenv ?
For example guess the url of the version that was requested and then
install it 🤗
On Fri, Jun 9, 2023, 9:41 PM Stathi C. @.***> wrote:

@grosser https://github.com/grosser done. See
Homebrew/homebrew-core#133303
https://github.com/Homebrew/homebrew-core/pull/133303
—
Reply to this email directly, view it on GitHub
https://github.com/syndbg/goenv/pull/304#issuecomment-1585481038, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACYZ7IQNJSK5PGGMCNQMTXKP3IJANCNFSM6AAAAAAY5GKTW4
.
You are receiving this because you were mentioned.Message ID:
@.***>


question about batch size and lr

Hi, I have a question about the batch size.
In your paper, you trained the model on 4 Tesla V100 with a batch size of 12.
But from you config file, batch size is set to 3 and it seems V100 doesn't have enough gpu memory for a batch size of 12.
So I assume the batch size is batch size per gpu.
https://github.com/wayveai/fiery/blob/44b465fc69c1d7e5aa3c5e024dae9d4af51fe6e6/fiery/configs/baseline.yml#L5
In this case, if I use 2 GPUs instead of 4, should I also reduce the learning rate by half?
Thank you very much! Looking forward to your reply!
Best Regards,
Xinchao

Hey! Sorry for the late reply. In PyTorch Lightning, the batch size parameter is per gpu, so with 4 gpus that's 3x4=12 elements indeed.
If you only use 2 GPUs, you can try halving the learning rate yes :)


Fix 14 typos

I have been studying this repository for a long time, and whenever I come across a typo, I fix it.
I discovered 14 typos in a total of 9 files. Then I merged them together.
The code quality is exceptionally high, so sincerely hope my PR can help make this repository more standardized.

@p0p3yee  hope this pr is useful for you


Section links not present on the "Quickstart: Install the AzureSphere SDK for Windows" page

This is major nitpicking here, so take it with a grain of salt.  On the "Quickstart: Install the AzureSphere SDK for Windows" page the last two major headers don't provide links.
To reproduce the issue . . .

Open the page: Link
Hove the mouse cursor over the major sections titles "Prerequisites", "Set up your dev kit on a Windows PC" or "Install the Azure Sphere SDK"
Notice that when the mouse hovers over these sections a clickable link icon appears to the left of the text, I use these links a lot in my Azure Sphere documentation and blogs, I like them!
Now hover the mouse over the last two major sections "Install CMake and Ninja on Windows" and "Install the Azure Sphere extension for Visual Studio Code"
The dynamic link icon does not appear

Again, I apologize for documenting such a minor issue.  My own best practice with issues is to document everything, then decide what to actually fix.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3859174a-d1d6-d10e-5fbf-8d83f8e0f150
Version Independent ID: 93000ca6-7a4d-11da-27d0-ba7430e83d6a
Content: Set up a dev kit and install the Azure Sphere SDK for Windows
Content Source: AzureSphere/articles/install/install-sdk.md
Product: azure-sphere
GitHub Login: @prabhushyja
Microsoft Alias: azurespheredocs

Hello @bawilless
Thanks for the feedback! We are currently investigating and will update you shortly
I see as below, Got it!
The Dynamic link is displayed!

No Dynamic link is displayed! we are looking into the last 2 sections!!!

Hello @bawilless
Thanks for the feedback! We are currently investigating and will update you shortly
I see as below, Got it!
The Dynamic link is displayed!

No Dynamic link is displayed! we are looking into the last 2 sections!!!

Hello @bawilless
I have assigned the issue to the content author for further review and update the doc as appropriate.

Hello, @bawilless
Thanks for the feedback, Brian. Unfortunately there's no fix for this at present; it's a bug in the Choose your development environment toggle at the top of the page. You can still right click and copy the links for those headings from the mini-TOC on the right rail.
Closing this issue, but we do appreciate the feedback!


Zeppelin process died

Iam wondering why my Zeppelin process died. Here is the log file:
Select the type of Zeppelin installation:

Default (Hadoop 2.4.0; Spark 1.3.1; local mode)
Good for quickstart:
does not require local Spark installation
does not require external Spark cluster
Advanced (pick versions and adjust configuration to your cluster)
1

Configuration is finished now,
please review the options you have chosen before installation begins:
Spark version: 1.3.1
Hadoop version: 2.4.0
Spark master URL: None
Resource manager: Spark standalone
Zeppelin port: 8080
y(es)/n(o) ?
y
Initiating installation...
[2015-06-27T22:31:52+0000]: Downloading Apache Zeppelin (incubating) from zeppelin-0.5.0-incubating-SNAPSHOT-spark1.3.1-hadoop2.4.0.tar.gz...
######################################################################## 100.0%
[2015-06-27T22:32:28+0000]: Done
[2015-06-27T22:32:28+0000]: Unpack zeppelin-0.5.0-incubating-SNAPSHOT-spark1.3.1-hadoop2.4.0.tar.gz to zeppelin-0.5.0-incubating-SNAPSHOT ...
[2015-06-27T22:32:32+0000]: Done
[2015-06-27T22:32:32+0000]: Downloading Zeppelin configuration file ...
######################################################################## 100.0%
[2015-06-27T22:32:32+0000]: Done
[2015-06-27T22:32:32+0000]: Pyspark found at /python:/python/lib/py4j-<IP_ADDRESS>-src.zip
[2015-06-27T22:32:32+0000]:   Reading the zeppelin-env.sh
[2015-06-27T22:32:33+0000]: Done
To run Apache Zeppelin (incubating) now do:
./bin/zeppelin-daemon.sh start
and visit http://localhost:8080
ubuntu@ip-172-31-25-168:~$ ls
zeppelin-0.5.0-incubating-SNAPSHOT
zeppelin-0.5.0-incubating-SNAPSHOT-spark1.3.1-hadoop2.4.0.tar.gz
ubuntu@ip-172-31-25-168:~$ cd zeppelin-0.5.0-incubating-SNAPSHOT
ubuntu@ip-172-31-25-168:~/zeppelin-0.5.0-incubating-SNAPSHOT$ ./bin/zeppelin-daemon.sh start
Log dir doesn't exist, create /home/ubuntu/zeppelin-0.5.0-incubating-SNAPSHOT/logs
Pid dir doesn't exist, create /home/ubuntu/zeppelin-0.5.0-incubating-SNAPSHOT/run
Zeppelin start                                             [  OK  ]
Zeppelin process died                                      [FAILED]
ubuntu@ip-172-31-25-168:~/zeppelin-0.5.0-incubating-SNAPSHOT$

@Emaasit thank you for your interest in Apache Zeppelin (incubating) and Z-Manager!
It looks like your installation went fine, so as soon as Zeppelin is incubating under Apache - the way to get help with it would be to ask the community on the user@ mailing list.
One way to get help quicker is to attach logs from your Zeppelin instance to the email on the list, you can find all logs under ~/zeppelin-0.5.0-incubating-SNAPSHOT/logs/
Hope this helps!


ENH: RSI is window safe, make it so

LGTM

Coverage increased (+0.0008%) to 87.493% when pulling 64d6bd5d7c7dc11ecec7a1d8e79e3e688fbaf249 on rsi-window-safe into ea677bbb0846b08030cd6dab42c46c9b117c4b31 on master.


Security #1: Attempt to bump up generic-array

Addresses report from dependabot: https://github.com/atsams-rs/atsamx7x-rust/security/dependabot/1

The linked report does not exist: 404.

That's pretty interesting, so for some bizarre reason you don't have access rights to it.

What about now?


New method to report a selected list of arrangements based on online daemons

The concept is to examine the arrangements in a catalog and report only those arrangements allowable with the current list of online, functional daemons and/or those commented out in a configuration file.    The method may be called at init and may also be available as an exposed method.
Potentially resolves #10

I think this could be a really elegant solution. Depending on how dynamic we want to be, this might be the kind of thing that doesn't even need an exposed method---it could just happen in the background. We'll need to decide what is and isn't cached by clients. The old idea of intentionally kicking clients to force cache invalidation could be relevant here.

This would require additional work to determine this, the problem at this stage is that the attune daemon just tries and fails to contact the underlying motors.
Now, that additional work may be valuable in its own right as well, so may well be worth doing.

If a background "update_state" were to occur where the daemon did in fact look for available arrangements, and if something changed where something became suddenly unavailable, would that cause a problem for docker?

Wouldn't a failure to connect essentially mean the motor is offline for all intents and purposes, so the only thing left is to tabulate the failures and go through the list of arrangements to see which ones carry a tune associated with that motor and leave that out from the reported list.


api: Generate CRDs from APIs

Superseded by #456, and other subsequent PRs, that'll break things in smaller PRs.


Fix line indentation on reformatting changed lines with blackconnect

Use case: I work in larger legacy codebases in which I don't want to reformat an entire file when I make a change. So I have pycharm configured to only reformat the changed code on save. And then have blackconnect trigger on code reformat. This way I can have blackd reformat only my code changes, while leaving the rest of the file unharmed. This currently doesn't work, there are cases when I change small fragments of existing code and the indentation breaks.
This PR adds a test to show what I mean :) and also provides a fix. I must say in honesty that this is the first time I'm changing an Intellij plugin so I may not do the right thing. I'm happy to further improve this work based on your feedback @lensvol .
Thanks a lot for this amazing plugin!

Thank you! I will look at this contribution soon, hopefully. :)

Hey @lensvol just a friendly ping to check whether you have some time for this PR. Otherwise I'll just ping you again in a little while.

Looks good to me! Thank you for this! :)

Thanks! There is one remaining thing though, the line length that blackd get's to see this way can be the length without indentation. I'll look into it and update the PR.

Hmm never mind, it looks like black by default doesn't split up long lines of strings. Unless you add the --experimental-string-processing option to it, see: https://github.com/psf/black/issues/1802. So ignore my previous statement :)

If you are finished, then I propose we merge this :)


Update README

Add experimental commands section and update Legal.

Thanks!

Thanks!

Thanks for the merge! 😄

Thanks for the merge! 😄


Concrete type propagation using ProtocolConformanceAnalysis

Part 2 of https://github.com/apple/swift/pull/16739/
This peephole optimization propagates concrete types for self arguments  and rewrites witness methods using ProtocolConformanceAnalysis!

@slavapestov Second PR for concrete type propagation of self arguments using ProtocolConformanceAnalysis, that was merged couple of days ago.

@atrick @slavapestov can you review this PR now? I have taken care of all the comments.

@atrick @slavapestov Any possibility of getting this review done? Thanks.

@atrick Moved the code that separately populated ConcreteExistentialInfo as an alternative constructor for ConcreteExistentialInfo. Can you check and let me know if you have any other concerns?

@atrick @slavapestov Cleaned up the interfaces a bit. Please have a look now.

@atrick @slavapestov Done. Anything else?

@rajbarik thanks for fixing the test.

@swift-ci Please test

@swift-ci Please test source compatibility

Build failed
Swift Test OS X Platform
Git Sha - cc1638c2ef50a4f0ef357f5f9bd09430d1814799

@swift-ci Please test source compatibility

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - a5aef01496d233e6ac135e597c0e2141d7c4b452

@rajbarik
/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/test/SILOptimizer/sil_combine_protocol_conf.swift:247:11: error: CHECK: expected string not found in input
15:46:57 // CHECK: load [[S11]] : $*Builtin.Int64
15:46:57           ^
15:46:57 <stdin>:1376:51: note: scanning from here
15:46:57  %8 = struct_element_addr %7 : $*Int, #Int._value // user: %9
15:46:57                                                   ^
15:46:57 <stdin>:1376:51: note: with variable "S11" equal to "%8"
15:46:57  %8 = struct_element_addr %7 : $*Int, #Int._value // user: %9
15:46:57                                                   ^
15:46:57 <stdin>:1377:7: note: possible intended match here
15:46:57  %9 = load %8 : $*Builtin.Int32 // user: %20
15:46:57       ^
15:46:57
15:46:57 --
15:46:57

Looks like you need to tweak the regex for 32 bit. Please run check-swift-validation-iphonesimulator-i386 locally.

@swift-ci Please test

@swift-ci Please test

@rajbarik +1! Congrats!

@atrick @slavapestov  Thanks a lot for all your help!

@rajbarik Thanks for keeping at it.