I am missing the "view more" link

Hey!
Thank you for the issue. What version of the package are you using?

v3.0.0

Since the package is now using the native Filament widgets, we can't put any more links in the footer as previously.
Now you will find the "View more" link under the heading:

great! :)
however plausible.io is hardcoded, but it should respect the FILAMENT_PLAUSIBLE_HOST config entry.
I can make a pull request if you want...

@grafst you're right, sorry! Yeah a PR would be awesome, thank you :)


dismissing onboarding takes two clicks

i could replicate this in a new env as well
likely since this is web app too, we could have a playwright test for it too
more info here https://github.com/KittyCAD/modeling-app/issues/1917#issuecomment-2127606635

I can replicate in Tauri but not in the web version, but we should still have a Tauri E2E test. Investigating more.

There is a race condition between these two function calls here. The onboardingStatus setting is set in memory but has not been persisted to the file system by the time navigate() is called. Then, if we are in Tauri, the onboardingRedirectLoader reads the current onboarding status value from file.
I have to think about how to know I've persisted the setting before I can advance to navigating.

In the web version it closes in 1 for me as well

tauri tests


Automatically set full task version in Azure Pipeline

This will bump the major version of the task in the published extension so it's officially v1 now.

/azp where


Empty View throws error

Using an empty view throws an error in viewEngine.js in method "ensureSingleElement" since allElements only contains empty string instead of DOM node.
Same in "createView" after processMarkup is called.

@paranoxx I've run into this a couple of times, the only solution I can find is by creating DOM element i.e. div or section, etc..  Looking at the source it looks like this may be intentional?  Maybe @EisenbergEffect can weigh in, if not I can make a PR for the fix.

What is the use case?  Why would we need to require in an html file with no mark-up?  Trying to understand the issue better.

@PWKad I guess its more that everything needs to be wrapped in some element, iirc

The use case is when you are creating a child routing scenario with an empty child route. Let's say you have a master-detail view and you want to save-and-close the detail, you might want to depopulate the view.
I can look into guarding this by creating an empty element if no markup is provided.


Fix Discord invite link in header

Description

Motivation for change?
The Discord invite link in the header of https://docs.stacks.co/ site was wrong.
What was changed?
In file: src/components/header.tsx, Discord link was changed from: 'https://discord.com/invite/6PcCMU', to: 'https://discord.gg/zrvWsQC'. I've tested new link during my sign up to the server. New link comes from https://community.stacks.org/ website.
Link to relevant issues?
No issues were created

Checklist

[x] Conventional commits were used
[ ] New links to files and images were verified - do not apply
[ ] For fixes/refactors: all existing references were identified and replaced - do not apply
[ ] Style guide was reviewed and applied - do not apply
[ ] Clear code samples were provided - do not apply
[ ] People were tagged for review

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


OLS-549: Proper output to CSV file

Description

Strip endlines from query + LLM response for better output table.
Full quoting in CSV cells (not nice to read, but safer for readers)

Type of change

[ ] Refactor
[ ] New feature
[x] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue #OLS-549
Closes #

/lgtm

/approve


add NULLIF to prevent dividing by 0 in fct_test_coverage

This is a:

[x] bug fix PR with no breaking changes
[ ] new functionality

Link to Issue

Closes #202
Description & motivation

Adjusted calculation of {{ model_type }}_test_coverage_pct in fct_test_coverage to prevent dividing by 0 in the case of 0 models of a given type
Integration Test Screenshot

Checklist

[ ] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)

[ ] BigQuery
[ ] Postgres
[ ] Redshift
[x] Snowflake

[ ] I have updated the README.md (if applicable)
[ ] I have added tests & descriptions to my models (and macros if applicable)
[ ] I have added an entry to CHANGELOG.md

Let me know if you have ideas as to how to catch this error in an integration test. dbt build was passing, but only when I went to actually query fct_test_coverage did I find this issue.

I'm going to create a safe_divide cross db macro in dbt_utils - eventually, we can use that for this calculation instead!


Override styles

@thatandromeda This isn't done, but I moved some things around so I think it may make sense to get it into main and keep working off the same stuff. Main changes:

moved interact stuff to it's own template so we can use the full width for the interaction.
put in a bunch of fake copy and placeholders so we can start to get a feel for how things flow and connect
created some override files for the theme so I can customize it but still use all the utility they have built in
added a bunch of styles

Let me know if you want to walk through any of these.

👍 to being able to work off of the same stuff. Also I love the font.
Some questions for the future (I am definitely merging this as-is, just flagging this for discussion/later work):
What is this box for?

Also is there a reason for the text to be so narrow? It makes sense at tablet width but it doesn't expand as I expand my browser window.

I'm finding that on the interact page, the viz part extends past the bottom of the page, but also I am unable to scroll the page down in order to see this. I found this with the previous style, and I know you aren't done with the interacting part yet, so this isn't an issue with this PR -- I just wanted to flag it as a future issue.
Similarly, I assume the "Help" link on the interact page will do something someday, but that hasn't been implemented yet?

Answers…

Top box is possible a little snapshot of the interaction or some other visual interest.
The text is set to a comfortable reading length which is why it doesn’t fill the whole space. I’ll see how things pan out and adjust how the content centers so it doesn’t seem weird.
The viz window is my next focus - it’s been bleeding way out of the window - I think it’s looking at the browser window and drawing a div that size without accounting for other content or padding in the viewport. I’m hoping that’s something that’s easy to tweak…
Yup, the help link will show interaction tips. Depending on how the viz fits in the window, I may move it/make it work differently so it’s just hanging out now (the actual tips are already there but hidden in the content…)

Thanks for the quick review! Now to dive into the interaction...

On Nov 30, 2021, at 1:01 PM, Andromeda Yelton @.***> wrote:
👍 to being able to work off of the same stuff. Also I love the font.
Some questions for the future (I am definitely merging this as-is, just flagging this for discussion/later work):
What is this box for?
https://user-images.githubusercontent.com/959761/144101608-de282536-f424-45b6-9954-0113b0f42a60.png
Also is there a reason for the text to be so narrow? It makes sense at tablet width but it doesn't expand as I expand my browser window.
https://user-images.githubusercontent.com/959761/144102149-b9fc3160-d300-4b2b-bf05-d633a930567b.png
I'm finding that on the interact page, the viz part extends past the bottom of the page, but also I am unable to scroll the page down in order to see this. I found this with the previous style, and I know you aren't done with the interacting part yet, so this isn't an issue with this PR -- I just wanted to flag it as a future issue.
Similarly, I assume the "Help" link on the interact page will do something someday, but that hasn't been implemented yet?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/thatandromeda/lc_site/pull/1#issuecomment-982882892, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBANPRFSTJU27AMVDKAC6LUOUGOFANCNFSM5JCL5AIA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


os=default install doesn't pass root path

..which in turn then doesn't load grub.cfg.

The os=default is caught by the catch all else statement and the root path is specified.
During installation the root path is on the optical media specified by -r cd0:
[Line 667]
			else
				printf '\(hd0\)\ /dev/zvol/'$disk'\n' > /iohyve/$name/device.map
				printf '\(cd0\)\ '$media'\n' >> /iohyve/$name/device.map
				grub-bhyve $wire_memory -m /iohyve/$name/device.map -r cd0 -c /dev/${con}A -M $ram ioh-$name
			fi

After installation the root path is on the harddrive specified by -r hd0,msdos1:
		elif [ $install = "no" ]; then
...
[Line 711]
			else
				printf '\(hd0\)\ /dev/zvol/'$disk'\n' > /iohyve/$name/device.map
				printf '\(cd0\)\ '$media'\n' >> /iohyve/$name/device.map
				grub-bhyve $wire_memory -m /iohyve/$name/device.map -r hd0,msdos1 -c /dev/${con}A -M $ram ioh-$name
			fi

What makes you say it is not being loaded? If you are experiencing the issue with an unlisted OS let me know, I would love to figure it out and add support.

Unfortunate use of words; by root path, I was referring to the directory where grub-bhyve is looking for grub.cfg. On the same lines you just referenced there is no -d to be found whereas all other cases does pass it. I will file a PR shortly.

I know -d has a default assumed value which I think is /boot/grub but I am not 100% sure.

Yes, that's correct.

The default property is a last ditch effort to give a GRUB CLI environment so you can load the kernel and initramfs manually. If you are having issues with a specific OS, please open a feature request so we can get to work adding the specific OS to the giant nested IF/THEN monstrosity.


[SDK] Perf improv

Problem solved
Avoid waterfalls in Promise.all
This is a continued work from #1648
Changes made

[ ] Public API changes: list the public API changes made if any
[x] Internal API changes: explain the internal logic changes

How to test

[x] Automated tests: link to unit test file
[ ] Manual tests: step by step instructions on how to test

To be improved:


JQL query fails when results include a custom status

I've been using this plugin with Joplin for Windows (10 and 11) for a while, and now moved to macOS (12.3.1 and 12.4).
I've added the following snippet to my Joplin note:
status not in (Done, Obsolete) AND assignee in (currentUser()) order by created DESC

I verified this query successfully retrieves results within Jira's UI, and this worked just fine on Joplin for Windows as well.
Now on Joplin for macOS, the same query returns the error:
Error: The status with id 'Requires More Detail' does not exist
If I remove the status filter from my query - it still fails with the same error.
If I remove the order by from my query - it still fails with the same error.
Only if I remove both, and only use the query assignee in (currentUser()) - it successfully returns results.
I should mention that one of the projects I'm associated with has custom statuses we've added ('Requires More Detail' and 'To Be Scheduled'), and if I exclude them from the search, it succeeds:
status not in (Done, Obsolete, "Requires More Detail", "To Be Scheduled") AND assignee in (currentUser()) order by created DESC
I've tested this with both the ```jira-search syntax and the <JiraSearch jql="status not in... syntax, getting the same result.

The error you get is generated by Jira and not the plugin.
Can you call the JIRA API with the query that is generating the error in order to let me know what is the output you get?
https://your.jira.server/rest/api/latest/search?jql=status%20not%20in%20(Done%2C%20Obsolete)%20AND%20assignee%20in%20(currentUser())%20order%20by%20created%20DESC

@marc0l92 thank you for your response,
When plugging in this URL (with my jira server URL) into Postman, and providing the appropriate Auth (Basic Auth, username is my email address, password is my Jira API Key, the same credentials I configured in Joplin's Jira Issue plugin settings), I'm able to get the expected results, no errors).

Thanks for the test.
Can you retry the same call and send me the screenshot of the response in the section where the status is showed?
I need to ask you also another api call:
https://your.jira.server/rest/api/latest/status/Requires%20More%20Detail

I think the issue is in the API that gets the status color. I will change the code in order to use a default gray in case the API to get the actual color fails.

Try to update the plugin to 2.4.0

Thank you @marc0l92! Updating to 2.4.0 appears to have solved the issue.
Do you still need me to provide you with the requested information above for troubleshooting the color issue?

The fix I did is to use the gray color in case I'm not able to get the real status color.
It will be useful for me if you do this test so I can fix the code and show the real status color


Revert "Handle null main branch"

Reverts Azure/azure-sdk-actions#10
I think this is causing problems with events from forks.

@richardpark-msft agreed, I think more documentation in general of what the different fields in the schema correspond to in the API is necessary. I'll take that on as a follow-up, as I also don't clearly understand how the values differ based on event origin.
For head branch, my understanding is it's the branch the commit belongs to, but is null when the commit is in a fork. See https://docs.github.com/en/rest/checks/suites?apiVersion=2022-11-28#list-check-suites-for-a-git-reference


Update README.md

Summary
Few things in the README that is exposed to the PyPI description:

Broken link: The documentation link is pointing to https://docs.quantum.ibm.com/guides/qiskit-ibm-transpiler which is 404ing
Old name: I think "Qiskit IBM Transpiler" was rebranded as "Qiskit Transpiler Service" (not fully sure)
Qiskit dependency phrasing: the expression "requires Qiskit 1.0 by default" sounds odd to me. I think "requires Qiskit 1.0 or greater" was meant.

Hi @1ucian0 , thank you for your PR.
I confirmed with @Eric-Arellano that name for the service is "Qiskit Transpiler Service", while client's name is "Qiskit IBM Transpiler"


[Improvement]: When manually setting table.event-time-field to a field, it should widen its data file mertic length

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
The current default length of the iceberg table for metadata metric is 'write.metadata.metrics.default' = 'truncate(16)'. meaning that data larger than 16 will have a loss of precision.
When we set table.event-time-field we often choose a time field in the format yyyy-MM-dd HH:mm:ss, obviously this string is longer than 16, then there will be a loss of precision when parsing the upperbounds and lowerbounds of the datafile.
From the user's point of view, most of the cases will not be able to change 'write.metadata.metrics.default' to a larger value or to 'full', so it is necessary to help the user to set this configuration.
How should we improve?
AMS should set global default configuration such as 'write.metadata.metrics.default' to 'truncate(32)' when creating a table, or just for the fields set in the table.event-time-field configuration mertric changes
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Subtasks
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

If there is no assignee to this issue, can I try it?


⚠ Bofrost.be has degraded performance

In 603ce83, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1082 ms

Resolved: Bofrost.be performance has improved in 0e4bb65 after 8 minutes.


SPFx web part On Premise (SharePoint 2016) - App for the Web part shows in Site Contents. if user clicks icon. Error 'Sorry, something went wrong'

Category

[x] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
On-Premise: After installing the SPFx app in Site Collection, clicking on the App icon in the Site Contents page should not error but either be disabled or provide property in the SPFx project's package-solution.json to set the desired launchUrl.
Comparing to a SharePoint App development, you are able to control that within the App Project or by registering the app using /_layouts/15/appregnew.aspx.
Observed Behavior
On-Premise: After installing the SPFx app in Site Collection, clicking on the App icon in the Site Contents page throws error: 'Sorry, something went wrong'
Steps to Reproduce

Deploy you production ready SPFx app to App Catalog (assuming your CDN is already properly configured)
Navigate to a Site Collection's Site Contents page, click Add an App, and select your SPFx App
Once App is deployed, click on its icon (the Tile).

Thanks in advance for your response and guidance. I'm very much looking foward to leveraging SPFx on our Large Enterprise SharePoint Farms to meet and exceed our customers needs.

Could you provide some information?

SharePoint 2016 FP2?

What version of SPFx are you using?

Yes - SharePoint @016 FP2
@microsoft/generator-sharepoint": { "isCreatingSolution": true, "environment": "onprem", "version": "1.5.1",.. (Not 100% how to tell SPFx Version)
I just installed the yo template 5 days ago. Selecting the On-prem option.
The solution deploys and works. its just that I am concerned with the above behavior as I can see users installing the app, clicking on the icon, and then complaining / submitting support tickets.

Sure - this can cause confusion for the end user, but it's actually technically by designs... or in the SPO this link for the SPFx solution is removed as a pretty recent fix. It's hygiene issue no doubt, but if that's something which truly needs to get fixed also in SP2016 platform, we would recommend opening a Premier support case, if needed. Right now we can't really process this request from this process.


Add addl(test-only) way to initialize events, setting errorcode

Some tests rely on creating fake events without all of the overhead of an inspector, etc. To support new tests that rely on m_errorcode (generally maps to the res field of events), add a new initializer that passes in a scap + ppm header and errorcode, and just directly sets m_errorcode.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Some tests rely on creating fake events without all of the overhead of an inspector, etc. To support new tests that rely on m_errorcode (generally maps to the res field of events), add a new initializer that passes in a scap + ppm header and errorcode, and just directly sets m_errorcode.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: d9a378fd2132889504ea2c70cc7e461cb2418961

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Molter73, mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Molter73,mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.11.0


A non used output in the solution of the xml tool wrapper

A non used output in the solution of the xml tool wrapper is specified, but the command does not seem to output something.
This could be confusing.

Resolved by PR #7, but I'm pretty sure it's not necessary to have an output for the tool to appear in the Galaxy history? Should the output be deleted instead?


New version: beeradmoore.dlss-swapper version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

For whoever reviews this, I don't think the questions of
Have you validated your manifest locally with winget validate --manifest <path>?

Does your manifest conform to the 1.6 schema?

as this update was created with the wingetcreate tool

Hi @beeradmoore,

For whoever reviews this, I don't think the questions of
Have you validated your manifest locally with winget validate --manifest <path>?

Does your manifest conform to the 1.6 schema?

as this update was created with the wingetcreate tool

Please understand that regardless of how the manifest is created and submitted, these questions are still valid. A manifest creation tool might take care of some of these questions, but the submitter is ultimately responsible for ensuring that the submitted manifest is valid and has been tested. Manifests which don't meet these might not be accepted, or might need significant modifications after initial submission.

Thanks for the info @stephengillie. Next update I'll go through the steps of answering those questions better, and also filing an issue with the microsoft/wingetcreate team and see if manifest version is going to get bumped to help with the other question.


feat(client): support requests without single root property

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


advance enableRawMode() before getColumns()

In some cases, the ioctl in getColumns() will error out and call getCursorPosition(), and the "\x1b[6n]" control character in this function will cause the output to be displayed back to the terminal. Advancing enableRawMode() to before getColumns() prevents this problem.

👍


The outputs of conv1d differs significantly on the CPU and GPU

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
tf 2.12.0
Custom code
Yes
OS platform and distribution
Ubuntu 20.04
Mobile device
No response
Python version
3.10
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
When conv1d used the same parameter settings, we gave the same input and found the largest difference in the output tensor 0.178863525390625.
Standalone code to reproduce the issue
import h5py
import tensorflow as tf
import numpy as np

tf.random.set_seed(42)

def chebyshev_distance(A: np.ndarray, B: np.ndarray):
    if A is None or B is None:
        return 0.0
    if A.shape != B.shape:
        return 9999999
    else:
        return float(np.max(np.abs(A - B)))

h5_file_path = "./output_diff_initial_weights.h5"
npz_path = "./output_diff_input.npz"
conv1d_layer = tf.keras.layers.Conv1D(filters=64, kernel_size=7, padding="valid")
layer_name = 'conv1d_2351'

data = np.load(npz_path)
inp = data['inp']
input_shape = inp.shape[1:]

with h5py.File(h5_file_path, 'r') as h5_file:
    weights = h5_file[f'{layer_name}/{layer_name}/kernel:0'][:]
    biases = h5_file[f'{layer_name}/{layer_name}/bias:0'][:]

conv1d_layer.build(input_shape)
conv1d_layer.set_weights([weights, biases])

with tf.device('/CPU:0'):
    x_cpu = tf.constant(inp, dtype=tf.float32)
    output_cpu = conv1d_layer(x_cpu)

if tf.config.list_physical_devices('GPU'):
    with tf.device('/GPU:0'):
        x_gpu = tf.constant(inp, dtype=tf.float32)
        output_gpu = conv1d_layer(x_gpu)

else:
    print("GPU not available.")

output_diff = chebyshev_distance(output_cpu.numpy(), output_gpu.numpy())
print(output_diff)

https://github.com/PhyllisJi/MoCoDiff_Bug/tree/tf-issue-%2374785
This repository provides the inputs and weights.Just type python conv1d_test.py.
Relevant log output
No response

To address the issue with the observed discrepancy between CPU and GPU outputs in your Conv1D layer
1-Ensure that both CPU and GPU are using the same floating-point precision.
x_cpu = tf.constant(inp, dtype=tf.float32)
x_gpu = tf.constant(inp, dtype=tf.float32)

2-Enable deterministic operations for TensorFlow on GPU.
tf.config.experimental.enable_op_determinism()

3-Double-check your environment consistency (CUDA, cuDNN, TensorFlow versions).
also, You've already mentioned trying TensorFlow Nightly, but if you're still using an older version on your main environment, upgrading to the latest stable version could potentially fix issues related to discrepancies between CPU and GPU computations.
By taking these steps, you should be able to identify and potentially resolve the discrepancy you're observing.
Let me know if any of these solutions work for you!

To address the issue with the observed discrepancy between CPU and GPU outputs in your Conv1D layer 1-Ensure that both CPU and GPU are using the same floating-point precision.
x_cpu = tf.constant(inp, dtype=tf.float32)
x_gpu = tf.constant(inp, dtype=tf.float32)

2-Enable deterministic operations for TensorFlow on GPU.
tf.config.experimental.enable_op_determinism()

3-Double-check your environment consistency (CUDA, cuDNN, TensorFlow versions).
also, You've already mentioned trying TensorFlow Nightly, but if you're still using an older version on your main environment, upgrading to the latest stable version could potentially fix issues related to discrepancies between CPU and GPU computations. By taking these steps, you should be able to identify and potentially resolve the discrepancy you're observing.
Let me know if any of these solutions work for you!

Step 2 solved my problem!


knife-artifactory unshare doesn't seem to work

When I try to use knife-artifactory unshare I get an error, even though I have delete rights (and share works for my user).
Here's what it looks like when I run the command with an artifactory 5.1.0 server:
knife artifactory unshare mycookbook 0.1.0
Are you sure you want to delete version 0.1.0 of the cookbook mycookbook from Artifactory? (Y/N) Y
ERROR: The data in your request was invalid
Response:

I expect not to see this error.

Hi there and thanks for reporting this,
Can you please post the what the Artifactory log shows when you run the command?
Also, when posting errors from the client please use the verbose flag (-V) and post the entire output from the client as well.
Thanks.

-V output:
$ knife artifactory unshare mycookbook 0.1.0 -V
INFO: Using configuration from /Users/myuser/.chef/knife.rb
Are you sure you want to delete version 0.1.0 of the cookbook mycookbook from Artifactory? (Y/N) Y
INFO: HTTP Request Returned 400 Bad Request:
ERROR: The data in your request was invalid
Response:

artifactory log (and yes I've set a default deployment repository on the virtual repo):
2017-04-27 14:24:38,284 [http-nio-8081-exec-4] [ERROR] (o.j.r.c.u.ChefUtils :65) - An error occurred while handling a Cookbook request: Cannot delete cookbook version from virtual repository

ok, so unfortunately undeploy from virtual repos is not supported - that's why its failing for you.
It's like this by design and for a good reason --> undeploy from a virtual when a user does not know what is the default deployment repo (that info is not available to non-admins) may produce unwanted behavior (i.e. user expects it to be removed from entire virtual while it was only removed from the deployment repo).
You are more than welcome to submit a feature request via our support portal - I'm closing this issue as this is an Artifactory issue and not directly related to the plugin.


Fix camera movement and make development cross-platform

Development is pretty much cross-platform after a few script modifications (no issues when building and whatnot) and the input is done each render, rather than each tick, to ensure a smooth movement with the camera. The examples were updated to reflect the code change. Webpack was also updated in the process because I couldn't live to see it outdated.

Hi, thanks for the PR but I'm a little unclear what it's doing. Camera movements and zooming should already be happening smoothly on render (hereabouts). It looks like this PR changes how often rendering.zoomDistance is updated, but that just changes the position the camera is zooming towards, it shouldn't affect how smoothly the zooming takes place.
Are the changes in this PR perceptibly affecting camera movement for you?

I should add, the build-related changes look fine, I just need to pull them down locally and test.

The main issue with the original behavior was that input was being collected each tick. So, on tick intervals lower than the rendering rate the camera seemed to move in a rough fashion. You could probably fix it with interpolation as well, but this PR could help with input latency as well. If you ran the test of both branches side by side, there would be a noticeable change when you rotated the camera. The zoomDistance change was done just to be synchronized with what I changed inside the engine.

Hi,
Perhaps I'm missing something, but for me the camera rotation from mouse inputs already happens on render. E.g. if I run the test world with the tick rate set to 1000ms, the camera rotates normally rather than once per second.
Is that not what you're seeing? You can set the tick rate by adding tickRate: 1000, to the options object here.
For reference, camera rotation (consuming mouse dx/dy input) starts here, in the render function.

Ah... perhaps I initially misunderstood what tickRate really was. I thought it was the number of times the tick function was being called per second, not the amount of time in ms spent each tick call...
Yeah, it's probably just my imagination or my computer making me believe that the camera was choppy. Should the change be reverted?

Thanks for confirming, in that case I'll go ahead and close this PR, as I think consuming input events on tick is the right thing to do. The intent here is that client "gameplay" code should be running on tick rather than render, but if the engine consumed scroll events on render then gameplay code listening to tick would miss events.
You're certainly welcome to send build-related stuff as separate PRs; it would be great if they could be relatively atomic (e.g. one PR to fix paths in the build script, a different one to up the webpack dependency, etc.)
Thanks!


Use App Badging API to show unread and mention count in PWA

Summary
When installing the Mattermost web app as a PWA using the web browser's "install app" feature, display the unread status and mention count on the app icon (in the Mac doc or Windows taskbar).
Uses the navigator.setAppBadge()/navigator.clearAppBadge() API:

https://developer.mozilla.org/en-US/docs/Web/API/Badging_API
https://developer.chrome.com/en/articles/badging-api/

Ticket Link
No ticket, but was also requested via uservoice:
https://mattermost.uservoice.com/forums/306457-general/suggestions/42592834-use-the-setappbadge-api
Related Pull Requests
N/A
Screenshots

Release Note
Added app badge to show unread and mention count in webapp when installed as a PWA

This is an experimental browser feature according to MDN, it is only currently supported in Chromium browsers. I tested in Chrome and Edge on Mac. This API also works on Windows. A test for if (!navigator.setAppBadge) is included in the code to not set the app badge for unsupported browsers.
In theory this is usable in Chrome for Android too, but it can't be used because Mattermost doesn't meet the PWA installability criteria (no Service Worker is registered), so Chrome for Android only offers to create a "shortcut" instead of installing as an app.
~The "should display correct app badge" test is similar to the "should display correct favicon" test. My test does not mock setAppBadge()/clearAppBadge(), if you have a suggestion on how to do so I can add it. (Also, the favicon tests don't actually check that the favicon in the DOM is updated either.)~ The test now mocks global.navigator.setAppBadge.
The desktop Mattermost app has a "Show red badge on Dock icon to indicate unread messages" option. It may make sense to add a similar option to the webapp if this is merged.

Hello @bburky,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

No sure how you want me to handle these ci/lint failures. It looks like the lib.dom.d.ts Typescript definitions are missing these new functions on navigator.
Error: components/favicon_title_handler/favicon_title_handler.tsx(189,24): error TS2339: Property 'setAppBadge' does not exist on type 'Navigator'.
Error: components/favicon_title_handler/favicon_title_handler.tsx(1[9](https://github.com/mattermost/mattermost-webapp/actions/runs/4327876788/jobs/7587718775#step:5:10)6,23): error TS2339: Property 'setAppBadge' does not exist on type 'Navigator'.
Error: components/favicon_title_handler/favicon_title_handler.tsx(198,23): error TS2339: Property 'setAppBadge' does not exist on type 'Navigator'.
Error: components/favicon_title_handler/favicon_title_handler.tsx(200,23): error TS2339: Property 'setAppBadge' does not exist on type 'Navigator'.
Error: components/favicon_title_handler/favicon_title_handler.test.tsx(144,26): error TS2339: Property 'setAppBadge' does not exist on type 'Navigator'.
Error: Process completed with exit code 1.

Thanks @devinbinnie. I added a definition for navigator.setAppBadge() to types/dom.d.ts (dom in filename to match lib.dom.d.ts).

And.... fixed the style bugs too now. I finally found make check-style, didn't see it at first.

I just checked and realized that Electron also supports this API. I think this will affect Mattermost Desktop. You'll two APIs fighting to do the same thing. And the presence of the desktop only setting "Show red badge on Dock icon to indicate unread messages" means they will sometimes try to set the badge differently.
So, sorry, this can't be merged as is.
You could actually move all the Desktop app's badge management into the webapp if you wanted to now, or instead disable my new code in Electron mode somehow.

/update-branch

So I just tested your branch locally and found no interference with the Mattermost Desktop App. I think it's because the App Badging API doesn't become active until the app is installed as a PWA, so it shouldn't have any effect.
Unless there's something else we'd have to do to trigger it?

I just checked and realized that Electron also supports this API. I think this will affect Mattermost Desktop. You'll two APIs fighting to do the same thing. And the presence of the desktop only setting "Show red badge on Dock icon to indicate unread messages" means they will sometimes try to set the badge differently.
So, sorry, this can't be merged as is.
You could actually move all the Desktop app's badge management into the webapp if you wanted to now, or instead disable my new code in Electron mode somehow.

@bburky So I just tested your branch locally and found no interference with the Mattermost Desktop App. I think it's because the App Badging API doesn't become active until the app is installed as a PWA, so it shouldn't have any effect.
Unless there's something else we'd have to do to trigger it?

I think it's a race condition that the Electron code will almost always win.
I set a breakpoint in the new code I wrote to force it to win the race:

Set a breakpoint at the top of updateAppBadge().

This demonstrates that the new code does run too

The Electron code will run in parallel and finish.
Continue from the breakpoint
The webapp code will update the badge.

If the Election code always wins the race in practice, maybe you can ignore it.

I think it's a race condition that the Electron code will almost always win.
I set a breakpoint in the new code I wrote to force it to win the race:

Set a breakpoint at the top of updateAppBadge().

This demonstrates that the new code does run too

The Electron code will run in parallel and finish.

Continue from the breakpoint

The webapp code will update the badge. (Which may be different than what Electron does.)

If the Election code always wins the race in practice, maybe you can ignore it.

I think what I'm getting at is that you can run the setAppBadge() in Electron, but Electron itself won't do anything with it specifically because it only runs when you're using a PWA. Also, our Electron app has its own badge setting code and shouldn't be working with what the web app uses anyways.

Using the Mac Desktop app, I tested from the js console of the web inspector (there are two, I forgot which) and navigator.setAppBadge() does work. Setting the breakpoint and stepping through shows that theoretically can get triggered.
Electron actually added support for this PWA API specifically. The Electron app "is" a PWA for these purposes (not sure that's always true, but this API works).

Hi, @bburky. Is there something that I'd need to enable in my browser to get Mattermost working as a PWA? I was going to test this out, but I can't make Chrome prompt me to use either my local MM instance or our server at https://community.mattermost.com as a PWA

@hmhealey The following steps should work:

Select "Create Shortcut..." in Chrome, or "Install This Site as an App" in Edge.

Chose a name for the created app. In Chrome you must choose "Open as a new window" (this is automatic in Edge).

If the website meets the criteria to be installable as a PWA, there is also a prompt in the location bar to install as an app. I  think the mattermost webapp is only missing a registered service worker: https://web.dev/install-criteria/. This install flow competes with your native apps, so you may not want to fully enable the automatic PWA installation flow, or at least use related_applications / prefer_related_applications too but I don't know all the details.
I'm not suggesting you promote the PWA over your native apps, but for people like me who would prefer to use one anyway over the Electron app, this PR makes the feature set closer.

Thanks for the detailed explanation! I didn't see the icon in the address bar, but I guess that's because we don't have a service worker as you said. Good to know that we at least offer basic support for that then since it sounds like a service worker would be a big task.
Part of me is a bit leery about using this API since it's experimental, but given Chrome's supported it as-is for quite a while and the mobile version of Webkit seems to support it as well, I'm good with using it for the time being

Hey there!, Thank you for your PR.
Webapp is now part of mattermost monorepo now at https://github.com/mattermost/mattermost-server/tree/master/webapp Would you be interested in opening the PR over there?

The web app now lives in the webapp/channels over in https://github.com/mattermost/mattermost-server. We decided to move it to be a monorepo to make both development and our CI pipelines easier, but it's unfortunately disruptive right now. We've updated our setup docs and added some steps for migrating to working with the monorepo.
Copying the changes over there hopefully shouldn't be too hard. There's a few changes to file paths (such as the code living in a dedicated src subdirectory), but most things should look the same as they do now.
Let us know if you could use any help with this. Hopefully the process is smooth.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Hello there! Could you please open the PR in the mattermost-server as part of the monorepo? I will be closing this PR for now. Thank you very much for your understanding and cooperation in this matter.


Loftq

Hi,
We would like to add our method, called LoftQ, to peft repo. Here's the paper link of our method https://arxiv.org/abs/2310.08659.

Thanks so much for this PR, LoftQ looks very interesting. I didn't do a full review yet, but have some more general points to start with:

Do you have any tests or examples that show this in action?
Could you please run make style on the the code?
From my superficial understanding, LoftQ is mainly an initialization scheme for LoRA when using quantized models, which works with different quantization methods. Would it be possible to integrate this completely into our LoRA implementation instead of creating a new adapter? E.g. right now, users can configure init_lora_weights=True/False. It would be super convenient if they could pass init_lora_weights="loftq" and then they get a normal LoRA model but with LoftQ-initialized weights. Maybe I'm missing something and that would not be possible, please let me know. If this is conceptually possible but you need support in implementing it in PEFT, let us know and we can help.

Hi,
Thanks for your advice. We will integrate LoftQ into init_lora_weights.
Best,
Yixiao

On Nov 9, 2023, at 5:06 AM, Benjamin Bossan @.***> wrote:
Thanks so much for this PR, LoftQ looks very interesting. I didn't do a full review yet, but have some more general points to start with:
Do you have any tests or examples that show this in action?
Could you please run make style on the the code?
From my superficial understanding, LoftQ is mainly an initialization scheme for LoRA when using quantized models, which works with different quantization methods. Would it be possible to integrate this completely into our LoRA implementation instead of creating a new adapter? E.g. right now, users can configure init_lora_weights=True/False. It would be super convenient if they could pass init_lora_weights="loftq" and then they get a normal LoRA model but with LoftQ-initialized weights. Maybe I'm missing something and that would not be possible, please let me know. If this is conceptually possible but you need support in implementing it in PEFT, let us know and we can help.
—
Reply to this email directly, view it on GitHub https://github.com/huggingface/peft/pull/1099#issuecomment-1803530902, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQQKA2U2IYXWC5JLVB7PFSTYDSTI7AVCNFSM6AAAAAA7DYHJPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBTGUZTAOJQGI.
You are receiving this because you authored the thread.


Bump virtlet base image

This change is

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


How to pop up Push Notification when app is killed? (iOS)

What version of RN and react-native-fcm are you running? RN 48 FB 9.6.2
What device are you using? (e.g iOS9 emulator, Android 6 device)? iOS11 iPhone SE
Is your app running in foreground, background or not running?

I am trying to pop up Push Notification when I get a message from my server when the app is killed. Below code is what I tried, but it doesn't pop up the Notification even if the event is triggered. Instead, when I open the app, it vibrate continuously. (I saw that you mentioned not to use the FCM.presentLocalNotification inside the event, but I have no idea how to pop up the notification except here when I get a message )
export function registerKilledListener(){
  // these callback will be triggered even when app is killed
  FCM.on(FCMEvent.Notification, async (notif) => {
    console.log('app is killed1');

    FCM.presentLocalNotification({
      vibrate: 500,
      title: 'Hello',
      body: 'Test Notification',
      big_text: 'i am large',
      priority: "high",
      sound: "bell.mp3",
      large_icon: "https://image.freepik.com/free-icon/small-boy-cartoon_318-38077.jpg",
      show_in_foreground: true,
      number: 10
    });

    AsyncStorage.setItem('lastNotification', JSON.stringify(notif));
  });
}

if you manually kill the app, the notification won't wake up the app. system design
you need to add content_available when you push your notification to wake app. check documentation
you can just use FCM's notification object for iOS to show notification


Error when try to save customer without email in admin

I get error if I try to save existing customer without email in admin:
NOT NULL constraint failed: auth_user.email

This is because the user is determined by it's email address, rather than by the username.

Yes, I see it. I wanted to say that we need to show warning message instead of 500 error.


Improve DSL test logging

Tag contexts with username.
Add descriptions for all file ops and log them.

This is the improved version of https://github.com/keybase/kbfs-old/pull/1069

This pulls in https://github.com/keybase/client/pull/4866/files .

I'm gonna decouple this from the client change, since they're not strictly dependent (and the client change is requiring a few more changes).

Flake is https://keybase.atlassian.net/browse/KBFS-1200


fix: picker: ensure keyboard navigation selected styles are implemented in year mode

SUMMARY:
Date Picker supports keyboard navigation, but year mode needs fixing:
Adds selected class names to picker year mode.
https://user-images.githubusercontent.com/99700808/215851730-21b15cd8-a6db-49e7-856d-32f3f789e2ef.mp4
GITHUB ISSUE (Open Source Contributors)
https://github.com/EightfoldAI/octuple/issues/501
JIRA TASK (Eightfold Employees Only):
CHANGE TYPE:

[X] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:
TODO: Add keyboard navigation tests (Jest)
TEST PLAN:
Pull the PR branch and run yarn and yarn storybook. test Date Picker keyboard navigation:
Tab - Places focus on the calendar in the dropdown
Date mode:
Arrow left - Previous day
Arrow right - Next day
Arrow down - Next week
Arrow up - Previous week
Page down - Next month
Page up - previous month
CTRL + Arrow left - Previous year
CTRL + Arrow right - Next year
Week mode:
Arrow left - N/A
Arrow right - N/A
Arrow down - Next week
Arrow up - Previous week
Page down - Next month
Page up - previous month
CTRL + Arrow left - Previous year
CTRL + Arrow right - Next year
Month mode:
Arrow left - Previous month
Arrow right - Next month
Arrow down - Next month row
Arrow up - Previous month row
CTRL + Arrow left - Previous year
CTRL + Arrow right - Next year
Page down - N/A
Page up - N/A
Year mode:
Arrow left - Previous year
Arrow right - Next year
Arrow down - Next year row
Arrow up - Previous year row
CTRL + Arrow left - Previous decade
CTRL + Arrow right - Next decade
Page down - N/A
Page up - N/A
Decade mode:
Arrow left - Previous decade
Arrow right - Next decade
Arrow down - Next decade row
Arrow up - Previous decade row
CTRL + Arrow left - Previous century
CTRL + Arrow right - Next century
Page down - N/A
Page up - N/A

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@96dd188). Click here to learn what that means.
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage        ?   84.77%
=======================================
  Files           ?      789
  Lines           ?    16550
  Branches        ?     5737
=======================================
  Hits            ?    14030
  Misses          ?     2453
  Partials        ?       67

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


unused_ddic - foreign key in another table

Hi, shouldn't this rule check also if other tables are referencing to the currently checked table?

yes, can you help creating a public example? just a few dummy objects should be enough to reproduce this error?

Yes, ofc.
Two Z tables should be enough, right?

yea, try :)

Funny thing: on version 2.74.61 it's ok 😄
Here are samples you asked about:
@EndUserText.label : 'AbapLint test table 1' @AbapCatalog.enhancement.category : #NOT_EXTENSIBLE @AbapCatalog.tableCategory : #TRANSPARENT @AbapCatalog.deliveryClass : #A @AbapCatalog.dataMaintenance : #RESTRICTED define table zlint_test1 {   key client : abap.clnt not null;   key bukrs  : bukrs not null; }
<EMAIL_ADDRESS>: 'AbapLint test table 2'
@AbapCatalog.enhancement.category : #NOT_EXTENSIBLE
@AbapCatalog.tableCategory : #TRANSPARENT
@AbapCatalog.deliveryClass : #A
@AbapCatalog.dataMaintenance : #RESTRICTED
define table zlint_test2 {
key client : abap.clnt not null;
@AbapCatalog.foreignKey.screenCheck : false
key bukrs  : bukrs not null
with foreign key zlint_test1
where client = zlint_test2.client
and bukrs = zlint_test2.bukrs;
}`
`CLASS zlint_test DEFINITION
PUBLIC
FINAL
CREATE PUBLIC .
PUBLIC SECTION.
TYPES ty_bukrs_config TYPE STANDARD TABLE OF zlint_test1 WITH KEY bukrs.
METHODS get_bukrs_config
RETURNING VALUE(bukrs_config) TYPE ty_bukrs_config.
PROTECTED SECTION.
PRIVATE SECTION.
ENDCLASS.
CLASS zlint_test IMPLEMENTATION.
METHOD get_bukrs_config.
SELECT bukrs INTO TABLE bukrs_config
FROM zlint_test1
ORDER BY PRIMARY KEY.
ASSERT sy-subrc <> 0.
ENDMETHOD.
ENDCLASS.`
$ZABAPLINT_TEST_CASES_20220204_094524.zip

how about latest, 2.85.9? does it give the false positive?

Docker downloads 2.84.9 as latest and there is a false positive there.

argh, the docker build keeps stopping every 60 days, anyhow, triggered again, latest should be up in a bit

Yup, on 2.85.9 still false positive

anyhow, need the files that abapGit creates, and as of now, TABL are serialized to XML by abapGit

What do you mean?

Here you can see the effect of the check. There are XMLs that you asked about.
https://github.com/Zeatynis/abaplint-issue/commit/0dc66e613b05c332773dcf5470fc221b54814db0

@Zeatynis try again, 2.91.0

Same. You can check in my test repo:
https://github.com/Zeatynis/abaplint-issue/actions/runs/2363288530

the finding is correct, https://github.com/Zeatynis/abaplint-issue/search?q=zlint_test2
zlint_test2 is not used anywhere in the other objects?

I just rechecked. It's resolved. I must have check it wrong.


patch ImagePickerIOS to return video width and height

Currently ImagePickerIOS does not return a width or height for videos selected in the Photo Library. This change patches our RN repo to grab the width and height data from the PHAsset and return it to JS through ImagePickerIOS.
This code was shamelessly stolen from Expo, who already handles this case:
https://github.com/expo/expo/blob/master/packages/expo-image-picker/ios/EXImagePicker/EXImagePicker.m#L297

react native already started leaning their core by migrating lots deps into react-native-community including image picker.
@adgarcia attempted to migrate to react-native-community/react-native-image-picker during the rn upgrade but cannot fix the mini carousel problem from the new Photo frameworks instead of ALAssetsLibrary iirc? maybe she can add more inputs.
Fairly certain RN wont accept this change to the core repo any more. But we should try to upstream to community once we migrate to react-native-community/react-native-image-picker

Does this deal w/ media picked from the carousel?

react native already started leaning their core by migrating lots deps into react-native-community including image picker.
@adgarcia attempted to migrate to react-native-community/react-native-image-picker during the rn upgrade but cannot fix the mini carousel problem from the new Photo frameworks instead of ALAssetsLibrary iirc? maybe she can add more inputs.
Fairly certain RN wont accept this change to the core repo any more. But we should try to upstream to community once we migrate to react-native-community/react-native-image-picker

fwiw, the latest react-native-community/camera-roll-manager returns the original filename, which (theoretically?) should work with what we have


help me for hacktoberfest.

please accept the pull request.
help me get the hacktober fest swag.

Please mark as invalid and spam, this is an obvious attempt to get a free t-shirt by 'contributing'(hacktoberfest)
This will also ban the user for trying to abuse the system by doing marginal effort


Fix compile error when compiling example with GCC8

GCC8 does not auto-deduce the template parameter for entt::registry, so it has to be provided explicitly.

$ gcc --version
gcc (Ubuntu 8.2.0-7ubuntu1) 8.2.0

I'm on Ubuntu 18.10.
For reference, this is the error I'm getting:
$ make
Scanning dependencies of target entt-test
[ 50%] Building CXX object src/CMakeFiles/entt-test.dir/entt-test/main.cpp.o
/home/ceeac/Projects/code/entt-test/src/entt-test/main.cpp:14:13: error: template placeholder type ‘registry’ must be followed by a simple declarator-id
 void update(entt::registry &registry) {
             ^~~~
In file included from /home/ceeac/Projects/code/entt-test/third_party/entt/src/entt/entity/registry.hpp:24,
                 from /home/ceeac/Projects/code/entt-test/third_party/entt/src/entt/entity/actor.hpp:9,
                 from /home/ceeac/Projects/code/entt-test/third_party/entt/src/entt/entt.hpp:8,
                 from /home/ceeac/Projects/code/entt-test/src/entt-test/main.cpp:1:
/home/ceeac/Projects/code/entt-test/third_party/entt/src/entt/entity/snapshot.hpp:23:7: note: ‘template<class> class entt::registry’ declared here
 class registry;
       ^~~~~~~~

Interesting. Let me see if there is an update and try it again.
That being said, the other problems remain:

uint32_t should be std::uint32_t for consistency and it's superfluous anyway. entt::registry<> works as well and std::uint32_t is the default.
The documentation must be updated as a whole or cannot be updated. This PR is incomplete.

Nevermind, I edited directly your PR.

Merged on master. Thanks for the PR.
I also added you to the contributors list. Do not forget to star the project if you like it. :+1:


Scrolling is not smooth

Title: Scrolling Not Smooth Bug on Website
Description:
There is an issue with the scrolling functionality on the website, which is causing a lack of smoothness during scrolling. This bug needs to be addressed and fixed in the repository.
Expected Behavior:
The scrolling should be smooth and responsive, allowing users to navigate through the content seamlessly.
Actual Behavior:
The scrolling is not smooth and feels jumpy or laggy. There is a noticeable delay or inconsistency in the scrolling motion, which affects the overall user experience.
Additional Information:

The issue is reproducible across different web browsers (chrome and safari too).
The problem persists on various devices (Mac and windows ) but in linux its working smooth.
No JavaScript errors or console warnings are displayed.

It seems to be fine to me. Can you record a short video of how you can produce that behavior? Thanks.

It seems to be fine to me. Can you record a short video of how you can produce that behavior? Thanks.

Sure I am fixing my environment. I think it might be my  system fault cause it's happing with some other projects also.

this can be closed


B 21492 INT - Part 2 - Improved Validation in Admin App for Transportation Office Assignments

B-21492
Summary
Adds addition validation for B-21492 to prevent assigning two transportation offices in the same GBLOC.
Previously, the validation messages didn't refresh properly due to a quirk of a dependency of the version of react-admin (4.12, latest is 5.3) that we use. To avoid misleading error messages I have updated these forms to validate on submit rather than blur, which seems to have no issues with displaying the desired error message.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Access the admin app.
Login as a new or existing admin user.
Open the form to create a new office user.
Attempt to create an office user with duplicate transportation office assignments or two transportation offices in the same GBLOC. You should be unable to.
Save a valid office user.
Repeat step 4 with the edit form.
Try to break it.

If you wish to verify the creation of your transportation office assignments in the DB the following query may be helpful.
SELECT * FROM public.transportation_office_assignments toas JOIN transportation_offices tos ON toas.transportation_office_id = tos.id JOIN office_users ou ON ou.id = toas.id WHERE ou.last_name = 'O''Testoghue'
You could also test these changes on the B-21490 PR which should contain these changes and will allow you to switch between the assigned transportation offices.
Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against 987b39fffc65697a755c596d7b8b58646ab1cdbb

Everything looks good, haven't been able to break it. Only thing I notice is that testing seems pretty sparse in the admin app.

That's true throughout the admin app. I've tried but it's not particularly testable. The react-admin docs generally recommend against testing unless you're doing something particularly custom. Maybe the validation functions could use some testing though.


Deploying an application that contains several packages

First: thanks for your open source work, Halcyon, HoH, Cannot, ..., they're all amazing pieces of work.
We are working on a CMS in Haskell (to be publicly announced in the coming week), that we would like to deploy with HoH (and provide a tutorial for others to deploy theirs with HoH).
The CMS recommends to break up features into separate packages, therefor a git repo of a project that uses this CMS contains a subdirectory for each package.
For instance: https://github.com/lambdacms/lambdacms.org
The "base" subfolder is contains the master site, it builds the actual binary that should be hosted. The other subdirectories contain dependencies of the "base" app.
Is it possible to install an app like this with HoH?  Or do you have suggestions on how we can make it easier for HoH to install an app like this?
Thanks.

Thanks for the kind words.  I’ve now opened a small PR, fixing a few minor packaging issues in your project (https://github.com/lambdacms/lambdacms.org/pull/1).
With these changes in place, I’ve successfully built your project on a regular Ubuntu 14.04 machine, then deployed it to Heroku:
$ curl -s https://lambdacms-dot-org.herokuapp.com | head
<!DOCTYPE html>
<meta charset="UTF-8"><title>Welcome To LambdaCms-org!</title><meta charset="utf-8"><meta http-equiv="X-UA-Compatible" content="IE=edge"><meta name="viewport" content="width=device-width, initial-scale=1"><link rel="stylesheet" href="http://localhost:3000/static/combined/OrNDj4Wt.css"><link rel="stylesheet" href="http://localhost:3000/static/tmp/autogen-qeZQLAVQ.css"></meta>

<button class="navbar-toggle collapsed" type="button" data-toggle="collapse" data-target="#navbar">Toggle Navigation

</button>

Home

In order to get here, I first split the project into three git repositories, one per package:

https://github.com/mietek/lambdacms.org-base
https://github.com/mietek/lambdacms.org-page
https://github.com/mietek/lambdacms.org-tutorial

Next, I added a number of Halcyon magic files to the master package (https://github.com/mietek/lambdacms.org-base/commit/185bdbd7e71c9d96b2db87ba5d93cee320138c3c:
$ git show --name-only HEAD
commit 185bdbd7e71c9d96b2db87ba5d93cee320138c3c
Author: Miëtek Bak<EMAIL_ADDRESS>Date:   Thu Jan 29 16:29:25 2015 +0000

    Package with Halcyon

.halcyon/constraints
.halcyon/extra-data-files
.halcyon/extra-os-packages
.halcyon/sandbox-extra-apps
.halcyon/sandbox-extra-apps-constraints/alex-3.1.4.constraints
.halcyon/sandbox-extra-apps-constraints/happy-1.19.5.constraints
.halcyon/sandbox-extra-configure-flags
.halcyon/sandbox-extra-os-packages
.halcyon/sandbox-sources

Each of these files is described in the Halcyon reference.  Most importantly, the HALCYON_SANDBOX_SOURCES option is used to point to the other two packages:
$ cat .halcyon/sandbox-sources
https://github.com/mietek/lambdacms.org-page
https://github.com/mietek/lambdacms.org-tutorial

Finally, I configured the app in the manner required by Yesod, by manually extracting portions of the DATABASE_URL set by heroku addons:add heroku-postgresql:hobby-dev:
$ heroku config | grep PG
PGDATABASE:                   d8n9…
PGHOST:                       ec2-….compute-1.amazonaws.com
PGPASS:                       IJJb…
PGUSER:                       kjrj…

When deploying on Heroku, Yesod automatically finds the static directory in the current working directory.  When deploying elsewhere, it’ll be necessary to also point STATIC_DIR into the Cabal run-time data files directory before starting the app.
Join #haskell-deployment on the freenode IRC network if you’d like to discuss this.

Thank you for this answer. I guess we will be waiting until it's possible to deploy the application from a single repository. Splitting them up into multiple repositories isn't really an option for our use case.

Thanks for this answer and the fixes. We are going to use this multi-repo setup for now.

Thanks @mietek for the elaborate reply, and the PR. As @matsrietdijk said we'll move to 1-repo-per-cabal-file and include a HoH-deploy tutorial for the initial release.
I'm still interested why you think multi-repos are not ideal. I can come up with some reasons, but I also see reasons in favor of them.

Oops,  just noticed APPROOT was set incorrectly on the live instance (lambdacms.herokuapp.com). Images and styles work now.

The multi-repo split interacts with Halcyon in a complex fashion.  It would be better to explain this in chat, once you have gone through the Halcyon tutorial.

Once again thanks for the resourceful reply. We'll reconsider it, in the light of the release we are planning to do in the coming days.


EVENT_AFTER_DELETE do not works with deleteAll

In project some callback function listen to ActiveRecord::EVENT_AFTER_DELETE event at AR model (behavior or afterDelete method).
I try to delete row by model with
Image::deleteAll("id = $id");
and
if($model = Image::findOne($id)) $model->delete();
I expect that callback function will run in both cases. But it's work only with delete (deleteAll will not trigger any events ).
I see note about it in documentation, but I think it's not obviously and can cause serious problems and bugs in system.

I see very old topick #1404 about it. If it's design "which gives much better performance", may be rename this static method to "sqlDelete" in next major?

Documentation is pretty clear about what the method does and how to write code in case you need events to be triggered. renaming the method does not make it more clear that no events are triggered.


Certain numeric data types cause an error

Certain scalar data types like I8, Enum U16 etc. seem to cause an error when converting from json to object.
The root cause is in json text vi: Scalar JSON text to Variant.vi
In this vi there are cases which group multiple data types and can output a variant in a different type than original:

This causes issues later down the road in your vi: JSON to LVObject.vi, specifically when using Flattened String To Variant. In the given example the specified type expects U16 data, but it gets U32 data and therefore fails to convert it to variant.

I modified the __JSONtext__Variant to Flattened String (special).vi as a possible solution. VI attached. Calling vi integration:

I would really appreciate it if you could make a new release as soon as possible. And thank you very much for the great work with the library!
__JSONtext__Variant to Flattened String (special).zip

Ahh, nevermind... just realized I need newer version of json text...


Support flexible date / times in the whence construction

This adds support for a variety of date / time layouts that are now usable in a custom whence (~(...)). For example, the following now works, among a host of other possible layouts:
> QUERY all since ~(2022/12/05)
2022-12-06T09:48:04-08:00 TRC cmd/fossil/client/client.go:99 > message sent bytes=33
+------------------------------------+-------+----------------------+
|                TIME                | TOPIC |         DATA         |
+------------------------------------+-------+----------------------+
| 2022-12-06T09:47:48.51024114-08:00 | /foo  | new day, new message |
+------------------------------------+-------+----------------------+

> QUERY all since ~(2022/12/04)
2022-12-06T09:48:14-08:00 TRC cmd/fossil/client/client.go:99 > message sent bytes=33
+-------------------------------------+--------------+----------------------+
|                TIME                 |    TOPIC     |         DATA         |
+-------------------------------------+--------------+----------------------+
| 2022-12-04T10:38:14.282027325-08:00 | /foo/bar/baz | blah                 |
| 2022-12-04T10:41:19.106400274-08:00 | /foo/bar     | baz                  |
| 2022-12-04T10:41:39.712533708-08:00 | /foo         | bar                  |
| 2022-12-06T09:47:48.51024114-08:00  | /foo         | new day, new message |
+-------------------------------------+--------------+----------------------+

closes issue #44

But it's such a nice error flow!


[VS Code] Cannot reply: No comment text.

Error:
Cannot reply: No comment text.
Steps to Reproduce:

Get a comment on a line as a host from some guest.
Try to reply and you won't be able to type in.
Guest can keep on commenting.

Version Data

extensionName
VSLS

extensionVersion
1.0.419

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.35.1

platformName
Linux

platformVersion
4.15.0-29-generic

I could not reproduce it on Win10 with the same version of VSCode.
What Linux distro do you use?
Also, if you can get Live Share logs and attach them to this issue, that should help us investigate. You can get the logs with 'Live Share: Export Logs' VSCode command.


Filling the area enclosed by CoordinateLine with color.

Hi,
Is it possible to fill the area enclosed with CoordinateLine with a color to get similar result?

Can we expect that feature soon? I think there is some demand.

yes that would be really useful.

thanks for bringing this back to attention; I'm quite busy at the moment, I hope to find some time for this the nexte weeks.

implemented in current release.
description


Add support for foreign key actions

This PR adds support for foreign key actions

@makenowjust Thank you for review. Now fixed.

@toga4 Thank you!


NCTL: always use casper-client-rs repo for casper-client

Changes:

removes pulling of casper-client from nctl bucket
switches to always use casper-client-rs

bors try

bors r+


VdrError: Pool timeout - Aca-Py 0.8.1

Can anyone please help on cause of the VDR error?
We are using the Agent version : bcgovimages/aries-cloudagent:py36-1.16-1_0.8.1
Error logs:
2023-05-08 06:05:42,639 aries_askar.native.aries_askar.ffi.store INFO 	src/ffi/store.rs:214 | Opened store StoreHandle(1)
2023-05-08 06:05:42,645 aries_askar.native.aries_askar.ffi.store INFO 	src/ffi/store.rs:528 | Started session SessionHandle(1) on store StoreHandle(1) (txn: true)
2023-05-08 06:05:42,655 aries_askar.native.aries_askar.backend.db_utils INFO 	src/backend/db_utils.rs:103 | Acquire pool connection
2023-05-08 06:05:42,655 aries_askar.native.aries_askar.backend.db_utils INFO 	src/backend/db_utils.rs:106 | Start transaction
2023-05-08 06:05:42,660 aries_askar.native.sqlx.query DEBUG 	None:0 | BEGIN; rows affected: 0, rows returned: 0, elapsed: 4.154ms
2023-05-08 06:05:42,686 aries_askar.native.sqlx.query DEBUG 	None:0 | SELECT id, value, (SELECT …; rows affected: 0, rows returned: 1, elapsed: 24.912ms
SELECT
id,
value,
(
SELECT
ARRAY_TO_STRING(
ARRAY_AGG(
it.plaintext || ':' || ENCODE(it.name, 'hex') || ':' || ENCODE(it.value, 'hex')
),
','
)
FROM
items_tags it
WHERE
it.item_id = i.id
) tags
FROM
items i
WHERE
profile_id = $1
AND kind = $2
AND category = $3
AND name = $4
AND (
expiry IS NULL
OR expiry > CURRENT_TIMESTAMP
)
2023-05-08 06:05:42,700 aries_askar.native.sqlx.query DEBUG 	None:0 | SELECT id, value, (SELECT …; rows affected: 0, rows returned: 1, elapsed: 10.972ms
SELECT
id,
value,
(
SELECT
ARRAY_TO_STRING(
ARRAY_AGG(
it.plaintext || ':' || ENCODE(it.name, 'hex') || ':' || ENCODE(it.value, 'hex')
),
','
)
FROM
items_tags it
WHERE
it.item_id = i.id
) tags
FROM
items i
WHERE
profile_id = $1
AND kind = $2
AND category = $3
AND name = $4
AND (
expiry IS NULL
OR expiry > CURRENT_TIMESTAMP
)
2023-05-08 06:05:42,705 aries_askar.native.aries_askar.backend.db_utils INFO 	src/backend/db_utils.rs:146 | Commit transaction on close
2023-05-08 06:05:42,710 aries_askar.native.sqlx.query DEBUG 	None:0 | COMMIT; rows affected: 0, rows returned: 0, elapsed: 4.327ms
2023-05-08 06:05:42,710 aries_askar.native.aries_askar.backend.db_utils INFO 	src/backend/db_utils.rs:168 | Dropped pool connection
2023-05-08 06:05:42,710 aries_askar.native.aries_askar.ffi.store INFO 	src/ffi/store.rs:1010 | Closed session SessionHandle(1)
2023-05-08 06:05:42,712 aries_askar.native.aries_askar.ffi.store INFO 	src/ffi/store.rs:528 | Started session SessionHandle(2) on store StoreHandle(1) (txn: false)
2023-05-08 06:05:42,713 aries_cloudagent.ledger.indy_vdr DEBUG Opening the pool ledger
2023-05-08 06:05:42,717 aries_cloudagent.ledger.indy_vdr DEBUG Wrote pool ledger config 'default'
2023-05-08 06:06:02,749 aries_cloudagent.commands.start ERROR Exception during startup:
Traceback (most recent call last):
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/commands/start.py", line 72, in init
await startup
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/commands/start.py", line 28, in start_app
await conductor.setup()
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/core/conductor.py", line 185, in setup
self.root_profile, self.setup_public_did and self.setup_public_did.did
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/config/ledger.py", line 136, in ledger_config
async with ledger:
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/ledger/indy_vdr.py", line 307, in aenter
await self.pool.context_open()
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/ledger/indy_vdr.py", line 228, in context_open
await self.open()
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/ledger/indy_vdr.py", line 191, in open
self.handle = await open_pool(transactions=txns, socks_proxy=self.socks_proxy)
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/indy_vdr/pool.py", line 177, in open_pool
await pool.refresh()
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/indy_vdr/pool.py", line 58, in refresh
await bindings.pool_refresh(self.handle)
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/asyncio/futures.py", line 327, in iter
yield self  # This tells Task to wait for completion.
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/asyncio/tasks.py", line 250, in _wakeup
future.result()
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/asyncio/futures.py", line 243, in result
raise self._exception
indy_vdr.error.VdrError: Pool timeout: Request was interrupted
Shutting down
2023-05-08 06:06:02,754 aries_cloudagent.core.event_bus DEBUG Notifying subscribers:
2023-05-08 06:06:02,764 aries_askar.native.aries_askar.backend.db_utils INFO 	src/backend/db_utils.rs:168 | Dropped pool connection
2023-05-08 06:06:02,765 aries_askar.native.aries_askar.ffi.store INFO 	src/ffi/store.rs:413 | Closed store StoreHandle(1)
2023-05-08 06:06:02,767 aries_askar.native.aries_askar.ffi.log DEBUG 	src/ffi/log.rs:130 | Removing custom logger
2023-05-08 06:06:02,768 aries_askar.native.aries_askar.ffi.store INFO 	src/ffi/store.rs:1012 | Session not found for closing: SessionHandle(2)

This is already closed but any solutions you would suggest? @jamshale

@alperari,
This might help https://github.com/hyperledger/aries-cloudagent-python/issues/2592#issuecomment-1792487825

After a long hustle finally figure it out.

In my case i was running von-network and two aries-cloudagent-python agents, Alice and Faber, in docker.
Genesis file provided that i provided agents with had <IP_ADDRESS> as node ip address.

Running agent containers in the same von_von network did the magic:
DOCKER_NET=von_von ./run_demo alice
DOCKER_NET=von_von ./run_demo faber

And finally i established communication between agents, created and issued schemas, etc.


Applying example to remix authenticator strategy

I'm trying to use the Remix example
The error I get is:
Error: Strategy oidc not found.

What I noticed is that example configuration is authenticator.use(strategy);, which is not also passing a name (as documented in remix-auth.
I tried adding a name But doing this changed nothing:
let strategy = new OIDCStrategy<User>(
    {
      …
      authorizationParams: {},
    },
    async ({ profile, tokens }) => {
      const { email, name, sub } = profile;
      // …
    }
  );
authenticator.use(strategy, "oidc");

Also note that I has to add authorizationParams to make TS happy.

About the name: forget it, inspecting the code I found that name parameter is optional read from the strategy object.
My problem seems related to configuration of the Issuer then, I've a long list of errors like:
    {
      received: 'HS384',
      code: 'invalid_enum_value',
      options: [Array],
      path: [Array],
      message: "Invalid enum value. Expected 'RS256' | 'RS384' | 'PS256', received 'HS384'"
    },
    {
      received: 'ES512',
      code: 'invalid_enum_value',
      options: [Array],
      path: [Array],
      message: "Invalid enum value. Expected 'RS256' | 'RS384' | 'PS256', received 'ES512'"
    },
    {
      received: 'PS512',
      code: 'invalid_enum_value',
      options: [Array],
      path: [Array],
      message: "Invalid enum value. Expected 'RS256' | 'RS384' | 'PS256', received 'PS512'"
    },
    {
      received: 'RS512',
      code: 'invalid_enum_value',
      options: [Array],
      path: [Array],
      message: "Invalid enum value. Expected 'RS256' | 'RS384' | 'PS256', received 'RS512'"
    }

Probably this is a misconfiguration on my side? I'm trying to use an OIDC service server by Keycloak

I think I will need to add more possible values to the id_token_signing_alg_values_supported or token_endpoint_auth_signing_alg_values_supported or relax the validation to any string 🤔

@sergiodxa yes, my impression was that those interfaces are too strict on possible values, or at least the list of possible values seems not updated enough.

Hi, I have the same issue with Ory Hydra. Some values are not taken into account in the enums.
Here is the ZodError content:
[
  {
    "received": "client_credentials",
    "code": "invalid_enum_value",
    "options": [
      "authorization_code",
      "refresh_token",
      "urn:ietf:params:oauth:grant-type:device_code",
      "urn:ietf:params:oauth:grant-type:jwt-bearer",
      "implicit"
    ],
    "path": [
      "grant_types_supported",
      2
    ],
    "message": "Invalid enum value. Expected 'authorization_code' | 'refresh_token' | 'urn:ietf:params:oauth:grant-type:device_code' | 'urn:ietf:params:oauth:grant-type:jwt-bearer' | 'implicit', received 'client_credentials'"
  },
  {
    "received": "offline",
    "code": "invalid_enum_value",
    "options": [
      "openid",
      "profile",
      "offline_access",
      "name",
      "given_name",
      "family_name",
      "nickname",
      "email",
      "email_verified",
      "picture",
      "created_at",
      "identities",
      "phone",
      "address"
    ],
    "path": [
      "scopes_supported",
      1
    ],
    "message": "Invalid enum value. Expected 'openid' | 'profile' | 'offline_access' | 'name' | 'given_name' | 'family_name' | 'nickname' | 'email' | 'email_verified' | 'picture' | 'created_at' | 'identities' | 'phone' | 'address', received 'offline'"
  },
  {
    "received": "token id_token code",
    "code": "invalid_enum_value",
    "options": [
      "code",
      "token",
      "id_token",
      "code token",
      "code id_token",
      "token id_token",
      "code token id_token",
      "none"
    ],
    "path": [
      "response_types_supported",
      5
    ],
    "message": "Invalid enum value. Expected 'code' | 'token' | 'id_token' | 'code token' | 'code id_token' | 'token id_token' | 'code token id_token' | 'none', received 'token id_token code'"
  },
  {
    "received": "pairwise",
    "code": "invalid_enum_value",
    "options": [
      "public"
    ],
    "path": [
      "subject_types_supported",
      1
    ],
    "message": "Invalid enum value. Expected 'public', received 'pairwise'"
  }
]

I have a similar validation problem with Azure AAD. Are there any plans to make schema validation less strict? Attaching my configuration and the resulting errors.
schema_validation_errors.json
openid-configuration.json


Suggestion: Color paper printer

You could implement a color printer that'll just print like a vanilla CC printer would, but would take ink cartridges and have options to change the text color (maybe with a setColor argument or just as an argument in the write function, depending on what the other printers use)

I don't think this is suitable for the mod. I think the automation challenge of juggling different inks for printing in a vanilla CC printer is more interesting than having an equivalent in sc-peripherals that reimplements all the same code and takes away everything interesting about it.


Gotchas

Creation of a "gotchas" page (currently located in the Learn/Quickstart section) to illustrate the most common Fortran traps to newcomers, as discussed here : https://fortran-lang.discourse.group/t/tsoding-on-fortran/6102/63?u=pieru

#build_preview

@PierUgit , Do you think this PR is good to merge as it seems to be a useful addition to the webpage.

Looks OK to me!

Sorry guys completely missed that. Good job on this @PierUgit and thanks for PR!


Option to disable energy safe

You implemented this: https://github.com/tooll3/t3/commit/181ab4669bd62846a76fc0aca72e9efb5e6ef3a1
It would be usefull to keep the application running if i minimize.

Interesting. Do you imagine an option for that?
May I ask, what's your usecase?

@pixtur Basically, I build my nodes. Then I use Spout as output for OBS.
When everything is set up, control is only via OSC. I don't have to work on Tooll3 itself any more. It can run quietly in the background. Unfortunately, you can't make it small, but have to keep it large throughout in order to use it.

Oh. That's actually a very valid use case. I didn't think of that!
I can add a user-setting.

Fixed in 34ce6173c7d225115e066fe79677cb83b1f329da

@pixtur Thanks <3


WIP: Add json (serde) support

I started this work because I'm also working on adding Connect RPC support to tonic. So having proper protobuf json support is the first step into achieving that goal.
This (unfortunately very big) PR adds json/serde support to prost. This is still a WIP effort but it is almost feature complete and passes all conformance tests except tests related to fieldmasks.
A non-exhaustive list of TODOs:

Decide whether the whole "custom serde" design is the one we want to persue
Properly document code and public api
Properly put this all behind a feature flag
Probably split things up because this PR also includes a new Any implementation
...

So I am just putting this up here to get a general vibe check...

However this PR is way too big to review.
Can you split this work into smaller PRs?

Yeah, it's actually on the TODO list. I just still haven't gotten to actually complete this as a whole yet.

Any news on this? This would be incredibly useful.

I've done a quick rebase and made few adjustments to pass the conformance tests again. It also seems like I need to do some tweaks to fix the CI for no-std.

Any news on this? This would be incredibly useful.

I am still way too busy with other things. What this PR needs is a split and a bit of slight documentation work. I will probably get to that at the end of December perhaps. Thanks for your patience!

@caspermeijn has asked for this to be split into smaller PRs:
https://github.com/tokio-rs/prost/pull/1081#pullrequestreview-2115852148
Reviewing this, I would also expect to see example messages which get extended and validating that before and after changes to the proto file, it works.
e.g.
message TestMessage {
    string name = 1;
}

Then a json payload that satisfies that is then stuck into:
message TestMessage {
    string name = 1;
    int32 age = 2;
}

Or is there an existing test framework and this is using it as another pass with serde enabled and I just don't see how it fits together.
I'm not a committer so take my suggestion with a grain of salt. You've already done an impressive bit of work here!

@caspermeijn has asked for this to be split into smaller PRs:

Yeah, I've mentioned this in my earlier update comment as well. It's definitely on my to-do list! :)

Or is there an existing test framework and this is using it as another pass with serde enabled and I just don't see how it fits together.

I haven't written any specific tests for this yet. That said, I'm not overly concerned because the conformance test suite already exercises this functionality by feeding data (with unknown/missing fields) for decoding/deserialization during our roundtrip conversions. However, having some dedicated tests in our own codebase wouldn't hurt either.
For now, I'll likely prioritize other tasks in the near future. However, I'd love to collaborate on this, if you have any ideas for tests, feel free to share :D

The most recent commits should address almost all conformance failures. There is just one remaining, but that is a rather uninteresting one (Recommended.Proto2.JsonInput.FieldNameExtension.Validator). I've also added some more cleanups and lint fixes.
I think I am approaching a state where I can actually focus on the other TODOs mentioned in my other comments above.


var = %env var does not roundtrip

var = %env var is used to assign an environment variable's value to a Python variable.
When running e.g. nbqa black (or isort, pyupgrade etc) on a cell containing such a construct, it gets transformed to the equivalent but harder to read var = get_ipython().run_line_magic("env", "var").
It would be great if this remained unedited.

Hey @danielsparing - thanks for reporting this, that's not intentional, it's definitely a bug. I'll have a think about how to fix it

PR on its way - this probably affects upstream black as well

@danielsparing this should be fixed in nbQA version 1.2.2, would really appreciate it if you could check and report back if that's not the case
Thanks again for your report!

@all-contributors please add @danielsparing for bugs

@danielsparing this should be fixed in nbQA version 1.2.2, would really appreciate it if you could check and report back if that's not the case
Thanks again for your report!

Yes, this fixes it! Thanks for much for the quick solution.


Ignore plugin hotfix - continuation of 4418

What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, link to documentation update:
N/A
Summary
based on #4418 adds tests, little refactor.
Does this PR introduce a breaking change?
No
Other information
Github doesnt allow me to add to this PR, nor to open a PR against the existing PR. :(

Thanks


QueryExecutionListener is not in pyspark

QueryExecutionListener cannot be found in pyspark - where is it?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 80152a97-1b69-b3fe-ed44-4ec20a7142b1
Version Independent ID: 80152a97-1b69-b3fe-ed44-4ec20a7142b1
Content: Monitoring Structured Streaming queries on Azure Databricks - Azure Databricks
Content Source: databricks/structured-streaming/stream-monitoring.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@chanansh
Thanks for your feedback! We will investigate and update as appropriate.

@chanansh
I've delegated this to content author @mssaperla, who will review it and offer his insightful opinions.

Thanks for your dedication to our documentation. We've created an internal work item (DOC-7915) to address your feedback. The timeline for resolution varies based on resourcing. We are closing this issue for now, but feel free to comment here as necessary.
#please-close

#please-close


new slot: lat_uncertainty, lon_uncertainty , lat_lon sometimes has uncertainty measurements with is

Some projects capture a level of uncertainty for lat_lon.
Should NMDC have a slot to capture this?
Pros:

More metadata
more consistent & accurate
Aligns with projects that capture this

Cons:

more slots
not commonly used/ provided
how would we use this? user research not completed on how useful it would be

@mslarae13 can this be closed with the release of Berkeley schema?


Deployment running into InternalServerError without further explanation in error messages

This issue is a: (mark with an x)

[x] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
While trying to deploy a very basic Container Apps Environment with two container apps, the deployment of a postgresql container fails with "InternalServerError"
Steps to reproduct

User the bicep files to deploy Container Apps
Look into the Deployment details via Portal

Expected behavior
Container Apps should be deployed correctly
Code
Container App Environments module
param name string
param location string
param lawClientId string
param lawClientSecret string

resource containerAppEnv 'Microsoft.App/managedEnvironments@2022-01-01-preview' = {
  name: name
  location: location
  properties: {
    appLogsConfiguration: {
      destination: 'log-analytics'
      logAnalyticsConfiguration: {
        customerId: lawClientId
        sharedKey: lawClientSecret
      }
    }
  }
}
output id string = containerAppEnv.id

Log Analytics Workspace Module
param location string
param name string

resource logAnalyticsWorkspace 'Microsoft.OperationalInsights/workspaces@2020-03-01-preview' = {
  name: name
  location: location
  properties: any({
    retentionInDays: 30
    features: {
      searchVersion: 1
    }
    sku: {
      name: 'PerGB2018'
    }
  })
}
output clientId string = logAnalyticsWorkspace.properties.customerId
output clientSecret string = logAnalyticsWorkspace.listKeys().primarySharedKey

The main.bicep
param location string = resourceGroup().location
param envName string = 'dev'

param registry string = 'drcentralservice.azurecr.io'
param registryUsername string = 'drcentralservice'

resource kv 'Microsoft.KeyVault/vaults@2019-09-01' existing = {
  name: 'deployment-kv-fja'
  scope: resourceGroup('1c5355b9-a455-4262-b252-b4832040f150', 'RG-Fabian' )
}

module law './modules/log-analytics-workspace.bicep' = {
    name: '${envName}log-analytics-workspace'
    params: {
      location: location
      name: 'law-${envName}'
    }
}

module containerAppEnvironment './modules/container-app-environment.bicep' = {
  name: '${envName}container-app-environment'
  params: {
    name: envName
    location: location
    lawClientId:law.outputs.clientId
    lawClientSecret: law.outputs.clientSecret
  }
}

resource containerAppNginxTest 'Microsoft.App/containerApps@2022-01-01-preview' = {
  name: 'nginx'
  location: location
  properties: {
    configuration: {
      ingress: {
        allowInsecure: false
        external: true
        targetPort: 80
        transport: 'http'
      }
    }
    managedEnvironmentId: containerAppEnvironment.outputs.id
    template: {
      containers: [
        {
          name: 'nginx'
          image: 'nginx:latest'
          resources: {
            cpu:  1
            memory: '2Gi'
          }
        }
      ]
      scale: {
        maxReplicas: 1
      }
    }
  }
}

resource containerAppPsql 'Microsoft.App/containerApps@2022-01-01-preview' = {
  name: 'db'
  location: location
  properties: {
    managedEnvironmentId: containerAppEnvironment.outputs.id
    template: {
      containers: [
        {
          name: 'db'
          image: 'postgres:14.1-bullseye'
          resources: {
            cpu: 1
            memory: '2.0Gi'
          }
          env: [
            {
              name: 'TZ'
              value: 'UTC'
            }
            {
              name: 'POSTGRES_DB'
              value: 'postgres'
            }
            {
              name: 'POSTGRES_USER'
              value: 'postgres'
            }
            {
              name: 'POSTGRES_PASSWORD'
              value: 'postgres'
            }
          ]
        }
      ]
      scale: {
        maxReplicas: 1
      }
    }
  }
}

Additional context
The issue occurs when doing a group deployment via Azure CLI

We've identified the cause of this issue and have deployed a hotfix for this. Could you please retry creating those apps.

We are now seeing a similar issues deploying the initial managedEnvironment
Deploying to an internal vnet
The deployment initiates
The Managed RG appears but a couple minutes into the deployment fails with the following
Managed Environment failed to initialized

I have the same problem with the same templates, someone done it?


Prepare for FastBoot 1.0

Fixes #99
PS: I haven't tested this, so please make sure to test this with an app before merging
cc: @soulim

Just chiming in on this issue - Fastboot support for this addon would be greatly appreciated. If the above pull request is valid, could we see it merged into a new release? Right now, the dependency on jQuery is preventing my app from launching in Fastboot altogether.
Thanks in advance -- and if I can help in any way please let me know.

@stickbyatlas would you mind testing this PR and see if it works? Also if you have cycles, would love to see the failing tests fixed. I won't have cycles to make the PR green.

I prefer this addon to ember-pikaday but I need FastBoot support. If there is anything I can do to help progress this please get in touch.


problem with connecting to IRC znc bouncer

Hi,
I have installed znc serwer on my raspberry pi. I want to connect my discord-irc bot to irc via my znc. I tring a lot of configs without any success. When i set bot to connect irc network directly bot work great, but i want connect it via znc. Here is my config file:

[
{
"nickname": "Bot",
"server": "<IP_ADDRESS>:9000",
"discordToken": "token",
"channelMapping": {
"#discord": "#irc"
},
"ircOptions": {
"userName": "login/network",
"password": "pass"
}
}
]

I can connect (via xchat) to znc on 2 ways.

connect only to server (without any password), and type line as describe:

Looking up <IP_ADDRESS>
Connecting to <IP_ADDRESS> (<IP_ADDRESS>) port 9000...
Connected. Now logging in...
Password required
*** You need to send your password. Try /quote PASS <username>:<password>

Configure xchat and type as server password: <username>:<password>

Can anyone help me with it?

ok, i reconfigure znc to listening on default irc port 6667, and remove :9000 from server. And works.
So the question is how to use discord-irc on not default server port.

Hello @eerozeteen
You can pass the port via "port" in "ircOptions"
[
{
"nickname": "Bot",
"server": "<IP_ADDRESS>",
"discordToken": "token",
"channelMapping": {
"#discord": "#irc"
},
"ircOptions": {
"userName": "login/network",
"password": "pass",
"port:": 9000"
}
}
]

We use node-irc as the IRC client. See also https://node-irc.readthedocs.io/en/latest/API.html#client

ok, thanks for replay, its works.


Google fonts are inaccessible

Since the official google fonts repo is gone for some reason, many font formulas using the url https://github.com/google/fonts/trunk/.. are unusable.

It will be back.


Update to .netstandard 2.0

Fix error using netcore 2.0

Duplicate of #464.
See #464 for an explanation of why Swashbuckle intentionally has not upgraded to netstandard 2.0. This PR will likely not be accepted.

Sorry, I didn't see #464.
I upgrade to netstandard 2.0 for the same reason of @JanEggers in #464.
I understand your explanation but if someone want to use Swashbuckle in a netcore 2.0 project, need an upgrade like this.

No, see #468. You can use it in netcore 2 projects without the upgrade. Just add the reference to the static files assembly. This is going to be a common sort of thing in netstandard / netcore - new to .NET people but something folks who use things like Node (lots of transitive dependencies) are used to.

I think this version should not replace support for .netstandard 1.6, but instead of add libraries required for .NET Standard 2.0 and use #ifdef to provide support for both versions. That way minimal version still would be the same, but at the same time support would be preserved.

I'm not sure there's a lot of value in that. The problem is that this sort of thing pops up when almost any transient dependency gets an update or any new netstandard version gets released. If the "fix" for the problem is to add a direct reference to Microsoft.AspNetCore.StaticFiles, that seems easy enough. That's also the official Microsoft solution for any sort of security upgrades they issue - add direct references to the upgraded packages right to your project.
Targeting netstandard 1.6 means it does work with netstandard 2.0. The larger issue is the MVC dependencies, specifically the StaticFiles dependency, right? It's not different code that needs to execute in Swashbuckle.
Again, this is stuff folks who use systems with large numbers of small and transient dependencies are kind of used to. It's a new and unfamiliar pain to .NET folks, but it's the trade-off for having netstandard/netcore.
Anyway, it's up to @domaindrivendev if he wants to maintain that. I'm just saying, this is a solved problem and it doesn't make sense to add support burden at this level.

@tillig Sorry, I probably don't understand from discussion in both issues that all that should be done is just explicitly require Microsoft.AspNetCore.StaticFiles which is more then fine for me.

FYI: for asp-core 2.1 the fix of "just link static-files" does not seem to work anymore. See #438

Same issue as others, all static files return 500 Internal Server Error from Kestrel... any recommended workaround?

Swashbuckle.AspNetCore Version 3.0.0
Microsoft.AspNetCore.Server.Kestrel Version 2.1.1
Microsoft.AspNetCore.StaticFiles Version 2.1.1
.Net Core 2.1.302
Ubuntu 16.04

Upgrade min bound to netstandard2.0 was already merged in #806. Will be available with the next major release - 4.0.0, coming soon.

Thanks for the follow-up @domaindrivendev .... any ETA?