year is shown as null in ID3v2.4 tagged file

id3-json -r 10.\ the\ masochism\ tango.mp3 | jq . outputs this:
{
  "data": {
    "album": "An Evening Wasted With Tom Lehrer",
    "artist": "Tom Lehrer",
    "comment": null,
    "genre": "Comedy",
    "title": "The Masochism Tango",
    "track": 10,
    "year": null
  }
}

while picard shows this:

It happens with this file: testfile.zip (it's in the public domain)
% ./id3-json -V
id3-json 0.1.2

I'm not very familiar with id3 tags, but the issue appears to be that v2.4 replaced the year tags (TORY and TYER) with time tags (TDOR and TDRL). Maybe they should be used if the year tags are not found?

That's a reasonable request, I agree. I've just pushed some code that should use fallbacks. Here's what I put in the README for it:
When reading tags, the plugin will try to return "year" from the TYER tag, but if there is none, it'll look for the year in the "date released" (TDRL), "original date released" (TDOR) and "date recorded" (TRDC) tags, in that order. When writing, it'll still write in "TYER".

I'd appreciate if you test it out and share your thoughts on the order of fallbacks.

Reading works fine! I think the order makes sense. But i wonder if it is legal to write TYER into an id3v2.4 header? The spec doesn't mention it so i guess not? I think it should write into the tag the original value came from.

Hmm, you're right. The reason it was working when I tested it is because I was writing the tags as v2.3. I've pushed a change that writes the version of the tags that was read, and updating the year no longer works.
What I think I'll do is only return the year if the version is < 2.4 and return the full date otherwise. Same for writing. It might be best to also expose a --tag-version flag and add a Version:  field in the Vim plugin. I'll work on it.

I've pushed some commit that implement this -- there's a "date" for v2.4 tags and a "year" for 2.3 and 2.2. These seem to be the only versions the rust library handles. If you install the latest git versions of the Vim plugin and the tool, you should be able to edit those consistently.
For the date, I've only taken "release date" to avoid mixing things up, now that we've got them separated.
Could you (carefully, on copies of music) try this out and let me know if it seems to work as you'd expect?

It looks like “release date” (TDRL) is not read and written by picard and EasyTag but they use “Recording time” (TDRC) instead¹, so it was a bit tricky to find a suitable file 😊.
id3-json reads and writes the files as expected. However, i get this error when trying to open a file with TDRL set in neovim:
Error detected while processing BufReadCmd Autocommands for "*.mp3"..function id3#ReadMp3[9]..id3#id3_json#Read[19]..<SNR>102_NullToString:
line    2:
E735: Can only compare Dictionary with Dictionary
Error detected while processing BufReadCmd Autocommands for "*.mp3"..function id3#ReadMp3[9]..id3#id3_json#Read:
line   44:
E731: using Dictionary as a String
E116: Invalid arguments for function extend

Files with no TDRL tag and TDRC instead trigger no error but the date isn't displayed, of course. Both the binary and the plugin were updated ~20 minutes before writing this.
¹ I gathered that by running strings <file> | less and searching for the tag names, not sure how accurate that is.

It looks like “release date” (TDRL) is not read and written by picard and EasyTag but they use “Recording time” (TDRC) instead¹, so it was a bit tricky to find a suitable file blush.

Hm, okay, "release date" was just my assumption, I've pushed a change that uses "recording date". Tested it locally with picard and it does seem like the updates are happening.

id3-json reads and writes the files as expected. However, i get this error when trying to open a file with TDRL set in neovim:

That's odd, I just tested it out with neovim and I'm not seeing this. I added some more precise checks, so if and when you see this error, maybe we'll get more context.
I also found a dumb bug with comments, which might have affected things, not sure. Either way, could you update both id3-json and id3.vim and give it another shot?

It works fine with files with “recording date” now but i still get the same error for files with “release date” but without “recording date”.
Error detected while processing BufReadCmd Autocommands for "*.mp3"..function id3#ReadMp3[9]..id
3#id3_json#Read[24]..<SNR>102_NullToString:
line    2:
E735: Can only compare Dictionary with Dictionary
Error detected while processing BufReadCmd Autocommands for "*.mp3"..function id3#ReadMp3[9]..id
3#id3_json#Read:
line   49:
E731: using Dictionary as a String
E116: Invalid arguments for function extend

Ah, the error is because of the comment! Both files i tested had http://www.jamendo.com Attribution-Noncommercial-No Derivative Works 3.0 set as comment. Setting it to test produced the same error. Removing the comment completely got rid of the error.

Ah, the error is because of the comment!

Hm, I still can't replicate it :/. It seems the json result's comment key is a dictionary, but I don't understand why. Could you run id3-json on the file directly and paste the results? Also, inside neovim, could you try:
echo string(json_decode(system('id3-json '.shellescape('10. the masochism tango.mp3'))))

Ah, the error is because of the comment!

Hm, I still can't replicate it :/. It seems the json result's comment key is a dictionary, but I don't understand why.

In picard i can add several comments to one file. But that should make it an array in my opinion… :thinking:

Could you run id3-json on the file directly and paste the results?

{
  "data": {
    "album": "The Butcher's Ballroom",
    "artist": "Diablo Swing Orchestra",
    "comment": "test\u0000",
    "date": null,
    "genre": null,
    "title": "Balrog Boogie",
    "track": 1
  },
  "version": "ID3v2.4"
}

Also, inside neovim, could you try:
echo string(json_decode(system('id3-json '.shellescape('10. the masochism tango.mp3'))))

(or whatever the name of the file you're testing with)

{'data': {'genre': v:null, 'track': 1, 'comment': {'_TYPE': [], '_VAL': ['test
']}, 'album': 'The Butcher''s Ballroom', 'date': v:null, 'title': 'Balrog Boogie', 'artist': 'Diablo Swing Orchestra'}, 'version': 'ID3v2.4'}

(the newline is not because of my window size, it's in the output)

I see now. This is a neovim thing. The help files for json_decode in neovim say this:
3. String contains NUL byte.  Two special dictionaries: for
   dictionary and for string will be emitted in case string
   with NUL byte was a dictionary key.

Vim just ignores the final nul byte (that's the \u{0000}).
I've pushed a new id3-json that cleans up trailing nul bytes for all the output strings. Try with that?

Yep, it works now. :tada:

Awesome :). I've pushed a new release, 0.2.0, with compiled binaries and everything. With that, I'll close this issue, but please open a new one if you run into more problems.


Long titles mess up layout

In firefox, long titles aren't handled properly:
wide screen seems kind of ok, but still weird because the title is not abbreviated, it just overflows into an invisible ara:

less space: not so good

not sure which instance this is but it seems like there are attributes within master _connection-header.css and _post-header.css that are not present (at least it seems that way within the minified code)


Getting issue while generating docs

Error: JSDoc closed with error code: 1
at ChildProcess. (node_modules\gulp-jsdoc3\dist\gulp-jsdoc.js:145:32)
at emitTwo (events.js:87:13)
at ChildProcess.emit (events.js:172:7)
at maybeClose (internal/child_process.js:821:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)

Can you provide a bit more context? Would you mine sharing what your gulpfile and jsdoc config look like?

@AndrewGuenther
I am using the simplest gulp task given in npm package help.
Below is the gulp file.
return gulp.src([${sourceDir}/js/modules/**/*.js], {read: false})
.pipe(plugins.jsdoc3(cb));
Not using jsDoc config.

Do you get this error consistently? Is there any other error output?
This means that JSDoc itself is failing somewhere, so I'm surprised that there isn't any other output.

@AndrewGuenther
Yes I am getting this consistently there is some output error but that some to be related to Commenting of the method.
Below is the one.
[01:59:40] ERROR: Unable to parse a tag's type expression for source file ...file_path
setScalingValue - Setter for scaling.": Expected "|" but "-" found.M.{

Ah, that means there is a syntax error in your JSDoc syntax.

@AndrewGuenther
Even after removing all syntax errors, exception is thrown.
[02:06:38] Error: task completion callback called too many times
at finish (..\node_modules
orchestrator\lib\runTask.js:15:10)
at cb (..\orch
estrator\lib\runTask.js:29:3)
at tryCatcher (..\node_modu
les\bluebird\js\release\util.js:16:23)
at Promise.successAdapter [as _fulfillmentHandler0] (..\node_modules\bluebird\js\release\nodeify.js:22:30)
at Promise._settlePromise (..\node_modules\bluebird\js\release\promise.js:564:21)
at Promise._settlePromise0 (..\node_modules\bluebird\js\release\promise.js:612:10)
at Promise._settlePromises (..\node_modules\bluebird\js\release\promise.js:691:18)
at Async._drainQueue (..\no
de_modules\bluebird\js\release\async.js:133:16)
at Async._drainQueues (..\n
ode_modules\bluebird\js\release\async.js:143:10)
at Immediate.Async.drainQueues [as _onImmediate] (..\node_modules\bluebird\js\release\async.js:17:14)
at processImmediate [as _immediateCallback] (timers.js:383:17)

What is the callback you're passing in in your gulpfile? You're not using gulp.dest anywhere are you?
@mlucool, you got any ideas on this one?

function generateDocs(cb) {
return gulp.src([${sourceDir}/js/modules/**/*.js], {read: false})
.pipe(plugins.jsdoc3(cb));
}
gulp.task('docs.generate', generateDocs);
this is the complete gulp task file I am using. Out is generated in docs/gen folder.

Nothing screams out. Can you try to reproduce with something you can share? Or maybe share the output of running it with the environment variable: DEBUG='gulp-jsdoc3'

[22:02:53] Starting 'docs.generate'...
gulp-jsdoc3 Config:
{
"tags": {
"allowUnknownTags": true
},
"opts": {
"destination": "./docs/gen"
},
"plugins": [
"plugins/markdown"
],
"templates": {
"cleverLinks": false,
"monospaceLinks": false,
"default": {
"outputSourceFiles": true
},
"path": "ink-docstrap",
"theme": "cerulean",
"navType": "vertical",
"linenums": true,
"dateFormat": "MMMM Do YYYY, h:mm:ss a"
}
} +0ms
gulp-jsdoc3 Documenting files: list of project js files... +62ms
[22:02:53] Finished 'docs.generate' after 176 ms
gulp-jsdoc3 ..\node_modules\j
sdoc\jsdoc.js -c ..\AppData\Local\Temp\tmp-4680prNmyCQ321gH.tmp -t
..\node_modules\ink-docstrap\t
emplate +31ms
[22:03:00] Documented 138 files!
[22:03:00] 'docs.generate' errored after 6.67 s
[22:03:00] Error: task completion callback called too many times
at finish (...\node_modules
orchestrator\lib\runTask.js:15:10)
at cb (...\node_modules\orch
estrator\lib\runTask.js:29:3)
at tryCatcher (...\node_modu
les\bluebird\js\release\util.js:16:23)
at Promise.successAdapter [as _fulfillmentHandler0] (...\node_modules\bluebird\js\release\nodeify.js:22:30)
at Promise._settlePromise (...\node_modules\bluebird\js\release\promise.js:564:21)
at Promise._settlePromise0 (...\node_modules\bluebird\js\release\promise.js:612:10)
at Promise._settlePromises (..\node_modules\bluebird\js\release\promise.js:691:18)
at Async._drainQueue (...\no
de_modules\bluebird\js\release\async.js:133:16)
at Async._drainQueues (...\n
ode_modules\bluebird\js\release\async.js:143:10)
at Immediate.Async.drainQueues [as _onImmediate] (...\node_modules\bluebird\js\release\async.js:17:14)
at processImmediate [as _immediateCallback] (timers.js:383:17)
...>
Output with DEBUG.

This means the cb you pass in is getting called more than once. From the snippit you gave, it seems that nothing you are doing would cause this.
Can you edit node_modules/gulp-jsdoc3/dist/gulp-jsdoc.js: as follows:
            debug('Documenting files: ' + jsdocConfigClone.source.include.join(' '));
            _fs2.default.writeFile(tmpobj.name, JSON.stringify(jsdocConfigClone), 'utf8', function (err) {
+            debug(JSON.stringify(jsdocConfigClone))

Then rerun with debug and use the output with the above command that was printed:
 ..\node_modules\jsdoc\jsdoc.js -c ..\AppData\Local\Temp\tmp-4680prNmyCQ321gH.tmp -t ..\node_modules\ink-docstrap\template

Where you would sub a saved version of the new output for  ..\AppData\Local\Temp\tmp-4680prNmyCQ321gH.tmp
Basically, my goal is to check how this runs without the gulp plugin.

@mlucool
my task completed without exceptions if I don't pass the cb in jsdocs3.
Thanks for your support.

Ok - closing as a no op here


Marlin / font related issues

Creating this umbrella item so we can point people at this for updates ...

#11

The only related issue is closed, so I don't think this one is needed anymore. If anyone thinks otherwise, happy to reopen.


Crashes on startup

The mod crashes when i launch the game

Could you please provide a crashlog?

It just says
An unexpcted error has occured
Exit Code 0

Windows/Linux
MacOs
To upload the log, you can simply drag it into Github. Please make sure that the last time you launched the game resulted in a crash.

k


[bug] Panel headings are not a consistent size

Steps:

Go to a project
Go to its wiki
Click the "Edit" toggle
Observer the difference in the panel headings of Edit and View

Expected:
They should be the same (presumably a height that is constant across the OSF).
Actual:
They are different.  Then if I create my own panel I get yet another height.

I believe @caneruguz already started addressing this?

@Gary the issue I'm addressing right now is unrelated to this.
The height of a panel header is determined by what the developer chooses to put in there, and the spacing of these elements are different. The panel header allows for these changes. It is of course aesthetically better to have them all be same height but for that the style  needs to be page specific css and not a global style change.
I think one could override the header min-height or height for this specific purpose, the wiki-page.css is a good place to add that override.

Thanks @caneruguz.
@ticklemepierce , can you update this with screenshots as well?

Fixed in release 0.67


NCBI taxonomy documentation

Suggest the following changes to https://qiita.ucsd.edu/static/doc/html/tutorials/prepare-information-files.html#required-fields-for-ebi-submission:

Place taxon_id and scientific_name together. It's strange that description is between them.
Provide a link to the NCBI taxonomy site: http://www.ncbi.nlm.nih.gov/taxonomy
Description for taxon_id: NCBI taxon ID for the sample. Should indicate metagenome being investigated. Examples: 410658 for soil metagenome, 749906 for gut metagenome, 412755 for marine sediment metagenome, 408172 for marine metagenome (seawater), or 449393 for freshwater metagenome. If unspecified use 408169.
Description for scientific_name: Common name for the provided NCBI taxon ID (must match taxon_id above). Examples: soil metagenome, gut metagenome, marine sediment metagenome, marine metagenome.

Luke
we have had to change unspecified (blank) to :Taxon_id 256318 and
scientific_name: metagenome.  This is required by EBI and ratified by EBI.
For all blanks I am using:
Env_biome: urban biome
env_feature: research facility
env_material (not env_matter): sterile water
env_package: misc environment
Gail
On Thu, Jun 23, 2016 at 5:39 PM, Luke Thompson<EMAIL_ADDRESS>wrote:

Suggest the following changes to
https://qiita.ucsd.edu/static/doc/html/tutorials/prepare-information-files.html#required-fields-for-ebi-submission
:

Place taxon_id and scientific_name together. It's strange that
description is between them.
Provide a link to the NCBI taxonomy site:
http://www.ncbi.nlm.nih.gov/taxonomy
Description for taxon_id: NCBI taxon ID for the sample. Should
indicate metagenome being investigated. Examples: 410658 for soil
metagenome, 749906 for gut metagenome, 412755 for marine sediment
metagenome, 408172 for marine metagenome (seawater), or 449393 for
freshwater metagenome. If unspecified use 408169.
Description for scientific_name: Common name for the provided NCBI
taxon ID (must match taxon_id above). Examples: soil metagenome, gut
metagenome, marine sediment metagenome, marine metagenome.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/biocore/qiita/issues/1869, or mute the thread
https://github.com/notifications/unsubscribe/AB69gNd5rpcuk9NgdMV17U4pKHyCarExks5qOydagaJpZM4I9Xj_
.

--
Gail Ackermann
Knight Lab
UCSD
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Thanks @cuttlefishh and @ackermag, I think this info is important and should be in the documentation.

Thanks Gail. The blank requirements for taxon_id and scientific_name can go in those descriptions. The blank requirements for env fields can go in those descriptions. I can make these changes and issue a PR. Can someone point me to the website code?


528  - Secure endpoints with HMPPS Auth tokens

Setup Spring Security to protect endpoints, must now present a valid HMPPS Auth JWT.
Added way of generating arbitrary JWTs with the private key that HMPPS Auth uses in the containerized version to be used in the tests - setup tests to use containerized HMPPS Auth.
Added convenience script to get a client_credentials JWT from containerized HMPPS Auth.

 Add token authentication to the API


why does the location error drop dramatically at the first few frames?

Hi, thanks for your great work!
I just look at the localization result gif you provide, the location error drops dramatically from more than 4 to a fairly low number at the first few frames, while the heading error stays at a normal level, what happened during this period?
Thank you.

Hey @cbtogu,
Thanks for following our work.
During the initialization period. we uniformly generate the particles on the road and use the top 80% percent of the particles to estimate the pose. Therefore, before convergence, the pose estimations are highly dependent on the weighted average pose of the initialization, which will change for different runs or start points.
After convergence, the pose estimation will keep around 0.3 meters and 3 degrees.
I hope my answer helps!

Thanks for your answer. @Chen-Xieyuanli
So overlap is used for localizing consecutive lidar scans, not for just one scan, because it needs some scans for convergence, am I right?

Yes, it's a typical Bayesian process, where we iteratively estimate the pose posterior using consecutive observation and in the end converge to the correct one.

Thank you for your reply @Chen-Xieyuanli
Another question, I try to verify the overlapnet localization using my own data, which is obtained in a big room. I want to use overlapnet for indoor localization with lidar scans.  We scan the room at a very slow speed (~0.1m/s or less), then we build a pcd point cloud manually, which is used to generate feature volumes for verification( we do NOT retrain the overlapnet) . But the localization result is very poor, not even close. So my question is:

Do I have to train the overlapnet for new weights use my own data ?
Which settings should I pay attetion to?
Thank you.

Hey @cbtogu,

We haven't tested our model with different scanners and environments so far, and I would also guess the pre-trained model will not perform well in totally different environments with different types of LiDAR scanners. However, for the localization problem, since you will anyway have the map beforehand, you could always train a new model for that map and it may work better.

For training a new model you could find a demo here: https://github.com/PRBonn/overlap_localization/blob/master/src/prepare_training/README.md

I hope this helps!

Thank you @Chen-Xieyuanli


Avoid the need for floating point arithmetic

The intent of the code maybe to other, non-integer growth factors (e.g. 1.5 or 2.5) but, as is, the float value is both unnecessary and introduces the need for a static_cast. Note that this could be further simplified, since x * 2 - x will always yield x.

Thanks for submitting this PR!
One minor pedantic point is that this will fail if the previous size is greater than half the extent of a size_t. Of course it would actually have failed in the original code too.
It might be an idea to at least check for this scenario and clamp the result of the increment.

One minor pedantic point is that this will fail if the previous size is greater than half the extent of a size_t. Of course it would actually have failed in the original code too.
It might be an idea to at least check for this scenario and clamp the result of the increment.

Thanks for the comment. I'm happy to add simple overflow detection. I think anything more than overkill, and I suspect that it's highly unlikely for this case to trigger anyways. Let me know if you want to keep it in.


Can't create a node from an output port when clicking too fast

Discord username
No response
What type of issue is this?
Permanent – Occurring repeatably
Is this issue blocking you from using Enso?

[ ] Yes, I can't use Enso because of this issue.

Is this a regression?

[ ] Yes, previous version of Enso did not have this issue.

What issue are you facing?
Creating a node by clicking on the output port and then clicking on the background doesn't work if the two clicks occur too close together in time (below our double-click threshold); the second click just drops the edge.
Expected behaviour
Clicking on the output port and then clicking on the background should create a node no matter how fast you do it.
How we can reproduce it?

Clicking on an output port.
Click on the background within 300ms of (1).

Screenshots or screencasts
No response
Logs
No response
Enso Version
develop (72ec775d8c)
Browser or standalone distribution
Standalone distribution (local project)
Browser Version or standalone distribution
standalone
Operating System
Linux
Operating System Version
No response
Hardware you are using
No response

This would require quite a deep change in our shortcut handling. Perhaps we should not treat two clicks as DoubleClick if the mouse significantly moved between them.

It seems to me that specifically if the second click is over a different target, we should not treat that as a DoubleClick.

No longer reproducible in GUI2. There we track double clicks on a single HTML element.


Would it make sense to restrict the action to what's possible?

If the cartpole is already all the way at the right, we can't really select that action. So would it make sense to disallow that from either the random case (by sampling again) or the network case (by choosing the next highest Q value that the network predicts)?

The episode itself terminates if the cartpole deviates from either side by more than 15 degrees, so the experience is recorded and (hopefully) the agent learns from it.

The action shouldn't be restricted since it's the goal of the agent to learn what action to take for the most reward.


document process to deploy contracts

copied from a Discord message which should be transcribed:
the code for deploying the contracts is here: https://github.com/nomad-xyz/monorepo/tree/main/packages/new-deploy
this script is an example of invoking the deploy script: https://github.com/nomad-xyz/monorepo/blob/5b603ee6f58c27d9d5dda6b2a1fa9435a9fc9b97/packages/new-deploy/package.json#L31
the arguments are

the local path to the config file
the local path to the overrides for submitting transactions (if desired)

in my case, i opted to store the configs in a local file in the same package, here: https://github.com/nomad-xyz/monorepo/tree/main/packages/new-deploy/config/development
the layout of the config file should look like this: https://github.com/nomad-xyz/rust/blob/main/configuration/configs/development.json
steps to make your own deploy are:

configure the chains you wan to deploy in the protocol section
delete the core and bridge components so that they are empty objects {} (TODO: make an example pre-deploy configuration)
plop that file into the local path, like above, and invoke the deploy script - just like in npm run deploy

oops! i meant to submit this to the monorepo: https://github.com/nomad-xyz/monorepo/issues/170


Remove host network

This is the same as #204 (with nice changes) but removing hostNetwork, in case we want it.

@aojea I'm merging here since the current implementation with affinity seems to have a breaking change. We can follow up again on the hostNetwork idea and see if there are feet there when you are back. Have a good weekend!

sure, my bad, sorry, I didn't expect we have to set weight 😄

sure, my bad, sorry, I didn't expect we have to set weight 😄

No no, totally OK, and not your fault! I don't know why the tests for the previous PR missed that! I am so appreciating your contributions and these tiny things are trivial compared to that.


Docs updates

Bunch of cleanup in this PR:

Remove deprecated SingularityContainerInfo constructor
Add a large amount of missing @ApiModelProperty annotations
Add a deploy defaults doc to point out fields that fall back to a system-wide or request-level config setting (/fixes #384)
Don't try and generate swagger docs for any org.apache.mesos classes (/fixes #967)
Don't hide overflow of tables in the gitbook
Fix default api-docs link (/fixes #1288)

Going to merge this one and publish an update to the docs


Don't lock topkg into minor version

Following comment by @avsm in https://github.com/ocaml/opam-repository/pull/8822

Looks good. Let's wait for CI

IIRC CI won't test this :P


Change password request

i need to put in a stronger password.
haxelib name: hackx2

I've just sent you an email. Please check and reply there.


How about pg_contrib?

Love the work you've don here but I miss quite a few things from contrib. Any chance that would be looked at in the near future?

Could you please explain what do you mean by pg_contrib? We're going to add lwrp for managing extensions, but no estimates now.

Well that is sort of what I am asking for. Right now I keep running into stuff like

ERROR:  could not open extension control file "/usr/share/postgresql/9.4/extension/hstore.control": No such file or directory

This is happening because `postgresql-9.4-contrib isn't installed. I can work around it for now but the lwrp should take peoples wish to have contrib installed into consideration when installing the rest of the packages.

We added new resources that allow to install extensions from postgresql-contrib subpackage, which comes installed, as well as from http://pgxn.org


All the store data is lost if there is an OOO error while saving it

Reported by Erik (@erikj:jki.re)
Its client was saving some data but it failed because there was an OOO error.
As the file was not saved, the stored was corrupted but the client should have performed a clear cache to retrieve a valid storage.

The IOS client create


How to mock when one cannot change baseUrl?

I am trying to mock response for chat application that uses chat sdk called layerhq-atlas. The problem is that I don't know what to set for base url. I can't see any retrofit code in their code.
From mockwebserver sample,
  HttpUrl baseUrl = server.url("/v1/chat/"); // I don't know what string to set here.
  Chat chat = new Chat(baseUrl);

I tried server.url("/"), but when I send a message, server.getRequestCount() is still zero.
Is there a way such that when any web request is made, it returns a canned response?

Please post usage questions to StackOverflow.


Change Construction/Destruction Core Icons/Materials

The icons of these materials don't really match what goes into making them, unlike the basic/improved/advanced processors. I suggest changing the icons to yellow and white, or change the materials to lapis and redstone.

No


Adding description when deploying the role assignments

We are using a similar pipeline for planning RBAC permissions.
It would be nice to filter out all the role assignments that EPAC is deploying.
Description is the only option for now?!

Thank you. I will also include a slightly revised version in the next release v10.0.0.


Update to golang 1.19

Update

go.mod
github actions
build Dockerfiles
build root image

I think we dont need these many commits. These can be converted to 2 commits. one for go 1.19 changes and one for golangci.

@iamniting Updated


Parsing Issue when annotations are embedded in a fully qualified name

The Java compiler allows an annotation to be embedded inside an FQN. It is not necessarily advisable, but this code will compile:
            import org.openrewrite.internal.lang.Nullable;

            public class AnnotationFun {
                public void justBecauseYouCanDoesntMeanYouShould(java.util.@Nullable List myList) {
                }
            }

I don't envision us making the required changes to support this.


Add a new option to force 'localhost' as hostname instead of local ip

For configuration reasons, I cannot use the local ip "<IP_ADDRESS>" to run my tests. So I added a new option to use "localhost" instead of "<IP_ADDRESS>" if any.

@frankcortes I like this a lot, but instead of forcing localhost, I think you should allow setting a custom hostname.

This feature is now available in newest version, v3.1.0


SAK-30277 - Update opencast repository URL

It's a shame they didn't do redirection for the old repository URLs.

Yeah, we could reply asking if that would be possible even temporarily (might not be), but still this needs to be changed.
I have a local .m2/settings.xml that overrides 3 repositories right now for improved build speed/reliability. Not sure how to get the best word out for that though.

I wasn't disagreeing with it being changed.
Does it need to be in more than just the kernel, it's just that then other modules in the build will start using this repository as well which will slow down building.

I believe that maven goes down the repositories in the order they're defined. So it would only end up using this one (last in the list) if it can't find the artifact everywhere else, right?
But this new nexus.opencast.net is distributed across 4 servers so it should be up there in speed, maybe not as fast as maven central, but it should always be going to maven central first.
I put it in master because I'm putting 3rd party artifacts there that used to be in Berkley, UCDavis and UCT and those servers are often unavailable and maybe disappear at any time. That's when it would need this repository, and there are a few outside of kernel that fall into there.

LGTM

Would be good to have your settings.xml more public.
I wasn't aware we used repositories from Berkley, UCDavis and UCT.


Close possibly open objects

This is mostly a refactor. Let me know if there are any conflicting opinions.

@weaviate-git-bot I agree to the Contributor License Agreement

This is a very simple change but looks complicated in the default diff view. After you enable Hide whitespace in the diff view settings on GitHub you will be able to view only the lines that were added and removed.

HI @abhishek-compro , thanks for your contribution! There are some type-checking failures, could you please adress them?

HI @abhishek-compro , thanks for your contribution! There are some type-checking failures, could you please adress them?

Done

@dirkkul I have run the tests as per the contributing guide and it only gives some warnings but no errors. I am using version 1.24.1.
https://github.com/weaviate/weaviate-python-client/actions/runs/8684237813/job/23851552307?pr=985#step:6:1286
I don't know how to fix address that is already in use. Is it something specific to my changes?

I don't know how to fix address that is already in use. Is it something specific to my changes?

that is sadly a flaky CI test, should not be connected to your changes
Thanks for your contribution, merged :)


Applied engines property on package.json

Motivation
Provide transparency for the users, which version of node runtime you support
Description
Updated engines property inside package.json with node version greater or equal to 16.16.0 to be enforced.
Checklist

[x] Read the contributing guidelines
[x] Commit messages follow the conventional commits spec
[ ] Performed a self-review of the PR
[ ] Added automated tests
[x] Manually tested the change

Tested to use node version 14 and attempt to run yarn :

To all reviewers:
As a first attempt, I have chosen version v16.16.0 because it is an official version to support M1 mac book pro and also well supported on AWS.
https://docs.aws.amazon.com/lambda/latest/dg/nodejs-image.html
https://docs.aws.amazon.com/codebuild/latest/userguide/runtime-versions.html
But happy to change if anyone else has better version to be supported. (with reasons)


LMB-391: Sorting on rangorde column in legislatuur table

⚠ WIP ⚠
Description
Sort the items in the table depending on the rangorde value (string/number).
How to test
Click the rangorde column and it should sort ASC press again and it should be DESC
Links to other PR's

https://github.com/lblod/frontend-lokaal-mandatenbeheer/pull/195

Closing as this is not the sorting we want. + karel merged the rangorde column with up and down


[Feature Request] Better alignment for file nesting

File nesting now:

...And that is a good example. There are really bad ones in my codebase. The alignment is hard to understand - files in the same level are not vertically aligned.
Copy what was done in Visual Studio. All files are vertically aligned.
There are many examples on that page. Here's one:

This feature is very important, but right now the UX needs polish. Basically some indentation tweaks.

See also #148951 #148925

It looks like OtherFile.ts in your case it at the root of the workspace rather than in SomeFolder, is this correct?
This is what I see when I try to replicate your setup:

I believe this is the correct behavior, it would be unexpected for a FileInRoot.ts to not be aligned with SomeFolder, and it would be unexpected for FileInFolder.ts to not be aligned with index.ts.

Hi thanks for the reply. I took that screenshot from the vscode docs themselves. In my setup, like in the image, files at all levels are not aligned - the "group" is not at the same level as other files. The VS screenshots show proper alignment.

Yes, I made that screenshot and I wrote those docs :) the OtherFile.ts is at the top level of the workspace, and thus is aligned with SomeFolder.

Lol, well played Sir! And well done on the high quality docs, they are appreciated :wink:
Perhaps my example was poor (and lazy, I just grabbed what was in the docs). Here are better ones:
Collapsed

Expanded

The files in the Demo directory - aaa.cs, bbb.js, bbb.min.js, bbb.min.js.map and ccc.txt - should all be aligned, both in collapsed and expanded states.
But the way it works now is the nested "group" is indented.
Compare that to the way it's done in Visual Studio (or other IDEs), which place all same-level files in the same vertical line.
Note that I'm not trying to be pedantic. Without alignment it's hard to tell them apart, and that means the feature isn't useful (I've since disabled it). But the goal is worthy, and we've been waiting for this feature for years - like I said, it's appreciated, but just needs some little tweaks.

Ah, so you're in the case where there are no folder icons. In this case yes the nesting parent are indented past their siblings because the alternative is displaying their arrows with less indentation than the parent arrows, which IMO would be odd. With folder icons enabled all siblings (besides nested children) are on the same level:

alternative is displaying their arrows with less indentation than the parent arrows, which IMO would be odd

It is odd when you think about it... but it works. IIRC in VS I think those arrows are hidden until hover. It makes more sense and is more "usable". Countless devs use VS with this feature.
Folder icons: I just went with the defaults I think, and I liked that it looks similar to VS.
Basically I was hoping it would look like other IDEs. Do you think it would be possible to provide the VS-like behaviour behind a config option? If not then go ahead and close this issue, and thanks for giving it consideration.

Basically any icons set that uses "hidesExplorerArrows": true would show the nesting in wrong alignment.

You can override that in either user or workspace's settings.json
{
    "[icon-set-name].hidesExplorerArrows": false
}

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

For anyone like me who landed here and was confused about the phrase "when folder icons are available" - it turns out VSCode supports different "icon themes" for the Explorer pane! The built-in theme "Minimal" does include icons for folders and "fixes" the nesting problem:

But you lose the wonderful custom icons that the default "Seti" theme provides. But but! You can add additional icon themes via extensions, including the expansive "Material Icon Theme" which includes folder icons and just about any other icon you could ever want:

Again, those on the thread probably knew about all this, but I didn't!

Hi, as @nfarina said, file icon themes Seti and AL (from Microsoft AL Language extension) do not do align properly.
We use this to "hide" report layouts we use and we mainly use AL theme.
Seti (bad)

AL (bad)

Minimal (good)

None (good)

I changed the styling a bit:

I think this is better, but I still don't like it, but I guess this is the best that we are going to get😄
How to do the same?
Open this file C:\Users\babak\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\workbench.desktop.main.css
Change babak to your system name
Add this code to that CSS file:
/* Explorer tree (fileNesting) */
.monaco-tl-twistie.codicon {
    /* Use this to completely get rid of the arrows and the spacing */
	/* width: 0 !important;
    padding-right: 0 !important;
    visibility: hidden !important;
	background-image: none !important; */

	/* Use this to fix the alignment and the spacing */
	width: 0 !important;
    padding-right: 0 !important;
}

/* Use this to move the arrow and fix the spacing */
.monaco-tl-twistie.codicon::before {
    position: absolute !important;
    right: 4px !important;
    font-size: 10px !important;
}

Whenever you update your vscode version, you need to do the same process again...

I turn off file nest now just for this UI
😢

I had the explorer.sortOrder set to foldersNestsFiles so that the UI was more readable, but today while working on a huge project that I didn't create, I ran into a problem with that - since the nested files are taken out of alphabetical order I had trouble finding the file I needed - turns out it was scrolled out of view up top with the rest of the nested files.
Once this nesting indentation problem is fixed then foldersNestsFiles should not be needed at all since it seems to me as if setting were added just as a workaround to this issue.

Installing the Material Icon Theme extension mentioned above fixes the problem.
Sorry for rapid-posting here, but I had previously failed to read all of the comments in-depth, saw others were still having the problem and I assumed that there was no easy fix outside of modifying VS Code's CSS.  Thanks again @nfarina


fix a Fail merge (my bad, sorry guys !)

a files was corrupt on this pull request :
https://github.com/5Mixer/mphx/pull/48
I fix it.

Sorry for that.

I'll try to remember to test this tomorrow :+1:

I wait the official release to link our project  who use mphx  ;) be patient :)


ARROW-13680: [C++] Create an asynchronous nursery to simplify capture logic

This PR adds two new utilities.
The first is an asynchronous smart pointer which makes it easier to ensure that asynchronous tasks are finished before an object is destroyed (and generally makes it safe to capture this)
The second is an asynchronous task group which collects futures and can help to ensure that all futures are completed.  It is similar to AllComplete except it doesn't require collecting all the futures at once.
Combined, these two things can help give structured concurrency / nursery type control over asynchronous operations.  I have used these utilities in #10955 if you would like to see an example of them in action.

Drafting this because I want to take a quick look to see if I can reuse the existing task group or if the semantics aren't quite right.

I've moved this back to ready for review.  AsyncTaskGroup is similar but not the same as the TaskGroups.  SerialTaskGroup and ThreadedTaskGroup take care of scheduling the task (submitting it to the executor) as well as tracking the task.  The AsyncTaskGroup is only responsible for tracking a set of tasks that were scheduled elsewhere.  ThreadedTaskGroup could maybe use AsyncTaskGroup through composition but that could be done elsewhere.
The scheduling in the dataset writer case happens in the file queue which doesn't quite fit the SerialTaskGroup / ThreadedTaskGroup model because each task should run serially (like SerialTaskGroup) but asynchronously (like ThreadedTaskGroup).  I could potentially extract the logic in DatasetWriterFileQueue into a AsyncSerialTaskGroup but for the moment I think what this PR and the dataset writer PR proposes is fine.


Feature request: fPIC option in CMakeLists.txt

Could fPIC be an option in CMakeLists.txt? Looking through CMakeLists.txt, it looks like it's being set when building a shared library or python bindings. It would be great if you could also force it. I'm not best suited to do cmake PRs. So if someone speaks native cmake, that would be great.

This is something you should set in your own cmake files though.  You shouldn't need dlib's cmake files to set it.

Okidok. Though I'm using plain old make files...

Oh. Well the. You should be able to set it when you build dlib using cmake’s normal options. Like you can tell cmake to build with whatever compile settings you want.

okidok


Missing php close tag

From the end of __autoload.php file php close tag is missing. (since 3 years? :) )

This was probably intentional.
http://blog.rogeriopvl.com/archives/php-files-closing-the-php-tag-or-not/


Add absolute url generation

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Tests pass?
✔

👍 Thanks!


[CT-3109] Problem installing old version

I'm having the same issue as in https://github.com/dbt-labs/dbt-core/issues/4185, while trying to install 0.20.2:
$ pip install dbt==0.20.2
Collecting dbt-extractor==0.4.0
  Using cached dbt_extractor-0.4.0.tar.gz (21 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done

  Preparing metadata (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [23 lines of output]
      💥 maturin failed
        Caused by: Cargo metadata failed. Does your crate compile with `cargo build`?
        Caused by: `cargo metadata` exited with an error:     Updating crates.io index
          Updating git repository `git://github.com/fishtown-analytics/tree-sitter-jinja2`
      warning: spurious network error (3 tries remaining): failed to connect to github.com: Operation timed out; class=Os (2)
      warning: spurious network error (2 tries remaining): failed to connect to github.com: Operation timed out; class=Os (2)
      warning: spurious network error (1 tries remaining): failed to connect to github.com: Operation timed out; class=Os (2)
      error: failed to get `tree-sitter-jinja2` as a dependency of package `dbt-extractor v0.4.0 (/private/var/folders/27/4cznr1bj5yd0mq5sbf3qtgv40000gn/T/pip-install-66vdgq2e/dbt-extractor_d1dd8847796247ac8e6ecd0096b7042d)`

      Caused by:
        failed to load source for dependency `tree-sitter-jinja2`

      Caused by:
        Unable to update git://github.com/fishtown-analytics/tree-sitter-jinja2?branch=main#52da7b0b

      Caused by:
        failed to fetch into: /Users/martinb/.cargo/git/db/tree-sitter-jinja2-0efee0b6ece5345f

      Caused by:
        failed to connect to github.com: Operation timed out; class=Os (2)
      Error running maturin: Command '['maturin', 'pep517', 'write-dist-info', '--metadata-directory', '/private/var/folders/27/4cznr1bj5yd0mq5sbf3qtgv40000gn/T/pip-modern-metadata-ff8cl4hx', '--interpreter', '/Users/martinb/.pyenv/versions/3.11.3/bin/python3.11']' returned non-zero exit status 1.
      Checking for Rust toolchain....
      Running `maturin pep517 write-dist-info --metadata-directory /private/var/folders/27/4cznr1bj5yd0mq5sbf3qtgv40000gn/T/pip-modern-metadata-ff8cl4hx --interpreter /Users/martinb/.pyenv/versions/3.11.3/bin/python3.11`
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

I have the latest rust on my system, in case it matters and it's not M1.
Unfortunately, we're stuck on this version for now. I dream of upgrading. #6527
I also tried brew with this version but it just fails without explanation so this is my last chance.
UPDATE: I (kinda) fixed this error by fetching manually.
Apparently, you can force cargo to use git cli like so:
cat ~/.cargo/config
[net]
git-fetch-with-cli = true

So when it runs, there's still an error but it shows you the git command that failed:
git fetch --tags --force --update-head-ok 'git://github.com/fishtown-analytics/tree-sitter-jinja2' '+refs/heads/*:refs/remotes/origin/*' '+HEAD:refs/remotes/origin/HEAD'

So I changed that to:
git fetch --tags --force --update-head-ok 'git@github.com:dbt-labs/tree-sitter-jinja2.git' '+refs/heads/*:refs/remotes/origin/*' '+HEAD:refs/remotes/origin/HEAD'

The next run pip install run didn't have this error.
But now there's a problem with numpy so I'm effectively giving up on this; I'll probably resort to using docker. It's an ancient version of dbt so what did I expect. :)

In case someone runs into a similar issue:
  docker run -it -v ~/.dbt/:/var/.dbt/ -v ./dbt:/var/dbt --entrypoint sh \
    fishtownanalytics/dbt:0.20.2
  cd /var/dbt
  dbt run --profiles-dir /var/.dbt/


Fix dot files

fix: fix dot files

Pull Request Test Coverage Report for Build 13

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 7:
0.0%

Covered Lines:
39

Relevant Lines:
39

💛  - Coveralls


⚠ GitLab Server has degraded performance

In 1fe60d8, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11677 ms

Resolved: GitLab Server performance has improved in 6eda444.


Click heatmap -> Select the radio button for that gene

Fixed in https://github.com/vitessce/vitessce/pull/1479


[PORT] OpenVPN

Please read conditions below carefully, and don't delete this part. Invalid issues will be closed.

No apps related to piracy or intellectual property infringement is allowed.
We can't guarantee if the app will be ported by anyone.
We encourage you to port the app by yourself. This would be a great contribution to webOS homebrew community.

[x] I understand conditions above
[ ] (Optional) I'd like to port this app by myself

Issue content starts below this line

OpenVPN builds perfectly fine for webOS and works well. (tun/tap driver is available on pretty much all devices)
This obviously needs a frontend and some maintenance background service.
OpenVPN build configuration:
. /opt/webos-sdk-x86_64/1.0.g/environment-setup-armv7a-neon-webos-linux-gnueabi
wget https://swupdate.openvpn.org/community/releases/openvpn-2.5.4.tar.gz && tar xvf openvpn-2.5.4.tar.gz && cd openvpn-2.5.4
./configure --host arm-webos-linux-gnueabi --disable-lzo --disable-plugin-auth-pam
make

Boringtun - userspace wireguard implementation that supports tun/tap could also work well in here, if anyone wanted to make it an actual universal frontend.
connmand has some support for VPNs, but I have no idea if it would be possible to leverage their VPN handling code to connect our openvpn outside TVs rootfs.
If anyone is willing to take it up, I would be glad to help out.

I would like to follow up on this, where can I find more documentation ? If I'm reading your explanation correctly, OpenVPN could be started manually on the TV by ssh-ing into it and editing the proper configuration files?

I think so, although there is no UI for configuration, you can SSH into it and run.

How would one SSH into webos sdkVersion 5.5.0? Everytime I try (using port 9922) it says:
Unable to negotiate with <IP_ADDRESS> port 9922: no matching host key type found. Their offer: ssh-rsa. I even tried specifying the RSA private key that lives at ~/.ssh/Nick\'s_TV_webos for me, using ssh<EMAIL_ADDRESS>-p 9922 -i ~/.ssh/Nick\'s_TV_webos, but it still says it can't find a matching key. Port 22 just fails to connect entirely.


chore: Upgrade AGP 8.3 -> 8.4

Gradle was updated from 8.4 to 8.6, and the Android Gradle plugin was updated from 8.3 to 8.4 according to the AS Jellyfish release.
Note: java.lang.OutOfMemoryError still appears on rebuild.
Workaround: change locally org.gradle.jvmargs=-Xmx2048m to a required value.

Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@k1rill @HamzaIsrar12 Kindly review the changes made in this pull request. Thank you.
Feel free to move the review from yourself to someone else.

@volodymyr-chekyrta 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


ci: sort out deepsource-go reported issues

only the change to tls/sni.ReadClientHelloInfo() affects behaviour, preventing handshakes lower than TLS 1.2.

<EMAIL_ADDRESS>tagged


Add example how to use gitbranach with airline

Maybe it would be good for the uninformed users to add an example to the readme how to use gitbranch with airline. Here is how I do it:
let g:airline_section_b = '%{gitbranch#name()}'

This is good if one doesn't want to use a heavy plugin like fugitive just to show the current branch in the airline.

That configuration looks like trivial for vim-airline users. Honestly speaking, I don't want to include configuration for vim-airline in my repository, sorry.

No problem. Just for reference let g:airline#extensions#branch#custom_head = 'gitbranch#name' might be a better approach than my above solution because it doesn't override the b_section completely which would also remove the hunk-indicator.


Enhance filter feature

update to:

[x] accept d/ department prefix
[x] accept s/ salary prefix to filter by salary
[x] other prefixes

Thanks @XihuaZ and @kenvynKwek ! This issue is closed!


Air filter device seems busted

First off, awesome integration and appreciate all the work!
I recently had deleted device from BlueAir iOS app and re-added the same device with a new name when changing its wifi network.
Now the integration seems to have data for the device with old name, some sensors Unavailable, switches don’t actually change anything on device.
I turned on the debug logs, but it seems all fine there. 200 on responses, don’t see any errors.
I have tried deleting integration and removing HACS add-on before re-adding it all.
I must be doing something wrong :)

Home Assistant 2023.4.6
Frontend 20230411.1 - latest
Protect 7770i

I see in README that 7770i has not been tested. Before changing wifi (I moved) it was working great!

Warning; this has only been tested with classic_205 and protect 7470i

I am having the same issue with the Google Home skill, seems to be BlueAir issue


The term version is used in the context of a version and a release

Hi,
When I read the document, I cant' figure out if you're saying that, I can install multiple versions of VS, or that I can install multiple version and multiple releases of that version.
Please update the document to call out installing multiple releases of a version of VS.
Releases is the term Microsoft uses for an update to a VS Version.
Version examples
Visual Studio Enterprise 2019
Visual Studio Professional 2019
Visual Studio Community 2019
Visual Studio Enterprise 2017
Visual Studio Professional 2017
Visual Studio Community 2017
Release examples
Visual Studio 2019 Enterprise 16.5.4
Visual Studio 2019 Enterprise 16.5.5
Visual Studio 2019 Enterprise 16.6.0
Visual Studio 2019 Enterprise 16.6.4
Thank you for updating the document so that it explicitly calls out SxS version as well as SxS releases.
Thank you,
Karl Shifflett

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 788a1b72-8bf6-2f87-e317-a176bfced823
Version Independent ID: 9ba41f95-d832-0668-f976-29f93f72320c
Content: Install Visual Studio versions side-by-side - Visual Studio
Content Source: docs/install/install-visual-studio-versions-side-by-side.md
Product: visual-studio-windows
Technology: vs-installation
GitHub Login: @ornellaalt
Microsoft Alias: ornella

Hi @karlamrock, thanks for your feedback. We recently updated the page to include more information about downloading minor versions side-by-side. It should go live this afternoon.


Cherry-Pick to RustLayout: Update MediaCompose to latest Unbundled release, reintegrate into the main Gradle Project (#193)

The ub-automotive-master-20231102 Unbundled release includes changes
that allow the Unbundled libraries to be built into a local maven
repository. This allows the MediaCompose apps to use those built
libraries separately from the Unbundled Gradle project. MediaCompose has
been updated to use this release.
MediaCompose has also been reintegrated into the main DesignCompose
Gradle project. Because it requires the Unbundled libraries it will only
be included if the unbundledAAOSDir gradle property is set. It will
check to make sure that the unbundled libraries have been built before
proceeding with a build.
New setup instructions:

Update your Unbundled checkout to the latest release, 20231102:

cd $YOUR_UNBUNDLED_REPO_PATH
repo init -u https://android.googlesource.com/platform/manifest -b ub-automotive-master-20231102
repo sync -cq -j8

Build the Unbundled libraries:

cd $YOUR_UNBUNDLED_REPO_PATH/packages/apps/Car/libs/aaos-apps-gradle-project
./gradlew publishAllPublicationsToLocalRepository

Now build MediaCompose from the main Gradle project:

cd $DESIGNCOMPOSE_CHECKOUT_ROOT
./gradlew mediacompose-app:assembleDebug

Is this a cp of main to f/rustlayout or just two commits (also the target branch isn't f/rustlayout so I'm more confused than usual :p!)?

It's a stacked PR on the base branch. Base branch is the AGP update. I'm testing. It' a cp of main to rustlayout.

BTW, I still have no idea if MediaCompose works properly, all I know is that it builds.


[Gekidou MM-46229] Add hideAndLock, showAndUnlock callbacks for Search

Summary
This PR fixes several issues with the navigation header.

Hides and locks the header when the results screen is shown. This prevents a user from pulling down and exposing the title.
Adds padding margin to the results header so the RoundedHeaderContext rounded edges show.
allows locking the header to a lockValue via the hideAndLock callback

sets lockValue to the padding value after hiding the header

allows unlocking the header via the showAndUnlock callback

resets lockValue to null and unlocks the header

When showing results and file filter or team is changed, show the Loading component causing the results page to flicker. Just reload the results with the new data.  This keeps the results header constant and only updates the value for the number of files found and the filter badge.

(Not in figma) could add a loading for the Results component which adds a loader within that window.
the initial loading component would show a loader including the header and results (already how this works)

[x] verify show more working before performing search
[x] verify show more working after a search and returns to initial screen (was causing a hang in the app)

Refactor

remove insets.top from scrollPaddingTop hook value

in components that used scrollPaddingTop, insets.top was being subtracted

add insets.top to the useDefaultHeader hook result

in components that use this hook, they were adding the insets.top value
now they do not depend on insets.top and get the exact value from the hook result

components affected:

channel/header/header.tsx
channel/channel.tsx
gallery/header/index.tsx
global_threads/index.tsx
recent_mentions.tsx
saved_messages.tsx
post_draft/post_draft.tsx

Ticket Link
https://mattermost.atlassian.net/browse/MM-46229
Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.

Device Information
This PR was tested on:
Screenshots

Release Note

I have tested this on ipad and iphone, but android is failing to build on my end.  @matthewbirtch, this should resolve the flicking and get the clear and cancel options to operate as expected, with respect to expanding and collapsing the header.

@jfrerich is this ready for me to review now then?

@jfrerich is this ready for me to review now then?

Yes.  I'd love to get your feedback.

@jfrerich this is working so much better now. A few things I noticed below, but seems a lot better.

The app crashes (on iOS simulator) when I'm in the collapsed state of the search top bar (focused on the search input) and then if I tap the  'Show more' button under 'Search options'. This is repeateable every time I follow this sequence.

https://user-images.githubusercontent.com/2040554/195441669-fd6b3229-d132-480b-baf0-5173e21e59d2.mov

The autocomplete shows when I select one of my recent searches. This is likely something for another PR though - not necessarily caused by this one.

https://user-images.githubusercontent.com/2040554/195441890-22c5e7a3-d0d6-4579-8bb2-2354ec78ff51.mov

The margin on the empty state is too tight to the edges. Again, this could be fixed in a separate PR

can you verify that you are using the latest commit in the PR? I was also facing the crashing issue, but I have it working on my end now.

@jfrerich I just pulled the latest and the app still crashes for me when I follow the steps I outlined

@jfrerich looks like the crash is now fixed, thanks!
Should we fix these other few issues in separate PRs or will you include them in this one?

The autocomplete shows when I select one of my recent searches. This is likely something for another PR though - not necessarily caused by this one.

The margin on the empty state is too tight to the edges. Again, this could be fixed in a separate PR

@matthewbirtch, I'm fine with merging, but need @enahum review first.

@matthewbirtch tickets created for follow updated
Autocomplete opens when recent search selected https://mattermost.atlassian.net/browse/MM-47766
Empty results Margins https://mattermost.atlassian.net/browse/MM-47765

FYI, this is still not correct.  @matthewbirtch, I have a UX question.  In the expanded state, I feel like switching through the search, recent mentions, and saved messages screen should all have the same height. so there is not flickering between the screen.  I will design to that criteria.  @elias, this should help with the constants used to calculate the search expanded and collapsed heights.

FYI, this is still not correct. @matthewbirtch, I have a UX question. In the expanded state, I feel like switching through the search, recent mentions, and saved messages screen should all have the same height. so there is not flickering between the screen. I will design to that criteria. @elias, this should help with the constants used to calculate the search expanded and collapsed heights.

@jfrerich I'm not 100% sure exactly what you mean, but the tabs should remain in whatever state they were left in last so that when you switch between them they retain the previous state and scroll you left it at. We should not reset the header height or reset the scroll when switching between tabs. Is this what you're proposing?
Or are you just suggesting that the search expanded top bar should be the same height as the recent mentions expanded top bar. If so, I agree! They should be consistent height in their expanded states


MINIFICPP-445 Added escape/unescape CSV expression language functions

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE file?
[x] If applicable, have you updated the NOTICE file?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@apiri sorry about that. Fixed.

Code, tests, and build all look good. Thanks for adding these! Will merge.
@phrocker I adjusted those lines that were affected by autoformat with no functional changes


Fix string type check for py2/py3

We need a more robust way to check for strings. I think that putting an isstr function in utils.fileio.py like suggested in this answer would be a reasonable solution.

This is relevant here: https://github.com/DarkEnergySurvey/ugali/blob/master/ugali/analysis/source.py#L100
where I needed to change if isinstance(srcmdl,str): to if isinstance(srcmdl,(basestring,str,unicode)): since the srcmdl was u'./mcmc/juicy_i_mcmc.yaml' (a unicode string)

Closed by #63


Build and adopt new visual redesign components in the Dashboard

Epic to capture the work needed to build and use the new components per the latest WP visual design.
Figma
Related Epic for Workspace efforts: #4830

TL;DR on the flow for this update since it has been going on in the background for a while (updated Jan 11, 2021)
Dashboard Redesign General Order and Prioritization

Finish adding basic components to design system that we know are getting used in the dashboard. Adding components just into storybook.   Should be wrapping this initial phase up this week or next depending on page layouts. The last things I want to get done for this initial group are form components we'll use in settings - basic input, radio, checkbox, toggle as well as wrapping up our search component.
Start tackling Dashboard iteratively (general order)

Anything that only appears when interacted with - dialogs, snack bars, popover menus, scroll to top buttons
Left Nav
Page headers
Settings view
Grid elements
Table elements
Single template view

While tackling this list, anything that comes up that isn't in the design system yet that should be will be added as part of acceptance.

@carlos-kelly @BrittanyIRL can we make sure we have tickets for this work? (Adopting the new visual design components in the Dashboard)

@o-fernandez I created tickets for each section of the design system foundation and light mode components as well as the sections of the dashboard at a high level that will be updated based on these foundational elements. We won't need to create all of these (like the panels for instance have no place in the dashboard) but I wanted to create tickets to track progress of where we're at with the whole design system getting implemented as a whole.

Awesome, there's also an epic for the Workspace, which we can move things to if we decide not to build as part of this effort. We can always double-tag to both epics and see where it gets picked up. :)
#4830

@o-fernandez @bmattb I updated the description of this story to include a brief review of the order I'm tackling things in. Talked it over a bit with Sam and this is what she was after. cluing you in too. Let me know if you need more info.

@o-fernandez @bmattb I updated the description of this story to include a brief review of the order I'm tackling things in. Talked it over a bit with Sam and this is what she was after. cluing you in too. Let me know if you need more info.

@o-fernandez @bmattb I updated the description of this story to include a brief review of the order I'm tackling things in. Talked it over a bit with Sam and this is what she was after. cluing you in too. Let me know if you need more info.

This is great - thanks @BrittanyIRL !

@o-fernandez @bmattb I updated the description of this story to include a brief review of the order I'm tackling things in. Talked it over a bit with Sam and this is what she was after. cluing you in too. Let me know if you need more info.

This is great - thanks @BrittanyIRL !

Closing this epic! Dashboard has been redesigned. Further work will have a separate epic as needed.


TZ environment variable name confusion

I don't know why or how your reply explains my confusion. The fact is using "TZ=" was not enough but instead a line with "TM_TZ=" works yet is not in the documentation written as "TM_TZ=". Am I just missing something that should be "obvious"?

Originally posted by @TSJasonH in https://github.com/teslamate-org/teslamate/issues/3651#issuecomment-1946031327

@TSJasonH please share your docker-compose file (without your secrets). The name of the environment variable is TZwithout any TM_

sure...
version: "3"

services:
  teslamate:
    image: teslamate/teslamate:latest
    restart: always
    environment:
      - ENCRYPTION_KEY=*redacted*
      - DATABASE_USER=teslamate
      - DATABASE_PASS=*redacted*
      - DATABASE_NAME=teslamate
      - DATABASE_HOST=database
      - MQTT_HOST=mosquitto
      - TZ="America/Indiana/Indianapolis"
      - TM_TZ="America/Indiana/Indianapolis"
    ports:
      - 4000:4000
    volumes:
      - ./import:/opt/app/import
    cap_drop:
      - all

  database:
    image: postgres:13
    restart: always
    environment:
      - POSTGRES_USER=teslamate
      - POSTGRES_PASSWORD=*redacted*
      - POSTGRES_DB=teslamate
    volumes:
      - teslamate-db:/var/lib/postgresql/data

  grafana:
    image: teslamate/grafana:latest
    restart: always
    environment:
      - DATABASE_USER=teslamate
      - DATABASE_PASS=*redacted*
      - DATABASE_NAME=teslamate
      - DATABASE_HOST=database
    ports:
      - 3000:3000
    volumes:
      - teslamate-grafana-data:/var/lib/grafana

  mosquitto:
    image: eclipse-mosquitto:2
    restart: always
    command: mosquitto -c /mosquitto-no-auth.conf
    # ports:
    #   - 1883:1883
    volumes:
      - mosquitto-conf:/mosquitto/config
      - mosquitto-data:/mosquitto/data

volumes:
  teslamate-db:
  teslamate-grafana-data:
  mosquitto-conf:
  mosquitto-data:

Random thought: I would like to be able to see the current timezone that is in use when the car is not charging. Maybe something to print the last refresh date/time in the live view or something like that would be a good idea.

Been using TM_TZ in the .env file since 2019. Both TeslaMate and Grafana reported the correct time since.
Here the instruction for the .env file does mention TM_TZ:
https://docs.teslamate.org/docs/guides/traefik
All i did was change the zone and kept the same variable to fix the issue.

Note the referenced instructions set TZ=${TM_TZ} in the docker-compose file.
So doing in this way makes sense. TeslaMate is reading the TZ value, which is set from the TM_TZ value.
But there is nothing in TeslaMate - that I am aware of - that reads the TM_TZ environment variable directly.
The docker-compose file quoted above does not have the  TZ=${TM_TZ} line.

Just to add another data point, my .yml file has the following:
TZ=America/Chicago
Nothing about TM_TZ in the file at all.  I'm not having a problem; time is being displayed correctly in both the Teslamate page and Grafana pages.
I don't know if this information helps or hurts...  I'm running the container locally in a Photon VM on an ESX host.

For what it is worth, a user on TMC changed the variable from TZ to TM_TZ and their internal server error on TeslaMate webpage during charging went away.
https://teslamotorsclub.com/tmc/threads/teslamate-megathread.191537/page-164#post-8088719

That does make sense. If TZ is wrong, then TeslaMate will see it and this will create the error. If TM_TZ is wrong, it doesn't matter, TeslaMate won't look at that and continue working using whatever the system default timezone is.

sure...
version: "3"

services:
  teslamate:
    image: teslamate/teslamate:latest
    restart: always
    environment:
      - ENCRYPTION_KEY=*redacted*
      - DATABASE_USER=teslamate
      - DATABASE_PASS=*redacted*
      - DATABASE_NAME=teslamate
      - DATABASE_HOST=database
      - MQTT_HOST=mosquitto
      - TZ="America/Indiana/Indianapolis"
      - TM_TZ="America/Indiana/Indianapolis"
    ports:
      - 4000:4000
    volumes:
      - ./import:/opt/app/import
    cap_drop:
      - all

  database:
    image: postgres:13
    restart: always
    environment:
      - POSTGRES_USER=teslamate
      - POSTGRES_PASSWORD=*redacted*
      - POSTGRES_DB=teslamate
    volumes:
      - teslamate-db:/var/lib/postgresql/data

  grafana:
    image: teslamate/grafana:latest
    restart: always
    environment:
      - DATABASE_USER=teslamate
      - DATABASE_PASS=*redacted*
      - DATABASE_NAME=teslamate
      - DATABASE_HOST=database
    ports:
      - 3000:3000
    volumes:
      - teslamate-grafana-data:/var/lib/grafana

  mosquitto:
    image: eclipse-mosquitto:2
    restart: always
    command: mosquitto -c /mosquitto-no-auth.conf
    # ports:
    #   - 1883:1883
    volumes:
      - mosquitto-conf:/mosquitto/config
      - mosquitto-data:/mosquitto/data

volumes:
  teslamate-db:
  teslamate-grafana-data:
  mosquitto-conf:
  mosquitto-data:

Even if it is not related to the issue, here, you need to update your postgres database container, please do a backup and follow https://docs.teslamate.org/docs/maintenance/upgrading_postgres

TZ="America/Indiana/Indianapolis"

The issue are the ". Please remove the unneeded TM_TZ and replace with - TZ=America/Indiana/Indianapolis

Looks good. Quotes...who knew :-/
Also thanks for the db upgrade tip. Completed the upgrade to pg 15 smoothly with the provided instructions.

The issue was fixed when I replaced to TZ by TM_TZ. As mentioned by @cwanja Now the web page is coming up while charging (no more 500 server error), but the time is 5.5 hours off. Although my TZ is set to America/Toronto? Grafana info is spot on about drive time and charge time, it is not just not showing up right on the Teslamate homepage.(+5,5 hours), As an example, at an expected local 8h15 finish time, it was showing 13h45. I’m not worried much, just want to report here.

I think it might help if the time displayed the timezone offset, that would help verify that the timezone is correct.

was getting internal server errors, tried TM_TZ and it still didnt fix it.
Rolled back to teslamate/teslamate:1.28.2 and its working fine again with just the TZ env

was getting internal server errors,

If you ask for help, please share your docker-compose (without credentials)

Total agree. Not only valid for TZ

was getting internal server errors,

If you ask for help, please share your docker-compose (without credentials)

This is the docker-compose i used a couple years ago initially, but have been using watchtower to update the stack
version: "3"

services:
  teslamate:
    image: teslamate/teslamate:latest
    restart: always
    environment:
      - PUID=1000
      - PGID=100
      - TZ=America/Los_angeles
      - ENCRYPTION_KEY=ABCDefg
      - DATABASE_USER=teslamate
      - DATABASE_PASS=secret
      - DATABASE_NAME=teslamate
      - DATABASE_HOST=database
      - MQTT_HOST=<IP_ADDRESS>
      - MQTT_PORT=1883
    ports:
      - 4000:4000
    volumes:
      - /volume2/docker/teslamate/import:/opt/app/import
    cap_drop:
      - all

  database:
    image: postgres:14
    restart: always
    environment:
      - PUID=1028
      - PGID=100
      - TZ=America/Los_angeles
      - POSTGRES_USER=teslamate
      - POSTGRES_PASSWORD=secret
      - POSTGRES_DB=teslamate
    volumes:
      - teslamate-db:/volume2/docker/teslamate/postgresql

  grafana:
    image: teslamate/grafana:latest
    restart: always
    environment:
      - PUID=1028
      - PGID=100
      - TZ=America/Los_angeles
      - DATABASE_USER=teslamate
      - DATABASE_PASS=secret
      - DATABASE_NAME=teslamate
      - DATABASE_HOST=database
    ports:
      - 3000:3000
    volumes:
      - teslamate-grafana-data:/volume2/docker/grafana

volumes:
  teslamate-db:
  teslamate-grafana-data:

Just pulled a pulled some "updated" version of <IP_ADDRESS> (Teslamate and Database have been downloaded) and now the time to finish is accordingly to my TZ ! All is good now!

This needs to be America/Los_Angeles in your case (So Angeles)

Thanks, I did spot that and had updated my container, but it did still get the internal server error. I'll try updating again and trying again -also will try updating postgres

I installed teslamate for the first time last week and followed the docker installation guide and using the example docker-compose.yml. I was having issues with the timestamps for my drives being hours off so I added the TZ variable into the compose and updated. Now my drives are the correct time.  The TZ setting should be added to the installation docs.

I was having issues with the timestamps for my drives being hours off so I added the TZ variable into the compose and updated. Now my drives are the correct time. The TZ setting should be added to the installation docs.

Where were your timestaps off? Grafana use your local browser settings for displaying.


iai-callgrind-runner broken incremental build

Installing this crate via the command below succeeds, but breaks cargo incrementability:
cargo install iai-callgrind-runner --version 0.12.3

Rerunning this command will recompile the binary from scratch, instead of being no-op.
This results in much slower builds, and not reusing the cache.
Expected:
Ignored package `iai-callgrind-runner v0.12.3` is already installed, use --force to override

Actual:
Replaced package `iai-callgrind-runner v0.12.3` with `iai-callgrind-runner v0.12.3` (executable `iai-callgrind-runner`)

Strange. Thanks for reporting this. I could reproduce it but don't know why this is happening, yet. Can you use binstall? Using cargo binstall<EMAIL_ADDRESS>seems to work:
❯ cargo binstall<EMAIL_ADDRESS> INFO iai-callgrind-runner v0.12.3 is already installed, use --force to override
 INFO Done in 1.242239ms

It looks like a cargo issue: https://github.com/rust-lang/cargo/issues/8703
iai-callgrind-runner is behind a feature gate and schema-gen which we only use internally, too.

Thanks for looking into this!

The fix will be part of the next release, but that doesn't fix the issue for older releases. For older releases binstall can be used to circumvent the problem with cargo install.

Does this solve your issue?

Yes. Thank you!


scroll to top when navigating to another page

Scroll to the top of the website when users navigate to another page of projects. It's a tiny enhancement but I suppose it's useful.

Added in 2f88726a467b1eca407f33df4f5c4b9c49950eb3


[DOCS] TVM install addenda for M1 Macs

Testing:
Ran restview on the doc and made sure it looked ok-ish.
Tested this on a sort-of-fresh M1 mac and can confirm these instructions work.

cc @hogepodge

@areusch @hogepodge PTAL

Hey guys, how is everything with this PR? If it looks good, let's https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-changes-explicitly

It should be good. @hogepodge @areusch ?


ignore first-pass-ledger-hashes in migration-mode

Explain your changes:
This PR makes the replayer ignores the first_pass_ledger_passes during migration-mode. The reasoning behind it is that during migration, we would not check snarked ledger hashes and we actually don't need those snarked ledger hashes for post-hard-fork transaction replaying. This fixes a stack overflow bug during migration.
Explain how you tested your changes:
*
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

!ci-nightly-me


Write a Ruby program to print pattern 1

Description
Write a Ruby program to print pattern 1
Input  : 5

Output :
1
1 2
1 2 3
1 2 3 4
1 2 3 4 5

Contributed by - @PraaneshSelvaraj

How to contribute

Save the solution in program/PrintPattern1.rb file
Add PrintPattern1.rb file in print-pattern-1 folder

!assign


[SIP-144] Proposal to Integrate VisActor Visualization Plugin into Superset

Please make sure you are familiar with the SIP process documented
here. The SIP will be numbered by a committer upon acceptance.
[SIP-144] Proposal to Integrate VisActor Visualization Plugin into Superset
Motivation
About VisActor:
VisActor is derived from a large number of visualization scenarios. While covering conventional visualization scenarios, it focuses on narrative visualization as a new point of emphasis and intelligent visualization as its goal. It has formed a visualization solution composed of multiple modules including rendering engine, visualization grammar, data analysis component, chart component, table component, GIS component, graph visualization component, and intelligent component.
We believe it could be a valuable addition to Superset, providing users with more high-level visualization ability.
Here is VisActor github address: https://github.com/VisActor
Here is VisActor website: https://www.visactor.io/
Proposed Change
- Chart Plugin Based VChart:
VChart is a charting component library in VisActor visualization system. It wraps the charting logic based on visual grammar library VGrammar and the component encapsulation based on visual rendering engine VRender. The core capabilities are as follows:

Cross-platform: Automatically adapt to desktop, H5, and multiple small program environments
Storytelling: Comprehensive annotation, animation, flow control, narrative templates, and other enhanced features for visual storytelling
Scenes: Deliver visual storytelling capabilities to end-users, unlock developer productivity

VChart Demo: https://www.visactor.io/vchart/example
- Table Plugin Based VTable:
VTable is based on visual rendering engine VRender.
The core capabilities are as follows:

Extreme performance: Supports fast computation and rendering of millions of data points.
Multidimensional analysis: Automatically analyzes and presents multidimensional data.
Strong expressiveness: Provides flexible and powerful graphic capabilities, seamlessly integrating with charts of VChart.

VTable Demo: https://www.visactor.io/vtable/example
- Intelligence Plugin Based VMind:
@visactor/vmind is an intelligent chart component based on LLM provided by VisActor, including dialog-based chart generation and editing capabilities. It provides a natural language interaction interface, allowing you to easily create chart narrative works with @visactor/VMind with just one sentence, and edit them through continuous dialogue, greatly improving your efficiency in creating data visualization works.
VMind Cases: https://www.visactor.io/vmind/scenario/Chart_Assistant
New or Changed Public Interfaces
Describe any new additions to the model, views or REST endpoints. Describe any changes to existing visualizations, dashboards and React components. Describe changes that affect the Superset CLI and how Superset is deployed.
New dependencies
@visactor/vchart
@visactor/vtable
@visactor/vmind
License: MIT
Migration Plan and Compatibility
one-api：https://github.com/songquanpeng/one-api
new-api：https://github.com/Calcium-Ion/new-api
Rejected Alternatives
Describe alternative approaches that were considered and rejected.

@rusackas @suddjian @craig-rueda @lilykuang @geido
Hello everyone！
I hope this message finds you well. I am a developer of project VisActor, our team are looking forward for cooperation with good visualization project. We noticed superset is a modern, enterprise-ready business intelligence web application and support plugin, such as echarts, etc.
So I'd like to check，is there aollowed to access visuliazation pulgin to enrich superset visualization ability？
Here is our proposal：https://github.com/apache/superset/issues/29886
Best regards,
VisActor Team

Hi! Thank you for the proposal! VisActor is very slick looking. I suppose I have a few initial questions to ask:

Are you proposing this as a replacement for ECharts, or to augment existing ECharts plugins?
Are you proposing putting these in core Superset, or do you want to make an external (third party) set of plugins people can add to their Superset instances?
Do you intend to contribute this code, or is this a request for engineering support from the Superset community?
Is there any sort of document comparing/contrasting VisActor with ECharts? That might be helpful to assess the situation

It's also worth saying that there are perpetual discussions around how to make the process of developing visualization plugins simpler. I don't think that will happen immediately, but it is discussed from time to time. Only mentioning it since when the day comes, existing plugins might need additional rework to accommodate a (hopefully simpler) API.

嗨！谢谢你的建议！VisActor 看起来非常漂亮。我想我有几个初步问题要问：

您是否建议用它来_替代_ECharts，或者_增强_现有的 ECharts 插件？
您是建议将这些放入核心 Superset 中，还是想要制作一组外部（第三方）插件供人们添加到他们的 Superset 实例中？
您是否打算贡献此代码，或者这是向 Superset 社区请求工程支持？
有没有比较/对比 VisActor 和 ECharts 的文档？这可能有助于评估情况

值得一提的是，关于如何简化可视化插件的开发过程的讨论从未停止。我认为这不会立即发生，但会不时地被讨论。之所以提到这一点，是因为到那时，现有的插件可能需要额外的修改才能适应（希望是更简单的）API。

当然可以，以下是你的回答翻译成英文：

Compared to ECharts, as previously mentioned, our VisActor product not only includes the standalone VChart chart library but also includes the VTable table library, VMind intelligent components, and VStory narrative components. These visualizations encompass a complete ecosystem of visualization rendering, so we expect to develop three visualization plugins on par with ECharts based on VisActor, rather than as a supplement to ECharts.

We hope to include high-frequency chart types or our unique capabilities into the core of Superset, such as chart annotations. Low-frequency chart types or component types can be placed into third-party plugins. Of course, this depends on your product definition of Superset.

Our team has a complete set of visualization engineers, and we are confident in participating in and contributing to Superset. During this period, we hope to have good communication with the Superset team and to listen to your development suggestions.

We have an internal comparison document with ECharts, which involves descriptions of chart types, feature capabilities, cross-platform compatibility, performance, package size, and other aspects. We will synchronize it with you after sorting it out later.

Please review and let me know if you need any adjustments or additional translations!

Hi! Thank you for the proposal! VisActor is very slick looking. I suppose I have a few initial questions to ask:

Are you proposing this as a replacement for ECharts, or to augment existing ECharts plugins?
Are you proposing putting these in core Superset, or do you want to make an external (third party) set of plugins people can add to their Superset instances?
Do you intend to contribute this code, or is this a request for engineering support from the Superset community?
Is there any sort of document comparing/contrasting VisActor with ECharts? That might be helpful to assess the situation

It's also worth saying that there are perpetual discussions around how to make the process of developing visualization plugins simpler. I don't think that will happen immediately, but it is discussed from time to time. Only mentioning it since when the day comes, existing plugins might need additional rework to accommodate a (hopefully simpler) API.

Compared to ECharts, as previously mentioned, our VisActor product not only includes the standalone VChart chart library but also includes the VTable table library, VMind intelligent components, and VStory narrative components. These visualizations encompass a complete ecosystem of visualization rendering, so we expect to develop three visualization plugins on par with ECharts based on VisActor, rather than as a supplement to ECharts.

We hope to include high-frequency chart types or our unique capabilities into the core of Superset, such as chart annotations. Low-frequency chart types or component types can be placed into third-party plugins. Of course, this depends on your product definition of Superset.

Our team has a complete set of visualization engineers, and we are confident in participating in and contributing to Superset. During this period, we hope to have good communication with the Superset team and to listen to your development suggestions.

We have an internal comparison document with ECharts, which involves descriptions of chart types, feature capabilities, cross-platform compatibility, performance, package size, and other aspects. We will synchronize it with you after sorting it out later.

Please review and let me know if you need any adjustments or additional translations!

Hi! Thank you for the proposal! VisActor is very slick looking. I suppose I have a few initial questions to ask:

Are you proposing this as a replacement for ECharts, or to augment existing ECharts plugins?
Are you proposing putting these in core Superset, or do you want to make an external (third party) set of plugins people can add to their Superset instances?
Do you intend to contribute this code, or is this a request for engineering support from the Superset community?
Is there any sort of document comparing/contrasting VisActor with ECharts? That might be helpful to assess the situation

It's also worth saying that there are perpetual discussions around how to make the process of developing visualization plugins simpler. I don't think that will happen immediately, but it is discussed from time to time. Only mentioning it since when the day comes, existing plugins might need additional rework to accommodate a (hopefully simpler) API.

Compared to ECharts, as previously mentioned, our VisActor product not only includes the standalone VChart chart library but also includes the VTable table library, VMind intelligent components, and VStory narrative components. These visualizations encompass a complete ecosystem of visualization rendering, so we expect to develop three visualization plugins on par with ECharts based on VisActor, rather than as a supplement to ECharts.

We hope to include high-frequency chart types or our unique capabilities into the core of Superset, such as chart annotations. Low-frequency chart types or component types can be placed into third-party plugins. Of course, this depends on your product definition of Superset.

Our team has a complete set of visualization engineers, and we are confident in participating in and contributing to Superset. During this period, we hope to have good communication with the Superset team and to listen to your development suggestions.

We have an internal comparison document with ECharts, which involves descriptions of chart types, feature capabilities, cross-platform compatibility, performance, package size, and other aspects. We will synchronize it with you after sorting it out later.

Please review and let me know if you need any adjustments or additional translations!

We discussed this quite a bit on Slack, but I think the fork in the road is whether or not you want to contribute this to the Superset repo to be maintained by Superset Committers, or whether it's going to be published on a separate repo. We can even establish a repo for it, if we want to keep it on the side as an optional installation.
If you go with adding it to the codebase officially, the SIP needs to go through the DISCUSS process (as we discussed on Slack) on the ASF<EMAIL_ADDRESS>email list. We'll lay out all the requirements of being an official plugin (supporting various features, arch/code designs, license requirements, etc).
If you keep it as an optional or 3rd party plugin, then I think both the requirements AND the process lighten up quite a bit.

Just surfacing that @skie1997 has been kind enough to share some docs on Slack, which could be useful here to share the intent/capabilities to carry the discussion forward
My current thinking is that we shouldn't be adopting any new plugins yet that compete with the existing ones. Anyone is of course welcome to publish third party plugins at any time.
Before we add/switch viz libraries to Superset more officially, I think we will need to re-address the plugin architecture a bit, starting with the design/interface/pluggability of control panels, and moving into the pluggability/security/semVer of plugins themselves. There have been some scattered discussions around much of this, but I think it won't be long until a plan is formalized and brought up as a SIP.


trueseeing: 2.1.5 -> 2.1.7

Diff: https://github.com/alterakey/trueseeing/compare/v2.1.5...v2.1.7
Changelog: https://github.com/alterakey/trueseeing/releases/tag/v2.1.7
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 254254 run on x86_64-linux 1

2 packages built:

trueseeing
trueseeing.dist


[Draft] [Service Bus] Plug in retry options for all async operations

Live tests - green ✔
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=329483&view=results

/azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests


fix(refactor): Deprecate unikraft.TypeNameVersion

Closes: #268

Prerequisite checklist

[x] Read the contribution guidelines regarding submitting new changes to the project;
[ ] Tested your changes against relevant architectures and platforms;
[ ] Ran make fmt on your commit series before opening this PR;
[ ] Updated relevant documentation.

Description of changes

Hi there, I hv been struggling wid some errs and can u take a look here? Do I have to create struct here? Thanks
Error: unikraft/type.go:114:7: invalid receiver type Nameable (pointer or interface type)
Error: unikraft/type.go:116:12: entity.Type undefined (type *Nameable is pointer to interface, not interface)

cc @nderjung

Hi @afzal442, thanks for having a look at this! Interfaces in Go cannot be instantiated in the same way as structures and as such implementing the String() method on the interface directly will result in a compile-time error.  Instead, each structure which implements the interface must include the String method.
My suggestion is to implement String() on all implementing components which in fact return the unikraft.TypeNamVersion such that their output is standardized, e.g. for the unikraft component:
func (uc UnikraftConfig) String() string {
  return unikraft.TypeNameVersion(uc)
}

Got tha idea. Thanks much! I have to implement String() on all implementing components UnikraftConfig.

Hi @afzal442, please can you view and address the checks that are failing? Additionally, rebasing to staging will invoke more up-to-date checks. Thanks!

Sorry @nderjung ! I am done. Could you review it? Thanks

Please see my inline comment which requests to discard the highlighted change. Additionally, please squash your commits into a single commit which has a commit title the same as this PR. :)

Please see my inline comment which requests to discard the highlighted change

Hi @nderjung I had already pointed out this in fact. But you said no. That's why there was no point of deprecation of unikraft.TypeNameVersion. LMK if I understood here.


Translation support for prefabs (and other?) assets

We have translation capacity now and our Weblate instance up at translate.terasology.org but that's currently limited to strings in the UI. We need to add support to also do translation inside prefabs so an "Axe" can be translated to other languages. Logistically we also need to find an easy way to set up one Weblate project per module and maybe have a base shared dictionary for words likely to be repeatedly translated in different places.
There is an old discussion with some notes at http://forum.terasology.org/threads/internationalisation.1028/
This isn't likely to be super straight forward but may be doable by an experienced individual or be suitable for a mentoring setup of some sort.
This issue replaces old #1343 since basic translation was implemented.

We are no longer using weblate.
Closing as outdated.


Improve code style and readability for DocumentDB

Enabling flake8 check on DocumentDB code results in new PEP8 compliance issue. I fixed all of them in this pull request. Moving forward, style check will be run on DocumentDB for each commit.
Many changes are caused by the removal of pylint: disable statement. These switches are not recommended. Disabling a check for the entire scope of a file should be cautious about. I removed most of the line-too-long exempts and narrows the scope of other exempts.

Codecov Report

Merging #3112 into master will not change coverage.
The diff coverage is 69.56%.

@@           Coverage Diff           @@
##           master    #3112   +/-   ##
=======================================
  Coverage   70.42%   70.42%
=======================================
  Files         360      360
  Lines       23185    23185
  Branches     3555     3555
=======================================
  Hits        16329    16329
  Misses       5822     5822
  Partials     1034     1034

Impacted Files
Coverage Δ

...ntdb/azure/cli/command_modules/documentdb/_help.py
100% <ø> (ø)
:arrow_up:

...i/command_modules/documentdb/_exception_handler.py
18.96% <0%> (ø)
:arrow_up:

...re/cli/command_modules/documentdb/_command_type.py
91.66% <100%> (ø)
:arrow_up:

...b/azure/cli/command_modules/documentdb/__init__.py
100% <100%> (ø)
:arrow_up:

...db/azure/cli/command_modules/documentdb/_params.py
72.72% <100%> (ø)
:arrow_up:

...b/azure/cli/command_modules/documentdb/commands.py
96.66% <100%> (ø)
:arrow_up:

...tdb/azure/cli/command_modules/documentdb/custom.py
20.66% <31.25%> (ø)
:arrow_up:

.../cli/command_modules/documentdb/_client_factory.py
24% <66.66%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8b827...2afe2d6. Read the comment docs.

Ping @tjprescott