ENH: add support for --addfragments flag

Adds supports for --addfragments flag for addition of fragmentary sequences to existing alignments.
Since it's just a small variant of mafft_add, rather than creating a new action I introduced a new parameter in the existing one that will determine whether the --add flag (current behaviour) or --addfragments one should be used.

Thanks so much for the contribution @misialq and for the review @mikerobeson! I have a use case for this now, so very excited to try it out!


Panda: Write positions for every gridscan

As a scientist/developer I would like to know that the panda is triggering at the right places. The panda can write triggering positions out as HDF files, we should configure it so that it always does this.
Note:

We provided the panda with a directory for this at https://github.com/DiamondLightSource/hyperion/pull/1337 but that directory will not exist, we may need to create it

Acceptance Criteria

Every time a panda grid scan is run it writes the positions out to an appropriate file

I just tried this out and we will need to create the directory first

The deployed Hyperion version now uses the directory provider, but we aren't creating the panda directory anywhere, so we need to make sure it's created in Hyperion before the next release


for the whole, okay, lots of features and a good look, but it's even faster in the transaction

Freely describe your questions or issues here.

@angga1222 Thank you for your testing and we hope to continue delivering high quality features and improvements!


Limit deploy step of deploy.yml to NCAR/CUPiD repo on main branch

Addresses #53
Summary of changes:

adds if check to make sure the action will only try to deploy from NCAR/CUPiD on main branch

See action run from my fork where the action returns success, but has skipped the deployment step.

This is great, thanks!


Business Rules Referral Prescription V0.21

Business Rules ReferralPrescription V0.21.docx

Elements from this document that are not applicable for the June release will be handled in branch issue-219

@annenerenhausen @NathanPeeters @EmilySevrin
The changes beyond the June release can be found on https://build.fhir.org/ig/hl7-be/referral/branches/issue-219/
I just started adding them to the IG.


Added my profile card

Sir/mam,
I have added my profile card following all the guidelines. Thank You!!!

@CodingSpecies, thanks for letting me know.
[x] Updated the fork
[x] uploaded png image of 721x721.

@geeky01adarsh I can't see your image, it just shows you have upstreamed your fork.

Ya, really sorry for that, my online editor hadn't committed the last changes I had made.
Completed it, please check it now.
@CodingSpecies

@geeky01adarsh this is no longer part of hacktoberfest, there was some issues. Perhaps see this topic: https://github.com/topics/hacktoberfest for more hacktoberfest repos. Sorry for this. I will merge this anyway.

That's alright!!! Thanks for merging it,,,


Working on routing with custom url

Great work you have here...
I'd like to ask on how to create routing if I want to make a pretty url. Something like this

example.com/fashion/10-best-winter-coath

where "fashion" is the slug for categories and "10-best-winter-coath" is slug for article.
Since your routing only take 1 paramater, I dont know how to do it using 2 parameters.
I try some combination like this

Route::get('{cSlug}/{aSlug}', ['as' => 'article', 'uses' => 'PageController@getArticle']);
Route::get('c/{cSlug}/{aSlug}', ['as' => 'article', 'uses' => 'PageController@getArticle']);

But it didn't work
I'm new to laravel, so I hope you can help me how to work it out.

routes.php
Route::get('c/{cSlug}/{aSlug}', ['as' => 'article', 'uses' => 'PageController@getArticle']);

And in your PageController,
public function getArticle(Category $category, Article $article)

And in the /app/Providers/RouteServiceProvider
Route::bind('aSlug', function ($slug) {
    return Article::with('category')->where('slug', $slug)->firstOrFail();
});
Route::bind('cSlug', function ($slug) {
    return Category::with('articles')->where('slug', $slug)->firstOrFail();
});


Different IN_MAP(IN CHANNEL) normalization definitions in Caffe and in ACL

Hi, ACL guys,
The CROSS-CHANNEL (CROSS-MAP) result of Caffe implementation and ACL is the same, while ACL has different understanding of IN-CHANNEL(IN-MAP) with Caffe.
Caffe will do a normalization with the square box related, which size is norm_size x norm_size.
Please refers to the illustrative function in src/caffe/test/test_lrn_layer.cpp
template
void LRNLayerTest::ReferenceLRNForward
ACL just calculates the elements following the width axis (dim==0) for IN-MAP, per my understanding of NENormalizationLayerKernel::normalize().
Please let me know if there is a plan to follow Caffe's IN CHANNEL normalization method?
@AnthonyARM
Thanks,
Cyberfire

Hello @cyberfire ,
The current IN-MAP normalization that we support follows the OpenVX specification.
Yes we have already identified that the Caffe in-map normalization is different and we are planning to support this as well.
Regards,
George

@GeorgeARM The answer is clear.  I will close this ticket.


zero global currency setup

we need a unified currency setup to understand what currencies are available and to use and refer to them with confidence:

UID <u8>
Name Vec<u8>
Symbol Vec<u8>
Decimals <u8>

0
Zero
ZERO
18

1
Game
GAME
10

2
Play
PLAY
10

...

10
Polkadot
DOT
10

11
Kusama
KSM
12

12
Acala
ACA
12

13
Acala Dollar
AUSD
12

...

100
3rd party

1. graph ->hadi @5-mark

[ ] extend schema to contain currencies
[ ] create mock data resolver to enable subscriptions

2. rust / chain (depends on 1.) @vovacha

[ ] add enums to extend primitives based on best practice

3. graph (depends on 2.) -> hadi @vasylenko-yevhen

[ ] create relevant logic to update based on produced blocks
[ ] expose values based on a query using address as arg returning currencies selected

4. frontend (depends on 1.) -> hadi @DarkNebula0

[ ] consume primitive currencies
[ ] make them visible based on feature / config
[ ] make them usable based on feature / config

@inan please add hadi to the repo and update the contents if required

@5-mark what is the status on this? I see a lot of ongoing tasks, are there tickets for this?


Hereditary Hemochromatosis xref

https://github.com/monarch-initiative/helpdesk/issues/31

Note to self: need to look into hemochromatosis classification further and flesh out our hierarchy eg bronze diabetes.
the parent of 'hereditary hemochromatosis' is hemosiderosis, we don't have a general hemochromatosis class. I'll look into this further

from Peter:
Many but not all cases of hemochromatosis are Mendelian.

Heamochromatosis shouldnt be is_a Hemosiderosis
Difference between haemochromatosis and Hemosiderosis
Hemochromatosis is a rare disease in which direct deposition of iron takes place in body organs such as liver, spleen, pancreas and skin that cause tissue damage. Hemosiderosis on the other hand side is a disorder characterized by deposition of excess iron within the body tissues that normally do not containing iron.

Thanks @ValWood!


Accessibility - Font Size Changes

Tidy 5e Sheets should be able to scale based on the root font size. By default, this font size is set to 16px by Foundry, but if the user increases it to 32px, for example, Tidy 5e Sheets should scale up comfortably. Its content should be readable, and its layout should not break in unexpected ways.
References
https://discord.com/channels/732325252788387980/1116078321067892796/1160617084955394088
From discord user fallayn:

btw my players with worse eyesight just noted that some parts of the sheet break pretty badly if you increase the font sizes in Foundry's settings (like the currency section)

This is already supported in Foundry with font scaling, plus the ability to zoom the browser itself.


Need to be root to install docs

The problem
In the Build.pm6 we have the following line:
my $dest-pref = $*REPO.repo-chain.grep(/site/).first.prefix.child("doc");

But when I check my repo-chain, I get the following:
% perl6 -e '.say for $*REPO.repo-chain;'
inst#/home/tmtvl/.perl6
inst#/usr/share/perl6/site
inst#/usr/share/perl6/vendor
inst#/usr/share/perl6
ap#
nqp#
perl5#

The site path requires root permissions to modify.
Suggestions
If the user isn't root, I suggest installing the docs to their local prefix. We could get that by grepping either for %*ENV<HOME> or for a dotdir (I do not use rakudobrew, so I don't know if zef uses the same directory when installed with it).

Hum. I don't think we should do this. First, let's just assume that the person using the installation has enough privs to install it whoever they want. Let's not second-guess them by using a OS-dependent way of detecting root, and a very fragile one at that. Most people just have a sudoed user.
It would be much better if you reverted this commit, and labeled this as "meta" for discussion.

WRT to the OP, you don't need to be root to install docs. Just need to have permission to write in the directories you are going to install things. I use perlbrew, I don't need to be root to install anything. So that would be another reason to revert this commit.

I've deleted the branch. If we aren't going to use an OS-dependent way of changing things we should at least allow the user to customize the install directory instead of just assuming that the user either A) has root permission, or B) is using perlbrew.
If we want Perl 6 to be enterprise-quality we should future-proof it accordingly.

We can't do that at the documentation level. It's zefs task to do that. We just give it to Zef to take care of that. You want to have it elsewhere, build the documentation and run the server. That's also included.

And just to be clear, Perl 6 is already enterprise-quality.

Okay, I'll ask zef if there's something they can do, thanks for the help!

Sure. Good luck!


Newsletters: add #27

Based on top of #96 (squashed).
I've left in the commits based on emailed feedback in case anyone wants to check the edit trail, but these can be squashed at commit time.

utACK. Amazing.

squashed commits down to two and merged. Thanks all!


[BUG] Unable to load one or more of the requested types in FSH.WebApi.Infrastructure.Common.StartUp

Hi!
I have recently cloned this project with the intent of studying the architecture. When I run the application I get an error at startup. The error occurs in Program.cs of the Host project when executing the line
builder.Services.AddInfrastructure(builder.Configuration);

The error occurs in the following code in FSH.WebApi.Infrastructure.Common.StartUp
    internal static IServiceCollection AddServices(this IServiceCollection services, Type interfaceType, ServiceLifetime lifetime)
    {
        var interfaceTypes =
            AppDomain.CurrentDomain.GetAssemblies()
                .SelectMany(s => s.GetTypes())
                .Where(t => interfaceType.IsAssignableFrom(t)
                            && t.IsClass && !t.IsAbstract)
                .Select(t => new
                {
                    Service = t.GetInterfaces().FirstOrDefault(),
                    Implementation = t
                })
                .Where(t => t.Service is not null
                            && interfaceType.IsAssignableFrom(t.Service));

        foreach (var type in interfaceTypes)
        {
            services.AddService(type.Service!, type.Implementation, lifetime);     <----- This is where the error occurs
        }

        return services;
    }

This is the exception:
ex	{"Unable to load one or more of the requested types.\r\nCould not load file or assembly 'System.ServiceModel, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The system cannot find the file specified.\r\nCould not load file or assembly 'System.ServiceModel, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The system cannot find the file specified.\r\nCould not load file or assembly 'System.ServiceModel, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The system cannot find the file specified.\r\nCould not load file or assembly 'System.ServiceModel, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The system cannot find the file specified."}	System.Exception {System.Reflection.ReflectionTypeLoadException}
Any idea on what may be wrong?

Hmm this looks strange... you simply cloned the project and build and ran it without any modifications?
System.ServiceModel version <IP_ADDRESS> feels like a .NET framework thing? Something must be mixed up with versions on your build system maybe?
What exactly is it trying to add (type.Service and type.Implementation) when that error gets thrown?

Hi @fretje,
yes, I simply cloned the project with VS2022, no modifications. Just to be sure, I cloned the solution again and I get the same error.
 I did a search on Google about it, one suggestion I found was to install the nuget package System.ServiceModel.Primitives. This doesn't resolve the problem but the error is different, though still related to System.ServiceModel. After installing the nuget package the error I get is the following
ex	{"Unable to load one or more of the requested types.\r\nCould not load type 'System.ServiceModel.Configuration.BehaviorExtensionElement' from assembly 'System.ServiceModel, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'."}	System.Exception {System.Reflection.ReflectionTypeLoadException}
None of the other solutions I have on this machine gives me this problem. To be sure it is not something related to versions in my computer, I tried cloning the solution to another computer and got the same error.
The exception is thrown in the code I posted in my first post when loading the IAuditService  interface.

That is very strange.
I can't repeat this. I also just cloned the project, and it builds and runs fine.
Something database related maybe? You have Sql Server Express LocalDB installed (that is what the default connectionstring is referring to).

I do have Sql Server Express LocalDB installed. Migration creates the db with all its schemas, the tables are properly seeded.

That's even stranger, as the database initialization happens after where you say you get that exception... So the database initialization shouldn't even be reached?
If it does, that probably means the code where you get the exception (startup) is called twice somehow? It seems to be called again after the database initialization, but then in the context of .NET framework? Doesn't really make much sense... but that's all I can tell from what I see here ;-)

Hmm... wait, I am not sure I follow you. The db is seeded when I execute dotnet run
E:\Source\Repos\Samples\dotnet-webapi-boilerplate\src\Host>dotnet run Building... [17:28:08 INF] Server Booting Up... [17:28:14 INF] Hangfire: Current Storage Provider : mssql [17:28:14 INF] For more Hangfire storage, visit https://www.hangfire.io/extensions.html [17:28:22 INF] Current DB Provider: mssql [17:28:25 INF] Applying Root Migrations. [17:28:26 INF] Applying Migrations for 'root' tenant. [17:28:26 INF] Connection to root's Database Succeeded. [17:28:26 INF] Seeding Admin Role for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Dashboard.View' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Hangfire.View' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Users.View' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Users.Search' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Users.Create' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Users.Update' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Users.Delete' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Users.Export' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.UserRoles.View' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.UserRoles.Update' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Roles.View' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Roles.Create' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Roles.Update' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Roles.Delete' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.RoleClaims.View' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.RoleClaims.Update' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Products.View' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Products.Search' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Products.Create' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Products.Update' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Products.Delete' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Products.Export' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Brands.View' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Brands.Search' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Brands.Create' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Brands.Update' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Brands.Delete' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Brands.Generate' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Brands.Clean' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Tenants.View' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Tenants.Create' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Tenants.Update' for 'root' Tenant. [17:28:26 INF] Seeding Admin Permission 'Permissions.Tenants.UpgradeSubscription' for 'root' Tenant. [17:28:26 INF] Seeding Basic Role for 'root' Tenant. [17:28:26 INF] Seeding Basic Permission 'Permissions.Products.View' for 'root' Tenant. [17:28:26 INF] Seeding Basic Permission 'Permissions.Products.Search' for 'root' Tenant. [17:28:26 INF] Seeding Basic Permission 'Permissions.Brands.View' for 'root' Tenant. [17:28:26 INF] Seeding Basic Permission 'Permissions.Brands.Search' for 'root' Tenant. [17:28:26 INF] Seeding Default Admin User for 'root' Tenant. [17:28:26 INF] Assigning Admin Role to Admin User for 'root' Tenant. [17:28:26 INF] Started to Seed Brands. [17:28:27 INF] Seeded Brands. [17:28:27 INF] For documentations and guides, visit https://www.fullstackhero.net [17:28:27 INF] To Sponsor this project, visit https://opencollective.com/fullstackhero [17:28:29 INF] Current DB Provider: mssql [17:28:29 INF] Now listening on: https://localhost:5001 [17:28:29 INF] Now listening on: http://localhost:5000 [17:28:29 INF] Application started. Press Ctrl+C to shut down. [17:28:29 INF] Hosting environment: NotDevelopment [17:28:29 INF] Content root path: E:\Source\Repos\Samples\dotnet-webapi-boilerplate\src\Host\
As both localhost:5001 or localhost:5000 don't work, I launch the application in debug mode and that is when I see the exception.
UPDATE: I have just noticed a new exception that didn't see before:
ex	{"Failed to bind to address https://<IP_ADDRESS>:5001: address already in use."}	System.Exception {System.IO.IOException}

Ok, I am not sure why but after cloning the solution for the umpteen time I don't get an exception anymore. So, I close the issue.


davinci-resolve: overriding appimage-run to use buildFHSEnvChroot

Description of changes
#226671 The way davinci-resolve was using appimage-run threw the following build errors:
DaVinci_Resolve_17.4.3_Linux.run is now installed in /build/home/.cache/appimage-run/0942a051d270a19f39d312a347c8cd0ebf45327ae
d008646f99d7bff78d5d8c4
This will install DaVinci Resolve on this computer
#Starting DaVinci Resolve install

Linux localhost 5.15.94 #1-NixOS SMP Tue Feb 14 18:18:05 UTC 2023 x86_64 GNU/Linux

Install Location : /nix/store/b0lv2di80qgnfhk7hxppmwz3xial1kny-davinci-resolve-17.4.3
User ID: 0

User Home: /build

Error: Installer failed
 Failed to copy file: share

Overriding appimage-run to use buildFHSEnvChroot instead seems to resolve the build error.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Nit: Commit messages are usually written in simple present, not present progressive.


Debugging source on OSX

I would like to debug a node-module compiled with node-gyp.
I am currently able to build a debug version of the module and to use gdb to trace through my code...
being a bit lazy, I would like to use a visual IDE (xcode) to step through the code and inspect values... I was under the impression that node-gyp would generate a xcode project that I could use and then using 'attach to process..." from xcode be able to set breakpoint and trace the code...
a) is that the correct approach?
b) can't find the xcode project... should it be somewhere in the /build directory?

node-gyp configure -- -f xcode

The fix, as noted by @graysonlang, would be to pass -f xcode to generate an XCode project. Going to close since there's no bug here in node-gyp or gyp


cannot load library libRaptorQ.so on Mac Sierra

On my Mac Sierra (10.12.5), I cannot import libraptorq.
It fails with OSError: cannot load library libRaptorQ.so: dlopen(libRaptorQ.so, 2): image not found.  Additionally, ctypes.util.find_library() did not manage to locate a library called 'libRaptorQ.so’.
I managed to fix it by renaming libRaptorQ.so to libRaptorQ.dylib on this line:
https://github.com/mk-fg/python-libraptorq/blob/master/libraptorq/__init__.py#L126
Ideally, importing the shared object should be handled in a platform agnostic manner.

Yeah, .so is a linux thing, and guess it's .dynlib on OSX (and .dll on Windows).
cffi probably has a wrapper to pick one depending on platform, which should probably be used here.
I've only ran the thing on linux myself, which is why it has that hardcoded .so in there.
Thanks for testing with OSX and providing a solution, should be easy to address, will probably get to it soon.

Apparently ffi.dlopen('RaptorQ') will work fine as well, as it indeed falls back to ctypes.util.find_library, as indicated in that error.
CFFI docs discourage relying on that though, so added explicit call to that ctypes helper, should probably work now.


pad is not adding the correct padding

return padEnd ? (str + padEnd) : (padEnd + str);

padEnd is a boolean, so this will produce undesired results. You should consider unit-testing such utilty modules. Even more so, when you plan to use them all over the place ;)

Good catch, I hadn't actually tested this implementation - way to go, me. I threw it together based on a simpler implementation and then neglected to test.
Thanks!


[Linux] Error while compiling GLSL shader. []

Release Type: Official Release
Version: <IP_ADDRESS>5+
Platform(s): Linux
Describe the bug
It is not possible to play any game during runtime because of error : Error while compiling GLSL shader. []
To Reproduce
Steps to reproduce the behavior:

Run GameStudio
Create new project based on SpaceEscape template
Add Linux platform
Go to Linux platform project and build It to test executable on Linux
Run

Expected behavior
The application should work flawlessly
Log and callstacks
stacktrace.txt
Additional context
What interesting though, You can run without any issues OpenGL app on Windows, so it might be easy to solve once you find the cause of the problem.
This issue will be updated as my investigation continues.

I found another way to reproduce the error:

create a project from an empty template
remove skybox and leave only two elements for Main Scene - camera and light.
import any custom model (for testing purposes I used royality free Train kit from Kenney).

Same result

I got the same result when I added only a procedural cube without material to the scene

Another use case:

1 . create a project from an empty template
2. remove skybox and leave only two elements for Main Scene - camera and light.

this time import only spritesheet (download any image from the internet or create by yourself)

Works

Conclusion : Both Procedural and Imported models may share a common code that is flawed

Okay...That's new.
Another use case
1 . create a project from an empty template, but this time don't check the HDR option and use *LDR instead - also pick lowest API level - Level 9
2. remove skybox and leave only two elements for Main Scene - camera and light.
3. import any model - procedural cube for example
Works!

Those steps sound like a similar issue to the mobile issue steps https://github.com/stride3d/stride/issues/2485
You might be able to just uncheck Generate mipmaps if Im right? I dont know how much that info actually helps you but if its true it may be useful.

I'm not sure if this is the case because my test projects don't contain any materials at all 😕

I compared the shader scripts and on both Windows and Linux they are the same

Another progress, I was able to capture SDL error:
INFO: Unable to make EGL context current (call to eglMakeCurrent failed, reporting an error of EGL_BAD_ACCESS) -1

Huh...Good news ! Looks like I have managed to making it work!
Bad news is that there is something wrong with wayland
Setting following env variable to X11 fixed an issue:
export SDL_VIDEODRIVER=x11


Fixed a typo within pkg/authorization/api.go

Signed-off-by: Diego Romero<EMAIL_ADDRESS>- What I did
As I was exploring the docker codebase, I found and corrected a typo within pkg/authorization/api.go
- How I did it
I replaced the spelling error with the correct word
- How to verify it
Options include Google or an old school dictionary
- Description for the changelog
Fixed a typo within pkg/authorization/api.go
- A picture of a cute animal (not mandatory but encouraged)

LGTM

LGTM


AddResourceDropdown should use the Link tag provided by react-router for redirecting the user to overlays.

Unfortunately, just inserting a Link component isn't as straightforward as it seems.  The issue then becomes, that the anchor (<a/>) tag that Link renders does not occupy the entire width and height of its parent div making part of the dropdown list item  unclickable:

Solving this problem requires that clockface Dropdown.Item take custom styles, class names, or both.  Since, all this story is doing is saving us the trouble of passing a couple of callbacks that fire router.push I say this story is fine to hold off until this occurs in clockface.


[Card in card image and video variant] Prod QA testing

User Story

As a [user role below]:
developer using the ibm.com Library Card in card

I need to:
have a version of the pattern or component that has been tested for accessibility compliance as well as on multiple browsers and platforms

so that I can:
be confident that my ibm.com web site users will have a good experience

Additional information

Browser Stack link
Browser Standard
Browser versions to be tested:  Tier 1 browsers will be tested with defects created as Sev 1 or Sev 2.  Tier 2 browser defects will be created as Sev 3 defects.
Platforms to be tested, by priority:  1)  Desktop  2)  Mobile  3)  Tablet
Mobile & Tablet iOS versions: 13.1, 13.3 and 14
Mobile & Tablet Android versions: 9.0 Pie and 8.1 Oreo
Browsers to be tested:  Desktop: Chrome, Firefox, Safari, Edge, Mobile: Chrome, Safari, Samsung Internet, UC Browser, Tablet: Safari, Chrome, Android
Accessibility Checklist
Creating a QA bug
See the Epic for the Design and Functional specs information
Only test the Web Components version.  The React version will be developed later.
Card in card Box folder
Web Components image variant Dev issue (#5308 )
Web Components video variant Dev issue (#5458 )
Once development is finished the updated code is available in the Web Components Canary Environment for testing.

Acceptance criteria

[ ] Accessibility testing is complete.  Component is compliant.
[ ] All browser versions are tested
[ ] All operating systems are tested
[ ] All devices are tested
[ ] Defects are recorded

@Praveen-sr The development had to be broken into 2 releases.  (March & April).  One for the card and card with image and the other includes the video feature, issue (#5458 ).  The testing of this component is blocked by the video feature that has been included in sprint 21-06

@Praveen-sr This component is ready to be tested.


Invalid chunk error when trying to load a dumped Db

I'm using PouchDb on electron with IndexedDb as a backend. So is the browser version of pouchdb. I'm dumping the database by using
var ws = fs.createWriteStream(path)
_db.dump(ws)

When I try to load the dumped db with
var rs = fs.createReadStream(path[0])
_db.load(rs)

I get the error Invalid non-string/buffer chunk
The node version is 4.1.1
Any ideas on what could be the problem?
------- EDIT -------
From what I see it could be a problem of being using the browser version in a node environment or something like that. Given that the part that's failing is this one here.
    // this only applies in the browser
    /* istanbul ignore next */
    if (!(chunk instanceof Buffer) && Buffer.isBuffer(chunk)) {
      chunk = new Buffer(chunk);
    }
    this.push(chunk);

chunk instanceof Buffer is true so is not doing chunk = new Buffer(chunk); Later it tries to validate on the function validChunk using !Buffer.isBuffer(chunk) which is not passing because the _isBuffer property is undefined

It was a problem of using it on the browser but with node. If I install the package using npm it works. But I have to also install pouchdb using npm. So I ended up having two installations. I'm using pouchdb with indexedDb on Electron because if I want to use it with leveldown I would have to build leveldown for each platform complicating my CI setting a lot. Is there a way of using the npm version with indexedb? Or I would like to have some pointers on how to patch pouchdb-replication-stream so it can contemplate this setting.


DCN v2 compilation for RTX 3080

Hello,
I am not able to compile DCN v2. My configuration is the following:
conda 4.9.2
python 3.8.8
pytorch 1.8.1
Build cuda_11.2.r11.2/compiler.29618528_0
driver version: 460.39
CUDA Version 11.2
I have tried many DCN v2 forks to compile but I was not able succeed.
Any help would be appreciated :)
Thank you
Fatih.

I am OK on both RTX3080 and pytorch 1.8 with CUDA11. Please make sure you using this fork.

Hey @capricornfati
If you are using a virtual environment, make sure you activate it by adding this line at the beginning of make.sh
source <absolute_path_to_virtualenv>/bin/activate
Also, change the line from 'sudo python setup.py build develop' to 'python setup.py build develop' in make.sh

Hey @capricornfati
If you are using a virtual environment, make sure you activate it by adding this line at the beginning of make.sh
source <absolute_path_to_virtualenv>/bin/activate
Also, change the line from 'sudo python setup.py build develop' to 'python setup.py build develop' in make.sh

Hello,
I have been experimenting in conda environment. I install cuda tool kit, torchvision and torch according to pytorch locally instructions. I removed “sudo”  in make.sh before. I haven’t tried to install pytorch on the system (without any virtual environment) yet. I will try it. Thank you

I am OK on both RTX3080 and pytorch 1.8 with CUDA11. Please make sure you using this fork.

Do you use anaconda?
Could you please give detailed information about your system?
os version
nvcc version (cuda)
nvidia-smi output
anaconda version
python version
pytorch version

Hey @capricornfati
If you are using a virtual environment, make sure you activate it by adding this line at the beginning of make.sh
source <absolute_path_to_virtualenv>/bin/activate
Also, change the line from 'sudo python setup.py build develop' to 'python setup.py build develop' in make.sh

I already did operations in activated conda environment so I think no need to activate python environment.
Any help would be appreciated

I'm not sure this is same issue but hope this helps. #40

@capricornfati I am getting the following error :
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1667, in _run_ninja_build
subprocess.run(
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/subprocess.py", line 516, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "setup.py", line 55, in
setup(
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/site-packages/setuptools/init.py", line 153, in setup
return distutils.core.setup(**attrs)
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/distutils/command/build.py", line 135, in run
self.run_command(cmd_name)
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 79, in run
_build_ext.run(self)
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/distutils/command/build_ext.py", line 340, in run
self.build_extensions()
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 708, in build_extensions
build_ext.build_extensions(self)
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/distutils/command/build_ext.py", line 449, in build_extensions
self._build_extensions_serial()
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/distutils/command/build_ext.py", line 474, in _build_extensions_serial
self.build_extension(ext)
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 202, in build_extension
_build_ext.build_extension(self, ext)
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/distutils/command/build_ext.py", line 528, in build_extension
objects = self.compiler.compile(sources,
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 529, in unix_wrap_ninja_compile
_write_ninja_file_and_compile_objects(
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1354, in _write_ninja_file_and_compile_objects
_run_ninja_build(
File "/usr0/home/sumita/miniconda3/envs/FairMOT/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1683, in _run_ninja_build
raise RuntimeError(message) from e
RuntimeError: Error compiling objects for extension
os version
nvcc version (cuda) : 9.1
nvidia-smi output : GeForce GTX 1080
anaconda version : latest
python version : 3.8
pytorch version : 1.8.0

@sumit-agrwl hello. Although a lot of time has passed but,, did you solve above issue?


Published versions of analyzer have FastUri incompatible with SDK 1.19.

In order for Analyzer's FastUri class to work, its implementation of hashCode must match the implementation in the SDK (because analyzer mixes FastUris and Uris inside Maps).
In version 1.19 of the SDK, Uri's implementation of hashCode was changed, and FastUri was updated accordingly.  However, since releases of analyzer to pub are not coupled with SDK releases, this means that there are published versions of analyzer that will break when SDK 1.19 is released.
Two versions of analyzer are affected: 0.27.5 and 0.28.0.
To work around the problem, we plan to add a static final boolean variable to analyzer which determines whether Uri uses a new or an old implementation of hashCode (by attempting to hash a hardcoded URI).  This boolean will determine the behavior of FastUri.hashCode.
This fix needs to be cherry-picked to the historic releases of analyzer, and released as 0.27.6 and 0.28.1, respectively.

Fix FastUri to be compatible with both old and new VMs.
https://github.com/dart-lang/sdk/commit/08a682500c1b67ed979d8a40d8b5e44191dca27c

I published 0.27.6 and 0.28.1 with the same FastUri implementation.

Should we archive the branches used to publish these versions, in case we need to do further bug fixes to them?

I don't know what this means in git :-(
I suspect that git cl land would attempt to land this in bleeding edge.
So, I just applied the changes to the corresponding branches #85551ad and #261ef2b, published analyzer and rolled the changes back.


Find more robust solution for binded/kt's dylib loading limitation

We currently have a solution in place which I think isn't ideal and we could make more robust; binded/kt/fix-load.sh exists to do a code-replace on the UniFFI code-generated binded/kt/src/main/kotlin/web5/sdk/web5.kt source code file.
The background is that we have a binded/kt/src/main/resources/natives/libweb5.dylib file, which is the build output of building the bindings/uniffi crate. This is obviously a binary file, which, in order for the binded/ projects to work, needs to be loaded into memory, whereafter the UniFFI code-generated can invoke the functionality within the binary. The UniFFI code-generated Kotlin code uses the Native.load() call to load the binary, and this call assumes the binary exists in some system-path (AKA, the binary cannot be loaded from within the JAR artifact). But we want developers to be able to add the web5-kt-core dependency and immediately be able to use it; we don't want them to have to install the dylib file to one of their compatible system paths. So the binded/kt/fix-load.sh script currently does a code-replace on the web5.kt source code file, and the new Kotlin code remediates this issue by unpacking the dylib file into a compatible path and calling the load() function.
All of this is less than ideal to me. Surely there is some mechanism for us to build the binded kt project with the binary file self-contained wherein the code and load the binary from within itself.

Unclear to me if the current solution will work in Android environments


Save build config independently from git repository

Describe the solution you'd like
I would like to have an option to save my build configuration somewhere.
Now when your token is invalid or you move your repo all configs are gone - there are permanently deleted so even AppCenter administrators cannot retrieve them.
Describe alternatives you've considered
Reusable build configuration would be great but maybe even some read-only history of configurations would be helpful? Maybe export to JSON? Something that can be used to restore configuration after repo change.

@dkoprowski Thanks for adding this feature request. We will keep this issue open for visibility and would let you know once we decide to support it in App Center.


Update German translations

Coverage remained the same at 58.782% when pulling 1d835d56b84345e78f276c304b2fa264e677d93f on der-lyse:master into ae278e780a01a1001cead5bd2ca24399d04bb5cc on newsboat:master.


Allow to get/set the encoding and charset

Such as IEncodingSupport::setEncoding , i want to code an extension for detect file's encoding. now detect encoding successed, but i don't known how to change encoding by API, could u help me?

We currently do not have API to set the encoding for files from extensions.

@bpasero  Think for your reply. Would you have plan to add API in future? or support encode detect just like ATOM?
https://github.com/Microsoft/vscode/issues/2123
Than my native language is Chinese, and vscode does not support encode detect without DOM header. so, I have to code an extension for encode detect, if both of them could not be supported, it will be a pity. your native language is English, perhaps you can not  feel the pain about the garbled.
If I have not reply in time, please email to me, ihuahua#live.com , # => @

This issue is currently assigned to the backlog. Every sprint we pick items from the backlog to plan for the current iteration. Please see https://github.com/Microsoft/vscode/wiki/Issue-Tracking#planning

@bpasero yeah, thanks very very much, I love vscode.

actually also a duplicate. first issue was #824

my god. it was been closed. i think the APIs has been provided in vscode 1.2. A half of my extension has been finished. T_T...


UniFi controller should adopt the certificate and hostname from pfsense

I have an automated way to do the certificate, likely the hostname is trivial.
Mostly looking for confirmation that this kind of integration is welcome.

I can speak for @gozoinks but I know that I'm very interested in this potential feature.

I have ACME installed on my pfSense box and a script that imports the Let's Encrypt cert into the UniFi controller - works like a charm. Setting Controller Hostname to the hostname of the pfSense box should be trivial indeed - actually if you run it on the same box, the only logical choice is to make it the same name.

Keeping the hostnames independent—specifically, keeping the UniFi controller hostname “unifi” — means new devices automatically discover and inform the controller. Leaving the UniFi controller  hostname at its default “unifi“ and the firewall hostname at its default “firewall”,  means everything works out of the box, and all the administrator has to do is add the hostnames to the DNS resolver. That seems logical to me.
In any case, this becomes a matter of preference or policy for a given network, and I’m not sure there is a benefit to changing hostnames for every installation.
Certificates, however, sure. Can your script generate a certificate for unifi.?

It could but there would be limited benefit since UniFi Controller will automatically install a self-signed certificate and the purpose of this is to automatically install a trusted certificate. We could consider something like let's encrypt but that generally requires that you are signing a publicly addressable hostname which I am not.
I didn't realize the discovery relied on the controller having that hostname - I wonder if we could handle that by automatically adding the record to pfsense's dns resolver. In any event, sounds like this is more complicated than I thought, while it worked well for me it may not be generally applicable.

actually if you run it on the same box, the only logical choice is to make it the same name

Why? I gave my controller a virtual IP and so it's not a problem with the own hostname. You could also just add a hostname to the resolver, but with a virtual IP you can even redirect the https port 443 to unifi's 8443 in the NAT settings and have a nice URL :)
But yes, I have a script for that like @dvdp , too. It run's right after a Let's Encrypt certificate was renewed, importing the new certificates and restarting my controller.

@xatage - you are absolutely right - my approach was just aiming at using the same IP and FQDN for pfSense and UniFi - works fine for me. Initially I created the cert for pfSense only so with just one domain, by using the same hostname for UniFi I did not need to create a new cert.
As for the discovery: I just added 'unifi' to the host overrides in the DNS Forwarder and set the IP to the IP of pfSense/UniFi box - devices are discovered nicely ....

Adding a 'unifi' record in DNS seems like a good idea.
I really like this line of discussion. Linking hostnames, certificates, and DNS records is a great way to make UniFi controller more seamlessly integrated with pfSense. I treat them as separate entities in my own installations, but I can totally see the value in treating them more as one, as a kind of DIY USG.
Doing that well involves UI for configuring the way UniFi controller and pfSense coexist.
But this brings me back to my notes in the README. The script here is portable to many BSD-based systems and requires no other infrastructure, running equally well on FreeNAS and plain old BSD. A pfSense GUI plugin depends on pfSense (and varies by version even), and developing that requires forking/branching the plugin repo. To me, therefore, the thing that makes sense is to fork the pfSense plugin repo to develop a pfSense package that provides a UI that bridges between pfSense and this script (or a package based on this script), or something to similar effect.
Otherwise, we run the risk of breaking compatibility with non-pfSense systems, introducing unexpected behavior, and adding the complexity of maintaining compatibility with third-party APIs.

To keep the compatibility with all systems, the script could detect if the system is indeed pfSense and do the certificate linking automatically but present a selection (where is your certificate file?) for other systems so that everyone can have the script at least automatically install the certificate into the controller.
This is super important for those running pfSense and Unifi on the same machine with HTTPS since pfSense sends HSTS headers and you can't access Unifi with an invalid certificate on the same hostname by default.

no updates since, closing for now


Add javaHome for building Java 11 and 17 multi-arch containers.

The previous builds failed due to a missing argument for Pjava${version}Home flag, add this flag in this PR.
Though building java8 doesn't need this flag, the extra (not working) Pjava8Home flag won't make the build fail.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

LGTM


Add permissions and usage utilities

What are you trying to accomplish?
Add a permissions system.
How are you accomplishing it?
Added config options for setting permission levels for roles (how permissive a role is) and features (how much permission is needed to use it). Added utility functions for the three basic queries: user permission level, feature permission level, and whether or not a user is allowed to use a feature. Compare function is greater-equal.
Is there anything reviewers should know?
Might not be a perfectly ideal setup, but the framework is there. Tested it on a private server using /pong and a pair of roles (one can use it and the other can't). Worked perfectly under all scenarios.
Serves as a potential fix to #47.

[x] Is it safe to rollback this change if anything goes wrong?

I have resolved the problems that I mentioned before


source dependencies from requirements.txt

Addresses #105.
This reads dependencies from the requirements.txt file and passes them to the install_requires argument in the setup.py.

amazing! thanks :-D


Quiet labels

I just found you gem and needed a minor change for it to be useful in my project. I am creating this PR in case you would find it useful too. Basicly I didn't want the labels that tools like Waffle add to issues in order to track the progress to show up on the printable card.
# Usage:
git2pdf gen -u user -r repo -q 'ready, in progress, done'

I should add that the reason I like this change is because I don't want to reprint the card just because it moves from ie. the ready column to the in-progress column


Fix CI installed version to not include commit offset

I thought that changing:
- LEGATEDATAFRAME_VERSION=$(rapids-version)
+ LEGATEDATAFRAME_VERSION="$(head -1 ./VERSION)"

in the docs build and test scripts when installing was a good idea to make things strict, but it seems like it is not actually safe (as noted by @jameslamb).
So, I should change it back (possibly also in one place in legate-dataframe).
A bit unclear if we need to build the .dev<N> version at all in that case, but maybe it is nice to just do it anyway.

Suspect this was copied from an old legate-dataframe issue? Here in legate-raft we never set the variable LEGATEDATAFRAME_VERSION in CI scripts.
I think it's referring to this:
https://github.com/rapidsai/legate-raft/blob/4f0afc1371fc734e87e0c4fbdce9e6f97d2c2c84/ci/test_python_common.sh#L16-L17
https://github.com/rapidsai/legate-raft/blob/4f0afc1371fc734e87e0c4fbdce9e6f97d2c2c84/ci/build_docs.sh#L9-L10
Some notes:

Using rapids-generate-version does not necessarily mean "including commit offsets"... for release builds (triggered by a tag matching the pattern ^v[0-9][0-9].[0-9][0-9].[0-9]$), the version number computed by that command will not have commit distance, e.g. it'd be 24.11.00, not something like 24.11.00.dev17
Yes, using rapids-generate-version in those scripts is unsafe. For non-release builds, it computes a version containing the tag distance (number of commits since last git tag) at runtime. That could return a different answer between package-build time and docs-build or testing time, e.g. if other PRs are merged in between those runs. We should be using doing what legate-boost does... using rapids-generate-version to update the VERSION file, but then always grepping out of it just the {major}.{minor}.{patch} part.

rapids-generate-version > ./VERSION
LEGATEBOOST_VERSION=$(rapids-version)

(legate-boost/ci/test_python_common.sh)
That has its own risks ... it could silently fall back to something else published on the legate conda channel instead of the downloaded packages built in the same CI run. That can be avoided with conda's "strict channel priority"... something that isn't guaranteed to work (yet) for dependency trees involving the rapidsai / rapidsai-nighly channels, but which hopefully will soon: https://github.com/rapidsai/build-planning/issues/84


Question on Scrapy

HI Michael,
I saw your youtube video on Scrappy  , I have one question regarding how can I save html data which we have crawled preserving all those links as it to mock a site locally ? I mean is it possible using scrapy preserving all navigation links of websites as it is locally (creating directory structure)

You should not use a scraper / crawler for this. Scrapers are best for grabbing specific data on a site. If you want the entire site,  then just download the entire thing with something like http://www.httrack.com/.


[FLINK-11155][fs][hadoop] Fix hadoop-free factory tests on Java 9

What is the purpose of the change
On Java 9 the default classloader is not a URLClassLoader, a behavior that we've been relying on so far.
This PR updates the hadoop-free (mapr) filesystem tests to instead use the ClassGraph library to determine the current classpath.

Looks correct, but it would be nice to solve this without another library.
This should work as well:
private static URL[] getClasspathURLs() {
	final String[] cp = System.getProperty("java.class.path").split(File.pathSeparator);

	return Arrays.stream(cp)
		.filter(str -> !str.isEmpty())
		.map(HadoopFreeFsFactoryTest::parse)
		.toArray(URL[]::new);
}

private static URL parse(String fileName) {
	try {
		return new File(fileName).toURI().toURL();
	} catch (MalformedURLException e) {
		throw new RuntimeException(e);
	}
}

That code could even go into a core util.

Updated the PR.


Make resource, groupchat and user names for the same user consistent

Version 0.3.20 now uses the username as the resource name. New change will be to use the XMPP nickname as the user name/label in Jitsi Meet web client like Candy does.

This work will be done properly in the 0.4.x branch


Enhancement: Support raw NSData, not just JSON

Having integrated the common code into a project in which I need to transmit binary data via NSData objects, the data is all being thrown away as the framework is expecting JSON only data.
I think, to be a truly useful, flexible framework it needs to support more than just JSON as a message package.

The framework only expects JSON data for authentication purposes. After that its left up to you to determine what kinds of data packets you want to send over. See the demo, we are sending plain text encoded with NSUTF8StringEncoding, there is no JSON. If you are reading no JSON read throwing away garbage data in the console before your code is actually calling sendData it means something is going wrong with the authentication flow.

What I do is wait for the connection state to become MGSessionStateConnected and then I send an NSData back to the peer.  The thing is that both ends will do the same thing when they connect so that they are basically telling the other peer about themselves.
When the receiver receives the NSData I get:
"No JSON found.
So yes I can see that it's using JSON for the initial connection and handshake, but I don't see it choosing to let the data through after that.
The Demo has some problems in that I couldn't get it to send text from one side to the other successfully.  I could see them connect, but no messages were displayed by the receiver if I typed into the other end.

What's probably happening is something like this:
Requestor ---------------- (requests connection) ----------------> Receiver ----> asks you for auth
Requestor <------------- (receives acceptance as JSON and extra "garbage" data together) ----- Receiver
So basically, before the requestor can receive the JSON that this has been accepted your data instance is "tacked" on before sending it to the requesting peer so it cannot parse the JSON. The easiest work around is probably to wait for a bit and send new data only after a couple of seconds after the MGSessionStateConnected is received. It chooses to let non JSON data through in the MGSession class after it has 'finalized' the connection. Hopefully, I can work around this so that this bug doesn't appear in the first non beta release of the framework.
As for the demo, you need to hit the return key for data to be sent over. It looks for the newline character and then sends the data over. I probably need to work on the demos a bit more to make them nicer but I have tested it and they do work (do not use it between the simulator and the mac) cause that may cause some problems but on an actual device and mac does work.

OK, that's a possibility.  I'll check that out and report back.  RE the demo, I'd tried that; I'll try again.  I had basically given up on the demo because of the problems with running it on iOS8.


Revert "Revert "Alpha pr for Migration""

Reverts OlympusDAO/olympus-frontend#873 & gets alpha from Saturday back on staging.

let's merge https://github.com/OlympusDAO/olympus-frontend/pull/884 before this one


Fail to clone environments/resources

Describe the bug

Steps to reproduce

Clone an environment with resources.

Clone a resource.

Check the result.

Result

No resources after cloning environment.

Cannot clone resources. No response.

Expected behavior

Environment

Walrus version: main c7fc65ae3ea5546452dd515722f9f0c0712c3e15
UI version: dev-61f3704

Additional context
Add any other context about the problem here.

Environment

Walrus version: main c7fc65ae3ea5546452dd515722f9f0c0712c3e15
UI version: dev-f0b97d5

Test Result: pass


Massive sound clipping

Sometimes when I use the browser's back button and press play, there is an extreme burst of noise. The noise was like a thunder of distortion, all instruments playing at once, shook my apartment and caused some ear bleeding.

Also, well, don't mean to be rude. The project is quite awesome especially considering you implemented the entire SoundFont spec in JavaScript and did it 6 years ago. 🙏

Actually I'm talking about this thing https://github.com/logue/smfplayer.js but I can't create issues there. Oh well 🤷♂


Support new ingress-nginx app

The name of nginx ingress app is changed. This PR adapts the operator so that it respects old&new app at the same time by using app.kubernetes.io/name label.
How I did test this PR

I deployed this version to my test MC.
I created a WC.
I deployed the old nginx-ingress-controller-app (2.30.1) and observed expected DNS records on route53.
I removed the old app. I removed all DNS records and hosted zone on route53.
I deployed the new ingress-nginx (3.0.0-beta1) and  observed expected DNS records on route53.

Note
We don't need to wait for anything to release this change. It is backward compatible. After this change, feel free to migrate nginx ingress apps in MCs and WCs.
Checklist

[x] Update changelog in CHANGELOG.md.

LGTM! Thanks a lot!
Hint: IMHO the migration to ingress-nginx should be done by the respective provider teams. But this can be discussed elsewhere.


Vite / TypeScript Configuration Overhaul

Related User Story

Related Tickets

Acceptance Criteria

In order to use client-side environment variables in Vite, our project must be configured to use ESM imports.
Our project is currently using ESM-style import statements. However, ESM is not enabled at the Node application level.
Enabling ESM breaks other parts of our configuration.
This may be resolved in splitting the client and server apps and their configurations.

Subtasks
<!-- If necessary, break down the ticket into smaller, actionable subtasks. Create issues accordingly.>

Completed with #223


IE/Edge browser support issues

Version
@nuxtjs/strapi: 0.3.0
nuxt: 2.14.12
Steps to reproduce
Open a Nuxt-Strapi app in IE/Edge in either Development or Production mode.
What is Expected?
For polyfills to kick in.
What is actually happening?
The app breaks completely and the only thing that's working is navigation.
Console shows an error that 0: Expected identifier, string or number
The issues happens here on line 22:

Is the Strapi module supported on older browsers? This is crucial for my current project.
For production it shows the same but the script's minified.

It needs to be transpiled for IE11 support. Unfortunately I've not had much success. So far I have in nuxt.config.js:
  build: {
    transpile: [
      ({ isLegacy }) => isLegacy && "@nuxtjs/strapi",
    ],
  }

If you're using the modern setting then this will transpile the strapi module for the legacy browsers.
The problem is that while it transpiles and gets past the first error, I now see Loading chunk 37 failed and IE can't load some chunk of JS related to Strapi. I've tried adding all the nuxt strapi dependencies to the transpile array but that doesn't change anything.


Sorting order

The current default sorting order is "script > style > html". My prefer sorting order is "html > style > script". Is there any option for that?

Added in v0.6.0, its called svelteSortOrder for your preference it would be
{
    "svelteSortOrder": "markup-styles-scripts"
}

I must be missing something obvious, but I added a .prettierrc to the root of my project and added:
{
  "svelteSortOrder": "scripts-markup-styles"
}

but VSCode is still formatting with the default sort order.

See this issue for vscode support. This was the first option added to the prettier plugin, so future options should probably work automatically in vscode once this is resolved.

Thanks @ryanatkn
Turns out I was missing something obvious - I had ESLint installed and that seemed to be messing with it. When I uninstalled that plugin, it started working with the .prettierrc I listed above.


Remove Person.webmaster property

This property is no longer actively used and future access rights will be provided through claudia groups. Thus is can be removed from the codebase.
Also see #668

Please look through the code thoroughly if this is still being used.


Menu open/close events not working

What package has an issue
@svelteuidev/core
A clear and concise description of what the bug is
The <Menu /> component events are not firing as expected.
<Menu on:open={()=>console.log('opened')}/>

Doesn't log anything when the menu is opened.
In which browser(s) did the problem occur?
Firefox
Steps To Reproduce
Make a component like this:
<Menu on:open={()=>console.log('opened')}/>

try opening the menu a few times with the browser console open.
Observe that nothing is logged.
Do you know how to fix the issue
No
Are you willing to participate in fixing this issue and create a pull request with the fix
Yes
Relevant Assets
I've made a storybook story to demonstrate the problem I'm facing:
https://github.com/mrbrianevans/svelteui/commit/7a62ea0ce353b4dc7eac87d5d3456747233ac021

I've looked into it briefly, and not been able to find what's causing the problem. Not sure if I'm even using the event handlers in the correct way. If anyone can point out the cause, I'm happy to contribute a fix.

Thank you @mrbrianevans. I'll investigate the events problem, it's probably a bug

Sorry, this got forgotten. I looked into it for a bit and it seems more complex that I though. For some reason the component callbacks are not being populated, so it appears like it does not have any callbacks to call on dispatch. I'll need to take some more time to identify the problem here

Fixed in new release 0.7.7


Extract metadata later

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix attempt.

Please check if the PR fulfills these requirements

[ ] E2E Tests for the changes have been added  via Cypress
[ ] Meaningful rspec tests have been added
[ ] Docs have been added / updated

What is the current behavior? (You can also link to an open issue here)

Upload of large files videos sometimes (#143). One reason maybe that metadata extractiontakes too long (especially when RAM is scarce) and causes a timeout.

What is the new behavior (if this is a feature change)?

This PR moves the extraction of video metadata to a sidekiq worker that is triggered only when the user saves the video.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

There is a warning, but I think this omit-able:
SHRINE WARNING: The "mime_type" Shrine metadata field will be set from the "Content-Type" request header, which might not hold the actual MIME type of the file. It is recommended to load the determine_mime_type plugin which determines MIME type from file content.

Furthermore, you might want reduce the number of ruby lint errors.


Add posthog component

What is this Contribution About?
This PR provides the posthog script and also allow it to listen deco events.
Issue Link
Please link to the relevant issue that this pull request addresses:

Issue: https://github.com/deco-cx/apps/issues/847

I think we should do that on a specific app to posthog like we talked.


feat(console): angular 15

With angular 15, our material design components break as the new code for MDC does not support dynamic css variables.
This PR now uses it's legacy components, which keeps the code as it was but is generating warnings as we don't use static variables for our color palette (SCSS is precompiled and has limited support for CSS variables).
In the long run, if custom design in console should be kept a feature, all material design components have to be replaced by own styled components or the design of the console should migrate to the new MDC components and downgrade to a static design.

you tell me when to look at this, right @peintnermax or does @eliobischof look into this?

This can be merged IMO 👍

It looks like the linter is failing
https://github.com/zitadel/zitadel/actions/runs/3738717221/jobs/6345093794#step:7:122

Btw. this feels to me not like a feat: instead i would prefer chore: or refactor:

Btw. this feels to me not like a feat: instead i would prefer chore: or refactor:

This explanation suggests, we should indeed increment the minor version: https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api

Btw. this feels to me not like a feat: instead i would prefer chore: or refactor:

AFAIU, this explanation suggests, we should indeed increment at least the patch version: https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api

Hm true, so it comes down to the question if it changes a feature or only fixes bugs 😁
Whats in it @peintnermax? Respecting the above it looks like fixes, right?

Fix suits the most 👍

@peintnermax the build is looking a little broken 😁 https://github.com/zitadel/zitadel/actions/runs/3739739211/jobs/6347298843#step:7:897

@peintnermax do we want to create a pre-release of this or are we confident?

My grep finds non-legacy imports, is that intended?

Thank you for the hint.. 👍This came from the merge with the main branch. I'd merge this as this will create additional conflicts in future too..

Just to be sure. The deletions are the legacy imports, right?

again? :-)

Just to be sure. The deletions are the legacy imports, right?

what do you mean? This PR changes imports to legacy as the new components are not supported by our label policy 🤔


Clean up ImageData (FINERACT-1201)

FINERACT-1201

Draft until I double check if the changes here are covered by an integration test.

Maybe it's not worth to have this small initial change as a separate PR.. probably simpler to "fold" this into the overall #1425.


cannot pass more than 3 parameters

hey i am not able to pass more than 3 parameters, its it related to coffee script ?

@ojacques yes maybe its a problem with apiai, im still not able to pass more than 3 parameters.

Just tested. It does work with more than 3 params

@ACBiggTasty have you tried passing parameters for two different intents? like first 3 parameters for intent A and rest of the 2 parameters for intent B, if the total parameters was 5.

Looks like it works for me. are you trying to pass two intents to the same function simultaneously?

@ACBiggTasty  can you show me your apiai.coffee code just want to see how are you emitting those parameters, i guess i have messed up with white spaces in the code, so im not able to pass more params


'Annotation' object has no attirubte 'annsamp'

Hi all --- I am trying to run the HMM segmentation in this notebook.

I came across the same issue, thanks for the explanation!

Hi!
It may take several hours to finish, depending on the size of your dataset and your hardware.


Diagnostic: Line Too Long feature broken

Hi, the recent addition of a diagnostic checking the line is over 80 characters is broken and is reporting lots of my lines have problems when they don't.
Disabling the feature in the settings still leaves the file marked as full of errors once the diagnostic has run over that file.
Take this line for example:
135 print "{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{right}{yellow}";
This is only 42 characters long once the control characters are converted, and the diagnostic is incorrectly marking it as over 80 characters.

Hi, thank you for this report. I fixed the problem. Now a control character only counts for one.


Need to sort out typings issues when updating all core dependencies

After doing a nuclear pnpm up --latest:
It works well with no regressions during runtime.
But sadly a lot of typings broke into havoc for major semver bumps.
I still have to wrap my head around various API changes for unified and friends deps. before publishing an update for this plugin, with 100% correct internal types.
I can't focus on this right now, but it's in my scope. As for now, this plugin is doing its duty, even with latest the remark versions.
In the meantime, any help will be appreciated!

Faulty deps. remaining:
 @types/mdast   3.0.13  →   4.0.1
 @types/unist    2.0.8  →   3.0.0
 unified        10.1.2  →  11.0.3
 vfile-message  ^3.1.4  →  ^4.0.2

Everything else has been upgraded.


Interactive mode

I would like to have a new parameter for Option: bool Interactive. When this is set to true, a delegate function will be called (which you need to pass in to the Parser somehow). This must happen BEFORE the check for required parameters is done. This will allow the developer to ask for the values interactively.
The return type of the delegate is object. When the delegate returns a non-null value, the value is assigned to the parameter (if the parameter is of a primitive type, the object is first cast to a nullable and the Value is used). When the delegate returns null, nothing happens and the Parser continues normally (possibly failing when the parameter was set to required).
The construction with the delegate ensures encapsulation (not an extra dependency on the console), and also gives the developer additional flexibility. But it's also fine if this is implemented as a simple method inside the parser, interacting with the console from CommandlineParser directly.
Either way, I think this would be a really helpful enhancement for many users of CommandLineParser.

Can you provide the suggested Delegate signature that you want to pass to Parser with pseudocode example.

While working out the details, I changed my mind slightly: the delegate must be a parameter to the OptionAttribute, not to the parser. After all, you may
want to have a different method to get the value for different parameters, as the example below shows.
Consider a simple MyOptions class, with only 2 properties: Username and Password (both string). Both are required (because the program cannot run without them). But the user has not supplied them.
The framework must be extended with a delegate as follows:
public delegate object GetParameter(OptionAttribute optionAttribute);
The BaseAttribute is enhanced with the following property:
public GetParameter ParamGetter { get; set; }
Somewhere inside the framework (not sure where, I haven't looked in detail at your code), there is probably some code that iterates over all the properties of the specified Options
object and the associated attribute:

   // iterate over all OptionAttributes and associated properties
   if (optionAttribute.ParamGetter != null)
   {
      var value = ParamGetter(optionAttribute);
      if (value != null)
      {
         // use this value for the current property
         // some type mapping must be done here because the delegate returns an object which must be converted to the
         // type of the property
      }
   }
}

The developer using CommandLineParser would use it like this:
public class MyOptions : Options
{
[Option("username", Required = true, HelpText = "Enter your username", ParamGetter = GetUsername)]
public string Username { get; set; }
[Option("password", Required = true, HelpText = "Enter your password", ParamGetter = GetPassword)]
public string Password { get; set; }
}
// ask the user to enter the username on the commandline
public object GetUsername(optionAttribute)
{
Console.WriteLine(optionAttribute.HelpText) + ":";
var username = Console.ReadLine();
return username;
}
// ask the user to enter the password on the commandline, hiding it from sight in case someone is watching
public object GetPassword(optionAttribute)
{
Console.WriteLine(optionAttribute.HelpText) + ":";
string pass = "";
do
{
ConsoleKeyInfo key = Console.ReadKey(true);
// Backspace Should Not Work
if (key.Key != ConsoleKey.Backspace && key.Key != ConsoleKey.Enter)
{
pass += key.KeyChar;
Console.Write("*");
}
else
{
if (key.Key == ConsoleKey.Backspace && pass.Length > 0)
{
pass = pass.Substring(0, (pass.Length - 1));
Console.Write("\b \b");
}
else if (key.Key == ConsoleKey.Enter)
{
break;
}
}
} while (true);
Console.WriteLine();
return pass;
}
Note: if it would be possible to use a delegate with a generic type argument, that would be even better. In that case, the developer could write a method with a specific return
type instead of the rather ugly 'object'.

I understand that you want parser can read input from keyboard at runtime for some arguments.

the delegate must be a parameter to the OptionAttribute

Delegate is not supported in Attributes, see attribute parameter types
Just a suggestion change for your design:
We can add a property to OptionAttribute like:
public bool EnableKeyboardInput {get;set}

When EnableKeyboardInput==true parser read the argument value.
KeyboardInput can  be a Built-in component to read user keyboard based on the true value of EnableKeyboardInput.
Question: How parser know that the argument is password protected?
[ ] Add other property to OptionAttribute like Secret : true/false
[ ] what is your suggestion?
Question: Do parser need to validate input keyboard: numeric /datetime or be relaxed?
Question: When to read arguments?
It can be read at the start of parsing based on the specs of options and arguments.
Question: what is the title (label) of input?
The title is the option shortname /or longname (user is not aware of the option property name).
E.g
Enter missing: -a
Enter missing values comma separated: --item-values
What is your suggestions based on the questions above?

I still investigate other solutions and I'll wait to listen from the community for other suggested solutions for this interactive feature.

@moh-hassan  I would like a integrated interactive mode, too. Regarding the detection of Password options: Why not identifying them by the type SecureString?

[Option("pass", Required = true, HelpText = "Enter your password")]
public SecureString Password { get; set; }

@moh-hassan  I would like a integrated interactive mode, too. Regarding the detection of Password options: Why not identifying them by the type SecureString?

[Option("pass", Required = true, HelpText = "Enter your password")]
public SecureString Password { get; set; }


openjdk: download from mercurial repository to GitHub

Reasons:

openjdk is migrating to GitHub (https://openjdk.java.net/jeps/369)
GitHub provides faster download speed that mercurial

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

/cc @NeQuissimus

LGTM, but you should probably migrate the other openjdk versions (8, 12, 13, 14) as well.  And then change the target branch to staging because that causes a lot of rebuilds.

I'm going to add the other files to this PR. Only Java 8 development stayed in mercurial. There're mirrors by AdoptOpenjdk but I wonder if we should use this for building upstream openjdk package.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/hash-mismatch-building-jre-on-release-20-09/9898/11

@asbachb

... Only Java 8 development stayed in mercurial.

I do see they have a tag for jdk8-b10: https://github.com/openjdk/jdk/tree/jdk8-b10. Can't we use that for openjdk-8?

@basvandijk from my understanding the repository contains code produced during intial development of first java 8 release. So I don't think that tag you mentioned reflects the current state nixpkgs is shipping now.

I'd suggest to merge this change for now and postpone the decision if we should migrate the others repo too after that topic gains some more traction: https://discourse.nixos.org/t/retirement-of-old-openjdk-releases/9929

Can you backport to 20.09 too, please?

Can you backport to 20.09 too, please?

2ce2f5a028e2302f29cf0efde499d7f10a1cc284


Firebase significantly contributes to iOS app launch time

Description
In Xcode Organizer in Xcode 16 beta we see Firebase is contributing 10 % to our app launch time, which is concerning.
Our custom measurements in production show the P90 for initialising Firebase SDK is 90 ms, P50 is 40 ms. We are using CocoaPods, but Firebase is statically linked.
These methods are responsible:

3 %: FIRCLSContextInitialize + 876 (130 ms spent in this code path during a 1792 ms launch)
2 %: __46+[APMAnalytics startWithAppID:origin:options:]_block_invoke + 1148 (90 ms spent in this code path during a 1220 ms launch)
2 %: +[APMAEU appStoreRURL] + 160 (90 ms spent in this code path during a 3528 ms launch)
1 %: -[APMUserDefaults objectForKey:] + 88 (90 ms spent in this code path during a 1186 ms launch)
1 %: -[FIRInstallationsAPIService initWithAPIKey:projectID:heartbeatLogger:] + 92 (60 ms spent in this code path during a 1830 ms launch)
1 %: APMIsScreenReportingEnabled + 28 (130 ms spent in this code path during a 2467 ms launch)

Might be related to https://github.com/firebase/firebase-ios-sdk/issues/13223.

Reproducing the issue
Open Xcode Organizer (Xcode 16 beta) Launch reports for any app with significant number of users and see the stats.
Firebase SDK Version
10.22
Xcode Version
16.0
Installation Method
CocoaPods
Firebase Product(s)
Crashlytics, Performance
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

  FirebaseABTesting: e6e3c3e0e35813874f571d1b7bdae2aab319dd38
  FirebaseAnalytics: 8d0ff929c63b7f72260f332b86ccf569776b75d3
  FirebaseCore: 0326ec9b05fbed8f8716cddbf0e36894a13837f7
  FirebaseCoreExtension: 8a47811d0b155501559ef05d089518152a0a1677
  FirebaseCoreInternal: 910a81992c33715fec9263ca7381d59ab3a750b7
  FirebaseCrashlytics: e568d68ce89117c80cddb04073ab9018725fbb8c
  FirebaseInstallations: 91950fe859846fff0fbd296180909dd273103b09
  FirebaseMessaging: 9f71037fd9db3376a4caa54e5a3949d1027b4b6e
  FirebasePerformance: 095debad1fc8d7d73148a835fcaec9e528946166
  FirebaseRemoteConfig: 9f3935cefecd85d5b312192117f444957de24a75
  FirebaseRemoteConfigInterop: b25018791b204c0d78a90e394d6c62d9b1f22da8
  FirebaseSessions: c0939656253a1fa0e94ecc266ccf770cc8b33732
  FirebaseSharedSwift:<PHONE_NUMBER>b1b2d5fd7e829eccc587044d72a4ba

10.27.0 addressed a startup time issue in Crashlytics that may be related to the top item in the list. Please update and let us know if the slowdown is still occurring.

We currently have 10.22.0 in production. When we tested the latest version (10.29.0) we were not able to see any improvements.

There is a new strack trace since we updated to Firebase 10.29.0:
-[RCNConfigDBManager loadInternalMetadataTable] + 160 (130 ms spent in this code path during a 1986 ms launch)
Our metrics show the Firebase init increased by 30 ms on iOS and 100 ms on tvOS due to this update.
We are not using RemoteConfig, it is automatically included as a dependency of FirebasePerformance.

@hsoi We are still on 10.29.0.
We did some app start optimizations on our side recently. Xcode Organizer Launch reports now show Firebase related stack traces are responsible for 56 % of slow app launches for our app, majority of it is FIRCLSContextInitialize call.
P90 for iOS and Apple TV Firebase configure call is around 180 ms.

@hsoi Do we have any update on this?

@sharanbasappa95 I'm not sure what update you're looking for from me - I'm just a user (still) affected by this issue too. Could you please clarify what you're looking for?

@hsoi wrongly tagged you instead of firebase team.

I'm using version 11.2.0, which still shows the Firebase SDK taking a lot of time to launch in xcode.
Has anyone tried using the latest version 11.6?


Fix line numbers for multiple files

This fixes the differences to the cat implementation for multiple files. See https://github.com/kyclark/command-line-rust/issues/9
Unfortunately, I haven't found a fix while still using enumerate. So, this kind of deviates from the text in the book.

This is a different implementation of cat that numbers all lines without resetting for each file. The version I was implementing starts over at 1 with each file. There's nothing wrong with this PR, and it fixes the test input nicely, but I was implementing a different program.

I found the same issue using the mk-outs.sh on my system.
Using the bash generator it generates 1..13 lines.
I'm using Fedora 38 with cat (GNU coreutils) 9.1.
Another solution is using bat, a cat replacement in rust. But it doesn't support -b, only -n.
So I think this is just the cat on MacOS that presents this behavior. There's a bsdcat on Fedora repo, but it doesn't supports any flags.


Listen for Client Side Events

Is it possible to listen for client side events?  I'd like to listen for an event that was fired on a page inside my Chrome instance and react accordingly.

See #167 and this wiki recipe. The general approach is to use Runtime.evaluate to wait for a promise:
await Runtime.evaluate({
    awaitPromise: true,
    expression: `new Promise((fulfill, reject) => {
        document.body.addEventListener('click', fulfill, {
            once: true
        });
    })`
});

@cyrus-and hello. I'm trying this code to wait for event and it always fails with message "Promise was collected" before event is fired.
Runtime.evaluate({
          awaitPromise: true,
          expression: `new Promise((fulfill, reject) => {
                        document.addEventListener('page_rendered', fulfill, {
                          once: true
                        });
                      })`
        }).then(() => {
          console.log('ok');
        }).catch((ex) => {
          console.log('fail', ex);
        });

@SkeLLLa take a look at this FAQ entry. If that doesn't solve your problem please file a new issue with all the details (that piece of code alone is not enough to explain the behavior).

Same problem. Any suggestion?


Add metrics for rate-limiter

It's interesting to have some insight into how the rate-limiter work with Redis. We might not need these metrics in the long run, but let's include them to see whether we can get some good data from them.
cc @wikimedia/services

Coverage decreased (-0.7%) to 89.093% when pulling 1d02619a3d19f83d90787202eb981f6dc529f6b5 on Pchelolo:limiter_monitoring into 7655e5775cb207401b80dbc546cdfe02ab7b17b3 on wikimedia:master.


Add run instructions to README.

These were provided to me by bashor.

There's a problem.  I have no out/production/ts2kt/ts2kt.js.

Thanks for the contribution!


Explain Playhead.reposition_

During live playback, the Playhead.reposition method prevents the user from scrubbing all the way back to 0 (AST). There's a comment in the code with a TODO to explain why, but no explanation is given.
Can you guys explain this?

When there is a seek, there are a number of cases that we may be in:  Live/on-demand, buffered/unbuffered, in-range/out-of-range, etc.. That TODO is about explaining how the code handles all those cases in the way that we want.  It is unrelated to your actual question.
In live streams, segments may not be available forever.  Usually they are only kept around for a set amount of time.  In DASH, this is specified using the timeShiftBufferDepth attribute.  This specifies an "availability window" for how long a segment is available on the server.  If the manifest only says segments will be available for 1 hour, then you can only seek backwards for 1 hour since older segments may have been deleted off the server.
You may want to look at shaka.media.PresentationTimeline, which defines which segments are available (Playhead enforces it).  Specifically, getSegmentAvailabilityStart and getSegmentAvailabilityDuration.

Ah, sorry -- I should have been more specific.
For live playback the code calculates a safe starting point by taking the earliest start, adding 1 second and the rebuffering goal. Assuming that safe region is inside the available window, it will add another 2 seconds to the targetTime.
Imagine a live manifest where the timeShiftBufferDepth is greater than or equal to the duration of the segments that are presented -- that is, the buffer is expanding, and not rolling. In this case, the first period starts at 0, and all of its segments are always available for playback, so getEarliestStart() returns 0. If the minBufferTime is set to 8, given the calculation above, the earliest that the user will be able to scrub to is 11 (8 + 2 + 1) -- this doesn't seem right to me, since those first 11 seconds are available and playable.
My questions are:

Why add 1 and 2 to the safe buffer region?
Why add the rebufferingGoal to the safe region?

It seems to me that rolling, or not, the beginning of the buffer (getEarliestStart()) should always be available on the server (ideally with some padding managed by the server), and that this calculation is superfluous.

Ok.  We could probably drop the 1, maybe the 2.  I'll need to discuss with the rest of the team.  Unfortunately the person that wrote it is no longer here and I'm a little fuzzy on the details of those.  This also needs to be adjusted for our (relatively) new in-progress recording support.
The reason we add rebufferingGoal is because we are unbuffered and we assume the window is moving.  So when we seek to that position, we will need to pause and wait for segments to be downloaded.  This can cause us to "fall" outside the availability window while we buffer.  To be safe, we add rebufferingGoal, which should be the amount of content that needs to be buffered to have seamless playback; therefore it should be a good approximation of the amount of time it will take to buffer enough.

Understood. I feel this conversation really comes down to getting a precise definition of timeShiftBufferDepth. My feeling is that liveEdge - TSB should represent the earliest possible time for which a segment request can start. If a segment falls outside of the TSB while a request for that segment is in progress, the server should not delete the segment.
On a more practical level, I guess I'm saying that the server should be responsible for making sure segments remain available for rebufferingGoal or at least segmentDuration after they expire. This does not feel like it should be the client's responsibility.

The expiration is calculated based on the end time of the segment.  So if liveEdge - TSBD is in the middle of a segment, that segment is still available.  It is only after liveEdge - TSBD passes the end time of the segment is that segment no longer available.
The problem on the client is that we have no way of knowing how long a segment remains available on the server, so it is the client's responsibility to enforce the availability window.  Now, we could allow playing content that we have already downloaded (e.g. the case where we "fall" outside the availability window while buffering); however, this can cause confusion for the users (especially with the seekable range).  This also breaks the intent of the TSBD, which is that the content is no longer available after that time, so we shouldn't play it.
We allow playing content that is near the earliest availability time, but so long as we are buffered so we don't fall outside the range while buffering.

Ok, I get where you're coming from here.
In the case where there is no duration (so this is not an IPR), but the back buffer is not (yet) rolling. It seems like we need to let the user scrub to the beginning in this case. What about adding a check to see if the overall availableDuration is less then the TSBD by more than the rebufferingGoal -- if that check passes, maybe we could just set safe = earliestStartTime?

You're right.  The problem is we adjust the availability start to 0.  After we adjust, we add rebufferingGoal.  What we should be doing is calculating the availability start, subtract rebufferingGoal, and then adjust to 0.  This will allow 0 to be considered "safe" so long as TSBD is far enough away.


Add Skill Checks

The Action Tray is very nicely formated but it seems to be missing the most common use of skill checks. Yes, you could roll a dexterity check, but not having a button that says Stealth Check adds an extra step for my players. Do you plan to integrate skills?

Thanks for the comment.
At this time, it is a conscious decision not to include skills here. I do have a separate module for that which I intend to release some time soon.


[Endpoints] RPC methods

Resources:

Figma
Stellar Developer Docs on RPC endpoint

Closing all released with some minor issues


[FEAT] Implement the Notification Box

Describe the feature
On clicking or hoverin on notification icon, a small notification block should appear which should display all the notifications to the user.
I would like to work on this feature under GSSoC, request you to assign this task to me
Add ScreenShots
similar to this:

Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@yashmandi
U have to complete asap.

I would like to work on this issue Can u please assign me this issue?


Random port mapping and warnings

There were some simple warnings associated with the objects passed that were fixed - I also added a patch to the 'Random port issue' https://github.com/kitematic/kitematic/issues/530
Port mapping settings view will also be updated shortly, as it's referencing the wrong object.

Thanks! Checking it out.

@TeckniX thank you!!
One small comment, then LGTM

DUH! forgot to remove some old comments - The restart is now streamlined through the ContainerAction, instead of the direct call - let me fix it

@TeckniX awesome! LGTM! Merging.


💡 RFC: Add support for autocompletion and type-checking for Content collections in MD and MDX files

Background & Motivation
When adding or editing a content entry (a Markdown (.md) or MDX (.mdx) file) from a content collection that has a collection schema, I would like VSCode to let me know when the frontmatter does not match the collection schema and help me fill the frontmatter based on the schema.
It should:

suggest or autocomplete the available frontmatter properties defined in the collection schema
(e.g., if I start typing sort I should get autocompletion for sortOrder because it is defined in the collection schema)

show errors if I type a frontmatter property that is not defined in the collection schema
(e.g., if I type undefinedField: true, because undefinedField is not defined in the schema)

show errors if I type a wrong type of value for a property
(e.g., if I type sortOrder: some text, because sortOrder should be a number)

show any missing frontmatter properties that are required by the collection schema
(e.g., if I forget to define the title property, and title is a required property in the schema, not optional)

Sample collection schema for the above examples:
const sampleCollection = defineCollection({
  schema: z.object({
    title: z.string(),
    sortOrder: z.number(),
    …
  }),
});

Proposed Solution
Possible solutions
Using an existing Markdown/MDX linting extension and adding the Astro content collection checks?
Alternatives considered
Switch to the browser to see any content collection schema errors in the new Error Overlay, then open the misbehaving content entry in VSCode, fix the issue, save, and repeat. But this can be a tedious process, especially after importing a large number of content entries that need fixing.
Risks, downsides, and/or tradeoffs
None that I can see
Open Questions
N/A
Detailed Design
No response
Help make it happen!

[ ] I am willing to submit a PR to implement this change.
[ ] I am willing to submit a PR to implement this change, but would need some guidance.
[ ] I am not willing to submit a PR to implement this change.

A code action to add all the properties to the front matter would be freaking huge


Console error message when window resized, IE only

I am using DataTables v1.10.10 with scrollY turned on.
The issue I am having is when DataTable().columns.adjust() is called and then a new table is loaded via jQuery, when the browser window is resized I get th e following error message in the console.
Unable to get property 'style' of undefined or null reference
The error only occurs in IE.
I have created a jsFiddle to recreate the issue https://jsfiddle.net/ajw89/3b8swp0v/
I have traced the issue back and it seems to have been introduced at v1.10.5.  Within _fnCalculateColumnWidths() it is binding a resize event onto the window for each table.  This event is not being removed so when I destroy the table then initialise a new table with the same ID, it will have 2 resize events bound to it.  When the window is resized the settings must be corrupt for the table that has been destroyed because it can't get the table headers.
If I run the following code prior to initialising the DataTable everything works as expected .
$(window).unbind("resize.DT-"+table_id);

The problem here is that you can't just remove the table by overwriting it in the DOM using $().html(). The DataTable instance will still exist, even if the table doesn't in the DOM - indeed this is a sure fire way of getting a memory leak on the page.
So what is happening is that the window resize event listener for the original table is still triggering (which you really don't want!). The "fix" is to destroy the old table which you can to with the destroy() API method: https://jsfiddle.net/3b8swp0v/5/


How to use similar type for redux state and react state

Hello.
I have a type:
type Patient = {
  id: number,
  name: string
};

I use this type in Redux's reducers, for example:
// My patients reducer
function patients(state: Array<?Patient> = [], action: Object) { ... }

I also need to use this type in a Form component I use to insert patients. Just like:
class Form extends Component {
  state: Patient
  constructor(props) {
    super(props);
    this.state = {
      id: 0,
      name: '',
      errors: {}
    }
  // ...
}

Of course this don't work because Patient type has no errors property. Just like flux says:
property `errors` of object literal Property not found in Patient

But I don't want to create another type for the Form's state with the same id and name properties plus the errors property. I want to somehow extend the Patient type to use in the Form state but keeping the errors property.
I had a research in the web and found that maybe interfaces can suit my needs, but if I try to declare the Patient type as an interface, the same error occurs.
Is there some technique to do that?

I presume that because this is a form of some sort that that's the reason you're not just reading the Patient stuff off the component props.
You could put the Patient object in a prop on the Component's state:
type OwnState = {
  patient: Patient,
  // or whatever type your `errors` prop has.
  errors: { [errorName: string]: string }
};

class Form extends Component {
  state: OwnState
  constructor(props) {
    super(props);
    this.state = {
      patient: {
        id: 0,
        name: '',
      },
      errors: {}
    }
  // ...
}

Though that presumes you're not using something which expects those props to be directly on this.state.
Failing that, does the & (Intersection) op work?
type OwnState = Patient & {
  // or whatever type your `errors` prop has.
  errors: { [errorName: string]: string }
};

class Form extends Component {
  state: OwnState
  constructor(props) {
    super(props);
    this.state = {
      id: 0,
      name: '',
      errors: {}
    }
  // ...
}


fix problem in player.findYakuman()

The new TenhoTest shows the problem : in findYakuman(), when the hands.getMentsuCompSet() > 1, each mentsuComp add to yakumanStock, but yakumanStock doesn't cleared in the next iteration. As the result, the final yakumanList.size > 1.
Fix: clear/recreate the yakumanStock in each iteration. just like in findNormalYaku().

LGTM!
Thank you for your bug fix


Remove Added Role Message

Hello! First time contributing here, I did have a quick check but I may have missed it, I couldn't seem to find a way to turn off the private message from the bot alerting you that you have added a role. Within my server members can add multiple roles to for them to receive multiple messages from the bot can be quite annoying for some. Is there a way to turn off this message?
Thanks!
Rob

You can do that using the -nodm flag, as stated in the documentation, e.g:
-rolemenu create <groupname> -nodm.
This will still DM error messages, but disable confirmation DMs.

Next time, please use the support server, thanks in advance!

My apologies I had completely missed that part of the documentation entirely (rookie mistake) Thank you very much for the assistance there!