engine_rocks: use tikv logger for rocksdb info log

Signed-off-by: Wangweizhen<EMAIL_ADDRESS>
What problem does this PR solve?
Move rocksdb info log to store and rotate as tikv log
UCP #6496
What's Changed:
add rocksdb-log configure
Check List
Tests

Manual test

Release note

RocksDB info log use the same rotating logic as TiKV info log.

Working in process. if completed, I will remove the WIP tag

@hawkingrei Do you mind list what's remaining to be done and how's your availability? I would like to get this done so if you are not available I can pick up what's left. In that case I'll check if full or partial score can be credited. Thanks.

[ ] Getting rid of valist. and refactor the logger interface to inject the string to log
[ ] Fix the error of configure.

thread 'config::test_toml_serde' panicked at 'called `Result::unwrap()` on an `Err` value: ValueAfterTable', src/libcore/result.rs:1188:5

[] Test the log outputting

Now, All Green.But I changed the source of rocksdb to my repo. So waiting for tikv/rust-rocksdb#482 merged

I have done some manual test.
1、set the log-info and rocksdb's info-log-dir
log-file = "/home/vagrant/devel/opensource/log/tikv.log"

[rocksdb]
info-log-dir = "/home/vagrant/devel/opensource/log/rocksdb/rocksdb.log"

it will write the tikv's and rocksdb' log into different file. rocksdb log file look like this.
[2020/05/06 06:05:47.546 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>546098, \"cf_name\": \"raft\", \"job\": 3, \"event\": \"table_file_creation\", \"file_number\": 66, \"file_size\": 917, \"table_properties\": {\"data_size\": 86, \"index_size\": 37, \"index_partitions\": 0, \"top_level_index_size\": 0, \"index_key_is_user_key\": 0, \"index_value_is_delta_encoded\": 0, \"filter_size\": 0, \"raw_key_size\": 38, \"raw_average_key_size\": 19, \"raw_value_size\": 30, \"raw_average_value_size\": 15, \"num_data_blocks\": 1, \"num_entries\": 2, \"num_deletions\": 0, \"num_merge_operands\": 0, \"num_range_deletions\": 0, \"format_version\": 0, \"fixed_key_len\": 0, \"filter_policy\": \"rocksdb.BuiltinBloomFilter\", \"column_family_name\": \"raft\", \"column_family_id\": 3, \"comparator\": \"leveldb.BytewiseComparator\", \"merge_operator\": \"nullptr\", \"prefix_extractor_name\": \"NoopSliceTransform\", \"property_collectors\": \"[]\", \"compression\": \"NoCompression\", \"compression_options\": \"window_bits=-14; level=32767; strategy=0; max_dict_bytes=0; zstd_max_train_bytes=0; enabled=0; \", \"creation_time\":<PHONE_NUMBER>, \"oldest"]
[2020/05/06 06:05:47.546 +00:00] [INFO] [logger.rs:12] ["[db/db_impl/db_impl.cc:702] ------- PERSISTING STATS -------"]
[2020/05/06 06:05:47.546 +00:00] [INFO] [logger.rs:12] ["[db/db_impl/db_impl.cc:764] [Pre-GC] In-memory stats history size: 48 bytes, slice count: 0"]
[2020/05/06 06:05:47.546 +00:00] [INFO] [logger.rs:12] ["[db/db_impl/db_impl.cc:773] [Post-GC] In-memory stats history size: 48 bytes, slice count: 0"]
[2020/05/06 06:05:47.547 +00:00] [INFO] [logger.rs:12] ["[db/compaction/compaction_job.cc:1392] [raft] [JOB 3] Compacted 1@0 + 1@6 files to L6 => 917 bytes"]
[2020/05/06 06:05:47.547 +00:00] [WARN] [logger.rs:14] ["[db/version_set.cc:3182] More existing levels in DB than needed. max_bytes_for_level_multiplier may not be guaranteed."]
[2020/05/06 06:05:47.548 +00:00] [INFO] [logger.rs:12] ["(Original Log Time 2020/05/06-06:05:47.548566) [db/compaction/compaction_job.cc:746] [raft] compacted to: base level 6 level multiplier 10.00 max bytes base 134217728 files[0 0 0 0 0 0 1] max score 0.00, MB/sec: 0.8 rd, 0.4 wr, level 6, files in(1, 1) out(1) MB in(0.0, 0.0) out(0.0), read-write-amplify(2.9) write-amplify(0.9) OK, records in: 3, records dropped: 1 output_compression: NoCompression\n"]
[2020/05/06 06:05:47.548 +00:00] [INFO] [logger.rs:12] ["(Original Log Time 2020/05/06-06:05:47.548575) EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>548571, \"job\": 3, \"event\": \"compaction_finished\", \"compaction_time_micros\": 2274, \"compaction_time_cpu_micros\": 842, \"output_level\": 6, \"num_output_files\": 1, \"total_output_size\": 917, \"num_input_records\": 3, \"num_output_records\": 2, \"num_subcompactions\": 1, \"output_compression\": \"NoCompression\", \"num_single_delete_mismatches\": 0, \"num_single_delete_fallthrough\": 0, \"lsm_state\": [0, 0, 0, 0, 0, 0, 1]}"]
[2020/05/06 06:05:47.548 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>548777, \"job\": 3, \"event\": \"table_file_deletion\", \"file_number\": 62}"]
[2020/05/06 06:05:47.548 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>548819, \"job\": 3, \"event\": \"table_file_deletion\", \"file_number\": 59}"]

2、set the tikv's log but not set rocksdb's log. rocksdb's and tikv's log will write into tikv's log.The tikv's log look like this.
[2020/05/06 06:08:15.702 +00:00] [INFO] [logger.rs:12] ["[db/db_impl/db_impl.cc:702] ------- PERSISTING STATS -------"]
[2020/05/06 06:08:15.702 +00:00] [INFO] [logger.rs:12] ["[db/db_impl/db_impl.cc:764] [Pre-GC] In-memory stats history size: 48 bytes, slice count: 0"]
[2020/05/06 06:08:15.702 +00:00] [INFO] [logger.rs:12] ["[db/db_impl/db_impl.cc:773] [Post-GC] In-memory stats history size: 48 bytes, slice count: 0"]
[2020/05/06 06:08:15.704 +00:00] [INFO] [logger.rs:12] ["[db/compaction/compaction_job.cc:1327] [raft] [JOB 3] Generated table #73: 2 keys, 917 bytes"]
[2020/05/06 06:08:15.704 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>704231, \"cf_name\": \"raft\", \"job\": 3, \"event\": \"table_file_creation\", \"file_number\": 73, \"file_size\": 917, \"table_properties\": {\"data_size\": 86, \"index_size\": 37, \"index_partitions\": 0, \"top_level_index_size\": 0, \"index_key_is_user_key\": 0, \"index_value_is_delta_encoded\": 0, \"filter_size\": 0, \"raw_key_size\": 38, \"raw_average_key_size\": 19, \"raw_value_size\": 30, \"raw_average_value_size\": 15, \"num_data_blocks\": 1, \"num_entries\": 2, \"num_deletions\": 0, \"num_merge_operands\": 0, \"num_range_deletions\": 0, \"format_version\": 0, \"fixed_key_len\": 0, \"filter_policy\": \"rocksdb.BuiltinBloomFilter\", \"column_family_name\": \"raft\", \"column_family_id\": 3, \"comparator\": \"leveldb.BytewiseComparator\", \"merge_operator\": \"nullptr\", \"prefix_extractor_name\": \"NoopSliceTransform\", \"property_collectors\": \"[]\", \"compression\": \"NoCompression\", \"compression_options\": \"window_bits=-14; level=32767; strategy=0; max_dict_bytes=0; zstd_max_train_bytes=0; enabled=0; \", \"creation_time\":<PHONE_NUMBER>, \"oldest"]
[2020/05/06 06:08:15.705 +00:00] [INFO] [logger.rs:12] ["[db/compaction/compaction_job.cc:1392] [raft] [JOB 3] Compacted 1@0 + 1@6 files to L6 => 917 bytes"]
[2020/05/06 06:08:15.705 +00:00] [WARN] [logger.rs:14] ["[db/version_set.cc:3182] More existing levels in DB than needed. max_bytes_for_level_multiplier may not be guaranteed."]
[2020/05/06 06:08:15.707 +00:00] [INFO] [logger.rs:12] ["(Original Log Time 2020/05/06-06:08:15.707090) [db/compaction/compaction_job.cc:746] [raft] compacted to: base level 6 level multiplier 10.00 max bytes base 134217728 files[0 0 0 0 0 0 1] max score 0.00, MB/sec: 0.6 rd, 0.3 wr, level 6, files in(1, 1) out(1) MB in(0.0, 0.0) out(0.0), read-write-amplify(2.9) write-amplify(0.9) OK, records in: 3, records dropped: 1 output_compression: NoCompression\n"]
[2020/05/06 06:08:15.707 +00:00] [INFO] [logger.rs:12] ["(Original Log Time 2020/05/06-06:08:15.707101) EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>707097, \"job\": 3, \"event\": \"compaction_finished\", \"compaction_time_micros\": 3381, \"compaction_time_cpu_micros\": 621, \"output_level\": 6, \"num_output_files\": 1, \"total_output_size\": 917, \"num_input_records\": 3, \"num_output_records\": 2, \"num_subcompactions\": 1, \"output_compression\": \"NoCompression\", \"num_single_delete_mismatches\": 0, \"num_single_delete_fallthrough\": 0, \"lsm_state\": [0, 0, 0, 0, 0, 0, 1]}"]
[2020/05/06 06:08:15.707 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>707732, \"job\": 3, \"event\": \"table_file_deletion\", \"file_number\": 69}"]
[2020/05/06 06:08:15.707 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>707776, \"job\": 3, \"event\": \"table_file_deletion\", \"file_number\": 66}"]
[2020/05/06 06:08:15.735 +00:00] [INFO] [mod.rs:172] ["Storage started."]
[2020/05/06 06:08:15.736 +00:00] [INFO] [mod.rs:332] ["starting working thread"] [worker=split-check]
[2020/05/06 06:08:15.737 +00:00] [INFO] [node.rs:160] ["put store to PD"] [store="id: 1 address: \"<IP_ADDRESS>:20160\" version: \"4.1.0-alpha\" status_address: \"<IP_ADDRESS>:20180\" git_hash: \"256a3648fc04bf1e7f49bbaa0e6577df0add1cd0\" start_timestamp:<PHONE_NUMBER> deploy_path: \"/home/vagrant/devel/opensource/tikv/target/release\""]
[2020/05/06 06:08:15.740 +00:00] [INFO] [node.rs:236] ["initializing replication mode"] [store_id=1] [status=]
[2020/05/06 06:08:15.741 +00:00] [INFO] [node.rs:383] ["start raft store thread"] [store_id=1]
[2020/05/06 06:08:15.741 +00:00] [INFO] [peer.rs:150] ["create peer"] [peer_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:809] ["became follower at term 14"] [term=14] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:288] [newRaft] [peers="[(3, Progress { matched: 14, next_idx: 15, state: Probe, paused: false, pending_snapshot: 0, pending_request_snapshot: 0, recent_active: false, ins: Inflights { start: 0, count: 0, buffer: [] } })]"] ["last term"=14] ["last index"=14] [applied=14] [commit=14] [term=14] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raw_node.rs:222] ["RawNode created with id 3."] [id=3] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:1203] ["starting a new election"] [term=14] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:859] ["became pre-candidate at term 14"] [term=14] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:928] ["3 received message from 3"] [term=14] [msg=MsgRequestPreVote] [from=3] [id=3] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:833] ["became candidate at term 15"] [term=15] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:928] ["3 received message from 3"] [term=15] [msg=MsgRequestVote] [from=3] [id=3] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:900] ["became leader at term 15"] [term=15] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [store.rs:860] ["start store"] [takes=184.215µs] [merge_count=0] [applying_count=0] [tombstone_count=0] [region_count=1] [store_id=1]

not set any log. both of them will write into stdout.

[2020/05/06 06:10:10.266 +00:00] [INFO] [logger.rs:12] ["[db/compaction/compaction_job.cc:1392] [raft] [JOB 3] Compacted 1@0 + 1@6 files to L6 => 917 bytes"]
[2020/05/06 06:10:10.266 +00:00] [WARN] [logger.rs:14] ["[db/version_set.cc:3182] More existing levels in DB than needed. max_bytes_for_level_multiplier may not be guaranteed."]
[2020/05/06 06:10:10.268 +00:00] [INFO] [logger.rs:12] ["(Original Log Time 2020/05/06-06:10:10.267852) [db/compaction/compaction_job.cc:746] [raft] compacted to: base level 6 level multiplier 10.00 max bytes base 134217728 files[0 0 0 0 0 0 1] max score 0.00, MB/sec: 0.7 rd, 0.3 wr, level 6, files in(1, 1) out(1) MB in(0.0, 0.0) out(0.0), read-write-amplify(2.9) write-amplify(0.9) OK, records in: 3, records dropped: 1 output_compression: NoCompression\n"]
[2020/05/06 06:10:10.268 +00:00] [INFO] [logger.rs:12] ["(Original Log Time 2020/05/06-06:10:10.267862) EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>267858, \"job\": 3, \"event\": \"compaction_finished\", \"compaction_time_micros\": 2726, \"compaction_time_cpu_micros\": 879, \"output_level\": 6, \"num_output_files\": 1, \"total_output_size\": 917, \"num_input_records\": 3, \"num_output_records\": 2, \"num_subcompactions\": 1, \"output_compression\": \"NoCompression\", \"num_single_delete_mismatches\": 0, \"num_single_delete_fallthrough\": 0, \"lsm_state\": [0, 0, 0, 0, 0, 0, 1]}"]
[2020/05/06 06:10:10.268 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>268135, \"job\": 3, \"event\": \"table_file_deletion\", \"file_number\": 76}"]
[2020/05/06 06:10:10.268 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>268204, \"job\": 3, \"event\": \"table_file_deletion\", \"file_number\": 73}"]
[2020/05/06 06:10:10.296 +00:00] [INFO] [mod.rs:172] ["Storage started."]
[2020/05/06 06:10:10.297 +00:00] [INFO] [mod.rs:332] ["starting working thread"] [worker=split-check]
[2020/05/06 06:10:10.298 +00:00] [INFO] [node.rs:160] ["put store to PD"] [store="id: 1 address: \"<IP_ADDRESS>:20160\" version: \"4.1.0-alpha\" status_address: \"<IP_ADDRESS>:20180\" git_hash: \"256a3648fc04bf1e7f49bbaa0e6577df0add1cd0\" start_timestamp:<PHONE_NUMBER> deploy_path: \"/home/vagrant/devel/opensource/tikv/target/release\""]
[2020/05/06 06:10:10.300 +00:00] [INFO] [node.rs:236] ["initializing replication mode"] [store_id=1] [status=]
[2020/05/06 06:10:10.300 +00:00] [INFO] [node.rs:383] ["start raft store thread"] [store_id=1]
[2020/05/06 06:10:10.301 +00:00] [INFO] [peer.rs:150] ["create peer"] [peer_id=3] [region_id=2]

not set any log. both of them will write into stdout.

[2020/05/06 06:10:10.266 +00:00] [INFO] [logger.rs:12] ["[db/compaction/compaction_job.cc:1392] [raft] [JOB 3] Compacted 1@0 + 1@6 files to L6 => 917 bytes"]
[2020/05/06 06:10:10.266 +00:00] [WARN] [logger.rs:14] ["[db/version_set.cc:3182] More existing levels in DB than needed. max_bytes_for_level_multiplier may not be guaranteed."]
[2020/05/06 06:10:10.268 +00:00] [INFO] [logger.rs:12] ["(Original Log Time 2020/05/06-06:10:10.267852) [db/compaction/compaction_job.cc:746] [raft] compacted to: base level 6 level multiplier 10.00 max bytes base 134217728 files[0 0 0 0 0 0 1] max score 0.00, MB/sec: 0.7 rd, 0.3 wr, level 6, files in(1, 1) out(1) MB in(0.0, 0.0) out(0.0), read-write-amplify(2.9) write-amplify(0.9) OK, records in: 3, records dropped: 1 output_compression: NoCompression\n"]
[2020/05/06 06:10:10.268 +00:00] [INFO] [logger.rs:12] ["(Original Log Time 2020/05/06-06:10:10.267862) EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>267858, \"job\": 3, \"event\": \"compaction_finished\", \"compaction_time_micros\": 2726, \"compaction_time_cpu_micros\": 879, \"output_level\": 6, \"num_output_files\": 1, \"total_output_size\": 917, \"num_input_records\": 3, \"num_output_records\": 2, \"num_subcompactions\": 1, \"output_compression\": \"NoCompression\", \"num_single_delete_mismatches\": 0, \"num_single_delete_fallthrough\": 0, \"lsm_state\": [0, 0, 0, 0, 0, 0, 1]}"]
[2020/05/06 06:10:10.268 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>268135, \"job\": 3, \"event\": \"table_file_deletion\", \"file_number\": 76}"]
[2020/05/06 06:10:10.268 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>268204, \"job\": 3, \"event\": \"table_file_deletion\", \"file_number\": 73}"]
[2020/05/06 06:10:10.296 +00:00] [INFO] [mod.rs:172] ["Storage started."]
[2020/05/06 06:10:10.297 +00:00] [INFO] [mod.rs:332] ["starting working thread"] [worker=split-check]
[2020/05/06 06:10:10.298 +00:00] [INFO] [node.rs:160] ["put store to PD"] [store="id: 1 address: \"<IP_ADDRESS>:20160\" version: \"4.1.0-alpha\" status_address: \"<IP_ADDRESS>:20180\" git_hash: \"256a3648fc04bf1e7f49bbaa0e6577df0add1cd0\" start_timestamp:<PHONE_NUMBER> deploy_path: \"/home/vagrant/devel/opensource/tikv/target/release\""]
[2020/05/06 06:10:10.300 +00:00] [INFO] [node.rs:236] ["initializing replication mode"] [store_id=1] [status=]
[2020/05/06 06:10:10.300 +00:00] [INFO] [node.rs:383] ["start raft store thread"] [store_id=1]
[2020/05/06 06:10:10.301 +00:00] [INFO] [peer.rs:150] ["create peer"] [peer_id=3] [region_id=2]

@yiwu-arbug PTAL

2、set the tikv's log but not set rocksdb's log. rocksdb's and tikv's log will write into tikv's log.The tikv's log look like this.
[2020/05/06 06:08:15.702 +00:00] [INFO] [logger.rs:12] ["[db/db_impl/db_impl.cc:702] ------- PERSISTING STATS -------"]
[2020/05/06 06:08:15.702 +00:00] [INFO] [logger.rs:12] ["[db/db_impl/db_impl.cc:764] [Pre-GC] In-memory stats history size: 48 bytes, slice count: 0"]
[2020/05/06 06:08:15.702 +00:00] [INFO] [logger.rs:12] ["[db/db_impl/db_impl.cc:773] [Post-GC] In-memory stats history size: 48 bytes, slice count: 0"]
[2020/05/06 06:08:15.704 +00:00] [INFO] [logger.rs:12] ["[db/compaction/compaction_job.cc:1327] [raft] [JOB 3] Generated table #73: 2 keys, 917 bytes"]
[2020/05/06 06:08:15.704 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>704231, \"cf_name\": \"raft\", \"job\": 3, \"event\": \"table_file_creation\", \"file_number\": 73, \"file_size\": 917, \"table_properties\": {\"data_size\": 86, \"index_size\": 37, \"index_partitions\": 0, \"top_level_index_size\": 0, \"index_key_is_user_key\": 0, \"index_value_is_delta_encoded\": 0, \"filter_size\": 0, \"raw_key_size\": 38, \"raw_average_key_size\": 19, \"raw_value_size\": 30, \"raw_average_value_size\": 15, \"num_data_blocks\": 1, \"num_entries\": 2, \"num_deletions\": 0, \"num_merge_operands\": 0, \"num_range_deletions\": 0, \"format_version\": 0, \"fixed_key_len\": 0, \"filter_policy\": \"rocksdb.BuiltinBloomFilter\", \"column_family_name\": \"raft\", \"column_family_id\": 3, \"comparator\": \"leveldb.BytewiseComparator\", \"merge_operator\": \"nullptr\", \"prefix_extractor_name\": \"NoopSliceTransform\", \"property_collectors\": \"[]\", \"compression\": \"NoCompression\", \"compression_options\": \"window_bits=-14; level=32767; strategy=0; max_dict_bytes=0; zstd_max_train_bytes=0; enabled=0; \", \"creation_time\":<PHONE_NUMBER>, \"oldest"]
[2020/05/06 06:08:15.705 +00:00] [INFO] [logger.rs:12] ["[db/compaction/compaction_job.cc:1392] [raft] [JOB 3] Compacted 1@0 + 1@6 files to L6 => 917 bytes"]
[2020/05/06 06:08:15.705 +00:00] [WARN] [logger.rs:14] ["[db/version_set.cc:3182] More existing levels in DB than needed. max_bytes_for_level_multiplier may not be guaranteed."]
[2020/05/06 06:08:15.707 +00:00] [INFO] [logger.rs:12] ["(Original Log Time 2020/05/06-06:08:15.707090) [db/compaction/compaction_job.cc:746] [raft] compacted to: base level 6 level multiplier 10.00 max bytes base 134217728 files[0 0 0 0 0 0 1] max score 0.00, MB/sec: 0.6 rd, 0.3 wr, level 6, files in(1, 1) out(1) MB in(0.0, 0.0) out(0.0), read-write-amplify(2.9) write-amplify(0.9) OK, records in: 3, records dropped: 1 output_compression: NoCompression\n"]
[2020/05/06 06:08:15.707 +00:00] [INFO] [logger.rs:12] ["(Original Log Time 2020/05/06-06:08:15.707101) EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>707097, \"job\": 3, \"event\": \"compaction_finished\", \"compaction_time_micros\": 3381, \"compaction_time_cpu_micros\": 621, \"output_level\": 6, \"num_output_files\": 1, \"total_output_size\": 917, \"num_input_records\": 3, \"num_output_records\": 2, \"num_subcompactions\": 1, \"output_compression\": \"NoCompression\", \"num_single_delete_mismatches\": 0, \"num_single_delete_fallthrough\": 0, \"lsm_state\": [0, 0, 0, 0, 0, 0, 1]}"]
[2020/05/06 06:08:15.707 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>707732, \"job\": 3, \"event\": \"table_file_deletion\", \"file_number\": 69}"]
[2020/05/06 06:08:15.707 +00:00] [INFO] [logger.rs:12] ["EVENT_LOG_v1 {\"time_micros\":<PHONE_NUMBER>707776, \"job\": 3, \"event\": \"table_file_deletion\", \"file_number\": 66}"]
[2020/05/06 06:08:15.735 +00:00] [INFO] [mod.rs:172] ["Storage started."]
[2020/05/06 06:08:15.736 +00:00] [INFO] [mod.rs:332] ["starting working thread"] [worker=split-check]
[2020/05/06 06:08:15.737 +00:00] [INFO] [node.rs:160] ["put store to PD"] [store="id: 1 address: \"<IP_ADDRESS>:20160\" version: \"4.1.0-alpha\" status_address: \"<IP_ADDRESS>:20180\" git_hash: \"256a3648fc04bf1e7f49bbaa0e6577df0add1cd0\" start_timestamp:<PHONE_NUMBER> deploy_path: \"/home/vagrant/devel/opensource/tikv/target/release\""]
[2020/05/06 06:08:15.740 +00:00] [INFO] [node.rs:236] ["initializing replication mode"] [store_id=1] [status=]
[2020/05/06 06:08:15.741 +00:00] [INFO] [node.rs:383] ["start raft store thread"] [store_id=1]
[2020/05/06 06:08:15.741 +00:00] [INFO] [peer.rs:150] ["create peer"] [peer_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:809] ["became follower at term 14"] [term=14] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:288] [newRaft] [peers="[(3, Progress { matched: 14, next_idx: 15, state: Probe, paused: false, pending_snapshot: 0, pending_request_snapshot: 0, recent_active: false, ins: Inflights { start: 0, count: 0, buffer: [] } })]"] ["last term"=14] ["last index"=14] [applied=14] [commit=14] [term=14] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raw_node.rs:222] ["RawNode created with id 3."] [id=3] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:1203] ["starting a new election"] [term=14] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:859] ["became pre-candidate at term 14"] [term=14] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:928] ["3 received message from 3"] [term=14] [msg=MsgRequestPreVote] [from=3] [id=3] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:833] ["became candidate at term 15"] [term=15] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:928] ["3 received message from 3"] [term=15] [msg=MsgRequestVote] [from=3] [id=3] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [raft.rs:900] ["became leader at term 15"] [term=15] [raft_id=3] [region_id=2]
[2020/05/06 06:08:15.741 +00:00] [INFO] [store.rs:860] ["start store"] [takes=184.215µs] [merge_count=0] [applying_count=0] [tombstone_count=0] [region_count=1] [store_id=1]

I can't find the logic that writes rocksdb log into tikv log when rocksdb log is not set.

Sorry for delay. I'll review tomorrow.

We need to also do the same for raftdb.

Haven't read the code, but some comments:

I didn't realize tikv config doesn't specify a log dir. Let's change plan. Let's still put rocksdb log under rocksdb directory, but use the new logger.
We need to also do the same for raftdb.
By default rocksdb should have its own log file. Let's not merge rocksdb log with tikv log in the same file.

So the logic of rocksdb log is that if rocksdb's info-log-dir is empty, the rocksdb's log will write into storage's data-dir?

So the logic of rocksdb log is that if rocksdb's info-log-dir is empty, the rocksdb's log will write into storage's data-dir?

should be in rocksdb/raftdb's default directory (/db and /raft respectively).

/rebuild

/run-all-tests

@hawkingrei do you mind address remaining unresolved minor comments? We are good to go after that.

@hawkingrei do you mind address remaining unresolved minor comments? We are good to go after that.

OK，I have solved the solution.

Need to add more UT and do manual tests

Add validate for log.

@Connor1996 PTAL

Trying to merge again. The UCP is close to the end and we need to merge by 6.5.

/merge

/merge

/merge

/merge

/merge

/merge

/merge

/merge


Improve hardfork timestamp override handling in add-chain.sh

Desiderata for improvements here:

we pipe the values through date -r <timestamp> -u  and append this as a comment on each line, so it matches:
https://github.com/ethereum-optimism/superchain-registry/blob/119f493760a5d2de4c9cb878dcfa03077e24d2bc/superchain/configs/sepolia/superchain.yaml#L10-L12
we iterate through all fields ending in _time, to catch future hardforks without needing to update the script
instead of filling with null when the jq query fails, we should use nil or even better just omit the entire line from the output yaml file.
EDIT: if the timestamp matches the superchain default in the neighbouring superchain.yaml file, we should NOT add the override at all.

IMO we tackle these in a followup issue / PRs. This PR is reasonably urgent, because it will cause tests to incorrectly fail on in flight standard chain PRs.

We should also perform a check that all existing files are consistent with the conventions above and modify them if so


⚠ Bofrost.be has degraded performance

In 824fd17, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1853 ms

Resolved: Bofrost.be performance has improved in 5877f34.


Better error handling with the bro log file is not found.

Right now the bro_log_reader.py doesn't raise an IOError exception when the bro log file is not found (or not readable), so that needs to be fixed. Also the log_to_dataframe class also needs to catch and rethrow that IOError so that scripts using either of those can properly catch the IOError.

Okay, this is now fixed. The bro_log_reader will throw an IOError when the file is not found. Looking at the tests this seems to propagate properly.


Concurrency policy

https://trello.com/c/iHcWEd6L/351-naisjob-eksponere-concurrencypolicy

 NaisJob: eksponere ConcurrencyPolicy


You can place lattice on occupied floor tiles/spaces indoors.

Description

Lattice placed indoors/in hallways lets you create what I assume to be multiple grids over top of each other simultaneously. Pretty sure this also comes with suffocation hazards and can be used to grief stations.
Reproduction

Unsure how to reliably reproduce but I assume it has to do with "reality breaking" with certain people just getting the ability to walk through windows/walls/etc. also getting the ability to build/construct on a separate grid as well. No idea if a git issue is open on THAT yet, either.
Screenshots

Additional context

this is already fixed but not published


Files for the credit scoring (character scoring)

Check the data_reading file to change the database credentials.
The credit_score file is the one you shoud call in java.
Use the following code when calling it: {
Process process = Runtime.getRuntime.exec("python credit_score.py business_id);
BufferedReader reader = new BufferedReader(new InputStreamReader(process.getInputStream()));
System.out.println(reader.readLine());
reader.close();
} The 'business_id' should be passed for it is used in retrieving the data.

For reasons of consistency with our development plan and architecture, I suggest you implement these in java as part of the core services in the crams-services module.


Custom osie via userdata

This lets us specify a custom osie version (for testing, yay testing) by supplying the info at provision time, via userdata. I've set it up so that when API has support for this in the provision call it should work already.

I'm not well-versed enough in the boots codebase to give this a thorough review, but I like the looks of what I see and am :100: to having this available soonish. :+1:


nil pointer error - 2

When the header Authorization and parameters code are not provided, CheckBearerAuth function returns nil.
Runtime error in file info.go:22
#44 Another solution
PS：English isn’t my first language, so please excuse any mistakes. ：）

I think it should be the bearer == nil and ret.Code == "" express the same meaning , so , like this is not to determine whether significant refining ?
Or modify CheckBearerAuth function returns a value of two  , like
func CheckBearerAuth(r *http.Request) (*BearerAuth, error)

Obsolete since #55 got merged.  Can be closed.


added update button to each show policy

1.adding update button to function setCardBody
2.adding a function that create the update button
3. adding a update class to css file in order to control the width of the collapse (when we enter the update button)

overall looks good,
just one question, when you use update in the css, i can't find the place in the code where you actually give the button the class name "update", can you direct me to the place?

yes, it is in  cardCardBodyUpdateButton = createInitElement('div', 'card card-body update');
I added this class because I want to control the width of the specific card body in the update button (if I don't add this when I press the update button I get a card body that out of the borders of the specific policy ), I hope this is more clear now


Tooltip is invalid

It always show 'Increment'.

The fix for this is now live here:
https://pub.dartlang.org/packages/fab_dialer


Test Issue created at Sat, 22 Jan 2022 02:18:16 GMT

Test issue body  Sat, 22 Jan 2022 02:18:16 GMT

Comment on issue at Sat, 22 Jan 2022 02:18:18 GMT


Add support for analytics

As a developer, I would like the Java SDK to support sending flag analytics to the Flagsmith API, so that we can view flag evaluation in the WebApp.

Analytics processing has been made available since v5.0.0.


Z-Rotation Groups

Description:
If you have a group that has z-rotation, the model flips on the X-axis
How to Replicate:
Create a model with a group that has rotation on the z axis, and export it into Dalek Mod
What Happens:
The group with rotation flips along the X axis
What should happen:
It should export as-is from Blockbench

Root problem to issue found.
Nothing to do with Z rotation; X rotation on groups was inverted value when importing.
Issue resolved in next version


Divide 8-bit reads into chunks of 64 bytes to satisfy ST-Link v2 max length

Fix for panic during ST-Link 8-bit memory reads (#425). Split the reads into 64-byte chunks as suggested in the issue.

Yes, I noticed that also. I will add the check for the probe and adjust the chunk size as in write_8 and push a new commit shortly.


Disable TestDistribution for native subprojects - cherry-pick of #28760 to release

As requested by @blindpirate
Original PR:

#28760

@bot-gradle merge


utils/analytics: fix BuildError reporting.

Need to ensure we call the correct methods to avoid duplicates.

Review period skipped due to critical label.


port remote_cmd_converter

This ports remote_cmd_converter node to ROS2.

@nnmm Thanks for the review.
I applied your suggested changes.
I also noticed that I forgot to port the launch file so there is also change to the launch file as well.


EXC_BAD_ACCESS on make.height.greaterThanOrEqualTo(constant)

New Issue Checklist

[x] I have looked at the Documentation
[x] I have read the F.A.Q.

Environment / Configuration
Platform

[ ] OS X
[x] iOS

Versions

Platform version is: 9.2.1
SnapKit version is: 0.19.1

Integration

[x] Carthage
[x] Cocoapods
[ ] Manually / Other

Issue
App crashes with EXC_BAD_ACCESS on seemingly innocuous lines such as make.height.greaterThanOrEqualTo(250). The common thing seems to be constraining a width or height to greater or less than (or equal to) a constant. Making something just equal to a constant seems to never cause these crashes.

(Seen this on one app using Carthage, and in another using Cocoapods.)

All right, now I actually saw it also for a plain equalTo condition (when the constant was a let variable in the same view controller class).

@repomies a bit odd, do you by chance have a snippet you can share? and/or a full sample project?

@robertjpayne sorry for the delay, I hope later this week I'll have time to provide you with a full sample project that exhibits this strange behavior. But for now, I hope this helps — the top of the stacktrace in Crashlytics looks like this:
Crashed: com.apple.main-thread
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000042500000

0 libobjc.A.dylib objc_retain + 7
1 SnapKit _TFC7SnapKit21ConstraintDescription20greaterThanOrEqualTofCSo6UIViewPS_29ConstraintDescriptionEditable_ + 32
2 SnapKit _TTWC7SnapKit21ConstraintDescriptionS_30ConstraintDescriptionRelatableS_FS1_20greaterThanOrEqualTofVSC6CGSizePS_29ConstraintDescriptionEditable_ + 80
3 (My App) CommentListViewController.swift line 228 CommentListViewController.(viewDidLoad() -> ()).(closure #4)

And the crashing line (228) is the last one inside this block:
commentingBar.snp_makeConstraints { make in
    make.top.equalTo(tableView.snp_bottom)
    make.left.right.equalTo(view)
    make.bottom.equalTo(view).offset(-TabBarHeight)
    make.height.greaterThanOrEqualTo(CGFloat(52))
}

If my memory serves, wrapping the constant into CGFloat() seemed to fix the crash in the past — or at least that's what I thought.

@repomies might need to wait until you have the project. I can't replicate this unfortunately. Quite strange!

Here's another, even more strange (since it's just a plain equalTo):
nameSeparator.snp_updateConstraints { (make) in
    make.top.equalTo(nameTextView.snp_bottom).offset(5)
    make.left.right.equalTo(nameLabel).inset(EdgeInsets(top: 0, left: -6, bottom: 0, right: -6))
    make.height.equalTo(0.5)
}

The last line in the closure gives this crash:
_TTWC7SnapKit21ConstraintDescriptionS_30ConstraintDescriptionRelatableS_FS1_7equalTofV12CoreGraphics7CGFloatPS_29ConstraintDescriptionEditable_ + 24
But yeah, I'll try to isolate the issue into a proper sample project.

@repomies do you by chance have any unprefixed Swift extensions of Objective-C classes? Such as:
extension UIViewController {
    func doSomething() {}
}

Anywhere in your project?

@repomies any luck getting a sample project or has it resolved itself?

Closing this due to inactivity. Please re-open if you feel it's still an issue.

@robertjpayne my apologies, forgot about this. Haven't experienced the problem lately at all, so the new Xcode/iOS update might have affected the underlying reason. Anyway, yes, I realized I had unprefixed Swift extensions of UIView (computed properties width and height, among other things) which might have been the real culprit here.


3D StaticBody constant linear/angular velocity doesn't work when using Bullet

Godot version: 3.0.2
Issue description:
While building my first game to test Godot out, I was reading about StaticBodys in the documentation and stumbled upon constant velocity:

[...] a constant linear or angular velocity can be set for the static body, so even if it doesn’t move, it affects other bodies as if it was moving [...]

It turns out, these properties do not have any effect at all with Bullet (the default 3D physics engine in Godot 3). With the engine set to GodotPhysics, these properties work as expected.
I need to investigate a bit further, but it seems the same thing is true for the thing the documentation calls "simulated motion mode".
Steps to reproduce:
Create a new scene with a StaticBody (e.g. a floor) and a RigidBody (e.g. a ball) and let the RigidBody drop on the StaticBody. Set constant_linear_velocity or constant_angular_velocity to any amount.
The RigidBody will be launched when 3d/physics_engine="GodotPhysics", but won't do anything for any other setting.
Minimal reproduction project:
Standalone test scenes are in this repository:
https://github.com/eiszfuchs/godot-test-scenes/blob/master/Scenes/ConstantLinearVelocity.tscn
https://github.com/eiszfuchs/godot-test-scenes/blob/master/Scenes/ConstantAngularVelocity.tscn

CC @AndreaCatania.

I tried to build a test scene for the "simulated motion mode" mentioned in the documentation. From what I'm getting is that it's supposed to work when moving a StaticBody via script (such as animating a moving platform via GDScript).
I couldn't get it to work in either physics engine. I couldn't find a setting (because the documentation says it's something that has to be set active). In fact, if you Google godot "simulated motion mode", this ticket shows up, and the mention in the documentation shows up, but nothing else.
There is something about it in the 2.1 documentation on KinematicBody2D, but that doesn't seem to be valid anymore in 3.0.
I'd really like that feature, too.

While building my first game to test Godot out, I was reading about StaticBodys in the documentation and stumbled upon constant velocity:

[...] a constant linear or angular velocity can be set for the static body, so even if it doesn’t move, it affects other bodies as if it was moving [...]

It turns out, these properties do not have any effect at all with Bullet (the default 3D physics engine in Godot 3). With the engine set to GodotPhysics, these properties work as expected.
Really strange, when I tested it, it was working... But thanks you for your report, I'll check it.
Also, the static body is not meant to be moved around, instead use the kinematic body and move it by changing its position, or use move_and_slide, etc...
Check the godot demos (platformer demo, if I don't go wrong (The one with pink box) ) how the platforms are moved using GDS

This issue affects both Physics engines now, on 3.0.6 and 3.1b10.

This issue affects both Physics engines now, on 3.0.6 and 3.1b10.

Here is a sample project in 3.1b11 with this issue: https://cdn.discordapp.com/attachments/212250894228652034/553366025760931844/3d_3.1.rar

Still happens on latest master branch.
@AndreaCatania The issue is that KinematicBody cannot be used with Trimesh or Convex collision generated from imported Meshes, so it is impossible to use with complex objects. 🤷♂

Still valid in e9d12f9


Improve connectivity change reconfigurations

Task/Issue URL: https://app.asana.com/0/488551667048375/1202217410650615/f
Description
This PR:

Ensures that the ConnectivityChangeReceiver only reconfigures the VPN when the network type changes, not in every single trigger

Incidentally, it also

Removes the PrivateDnsSettingMonitor class and performs that work directly in the NetworkTypeCollector as it is more readable
Sets the TUN_READ_IO_SAMPLES trigger to 1min instead of 45sec, as 45sec was too low
Makes the VpnPreferences an interface so that it can be faked. This requires some minor changes in AndroidVpnReminderReceiverManager

Steps to test this PR
Private DNS

[ ] Install from this branch
[ ] Enable AppTP
[ ] Go to AppTP dev settings and make sure "Private DNS" toggle is ON
[ ] Go to Android settings -> Private DNS and manually configure to one.one.one.one, click save
[ ] Verify the VPN restarts
[ ] Verify in the diagnostics screen that <IP_ADDRESS> address is configured as DNS
[ ] Verify apps continue to work

Network switching handling

[ ] Enable ApptP
[ ] ensure you're on WIFI network
[ ] Scroll down from top of the screen
[ ] Select mobile data
[ ] verify the VPN restarts only once, logcat Connectivity change to... prints once
[ ] Scroll down from top of the screen
[ ] Select WIFI
[ ] verify the VPN restarts only once, logcat Connectivity change to... prints once
[ ] Verify apps continue to work

Current dependencies on/for this PR:

develop

PR #1905   (this PR)

This comment was auto-generated by Graphite.


fix: change html direction based on selected language

Thanks for the PR! It's something that I wanted to implement for a while, just forgot about it.
Your solution is pretty strait forward, but there is a couple of problems with it:

LocaleDirectionality::new() will not work if icu_compiled_data is disabled.
It's would be better to implement a direction function on the Locale trait instead
Maybe put this as an option ? being true by default just like set_lang_attr_on_html

Thinking about it, the direction can be computed at compile time in the macro, this would remove the need to include icu_locid_transform in the final binary

I tried to address the issues you mentioned. Please let me know if there are any more.

@Baptistemontan Your PR is actually what this PR should be for. I just reverted the changes and applied your PR. Thanks for your work.

Don't worry about the failing tests, it'a semver problem

I kind of feel bad for my PR, I just wanted to show you how I would have made it, this is your PR and your work and want o give you credit for it

You shouldn't and it's totally fine! It could take more time and effort from me to understand the codebase due to heavy usage of macros to land this feature. Thanks for maintaining this repo.

It could take more time and effort from me to understand the codebase due to heavy usage of macros to land this feature.

The macro code base is pretty big, and not well documented, I know it can be difficult to understand what's going on as even me sometimes get lost in it. I refactored it several times but it's still very complex and confusing, I need to make the code more welcoming for peopleto propose PR.


Added timeout field to BackupConfig type

Issue https://github.com/rancher/rancher/issues/30663

Superseded by https://github.com/rancher/types/pull/1196

Superseded by https://github.com/rancher/types/pull/1196


The "All required fields are completed" publication message repeatedly arises

Add a file to a resource that is otherwise publishable
Observe the publication message
View, then edit the same resource
Add a file and observe the same the resource is now publishable message
5. This is a bit misleading, as adding the 10th file to a resource, for example, does not actually change it's publishability

This has been fixed in 1.50 release - tested on prod. So closing.


[celero] Updated to v2.9.0

[x] Changes comply with the maintainer guide

[x] SHA512s are updated for each updated download

[x] The "supports" clause reflects platforms that may be fixed by this new version

[x] Any fixed CI baseline entries are removed from that file.

[x] Any patches that are no longer applied are deleted from the port's directory.

[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.

[x] Only one version is added to each modified port's versions file.

SHA512s are updated for each updated download

Fixed demo project compilation on Linux

Tested on Windows x64 (Visual Studio) and Linux x64 (GCC on Ubuntu).

Usage test pass with following triplets:
x86-windows
x64-windows
x64-windows-static


Singularity based RStudio

This commit removes the requirement for using proot to create private /tmp spaces. Instead a Singularity container is used which mounts RStudio and its dependencies from the host, plus overrides the mount for /tmp using a new tmp dir rooted in PBSTMP. The Singularity container is as simple as can be requiring only the installation of which over the base CentOS 7. Since R or RStudio are not installed in the image then the image should not require a rebuild in the event of changes to RStudio.
The path to the image is currently in my home directory, and needs to be moved to a system directory, or the WIAG user's home. Also naming the image something slightly more useful than centos7.simg like rstudio_launcher_centos7.simg may be useful.
Heechang has installed the image in a system directory.

@treydock I have moved some of the host specific environment into a module, and confirmed that things work as expected.
For reference below is the module:
help([[This module sets up the RStudio server Singularity environment]])
setenv("SINGULARITY_BINDPATH","/usr/local,/etc/profile.d/lmod.sh,/usr/share/lmod,/opt/intel,/opt/mvapich2,/usr/lib64")
setenv("RSTUDIO_SERVER_IMAGE","/usr/local/project/ondemand/singularity/rstudio/rstudio_launcher_centos7.simg")

If this is amenable then I am going to ask SciApps to install/make the module and will merge this into production later today or early tomorrow.


metrics 3.2.2

What changes were proposed in this pull request?
bump codahale metrics version from 3.1.2 to 3.2.2

Main thing I want is the default shared metrics registry that was backported to 3.2.0 which gives libs a reasonable place to add metrics. Relevant PR: https://github.com/dropwizard/metrics/pull/801

Will merge once the build passes.

@ellisjoe when you bump dependencies you have to run ./dev/test-dependencies.sh --replace-manifest to update dependencies


UnicodeEncodeError: 'charmap' codec can't encode character '\ufb01' in position 793

PC: Win 10
Traceback (most recent call last):
File "C:\PythonScriptLocation\summarize.py", line 458, in
f.write(text)
File "C:\Python310\lib\encodings\cp1252.py", line 19, in encode
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\ufb01' in position 793: character maps to
I solved the issue:
Lines: 434, 457, 499, 513, 530, 532, 547, 564, 588, 603, 612, 630, 648
Add the attribute  encoding='utf-8' to the code line like so:
with open(overall_summary_path, 'w', encoding='utf-8') as f:

Thanks. ChatGPT says that On macOS and Linux, the default encoding is usually UTF-8., but On Windows, the default encoding is typically Windows-1252 or CP-1252.
I've only tested the code on macOS and Linux, so I think your solution is the correct one for Windows. Do you want to make a PR against my repo so you get contributor credit, or should I go ahead and do it and just reference this issue?

Im unfamiliar with Github, would you be able to add me as a contributor?
Glad I could help. :D

Committed in https://github.com/scottleibrand/gpt-summarizer/commit/ccbfb2fd13ea17042afa8dbeb859da7a8a9ed72d


Add to exisiting columns

Add the ability to add a column to the existing columns without having to redeclare them all

Hi @jjgrainger
I would like to contrite to this enhancement, please guide me more about this.
thanks


High severity whitesource vulnerability

Hi support,
I am getting high severity whitesource vulnerability for axios 0.21.4 in @sap-cloud-sdk/core 1.54.0. Please see the impact analysis below:

Request you to please provide a fix for this vulnerability.
Best Regards
Krishan

Hi @krishraheja ,
Thanks for raising up.
Are you using our (pre-generated clients) vdm or only the sdk core? (Or could you please list all the sdk dependencies you are using?)
Could you please try version 1.54.1?
By the way, we have released version 2 since the beginning of the year and version 1 will be deprecated in the near future.
FYI, @marikaner.
BR,
Junjie

Hi Junjie,
Thanks for your prompt reply.
We are only using core library @sap-cloud-sdk/core. As per your suggestion, I was checking for 1.54.1 version, but it not available in npmjs. is that already pushed or should I wait to reflect it there.
Best Regards
Krishan

Hey @krishraheja
1.54.1 is available here (since 3 months<EMAIL_ADDRESS>e.g. with this command:
npm i<EMAIL_ADDRESS>
Hope that helps
Best,
Tom

Hi @tomfrenken @jjtang1985
It's strange that I can't see 1.54.1 in npmjs but when I added this version in package.json, it has resolved my issue. Also not sure in my package.json I had added it like  "@sap-cloud-sdk/core": "^1.54.0" then it should have picked 1.54.1 automatically.
Thanks a lot for your support.
Appreciate your good work!
Best Regards
Krishan

Hi @krishraheja ,
there was a tag issue with the @sap-cloud-sdk/core package.
Before, ^1.54.0 pointed to 1.54.0, but now it points to 1.54.1.
Best regards,
Junjie

Hi @jjtang1985
Yes now it is showing exact 1.54.1 version. Thanks for your support.
Best Regards
Krishan


Can somebody help me with 2FA, I blocked 1 of my accounts...

I had synced 2FA app on Chrome because it doesnt work on my phone I dont know why. Then I turned off 2FA now, I have turned on and I cannot use my 2FA again at all............. what to do ? I contact the support but they dont respond soon maybe until 24-48 hours. Is there any chance to sync my account. The app is added on my chrome and it was working well. But now doesnt.

Hi, Megmog
I can't catch up with your point, can you answer these questions with yes or no

You have installed this Chrome extension because your phone can not work?
You had synced 2FA app on Chrome, so you had installed this extension on more then one computers?

You can not sign in your account because you have lost your 2FA secret?

Please tell me your answers, and I'll think about how to help you.
Li Zhe

Hi, Megmog
I will close this issue in 2 days if you fail to respond in time.
Li Zhe

Oh, sorry Li Zhe. but I have no idea waht I did. I talked with website
admins adn they removed me the 2FA. Anyway now I have 2FA on my Windows 7
Chrome Brower. On my android my 2FA application do not work. I have no idea
why is it like that. I tried to synchronized but it doesnt work. It says me
that synchronization seems like to be already done before. I have tried to
installed many times. I reinstall android and updated everythign. It is the
same. It never works on my android.
On Tue, Apr 7, 2015 at 12:52 PM, Li Zhe<EMAIL_ADDRESS>wrote:

Hi, Megmog
I will close this issue in 2 days if you fail to respond in time.
Li Zhe
—
Reply to this email directly or view it on GitHub
https://github.com/Sneezry/authenticator/issues/5#issuecomment-90491542.

 After these 2 operations 2FA on my Chrome browsers on
windows 7 didnt work anymore and wasnt able to be synchorinzed. But I
resolved that problem. Now my problem is if it is possible to install it
and make it work properly on my tablet android.
On Tue, Apr 7, 2015 at 1:28 PM, Petroslav Panayotov<EMAIL_ADDRESS>
wrote:

Oh, sorry Li Zhe. but I have no idea waht I did. I talked with website
admins adn they removed me the 2FA. Anyway now I have 2FA on my Windows 7
Chrome Brower. On my android my 2FA application do not work. I have no idea
why is it like that. I tried to synchronized but it doesnt work. It says me
that synchronization seems like to be already done before. I have tried to
installed many times. I reinstall android and updated everythign. It is the
same. It never works on my android.
On Tue, Apr 7, 2015 at 12:52 PM, Li Zhe<EMAIL_ADDRESS>wrote:

Hi, Megmog
I will close this issue in 2 days if you fail to respond in time.
Li Zhe
—
Reply to this email directly or view it on GitHub
https://github.com/Sneezry/authenticator/issues/5#issuecomment-90491542
.

OK Megmog, I'm happy to know you have solved the problem with you account. To the android issue, it's beyond my ability, so would you mind me close this issue, or do you have any other questions about the extension?
Li Zhe

Its ok , Li. Close it. Whatever. Just say me if it was possible to
synchronize it again after I had reset 2FA account security settings.
On Apr 7, 2015 2:14 PM, "Li Zhe"<EMAIL_ADDRESS>wrote:

OK Megmog, I'm happy to know you have solved the problem with you account.
To the android issue, it's beyond my ability, so would you mind me close
this issue, or do you have any other questions about the extension?
Li Zhe
—
Reply to this email directly or view it on GitHub
https://github.com/Sneezry/authenticator/issues/5#issuecomment-90509118.

Account data will be synced by Google among extensions. You may also open QR code and scan it with your smart phone.


No AtomicParsley on Android Devices -> Embeding Thumbnails?

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2<IP_ADDRESS>. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2<IP_ADDRESS>

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[x] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.

Is there any other way to embed thumbnails to the audio file then with AtomicParsley since I cant find a way to install it with termux or any other way. Also if I use the -x option and convert it to mp3 every file has the ssame thumbnail (Probabaly because of my Phone but still)
Thanks

Currently embedding in mp4 and m4a is only possible with AtomicParsley.

https://github.com/rg3/youtube-dl/issues/12459

github.com/rg3/youtube-dl/issues/10359

http://github.com/rg3/youtube-dl/issues/10359

http://github.com/rg3/youtube-dl/issues/12126

http://github.com/rg3/youtube-dl/issues/6046

http://github.com/rg3/youtube-dl/issues/8379

https://github.com/rg3/youtube-dl/pull/15445

@dstftw that is not true anymore (not sure if it was even true when you said
it):
youtube-dl --write-thumbnail --format m4a --output 1.m4a Aio_UkAJtoI

mp4box -itags cover=1.jpg 1.m4a

mp4tag --add Cover:JPEG:1.jpg 1.m4a 2.m4a

tageditor -s cover=1.jpg -f 1.m4a

operon image-set 1.jpg 1.m4a

http://github.com/svnpenn/bay/blob/master/doc/mp4-m4a-metadata.md


chore: update arweave fallback for Aug 30

Description
Added Arweave content as of Aug 30

Review Error for wilsoncusack @ 2023-08-30 17:05:14 UTC
User failed mfa authentication, see go/mfa-help


Only clear context in SidekiqCleanupMiddleware if no exception was raised

Fixes issue referenced at https://github.com/getsentry/raven-ruby/pull/637#issuecomment-290391560
Without this change SidekiqCleanupMiddleware clears out context before Sidekiq error handler has a chance to report it.

Could you spell out a test case for this similar to what I'd done in #637 to demonstrate the problem you're encountering? Based on that comment I'm not sure I'd run into it and I'd like to make sure the issue isn't from something else (version of sidekick, active job, etc).

@drewish the test-case would be identical to what you had in #637 but SadWorker should also register a tag like this:
class SadWorker
  include Sidekiq::Worker

  sidekiq_options :retry => false

  def perform(*args)
    Raven.tags_context mood: 'sad'
    raise "I'm sad!"
  end
end

And this tag is what never reaches sentry. Looking at the code with debugger the order of execution looks like this:
    6:   def perform(*args)
    7:     Raven.tags_context mood: 'sad'
    8:     debugger
=>  9:     raise "I'm sad!"
   10:   end
   11: end
(byebug) cont

[5, 14] in /Users/tarmo/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/raven-ruby-3dde5b735b4c/lib/raven/integrations/sidekiq.rb
    5:   class SidekiqCleanupMiddleware
    6:     def call(_worker, _job, _queue)
    7:       yield
    8:     ensure
    9:       debugger
=> 10:       Context.clear!
   11:       BreadcrumbBuffer.clear!
   12:     end
   13:   end
   14:
(byebug) Raven.tags_context
{:mood=>"sad"}
(byebug) cont
   15:   class SidekiqErrorHandler
   16:     ACTIVEJOB_RESERVED_PREFIX = "_aj_".freeze
   17:
   18:     def call(ex, context)
   19:       debugger
=> 20:       context = filter_context(context)
   21:       Raven.capture_exception(
   22:         ex,
   23:         :message => ex.message,
   24:         :extra => { :sidekiq => context },
(byebug) Raven.tags_context
{}

The last line demonstrates that by the time the error handler is invoked there is nothing returned by Raven.tags_context.


breaking(Search): update onResultSelect and onSearchChange signature

BREAKING
This wasn't done in #951 and there were arguments for that reason, however I think that all our callbacks should be consistent.

Handler
Previous Signature
Current Signature

onResultSelect
(e, result)
(e, { ...props, result })

onSearchChange
(e, value)
(e, { ...props, value })

Before
<Search onResultSelect={(e, result) => console.log(e, result)} />
<Search onSearchChange={(e, value) => console.log(e, value)} />

After
<Search onResultSelect={(e, data) => console.log(e, data)} />
<Search onResultSelect={(e, { result }) => console.log(e, result)} />

<Search onSearchChange={(e, data) => console.log(e, data)} />
<Search onSearchChange={(e, { value }) => console.log(e, value)} />

Codecov Report

Merging #1828 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1828      +/-   ##
==========================================
- Coverage   99.75%   99.75%   -0.01%
==========================================
  Files         144      144
  Lines        2463     2462       -1
==========================================
- Hits         2457     2456       -1
  Misses          6        6

Impacted Files
Coverage Δ

src/modules/Search/Search.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c194992...7014110. Read the comment docs.

Released in<EMAIL_ADDRESS>


FOUC in Production since Nuxt 3.10.0

Environment

Operating System: Darwin
Node Version:     v20.10.0
Nuxt Version:     3.11.2
CLI Version:      3.11.1
Nitro Version:    2.9.6
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      css
Runtime Modules:  -
Build Modules:    -

Reproduction
https://github.com/DallasHoff/nuxt-fouc-example
Describe the bug
Under certain conditions, I am seeing a flash of unstyled content in the production build of a site since Nuxt 3.10.0. In the provided reproduction, you can see this by building the site (npm run build) and then previewing it (npm run preview) and watching as the page loads. The links in the navbar will start out unstyled, in a vertical stack, and then switch to being styled in a row.
If you then downgrade the project to Nuxt 3.9.3 with no other changes, the FOUC will not happen. Checking the built HTML of the page, you can see that this version has the CSS of the navbar component inlined, where newer versions of Nuxt do not.
Strangely, the FOUC also only happens with certain configurations of the components. The FOUC does not happen if:

The <style> tag in layouts/default.vue is empty.
The <script> tag in components/app/navbar.vue does not have lang="ts"

#25806 is similar, but that was resolved as an issue with Vite while this issue happens in production and not development. The issue appears if either nuxt build or nuxt generate is used to build the site.
Additional context
No response
Logs
No response

Nuxt 3.12 fixed this.

@mhdSid I did not close this. The original reporter did, when it was resolved for them.
I'll look forward to your reproduction in the issue you've opened. 🙏

@danielroe  I'll do my best to make a reproducible example


Update README.md

Switch mod-card to card-mod, I think thats what you meant

the lovelace-card-mod support both mod-card and card-mod, but I think card-mod is actually more right.
Thank you. ;)


score range for each dimension?

Currently Vbench can evaluate on the list of dimension
['subject_consistency', 'background_consistency', 'temporal_flickering', 'motion_smoothness', 'dynamic_degree', 'aesthetic_quality', 'imaging_quality', 'object_class', 'multiple_objects', 'human_action', 'color', 'spatial_relationship', 'scene', 'temporal_style', 'appearance_style', 'overall_consistency']
I run some of them on my customized video, however, the score range for each of the dimension is different.
For one of my videos, It has 5 scores
subject consistency:  10.982122957706451
motion_smoothness: 0.9960492387493192
dynamic degree: false
aesthetic_quality: 0.6582092642784119
imaging_quality: 72.89873886108398
while the overall score is as following
subject consistency:  0.9861730885776606
motion_smoothness: 0.9909714810295909
dynamic degree: 0.16666666666666666
aesthetic_quality: 0.6556713245809078
imaging_quality: 0.7093512528141342
Can you illustrate more on the score range for each video and what does it mean?
It would be better to generate some example for score anchor for each dimension.
For example, if the range of aesthetic_quality is 0-1.
I would like to know how 0.1, 0.5 and 0.9 look like separately.
Thanks!

Hi, thanks for your question! The score range for all dimensions are 0 to 1.
For samples of different scores, at different dimensions, you can refer to section G of supplementary materials: https://arxiv.org/pdf/2311.17982, where for each dimension we provided some samples at varying scores.

Thanks Ziqi for your helpful answer. May I ask why we have
dynamic degree as false,
while subject consistency & imaging_quality much larger than 1?

Hi, I assume you are asking about the scores for individual videos in the generated eval_results.json file.
For dynamic_degree, each video undergoes binary classification, with true referring to dynamic, while false referring to static. The final score for the dynamic_degree dimension is defined as the percentage of videos classified as dynamic.
For other dimensions that have values larger than 1, it could be due to these two reasons: (1) The individual videos' raw score is in the range of 0-100. (2) The individual video's raw score hasn't been divided by the frame count yet.
We retain these raw scores for individual videos in case users need them for debugging. However, you should refer to the final aggregated score for each dimension to assess the model's performance in that particular dimension.

Hi, I assume you are asking about the scores for individual videos in the generated eval_results.json file.
For dynamic_degree, each video undergoes binary classification, with true referring to dynamic, while false referring to static. The final score for the dynamic_degree dimension is defined as the percentage of videos classified as dynamic.
For other dimensions that have values larger than 1, it could be due to these two reasons: (1) The individual videos' raw score is in the range of 0-100. (2) The individual video's raw score hasn't been divided by the frame count yet.
We retain these raw scores for individual videos in case users need them for debugging. However, you should refer to the final aggregated score for each dimension to assess the model's performance in that particular dimension.

how can I get the original classification probability of dynamic_degree?

Hi, it's not probability-based classification, but based on threshold.

Hi, it's not probability-based classification, but based on threshold.

Hello! Sorry, but I still did not get how to get a numeric value instead of boolean? Boolean seems not to be useful for my evaluations


feat: show travel animation for ennemies and exploring

resolves #396

@credence0x fixed the issue with the disappearing armies


[Bug?]: Ref is undefined when component has a loading resource

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
When I load the page I get a Ref is undefined error in a createEffect when assigning the value property. It seems to be because the component is still loading because of a createResource which has not finished, why there hasn't been anything rendered yet.
Expected behavior 🤔
Not throwing the error.
I am not sure how the workflow should be in such a case. I would guess wrapping the HTML elements which use the resource payload so other elements who have refs assigned can render, but Suspense only works for components and not in the same file if I read correctly.
Steps to reproduce 🕹
Steps:
git clone  https://git.moonleay.net/Websites/liljudd-website.git
cd liljudd-website/
git checkout ref-resource-bug
pnpm i
pnpm dev

Open http://localhost:3000/config/598539452343648256 in your browser

Having a ref in a component and a createResource which takes some time to load. Accessing the ref too early will result in the undefined error.
Context 🔦
I removed everything unnecessary from the project and pushed a separate branch ref-resource-bug. I also wonder why the effect is executing so early. The reason for running in the first place is being the Intl object not being the same with SSR, right? Like server and client having different preferences, which makes it fine running the effect, but if I would check first if (!timePlanningRef) return; then I would not insert the default timezone for the user and would also not have a rerun of the effect until the user inputs anything and might wonder of the mismatched place holder value coming from the server.
I also had many other issues like Hydration mismatches and sourceMaps being null, if I would have elements accessing the resources I would have the errors, but also not every time, depending how fast the resource resolved. But I could be sure of the ref error and just added a 3 sec delay as a showcase. I might open another issue when I have more clear results of the cause of the other errors, but one step at the time.
Your environment 🌎
System:
  OS: Linux pop-os 6.5.6-76060506-generic #202310061235~1697396945~22.04~9283e32 SMP PREEMPT_DYNAMIC Sun O x86_64 x86_64 x86_64 GNU/Linux
  CPU: (8c/16t) x86_64
Binaries:
  Node: v21.1.0 - /home/aronmal/.nvm/versions/node/v21.1.0/bin/node
  Yarn: 1.22.21 - /home/aronmal/.nvm/versions/node/v21.1.0/bin/yarn
  npm: 10.2.0 - /home/aronmal/.nvm/versions/node/v21.1.0/bin/npm
  pnpm: 8.14.1 - /home/aronmal/.nvm/versions/node/v21.1.0/bin/pnpm (my preference)
npmPackages:
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>extraneous
├──<EMAIL_ADDRESS>extraneous
├──<EMAIL_ADDRESS>extraneous
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>extraneous
├──<EMAIL_ADDRESS>extraneous
├──<EMAIL_ADDRESS>extraneous
├──<EMAIL_ADDRESS>extraneous
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>extraneous
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

Here is the error:

And when I use the payload data in a For component I get the mismatch error:

Have you tried using signals for refs instead of a plain variable?

Probably doable. I would then have a Element | undefined type because of no initial value as input, but that would be more strict and better to work with. But is there a specific reason why they use plain let vars in the solidjs docs?

Ah, when I use a signal, the value is or should be treated as an readonly value, right? As long as I use it as a proxy I could do it like this:
const [timezoneRef, setTimezoneRef] = createSignal<HTMLInputElement>();

createEffect(() => {
  const ref = timezoneRef()
  if (!ref) return
  ref.value = timezone();
});

return <input ref={(e) => setTimezoneRef(e)} />;

It does work like this. But is it intended this way within an async component? If yes, it would be nice if there would be a note in the docs.

Reference for this issue:
https://git.moonleay.net/Websites/liljudd-website/commits/branch/ref-resource-bug


editor.tabsize and extension tab size not correct

Hi! Here is my VS Code settings: https://gyazo.com/726cd79d17a82d93ef5975faf4ec7952
But when i use "Format document", extension always сhange tab size to 4:
1)before https://gyazo.com/1cd9d9d1deb178865c55030353a840f5
2)after https://gyazo.com/64de2c3c855e27bf70b6351744201b86
I have tried solutions from another similiar issues, but it takes no effect
Any help?

Having this same issue.

Thanks @mderkach for bringing this to my attention! I've just pushed a fix and indentation should work properly now 👍

Either this bug is back or there's a lack configuration reference in readme.


Failed to verify signature on dotfiles due to unsigned commit

Hello!
First of all, thank you for the great idea and for the service!
I have recently created a new account (at the to1 host) with success, but during what I suppose to be the default user onboarding process, I encounter the error as per subject, probably due to the last commit (47a237d6d36dc1dcb16bf01345063c1efec733bc) not having been signed before merge.
For the sake of completeness, I have pasted the full (anonymized) console print below.
Console print

Linux to1 4.9.0-8-amd64 #1 SMP Debian 4.9.130-2 (2018-10-27) x86_64
The programs included with the Debian GNU/Linux system are free software;
the exact distribution terms for each program are described in the
individual files in /usr/share/doc/*/copyright.
Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
permitted by applicable law.
You have new mail.
Last login: Thu Mar 28 17:11:41 2019 from [IP address]
Cloning into '/home/[username]/.dotfiles'...
remote: Enumerating objects: 8, done.
remote: Counting objects: 100% (8/8), done.
remote: Compressing objects: 100% (7/7), done.
remote: Total 523 (delta 1), reused 2 (delta 1), pack-reused 515
Receiving objects: 100% (523/523), 275.13 KiB | 0 bytes/s, done.
Resolving deltas: 100% (225/225), done.
Submodule '.grml-etc-core' (https://github.com/grml/grml-etc-core.git) registered for path 'zsh/.grml-etc-core'
Cloning into '/home/[username]/.dotfiles/zsh/.grml-etc-core'...
remote: Enumerating objects: 14, done.
remote: Counting objects: 100% (14/14), done.
remote: Compressing objects: 100% (12/12), done.
remote: Total 7084 (delta 3), reused 6 (delta 2), pack-reused 7070
Receiving objects: 100% (7084/7084), 2.91 MiB | 0 bytes/s, done.
Resolving deltas: 100% (4143/4143), done.
Submodule path 'zsh/.grml-etc-core': checked out 'c5383b10d449697922b6da3262b63a95ed5cc83d'
CRITICAL: Failed to verify signature on dotfiles

Should be fixed now.


Extracting features importance

MLBlocks version: '0.2.0'
Python version: Python 3.6.3
Operating System: MacOS High Sierra

Description
I have been trying to produce the features importance from a classifier (RandomForrest). The feature_importances function doesn't take arguments. So, the MLPipeline doesn't execute (TypeError: 'numpy.ndarray' object is not callable).
What I Did
I left the arguments empty in the primitive definition file in the produce part.

{
    "name": "sklearn.ensemble.RandomForestClassifier1",
    "documentation": "http://scikit-learn.org/stable/modules/generated/sklearn.ensemble.RandomForestClassifier.html",
    "description": "Scikit-learn RandomForestClassifier.",
    "classifiers": {
        "type": "estimator",
        "subtype": "classifier"
    },
    "modalities": [],
    "primitive": "sklearn.ensemble.RandomForestClassifier",
    "fit": {
        "method": "fit",
        "args": [
            {
                "name": "X",
                "type": "DataFrame"
            },
            {
                "name": "y",
                "type": "Series"
            }
        ]
    },
    "produce": {
        "method": "feature_importances_",
        "args": [],
        "output": [
            {
                "name": "y",
                "type": "Series"
            }
        ]
    },
    "hyperparameters": {
        "fixed": {
            "n_jobs": {
                "type": "int",
                "default": -1
            }
        },
        "tunable": {
            "criterion": {
                "type": "str",
                "default": "entropy",
                "values": ["entropy", "gini"]
            },
            "max_features": {
                "type": "str",
                "default": null,
                "range": [null, "auto", "log2"]
            },
            "max_depth": {
                "type": "int",
                "default": 10,
                "range": [1, 30]
            },
            "min_samples_split": {
                "type": "float",
                "default": 0.1,
                "range": [0.0001, 0.5]
            },
            "min_samples_leaf": {
                "type": "float",
                "default": 0.1,
                "range": [0.0001, 0.5]
            },
            "n_estimators": {
                "type": "int",
                "default": 30,
                "values": [2, 500]
            },
            "class_weight": {
                "type": "str",
                "default": null,
                "range": [null, "balanced"]
            }
        }
    }
}

Thanks for reporting this @faisalaleissa
However, I think that the problem is that feature_importances_ is not a method, but rather an attribute, so instead of calling it (which is what MLBlocks will try when you set it as the method), what you would need to do is just "read it", which is not something natively supported by MLBlocks.
So, in order to do this, the only option that you have is to write a python primitive in MLPrimitives that in its fit method calls the RandomForest fit method and in its produce method just takes the attribute from the RandomForest object and returns it.
However, a question arises: what do you intentend to do with the feature_importances_ value?
If what you want to do is a feature selection based on that, I recommend you to have a look at the SelectFromModel class from scikit-learn and the corresponding MLBlocks integration, which you can find here:

JSON: https://github.com/HDI-Project/MLPrimitives/blob/master/mlblocks_primitives/mlprimitives.feature_selection.ExtraTreesClassifierFeatureSelector.json
Python adapter: https://github.com/HDI-Project/MLPrimitives/blob/master/mlprimitives/feature_selection.py

Thanks for the quick reply. I'm working on a classifier reporting library, in which, we compute metrics and evaluate the classifiers. One part is to rank the features that are most affective for the classifier.
I think the feature selector you mentioned will be suitble.
Thanks again.


Apply margin bottom helper to big number component

What
Applies the shared helper, which includes standardised margin_bottom behaviour, to the big number component.
Why
Fixes https://github.com/alphagov/govuk_publishing_components/issues/2479
Visual Changes
New docs section

Just spotted that this needs a test for the new attribute. I initially thought that this wouldn't need one as this relies on an external helper which as its own tests but other components using the helper add tests for margin_bottom. Will follow convention here.

@owenatgov good shout. Yes, the tests don't need to be exhaustive because as you pointed out this functionality already has tests, but a basic test to check that the margin helper has been implemented correctly on this component would be good 👍

@andysellick Would you mind approving Percy? Once you do (if you're happy with it) I'll merge this.


fix: adds operator-sdk make target

Adds a make target to download the operator-sdk binary.
This is required for downstream builds.
Signed-off-by: N Balachandran<EMAIL_ADDRESS>

I have currently just copied and modified the opm target. Todo : Write a function to do this.

I have currently just copied and modified the opm target. Todo : Write a function to do this.

by writing a function you mean, factor out installation in opm & operator-sdk?

I have currently just copied and modified the opm target. Todo : Write a function to do this.

by writing a function you mean, factor out installation in opm & operator-sdk?

Yes, that's right.


API's

a general API to one's own algorithm by which he updates the datapoint \ rigidbody state vector.

Not so clear. There is already an update function


[MRG] Add MLKR and MMC to doc index

Add newly introduced MMC and MLKR to the documentation.

If the current description of MMC and MLKR is good, I think we can merge.


Append Instructions for Unique Website Names

Deployment fails due to "Website with given name devapp-webapp already exists."
You should add a comment/note to change the parameter values to a more unique string to avoid this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8974207c-f48f-7226-9f68-4c8639e3c513
Version Independent ID: 3888d579-9ad6-4bba-a6d4-4ae78b08cd48
Content: Tutorial - use parameter file to help deploy an Azure Resource Manager template
Content Source: articles/azure-resource-manager/template-tutorial-use-parameter-file.md
Service: azure-resource-manager
GitHub Login: @mumian
Microsoft Alias: jgao

@AErmie Thank you for your feedback! We will review and update as appropriate.

@Aermie - thanks for the feedback.  This issue has been addressed in https://github.com/Azure/azure-docs-json-samples/pull/100
#please-close


[SPARK-17970][SQL] store partition spec in metastore for data source table

What changes were proposed in this pull request?
We should follow hive table and also store partition spec in metastore for data source table.
This brings 2 benefits:

It's more flexible to manage the table data files, as users can use ADD PARTITION, DROP PARTITION and RENAME PARTITION
We don't need to cache all file status for data source table anymore.

How was this patch tested?
existing tests.

cc @yhuai

Also cc @ericl

Test build #67076 has started for PR 15515 at commit ceac57b.

Test build #67076 has finished for PR 15515 at commit ceac57b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67076/
Test FAILed.

Also cc @mallman

Test build #67186 has started for PR 15515 at commit 561fbce.

Test build #67186 has finished for PR 15515 at commit 561fbce.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67186/
Test FAILed.

Merged build finished. Test FAILed.

Test build #67200 has started for PR 15515 at commit 96b12e5.

Test build #67200 has finished for PR 15515 at commit 96b12e5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67200/
Test FAILed.

Could we add a feature flag for this? Then it would be easier to write tests for backwards compatibility against old data-source tables.

Test build #67230 has started for PR 15515 at commit 4d93f48.

Test build #67230 has finished for PR 15515 at commit 4d93f48.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67230/
Test FAILed.

Test build #67283 has started for PR 15515 at commit 44f6c70.

Test build #67283 has finished for PR 15515 at commit 44f6c70.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67283/
Test FAILed.

Test build #67294 has started for PR 15515 at commit 2ec970f.

Test build #67296 has started for PR 15515 at commit 17f23cd.

Test build #67294 has finished for PR 15515 at commit 2ec970f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67294/
Test FAILed.

Test build #67296 has finished for PR 15515 at commit 17f23cd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67296/
Test FAILed.

Test build #67347 has started for PR 15515 at commit f40e72f.

Test build #67347 has finished for PR 15515 at commit f40e72f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67347/
Test FAILed.

Test build #67353 has started for PR 15515 at commit 390c2db.

Test build #67353 has finished for PR 15515 at commit 390c2db.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67353/
Test FAILed.

Merged build finished. Test FAILed.

Test build #67354 has started for PR 15515 at commit 4294510.

Test build #67354 has finished for PR 15515 at commit 4294510.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67354/
Test FAILed.

Test build #67355 has started for PR 15515 at commit de6c00d.

Test build #67357 has started for PR 15515 at commit 1b73b7b.

Test build #67358 has started for PR 15515 at commit 4da7724.

Test build #67359 has started for PR 15515 at commit 34b1ae6.

@cloud-fan I think this is pretty close once https://github.com/apache/spark/pull/15539 is merged.
The only remaining issues I know about are (1) supporting mixed case columns, and (2) optimizing the insert command to not call repair table. But as discussed we can address these separately.

Test build #67355 has finished for PR 15515 at commit de6c00d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67355/
Test FAILed.

Looks like two failing tests in FileStreamSourceSuite

Test build #67358 has finished for PR 15515 at commit 4da7724.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67358/
Test FAILed.

Test build #67357 has finished for PR 15515 at commit 1b73b7b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67357/
Test FAILed.

Test build #67359 has finished for PR 15515 at commit 34b1ae6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67359/
Test FAILed.

Test build #67365 has started for PR 15515 at commit f903243.

Test build #67365 has finished for PR 15515 at commit f903243.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67365/
Test PASSed.

Merged build finished. Test PASSed.

Test build #67464 has started for PR 15515 at commit f882988.

Test build #67467 has started for PR 15515 at commit e42bb5a.

Ok, I think this is now ready to review. I've pushed commits that add a feature flag (consolidated with prior feature flags to make it easy to revert back to 2.0 behavior), backwards compatibility, and tests cases.
The proposal for backwards compatibility is as follows.

Newly created datasource tables will have the table property partitionProvider=hive and will use the metastore for partition discovery.
Older Spark versions will not respect the partitionProvider property, and will always discover partitions from remote storage.
When partitionProvider is set to hive, partition related hive DDLs (e.g. SHOW PARTITIONS) will work. Otherwise, an exception will be thrown telling the user to run msck repair table to import the table partitions into the hive metastore (this will set partitionProvider = hive).
When the feature flag is disabled, tables with hive partition provider will behave like legacy tables. The partition DDLs will also be disabled for all datasource tables.

Test build #67468 has started for PR 15515 at commit bc659c5.

Test build #67464 has finished for PR 15515 at commit f882988.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  case class AssignStrategy(partitions: Array[TopicPartition], kafkaParams: ju.Map[String, Object])
  case class SourceInfo(name: String, schema: StructType, partitionColumns: Seq[String])

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67464/
Test PASSed.

Test build #67467 has finished for PR 15515 at commit e42bb5a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67467/
Test PASSed.

Test build #67468 has finished for PR 15515 at commit bc659c5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67468/
Test PASSed.

Test build #67477 has started for PR 15515 at commit ba4f32f.

Test build #67477 has finished for PR 15515 at commit ba4f32f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67477/
Test PASSed.

Rebased

Test build #67484 has started for PR 15515 at commit df5d439.

Test build #67484 has finished for PR 15515 at commit df5d439.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67484/
Test PASSed.

Merged build finished. Test PASSed.

Test build #67510 has started for PR 15515 at commit 8f9d219.

Test build #67511 has started for PR 15515 at commit ef954fb.

Test build #67510 has finished for PR 15515 at commit 8f9d219.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SingularMatrixException(message: String, cause: Throwable)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67510/
Test FAILed.

Test build #67511 has finished for PR 15515 at commit ef954fb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67511/
Test FAILed.

Test build #67521 has started for PR 15515 at commit 802372c.

Test build #67521 has finished for PR 15515 at commit 802372c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67521/
Test FAILed.

Test build #67529 has started for PR 15515 at commit e3f6610.

Test build #67530 has started for PR 15515 at commit a442aa4.

Test build #67529 has finished for PR 15515 at commit e3f6610.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67529/
Test FAILed.

Merged build finished. Test FAILed.

Test build #67530 has finished for PR 15515 at commit a442aa4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67530/
Test FAILed.

Merged build finished. Test FAILed.

Test build #67538 has started for PR 15515 at commit 87a6b40.

Test build #67538 has finished for PR 15515 at commit 87a6b40.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67538/
Test PASSed.

Test build #67580 has started for PR 15515 at commit 58f1aba.

LGTM, I added a new commit to make partitionProviderIsHive a field and put it in table properties in HiveExternalCatalog, to simplify the code a little bit. Feel free to revert it if it breaks something.

Test build #67580 has finished for PR 15515 at commit 58f1aba.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67580/
Test FAILed.

Test build #67586 has started for PR 15515 at commit 05fd862.

Test build #67586 has finished for PR 15515 at commit 05fd862.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67586/
Test FAILed.

Merged build finished. Test FAILed.

That LGTM as well. I pushed a small fix for the failing debug mode test.

Test build #67594 has finished for PR 15515 at commit 012c124.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67594/
Test FAILed.

Test build #67604 has started for PR 15515 at commit 9a6fff6.

Test build #67604 has finished for PR 15515 at commit 9a6fff6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67604/
Test FAILed.

Test build #67610 has started for PR 15515 at commit 8c80555.

Test build #67610 has finished for PR 15515 at commit 8c80555.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67610/
Test PASSed.

Merged build finished. Test PASSed.

Test build #67615 has started for PR 15515 at commit b6776cc.

Test build #67615 has finished for PR 15515 at commit b6776cc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67615/
Test FAILed.

[info] - SPARK-10562: partition by column with mixed case name *** FAILED *** (605 milliseconds)
[info]   java.lang.reflect.InvocationTargetException:
[info]   at sun.reflect.GeneratedMethodAccessor156.invoke(Unknown Source)
[info]   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[info]   at java.lang.reflect.Method.invoke(Method.java:497)
[info]   at org.apache.spark.sql.hive.client.Shim_v0_13.getPartitionsByFilter(HiveShim.scala:588)

Odd that the last commit could cause this, maybe it's a flake? jenkins test this please

retest this please

Test build #67625 has started for PR 15515 at commit b6776cc.

Test build #67625 has finished for PR 15515 at commit b6776cc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67625/
Test FAILed.

retest this please

Test build #67632 has started for PR 15515 at commit b6776cc.

Test build #67632 has finished for PR 15515 at commit b6776cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67632/
Test PASSed.

Looks good. I left a few questions. Let me know if you want to address them in follow-up prs.

Cool. I am merging this pr to unblock other tasks.