ModelNotFound Exception: No NLU or Core data for unpacked model

Rasa version: 1.3.9
Python version: 3.7.4
Operating system: Windows 10 (VM)
Issue: ModelNotFound Exception: No NLU or Core data for unpacked model at: './models/
So I'm trying to update my model from pre-1.0 Rasa to the up-to-date package, and I'm finding myself utterly lacking in the competence to do this? Before, I had my model in a subfolder under /models/dialogue and now it's being exported from the train function as a tar.gz file. So I extracted the file and put it in the folder structure I had before, only now I keep getting the above error, and I don't know what's wrong with my setup. My models folder contains exactly what 'comes out' of the unzipped file, so what is it missing?
Thanks so much in advance for any help!

Thanks for the issue, @dakshvar22 will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

Hi @cintahofmann, in the latest version you don't need/want to extract the file, rather the models will live in the models/ directory as tar.gz files. Is that helpful? If not, can you please post the output of the commands you are running?

Hi @erohmensing, thanks for your response! :) When I try to just leave the unzipped file in the folder structure, I get the same error. This is what my dialogue management model looks like with the subfolder structure:
from __future__ import division
from __future__ import print_function
from __future__ import unicode_literals

import logging
import rasa.core
import asyncio
from rasa.core.agent import Agent
from rasa.core.policies.keras_policy import KerasPolicy
from rasa.core.policies.memoization import MemoizationPolicy
from rasa.core.interpreter import RasaNLUInterpreter
from rasa.core.run import serve_application
from rasa.core import config
from rasa.utils.endpoints import EndpointConfig

from rasa.core.policies.fallback import FallbackPolicy
from rasa.core.policies.form_policy import FormPolicy

logger = logging.getLogger(__name__)

async def train_dialogue(domain_file = 'domain.yml',
					model_path = './models/core',
					training_data_file = './data/stories.md'):

	fallback = FallbackPolicy(fallback_action_name="action_default_fallback",
                          core_threshold=0.2,
                          nlu_threshold=0.4)

	agent = Agent(domain_file, policies = [FormPolicy(), MemoizationPolicy(), KerasPolicy(max_history=3, epochs=200, batch_size=50), fallback])
	data = await agent.load_data(training_data_file)

	agent.train(data)

	agent.persist(model_path)
	return agent

def run_report_bot(serve_forever=True):
	interpreter = RasaNLUInterpreter('./models/nlu/')
	action_endpoint = EndpointConfig(url="http://localhost:5055/webhook")

	agent = Agent.load('./models/core', interpreter=interpreter, action_endpoint=action_endpoint)
	rasa_core.run.serve_application(agent ,channel='cmdline')

	return agent

if __name__ == '__main__':
	train_dialogue()
	run_report_bot()

So, this is what happens when I delete the subfolder structure and just leave the unextracted tar.gz files (and take out the reference to the subfolders from the dialogue management model.py):
(aka it seems to be looking for the json that's inside the zipped model file)
  File "C:\Users\Cinta\Anaconda3\lib\site-packages\rasa\nlu\model.py", line 68, in load
    data = rasa.utils.io.read_json_file(metadata_file)
  File "C:\Users\Cinta\Anaconda3\lib\site-packages\rasa\utils\io.py", line 141, in read_json_file
    content = read_file(filename)
  File "C:\Users\Cinta\Anaconda3\lib\site-packages\rasa\utils\io.py", line 136, in read_file
    raise ValueError("File '{}' does not exist.".format(filename))
ValueError: File './models/metadata.json' does not exist.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "dialogue_management_model.py", line 53, in <module>
    run_report_bot()
  File "dialogue_management_model.py", line 42, in run_report_bot
    interpreter = RasaNLUInterpreter('./models/')
  File "C:\Users\Cinta\Anaconda3\lib\site-packages\rasa\core\interpreter.py", line 263, in __init__
    self._load_interpreter()
  File "C:\Users\Cinta\Anaconda3\lib\site-packages\rasa\core\interpreter.py", line 286, in _load_interpreter
    self.interpreter = Interpreter.load(self.model_directory)
  File "C:\Users\Cinta\Anaconda3\lib\site-packages\rasa\nlu\model.py", line 302, in load
    model_metadata = Metadata.load(model_dir)
  File "C:\Users\Cinta\Anaconda3\lib\site-packages\rasa\nlu\model.py", line 73, in load
    "Failed to load model metadata from '{}'. {}".format(abspath, e)
rasa.nlu.model.InvalidModelError: Failed to load model metadata from 'C:\Users\Cinta\Documents\Chatbot\models\metadata.json'. File './models/metadata.json' does not exist.

And then, if I just copy over the metadata.json from the previously extracted model file, this happens - which makes no sense, as I trained the model literally yesterday using Rasa 1.3.9 (which is reflected in the file name of course):
dialogue_management_model.py:52: RuntimeWarning: coroutine 'train_dialogue' was never awaited
  train_dialogue()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
Traceback (most recent call last):
  File "dialogue_management_model.py", line 53, in <module>
    run_report_bot()
  File "dialogue_management_model.py", line 42, in run_report_bot
    interpreter = RasaNLUInterpreter('./models/')
  File "C:\Users\Cinta\Anaconda3\lib\site-packages\rasa\core\interpreter.py", line 263, in __init__
    self._load_interpreter()
  File "C:\Users\Cinta\Anaconda3\lib\site-packages\rasa\core\interpreter.py", line 286, in _load_interpreter
    self.interpreter = Interpreter.load(self.model_directory)
  File "C:\Users\Cinta\Anaconda3\lib\site-packages\rasa\nlu\model.py", line 304, in load
    Interpreter.ensure_model_compatibility(model_metadata)
  File "C:\Users\Cinta\Anaconda3\lib\site-packages\rasa\nlu\model.py", line 279, in ensure_model_compatibility
    "".format(model_version, rasa.__version__)
rasa.nlu.model.UnsupportedModelError: The model version is too old to be loaded by this Rasa NLU instance. Either retrain the model, or run with an older version. Model version: 0.0.0 Instance version: 1.3.9

I am having the same issue. any solution?

@aziz-raihan this issue is old and about version 1.3, when we are now on 1.9. If you are still seeing issues on the later versions, please open a new bug report and we'll reinvestigate.

Still getting this issue. I am using rasa.nlu.train.train with params: nlu_config, data, path, fixed_model_name to create a model using syncio run_until_complete in python, but unable to load the model using the cli command rasa run -m trained_model

See my above comment!


Blurred images when using batch count: 4 with sharpness: 1

UI
Forge
Model
Flux.1-dev
Batch Count
3+
ReSharpen Sharpness
1
Description
Images produced by the system become increasingly blurred as the batch count increases. This issue is noticeable even when generating images with 5 sampling steps. Increasing the batch size does not trigger this bug; only the batch count affects the image sharpness.
Sample output
https://i.imgur.com/RXwZo2U.jpeg
Formatting powered by GPT 😆

Does this problem only occur with Flux models? Cause I tried with SD 1.5 ones and couldn't reproduce.
Though I also pushed a commit that might fix it.

Does this problem only occur with Flux models?
I think so. It seems like it's fixed now in Flux as well.

Oh nice. I'll close the issue then.


GCE: Break connection after 10 min deployment.

I've installed workflow on Google Container Engine, trying to deploy an app. It breaks after 10 minutes:
~/workfiles/idg [master]> git push deis-gprod production
Counting objects: 172633, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (46754/46754), done.
Writing objects: 100% (172633/172633), 82.20 MiB | 3.13 MiB/s, done.
Total 172633 (delta 129865), reused 165534 (delta 124087)
Starting build... but first, coffee!
Step 1 : FROM dmapper/baseimage:v2.0.0
---> eec6d6fbd455
Step 2 : ADD . /app
---> 0dbc487f4940
Removing intermediate container a804c8383554
Step 3 : RUN echo

....

fatal: The remote end hung up unexpectedly
fatal: The remote end hung up unexpectedly

I've read the https://github.com/deis/router/pull/94/files about idle connections. But it's not an idle connection. All the 10 minutes I'm getting deployment log.
We have quite a big app. Usually it takes us a half an hour to deploy it (using deis 1.0 with baseimage and Dockerfile in DigitalOcean).
What could it be? How can I fix this?
P.S. Workflow version is 2.5.0

By default the builder waits for 15 min for the build to complete(https://github.com/deis/builder/blob/f8cc20b429784824d3bf6b3f1059f9b219bf60c7/pkg/gitreceive/config.go#L35)...you can override it using BUILDER_POD_WAIT_DURATION env variable in the builder deployment template kubectl edit deployment deis-builder --namespace=deis

I don't think this is the right reason because it breaks exactly after 10 minutes. See the logs:
~/workfiles/idg [master]> date; BUILDER_POD_WAIT_DURATION=9000000 git push deis-gprod production; date;
Fri Sep 30 09:41:07 MSK 2016
Counting objects: 174057, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (47474/47474), done.
Writing objects: 100% (174057/174057), 82.43 MiB | 2.95 MiB/s, done.
Total 174057 (delta 130933), reused 166551 (delta 124772)
Starting build... but first, coffee!
Step 1 : FROM dmapper/baseimage:v2.0.0
---> eec6d6fbd455
Step 2 : ADD . /app
---> d45a3954cadb
Removing intermediate container 2c05b324678d

// ... another logs

[1]  39% 1234/2470 build modules
fatal: The remote end hung up unexpectedly
fatal: The remote end hung up unexpectedly
Fri Sep 30 09:51:09 MSK 2016
~/workfiles/idg [master]>

can you change the GIT_LOCK_TIMEOUT from 10 min to something more on the builder deployment  https://github.com/deis/builder/blob/master/pkg/sshd/config.go#L17  and see if it helps

Didn't help as well.
~/workfiles/idg [master]> date; GIT_LOCK_TIMEOUT=15 git push deis-gprod production; date;
Fri Sep 30 10:10:16 MSK 2016
Counting objects: 174057, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (47474/47474), done.
Writing objects: 100% (174057/174057), 82.43 MiB | 3.90 MiB/s, done.
Total 174057 (delta 130932), reused 166552 (delta 124772)
Starting build... but first, coffee!
Step 1 : FROM dmapper/baseimage:v2.0.0
---> eec6d6fbd455
Step 2 : ADD . /app
---> 40b50cec397f
Removing intermediate container 0f7de2dc4a36
Step 3 : RUN echo
// ..

 51% 436/638 build modules
 51% 437/638 build modules
fatal: The remote end hung up unexpectedly
fatal: The remote end hung up unexpectedly
Fri Sep 30 10:20:17 MSK 2016

Hm, how do I change GIT_LOCK_TIMEOUT in the builder itself? Is there a easy way to change it right inside the created GCE container?

Just tried to change config for builder using: "kubectl edit deployment deis-builder --namespace=deis"
Set up both BUILDER_POD_WAIT_DURATION=3000000 and `GIT_LOCK_TIMEOUT=50. Didn't help. Still failing in 10 min.

is there anything in the builder logs?

ping

Sorry, they switched me to another task temporary. I close the issue for a while and then reopen it again.

I am seeing the same thing on Azure.


new opening times

Could someone adapt the new opening times?
Monday till Friday 5pm till late
Saturday und Sunday 8pm till late
thanks!

@patfraud should we do 2 lines? I don't see another way…
The wording is fine? (I only changed "und" to "and").

hehe, thanks. "rofl"
yes, lgtm
danke

thanks


[BUG]

Describe the bug
Images not loading on the manager page. Not even Dynasty showing up as team status.
Your League ID
In many cases, the bug maybe related to something not yet accommodated for in League Page, or something specific to your league. Adding your league ID allows for a faster debug and bug fix.
To Reproduce
Steps to reproduce the behavior:

Go to 'sffl.vercel.app'
Click on league info, managers.'
See error

Expected behavior
Standard Pictures to load.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Not sure what happened after the latest update, but I have to restart everything now and most stuff won't work.

I can't reproduce this locally. Can you send me your league website?


handlerWillRespond callback never invoked for failures

Library Affected:
"workbox-background-sync": "^6.5.3",
"workbox-core": "^6.5.3",
"workbox-precaching": "^6.5.3",
"workbox-window": "^6.5.3"
Browser & Platform:
all browsers
Issue or Feature Request Description:
According to this page: https://developer.chrome.com/docs/workbox/using-plugins/#methods-for-custom-plugins

handlerWillRespond: Called before the strategy's handle() method returns a response, which is helpful if you need to modify a response before returning it to a RouteHandler or other custom logic.

So I have set the following configuration:
sw.js
import {
  precacheAndRoute,
  cleanupOutdatedCaches,
  createHandlerBoundToURL,
} from "workbox-precaching";
import { NavigationRoute, registerRoute } from "workbox-routing";
import { Queue } from "workbox-background-sync";
import { NetworkOnly } from "workbox-strategies";

const queue = new Queue("myQueueName", {
  onSync: async ({ queue }) => {
    let entry;
    while ((entry = await queue.shiftRequest())) {
      try {
        await fetch(entry.request.clone());
      } catch (error) {
        await queue.unshiftRequest(entry);
        throw error;
      }
    }
  },
});

precacheAndRoute(self.__WB_MANIFEST);
cleanupOutdatedCaches();
registerRoute(new NavigationRoute(createHandlerBoundToURL("index.html")));

const statusPlugin = {
  handlerWillRespond: async ({ request, response, event, state }) => {
    console.log("handlerWillRespond");
    return response;
  },
  fetchDidFail: async ({ originalRequest, request, error, event }) => {
    console.log("fetchDidFail");
    queue.pushRequest({ request: originalRequest });
  },
  fetchDidSucceed: ({ response }) => {
    console.log("fetchDidSucceed");
    return response;
  },
};

registerRoute(
  new RegExp(".*/Exercises/.*"),
  new NetworkOnly({
    plugins: [statusPlugin],
  }),
  "POST"
);

On the client using axios:
    const axiosInstance = axios.create({
      timeout: 2000,
      withCredentials: true,
    });

    const add = async () => {
      try {
        console.log("Client makes a request");
        var response = await axiosInstance.post("Exercises/Create", { name: 'test' });
        console.log("Client sees OK");
      } catch (error) {
        console.log("Client sees an error");
      }
    };

For error response the order of output is:

Client makes a request
Client sees an error
fetchDidFail

The handlerWillRespond callback is never invoked. I expect the following output:

Client makes a request
handlerWillRespond <------
Client sees an error
fetchDidFail

For successful responses order is:

Client makes a request
fetchDidSucceed
handlerWillRespond
Client sees OK

If handlerWillRespond (regardless if it's a bug or not) is not meant to be used for this use-case and is not meant to be invoked before client sees the error response - could you show an approach that allows to override the response before the client sees it? Basically I want to override the fetch false-positive results

I believe that what you're seeing is the expected behavior.
handlerWillRespond will only be invoked if there's a valid Response generated by the strategy, and it gives you a chance to modify that Response object prior to passing it along to the client page. If you're using a NetworkOnly strategy and the network is unavailable, then handlerWillRespond will not be called.
If you want to provide a fallback/"fake" Response via a plugin, as an alternative to returning a network error, then you have two options:
fetchDidFail can be used to return a fallback response when the network portion of a strategy fails to returns a Response. (As you'd assume, in NetworkOnly, there's only a network portion.)
handlerDidError can be used to return a fallback response when all portions of a strategy fail to return a Response—i.e., both the network and any cache-based portion of a strategy fail to generate anything.
So, it sounds like using one of either fetchDidFail or handlerDidError will give you want you want.


Package flagged as installonly prevents yum update from succeeding

In this line  https://github.com/NVIDIA/yum-packaging-precompiled-kmod/blob/main/yum-kmod-nvidia.spec#L75 it seems the package is flagged as an installonly package
This leads to yum attempting an install when we request a package update:
Package 3:kmod-nvidia-latest-3.10.0-1160.49.1.r470.82.01.el7.post1.x86_64 is allowed multiple installs

Which eventually causes a conflict as to do an install it needs to remove the old driver and that would break the older version of the installed kmod.
It might be by design (installonly is documented to be used to prevent packages from being updated) but if so it does cause issues with automation tools like yum-cron and auter
Is this intended or is it an oversight?

I believe this a WAR for EL7 distros to allow multiple kmod packages (same NVIDIA driver, different kernel versions) to be installed at the same time.
As per: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/6/html/deployment_guide/sec-configuring_yum_and_yum_repositories

installonlypkgs=space separated list of packages
Here you can provide a space-separated list of packages which yum can install, but will never update. See the yum.conf(5) manual page for the list of packages which are install-only by default.
If you add the installonlypkgs directive to /etc/yum.conf, you should ensure that you list all of the packages that should be install-only, including any of those listed under the installonlypkgs section of yum.conf(5). In particular, kernel packages should always be listed in installonlypkgs (as they are by default), and installonly_limit should always be set to a value greater than 2 so that a backup kernel is always available in case the default one fails to boot.

We try to upgrade from 470 to 525 but the way it happens is through the upgrade of the kmod package.
We don't install the nvidia-driver-latest directly (which maybe is what gets us into this)
The command it runs is a simple yum update:
Resolving Dependencies
[...]
Dependencies Resolved

====================================================================================================================================================================================================
 Package                                                  Arch                           Version                                                      Repository                               Size
====================================================================================================================================================================================================
Installing:
 kmod-nvidia-latest                                       x86_64                         3:zzzz.r525.zzzz                                             REDACTED                          REDACTED
Updating:
 nvidia-driver-latest                                     x86_64                         3:525.85.12-1.el7                                            REDACTED                             REDACTED
 nvidia-driver-latest-NVML                                x86_64                         3:525.85.12-1.el7                                            REDACTED                             REDACTED
 nvidia-driver-latest-NvFBCOpenGL                         x86_64                         3:525.85.12-1.el7                                            REDACTED                              REDACTED
 nvidia-driver-latest-cuda                                x86_64                         3:525.85.12-1.el7                                            REDACTED                             REDACTED
 nvidia-driver-latest-cuda-libs                           x86_64                         3:525.85.12-1.el7                                            REDACTED                              REDACTED
 nvidia-driver-latest-devel                               x86_64                         3:525.85.12-1.el7                                            REDACTED                              REDACTED
 nvidia-driver-latest-libs                                x86_64                         3:525.85.12-1.el7                                            REDACTED                             REDACTED
 nvidia-modprobe-latest                                   x86_64                         3:525.85.12-1.el7                                            REDACTED                              REDACTED
 nvidia-persistenced-latest                               x86_64                         3:525.85.12-1.el7                                            REDACTED                              REDACTED
 nvidia-xconfig-latest                                    x86_64                         3:525.85.12-1.el7                                            REDACTED                              REDACTED
Installing for dependencies:
 egl-wayland                                              x86_64                         1.1.6-1.el7                                                  REDACTED                                    REDACTED
Not available:
 kmod-nvidia-latest                                       x86_64                         3:zzz.r525.zzz                                                 -                                       0.0

Transaction Summary
====================================================================================================================================================================================================
Install         1 Package  (+1 Dependent package)
Upgrade        10 Packages
Not available   1 Package

Total download size: REDACTED
[...]
Total                                                                                125 MB/s | 334 MB  00:00:02
Running transaction check
ERROR with transaction check vs depsolve:
nvidia-driver-latest = 3:470.zzz is needed by (installed) kmod-nvidia-latest-3:zzz.r470.zzz
 You could try running: rpm -Va --nofiles --nodigest

Sadly as far as I can tell both yum upgrade and yum update --obsoletes fail because of the same conflict (that it cannot remove the old driver because that would break the old kmod package)

As a workaround we have now changed our infra so our systems do an uninstall followed by install.

(thanks by the way) (:


No healthy host for HTTP connection pool error while using envoy external authorization using http service.

No healthy host for HTTP connection pool error while using envoy external authorization using http service.
Description:
I have been trying to use Envoy proxy from intercepting google cloud storage calls using hadoop gcs connector https://github.com/GoogleCloudDataproc/hadoop-connectors . This flow is working fine for me now. Now I want to add http service based authorization on the Envoy side before forwarding the requests to google storage server by following this doc https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/ext_authz_filter but getting this error.
Here is the proxy logs :

[2020-12-18 18:11:11.156][3998945][debug][http] [source/common/http/filter_manager.cc:721] [C0][S9503803361663740970] request end stream
[2020-12-18 18:11:11.279][3998945][trace][filter] [source/extensions/filters/http/ext_authz/ext_authz.cc:69] [C0][S9503803361663740970] ext_authz filter calling authorization server
[2020-12-18 18:11:11.304][3998945][debug][router] [source/common/router/router.cc:429] [C0][S15803442533933423924] cluster 'ext-authz' match for URL '/storage/v1/b/gcs-mthakur-bucket'
[2020-12-18 18:11:11.361][3998945][debug][upstream] [source/common/upstream/cluster_manager_impl.cc:1357] no healthy host for HTTP connection pool
[2020-12-18 18:11:11.370][3998945][debug][http] [source/common/http/async_client_impl.cc:100] async http request response headers (end_stream=false):
':status', '503'
'content-length', '19'
'content-type', 'text/plain'

Here is my envoy yaml:

http_filters:
- name: envoy.filters.http.ext_authz
typed_config:
"@type": type.googleapis.com/envoy.extensions.filters.http.ext_authz.v3.ExtAuthz
http_service:
server_uri:
uri: <IP_ADDRESS>:8080
cluster: ext-authz
timeout: 30s

... corresponding cluster conf as well.
I have a server running at localhost on port 8080 written in java.
Do I need to implement anything in my auth server? I am unable to find any relevant docs. Please help. Thanks

Hey @mukund-thakur!
There is a working example in the repo: https://github.com/envoyproxy/envoy/tree/master/examples/ext_authz as the source for this sandbox: https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/ext_authz
This is a sample for having ext_authz with HTTP service: https://github.com/envoyproxy/envoy/blob/master/examples/ext_authz/config/http-service.yaml
The GCS service should act as the upstream service here: https://github.com/envoyproxy/envoy/blob/2a9bb4d075f39e83a1b2c999ce6cfa8e21515c4d/examples/ext_authz/config/http-service.yaml#L54, and your Java application should be here: https://github.com/envoyproxy/envoy/blob/2a9bb4d075f39e83a1b2c999ce6cfa8e21515c4d/examples/ext_authz/config/http-service.yaml#L68. The example of ext_authz service is written in JavaScript https://github.com/envoyproxy/envoy/blob/master/examples/ext_authz/auth/http-service/server.js but I think you'll get the idea.
Hope it helps!

Thanks @dio for the docs. I tried this and it works. But I am not using docker and running the services separately and my auth server is running at http://<IP_ADDRESS>:8080/

, and your Java application should be here:
https://github.com/envoyproxy/envoy/blob/2a9bb4d075f39e83a1b2c999ce6cfa8e21515c4d/examples/ext_authz/config/http-service.yaml#L68

So I updated the address here to <IP_ADDRESS> and port as well.
But getting error

No healthy host for HTTP connection pool

Also I am seeing some suspicious logs

DNS for <IP_ADDRESS> resolved with: flags=3[MoreComing=yes, Add=yes], interface_index=0, error_code=-65568, hostname=<IP_ADDRESS>.

I am expecting envoy to at least send the calls to http://<IP_ADDRESS>:8080/.

I ran this node server https://github.com/envoyproxy/envoy/blob/master/examples/ext_authz/auth/http-service/server.js  in my localhost as well which I am able to access using curl but not working with envoy. I think I am missing some configuration here when not run the complete setup using docker.
Here is the my yaml config. Please suggest if any changes required. Thanks

http_filters:
name: envoy.filters.http.ext_authz
typed_config:
"@type": type.googleapis.com/envoy.extensions.filters.http.ext_authz.v3.ExtAuthz
transport_api_version: V3
http_service:
server_uri:
uri: http://<IP_ADDRESS>:9002/
cluster: ext_authz-http-service
timeout:  15s
authorization_response:
allowed_upstream_headers:
patterns:
- exact: x-current-user
name: ext_authz-http-service
connect_timeout: 15s
type: STRICT_DNS
lb_policy: ROUND_ROBIN
load_assignment:
cluster_name: ext_authz-http-service
endpoints:
- lb_endpoints:
- endpoint:
address:
socket_address:
address: <IP_ADDRESS>
port_value: 9002

@mukund-thakur when specifying the endpoints using IP addresses you should use STATIC cluster type instead of STRICT_DNS.

Thanks a lot @dio . It worked.


Uncaught TypeError: str.slice is not a function

I am using<EMAIL_ADDRESS>and neither redirect nor FlowRouter.go seem to work. I am trying to trigger after an evaluation. "redirect" throws Uncaught TypeError: str.slice is not a function and FlowRouter.go only changes the route for a second and changes it back to the route I just evaluated against. I expected to be redirected, actually.
I attached a screenshot from the browser tools and it seems there is a serious problem with "redirect". The string prototype is actually not a string, its a function. Any idea?

Redirect seems to throw an error when I access a route
triggersEnter: [function(context, redirect) {     redirect('/posts/list');   }],

I am using<EMAIL_ADDRESS>and neither redirect nor FlowRouter.go seem to work. I am trying to trigger after an evaluation. "redirect" throws Uncaught TypeError: str.slice is not a function and FlowRouter.go only changes the route for a second and changes it back to the route I just evaluated against. I expected to be redirected, actually.

I'm bumping into this same error, in the same context:
  // Set group using previous re-direct
  const authenticatedRoutes = FlowRouter.group({
    name: 'authenticated',
    triggersEnter: [function(context, redirect) {
      // Redirect unauthed users to login page
      if (!Meteor.loggingIn() && !Meteor.userId()) {
        console.log('not authorized');
        redirect('/login');
      }
    }]
  });

The log statement is firing without issue. If I replace the redirect with FlowRouter.go, I get the same issue described by @MHerszak

quick followup—reverting to current stable version of flow-router (not -ssr) corrects this issue. I'm currently using Meteor 1.3-beta.12.

This is fixed thanks to @marbemac's PR. Update the package.


Add functional of asking user for permission to send push notifications and getting existing permissions

Proposed changes

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

method addAskForNotificationPermission created using method addAskForPermission as example

Oh, you're correct, @gwythyr. We'll take a look, thanks!

Thank you!


fixed 'tutkimuspaikka pyydetty' form state bug

Codecov Report

Merging #192 (4e270dc) into main (b55e286) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   86.82%   86.82%
=======================================
  Files          17       17
  Lines         334      334
  Branches       33       33
=======================================
  Hits          290      290
  Misses         42       42
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55e286...4e270dc. Read the comment docs.


fix: Deselection of the preselected group values

Issues:

The custom event 'remove' is not working when emitted from inside the selectGroup method, thus need to call the removeElement method instead.

When removing an element, there is a deep comparison of objects thus need to compare using the JSON.stringify method and then remove the elements from the internalValue array.

Fixes #713

@chandrabhan-singh-27d Is there any open issue for the same with the reproducible link. If not then please create the issue first, then we can look into it.
Thanks for the PR.

@chandrabhan-singh-27d Is there any open issue for the same with the reproducible link. If not then please create the issue first, then we can look into it.
Thanks for the PR.

Hi @akki-jat, please find the issue #713. Thanks!

Hi @akki-jat, just checking if we can merge this as we are using the library in our app in productions and a quick merge can help us minimizing the fix replication at each instance. As mentioned earlier, here is the issue #713. Appreciate the help!

Closing as we have new PR (https://github.com/shentao/vue-multiselect/pull/1754) for the same.

@chandrabhan-singh-27d Please check if PR https://github.com/shentao/vue-multiselect/pull/1754 fixes the issue or not.

Yes, it does. Thanks for fixing the issue @akki-jat.

@mattelen please take a look. As it is a bug we can release it in version 2.


Login always returns to frontend page.

Description
At the backend url login page, when an administrator logins, he is redirected to home url and not the administrator area.
He then has to input the url again to enter the administration area, which has a different domain.
Step-by-step reproduction instructions

Administrator inserts the administration area login url (backend.com/wp-admin).
Administrator logs in correctly.
Administrator is redirected to site home page (frontend.com).

Expected behaviour

Regular user logins (frontend.com/wp-login).
Regular user is redirected for home page (frontend.com).
Administrator logins (backend.com/wp-login)
Administrator is redirected to administration area (backend.com/wp-admin).

Actual behaviour

Regular user logins (frontend.com/wp-login).
Regular user is redirected for home page (frontend.com).
Administrator logins (backend.com/wp-login)
Administrator is redirected for home page (frontend.com).

WordPress information

PHP version: 7.4
WordPress version: 5.6.1
OneLogin's SAML PHP Toolkit version: 3.3.1

Device information

Device: All devices
Operating system: All
Browser: All

Hi there!
We're experiencing the same issue with our project - Were you able to resolve this issue?


Question about the tokenizer's pad_token when using llama2 as target model

Hello authors,  you guys have done an amazing work in the AI  safety area. I hava a very simple question about tokenizer's pad_token when using llama2 as target model.  The below code shows when using llama2 as target model, the tokenizer's pad_token should be tokenizer.unk_token.

But when i run the main.py, the tokenizer's pad_token is tokenizer.eos_token rather than tokenizer.unk_token because like the below picture shows, in the config.py, the path of Llama-2-7b-chat-hf do not contain " llama2" instead of "Llama-2". Is this an error?

Hi,
I think it shouldn't matter at all for our codebase since we've been always using batch size equal to one (thus, no padding is needed for shorter sequences in a batch).
The reason why that if condition is present is because our repository is based on https://github.com/patrickrchao/JailbreakingLLMs which does use batching, and most likely I just forgot to remove this inactive if statement.

Thank you for time, i will close this issue.


testing pull approve

test it by approving mine.

lgtm

LGTM

middle LGTM

LGTM  extra

LGTM

NOT LGTM

LGTM NOT LGTM

LgTm

maybe we should just use gerrit?

NoT lgtm

I much prefer github to gerrit

lgTM

lol, github + gerrit http://gerrithub.io/

I don't have much experience with gerrit. I think the code review tool looks better over there though.

I used it for a while when I was doing openstack stuff and while it worked, it just seemed more complex than github.


when I use ART I get the following error "undefined is not an object (evaluating 'undefined.hex')"

[√ ] I have reviewed the documentation
[√ ] I have searched existing issues
[√] I am using the latest React Native version

Environment
Environment:
OS: macOS High Sierra 10.13.3
Node: 8.9.4
Yarn: Not Found
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.3 Build version 9E145
Android Studio: Not Found
Packages: (wanted => installed)
react: ^16.3.1 => 16.3.1
react-native: ^0.55.2 => 0.55.2
Steps to Reproduce
import {ART} from 'react-native';
...
<ART.Surface/>
Expected Behavior
build success
Actual Behavior

Does anyone have the same problem?

What is this ART you are importing? I can't find any reference to it in the docs

I still don't understand what ART is or where it comes from. Is it something from these react-native-google-maps or react-native-maps packages?

I intend to use react-native-progress, but I found that the error('undefined.hex') thrown by this package was caused by ART.

i met the  same problem

I fork the art package and adjusted the following:

then add this "art": "BluePecker/art" to package.json


Tag CmdStan 6.0.1

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/8813
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v6.0.1 -m "<description of version>"<PHONE_NUMBER>011b20394cb9da520c218a6d97f20b
git push origin v6.0.1


Allow client SDK to provide a custom version number

Currently, the datadog SDK seems to be looking up our version number from the PackageManager: https://github.com/DataDog/dd-sdk-android/blob/4be13fb69720ba54a7d61284816fb8a91ed75d19/dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/CoreFeature.kt#L314C34-L314C59
We reuse the same user-visible number if we discover bugs before pushing to production, but this makes all of our datadog dashboards extremely confusing to use.
We'd like to be able to provide our version code as the datadog version, rather than the user-visible version string.

Hi @ankushg , this is a topic we're considering supporting in the future, we'll keep you posted when we have a plan for such use case

Thanks -- from the code, it looked like we should have been able to pass in an attribute called "_dd.version" and have that used instead of what the PackageManager reports
Is that accurate?

Yes indeed that workaround will work, you just need to make sure you change also the version in the gradle plugin when uploading your Proguard/R8 mapping files, with the following snippet :
datadog {
    versionName = "42"
}
```


Error downloading from nfl.com

I am using 2<IP_ADDRESS> - the latest tagged in homebrew.  I don't believe this should be a problem, but if it has been fixed since then I am sorry.  I did not find any commits, issues, or PR's related to nfl since this release was tagged.
Gist of output: https://gist.github.com/iggyvolz/8e4a71a871a2c2216ad8
Looks like the source of the NFL page was modified... if I get a chance I'll try and look into this.

Thanks for the report, it will work in the next version.

youtube-dl 2<IP_ADDRESS> and newer add support for NFL article pages. See our FAQ if you need help updating.

Thank you!


 Add finish_cloned to ArrayBuilder

Which issue does this PR close?
Closes #3154
Are there any user-facing changes?
Yes, users will get a new function finish_cloned to get snapshot of data in ArrayBuilder.
WIP: This is the first commit to make sure the PR is in right direction.

I wonder if instead of MutableBuffer: Clone and adding finish_cloned to BufferBuilder, etc... we could just make use of https://docs.rs/arrow-buffer/latest/arrow_buffer/struct.Buffer.html#method.from_slice_ref?
What do you think?

Edit: I think finish_cloned function needs to be added to null_buffer_builder as null_buffer_builder.bitmap_builder might not be accessible outside the struct.

I'd suggest adding something like
    /// Returns the packed bits
    pub fn as_slice(&self) -> Option<&[u8]> {
        Some(self.bitmap_builder?.as_slice())
    }


[Usage] Error when use cli.py after merge-lora-weights.py

Describe the issue
Issue:
I used finetune_lora.sh to finetune vicuna-v1.5-13b with custom data. After it, I got a folder with adapter_model.safetensors, non_lora_trainables.bin. Then I merged it by merge-lora-weights.py, and I got another folder with three pytorch-model.bin.
When I used cli.py, it occured an error.
I didn't use the --load-4bit because of this issue #744. I met the same error before, so I removed it.
Command:
CUDA_VISIBLE_DEVICES=0 python -m llava.serve.cli --model-path /home/xhw/LLaVA/llava-v1.5-13b-lora-merge --model-base /home/xhw/LLaVA/vicuna-13b --image-file /home/xhw/LLaVA/images/8.jpg

Log:
[2024-07-25 06:06:17,295] [INFO] [real_accelerator.py:161:get_accelerator] Setting ds_accelerator to cuda (auto detect)
Loading LLaVA from base model...
Loading checkpoint shards: 100%|███████████████████████████████████████████████████████████████████████████████| 3/3 [00:13<00:00,  4.42s/it]
Some weights of LlavaLlamaForCausalLM were not initialized from the model checkpoint at /home/xhw/LLaVA/vicuna-13b and are newly initialized: ['model.mm_projector.0.bias', 'model.mm_projector.0.weight', 'model.mm_projector.2.bias', 'model.mm_projector.2.weight']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.
Loading additional LLaVA weights...
Loading LoRA weights...
Traceback (most recent call last):
  File "/home/xhw/anaconda3/envs/llava/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/xhw/anaconda3/envs/llava/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/xhw/LLaVA/llava/serve/cli.py", line 126, in <module>
    main(args)
  File "/home/xhw/LLaVA/llava/serve/cli.py", line 32, in main
    tokenizer, model, image_processor, context_len = load_pretrained_model(args.model_path, args.model_base, model_name, args.load_8bit, args.load_4bit, device=args.device)
  File "/home/xhw/LLaVA/llava/model/builder.py", line 83, in load_pretrained_model
    model = PeftModel.from_pretrained(model, model_path)
  File "/home/xhw/anaconda3/envs/llava/lib/python3.10/site-packages/peft/peft_model.py", line 430, in from_pretrained
    model.load_adapter(model_id, adapter_name, is_trainable=is_trainable, **kwargs)
  File "/home/xhw/anaconda3/envs/llava/lib/python3.10/site-packages/peft/peft_model.py", line 984, in load_adapter
    adapters_weights = load_peft_weights(model_id, device=torch_device, **hf_hub_download_kwargs)
  File "/home/xhw/anaconda3/envs/llava/lib/python3.10/site-packages/peft/utils/save_and_load.py", line 415, in load_peft_weights
    has_remote_safetensors_file = file_exists(
  File "/home/xhw/anaconda3/envs/llava/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 106, in _inner_fn
    validate_repo_id(arg_value)
  File "/home/xhw/anaconda3/envs/llava/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 154, in validate_repo_id
    raise HFValidationError(
huggingface_hub.errors.HFValidationError: Repo id must be in the form 'repo_name' or 'namespace/repo_name': '/home/xhw/LLaVA/llava-v1.5-13b-lora-merge'. Use `repo_type` argument if needed.

Here is my folder screenshots.
Screenshots:

I have checked the builder.py, it seems you should not have "lora" in the name of the folder of merged weight, otherwise it will download non_lora_trainables.bin from huggingface.


sanity checking mismatch

iam@shaman:~/Repositories/yices2$ wllvm-sanity-checker

We are wllvm version 1.1.3 and we are using clang.

The C compiler /usr/local/llvm-3.5/bin/clang is:

	clang version 3.5.2 (branches/release_35 229013) (llvm/branches/release_35 229009)

The C++ compiler /usr/local/llvm-3.5/bin/clang++ is:

	clang version 3.5.2 (branches/release_35 229013) (llvm/branches/release_35 229009)

The bitcode linker /usr/local/llvm-3.5/bin/llvm-link is:

	LLVM version 3.5.2

The bitcode archiver /usr/local/llvm-3.5/bin/llvm-ar is:

	LLVM version 3.5.2

Not using a bitcode store.

compilers match, archiver and linker do not.
iam@shaman:~/Repositories/yices2$ gsanity-check

Logging output directed to /tmp/gllvm.txt.
Logging level is set to DEBUG.

Happily sitting atop "linux" operating system.

The C compiler /usr/local/llvm-3.5/bin/clang is:

	clang version 3.5.2 (branches/release_35 229013) (llvm/branches/release_35 229009)

The CXX compiler /usr/local/llvm-3.5/bin/clang++ is:

	clang version 3.5.2 (branches/release_35 229013) (llvm/branches/release_35 229009)

The bitcode linker llvm-link is:

	LLVM version 3.8.1

The bitcode archiver llvm-ar is:

	LLVM version 3.8.1

Not using a bitcode store.

fixed.


Getting "Javascript error occured in the main process" Win10 x64

OS:
Win 10 x64
Issue Descriptions:
I've been running this app for many months (love it) and yesterday it started throwing this error:

Error
A Javascript error occurred in the main process
Uncaught Exception: SyntaxError Unexpected token

Then launching to a white screen.
I uninstalled, downloaded the latest from the site, and the installer is having the same issue :sob:
It does a cool load bar thing for a few seconds and pops the error.
Steps to Reproduce:
I'm guessing that I'm one of the lucky few running into this... since it's not even launching I'm not sure how to provide better info for debugging :disappointed:

Go ahead and delete your settings file and it should clear right up. Same solution as #1122

See https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/1122

Fixed it! Thanks so much!


Helm Chart?

Is your feature request related to a problem? Please describe.
The docker install process is pretty involved, trying to install Mercure on a kubernetes cluster could be quite tricky for less experienced admins. (me)
Describe the solution you'd like
Helm installation process ideally with a repo hosted on github. This likely wouldn't integrate into the current install.sh workflow too well.
Describe alternatives you've considered
a kubectl install could be more similar to other deployment methods in install.sh
Additional context
I'm going to start playing around with getting mercure installed on my kubernetes cluster and will update with any details I find. I'm going to try using kompose to convert the compose file but i'm not too hopeful it'll work out of the box, I haven't seen any of these x-... fields before.
If I were to successfully develop the helm deployment and make a pr would this be something you'd be open to accepting?
Thanks!

after some digging, it turns out this won't be as simple of an extension as I had hoped due to its dependency on spawning docker containers. adding kubernetes support would require code modifications for spawning jobs or pods instead. while it wouldn't be a crazy amount of reworking, it's more than I'm looking to support lol. Thanks for your willingness though, the project looks cool!


Make it easier to update registered resources' endpoint URLs in the GBIF Registry

After migrating the IPT to a new base URL, the IPT admin currently needs to press the "publish all resources" button in order to update the registered resources' endpoint URLs in the GBIF Registry. If this action isn't performed, the GBIF Registry won't have the resources' correct endpoint URL and thus GBIF won't be able to re-index them.
Republishing a lot of resources can be inconvenient, therefore the IPT needs to make it to update registered resources' endpoint URLs in the GBIF Registry. To do so, the IPT can sync all registered resources' endpoint URLs with the GBIF Registry every time the IPT admin updates the IPT registration.
Additional information:
This change requires an update to the user manual in the following sections:

Publish all resources
Edit GBIF Registration

Outstanding: user manual changes

Issue verified.

Changes to user manual completed in following sections:

https://github.com/gbif/ipt/wiki/IPT2ManualNotes.wiki#edit-gbif-registration
https://github.com/gbif/ipt/wiki/IPT2ManualNotes.wiki#publish-all-resources


stats: minor review comments

Signed-off-by: Rama<EMAIL_ADDRESS>Description:
Fixes remaning minor comments in PR https://github.com/envoyproxy/envoy/pull/3262
Risk Level: Low
Testing: Automated tests
Docs Changes: NA
Release Notes: NA

@mattklein123 @mrice32 @jmarantz
Addressed the review comments in the last PR. PTAL.

Specified the correct type
Removed lock in tlsHistogram
Made getTagsForName const

@mattklein123 Thanks. That is a good idea I think. I have changed the test to wait for histogram, counter and gauges as well. Should fix the flaky behaviour.

@jmarantz can you check if https://github.com/envoyproxy/envoy/issues/3238 is fixed?


chore: bdd-spring-1585376714 to 0.0.1

chore: Promote bdd-spring-1585376714 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


options to change the default server urls

Hi,
I just propose to permit the change of server urls, it's some times useful ;-)
The default behavior of the Provider does not change, just 2 new optional options.
The README talk about them :
$OpenStreetMapProvider = new \JBelien\OAuth2\Client\Provider\OpenStreetMap([
    'clientId'     => 'yourId',          // The client ID assigned to you by OpenStreetMap.org
    'clientSecret' => 'yourSecret',      // The client password assigned to you by OpenStreetMap.org
    'redirectUri'  => 'yourRedirectUri', // The return URL you specified for your app on OpenStreetMap.org
    'dev'          => false              // Whether to use the OpenStreetMap test environment at https://master.apis.dev.openstreetmap.org/
    /*
    For a particular need you can change the default server urls with this two options:
    'osm_base_url' =>  'https://www.openstreetmap.org',
    'osm_base_url_dev' => 'https://master.apis.dev.openstreetmap.org',
    */
]);

Thanks and cheers :-)

Hi @jbelien
Thanks you for having a look at this PR. Don't hesitate to ask me for corrections and improvements ;-)

Hi @jbelien
Will you accept this PR ? Any requirement ?
Thanks & cheers


Prevent Explorer from shutting down the node when embedded into a larger application

Want to verify that repeat crashing will allow Riak Explorer to die without ordering a shutdown of the whole VM when included as a top-level application.

@drewkerrigan any ideas on how this currently behaves?

@angrycub @paultannenbaum when Riak Explorer is included as a patch to the top level riak app, the way that it gets started is by piggybacking on Riak Control's entry point. Here is Riak Explorer's modified riak_control_sup.erl: https://github.com/basho-labs/riak_explorer/blob/master/src/riak_control_sup.erl#L69
Here's the original: https://github.com/basho/riak_control/blob/develop/src/riak_control_sup.erl#L66
This should be safe with regard to explorer dying as it exhibits the same behavior as the existing riak_control supervisor, let me know if you still have concerns about it though and we can investigate further @angrycub

Check #145 for a change which should address this

@angrycub This has been merged.  Is this issue resolved?


🐞 parse error if args contains multi colons, detail in issue #1409

Thank for your interested and going as as far as submitting a pull request! However, I'll be closing this, see the explanation in https://github.com/elastic/rally/issues/1409.


[Event Request] Codeunit 22 "Item Jnl.-Post Line" – New Event “OnItemValuePostingOnBeforeInsertOHValueEntry”

Could we please have a new publisher “OnItemValuePostingOnBeforeInsertOHValueEntry” in Function “ItemValuePosting”, Codeunit 22 " Item Jnl.-Post Line”, including a handle pattern?

    local procedure ItemValuePosting()
*** start new code ***
    var
        IsUnhandled: Boolean;
*** stop new code ***
    begin
        with ItemJnlLine do begin
            if ("Value Entry Type" = "Value Entry Type"::"Direct Cost") and
…
            OnItemValuePostingOnAfterInsertValueEntry(GlobalValueEntry, GlobalItemLedgEntry, ValueEntryNo);

*** start old code ***
            //if ("Value Entry Type" <> "Value Entry Type"::"Direct Cost") or
            //   ("Item Charge No." <> '')
            //then begin
*** stop old code ***
*** start new code ***
            IsUnhandled := ("Value Entry Type" <> "Value Entry Type"::"Direct Cost") or ("Item Charge No." <> '');
            OnItemValuePostingOnBeforeInsertOHValueEntry(ItemJnlLine, IsUnhandled);
            if IsUnhandled then begin
*** stop new code ***
                if ("Value Entry Type" <> "Value Entry Type"::Rounding) and (not Adjustment) then begin
                    if GlobalItemLedgEntry.Positive then
…
*** start new code ***
    [IntegrationEvent(false, false)]
    local procedure OnItemValuePostingOnBeforeInsertOHValueEntry(ItemJnlLine: record "Item Journal Line"; var IsUnhandled: Boolean)
    begin
    end;
*** stop new code ***

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Not linting code layout/whitespaces

Hello folks,
consider following crap code:
import numpy as np

def estimate_coef (x ,
                   y):
        # number of observations/points
        n = np.size( x)

        # mean of x and y vector
        m_x = np.mean(x )
        m_y = np.mean(y)

        # calculating cross-deviation and deviation about x
        SS_xy = np.sum(y*x) - n*m_y*m_x
        SS_xx = np.sum(x*x) - n*m_x*m_x

        # calculating regression coefficients
        b_1 = SS_xy/SS_xx
        b_0 = m_y - b_1*m_x

        return b_0 ,  b_1

Let's run flake8 against it.
$ poetry run flake8 lr.py
> lr.py:4:18: E211 whitespace before '('
lr.py:4:21: E203 whitespace before ','
lr.py:4:23: W291 trailing whitespace
lr.py:6:9: E117 over-indented (comment)
lr.py:10:24: E202 whitespace before ')'
lr.py:11:25: W291 trailing whitespace
lr.py:12:1: W293 blank line contains whitespace
lr.py:14:40: W291 trailing whitespace
lr.py:15:40: W291 trailing whitespace
lr.py:16:1: W293 blank line contains whitespace
lr.py:18:26: W291 trailing whitespace
lr.py:19:28: W291 trailing whitespace
lr.py:20:1: W293 blank line contains whitespace
lr.py:21:19: E203 whitespace before ','
lr.py:21:26: W291 trailing whitespace

According to PEP8 code layout and where to put whitespaces is pretty important stuff and clearly defined.
Ruff doesn't detect anything here whatsoever.  I've been pretty excited to check out this hot new thingy ruff hoping to happily migrate from flake8. I have no idea if it's by design or still not implemented but saying ruff can be put in flake8 place in your pipeline and everything will be ok is a bit far reach now.

⚖ Near-parity with the built-in Flake8 rule set

Guys, that's not near-parity. I've spent last 2 hours looking through docs, bugs thinking I've screwed up something since ruff wasn't showing anything.
Please don't read it as a rant.
It was pretty rough. I'd be pretty happy to contribute though as I have to start learning rust anyway ;p

By default, Ruff enables Flake8's E and F rules. Ruff supports all rules from the F category, and a subset of the E category, omitting those stylistic rules made obsolete by the use of an autoformatter, like Black.

Guys, no check can be made obsolete. Not everyone is using black or any other formatter. This is just hidden coupling. Even if I'm using auto-formatter you actually put linters after them in your pipeline. You need definitive check against PEP8 in your pipeline, no matter other tools you might be using.

Some of the rules are available with 0.0.269 https://github.com/charliermarsh/ruff/releases/tag/v0.0.269

I'm using the latest v0.0.270. I'm aware what is to be expected of v0.0.x but I have issue with this design mindset.
All of Python folks already solved that in the past and showed us how to walk it. It's clearly violating PEP20.
I just want ruff to become awesome linter and safe to use by juniors.

Errors should never pass silently.
Unless explicitly silenced.

I'm sorry that you had a rough experience. Candidly, it doesn't feel super productive to me to debate some of the questions raised above since you have strong opinions on them, and I'm not sure what we can do to address your concerns, other than the things we're already doing: these limitations are called out in the docs, and we actually are in the process of adding those rules (we've added most of them as experimental rules in the last few releases; soon, they will be part of the default E rule set, just as they are in Flake8, and so will be on-by-default for all users).
For context, a project of this scope requires constant prioritization, and the stylistic rules just weren't heavily prioritized since, empirically, that weren't blockers to enabling projects of all shapes and sizes to migrate to Ruff.


Cannot get custom metric

I've been trying to setup HPA based on AWS SQS queue depth using prometheus adapter for a while now. All configuration looks correct but i still cannot get past the below error. What am i doing wrong?
Warning  FailedComputeMetricsReplicas  8s (x6 over 83s)  horizontal-pod-autoscaler  invalid metrics (1 invalid out of 1), first error is: failed to get object metric value: unable to get metric approximate_number_of_messages: Service on <namespace1> <metric1>/unable to fetch metrics from custom metrics API: the server could not find the metric approximate_number_of_messages for services
Notes:
-- Prometheus service is running in prometheus namespace
-- Prometheus adapter is installed in monitoring namespace
-- Application service that requires scaling (service1) is running in namespace1
-- I've skipped listing some RBAC resources since they have annotations internal to my firm. In any case i don't think roles are a problem, since the error i get does not indicate an issue tied to access.
PROMETHEUS ADAPTER RESOURCES
configmap.yml

apiVersion: v1
kind: ConfigMap
metadata:
  name: prometheus-adapter-config
  namespace: monitoring
data:
  config.yaml: |
    rules:
    - seriesQuery: 'approximate_number_of_messages{kubernetes_namespace!="",kubernetes_pod_name!=""}'
      resources:
        overrides:
          kubernetes_namespace: {resource: "namespace"}
          kubernetes_pod_name: {resource: "pod"}
      name:
        matches: "approximate_number_of_messages"
        as: "approximate_number_of_messages"
      metricsQuery: sum(rate(<<.Series>>{<<.LabelMatchers>>,container_name!="POD"}[1m])) by (<<.GroupBy>>)

custom_metric_apiservice.yml
apiVersion: apiregistration.k8s.io/v1beta1
kind: APIService
metadata:
  name: v1beta1.custom.metrics.k8s.io
spec:
  service:
    name: prometheus-adapter
    namespace: monitoring
  group: custom.metrics.k8s.io
  version: v1beta1
  insecureSkipTLSVerify: true
  groupPriorityMinimum: 100
  versionPriority: 100

deployment.yml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: prometheus-adapter
  namespace: monitoring
spec:
  replicas: 1
  selector:
    matchLabels:
      name: prometheus-adapter
  strategy:
    rollingUpdate:
      maxSurge: 1
      maxUnavailable: 0
  template:
    metadata:
      labels:
        name: prometheus-adapter
    spec:
      containers:
        - args:
            - --cert-dir=/var/run/serving-cert
            - --config=/etc/adapter/config.yaml
            - --logtostderr=true
            - --metrics-relist-interval=1m
            - --prometheus-url=http://prometheus-service.prometheus.svc:9090/
            - --secure-port=6443
          image: <image_uri>
          name: prometheus-adapter
          ports:
            - containerPort: 6443
          volumeMounts:
            - mountPath: /tmp
              name: tmpfs
              readOnly: false
            - mountPath: /var/run/serving-cert
              name: volume-serving-cert
              readOnly: false
            - mountPath: /etc/adapter
              name: config
              readOnly: false
      serviceAccountName: prometheus-adapter
      volumes:
        - emptyDir: {}
          name: tmpfs
        - emptyDir: {}
          name: volume-serving-cert
        - configMap:
            name: prometheus-adapter-config
          name: config

networkpolicy.yml
apiVersion: projectcalico.org/v3
kind: NetworkPolicy
metadata:
  name: default.permit-prom-adaptor-api-access-app
  namespace: monitoring
spec:
  order: 301
  #selector: name == 'prometheus-adapter'
  types:
    - Egress
  egress:
    - action: Allow
      destination:
        namespaceSelector: all()
        selector: endpoints.projectcalico.org/serviceName == 'kubernetes' && provider == 'kubernetes' && component == 'apiserver' && projectcalico.org/namespace == 'default'
        ports:
          - 443
      protocol: TCP
---
apiVersion: projectcalico.org/v3
kind: NetworkPolicy
metadata:
  name: default.permit-adaptor-to-prometheus
  namespace: monitoring
spec:
  order: 301
  types:
    - Egress
  egress:
    - action: Allow
      protocol: TCP
      destination:
        namespaceSelector: prometheus == 'monitor'
        ports:
          - 9090

prometheus_adapter_service.yml
apiVersion: v1
kind: Service
metadata:
  labels:
    name: prometheus-adapter
  name: prometheus-adapter
  namespace: monitoring
spec:
  ports:
    - name: https
      port: 443
      targetPort: 6443
  selector:
    name: prometheus-adapter

APPLICATION SERVICE RESOURCES
deployment.yml
apiVersion: v1
kind: Namespace
metadata:
  labels:
    prometheus: monitor
  name: namespace1
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: service1
  namespace: namespace1
spec:
  selector:
    matchLabels:
      app: service1
  template:
    metadata:
      labels:
        app: service1
      annotations:
        prometheus.io/scrape: 'true'
        prometheus.io/port: '8443'
        prometheus.io/path: /queue_messages
    spec:
      securityContext:
        runAsUser: 999
      imagePullSecrets:
        - name: regcred
      serviceAccountName: service1-sa
      containers:
        - name: service1
          image: <image_uri>
          ports:
            - containerPort: 8443
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: service1-worker
  namespace: namespace1
spec:
  selector:
    matchLabels:
      app: service1-worker
  replicas: 1
  template:
    metadata:
      labels:
        app: service1-worker
    spec:
      securityContext:
        fsGroup: 99
        runAsNonRoot: true
        runAsUser: 99
      imagePullSecrets:
        - name: regcred
      containers:
        - name: service1-worker
          image: <image_uri>
          command: [ "/bin/bash", "-c", "--" ]
          args: [ "while true; do sleep 30; done;" ]

hpa.yml
apiVersion: autoscaling/v2beta2
kind: HorizontalPodAutoscaler
metadata:
  name: service1-hpa
  namespace: namespace1
spec:
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: service1
  minReplicas: 2
  maxReplicas: 20
  metrics:
    - type: Object
      object:
        metric:
          name: approximate_number_of_messages
        describedObject:
          apiVersion: v1
          kind: Service
          name: service1
        target:
          type: Value
          value: 10
  behavior:
    scaleDown:
      stabilizationWindowSeconds: 30
      policies:
        - type: Percent
          value: 100
          periodSeconds: 15

service.yml
apiVersion: v1
kind: Service
metadata:
  name: service1
  namespace: namespace1
  labels:
    app: service1
spec:
  ports:
    - name: metrics
      port: 9090
      targetPort: 8443
      protocol: TCP
  selector:
    app: service1

service_monitor.yml
---
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: service1
  namespace: namespace1
  labels:
    prometheus: monitor
spec:
  namespaceSelector:
    matchNames:
      - namespace1
  selector:
    matchLabels:
      app: service1
  endpoints:
    - port: metrics
      path: /queue_messages

LOGS
HPA events - ERROR
  Type           Status  Reason                 Message
  ----           ------  ------                 -------
  AbleToScale    True    SucceededGetScale      the HPA controller was able to get the target's current scale
  ScalingActive  False   FailedGetObjectMetric  the HPA was unable to compute the replica count: unable to get metric approximate_number_of_messages: Service on namespace1 service1/unable to fetch metrics from custom metrics API: the server could not find the metric approximate_number_of_messages for services
Events:
  Type     Reason                        Age               From                       Message
  ----     ------                        ----              ----                       -------
  Warning  FailedGetObjectMetric         8s (x6 over 83s)  horizontal-pod-autoscaler  unable to get metric approximate_number_of_messages: Service on namespace1 service1/unable to fetch metrics from custom metrics API: the server could not find the metric approximate_number_of_messages for services
  Warning  FailedComputeMetricsReplicas  8s (x6 over 83s)  horizontal-pod-autoscaler  invalid metrics (1 invalid out of 1), first error is: failed to get object metric value: unable to get metric approximate_number_of_messages: Service on namespace1 service1/unable to fetch metrics from custom metrics API: the server could not find the metric approximate_number_of_messages for service

Container is publishing the metric successfully. Below are results from running the command in the container
appuser@container[service1-xxxxx-xxxxx]:/# curl http://localhost:8443/queue_messages

approximate_number_of_messages 0

Custom metric - NO METRIC LISTED
kubectl get --raw="/apis/custom.metrics.k8s.io/v1beta1/"
{"kind":"APIResourceList","apiVersion":"v1","groupVersion":"custom.metrics.k8s.io/v1beta1","resources":[]

/retitle Cannot get custom metric
/kind support

Hi,
we had the same issue and the solution was in the config.yaml. We made the following changes:
    rules:     - seriesQuery: 'approximate_number_of_messages{namespace!="",pod!=""}'       resources:         overrides:           namespace: {resource: "namespace"}           pod: {resource: "pod"}
(basically "removing" the overrides). After that it all worked fine.

@jlange-koch But you still have the overrides in your snippet above. Did you mean to remove the overrides: tags?

/assign @olivierlemasle
/triage accepted

@olivierlemasle  I figured out the problem. Here is how i fixed the issue:

ServiceMonitor and Prometheus annotations cause conflict if used together. I removed the annotations and switched to Service Monitor only
prometheus.io/scrape: 'true'
prometheus.io/port: '8443'
prometheus.io/path: /queue_messages

I updated my ConfigMap overrides to use
kubernetes_namespace instead of namespace
kubernetes_pod_name instead of pod

like so:
- seriesQuery: 'approximate_number_of_messages{kubernetes_namespace!="",kubernetes_pod_name!=""}'
      resources:
        overrides:
          kubernetes_namespace: {resource: "namespace"}
          kubernetes_pod_name: {resource: "pod"}

Thank you @jimitkr for your closing comment.


feat(avm): e2e proving of storage

Benchmark results
Metrics with a significant change:

avm_simulation_time_ms (Token:mint_public): 528 (+737%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 59.8 (-69%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,746
1,551
697
768 (+4%)
766

proof_construction_time_sha256_30_ms
11,378 (-1%)
3,096 (+1%)
1,366
1,418
1,459 (+1%)

proof_construction_time_sha256_100_ms
43,619
11,735
5,418
5,399
5,345

proof_construction_time_poseidon_hash_ms
77.0 (-1%)
34.0
34.0
59.0 (+2%)
87.0 (-1%)

proof_construction_time_poseidon_hash_30_ms
1,518
419
201
240 (+8%)
268

proof_construction_time_poseidon_hash_100_ms
5,730
1,573
727
800 (+2%)
793

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,464
9,452
9,452

l1_rollup_execution_gas
610,285
610,273
610,273

l2_block_processing_time_in_ms
707 (+1%)
1,300 (+1%)
2,467

l2_block_building_time_in_ms
22,469
46,431 (+1%)
88,333 (+1%)

l2_block_rollup_simulation_time_in_ms
22,360
46,097 (+1%)
87,928 (+1%)

l2_block_public_tx_process_time_in_ms
19,224
42,640 (+1%)
84,660 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
6,021 (+2%)
8,573 (+2%)

node_database_size_in_bytes
9,474,128
12,742,736

pxe_database_size_in_bytes
9,242
15,127

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms

GasToken:_increase_public_balance
67.5 (-1%)

GasToken:set_portal
16.1 (-11%)

Token:constructor
95.0

FPC:constructor
60.4 (-1%)

GasToken:mint_public
53.0 (-2%)

Token:mint_public
:warning: 528 (+737%)

Token:assert_minter_and_mint
:warning: 59.8 (-69%)

SchnorrAccount:approve_public_authwit
32.0 (-1%)

FPC:prepare_fee
82.5 (+10%)

Token:transfer_public
43.9

FPC:pay_refund
72.0 (+7%)

Benchmarking:increment_balance
2,447 (+1%)

Token:_increase_public_balance
56.1 (+1%)

FPC:pay_refund_with_shielded_rebate
55.3 (-1%)

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.176 (-4%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.4
17.0
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.605
0.518
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
48.6
76.4
133 (-1%)
249 (+1%)
474 (-1%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
288
543
1,055
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.496
0.470
0.456 (-1%)
0.451 (+1%)
0.443 (-1%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
59.7
114 (+1%)
184 (-1%)
358 (+1%)
701
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
208
355
691
1,363
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.505
0.509
0.487 (-1%)
0.484 (+1%)
0.482
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
60.7 (+1%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
103

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.552

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
79,300
673,633

Transaction size based on fee payment method
| Metric |  |
| - |  |


Delete & Copy world methods causing crash

Hello,
Using the methods  Server.deleteWorld() and Server.copyWorld() cause a crash. Is it a known problem ? Or maybe I don't use it in the good way.
I saw a previous Issue about these features which was closed. I hoped it would work :(.

I believe those methods are not implemented in Sponge's current version yet, along with much of the API. You'll have to wait until they are to test whatever you're using them for.

Can you post a stacktrace of your crash?
Usually if something is not implemented that is used by plugins then the server does not crash.

This is an implementation issue, not an api issue.

Probarly not implemented.

Indeed, this is an implementation issue, the methods are not implemented. It doesn't cause a crash but an error. I was tired, I guess, sorry.
I will wait until they are implemented :).
Thanks


Revised longitude values for WNAI societies in "WNAI" > "societies.csv" place societies in eastern hemisphere

@bibiko, @xrotwang can you tell if this error entered via my files or in the creation of the society.csv file?
Note that the societies appear in the right place on maps (in western hemisphere).

For WNAI, origLong didn't come in any of the new files you sent, but instead was taken from https://github.com/D-PLACE/dplace-data/blob/master/legacy/LatLong_data.csv
Would have to investigate when and how that file entered the repository. Should I?
I understand that the revised longitudes are correct, right?

Hi @xrotwang, no, the revised longitudes are not correct - they should all have a minus sign in front of them (*-1), placing them in the western hemisphere. Otherwise they seem to be correct.

@kirbykat But that's the case: https://github.com/D-PLACE/dplace-data/blob/master/datasets/WNAI/societies.csv
Or which file are you looking at?

@xrotwang,  ah, sorry, this must been a 2 am-brain related issue. the revised lat/longs are indeed correct.


connectivity: egress HTTP and policy w/ toFQDNs

Best reviewed per commit.

Added test client-egress-l7 for HTTP filtering with and without toFQDNs. Only client Pod 'other' is allowed to generate HTTP traffic.
Some fixups to the yaml parser and error reporting.
Run PodToWorld calls to google.com from all client Pods.
Execute connectivity.Run() inside its own goroutine.

Converted to draft as it's currently blocked on https://github.com/cilium/cilium/issues/16376 and L7 ingress policy test needs to be added.


Invite players to team

Search for players, if not found send invite via email

When inviting a new user, log invite and use that to add them to team when they join


Update SBOM-wiki/about-us.md to fix Charter link

The Charter link at the bottom of about-us page results in a not found error. This updates the link to the file as it resolves on GitHub.

@GeauxJD I just saw that this is still marked as work in progress. Do you intend to add some more fixes or should i merge this?

Hello, no other changes planned. I didn't click the "Review" button, sorry! Have done so now.

Ah great. Than i will merge it right away.


toggling k8s configuration with a relevant property fixes gh-585

To enable or disable only the k8s configuration feature it's expected to use the relevant property spring.cloud.kubernetes.config.enabled=true/false, without a need to disable Kubernetes itself using property 'spring.cloud.kubernetes.enabled. With this modification, it's possible to disable only the configuration feature using property spring.cloud.kubernetes.config.enabledor when choosing to completely turn off Kubernetes usingspring.cloud.kubernetes.enabled`.

@Haybu can you look at the failures?

@Haybu merge it into master as well


SubSquid tutorial

Similarly to #2715 It would be nice to have tutorial where devs can learn how to extend the rubick service

@thea-exe do you think you could help to write a tutorial on this? :)

@yangwao this should be a hands-on session similarly to #2715 :)

write a tutorial

Should be released imo :)

Yes!
On Mon, May 2, 2022 at 6:34 AM Viki Val @.***> wrote:

@yangwao https://github.com/yangwao this should be a hands-on session
similarly to #2715 https://github.com/kodadot/nft-gallery/issues/2715 :)
write a tutorial
Should be released imo :)
—
Reply to this email directly, view it on GitHub
https://github.com/kodadot/nft-gallery/issues/2721#issuecomment-1114708967,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APSXNDTEF7BVGGHDFE6KSNDVH6VS3ANCNFSM5SFNKVLA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I would also love that tutorial because right now I am avoiding all SubSquid tagged issues

I would also love that tutorial because right now I am avoiding all SubSquid tagged issues

Hey! There's a PR looking to be approved for this. For now, you can reference https://youtu.be/7eQu_KS1TJk :)

meanwhile https://docs.subsquid.io/tutorials/create-a-simple-squid/

yeah spoke to Wao, he said wanted one specifically from KodaDot when I
wrote this.
On Mon, Sep 12, 2022 at 8:15 AM roiLeo @.***> wrote:

meanwhile https://docs.subsquid.io/tutorials/create-a-simple-squid/
—
Reply to this email directly, view it on GitHub
https://github.com/kodadot/nft-gallery/issues/2721#issuecomment-1243652063,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APSXNDVPTYBCPQIDXVMZK63V54NFZANCNFSM5SFNKVLA
.
You are receiving this because you were mentioned.Message ID:
@.***>


remove duplicate license

The license file is included two times and one is at the wrong place.
If we take a look at the wheel dist, we can see there is LICENSE at the root and also graphinder-1.11.5.dist-info/LICENSE:
$ 7z l dist/graphinder-1.11.5-py3-none-any.whl | grep -i license
1980-01-01 00:00:00 .....         1118          661  LICENSE
1980-01-01 00:00:00 .....         1118          661  graphinder-1.11.5.dist-info/LICENSE

But this is an issue, because when you install it on your system, it deploys one of the license file on the root path of the python site package directory:
$ tar tvf graphinder-1.11.5-1-any.pkg.tar.zst | grep -i license
-rw-r--r-- root/root      1118 2022-11-25 11:27 usr/lib/python3.10/site-packages/LICENSE
-rw-r--r-- root/root      1118 2022-11-25 11:27 usr/lib/python3.10/site-packages/graphinder-1.11.5.dist-info/LICENSE

So by removing the LICENSE from include it will remove usr/lib/python3.10/site-packages/LICENSE but keep usr/lib/python3.10/site-packages/graphinder-1.11.5.dist-info/LICENSE.
Other packages like https://github.com/nikitastupin/clairvoyance/pull/55 have the same issue which conflicts and prevent installing new tools with the same issue.
error: failed to commit transaction (conflicting files)
clairvoyance: /usr/lib/python3.10/site-packages/LICENSE exists in filesystem (owned by crackmapexec)

Interesting, was not aware of such behavior.
I'll build on my side an make sure the license is still shipped.

Codecov Report
Base: 86.94% // Head: 86.94% // No change to project coverage :thumbsup:

Coverage data is based on head (4df498e) compared to base (939e88e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   86.94%   86.94%
=======================================
  Files          20       20
  Lines         567      567
=======================================
  Hits          493      493
  Misses         74       74

Flag
Coverage Δ

unittests
86.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Maybe when the license field is set it automatically includes it so there is no need to put it in the include field. But anyway it shouldn't be place here. IDK if it's specific to poetry because building it pip does the same.

Fixed in both v1 and v2.
Packages are deploying.


Apple TV+

Apple TV+ please! I would but I'm not sure what to look for!

Apple TV+
https://tv.apple.com/
No
Sometimes

Also eagerly awaiting Apple TV+ support!

any chance this is being worked on by the dev?


Updates to listing notification email

Doorway would like to add some language to the listing notification email

Add listing due time to new listing notification emails
Add a sentence  in the email that says “Please refer to the listing for the most accurate information, as it is subject to change.”

AC:

The listing closure time is displayed on the email (in addition to the date)
New copy is displayed on the listing
Applicant receives emails in their preferred language, all strings are translated
Date and times on email blast are displayed in the email in PST

Placement of new line of copy TBD and needs to be approved by BAHFA
We have a template to work off of

Hard to test without access to govdelivery
Morgan will have to set that up for whoever is testing it, account is owned by BAHFA
Morgan can't add everyone to the UI but can add everyone to the distribution list

Looks like we don't have a unit test for this email, so I'm adding one to aid development as well as validate in automated tests.


Add support for adding Protected Tags

Prerequisites:

Is the functionality available in the GitHub UI? If so, please provide a link to information about the feature.
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-tag-protection-rules

Is the functionality available through the GitHub API? If the functionality is available, please provide links to the
API documentation (https://developer.github.com/v3/) as well as the Octokit documentation (https://octokit.github.io/).
https://docs.github.com/en/free-pro-team@latest/rest/repos/tags?apiVersion=2022-11-28#create-a-tag-protection-state-for-a-repository

New Feature
Adding the ability to add protected tags via the .github/settings.yml file. Similar to how branches and branch protection is added,  adding the ability to specify a list of patterns to add as protected tags.
e.g.
tags:
  - protection:
       pattern: ["v1", "release/*, "latest"]

it seems like github is suggesting that defining tag protections as part of repository rules is now preferred over this approach, i'm wondering if adding support directly for tag protections at this point makes sense for this project.
adding support for repository rules is a high priority for me. if that were implemented, is there still a need for this functionality to also be added?


Error connecting to JIRA: The underlying connection was closed: Could not establish trust relationship for the SSL/TSL secure channel

We use a non public JIRA instance, which has no current certificates at the moment. Would it be possible to bypass/configure the application to bypass the SSL connection?

Well you could add your own internal root CA certificate as a trusted source. But I do not have a lot of experience with this myself.


Bellhop.disconnect() doesn't work

If you disconnect and reconnect, you end up receiving each message twice.
This is due to the fact that Bellhop.disconnect() doesn't release the event listener. Indeed, addEventListener (see this line) and removeEventListener (see this line) are not called on the same function.

Okay, this should be resolved now!


fix/test test.aria.templates.customization.CustomTemplateTestCase

This commit fixes a random issue happening at the end of CustomTemplateTestCase:
restoring the environment at the end of the test triggers an XHR which can cause issues on the following tests in the test campaign.

@benouat Thank you for your review!


cataclysm-dda-git: remove incompatible patches, bump git

Description of changes
update git variety of cataclysm-dda by removing patches that are no longer applicable (and hopefully not required)
note that i've actually done this while working on adding Cataclysm: Bright Nights (a fork of C:DDA) package. if this PR is not going to be reviewed/merged i'm likely just going to fuse this into upcoming PR for that
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Seems to be working fine on NixOS, can't check the Darwin issue myself.

@DeeUnderscore done

@rardiol @DeeUnderscore would you say it would make sense for Bright Nights fork package to be included (lets say as bn.nix and bn-git.nix) in the same directory or keep them separate? so far it seems the only compilation change required (besides different source) -Wno-ignored-attributes flag

On Tuesday, 30 July 2024 17.14.23 GMT-3 caryoscelus wrote:

@rardiol @DeeUnderscore would you say it would make sense for Bright Nights
fork package to be included (lets say as bn.nix and bn-git.nix) in the same
directory or keep them separate? so far it seems the only compilation
change required (besides different source) -Wno-ignored-attributes flag
If it is a fork and is essentially the same derivation and both will evolve
together I think it makes sense to keep both in the same directory.

Tested with Linux, works fine. Could we merge this PR separately, now, to get a baseline working, and then continue working on C:BN?

@cizra that was what i expected

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1931

Waiting for someone with merge access, then... I wonder if there's a procedure to get their attention.

There is a thread on the Discourse that can be used for that, where I've posted this (see previous automated comment)


[1.2.x] Fix the extraHash used when reading a V1 file

This backports #581 which fixes an issue introduced in #542, the fix
wasn't backported when #542 itself was backported in #599.
Setting extraHash to apiHash is not safe because in
IncrementalNameHashing#sameAPI an error is emitted if the extra hashes
are different and the class is not a trait. Setting it to 0 should be
safe since that's the value used for things which are not traits.

To validate this pull request against other sbt modules, please visit this link.

@eed3si9n I suggest releasing an sbt 1.2.5 asap with that fix in to prevent more confusion like https://gitter.im/sbt/sbt?at=5bbbbcea6e5a401c2d39580f

Sounds like a good idea to get it out soon.

to help searchers, the error message is "different extra api hashes for no traits" (at least, that's the one I've seen)

also to help searches: you can work around this issue by running "sbt clean".

clean doesn't help for me. I see this on current akka master (bf4a6c37b4) now

updating to sbt 1.2.6 solves the issue (didn't know it was released at first)

Hi.
clean also did not help for me, when upgrading to 1.2.4.
I now also see this when using 1.2.6:
[error] one error found
[error] java.lang.RuntimeException: A fatal error happened in `SameAPI`: different extra api hashes for no traits!
[error]   `eve.publish.codegen.package`: 0
[error]   `eve.publish.codegen.package`:<PHONE_NUMBER>
[error]
[error] 	at scala.sys.package$.error(package.scala:26)
[error] 	at sbt.internal.inc.IncrementalNameHashing.sameAPI(IncrementalNameHashing.scala:52)
[error] 	at sbt.internal.inc.IncrementalCommon.sameClass(IncrementalCommon.scala:204)
[error] 	at sbt.internal.inc.IncrementalCommon.$anonfun$changedIncremental$1(IncrementalCommon.scala:186)

Could this be due to me upgrading to 1.2.4 first, which already writes a v2 file with the extra hash information?

That would be my guess, yes :+1:

Hi!
I have the same issue as @avdv - upgrading to 1.2.6 helped 1 project, for other I still see the error:
[error] java.lang.RuntimeException: A fatal error happened in `SameAPI`: different extra api hashes for no traits!
[error]   `org.recmap.MapRecursiveExtensions`: 0
[error]   `org.recmap.MapRecursiveExtensions`:<PHONE_NUMBER>

I deleted ~/.ivy2/cache contents, all target directories, and still the same error.

Are you sure you have removed all target directories in your project? The fact that sbt is able to deserialize the previous compilation analysis means you probably haven’t cleaned all the target directories, as that’s the only place where the analysis files are written.

Is it possible, the issue might stem from a dependency, that is a git repository?
It has sbt=1.2.4 in build.properties. If I change checkout it locally and change to 1.2.6,, it compiles without error. Going back to 1.2.4 does not produce error any more.

Is it possible, the issue might stem from a dependency, that is a git repository?

Yes, absolutely :smile: If you're using a git repository as a dependency and you're not yet on 1.2.4, sbt will use the zinc compiler in 1.2.4 to compile.

I got this error when upgrading from 1.2.3 to 1.2.6 in scalaz-zio build.
[error] java.lang.RuntimeException: A fatal error happened in `SameAPI`: different extra api hashes for no traits!
[error]   `scalaz.zio.package`: 0
[error]   `scalaz.zio.package`: -1375558950

It might be possible to reproduce it from this branch ..???
https://github.com/scalavision/scalaz-zio/tree/hashing-failure-with-1.2.6-sbt.
So, might this have been introduced before 1.2.4?

I just ran into this using sbt 1.2.6, and for some reason running clean did not solve the issue.
But running git clean -f worked.

That's what I thought too, but it was lm, and lmRoot covers all the subprojects:
lazy val lmRoot = (project in file("."))
  .aggregate(lmCore, lmIvy, lmCoursier)

including the ones I had issue with, which I think was core. I wonder if there's some cache stickiness caused by the metabuild, which clean won't get to.

I wonder if there's some cache stickiness caused by the metabuild, which clean won't get to.

Agreed, sounds like a plausible hypothesis.

If it can help, I just had the issue when migrating a project from 1.2.3 to 1.2.6. Issuing sbt clean in the project directory solved it , which corroborates with the metabuild hypothesis.

If it can help, I just had the issue when migrating a project from 1.2.3 to 1.2.6. Issuing sbt clean in the project directory solved it , which corroborates with the metabuild hypothesis.

Same. I ran clean while in sbt console on root project and it didn't worked but it worked when I ran sbt clean from the terminal inside the project dir.

I just encounteded the same issue with SBT 1.2.6. In my case, an sbt clean inside the project dir didn't resolve the issue. From my experience, it seems that the frequency of the error has been reduced, but there is still a chance that it will turn up.


I got this error when running inference.py, can you help me fix this?

RuntimeError: CUDA error: invalid device ordinal
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with TORCH_USE_CUDA_DSA to enable device-side assertions.

Hi @gallilmaimon,
The same issue was produced from my side.
I tried with different torch versions.
torch1.9+cu111
torch1.10+cu102
torch1.13+cu117

I'm using Python3.8 and CUDA is enabled.

This seems to be that the default value for the num_gpus argument in the config for sr for VCTK is 2, which means it won't work out of the box on single GPU machines.
Try changing this line https://github.com/gallilmaimon/DISSC/blob/d4ceca7f91c4e6afc96618649745e902fc2de720/sr/configs/VCTK/hubert100_lut.json#L9 in file '''sr/configs/VCTK/hubert100_lut.json''' to 1.
If this solves the issue as expected I will update the default config for single GPU and add a comment in the readme file. Let me know.

@gallilmaimon
Unfortunately, this is not working. I tried with num_gpus: 2.

@gallilmaimon
Thanks for your reply.
Here's the whole error message when running python sr/inference.py --input_code_file data/unseen/pred_hubert/p231_encoded.txt --data_path data/unseen/wav --output_dir dissc_p231 --checkpoint_file sr/checkpoints/vctk_hubert --unseen_speaker --id_to_spkr data/Syn_VCTK/hubert100/id_to_spkr.pkl --vc
Process SpawnPoolWorker-8:
Traceback (most recent call last):
  File "C:\Users\{user}\anaconda3\envs\dissc\lib\multiprocessing\process.py", line 315, in _bootstrap
    self.run()
  File "C:\Users\{user}\anaconda3\envs\dissc\lib\multiprocessing\process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Users\{user}\anaconda3\envs\dissc\lib\multiprocessing\pool.py", line 109, in worker
    initializer(*initargs)
  File "E:\models\voice_conversion\DISSC\sr\inference.py", line 114, in init_worker
    generator = CodeGenerator(h).to(idx)
  File "C:\Users\{user}\anaconda3\envs\dissc\lib\site-packages\torch\nn\modules\module.py", line 987, in to
    return self._apply(convert)
  File "C:\Users\{user}\anaconda3\envs\dissc\lib\site-packages\torch\nn\modules\module.py", line 639, in _apply
    module._apply(fn)
  File "C:\Users\{user}\anaconda3\envs\dissc\lib\site-packages\torch\nn\modules\module.py", line 662, in _apply
    param_applied = fn(param)
  File "C:\Users\{user}\anaconda3\envs\dissc\lib\site-packages\torch\nn\modules\module.py", line 985, in convert
    return t.to(device, dtype if t.is_floating_point() or t.is_complex() else None, non_blocking)
RuntimeError: CUDA error: invalid device ordinal
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "C:\Users\{user}\anaconda3\envs\dissc\lib\multiprocessing\pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "C:\Users\{user}\anaconda3\envs\dissc\lib\site-packages\torch\autograd\grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "E:\models\voice_conversion\DISSC\sr\inference.py", line 177, in inference
    code, gt_audio, filename, _ = dataset[item_index]
  File "E:\models\voice_conversion\DISSC\sr\dataset.py", line 269, in __getitem__
    mel_loss = mel_spectrogram(audio, self.n_fft, self.num_mels,
  File "E:\models\voice_conversion\DISSC\sr\dataset.py", line 54, in mel_spectrogram
    mel = librosa_mel_fn(sampling_rate, n_fft, num_mels, fmin, fmax)
TypeError: mel() takes 0 positional arguments but 5 were given
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "sr/inference.py", line 363, in <module>
    main()
  File "sr/inference.py", line 354, in main
    for i, _ in enumerate(pool.imap(inference, idx), 1):
  File "C:\Users\{user}\anaconda3\envs\dissc\lib\multiprocessing\pool.py", line 868, in next
    raise value
TypeError: mel() takes 0 positional arguments but 5 were given

It's working now. Thanks.

That's great! Anything particular regarding librosa versions or something you changed that I should note in the requirements or readme? If not I think I will close the issue for now :)

Sure, it was librosa.
Should add librosa==0.9.1 to the requirements.txt.


Automatic channel status - percentage based on time

I would love to see a more detailed options for the automatic channel status posting.
Currenly it is only based on percentage of a print. If i print only takes a couple of minutes to print the status is spammed way to often.
Not sure what is the best fit here but i would love seeing something like "post every 10%, but only if last message was 30min ago, or post if last message was 2 hours ago if if 10% haven't reached yet"
Thanks alot!

You mean minimum Time between Messages?

Will come in 0.0.3

https://github.com/eliteSchwein/mooncord/wiki/Status-Configuration wiki entry is now present


Job title should be a searchable field.

User Story
Should be able to search for people by job title

T-shirt size: S(mall), M(edium), L(arge)

User Story
"As a user of a NeXt, I would like to be able to add job title to my search queries to help me find the correct set of results."

Description
relates to story #1245 and to #1111 Search

Acceptance Criteria/Tests
Verify that any search box that is expected to return People we should be able to query on job title.

Question:  This seems to be of limited usefulness unless we can combine terms to query on...  Like "name contains John AND title contains Architect" -- maybe just a V2 feature?

migrated to new tmobile/sawtooth-next-directory repo


feat: get images on main

For more details refer to the following issue: https://github.com/canonical/bundle-kubeflow/issues/679
Summary of changes:

Added script that produces list of container images managed by charm in this repository. Image list is a dynamic list.

NOTE: Script replaced outdated get-images-1.7-stable.sh script.

Not sure if we should merge this since https://github.com/canonical/metacontroller-operator/issues/80. If I send a PR for this, then we should modify this script as well.

@phoevos Updated with your suggestion. Please approve and merge when ready.

CI is green, @i-chvets feel free to merge!