Does not build in Xcode 10 by dragging project into workspace

The problem is the iOS target's copy-frameworks phase. This fails, because I am not using carthage in my build pipeline for my application, purposefully.
I don't think a framework should have a "copy-frameworks" phase. This should be reserved for executables.

This is a false alarm, seems I had an invalid submodule propagated through carthage in the first place, and ReSwift-Router's copy-frameworks phase was what was failing. Not sure how it got in this state, but a fresh clone builds. Sorry for the false alarm.
@DivineDominion Though if you would like to continue the discussion about why the "copy-frameworks" phase is needed, that's fine. Because I still do fine that odd.

Looks like I made a mistake back when I reorganized things. Thanks for pointing this out!

Sounds good, thanks @mjarvis !

@mjarvis I just remembered a theory about why my Git/Carthage barfed. So the repo is ReSwift/ReSwift-Router, but the Carthage instructions say github "ReSwift/ReSwiftRouter". Test Github serves up a 301 at this URL, but there might be something weird going on with Carthage in terms of parsing and what not. I remember I changed my Cartfile to ``github "ReSwift/ReSwift-Router"and recloned and everything was working fine from that point on. I thought it might have been a fluke, but maybe it is related to that-` and the 301?


AssignmentPattern not available

The node type AssignmentPattern is not allowed in escodegen, or atleast the online demo on esprima.org

Looks like it works to me. Re-open with a repro case against master or ask esprima to update their online demo.


Remove custom decoding function from SourceKitLSPOptions

We forgot to decode the following keys in the custom decode function, which meant that you couldn’t set them using SourceKit-LSP’s config.json file.

backgroundPreparationMode
sourcekitdRequestTimeout
cancelTextDocumentRequestsOnEditAndClose

We had the custom decoder function so that the keys weren’t required in the JSON but we could access eg. SwiftPMOptions without needing to deal with optionals in the codebase.
Make the accesses to these nested options structs a little more verbose but eliminate the source of the above bug, which seems like a good tradeoff.

@swift-ci Please test

@swift-ci Please test Windows


Fix DelayedLoadUnloadWrapper tests not completely waiting for load

Checking just the reference count is not enough due to the create function being called immediately (https://github.com/ppy/osu-framework/blob/master/osu.Framework/Graphics/Containers/DelayedLoadUnloadWrapper.cs#L17).


[Bug]: scope to tenant not respected on nested resource

What happened?
When I create a record of a nested resource - in this case a page which is nested to a document - I get a 500 error as team_id isn't present on the nested resource table.
Documents are scoped to tenants but pages don't have to be as they belong to documents.
How to reproduce the bug
Create a resource and a nested resource. Set scopedToTenant as false on the nested resource.
Package Version
1.0.0
PHP Version
8.3
Laravel Version
10
Which operating systems does with happen with?
macOS
Notes
I may be using the package wrong and if so please let me know what I should've done differently.
Thanks for an excellent plugin!

@jamessessford Hi, thanks for the bug report. Can you provide a test repository with the bug? I tried reproducing it as you described and I can disable tenant scoping without an issue.

I will bud! Is there any chance you can put the test repo you've made up to see if I've just made a mistake?

Sorry it took a little longer than I expected @lukas-frey - the test repo is available at https://github.com/jamessessford/nested-resource-bug

Sorry it took a little longer than I expected @lukas-frey - the test repo is available at https://github.com/jamessessford/nested-resource-bug

Thanks for the repo. The issue is that you're trying to set one of the child nested resources (not the root nested resource) as not scoped. However, since the CreateDocumentPage is a DocumentResource page, not a PageResource page, it uses the isScopedToTenant setting from DocumentResource, not PageResource (CreateRelatedRecord class line 184).
Currently there's no easy way for me to know the related resource without introducing another property you need to manually set in each page, which is not something I'm too inclined to do right now.
What's the use case actually here? Why do you need to disable scoping on the PageResource? It belongs to a document, which is scoped to a tenant anyways, so it will still be scoped to a tenant via this relationship. Is it really necessary to have it disabled? Maybe I'm missing something.
Anyways, your best best for now is to override the handleRecordCreation method in your CreateDocumentPage class and replace the static::getResource() call with the actual resource (PageResource) in your case.

Thanks for checking it out @lukas-frey

What's the use case actually here? Why do you need to disable scoping on the PageResource? It belongs to a document, which is scoped to a tenant anyways, so it will still be scoped to a tenant via this relationship. Is it really necessary to have it disabled? Maybe I'm missing something.

Not entirely needed no - I'm was just trying to keep the database smaller and because a document already belonged to a tenant, it seemed a wasted field to also include it on the pages. They can only be browsed via the DocumentResource so didn't need to be scoped.

Anyways, your best bet for now is to override the handleRecordCreation method in your CreateDocumentPage class and replace the static::getResource() call with the actual resource (PageResource) in your case.

Thanks, I'll give this a shot when I'm looking at it again.

@lukas-frey - I think I've fixed this in my local version - are you happy if I raise a pull request for you to have a look at?

@lukas-frey - I think I've fixed this in my local version - are you happy if I raise a pull request for you to have a look at?

Sure, you're more than welcome to create a PR and I'll have a look! :)

Thanks, @lukas-frey
#32


Auto dismiss alert

Hi,
I want my alert auto dismiss in x seconds, how can I setup it?
Thanks

You can create your own thread to process this.
LGAlertView *alertView = [LGAlertView alertViewWithXxxxx];
[alertView performSelector:@selector(dismissAnimated) withObject:nil afterDelay:3.f]; // dismiss in 3 seconds

Or you can use dispatch_after
https://developer.apple.com/documentation/dispatch/1452876-dispatch_after


Issues Starting Course

Summary
When attempting to start the course, the repository doesn't update after waiting 20 seconds and refreshing the page.
How to reproduce

Go to https://github.com/skills/reusable-workflows
Right-click on 'Start This Course' and open in new tab
Wait 20 seconds and refresh pages
See error (page/repo readme.md doesn't update to reflect next steps)

Additional context
I was able to reproduce this issue on the following Skills page activities:
-Secure your repository supply chain
-Secure code game
-Introduction to CodeQL
-Change commit history
-Introduction to secret scanning
https://github.com/skills/reusable-workflows/assets/100397897/3b30024c-15b4-4dc8-b44d-774503c5b08d

All workflows are stopped with an error.
https://github.com/kieferland/skills-reusable-workflows/actions/runs/9472867340
It is likely that the error is a result of this incident (Jun 11, 20:33 - 21:39 UTC), for the commit time is Jun 11, 21:05 UTC.
https://www.githubstatus.com/incidents/lfrlwdg67fn8

Thank you, Shinsuke!  I have book marked the GitHub status website for future reference, cheers.


[bug] pipe crashing at deno runtime level ($200)

https://github.com/denoland/deno_core/issues/898
/bounty 200
definition of done:

does not crash anymore

Hi @louis030195, I've taken a look at the deno/rust files, and I'm wondering why everything is set up on rust instead of letting the deno file run the parallelism. They have the Thread package, which probably should be more deterministic here. What do you think?

@ologbonowiwi not familiar with deno, it's my first time using it, all i want ideally is:

dev can write pipes (plugins) in ts/js
can use dependencies do for example bun i ai, use normal import, all normal code and not weird deno import
can write some abstraction/sdk to facilitate getting screenpipe data into LLMs

atm what does not work:

cannot use dependencies
deno crashes sometimes

the thread package seems interesting but i'd prefer people can just write normal js without problem and since most people these days use chatgpt to write code, it unlikely will use thread package (maybe im wrong)

ideally we could have common js code -> run through through our deno code that uses the Thread package (and therefore can be parallelized without the hurdle of users doing it themselves)
It’s my first time looking into an issue on the project so I’m not sure how it really works. any place where I could learn more about this part of the project? I need to gain more context on this but I have a good knowledge on js side so if I fill that gap I can handle this issue. /attempt #445

https://github.com/mediar-ai/screenpipe/blob/main/screenpipe-core/src/pipes.rs
and the deno folder
these are the only deno related code

If anyone wants, feel free to pick this up.
I heard that Deno has significant challenges making its runtime compatible with Node. I think there's a high chance we’re missing something Deno would natively do in case we use their CLI (or even starting their runtime in Rust, but not doing the back-and-forth to “mock” things like filesystem and fetch calls).
Besides, we were not leveraging the event loop's power to do asynchronous processing (I/O, network calls, and so on). We’d be better off relying on the already-established tools of the JS runtime/ecosystem to do this heavy work and only having a specific layer inject some dependencies, such as custom pipes.
I'm refraining from working on this because I think the way we're handling the script running is more complex than I anticipated.
Besides that, I think the way it is currently done has a high risk of unexpected behavior. If I’m using fetch, I expect it to behave as it has been in browsers forever. But since we're using reqwest under the hood, the original assumption of someone used to the actual fetch from chrome/node/deno is wrong, which can bring debug issues for ppl who need to create pipes in the future.
I'd recommend reframing our approach to rely most on the deno runtime and letting it do its magic on running the Js/ts scripts or creating explicitly different helpers. I mean, if we want to keep the filesystem requests on rust-land, per se, we could export pipe.writeFile instead of having a “fake” fs.writeFile, which does not rely on libuv as most JavaScript runtimes do. Besides that, with the deno, I believe we’d have dependencies importing out of the box.

I can't speak much to the above but I know that BorrowMutError is a consequence of using deno in tokio's multi-thread runtime. Deno needs to a in a current-thread runtime. I can make an /attempt #445, but the tricky part is going to be how to decide how to mix it in with the existing multi-threaded runtime.

but the tricky part is going to be how to decide how to mix it in with the existing multi-threaded runtime

Yeah, I think we can have issues with the fact we are relying on Tokio threads to do async stuff such as filesystem calls.
imo, we'd be better off handing this to deno (cause they already support it anyways)

I heard that Deno has significant challenges making its runtime compatible with Node. I think there's a high chance we’re missing something Deno would natively do in case we use their CLI (or even starting their runtime in Rust, but not doing the back-and-forth to “mock” things like filesystem and fetch calls).
Besides, we were not leveraging the event loop's power to do asynchronous processing (I/O, network calls, and so on). We’d be better off relying on the already-established tools of the JS runtime/ecosystem to do this heavy work and only having a specific layer inject some dependencies, such as custom pipes.
Besides that, I think the way it is currently done has a high risk of unexpected behavior. If I’m using fetch, I expect it to behave as it has been in browsers forever. But since we're using reqwest under the hood, the original assumption of someone used to the actual fetch from chrome/node/deno is wrong, which can bring debug issues for ppl who need to create pipes in the future.
I'd recommend reframing our approach to rely most on the deno runtime and letting it do its magic on running the Js/ts scripts or creating explicitly different helpers. I mean, if we want to keep the filesystem requests on rust-land, per se, we could export pipe.writeFile instead of having a “fake” fs.writeFile, which does not rely on libuv as most JavaScript runtimes do. Besides that, with the deno, I believe we’d have dependencies importing out of the box.
I'm refraining from working on this because I think the way we're handling the scripts running is the root cause of our issues, and fixing it is more complex than I anticipated.

do you mean something like
multiple deno projects in a multi-folder setup with a single cli command. here's how you can set it up:

create a root directory for your projects
add subdirectories for each project
create a main script to import and run all projects

here's a quick example structure:
root/
├── project1/
│   └── main.ts
├── project2/
│   └── main.ts
├── project3/
│   └── main.ts
└── run_all.ts

in your run_all.ts file, you can import and run all the projects:
import "./project1/main.ts";
import "./project2/main.ts";
import "./project3/main.ts";

console.log("all projects started");

then, you can run everything with a single command:
deno run --allow-read --allow-net run_all.ts

make sure to include any necessary permissions flags (like --allow-read or --allow-net) that your projects might need.
pro tip: if your projects are more complex and need to be initialized or have async operations, you could modify run_all.ts to handle that:
import { start as start1 } from "./project1/main.ts";
import { start as start2 } from "./project2/main.ts";
import { start as start3 } from "./project3/main.ts";

async function runAll() {
  await Promise.all([
    start1(),
    start2(),
    start3(),
  ]);
  console.log("all projects started");
}

runAll();

eg.
rust -> run deno cli that run some js code that import all pipes and run them
or (AI suggestions):
Based on the provided code for pipes.rs and pipe_manager.rs, here are 10 high-level ways you could host pipes using Deno:

Deno Deploy:
Use Deno's serverless platform to host each pipe as a separate serverless function.

Deno HTTP Server:
Create a simple HTTP server using Deno's standard library to serve pipes.

Oak Framework:
Utilize the Oak middleware framework for Deno to create a more robust API for serving pipes.

WebSocket Server:
Implement a WebSocket server in Deno to allow real-time communication with pipes.

Deno Worker Threads:
Run each pipe in a separate Deno worker thread for improved concurrency.

Deno Plugins:
Develop Deno plugins to extend functionality and host pipes as loadable modules.

Deno with Docker:
Containerize your Deno application and pipes for easy deployment and scaling.

Deno CLI Tool:
Create a CLI tool using Deno that can run pipes locally or on remote servers.

Deno with Kubernetes:
Deploy your Deno application and pipes on a Kubernetes cluster for orchestration.

Deno Static File Server:
Use Deno's file server capabilities to serve static pipe files and execute them on demand.

To implement any of these approaches, you'd need to modify your existing code to work with Deno instead of the current runtime. This would involve adapting the module system, using Deno-specific APIs, and potentially restructuring parts of your application.

rust -> run deno cli that runs some js code that imports all pipes and runs them

That's precisely it. But if I'm not mistaken, deno is mostly Node-compatible (source: Node APIs).
I think it would be great to have a Rust layer that instantiates the Deno runtime, as we already have it. We then run the run_all.ts file, which can receive some arguments (such as the pipes it needs to execute).
Alternatively, we can somehow handle this to deno cli and mention to the users that they can run pipes but need to install deno first (or IDK if we can have deno in the project or use it as cli)

rust -> run deno cli that runs some js code that imports all pipes and runs them

That's precisely it. deno is mostly Node-compatible (source: Node APIs). So we can have imports + node native support + deno native support almost effortlessly.
It can keep the Rust layer that instantiates the Deno runtime. We then run the run_all.ts file, which can receive some arguments (such as the pipes it needs to execute). Alternatively, we can somehow handle this to deno cli and mention to the users that they can run pipes but need to install deno first (or IDK if we can have deno in the project or use it as cli)

i see

so next step i think of is that i will do a large refactor to make pipes imported by some js/ts core module and execute them
this module will be execxuted by deno cli itself
deno cli will be installed in in pre_build.js for the app on all OSes but CLI users need to install deno cli

this will:

solve the crash here
remove need to reimplement all the node api in rust myself
allow dependencies
let people just write normal js and it works
let people run servers or whatever and it works

update: afraid not going to the deno cli path: https://github.com/mediar-ai/screenpipe/pull/462/files
problem is that you can't write rust extensions easily this way and big next feature we're launching is the ability to control your computer in js eg
await pipe.click({x: 200, y: 350})

await pipe.type("yo")

// or provide LLM tools like typing and mouse and give full autonomy to solve tasks on the computer ...

right now i am going to investigate if i can import packages or use deno.json like when using cli using the current way

other info: https://github.com/denoland/deno/blob/main/ext/webgpu/lib.rs
seems to be possible to write rust extensions
although not sure if need to be web assembly compatible (dont think the extensions i want to build can compile to wasm)

ok here are my updated thoughts:

i will use deno cli because i think that's where the deno team put the most effort and is more reliable and clean
i will implement short term hacks to be able to use low level api from the pipes like: opening http endpoint to control mouse/keyboard until i figure out cleaner way to create deno extensions in rust

just looked at #462. it looks way cleaner now

now everything works
except idk how to write rust extensions yet which is useful for low level / native stuff like keyboard control or mouse

great to know!
we can maybe close this issue then? And maybe create another issue for supporting rust?
PS: I would appreciate a tip if my suggestions helped fix this.

/tip $100 @ologbonowiwi
thank you for the suggestions 🙏


docker compose versions?

The docs state:

Install legacy/v1 docker-compose...
verify installation with docker-compose --version; result should be 1.29.2 or similar, not 2.x.x

However I've had no problem using modern inbuilt docker-compose  v2.17.3 (aka docker compose...).
The only caviet to that is this line of code: https://github.com/RopeWiki/app/blob/93d285648899edd1db9e0e70e848fd13b13dcdd5/deploy_tool.py#L42
The compose -p flag now produces containers with - not _ in the names. This only seems to affect the sql restore commands.
If there is more complicated problems I'm missing, the COMPOSE_COMPATIBILITY  flag can be set to revert the new version to old behavior: https://stackoverflow.com/a/69519102/142270

Hi.  I'm new to this project, I just set it up locally to get my feet wet.  I also noticed this issue causes deploy_tool.py to fail

Hi, I'm new to this project.  I'm interested in helping, so I just set it up locally to get my feet wet.  I found this issue right away because it causes the deployment to fail here:
https://github.com/RopeWiki/app/blob/fbe903b8782f2648e6642d0234462481428aca62/deploy_tool.py#L313
Underscore is actually not allowed in DNS names, that's why v2 made this change.  I made a commit to replace all underscores in hostnames with hyphens, including container names even though that's not strictly necessary.
e6992068d7a3cd318e6f8dd8029d42400b363a58

Strictly speaking, it's hostnames rather than DNS names that aren't allowed to have underscores, and I'm generally happy to fix/have fixed the hostnames in, e.g., the docker compose YAML.  But, could you elaborate on how the deployment fails?  We have 3 developers and the production deployment who successfully use the repo as it is currently, so failing due to an invalid hostname seems surprising and makes me suspicious that the underscore in hostname issue may not actually be your root problem.
PRs are always welcome in any case though :)  There are at least 5 things that may currently have underscores in them: hostnames, container names, service names, deployment names, and deployment configuration names.  It definitely seems reasonable to make sure hostnames don't have underscores, and it seems reasonable to make sure container names easily/obviously reveal their hostnames (e.g., container name = [deployment name]-[hostname] or [deployment name]_[hostname]).
docker-compose v1 takes extra effort to install now so I still support the intent of this issue, which is to replace docker-compose v1 with the v2 compose plugin for docker (which happens to concatenate with dashes).

Ah, you're right!  I was just assuming DNS name follows hostname.
To clarify, the build only fails when I use compose v2.  I guess your team doesn't notice it because you use v1?
% python3 deploy_tool.py local create_db
2023-06-26T09:15:54.513905 Deleting/cleaning up any existing database...
2023-06-26T09:15:54.514133   RUN git log -n 1
2023-06-26T09:15:54.534875   RUN git status
2023-06-26T09:15:54.548230   SCRIPT docker-compose -p local stop ropewiki_db
2023-06-26T09:15:54.548256   RUN sh /Users/ebalsley/source/ropewiki/app/docker_compose_command.sh && rm /Users/ebalsley/source/ropewiki/app/docker_compose_command.sh
2023-06-26T09:15:54.787903   SCRIPT docker-compose -p local rm -v -f ropewiki_db
2023-06-26T09:15:54.787945   RUN sh /Users/ebalsley/source/ropewiki/app/docker_compose_command.sh && rm /Users/ebalsley/source/ropewiki/app/docker_compose_command.sh
[]
No stopped containers
2023-06-26T09:15:54.882906   RUN docker volume ls
2023-06-26T09:15:54.933723   SCRIPT docker-compose -p local up -d ropewiki_db ropewiki_backup_manager
2023-06-26T09:15:54.933768   RUN sh /Users/ebalsley/source/ropewiki/app/docker_compose_command.sh && rm /Users/ebalsley/source/ropewiki/app/docker_compose_command.sh
[+] Running 5/5
 ✔ Network local_default                      C...                         0.1s
 ✔ Volume "ropewiki_proxy_certs"              Created                      0.0s
 ✔ Volume "ropewiki_database_storage"         Created                      0.0s
 ✔ Container local-ropewiki_db-1              Started                      0.4s
 ✔ Container local-ropewiki_backup_manager-1  Started                      0.7s
2023-06-26T09:15:55.811256 >> Waiting for MySQL database to initialize...
2023-06-26T09:16:00.814939   RUN docker inspect --format "{{.State.Status}}" local_ropewiki_db_1

Error: No such object: local_ropewiki_db_1

ERROR: Return code 1

This GH issue is more standardizing developer work flow than fixing a
technical issue.
The actual question (for Ben to answer) is why the docs and code require
v1. I use v2 happily with tiny changes about _ and -.
On Mon, Jun 26, 2023, 18:31 Elliott Balsley @.***>
wrote:

Ah, you're right! I was just assuming DNS name follows hostname.
To clarify, the build only fails when I use compose v2. I guess your team
doesn't notice it because you use v1?
% python3 deploy_tool.py local create_db
2023-06-26T09:15:54.513905 Deleting/cleaning up any existing database...
2023-06-26T09:15:54.514133   RUN git log -n 1
2023-06-26T09:15:54.534875   RUN git status
2023-06-26T09:15:54.548230   SCRIPT docker-compose -p local stop ropewiki_db
2023-06-26T09:15:54.548256   RUN sh /Users/ebalsley/source/ropewiki/app/docker_compose_command.sh && rm /Users/ebalsley/source/ropewiki/app/docker_compose_command.sh
2023-06-26T09:15:54.787903   SCRIPT docker-compose -p local rm -v -f ropewiki_db
2023-06-26T09:15:54.787945   RUN sh /Users/ebalsley/source/ropewiki/app/docker_compose_command.sh && rm /Users/ebalsley/source/ropewiki/app/docker_compose_command.sh
[]
No stopped containers
2023-06-26T09:15:54.882906   RUN docker volume ls
2023-06-26T09:15:54.933723   SCRIPT docker-compose -p local up -d ropewiki_db ropewiki_backup_manager
2023-06-26T09:15:54.933768   RUN sh /Users/ebalsley/source/ropewiki/app/docker_compose_command.sh && rm /Users/ebalsley/source/ropewiki/app/docker_compose_command.sh
[+] Running 5/5
✔ Network local_default                      C...                         0.1s
✔ Volume "ropewiki_proxy_certs"              Created                      0.0s
✔ Volume "ropewiki_database_storage"         Created                      0.0s
✔ Container local-ropewiki_db-1              Started                      0.4s
✔ Container local-ropewiki_backup_manager-1  Started                      0.7s
2023-06-26T09:15:55.811256 >> Waiting for MySQL database to initialize...
2023-06-26T09:16:00.814939   RUN docker inspect --format "{{.State.Status}}" local_ropewiki_db_1
Error: No such object: local_ropewiki_db_1
ERROR: Return code 1
—
Reply to this email directly, view it on GitHub
https://github.com/RopeWiki/app/issues/35#issuecomment-1607828762, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABAD7AM2IRM4M6UGNVQV23XNG2MTANCNFSM6AAAAAAYMU4H5M
.
You are receiving this because you authored the thread.Message ID:
@.***>

The container names for the database and backup manager are hardcoded in deploy_tool.py to be constructed in the way that docker-compose v1 constructs container names -- docker compose v2 constructs container names with dashes and therefore someone using docker compose v2 should* experience exactly the problem in @llamafilm's logs above when attempting to execute a deploy_tool command that involves the database or backup manager containers.
*should = "what happens now", not "what should happen in an ideal world", which is what we'll fix with this issue (shortly) :)


MSID: 88065 Version: 1 DOI: 2<IP_ADDRESS>1668

"msas": "Immunology and Inflammation, Structural Biology and Molecular Biophysics"
"msid": "88065"
"preprintDoi": "10.1101/2<IP_ADDRESS>1668"
"Reviewed Preprint posted": "2023-06-21"
"Sent for peer review": "2023-04-11"
"Posted to bioRxiv": "2023-03-22" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>1668v4")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v1/by-publisher/elife/get-by-manuscript-id?manuscript_id=88065)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/88065/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: https://github.com/elifesciences/enhanced-preprints-data/pull/105
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews
Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>1668)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/88065/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/88065)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/88065

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/88065

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/88065/v1/88065-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/88065)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

bioRxiv have made a complete mess of the corresponding authors, which needs fixing.

Fix in https://github.com/elifesciences/enhanced-preprints-biorxiv-xslt/pull/47

Email still incorrect - fix in https://github.com/elifesciences/enhanced-preprints-biorxiv-xslt/pull/49


Error run code

Help me, the code when i run it, some code is error..
E:\SHARED\BrainDamage>python eclipse.py
File "eclipse.py", line 101
print e
^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(e)?
E:\SHARED\BrainDamage>

What version of python you using?  Likely fix:
dos2unix eclipse.py then run or run on linux


Add state management

This experiment seems a tad outdated now. Can we close it, or is it still useful?


Installation fails on torch_sparse No module named 'torch'

When installing the package (i.e. pip install .), we get the following error when trying to install torch_sparse:
ModuleNotFoundError: No module named 'torch'
This comment seems appropriate: 😜  https://github.com/DeepRank/deeprank-gnn-2/blob/42d02b18accdda10840d78ffbe2e7f6d7a662fe9/setup.py#L41
Another pointer might be that we do all kinds of tricks in our CI to install the dependencies: https://github.com/DeepRank/deeprank-gnn-2/blob/42d02b18accdda10840d78ffbe2e7f6d7a662fe9/.github/workflows/build.yml#L38

This is resolved with #40 (although in the future we might want a simpler way of installing dependencies)


Uuid -> Leafref at Notifications

All *Notification::objectIdRef attributes will become _objectIdRef attributes generated from shared associations to LTP class in UML. This applies on all notifications.
All *notification::object-id-ref leaf will become leafref to LTP.
Only object-deletion-notification::object-id-ref : leafref will be "require-instance false;"

All *Notification::objectIdRef attributes became _objectIdRef attributes generated from shared associations to LTP class in UML.
All *notification::object-id-ref leaf became leafref to LTP in YANG.


Java code to find single element in the input - Issue #5

Description
Find the only word that appeared single time in the input
E.g.
Input
Input: red,animal,bird,animal,bird
Output
Output: red
Reference Issue number #5
issue_no must refer to the issue related to this PR, visit here
Type of change
Choosing one or more options from the following as per the nature of your Pull request.
NOTE: Check boxes using [x]

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Documentation Update

Checklist:

[x] I have named my files and folder, according to this project's guidelines.
[x] My code follows the style guidelines of this project.
[x] My Pull Request has a descriptive title. (not a vague title like Update index.md)
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have created a helpful and easy to understand README.md, with problem description and my name.
[ ] I have included a requirements.txt file (if external libraries are required.)
[x] My changes do not produce any warnings.
[x] I have starred this repository.
[ ] I have added a working sample/screenshot of the script.
[ ] I have checked for trailing spaces in file names and none have them.

There seemed to be a problem with the previous PR, will do fresh one soon.

I am unable to submit a fresh PR- The error I get is,
fatal: unable to access 'https://github.com/pratik-choudhari/AlgoCode.git/': The requested URL returned error: 403
Could you kindle suggest me how to overcome this?

@ReyhanSara I cannot suggest a remediation based on these details. One thing you can do is delete the fork and refork the repo and then work on it.


(PUP-4557) Extend unit testing for 100% coverage

This conflicts with the other spec pull. I probably should've merged this one first, since it's bigger. Oh well.
This is ready as soon as it gets a rebase, I think

Rebased.


Log 10569 profiling target

This adds a benchmark as well as a make bench target to run it. When run it will drop file named flamegraph.svg in the repo root directory

I have one last change to make to this pending the change to build images. Once that's been merged I'll be able to remove the Dockerfile.bench from this to avoid duplicating base image Dockerfile in here


Multi-arch builds with GitHub Actions

Configured GHA workflows to build multi-arch images for all applications and sign them with Sigstore.
To make the workflows work, you need to add a Secret named IMAGE_PUSH_TOKEN to the repository settings with a PAT having "packages (write)" permissions.

Is it ok to use GitHub Container Registry? Docker Hub would cause us issue with the rate limits, whereas GHCR wouldn't. I've been hitting the rate limits on the cloud cluster (locally it's better since I'm logged in, though I'm on an ARM machine, so the AMD-only images don't run that well).

I had my PAT token leaked before.. so I think I will try with this: https://docs.github.com/en/actions/security-guides/automatic-token-authentication


veracruz API (client interface) documentation or libraries that allow clients to be built in other languages

Requested feature
API documentation and a set of libraries that allow clients to be built to interface with veracruz
Motivation
Build user applications that interface with veracruz providing input/output and programs to a veracruz instance.
Additional context
Rust API exists but not fully documented, C is provided but it is oriented towards a microcontroller environment.

Consider the API as first class citizen and properly document it


Added release docs for 1.19-2

Issue #, if available:
Description of changes:
WIP until closer to release
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/unhold


Add v22.2.17 release notes

Fixes DOC-9166

@taroface I just updated this to be ready for "cloud first" release
Left a comment on REL-548 with some additional details (I think this is supposed to be released to cloud "soon" per that ticket )

@mdlinville added you to review the cloud-first Liquid logic, looks like I'm breaking something but I'm not sure why.  Followed the steps in https://cockroachlabs.atlassian.net/wiki/x/gQGaQw but probably holding it wrong

@mdlinville added you to review the cloud-first Liquid logic, looks like I'm breaking something but I'm not sure why. Followed the steps in https://cockroachlabs.atlassian.net/wiki/x/gQGaQw but probably holding it wrong

I think you need to add something like https://github.com/cockroachdb/docs/pull/18020/files#diff-7e4e754d259bdf2409d23c85fc15faf5cdd01563c4bf05508d997c6407831cf1R31 to the 22.2 file for this version.

I think you need to add something like https://github.com/cockroachdb/docs/pull/18020/files#diff-7e4e754d259bdf2409d23c85fc15faf5cdd01563c4bf05508d997c6407831cf1R31 for this version near the bottom of v22.2.md.

Hmm, I thought I did add this here.  Maybe if I edit some stuff and do a new push it will "take" this time 🤞

Need some links here. Otherwise all looks good except for the liquid stuff you mentioned.

Thanks @taroface, will update these!
PS Just got word there will be a slightly different SHA so I will update this now based on your feedback with links etc ...
but will be updating the PR again later today or first thing Monday AM (according to linked comment the CC binaries are targeting publish for Monday).  Probably tiny changes like 1-2 lines is my guess

Based on some local experimentation, it looks to me like commenting out the YAML is enough to keep a build from being added to the main v22.2.md page
Further, it is actually much simpler to add the "cloud first" v22.2.17 header and note directly to v22.2.md rather than trying to galaxy brain something into that page via Liquid
In the latest push I've done just that, since the Liquid logic was breaking the v22.2.md page build and thus all links pointing to it.
I have also added a comment to our wiki page 'Publish Release Notes' to discuss further

@mdlinville I've visually checked the output of this build both locally and in the preview build (links below).  It looks like this is working ok.  Please let me know if you can see a way this is not working

v22.2 main page (has v22.2.17 listed, but only shows the cloud first blurb)
v22.2 section of Production Releases page  (this LGTM since v22.2.17 does not appear there, but let me know if I'm missing something?)

This LGTM, as long as we are good with having nothing at all in the releases index table for this version. It's not simple to add something to that table manually, and it's also not simple to add a note near the table to explain why it isn't there. As long as we think people will know how to get to the major version's release index to read the notes.

Oh I see what you mean now.  Looking at https://deploy-preview-18046--cockroachdb-docs.netlify.app/docs/releases/v23.1#v23-1-12 I can see that this is broken somehow in a way that the v23.1.12 release notes were able to work.  OK back to the drawing board debugging the Liquid

OK I think I have figured this out (see latest push).  There were two separate issues breaking the build:

In the file v22.2.md there was an undefined variable being referred to in Liquid. This occurred because there has not been a cloud first release of this version yet.
To comment out the docker and download links in v22.2.17.md, you must use the Liquid {% comment %} syntax, standard HTML comment syntax does not work, and causes the build to break.

Both of these issues should be resolved in the latest changes

Update: v22.2.17 is no longer a "cloud first" release (we're not doing them for the v22.2 line) and the latest SHA adds 2 new lines which I've edited and added links for
Details in this message from @celiala
it's still scheduled to go out today (2023-11-20)


MSC2874: Single SSSS

Rendered

Implementation:

using the default key when unlocking SSSS: https://github.com/matrix-org/matrix-react-sdk/pull/5638
setting the default key when creating SSSS: https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/crypto/index.js#L676

@mscbot fcp merge

We need a codename for this, because people will think we are randomly hissing :)

Merged! :tada:


Add support for generic/detecting providers

An initial pass at generic/detecting providers that can scoop up and claim domains without specific providers, such as Mastodon instances. First commit is actual code but could be cleaned up/take feedback on, the other two are a demo provider/config.

Looks pretty good, I like the approach.
One change I'd be interested in exploring is adding a score to the detection result. This check, for example, might also match a blog post on a Wordpress site whose title is "Mastodon", for example, but that should match the Wordpress provider.

Should be good to go. I ended up going with the certainty/scored route. Why?

It covers all the same bases as a simple yes/no (by selecting simply 0 or 1 scores)
It allows further flexibility later
It allows for providers to age gracefully. As self-hosted instances that these providers may target will end up version smeared as people upgrade at different speeds (or not), the provider can fail an increasing number of checks to fingerprint a service and give over time a decreasing certainty

I know that Mastodon was just an example, but before this is merged can you add a genuine provider so that we can prove your approach?

Done. #2 needs updated to include that Mastodon should get better 2FA support, as I don't have an instance/account to test it with.

LGTM, I'll test it once I'm back from vacation.

Fails with TOTP enabled, would be nice to see that added but if you don't have the time I'll just test it without.

I'm about to go away for a week on a training exercise so it's not something I'll likely include in this PR. Once I get back I can look at it, for the meantime I'd just ask that #2 gets updated so it's something that can be said is known.

A week is a small time to wait if you think you can get to this afterwards

~/s/pass-rotate > ./pass-rotate cmpwn.com
Rotating cmpwn.com... FAIL
Traceback (most recent call last):
  File "./pass-rotate", line 124, in <module>
    provider.prepare(old_password)
  File "/home/sircmpwn/sources/pass-rotate/passrotate/providers/mastodon.py", line 53, in prepare
    self._form = get_form(r.text, id="edit_user")
  File "/home/sircmpwn/sources/pass-rotate/passrotate/forms.py", line 36, in get_form
    inputs = form.find_all("input") + form.find_all("select")
AttributeError: 'NoneType' object has no attribute 'find_all'

Failed to rotate cmpwn.com

This should be better handled, my apologies. In essence, there's no way to distinguish between "username/password invalid" and "require additional authentication" - mastodon returns 200 and lands you back on /auth/sign_in for each.
I'm going to see if upstream will accept a patch for this, where bad user/pass is distinguished with a different code, perhaps? In the meantime I'll have to scrape the page a bit, and then do the right thing.


Add website link to repo

Hey, this looks like a really neat resource. Can I suggest adding the "website" field on the repository such that people finding the repository can find the published site?
https://tgthorley.github.io/Safety-and-Wellbeing-for-Researchers-and-Practitioners/
Docs are kinda here for how to do that if you need them: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/classifying-your-repository-with-topics

Thanks @ThisIsMissEm !
Done!


Update doc and links to support new main branch

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci smoke test


Application crashing my scene

Describe the bug
A clear and concise description of what the bug is.
Whenever I add application to room, the scene crashes with the message "Could not send message with reason: rate limited". This did not happen immediately but after setting up the encounter and then refreshing the page. But since then any time I delete and re add the application to the room it immediately crashes just that scene with the same error message. When the application is deleted from the room, the scene then loads again.
Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: Windows 10 pro
Browser Chrome
Version 130.0.6723.70 (Chrome)

Aw yes. This is a big issue. I'll get on it.

This seems to be a bug when loading a scene a second time. Reloaded causes the tokens to update super frequently, causing the entire scene to get rate limited.

@Theosis23 apologies. i believe a fix has been released.

Just tested and reloaded. All good!
Thank you so much!


[FIX] Fix of inconsistent indices #1726 #1731 #1732 #1734

What do these changes do?

[x] passes flake8 modin
[x] passes black --check modin
[x] signed commit with git commit -s
[x] Resolves #1726, #1731, #1732 and #1734
[x] tests added and passing

Initially, this PR was fixing that to_pandas in pandas backend does not consider information about indices/columns of modin frame, only from partitions. But after that fix many tests started to fail because df_equals, that uses in many tests, use to_pandas to convert modin frame to pandas and then compare it with an expected result. It revealed that many operations returns modin frame with incorrect indices, so this PR is also fixing all of them.

All check seems to be pass, except few that canceled because of timeout

LGTM! Let's wait for @devin-petersohn , and @gshimansky .

@devin-petersohn I guess I addressed all your comments, please take a look. I've also added propagation indices names like ["__reduced__"] for Series into partitions, to it successfully passed assert check in to_pandas

@devin-petersohn comments addressed and CI is green (for the exception of black check that seems to be frozen)

@devin-petersohn I've found out that df_equals sorts columns labels before asserting frame equality, so after I've added assertion for columns equality (without that sorting) many tests appear to be failed. Are we really want to sort columns to check frames equality or this is a legacy stuff?

Are we really want to sort columns to check frames equality or this is a legacy stuff?

This is legacy, we should not be sorting. This is a different issue, let's open a new issue and PR for that and add the check in df_equals there.
It looks like CI is failing to download the packages.

Are we really want to sort columns to check frames equality or this is a legacy stuff?

This is legacy, we should not be sorting. This is a different issue, let's open a new issue and PR for that and add the check in df_equals there.
It looks like CI is failing to download the packages.

removed asserting columns from that branch and created a separate issue about sorting labels (#1784)

@devin-petersohn CI is green, I guess PR is ready to merge


Policy Change Reminder Appearing on Turn 1

Looks like the latest update included a policy change reminder? I somehow got it on turn 1, when there was no government or policy to choose from. When I click on "Change Government", nothing happens and the dialog box stays there, though I am able to close the dialog and end turn. See screenshot below. It was a single player game with CQUI, Civ VI Graphs, and no other mods. I run the latest patch of Civ 6 on Windows, with all current DLCs enabled. Among three games I've started since yesterday, this only happened in one game.

Are you using any other mod ? On windows ? Can you reproduce this issue and then post your logs (they're in Documents\my games\Sid Meier's Civilization VI\Logs) and if it's possible your save game.

Updated description with more info. Unfortunately I didn't save that turn, but I'll try to reproduce this issue.

@Azurency I just encountered this bug again. Still on Windows but with more mods: CQUI, Civ VI Graphs, RevealMap, Flatter Dynamic Turn Timer, and Greater Start Distance.
Attached the log files and the save game. Hope this helps!

@sparrow8332 I think it only occurs in turn 1 (when founding the city right away?).

ive ran another 6 games from turn 1 to turn 15 and still not having the issue you describe

It only happens on turn 1, and only in some games. I've seen it happen with only CQUI and Civ VI Graphs, so it may be possible that this bug is caused by the two mods being incompatible with each other. I'll see if I can reproduce it in CQUI only. If I can't do so within a few days, we can just close this ticket.

Update: I played a dozen starts after unsubscribing from Civ VI Graphs, and this issue never occurred again. Pretty sure it's a mod incompatibility issue and not a bug in CQUI.

Reliably duplicated!
I realize this is old, but in case anyone else finds this, I just experienced this a whole 2.5 years later. This is my first game ever using this mod. The only other mod I have is Aircraft Carriers Double Capacity. I am subscribed to this mod via Steam Workshop -- I did not attempt to install it any other way.
The only reason I'm posting a comment here is because I noticed that the other player above is playing as Frederick Barboarossa, which is also who I am playing as when this happened. I do not get a prompt that I can close -- it completely halts progress of the game. I cannot progress to the next turn.
Screenshot and saved game file attached. Reloading the save puts me right back into the same "stuck" spot.
I had my Create Game settings saved, so I tested 3 other leaders by loading my settings, changing the leader, and immediately beginning.
✅  Montezuma, no problem.
✅  Gilgamesh, no problem.
✅  John Curtin, no problem.
Tried again with a new Frederick, and exact same issue occurred. It appears the bug is this mod + Frederick leader.
❌  Frederick Barboarossa
I do not own Gathering Storm or Rise and Fall.

Fred 4000 BC  Civics Bug.zip


MatMulInteger const prop

Note that it is implemented with a reusable helper method ElementsAttrBuilder::matMul() which is designed to also work for the MatMul op, so it will be easy to add const prop for MatMul afterwards.

Jenkins Linux ppc64le Build #9554 [push] MatMulInteger const prop... started at 21:22

Jenkins Linux s390x Build #10508 [push] MatMulInteger const prop... started at 21:21

Jenkins Linux amd64 Build #10497 [push] MatMulInteger const prop... started at 20:21

Jenkins Linux amd64 Build #10497 [push] MatMulInteger const prop... passed after 1 hr 24 min

Jenkins Linux s390x Build #10508 [push] MatMulInteger const prop... passed after 1 hr 35 min

Jenkins Linux ppc64le Build #9554 [push] MatMulInteger const prop... passed after 1 hr 55 min


Can not get it run on windows

Hi there,
i can't get this run on windows.
I am stuck at this:
"Error: No native build was found for platform=win32 arch=x64 runtime=node abi=120 uv=1 libc=glibc node=21.7.1
loaded from: G:\AIZeug\humanify-main\node_modules\zeromq"
Is there any chance to get this running on windows without using wsl?
There was also an issue with the current node version and i had to change the start script to "tsx src/index.ts", otherwise it complained about not knowing the file extension ".ts".

Unfortunately I don't have any good way to develop on Windows at the moment, so cannot guarantee any support for that platform.
Zeromq does claim it should work on Windows too, so not sure what the issue here is 🤔

I'll mark this as wonrfix for now, but I'll be happy to accept any pull requests that fix the windows support

@jehna While it wouldn't make for the best dev workflow, I wonder if adding some basic cross-platform build tests on GitHub actions would help highlight/protect against these sorts of issues?

Zeromq does claim it should work on Windows too, so not sure what the issue here is 🤔

Unsure if this is relevant, since theoretically it should have binaries from prebuild:

https://github.com/zeromq/zeromq.js/tree/5.x#installation---users

windows users: do not forget to set msvs_version according to your visual studio version 2013,2015,2017 npm config set msvs_version 2015 Now, prepare to be amazed by the wonders of binaries.
To use your system's libzmq (if it has been installed and development headers are available):
npm install zeromq@5 --zmq-external

I think that explains it<EMAIL_ADDRESS>The prebuilt binaries only exist up to node v18

The prebuilt binaries only exist up to node v18

Yeah, I was just about to say, the script in the package.json lists the following:

https://github.com/zeromq/zeromq.js/blob/5.x/package.json#L30-L31

"prebuildify": "prebuildify -t 18.12.1 -t 16.18.1 -t 14.21.1 -t 12.22.12 -t<EMAIL_ADDRESS>-t<EMAIL_ADDRESS>--strip",
"prebuildify-ia32": "prebuildify --arch=ia32 -t 18.12.1 -t 16.18.1 -t 14.21.1 -t 12.22.12 -t<EMAIL_ADDRESS>-t<EMAIL_ADDRESS>--strip",

I'm having this too on macos, did anyone fix this?

did anyone fix this?

@JxxIT I believe the solution is probably "use an older version of node that the zeromq.js binaries are built for"

@0xdevalias Wow, thanks! It worked for me.

I recommend using the latest beta version of zeromq until we fully release v6

@aminya Sorry for this stupid question: Do you have an eta for v6?

Zeromq not needed anymore since v2 was released, should work now on Windows.
I think I could add some e2e test for running on Windows, as GH runners have a windows host too 🤔

If anyone still cannot make it work in Windows then my suggestion is to use WSL, it works with a couple of tweaks (I didn't test with GPU yet)


Open folder does not open folders

VSCode Version:
1.45.1
5763d909d5f12fe19f215cbfdd29a91c0fa9208a
x64
OS Version: Ubuntu 20.04 LTS

Steps to Reproduce:

Run code . on any directory. Alternative, Run code, and use the GUI to open a directory.

Does this issue occur when all extensions are disabled?: Yes

Running into the same issue. 100% reproducible with any folder with all extensions disabled.
Calling code . in the folder opens vscode, but there is no folder open. The outliner prompts to "Open Folder". Clicking it and choosing a folder does nothing. No change.

VSCode version:
1.45.1
5763d909d5f12fe19f215cbfdd29a91c0fa9208a
x64
OS version: macOS Mojave 10.14.2 (18C54)

Errors from dev tools:

Error: ENOENT: no such file or directory, uv_cwd
    at process.cwd (internal/process/main_thread_only.js:42:25)
    at process.cwd (/Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar/graceful-fs/polyfills.js:10:19)
    at q.resolveSingleFolderWorkspaceInitializationPayload (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:7233:171)
    at q.resolveWorkspaceInitializationPayload (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:7232:563)
    at q.initServices (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:7232:21)
    at q.open (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:7229:715)
    at Object.t.main (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:7234:444)
    at file:///Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.js:8:763
    at processTicksAndRejections (internal/process/task_queues.js:85:5)
onUnexpectedError @ bootstrap-window.js:209
(anonymous) @ bootstrap-window.js:52
emit @ events.js:203
./lib/renderer/init.ts.window.onerror @ init.ts:188
error (async)
(anonymous) @ init.ts:183
./lib/renderer/init.ts @ init.ts:232
__webpack_require__ @ bootstrap:19
(anonymous) @ bootstrap:83
(anonymous) @ bootstrap:83
NativeModule.compile @ internal/bootstrap/loaders.js:302
NativeModule.compileForPublicLoader @ internal/bootstrap/loaders.js:219
loadNativeModule @ internal/modules/cjs/helpers.js:23
Module._load @ internal/modules/cjs/loader.js:630
Module._load @ electron/js2c/asar.js:717
Module._load @ electron/js2c/asar.js:717
Module.runMain @ internal/modules/cjs/loader.js:944
(anonymous) @ internal/main/run_main_module.js:17
bootstrap-window.js:212 Error: ENOENT: no such file or directory, uv_cwd

Error: ENOENT: no such file or directory, uv_cwd
    at process.cwd (internal/process/main_thread_only.js:42)
    at process.cwd (/Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar/graceful-fs/polyfills.js:10)
    at q.resolveSingleFolderWorkspaceInitializationPayload (desktop.main.ts:276)
    at q.resolveWorkspaceInitializationPayload (desktop.main.ts:253)
    at q.initServices (desktop.main.ts:217)
    at q.open (desktop.main.ts:111)
    at Object.t.main (desktop.main.ts:343)
    at workbench.js:33
    at processTicksAndRejections (internal/process/task_queues.js:85)
    at errors.ts:26

https://github.com/microsoft/vscode/issues/2259


Bugfix/stderr

The stderr message was not being captured in the history log or printed to the user neither.

Handle #5


Tweak the Clock UI on Taskbar

Summary of the new feature/enhancement
A PowerToy option to enable the display of the seconds in the taskbar clock.
Proposed technical implementation details (optional)
Windows supports seconds in the taskbar clock via the registry key below. This PowerToy would provide a user-facing UI option to set this registry key value.
key: HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Advanced
ShowSecondsInSystemClock
type: REG_dword
value: 1

good idea.

Things to validate: be an MSIX and tweak these style regkeys

An option to show week numbers would be useful as well

An option to show week numbers would be useful as well

Already an issue for this.  #470

It seems Microsoft removed the ability to see seconds at all on Windows 11 as the Winaero tweak doesn't work anymore

The newest preview build of Windows Server 2022 has a hidden feature to enable secounds on the taskbar. But it isn't officially announced yet.

The feature landed in the latest dev build of Windows 11.


PVCs are not created when calling kompose up

Yes I think this is because there is no case for creating a PVC here https://github.com/kubernetes-incubator/kompose/blob/master/pkg/transformer/kubernetes/kubernetes.go#L357

@surajssd yes this is the reason for this, and same think in openshift.go

this breaks kompose for docker-compose files that are using volumes so I'm giving this P0


Slime and magma cube hurt morphed player

Even if not attacking the player

Can confirm same here

Implemented as of 1342bf716214f7aa587b7e911d2f08efc05f415c


MPU driver for libhal

The mpu for libhal hasn't been filled out yet and we need this in order to home the arm. Get this done asap for homing.

I aim to get the first set of code imported by 2/3/23 and aim to debug and finish testing it by 2/10/23* (This date is subject to change as problems arise, they will arise)

https://github.com/libhal/libhal-mpu
1.0.0 is released as of 2/18/23


open-policy-agent: 0.38.1 -> 0.40.0

Description of changes

Bump open-policy-agent to 0.40.0
set the mainProgram to opa for nix run
Also fixes the builds on darwin (https://hydra.nixos.org/build/176050231)
ZHF: #172160

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[X] x86_64-darwin
[ ] aarch64-darwin

[X] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

getting too many open files issues on darwin now

Result of nixpkgs-review pr 172359 run on x86_64-linux 1

1 package built:

open-policy-agent


feat: Great Learning

Related Issue
Closes #1375

Description

Added Great Learning Academy in product.json File for Learning Different Courses in Current Demands like Software Development, Other Programming Languages

Screenshots

Checklist

[x] My code adheres to the established style guidelines of the project.
[x] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

@NarendraKoya999 is it free

@NarendraKoya999 is it free

Yes @JasonDsouza212 . Lot of Web Development related Courses are Freely Available in this Platform. At the starting of my career start in Frontend Development. I can chosen this Website Free Content


Resolve segfaults when TF & Catalyst are both imported

Global symbols in our shared libraries can conflict with identically
named global symbols in other libraries loaded in the same process.
This can easily happen when two projects include the same library, such
as TensorFlow and Catalyst both including LLVM in their distributions.
All core compiler dependencies are now compiled with default hidden
visibility, including LLVM/MLIR, Enzyme, MLIR-HLO, and Catalyst. Since
we link dependencies statically into our main compiler_driver library
this does not pose any issues. It does mean however mean that most
symbols will be inaccessible outside of the compiler_driver library.
Note: While the potential for symbol conflicts exists for both Linux & macOS, in my testing the crashes only occurred on macOS.
[sc-54428]

@dime10 changelog?

@dime10 you can also remove some infrastructure in pytests that always imports catalyst before tensorflow for the autograph tests.


Waiting List Amends

Bits and bobs of tidying, commit messages describe each change.

:tada: This PR is included in version 5.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update Input tabs in Shex tool

Updated the input tabs in the shex-simple.js fille such that it changes only when textMapIsSparqlQuery is set.
see commit #43

LGTM

I think changes from the latest commit here were lost


Update/fix url for "contribute - Angular Material"

I'm not sure, should we really redirect the newcomers to the material2 project? It's still in progress and material1 is stable.
So I think it would be better to create a second link. Linking to both projects. material1 and material2

@DevVersion but first link is broken too, so i already updated it for 1st version.

Okay, I created a PR because I thought you want to refer to material2. But I closed mine ;)

@DevVersion can you check a description for Material2, am i right?

I would prefer not to list Material 2 on the contribute page, as we're not set up for additional contributors, but the link fix for material 1 is good

Kept the link fix; ignored the rest. Thanks.


Custom components

Related to https://github.com/rrag/react-stockcharts/issues/103
I am exploring an alternative that supports both svg and canvas but also avoids the hacks in place to make canvas work fast. In doing this there could be changes to the components, and the wrap function, it could even be removed. However I do not anticipate changes to any charts.
So this change if successful, will result in breaking changes to anyone who has developed a custom component. I want to get a feeling of how many of you have developed or planning to build a custom component. If so would you consider making a PR to add that here to the repo?

Hello, well I did a Custom component (ScatterLineSeries) which mainly permits me to draw curves on discontinuous data, and data points of different shapes. I don't know if a similar series exists exists in 0.5 but a PR is possible. It draws only on canvas (no svg).

@Pinxie could you share it in an email may be. I would like to see if it can be replaced using a combination of existing LineSeries and ScatterSeries and may be a custom XXXMarker

here is a preview to a list of potential changes in 0.6
in 0.6 -
https://github.com/rrag/react-stockcharts/blob/next/docs/lib/charts/CandleStickChartWithEdge.jsx
in 0.5 -
https://github.com/rrag/react-stockcharts/blob/master/docs/lib/charts/CandleStickChartWithEdge.jsx
Changes

CurrentCoordinate, MouseCoordinateX, MouseCoordinateY no longer need a required prop id
TooltipContainer is removed, and the tooltips (OHLCTooltip, MovingAverageTooltip) are now moved inside the Chart relative to which you you specify the origin, so this makes the forChart prop on the different XXXTooltip unnecessary
EventCapture is removed, and you get event capture added by default

Please comment on how you like the changes

merged to master and 0.6.0-beta.2 published to npm


ability to create zipsprings in UI

In SC, piling two masses on top of each other and then double-clicking in construct mode would sometimes create a zipspring, if you were lucky.  (If you were not lucky, swapping the order of the masses would fix things).
Add this behavior to communityconstructor, perhaps through the dblclick event.

Alternately, something like "middle click to toggle zipspring" might be nicer to use.

Turns out the old trick of "drag to top-left corner and double-click" still works, without even needing to special-case it in.  Amazing!


Use ⌘ + , to open Preferences

Currently, Search and Find have shortcuts, but Preferences doesn't. It would be nice to have a shortcut for Preferences.

There you go :)

Wow, that's fast, thanks


Install downloads 2 byte file and fails hash verification

Brief description of your issue
Our package fails to install due to hash verification failure since the manifests were updated to 1.0 schema.
winget seems to be downloading a 2 byte file instead of the actual 15 MB .MSI file. All of our previous versions have the same problem.

Steps to reproduce
winget install MasterPackager
Expected behavior
The package is downloaded, hash is verified and package is installed.
Actual behavior
We receive the following error - "Installer hash does not match; this cannot be overridden when running as admin" and it  seems to be downloading a 2 byte file instead of the actual 15 MB .MSI file.
Environment
Clean Windows 10 20H2 VM with no other software.
Windows Package Manager v1.0.11692
Windows: Windows.Desktop v10.0.19042.746
Package: Microsoft.DesktopAppInstaller v1.12.11692.0

For me, the solution to this was to switch to wininet rather than do.

@ItzLevvie  Is this something we should fix on our website where the file is stored?

We've see this issue occur most frequently when the URL for the download has a redirect to an http:// URL rather than an https:// URL. The Delivery Optimization (DO) downloader doesn't support HTTP redirects. DO attempts to use range requests to pull the file down in smaller pieces via parallel download for optimization. Changing the settings to use wininet is a temporary workaround until we either make a hard policy decision about https:// or we find a better way to detect when this occurs and we can fall back to wininet "faster".

@denelon but in this case the URL is https?

@ItzLevvie Is this something we should fix on our website where the file is stored?

I think so. It might be that Delivery Optimization doesn't support some of the features on your server that WinINet supports.
I think the only way to tell is to make a program that exports headers with Delivery Optimization and WinINet and then compare both of them to see the differences.
Delivery Optimization (DO):

WinINet:

You can take a look at the comments from https://github.com/microsoft/winget-pkgs/pull/15665 to see what may be happening.

@MasterPackager
We've published the v1.1 release candidate and updated our troubleshooting guide.
Can you confirm if this is still happening?

@denelon we can confirm we still have this problem

@denelon we managed to finally fix it by changing the url to this one - https://www.masterpackager.com/installer/professional/masterpackager_21.2.7837.0.msi
Should we close the issue? Or do you want to keep it open until you figure out why the other url doesn't work?

I think it should be closed treating it as an edge case.

@MasterPackager thanks for following up. Yes, go ahead and close the issue if you have a resolution. Until we have enough other instances to see what's common, I don't think we have enough to go on. I'm pretty sure one of us will remember the issue well enough if it pops up again, and we can check the history for context and other possible URLs.

For some additional context, we do have an ask for the Delivery Optimization service to support https -> http redirects.


IAM CRDs not saving values to Secrets (writeConnectionSecretToRef)

What happened?
When using Crossplane (1.6.1) and provider-aws (0.22.0) I am attempting to create a couple of AWS resources (role/policy) and in each of those resources I have provided a value for writeConnectionSecretToRef inorder to have the returned value saved as a secret (for future reference).
During my testing the AWS IAM resource(s) are created correctly... However the resource return values are not saved as secrets.
How can we reproduce it?
Here is a sample Role flie
apiVersion: iam.aws.crossplane.io/v1beta1
kind: Role
metadata:
  name: testrole
  namespace: test
spec:
  forProvider:
    assumeRolePolicyDocument: |
        {
            "Version": "2012-10-17",
            "Statement": [
                {
                "Effect": "Allow",
                "Principal": {
                    "Federated": "arn:aws:iam::11111111:oidc-provider/oidc.<VALID_ARN>"
                },
                "Action": "sts:AssumeRoleWithWebIdentity"
                }
            ]
        }
    tags:
      - key: Name
        value: test
      - key: CreatedBy
        value: Crossplane
      - key: OwnedBy
        value: test1234
  writeConnectionSecretToRef:
    name: rolevalue
    namespace: test

What environment did it happen in?
Crossplane version: 1.6.1
AWS EKS 1.21
Provider: aws-0.22.0

I have upgraded the provider to: 0.23.0
And have tried to remove the tags section. But nothing has worked.
I enabled debugging for the aws provider and I see the output:
2022-01-18T14:58:10.559Z	DEBUG	provider-aws	Reconciling	{"controller": "managed/role.iam.aws.crossplane.io", "request": "/test-role-debug2-tmp"} 2022-01-18T14:58:11.052Z	DEBUG	provider-aws	Successfully requested creation of external resource	{"controller": "managed/role.iam.aws.crossplane.io", "request": "/justin-role-debug2-tmp", "uid": "42b1466a-325d-43e3-a46b-ce48472d7c94", "version": "290802430", "external-name": "", "external-name": "test-role-debug2-tmp"} 2022-01-18T14:58:11.053Z	DEBUG	controller-runtime.manager.events	Normal	{"object": {"kind":"Role","name":"test-role-debug2-tmp","uid":"42b1466a-325d-43e3-a46b-ce48472d7c94","apiVersion":"iam.aws.crossplane.io/v1beta1","resourceVersion":"290802450"}, "reason": "CreatedExternalResource", "message": "Successfully requested creation of external resource"} 2022-01-18T14:58:11.061Z	DEBUG	provider-aws	Reconciling	{"controller": "managed/role.iam.aws.crossplane.io", "request": "/test-role-debug2-tmp"} 2022-01-18T14:58:11.378Z	DEBUG	provider-aws	External resource is up to date	{"controller": "managed/role.iam.aws.crossplane.io", "request": "/test-role-debug2-tmp", "uid": "42b1466a-325d-43e3-a46b-ce48472d7c94", "version": "290802452", "external-name": "test-role-debug2-tmp", "requeue-after": "2022-01-18T14:59:11.378Z"} 2022-01-18T14:58:11.385Z	DEBUG	provider-aws	Reconciling	{"controller": "managed/role.iam.aws.crossplane.io", "request": "/test-role-debug2-tmp"} 2022-01-18T14:58:11.722Z	DEBUG	provider-aws	External resource is up to date	{"controller": "managed/role.iam.aws.crossplane.io", "request": "/test-role-debug2-tmp", "uid": "42b1466a-325d-43e3-a46b-ce48472d7c94", "version": "290802474", "external-name": "justin-role-debug2-tmp", "requeue-after": "2022-01-18T14:59:11.722Z"} 2022-01-18T14:58:11.728Z	ERROR	controller-runtime.manager.controller.managed/role.iam.aws.crossplane.io	Reconciler error	{"reconciler group": "iam.aws.crossplane.io", "reconciler kind": "Role", "name": "test-role-debug2-tmp", "namespace": "", "error": "cannot update managed resource status: Operation cannot be fulfilled on roles.iam.aws.crossplane.io \"test-role-debug2-tmp\": the object has been modified; please apply your changes to the latest version and try again"} 2022-01-18T14:58:11.728Z	DEBUG	provider-aws	Reconciling	{"controller": "managed/role.iam.aws.crossplane.io", "request": "/justin-role-debug2-tmp"} 2022-01-18T14:58:12.071Z	DEBUG	provider-aws	External resource is up to date	{"controller": "managed/role.iam.aws.crossplane.io", "request": "/test-role-debug2-tmp", "uid": "42b1466a-325d-43e3-a46b-ce48472d7c94", "version": "290802475", "external-name": "test-role-debug2-tmp", "requeue-after": "2022-01-18T14:59:12.071Z"} 2022-01-18T14:58:12.077Z	DEBUG	provider-aws	Reconciling	{"controller": "managed/role.iam.aws.crossplane.io", "request": "/test-role-debug2-tmp"} 2022-01-18T14:58:12.396Z	DEBUG	provider-aws	External resource is up to date	{"controller": "managed/role.iam.aws.crossplane.io", "request": "/test-role-debug2-tmp", "uid": "42b1466a-325d-43e3-a46b-ce48472d7c94", "version": "290802475", "external-name": "test-role-debug2-tmp", "requeue-after": "2022-01-18T14:59:12.396Z"} 2022-01-18T14:59:12.078Z	DEBUG	provider-aws	Reconciling	{"controller": "managed/role.iam.aws.crossplane.io", "request": "/test-role-debug2-tmp"} 2022-01-18T14:59:12.427Z	DEBUG	provider-aws	External resource is up to date	{"controller": "managed/role.iam.aws.crossplane.io", "request": "/test-role-debug2-tmp", "uid": "42b1466a-325d-43e3-a46b-ce48472d7c94", "version": "290802475", "external-name": "test-role-debug2-tmp", "requeue-after": "2022-01-18T15:00:12.427Z"}

Hi @jwitrick ! What value would you expect an IAM Role to publish as connection details? For reference, IAM Access Key resource publishes the sensitive information you can use in your CLI config to connect.

For the Role (and applies to Policy/User) I would expect it to write out the the resource ARN.
I know for usage within crossplane there are references roleNameRef (and other ways) to reference the created resource, but I still have a number of non-crossplane resources which would need to reference the resource arns...

Non-sensitive information about the resource are written back to the resource itself. Can you use the status field of the iam role managed resource instead of a secret?

Hum. Its possible I was trying to use it in a consistent manor (i.e. secrets).
I will walk through it shortly.

FWIW, we publish sensitive information via Secrets but also other things to help connecting. I don't really see a problem publishing the ARN of the role in the secret since if no secret ref is given, it's no-op. You can publish it as a single key as a value for ConnectionDetails field https://github.com/crossplane/provider-aws/blob/c8c6c1b/pkg/controller/iam/role/controller.go#L133


Add game template, and constants file

Closes #14
I also added a constants.py, to save us some time. I know we did that later in Pyweek35, and it causes some issues.

Instead of making a fork, could you put this as a repo branch?

Instead of making a fork, could you put this as a repo branch?

I did try to do that, said I was unauthorized. Maybe it was the way I was doing it on phone? I can redo the PR on PC if thats a problem.

It's a start, however I'd like this to also have blocks, physics, the player movement, etc. There's lots of tutorials that we can use to get there. Let me know if you don't have time and I can work on it.

Sounds good, Ill work on the changes tonight.

Moved to #27


"sdk_version" parameter causes UNKNOWN_ERR during login

App worked fine for few days, but then started showing login errors. removing "sdk_version" parameter seems to fix the login problem

Thanks!

I might be wrong but I thought the SDK version provided here directly restricted the apps that you are able to download (based on their minimum OS support).
Might be worth removing this key from the configuration file and the related parsing logic if you decide we really don't need this.


Update languages.yml

Add xojo_image file Extension for Xojo.
redirecting to source.xojo for RealBasic files

Description
Moving RealBasic files to use Xojo syntax. (They are the same thing)
Added xojo_image file extension.
Checklist:

[x] I am associating a language with a new file extension.

[x] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:
Search

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

Sample

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[x] I am fixing a misclassified language

[ ] I have included a new sample for the misclassified language:
[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

Please review


Windows error Failed to load dynamic library

Hi, i'm getting this error on windows 11 with flutter.
Flutter 3.19.5 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 300451adae (2 weeks ago) • 2024-03-27 21:54:07 -0500
Engine • revision e76c956498
Tools • Dart 3.3.3 • DevTools 2.31.1

same here, I tried with script rps hello and it throws the same error.
Hmm is it because of windows 11 ? haven't tried it on win10.

Same issue here on Win11. It works just fine on Win10.

Same issue on recently installed win10, after running with dart pub global activate rps --version 0.8.1 and trying to run a script with rps. I've added %LOCALAPPDATA%\Pub\Cache\bin to path manually.
Intrestingly, if I navigate to %LOCALAPPDATA%\Pub\Cache\hosted\pub.dev\rps-0.8.1\native then I can see the rps_x64.dll.
Maybe some dependencies of this dll cannot be resolved.

I got the same issue.

ps: macos works well with this

I got the same issue on Win 11. The solution is simple. Just install Visual Studio with recommended Desktop development with C++ option from recommendation of flutter doctor command.
But it would be very nice to make work this package without installing Visual Studio.

This is probably due to the lack of CRT dynamic lib. I will look into this.

Hi all,
A possible fix for this bug has been implemented and is present in rps version 0.9.1.
I am closing this issue for now, if this error still occurs, feel free to reopen this issue.


Add CI for builds without error logging enabled.

Problem
Disabling error logging does not build.
Change overview
Make it build, add CI.
Testing
CI added.

fast track: trivial change with CI (since the whole point of this is CI)


How to make a new command

How would you make a new command after
break;

Okay, I got it now. If you want to do it:

case 'ping':
bot.sendMessage({
to: channelID,
message: 'Pong!'
});
break;


is it possible to ignore closed files from the navigation ?

atm going back/forth will open closed files, so can we exclude the closed files from the navigation loop ?

Sorry for the late reply.
This extension is just a UI representation of the default VSCode commands (workbench.action.navigateBack and workbench.action.navigateForward) and has a dead-simple implementation. However, I researched the Extensions API a bit and seems like access to the workbench history is not supported. Reference: https://github.com/microsoft/vscode/issues/64223
The closest command for your request is workbench.action.quickOpenPreviousRecentlyUsedEditorInGroup which works quite different by showing a list of opened tabs. You may try using it instead. It's ⌃Tab / ⌃⇧Tab on MacOS and  Ctrl + Tab / Ctrl + Shift + Tab on Windows or Linux.

The closest command for your request is workbench.action.quickOpenPreviousRecentlyUsedEditorInGroup which works quite different by showing a list of opened tabs. You may try using it instead. It's ⌃Tab / ⌃⇧Tab on MacOS and Ctrl + Tab / Ctrl + Shift + Tab on Windows or Linux.

that would give a totally different results 😢 , still thanks for the headsup.


Fixes valid M3U checking

Some streams don't place the #EXTM3U directive on its own line. This checks if the first line starts with the directive, allowing all valid M3U streams to pass.

Thank you very much for your PR, change will be released on NPM in a few days :)


Split COMMAND register for I2C

Satisfying the https://github.com/esp-rs/esp-hal/issues/1751

The -ulp and -lp pacs have this register too btw

The -ulp and -lp pacs have this register too btw

yes, but initially this PR was created to resolve the issue on non-LP chips.

And honestly, tried to do it, but the way the LP I2C peripherals were previously patched makes me personally some problems with making these changes for them. If we ever need to do this at some point - I'll get back to it, no problem.


HSEARCH-2678 Add a simple query string entry point to the DSL

https://hibernate.atlassian.net/browse/HSEARCH-2678

So, this has a very long history as I started to work on this in 2011 :). This patch is very different from what I envisioned at the start.
Why revisit it now? Got kicked out last week of $oldJob GitHub organization and this branch was hosted in the hibernate-search repository of this organization so it was high time to host it in a safe place. While at it, I decided to rebase it, polish it and well... here we are...
Some history
The idea of this patch came from the impossibility to execute a plain text query with a AND operator with the keyword() DSL.
Basically, we had our users entering "word1 word2" as a search query and they wanted only the results containing word1 and word2. We also wanted this to work with multiple fields. Meaning I would want to look for results containing word1 and word2 but either in name or description.
It looks like a simple issue but it's not that simple, especially when analyzers come into play.
Our users might also want to use simple "advanced" query features like phrase queries or negative queries.
I tried several times to arrive to something working well, thought about using DisMax...
The current version of the patch became possible when Lucene introduced the SimpleQueryParser (which is also available on Elasticsearch) which is a very simple lenient parser that can be used exactly for this purpose.
How it works
You can see a couple of examples in the doc added at the start of this patch. It should give you a good overview of how it works.
I also added a couple of tests that demonstrates the features.
While quite simple by itself, I think it's a great feature for the end user.

Jenkins, retest this please

@yrodiere I think I addressed all your comments and we should be on the same page regarding this feature. The first 2 commits should probably be squashed after review.
As for the build status, the failure looks unrelated.

Jenkins, retest this please

@yrodiere I pushed a new version:

squashed the 2 first commits
added one commit to rename useAnd...
added one commit to add lucene-queryparser to OSGi and distribution. It was already present in the WildFly modules.

Great work!
Looks very good. The only detail I'm not convinced of is the starting point of the DSL:
qb.simpleQueryString()
It feels a bit at odds with the other methods, but not having a better idea I merged it.
Proposal: let's post a dedicated blog to present / explain the feature and see if someone has a better name to offer.
Merged!


Scroll or Navigate to see the output of the executed commands

Issue's Description
I select and run a command and its successful. But wait. What did you run? Can I have a look at it?
For an instance, under System Setup -> Grub Themes, I've installed a new theme for my Grub. It ran successfully but the output is truncated.
Suggestion
A "man" page like scroll would be useful to take a look at the commands that have been executed.
Additional context
Here's a screenshot for a reference.

Checklist

[ X ] I checked for duplicate issues.
[ X ] I checked already existing discussions.
[ X ] This feature is not included in the roadmap.

/label 'rust'


⚠ Bofrost.be has degraded performance

In 7caffbd, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1284 ms

Resolved: Bofrost.be performance has improved in 25a15c0.


Add a timeout to the EverDrive side of the library

anacierdem added 24d404e to the library, and it seemed to work fine with the samples, however a user was having trouble where his homebrew was failing to print. Later, we isolated a single sample which presented the same issue, being nu5 from libultra. We tried tweaking the function but we could not get it to work, so I undid the commit. See issue #83 for more information.
So unfortunately the solution proposed in the commit might not work well in a practical sense. Some alternative solution is needed, that is if the risk of the USB stalling permanantly is possible.
Hopefully this issue can be looked into by someone who owns an EverDrive?

Paging @rasky and @anacierdem

Found the original reason why this was added.

After @rasky's reminder I remember this was to fix N64 side waiting too long if the PC is not listening and emptying the usb buffer. Also probably it was not waiting indefinitely but was slowing down the code too much. I will check how exactly it behaves.

That's a perfectly valid reason, the function just needs to be modified to output either error (on timeout) or zero on success, and subsequent calls to the function need to be modified to take the return value into account and branch accordingly, to prevent pushing data to the USB when it is still busy :smile:

Fixed in b716f17


feat: Display content for no tickets

Fixes #642
Changes:

Add a new resource file for the content of no tickets  content_no_tickets.xml
Observe no tickets boolean from OrdersUnderUserVM.kt and visible no tickets content in OrdersUnderUserFragment.kt
Direct to ticket issue URL when clicking on Find mt tickets in the content.

Screenshots for the change:

Tint the icon purple and increase circle border width

@iamareebjamal Updated.

@iamareebjamal Then how can I tint, should I tint programmatically as wrapDrawable or something else. Please suggest me?

@iamareebjamal Updated. Sorry for irksome comments, it is due to down of GitHub server.


Split up fwd.hpp into multiple headers

I'm not going to do this one.  That header is very small (~100 lines).  It's no burden to include it.  Moreover, it has at least some content needed by all the other headers, so splitting it up would not even reduce the number of headers you need to include to use any one header -- that number would remain at 2.


Add 'ClrAccordionModule' and 'ClrStepperModule' to default exports

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

There doesn't appear to be tests for barrel exports.
PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently we cannot import the ClrAccordionModule independently (import { ClrAccordionModule } from '@clr/angular'). We have to import the entire clarity package. I've added the module as an export to keep consistency with other features.
Issue Number: N/A
What is the new behavior?
import { ClrAccordionModule } from '@clr/angular'
import { ClrStepperModule } from '@clr/angular'
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I'll reopen this with the correct commit syntax. Apologies.


cranelift: Merge bitcasts into loads

👋 Hey,
I was looking at some wasmtime generated CLIF, and noticed that wasmtime emits a bitcast after SIMD loads. That's okay, but it prevents the loads being merged into some ops. So I decided to have a go at trying to remove these.
The rule works, which is nice, but It doesn't seem to delete the previous load, which I assume is some sort of correctness rule embedded in the mid end? This optimization looks correct to me, but I might be wrong!

For this example CLIF:
function %b() -> i32x4 {
    ss0 = explicit_slot 16

block0:
    v0 = stack_addr.i64 ss0
    v1 = load.i8x16 little notrap aligned v0
    v2 = bitcast.i32x4 little v1
    v3 = iabs v2
    return v3
}

We now merge the load into the iabs:
 10:   66 0f 38 1e 00          pabsd   (%rax), %xmm0

Where we used to do a load + pabsd:
   c:   f3 0f 6f 10             movdqu  (%rax), %xmm2
  10:   66 0f 38 1e c2          pabsd   %xmm2, %xmm0

In practice this doesn't help Wasmtime that much for SSE ops, since they require the loads to be aligned, but it should for VEX/EVEX ops.

That is unfortunate 😕 . And yeah, It looks like egraphs is not the right place to do it (for now!).

The new load must be placed at the same point in the side-effecting skeleton as the original, or we could be changing where traps are detected. We don't have any way to guarantee that in egraph rules right now.

It's only an improvement if all users of the value want the bitcasted type. If any want the original type then you'd need to insert a bitcast in the other direction, or worse, keep both loads. We can't tell in the egraph whether a value is used until the elaboration step at the end, which I think is too late for this.

Oh yeah! I was sort of expecting that it wouldn't perform the rewrite if there was more than one user for the load, doing the load twice doesn't seem like a great option.
I think we can keep all those constraints if we do this via simple_preopt (maybe, I haven't thought a lot about this!). But I think it would be nice to have some numbers on how much this affects perf before adding more stuff there.
Thank you guys for looking at this though!

I'm curious whether the backends can do this optimization, if it's just about load-sinking. I'm not sure what it would take to get the load-sinking machinery to "see through" bitcasts.
I think the most general bitcast optimizations would be target-specific anyway. Something like, if both types are stored in the same register class, then the lowering for bitcast can just return the input register. I'm not sure how endianness interacts with that and I've probably missed other important details, but maybe there's something easy to try in there.

I'm curious whether the backends can do this optimization, if it's just about load-sinking. I'm not sure what it would take to get the load-sinking machinery to "see through" bitcasts.

We could possibly do the same thing that we do on conditional branches with the maybe_uextend extractor: basically, build a little helper manually to do that "seeing through". It seems like a pretty reasonable manageable (i.e., not too high) level of complexity to me, vs. trying to reason about the combination in the mid-end.


DaylightPortalNode

lack DaylightPortalNode ,how to solte

run your description through a spell checker before submitting an issue.
DaylightPortalNode did not exist in the Revit 2015 API. It was introduced in Revit 2017. In Revit 2018 obsolete and no longer exists, cf. the Revit API docs at http://www.revitapidocs.com/2017/85a6e9b3-6cb9-0e15-9c5d-40e9d240fd49.htm


Add setup_chat_format for adding new special tokens to model for training chat models

What does this PR do?
This PR adds a new util method setup_chat_format, which automatically defines the chat_template for a tokenizer, adds special tokens, resizes the model embedding layer (optional to a multiple of 64)
It also introduces the ChatMlSpecialTokens dataclass, which is used in the setup_chat_format. This will make it easy to extend to different formats in the future, e.g., llama, but for now, we only add chatml.
Open Discussions
Should we add more dummy tokens to the tokenizer when the embedding layer is extended to a multiple of x? This can lead to downstream issues with llama.cpp

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Fine control of NPC (make the NPC controllable)

By request of Alexander Anderson<EMAIL_ADDRESS>Extending the current API to control the rest of dynamic objects. At least to have a finer control of their initialization:
Use cases:

creating situations in which we have a car in front of us blocking our car, etc.
create "events", e.g. car overtaking another car, etc.

When is this feature planned to be released?

Hey @sandman
This is a high priority feature for us. But we have planned date to release yet.
Thanks for your interest.
Cheers.

I've been working on this for a while now. Here what works:
-spawning a pedestrian(or more) with a certain trajectory and speed, configurable from the settings file or sent from the python client(to be used in crash simulations). This basically uses a combination of SetActorLocation and Controller->MoveTo along with selectively disabling the part of code that stops the pedestrian if he is about to intersect with a vehicle.
-the same with cars
My only issue is that pedestrians seem to remain stuck around intersections sometimes. I haven't been able to find any code that would affect this. I have a suspicion that it might be somewhere in a blueprint, any ideas? Pedestrians spawned on the sidewalk in the vicinity of intersections sometimes never move using Controller->MoveTo, unless I interpolate using SetActorLocation(start+ratio*end)....

Hi, I have this partly working. Perhaps I could submit a PR after the ITSC2018 deadline(1 May)...

Any updates on when these features will be included?

Hey, this was already possible in 0.9.0, and will be significantly improved in 0.9.1.

Hey, this was already possible in 0.9.0, and will be significantly improved in 0.9.1.

Hi @nsubiron could you kindly point me to an example for controlling NPCs? Thanks!


chore(main): release 1.0.1

:robot: I have created a release beep boop
1.0.1 (2024-07-26)
Bug Fixes

commit (7866c3e)
module name (0d2d924)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.1
:sunflower:


Add SonarQube configuration file

^Title

This is definitely a good practice. However I was wondering if it's necessary for a project as small as this.