HADOOP-18145.Decompress the ZIP file and retain the original file per…

Description of PR
When we use the unzip method of Hadoop common to decompress, the UNIX permission cannot be reserved, so we use the ziparchiveentry of Apache common to preserve the permission information. When the file has UNIX permission, the unzip decompression method will preserve the permission first, and then set the original permission information to the new file.
How was this patch tested?
Unit tests were conducted.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 28s

trunk passed

+1 :green_heart:
compile
24m 45s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m 47s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 38s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 30s

trunk passed

+1 :green_heart:
shadedclient
25m 14s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
25m 35s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  2s

the patch passed

+1 :green_heart:
compile
23m 38s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
23m 38s
/results-compile-javac-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 generated 4 new + 1815 unchanged - 1 fixed = 1819 total (was 1816)

+1 :green_heart:
compile
20m 45s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
javac
20m 45s
/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 1690 unchanged - 1 fixed = 1691 total (was 1691)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 75 unchanged - 0 fixed = 77 total (was 75)

+1 :green_heart:
mvnsite
1m 35s

the patch passed

+1 :green_heart:
javadoc
1m  6s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 41s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
2m 43s
/new-spotbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
shadedclient
25m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
24m 58s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

219m 43s

Reason
Tests

SpotBugs
module:hadoop-common-project/hadoop-common

Primitive value is boxed and then immediately unboxed in org.apache.hadoop.fs.FileUtil.permissionsFromMode(Integer)  At FileUtil.java:then immediately unboxed in org.apache.hadoop.fs.FileUtil.permissionsFromMode(Integer)  At FileUtil.java:[line 689]

org.apache.hadoop.fs.FileUtil.permissionsFromMode(Integer) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead  At FileUtil.java:constructor; use Long.valueOf(long) instead  At FileUtil.java:[line 688]

Failed junit tests
hadoop.fs.TestFileUtil

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4036

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux ea0d437dc151 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 07c0467c094cb2970144c628774c84e48e59f9fe

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/1/testReport/

Max. process+thread count
2398 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 32s

trunk passed

+1 :green_heart:
compile
24m  9s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m 40s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 36s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 30s

trunk passed

+1 :green_heart:
shadedclient
25m 27s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
25m 47s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  0s

the patch passed

+1 :green_heart:
compile
23m 36s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
23m 36s

the patch passed

+1 :green_heart:
compile
20m 39s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 39s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 75 unchanged - 0 fixed = 77 total (was 75)

+1 :green_heart:
mvnsite
1m 34s

the patch passed

+1 :green_heart:
javadoc
1m  3s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 39s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 41s

the patch passed

+1 :green_heart:
shadedclient
25m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
28m 18s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

223m 51s

Reason
Tests

Failed junit tests
hadoop.fs.TestFileUtil

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4036

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 3aef19088411 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5c3e32fbb791db733a6547c019e08d47db164d09

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/2/testReport/

Max. process+thread count
2637 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m  5s

trunk passed

+1 :green_heart:
compile
24m 17s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m 40s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 36s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 32s

trunk passed

+1 :green_heart:
shadedclient
25m  7s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
25m 29s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  5s

the patch passed

+1 :green_heart:
compile
24m  0s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
24m  0s

the patch passed

+1 :green_heart:
compile
20m 38s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 38s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 75 unchanged - 0 fixed = 77 total (was 75)

+1 :green_heart:
mvnsite
1m 35s

the patch passed

+1 :green_heart:
javadoc
1m  4s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 39s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 43s

the patch passed

+1 :green_heart:
shadedclient
25m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
24m 56s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

218m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4036

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux c30ae7ea90e2 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 23a09963e02a37ea540e2b313f8d04aa28043031

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/4/testReport/

Max. process+thread count
1260 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 25s

trunk passed

+1 :green_heart:
compile
28m  8s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
23m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 50s

trunk passed

+1 :green_heart:
javadoc
1m 16s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 48s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 57s

trunk passed

+1 :green_heart:
shadedclient
26m 14s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
26m 37s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
27m 26s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
27m 26s

the patch passed

+1 :green_heart:
compile
23m 33s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
23m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  5s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 75 unchanged - 0 fixed = 77 total (was 75)

+1 :green_heart:
mvnsite
1m 47s

the patch passed

+1 :green_heart:
javadoc
1m 13s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 47s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  4s

the patch passed

+1 :green_heart:
shadedclient
26m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
25m 39s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

237m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4036

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 4d8281ddfbcc 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 23a09963e02a37ea540e2b313f8d04aa28043031

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/3/testReport/

Max. process+thread count
1252 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

seems a reasonable idea, just some details about production code and tests to resolve

Thank you for your review.@steveloughran

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  0s

trunk passed

+1 :green_heart:
compile
22m 29s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 38s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 41s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 28s

trunk passed

+1 :green_heart:
shadedclient
22m 13s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
22m 36s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 38s
/patch-mvninstall-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
compile
1m  6s
/patch-compile-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
1m  6s
/patch-compile-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
0m 58s
/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
0m 58s
/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 44s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 3 new + 75 unchanged - 0 fixed = 78 total (was 75)

-1 :x:
mvnsite
0m 40s
/patch-mvnsite-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
0m 38s
/patch-spotbugs-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
shadedclient
8m  2s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 39s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

116m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4036

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 5fd9f6a724b5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c1dc8c7560d5d98b942f7ab4e30fe8583c6ab10d

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/6/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m  8s

trunk passed

+1 :green_heart:
compile
24m 19s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m 52s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 38s

trunk passed

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 30s

trunk passed

+1 :green_heart:
shadedclient
25m 10s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
25m 30s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 39s
/patch-mvninstall-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
compile
1m  7s
/patch-compile-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
1m  7s
/patch-compile-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
0m 58s
/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
0m 58s
/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 43s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 3 new + 75 unchanged - 0 fixed = 78 total (was 75)

-1 :x:
mvnsite
0m 41s
/patch-mvnsite-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
0m 38s
/patch-spotbugs-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
shadedclient
7m 40s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 37s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
asflicense
0m 24s

The patch does not generate ASF License warnings.

124m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4036

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 71086bc55f8e 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c1dc8c7560d5d98b942f7ab4e30fe8583c6ab10d

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/5/testReport/

Max. process+thread count
580 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 12s

trunk passed

+1 :green_heart:
compile
22m 19s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 38s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 43s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 30s

trunk passed

+1 :green_heart:
shadedclient
21m 59s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
22m 23s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 36s
/patch-mvninstall-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
compile
1m  5s
/patch-compile-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
1m  5s
/patch-compile-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
0m 58s
/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
0m 58s
/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 43s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 3 new + 75 unchanged - 0 fixed = 78 total (was 75)

-1 :x:
mvnsite
0m 42s
/patch-mvnsite-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
0m 39s
/patch-spotbugs-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
shadedclient
8m  5s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 38s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

115m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4036

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux f3b7e0fc3f35 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3915b0743c4283f12a1d2a6b68d2de3303650b69

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/7/testReport/

Max. process+thread count
543 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 12s

trunk passed

+1 :green_heart:
compile
24m 17s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m 43s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 38s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 30s

trunk passed

+1 :green_heart:
shadedclient
25m  6s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
25m 27s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
23m 38s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
23m 38s

the patch passed

+1 :green_heart:
compile
20m 47s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 47s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 3 new + 75 unchanged - 0 fixed = 78 total (was 75)

+1 :green_heart:
mvnsite
1m 35s

the patch passed

+1 :green_heart:
javadoc
1m  3s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 38s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 42s

the patch passed

+1 :green_heart:
shadedclient
25m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 43s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

211m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4036

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux dc3cb049a2b0 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7732357fbfae4404d331d08b9b790d4d752e4b86

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/8/testReport/

Max. process+thread count
1252 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

down to the last through checkstyles -this is good.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java:694:  /** Assign the original permissions to the file */: First sentence should end with a period. [JavadocStyle]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java:751:                Files.setPosixFilePermissions(file.toPath(), permissionsFromMode(entry.getUnixMode()));: 'if' child has incorrect indentation level 16, expected level should be 14. [Indentation]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java:751:                Files.setPosixFilePermissions(file.toPath(), permissionsFromMode(entry.getUnixMode()));: Line is longer than 100 characters (found 103). [LineLength]

can you add ext to the asserts for permissons, e.g
Good advice. I'll add it

nearly there, just fix the checkstyles and add assertion error messages on the checks for permisson
Thank you for your review again.@steveloughran

Yes, if I set the suid flag, the file will be executed with the same permissions as the owner of the executable file. I think it's dangerous. So, in the code, any file with a suid flag will end up with only executable permission +x, this is only about rwx permissions.

Yes, if I set the suid flag, the file will be executed with the same permissions as the owner of the executable file. I think it's dangerous. So, in the code, any file with a suid flag will end up with only executable permission +x, this is only about rwx permissions.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 58s

trunk passed

+1 :green_heart:
compile
24m 41s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
21m  0s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 37s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 30s

trunk passed

+1 :green_heart:
shadedclient
25m 26s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
25m 46s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  1s

the patch passed

+1 :green_heart:
compile
23m 56s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
23m 56s

the patch passed

+1 :green_heart:
compile
21m  2s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m  2s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 58s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 60 unchanged - 0 fixed = 62 total (was 60)

+1 :green_heart:
mvnsite
1m 35s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 41s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 39s

the patch passed

+1 :green_heart:
shadedclient
25m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 44s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

213m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4036

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 49ac92c75ee7 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / eb83019dbe1e8cc743cbd860b2e0dcd287bb6ab2

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/14/testReport/

Max. process+thread count
1246 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/14/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thank you for your review. @steveloughran
1.the design of this method is more redundant, but more clear, and I will improve it.
2.the test case, I try to use UserPrincipalLookupService class to update the current user groups and others, to verify the current file permissions for user groups and others as a result, but for ordinary users, is impossible to setOwner operation, this leads to the current user can't change, to this, Do you have any good suggestions?

then the permissionsFromMode() method can be tested passing in permissions for users group and other only, e.g.

`File tempFile = File.createTempFile("test-unzip", ".txt");
Files.setPosixFilePermissions(tempFile.toPath(), permissionsFromMode(0700));
UserPrincipalLookupService lookupService = FileSystems.getDefault().getUserPrincipalLookupService();
GroupPrincipal groupPrincipal = lookupService.lookupPrincipalByGroupName("staff");
UserPrincipal userPrincipal = lookupService.lookupPrincipalByName("cooper");
PosixFileAttributeView view = Files.getFileAttributeView(tempFile.toPath(), PosixFileAttributeView.class);
view.setGroup(groupPrincipal);
readTargetPermission(tempFile.toPath());
// This is going to fail because it's just a normal user
view.setOwner(userPrincipal);
readTargetPermission(tempFile.toPath());
assertTrue("file lacks execute permissions", tempFile.canExecute());
assertTrue("file lacks write permissions", tempFile.canWrite());
assertTrue("file lacks read permissions", tempFile.canRead());`
I tried to change the current user, but failed.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m  7s

trunk passed

+1 :green_heart:
compile
24m 49s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
21m  6s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 39s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 30s

trunk passed

+1 :green_heart:
shadedclient
25m 38s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
25m 59s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  1s

the patch passed

+1 :green_heart:
compile
24m  1s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
24m  1s

the patch passed

+1 :green_heart:
compile
21m  9s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 60 unchanged - 0 fixed = 62 total (was 60)

+1 :green_heart:
mvnsite
1m 36s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 40s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 41s

the patch passed

+1 :green_heart:
shadedclient
25m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 55s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

214m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/15/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4036

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux d95296821707 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3f43d54b7ce4c5a9fe40a148cdd18d80520e4d44

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/15/testReport/

Max. process+thread count
1530 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/15/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 49s

trunk passed

+1 :green_heart:
compile
29m 24s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
24m  3s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 51s

trunk passed

+1 :green_heart:
javadoc
1m 18s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 49s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 57s

trunk passed

+1 :green_heart:
shadedclient
26m 36s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
26m 59s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
27m 50s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
27m 50s

the patch passed

+1 :green_heart:
compile
24m 26s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
24m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  6s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 4 new + 60 unchanged - 0 fixed = 64 total (was 60)

+1 :green_heart:
mvnsite
1m 49s

the patch passed

+1 :green_heart:
javadoc
1m 13s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 47s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  3s

the patch passed

+1 :green_heart:
shadedclient
26m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 45s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

235m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/16/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4036

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux ce7d163f98b6 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0ecf06e77040751e3546a0416ee6bbb15c7fddea

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/16/testReport/

Max. process+thread count
1828 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/16/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 53s

trunk passed

+1 :green_heart:
compile
28m 54s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
24m  6s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 50s

trunk passed

+1 :green_heart:
javadoc
1m 19s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 55s

trunk passed

+1 :green_heart:
shadedclient
26m 47s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
27m 10s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
27m 46s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
27m 46s

the patch passed

+1 :green_heart:
compile
23m 47s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
23m 47s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  3s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 4 new + 60 unchanged - 0 fixed = 64 total (was 60)

+1 :green_heart:
mvnsite
1m 46s

the patch passed

+1 :green_heart:
javadoc
1m 13s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 44s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 10s

the patch passed

+1 :green_heart:
shadedclient
27m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 43s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

234m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/17/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4036

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 4902f4d06af0 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 90bb4aa47a7cdc1e6482a466ac1498ba7e7e3e21

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/17/testReport/

Max. process+thread count
3098 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4036/17/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

+1.
merged to trunk and cherrypicked into branch-3.3.
thanks!
sorry for being so rigorous here but we have to worry about security in the code which expands and then executes artifacts; unzip is a source of CVEs across many applications

Thanks for your guidance.
It is necessary to be strict with the code. I look forward to cooperating with you next time.


TELESTION-460 Dashboard layout editor

A layout editor for dashboards to make them configurable by users.
Interaction can be performed using both the mouse and the keyboard.
Changes are handled completely independently from the UI, allowing for both an easier way to ensure invalid states cannot occur as well as testability. During the user interaction, no actual state changes are performed. Once the interaction finishes, the changes get interpreted to the closest possible state change and "committed" to the state, where (in compliance with any business logic) the changes are applied and, thus, updates in the UI. This also allows us to implement any interactions without absolute positioning and resize observers. Instead, the native CSS grid can be used.
Due to the relative complexity and clear boundaries of this subsystem, a separate folder structure which also includes a README.md was created.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #411

PR #412

PR #417   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 26, 7:15 PM: @pklaschka merged this pull request with Graphite.


Machine-readable yotta ls output

Some common operations would be easier if yotta ls produced machine-readable output.  In particular, a way of removing the tree diagram and colour would help.
For example an output like the following would provide easy parsing
$ yotta ls --no-format
module#version
dependency1#version
linked-dependency -> link-target#version

--plain?

--porcelain?
See: git-status --porcelain

I literally shuddered just now trying --porcelain? as output reminded me of SVN...

This is something we will need also, for all yotta commands really.
From: Brendan Moran <notifications<EMAIL_ADDRESS>Reply-To: ARMmbed/yotta <reply<EMAIL_ADDRESS>Date: Friday, 20 March 2015 12:20
To: ARMmbed/yotta <yotta<EMAIL_ADDRESS>Subject: [yotta] Machine-readable yotta ls output (#186)
Some common operations would be easier if yotta ls produced machine-readable output. In particular, a way of removing the tree diagram and colour would help.
For example an output like the following would provide easy parsing
$ yotta ls
module#version
dependency1#version
linked-dependency -> link-target#version
—
Reply to this email directly or view it on GitHubhttps://github.com/ARMmbed/yotta/issues/186.
-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782

So, some commands (like build) stream the output from subprocess as they run, and add their own output before/after that.
I'd like to add a --json type flag, which processes command output into a very robust machine readable form, but unfortunately that is not easily compatible with streaming output.
So here's what I propose.
yotta accepts --plain as a top level argument (before any subcommands). This will prevent coloured output in all commands, and modify the output of commands like yotta list to remove other fancy formatting.
If that proves insufficient, we can add additional --json output flags for specific commands where it makes sense.
In the future --plain might be the default if yotta detects stdout is a pipe, too.

That sounds good to me.

See #226

This was fixed since yotta 0.13.0, when the yt ls --json format was stabilised.


Retire RHEL 6.5 instructions until we can fix them up, or are convinced ...

...there is no demand.

Currently, we do not support RHEL 6.5 due to the issues highlighted in #455.  Consequently, we should retire the RHEL 6.5 instructions until we can either fix #455 or we decide that there is no demand for support on anything earlier than RHEL 7.

\o/
The king is dead, long live the king! :sparkles:


Set up JS pipelines

Related to #54 - attempt at creating pipeline needed for #53.
To be honest, I have no idea if I'm doing this right but I want to have the following functionality:

Build - npm run build and npm pack
Analyze - npm run lint and npm audit
Test - npm test

The project defined in #53 will reside in src/ts/eslint-plugin-azure-sdk, which I access by cding in through a script block, but I'm not sure if this is the correct way to do it or how to make it modular to other projects in src/ts.
@Azure/azure-sdk-eng

I would be inclined to lift this module and put it under tools/eslint-plugin-azure-sdk. And then name your Azure Pipelines YAML file ci.yml and drop it under that directory. I've got some changes coming in this pipeline which will make it such that the azure-sdk-tools repo builds in a similar way to the other mono repos and doing what I'm proposing here would snap us towards that model.

@arpanlaha the changes you made to remove the matrix look good. You can incorporate the suggestions and address the questions made by Mitch :)

Suggestions:

Relocate the package itself under tools/eslint-plugin-azure-sdk.
Rename the js.yml file to ci.yml and move it under tools/eslint-plugin-azure-sdk.

How will this package be consumed in the JS repo - will you be publishing it to NPM and consuming it as a dev dependency?

@mitchdenny added your suggestions! This will be published to NPM under the ts-common scope and is intended to be used as a dev dependency by all the JS/TS service packages to streamline the guideline review process. Ideally all that would be required there would be to add the dev dependency and add 2-3 lines to the package's eslintrc to import the plugin and its recommended configuration.


Release ecctl v1.1.0

Version to be released

Release ecctl v1.1.0
Checklist

[x] Verify a cloud-sdk-go release with the same version has been made.
[x] Update the cloud-sdk-go dependency. (#404)
[x] Update VERSION environment variable in the Makefile and generate changelog. (#406)
[x] Execute the release.
[x] Create release branch for documentation.
[x] Modify the conf.yaml file in the docs repository to add the release branch. (https://github.com/elastic/docs/pull/2016 To be merged alongside 2.7.1 release)
[x] Run a full doc rebuild.
[x] Celebrate :tada:

The release is already out


Removing Helmfile install as it has fallen behind

When looking into the Helmfile deployment method I noticed it currently uses 0.8, we should remove it from the documentation for now to not confuse users with installing older versions.

/lgtm
/approve


Sponsor and member contact link improvement

Is your feature request related to a problem? Please describe.
We are trying to improve new members' and sponsors' experience and contact flow.
Having the same user experience as they can get from other Eclipse Foundation working group pages will be helpful.
Describe the solution you'd like
Instead of having https://adoptium.net/members/  a "want to join?" button has the same flow as this page  https://www.eclipse.org/org/workinggroups/explore.php having 2: contact us about membership that will go to the same link https://adoptium.net/join/ and My organization is ready to join now https://membership.eclipse.org/application#sign-in .
And for Sponsor's page: https://adoptium.net/sponsors/ ,  want to sponsor? Change from the form link to the same links mentioned above.
Describe alternatives you've considered
a first step for sure is changing the "want to sponsor" to the same link as "want to join?" from the member page.
Then we could add the rest of the buttons and related links.
As part of the website improvements ideas: https://github.com/adoptium/adoptium.net/issues/1253

Hi can I be assigned to this issue?

@pandenaman007 consider yourself assigned - thank you.

@pandenaman007 consider yourself assigned - thank you.

According to me we should place the "want to join" button at the starting of the webpage rather than at the end as the user would have to scroll all the way down in the same way as  the Eclipse foundation page is designed. We can have two button placed side-by-side one of "want to join" and the other should be about the contact for the membership. These should be at the top of the page just like that of the page of The Eclipse Foundation. For the "want to sponsor" we can place that one at the end of the webpage. This can be the improvements over the current format.

No ma'am I think this is good according to me and also I checked the resources You mentioned in #1253 such as that of the Jakarta Package EE . I think this good approach for the contact linking UX design so that it gets the attention of more people. Thanks for your kind support.

hi @pandenaman007 - I think this issue is not a "good first issue" because there are aspects of it that are still not defined, so requires more discussion.  If you are okay with it, I would like your help on a better defined issue, (and I would tag you shortly on a different issue to assist with).

Reading the request, I think there are some problems with the suggested workflow which I will outline after I first interpret what I think is being requested.  This is a large feature request (that is not suitable as a good first issue), it can be broken down into several smaller pieces (each of which perhaps are good first issues).
The current request is this:

Update the members page
a. Change the link of the "Want to Join" button to link to https://adoptium.net/join/
b. Change the text "Want to Join" button to say "Become a Member"
c. Add a 2nd button called "My organization is ready to Join" which links to https://membership.eclipse.org/application#sign-in
Update the sponsors page
a. Change the "Want to become a sponsor?" button to link to https://adoptium.net/join/
b. Add a 2nd button called "My organization is ready to Sponsor" which links to https://membership.eclipse.org/application#sign-in (this is bad, see notes below)

Problems to consider:
1 - if we want to change the flow to be like https://www.eclipse.org/org/workinggroups/explore.php, then we are missing a link off to a page that describes what a working group is (https://www.eclipse.org/org/workinggroups/about.php)
1b - requesting that "Become a Member" button leads off to a form to contact us, so it is misleading, perhaps "Contact us" is more accurate
1c - what wording to put on a 2nd button "My organization is ready to Join" is likely 'too long', perhaps "Join now"
2a - this is wrong, if they want to sponsor we are driving them to a contact us page that is saying they have to join the working group
2b - this is wrong, they are saying they are ready to sponsor, and we ignore that request and drive them to a membership application
We have many web pages being discussed as part of this workflow:

Page
Link
Notes

"Members" page
https://adoptium.net/members/
a list of existing members and button(s) to take action

"Member Application form" page
https://membership.eclipse.org/application#sign-in

"Sponsors" page
https://adoptium.net/sponsors/
a list of existing sponsors and button(s) to take action

"Sponsor Application form" pdf
https://www.eclipse.org/org/workinggroups/sponsorship/working-group-sponsorship-agreement.pdf
This likely should not be a direct download from a button, but rather a link with text: "Sponsorship Agreement" off of the "How to Support Us" page

"Join" page
https://adoptium.net/join/
should be renamed "Contact form" page has the header "Join the Eclipse Adoptium® Working Group", which should be changed to "Contact us"

"About working groups" page
https://www.eclipse.org/org/workinggroups/about.php
not part of our website, but can link off to it for informational reasons)

"How to support us" page
TBD
doesn't exist yet, this should describe the preferred, various ways that people and organizations can support our project, and that EF membership fees are directed to general services, not to specific project needs

Adding a flow diagram for a potential flow from the members page to other pages (and what those pages link off to):
flowchart LR

A[Members page]
A --> C{Decision}
C -->|Learn More| D[How to Support Us page]-->|Contact us| B[Contact form page]
C -->|Contact Us| F[Contact form page]
C -->|Ready to Join| E[Membership Application page]
D -->|About Working Groups| G[About working groups page]
D -->|Sponsor Us| H[Sponsor Application form]
D -->|Join EF| I[Membership Application page]
D -->|Join Adoptium WG|J[Membership Application page]

Yes Ma'am I think this will require more level of understanding and experience for me to solve. Please assign me some other issue and I would be very happy to solve that issue. Again thanks a lot for your kind support.

@pandenaman007 - if you can shift over to work on https://github.com/adoptium/aqa-tests/issues/4199 that would be wonderful!

@smlambert can take up this?


Missing SSL certificate roots

The following error can be seen in the ingress-controller container logs every minute when you have an Ingress definition using a TLS secret (in my case a cert from Let's Encrypt):
backend_ssl.go:153] unexpected error generating SSL certificate with full intermediate chain CA certs: x509: failed to load system roots and no roots provided

The line of code in question is this one.
This is because the Debian base image used by the ingress-controller image doesn't ship with root CA certs, so it can't verify the full chain.
We can work around this by starting the ingress-controller container with a command like:
sh -c apt-get update && apt-get install -y ca-certificates && /kong-ingress-controller <options...>

But it would probably be nicer to do something like this in the Dockerfile:
apt-get update && apt-get install -y ca-certificates

I am using the Kong Ingress controller snis-fix branch.
A similar fix might be needed in the kong:0.X-centos7 Dockerfiles, by the way, but not the Alpine ones, because they already include apk add ca-certificates.

Hi @dag24,
Thank you for reporting this issue.
I've opened up #95, which should fix this issue.

This is fixed in 0.1.0, thank you!


Create Detection for log4j exploit

Background
This rule will search ALL FIELDS in the log sources defined in the yaml. This is needed because the exploit can be injected into a ton of fields, headers, etc. Casting a wide net but the strings are oddball enough that I think the False positive rate should be low
Changes

Create log4j exploit rule and tests

Testing
CI/CD and Unit tests

This rule will search ALL FIELDS in the log sources defined in the yaml. This is needed because the exploit can be injected into a ton of fields, headers, etc. Casting a wide net but the strings are oddball enough that I think the False positive rate should be low

Any performance concerns we should have?

This rule will search ALL FIELDS in the log sources defined in the yaml. This is needed because the exploit can be injected into a ton of fields, headers, etc. Casting a wide net but the strings are oddball enough that I think the False positive rate should be low

Any performance concerns we should have?

@jpl5280  There shouldn't be. Running unit tests locally the performance is very similar to other complex rules that we have.
panther_analysis_tool test --filter RuleID=IOC.Log4jExploit  **2.23s user 0.51s system 97% cpu 2.818 total**

panther_analysis_tool test --filter RuleID=GSuite.Drive.ExternalFileShare  **2.20s user 0.55s system 97% cpu 2.824 total**

This rule will search ALL FIELDS in the log sources defined in the yaml. This is needed because the exploit can be injected into a ton of fields, headers, etc. Casting a wide net but the strings are oddball enough that I think the False positive rate should be low

Any performance concerns we should have?

My main concern is that for high volume log sources that don't normally have any complex rules running on them (like say VPC flow logs or s3 server access logs maybe) this could represent a significant uptick in processing. Will be good to keep an eye on how this performs.
But in general I agree, pretty much any amount of local processing will be faster than some of our rules that reach out to dynamdb or even the open internet to do IP lookups and the like.


Package.GetAppInstallerInfo() returns Err with HRESULT 0x00000000

Summary
Package.GetAppInstalllerInfo() returns a confusing error:
Failed to get AppInstallerInfo for name: Paint publisher: Microsoft Corporation : Error {
    code: HRESULT(0x00000000),
    message: "The operation completed successfully.",
}

I've tried this on windows 10 and 11 and all Packages that FindPackages returns gives the error when calling GetAppInstallerInfo.
Crate manifest
[package]
name = "winpacman"
version = "0.1.0"
edition = "2021"

[dependencies]
anyhow = "1.0.94"
tabled = "0.17.0"
windows = { version = "0.58.0", features = ["Management", "ApplicationModel", "Management_Deployment", "Foundation_Collections"] }

Crate code
use anyhow::Context;
use tabled::{Table, Tabled};
use windows::ApplicationModel::{AppInstallerInfo, Package, PackageVersion};
use windows::Management::Deployment::PackageManager;

#[derive(Tabled, Debug)]
struct App {
    pub name: String,
    pub publisher: String,
    pub version: String,
}

fn main() -> anyhow::Result<()> {
    let pacman = PackageManager::new().context("Failed to get Package Manager")?;
    let packages = pacman
        .FindPackages()
        .context("Failed to get all packages")?;
    let mut apps = vec![];
    for package in packages {
        if package
            .IsFramework()
            .context("Failed to check if IsFramework")?
        {
            continue;
        }
        let name = package
            .DisplayName()
            .map(|h| h.to_string_lossy())
            .unwrap_or_default();
        let publisher = package
            .PublisherDisplayName()
            .map(|h| h.to_string_lossy())
            .unwrap_or_default();
        let version = match package.GetAppInstallerInfo() {
            Ok(a) => {
                let version = a.Version().context("Failed to get version")?;
                format!("{:?}", version)
            }
            Err(e) => {
                eprintln!("Failed to get AppInstallerInfo for name: {name} publisher: {publisher} : {e:#?}");
                "".to_string()
            }
        };
        let version = format!("{:?}", version);
        apps.push(App {
            name,
            publisher,
            version,
        });
    }

    let table = Table::new(&apps).to_string();
    println!("{table}");

    Ok(())
}

This just means that the call returns a null pointer "successfully". You'll notice this behavior seems to be expected based on the C# sample here:
https://learn.microsoft.com/en-us/uwp/api/windows.applicationmodel.package.getappinstallerinfo?view=winrt-26100

Also just a heads up, as a user of .appinstaller myself--Microsoft disabled the ms-appinstaller: protocol/scheme handler, so I'm not sure how useful this API is anymore.


added case-sensitive note to multipliers

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingAds/hotel-service/reference.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Error: Cannot find module 'juice'

I've tried updating from v2 to v3 but apparently v3 depends on a 'juice' module that is not in email-templates own depedencies. Do you want me to submit a PR with this feature or is it this way on purpose ?

Seems I'm not the only one #248

@hugodes which version of email-templates are you using?  please use the latest if you can.  npm install email-templates@latest or yarn add email-templates@latest.  juice is in fact a listed dependency in the project if you look at https://github.com/niftylettuce/email-templates/blob/master/package.json#L22-L23.  there was a bug in an older version of 3.x that had this issue.

@hugodes if this is still an issue please comment here again with more info including what version of node and what version of email-templates you are using.  thanks!

@niftylettuce  I'm using 3.1.7 , node 8.9.1 (LTS)

@hugodes can you try reinstalling?  it should be OK, juice is listed as a dep.  try clearing and reinstalling your node modules?

I've node so, rm -rf node_modules && npm install (with this line in my package.json:     "email-templates": "^3.1.7",

@hugodes what is the version that gets installed in node_modules?  can you open node_modules/email-templates/package.json and share the version?  also feel free to join our Slack channel if you'd rather ping me there to help figure out this weird issue.

{   "_args": [     [<EMAIL_ADDRESS>      "/Users/hugodes/src/core/corejs"     ]   ],   "_from"<EMAIL_ADDRESS>  "_id"<EMAIL_ADDRESS>  "_inBundle": false,   "_integrity": "sha512-qaev+07u7czIDAVoCPT/8RZcDZZPe9FA/ezaYHcIJagAJI6e/DHujBGmCGje+Z0PTaLoS0SmKVXeI5WcjWF/Kg==",   "_location": "/email-templates",   "_phantomChildren": {     "async": "2.5.0",     "chalk": "1.1.3",     "cheerio": "0.22.0",     "commander": "2.9.0",     "cross-spawn": "5.1.0",     "datauri": "1.0.5",     "graceful-fs": "4.1.11",     "htmlparser2": "3.9.2",     "lodash.unescape": "4.0.1",     "mensch": "0.3.3",     "ms": "2.0.0",     "request": "2.83.0",     "slick": "1.12.2",     "universalify": "0.1.1",     "valid-data-url": "0.1.4",     "xtend": "4.0.1"   },   "_requested": {     "type": "version",     "registry": true,     "raw"<EMAIL_ADDRESS>    "name": "email-templates",     "escapedName": "email-templates",     "rawSpec": "3.1.7",     "saveSpec": null,     "fetchSpec": "3.1.7"   },   "_requiredBy": [     "/"   ],   "_resolved": "https://registry.npmjs.org/email-templates/-/email-templates-3.1.7.tgz",   "_spec": "3.1.7",   "_where": "/Users/hugodes/src/core/corejs",   "author": {     "name": "Nick Baugh",     "email"<EMAIL_ADDRESS>    "url": "http://niftylettuce.com"   },   "bugs": {     "url": "https://github.com/niftylettuce/email-templates/issues",     "email"<EMAIL_ADDRESS> },   "contributors": [     {       "name": "Nick Baugh",       "email"<EMAIL_ADDRESS>      "url": "http://niftylettuce.com"     }   ],   "dependencies": {     "@ladjs/i18n": "^0.0.5",     "auto-bind": "^1.1.0",     "consolidate": "^0.14.5",     "debug": "^3.1.0",     "fs-extra": "^4.0.2",     "get-paths": "^0.0.2",     "html-to-text": "^3.3.0",     "juice": "^4.2.0",     "juice-resources-promise": "^0.0.2",     "lodash.defaultsdeep": "^4.6.0",     "lodash.isempty": "^4.4.0",     "lodash.isfunction": "^3.0.8",     "lodash.isobject": "^3.0.2",     "lodash.isstring": "^4.0.1",     "lodash.merge": "^4.6.0",     "lodash.omit": "^4.5.0",     "nodemailer": "^4.1.3",     "preview-email": "^0.0.6"   },   "description": "Create, preview, and send custom email templates for Node.js. Highly configurable and supports automatic inline CSS, stylesheets, embedded images and fonts, and much more! Made for sending beautiful emails with Lad.",   "devDependencies": {     "ava": "^0.22.0",     "babel-cli": "^6.26.0",     "babel-preset-env": "^1.6.1",     "cheerio": "^1.0.0-rc.2",     "codecov": "^2.3.0",     "cross-env": "^5.0.5",     "eslint": "^4.8.0",     "eslint-config-prettier": "^2.6.0",     "eslint-plugin-prettier": "^2.3.1",     "husky": "^0.14.3",     "lint-staged": "^4.2.3",     "nyc": "^11.2.1",     "prettier": "^1.7.4",     "pug": "^2.0.0-rc.4",     "remark-cli": "^4.0.0",     "remark-preset-github": "^0.0.7",     "xo": "^0.19.0"   },   "engines": {     "node": ">=6.4.0"   },   "files": [     "lib",     "locales"   ],   "homepage": "https://github.com/niftylettuce/email-templates",   "keywords": [     "email",     "lad",     "lass",     "koa",     "pug",     "consolidate",     "template",     "templates",     "engine",     "postmark",     "sendgrid",     "mailchimp",     "mandrill",     "transport",     "nodemailer",     "moonmail",     "mailgun"   ],   "license": "MIT",   "lint-staged": {     "*.{js,jsx,mjs,ts,tsx,css,less,scss,json,graphql}": [       "prettier --write --single-quote --trailing-comma none",       "git add"     ],     "*.md": [       "remark . -qfo",       "git add"     ]   },   "main": "lib/index.js",   "name": "email-templates",   "remarkConfig": {     "plugins": [       "preset-github"     ]   },   "repository": {     "type": "git",     "url": "git+https://github.com/niftylettuce/email-templates.git"   },   "scripts": {     "build": "babel src --out-dir lib",     "coverage": "nyc report --reporter=text-lcov > coverage.lcov && codecov",     "lint": "xo && remark . -qfo",     "precommit": "lint-staged && npm test",     "test": "npm run build && npm run lint && npm run test-coverage",     "test-coverage": "cross-env NODE_ENV=test nyc ava",     "watch": "babel src --watch --out-dir lib"   },   "version": "3.1.7",   "xo": {     "extends": "prettier",     "plugins": [       "prettier"     ],     "parserOptions": {       "sourceType": "script"     },     "rules": {       "prettier/prettier": [         "error",         {           "singleQuote": true,           "bracketSpacing": true,           "trailingComma": "none"         }       ],       "max-len": [         "error",         {           "code": 80,           "ignoreUrls": true         }       ],       "capitalized-comments": "off",       "camelcase": "off",       "no-warning-comments": "off"     },     "space": true   } }
I'll join you on slack

@niftylettuce what's your handle on slack ?

im niftylettuce on Slack
http://slack.crocodilejs.com
On Nov 22, 2017 12:46 PM, "Hugo Des"<EMAIL_ADDRESS>wrote:

@niftylettuce https://github.com/niftylettuce what's your handle on
slack ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/niftylettuce/email-templates/issues/263#issuecomment-346425535,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAf7hdUTHqQ5FiCBaKvvQeYL5fj3x8SMks5s5F4MgaJpZM4QnucZ
.

Experience the same problem...

@climberwoodi can you try yarn clean email-templates or npm clean email-templates to see if that resolves issue?

I haven't been able to reproduce and the Travis-CI tests are all passing so I'm guessing this is a local/cache only issue.
I'd suggest upgrading npm install -g npm if you need, but if you have further information on how to reproduce please let me know.

@niftylettuce I'm facing this same issue using email-templates ^3.3.3 which has a juice dependency of ^4.2.2. After running npm install from my root project, the juice dependency is apparently not being added to my node_modules.


Java JAR contains native library twice

Describe the bug
There are two copies of the libusearch.so in the JAR file.  This shouldn't break anything, but it would cause the JAR to be larger than it should be.
shasum -a 256 libusearch.so
0eed2c593261e727b31e83b75323de927959b4bdf36d3d48c7ce2007e018674c  libusearch.so
shasum -a 256 shared/libusearch.so
0eed2c593261e727b31e83b75323de927959b4bdf36d3d48c7ce2007e018674c  shared/libusearch.so

Steps to reproduce

Download the 2.8.12 JAR from Maven central
Unzip the JAR
Inspect the JAR contents

Expected behavior
Jar contains a single
USearch version
2.8.12
Operating System
n/a
Hardware architecture
Arm
Which interface are you using?
Other bindings
Contact Details
No response
Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey @ccjernigan! Thank you for spotting the issue! Any chance you know how to fix it? I'm only the basics of using Java and Bazel.


[Event Request] Application “Tests-ERM”, Codeunit 134460 "ERM Item Cross Reference Sales"

[Event Request] Application “Tests-ERM”, Codeunit 134460 "ERM Item Cross Reference Sales"

Could you please insert the OnTestInitialize Event at the beginning of Initialize procedure?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


i have a problem

after i did made the rat i did run at the pc still not working the discord bot keeps being offline i need help fr

Hey, just use the ModdedPysilon version, it covers every bug and it make sure your discord account never get banned.
Leave me a star if you like my project ;)

Hey, just use the ModdedPysilon version, it covers every bug and it make sure your discord account never get banned. Leave me a star if you like my project ;)

can i have link for a modded project? and thank you i will leave for u a star


Unsafe storage keys due to potential collision

It was reported by @hanakannzashi to https://github.com/near/near-sdk-rs/issues/1141, but I checked near-sdk-contract-tools and realized that it has the same issue:
Hard-coded Storage key is unsafe, this may lead to colliding key-values stored in collections if user has other collections and uses 0 storage key for something else. It can either fail or even go unnoticed if the schema is the same:
#[derive(BorshSerialize, BorshStorageKey)]
enum StorageKey {
    MyKey {
        account_hash: Vec<u8>
    },
    // other variants
}

https://github.com/near/near-sdk-contract-tools/blob/1efbd10059cb7472c80eac4b482c9d005d00af24/src/standard/nep171/mod.rs#L72-L75

First and foremost, this is a valid concern. Thank you for the report.
Here is how near-sdk-contract-tools currently handles storage keys for most components (e.g. NEP-141):

A default storage key prefix is defined here. In the case of NEP-141, this default prefix is "~$141".
All storage entries managed by a component use that prefix to construct their keys.
All components allow the user to override the default storage prefix. Here is a test that demonstrates that functionality.

With that being said, there are not currently any safeguards that prevent (or even warn a user against) duplicating/overloading a storage key. That seems like a difficult problem to solve, though, without creating a complex compile-time key management system and prohibiting the use of env::storage_* methods.

Ah, I see, near-sdk-contract-tools deals with the storage keys much better than near-contract-standards. Given that the chances are that there will be a collision with ~$141 prefix are much lower than a simple enum-index key, I believe this issue can be closed as resolving it, as was mentioned above, would require some generic solution on near-skd-rs side.


Install the SlimeVR Overlay

This is blocked on the autoupdater. The plan is for the MSI installer to call the autoupdater cli to handle all of the dirty work.

Need more Infos. What to get in the Installer and where to put, what to register,...


The web UI should provide assistance for configuration validation

The web ui should provide facilities for executing (and capturing output of) e.g
logstash --config-test

on each slave, thereby verifying that the configuration file is correctly written and doesn't contain any syntax errors.
OR
The web ui should allow the user to view logstash's own log-file wherein configuration problems will typically be written.

Out of date


Quick question on ./zenbot.sh sell cancelorder!

Remove everything above before creating your issue.
System information
Stock ubuntu 16.04.4 LTS
Custom script.
Zenbot Master Repository
Stock Zenbot Conf.js
Describe the problem
Hello! I have been updating my cryptoping plugin for zenbot, and it's been awhile since I've dug into the code, but does zenbot support cancel_after on ./zenbot.sh sell command?
Source code / Error logs
My script: https://github.com/juanzolo/Zenbot-CryptoPing/blob/master/polo.py

Hi @juanzolo, some time ago we changed our policy to no longer allow questions in our GitHub Issues (as stated in the first line when you create a new issue), please post your question to our reddit instead:
https://www.reddit.com/r/zenbot/


A small change to update a file name in the query tutorial

I was working through this tutorial and noticed that the generated file name is actually LaunchListQuery.kt and thought it might confuse people.

@nymerias: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Thanks a lot 🤗 !


Odd behavior with apps started from a group.

I noticed that marathon-consul seems to have trouble creating names for apps started from a group in marathon.
If we create a simple group:
{ "groups": {"id": "a", "apps": [{"id":"b", ...}]}}

and start the group with curl -XPUT http://marathon/v2/groups/foo ...
marathon will start an app named /foo/a/b
but marathon-consul stores this under the key marathon/foo-a-b/tasks/foo_a_b.c76b66f4-0f16-11e5-bcfb-56847afe9799
Is this expected behavior? It is rather unwieldy to use keys of this form from consul-template.

I'm going to close this. Its a non-issue which I attribute to not fully understanding the consul KV paths, and lack of sleep :)


Stratagem GUI should be hidden if not available

Fixes #1160.
Stratagem info: "Scan Filesystem Now", "Top inode Users", "File Size Distribution", ... is all shown in filesystem detail page, but there's no stratagem profiles or components installed on servers.
To Reproduce
Steps to reproduce the behavior:

Create filesystem in managed mode.
See Stratagem components

Expected behavior
No stratagem components
Signed-off-by: Will Johnson<EMAIL_ADDRESS>

Codecov Report

Merging #1165 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1165   +/-   ##
=======================================
  Coverage   95.39%   95.39%
=======================================
  Files           2        2
  Lines         152      152
=======================================
  Hits          145      145
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bbe9e6...dbae6e1. Read the comment docs.


Code cleanup: move TODO items into a GitHub Issue

Description
https://github.com/rubyforgood/diaper/issues/310 is to go through TODO items in the codebase. This PR addresses one of those TODO items by deleting the TODO item.
Notes on why delete TODO item with no code change
These are covered in https://github.com/rubyforgood/diaper/issues/411
Checklist:

[x] I have performed a self-review of my own code,
[x] ~I have commented my code, particularly in hard-to-understand areas,~
[x] I have made corresponding changes to the documentation,
[x] ~I have added tests that prove my fix is effective or that my feature works,~
[x] New and existing unit tests pass locally with my changes ("bundle exec rake"),
[x] ~Title include "WIP" if work is in progress.~

Should we keep these todos as todos or make issues? @armahillo

@ElishebaW I've created issues for each of those items, so the TODOs can be deleted! :+1:


Issue with basePath encoding in result uri

Hi,
Have got an issue with latest version 3.0.2
We used some custom filter which replaced %7E back to ~ in result url.
It was done via manipulating FilterContext and replacing originalPath and substitutedPath.
In latest version that trick does not work.
So I'm expecting:
Logged in console http://localhost:8080/restapi/v1.0/acc/~/ext/asdhdj,123fhfjhs,null,"%@*:!"
Sent to server http://localhost:8080/restapi/v1.0/acc/~/ext/asdhdj%2C123fhfjhs%2Cnull%2C%22%25%40*%3A%21%22"
Actual sent to server:
http://localhost:8080/restapi/v1.0/acc/%7E/ext/asdhdj%2C123fhfjhs%2Cnull%2C%22%25%40*%3A%21%22"
Could you please giva an advice how to solve it in better way?

Hmm one idea would be to disable URL encoding and perform it yourself in a filter. Thus you should be able to control exactly how to deal with certain characters.

Have tried but got issue with method com.ringcentral.qa.platform.restassured.CustomRequestSpecificationImpl#generateRequestUriForLogging
So current solution is to disable encoding for all `com.ringcentral.qa.platform.restassured.CustomRequestSpecificationImpl#partiallyApplyPathParams' and logging filters and added
 URL url = new URL(targetUri)
        URI uriFromUrl = new URI(url.getProtocol(), url.getUserInfo(), url.getHost(), url.getPort(), url.getPath(), url.getQuery(), url.getRef())
        targetUri = uriFromUrl.toASCIIString()

to generateRequestUriForLogging() and
  URL url = new URL(baseUri + targetPath)
            URI uriFromUrl = new URI(url.getProtocol(), url.getUserInfo(), url.getHost(), url.getPort(), url.getPath(), url.getQuery(), url.getRef())

to sendHttpRequest()

@johanhaleby I could provide pull request if you guide me how to fix it in a better way


Add six to install_requires

six is a documented dependency, add it to install_requires accordingly

Thanks for adding this! If you accept the CLA (https://cla.developers.google.com/) I can merge.

@soupytwist Hi Nick! I'm not too keen to sign a CLA at the moment, especially for such a small, metadata only change, but happy for you to close this or replace it with a PR of your own. If there are better alternatives I'm all ears

I've added this in the latest commit. Thanks for your help!

@soupytwist Thank you Nick, my pleasure :)


Weird training loss curve on VOC2007

I followed the instructions in the README to train faster rcnn(vgg16 backbone) model on Pascal VOC 2007. My environment is Ubuntu14.04 + tensorflow r1.2 + GTX1080ti. After training, I get such total loss curve on tensorboard

the orange one is the train loss and the blue one is the val loss(on VOC 2007 test set), does these two loss curve seem normal? I'm a little confused

quite normal to me.. did you get similar results after training?

yes, I get ~70 mAP on VOC2007 test set(trained on VOC 2007 trainval). I just wonder why the training loss is oscillating and the performance on validation set doesn't get better as time goes by?

@endernewton yes, I get ~70 mAP on VOC2007 test set(trained on VOC 2007 trainval). I just wonder why the training loss is oscillating and the performance on validation set doesn't get better as time goes by?

according to traditional ML it is called overfitting, but maybe convnet has other intriguing properties except this one. closing.

@yaoqi-zd  Hi, I am quite curious about  how to make  two curves show together on a  graph?
and  did you train your model at trainval set? Do you mean  training the model with the tfrecord create with trainval.txt in pascal_voc2007?   Thanks.