browse page acceptance things

[ ] filters should be using the icon in the ux designs
[ ] we need some sort of animation on close of the filters, right now it closes too quickly.. folks should be able to see the box check and things apply and then the menu close with ease
[x] the entire checkbox item check and text should be interactive and show a change of mouse pointer on interaction
[x] view package should be 18px, its really important that this stand out; the idea of the button on hover also helped to communicate this; also package should start with an uppercase P
[x] package names should turn blue and underline on hover to represent a link
[ ] the subheading needs to have a max-width added to it, otherwise, the line length becomes too long and is not readable, pls see figma for suggestion. also the you can msg needs to be on its own line

@praneetloke @cnunciato wasn't sure where or how you wanted this feedback, let me know if an issue is not the right thing for you

im going to close this, we can open a separate issue if the later items come up again.


Context might not have get method

This change fixes undefined is not a function exception

Thank you for submitting this fix.
I'm closing this PR because the most current version doesn't have this problem (branch 1-0-stable).


[Feature] Multiple toolbox items

Adds ability to display 3 separate toolbox entries for header tool with different levels.
Removes header options block tunes
Works with https://github.com/codex-team/editor.js/pull/2692

I'm not sure that we need to provide multiple toolbox items for Heading out of the box. It can mess the default UI. Questionable.


singularity fails to run images

Describe the bug
Nixpkgs's package of Sylabs SingularityCE (singularity) now fails to execute image.
After initial examination, the known cause is the failure to substitute default FHS PATHs for some files, but the fix is WIP.
Steps To Reproduce
Steps to reproduce the behavior:

cd NixOS/nixpkgs
nix run .#singularity exec -- "$(nix build .#singularity.tests.image-hello-cowsay --print-out-paths)" hello | nix run .#apptainer exec -- "$(nix build .#apptainer.tests.image-hello-cowsay --print-out-paths)" cowsay
See error.

Expected behavior
singularity exec <image> <commands> should succeed.
 _______________
< Hello, world! >
 ---------------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers
@jbedo @ShamrockLee

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

Add a :+1: reaction to issues you find important.

nix run .#singularity exec

singularity isn't supposed to work without setuid?

nix run .#singularity exec

singularity isn't supposed to work without setuid?

Yup. The error seems to result from failure to replace all the default paths after source file hierarchy changes.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1639


Azure Germany/Management API: The subscription '[…]' could not be found

I have created a subscription with Azure Germany, and now I am attempting to deploy my application topology there using the Azure Management API and a service principal.
Deployment works fine towards the regular Azure cloud, however when I attempt to deploy towards my subscription in Azure Germany, I get the following error message: The subscription '[...]' could not be found.
I am able to successfully acquire an authentication token using AuthenticationContext.AcquireTokenAsync(), and I am using "https://login.microsoftonline.de/[directoryId]" as authority and "https://management.core.cloudapi.de/" as resource. Additionally, I am using "Germany Northeast" as location/region.
The error occurs as soon as I attempt to perform a typical management task, such as creating a resource group.
I have checked the following things:

App registration settings
App permissions (Windows Azure Active
Directory + Windows Azure Service Management API)
Correctness of
subscription id, app id, and app secret/key

I am at a loss at what could be wrong. What could be causing this error message?

You need to make sure that the subscription is in the same directory as the application you are using for authentication, that the application is authorized to use resource manager APIs, and that the application has been assigned a role that provides it access to the subscription (at leasr reader, but you probably want it to have Contributor or Owner access).
If you think that all this is the case, then getting the request/response traces for your calls would help to diagnose the issue.  You can use the Log4Net extension library: https://www.nuget.org/packages/Microsoft.Rest.ClientRuntime.Log4Net/ to get Log4Net logs of the traces, or you can attach your own tracing interceptor to ServiceClientTracing here:  https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/src/ClientRuntime/Microsoft.Rest.ClientRuntime/ServiceClientTracing.cs#L81

@andrerav hope our suggestion resolved your issue. Closing this issue.

Found it: For some reason the ResourceManagementClient doesn't use the Environment settings of the AzureEnvironment from the AzureCredentials object it gets in the constructor.
Therefore it accesses the wrong management endpoint and doesn't find anything of course.


Your wiki page is GitHub theme dependent

Hi,
The images you use in your wiki page seem to be GitHub theme dependent. I had to change my GitHub theme to view them properly. My default them is "Dark default". When I view the wiki page with that theme, this is what I see:

But when I switch to the "Light default" theme, I see everything properly:

Sorry about the late response. And no, it's not fixed yet - in fact, there's no change at all.

Why am I unable to reopen this issue?

It's reopened now.

Please recheck it. Does it work for you now?

The first image has a white background now for both light and dark themes. The second and third images seem to have a transparent bg. While this does not affect the second image (it still looks weird but not unintelligible), the rownames and colnames in the third heatmap disappear in the dark theme. You should also be able to enable themes and check images on your end.

Thanks for your feedback. But I will not spend too much time accommodating different github themes cause it is not that important to me.
You can switch to a traditional theme to view the wiki/parameter, or you can just save the picture on your own computer for easy access.

Another option is to have the images as clickable links ( that opens the image in a new tab and add some text stating that if the images don't render properly owing to GitHub themes, click on the image to view it in a new tab - that fixes the problem.

This is a good suggestion. Could you please modify it and make a pull request?

I did not know one could fork and modify the wiki, or I'd have contributed in a better manner. I'll fix the images and add links and submit a PR over the next few days.

For the moment, you're welcome to look at https://github.com/RamRS/PyComplexHeatmap/wiki/Features - the image is stable across themes.

I have updated the wiki pages to be theme independent. Apparently PRs cannot be created for wiki pages, so please clone https://github.com/RamRS/PyComplexHeatmap.wiki.git, set https://github.com/DingWB/PyComplexHeatmap.wiki.git as a remote and push to that remote to merge in the changes.

Thank you, Ram. I have already pushed your wiki.git to https://github.com/DingWB/PyComplexHeatmap.wiki.git.
Please recheck whether it works.

BTW, what do you think of this PyComplexHeatmap? Do you have any suggestions for this package?

I'll check it out. I use ComplexHeatmap A LOT but I stay away from Python so any testing will need to be exclusively for the purpose of testing your package, not during regular usage.

Hi, your wiki images are back to being broken after your latest commit. All it takes is to replace the transparent background with a white background on the PNG files. Maybe do that before uploading the images to github?


Website (metasmoke.erwaysoftware.com) gives a 503 service unavailable Error.

The website (https://metasmoke.erwaysoftware.com/), linked from the description of this github repo is broken, It gives me a "503 Service Unavailable" error page. Would be nice if it worked :-)

Yes, this is a recurring issue, but it belongs to https://github.com/Charcoal-SE/metasmoke


Shrink all-packages.nix

Issue description
I think everyone agrees that all-packages.nix has become too difficult to maintain. I hope we can look into moving some of it into separate files. My goal would be to get it to under 15,000 lines which is the max GitHub will display. Right now it is 21,380 lines. This is related to #39169.
Easy changes

[ ] Merge common "inherit (x)" uses
[ ] Move "nixpkgs.windows" attribute to its own file
[ ] Move "nixpkgs.linuxPackagesFor" to its own file
[ ] Move "nixpkgs.tests" to its own file
[ ] Get rid of legacy "emacsPackagesGen" stuff (emacsPackagesNg has replaced it)
[ ] Move some aliases to aliases.nix

Hard changes

[ ] Move "stdenv" stuff to its own stdenv-packages.nix file
[ ] Get rid of overrides in all-packages.nix (#39515)

[ ] Autogenerate pkgs/package-list.nix and use that as a base for most of what pkgs/top-level/all-packages.nix now does.

Maybe even alphabetically order it?


Completed making Pumpkin Pursuit Game

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #1939

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸
https://github.com/kunjgit/GameZone/assets/112749383/7d7ce15d-8b8e-49d4-9420-9007990fdbf9

Thank you soo much for contributing to our repository 💗

Thank you @akhilender-bongirwar ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

you have to add proper game thumbnail !!!

you have to add proper game thumbnail !!!

Sure @kunjgit, will add it now. :)

Thank you  @akhilender-bongirwar , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Hey @akhilender-bongirwar,
You can't work on a closed issue 👀!
Follow the proper guideline and make a new PR again 😀.
Happy Hacking 💗


ENH be able to plot MEG fields to the scalp surf

@BushraR this will give you the MEG fields in the scalp if you put to True the head_surf. It will do a remapping to the scalp surf instead of the helmet one. I put in the example how you can use it (commented at the end)
I was using it for my own plots. I don't know if @agramfort @Eric89GXL find this kind of useful to keep it.
Closes #2002.

Edited your description to add the "closes" tag

Ok I've changed it by giving the trans path but I don't get why Travis is not happy. It looks like it's not finding the trans fname? but it's the same that was used before I didn't change that one.

Coverage decreased (-10.58%) to 79.71% when pulling 96cb1af0d13e247f3aa5d53c759b19b52eaf1107 on yousrabk:field_map into 18b82607d18d9603ac62c33fe91b3b4a8094ab66 on mne-tools:master.

Sure @mainakjas, done!

@yousrabk did you test if this works when no EEG channels are present in the data?

Yes @mainakjas as it was working before, I just added a parameter allowing the computation of MEG fields in the head surf. It is not changinf anything else.

Perfect, I think that makes more sense.

Error:
https://travis-ci.org/mne-tools/mne-python/jobs/59890828

@yousrabk this good to go from your end? I see the CIs are happy now.

Yes it's ready to go from my end. Thank you @Eric89GXL

Thanks for the enhancement @yousrabk!


Reusing deployed address?

I deploy contract with different address and yet the contract address is still same ?
Wallet Ethereum Address: 0xD1244aa84ad5188783721f2D142380F0F1e95088
Wallet f4Address:  f410f2esevkck2umipa3sd4wrii4a6dy6suei4hcukxa
reusing "SimpleCoin" at 0x5A85Bc1Cc4764F5F3f3850Abc3A64D78e6829Fb2

is this behaviour intended? and why?

By different address do you mean you are using a new private key? After making a deployment, hardhat stores all the metadata in the "deployments" directory. If you want to redeploy the contracts to new addresses you can use yarn hardhat deploy --reset


Error downloading release files after upgrade to 1.20.3 (HTTP code 500)

Description
After upgrading 1.19.0 -> 1.20.3, the following error is shown when trying to download a release file:
An error occurred:

Open, open /var/lib/gitea/data/data/attachments/7/3/73bcfcc3-ab3c-42b3-9980-6f1e99312034: no such file or directory

Looking at the startup logs it seems that the attachments path is different despite using the same configuration.
Before upgrade:
...s/storage/storage.go:175:initAttachments() [I] Initialising Attachment storage with type:
 ...les/storage/local.go:45:NewLocalStorage() [I] Creating new Local Storage at /var/lib/gitea/data/attachments

After upgrade:
...s/storage/storage.go:176:initAttachments() [I] Initialising Attachment storage with type: local
...les/storage/local.go:33:NewLocalStorage() [I] Creating new Local Storage at /var/lib/gitea/data/data/attachments

Gitea Version
1.20.3
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Prebuilt binary (https://dl.gitea.com/gitea/1.20.3/gitea-1.20.3-linux-amd64) on RHEL8.8 with systemd.
Service file based on https://github.com/go-gitea/gitea/blob/main/contrib/systemd/gitea.service
Database
None

Thanks for the quick response @CaiCandong
[attachment]
ENABLE = true
PATH = data/attachments
MAX_SIZE = 100
MAX_FILES = 5

Thanks. I can also see locally that there seems to be an extra /data here.

PATH = data/attachments. Thanks for posting your config, could you update the PATH to be an absolute path definition (/var/lib/gitea/data/attachments)?

PATH = data/attachments. Thanks for posting your config, could you update the PATH to be an absolute path definition (/var/lib/gitea/data/attachments)?

I think this is a bug if I don't set this field:

@techknowlogick  Changing to absolute path seems to fix the variable as seen in startup logs:
...les/storage/local.go:33:NewLocalStorage() [I] Creating new Local Storage at /var/lib/gitea/data/attachments

Older release files can now be downloaded, but newer releases fail (these seem to be stored in /var/lib/data/data):
An error occurred:

Open, open /var/lib/gitea/data/attachments/a/1/a1325050-c807-4c8c-8a8f-9ad6c18ab8c3: no such file or directory

You can move over manually first, which will allow your service to be available. I'm still locating the location of this bug. @mppha

fyi, all our releases are now available after setting the config to PATH = /var/lib/gitea/data/attachments and moving all newer releases manually from /var/lib/gitea/data/data/attachments to /var/lib/gitea/data/attachments

@mppha glad to hear.
I'll keep this open while @CaiCandong does additional investigation and creates a bugfix

I'll keep this open while @CaiCandong does additional investigation and creates a bugfix

I asked Lunny about this and he said that the path is relative to the AppDataPath, so maybe we should update the config docs and app.example.ini.

This change was caused by #26271. Although I do not understand the code about it now, it is clear that it does that to fix a bug. But it is breaking change.
For configuration as below:
[attachment]
ENABLE = true
PATH = data/attachments
MAX_SIZE = 100
MAX_FILES = 5

Before #26271， the resolved path  is ${AppWorkPath}/${attachments.PATH} (/var/lib/gitea/data/attachments)
After  #26271， the resolved path  is ${AppDataPath}/${attachments.PATH} (/var/lib/gitea/data/data/attachments)

I'll keep this open while @CaiCandong does additional investigation and creates a bugfix

I asked @lunny about this, and he said that the path is relative to the AppDataPath, so maybe we should update the config docs and app.example.ini The default configuration should be PATH=attachments (${AppDataPath}/${attachments.PATH} ) I haven't tested to see if in 1.19.0 whether the ${AppWorkPath}/${attachments.PATH}

Yes, this is a break change.


Unify JSX docs in a single file.

@mattdamon108 would you review the updated, unified docs?

Maybe it is too much though, how about adding some kind of troubleshooting or migration how-to section. e.g. the handwritten component as per v3 before.

Maybe it is too much though, how about adding some kind of troubleshooting or migration how-to section. e.g. the handwritten component as per v3 before?

Would you list situations not currently covered but which should be covered, each with an example?

Maybe it is too much though, how about adding some kind of troubleshooting or migration how-to section. e.g. the handwritten component as per v3 before?

Would you list situations not currently covered but which should be covered, each with an example?

Sure, during test with community, there are some expected cases. I’ll list up soon.


add rag deployment introduction

add rag deployment introduction

Please follow Conventional Commits standard to edit your commit message. The optional scope name should be rfcs. All our commits to RustSBI should be attached with Signed-off-by information to sign your ID name and e-mail. When editing commits, do not close this pull request; instead modify the commit to be merged and force-push into the original branch, then the files changed in this pull request will be automatically synchronized.


MSID: 87450 Version: 1 DOI: arXiv.2202.13658

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=87450)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/87450/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[ ] Public reviews available on sciety (https://sciety.org/articles/activity/10.48550/arXiv.2202.13658)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/87450/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/87450)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/87450

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/87450

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/87450/v1/87450-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/87450)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

We have a typeset version of this, but it looks like the authors subsequently provided an updated version (we have v2, the latest version is v3).
@JGilbert-eLife are you OK to reach out to Exeter and ask them to typeset a meca package for the v3?

I've asked Exeter for the v3 version.

I've replaced the package in the AWS with the new version from Exeter.

Thanks!

Stefan Klumpp has been assigned a corresponding author status - sorry, this is a mistake I made in the reloaded package -- the email that should have been applied to the last author went on the wrong Stefan! Should I reload it to the bucket?

No worries - I've fixed the author email issue. There were only 11 display equations so I 'fixed' those too (by capturing the labels in the image).
There's a ticket to cover adding equation labels in EPP. But I think for now, yeah it makes sense to ask Exeter to include them in the images they capture as well.


STF_COMMAND should be able to append extra STF perl options

the STF_COMMAND defined in the x.build/makefile should be able to append extra STF perl options.
For example, the -results-root can only be added when tests are executed from perl script. If a user want to define extra results-root dir, he have to use perl script to run the test. With the ability of appending extra perl script options, we can add extra options to test execution.
A proposal is changing
STF_COMMAND:=perl $(STF_ROOT)$(D)stf.core$(D)scripts$(D)stf.pl $(JAVA_ARGS_ARG) -test-root="$(STF_ROOT);$(OPENJDK_SYSTEMTEST_TARGET_ROOT)" -systemtest-prereqs="$(RESOLVED_PREREQS_ROOT)"
to
STF_COMMAND:=perl $(STF_ROOT)$(D)stf.core$(D)scripts$(D)stf.pl $(JAVA_ARGS_ARG) -test-root="$(STF_ROOT);$(OPENJDK_SYSTEMTEST_TARGET_ROOT)" -systemtest-prereqs="$(RESOLVED_PREREQS_ROOT)" $(EXTRA_STF_OPTION)

Hi @Mesbah-Alam  and @lumpfish  any opinion about this?

I prefer the approach of exposing stf command line arguments explicity rather than with a general STF_OPTIONS=xxx macro.
For results-root, we already have this issue: https://github.com/AdoptOpenJDK/openjdk-systemtest/issues/17
Is there another argument you need to set also?

Thanks for pointing me to the existing issue. The results-root is what we currently need.

The other issue with just allowing extra command line options to be added in the this way is that it is difficult to pass the options from the make command line to the actual command within the make target when the options contains quotes and whitespace.

Agree with Simon that whitespaces and quotes may be an issue if we want to add multiple extra command line options. Since most common options are available from make command line options, I will close this issue. If new options are needed, will open new issues to track them.


feat(doc): update doc

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Update README, add model convert from NetDef to ONNX
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @FogDong

Does this PR introduce a user-facing change?:

Update README, add model convert from NetDef to ONNX

/retest


Snowflake: support //-style single line comments

SnowflakeDB supports // as a single-line comment marker, in addition to the more standard --. Flyway's SnowflakeParser doesn't recognise it and therefore submits them to the database; Snowflake correctly sees them as comments but throws "incorrect statement count" errors.
Workround: use -- instead of //

A fix will be in 6.5.3


WIP: Add target for ARM integration tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.42%. Comparing base (0613ce6) to head (1179d8c).
Report is 5 commits behind head on main.

:exclamation:  There is a different number of reports uploaded between BASE (0613ce6) and HEAD (1179d8c). Click for more details.
HEAD has 3 uploads less than BASE

Flag
BASE (0613ce6)
HEAD (1179d8c)

oats-test
1
0

k8s-integration-test
1
0

integration-test
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1139       +/-   ##
===========================================
- Coverage   81.98%   52.42%   -29.57%
===========================================
  Files         141      141
  Lines       11588    11595        +7
===========================================
- Hits         9501     6079     -3422
- Misses       1561     5113     +3552
+ Partials      526      403      -123

Flag
Coverage Δ

integration-test
?

k8s-integration-test
?

oats-test
?

unittests
52.42% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bug] Config gets deleted on update

If the config file is created in ./node_modules, it will be deleted when you update via npm.
You could add a config option to mqpServer.start or make db + config paths relative to the file starting the server.

Is something we already have on our radar.

Yeah I know just wanted to add it here

On hold until #39 gets finished because we need to change how the config is stored / loaded.


for-loops changed to while-loops when appropiate user:igallegosagas<EMAIL_ADDRESS>

Hi @KevinGilmore  now the PR is "able to merge". I had to delete my repository and downloading the module again. Is there a more practical way to do it?
Ignacio

Hi @bluemontag - there are different ways to accomplish this, but generally it involves pulling changes from the upstream repository into your local repository, then resolving any conflicts, then committing and pushing.
This is especially important to do after one or more of your PRs has been merged and you are working on a new PR.
Since you are working directly on the master branch, it's a little easier than when working off of a different branch. So, given that you are working on master, it's as simple as:
git merge upstream/master
and then resolving the merge conflicts, if any.


Bug in compile/decompose functions in gaussian backend

Issue description
I called the Monte Carlo event probability function which has some issue with the decomposition functions for gaussian backend. I tried to solve the error by changing the tolerance level in the rectangular function in decompositions.py. This did not help and on printing the 'diffn'  in the rectangular function, values >1 were also seen. The error looks like this:
----> 7     fv = np.array(similarity.feature_vector_mc(nx.Graph(mol), events, 2, n_mean=8, samples=1000))
      8     t2 = time.time()
      9     fv = fv*(1/np.linalg.norm(fv))
~/Desktop/xanadu/strawberryfields/strawberryfields/apps/similarity.py in feature_vector_mc(graph, event_photon_numbers, max_count_per_mode, n_mean, samples, loss)
    551     return [
    552         prob_event_mc(graph, photons, max_count_per_mode, n_mean, samples, loss)
--> 553         for photons in event_photon_numbers
    554     ]
~/Desktop/xanadu/strawberryfields/strawberryfields/apps/similarity.py in <listcomp>(.0)
    551     return [
    552         prob_event_mc(graph, photons, max_count_per_mode, n_mean, samples, loss)
--> 553         for photons in event_photon_numbers
    554     ]
~/Desktop/xanadu/strawberryfields/strawberryfields/apps/similarity.py in prob_event_mc(graph, photon_number, max_count_per_mode, n_mean, samples, loss)
    451
    452     eng = sf.LocalEngine(backend="gaussian")
--> 453     result = eng.run(p)
    454
    455     prob = 0
~/Desktop/xanadu/strawberryfields/strawberryfields/engine.py in run(self, program, args, compile_options, run_options)
    388         eng_run_options = {key: temp_run_options[key] for key in temp_run_options.keys() & eng_run_keys}
    389
--> 390         result = super()._run(program, args=args, compile_options=compile_options, **eng_run_options)
    391
    392         modes = temp_run_options["modes"]
~/Desktop/xanadu/strawberryfields/strawberryfields/engine.py in _run(self, program, args, compile_options, **kwargs)
    275             target = self.backend.circuit_spec
    276             if target is not None and p.target != target:
--> 277                 p = p.compile(target, **compile_options)
    278             p.lock()
    279
~/Desktop/xanadu/strawberryfields/strawberryfields/program.py in compile(self, target, **kwargs)
    509                 )
    510
--> 511         seq = db.decompose(self.circuit)
    512
    513         if kwargs.get('warn_connected', True):
~/Desktop/xanadu/strawberryfields/strawberryfields/circuitspecs/circuit_specs.py in decompose(self, seq)
    264                     temp = cmd.op.decompose(cmd.reg, **kwargs)
    265                     # now compile the decomposition
--> 266                     temp = self.decompose(temp)
    267                     compiled.extend(temp)
    268                 except NotImplementedError as err:
~/Desktop/xanadu/strawberryfields/strawberryfields/circuitspecs/circuit_specs.py in decompose(self, seq)
    262                 try:
    263                     kwargs = self.decompositions[op_name]
--> 264                     temp = cmd.op.decompose(cmd.reg, **kwargs)
    265                     # now compile the decomposition
    266                     temp = self.decompose(temp)
~/Desktop/xanadu/strawberryfields/strawberryfields/ops.py in decompose(self, reg, **kwargs)
    418             list[Command]: decomposition as a list of operations acting on specific subsystems
    419         """
--> 420         return self._decompose(reg, **kwargs)
    421
    422     def _decompose(self, reg, **kwargs):
~/Desktop/xanadu/strawberryfields/strawberryfields/ops.py in _decompose(self, reg, **kwargs)
   1717         if not self.identity or not drop_identity:
   1718             decomp_fn = getattr(dec, mesh)
-> 1719             BS1, R, BS2 = decomp_fn(self.p[0], tol=tol)
   1720
   1721             for n, m, theta, phi, _ in BS1:
~/Desktop/xanadu/strawberryfields/strawberryfields/decompositions.py in rectangular(V, tol)
    322     diffn = np.linalg.norm(V @ V.conj().T - np.identity(nsize))
    323     if diffn >= tol:
--> 324         raise ValueError("The input matrix is not unitary")
    325
    326     tilist = []
ValueError: The input matrix is not unitary

Expected behavior: monte carlo feature vectors outputted

Actual behavior: ValueError seen

Reproduces how often: The error might or might not occur when I change the n_mean or the adj matrix.

System information:

Strawberry Fields: a Python library for continuous-variable quantum circuits.
Copyright 2018-2020 Xanadu Quantum Technologies Inc.

Python version:            3.5.6
Platform info:             Darwin-18.7.0-x86_64-i386-64bit
Installation path:         /Users/aroosa/Desktop/xanadu/strawberryfields/strawberryfields
Strawberry Fields version: 0.13.0-dev
Numpy version:             1.17.4
Scipy version:             1.3.3
SymPy version:             1.5.1
NetworkX version:          2.4
The Walrus version:        0.11.0
Blackbird version:         0.2.3
/opt/anaconda3/envs/graph/lib/python3.5/site-packages/tensorflow/python/framework/dtypes.py:458: FutureWarning:

Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.

/opt/anaconda3/envs/graph/lib/python3.5/site-packages/tensorflow/python/framework/dtypes.py:459: FutureWarning:

Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.

/opt/anaconda3/envs/graph/lib/python3.5/site-packages/tensorflow/python/framework/dtypes.py:460: FutureWarning:

Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.

/opt/anaconda3/envs/graph/lib/python3.5/site-packages/tensorflow/python/framework/dtypes.py:461: FutureWarning:

Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.

/opt/anaconda3/envs/graph/lib/python3.5/site-packages/tensorflow/python/framework/dtypes.py:462: FutureWarning:

Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.

/opt/anaconda3/envs/graph/lib/python3.5/site-packages/tensorflow/python/framework/dtypes.py:465: FutureWarning:

Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.

TensorFlow version:        1.3.0

Source code and tracebacks
My code snippet:
events = [2, 4, 6, 8, 10, 12]
fv = np.array(similarity.feature_vector_mc(nx.Graph(test), events, 2, n_mean=8, samples=1000))
where test is the adj matrix.
Additional information
I noticed that different functions have different tolerance levels.
Also, I don't think this error comes from Walrus.

Thanks @AroosaIjaz for reporting.

@trbromley, it looks like the apps layer might be generating a non-unitary interferometer?

Thank you, guys!


Damaged icons

Damaged icons are not like in Gnome but the application is still functioning, I run this at Fedora Kinoite

Hello.
That's strange, it looks like some of your icons are light, and some are dark.
Are you running it standalone, or as a flatpak? And have you changed your GTK icon theme?

Perhaps you have some icons cached, does gtk-update-icon-cache help?


While creating a query, a DOM node is immediately inserted

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
While creating a new query, a default DOM node is immediately inserted in the application. This results in fetches to the backend before the user had the chance to edit the query. This is wasteful. Instead, on query creation the query should stay in draft, detached from the dom until the user presses "save" the first time.
Blocked on https://github.com/mui/mui-toolpad/issues/1126
Context 🔦
Splitted off from https://github.com/mui/mui-toolpad/issues/1001 as being lower priority

Can You Assign Me This Issue?

@Ratikant-rout While this issue is blocked on #1126 currently, feel free to pick any other issue.
And it is great to see your interest in the project.


Fix rendering of request URI

Example to reproduce the problem:
import cats.effect.{IO, IOApp}
import org.http4s.implicits.http4sLiteralsSyntax
import org.http4s.netty.client.NettyClientBuilder
import org.http4s.{Method, Request}

object NettyClientIssue1 extends IOApp.Simple {

  override def run: IO[Unit] =
    NettyClientBuilder[IO]
      .resource
      .use(client =>
        client.expect[String](Request[IO](method = Method.GET, uri = uri"http://example.com/aaa"))
      )
      .void
}

http4s-netty-client 0.5.1 renders this request as
GET http:/aaa HTTP/1.1
Accept: text/*
Host: example.com

(notice the unexpected http:)
with this fix it will be rendered as
GET /aaa HTTP/1.1
Accept: text/*
Host: example.com

The solution is as in ember-client

Oh. Good catch. thanks


Add website: Rhys Wynne

I'd like to include my website in the RSS Blogroll Network crawler.
My RSS feed is located at: https://www.rhyswynne.co.uk/feed/
I have:

✅ Confirmed my site isn't currently listed in the network
✅ An OPML blogroll which is discoverable at either
✅ Using a <source:blogroll ...> element in my RSS feed
✅ Using a <link rel="blogroll" ...> HTML element on my home screen; and/or
[ ] At the /.well-known/recommendations.opml path
✅ My OPML blogroll recommends at least two other websites or blogs
✅ My site is personal, non-commercial, and ad-free
✅ My site only contains human generated content (no AI other than spelling/grammar checkers)
✅ My site doesn't contain pornography, hate speech, or violent images (curse words are OK).
✅ I'm not blocking the crawler with robots.txt

I'll follow up on this one. Most of the other blogrolls use the xmlUrl to point at another feed, but your using the htmlUrl to point at websites. This is valid and the crawler is processing the links, but they aren't showing up on the web page yet.

You can keep it as is. The htmlUrl is a valid way to build the OPML file, so I added support for that.
I just pushed a bunch more changes and now your page looks much better: https://alexsci.com/rss-blogroll-network/discover/feed-c2d8fce410dbc75ce21ee490648e1d70/
I'm only listing three of the sites in your blogroll as those are the only ones with RSS feeds. This project is sorta RSS-centric so I'm not listing the websites that don't (appear to) have web feeds. I may change that around later.
Ping me if anything looks off, I'm still very much in build mode for this project.


onDrag reports previous position

onDrag is called before updating the state. It therefore reports positions which correspond to the previous mouse event. I am trying to update the position of a sibling in the onDrag handler. This behavior causes the sibling to "lag" behind.
Even worse, since handleDragEnd resets the state before calling onStop, the last position is never reported. This could lead to persisting different a position than last displayed.
I could think of three possible solutions:

Set state before invoking onDrag. This would result in an extra render even if dragging is canceled. Not sure if this could have unwanted side effects.
Explicitly pass the new position to createUIEvent and make it fall back to state if non is passed.
Add a new event callback (onDragged?) to keep everything 100% backwards compatible. I can't help but feel that would be ugly, though.

I'd be happy to provide a PR.

This is fixed in v1.0.0, where we pass the event along from <DraggableCore> to the onDrag handler. This core event contains the correct data and is not out of date.


Add support for Xbox One Wireless Controller

Hi,
I have created and tested a patch to add a controller definition for the Xbox One Wireless Controller which is different to the Xbox 360 Wireless Controller.
xbox_one_controller_patch.txt
Please let me know if you need any further information.
Kind regards,
Jenson

Hey Jenson! Thanks for this, and apologies for not seeing it until now. I do not have an Xbox One controller to test with, but your config looks sensible. I will get it raised as a PR and merged.

This is now in the latest release. Thanks for the contribution!


[RFC] Add pre/post slice execution hook to SearchOperationListener for concurrent segment search to collect search metrics & stats

Is your feature request related to a problem? Please describe
The basic problem I am trying to solve here is that from within a search request (ie. everything that comes after ContextIndexSearcher#search), it’s very difficult to figure out which which search task the current thread is executing against. Because of this, it’s very difficult to collect statistics and metrics from within the thread execution for the search task.
At a very high level, in order to collect metrics and stats during a search request and relate it back to the currently executing search request, we need some way to reference the task id (or some other unique identifier for the request) while the query is running. Before concurrent segment search one such unique identifier could have been the thread id, however with concurrent segment search this invariant is no longer valid as the same request may be served by multiple threads and, vice-versa, the same thread may serve multiple search requests.
One example to illustrate how this is needed is the SearchSlowLog. Today this class collects all of its information from the SearchContext and for requests that take longer than a configurable amount of time T this information is printed to the slow log. However, this information is limited in its usefulness as the only stat reported is the overall duration of the request and there are no breakdowns related to how long different parts of the query took. While the query profiler can partially fill in the gap here, it’s not viable to run all queries through the query profiler due to the non-negligble overhead introduced by the additional collectors when profiling is enabled.
More concretely, when we look at searching against remote data (such as with searchable snapshots and writable warm), much of the search query time will be spent in downloading blocks from the remote repo yet there's no way to gather query level details about this from the Collector as these are implemented at the IndexInput level. For example, for debugging long running queries it would be critical to know the number of blocks being downloaded, the number of bytes being downloaded, and the file cache hits and misses, etc.
Furthermore, looking forward Lucene 10 is introducing a prefetch notion to the IndexInput interface and if want to measure performance gains from any potential prefetch implementations we will need to be able to collect this information per-query.
Describe the solution you'd like
The solution I am suggesting is to add to the existing SearchOperationListener, with a pre/post slice execution phase that will happen right before/after ContextIndexSearcher#Search. This will give the thread executions an easy way to keep a reference to the task ID it is currently working on.
Related component
Search:Performance
Describe alternatives you've considered
RunnableTaskExecutionListener
Today the TaskResourceTrackingService already tracks CPU/memory usage at the task level across threads. It does so by implementing the RunnableTaskExecutionListener interface which has a hook to run before and after each task of the type TaskAwareRunnable and this includes tasks in the concurrent search threadpool. One possible solution is to open up this RunnableTaskExecutionListener as a pluggable interface and this naturally gives all tasks that implement the corresponding runnable the ability to have pre- and post- execution actions.
Why did I not choose this?
The main issue with this approach is that a plugin implementation will typically not want to do the same resource tracking on every single thread pool. So for example if I want to track search related metrics, I would only want to do so on the search and index_searcher (and search_throttled) threadpools, however there’s no way to make that distinction in the existing interface.
As for the existing TaskResourceTrackingService, it does not run within any of the threads that it is tracking and therefore can only get surface level information like the memory allocated and cpu utilization, it would not be able to implement any metrics collectors within the threads.
TaskAwareRunnable
The existing TaskAwareRunnable that is used by the TaskResourceTrackingService actually does have a reference to the task id and it is used in the doRun method to initialize the task tracking. As is there’s no way to access the ThreadContext reference from within the original task execution that is wrapped by the TaskAwareRunnable, however one solution is to allow plugins to provide their own Runnable wrappers to take advantage of this ThreadContext.
Why did I not choose this?
Having multiple plugins provide multiple wrapping implementations will get very complicated very quickly and will likely get into a situation in which the order of wrapping becomes another problem that needs to be solved.
Additional context
No response

@sohami @reta curious to get your thoughts on this, thanks!

@jed326 Thanks for creating the proposal. I do see the slice level callbacks to be useful and the use cases makes sense. As you pointed out to capture per slice/search request level information about the blocks accessed or time take to download those vs FileCache hit/miss will be useful to understand the query latency. This may also bring in some opportunity to simplify how search profile related informations are captured in concurrent path.

Sorry for delay @jed326 , I also agree with @sohami that such callbacks could be useful since the SearchContext has reference to the search task (for corelation purposes). Thank you.


[FC UI] Mock FC API for integration testing

As a developer working on an FC API, I need to be able to test my UI changes against a mock API.
Eng:

this could be a set of cloud functions or a single server running on app engine

AC:

mock API exists with dummy responses for every endpoint in a FC cash-in flow
API should do auth checks but otherwise just return dummy successes for now
configuration for this mock vendor should be added to vendor configuration on alfajores (see #1979)
includes deployment

My vote here is for an app engine service; we'll be able to reuse the API skeleton that we generate, as well as the auth middlewares from #468. It's a lot also less of a headache (imo) than maintaining a new cloud function for each endpoint.

Another thought is that if, for testing purposes, we want to have multiple mock vendors to test out different UIs/flows, we could "hack" support for this into a single API, by having every path in the API prefaced by a mock provider identifier, e.g. awesome-fiat-connect-implementation.com/:providerName/quote/in, and set the base path for each provider in the vendor configs to e.g. awesome-fiat-connect-implementation.com/reallyGoodCICOProvider/. Implementation-wise, we could just have some lame dictionary lookup within the API mapping providerName to their response for each endpoint.

@satish-ravi what else is needed here? anything?

@cajubelt I guess from the AC, just the deployment PR is left. Was adding endpoints to change mocks in scope for this ticket?


Please make a portable version

📝 Provide a description of the new feature
What is the expected behavior of the proposed feature?  What is the scenario this would be used?
---Now PowerToys can only run after installing the installer. Could we have a portable version? A folder contains all the essential components would do the job. A single file executable would be the best. Thus we could throw it in OneDrive and keep the configuration consistent across multiple machines.
If you'd like to see this feature implemented, add a 👍 reaction to this post.

For modules like VideoConference you need to install the driver

Duplicate of https://github.com/microsoft/PowerToys/issues/598


Add alert rules to argo-controller based on the KF093 spec

These alert rules provide an overview of all service states.
Using the KubeflowServiceDown or KubeflowServiceIsNotStable filter, the user
can easily see the status of all Kubeflow services.
part-of: #1026

I think we are missing tests for this change. I believe the in the issue canonical/bundle-kubeflow#1026 we are talking about using this https://github.com/canonical/charmed-kubeflow-chisme/blob/b64f6ccca228d08c6533cbe83382306cd46670dc/src/charmed_kubeflow_chisme/testing/cos_integration.py#L413 for testing.

That's the recommended way. I created this and other PRs like this by script, so I did not check if charm implement the testing or not. That means that for some charms (like this one) we only update the alert rule and for some we add it. Do you think that we should include those test to all of them?

Can you also please provide minimal steps for reviewer to test it locally? What should I deploy and what should I check.

Something like deploy grafana-agent and check that alert rule is part of relation or deploy whole cos and check it in Grafana UI? WDYT?


provide input for examples

also add pow (^^) to the rpn calculator

https://github.com/D-Programming-Language/dlang.org/pull/1098 ?

Updated @CyberShadow

Too bad the "Run" button doesn't appear on the autotester, because it would involve a cross-origin request...

@CyberShadow I guess we can allow auto-tester URL for cross-origin?

I guess? Just keep in mind that anyone can create a PR...

Hmm, not sure if they can do any more harm than just using dpaste.dzfl.pl ?
Although you may be right


fix: don't error when existing symlink points at correct path

Summary
Update error handling in wrapnix package to succeed if intended symlinks already exist
How was it tested?
Manually testing.

confirmed this resolves the issue on macos and linux.


[FEAT]: Implement LLMLingua-2

What would you like to see?
Implement: https://github.com/microsoft/LLMLingua to reduce cost and increase speed, especially for pinned documents.

While I can see a use case for this in specific circumstances, having an LLM pre-summarize the full-text pinned document defeats the purpose of pinning. It also adds some overhead and technical issues that just don't fit for AnythingLLM and its intended use-case.
Adding an additional 25s+ latency for what essentially comes down to a black-box summarization of text pre-input to the actual LLM that can stream is going to be unacceptable for most. Given the only way this would save tokens is if we routed it through a local model - otherwise, we are using a cloud-based LLM to summarize ($) and then send that hopefully ok compressed response back to the same model ($+$).
Intuitively, this is really just what a vector database does, but likely more accurate at the expense of both speed & cost (if on cloud). Since all this process does is use an LLM to "trim the fat" from context, that is exactly what vector databases do, but faster (albeit at the price of accuracy sometimes). The only overt benefit is the KV-Cache not being large when using this method, but this benefit is insignificant in performance given the above tradeoff.
Lastly, this is in Python, which given the tradeoffs, is not worth the lift to transform into NodeJS code since we could probably get 100x more returns from just implementing knowledge-graphs, which can be built async and are non-blocking.
This is being done on another branch right now and has great returns for very little costs.
There are about 1,000+ ways to improve RAG, only very few of which can be applied to a general use case, and in the interest of keeping AnythingLLM useable and understandable to a person who is not deep into this space, but requires this kind of experience - we can only add so many "RAG improvements".
I think this does open a conversation for a "plugin" style arch for allowing this kind of custom implementation of tooling without anyone having to code it except the user who explicitly requires it.


Powershell/csx support?

Hey there,
Are there any plans to support PowerShell Core for Linux?
Also, I know this is a long shot, but how about dotnet-script (.csx files)? Unfortunately, I have been asking Jetbrains for support in Rider for it for years, but no movement.
Vscode supports it, but... then I would have to use VSCode, which is nearly not worth it.
Thanks,
-MH

I utilize OmniSharp, so csx files should work.
https://github.com/OmniSharp/omnisharp-roslyn/wiki/Configuration-Options
You have to create a omnisharp.json file and place it in your workspace and add following lines (with your custom settings).
{   "script": {      "enabled": true,      "defaultTargetFramework": "net60",      "enableScriptNuGetReferences": false   } }
powershell core is a seperate issue I have to look into.

I published v.1.1.0 with css support.
Make sure you restart Lapce after install.

I added a omnisharp.json file to the workspace with:
{
  "script": {
    "enabled": true,
    "enableScriptNuGetReferences": true,
    "defaultTargetFramework": "net6.0"
  }
}

surely you can use a different TargetFramework.

This is great news, thank you for this!

I don't know if it's only on my machine, but I receive random Omnisharp crashes when working with .csx
https://github.com/OmniSharp/omnisharp-roslyn/issues/2500
Maybe you can try it out maybe even add some logs to the ticket

Sure thing. I have a few meetings this morning but will see if I can fit in a few minutes to at least give it a try. Then this afternoon, I can definitely give it a thorough go. :+1:

This is a repo I often reference, as it covers many use-cases, just in case it is useful in narrowing down/pinpointing an issue.  https://github.com/cesarrrguez/CSharpScripts
I also make use of .rsp files and .slnf in one of my projects, which acts as a dotnet-based version of the now deprecated "jobber", or "ofelia" applications. I will see if I have any issues with this project, as it pretty much makes use of all possible .csx features.

I can confirm csx has some highlighting issues. Maybe open an issue at
https://github.com/lapce/lapce/issues

@MostHated I opened a issue at razzmatazz/csharp-language-server/issues/81


DE0 board ignores colour settings.

DE0 board ignores colour settings. Will fix in the near future.

Fixed.


feat: update eth_getUserOperationByHash response for pending status

Pull Request Checklist

[x] Did you add new tests and confirm existing tests pass? (yarn test)
[x] Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
[x] Do your commits follow the Conventional Commits standard?
[x] Does your PR title also follow the Conventional Commits standard?
[x] If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
[x] Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
[x] Did you follow the contribution guidelines?

PR-Codex overview
This PR focuses on updating the UserOperationReceipt interface in the types.ts file.
Detailed summary

Updated blockNumber property to accept null if the user operation is pending.
Updated blockHash property to accept null if the user operation is pending.
Updated transactionHash property to accept null if the user operation is pending.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Per: https://github.com/eth-infinitism/account-abstraction/pull/382/files

should we update the doc for eth_getUserOperationByHash as well?

should we update the doc for eth_getUserOperationByHash as well?
@denniswon there's no doc that goes to this level of granularity on the type (see the method doc).

Ava/Sahil are working getting types in and I'll let them know accordingly.

is this pr good to merge ? @avasisht23 @moldy530

unsure if this is necessary anymore, closing


Feature Request: progress bar

I'm using Harlequin to execute OLAP-style queries that can run for seconds or minutes.
If I was able to report this information back from a driver, would you consider accepting a PR that displayed this progress?

Are there any RDBMS that provide a progress bar? I know you could update the bar if you fetch records in batches but for OLAP dabs that shouldn't be the majority of the execution time?
But if so, then yes. There is actually a Textual progress bar widget that would work fine. It would probably fit in the "Run Query Bar" between the editor and results pane.

I know FlightSQL does provide a query progress field, but I don't know if it's exposed through ADBC. Not sure on any others, but Spark, Trino, etc all expose progress in some form.


Routing between 2 containers

Question
How can I realize traffic routing within a pod where I have 2 containers configured to work with NSM?
In partciular I should realize routing between one container leveraging cmd-nse-icmp-responder and the other cmd-nsc
Examples
In my case I have 3 pods for simplicity:
POD1 (NSC)
POD2 (the pod with the 2 containers mentioned above)
POD3 (NSE where I have the service requested by the client)
The situation with the interfaces is as follows:
POD1(<IP_ADDRESS>) === POD2[(<IP_ADDRESS>) (<IP_ADDRESS>)] === POD3 (<IP_ADDRESS>).
In short what I would like is that from POD1 I can reach POD3 via POD2.
For example using this command, the ping fails:
kubectl exec pods/alpine -n ns-nse-composition -- ping -c 4 <IP_ADDRESS>
Here there are the files that i'm using
nse-kernel-composition.zip
Here there are the routes that i tried to use.
iptables -t nat -A PREROUTING -i $INTERFACE -j DNAT --to 172.16.1.
iptables -t nat -A POSTROUTING -o kernelint2 -j SNAT --to <IP_ADDRESS>
Here there are the logs of the pods
all_logs.txt

If you apply the iptables rules above, when you ping -c 4 <IP_ADDRESS> you actually ping <IP_ADDRESS>
Is this not enough for your purpose?

Yes, and it works. I was wondering if it was possible to directly ping <IP_ADDRESS> and let the traffic go through the other pod in the middle. Something similar to the original example of nse-composition, where the NSC pings directly the NSE, passing through the other pods, but since in that case there are the vpp-forwarder and memif mechanisms i think this one is the best option. Do you agree @glazychev-art ?
Do you have any plans to also develop a kernel forwarder?

@isZams
I'm not sure, but probably you might be interested in:
https://github.com/kubeslice/cmd-forwarder-kernel/tree/master

It will not be instead of a forwarder-vpp. You need to look at the general approach and use it in your passthrough pod.
But I'm not familiar with this project, so I'm not sure if this will work for you.

Ok, thanks again @glazychev-art.!


Time Slider: Add UWP implementation

Adds the TimeSlider control on UWP

might want to consider getting rid of the data string converter, and just use function x-binding instead

@dotMorten looks like that's not possible in a control template.  Build fails with the following:

I wasn't able to find an effective workaround.  Let me know if you know of any tricks to get this working and I'll update it.


Coverage missing for QThreads

New Issue to separate the discussion on #582.
Here is a gist file for the test:
https://gist.github.com/hhslepicka/3153c9c2ac27dee4398754dce6a11fea
Environment:

macOS High Sierra - 10.13.5
Tested with Python 2.7 and 3.6 (Anaconda)
Coverage: 4.5.1 with C extension

Dependencies:

Python 2.7 or 3.6 (I tested with both)
PyQt5 & Qt5... any version...

Some useful information:
(py36) slepicka@public-81-101:~/sandbox/covtest  $ coverage --version
Coverage.py, version 4.5.1 with C extension
Documentation at https://coverage.readthedocs.io

(py36) slepicka@dhcp-swlan-public-81-101:~/sandbox/covtest  $ coverage run test.py
Counter:  56

(py36) slepicka@dhcp-swlan-public-81-101:~/sandbox/covtest  $ coverage report -m
Name      Stmts   Miss  Cover   Missing
---------------------------------------
test.py      24      4    83%   13-15, 18

Documentation for QThread in case it is useful: http://doc.qt.io/qt-5/qthread.html
Just let me know if you need additional info from my system.

From @nedbat's post in another thread.
Asked on the PyQt list: Any way to run code before each QThread?.
From there: an example of monkey-patching QThread to add debugging support: http://die-offenbachs.homelinux.org:48888/hg/eric/file/87b1626eb49b/DebugClients/Python/ThreadExtension.py#l361

Even when explicitly registering sys.settrace, it doesn't work. Am I missing something?
https://gist.github.com/enkore/14c53e9af79e9bbaf66478115605633f

I'd like to say, I tried sys.settrace(threading._trace_hook) and it seems to work fine... coverage is reported on all threads.    Maybe all coveragepy needs is to enshrine this by adding a :  coverage.thread_start() function.   Then users of exotic threading system can just call that function.

I solved this by writing a custom decorator to decorate your own methods with that are afflicted by this problem. Disclaimer: I am a Python enthusiast and not an expert, but it seems to work all right for me.
Paste this code to the top of your module:
# Code coverage tools 'coverage' and 'pytest-cov' don't seem to correctly trace
# code which is inside methods called from within QThreads, see
# https://github.com/nedbat/coveragepy/issues/686
# To mitigate this problem, I use a custom decorator '@coverage_resolve_trace'
# to be hung onto those method definitions. This will prepend the decorated
# method code with 'sys.settrace(threading._trace_hook)' when a code
# coverage test is detected. When no coverage test is detected, it will just
# pass the original method untouched.

running_coverage = 'coverage' in sys.modules
if running_coverage: print("\nCode coverage test detected\n")
import threading
from functools import wraps
def coverage_resolve_trace(fn):
    @wraps(fn)
    def wrapped(*args, **kwargs):
        if running_coverage: sys.settrace(threading._trace_hook)
        fn(*args, **kwargs)
    return wrapped

I hope my solution is of use to others, too.

I have developed such pytest fixture:
@pytest.fixture()
def _dangling_qthreads(monkeypatch, qtbot, request):
    from qtpy.QtCore import QThread

    base_constructor = QThread.__init__

    def run_with_trace(self):  # pragma: no cover
        """
        QThread.run but adding execution to sys.settrace when measuring coverage.

        See https://github.com/nedbat/coveragepy/issues/686#issuecomment-634932753
        and `init_with_trace`. When running QThreads during testing, we monkeypatch
        the QThread constructor and run methods with traceable equivalents.
        """
        if 'coverage' in sys.modules:
            # https://github.com/nedbat/coveragepy/issues/686#issuecomment-634932753
            sys.settrace(threading._trace_hook)
        self._base_run()

    def init_with_trace(self, *args, **kwargs):
        """Constructor for QThread adding tracing for coverage measurements.

        Functions running in QThreads don't get measured by coverage.py, see
        https://github.com/nedbat/coveragepy/issues/686. Therefore, we will
        monkeypatch the constructor to add to the thread to `sys.settrace` when
        we call `run` and `coverage` is in `sys.modules`.
        """
        base_constructor(self, *args, **kwargs)
        self._base_run = self.run
        self.run = partial(run_with_trace, self)

    monkeypatch.setattr(QThread, '__init__', init_with_trace)

It monkeypatch run function to init coverage.

Based on previous fixture, I did it for QThreadPool
@fixture(autouse=True)
def cover_qthreadpool(monkeypatch, qtbot):
  from PySide6.QtCore import QThreadPool

  base_constructor = QThreadPool.globalInstance().start

  def run_with_trace(self):  # pragma: no cover
      """
      QThread.run but adding execution to sys.settrace when measuring coverage.

      See https://github.com/nedbat/coveragepy/issues/686#issuecomment-634932753
      and `init_with_trace`. When running QThreads during testing, we monkeypatch
      the QThread constructor and run methods with traceable equivalents.
      """
      if "coverage" in sys.modules:
          # https://github.com/nedbat/coveragepy/issues/686#issuecomment-634932753
          sys.settrace(threading._trace_hook)
      self._base_run()

  def _start(worker, *args, **kwargs):
      """Constructor for QThread adding tracing for coverage measurements.

      Functions running in QThreads don't get measured by coverage.py, see
      https://github.com/nedbat/coveragepy/issues/686. Therefore, we will
      monkeypatch the constructor to add to the thread to `sys.settrace` when
      we call `run` and `coverage` is in `sys.modules`.
      """
      worker._base_run = worker.run
      worker.run = partial(run_with_trace, worker)
      return base_constructor(worker, *args, **kwargs)

  monkeypatch.setattr(QThreadPool.globalInstance(), "start", _start)


error with dependencies // jsdevtools

Hi all,
I've got a system up an running using Vue.js 3.0.5 and Vite as a build system.
As I need to use a Swagger API in my project I thought it might be a good deal using this openapi-client-axios.
Actually I get an error as soon as I import the client:
import OpenAPIClientAxios from 'openapi-client-axios'
const api = new OpenAPIClientAxios({ definition: 'api.json' })
api.init()

These lines occur the error message:
[vite] new dependencies found: openapi-client-axios, updating...
 ><EMAIL_ADDRESS>error: No matching export for import "inspect"
    1 │ import { inspect } from "util";
      ╵          ~~~~~~~

[vite] error while updating dependencies:
Error: Build failed with 1 error:
node_modules/@jsdevtools/ono/esm/types.js:1:9: error: No matching export for import "inspect"

Is it possible that some of the dependencies or this entire project are not ready for Vue 3 or what am I doing wrong?
Thanks a lot.

Looks like you are missing a polyfill for the node.js util core package.
Try npm install --save util

Thanks so much for the response 👍
It seams this fixes the error explained above.
I don't know why my node (15.8.0) didn't have this module.
One step further. Now it ends in the browser console:
Uncaught ReferenceError: process is not defined
    at util.js:109

Do you have a good solution for this problem as well?

Sorry, haven't dug that deep into vue but for whatever reason it seems like util is not being included by vue. Installing the util package doesn't work because process is not defined in the browser.
You might be able to work around that error by manually setting window.process = { env: {} };, but it's a hack.
I'd look into your vue bundler config to see if there is a way to properly include the util in your browser bundle.
I'd highly appreciate you report back your findings for other Vue users!

Thanks for trying to help. Your mentioned hack with manually setting does not work either.
I'm pretty new to Vite so I have a hard time understanding what's going on there. I will post a solution when I come up with one :)
As soon as I remove the import of openapi-client-axios my project continues working.
For me openapi-client-axios does not work with Vue+Vite at the moment, I guess because of dependencies to other projects like util.

Similar issue with Vue3 + Quasar2, after installing utils package, the following issues remain outstanding:
App •  ERROR  •  UI  in<EMAIL_ADDRESS>
Module not found: Can't resolve imported dependency "http"
Did you forget to install it? You can run: npm install --save http

 App •  ERROR  •  UI  in<EMAIL_ADDRESS>
Module not found: Can't resolve imported dependency "https"
Did you forget to install it? You can run: npm install --save https

Installing those two packages does not work.

You’ll need to provide polyfills for these native nodejs dependencies in your bundler.
See https://cli.vuejs.org/guide/browser-compatibility.html#polyfills for more details

You’ll need to expand your webpack config and add fallbacks for the missing node dependencies.
https://cli.vuejs.org/guide/webpack.html#simple-configuration
Also see https://stackoverflow.com/questions/64557638/how-to-polyfill-node-core-modules-in-webpack-5
Hope this gets you on the right track! 😊

You’ll need to expand your webpack config and add fallbacks for the missing node dependencies.
https://cli.vuejs.org/guide/webpack.html#simple-configuration
Also see https://stackoverflow.com/questions/64557638/how-to-polyfill-node-core-modules-in-webpack-5
Hope this gets you on the right track! 😊

Well, thanks, but it actually did not help. After spending 3 hours trying to work it out, I gave up... There does not seem to be a straightforward way for Vue.js developers to use openapi-client-axios.

Yeah, looks like Vite doesn't love "node.js" modules, so, I found one dirty solution:

Add into vite.config.ts an define

export default defineConfig({
  define: {
    'process.browser': 'true',
  },
})

Put into your index.html one fake-polyfill for Buffer (before main script src section)

    <script>
      Buffer = {isBuffer: () => {return false} }
    </script>

Then install one required module npm install url

And at last make some magic

import axios from 'axios';

import OpenAPIClientAxios from 'openapi-client-axios';
import { Client as PetStoreClient } from './types';

async function getClient() {
    // (!) Download scheme by yourself or read from file
    // because when you pass in OACA an url,
    // it make some calls using fns from node native `http` and `https` libs
    const definition = (await axios.get('http://<IP_ADDRESS>:3000/docs/json')).data

    // Pass it into OACA
    const api = new OpenAPIClientAxios({
        withServer: {url:'http://<IP_ADDRESS>:3000'},
        definition: definition
    });

    // Voila!
    const client = await api.init<PetStoreClient>();
    const result = await client.createDog(undefined, {name:'test'})
    console.log('result', result.data)
}

@anttiviljami, also I think that we can help someone with this, if will be building ESM or .min version, where all node-core-pollyfills will be already included.
(I can't found for Vite any adequate node-core polyfill plugin too)

Same issue, solved by adding this into vue.config.js :
const NodePolyfillPlugin = require( 'node-polyfill-webpack-plugin' );

module.exports = {
  configureWebpack: {
    plugins: [
      new NodePolyfillPlugin(),
    ],
  },
};

This issue should be fixed with<EMAIL_ADDRESS>


Add some request parameters to json response

Hi
I think that adding 3 parameters to the json response for "Consumer Topic Detail" query will be great.
The parameters are the following

Cluster name
Consumer group
topic name

The params are already exists in the server url, and this will be great if they will be printed in the response.
Thanks
D.

Something like this sounds like a good idea to have for all responses. At the very least, we can include the request URL which encodes all the information. I will try to work on this soon, if someone else doesn't submit a PR first. As long as we're just adding things to the JSON response, it's not a major API change.

Thanks @toddpalino!

Hi @toddpalino any progress on that?

+1

Fixed now in trunk


Create resource error by following the swagger and examples

When I try to create privateCloulds by using the example https://github.com/Azure/azure-rest-api-specs/blob/master/specification/vmwarevirtustream/resource-manager/Microsoft.VMwareVirtustream/preview/2019-08-09-preview/examples/PrivateClouds_CreateOrUpdate.json, I get the 400 bad request with error message:
{
    "error": {
        "code": "DisallowedResourceOperation",
        "message": "The operation 'write' on resource type 'privateClouds' is disallowed."
    }
}

The request I used is:
curl --location --request PUT 'https://management.azure.com/subscriptions/7fd08dcc-a653-4b0f-8f8c-4dac889fdda4/resourceGroups/weidongtest/providers/Microsoft.VMwareVirtustream/privateClouds/dwtest?api-version=2019-08-09-preview' \
--header 'Content-Type: application/json; charset=utf-8' \
--data-raw ' {
  "location": "eastus2",
  "properties": {
    "cluster": {
      "clusterSize": 4
    }
  },
  "tags": {}
}'

You need to be using the Microsoft.AVS namespace. I recommend installing the az vmware cli extension and then calling az vmware private-cloud create with --debug to see how to use the REST API.

Hi @ctaggart Cloud you please update the swagger? I think the namespace of swagger is still Microsoft.VMwareVirtustream.
Thank you

Make sure you are using:
specification\vmware\resource-manager\Microsoft.AVS\preview\2019-08-09-preview\vmware.json
instead of:
specification\vmwarevirtustream\resource-manager\Microsoft.VMwareVirtustream\preview\2019-08-09-preview\vmwarevirtustream.json
Yes, networkBlock is required and it is not reflected in this public preview API version. It is something I'm looking to address for the GA API version. The problem is we are reusing the same definition for the PATCH body and "Properties of a PATCH request body must not be required.".


自动建表时如何设置分区选项？

Your Question

The document you expected this should be explained

Expected answer

use gorm:table_options, refer README.

well done!


created index.html

created base html file for the index page no css or js has been linked

This is approved yahoo!


disableMetrics in client initializer does nothing

Describe the bug
public class UnleashClientBase {
…
    public init(unleashUrl: String, clientKey: String, refreshInterval: Int = 15, metricsInterval: Int = 30, disableMetrics: Bool = false, appName: String = "unleash-swift-client", environment: String? = nil, poller: Poller? = nil, metrics: Metrics? = nil) {

There is a parameter to disable metrics, but that does nothing.
Steps to reproduce the bug
No response
Expected behavior
No response
Logs, error output, etc.
No response
Screenshots
No response
Additional context
No response
Unleash version
0.0.10
Subscription type
None
Hosting type
Self-hosted
SDK information (language and version)
No response

@octover Fixing in the next PR soon

Should be fixed now

Sweet, thanks.


Specify proof format and verification algorithm

I was curious about how to validate proofs exported from merk.js and reading the code, I wasn't entirely sure.  For the purpose of this issue, I just care about existence proofs for exactly one value (it seems you return general range proofs by default, maybe simpler to focus on one case).
The code seems to be this: https://github.com/nomic-io/merk/blob/master/src/verify.js#L15-L47
This is my understanding:
A child node contains {key, value} (both strings)
An inner node contains {left, right, kvHash}

left and right are either null?, a reference to another node (recurse), or the hash of that subset of the tree.
kvHash is ??? (data stored in inner node also?)

In the case of serialized proofs, I would assume for every inner node, either left or right is a base64 hash of the subtree, and the other one is a reference to the child node leading to the leaf of interest.
So far, so good. The hash for a leaf node also seems quite simple:
function getKvHash ({ key, value }) {
  let input = Buffer.concat([
    VarString.encode(key),
    VarString.encode(value)
  ])
  return ripemd160(sha256(input))
}

varint length prefix the key and the value, concatenate, then hash. Solid.
But... looking at:
function childHash (child) {
  if (child == null) {
    return nullHash
  }
  if (typeof child === 'string') {
    return Buffer.from(child, 'base64')
  }
  if (typeof child === 'object') {
    return getHash(child)
  }
  throw Error('Invalid child node value')
}

function getHash (node) {
  let kvHash = node.kvHash
    ? Buffer.from(node.kvHash, 'base64')
    : getKvHash(node)

  let input = Buffer.concat([
    childHash(node.left),
    childHash(node.right),
    kvHash
  ])
  return ripemd160(sha256(input))
}

It seems that the hash of a child node is not just getKvHash, but getHash. Given left and right are both null for the child node. This ends up like:
kvhash = ripemd160(sha256(key.length || key || value.length || value))
Then one step that treats it like an inner node
childHash = ripemd160(sha256([0, 0, ... (40 bytes 0)]  || kvhash))
The inner node would be:
innerHash = ripemd160(sha256(child.left || child.right || inner.kvhash))
And then what is inner.kvhash?
I'd love to understand this algorithm well, and be able to validate it in another language (eg. go) as a step towards unifying merkle proofs on the road to ibc

One thing you might be missing is that all nodes have a key and a value, including inner nodes (unlike the golang IAVL tree). This is why we need a separate kvHash for each node, otherwise merkle branches would require key/value data for unrelated nodes in the branch.
So unlike many other tree implementations, inner nodes and leaf nodes have the same format, the only difference is that left and right will be either null or undefined.

Okay, that is interesting. And enlightening.
So, for inner nodes, we are guaranteed left and right to be defined.
For child nodes, we are guaranteed left and right to be null or undefined.
Correct?
And we should have {key, value} or kvHash for all (only leaf to be proven must be in {key, value} format)?

So, for inner nodes, we are guaranteed left and right to be defined.
It is also possible to have one be undefined, at the edges of the tree.

For child nodes, we are guaranteed left and right to be null or undefined.
And we should have {key, value} or kvHash for all (only leaf to be proven must be in {key, value} format)?
That's correct.

Okay, I made a sample tree
    state.foo = 'bar';
    state.food = 'yummy';
    state.bath = {tub: 'full', room: 'small'};
    state.baz = { x: 123, y: { z: 456 } };

And got this:
root: a5a3a7255ef65deea2ba17b22b3b5b1521628a22
query baz.y:
{ left: 'F4j9DF3/N4rBqoX4JYyW9AdvDAo=',
  right:
   { left: null, right: null, key: '.baz.y', value: '{"z":456}' },
  key: '.baz',
  value: '{"x":123}' }

query food:
{ left:
   { left:
      { left: null,
        right: null,
        key: '.',
        value: '{"foo":"bar","food":"yummy"}' },
     right: null,
     key: '.bath',
     value: '{"room":"small","tub":"full"}' },
  right: 'Z7Rs82itYwVwev3PUp0KFDpX9hc=',
  kvHash: '2RiU70Z1dYW4CHRnRkzZ2YlqJDI=' }

FYI, I made a repo https://github.com/confio/proofs-merk to try to parse these out.
I would like to figure out how to extend a generic proof format to hold this info: https://github.com/confio/proofs in particular https://github.com/confio/proofs/issues/5
Any collaboration and feedback is more than welcome

It's not an exact spec, but I outlined the new proof format and verification algorithm in this document: https://github.com/nomic-io/merk/blob/develop/docs/algorithms.md

Thanks, that is quite a nice document of the proof format and verification/generation algorithm.
The examples were very useful to understand the use of Parent and Child

Closing this since that document exists, can open specific issues in the future around any proof format questions.


Intent to Play Back Recordings

The intent to play back an audio recording isn't handled because CommonPlay captures it first. This skill should be converted to a CommonPlay skill with a search method that finds the appropriate audio recording

This skill should be replaced with https://github.com/NeonGeckoCom/skill-audio-recording

Skill is replaced; if issue persists in audio-recording skill then a new issue should be opened there


High Urgency: Certificates are lost after an update via AppStorr

Upon releasing an app update via the Apple Store, the Certificates that were saved on the device prior to the update are lost.
Multiple reports have been given from the AppStore review and on Twitter.
Please treat this as urgent.
Best Regards
Panayiotis Savva
Cyprus.

I will close the issue as we know this originates from a missing old fix (storage)

Perfect! I am glad that the problem could be solved.
We were also not able to reproduce the issue.


edit readme

Pull Request #1 as specified in Checkpoint-35

Hey @dpg5000, this the base repo for Bloc, not your own created repo. I know that the language was a little vague before in the Intro to Projects checkpoint, so I've since updated it to give more clarity to the process. Would you mind re-submitting to your copy using the updated instructions? Thanks!

Absolutely!  Sorry for any inconvenience!

No problem! Have a great week!


Next 14 support

Due to https://github.com/gladly-team/next-firebase-auth/blob/2c8f771e7ca286063b1b0afea9b8796832550728/package.json#L114, it's currently not possible to use next-firebase-auth with Next 14.
When looking at the breaking changes for Next 14, I don't see anything that should prevent next-firebase-auth to work, so would it be possible to allow upgrades to Next 14?

Releasing a version with this shortly. Thanks for the issue!


[Bug] [Task Definition] cannot change  Environment Name when create or edit task

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
It's not work when I create or change the task Environment Name, and Environment Name always use the first Environment of the Worker Group.
What you expected to happen
Environment Name should be changed so that I can use different Environment Name from the same Worker group.
How to reproduce
It's simple to reproduce this issue
1. into the `Security -> Environment Manage`, create multiple `Environment Name` that all belongs to one worker group.
2. into the `Project -> Task -> Task Definition`, change the `Environment Name` by create or edit task;
3. save and review the task，and will find it's not work;

Anything else
How often does this problem occur?

every time

The following instructions may be useful
Our dolphincheduler instance use MySQL database, and found the sql update with wrong contition:
# 1
select
  id, code...
  from t_ds_task_definition
  WHERE code = ...
  and version = ..

# 2
insert into t_ds_task_definition_log ...

# 3
  UPDATE t_ds_task_definition  SET code=...
...
WHERE id=?

we cann't find the id value from the table t_ds_task_definition, but found in table t_ds_task_definition_log.
Version
3.1.x
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

We use the standalone mode(v3.1.0).  and found t_ds_task_definition  update correctly, but display in the web always wrong.

I use the standalone mode(v3.1.0) too.

I can't reproduce too ,@arstercz can you provide more infomation to help reproducing this issue ?

which milestone will it be fixed? it seems it's a UI bug, when UI dialog show, it should display the corrent env-name last edited. 3q

这个BUG随手就可以改掉的，为何要一推再推呢？！

这个BUG随手就可以改掉的，为何要一推再推呢？！

This issue will be fixed after pr #13148 is completed


Link in "Publish to Azure" section points to "error 404 - Content Not Found" page

[Enter feedback here]
In the "Publish to Azure" section in "Part 10, examine the Details and Delete methods of an ASP.NET Core app"
https://docs.microsoft.com/en-us/aspnet/core/tutorials/first-mvc-app/details?view=aspnetcore-3.1
Quoted:
"For information on deploying to Azure, see Tutorial: Build a .NET Core and SQL Database web app in Azure App Service."
When I click on the tutorial link, it points to this link, which returns error 404.
https://docs.microsoft.com/en-us/azure/app-service/app-service-web-tutorial-dotnetcore-sqldb
I believe this should be the right link:
https://docs.microsoft.com/en-us/azure/app-service/tutorial-dotnetcore-sqldb-app?pivots=platform-linux

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 97234f18-4009-0ebf-a379-9b63125529cd
Version Independent ID: 1bf4792d-dab4-e03d-2021-3dcdcaff6a0f
Content: Part 10, examine the Details and Delete methods of an ASP.NET Core app
Content Source: aspnetcore/tutorials/first-mvc-app/details.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@serpent5  let me know if you'd like to fix this one.


Add assessmentMode to the VM Model

All SDK Contribution checklist:
Corresponding swagger PR
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

/check-enforcer override

@nisha-bhatia @allenjzhang - I have not been able to get check-enforcer to complete. It appears to get stuck in the "In progress" state. Can you please take a look at its results?

/azp run net - mgmt - ci

@nisha-bhatia - Your actions did not fix the check-enforcer issue. Are there other things to try?

/check-enforcer evaluate

/azp run net - mgmt - ci

@mirichmo, we generally don't review PR going into a feature branch which is generally for dev/team staging purposes. Thus the lack of pipeline support. Once your work is ready to release and merging back into master, we will do proper reviews.
In the meantime, if you want to preemptively see if your staged code works or not on CI, please open a PR merging to master, BUT:

Open as Draft
Place a Do Not Merge label or in the title to signal to us no need to review.

/azp run net - compute - ci

Abandoning because it must target a new branch


Add nemlayek's file

created a branch, created a file and made a commit, and opened a pull request

Good to go


React to HttpAbstractions namespace changes

aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
clean up usings

Hi @dougbu, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

/cc @davidfowl @Tratcher

:shipit:

16a0482


Preferences cleanup

As seen in #22, the way preferences are handled is a bit confusing and disjointed. This change puts all of the preference getters in a separate Prefs class, which has several benefits:

Removes members of MainActivity that were storing some of the preferences, along with the code to bundle and unbundle them.
Puts all of the preferences in a single place where they can easily be seen.
Removes code duplication where some preferences were gotten in multiple places. If these default was to be changed the getters would have had to have been altered in multiple places; with this change only the one place in the Prefs class needs to be altered.

I'm submitting this as a PR separate from the fix for #22 as I haven't implemented that yet and I wanted to avoid merge conflicts later on.

Right after I submitted this PR I noticed the fdw/Goodtime@refactor branch, which doesn't separate out the Prefs class but also has some good ideas, and which will have a massive merge conflict if this is merged. @fdw, would you care to chime in on the discussion about cleaning up the preferences? Perhaps I should close this PR and open another issue?

Thanks for noticing my refactoring, and asking before I'm sitting on a massive merge conflict :)
I quite like the idea of a separate Preferences class, so that the default values are encapsulated there. This is definitely helpful. (Although I'd rather call it Preferences instead of Prefs.)
Regarding a good merging strategy: I think I'm quite done refactoring, so how about I start a pull request, and you can then rebase your changes on that? I think this would be easier than the other way around. Would that work for you?

@fdw Sure, sounds good to me! I'll star work on that in a little bit.

Thanks :)
You might want to take a look at PreferenceKeys, this should probably be merged into your Prefs. And maybe the migrateSettings() from MainActivity too?

OK, I just rebased all my changes on top of #29. Since this PR is based on that one, it's probably a good idea to merge #29 first, and then this one.
Of particular note: I took @fdw's advice and renamed PreferenceKeys into Preferences before merging all of the getters in, and also moved migratePreferencesIfNeeded() into the Preferences class.

Hi and thanks for the great contribution! :+1: I'll merge as soon as I get home because I'm traveling at the moment.

Hey, I updated the contributors page.
Please give thumbs up or down.
Maybe for some reason you want it spelled differently or don't want it mentioned at all :)
Commit: https://github.com/adrcotfas/Goodtime/commit/d5036f1da8443e205246a3d9ec27c4e3339175a9