Enhanced user experience Closes #21

Now the grid of messages is more clear (can be even more when messages get color depending on who sent it) because of the callout rectangle
Added rounded borders

Closes #21


find_or_create_by(!) should run in a transaction

Right?

I don't think so? It calls create, which has its work done in a transaction.

Are you thinking of find_or_create perhaps and not find_or_create_by?  find_or_create_by and find_or_create_by! both do a find and then a create:
https://github.com/neo4jrb/neo4j/blob/d40d84774abb1caa84fab8427b542695d1ac1bae/lib/neo4j/active_node/persistence.rb#L146
Also (pet peeve alert), find_or_create_by are doing what ActiveRecord's find_or_create method does. ;)

The _by version. create just calls save which is within a transaction. Unless wrapping it in a transaction would give the find_by call access to uncommitted data created within a parent transaction?

I was just thinking that a method making two database calls should probably be wrapped in a transaction, though I didn't think about it too much.  I suppose since the find_by doesn't change anything that it doesn't seem like a big deal.
What about this situation, though:
Let's say two processes/threads call find_or_create_by at around the same time and this particular order happens:
A: find_by (nothing found)
B: find_by (nothing found)
A: create (node created)
B: create (node created)
It probably wouldn't even need to be two calls to find_or_create_by, but that is the most straightforward example, I think.  I think having the two queries run inside a transaction might alleviate this.  Although maybe not... If all you've done so far is two reads in two transactions then I don't think it would lock.  If you do a create I don't know what it would lock, but even if it did I think that the second create could still execute after the first transaction is done because there's nothing conflicting about the two created nodes (unless there's a constraint, perhaps)

Right, it won't help in that case for the reasons you described. I don't think it would lock at all unless you were creating a relationship. Merge would help here but it has those known drawbacks within the gem.

Yeah, I definitely want an option where people can do this where it's going to respect validations / hooks.  Ok, going to close for now, thanks ;)


Split a Circular Linked List into two halves Python

💥 Proposal
Split a Circular Linked List into two halves Python
I am GSSOC'21 Participant. Kindly assign me the same.
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


Node12 is deprecated

Just as a heads-up, as of recently (today?) the following popped up in the build annotations:
Node.js 12 actions are deprecated. For more information see: [link].
Please update the following actions to use Node.js 16: ilammy/msvc-dev-cmd

The link to the announcement: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
I tried a quick fix by forking and just changing it to node16 but it kinda exploded and i didn't want to open that can of worms :)

@codemasher,

I tried a quick fix by forking and just changing it to node16 but it kinda exploded

What exactly went wrong there?
I've pushed v1.12 (and updated v1) with the same fix from @Geod24 which should remove the warning. Looks fine to me...

To be honest i have no idea what happened - perhaps because i ran the action from my own fork/branch (which i've deleted since)?
however, i found the log from said run - if that helps:
Run codemasher/msvc-dev-cmd@update-node
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module '@actions/core'
Require stack:
- D:\a\_actions\codemasher\msvc-dev-cmd\update-node\index.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (D:\a\_actions\codemasher\msvc-dev-cmd\update-node\index.js:1:14)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    'D:\\a\\_actions\\codemasher\\msvc-dev-cmd\\update-node\\index.js'
  ]
}

Either way: thank y'all for the fix!

Hm... I'd suppose you cloned the master branch which does not have node_modules directory vendored (that avoids clutter and need to constantly update them here). That branch won't work before you npm install the dependencies.
The release/v1 branch has node_modules, that's where the action code comes from when it's used by other projects.

Ah that might have been the issue. Since i didn't have the brain juice to look into it, i deleted the branch and moved on - thanks for clearing this up!


Empty array (incorrectly?) triggering ValidationError

I am trying to validate a schema which should have a required key but may either have a populated array (of objects!) OR an empty array.  (Using 2.6.0)
Here's my simple repro case.  Schema first.  Note that my array, if it had elements, would be an array of objects and not simple elements.
{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "type": "object",
  "properties": {
    "x": {
      "type": "array",
      "items": [
        {
          "type": "object",
          "properties": {
            "a": {
              "type": "string"
            }
          },
          "required": ["a"],
          "additionalProperties": false
        }
      ]
    }
  },
  "required": [ "x" ],
  "additionalProperties": false
}

The populated case succeeds: {"x": [ {"a":"foo"} ] }
However, the empty array case of {"x": [] }' fails with
JSON::Schema::ValidationError: The property '#/x/0' of type NilClass did not match the following type: object in schema file:///zzz/schemas/schema.json
from /zzz/vendor/bundle/ruby/2.3.0/gems/json-schema-2.6.0/lib/json-schema/attribute.rb:18:in `validation_error'
Am I making a fundamental error with my schema, or is this a bug?  I'm new at this but the way I read the spec, the empty array should be allowed in this case...

Ok, I'm still learning here.
I think my solution is to define the inner array as allowing both object and null as choices, e.g.
    "x": {
      "type": "array",
      "items": [
        {
          "type": ["object", "null"],

though I wouldn't mind someone validating that...

The problem is that you specified the array items within an array, you need to specify it in an object.
Specifying an object schema here means that all of the 0..n elements within the array must adhere to the given schema (no element is always valid to any schema).
But if you specify an array of schemas, the elements at the respective index position must adhere to the schema at the same position. http://json-schema.org/latest/json-schema-validation.html#anchor36

Oh, I see!  Thanks!


mimir worker v0

This PR adds the mimir_worker interface.
A follow-up PR will align with the contents of the mimir charm repo and add some tests

@PietroPasotti this PR is pretty stale, any problem if I close it?

fine with me. we'll pick it up when we resume working on mimir next cycle


tether and tetherOffset in @floating-ui/react-dom

Hello, I’m in the process of migrating @sanity/ui from react-popper to @floating-ui/react-dom.
I’m looking for the equivalent of tether and tetherOffset, but have not found it when browser through docs. Is this replaced by some new functionality? Or should I make my own middleware?
Cheers, & thanks for the great work!

limitShift is the replacement


Todo: charinfo command

The plan for this feature is basically to replicate this command from Kitchen SInk:

We have ksink now, so this isn't necessary


useImplementingTypes on client preset

Is your feature request related to a problem? Please describe.
Now it's impossible to use implementing types with the client preset when use interfaces.
Describe the solution you'd like
'./gql/': {
    preset: 'client',
    config: {
        useImplementingTypes: true,
    },
}

Describe alternatives you've considered
Alternative now is avoid of use client preset and instead use typescript plugin where this future was implemented.
Is your feature request related to a problem? Please describe.
No response

This would be helpful as client-preset is now the recommended approach but in order to use useImplementingTypes, we have to go back with typescript plugin.


Remove Log4J 1.x from the bin distribution

Motivation
For some reasons, Log4J 1.2.x was being included in the binary tar.gz, even though not used anymore.

run integration tests

run integration tests

run integration tests


Squaremap-signs allows for injecting HTML

Using the following sign:

I see the following result on the map:

This would also allow throwing an Error in the browser.

This is an issue that needs fixing in squaremap-signs itself, as it is adding unsanitised user input into the marker tooltip and will be causing the same issue in the stock frontend.
Squaremap markers are allowed to include html in their tooltips and the official addons make frequent use of this, so it cannot be stripped out without breaking compatibility.


Dynamically passing new data to modelview (non-standalone views)

All the examples I found of passing additional parameters make use of standalone views.
I want to compute new data and pass to the view on each request, is it possible?
Looked at ModelView functions and attributes but I don't see anything relevant.

looked into basemodelview as well and there's nothing there either, there's extra_args that are passed to self.render() but they are just extra url query GET args.


Custom kernel Issues

CombinedKernel.cpp line 154: Number of lhs-feature vectors (4345) not match with number of rows (1831) of custom kernel
Is it necessary that feature matrix  rows and columns should match. I have to split my data into train and test where by it may not be possible to pass a square matrix to custom kernel. How to handle this.

Can you share a minimal example of the code that caused this?


clickhouse: add limitations and limits for a service

Adding info on restrictions on using Aiven for ClickHouse so that the users are aware of the service capabilities and can make educated choices when operating it.
https://aiven.atlassian.net/browse/DOC-61

Looks good to me, the only thing is on the backups. It says data is lost on the recycling of nodes, does that include patches/migrations/scaling?

None of the example you mention @ROConnor-Aiven  are data loss scenarios, they are handled safely and automatically.

If anyone has any insights into the Cloudflare Pages build failure feel free to share, not able to get visibility into it.

@aris-aiven fixed that :-)


Add Squircle primitive

Objective

Adds a squircle primitive, Fixes #13469

Solution

Added a Squircle primitive to bevy_math. The chosen squircle is based on the superellipse.
Implemented gizmos for squircles

squircles use rectangles and rhombuses internally if the shapes are sufficiently similar.
The resolution of the squircle can be configured by calling .resolution() on the builder

Additional information
The gizmos implementation may seem overcomplicated, but the following images may clarify why an implementation like this is needed:

The left squircles use samples that are equally spaced by angle.
The center squircles use samples interpolated between the left and right (this is the solution I ended up using)
The right squircles use samples that have equally spaced normal vectors, i.e. the normal vector rotates by the same amount between each sampled point.
All squircles have a resolution of 32

Should we merge this anyways and tackle adding rounded corner support using squircles in a follow-up?

Yeah, I would prefer that to be in a follow up, since that would be a completely new solution touching at least one more crate

@lynn-lumen looks like this needs some love with the recent changes on main.

Is there a variation of this type of shape that would have "symmetrical curvature" even when width and height are not equal?
To crudely illustrate: https://www.desmos.com/calculator/r4mzfslt8m

Bumping to controversial: I'm not actually sold on how useful this is. Maybe the UI designers know something I don't, but this doesn't seem to be a meaningful improvement over rounded corners.

There seems to be an issue with access_kit_macos which prohibits building bevy. I have filed an issue #14956


document fixes

Thanks. Going forward it would be better to keep changes such as the one CMakeLists.txt separate, since it is almost a functional change.

ok!


Pretrained model link not working

Hello, the link you have provided for the pre-trained model doesn't seem to be working. Could you please update it?

sorry, my bad. It seems to work in incognito mode


Added ability to generate listeners

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the code of conduct.

Changes

[x] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Closes : #155
Description

Put on hold - different idea which includes buildSrc


Unable to use the project on Mac OSX

Is it not possible to use web app samples on Mac OS?
On "npm i" it comes up with Platform error.

We currently do not publish a MacOS version of the iModel.js native node addon so the samples will not work on a Mac.
The list of currently supported platforms can be found here: https://imodeljs.org/learning/supportedplatforms/.
We're working on getting one published and will update that list once it's available.

@yesprasoon MacOS is now officially supported as of iModel.js 1.12.0.  Let us know if you face any issues when using it.  Thanks!

I tried with three projects and here are the issues in those 3 when I try
to do npm i or npm install:
viewer-only-sample = GET
https://registry.npmjs.org/@bentley/frontend-sample-base - Not found
query-agent = GET https://registry.npmjs.org/imodel-changeset-test-utility

Not found

simple-viewer-app = Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"win32,linux","arch":"any"} (current:
{"os":"darwin","arch":"x64"})
On Thu, Feb 13, 2020 at 10:45 PM Caleb Shafer<EMAIL_ADDRESS>wrote:

@yesprasoon https://github.com/yesprasoon MacOS is now officially
supported as of iModel.js 1.12.0. Let us know if you face any issues when
using it. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/imodeljs/imodeljs-samples/issues/9?email_source=notifications&email_token=AA7G7HXHJXMWNBOBGB2TIZDRCV525A5CNFSM4JPPALT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELV2LMA#issuecomment-585868720,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7G7HQIKN55SJEQMSYHEH3RCV525ANCNFSM4JPPALTQ
.

@yesprasoon the imodeljs-samples repo and all of the samples within it are setup using Rush so you'll need to use that to install the samples.  Here are the steps from the README for how to builds the samples.
In terms of the Unsupported platform for simple-viewer-app@0.0.0:..., that's a bug on our part.  We'll have a fix available soon.


[DO NOT MERGE]Replace mirror1 with an S3 bucket

We want to serve our mirrors from an S3 bucket rather than a
dedicated machine. To do this we need to configure fastly with the
correct authorization headers and remove the AWS headers from
returned objects.
This is a placeholder PR until we can fully check this. I believe it to be reasonable correct but a test bed (which isn't production) needs to be made.

After chatting with @surminus I think this is wrong. The plan is to use an IP based read-only policy on S3 so the authorisation can be removed.
To reflect this I'm going to close this PR and try again.


Spurious CI failure connecting to ganache

Sometimes we get an integration test failure on CI that looks like
 [data-source-context:stdout] yarn run v1.22.10
[data-source-context:stdout] $ yarn build-contracts && truffle test --compile-none --network test
[data-source-context:stdout] $ ../common/build-contracts.sh
[data-source-context:stdout] $ /home/runner/work/graph-node/graph-node/tests/integration-tests/node_modules/.bin/truffle compile
[data-source-context:stdout]
[data-source-context:stdout] Compiling your contracts...
[data-source-context:stdout] ===========================
[data-source-context:stdout] > Everything is up to date, there is nothing to compile.
[data-source-context:stdout]
[data-source-context:stdout] > Something went wrong while attempting to connect to the network. Check your network configuration.
[data-source-context:stdout] Invalid JSON RPC response: "404 page not found\n"
[data-source-context:stdout] Truffle v5.2.3 (core: 5.2.3)
[data-source-context:stdout] Node v14.17.0
[data-source-context:stdout] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Such as in this run https://github.com/graphprotocol/graph-node/pull/2499/checks?check_run_id=2690014734.

Thanks to @lutter we don't use ganache in CI anymore, yay


Avoid get_device

Please see #2776.

LGTM

Do we need to backport this PR?

Yes, It is better.

OK


Feature Request

I'd like to be able to clear the notification stream. Currently it seems like the only way to remove the highlight from a new comment notification is to click through it, but I usually click to the first and then go through the comments on the board.

Would you essentially like a "mark as read" button, ala Facebook?

Yes! That would be nice.

That makes sense and is doable. As ever, I can't promise a delivery date, but I'll try to make this happen for you soon. :smile:

Awesome. Thanks!


Develop stream 2023-06-19

Split off hipRAND from rocRAND.
Implement methods:

GetDirectionVectors32/64,
GetScrambleConstants32/64,
DirectionVectorSet.

Create new tests in test_hiprand_kernel.cpp that use sobol and scrambled sobol.
Remove reliance on manually-specified WIN32 define.
Remove references to HCC.
Add linkage test to CI.
Add copyright check script.

cc @RobsonRLemos @lawruble13

Splitting hipRAND requires some changes in some of our CI, this is in progress and should be complete soon so this can be merged without causing issues.


Feat(icon): Added safetensors extension support

Fixes #3499
Changes proposed:

[x] Add
[ ] Delete
[ ] Fix
[ ] Prepare

Safetensors is a file format for storing and distributing tensors, which are multi-dimensional arrays often used in machine learning algorithms.

@robertohuertasm can you take a look at this PR?
people from HuggingFace would love this icon support :)

Hi, any updates on this? 🤗

Yeah added icon for dark and light mode

awesome 🥳


[pyTorch] Enable the model to change precision between iterations

This fixes an issue with the wrong types being used when the model is cast after the first iteration.

/te-ci

/te-ci

/te-ci


⚠ Bofrost.be has degraded performance

In a4dab94, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1866 ms

Resolved: Bofrost.be performance has improved in 56f2645 after 28 minutes.


LeafFieldComparator setBottom not being called before compareBottom

Description
It looks like there's a problem in the TopFieldCollector.java where it calls "compareBottom" without calling "setBottom" first.
I believe this is an issue if getLeafComparer( ) is called more than once, as the new class will no longer have the previous bottom slot value.
I found a workaround is to rescope the variable storing the bottom slot set from calling "setBottom( )", to outside of the LeafFieldComparator class to make it persistent (just like the setTopValue( ) is called outside of the LeafFieldComparator class).
Rescoping the bottom slot should be safe unless multiple threads are being run at the same time and need their own version of bottomSlot for the LeafFieldComparator class.
The documentation here
https://lucene.apache.org/core/8_0_0/core/org/apache/lucene/search/LeafFieldComparator.html
states that "[setBottom] will always be called before compareBottom(int)"
So one might think the LeafFieldComparator would be used like this:
//get new leaf comparator
LeafFieldComparator lc = getLeafComparator( );
//setBottom before compareBottom
lc.setBottom(xxx);
lc.compareBottom(yyy);

//get new leaf comparator
lc = getLeafComparator( );
//setBottom before compareBottom
lc.setBottom(xxx2);
lc.compareBottom(yyy2);

However, it is being called in this fashion:
//get new leaf comparator
LeafFieldComparator lc = getLeafComparator( );
//setBottom before compareBottom
lc.setBottom(xxx);
lc.compareBottom(yyy);

//get new leaf comparator
LeafFieldComparator lc = getLeafComparator( );
//compareBottom... hopefully the slot is correct...
lc.compareBottom(yyy);

As you can see, the 2nd set of code does not treat the LeafComparator as if each instance has it's own bottomSlot variable. I believe the purpose of this would be to allow multiple threads to call this simultaneously, which would require each one to have it's own bottomSlot, otherwise it would not be thread safe.
Also, if setBottom was meant to be outside of the scope of LeafComparator, then why was the time taken to put setTop outside and setBottom inside? This seems to have been done very deliberately according to the documentation.
Here is a sample code snippet:
import org.apache.lucene.index.LeafReaderContext;
import org.apache.lucene.search.FieldComparator;
import org.apache.lucene.search.LeafFieldComparator;
import org.apache.lucene.search.Scorable;

public final class MySimpleStringComparator extends FieldComparator<String> {
	private String[] values;
	private final String field;
	private String topValue;

	//SCOPING bottomSlot HERE WILL CAUSE ITEMS TO RETURN PROPERLY
	//private int bottomSlot;

	public MySimpleStringComparator(int numHits, String field) {
		this.values = new String[numHits];
		this.field = field;
	}

	@Override
	public int compare(int slot1, int slot2) {
		return this.compareValues(this.values[slot1], this.values[slot2]);
	}

	@Override
	public LeafFieldComparator getLeafComparator(LeafReaderContext lrc) throws IOException {
		final LeafReaderContext frc = lrc;

		return new LeafFieldComparator() {
			//SCOPING bottomSlot HERE WILL CAUSE ITEMS ON A SUBSET TO RANDOMLY DISAPPEAR
			private int bottomSlot;

			public void setScorer(Scorable arg0) throws IOException {
			}

			public void setBottom(int slot) throws IOException {
				bottomSlot = slot;
			}

			public void copy(int slot, int doc) throws IOException {
				values[slot] = frc.reader().document(doc).get(field);
			}

			public int compareTop(int doc) throws IOException {
				return compareValues(topValue, frc.reader().document(doc).get(field));
			}

			public int compareBottom(int doc) throws IOException {
				return compareValues(values[bottomSlot], frc.reader().document(doc).get(field));
			}
		};
	}

	@Override
	public void setTopValue(String val) {
		this.topValue = val;
	}

	@Override
	public String value(int slot) {
		return this.values[slot];
	}
}

Here is a code snippet that runs a search/sort for a single page that utilizes the MySimpleStringComparator above.
ComplexPhraseQueryParser cpqp = new ComplexPhraseQueryParser("somefield", analyzer);
Query query = cpqp.parse("somevalue");

pageSize = 10;
pageNum = 1;
requestedRecords = pageSize * pageNum;
startOffset = (pageNum - 1) * pageSize;

FieldComparatorSource fsc = new FieldComparatorSource() {
	@Override
	public FieldComparator<String> newComparator(String fieldname, int numhits, int sortPos, boolean reversed) {
		return new MySimpleStringComparator(numhits, fieldname);
	}
};

Sort sort = new Sort(new SortField("firstname", fsc, false));
IndexSearcher searcher = new IndexSearcher(reader);
TopFieldCollector tfcollector = TopFieldCollector.create(sort, requestedRecords, Integer.MAX_VALUE);
searcher.search(query, tfcollector);
ScoreDoc[] hits = tfcollector.topDocs(startOffset, pageSize).scoreDocs;

Version and environment details
This is running on Windows Server 2019 using Tomcat 8.5 with Lucene 8.11.2 (also reproduceable in 8.6.0)

I think you're right that bottom should be scoped outside the LeafFieldComparator. It stores the bottom slot value for competitive hits and should survive across leaf contexts.
I checked a few FieldComparator implementations however, and I do see  it scoped outside the LeafFieldComparator. For e.g. DoubleComparator, and DocComparator
This also seems to be the case in Lucene 8.11.2 ([1], [2])
Can you share code references/links for some comparators where you see this is an issue? Or perhaps a test which reproduces this issue?

It's been a long time, but I would guess that setBottom was put on LeafFieldComparator instead of FieldComparator because it is always called from a LeafCollector rather than a Collector (in contrast to e.g. setTop). It could make sense to move it to Comparator, but this would force LeafCollectors produced by top-field comparators to keep track of both the FieldComparator and the LeafFieldComparator. In the end I don't have a strong opinion on this question, there seem to be pros/cons with both having setBottom on Comparator and LeafFieldComparator.


Add CODEOWNERS

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (master)
[ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

There is an error that prevents the PR from being merged: lint private_in_public has been removed: replaced with another group of lints, see RFC https://rust-lang.github.io/rfcs/2145-type-privacy.html for more information
I replaced it with the guidelines given in the RFC, will see how it works...

Ok, it seems alternatives are not stable yet, so the best bet is to remove this lint for now.


Revert "Downloading videos using Background Fetch API"

Reverts GoogleChrome/kino#169

@Swansoffie02 I'm not sure exactly what your goal is for this PR and what it's meant to accomplish. I'm going to close the PR, if there is a valid reason for reverting then please describe it.


Astro not able to update/install

After the latest update got released, Astro is not able to update/install, even after rest and reboot

Hey sorry this should be fixed now

yep fixed, also the crashes look to have been fixed, did not enter a duty with an astro healer yet to 100% confirm but it looks ok :)


Add cpu-support to preview LogisticRegression

Description
Add fallback to daal4py LogisticRegression in case algorithm is run with cpu device

/intelci: run

/intelci: run


Use of Dodrio virtual DOM

Maybe if you’re not that eager to maintain you own virtual DOM, you might use https://github.com/fitzgen/dodrio

Dodrio looks really cool!
I do see that it is now achieved by the owner so I'm going to close this issue - if anything changes then feel free to re-open this proposal or make a new one!
Happy coding ❤


fix :key problem

Problem Summary:
What is changed and how it works?
Proposal: xxx
Feel free to ping committers for the review!
Contribution Checklist

Make sure that the pull request corresponds to a GITHUB issue.

Name the pull request in the form "[Feature] [component] Title of the pull request", where Feature can be replaced by Hotfix, Bug, etc.

Minor fixes should be named following this pattern: [hotfix] [docs] Fix typo in README.md doc.

-->
Purpose of this pull request
In the lanuch stage, check "Application Launching Progress", there will be a lot of errors on the page, and the page will be stuck
在lanuch阶段，查看“Application Launching Progress”, 页面会有大量报错，会将页面卡住

LGTM


Add start unit tests

I would prioritize this and #45 to make the codebase more approachable for contribution :fearful:

I added the priority labels to those 2 cards.
I agree they are priority. Also #43 is very important.
Do you want to work on those? Go ahead. It will be very helpful for the project :D
And thanks for the help so far.

I would except the fact that the code is untested makes it very difficult to understand. Don't really know where to start in terms of getting the tests to start :/

The code indeed lack tests and it may be difficult to understand. But at least is separated in small functions and that may help to test it.
I will try to add some tests as well.

Did you see my pr #68? I was able to get the tests running last night.

Nice, I checked it quickly, but will look further this week.

Did you get a chance to look at it @glauberramos ?

Not really =/
I'll travel to the beach now and will be back on monday. I will take a look early next week.

Pull request accepted :dancer:


[bugfix] fix finetune_checkpoint restore bug

variables contain partitioned name pattern, but has not save_slice_info is not considered as sliced variable

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


governance center usability improvements - ES related UI fixes

please merge these changes.

Is there any specific reason to use success-MsgDiv & error-MsgDiv  classes instead of bootstrap alert classes. ?

I wouldn't know the motivation behind that as @hiranthadhanuka did the initial override. but I guess its ok to use a custom class name instead generics as we can use (if we ever need to) bootstrap and metro styling at once if we follow this. WDYT?


Extract constants to separate script for C_WGL and C_WinApi.

Done only for C_WinApi module. There is not much in C_WGL module to need to do that.


fix incorporation of tapering weights

As x0s(:,7) also contains the integration weight of the secondary source, the influence of the tapering has to be computed by normalising the result to the original integration weight.

Has this also to be considered in SFS_monochromatic/driving_function_mono_localwfs.m?

It is already considered by https://github.com/sfstoolbox/sfs-matlab/blob/2bbd541d3aa1783a7b5273339b316e3638096d9f/SFS_monochromatic/driving_functions_mono/driving_function_mono_wfs_vss.m#L89.

If you would like to use only the tapering weights and exclude the integration weights you might also considering to use tapering_window() instead of secondary_source_tapering(). This is actual used in the latter, have a look.
For the time domain the code would then look like this:
wtap = tapering_window(x0s,conf);

and you can remove the x0tmp = secondary_source_tapering(x0s,conf); line.
For the frequencz domain you could change it to
wtap = secondary_source_tapering(xtmp,conf);
Dmatrix(xdx,idx) = driving_function_mono_wfs(xtmp,xv(idx,1:3),'fs',f,conf) .* wtap;

and remove the x0(:,7) = 1; line. In my opinion the result would be easier to understand.

Ah, cool. I will change both functions.


[AION] Add 0x to transaction hash

https://github.com/trustwallet/blockatlas/commit/22ed27ae9252e38f9d75e0aec93d5b086e565426


Add two missing pthread calls to the OpenBSD support.

These are shamelessly copied from the NetBSD support, whose prototypes in this regard are identical to OpenBSD's.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

cc @semarie

@gnzlbg test is fine on my side. thanks.

@bors: r+

:pushpin: Commit f66774e673c9bf721f88e3d6b7d865d027eff0d2 has been approved by gnzlbg

:hourglass: Testing commit f66774e673c9bf721f88e3d6b7d865d027eff0d2 with merge 599704faf027121fe0003ff598c166bdd5c3abd8...

:broken_heart: Test failed - status-azure

cc @tlively @alexcrichton it seems that the asmjs and emscripten build jobs are down.
apparently i686-pc-windows-gnu is failing with a segfault on nightly, @mati865 i can't find a report for anything weird for that target upstream, have you seen that recently somewhere else ?

Personally I don't use 32 bit platforms/toolchains at all. You should report it at Rust repo.
I won't be able to look into it for few days so hopefully somebody will fix it.

Will have a PR up tomorrow morning to upgrade the Emscripten version on the CI. It's basically going to be copying the new emscripten.sh file from the rust-lang/rust repo.

Is it worth retrying a build now?

Can we try another build?

bors is down, hopefully it will be back up soon

@bors r- retry

@bors: r+

:pushpin: Commit f66774e673c9bf721f88e3d6b7d865d027eff0d2 has been approved by gnzlbg

:hourglass: Testing commit f66774e673c9bf721f88e3d6b7d865d027eff0d2 with merge 328eff4d1b83290e8f96f7be0cc063c9e752dbdb...

:sunny: Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 328eff4d1b83290e8f96f7be0cc063c9e752dbdb to master...


Resolve conflicts automatically when making new release

During automated release process some files are modified, which causes conflicts when creating a new release.
Find a way to automatically accept changes from the incoming (release) branch when making a PR to master.

release notes must be updated separately to development before the release-X.Y.Z branch gets created
so the workflow should be: close milestone -> make branch for release notes -> make release notes -> make pr to development -> accept PR -> create release-X.Y.Z branch -> update versions in that branch -> merge master into that branch, using --strategy=ours -> create PR from release-X.Y.Z into master

alrighty, more additional steps: since development is protected by checks, a PR must be made for release notes separately, and ideally there is another workflow fired when that PR is ready to be closed and closes it

this is great... according to the docs and support check_suite events are not triggered from the default actions workflow, which means on: status events should be used


Release/g6 4.3.2

Updated to the latest antv and graphin release.
Graphin: 2.0.7
G6: 4.3.2
demo example looks fine but will try it out in the larger application

Ok maybe, it's not a good idea...
I am getting the following error:
 ../../node_modules/@antv/algorithm/es/gaddi.js:3:9: error: No matching export in "../../node_modules/tslib/tslib.es6.js" for import "__spreadArray"
    3 │ import { __spreadArray } from "tslib";
      ╵          ~~~~~~~~~~~~~

Will re-install all dependencies and try again but if this does not work, let's just use the old one. No time to debug

ok not a good idea, let's scrap this.


I use golang eight years.Today I want create a object.I run the code but I got error.

I use golang eight years.Today I want create a object.I run the code but I got error.
obj1:={
attributeName1 int
attributeName2 int
AttributeName2 int
init:=func(){
}
Func1:=func()int {
	return 33
}
Func2:=func()int {
	obj3.func1()
	return 3243
}
length float32
go Func1()
obj3:={
	kkk int
	aaa int
	jjj int
	init:=func(){

	}
	func1:=func(){

	}
	run:=func(){

	}
}
obj3.run()

}
I run it but I got error:
.\RangeTree.go:3:1: syntax error: non-declaration statement outside function body
.\RangeTree.go:7:14: method has no receiver
.\RangeTree.go:7:14: syntax error: unexpected {, expected name
.\RangeTree.go:10:2: syntax error: non-declaration statement outside function body
.\RangeTree.go:10:15: method has no receiver
.\RangeTree.go:11:3: syntax error: unexpected return, expected )
.\RangeTree.go:17:2: syntax error: non-declaration statement outside function body
.\RangeTree.go:23:15: method has no receiver
.\RangeTree.go:23:15: syntax error: unexpected {, expected name
.\RangeTree.go:26:3: syntax error: non-declaration statement outside function body
.\RangeTree.go:26:3: too many errors
I want it no error.
I just want one instance. so didn't need class define.
I want the object have one init func. that initialize the object at define.
I want the object define context can run none define code at object create.eg: obj3.run().

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions


Seattle: Include question type in question object

TODO: followup with Gwen about what this will be used for

This is a duplicate of #5437


Simple bookkeeping feature

What do you think of implementing a simple bookkeeping with all entry and exit trades?
Something pretty much like arbitrader-state.json would be fine. It would make life easier when you have several exchanges.

Yeah, I think that would be very useful. It would help with some of the work I've been doing around trying to make the bot's prediction of things like fees and profit agree with the actual outcomes. It would also be really nice to have a clearer picture of how you're doing over time.

Cool, I will try to implement it over the weekend.
I thought about creating a json file with a json array containing all trades grouped by an UUID. Pretty much like arbitrader-state.json. I think it is already a good starting point. Maybe in the future also export to CSV.


Add missing build dep & fix link

The changes are pretty simple and self-explanatory.
Why not include all the dependencies that are missing?
There are some other dependencies that are not stated (such as make) but these are easy to find out, however cairo is not, so for now I've only added cairo.

@googlebot I signed it!


Make most variants of module.exports = { ... } fixable

This is https://github.com/mysticatea/eslint-plugin-node/pull/208 against your fork now that eslint-plugin-node is unmaintained and eslint-plugin-n is being used by eslint-config-standard 😇
It got reviewed by the original author, who then disappeared before merging it.

CI failure (npm ERR! 409 Conflict - GET https://registry.npmjs.org/astral-regex ) seems unrelated as I'm not touching any dependencies: https://github.com/weiran-zsd/eslint-plugin-node/runs/6145701620?check_suite_focus=true#step:4:9 🤔

no worries, I've re-run the ci - seems working now! 🎉

released in v15.2.0


Support all dash.js configuration options

Allow all configuration options that dash.js supports to be passed at instantiation.
I updated the README.md, but I think my wording is confusing. Can someone please suggest a better way to describe what this does?
This will not work on IE8 because of Object.keys and Array.prototype.forEach. IE8 doesn't support dash anyway, so that shouldn't matter, right?
Todo:

[x] Better wording for docs?
[x] Do we need the Object.keys and Array.prototype.forEach polyfills?
[x] Support non-boolean options

Addresses #138

Nice! Yes you don't have to worry about IE8 compatibility, the source handler code will only execute on browsers that support MSE.

@mjneil  and @forbesjo : Do you think the readme update is sufficient?

The README looks good to me

+1 for non-boolean options please!
We'd love to do: setMaxAllowedBitrateFor('video', 2000)

@richardbushell You're right, I totally missed this. New PR sent that will support multi-argument configuration #144


Revert "Fix some clang-tidy issue"

Reverts grpc/grpc#28679
Looks like it breaks
grpc/core/master/linux/grpc_basictests_c_cpp_dbg and grpc/core/master/linux/grpc_basictests_c_cpp_opt
https://source.cloud.google.com/results/invocations/e81551a9-e704-4bf5-b5c5-e4284da75a24/targets/github%2Fgrpc%2Ftoplevel_run_tests_invocations%2Frun_tests_c%2B%2B_linux_dbg_native/tests
run_tests.py relies on first obtaining the list of tests from test binaries, and it seems that started failing becuase of the PR.
2022-01-26 00:23:57,136 START: tools/run_tests/helper_scripts/pre_build_cmake.sh
2022-01-26 00:24:10,990 PASSED: tools/run_tests/helper_scripts/pre_build_cmake.sh [time=13.9sec, retries=0:0; cpu_cost=1.0; estimated=1.0]
2022-01-26 00:24:10,990 START: make
2022-01-26 00:26:58,228 PASSED: make [time=167.2sec, retries=0:0; cpu_cost=10.4; estimated=1.0]
2022-01-26 00:26:58,244 failed to detect port server
Traceback (most recent call last):
  File "/usr/lib/python3.9/urllib/request.py", line 1346, in do_open
    h.request(req.get_method(), req.selector, req.data, headers,
  File "/usr/lib/python3.9/http/client.py", line 1255, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/lib/python3.9/http/client.py", line 1301, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.9/http/client.py", line 1250, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.9/http/client.py", line 1010, in _send_output
    self.send(msg)
  File "/usr/lib/python3.9/http/client.py", line 950, in send
    self.connect()
  File "/usr/lib/python3.9/http/client.py", line 921, in connect
    self.sock = self._create_connection(
  File "/usr/lib/python3.9/socket.py", line 843, in create_connection
    raise err
  File "/usr/lib/python3.9/socket.py", line 831, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/var/local/git/grpc/tools/run_tests/python_utils/start_port_server.py", line 41, in start_port_server
    request.urlopen('http://localhost:%d/version_number' %
  File "/usr/lib/python3.9/urllib/request.py", line 214, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.9/urllib/request.py", line 517, in open
    response = self._open(req, data)
  File "/usr/lib/python3.9/urllib/request.py", line 534, in _open
    result = self._call_chain(self.handle_open, protocol, protocol +
  File "/usr/lib/python3.9/urllib/request.py", line 494, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.9/urllib/request.py", line 1375, in http_open
    return self.do_open(http.client.HTTPConnection, req)
  File "/usr/lib/python3.9/urllib/request.py", line 1349, in do_open
    raise URLError(err)
urllib.error.URLError: <urlopen error [Errno 111] Connection refused>
2022-01-26 00:26:58,248 starting port_server, with log file /tmp/tmpim49umzr
2022-01-26 00:26:59,358 port server is up and ready
Traceback (most recent call last):
  File "/var/local/git/grpc/tools/run_tests/run_tests.py", line 1881, in <module>
    errors = _build_and_run(check_cancelled=lambda: False,
  File "/var/local/git/grpc/tools/run_tests/run_tests.py", line 1765, in _build_and_run
    one_run = set(spec for language in languages
  File "/var/local/git/grpc/tools/run_tests/run_tests.py", line 1766, in <genexpr>
    for spec in language.test_specs()
  File "/var/local/git/grpc/tools/run_tests/run_tests.py", line 360, in test_specs
    tests = subprocess.check_output(
  File "/usr/lib/python3.9/subprocess.py", line 424, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.9/subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['cmake/build/interop_test', '--gtest_list_tests']' returned non-zero exit status 1.

Pretty sure this is also responsible for breaking imports - so let's check that before rolling forward too.


Delivering exception to http://undefined:80undefined

I was setting up bugsnag in local env and threw a dummy exception in request handler to test the integration. This message was logged through a custom logger[1] by bugsnag. Despite the strange error message, the exception appeared in the dashboard.
{"level":30,"time":1540199180996,"msg":"Delivering exception to http://undefined:80undefined","pid":15388,"hostname":"localhost","reqId":"be26bf30-d5d9-11e8-a814-97f91aedacb4","personId":6,"v":1}

This is the line in bugsnag lib that logs the message, and logging Configuration before that line shows that notifyHost or notifyPath are not set in the object.
Configuration.logger.info("Delivering exception to " + (Configuration.useSSL ? "https" : "http") + "://" + Configuration.notifyHost + ":" + port + Configuration.notifyPath);

[1]:
bugsnag.register(BUGSNAG_API_KEY, {
  logger: log
})

Looks like this log message was broken as a part of #143. We are close to releasing a new major version that will be an entire rewrite that will fix this.

The rewrite @snmaynard mentioned is now complete and released: @bugsnag/js (docs, upgrade guide)
This package is now deprecated so we're closing off old issues.


Ability to append GET, POST or named data to request

Mainly used in Middleware.

Decided against this, it's basically what the fallback parameter on $request->data() is for.


JW-938 Unified interface naming.

Default vif indices should now work, as well as adding multiple physical interfaces, etc. There is no special case for any type of interface during processing anymore.

Do not review quality of code in files in sandesh-temp directory please, these were not written by me, just generated via sandesh.exe.

Retest this please


[Issue] Error on opening todo-nodejs-mongo in Codespace

[ ] Make sure you've installed the latest version using instructions in the wiki

Output from azd version
azd version 0.4.0-beta.1 (commit 2bf7a529914d86d8e9f5d7b6f95a4f20a2351e01)
Output from az version
Run az version and copy and paste the output here (minimum required version is 2.38.0):
{
  "azure-cli": "2.38.0",
  "azure-cli-core": "2.38.0",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {}
}

Describe the bug
Seeing this error when opening todo-nodejs-mongo in Codespace

The output window shows something about missing dotenv for a second and then it disappears (I haven't been successful in screenshotting it).
To Reproduce

Open todo-nodejs-mongo in a Codespace
See prompt in bottom corner

Expected behavior
No error
Environment
Codespaces

I've seen that error when the azd vscode extension is not installed (it brings the dotenv dependency for the tasks).
So, as soon as the extension is automatically installed by the vscode settings, the error is gone.
@karolz-ms is there a way to make the tasks ti wait until vscode has finished all the remote container setup before it checks the tasks? Or, maybe we can install the dotenv dependency in the container directly

@vhvb1989 @savannahostrowski I do not think merely opening an AZD-enabled project should result in running any tasks. What I suspect is happening is overly-eager validation of task file syntax, which results in an error that disappears after our extension finishes installation.
I am not really sure if this is a Codespaces issue or VS Code issue. Will ping my VS Code contacts.

@karolz-ms @savannahostrowski @vhvb1989 We had logged https://github.com/microsoft/vscode/issues/165292 a few weeks ago

Opened https://github.com/microsoft/vscode/issues/168494 to have VS Code people look at this. Probably external.

Going to close this as I haven't seen it in awhile/it was upstream.


Fixed a false positive test

While studying the code, I noticed that a rendering test passed when unintent=false is sent to the get-code-snippet helper. We also want to keep in mind that QUnit DOM trims both the expected and actual values (unless we pass a regex). To check for indentation, I used textContent to get the raw output.

Thanks!


WIP: Add styled components

- Summary
This adds the styled-components library to the project and starts the process of replacing the css with individual styled-components.

This solves the lack of styled components. Should make the maintenance of the styling more idiomatic.
- Test plan
None at the moment. I could look into setting up some selenium testing to verify the elements are working as expected.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@rolfea can you make this an incremental change to just add the Button styling. I think making incremental PR's is the way to go.
When you have removed the comments cleaned up lint, it would be ideal to merge this.
As far as testing. I would like to address some sort of unit testing structure first before approach integration or acceptance testing through selenium

@bdougie sounds good - I will make this a more incremental change and clean up the linting
we should chat about what the best approach for unit testing would be

Going to close for now. I am updating to Style components 2.0


hcxdumptool: 6.0.7 -> 6.1.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ZerBea/hcxdumptool/releases.
meta.description for hcxdumptool is: "Small tool to capture packets from wlan devices"
meta.homepage for hcxdumptool is: "https://github.com/ZerBea/hcxdumptool"
meta.changelog for hcxdumptool is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 6.1.0 with grep in /nix/store/m85bfsrdrv7vl45biapbh6vxz345hhic-hcxdumptool-6.1.0

directory tree listing: https://gist.github.com/c8ee2754dcf87fd8c44e652f75417e8b

du listing: https://gist.github.com/710035e8592ef56473d9bfdc93b8267f

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
hcxdumptool
wifite2

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/m85bfsrdrv7vl45biapbh6vxz345hhic-hcxdumptool-6.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A hcxdumptool https://github.com/r-ryantm/nixpkgs/archive/78971f3faf120b50b0fd32ee1b4382feae33775d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/m85bfsrdrv7vl45biapbh6vxz345hhic-hcxdumptool-6.1.0
ls -la /nix/store/m85bfsrdrv7vl45biapbh6vxz345hhic-hcxdumptool-6.1.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

2 packages built:

hcxdumptool
wifite2

Maintainer pings
cc @danielfullmer for testing.

Does this needs to be updated in sync with https://github.com/NixOS/nixpkgs/pull/94504 ?


Flaky test_random.test_shuffle

http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/master/542/pipeline
======================================================================

FAIL: test_random.test_shuffle

----------------------------------------------------------------------

Traceback (most recent call last):

  File "C:\Anaconda3\envs\py2\lib\site-packages\nose\case.py", line 197, in runTest

    self.test(*self.arg)

  File "C:\jenkins_slave\workspace\ut-python-gpu\tests\python\unittest\common.py", line 157, in test_new

    orig_test(*args, **kwargs)

  File "C:\jenkins_slave\workspace\ut-python-gpu\tests\python\unittest\test_random.py", line 625, in test_shuffle

    testSmall(mx.nd.arange(0, 3), 100, 20000)

  File "C:\jenkins_slave\workspace\ut-python-gpu\tests\python\unittest\test_random.py", line 599, in testSmall

    assert abs(1. * count[str(mx.nd.array(p))] / repeat2 - 1. / math.factorial(data.shape[0])) < 0.01

AssertionError:

-------------------- >> begin captured logging << --------------------

common: INFO: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1485655931 to reproduce.

--------------------- >> end captured logging << ---------------------

https://issues.apache.org/jira/browse/MXNET-236

https://github.com/apache/incubator-mxnet/pull/10048
@reminisce @asitstands

@asitstands Could you verify whether 0.01 threshold is too big for checking the uniform distribution?

@reminisce The probability that the test fails is approximately 0.001 with the 0.01 criterion even if shuffle is implemented correctly, assuming the quality of the random numbers are good enough. So it could fail every 1000 runs of the test in average. It looks somewhat high probability. To lower the probability we can increase the number of samples to test uniformity of the shuffling. It is currently 20000. If we increase it as 40000, the failure probability is less than 10^-6 but the running time also increases. In my mahcine the running time increases from 40s to 55s. If this is not acceptable, another way is to relax the criterion as 0.015, which also makes the failure probability as less than 10^-6 but the test becomes less strict. I think that increasing the number of samples would be better. If the test again fails frequently with this increased number of samples, then there must be some problem in the implementation of shuffle or the random number generators. How do you think?

@asitstands Can you try feeding a fixed seed to the decorator with_seed and see whether the result distribution is fixed? If so, we can make that unit test deterministic.

@reminisce Seeding with with_seed produces a deterministic result. The test becomes significantly weaker comparing to the collective result produced by repeats with different seeds. However, if time consumption is important, I think that fixing the seed is reasonable. I'll make the change.

Addressed in #10313.

Time consumption for tests is not that important, but I think we should ask another question: If the generation of random numbers takes such a significant amount of time, wouldn't this also harm runtime performance in real applications?

@marcoabreu In the case of shuffle, the time consumption is mainly from the memory copy and not from the generation of random numbers. Random shuffling of n elements needs O(n) swaps of elements (exactly n for Fisher-yates algorithm). The memory copy is the "nature" of shuffling. We cannot avoid it if we want to shuffle something. Testing statistical validity of the random shuffling needs a lot of samplings and this is also the nature of the problem. We cannot avoid it without sacrificing something such as running time or strictness. Basically serious statistical testing of shuffling may not be considered as a part of unit tests and needs to be a separate test. But practically we need to settle down with somewhat less strict test as a part of unit tests.

@marcoabreu The implementation of shuffle already uses parallelism. On GPU, it utilizes parallel sorting algorithm and the memory swap is also parallelized. On CPU it uses GNU's parallel implementation of std::random_shuffle if the array is 1D. Only for higher dimensional arrays in CPU, the implementation is sequential. The optimization in this case is not trivial due to the diversity of data shape and hardware. I have tested a naive parallelization of the memory copy for the case. You can see the result in this comment. You have asked the test but I forgot mentioning you at the comment :)

Thanks for this great explanation and the detailed benchmarks, great job! In that case, I'd propose to go with the increase to 40000 samples - we can go even higher if you would like, the slaves have 72 vCPUs available (while I can't judge the GPU performance for this use-case) and since this task is IO-bound, we should not really see that much of an increase in time consumption as all threads can prepare the data in parallel and do something different while they're waiting for the memory controller. What do you think?
While pinning the seed makes things more comfortable, we have found quite a lot of issues in the past due to the random seeding.

If longer running time is allowed, I think that using 40000 samples would be better than fixing the random seed. More strict tests are better as long as we have available resources for them. In the other hand, I think that 0.01 criterion and 40000 samples are practically enough. More strict test requires much more cost. I repoduced the failure with the reported seed and confirmed that the test is ok with 40000 samples. This test will fail again someday even with the increased number of samples, but the probability is very low. How do you think @reminisce ?

I think 1^-6 sounds quite reasonable and the time consumption is still within acceptable boundaries :)
@reminisce please review the PR as you have more in-depth knowledge


Add code coverage badge

Integrate the code coverage badge into the Readme using CodeCov.io .

Implemented in #3


Create HTML DOM Events functions

Create HTML DOM Events functions

We will use this approach #86 that can minimise spaghetti code.
So, we don't need to create pure functions for everything.


PostprocessImageArgs.init() missing 1 required positional argument: 'index', after new SD Forge overhaul update.

Nai api connects to the server no problem, but the generation does not work at the moment.

Ah yes, it seems to be fixed! Thank you! 👍


What about Timeline animation?

Hi there. Could you give some example to animate components one by one, like kind of TimeLine animation in anime.js. It's not staggerAnimation of list's items. I want to animate two different components in two different places of page, but one by one. I know how it may be implemented with anime.js or gsap.
Is there some way to make it with react-anime?.
http://anime-js.com/documentation/#basicTimeline
I'll be grateful for any help, thanks.

Controlling multiple components in different components would require the 2 components to share state in some way. Let me try cooking up an example here:
Lets say for instance, we have a view with Header and Body components.
We want it so that if we click a button, a unique animation will play one each of these components, 1 by 1.
import { Component } from 'react';

 class View extends Component {

  triggerAnimation = () => {
    // Stub
  }

 render() {
    return (
      <div>
        <Header/>
        <Body/>
        <Button onClick={this.tiggerAnimation}/>
      </div>
    );
  }
}

Workaround - Delay
One way to go about doing this is to set the delay of each element to be whatever the duration would be in timeline, for instance, I do that in the intro animation of the React Anime Github Page.
The whole point of a Timeline is to centralize those keyframes in one place though...
Future Work
Perhaps some future work should be defining a <Timeline/> element:
let Logo = () => (
  <Timeline>
    <Keyframe>
      <LogoOutline/>
    </Keyframe>
   <Keyframe>
      <LogoLines/>
    <Keyframe>
  </Timeline>
);

Sounds like a good feature for 2.1!

Oh thanks a lot, I am looking forward Timeline component. I'll use workaround solution. Thanks for the help.

Actually, we can use a trick here!
<Anime
    autoplay={false}
    ref={ref => {
        console.log('ref', ref);
        setTimeout(() => {
            ref.anime.play();
        }, 2e3);
        this._ref = ref;// this way we can control the animation also outside!
    }}
    ...
>
...
</Anime>

Was this functionality ever added? :c


python310Packages.yalexs-ble: 1.4.0 -> 1.6.2

Description of changes
https://github.com/bdraco/yalexs-ble/releases/tag/v1.6.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 187553 run on x86_64-linux 1

2 packages built:

python310Packages.yalexs-ble
python39Packages.yalexs-ble


Update to Mattermost v4.1

Hi @pichouk,
Wonder if I can ask your help to update the mattermost-docker repo to version 4.1.0 please?
You can find the changelog here and download links here
Thanks!

Sorry, I missed this month minor update...
Changelog seems ok for me, no braking changes. I just created PR #165 and wait for the Travis tests to be OK. WIll merge and tag in few minutes.

Seems good 👍


Add handling of PushEvent commits.

@geneh,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Breaking in VSCode

Bug Report

TSLint version: 5.20.1
TypeScript version: 3.6.4, (also on 3.7.2)
Running TSLint via: VSCode

Reproduction using TSLint Playground
Looks like tslint just fails on VSCode, using TypeScript 3.6.3 causes it to reactivate.
TypeScript code being linted
var wat;

^ my rules should be showing a warning on this code. should be let or const.
Actual behavior
Doesn't do anything
Expected behavior
Should work with latest TS
Doesn't look like many things were added in 3.6.4
https://github.com/microsoft/TypeScript/milestone/104?closed=1

I think I'm going insane.
It looks like a general failure.

Workspace version actually fails across the board, but using VSCode's version works. Wat

false positive, actually vscode broke it

🤖 Beep boop! 👉  TSLint is deprecated 👈  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


Where should this repository live?

I have no opinion about where to host this repository here for the workshop. If we would want to make a blog post about it, maybe it makes sense to transfer the ownership to the DE-RSE github organization? Don't know if this is possible and whether it confirms with the rules of de-RSE. May @sdruskat knows?

We (the Society) haven't thought about adopting repositories yet. I think this is currently out of scope for the association and not really necessary - so would suggest you keep hosting it under your own account - but I'm happy to discuss this further. Why do you think it would be beneficial to have this hosted as part of the de-RSE org?

Well, if this is an outcome of deRSE20 (particularly if I am not the only contributor), it would make sense to host it at github/de-RSE. But probably it does not make sense to make any decision before the workshop is accepted :sweat_smile:


Widen def for GO:0019933 cAMP-mediated signaling or new terms

The current def doesn't include how Dicty uses cAMP-mediated signaling, and we use this term.
"Any intracellular signal transduction in which the signal is passed on within the cell via cyclic AMP (cAMP). Includes production of cAMP, and downstream effectors that further transmit the signal within the cell. "
Context: In Dicty, the cAMP signaling is between cells when they start the development process, and even later in development. Dicty cells, when they starve produce and secrete cAMP. Other cells receive the signal, and then also start producing and secreting cAMP. Since the cells go through a refractory period when they are insensitive and also though produced Phosphodiesterase that breaks down the cAMP, in dark field you see cAMP waves.
I think the def should be complete changed
A suggestion:
Any intra- or extracellular signal transduction in which the signal is passed on via cyclic AMP (cAMP). Including production of cAMP, and downstream effectors that further transmit the signal within or between cells.
Thanks

Hi @pfey03
We had discussed this for the GPCR work, see slide 32 here:
https://docs.google.com/presentation/d/1xR6EFbRyCSwruXVeMYZtJfwWEbIr6U8zei8IwGG3OrA/edit#slide=id.g26be66c50c_0_86
I think we need to distinguish the extracellular with a different term, it's not the same pathway - what do you think ?
Thanks, Pascale

@pgaudet many thanks for the reminder, it's been a long time ago. In general I'm open to distinguish the extra- and intracellular pathways.
It's a mess as we have so many annotations and also phenotypes. The suggested term in the slide 'cAMP receptor signaling pathway' does not yet exist. Should this finally be created for the extracellular pathway?
Also, a related Q, you will at least understand:
You know that cAMP signaling in Dicty is in 6 min waves, so researchers often talk about cAMP waves. Car1 stimulates intracellular cAMP, through PI3K, activating ACA. Cells eventually become saturated/insensitive. Then extracellular PDE breaks down cAMP and they become sensitive again.  Very good to see in dark field microscopy. Is it worth expressing this specifically? 'cAMP wave formation', or 'cAMP signal relay organization'?
As a child of 'cAMP receptor signaling pathway'
Since I'm also updating phenotypes a lot for the UPHENO project, I'd like to get this cleaned up.
Thanks for your help with this.
Petra

@pgaudet I'd like yo move this ahead. How about
Add New: 'cAMP receptor signaling pathway'
is_a GO:0007189 adenylate cyclase-activating G protein-coupled receptor signaling pathway
"An extracellular signal transduction with cyclic AMP (cAMP) produced by a cell and then accepted by extracellular cAMP receptors on other cells, where the signal is transmitted to downstream effectors within the cell.
And maybe also  a child of 'cAMP receptor signaling pathway'
New 'cAMP signal relay'
"Cells produce cAMP and receive the cAMP signal  to produce more cAMP, alternating between cAMP sensitive and insensitive stages, resulting in CAMP relays and visible cAMP waves. An example occurs in Dictyostelium"
I can also add paper refs if we move forward with this. THANKS!!

@pgaudet I'd like yo move this ahead. How about
Add New: 'cAMP receptor signaling pathway'
is_a GO:0007189 adenylate cyclase-activating G protein-coupled receptor signaling pathway
"An extracellular signal transduction with cyclic AMP (cAMP) produced by a cell and then accepted by extracellular cAMP receptors on other cells, where the signal is transmitted to downstream effectors within the cell.
And maybe also  a child of 'cAMP receptor signaling pathway'
New 'cAMP signal relay'
"Cells produce cAMP and receive the cAMP signal  to produce more cAMP, alternating between cAMP sensitive and insensitive stages, resulting in CAMP relays and visible cAMP waves. An example occurs in Dictyostelium"
I can also add paper refs if we move forward with this. THANKS!!

this will seem a bit odd:
GO:0019933    cAMP-mediated signaling
-- GO:0007189   adenylate cyclase-activating G protein-coupled receptor signaling pathway
----GO:NEW cAMP receptor signaling pathway

this will seem a bit odd:
GO:0019933    cAMP-mediated signaling
-- GO:0007189   adenylate cyclase-activating G protein-coupled receptor signaling pathway
----GO:NEW cAMP receptor signaling pathway

cAMP mediated signaling will not be the parent. It should be a separate branch, see the top. Intra and Extracellular cAMP signaling should be separate

cAMP mediated signaling will not be the parent. It should be a separate branch, see the top. Intra and Extracellular cAMP signaling should be separate

I think the term should be a child of 'GO:0007186  G protein-coupled receptor signaling pathway', similar to 'GO:0007216  G protein-coupled glutamate receptor signaling pathway':

the term label could be G protein-coupled cAMP receptor signaling pathway'
definition: A series of molecular signals initiated by cAMP binding to its receptor on the surface of the target cell, and proceeding with the activated receptor promoting the exchange of GDP for GTP on the alpha-subunit of an associated heterotrimeric G-protein complex.
with some comments about possibly ambiguity with the cAMP signaling term

Would that work ?
Thanks, Pascale

I think the term should be a child of 'GO:0007186  G protein-coupled receptor signaling pathway', similar to 'GO:0007216  G protein-coupled glutamate receptor signaling pathway':

the term label could be G protein-coupled cAMP receptor signaling pathway'
definition: A series of molecular signals initiated by cAMP binding to its receptor on the surface of the target cell, and proceeding with the activated receptor promoting the exchange of GDP for GTP on the alpha-subunit of an associated heterotrimeric G-protein complex.
with some comments about possibly ambiguity with the cAMP signaling term

Would that work ?
Thanks, Pascale

I see.  Yes. Could this be made clearer by describing the signalling pathway as inter-cellular in the term name?

I see.  Yes. Could this be made clearer by describing the signalling pathway as inter-cellular in the term name?

You suggest GO:0019933 cAMP-mediated signaling -> intracellular cAMP-mediated signaling? Does that not complicate the label, since this is the most common case and the Dicty extracellular cAMP signaling is the exception?

You suggest GO:0019933 cAMP-mediated signaling -> intracellular cAMP-mediated signaling? Does that not complicate the label, since this is the most common case and the Dicty extracellular cAMP signaling is the exception?

Val said INTER-Cellular, but I also prefer extracellular.
@pgaudet Yes, that term, it's long but would work for Dicty. As cAMP receptor is in the term and the def is very explicit.

Val said INTER-Cellular, but I also prefer extracellular.
@pgaudet Yes, that term, it's long but would work for Dicty. As cAMP receptor is in the term and the def is very explicit.

I meant for  GO:NEW cAMP receptor signaling pathway
I just thought this might confuse people. Using a loose definition of receptor anything which binds to cAMP is a cAMP receptor (in fact PKA regulatory subunit could be described as an intracellular cAMP receptor), and there are many intracellular receptors in pathogen host interactions.
I envisage future problems if it isn't clear in the term name.

I meant for  GO:NEW cAMP receptor signaling pathway
I just thought this might confuse people. Using a loose definition of receptor anything which binds to cAMP is a cAMP receptor (in fact PKA regulatory subunit could be described as an intracellular cAMP receptor), and there are many intracellular receptors in pathogen host interactions.
I envisage future problems if it isn't clear in the term name.

OK @pfey03 got it.
What about "extracellular cAMP signaling pathway"
or "cAMP extracellular signaling pathway"
Avoiding receptor.

OK @pfey03 got it.
What about "extracellular cAMP signaling pathway"
or "cAMP extracellular signaling pathway"
Avoiding receptor.

extracellular cAMP signaling pathway"
or "cAMP extracellular signaling pathway"

But  the signaling pathway is not extracellular
Same for other formulations:

'extracellular G protein-coupled cAMP receptor signaling pathway'? but the signaling pathway is not extracellular
'G protein-coupled extracellular cAMP receptor signaling pathway' but the cAMP receptor is not extracellular

Meanwhile, I created this term:
+[Term]
+id: GO:0140582
+name: G protein-coupled cAMP receptor signaling pathway
+namespace: molecular_function
+def: "A series of molecular signals initiated by cAMP binding to its receptor on the surface of the target cell, and proceeding with the activated receptor promoting the exchange of GDP for GTP on the alpha-subunit of an associated heterotrimeric G-protein complex." [PMID:9578623]
+is_a: GO:0007186 ! G protein-coupled receptor signaling pathway
+property_value: term_tracker_item https://github.com/geneontology/go-ontology/issues/20487 xsd:anyURI
+created_by: pg
+creation_date: 2021-01-18T19:30:30Z
Does that work ?

extracellular cAMP signaling pathway"
or "cAMP extracellular signaling pathway"

But  the signaling pathway is not extracellular
Same for other formulations:

'extracellular G protein-coupled cAMP receptor signaling pathway'? but the signaling pathway is not extracellular
'G protein-coupled extracellular cAMP receptor signaling pathway' but the cAMP receptor is not extracellular

Meanwhile, I created this term:
+[Term]
+id: GO:0140582
+name: G protein-coupled cAMP receptor signaling pathway
+namespace: molecular_function
+def: "A series of molecular signals initiated by cAMP binding to its receptor on the surface of the target cell, and proceeding with the activated receptor promoting the exchange of GDP for GTP on the alpha-subunit of an associated heterotrimeric G-protein complex." [PMID:9578623]
+is_a: GO:0007186 ! G protein-coupled receptor signaling pathway
+property_value: term_tracker_item https://github.com/geneontology/go-ontology/issues/20487 xsd:anyURI
+created_by: pg
+creation_date: 2021-01-18T19:30:30Z
Does that work ?

Yes ignore my concerns. It will be fine if people read the definitions ;)
Could also add "never in fungi" (as far as we know currently!)

Yes ignore my concerns. It will be fine if people read the definitions ;)
Could also add "never in fungi" (as far as we know currently!)

Thanks @pgaudet and yes add exclusions where the def would not be true. I need to re-annotate the few that we annotated to cAMP-mediated signaling without reading the def once the term is available.

Thanks @pgaudet and yes add exclusions where the def would not be true. I need to re-annotate the few that we annotated to cAMP-mediated signaling without reading the def once the term is available.

@pgaudet
Looking at annotations that I'll need to update, I noticed a direct child also annotated:
GO:0007189 adenylate cyclase-activating G protein-coupled receptor signaling pathway
Def: The series of molecular signals generated as a consequence of a G protein-coupled receptor binding to its physiological ligand, where the pathway proceeds through activation of adenylyl cyclase activity and a subsequent increase in the concentration of cyclic AMP (cAMP).
Is_a
GO:0019933 cAMP-mediated signaling
GO:0007189 fits what happens in Dicty well and the Def doesn't violate what's in Dicty. Just true path rule is violated. Maybe this term should be moved?

There are also two PAINT annotations:
UniProtKB | P54654 | cap | involved_in | GO:0019933 | cAMP-mediated signaling | ECO:0000318 | IBA | PMID:21873635 | CGD:CAL0000183073|PANTHER:PTN000068843|PomBase:SPCC306.09c | 44689 | GO_Central |   | P
UniProtKB | Q03100 | acaA | involved_in | GO:0007189 | adenylate cyclase-activating G protein-coupled receptor signaling pathway | ECO:0000318 | IBA | PMID:21873635 | MGI:MGI:108450|MGI:MGI:87917|MGI:MGI:99673|MGI:MGI:99675|PANTHER:PTN002899368|RGD:2036|RGD:619965|RGD:619966|RGD:71014|UniProtKB:O43306|UniProtKB:O60503|UniProtKB:O95622|UniProtKB:P19754|dictyBase:DDB_G0281545 | 44689 | GO_Central |   | P

@pgaudet
Looking at annotations that I'll need to update, I noticed a direct child also annotated:
GO:0007189 adenylate cyclase-activating G protein-coupled receptor signaling pathway
Def: The series of molecular signals generated as a consequence of a G protein-coupled receptor binding to its physiological ligand, where the pathway proceeds through activation of adenylyl cyclase activity and a subsequent increase in the concentration of cyclic AMP (cAMP).
Is_a
GO:0019933 cAMP-mediated signaling
GO:0007189 fits what happens in Dicty well and the Def doesn't violate what's in Dicty. Just true path rule is violated. Maybe this term should be moved?

There are also two PAINT annotations:
UniProtKB | P54654 | cap | involved_in | GO:0019933 | cAMP-mediated signaling | ECO:0000318 | IBA | PMID:21873635 | CGD:CAL0000183073|PANTHER:PTN000068843|PomBase:SPCC306.09c | 44689 | GO_Central |   | P
UniProtKB | Q03100 | acaA | involved_in | GO:0007189 | adenylate cyclase-activating G protein-coupled receptor signaling pathway | ECO:0000318 | IBA | PMID:21873635 | MGI:MGI:108450|MGI:MGI:87917|MGI:MGI:99673|MGI:MGI:99675|PANTHER:PTN002899368|RGD:2036|RGD:619965|RGD:619966|RGD:71014|UniProtKB:O43306|UniProtKB:O60503|UniProtKB:O95622|UniProtKB:P19754|dictyBase:DDB_G0281545 | 44689 | GO_Central |   | P

We use the term
GO:0007189 adenylate cyclase-activating G protein-coupled receptor signaling pathway
for CAMP mediated signalling pathway in pombe.
This was an outcome of the work surrounding the signalling meeting in Cambridge when it was
decided that all
GO:0007189 adenylate cyclase-activating G protein-coupled receptor signaling pathway
was CAMP-mediated signalling.
I think this is correct.

We use the term
GO:0007189 adenylate cyclase-activating G protein-coupled receptor signaling pathway
for CAMP mediated signalling pathway in pombe.
This was an outcome of the work surrounding the signalling meeting in Cambridge when it was
decided that all
GO:0007189 adenylate cyclase-activating G protein-coupled receptor signaling pathway
was CAMP-mediated signalling.
I think this is correct.

https://github.com/geneontology/go-ontology/issues/13949
and
https://github.com/geneontology/go-ontology/issues/13903

https://github.com/geneontology/go-ontology/issues/13949
and
https://github.com/geneontology/go-ontology/issues/13903

maybe this term then needs to be child of both branches?
as above from @ValWood
a child of the new:
G protein-coupled cAMP receptor signaling pathway

maybe this term then needs to be child of both branches?
as above from @ValWood
a child of the new:
G protein-coupled cAMP receptor signaling pathway

@pfey03
How about if the new term was :
adenylate cyclase-activating G protein-coupled receptor cAMP receptor signaling pathway?
or maybe easier to read:
G protein-coupled receptor cAMP receptor signaling pathway, adenylate cyclase-activating?

@pfey03
How about if the new term was :
adenylate cyclase-activating G protein-coupled receptor cAMP receptor signaling pathway?
or maybe easier to read:
G protein-coupled receptor cAMP receptor signaling pathway, adenylate cyclase-activating?

I removed the relation:
GO:0007189 adenylate cyclase-activating G protein-coupled receptor signaling pathway
Is_a
GO:0019933 cAMP-mediated signaling
It's now only under 'second messenger-mediated signaling'

and here's the tree for the new term 'adenylate cyclase-activating G protein-coupled receptor cAMP receptor signaling pathway'

Does this now seem accurate ?

I removed the relation:
GO:0007189 adenylate cyclase-activating G protein-coupled receptor signaling pathway
Is_a
GO:0019933 cAMP-mediated signaling
It's now only under 'second messenger-mediated signaling'

and here's the tree for the new term 'adenylate cyclase-activating G protein-coupled receptor cAMP receptor signaling pathway'

Does this now seem accurate ?

Note that
'adenylate cyclase-modulating G protein-coupled receptor signaling pathway' 'has part' some 'cAMP-mediated signaling'
(and 'has part' some 'regulation of cAMP-mediated signaling' - which seem inconsistent)

Note that
'adenylate cyclase-modulating G protein-coupled receptor signaling pathway' 'has part' some 'cAMP-mediated signaling'
(and 'has part' some 'regulation of cAMP-mediated signaling' - which seem inconsistent)

@pfey03
I think the PAINT annotations are not great but OK ?

@pfey03
I think the PAINT annotations are not great but OK ?

I will also add a taxon constraint on the new term
GO:0140582 adenylate cyclase-activating G protein-coupled cAMP receptor signaling pathway
only in NCBITaxon:33083 | Dictyostelids

I will also add a taxon constraint on the new term
GO:0140582 adenylate cyclase-activating G protein-coupled cAMP receptor signaling pathway
only in NCBITaxon:33083 | Dictyostelids

but isn't
'adenylate cyclase-modulating G protein-coupled receptor signaling pathway
always "cAMP mediated signalling pathway"?  ...it's just 2 names for the same pathway really?
With this merge our "cAMP-mediated signalling pathway will no longer be annotated to the term "cAMP-mediated signalling". We spent a lot of time  making sure this pathway is correctly annotated during the signalling meeting and since.
see the "cAMP mediated signalling pathway" here:https://github.com/pombase/curation/issues/1699
@Antonialock

but isn't
'adenylate cyclase-modulating G protein-coupled receptor signaling pathway
always "cAMP mediated signalling pathway"?  ...it's just 2 names for the same pathway really?
With this merge our "cAMP-mediated signalling pathway will no longer be annotated to the term "cAMP-mediated signalling". We spent a lot of time  making sure this pathway is correctly annotated during the signalling meeting and since.
see the "cAMP mediated signalling pathway" here:https://github.com/pombase/curation/issues/1699
@Antonialock

'adenylate cyclase-modulating G protein-coupled receptor signaling pathway
always "cAMP mediated signalling pathway"? ...it's just 2 names for the same pathway really?

I agree. I'll create a new ticket (I cannot find any existing one)

'adenylate cyclase-modulating G protein-coupled receptor signaling pathway
always "cAMP mediated signalling pathway"? ...it's just 2 names for the same pathway really?

I agree. I'll create a new ticket (I cannot find any existing one)

I see that in the def of
GO:0019933    cAMP-mediated signaling
is

Definition
Parents

Any intracellular signal transduction in which the signal is passed on within the cell via cyclic AMP (cAMP). Includes production of cAMP, and downstream effectors that further transmit the signal within the cell.

I assumed the production of camp includes receptor to adenylate cyclase?
So now we would need to annotate to both
'adenylate cyclase-modulating G protein-coupled receptor signaling pathway
and
cAMP-mediated signalling"
So we are back to the problem of multiple orthogonal ways to describe the same pathway (the pathway is also commonly called "glucose-mediated signalling".)
Maybe cAMP mediated signalling is broader? (anything that operated "via" cAMP
https://jcs.biologists.org/content/114/11/1971
I think we are tying ourselves in knots trying to annotated to signalling pathway terms. We need a different solution!

I see that in the def of
GO:0019933    cAMP-mediated signaling
is

Definition
Parents

Any intracellular signal transduction in which the signal is passed on within the cell via cyclic AMP (cAMP). Includes production of cAMP, and downstream effectors that further transmit the signal within the cell.

I assumed the production of camp includes receptor to adenylate cyclase?
So now we would need to annotate to both
'adenylate cyclase-modulating G protein-coupled receptor signaling pathway
and
cAMP-mediated signalling"
So we are back to the problem of multiple orthogonal ways to describe the same pathway (the pathway is also commonly called "glucose-mediated signalling".)
Maybe cAMP mediated signalling is broader? (anything that operated "via" cAMP
https://jcs.biologists.org/content/114/11/1971
I think we are tying ourselves in knots trying to annotated to signalling pathway terms. We need a different solution!

I think we are tying ourselves in knots trying to annotated to signalling pathway terms. We need a different solution!

I agree. Please move the discussion to https://github.com/geneontology/go-ontology/issues/20712

I think we are tying ourselves in knots trying to annotated to signalling pathway terms. We need a different solution!

I agree. Please move the discussion to https://github.com/geneontology/go-ontology/issues/20712

OK, but I don't think you can make the existing "cAMP-mediated signalling" a has_part of GO:0007189 because the annotations don't fit...

OK, but I don't think you can make the existing "cAMP-mediated signalling" a has_part of GO:0007189 because the annotations don't fit...

OK, right now there is no connection between
GO:0019933 cAMP-mediated signalling and
GO:0007189 adenylate cyclase-activating G protein-coupled receptor signaling pathway

OK, right now there is no connection between
GO:0019933 cAMP-mediated signalling and
GO:0007189 adenylate cyclase-activating G protein-coupled receptor signaling pathway

@pascale, it was a lot to read up this morning. The only qualms I have is that I don't like these very long terms and
"adenylate cyclase-activating G protein-coupled receptor cAMP receptor signaling pathway" is such a term. Although of course it fits Dicty. Is this  GO:0140582?  Need to spend more time with this but trust you do the right thing.

@pascale, it was a lot to read up this morning. The only qualms I have is that I don't like these very long terms and
"adenylate cyclase-activating G protein-coupled receptor cAMP receptor signaling pathway" is such a term. Although of course it fits Dicty. Is this  GO:0140582?  Need to spend more time with this but trust you do the right thing.


Computational to non-uniform mapping for gyrokinetic simulations

Associated DR #546. This has included 8 regression tests in mapc2p, tokamak and mirror geometry. There is a unit test for the zero/position_map.c functionality. Tests have been successfully completed on CPU, GPU, multi-CPU, and multi-GPU. The tests are valgrind clean, although the STEP unit tests are not valgrind clean on gk-g0-app.
Make a non-uniform map with STEP and show how it deforms the map.
Show a WHAM mapping
Cartesian with more cells near z walls (gk-sheath)

Test the root finding map more. Test 2x and 3x wham. Make plots of the magnetic field. Check with a mirror not located at pi/2.

Here is an example of the non-uniform map working on the STEP geometry to minimize the magnetic field variation.

Here is a non-uniform map for WHAM that makes dB/dTheta = constant


Is it possible to provide features like downloading attachments?

Is it possible to provide features like downloading attachments?
Is it possible to configure my own server using mailsac open source with my own domain and then have some option to download or see attachments?
Thanks!

@rahulmr mailpraser does the job, but this is something awaits for implementation, maybe v2?

Thanks for the update. Please do let me know once you have implemented it in v2 :)

Sorry guys I have been tied up and keep meaning to give mailsac love to release the latest. but that has not happened. If you need a quick-and-dirty way to grab attachments:
https://github.com/ruffrey/mailsac/blob/master/lib/mailserver.js#L117
after mailparser gets it, the attachments might be sitting right there as base64, but we are (at this time) intentionally dropping them. you could insert them into mongodb as a base64 then do the work to render them on your end. From an express route, something like: res.set('content-type', 'whatever/attachment-type'); res.send(new Buffer(attachmentAsBase64, 'base64')).

Thanks but I am just an end user :( so do not know how to do what you have suggested. Where to put the res.set on which line etc. Sorry.

@ruffrey it seems code is changed now. Could you please suggest a better way to get the attachment? Thanks


Commiting all the existing stuff I wrote.

just flicked through it. this is shaping up to be really valuable!


Vision only Apollo system (Apollo Lite)

Where is apollo lite? Has it been released? Will it get released on GitHub? Currently, you can't run apollo on cameras alone correct? Just curious, Thank you. Can you run 6.0 on cameras and ultrasonic only?

Looks like someone already asked this. Thanks

What was the answer to that question?


Feature request: add exception handlers return types to OpenAPI responses

Use case
I use an API Gateway event handler with validation enabled and I'd like exception handlers response types to be automatically add to the openAPI schema. I can add responses parameter to my endpoint definition, however it's not ideal as it adds a lot off repetition, duplication and introduce potential for incorrect openAPI schemas.

Alternative solutions
No response
Acknowledgment

[X] This feature request meets Powertools for AWS Lambda (Python) Tenets
[ ] Should this be considered in other Powertools for AWS Lambda languages? i.e. Java, TypeScript, and .NET

Hi @ThomasLeedsLRH! Thanks for opening this issue and bringing this suggestion.
I don't think we should include exception_handler in the OpenAPI schema. The exception_handler feature is intended to catch general/custom Python exceptions, not define the responses in the OpenAPI schema. I realize there may be some overlap between these features, and the code may get repetitive if you define both, but if we assume we always should include exception_handler in the OpenAPI schema, we may be defining unwanted behavior for some routes that want to treat exceptions in a different way.
I will leave this issue open to hear more from you and other customers.

Hi @leandrodamascena,
my issue is quite similar to this one, so I decided to comment here instead of opening a new issue.
The problem is that the "Validation Error" response is always included in the OpenAPI schema (primarily due to this code), which can lead to incorrect documentation generation when using @app.exception_handler(RequestValidationError).
In my case, I want to return validation errors with a 400 status code and in a different format, like this:
{
    "error": {
        "statusCode": 400,
        "message": "Invalid request parameters",
        "description": {
            "body.user_email": "Field required"
        }
    }
}

To achieve this, I am using a custom exception handler and a custom class:
def validation_error_description(exc: RequestValidationError):
    """
    Extracts and formats validation error messages from a RequestValidationError.
    It creates a dictionary where each key represents the location of the validation error
    in the request (e.g., "body.email"), and the corresponding value is the error message.

    Args:
        exc (RequestValidationError): The exception raised during request validation.

    Returns:
        dict: A dictionary containing detailed descriptions of each validation error.

    """
    error_description = {}

    for error in exc.errors():
        # Creating a string representation of the location (path) of each error in the request
        field = ".".join([str(elem) for elem in error["loc"]])
        # Mapping the error location to its message
        error_description[field] = error["msg"]

    return error_description

class ExceptionHandlers:
    """
    A class to handle common exceptions for AWS Lambda functions using AWS Lambda Powertools.

    Attributes:
        app (LambdaPowertoolsApp): An instance of the LambdaPowertoolsApp.
        logger (Logger): An instance of the Powertools Logger.

    """

    def __init__(self, app, logger=None):
        self.app = app
        self.logger = logger or Logger()

    # 400 Bad Request
    def invalid_params(self, exc):
        """
        Handles RequestValidationError exceptions
            by logging the error and returning a custom Response.

        Args:
            exc (RequestValidationError): The exception object.

        Returns:
            Response: A custom response with a status code of 400, indicating a bad request.

        """
        if exc.__class__.__name__ == "TypeError" and "JSON object must be" in str(exc):
            error_description = {"body": "Invalid or empty request body"}
        else:
            if isinstance(exc, RequestValidationError):
                error_description = validation_error_description(exc)
            else:
                error_description = str(exc)

            self.logger.error(
                f"Data validation error: {error_description}",
                extra={
                    "path": self.app.current_event.path,
                    "query_strings": self.app.current_event.query_string_parameters,
                },
            )

        return Response(
            status_code=HTTPStatus.BAD_REQUEST.value,
            content_type=content_types.APPLICATION_JSON,
            body={
                "error": {
                    "statusCode": HTTPStatus.BAD_REQUEST.value,
                    "message": "Invalid request parameters",
                    "description": error_description,
                }
            },
        )

...
exception_handlers = ExceptionHandlers(app=app)
...
@app.exception_handler([RequestValidationError, ValidationError, ValidationException])
def handle_invalid_params_wrapper(exc):
    return exception_handlers.invalid_params(exc)

However, when I generate the OpenAPI schema, I have to manually add the 400 response to each of my routers:
@router.get(
    "/user/<id>",
    summary="Get user data",
    responses={
        200: {...},
        400: {
            "description": "Bad request",
            "content": {"application/json": {"model": BadRequestResponse}},
      },
    ...

But I also end up with a 422 response in my OpenAPI schema, which shouldn't be there:

Ideally, I would like to be able to reuse response models from exception_handler without having to define them for each router.
At the very least, the 422 response should not be added to the OpenAPI, as it can be overridden.

Hi @Hatter1337! Sorry I completely missed this comment! I'm adding it to my backlog to respond to this week, okay?

Hi @Hatter1337! Sorry I completely missed this comment! I'm adding it to my backlog to respond to this week, okay?

Sure, thank you

Hi @leandrodamascena, sorry for checking up but is there any update on this?


Q: Why does user_created contain data and other events do not?

I noticed that the user_created event has a data field that is an object that contains the user data.
However, when I send any other event, using POST /client/events, the resulting event in the user details view has no data field, although I passed it. The data is merged into the other fields of the event, instead.
Is this a coincidence, or is it by design?

It's passed in a copy of the user object so the structure is mimicking how events and users store the majority of their keys under data. We kinda obfuscate that that is happening in most of the UI since its not something the user should need to care about (they should just be able to assume that all properties exist at the same level). In that vein I think it would probably make sense to expand the data object on the user

The reason why I am asking is that I have problems to correctly trigger on events.
I want to create an entrance in a journey that triggers on a field inside the event. It looks like on all events except user_created I have to write $.field. On user_created I have to write $.data.field.

This should be resolved in the next release 👍🏻


How do I completely disable heirline winbar for some filetypes?

I have this code:
local winbar = {
        condition = function()
            return conditions.buffer_matches({ filetype = { "toggleterm", "Trouble" } }) == false
        end,
        BufferComponent,
        ExplorerComponent,
        Navic,
    }

which kinda works? here is an example(I highlighted the window separator for better visibility):

There is empty space between the Window Separator and the Window content itself which indicates that a winbar is meant to go there.

See instructions at https://github.com/rebelot/heirline.nvim/blob/master/cookbook.md#winbar

Just a note, if you prefer using an autocmd, to remove winbar for terminals you need a TermOpen autocmd

@rebelot oh so I need to add an autocmd + the winbar conditions?

@rebelot thank you!


Support for rfc6598 space in IPv4Network/Address.is_private

What steps will reproduce the problem?
1. ipaddr.IPv4Network('<IP_ADDRESS>/24').is_private == False

What is the expected output? What do you see instead?

Given RFC6598, <IP_ADDRESS>/10 is now approved for use as CGN space, and also for
rfc1918-like private usage. Could the code to altered so that is_private will
return true for <IP_ADDRESS>/10 as well??

What version of the product are you using? On what operating system?

all versions.. Ubuntu

Please provide any additional information below.

<IP_ADDRESS>/24: is_private=False
<IP_ADDRESS>/24: is_private=True
<IP_ADDRESS>/24: is_private=True
<IP_ADDRESS>/24: is_private=True
<IP_ADDRESS>/24: is_private=False
<IP_ADDRESS>/24: is_private=False

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 1 Mar 2013 at 12:29

I can see either side here; CGN is like private space, but also unlike it.  I'm going to say this should stay as it is, for consistency with past versions and with ipaddress.