update react-scripts from 4 to 5

What does this PR do and why?
What:
This PR takes the first step of updating the project's react-scripts. This is the output of running yarn add --exact<EMAIL_ADDRESS>I found this command in the changelog: https://github.com/facebook/create-react-app/blob/main/CHANGELOG.md
Notes:

this diff shouldn't be landed on its own but with the entire stack. Just running the single command above will leave the code base in a broken state.
The lock file change is so big because CRA react-scripts@5 uses webpack@5 under the hood which drops all polyfills that the project used.
I'll continue to update my PRs as they're marked ready for review. There was significant concern about using re-wired in #712, which I'll address in that diff/PR.

Why:
#712 because we need to upgrade the project.
How:
Stacked Diffs: You'll see in the autogenerated comment below this that the following set of PRs are 'diffs' that are stacked on top of one another. Instead of each PR depending on main, they depend on each other, one on top of the other in sequence.
Why Stacked Diffs:
Each diff is a single action in isolation, which makes each PR focused on a single problem or action. It's a pretty well-established way of working. Engineers at FB, Google, Airbnb and other big tech companies have been doing it for years. In my current role, we use Phabricator (https://www.phacility.com) which is a bit dated. Graphite (http://graphite.dev which is used to create this stacked diff is the modern version of phabricator that's built for GitHub.
It's a pretty common feature request of Github https://twitter.com/dan_abramov/status/1519020234316955650?s=20&t=wgrt4HlYmbfyKSGe1VkQfw (a common request of @gaearon too)
Here's a bit more documentation on stacked diffs if you're interested:

https://docs.graphite.dev/getting-started/why-use-stacked-changes
https://graphite.dev/blog/post/DThX8ffP1gmxWJChEv0y
https://graphite.dev/blog/post/N8SOs49y4bYdV1Vjf5qE

Screenshots or screen recordings
N/A
Acceptance checklist

[x] I have evaluated the Approval Guidelines for this PR.
[x] I have tested this PR in all supported browsers.

Current dependencies on/for this PR:

main

PR #867   (this PR)

PR #868

PR #869

PR #870

PR #871

This comment was auto-generated by Graphite.

Big advocate of stacked diffs/chained PRs. Thanks @benschac, will review!

@benschac heads up - I'm not going to get to this until next week. I've had a quick skim though and it looks really promising. Thanks a ton for diving into this 🙏

No worries, I wasn't planning on updating this stack until the weekend. Which, I should have communicated more directly here.
Ty for the heads up.

@benschac can't thank you enough for your work here.
After reviewing these PRs and familiarizing myself with the CRA 5/polyfill status quo, it feels like moving forward with Rewire isn't as big of a commitment as I first thought. Correct me if I'm wrong, but it looks like, if CRA ever does decide to re-add support for those core node modules, we can quite easily strip out rewire and start using react-scripts to build the project again.
By committing to this though, we are still diverting from the out-of-the-box solution, which will naturally incur some maintenance overhead going forward (with more deps to keep track of and such). We're also becoming dependent on an "unofficial" tool, which despite being very well maintained, might prove to cause headaches down the road.
My only question at this point is: what are we gaining from webpack 5/ CRA 5? Are the benefits meaningful enough to warrant the above? I'm okay with staying with CRA 4 for the foreseeable future unless there is a compelling reason to upgrade. But if there are compelling reasons to upgrade, your proposed approach in these PRs is certainly the approach we should take 👍  LMK

After reviewing these PRs and familiarizing myself with the CRA 5/polyfill status quo, it feels like moving forward with Rewire isn't as big of a commitment as I first thought. Correct me if I'm wrong, but it looks like, if CRA ever does decide to re-add support for those core node modules, we can quite easily strip out rewire and start using react-scripts to build the project again.

Yes. Additionally, CRA needs a way to import polyfills now that webpack@5 no longer ships them by default. So, we'd have a similar setup to what we have done in this diff stack either way.

My only question at this point is: what are we gaining from webpack 5/ CRA 5? Are the benefits meaningful enough to warrant the above? I'm okay with staying with CRA 4 for the foreseeable future unless there is a compelling reason to upgrade. But if there are compelling reasons to upgrade, your proposed approach in these PRs is certainly the approach we should take 👍 LMK

Yes, looking at the changelog I think it's worth keeping up to date with these deps and getting perf gains. I don't just think it's a react-scripts thing though. We'd get bit by the same issue, if there's a package we needed to use in react-scripts@4 that needed a webpack configuration.
https://github.com/facebook/create-react-app/blob/main/CHANGELOG.md#full-changelog
Webpack@5 is the biggest change: https://webpack.js.org/blog/2020-10-10-webpack-5-release/

Improve build performance with Persistent Caching.
Improve Long Term Caching with better algorithms and defaults.
Improve bundle size with better Tree Shaking and Code Generation.
Improve compatibility with the web platform.
Clean up internal structures that were left in a weird state while implementing features in v4 without introducing any breaking changes.
Prepare for future features by introducing breaking changes now, allowing us to stay on v5 for as long as possible.

Debugging:

https://github.com/facebook/create-react-app/pull/8227

These are just my two cents. I'm not married to this solution and would be just fine abandoning this stack if the team feels like waiting is a better solution too. webpack@5 has been out for 2 years now and is pretty battle tested. re-wired looks like it has a lot of community support and large projects like web3.js are instructing users to use it directly in their documentation.
I'm not saying this implementation won't cause issues down that road, just that other teams and projects suggest this path and it seems fine.

@benschac thanks for the detailed response. I'm on board. LFG.
How would you like to proceed? Shall we merge the PR chain from top to bottom into a single PR, test this PR, and merge it to main?

cc @peripheralist @johnnyd-eth in case there are any concerns you have

@benschac thanks for the detailed response. I'm on board. LFG.
How would you like to proceed? Shall we merge the PR chain from top to bottom into a single PR, test this PR, and merge it to main?

Yeah, I can merge them all together. Graphite has a merge feature but we'd need to add the graphite app to the repo. I'm not sure if folks want to do that.

I still need to fix the tests. Please hold off on reviewing this PR for the moment.

Could I get access to fleek? I thought the easiest / and most logical path forward to fixing the failing CI tests would be to upgrade jest. Which, fixed the tests, but broke fleek's build and CI. I'm getting a 404 when clicking any of the fleek links.

Could I get access to fleek? I thought the easiest / and most logical path forward to fixing the failing CI tests would be to upgrade jest. Which, fixed the tests, but broke fleek's build and CI. I'm getting a 404 when clicking any of the fleek links.

@benschac ah gotcha. Unfortunately I think we've filled all of our Fleek seats, potentially @peripheralist can help check this.
In any case, here's the deploy log:
Deploy started at 4:33:50 AM 05/16/2022

4:33:51 AM 05/16/2022: Deploy started
4:33:53 AM 05/16/2022: Docker image: 'fleek/create-react-app'
4:33:53 AM 05/16/2022: Build command: 'yarn && yarn build'
4:33:53 AM 05/16/2022: Triggering build execution...
4:34:49 AM 05/16/2022: yarn install v1.22.5
4:34:50 AM 05/16/2022: [1/4] Resolving packages...
4:34:51 AM 05/16/2022: [2/4] Fetching packages...
4:36:00 AM 05/16/2022: info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
4:36:00 AM 05/16/2022: info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
4:36:00 AM 05/16/2022: info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
4:36:00 AM 05/16/2022: info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
4:36:00 AM 05/16/2022: error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0". Got "16.4.2"
4:36:01 AM 05/16/2022: error Found incompatible module.
4:36:01 AM 05/16/2022: info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
4:36:25 AM 05/16/2022: Error occured during the build.

So, I'm at a stopping point with this one. I've got tests and linting working both locally and on CI. Fleek continues to be a black-box, I don't really have any way of knowing what's going on there without seeing how the project is configured.
Next steps:

Is there a way for me to get access to fleek?
Is it possible for someone on the core team to take a look and debug it @aeolianeth @peripheralist @johnnyd-eth @wraeth-eth
Is it possible for me to get the exact configuration of fleek? I can fork the repo with my branch, debug on my end and come back with changes that need to be made on fleek
Could I pair with someone on core, and we can take a look together?

I don't think it should be too time-consuming but I don't think I have enough information to complete this tasks ATM.

@aeolianeth is there anything we can do to help unblock @benschac here? I am a bit out of loop with the status of the fleek stuff, but is it possible (if we can't get more permissions) to get someone to have a look at fleek and see why this is failing?

@aeolianeth is there anything we can do to help unblock @benschac here? I am a bit out of loop with the status of the fleek stuff, but is it possible (if we can't get more permissions) to get someone to have a look at fleek and see why this is failing?

@wraeth-eth we've given @benschac Fleek access and he'll be tackling it this weekend 💪 https://discord.com/channels/939317843059679252/939705688563810304/978992950522572830

Closing in favor of https://github.com/jbx-protocol/juice-interface/pull/1135

@benschac thanks so so much for your hard work here.
Because we're moving to Next soon, I think we can stay on react-scripts@4 for now.
I've picked everything except for the rewired stuff into https://github.com/jbx-protocol/juice-interface/pull/1135
Closing this PR in favor of https://github.com/jbx-protocol/juice-interface/pull/1135


Cannot set property after zp update

Hey! I’ve updated the plugin to the last version and now my players don’t load, only 1 of 3 after a while. The rest is unreachable while no change is made in the speakers or ip’s.

What version did you upgrade from?
Could you please capture and attach a debug log file?  See https://github.com/ebaauw/homebridge-zp#debug-log-file.

homebridge.log
Does this help?

I've updated from the last most recent version to the new V1.0.32. Zoneplayer app and sonos app see all speakers correctly, it's just the homebridge plugin that doesn't see them correctly. After a while my "Bar" zone/speakers pops up, but the rest doesn't

Does this help?

Sorry, will have to wait till this evening to look at it - work's calling.

A TypeError surely is a bug, but in this case just a symptom of an underlying problem, I'm afraid.  I see an awful lot of other error messages (from other plugins), indicating network connectivity issues.  I need the debug log messages (from homebridge -D) to understand what's happening.  I think Homebridge ZP receives incomplete info from the zone players.
Could you capture the output of zp -H <IP_ADDRESS> topology -v?  If that also causes an error, could you try DEBUG=* zp -H <IP_ADDRESS> topology -v.  This will produce a ludicrous
amount of debug messages.

The other errors come from Homebridge tv’s, they always give those errors when switched off. Network is all fine, 420mbit continuous without downtime. Sonos is playing non stop too without any problem. But i’ll try the commands and will upload The file

Naamloos.docx

That's not the full output.  Also what were you thinking creating a Word file for this?!
Looks like the Sub for the Bar is missing from the topology, but still mentioned in the channel map.  Does it appear in the Sonos app?

Network is all fine, 420mbit continuous without downtime.

I meant your local network, not your Internet connection.

It started working again, i've used the homebridge-sonos plugin in the meantime, that worked fine from the start. And after the last nodejs update your plugin worked fine again too. Sorry that i ain't a tech expert. I just try to give what you've asked for, no need to get offended here for just me trying...

It started working again

That's good.

And after the last nodejs update your plugin worked fine again too.

I don't think the error has anything to do with any version update.  I (hopefully) fixed the TypeError, but cannot fix the missing zone player.

Fix for TypeError in v1.0.34.


Fixing null check bug causing sign-in issues

@jplafonta,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


hay I'm having issue with npm start

My webpage is not showing any graphical data after pressing "Start Streaming Data"

My vs code is also showing 6 problems with Graph.tsx

please help

My webpage is not showing any graphical data after pressing "Start Streaming Data"

My vs code is also showing 6 problems with Graph.tsx

please help

Please share the full screen of the file Graph.tsx


Update Readme.md

add proper instructions to azd up (currently its not running locally)
fix the paths - to install the requirements.txt and run the app.py - needs to be from src folder
add screenshots from app

[ x] - add proper instructions to azd up (currently its not running locally)
[ x] - fix the paths - to install the requirements.txt and run the app.py - needs to be from src folder
[ ] - add screenshots from app

done


Feat: Recording Saving

Describe the feature
@SUGAM-ARORA I want to add an option for recording to be saved in the speed option. Kindly assign me this issue.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Ojas-Arora Issue assigned to you . Made the required changes in the code but the recording won't be save till backend is there.


invalid parameters name

Currently i get "OrgLCID" (not documented) and "UserLCID" (case does matter) parameters for HTML web resource added to UCI form as web resource

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 31cb0712-bb15-0627-02bd-3873d21c327f
Version Independent ID: 08f51d50-5422-a7bb-a11c-022c278e7a0c
Content: Use IFRAME and web resource controls on a form
Content Source: ce/developer/use-iframe-and-web-resource-controls-on-a-form.md
Service: crm-online
GitHub Login: @JimDaly
Microsoft Alias: jdaly

Thanks for your feedback. We are closing this issue because we are either unable to find relevant information or reproduce this. If you're still experiencing the issue described here, please reopen or create a new issue.


Dazfuller/adf selfhosted ir java

At the moment, if the documentation is followed then a self-hosted IR environment will not be able to generate files which require Java for generation (Parquet, ORC, Avro). To ensure that this works JRE8 is required along with the VC++ 2010 Redist package. I've validated this through the deployment of a number of self-hosted IR environments and others have encountered these issues.

@dazfuller : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@nabhishek as it says in the update, this is if you want to copy data to Avro, ORC or Parquet, the self-hosted IR won't be able to use the JRE unless the C++2010 runtime is installed (this is the link in the description of the PR)
I was adding here as I've gone through this a number of times with customers at fortune 100 companies who have fallen into this issues and haven't been able to find the document I'm linking out to. Plus the C++ 2010 runtime is an obscure issue which often takes a long time to Google to resolve.
I can add to other documents if needed though

#sign-off


Setup kanban board Pull request

Hello there, 👋
In this project, we have a team of four individuals working collectively.
Here is our Project
Below is a screenshot of our board

Hi @HERMON-1995,
Wow, you did it 🎉

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
To highlight

All cards have been assigned, pointed, and have descriptions.✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Sliders feedback

[ ] The slider thumbs (the draggable part) feel like they might be a bit small, especially in the disabled state
[ ] The disabled thumb needs a "stroke" of background color surrounding it to make it stand out from the slider line (you should be able to see this in the spec images)
[ ] The thumb should enlarge when it's being dragged

Above, blue is from the spec.  Purpose is from Flutter.


SSD1327 IOError: [Errno 6] No such device or address

Type of Raspberry Pi

NanoPi Core2
Linux Kernel version
Linux PD2 4.14.111 #2 SMP Tue Apr 30 16:04:14 CST 2019 aarch64 aarch64 aarch64 GNU/Linux
Expected behaviour
I've been using an SSD1306 without any problems and I have changed to an SSD1327.
I've updated the luma.core to 1.10.1:
pi@PD2:~$ pip list | grep luma
luma.core (1.10.1)
luma.oled (3.2.1)

When trying to initialise the screen I get this:
pi@PD2:~$ python
Python 2.7.12 (default, Nov 12 2018, 14:36:49)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from luma.core.interface.serial import i2c
>>> from luma.oled.device import ssd1327
>>> serial = i2c(port=0, address=0x3c)
>>> display = ssd1327(serial)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/luma/oled/device/__init__.py", line 651, in __init__
    nibble_order=1, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/luma/oled/device/greyscale.py", line 34, in __init__
    self._init_sequence()
  File "/usr/local/lib/python2.7/dist-packages/luma/oled/device/__init__.py", line 663, in _init_sequence
    0xA8, 0x7F)         # set multiplex ratio: 127
  File "/usr/local/lib/python2.7/dist-packages/luma/core/device.py", line 39, in command
    self._serial_interface.command(*cmd)
  File "/usr/local/lib/python2.7/dist-packages/luma/core/interface/serial.py", line 85, in command
    list(cmd))
  File "/home/pi/.local/lib/python2.7/site-packages/smbus2/smbus2.py", line 482, in write_i2c_block_data
    ioctl(self.fd, I2C_SMBUS, msg)
IOError: [Errno 6] No such device or address

Thanks.

Ignore the issue. I will close it.
Seems to be a hardware problem on the bus with the new devices that I have installed.
Thanks.

I was going to ask whether the NanoPi core 2 has built-in pull-up resistors on the I2C data and clock lines. If not, you may want to add a 10K pull-up resistor on each line.

The NanoPi doesn't but the display is connected through an add-on board that has the pull ups. As a matter of fact both the screen and the other GPIO extender boards have their own pull ups. So I removed the pair from the screen but that did not solve the problem. In the end II have separated the GPIO and the screen and I have tested only with the screen. That works fine.
So I will continue to see where the problem is. I have another GPIO board that I can test separately independent on the screen and then try again all of them on the same bus. There are a few other hacks that I did on the boards - I might have screwed up something - although I've triple checked and nothing seems to be a problem.
Thing is, the luma.oled is working fine.
Thanks for the work, and for sharing it by the way.


recipes-openamp: rpmsg-examples: Use latest commit

Latest commit updates usage of driver unload/load in rpmsg-kernel-space apps
Signed-off-by: Ben Levinsky<EMAIL_ADDRESS>

CC @arnopo  @mhatle  @TanmayShah-xilinx

Looks fine to me.  I have not done a test build for this but am OK to merge anyway

Since the commits that this point to are reviwed and merged by @arnopo I am OK with this being merged.
If there is any objection please speak up.
Otherwise I will merge it tomorrow Feb 15.

I've merged it.. thanks for the reviews.


The Package Does Not Respect The Current Theme

I'm running the Unity Dark UI theme but this package does not use its styling:

I don't know if a change has been made, but it's respecting my theme (see screenshots for #20)


Azure Storage Explorer - Cannot connect to IoT Edge Local Blob Storage

Storage Explorer Version: 1.14.2
Build Number: 20200715.2
Platform/OS: Windows 10 Professional
Architecture: x64
Regression From:  unsure
Bug Description
Storage Explorer throws exception when navigating to Blob Containers and File shares.
Steps to Reproduce
Installed Azure IoT Blob on Ubuntu 18.04 server per https://docs.microsoft.com/en-us/azure/iot-edge/how-to-deploy-blob
Docker is up and running and reported in IoT Edge

Set up a connection in Azure Storage explorer using account name and Key.
IOT Edge device can be pinged.
Navigating to Blob Containers/File containers throws errors. Ditto with Table/Queue
issue_file_container.txt
issue_blob_container.txt

issue_queue.txt
Expected Experience
Since ping/docker is all reporting OK, I would expect this to connect to IoT Edge Local Blob Storage.
Actual Experience
Clicking/expanding on the containers throws errors as outlined in the attached text files.
Additional Context
Reference for deploying Blob storage taken from here. https://docs.microsoft.com/en-us/azure/iot-edge/how-to-deploy-blob
Occaisionaly get "account has been disabled" message.

For reference I am also adding the deployment manifest json file
deployment.manifest.txt

@seshagc What is the connection string you used in Storage Explorer to connect to blob storage container? Side note - only "Blob Containers" option should work.

https://localblobstorage.blob.core.windows.net
I have a windows host. I have an Ubuntu Box running on Vagrant and local blob storage is created on this Ubuntu box.

@SeshagiriSriram This doesn't seem correct. Plese follow these instructions: https://docs.microsoft.com/en-us/azure/iot-edge/how-to-store-data-blob#connect-to-your-local-storage-with-azure-storage-explorer

Closing due to lack of response from issue opener. Please open a new issue if you still need help.


chore(jql-parser): switch to winnow

Why -> https://docs.rs/winnow/latest/winnow/_topic/why/index.html
Another potential benefit is the performance 🚀

If you feel up to it, I'd love to hear an experience report of using winnow.  This was done by the hcl-edit author (here) and it was a big help
Example topics

What helped out compared to past parser experience
What got in the way
What was confusing
Any suggestions for making things more obvious
Any thoughts on further improving naming

Thanks again @epage, I've created a follow-up PR based on your awesome feedback :).
N.B.: since the parser gets its input from Clap as query, I'm not sure if converting it to &[u8] is a good move or not (though the CLI also accepts to read the query as query_from_file but that not the main usage).

N.B.: since the parser gets its input from Clap as query, I'm not sure if converting it to &[u8] is a good move or not (though the CLI also accepts to read the query as query_from_file but that not the main usage).

The source doesn't matter (for toml_edit we call as_bytes() on a &str).   You will need to re-validate any &[u8] you get out to convert it to &str.  For toml_edit, whenever the grammar is ASCII only, I use unsafe to bypass the validation.  Depending on you aversion to unsafe and the cost of that validation, I'm not sure how much of a gain it will be.


Fix non-import loading of MailSlurp package

When using the MailSlurp package in a non-babel/non-typescript environment, I get the following error during the constructor process:
TypeError: MailSlurp is not a constructor
I've faced this issue in the past, and the answer is to use the .default property (alternatively, it looks like .MailSlurp would work as well).

Thanks again @klamping !


renderers_and_plotly_chart - Direct Performance and Net Worth Plotting - AttributeError: 'collections.OrderedDict' object has no attribute 'plot

I run with same error, cannot plot any picture.

Try this one:
performance = pd.DataFrame.from_dict(env.action_scheme.portfolio.performance, orient='index') performance.plot()

Try this one:
performance = pd.DataFrame.from_dict(env.action_scheme.portfolio.performance, orient='index') performance.plot()

thank u. :)

Fixed in https://github.com/tensortrade-org/tensortrade/commit/2c5cb65b022351fefcc5b3a6f9e88a837d2edec4
sorry for the delay :)


Support Razer local dimming switch on/off.

Due to miniled error, some devices will be dimmed like the video below. Can you add the feature that can switch on and off local dimming?
https://www.youtube.com/watch?v=1Ce3IxPp0AU

I'm looking to implement the local dimming switch from the blade 2024 into the blade 2023. Since both of them use the same panel with the same issues with miniled but Razer chose to exclude the button for 2023 model is outrageous.


refactor: readonly struct properties and hide internals

This change upgrades the repo to jsii 0.8.0 which requires that all struct types (data interfaces like our "Props" interfaces) will be marked readonly in order to ensure they can be passed by-value.
The new jsii version also hides all members marked as @internal which means that those APIs will not be available from outside the framework.
Fixes awslabs/cdk-ops#321
BREAKING CHANGE: stack._toCloudFormation method is now unavailable and is replaced by @aws-cdk/assert.SynthUtils.toCloudFormation(stack).

Pull Request Checklist

[x] Testing

Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
CLI change?: coordinate update of integration tests with team
cdk-init template change?: coordinated update of integration tests with team

[x] Docs

jsdocs: All public APIs documented
README: README and/or documentation topic updated

[x] Title and Description

Change type: title prefixed with fix, feat will appear in changelog
Title: use lower-case and doesn't end with a period
Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

[x] Sensitive Modules (requires 2 PR approvers)

IAM Policy Document (in @aws-cdk/aws-iam)
EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

What is the new/correct way to modify Props after creating the object?
I use this currently to set fields conditionally after creating the object with my shared config:
e.g. https://github.com/taimos/cdk-constructs/blob/master/lib/alexa/skill.ts#L57

@hoegertn not sure what this line points at :-)

Sorry, I changed it already. Here is the link to the revision: https://github.com/taimos/cdk-constructs/blob/e2279f2bcc004374dcbba5c14be61dd78ab30158/lib/alexa/skill.ts#L56
I changed it in master, but I am not really happy with the code.

@eladb since the attributes are readonly now, could you share a recommended way to modify/dynamically create Props objects?

See https://github.com/awslabs/aws-cdk/pull/2372

Thanks!


Generating builders for classes

Hi!
Previously I was using maven-jaxb2-plugin from org.jvnet.jaxb2.maven2 but after upgrading to Spring boot 3.0.6 I can't use it anymore. So I changed to this, but then jaxb2-rich-contract-plugin does not work. I was using it to generate builders. Does it have a version that's compatible with this library? Understandable if you don't know, just thought to shoot out the question before I rebuild it myself.

Sorry, never used that plugin myself - sorry.
I am using https://github.com/phax/ph-jaxb-plugin :)

Yes correct - it doesn't create builders.
Are you referring to https://github.com/mklemm/jaxb2-rich-contract-plugin?

Okok. Yes exactly
mån 8 maj 2023 kl. 18:02 skrev Philip Helger @.***>:

Yes correct - it doesn't create builders.
Are you referring to https://github.com/mklemm/jaxb2-rich-contract-plugin?
—
Reply to this email directly, view it on GitHub
https://github.com/phax/maven-jaxb2-plugin/issues/12#issuecomment-1538507630,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACA4CVE4HL66BQP5E6GUIRDXFEDIZANCNFSM6AAAAAAX2AVNIQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Med vänlig hälsning,
Rasmus Kockum

@razum90 does it still a need of yours to have xjc plugin builder support of jakarta ?

@razum90 jaxb4 support is out for maven-jaxb2-plugin in highsource jaxb-tools
You'll be able to use Fluent API plugin with it
Please check migration guide also if needed

Please use https://github.com/highsource/jaxb-tools for all remaining issues on that topic. Thanks :)


Reference indexing fails when a ParentalKey relation is masked by a property of the same name

Developers will often set ParentalKey to point to the base Page model rather than the specific page type it relates to, meaning that the relation is defined on all page types, even if it's not used as such:
class FooPage(Page):
    # ...

class FooStatistics(Orderable):
    page = ParentalKey(Page, related_name="statistics")  # should really be FooPage
    # ...

The ReferenceIndex. _extract_references_from_object method will thus follow this relation for all page types. If some other page then re-uses that name for some other property - which would normally be harmless since we don't care about the relation becoming inaccessible on that page type:
class BarPage(Page):
    @property
    def statistics(self):
        return BarStatistics.objects.first()

the reference index will fail at the point of calling child_objects = getattr(object, relation_name).all(), because getattr(object, relation_name) does not return the expected RelatedManager / QuerySet.
<class 'myapp.models.BarPage'>
Traceback (most recent call last):
  File "manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/venv/lib/python3.8/site-packages/django/core/management/__init__.py", line 419, in execute_from_command_line
    utility.execute()
  File "/venv/lib/python3.8/site-packages/django/core/management/__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/venv/lib/python3.8/site-packages/django/core/management/base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/venv/lib/python3.8/site-packages/django/core/management/base.py", line 398, in execute
    output = self.handle(*args, **options)
  File "/venv/lib/python3.8/site-packages/wagtail/management/commands/rebuild_references_index.py", line 52, in handle
    ReferenceIndex.create_or_update_for_object(instance)
  File "/venv/lib/python3.8/site-packages/wagtail/models/reference_index.py", line 364, in create_or_update_for_object
    references = set(cls._extract_references_from_object(object))
  File "/venv/lib/python3.8/site-packages/wagtail/models/reference_index.py", line 313, in _extract_references_from_object
    child_objects = getattr(object, relation_name).all()
AttributeError: 'BarStatistics' object has no attribute 'all'

Ideally we would be able to follow the relation without going through getattr(object, relation_name) - hopefully there's some method for doing this based on the child_relation object that we obtained relation_name from. (This would also allow it to work for related_name="+" relations - how do we handle those currently?)

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: no

(This would also allow it to work for related_name="+" relations - how do we handle those currently?)

We are only concerned with ParentalKeys here, so the answer is... we don't.
https://github.com/wagtail/django-modelcluster/blob/be42bbe179f92a383b21b52b94d5be47fda46cc4/modelcluster/fields.py#L269-L277

On further investigation, masking ParentalKey relations in this way failed even before the reference index was added - ClusterableModel.save runs getattr(self, relation).commit(), and has done so since the start of Wagtail - therefore we can reasonably declare this setup unsupported.


Links available in iot-location-services-samples not working

The links provided within the second use case - geo services are not working
https://developers.sap.com/tutorials/iot-locations-geofence - 404 Error Page Not Found. Pl check.

Hi @inayath-m, thanks for notifying it. The main page has been updated and the link has been fixed.


sudo: set secure_path with root-installed software only

Given the following hypothetical:

Nix allows any user to install software in to their PATH. A crafty
person with malicious intent could use Nix to alter the installed
software of a given user without editing their PATH, and without any
"writable" user directories in the PATH.

This change explicitly sets sudo's PATH to only include root installed
software. This at least reduces the chances of that hypothetical
coming true.
Tested and seemed to work a treat. Also easy to roll back if it is
unwanted.

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@samueldr points out this would break sudo on binaries fetched by nix-shell, which seems pretty annoying (nix-shell -p mtr anyone?) so maybe we don't want this by default? Hmm

Not a bad workaround, though:
[grahamc@Petunia:~]$ nix-shell -p vim

[nix-shell:~]$ sudo vim
sudo: vim : commande introuvable

[nix-shell:~]$ sudo $(which vim)

(worked fine)

cc @cransom

It sounds like a good idea but I am not sure we have a clear picture of "valid" uses.
For the mtr problem you should be using programs.mtr.enable anyway….
I have the feeling that we might be able to accept this since we are already breaking so many "standard" assumptions when compared to other Distros (Debian, Fedora, …). It might still be an infinite source of user confusion (paradoxically; it should have been the other way) as it used to work on likely works everywhere else. I am also thinking about stuff like ruby, python, … "virtualenvs" where sudo might be used seldomly and we do not know about it.
As with any change: We can try and roll back if things are too broken. I would definitely prefer some kind of A/B-Testing for these but we don't have that.
(nixos.experiements.enable = true; anyone? :-))

Nix allows any user to install software in to their PATH. A crafty
person with malicious intent could use Nix to alter the installed
software of a given user without editing their PATH, and without any
"writable" user directories in the PATH.

I’m not sure I understand how they would do that without already having root?

Yeah, that wasn't worded well, @alyssais. I don't mean an arbitrary user, but the current user. Any program run as a given user could install new programs for that same user.

@andir

I have the feeling that we might be able to accept this since we are already breaking so many "standard" assumptions when compared to other Distros (Debian, Fedora, …).

RHEL and Debian lookalikes already set this to something like:
Defaults        secure_path="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin"

:)

Does sudo nix-shell work out of the box? I imagine it does, right?

It does!
$ sudo nix-shell -p hello --run hello
Bonjour, le monde !

@grahamc I assume the threat model is:

A user has some restricted sudo access (eg. only sudo foo --bar), and could use $PATH to make foo execute arbitrary programs as root if foo does a system() or similar.

In which case it's AFAIK not nix-specific (anyone could just set $PATH to point to ~/bin), but the generic attack against sudo, which is as you mention mitigated by secure_path.
@alyssais If I'm not mistaken with the above, then I think this is the threat model you were wondering about -- and in this situation sudo nix-shell is not a possible bypass :)

@grahamc I assume the threat model is:

A user has some restricted sudo access (eg. only sudo foo --bar), and could use $PATH to make foo execute arbitrary programs as root if foo does a system() or similar.

With Nix in the path, there is no illusion of restricting what programs a user can run with sudo. So, this makes no attempt to help with that. This is more about a problem with an attacker transparently replacing executables on the PATH. For example, replacing vim with a pwnd vim in the user's profile, they might never know because the $PATH looks right and they "never" use nix-env. As it currently stands, next time they run sudo vim they'll give this pwnd vim root access. With this PR, sudo vim would use the root-installed vim.

@grahamc IMO your example is not a realistic threat model: if the attacking program can replace vim, it can replace sudo with myevilsudo just as well (ie. something that would be a wrapper around sudo but also installs a backdoor or similar).
OTOH, for a user with restricted sudo access (including, presumedly, no nix, otherwise it wouldn't be restricted), the patch does totally make sense to me: the user with something like [...] = (ALL) /run/current-system/sw/bin/something --foobar, assuming something does system("foobar"), could execute whatever they want as root by sending in a $PATH that includes their own evil foobar without this patch.

This patch has nothing to do with explicitly setting the PATH for a restricted sudo user, it is just a Defaults clause. More specific restrictions should be set with extraRules. This specific option should not be used for general access restriction.

I asked in #debian why they set the secure_path the way they do, and they said indeed it is to make carefully restricted users' PATHs safe. I'm not sure we can claim that value, though, since nix-shell will still be in PATH and that is a lot of power.

Note: I'm requesting reviews and ccing people who tell me they combine sudo and nix-shell.

Not a bad workaround, though:

My feeling is that sudo nix-shell -p ... would be preferable over nix-shell -p ... --run '...' is preferable anyway as in the former case the entire environment is being set up as the privileged user.

@grahamc I think debian's threat model, as well as the one I'm envisioning, is basically something like:
#!/bin/sh
# (in /whatever/foo.sh)
exec bar

And then the user U having access to sudo /whatever/foo.sh.
In this model, with $PATH user-controlled, U would be able to execute anything as root by naming it bar and prepending its dir to $PATH. While, with $PATH root-controlled (ie. with this patch), U can execute only the root-expected bar.
Now, if /whatever/foo.sh were calling nix-shell, then it would potentially open up some more ways to bypass things by U, but the point is so long as /whatever/foo.sh isn't explicitly calling nix-shell, it won't allow the user to run whatever-they-want :)

So if a malicious program could just take over sudo anyways, what are the upsides? You can't really install suftware as non-root anyway on debian, so there are not much downsides there. But there are for nixos.

what are the upsides?

Yes, that is the question.

@timokau The upsides are to defend root against the malicious (or compromised) restricted-sudo user U described in https://github.com/NixOS/nixpkgs/pull/64209#issuecomment-508123221 :)

That does seem a bit contrieved to me. Its basically the setuid scenario, and the same security concerns apply. This change sounds like it could be a significant inconvenience (I manage most of my packages with home-manager, sometimes use nix-shell to query hardware info or something that needs a one-off sudo package). The "restricted sudo" case doesn't seem worth it to me.

It is exactly the setuid scenario indeed. OTOH, sudo is actually designed to work around the security shortcomings of setuid.
BTW, this “cleaning $PATH” behavior is very similar to the “cleaning $HOME” behavior we already have, and has similar inconvenience level: user-level config (vs. user-level packages) don't get in, because they would be dangerous as they'd allow unexpected software to run as root (eg. .vimrc or similar).
Arguably managing all one's packages through home-manager is thus a broken workflow (it installs packages for root as a user), and it makes sense to make it no longer work. OTOH, it is convenient.
I'm personally in favor of this change, mostly because people expect sudo to clean $PATH, while they don't expect setuid to, as it's the way all other distros do it.

Well "cleaning $HOME" is actually a convenience in my view, since it keeps all my home from being cluttered by root-owned files.

Arguably managing all one's packages through home-manager is thus a broken workflow (it installs packages for root as a user), and it makes sense to make it no longer work. OTOH, it is convenient.

I don't understand that point. Why would that be a broken workflow?

mostly because people expect sudo to clean $PATH

Do they though? Because I don't. Debian may do it, but I don't think most people will have noticed because most debian binaries will live in one of the whiltelisted paths anyway.

This will be my last message on this topic, as we're clearly running around in circles. (for the “broken workflow”, it's in the parenthesis that just follow these two words, in your quote)
I'm sorry in advance if my tone gets heated along the message (which is another reason for this to be my last message), I've tried to tone it down by re-reading but may have missed places.
Here is a scenario:

I'm a sysadmin.
I allow my apache2 user to run sudo my_database_cleanup.sh, which will be called by some kind of webcron or whatever.
my_database_cleanup.sh is some kind of shell script, written like any usual shell script, that just performs a database cleanup.
(Note: this is exactly how restricted-sudo is used just about everywhere)
Poof, apache2 now has rights equivalent to those of root, by using the attack listed at https://github.com/NixOS/nixpkgs/pull/64209#issuecomment-508123221. Welcome privilege escalation.

NixOS currently encourages behavior that unfortunately doesn't work with the fix to this vulnerability, by having user-only-installed packages propagate to root. However, this behavior is not right, just like a user being able to install packages in root's environment would be wrong (though it's not the same threat model).
The workaround @grahamc suggested at https://github.com/NixOS/nixpkgs/pull/64209#issuecomment-507896348 works when you already are with user-installed packages (nix-shell or home-manager) and really want to do that, and other than that just enter a sudo and then enter a nix-shell.
But having the user able to make it look to other programs like it's installed software as root is exactly what causes the vulnerability I described above.
Now, your opposition to this is based on usability. To which my answer will be: why are you even installing sysadmin tools via home-manager, and not via /etc/nixos or via root's home-manager? There is no semantic reason for them to be there, and they could shadow things installed as root.
Your user being an all-privileged sudo user should be considered the exception, not the rule. Sudo is not just a way to have a keyword that you need to type to brick your system, it's a tool that 1. switches to another user, 2. runs a command, and 3. switches back to the original user. When you see it in these 3 steps, it becomes obvious that what you have installed as your local user should not affect execution of the command in step 2 -- if it did (and for the time being it does), then it'd be a security vulnerability.

One way to easily preserve the UX and improve automated script security is to make wheel an exempt group.

This will be my last message on this topic, as we're clearly running around in circles. (for the “broken workflow”, it's in the parenthesis that just follow these two words, in your quote)
I'm sorry in advance if my tone gets heated along the message (which is another reason for this to be my last message), I've tried to tone it down by re-reading but may have missed places.

I certainly don't want to step on anyones toes, sorry if it seems that way :)

Here is a scenario:
1. I'm a sysadmin.

2. I allow my `apache2` user to run `sudo my_database_cleanup.sh`, which will be called by some kind of webcron or whatever.

3. `my_database_cleanup.sh` is some kind of shell script, written like any usual shell script, that just performs a database cleanup.

4. (Note: this is _exactly_ how restricted-sudo is used just about everywhere)

5. Poof, `apache2` now has rights equivalent to those of root, by using the attack listed at [#64209 (comment)](https://github.com/NixOS/nixpkgs/pull/64209#issuecomment-508123221). Welcome privilege escalation.

Okay now the scenario doesn't seem contrieved anymore. For me sudo is just a convenient tool to elevate my privileges temporarily, for that usecase I would use setuid. I also think in that case authors should use absolute paths anyway. But I know that "I think people should be doing" is not what people actually will be doing. And its always good to remove footguns.

NixOS currently encourages behavior that unfortunately doesn't work with the fix to this vulnerability, by having user-only-installed packages propagate to root. However, this behavior is not right, just like a user being able to install packages in root's environment would be wrong (though it's not the same threat model).

I disagree here. sudo (for me) is about executing something with the privileges of another user, while keeping the environment. Just because a package is in my PATH while I run sudo, I wouln't consider it to "propagate to root" -- its just part of my current environment.

The workaround @grahamc suggested at #64209 (comment) works when you already are with user-installed packages (nix-shell or home-manager) and really want to do that, and other than that just enter a sudo and then enter a nix-shell.

In my opinion that would break user expectations too much. I would certainly have been surprised, and it wouldn't be obvious why its not working as I expect.

Now, your opposition to this is based on usability. To which my answer will be: why are you even installing sysadmin tools via home-manager, and not via /etc/nixos or via root's home-manager? There is no semantic reason for them to be there, and they could shadow things installed as root.

Actually looking into my shell history, I have to admit I don't actually do that very often. Still, not every tool run with sudo has to strictly be a "sysadmin tool", it could be a tool that is only executed with elevated permissions as an exception. The best example I can come up with off the top of my head is an editor. That's not ideal of course (sudoedit), but you get the idea.
I like @grahamc's idea. If the main thread model here is the restricted-sudo case, why not just apply to that one. Only downside is that it could be even more confusing because of the inconsistency.

(disclaimer: I only got pinged because I participated in the twitter poll).
For me personally the sudo $(which foobar) workaround is fine (if I understood everything correctly :sweat_smile: ), I don't have any strong opinions about adding further options for this.

For the author, reviewers, and committers: this PR was scanned and appears to add a use of the deprecated types.string, which emits a warning as of #66346. Before merging, please change this to another type, possibly:

types.str for a single string where merging does not make sense, or cannot work
types.lines for multi-line configuration or scripts where merging is possible
types.listOf types.str for a mergeable list of strings

Looks good to me. Let's make it the default.

@grahamc why was this not merged? Is it not worth it anymore, has the problem been solved by any other issue ? Could you explains what happened for this to be forgotten?


[shell] Add subcommand help to shell config command.

Problem
It isn't easy to glean what parameters are valid arguments to the chip-shell config command.
Change overview
Add config help command to list which parameters can be get or get/set.
Testing
Manually + CI.

Fast tracking, given this is adding functionality for testing.


count only positional params for _function_nargs

Coverage remained the same at 80.976% when pulling bd2c592a0bcec5085a35e81ca1569ccaaf6e3416 on gertjanvanzwieten:fix-function-nargs into 850be27089e091c1498a734f2bc7b53748855e98 on nutils:master.

replaced by #252


The goal of this repo is to help beginners who are doing their first pull requests. Feel free to join!
Instruction
try to solve issues.
How to Create a Pull Request

Click on the fork on the top to fork this repo.
Go to your repo where you fork the project.
Hit the clone button on your forked repo and copy the given link.
On your terminal/command prompt, type "git clone [put the link here]".
Add your name in the CONTRIBUTORS.md.
Afterward, on your terminal/command prompt, type "git add CONTRIBUTORS.md".
then type 'git commit -m "[type a message]" '.
Push the commit. then type "git push origin master".
Go back to the original repo.
Hit "new pull request" and compare between forks.
Confirm the pull request and that's it!

Installation
Make sure git is installed.

This is great! I made my first PR earlier today, and hence know how useful and motivating this can be!

star


fix type error in newer versions of urdf

I believe this should fix the compiler errors of the latest rviz release on some platforms which were introduced in: https://github.com/ros-visualization/rviz/pull/1079

Backported in https://github.com/ros-visualization/rviz/pull/1110


set four decimal points for independent axis range

This addresses https://github.com/VEuPathDB/web-eda/issues/1015#issuecomment-1116389339
The same study and variables shown in the comment's screenshot is reproduced with this PR as follows. Now the decimal point is limited up to 4 digits: see X-axis range's min value. I also changed existing function to check whether the number value is integer or not because there is no need to have additional decimal point for the integer case.

@jtlong3rd ! Are you watching my works in real-time??? 😄 I was even modifying my initial comment when you just approved! 👍

@jtlong3rd ! Are you watching my works in real-time??? 😄 I was even modifying my initial comment when you just approved! 👍

😆 We recently added a #github-pull-requests channel to the EPVB slack, so I got a push notification when you added me as a reviewer.

@jtlong3rd Aha I see! I had an experience to make it at another slack myself. But it is soooo fast anyway 👍👍


Bug fix wrong result after reorder mor table

Proposed changes
fix wrong result after reorder mor table
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


No rendering for OnPolicy algos

This is resolved in my PR.
On Fri, 26 Jun 2020, 21:28 Sampreet<EMAIL_ADDRESS>wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SforAiDl/genrl/issues/180, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH72FJ65PW3QABIXWGCNJH3RYTAUFANCNFSM4OJOPUAQ
.

Resolved


add support for module members that are no function

Currently only exported functions of modules can be documented well. Since we have some exports of simpler object or primitive type (like log.level or log.BLACKBOX) that we need to document, there needs to be better support for them. For example, one issue is that after the name of the module member always opening and closing parentheses are added, regardless of the type.

Implemented on master (v2.0.0).


[Don't merge] Jenkins testing

Coverage decreased (-4.2%) to 56.379% when pulling c19be91b509ca5cb6523f0035929e0ecfbcfc451 on yuan/jenkins-int into 91ee789725709d438ae3f50f119be1db049a1b2b on master.

Coverage decreased (-4.2%) to 56.379% when pulling c19be91b509ca5cb6523f0035929e0ecfbcfc451 on yuan/jenkins-int into 91ee789725709d438ae3f50f119be1db049a1b2b on master.


Forward ref support

Completely clean implementation of the forwardRef support.
This will use it when the API is available and is completely backward compatible.

Added actual code
Added test for the forwardRef API
Added documentation for it

Some notes here:

The changes in src/tests/dynamic-styles.js were necessary because rendering a forwardRef node is apparently returning null and that broke some of the tests.
The big changes inside src/createHoc.js were necessary because the react/sort-comp didn't validate the immediately returned class before.

@kof do you know whats up with the CI?
Sent with GitHawk

@kof do you know whats up with the CI?

haven't looked into it yet, if you know whats up please check


back end changes for review comments updates

Issue #:
https://github.com/bcgov/met-public/issues/1016
Description of changes:

Added columns and table to handle notify email and Review/Internal Note and logic to store the details
Changed the logic to handle rejection email only in case of changes on review comment or rejection reason

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #1090 (7d8aa6b) into main (729e25c) will decrease coverage by 0.34%.
The diff coverage is 58.58%.

@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
- Coverage   73.99%   73.65%   -0.35%
==========================================
  Files         233      236       +3
  Lines        6669     6791     +122
  Branches      464      464
==========================================
+ Hits         4935     5002      +67
- Misses       1660     1715      +55
  Partials       74       74

Flag
Coverage Δ

metapi
78.75% <58.58%> (-0.87%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

met-api/src/met_api/services/submission_service.py
56.14% <34.04%> (-8.66%)
:arrow_down:

met-api/src/met_api/models/staff_note.py
67.74% <67.74%> (ø)

met-api/src/met_api/constants/staff_note_type.py
100.00% <100.00%> (ø)

met-api/src/met_api/models/__init__.py
100.00% <100.00%> (ø)

met-api/src/met_api/models/submission.py
68.42% <100.00%> (+1.02%)
:arrow_up:

met-api/src/met_api/schemas/staff_note.py
100.00% <100.00%> (ø)

met-api/src/met_api/schemas/submission.py
100.00% <100.00%> (ø)

met-api/src/met_api/resources/user.py
77.35% <0.00%> (-11.84%)
:arrow_down:

met-api/src/met_api/services/user_service.py
85.71% <0.00%> (-8.84%)
:arrow_down:


arc.open error Error in (function (cl, name, valueClass)

My R code looks like:
vac <- arc.open("completepath/filename.gdb")
and I am getting the following error:
Error in (function (cl, name, valueClass)  :
assignment of an object of class “numeric” is not valid for @‘.ptr’ in an object of class “arc.workspace_impl”; is(value, "externalptr") is not TRUE

@rmdewan the bridge doesn't directly handle workspaces (like a GDB), you'll need to pass in a fully qualified path to a specific datasource (like a feature class residing in the GDB).

Thanks Shaun,
Rajiv
--
Rajiv Dewan
Xerox Professor of Business
Computers & Information Systems and Business Analytics
Simon School, University of Rochester
3-333B Carol Simon Hall
Rajiv.dewan<EMAIL_ADDRESS>  585 275 3827
From: Shaun Walbridge<EMAIL_ADDRESS>Sent: Friday, February 23, 2018 4:40 PM
To: R-ArcGIS/r-bridge-install<EMAIL_ADDRESS>Cc: DEWAN, RAJIV<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [R-ArcGIS/r-bridge-install] arc.open error Error in (function (cl, name, valueClass) (#66)
@rmdewanhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rmdewan&d=DwMCaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=8A2X9fsVWLhm3sS-7EDsm2-rfODDIKyWrMN4QLOm7cs&m=KILRwaYawItuQaOQGUhaMFzxw9Zsb67-s7Rpa0s6GXY&s=QVE-0YmPChuSZJuo0GwuGQaJ2k_id7-zwBIG_0y1vSQ&e= the bridge doesn't directly handle workspaces (like a GDB), you'll need to pass in a fully qualified path to a specific datasource (like a feature class residing in the GDB).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_R-2DArcGIS_r-2Dbridge-2Dinstall_issues_66-23issuecomment-2D368146095&d=DwMCaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=8A2X9fsVWLhm3sS-7EDsm2-rfODDIKyWrMN4QLOm7cs&m=KILRwaYawItuQaOQGUhaMFzxw9Zsb67-s7Rpa0s6GXY&s=jzQ7w5z_-IcZlPeHarTGWiOGNRCLYlVsN6G_Uefllv4&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AUX2ww1IuPbSec0jBnIi8dx-5FJvXIsTbkks5tXzAUgaJpZM4SRg0A&d=DwMCaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=8A2X9fsVWLhm3sS-7EDsm2-rfODDIKyWrMN4QLOm7cs&m=KILRwaYawItuQaOQGUhaMFzxw9Zsb67-s7Rpa0s6GXY&s=-MBv7GmzZlDKfBtLRRc7rQMl77MWJOc4kk9xgW2UEVQ&e=.

@rmdewan No problem, happy to help. I'll make a note that we should provide a more useful error message if you pass in a workspace to arc.open.

Hi Shaun,
I am very familiar with R but a complete novice with ArcGIS.  Some one sent me this GDB file which I can open in ArgGIS Pro.  It is folder with very many files in it of the following kinds: ATX, GDBTABLE, GDBINDEXES, and SPX among a couple of others.  I want to extract the lat/log into an R dataset.  Which of these should I try to open in arc.open()?
Thanks and sorry for the very newbie question,
Rajiv
--
Rajiv Dewan
Xerox Professor of Business
Computers & Information Systems and Business Analytics
Simon School, University of Rochester
3-333B Carol Simon Hall
Rajiv.dewan<EMAIL_ADDRESS>  585 275 3827
From: Shaun Walbridge<EMAIL_ADDRESS>Sent: Friday, February 23, 2018 4:44 PM
To: R-ArcGIS/r-bridge-install<EMAIL_ADDRESS>Cc: DEWAN, RAJIV<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [R-ArcGIS/r-bridge-install] arc.open error Error in (function (cl, name, valueClass) (#66)
@rmdewanhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rmdewan&d=DwMCaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=8A2X9fsVWLhm3sS-7EDsm2-rfODDIKyWrMN4QLOm7cs&m=XkLpQCkQWLscub-3GAiIQ86rjKEe7-RqNoRsjmJhCSg&s=zf2iIDayXB4lk44Amzd58RtFDCBLy6gwq2PkpsbV0OQ&e= No problem, happy to help. I'll make a note that we should provide a more useful error message if you pass in a workspace to arc.open.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_R-2DArcGIS_r-2Dbridge-2Dinstall_issues_66-23issuecomment-2D368147096&d=DwMCaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=8A2X9fsVWLhm3sS-7EDsm2-rfODDIKyWrMN4QLOm7cs&m=XkLpQCkQWLscub-3GAiIQ86rjKEe7-RqNoRsjmJhCSg&s=S7rxMyKEqTBlJjbbpotIUosX2pI5GgF-Cg-yxpoNDKY&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AUX2w99ZT16hpr-2DYIFNhyCImyh-5FnNaHsks5tXzEYgaJpZM4SRg0A&d=DwMCaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=8A2X9fsVWLhm3sS-7EDsm2-rfODDIKyWrMN4QLOm7cs&m=XkLpQCkQWLscub-3GAiIQ86rjKEe7-RqNoRsjmJhCSg&s=8anKkFx-oFkmmCNUL3luZbedLsfjUbzx923Sphmm27A&e=.

Try beta release <IP_ADDRESS>-beta it should be more friendly with opening .gdb workspace.

Thanks a lot,
Rajiv
Rajiv Dewan
Xerox Professor of Business
Computers & Information Systems and Business Analytics
Simon Business School, University of Rochester
Carol Simon Hall Room 3-333B
585 275 3827
On Feb 23, 2018, at 5:52 PM, Dmitry Pavlushko <notifications<EMAIL_ADDRESS>wrote:
Try beta release <IP_ADDRESS>-betahttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_R-2DArcGIS_r-2Dbridge_releases_tag_v<IP_ADDRESS>-2Dbeta&d=DwMCaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=8A2X9fsVWLhm3sS-7EDsm2-rfODDIKyWrMN4QLOm7cs&m=ewQN8MHkwc1l2tOKh0sc8p8xmUyQGTK3CepMY1Pxqw8&s=7dKwLCYNgS0UEJRcaL-7P2Q8Q1vGiU18qD-euarBXb0&e= it should be more friendly with opening .gdb workspace.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_R-2DArcGIS_r-2Dbridge-2Dinstall_issues_66-23issuecomment-2D368161587&d=DwMCaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=8A2X9fsVWLhm3sS-7EDsm2-rfODDIKyWrMN4QLOm7cs&m=ewQN8MHkwc1l2tOKh0sc8p8xmUyQGTK3CepMY1Pxqw8&s=V2Zy2et2fNJCbbcKLp0-FW0BCYAVG6EsRsKgRVYLJxI&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AUX2w9PnvQ4qwwn3C6OC-2Dd8-2DcwST8GXDks5tX0EhgaJpZM4SRg0A&d=DwMCaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=8A2X9fsVWLhm3sS-7EDsm2-rfODDIKyWrMN4QLOm7cs&m=ewQN8MHkwc1l2tOKh0sc8p8xmUyQGTK3CepMY1Pxqw8&s=wRcydlXaGSsmFxwa9QbDLoeZh4AP_ruVntoI8Aa4kkY&e=.

Hi @rmdewan, no problem. File Geodatabases are a collection of files comprising the database. This database can contain many different data sets all within it, but unfortunately as a pure database, you can't immediately tell from the filenames on disk what it contains. If you can open the data in ArcGIS Pro, you should be able to navigate to the GDB, and see the feature class, raster or table names from within the application.  Once you see one of those names, you can add it after ".gdb/" and it'll be openable within R.

That is a cool tip Shaun.
Thanks
Rajiv
Rajiv Dewan
Xerox Professor of Business
Computers & Information Systems and Business Analytics
Simon Business School, University of Rochester
Carol Simon Hall Room 3-333B
585 275 3827
On Feb 23, 2018, at 6:26 PM, Shaun Walbridge <notifications<EMAIL_ADDRESS>wrote:
Hi @rmdewanhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rmdewan&d=DwMFaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=8A2X9fsVWLhm3sS-7EDsm2-rfODDIKyWrMN4QLOm7cs&m=116XU_mj9E8mg08IkkuqfdRldTO_HhSlFEFMVohrylo&s=T2YqrzxlnISGzBZVTQ6nuuaJmT3E3T_OF0F6C3RHj50&e=, no problem. File Geodatabases are a collection of files comprising the database. This database can contain many different data sets all within it, but unfortunately as a pure database, you can't immediately tell from the filenames on disk what it contains. If you can open the data in ArcGIS Pro, you should be able to navigate to the GDB, and see the feature class, raster or table names from within the application. Once you see one of those names, you can add it after ".gdb/" and it'll be openable within R.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_R-2DArcGIS_r-2Dbridge-2Dinstall_issues_66-23issuecomment-2D368168390&d=DwMFaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=8A2X9fsVWLhm3sS-7EDsm2-rfODDIKyWrMN4QLOm7cs&m=116XU_mj9E8mg08IkkuqfdRldTO_HhSlFEFMVohrylo&s=sly1MECtmf9jnQdcj-9WRcnwfzj_llNujKJB-ZB7Dig&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AUX2w4mzoyEr2DoC0OduRDxO5FA3QFbhks5tX0kwgaJpZM4SRg0A&d=DwMFaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=8A2X9fsVWLhm3sS-7EDsm2-rfODDIKyWrMN4QLOm7cs&m=116XU_mj9E8mg08IkkuqfdRldTO_HhSlFEFMVohrylo&s=5Zobobg1-HLgzs6FdWGl-JCmOQQDTXxGIgoZYzQDGH4&e=.


input shapes for combined chains

Is it possible to save a onnx model like this?
which is set together in a Flux.Chain object?
This is currently not working because I have failed to provide matching inputshapes.
This would be the second question: What are the input shapes of a combined chain like this?
chain = Flux.Chain(Dense(1, 6, σ), Dense(6, 1))
...
save('my model.onnx', chain)

Hi,
It looks like the main problem is that Sigmoid is not supported by ONNXNaiveNASflux yet. Fortunately it is trivial to add and I will add it in #76
In the meantime, you can add support for it yourself by just running this:
Flux.σ(pp::ONNXNaiveNASflux.AbstractProbe) = ONNXNaiveNASflux.attribfun(identity, "Sigmoid", pp)

As for input shapes, they should be inferred correctly from Chain in most cases.
If you want to supply them yourself they shall be supplied as Flux wants them, for example save("mymodel.onnx", chain(1, :BatchSize)) or save("mymodel.onnx", chain, (1, missing)).

@DrChainsaw thank you! that was a quick fix.
I am able to export the model both using the inferred inputshapes and missing:
save('my model.onnx', chain)
save("mymodel.onnx", chain, (1, missing))
however this fails:
save("mymodel.onnx", chain(1, :BatchSize))
error:
ERROR: LoadError: MethodError: no method matching (::Chain{Tuple{Dense{typeof(σ), Matrix{Float32}, Vector{Float32}}, Dense{typeof(identity), Matrix{Float32}, Vector{Float32}}}})(::Int64, ::Symbol)
Closest candidates are:
  (::Chain)(::Any) at ~/.julia/packages/Flux/4k0Ls/src/layers/basic.jl:5

For the successful cases I tried to import the model in Matlab and noticed that the model is exported with size '(?, 1)' which causes an error in Matlab. My question here is if it is right that the model is exported with and undetermined size?
just for completeness this is the error trown, which I think I can fix by being more specific when calling the import function.
Unable to import the network because of the following issues:

1 operator(s)	:	Unable to create an input layer for ONNX input #1 (with name 'data_0')
because its data format is unknown or not supported as a MATLAB input layer. If you know the
input format, pass it by using the "InputDataFormats" parameter.
 The input shape declared in the ONNX file is '(?, 1)'.
1 operator(s)	:	Unable to create an output layer for ONNX network output #1 (with name
'dense_1') because its data format is unknown or not supported as a MATLAB output layer. If
you know the output format, pass it using the 'OutputDataFormats' parameter.

Great that it was just the Sigmoid. Most ops are trivial to add, but I'm still only adding them when someone needs them in an attempt to reduce future maintenance burden if/when I need to refactor stuff.
I made a copy-paste error for the input size which fails, it should be save("mymodel.onnx", chain, (1, :BatchSize)) (note the comma after chain).
About the matlab error and the (?, 1) size:
It should be correct. The question mark is the batch size which can't be inferred from the model itself and which is also generally not a fixed number for a given model except in rare circumstances.
Iirc, ONNX supports three different way to specify an input size along any dimension:

As a number, stating exactly what it is, like 1 in your model
As a variable with a name, which is what :BatchSize will result in
Unspecified, which is what missing will do (and this is also the default for sizes which can't be inferred like the batch size)

ONNX is a bit of a sprawling spec, and implementations having only partial coverage of it seems to be the norm. Here it appears like matlab does not support option 3 (which it seems to print as a ?).
You can either try with 2 (i.e the one with :BatchSize) or you can just put some number for the batch size (maybe you have one you intend to use).
As you said, using InputDataFormats is probably a perfectly fine way to get matlab to import the model and it is probably there just for this reason.
Fwiw, ONNXNaiveNASflux also lets the user override any model shapes in the load function and it is there just for the case when someone tries to load a model with some inputs specification it does not yet support.

Sorry, got a bit distracted but now I have merged the sigmoid and will release soon. Please reopen if you still have issues to load the model.


Rename isParameterDeclaration, deprecate isParameter

This is a follow-up to #49929, which:

Renames isParameterDeclaration to isPartOfParameterDeclaration.
Renames isParameter to isParameterDeclaration (as that is the node name).
Adds a deprecated compat function isParameter.
Renames SyntaxKind.Parameter to SyntaxKind.ParameterDeclaration and adds a deprecated duplicate (like we did with JSDoc).

I made up the timing for this deprecation; I just copied the same scheme as another helper's but I feel like this one needs a loooot of time for people to fix.

I'm going to pull the isParameterDeclaration -> isPartOfParameterDeclaration rename into its own PR; it's confused enough people working on TS, but thankfully nobody externally is using it: https://github.com/search?q=%2F\bts\.isParameterDeclaration\b%2F+(language%3ATypeScript+OR+language%3AJavaScript)&type=code


Store version of annotation tools used to ensure reproducibility

Is your feature request related to a problem? Please describe.
Marvin's VTC annotator has already gone through two versions (one in December 2019 and one in March 2020, see master branch and new_model branch here).
Some subsequent tools such as ALICE depend on the version of the VTC to produce the appropriate results (using either one set of regression coefficients or another). With new versions of the VTC and ALICE coming out in the next few weeks/months, it appears essential to keep the information of which versions of the tools were used to annotate the audio files. This would prevent us from running tool B with annotations of tool A v1 when tool B needs annotations produced by tool A v2. For example, ALICE's regression coefficients were tuned so as to compensate for the VTC's errors, it's thus essential to run ALICE with the same VTC segments it was trained on.
Describe the solution you'd like
Add a column akin to CP's package_version column so that we can specify the version of the annotation tool used (or commit hash)

Great idea!
Those could be stored in metadata/annotations.csv indeed, but maybe also inside the annotation folder? e.g. in some yml file into annotations/vtc/? whatever you like better!

I think it would be better if it's stored in metadata/annotations.csv. I'm however not sure how to properly signal version numbers. For example, both the VTC and ALICE do not use version numbers (AFAIK), and using the repository's commit hash might be a bit too restrictive (you could apply some cosmetic changes on some files without changing the model itself).
I'm not sure what is the way to go, even though I feel it's an important issue.

I think commit hashes are good because you can always perform a diff between two commit hashes and assess whether the changes are significant.
This raises the broader issue of storing custom metadata about the annotations (for instance, this might be useful for handling manual annotations too -- for instance, one might want to keep track of each annotator's native language). We could just allow users to add their own custom fields to the annotations index and it would be up to them to decide how to handle this.

@alecristia what do you think about this?

We think opening the possibility for people to add whatever column they want to metadata/annotations.csv will lead to information not being easily human readable and people will forget it is here. In general metadata/annotations.csv should not be open and read by hand.
We believe this information belongs  in an annotation dedicated section in the README of the dataset.
The hash commit of ALICE / VTC should probably be indicated in the README also.


Disable swiping back only to the spalsh screen

Version
Tell us which versions you are using:

react-native-router-flux "^4.0.1"
react "16.3.1"
react-native  "0.55.4"

Expected behaviour
I want to disable the swipe back function only from main screen to splash screen.
And when it comes to other screens, I want the swipe back function to work.
Actual behaviour
I have tried to add gestureEnabled / panHandlers to the parent Scene, but it will disable all the swipe back function.
What I expect is to only disable the swipe back function to spash screen.
Sample Code
<Router>
    <Scene hideNavBar={true}>
      <Scene key="splashScreen" component={splashScreen} initial />
      <Scene key="mainScreen" title="main" hideNavBar={true} >
        <Scene key="main1" component={main1} />
        <Scene key="main2" component={main2} />
      </Scene>
    </Scene>
  </Router>

I want to disable swipe back between splashScreen and main1/main2 ,
and enable swipe back between main1 and main2.

Only way to do this is using the panHandlers={null} prop. You can switch up how your scenes are nested or only specify that prop on certain scenes to ensure the rest of your application still has the expected swipe back behavior.

I agree with @LeviWilliams - I believe Splashscreen should not be part of your group of scenes - but a piece of Switch - to be replaced when finish loading - that way there is no back to splash when the app loads - since the scene would be removed from the stack.
Or try to use a type replace - that way it will be also replaced instead of having other scene pushed over.
Let's move this discussion to StackOverflow or the gitter channel - since it suits more there than here. In case if you think this is a bug and need to be really fixed, reopen the issue.


Debugging with Mocha and TypeScript does not reach breakpoints

I am using Mocha to run tests due to it's popularity yet I cannot get the debugger to attach when launching a task to run tests.
What I have started to do is run tests using Grunt with the debug-brk option set to true so that it stops on the first statement and waits for a debugger to connect on port 5858. I can then attach the VS Code debugger and start using breakpoints.
I just discovered that when I attach the debugger in this way I need to make sure that sourceMaps is set to true. By default this option is not even defined with the "Attach" task. This is an important detail. I hope including it here helps others who are working with TypeScript. It would be helpful to add it to the tasks template even with the value set to off like it is for launching tasks.
I am creating this issue in hopes of learning how I can get VS Code to automatically attach to the running Mocha task with it working with source maps so I can debug through TypeScript without the extra step.
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Launch Tests",
            "type": "node",
            "request": "launch",
            "program": "${workspaceRoot}/node_modules/.bin/mocha",
            "stopOnEntry": false,
            "args": ["--reporter", "spec", "--timeout", "5000", "--require", "source-map-support/register", "test/**/*.js"],
            "cwd": "${workspaceRoot}",
            "runtimeExecutable": null,
            "runtimeArgs": [
                "--nolazy"
            ],
            "env": {
                "NODE_ENV": "dev"
            },
            "externalConsole": false,
            "sourceMaps": true,
            "outDir": "${workspaceRoot}/test/"
        },
        {
            "name": "Launch Tests (debug)",
            "type": "node",
            "request": "launch",
            "program": "${workspaceRoot}/node_modules/.bin/mocha",
            "stopOnEntry": false,
            "args": ["--reporter", "spec", "--timeout", "5000", "--debug", "--require", "source-map-support/register", "test/**/*.js"],
            "cwd": "${workspaceRoot}",
            "runtimeExecutable": null,
            "runtimeArgs": [
                "--nolazy"
            ],
            "env": {
                "NODE_ENV": "dev"
            },
            "externalConsole": false,
            "sourceMaps": true,
            "outDir": "${workspaceRoot}/test/"
        }
        {
            "name": "Attach (5858)",
            "type": "node",
            "request": "attach",
            "port": 5858,
            "sourceMaps": true
        },
    ]
}

@brennanMKE what version of VS Code are you using and on what platform?

I am also having issues to get the debugger to stop at breakpoints when running mocha against ES6 transpiled files with sourceMap.
I created the repository https://github.com/onlyann/vscode-issue-3144 to demonstrate the issue.
If I put a breakpoint in the transpiled file, the debugger stops at the breakpoint displaying the source ES6 file. However, when I put a breakpoint in the source file, it is ignored.
This is happening with version 0.10.8 on Windows.

@onlyann thanks for preparing the repository.
The npm run transpile fails for me because it references a non-existing build/test_spec.js

@onlyann Since your generated JavaScript lives in the builddirectory, you'll have to add this
"outDir": "${workspaceRoot}/build"

to your launch config.

Thanks @weinand . That works.
I read this documentation about outDir but I am not sure I understand how the debugger makes use of this option, or should I say how the debugger maps breakpoints between source and generated file.
I naively assume that when the generated file is loaded, it would use the sourceMap file to locate the source file and that would be enough to discover breakpoints without the use of outDir.

@onlyann source maps map generated code back to source. They do not directly support the reverse mapping (which is required when setting a breakpoint in the source).
In order to find the source map for a source file, it is basically necessary to search all source map files and then look for a reference to that source inside the source map.
Since every project is free to place the generated code and the corresponding source maps wherever it wants, we do not want to perform an exhaustive search on the whole disk. Instead we require that the outDir attribute points to the root folder where to look for generated code and source maps.
The outDir corresponds to the outDir used in the tsconfig.json.

@weinand I think adding the source maps property to the template would be helpful. Adjusting the outDir value did not work for me. I cannot share this code but when I can I will create a sample which I can share on GitHub to demonstrate the issue.
I am working on a Mac with the latest version of VS Code.

I'm writing debugger for ruby and using the same Run Test config as Mock Debug as below
{
	"name": "Run Tests",
	"type": "node",
	"request": "launch",
	"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
	"runtimeArgs": [ "--nolazy" ],
	"args": [
		"-u", "tdd",
		"--timeout", "999999",
		"--colors",
		"./out/tests/"
	],
	"sourceMaps": true,
	"outDir": "${workspaceRoot}/out",
	"cwd": "${workspaceRoot}"
}

But breakpoints on my debug adapter never gets hit, whether it's set on TS or JS files. Using the latest VS Code on Mac.

@rebornix running the tests involves two processes: the tests in adapter.test.ts and the debug adapter ruby.ts. If you launch the test with the "Run Tests" launch config you can debug the tests, but not the debug adapter (because that's a different process not started in debug mode).
If you want to debug the debug adapter (while running the test) do the following:

launch the debug adapter in server mode with the "ruby debug server" launch config.
set a breakpoint in ruby.ts
in adapter.test.ts:26 add the port number 4711 as a second argument to dc.start(done) so that the tests connect to the ruby debug server (instead of launching the debug adapter).
run your tests from the command line:

node node_modules/mocha/bin/_mocha -u tdd --timeout 999999 --colors ./out/tests/

Now you should hit the breakpoint.
If you only want to run a single test, just add .only to the test like this:
test.only('should run program to the end'...

@weinand thanks for making it clear! It works as charm.

@weinand I'am using vscode 1.1.0 on Windows10, my breakpoint set on a ts file does not get hit. But when I set stopOnEntry to true, vscode can stop at the first statement in the ts file, at this moment, if I set a new breakpoint, the new breakpoint will just work!! I noticed that at the left below corner of debug view, in the BREAKPOINTS window, the breakpoint that can not get hit that I'v set when in editing mode, is displaying √ main.ts 6 src, which src is correct dir of this file, and the breakpoint that gets hit that I've set in debug mode is displaying √ main.ts 6 \.
What would cause this?
My config:
{
			"name": "Launch",
			"type": "node",
			"request": "launch",
			"program": "${workspaceRoot}/src/main.ts",
			"stopOnEntry": false,
			"args": [],
			"cwd": "${workspaceRoot}",
			"preLaunchTask": "default",
			"runtimeExecutable": null,
			"runtimeArgs": [
				"--nolazy"
			],
			"env": {
				"NODE_ENV": "development"
			},
			"externalConsole": false,
			"sourceMaps": true,
			"outDir": "${workspaceRoot}/dist"
		},

My tsconfig.json
{
	"files": [
		"src/main.ts"
	],
	"compilerOptions": {
		"noImplicitAny": true,
		"target": "es6",
		"module": "commonjs",
		"sourceMap": true,
		"allowJs": true,
		"outDir": "./dist"
	}
}

I also stumbled on this problem today and after spending several hours trying to figure what I was doing wrong, I found that when setting up the launch configuration, the "program" setting must be set like this:
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
and not like this:
"program": "${workspaceRoot}/node_modules/mocha/bin/mocha",

I have a similar problem. Here's my configuration:
{
    "name": "Run Tests",
    "cwd": "${workspaceRoot}",
    "program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
    "args": [
        "-u", "tdd",
        "--timeout", "999999",
        "--colors",
        "${workspaceRoot}/.js/tests/**/*.js"
    ],
    "runtimeArgs": [
        "--nolazy"
    ],
    "sourceMaps": true,
    "outFiles": [
        "${workspaceRoot}/.js/*"
    ],
    "type": "node",
    "request": "launch"
}

If I put a breakpoint on the js file, than it redirects me to the typescript version. However, without the corresponding .js file opened it won't work.

The outfiles glob pattern looks wrong. Please try "${workspaceRoot}/.js/**/*.js"

@weinand thanks, that works now!

@weinand  @samiraguiar Thank you, this works now!

For breakpoints to work, I had to set protocol to inspector:
    {
        "type": "node",
        "request": "launch",
        "name": "Mocha Tests 2",
        "program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
        "protocol": "inspector",
        "args": [
            "-u",
            "tdd",
            "--no-timeouts",
            "-r",
            "ts-node/register",
            "--colors",
            "${workspaceRoot}/app/**/*.spec.ts*"
        ],
        "outFiles": [
            "${workspaceRoot}/dist"
        ],
        "sourceMaps": true,
        "cwd": "${workspaceRoot}",
        "runtimeExecutable": null,
        "internalConsoleOptions": "openOnSessionStart",
        "stopOnEntry": false,
        "env": {
            "NODE_ENV": "testing"
        },
        "skipFiles": [
            "node_modules/**/*.js",
            "<node_internals>/**/*.js"
        ]
    },

@brennanMKE the "outFiles" attribute expects glob patterns. Please use "${workspaceRoot}/dist/**/*.js"

@PaulStovell Thank you. It fixed the issue to me

I hit this issue today. I had a config almost identical to Paul Stovell above. But it didn't work even with protocol: inspector.
I found this article: https://saravanaj.github.io/2017/02/05/debugging-mocha-tests-written-in-typescript-with-visual-studio-code/ which indicated to run it against the js files instead of through ts-node. So my task becomes:
{       "name": "Debug mocha",       "type": "node",       "request": "launch",       "program": "/Users/rgilling/.nvm/versions/node/v7.2.1/bin/_mocha",       "stopOnEntry": false,       "args": ["--no-timeouts", "dist/**/*.spec.js"],       "cwd": "${workspaceRoot}",       "runtimeExecutable": null,       "sourceMaps": true,       "outFiles": ["${workspaceRoot}/dist/**/*.js"],       "env": {         "NODE_ENV": "test",         "quiet": "false"       }     },
Then when I set break point within the ts code it works fine. Trying to run it through  ts-node was not working....

@rgilling I'm not sure that mocha understands a glob pattern argument:
"args": ["--no-timeouts", "dist/**/*.spec.js"],

I just specify the folder with the tests (generated JavaScript):
"args": ["--no-timeouts", "dist"],

@weinand - glob works okay with mocha, I'm trying to add some consistency between the angular 2 code and Node, which is why I'm migrating server code to Typescript. So now my units tests are in the same directories as the regular code, which is a similar layout to angular-cli projects.

@rgilling I have the same issue, but I am only writing JS not TS.. can't hit breakpoints still

@f0ster you do not have the same issue if you are not using TS. Please read https://github.com/Microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions and create a new issue:

Do not add your issue as a comment to an existing issue unless it's for the identical input. Many issues look similar, but have different causes.


Can't reconstruct surface from point cloud with constant x, y or z coord

Hi Marco. Thanks a lot for Vedo, great project !
I'm struggling at the moment with the function reconstruct_surface. I am unable to reconstruct surfaces from point cloud that are normal to either x, y, or z vector. Looks like somewhere in VTK a division by zero happens. Relevant error: ERROR: In vtkLookupTable.cxx, line 173 vtkLookupTable (0000016FCC469B90): Bad table range: [1e+299, -1e+299]
I wonder if there's something that can be done in Vedo to prevent that or if it's just the maths that VTK implement that create this issue.
By the way i'm also wondering why reconstructed surface show wider range than that of the point cloud. Do you have any insight on this ?
Here is a piece of code that reproduces the issue with divisions by zero (ran it on vedo 2023.4.6). Let me know if you need more information
Have a nice weekend
import numpy as np
from colorcet import bmy
from scipy.spatial.transform import Rotation
from vedo import Points, show

def add_reconst(n, i_color=2):
    # build mesh & color
    p = Points(np_pts)
    m = p.reconstruct_surface()
    m.cmap(input_cmap=bmy, input_array=m.points()[:, i_color]).add_scalarbar()
    # fill result tables
    names.append(n)
    pts.append(p)
    mesh.append(m)

names = []
pts = []
mesh = []

# x, y grid
x, y = np.meshgrid(np.linspace(0, 1), np.linspace(0, 1))

# grid with constant z=0
np_pts = np.column_stack((x.ravel(), y.ravel(), np.zeros_like(x.ravel())))
add_reconst("z=0")

# grid with constant z=1
np_pts[:, 2] = 1
add_reconst("z=1")

# grid with varying z
np_pts[:, 2] = np.sin(np_pts[:, 0])
add_reconst("sin z")

# constant y
np_pts[:, 2] = np_pts[:, 1]
np_pts[:, 1] = 0
add_reconst("y=0", 1)

# constant x
np_pts[:, 1] = np_pts[:, 0]
np_pts[:, 0] = 0
add_reconst("x=0", 0)

# rotated plan
r = Rotation.from_euler("xyz", [30, 40, 60])
np_pts = r.apply(np_pts)
add_reconst("tilted")

# original data
np_pts = np.column_stack((x.ravel(), y.ravel(), np.zeros_like(x.ravel())))
np_pts[0, 2] += np.finfo(float).eps
add_reconst("z=0 with eps")

show([t for t in zip(names, pts, mesh)], N=len(mesh), axes=1)

Hi @ldouteau
that's because you have a zero range in x (or y or z). Consider this:
import numpy as np
from colorcet import bmy
from vedo import Points, Grid, show

def add_reconst(n, i_color=2):
    # build mesh & color
    p = Points(np_pts)

    bb = list(p.bounds())
    if bb[0] == bb[1]:
        bb[1] += 1
        bb[0] -= 1
    if bb[2] == bb[3]:
        bb[3] += 1
        bb[2] -= 1
    if bb[4] == bb[5]:
        bb[5] += 1
        bb[4] -= 1

    m = p.reconstruct_surface(bounds=bb)
    m.cmap(bmy, input_array=m.points()[:, i_color]).add_scalarbar()
    names.append(n)
    pts.append(p)
    mesh.append(m)

names = []
pts = []
mesh = []

grid = Grid(res=(20, 20))

# grid with constant z=0
np_pts = grid.clone().points()
add_reconst("z=0")

# grid with constant z=1
np_pts = grid.clone().z(1).points()
add_reconst("z=1")

# grid with varying z
np_pts = grid.clone().points()
np_pts[:, 2] = np.sin(np_pts[:, 0])
add_reconst("sin z")

# constant y
np_pts = grid.clone().rotate_x(90).points()
add_reconst("y=0", 1)

# constant x
np_pts = grid.clone().rotate_y(90).points()
add_reconst("x=0", 0)

# rotated plan
np_pts = grid.clone().rotate_x(90).rotate_y(40).rotate_z(60).points()
add_reconst("tilted")

show([t for t in zip(names, pts, mesh)], N=len(mesh), sharecam=False, axes=1)

BTW i love:
show([t for t in zip(names, pts, mesh)], N=len(mesh), sharecam=False, axes=1)

I never thought of doing it that way! :)

By the way i'm also wondering why reconstructed surface show wider range than that of the point cloud. Do you have any insight on this ?

that is because the pointcloud is embedded in a volume that is necessarily a box aligned to the cartesian axes.

Hi @marcomusy. Thanks for your answer, that's exactly what i was looking for. Imo it would be nice if reconstruct_surface could include a check over the values of x, y, z. Some thing like
bounds = self.bounds()
for i in range(3):
    # Extend bounding box when we have constant variable
    if bounds[2 * i + 1] == bounds[2 * i]:
        bounds[2 * i] -= 10 * np.finfo(float).eps
        bounds[2 * i + 1] += 10 * np.finfo(float).eps
    # Build the bounding box including padding
    dx = padding * (bounds[2 * i + 1] - bounds[2 * i])
    bounds[2 * i] -= dx
    bounds[2 * i + 1] += dx

I'll let you decide on this.
Also thanks for the tips on Grid, i'm never sure how to use it


Fix the API to send null instead of maximum integer when the rows processed limit is not set

Fixed not later than https://github.com/odalic/sti/commit/f23eed47e82fc316bdc313df2fa435f3a41ebb75 .


Reg:Streaming command exited with status 1

Hi,
I am evaluating a situation in which backend sink will fail i saw that the server keeps trying to connect to backend as i have set it in daemonize mode.If i have to stop it after some number of retry where should i put the condition i saw src/conn_handler.c  file is handling it ,clarify if i am wrong.

i would also like to know if the backend sink is down what will happen to data .will it flush the complete data after flush interval?
and will it keep on trying continousoly?

@priya23 statsite will invoke the sink only once and send the data. Most of the sinks implement retry logic to talk to the backend (for example the graphite sink), however statsite does not have any retry logic itself, as its invoking a local handler and does not expect network failures. Hope that helps!


Will this project feature more than aria2?

Does the project know that the rpc protocol is supported? I don't understand c++, but I like .net and look forward to the monotorrent feature and user experience better than aria2.

I don't intend to write a full replacement for aria2. That would be beyond the scope of this particular library.
An RPC protocol would be trivial to create if someone wanted to create a daemon, similar to aria2, which could be used to download in the background. The rpc calls would be used to interact with the daemon, rather than monotorrent itself, though.
Hope that helps, and thanks for the support!


[Google Meet] ...

Extension
https://www.raycast.com/vitoorgomes/google-meet
Description

Didn't copy the Meet link. It remains frozen in the 'Creating meeting...' state.
Steps To Reproduce

Open Raycast
Open command 'Create Meet'

Current Behaviour
No response
Expected Behaviour
No response

Vivaldi. It’s working now (:
On 29 July 2023 at 20:04:29, Vitor Gomes @.***) wrote:
Extension
https://www.raycast.com/vitoorgomes/google-meet
Description
[image: image]
https://user-images.githubusercontent.com/16434211/250207314-8290f9b1-539b-4c6b-b5f5-83d748f0d617.png
Didn't copy the Meet link. It remains frozen in the 'Creating meeting...'
state.
Steps To Reproduce

Open Raycast
Open command 'Create Meet'

Current Behaviour
No response
Expected Behaviour
No response
Hey there @crisneda https://github.com/crisneda
Could you tell me which browser were you trying to open it with?
I'm fixing this problem and testing on a lot a browsers, would be nice to
see if yours is one of the ones that I'm testing against or not
—
Reply to this email directly, view it on GitHub
https://github.com/raycast/extensions/issues/7342#issuecomment-1656970996,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD5MIIYN52INMLZBXCKGBHDXSWQI3ANCNFSM6AAAAAAZ2LSLRU
.
You are receiving this because you were mentioned.Message ID:
@.***>


PDB cannot be loaded from SymbolSource

Hi
As explained #236  I'm trying to load the pdb from http://srv.symbolsource.org/pdb/public but is seems to be down.
Does nlog still use symbolsource?

Symbols nuget-packages are being created, and they should be pushed to SymbolServer.
But can see that PullRequest also attempts to publish to SymbolServer. This should probably be stopped.
But I guess @304NotModified performs the final publish to nuget. Not sure if this includes the symbols-package:
https://www.appveyor.com/docs/deployment/nuget/
There is also this command:
dotnet nuget push [PACKAGE].nupkg

This command automatically pushes the primary package to nuget.org and the symbol package to the official Nuget symbols source: symbolsource.org.

https://geeklearning.io/how-to-debug-a-net-core-nuget-package/

Hi
Thanks for the info, I see this is the default setup but it doesn't mean anything is symbolsource.org fails to load... So I have to wait for them to fix I think.

Think we could try and change NLog to have the following (Only works for netstandard + net471):
<DebugType>embedded</DebugType>
https://github.com/rgl/example-dotnet-source-link
This can then be combined with Microsoft.SourceLink.GitHub:
<PackageReference Include="Microsoft.SourceLink.Vsts.Git" Version="1.0.0-beta-63127-02" PrivateAssets="All"/>

I think symbolsource.org is having a bad time, now the site is not even available.
So it would be great to have an alternative.

You can see something here (Search for SourceLink in the page below):
https://blogs.msdn.microsoft.com/dotnet/2018/05/30/announcing-net-core-2-1/

:) nice!

Hi
So it seems currently symbolsource is down, and we don't have an alternative way to debug NLog nuget package.
I have 1 NullReference exception I see at my application startup and 1 KeyAlreadyExists exception with NLog.Targets.Gelf package which I'm trying to solve. The best way seems to go from the source code.

@emresebat One can usually get very far with the Exception.StackTrace. But yes this is something to improve upon. Maybe create a PullRequest?

Starting today, you can publish symbol packages to the NuGet.org symbol server.

https://blog.nuget.org/20181116/Improved-debugging-experience-with-the-NuGet-org-symbol-server-and-snupkg.html


agent option "stop agent from taking new tasks" not working

version: 8d625788461eacfbb3645a40c4ef099cb2737afb do not respect this option

If https://ci.woodpecker-ci.org/repos/3780/pipeline/10780/9 is using the autoscaler then this issue might be causing the
Oh no, we got some errors!
Canceled

When an agent is shut down while processing a pipeline, this is sometimes the error message woodpecker shows.

Good catch.

I checked again and with my agent in the debugger it seems to work and stops in https://github.com/woodpecker-ci/woodpecker/blob/619858e0e96743dc72079b5f1989a2f415138119/server/grpc/rpc.go#L68

2.1.1, Kubernetes - doesn't work.

The issue seems to be that the agent is long-polling and as soon as its inside of the queue.Poll()  loop it wont recognize updates to NoSchedule.