Generic Map without parameters

I am studying the MVCSiteMapProvider to use it in my company project, and we decided to use the Dynamic Node approach to build the map.
We have a table with our Areas, Controller and Actions mapped to give the permissions per user, I would like to use this same table to populate my Dynamic Nodes, the problem is when I am mapping an action that need parameters.
I found two solutions for this situation:
1 - Generate an new Node for each record in my database
2 - Use the "PreserverRouteParameter" property
But in this second option I need to know the name of my parameter, and I don't have this information in my database.
There is no way to map a action and just ignore the parameters?

We ran into a similar issue where we wanted to match on controller & action without using preserverRouteParameters.   Allowing parameters to be ignored would be very usefull.
Our work around was to add an action filter to dynamically inject all parameters into the RouteValues for the node.  This forces mvcSiteMapProvider to match without preserverRouteParameters.  To make it work you associate the filter with your actions and set key="{controller}.{action}" for the nodes so the action filter can find them and stuff the route values.
You can see the code for the MvcSiteMapIgnoreParameters filter on issues/404
Note: If you are using area modify the code and key to: {area}.{controller}.{action}

@NBONDEZANMERRION
I am not sure how you would expect that to work.  The relationship is 1-1. This ensures the combination can only match 1 node and skip all of the other nodes that don't match. It also ensures you can get a match regardless of how many parameters or how complex the configuration.
<mvcSiteMapNode title="Product 1" controller="Product" action="Details" preservedRouteParameters="id"/>

The effect of using preservedRouteParamters overrides the default behavior. This creates a 1-many relationship, effectively matching any id (and preserving it so it will be used to construct the URL of the matching node and any ancestor nodes). It is effectively the same as this (and I have been considering adding this alternative syntax because it is easier to understand).
<mvcSiteMapNode title="Product 1" controller="Product" action="Details" id="*"/>

What you are proposing, would effectively be:
<mvcSiteMapNode title="Product 1" controller="Product" action="Details" *="*"/>

But that would always match the first node regardless of what additional parameters are on it, since the first match (not necessarily the best match) always wins.
You say that "those keys are not in your database", but that is not typically the case in any MVC application. Generally speaking you would configure the route keys into the node, much as you would with your keys in .NET routing and they would typically be either XML or .NET attribute based nodes, since using dynamic nodes would not be necessary in this case (although it is certainly possible).
If you were using dynamic node providers, you could just create a separate provider for each database table and hard-code the preserved route parameters (route keys) much as you would in the XML or .NET attribute configuration (or your .NET routing configuration for that matter), since a typical design treats all of the records in a table similarly.

Just what information is in your database and how is your routing configured so that MVC can match a URL to a database record in your case?
Just how many different route values could there be in your configuration that it would be impractical to specify them explicitly?
How did you get around that in your routing, since it typically requires you to specify route keys explicitly?
How did you get your route configuration to work with MVC (MvcSiteMapProvider node URLs work almost exactly the same way that ActionLink works)?

Do note that if you specify a key in preservedRouteParameters that doesn't happen to exist in the URL, it will simply not be considered as part of the match. So, even if you have 15 different parameters that may or may not exist in the URL, it wouldn't be such a big deal to specify them all, which would effectively "ignore" all 15 and carry the existing ones over so when your link URLs are generated they will exist there as well.
Also note that if you are using query strings, they are always ignored by default.
Furthermore, if you are using URL slugs in your database, you can always configure your nodes with URLs instead of with route values, and then you don't need an explicit route configuration in MvcSiteMapProvider. But I would definitely recommend using dynamic node providers (or ISiteMapNodeProvider) to load your URLs from the database if you go this route.
<mvcSiteMapNode title="Product 1" url="~/product-1" />

We have a table with our Areas, Controller and Actions mapped to give the permissions per user, I would like to use this same table to populate my Dynamic Nodes, the problem is when I am mapping an action that need parameters.

The recommended approach is to always load all nodes for all users, since caching will prevent anything from being truly dynamic (the name for "dynamic node provider" was a poor design choice), and then you can use one of the following approaches from these answers to show the nodes that correspond to the current user.
http://stackoverflow.com/questions/26541338/load-an-xml-sitemap-into-mvcsitemapprovider-based-on-user-role
http://stackoverflow.com/questions/19625384/how-to-render-specific-sitemap-section-using-mvcsitemapprovider/19666647#19666647


Internal Server Error when trying to deserialise body when Content-Type is not application/json

I get the following error when trying to hit "/register" with incorrect Content-Type as text/plain

[2020-06-11 10:15:12,484] ERROR in app: Exception on /register [POST]
Traceback (most recent call last):
File "/home/aguru/.local/lib/python3.7/site-packages/flask/app.py", line 2447, in wsgi_app
response = self.full_dispatch_request()
File "/home/aguru/.local/lib/python3.7/site-packages/flask/app.py", line 1952, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/aguru/.local/lib/python3.7/site-packages/flask/app.py", line 1821, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/aguru/.local/lib/python3.7/site-packages/flask/_compat.py", line 39, in reraise
raise value
File "/home/aguru/.local/lib/python3.7/site-packages/flask/app.py", line 1950, in full_dispatch_request
rv = self.dispatch_request()
File "/home/aguru/.local/lib/python3.7/site-packages/flask/app.py", line 1936, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/usr/local/lib/python3.7/dist-packages/flask_pydantic/core.py", line 131, in wrapper
b = body(**body_params)
TypeError: ModelMetaclass object argument after ** must be a mapping, not NoneType
<IP_ADDRESS> - - [11/Jun/2020 10:15:12] "POST /register HTTP/1.1" 500 -

Postman

Code
from flask import Flask
from flask_pydantic import validate
from pydantic import BaseModel
from typing import Optional

app = Flask(__name__)

class BodyModel(BaseModel):
    service: str
    details: Optional[str]

class ResponseModel(BaseModel):
    uuid: str
    status: Optional[str]

@app.route("/register", methods=["POST"])
@validate(body=BodyModel)
def register_service_request():
    # save model to DB
    uuid = "uuid"

    return ResponseModel(uuid=uuid), 202

app.run()

I would have expected either:

Should it be Bad Request (or may be Validation Error) instead? We are expecting a json here but got text?
Try to get_json (force=True) even when Content-Type is not application/json. (Does not seem to be proper way of doing it though)

@bauerji Your thoughts?

Hello @adityaguru149,
I propose another solution: since you defined a request body model, you are expecting application/json content type. If the request has some other content type then the response should have 415 - unsupported media type status.


No panic init variant

Added a try_init_with() that doesn't panic but returns an Option.

What is the use case for a try_ variant? StaticCell is supposed to be used at program startup to initialize global things once. At that point you know for sure it's not initialized, so the panic can't happen.

It would allow for a custom panic message via .expect() when static-cell is used as a depencency in a crate.

Please consider accepting this PR or provide another method like is_used to allow a check before calling init. There are use cases for this crate that would benefit of it.

Thank you!


Bump to version 1.1.0

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cf902ed). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage          ?   98.28%
=========================================
  Files             ?       13
  Lines             ?      467
  Branches          ?       78
=========================================
  Hits              ?      459
  Misses            ?        0
  Partials          ?        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf902ed...2752770. Read the comment docs.


This adb server's $ADB_VENDOR_KEYS is not set

when I click grant (any red grant button) I get a error message pop up:

adb: device unauthorized.
This adb server's $ADB_VENDOR_KEYS is not set
Try 'adb kill-server' if that seems wrong.
Otherwise check for a confirmation dialog on your device.

killing the adb server doesn't seem to help
Pixel 7, android 14, Build UQ1A.240105.004
Debian Bookworm, kernel up to date
I tried on cli and got a similar error:
$ adb shell
adb server version (40) doesn't match this client (41); killing...

daemon started successfully
adb: device unauthorized.
This adb server's $ADB_VENDOR_KEYS is not set
Try 'adb kill-server' if that seems wrong.
Otherwise check for a confirmation dialog on your device.

Did you enable developer options and USB debugging on your phone?

Yep

Can you try toggling it off, clicking the "Revoke..." option, then turning it on again and see if a popup shows up asking you to accept the connection?

I did that, but nothing in the linux app changed.  I was however able to use adb on the commandline to grant the permissions after doing that.  I got the expected "allow this key to debug" message on the phone, approved it, and sdb shell then worked without error.  So manual ADB from apt works.  just not this app.
I thought I might try to get you the app version number for debugging purposes:
bcroan@x360:~/.config/systemd/user$ com.joaomgcd.taskerpermissions -version
libva error: /usr/lib/x86_64-linux-gnu/dri/i965_drv_video.so init failed
Running chmod chmod 755 /opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb
chmod result {
code: 1,
out: '',
error: "chmod: cannot access '/opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb': Not a directory\n"
}
Running command line Server /opt/com.joaomgcd.taskerpermissions/bin/linux/adb devices -l
Command line result {
code: 0,
out: 'List of devices attached\n\n',
error: "adb server version (41) doesn't match this client (40); killing...\n" +
'* daemon started successfully\n'
}
but --version just threw that error.   Interesting...  I wonder what version the adb is that you include in your app...
so I ran:
bcroan@x360:~/.config/systemd/user$ /opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb --version
bash: /opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb: Not a directory
What???
bcroan@x360:~/.config/systemd/user$ /opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb
bash: /opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb: Not a directory
bcroan@x360:~/.config/systemd/user$ file /opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb
/opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb: cannot open `/opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb' (Not a directory)
bcroan@x360:~/.config/systemd/user$ ls -l  /opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb
ls: cannot access '/opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb': Not a directory
bcroan@x360:~/.config/systemd/user$ ls -l  /opt/com.joaomgcd.taskerpermissions/resources/
/opt/com.joaomgcd.taskerpermissions/resources/:
total 1060
-rw-r--r-- 1 root root 1085004 Jan 25  2022 app.asar
bcroan@x360:~/.config/systemd/user$ ls -l  /opt/com.joaomgcd.taskerpermissions/resources/app.asar
-rw-r--r-- 1 root root 1085004 Jan 25  2022 /opt/com.joaomgcd.taskerpermissions/resources/app.asar
bcroan@x360:~/.config/systemd/user$ /opt/com.joaomgcd.taskerpermissions/resources/app.asar
bash: /opt/com.joaomgcd.taskerpermissions/resources/app.asar: Permission denied
bcroan@x360:~/.config/systemd/user$ file /opt/com.joaomgcd.taskerpermissions/resources/app.asar
/opt/com.joaomgcd.taskerpermissions/resources/app.asar: Electron ASAR archive, header length: 2587 bytes
bcroan@x360:~/.config/systemd/user$
So the adb you use is extracted at runtime and deleted after?
if it helps:md5sum /opt/com.joaomgcd.taskerpermissions/com.joaomgcd.taskerpermissions
09bb8add8b6dafd865d6df29c38f88cf  /opt/com.joaomgcd.taskerpermissions/com.joaomgcd.taskerpermissions

That shell error is a bit misleading.
$ /opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb --version
bash: /opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb: Not a directory
I tried to run adb --version.  and bash told me that's not a directory.  I believe "not a directory" applies to any one of the dirs in the path as I typed it.  Indeed app.asar, is not a directory.  it's a file for me.  But then why is it used as if it was a directory when I run:
com.joaomgcd.taskerpermissions -version
When you run "com.joaomgcd.taskerpermissions -version" do you see an error message?

Where exactly would I run that command? In what folder?

I am getting this error as well on linux after it seemed to work previously (got to a different error though)
on linux "com.joaomgcd.taskerpermissions -version" can be run in the terminal in any folder. I get this error message:
chmod: cannot access '/opt/com.joaomgcd.taskerpermissions/resources/app.asar/bin/linux/adb': Not a directory\n


1487 reflect the ske policy changes in our services

Important
Do NOT merge until 11 April. See Trello card for details
Context
Changes to the Subject Knowledge Enhancement (SKE) were announced last week.
From the 11th April, it means that some subjects will no longer be eligible for funding.

Primary Maths (03),
Design and Technology (DT),
English (Q3),
Biology (C1), and
Religious education (V6) are the subjects where this policy applies.
All other subjects, eligible for SKE, will continue to be funded.

We need to:
Remove references to SKE funding being available in said subjects. (Publish, Apply, Find)
Prevent providers from setting SKE as a condition of offer for the affected subjects. (Manage)
Changes proposed in this pull request
NOTE: We are not doing a data migration to change any existing SKE conditions for these subjects. There will comms directly to providers about this and they will decide how they wish to proceed.

Remove references to the subjects no longer receiving SKE funding
Remove the religious education specific logic that is no longer needed (RE is no longer funded)
Update all related specs. This included removing 'should' where required.

Guidance to review
Are there other areas to consider? Anything I'm missing?
Link to Trello card
https://trello.com/c/hUwTntvP

Code looks good. Only consideration is for:
What to do with the existing offers for that has these subjects that we removed as SKE condition?
But I see that you asked on the Trello ticket, so should we manual test having a SKE record for any of the remove subject and go to manage and remove the SKE condition? It should work btw, just me being cautious.

Hi Tomas, The content / policy people are coming up with a solution as it will come down to the provider to make a decision about what to do for each offer. A part from drawing up a list of relevant offers, there won't be a technical intervention.

 Reflect the SKE policy changes in our services


Testing UI tests reliability in workflow actions

Testing UI tests in the workflow
This is just to see if I can improve the reliability and stability of the UI tests in the workflow actions
Checklist
Before raising your pull request:

[ ] Commit messages that conform to conventional commit messages
[ ] Ran the app locally ensuring it builds
[ ] Ran the tests locally ensuring they pass on Build
[ ] Pull request has a clear title with a short description about the feature or update
[ ] Created a draft pull request if it is not yet ready for review

Before your pull request can be reviewed:

[ ] Met all of the acceptance criteria specified in the user story on Jira

[ ] Reviewed your own code to ensure you are following the style guidelines

[ ] Ran the app and tested the feature on a range of device sizes
Please include iPod Touch, iPhone SE and iPhone 11 as a minimum.

[ ] Written Unit and Integration tests if needed

[ ] Met all accessibility requirements?

[ ] Checked dynamic type sizes are applied
[ ] Checked VoiceOver can navigate your new code
[ ] Checked a user can navigate only using a keyboard around your new code

Before merging your pull request:

[ ] Ensure that the code coverage and SonarCloud checks have passed
[ ] Actioned and resolved all comments, reaching out to reviewers for clarifications if necessary.
[ ] Ran the app to ensure that no regressions have been caused by changes during code review.

Closing this PR as the work is now included in https://govukverify.atlassian.net/browse/DCMAW-7722


A user's dark-mode settings are not respected

We may need to consult JP on this as the color scheme completely changes.

Isn't the problem that "the user's dark mode settings are only sometimes respected"? An easier problem to solve, no?


Infrastructure Setup

This seems to be failing because no migrations. Otherwise working though!
@webofbits if you're ok with it we can merge this in.


FileHandle is not Clone

When using async functionality in Iced, one uses a Message type that must be Clone in practice.
To be able to use rfd's AsyncFileDialog in Iced, it would be nice if FileHandle could implement Clone.

Since https://github.com/PolyMeilex/rfd/pull/216 got merged, can this be closed now?
Or would you like to wait until a new release of this crate is done?

Thank you for the fix! It will be useful.
I don't mind if this issue is closed. You can do as you prefer.


Weird behaviour when LayoutF returns small sizes, e.g. 1.33,1.00

Ebitengine Version
2.7.3
Operating System

[ ] Windows
[ ] macOS
[X] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] PlayStation 5
[ ] Xbox
[ ] Web Browsers

Go Version (go version)
go version go1.22.2 linux/amd64
What steps will reproduce the problem?
Run this code, and provide your own image in the "resources/" directory.
// Package main...
package main

import (
	"embed"
	"image"
	_ "image/png"
	"log"

	"github.com/hajimehoshi/ebiten/v2"
	"github.com/hajimehoshi/ebiten/v2/inpututil"
)

//go:embed resources/*
var resources embed.FS

type game struct {
	outsideWidth  float64
	outsizeHeight float64
	width         float64
	height        float64
	m             *ebiten.Image

	x  float64
	y  float64
	dx float64
	dy float64
}

func (g *game) Layout(_, _ int) (int, int) {
	// As game implements the interface LayoutFer, Layout is never called and LayoutF is called
	// instead. However, game has to implement Layout to satisfy the interface Game.
	panic("windowsize: Layout must not be called")
}

func (g *game) LayoutF(outsideWidth, outsideHeight float64) (float64, float64) {
	// Target ratio is 1.33/1, basically aiming for 4/3 ratio, but keeping the screen unit size to
	// be 1. If the screen is wider, keep height at 1, and extend the width to whatever calculation
	// yields, e.g. 2.5/1. If the screen is taller on the other hand, then keep the height at 1.33
	// and make the height as small as required, e.g. 1.33/2.

	if outsideWidth == g.outsideWidth && outsideHeight == g.outsizeHeight {
		return g.width, g.height
	}

	g.outsideWidth = outsideWidth
	g.outsizeHeight = outsideHeight

	targetRatio := 4.0 / 3.0
	ratio := outsideWidth / outsideHeight

	if ratio > targetRatio {
		g.width = ratio
		g.height = 1
	} else {
		g.width = targetRatio
		g.height = outsideHeight * targetRatio / outsideWidth
	}

	log.Printf("Layout: %.2f:%.2f\n", g.width, g.height)

	return g.width, g.height
}

func (g *game) Update() error {
	if ebiten.IsKeyPressed(ebiten.KeyAlt) && inpututil.IsKeyJustPressed(ebiten.KeyEnter) {
		ebiten.SetFullscreen(!ebiten.IsFullscreen())
	}
	return nil
}

var ox float64
var oy float64

func (g *game) Draw(screen *ebiten.Image) {
	screen.Clear()

	imageSize := g.m.Bounds()

	var op ebiten.DrawImageOptions
	op.GeoM.Scale(1/float64(imageSize.Dx()), 1/float64(imageSize.Dy()))
	// op.GeoM.Scale(0.5, 0.5)
	tx := g.width/2 - 0.5
	ty := g.height/2 - 0.5
	if tx != ox || ty != oy {
		ox = tx
		oy = ty
		log.Printf("Translate: %.3fx%.3f\n", tx, ty)
	}
	op.GeoM.Translate(tx, ty)

	screen.DrawImage(g.m, &op)
}

func main() {
	file, err := resources.Open("resources/512-x-512-32-bit-png-with-alpha-11.png")
	if err != nil {
		log.Fatalf("Failed to open image file: %s\n", err)
	}
	m, format, err := image.Decode(file)
	if err != nil {
		log.Fatalf("Failed to open image file: %s\n", err)
	}
	log.Printf("Image type: %s\n", format)

	ebiten.SetWindowTitle("shooter")
	ebiten.SetVsyncEnabled(true)
	ebiten.SetWindowResizingMode(ebiten.WindowResizingModeEnabled)

	options := &ebiten.RunGameOptions{
		X11ClassName:    "shooter-class-name",
		X11InstanceName: "shooter-instance-name",
	}

	game := &game{
		width:  4,
		height: 3,
		m:      ebiten.NewImageFromImage(m),
	}

	if err := ebiten.RunGameWithOptions(game, options); err != nil {
		log.Fatal(err)
	}
}

What is the expected result?

The rectangle image should be centered.
Image should stay centered when resizing the window.
Image should show contents properly, and not just colored rectangle.

What happens instead?
Image stays in place until the window size crosses some boundary; then the image jumps to new place and stays in place until next "boundary".
Anything else you feel useful to add?
I am guessing, but it seems that internally engine is using integers, so using floats for drawing, sizing etc like I do hits some rounding issue internally. I.e. the engine cannot work with pure floats.

Would it be possible to minimize the reproducible case more? Thanks

1.33,1.00

You mean the size less than 2...?

Yes. I wanted to make scalable UI/game, so that at any resolution I am drawing in 0..1 coords.
I will try to simplify the code tomorrow.

This means the screen size is only 1 or 2 pixels. Ebitengine doesn't expose the texels (0-1).

... well, then I am not understanding the documentation. LayoutF allows for float return size, and the docs say:
Even though the outside size and the screen size differ, the rendering scale is automatically adjusted to fit with the outside. I interpret this that whatever size I return from Layout will be scaled to physical window size. So, I don't see a difference between 1.33,1.00, or 133,100, or 133000,100000. All these should be scaled to the same physical window, and hence should produce the same image.
If there is expectation for Layout() to return size in pixels, then I do not understand LayoutF(). What would the meaning of e.g. return 640.445, 320.128 mean? Fractional pixel sizes?

There is expectation both for Layout and LayoutF to return size in pixels. Returning 640.445, 320.128 at LayoutF means the internal offscreen framebuffer size is (probably) 641 and 321, and 640.445, 320.128 are also used to the scale of the offscreen framebuffer to the final screen framebuffer.

Fair enough. I still do not understand your explanation for fractional pixel sizes returned from LayoutF(). But I don't have to understand it. I would just kindly ask to add a comment to Layout() that the return should be in pixels. That would make it obvous that e.g. 1.33 would show only a single pixel. The issue can be closed if you agree.

Sure, I'll add more comments. Thanks!


List Messages, Move Single Message or All Messages

Added ability to list messages in the -src queue, move a single message from -src to -dest by specifying the MessageId.

Merge back to master


[QUESTION] How to set Authorization Header Swagger Definition

I want to have a definition of my auth mechanism in the generated Swagger JSON but can't figure out how to do it.
I would like to do it without passport so i can avoid a bigger refactoring of my current strategy.
The least i would like to achieve is to add a required header field to any method decorated by my custom "@Auth" decorator.
For the custom decorator i followed the dos here:
https://tsed.io/docs/authentication.html#create-your-auth-decorator
But they seem to be outdated or wrong.
they mention the "Operations" decorator but it is marked as deprecated.
And in the code they use the "In" decorator(?) but this one does not work for me.
Bonus points:
Would be nice if i could somehow instruct ts.ed to insert the auth strategy / how to do auth into the swagger so i could use the "authorize" button inside swagger ui

@jappyjan The documentation doesn't mention the @Operation decorator but the @In.
For me the example works:
@Controller("/dashboard")
class DashboardCtrl {
  @Get("/")
  @CustomAuth({role: "admin", scopes: ["email", "firstname"]})
  public getResource() {
  }
}

But the decorator doesn't work is you use it on class, @In doesn't support usage on class.
To configure security options you have to give the spec information on server level:

@Configuration({
swagger: [
    {
      path: "/doc",
      spec: {
        info: {
        },
        securityDefinitions: {
          // add you security definitions
        },
      }
    }
  ],

})
export class Server {

}

I'll try to rewrite the example ;)

What is your Ts.ED version?

Hello @jappyjan
v6.3.0 fix some issue on Swagger documentation.
I also rewritten examples on authentication page and added a sandbox example: https://tsed.io/docs/authentication.html
See you
Romain

I'm using version 5.65
Thanks for the hint to v6... upgrading helped 👍

Cool :)


The product's image is cropped in mobile view in wishlist page.

Issue Description
After adding the product to the wishlist and then inspecting the details in mobile view we can see the images are not appearing properly.
Bagisto Version
MASTER
Steps To Reproduce
Store Front -> Add Product to wishlist -> Go to wishlist -> Inspect the details in mobile view.
Actual Result
Please check the screenshot for a better understanding of the issue.

Expected Result
The images at the wishlist should look clear.

I want to work on this, if it isn't resolved yet. If not this, then anything else related to development

@Sanjaybhattwebkul @ashishkumar-webkul  issue fixed #6832

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.


Example: pi1s1 = Z

I think that we now have enough stuff implemented to prove that the loop space of the circle is the integers. This would be a great example to try, and would provide a point of comparison with the Swedish implementation (https://github.com/mortberg/cubicaltt/blob/master/examples/helix.ctt).

As a start, we can start proving some basic results about equivalences, such as "adjointification" (which takes an isomorphism to an VV-style equivalence): https://github.com/RedPRL/sml-redprl/commit/fe9ababa096e054df778b9ed0cf6bc135eebf524
I still need to fill in the hard part of this theorem, which looks like it will be a very gnarly nested composition (at least, if the Swedish version is any indication: https://github.com/mortberg/cubicaltt/blob/a331f1d355c5d2fc608a59c1cbbf016ea09d6deb/examples/equiv.ctt)

We need #330 to reduce ($ f loop^2) to 2 by pure magic.

This was partially addressed by #420 and we need some machinery to proceed further.

When you have done this please let me know so that I can compare with what I have in cubicaltt.
A nice corollary that you could do once you have this is that the loop space of S^1 is a set. To prove this just transport the proof that Z is a set along the pi1(S^1) = Z equality. How complicated is the obtained term?

It would be great if we do not have to manually prove that
(S1-rec [_] (U 0 kan) (@ p 1) int [x] (@ IntSuccPath x))

is just
int

@favonia I was looking again at the "theorem" you sent me the other day which was currently hard to prove, and I realized that it's not well-typed:
Thm IntToS1LoopToInt/succ : [
  (-> [n : nat]
   (= int
    ($ S1LoopToInt ($ IntToS1Loop (succ n)))
    (succ ($ S1LoopToInt ($ IntToS1Loop n)))))
]

It's not well-typed, because nat is no longer a subtype of int, and also succ doesn't apply to integers.
Now, I did try replacing with int and IntSucc, but I didn't make much progress.


Bug Fixes and Reorder arrays

Reorder R(NT,3) to R(3,NT) because I usually access x,y,z in succession.
Also make several Bug Fixes that probably only affect me.

I am able to compile the code using params::pi in definition of constants. We should clear this up then merge these changes!


Ds.dataset() should be able to return partition column as datetime (if it is in ISO date format)

Describe the enhancement requested
Right now, ds.dataset() can include the partition key in the result if partitioning='hive' option is used.
However, this partition key column is returned as a str, though it used to be a date.
Would be nice, if it was returned as a datetime column, if it is in the standard ISO format.
import pyarrow.dataset as ds

mytab = ds.dataset("my_table_name", partitioning='hive').to_table()
print(mytab)

Calendar_date is the partitioning column.


Framework in the works?

Are there any plans to build a framework that ties redux, react, react-hot-loader, and webpack together? That in and of itself would be rather simple, but then the (also relatively simple) inclusion of generators would save thousands of collective hours and also help these tools gain popularity (Rails, for example, became quite famous for the "5-minute blog").
I also see the potential for built-in debugging tools (maybe via a plugin system), for truly Bret Victor-esque development, even beyond what @gaearon has demoed so far. Is this already in the works or should it be developed independently?

I don't have such plans but feel free to build one!
I'd be wary of fragmenting the community though.

I also see the potential for built-in debugging tools (maybe via a plugin system), for truly Bret Victor-esque development, even beyond what @gaearon has demoed so far.

This doesn't require a framework. Check out redux-devtools issues.

I am working on something almost exactly like this (with the minor exception of browserify instead of webpack).  When finished it will be called "moped" it will combine:

express - although it will probably work with any node.js web framework
browserify - via browserify-middleware extended to add hot-loading via browserify-react-live and browserify-patch-server
react
redux & react-redux
react-router
babel - with source maps supported by default

It will support seamlessly writing universal apps and have built in support for doing "Flux over the wire" style communication.  I also plan to build a plugin for real time using primus and another plugin for doing declarative queries via an @query decorator.  The @query plugin will also have full support for real-time.
It should then be possible to do a nice job of the "5 minute twitter clone" or the "5 minute chat room" or the "5 minute collaborative task list".
Although it's a little broken at the moment, and running on an out of date version of moped, you can see an example of what an app developed using this technology might look like at https://github.com/ForbesLindesay/chat-example/tree/master/app.

I do think that having a "framework" that shows you how to glue together a bunch of libraries can be useful. One of the big problems right now is that you need to sorta figure out how to glue em all together just to get a more complicated app up and running.
I know of at least one project that seems to be trying to tackle this: esex.

Rather than a framework, I might suggest an open-sourced production
application built using the ecosystem. Or better, several of them.
What worries me about a framework is that it locks in a certain
configuration of components from the ecosystem.
Getting real applications out in the open that use these awesome
innovations along with great zero-to-production walk-throughout/ tutorials
for building them is going to be one of my major goals.
On Mon, Aug 10, 2015 at 3:35 PM Cesar Andreu<EMAIL_ADDRESS>wrote:

I do think that having a "framework" that shows you how to glue together a
bunch of libraries can be useful. One of the big problems right now is that
you need to sorta figure out how to glue em all together just to get a more
complicated app up and running.
I know of at least one project that seems to be trying to tackle this:
esex https://github.com/esex/esex.
—
Reply to this email directly or view it on GitHub
https://github.com/gaearon/redux/issues/450#issuecomment-129577603.

My thinking is that a "framework" should never be more than a couple of hundred lines of code, and it should be an explicit goal that a user could rip out that framework and change to doing things manually with only minimal effort.

Thanks for the update @gaearon! And thanks @cesarandreu and @ForbesLindesay for sharing some existing work towards a framework.
@danmartinez101 An advantage of a framework over an open-sourced application is that you don't have to figure out where to start. You have generators to implement all the boilerplate for you, as well as sane defaults. It's a lot easier to dive in, get something minimal working, then keep learning as you go.
Since this issue is doesn't require any further action or answers, I'll close this (which doesn't mean folks can't still contribute to the conversation).

My personal preference for a "framework" here would be a starter kit/generator for each combination of React ecosystem libraries (using/not using Redux, React Router, RX, etc) that just gives enough boilerplate to glue stuff together without having too many opinions. Luckily there's already a bunch of these out in the wild :smile:
I guess a single generator could let you make these decisions step-by-step, but I had a bad experience with previous Yeoman generators when trying out Angular stuff, so I'm kind of scarred from that, haha.

Yeoman generator would be great actually as it is awesome entry point for newbies but I agree with @calesce on his concerns. I guess it is harder to maintain generator that some seed project. Because of that generators start to make some outdated stuff. And for the same reason if a generator behaves slightly different that you expect it is very hard to customize it.

Yeoman has its benefits, but fur redux, how much effort would it really
save anyone? There's really only one type of thing to generate (actions),
and the code output would probably be less than 10-15 lines of code. That's
my initial guess at least; I'd be interested to know what would actually be
possible there.
On Aug 12, 2015 7:05 AM, "Sergey Lapin"<EMAIL_ADDRESS>wrote:

Yeoman generator would be great actually as it is awesome entry point for
newbies but I agree with @calesce https://github.com/calesce on his
concerns. I guess it is harder to maintain generator that some seed
project. Because of that generators start to make some outdated stuff. And
for the same reason if a generator behaves slightly different that you
expect it is very hard to customize it.
—
Reply to this email directly or view it on GitHub
https://github.com/gaearon/redux/issues/450#issuecomment-130262343.

There also a lot of plugins and related packages that yeoman can handle, there could be react-router or not, lots of usage cases..

I think the big benefit would be being able to get up to speed faster.  For instance, with angular, everything is there for you, and the documentation explains everything you need to know.  With react, redux, babel, webpack, etc. there is a lot of up front time involved in getting everything configured and choosing best practices.  Although I must say a lot of these individual projects have great documentation, especially redux!
Boilerplates are useful, but not nearly as much as if everything was packaged into a framework of some sort.
It's tricky because everyone has different use cases and different library and best practice preferences.  If there were one framework that had sane defaults for libraries and best practices you could swap out if needed, that could be really great.  There might be room for one that does universal rendering, and one that is client side only for folks who are migrating from a legacy / non node app as well.
The biggest productivity boost for getting started would be comprehensive documentation of using the sane defaults for libraries and best practices.  Then there could be a standard way to integrate all these great libraries.

I think the benefits you're describing--quick startup, sane defaults,
etc.--are well covered by using projects like react-redux-starter-kit.
reduxframework init is less verbose than git clone https://github.com/davezuko/react-redux-starter-kit.git project && cd project && rm -rf .git && git init but I'm not sure a framework project
would provide enough benefit to justify the additional abstractions. Redux
is so simple I don't think that generators are even going to add a benefit.
What are examples of things which the starter packs are not sufficient for?

React-redux-starter-kit looks pretty sweet.  But compare it's documentation to angular's.  I guess the biggest hurdle is comprehensive documentation of how all the pieces fit together, and best practices for the most common use cases.


Shebangs are completely ignored

Describe the bug
All scripts launched from linutil are run directly with sh -e, completely disregarding the shebang on each script. This should be fixed to allow for future scripts which may require to be launched with a different shell or other executable program. We must not go too far with this approach, especially when implementing reversion which may involve a major restructure. Relevant to the topic: @adamperkowski, @nnyyxxxx.
Checklist

[x] I checked for duplicate issues.
[x] I checked already existing discussions.
[x] This issue is not included in the roadmap.

Interesting

We could try and make the shebangs more dynamic for every script via making a function in common-script depending on the distribution. Only in theory though I would have to test further.


[improve][broker] Decouple pulsar_storage_backlog_age_seconds metric from backlogQuota policy

Motivation
#21709 introduced a valuable metric: pulsar_storage_backlog_age_seconds, but it only updates when a topic has the message_age backlog quota policy.
Modifications

Decouple pulsar_storage_backlog_age_seconds metric from backlogQuota policy
For now, the backlogQuotaChecker is also used to periodically update the pulsar_storage_backlog_age_seconds metric, regardless of whether the topic has a backlog quota policy.

Verifying this change

Add backlogsAgeMetricsNoPreciseWithoutBacklogQuota and backlogsAgeMetricsPreciseWithoutBacklogQuota to cover this change.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report
Attention: Patch coverage is 84.41558% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.42%. Comparing base (bbc6224) to head (e2a102f).
Report is 739 commits behind head on master.

Files with missing lines
Patch %
Lines

...sar/broker/service/persistent/PersistentTopic.java
83.60%
8 Missing and 2 partials :warning:

...rg/apache/pulsar/broker/service/BrokerService.java
87.50%
1 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23619      +/-   ##
============================================
+ Coverage     73.57%   74.42%   +0.85%
- Complexity    32624    35003    +2379
============================================
  Files          1877     1944      +67
  Lines        139502   147136    +7634
  Branches      15299    16224     +925
============================================
+ Hits         102638   109512    +6874
- Misses        28908    29184     +276
- Partials       7956     8440     +484

Flag
Coverage Δ

inttests
27.43% <35.06%> (+2.85%)
:arrow_up:

systests
24.42% <40.25%> (+0.09%)
:arrow_up:

unittests
73.80% <84.41%> (+0.95%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

.../pulsar/broker/service/persistent/SystemTopic.java
84.21% <ø> (+4.21%)
:arrow_up:

...rg/apache/pulsar/broker/service/BrokerService.java
84.14% <87.50%> (+3.36%)
:arrow_up:

...sar/broker/service/persistent/PersistentTopic.java
80.13% <83.60%> (+1.67%)
:arrow_up:

... and 663 files with indirect coverage changes

----
🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles


CI: Fixes pyparsing version in doc build

Reference isssue: gh-14911
Also see: https://github.com/pyparsing/pyparsing/issues/317
cc @rgommers

Thanks @Smit-create


missing pack.mcmeta

mod fails to load because of missing pack.mcmeta in the most recent forge 1.16.5 version

Hmmmm, the missing pack.meta shouldn't cause the mod not to load. It will only cause resources from the mod to be missing from the game, which shouldn't be an issue as the mod doesn't contain any resources needed in-game.
Can you send me your full server log when this error occurred?

Issue was fixed in Version 2.1


added .net 1.6.4 rns

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[X] Maintenance/Chore

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://660442bdfaa0e20b5c62baa1--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66044365c42a1a143a7a89bd--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66044dee5c350c22dc455119--harness-developer.netlify.app


Update plotters.py

Added an color bar label to the plot_track function

I would like to avoid complex colorbars and variables in tracks b/c that should be up to the end user. Let's keep it to basic tracks and property sections for now.
PS: I'm closing for the same reason as https://github.com/ioos/gliderpy/pull/98


A More Dyslexia Friendly Experience

Thanks @heylf for the links in GOATS

Before I forget. Maybe a dyslexia friendly layout for GTN/Galaxy would be nice. https://www.succeedwithdyslexia.org/blog/creating-a-dyslexia-friendly-website-experience/
Dyslexia is not so often spoken about and many people do not even know they have a certain degree of dyslexia. It is estimated that 10% of the world's population has dyslexia.
BDA (https://www.bdadyslexia.org.uk/). Training for educator for dyslexia:
https://www.bdadyslexia.org.uk/services/training?method=online (but it costs money)
Dyslexia Style Guide according to the BDA:
Dyslexia_Style_Guide_2018-final-1.pdf

I think we're hitting most of the bullet points already:
Readable Fonts

[x] Use sans serif fonts, such as Arial and Comic Sans, as letters can appear less crowded. Alternatives include Verdana, Tahoma, Century Gothic, Trebuchet, Calibri, Open Sans.
[x] Font size should be 12-14 point or equivalent (e.g. 1-1.2em / 16-19 px). Some
dyslexic readers may request a larger font. (NB: users can adjust their own, browsers have a zoom. Mine's ~120% just by default.)
[ ] Larger inter-letter / character spacing (sometimes called tracking) improves readability, ideally around 35% of the average letter width. If letter spacing is excessive it can reduce readability.
[ ] Inter-word spacing should be at least 3.5 times the inter-letter spacing.
[x] Larger line spacing improves readability and should be proportional to inter-word
spacing; 1.5 / 150% is preferable.
[x] Avoid Underlining and italics as this can make the text appear to run together and
cause crowding. Use bold for emphasis. (NB: stylistically we cannot always do this e.g. organism names, but overall mostly we use bolding.)
[x] Avoid text in uppercase / capital letters and small caps, which can be less familiar
to the reader and harder to read.

Headings and Structure

[x] Use headings and styles to create consistent structure to help people navigate
through your content.
In Word, you’ll find these tools in the ‘Home’ tab:
[x] For headings, use a font size that is at least 20% larger than the normal text. If
further emphasis is required, then use bold.
[x] Use formatting tools for text alignment, justification, indents, lists, line and
paragraph spacing to support assistive technology users.
In Word, you’ll find these tools in the ‘Layout’ tab:
[x] Add extra space around headings and between paragraphs.
[x] Ensure hyperlinks look different from headings and normal text.

Colour

[x]  Use single colour backgrounds. Avoid background patterns or pictures and
distracting surrounds.
[x] Use sufficient contrast levels between background and text.
[x] Use dark coloured text on a light (not white) background.
[x] Avoid green and red/pink, as these colours are difficult for those who have colour
vision deficiencies (colour blindness).
[x] Consider alternatives to white backgrounds for paper, computer and visual aids
such as whiteboards. White can appear too dazzling. Use cream or a soft pastel
colour. Some dyslexic people will have their own colour preference.
~- [ ] When printing, use matt paper rather than gloss. Paper should be thick enough to
prevent the other side showing through.~

Layout

[x] Left align text, without justification.
[x] Avoid multiple columns (as used in newspapers).
[ ] Lines should not be too long: 60 to 70 characters. (Currently at ~140)
[x] Use white space to remove clutter near text and group related content.
[x] Break up the text with regular section headings in long documents and include a
table of contents.

Writing Style

[x] Use active rather than passive voice.
[x] Be concise; avoid using long, dense paragraphs.
[x] Use short, simple sentences in a direct style.
[x] Use images to support text. Flow charts are ideal for explaining procedures.
Pictograms and graphics can help to locate and support information in the text.
[x] Consider using bullet points and numbering rather than continuous prose.
[x] Give instructions clearly.
[x] Avoid double negatives.
[x] Avoid abbreviations where possible; always provide the expanded form when first
used.
[ ] Provide a glossary of abbreviations and jargon. (somewhat. Per tutorial we have some whenever abbreviations are explicitly declared, but not jargon.)

Action items:

We could have a specific themes: one with, and one without the OpenDyselxia font (since I know not all dyslexics like that font), that do the non-white/non-black colours
Maybe try shorter line lengths?
check tracking

Left aligned text that’s got about 60-70 characters to a line is much easier to read.

lol, love how they don't even follow their own guidelines

We do essentially all of this that we can already, user prefs added the last bit of colour support so people could choose what they want.


[DO NOT MERGE ] Iris Example - To save as entire model and state dict and test

Signed-off-by: Shrinath Suresh<EMAIL_ADDRESS>What changes are proposed in this pull request?
Adding a sample script to test the state dict mlflow fix
How is this patch tested?
Run the example and perform prediction using save_and_load_test.py
Release Notes
Is this a user-facing change?

[x] No. You can skip the rest of this section.
[ ] Yes. Give a description of this change to be included in the release notes for MLflow TorchServe Deployment Plugin users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s) does this PR affect?
Components

[ ] area/deploy: Main deployment plugin logic
[ ] area/build: Build and test infrastructure for MLflow TorchServe Deployment Plugin
[ ] area/docs: MLflow TorchServe Deployment Plugin documentation pages
[ ] area/examples: Example code

How should the PR be classified in the release notes? Choose one:

[ ] rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
[x] rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
[ ] rn/feature - A new user-facing feature worth mentioning in the release notes
[ ] rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
[ ] rn/documentation - A user-facing documentation change worth mentioning in the release notes

Duplicate PR - https://github.com/mlflow/mlflow-torchserve/pull/47


Update composer.json

Title:
Description:

Provide a clear and concise description of the changes being made.
Explain the reasons behind these changes.

Checklist:

[ ] Changes are consistent with the project's coding style.
[ ] Documentation (if applicable) has been updated.
[ ] Link to related issue (if applicable):

Testing Instructions:

Instructions for reviewers on how to test the changes

Checkmarx One – Scan Summary & Details – e624be0c-9186-4d32-9b13-29d8508eb482
No New Or Fixed Issues Found


ocfl deduplication is not working as expected

In testing editing, I've noticed that files I think should be bitwise identical - for eg image-1.jpg from the first upload, and then image-1.jpg after v1 has been extracted for the second upload - are not, so ocfl is storing two copies of the file.
This will be a problem in large datasets where (for eg) we only want an edit to update the weedcoco.json and not duplicate 1000s of image files.
How I want to tackle it - take the test images which are causing the problem and add a test case to the weedcoco/tests/repo/test_deposit (with maybe some kind of mocking to do the redis mapping)

The migrate_images method on RepositoryDataset is rewriting the image to remove exif data - this is OK on the first upload, but it's also being run each time a dataset is checked out of ocfl. This results in slight differences in the file (probably from the image compression algorithm) which stops ocfl from deduplicating them.

Fixed this in PR #667


Update to proxy 08/15

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
07910e04a11573fb43f65c4cffdb379351f16e3b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
07910e04a11573fb43f65c4cffdb379351f16e3b
link
/test istio-unit-tests

prow/e2e-dashboard.sh
07910e04a11573fb43f65c4cffdb379351f16e3b
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


customer_question_sets.question_set_id' isn't in GROUP BY issue

I have updated config/database.php file strict => false, but still it is showing errors.
Any way to resolve this issue

i am using laravel 5.4

Please post your query.


Ped Delay report tagged to incorrect location

What Happened
The textual description of the location is "Old Mill Rd near Old Mill Restaurant", but the report is tagged to Old Mill Drive near Bloor.
What Should Happen
The study data should be tagged to the correct location.
To Reproduce
Steps to reproduce the bug:

Go to https://move.intra.qa-toronto.ca/view/location/s1:AbXUrB/POINTS/reports/PED_DELAY.
Compare the textual description of the study location with the location tagged.

Screenshots
n/a
Additional Notes
n/a - can add more details if needed

This has been moved to Notion (internal only link). Closing.


Correct command mistakes in CONTRIBUTING.md and improve how to contribute

Description
Its minor but can be confusing to someone getting started
on CONTRIBUTING.md the commands are
yarn
instead of
yarn install
on running app in development mode:
its
yarn start
instead of
yarn run dev
or
npm run dev
Screenshots

Additional information
suggested:
improve the how to contribute to be beginner friendly

Is this issue still available? I would like to work on it

Is this issue still available? I would like to work on it

Hello @kihuni, this issue is currently being worked on by @dmuyah
feel free to checkout the issues tab for more upcoming issues

Thank you @orama254 I will stay tuned.


deploy current_client_obj() function

we should have documentation for this and other built in procedures that are deployed with ermrest


Enforce start date higher or equal to creation date for proposal

@ChaituVR Oh I misread this the first time. Thought it was for start > end. I will create a PR with a fix today

Hello @ChaituVR @samuveth what's the status of this issue?


⚠ TADA Wallet Web has degraded performance

In afbd3f2, TADA Wallet Web ($WALLET_WEB_URL) experienced degraded performance:

HTTP code: 200
Response time: 11763 ms

Resolved: TADA Wallet Web performance has improved in a9eb68b.


Enhance "About GitHub Advanced Security" page

Why:
Closes https://github.com/github/docs-content/issues/6200

What's being changed:

Added a table breaking down GHAS availabilty for public and private repos for ftp and ghec.
Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Ok, this PR is good to go now!

@lucie-docs Thanks so much for opening a PR! I'll get this triaged for review :zap:

PR

a5c3785


Remove cron instructions

Setting up cron to run execute maintenance is no longer needed with TimescaleDB 2. Promscale autmatically schedules jobs within the database to run execute_maintenance.
Solves #910

Actually, we still have a lot of users using TimescaleDB 1.7. So we shouldn't remove instructions but add a note instead. I'll close this PR and start a new one.


backend/local: remove useless and buggy truncate key

What problem does this PR solve?
Remove the useless and buggy truncateRowKey call when generates region split keys because this action is not compatible with clustered index. And it's also useless even with clustered index disabled.
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects
Related changes

/merge


'package:flutter/src/widgets/navigator.dart': Failed assertion: line 5253 pos 12: '!_debugLocked': is not true.

Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:

hot reload do not work

@inamjung
Please provide flutter doctor -v, flutter run --verbose and a complete minimal reproducible code sample that shows this issue.
Just issue as the title without any description or details won't help to address this issue.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Question about the learning rate η

Hi!
This is a nice work! I am studying your paper and trying to running the DSPN method on my own dataset. However, I find the repr_loss and set_loss can not convergence after some epoches.
So I wonder if the  learning rate η = 800 is suit to my dataset, which is CrowdHuman dataset.
Or can you tell me how you adjust the learning rate in your experiments.
Or could you please give me any advice about using DSPN on custom dataset?
Thanks a lot!

The way I set η is by looking what happens when the weights are randomly initialised, i.e. at the start of training. I started with a low η and increased it until I saw in the Tensorboard plots that with random init, the set elements were visible changing when doing the inner optimisation loop.
For my datasets, I normalised all the set elements to be either in the range [0, 1] or [-1, 1]. Let me know if that helps.


[Feature Review] Capitalized letters in Credential Definition and Attribute Names

When using camelCase naming convention, Credential Definition names and Schema Attribute names get a space prepended to them, resulting in anomalies when responding to a presentation request from the BC Wallet app.
MyTag would become My Tag in the wallet and MyAttribute would become My Attribute. The wallet is then having a hard time responding to presentation requests based on those values as restrictions/attribute names.
Is this string manipulation introduced in the Traction app or on the Bifold/BC Wallet app?

The Bifold/BC Wallet specifically expands the CamelCase for display purposes (putting text on a screen), but does not do anything that would affect the processing of the AnonCreds objects — credentials, presentations.  Did you note the changes anywhere other than on the Wallet display?
What anomalies occured that might be traced to this behaviour?

as per above comments from @swcurran looks like this is expected behaviour and not an issue/bug , closing


ZSE11 Illumination negative in sunlight

When the ZSE11-800LR is in direct sunlight it is reporting negative values instead of maxing out at 32767. FW: 2.00, HW: 2, Driver: 1.2.2

Link from @anderml1955 on community post -- looks like this old bug has resurfaced: https://community.smartthings.com/t/release-zooz-q-sensor-zse11/224579/17
I can add a workaround to the driver.


Added college name to the domain list

@roshanlimbu Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


simple sparse file support, fixes #256

Implemented sparse file support to remove this blocker for people backing up lots of
huge sparse files (like VM images). Attic could not support this use case yet as it would
have restored all files to their fully expanded size, possibly running out of disk space if
the total expanded size would be bigger than the available space.
Please note that this is a very simple implementation of sparse file support - at backup time,
it does not do anything special (it just reads all these zero bytes, chunks, deduplicates, compresses and
encrypts them as usual). At restore time, it detects chunks that are completely filled with zeros
and does a seek on the output file rather than a normal data write, so it creates a hole in
a sparse file. The chunk size for these all-zero chunks is currently 10MiB, so it'll create holes
of multiples of that size (depends also a bit on fs block size, alignment, previously written data).
Special cases like sparse files starting and/or ending with a hole are supported.
Please note that it will currently always create sparse files at restore time if it detects all-zero
chunks.
Also improved:
I needed a constant for the max. chunk size, so I introduced CHUNK_MAX (see also
existing CHUNK_MIN) for the maximum chunk size (which is the same as the chunk
buffer size).
Attic still always uses 10MiB chunk buffer size now, but it could be changed now more easily.

About the test failure see issue #304.

closing this pull request, seems unwanted.


Unable to add domain and hostnames to firewall rules

I'm using windows firewall and blocked all outgoing connections except allowed
There are some problems with visual studio downloader:

Windows Firewall does not accept domains. Only IPs can be specified
In every request, IP of a domain may be different, for example aka.ms will point to <IP_ADDRESS> and <IP_ADDRESS> (in nslookup from different locations and different time)
There are a lot of addresses to be add
Visual studio downloader, extracts itself into tmp folder and one of extracted executable in that folder, connects to network, so it is not possible to add a rule with specific executable in Windows Firewall

After all, I couldn't download vs without disabling firewall
Please change visual studio downloader so a permanent and specific executable connect to internet. In this case, we can add that executable to Windows Firewall and trust it

@behzadian Thanks for your input. If you would like to see a change in how the product works, please consider using either the Report a Problem tool, or the Suggest a feature tool. Meanwhile, your input here is on record.


System.IO.FileNotFoundException: Could not load file or assembly 'Mono.Options, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=0738eb9f132ed756' or one of its dependencies.

Followed the build instructions at https://mono.github.io/Embeddinator-4000/Contributing.md.  Try to run objcgen.exe, and I got instructions telling me to file a bug:
james@retina:~/git/Embeddinator-4000$ mono ./objcgen/obj/x86/Debug/objcgen.exe
EM0000: Unexpected error - Please fill a bug report at https://github.com/mono/Embeddinator-4000/issues
System.IO.FileNotFoundException: Could not load file or assembly 'Mono.Options, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=0738eb9f132ed756' or one of its dependencies.
File name: 'Mono.Options, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=0738eb9f132ed756'
  at Embeddinator.Driver.Main (System.String[] args) [0x00002] in <182a20751ebf478cbe1e0bbc180996c8>:0
james@retina:~/git/Embeddinator-4000$

Darwin retina.local 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64

This was pilot error; I was trying to run objcgen.exe directly, not
mono build/lib/Debug/MonoEmbeddinator4000.exe


[Unity] Add LoadWholeParamOnWorker0 function in shard loader

In DistIR compilation flow, shard loading is implemented in a Relax func, like
a = LoadWholeParamOnWorker0(loader, index=0)
b = broadcast(a)
c = LoadWholeParamOnWorker0(loader, index=1)
d = scatter_from_worker0(c)

LoadWholeParamOnWorker0 loads the unsharded param on worker0, and for other workers returns an empty array.
This PR implements LoadWholeParamOnWorker0

cc: @junrushao

The implementation looks good, but not sure what the best name tbh. @tqchen maybe you could suggest?

How about LoadParamOnWorker0. And for future sharded version we can say LoadShardedParams

sounds good

Sounds good! Let’s do that then


Bitmap resize is always using low resolution algorithm

https://devdocs.io/dom/canvasrenderingcontext2d/imagesmoothingquality


[Alert component] Make it undismissible by default

This renders an alert which is dismissible, since I didn't tell it not to be, but the close button has no default handler. This feels strange to me, I think we should make it undismissible by default.

Yeah good point. We can maybe be fancy here and use this.$listeners.close to figure it out.
Also, I notice that the click event is bound to the icon and not the button which is wrong, so we should fix that too.


Why not Node 5??

Why not use Node 5 vs 0.10.x?

Code is based on Meteor platform 1.2.x.    Meteor 1.2.x is tested against 0.10.x

Ah okay -- was just curious -- always worth asking!


IF-136: Efficiency Equipment aggregated stats

Task linked: IF-136 Machine Availability Dashboard (Aggregated)


custom Layout is not working  when Push

I have a minview controller and i want to push to another view controller,
when pushing, the tab bar will be at top while in storyboard i put it in the middle of the view.
Knowing that if the view was a root view controller the layout works but if it comes from a push, it doesnt. Any solution ?

@sam961  Have you set up all containts using interface builder?

@sam961 @mtnbarreto I have same issue. Have you guys found the solution? Appreciate any help.

I have tested it and it seems to work fine.
Take into account that I added the ButtonBarView and the container view using interface builder (storyboards) and connect the necessary outlets and set up its constraints.
See the changes over here: https://github.com/xmartlabs/XLPagerTabStrip/tree/issue/299/example
if it still doesn't work, please add another example reproducing the issue...

I threw up some test files at gist below.
When pushing the view programmatically - it all goes pear shaped.
https://gist.github.com/johndpope/9b9205f0bcc2a7835753aa70b948f2e2

not ideal - but get out of jail card hack

 override func viewWillDisappear(_ animated: Bool) {
        super.viewWillDisappear(animated)
        Logger.verbose("viewWillDisappear")
        buttonBarView.isHidden = true
        buttonBarView.isUserInteractionEnabled = false
        self.title = ""
    }

    override func viewWillAppear(_ animated: Bool) {
        super.viewWillAppear(animated)
        Logger.verbose("viewWillAppear")
        buttonBarView.isHidden = false
        buttonBarView.isUserInteractionEnabled = true
        self.title = ""
    }


[Question]: Using IOS background location update but the gps keeps drifting

Please check the following before submitting a new issue.

[X] I have searched the existing issues.
[X] I have carefully read the documentation.

Please select for which platform(s) you need help

[ ] Android
[X] iOS
[ ] Linux
[ ] macOS
[ ] Web
[ ] Windows

Your question
I'm using Geolocator.getPositionStream with AppleSettings that allows background location update. However, I notice that the location data return from the stream tends to drift when the device is stationary. Is there a way that I can filter out the drifted location data?
Version
11.0.0

Dear @Ellynnn,
You could write an own implementation filtering out drifted location data. The plugin only passes data that is retrieved bij the OS. Playing around with the settings for your desired situation might improve the data quality.
Kind regards


Implement wc fast paths that skip Unicode decoding.

Byte, character, and line counting can all be done on the raw bytes
of the incoming stream without decoding the Unicode characters. This
fact was previously exploited in specific fast paths for counting
characters and counting lines. This change unifies those fast paths into
a single shared fast paths, using const generics to specialize the
function for each use case. This has the benefit of making sure that all
combinations of these Unicode-oblivious fast paths benefit from the same
optimization.
On my laptop, this speeds up wc -clm odyssey1024.txt from 840ms to
120ms. I experimented with using a filter loop for line counting, but
continuing to use the bytecount crate came out ahead by a significant
margin.

@resistor good job, but needs a cargo fmt run ;)

@resistor good job, but needs a cargo fmt run ;)

Done

the coverage indicates that we are missing some tests, could you please add them ?
thanks

the coverage indicates that we are missing some tests, could you please add them ?
thanks

Done

@sylvestre this is now good to merge (tail-related failures) ;)
Congrats @resistor !

indeed, thanks :)


Patching false positive page address assertion (ver1)

For #325
Describe the bug
False positive assertion on behat tests where a link is clicked and the resulting page is verified to be a specified URL. I uncovered this when I changed a link's href, and then found a behat test asserting the proper webpage has opened was still passing with the old URL.
To Reproduce
Steps to reproduce the behavior:

Find any usage of a new tab or window should open at... in features directory that specifies a URL (paths seem to be working as intended).
Swap The URL specified with something like https://hello, which obviously isn't a valid URL nor the href of the link being clicked.
Run behat test.

Expected behavior
Test should fail.
Actual behavior
Test passes.
Solution
FlexibleContext::assertPageAddress
if (!strpos($actual, $page) === 0) {

This was allowing every URL to pass. Another issue was using strpos.
E.g., if $actual is http://www.stdcheck.local/my-account.php#/stdcheck.com/main
and $page is http://www.stdcheck.local/my-account.php,
this method would assert true despite the URLs being different.
I changed this conditional check to an equality (not strictly equal to !==)
if ($actual !== $page) {

And I trim any trailing slash off both $page and $actual
Some refactoring was necessary because WebContext::assertNewWindowPageAddress in STDcheck was calling FlexibleContext::assertPageAddress from within a waitFor, and assertPageAddress also uses a waitFor. So we were waiting on assertPageAddress to timeout before actually trying to change the tab/window.
I abstracted the logic from within the waitFor in FlexibleContext::assertPageAddress into assertPageAddressOnce, and I changed the callback in WebContext::assertNewWindowPageAddress to this new method.
This was all to accommodate callRecords.feature in STDcheck, which seems to be the only test that was causing a false positive (Rodolfo said it was from a 3rd party extension CSA's no longer use). I have a PR for the changes that need to be applied to STDcheck.
Note:
Some behat tests and one call to assertPageAddress (in WebContext) will need to be modified in STDcheck. They will fail if these changes are merged and the updated version of FlexibleMink is specified in composer.json (version 1.x specifically). I will create a PR on STDcheck for these changes.

Will need to run composer update medology/flexible-mink on STDcheck and push changes to composer.lock on the PR for STDcheck


⚠ Bofrost.fr has degraded performance

In c661ce0, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 948 ms

Resolved: Bofrost.fr performance has improved in 9180797.


build.psm1 Should Refresh the Ruby Gems during Start-PSBuild or Start-PSPackage

Steps to reproduce
This occurred during a Travis CI pass on OSX. The PR succeeded during initial validation, but failed after merge. It is unrelated to the content of the PR that got merged.
Expected behavior
Success
Actual behavior
. . .
publish: Published to /Users/travis/build/PowerShell/PowerShell/src/powershell-unix/bin/Linux/netcoreapp1.0/osx.10.11-x64/publish
Published 1/1 projects successfully
VERBOSE: PowerShell Ngen assemblies have been generated, deleting ILs...
PowerShell.exe with ngen binaries is available at: /Users/travis/build/PowerShell/PowerShell/src/powershell-unix/bin/Linux/netcoreapp1.0/osx.10.11-x64/publish/powershell
WARNING: Please ensure you have previously run Start-PSBuild -Clean -CrossGen!
WARNING: -Types was not specified, continuing with osxpkg!
WARNING: Suffix not given, building primary PowerShell package!
roff: /Users/travis/build/PowerShell/PowerShell/assets/powershell.1
/gems/ruby-2.2.1/gems/bundler-1.13.1/lib/bundler/rubygems_ext.rb:45:in full_gem_path': uninitialized constant Bundler::Plugin::API::Source (NameError) 	from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/basic_specification.rb:144:in block in full_require_paths'
from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/basic_specification.rb:143:in map' 	from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/basic_specification.rb:143:in full_require_paths'
from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/basic_specification.rb:76:in contains_requirable_file?' 	from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:949:in block in find_in_unresolved'
from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:949:in each' 	from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:949:in find_all'
from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:949:in find_in_unresolved' 	from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:74:in require'
from /Users/travis/.rvm/gems/ruby-2.2.1/gems/bundler-1.13.1/lib/bundler/plugin/api/source.rb:2:in <top (required)>' 	from /Users/travis/.rvm/gems/ruby-2.2.1/gems/bundler-1.13.1/lib/bundler/rubygems_ext.rb:45:in full_gem_path'
from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/basic_specification.rb:144:in block in full_require_paths' 	from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/basic_specification.rb:143:in map'
from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/basic_specification.rb:143:in full_require_paths' 	from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:1370:in add_self_to_load_path'
from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:1283:in activate' 	from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:1314:in block in activate_dependencies'
from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:1300:in each' 	from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:1300:in activate_dependencies'
from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:1282:in activate' 	from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_gem.rb:67:in block in gem'
from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_gem.rb:66:in synchronize' 	from /Users/travis/.rvm/rubies/ruby-2.2.1/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_gem.rb:66:in gem'
from /Users/travis/.rvm/gems/ruby-2.2.1/bin/fpm:22:in <main>' 	from /Users/travis/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in eval'
from /Users/travis/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in `'
Execution of { fpm $Arguments } failed with exit code 1
At /Users/travis/build/PowerShell/PowerShell/build.psm1:1871 char:13

        throw "Execution of {$sb} failed with exit code $LASTEXIT ...

        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OperationStopped: (Execution of { ...ith exit co
de 1:String) [], RuntimeException
FullyQualifiedErrorId : Execution of { fpm $Arguments } failed with exit
code 1

Environment data
Travis CI for OSX

We should fix it ASAP, the current status of master on Travis is failing, because of it.

This wasn't a problem with the gems, it was as buggy version of bundler. Fixed in #2352.


Change auto topic create to be false

Fixes #472

Proposed Changes

Set auto.create.topics.enable to false

Release Note

Docs

Sounds reasonable /approve


Add back leading slash on meta class names

After my last change to support the meta metadata format, I accidentally nuked the leading slash on the class names :(. This PR adds that slash back to fix autocompletion.

I have to say I didn't notice any issue with autocomplete when the backslash wasn't there! And I WAS using a version of this repository that had your new meta format in it.
Hmmm....


Add OwnTone recipe

mDNS/Zeroconf is not working. Any ideas how to fix that?

mDNS/Zeroconf is not working. Any ideas how to fix that?

Make use of the hostNetwork: true option.


Jetbrains IDE 2019.3.1 now crashes when launched with splash

Pretty much our jetbrains IDEs are affected by https://github.com/dubreuia/intellij-plugin-save-actions/issues/289
was able to get pycharm-community to work by doing: pycharm-community nosplash, but still annoying
regression(although upstream regression) introduced #73879
cc @kolaente  @Lassulus

I have the same problem with mypy, pylint and docker plugins installed


Installed extensions unchecked Update checkbox after enabling for all extensions

Testing #223091

Disable Auto Update for All Extensions.
Enable Auto Update for All Extensions.
Search for an installed extension.
Auto Update is not checked. 🐛

When I clear the search box, sometimes the checkboxes are then checked. Again searching for an installed extension shows the boxes unchecked.

When I clear the search box, sometimes the checkboxes are then checked. Again searching for an installed extension shows the boxes unchecked

Do you mean the checkbox is not checked when you search for an installed extension? Otherwise it is checked?

Yes.

Actually now I just reproduced it without searching. This is after enabling auto update for all:

Oh...it updated after a while! I also noticed that when I clear the search box it takes a very long time for the Extensions panel to show the installed extensions when I just enabled or disabled auto update for all extensions. There seems to be a performance issue.

Thats right, this action updates all extensions to disable auto update. This is any async operation. I would probably show a progress to indicate that operation is running.


Suggestion: Consider changing default color from ColorWhite to ColorClear

Right now, when working with light terminal background, there are quite a few places that need to be overridden from ColorWhite to ColorClear (or some other color that is readable on white background).
Not only this makes development and experimentation a little lengthier, I suspect it also causes developers who publish packages that rely on termui to have a default theme that is not friendly to light background users.
I believe that if ColorClear is used as the default color, and both ColorBlack and ColorWhite are avoided in all the defaults, this will be a good starting point for everybody, and will provide a sensible theme that works out of the box for both dark and light background users.

Agreed on this. I was going mad trying to get it to change from ColorWhite to the default terminal color and had no idea it was ColorClear until I saw this post. It shouldn't default to ColorWhite. This presupposes a very specific system setup and ignores the colors users have personally selected for readability in their own terminals.


Ensure cache file is included in debug logging

As per #168 it would be useful to ensure the requests cache path is included in the verbose output

The is done in tvdb_api,
https://github.com/dbr/tvdb_api/commit/6d78fe36dab48ed42ea712310b2207b4169d1fbc


Create a table of content with links

I see myself using this a lot as reference for my own scripts, so having a TOC instead of doing search and find would help a lot

Cool - just learned something new...


New things in series, changed abs_le, updated things

Changed Order World's abs_le to an if-and-only-if (this was in the text but not the proof), which meant I had to amend Dan's Cauchy --> Bounded slightly (this used the previous abs_le).
Added "shift rule" for sequences, which I used for Series converges --> sequence tends to 0.
Storing this in Series for now (along with my Convergent --> Bounded) but it should maybe move into limits at a later date.

Closing this for now, as Gavin is preparing a more comprehensive pull request.


ipywidgets do not respect color theme

Duplicating https://github.com/tqdm/tqdm/issues/1457 because I think the issue lies in the vscode extensions rather than tqdm or ipywidgets.
Whenever I create a tqdm progress bar in a vscode notebook, it renders in "light mode" rather than matching the current theme. Having a play, it looks like this is also true for the underlying ipywidget.IntProgress object. For example:

This is on a fresh python environment with:

ipywidgets=8.1.5,
notebook=7.2.2,
tqdm=4.66.5,

and vscode Jupyter=v2024.7.0 batch of extensions, of which I'm guessing the important one is notebook renderer=v1.0.19.
My settings json has the line "workbench.preferredDarkColorTheme": "Default Dark Modern"
The setting "jupyter.themeMatplotlibPlots": true/false has no effect.
Hopefully there is enough here for you to triage exactly which library/extension is at fault, I apologise if this is the wrong place for posting!
For context, there are also stack overflow questions for this as well:

https://stackoverflow.com/questions/71534901/make-tqdm-bar-dark-in-vscode-jupyter-notebook
https://stackoverflow.com/questions/75429196/vs-code-jupyter-notebook-dark-theme-for-interactive-elements

There is some suggestion that vscode "can't theme ipywidgets", but I'm pretty sure JupyterLab manages it.
Thanks for your help

Duplicate of https://github.com/microsoft/vscode-jupyter/issues/7161


Building llama_cpp container does not produce the compiled C++ version of llama.cpp executables

Hello! I am using the prebuilt container dustynv/llama_cpp, which contains the built C++ executables inside /opt/llama.cpp.
However, trying to rebuild it from scratch to get some fixes from the main repo, I obtain a container that has no /opt/llama.cpp folder.
I suspect that #422 broke something...

Hi @amasciotta, yes it builds llama_cpp_python from https://github.com/abetlen/llama-cpp-python which has llama.cpp as submodule.  For now if you need to retain the C++ stuff, you just may want to build it, it is straightforward to compile these days with -DLLAMA_CUBLAS=on -DLLAMA_CUDA_F16=1

I will definitely try to build it myself. Any other suggestion on how to set compile options to work best on Jetson Xavier and Orin?

I'm not entirely convinced my local build issue on an AGX Orin 32GB running Jetpack 6, with jetson-containers pulled today #commit:e77e05ebcbbb15e315bbf8b5bcd160946995a12c  is the same as described in this ticket, but figured I'd supply my buildlog here nonetheless rather than open what is likely to b a duplicate ticket.
agx_orin_llama_cpp_buildlog.txt

OSError: libnvrm_gpu.so: cannot open shared object file: No such file or directory

@hillct that looks like a different issue, like your docker engine or nvidia runtime is misconfigured.  It seems unable to access GPU drivers during the build - do you have your default docker runtime set to nvidia, like shown here?
https://github.com/dusty-nv/jetson-containers/blob/master/docs/setup.md#docker-default-runtime
Alternatively, are you able to do things like import tensorrt inside l4t-jetpack container?

OSError: libnvrm_gpu.so: cannot open shared object file: No such file or directory

@hillct that looks like a different issue, like your docker engine or nvidia runtime is misconfigured. It seems unable to access GPU drivers during the build - do you have your default docker runtime set to nvidia, like shown here?
https://github.com/dusty-nv/jetson-containers/blob/master/docs/setup.md#docker-default-runtime

The nvidia runtime was defined in that I was always able to run CUDA-enabled containers but it had always been my habit to specify the nvidia runtime on the docker command line ie: --runtime nvidia. The missing property was "default-runtime" which would have removed the command line arg requirement. Presumably on of the scripted build steps omitted the command line arg. It's worth noting that other containers locally built using your jetson-containers build scripts seem to build successfully, notably here, for example ollama, which upon review does explicitly specify the nvidia runtime on the docker command line, so the absence of the explicit specification is llama_cpp specific not at the jetson-conainers script level. Whether or not i should be 'fixed' for this build script, is debatable, but there's a good argument for consistency across  all jetson-containers build scripts.
As I write this, a new llama_cpp build has completed successfully, so the specification of default-runtime was indeed the issue. Thanks!
PS: Looking now at the final docker run command, the --runtime nvidia arg is specified so it must have related only to the intermediate build step.

Alternatively, are you able to do things like import tensorrt inside l4t-jetpack container?

docker build does not accept the --runtime flag, but does honor the default-runtime being set in /etc/docker/daemon.json (unless you are using buildkit, which is why I disable that).  So for containers that use CUDA during the build, those need it.  The tests are run with docker run --runtime nvidia at the conclusion of each dockerfile being built.


Blueprint should also generate a unit test

[x] Verify that method returns the correct response shape

Closed by #6


API: add faucet balance endpoint

Problem: We cannot see the faucet balance directly from the API
Solution: We need a /balance endpoint so we can check it

Hi @karacurt can i get assigned to this issue ?

https://github.com/G7DAO/protocol/pull/164

alright 👌🏼

@gabrieltemtsen  - please check the review that @karacurt left for you on the PR. Let us continue all discussion on the PR.

Thanks @zomglings

Solved by https://github.com/G7DAO/protocol/pull/164


Rename of primary branch to "main"

Solution for https://github.com/techservicesillinois/SecOps-Powershell-CISDSC/issues/101
Actions updated
Module manifests updated
Branch protection policy and default branch have been updated on the repository settings (please double check me!)

Consider adding "Require linear history" to the branch policy. It squashes all your branch commits into one when you merge to main and makes the commit history a bit cleaner.
We also enable "Include administrators" so the configured policy is enforced for repo admins as well.

Consider adding "Require linear history" to the branch policy. It squashes all your branch commits into one when you merge to main and makes the commit history a bit cleaner.
We also enable "Include administrators" so the configured policy is enforced for repo admins as well.

Done

Also please let me know if there's a better way to link to the license and changelog. I didn't see anyway to link to a file without specifying branch in the URL.


integration lost connection to HACS?

Hey!
I noticed this morning that my alarmdotcom integration, which has been working well, is actually not communicating with HACS anymore. For example, the version I have installed is version v0.2.10 ( I had to go into the manifest.json to see the version)
When I go to HACS>integrations>alarmdotcom
HACS is acting as if I don't have it installed and I can download the integration (which shows up as blank integrations in HACS and says "The developer has not provided any more information for this repository").
just curious, did the integration move? How to do I get the integration back on track with updates?
thanks!

never mind! Just read your note on the front page. Cheers


basic sprig integration with possible page URL events

i've given Austin, James, and Stephen access. Next up I will suggest some surveys

ready for another review, if you click the link you will see the sample survey on dev

Saw Austin's comment about using the NPM package and agree that would be better if you want to do that instead of following my comments.

The issue with NPM is that it won't automatically update to the latest version. 99% of Sprig customers are on the snippet installation..
Addressing all the comments now

alright PTAnotherL @jahooma

feel free to merge whenever! the study is launched so that will start sending the study to eligible users (after they visit 4 more times)


Common infrastructure to check that all required files are present at model start

Based on bitter experience, one thing I want NextSIM_DG to do is check for the existence of all external files (particularly forcing files) required for the specified run period. This is to be done as part of the run set up so that the user doesn't get 4 years into a 5 years run only to have the model crash with a file not found error.
This means that all relevant Modules (probably mostly implementations of IAtmosphereBoundary and IOceanBoundary) should be able to check for the existence of all the files they will need between two dates.
The functionality should likely be implemented in the ModelComponent base class to allow all parts of the model to be recursively checked, even if most of them will return true (‘I have all the files I need, because I don't need any’).

When using the OASIS or NorESM couplers or XIOS, it might be necessary to check for the presence of the files we know are required ourselves. The coupling libraries will not necessarily provide the ability to request that they check that all the files exist.


Receive handle to the underlying bytes during .json() deserialization error

I can't see an easy way of doing the following (specifically in an async context):

Receive a response
Under the assumption that it's a JSON attempt to de-serialize.
In the event that the response was not a JSON, log the actual response bytes/text.

In a perfect world one would know the response type from the content-type header, however my application interacts with a lot of blockchain projects...

The easiest way to do so now is to not use response.json(), but to await the body bytes, and then try passing them to serde_json yourself.


Translate ObjectReference #32433

Translate ObjectReference https://github.com/kubernetes/website/issues/32433

https://github.com/kubernetes/website/pull/32447#issuecomment-1076369962****

/easycla

Thanks for correcting .

/lgtm
/approve


Optimized the logic to get the job status.

Optimized the logic to get the job status.
Added property to configure S3 retries. By default, the retry setting is 5.

Coverage decreased (-0.03%) to 88.774% when pulling f5f190a905e89698914c9b9069c2c2ee064adfa1 on ajoymajumdar:develop into 3467f1488d0e67ef5de51dcd9de6e54026a8291d on Netflix:develop.


Point Rest Layer (back)

Change Point Rest layer to POI - Point Of Interest. This is correct call rest layer

next step I added unit tests and modify structure rest layer


fix latest tag was added to the incorrect commit hash

closes #212

We are seeing the thread-comment in this thread because the GITHUB_REPOSITORY env var is set to "cpp-linter/cpp-linter-action" (not "cpp-linter/test-cpp-linter-action"). There are other problems that we have been trying to workaround as well, all the problems relate to the fact: The cpp-linter package is not meant to be executed on a certain repo that is not same repo triggering the workflow.

The cpp-linter package is not meant to be executed on a certain repo that is not same repo triggering the workflow.

I think the solution is to switch back to running cpp-linter on this repo. Instead of using docs/examples/demo folder, we could add the test repo as a submodule of this repo and set ignore to explicitly not ignore the submodule. With the submodule checked out, we could then call a reusable workflow from the submodule's path (I think).

With the submodule checked out, we could then call a reusable workflow from the submodule's path (I think).

This idea won't work exactly as stated. We can't checkout a submodule (in 1 job) then call the reusable workflow from the submodule's path (in another job).

According to GH docs:

You can't overwrite the value of the default environment variables named GITHUB_* and RUNNER_*.

Docs about using on.push.tags
This seems more applicable to the triger that calls the reusable workflow:
on:
  push:
    tags:
      - latest

oh, I never thought to use ./. That's very clever.

The self test CI failed because

It found errors in the C source files that installed with pygit2. Basically it didn't ignore the venv that it was running from.

Body is too long (maximum is 65536 characters).

We really need to review/test cpp-linter/cpp-linter#91 to avoid this "comment too long" error


WebM export doesn't work on Chrome (online version does)

Windows 8.1 x64, Chrome 53.0.2785.89
node,js 4.5.0
npm 3.10.6
bower 1.7.9
grunt-cli 1.2.0
gem (ruby) 2.6.6
latest compass
A deployed offline version tested with "grunt serve" works fine, except for video export. Whenever I try to export video the progress bar doesn't move forward.
Site version however works great.
There were a lot of deprecation warnings when building, maybe something broke since then?
P.S. Also I think build instructions should mention Ruby and Compass installation since grunt was throwing errors at me without them.

I came across this error too.  Depthy WebM export, for me, only works in Firefox, in December 2023.
Chrome, Chromium--totally broken.
I was trying to use Depthy for bulk WebM creation.  I tried manually operating several tabs, with several WebM renderings going at the same time.  That worked, but was painful to do.  Still took hours of fully-engaged, dry work.
Automation really was quite necessary for my use case.  Support for Firefox in Puppeteer is so poor that Depthy/Puppeteer automation with Puppeteer is currently, functionally impossible.  The mechanism to enable it was just two days ago, closed on the Mozilla Bug forums, as "Not Going to Fix".  https://bugzilla.mozilla.org/show_bug.cgi?id=1587446
I started going through the Depthy code, searching for a way to solve my problem.  I looked into how the WebM's were made, and a key component/library enabling this array to WebM conversion in Depthy is a library called Whammy.  When I searched for Chrome incompatibility with Whammy, I hit a bullseye.  Most of the thread is in Mandarin, which I didn't translate....All I needed was that the error was the same, and the OP said the last working Chrome Version was Google Chrome 90.0.4430.212 (64-bit).
https://github.com/antimatter15/whammy/issues/70
In order to use Depthy with Chrome or Puppeteer, npm install<EMAIL_ADDRESS>or use Chrome <=90.0.4430.212; which was released on May 10, 2021 before then works fine.
That is the last working version of Chrome for Whammy, and therefore, for Depthy.

Hi, it probably won't work for your use case with automation, but just in case here's source project and build for DepthyOffline: https://github.com/brachna/DepthyOffline


Caches on Deno Deploy

Hello,
I got this error while running on Deno Deploy, had to stop using cache middleware.

It may relate to this part, where the global caches variable isn't available as Cache API has not been supported by Deno Deploy. I guess that.

Hi @ndaidong !
Ah, yes. It seems so. We'll have to make that clear in the document. Thanks!

Hello, I would like to jump on to fix this issue

@heysolomon
I had not done it yet. Yes, just add a note there.

@heysolomon
I had not done it yet. Yes, just add a note there.

okay

@heysolomon
I had not done it yet. Yes, just add a note there.

After going through the repo, I couldn't find the folder/file relating to the hono.dev document, I checked other repositories in the honojs organization and found the website repo, which is the repository for hono.dev.
I will create an issue similar to the title here, and add the note there.
This is fine right?

@heysolomon
Yeah, thank you for the PR! This issue can be closed!


text in backticks rendering in title is now native!

https://twitter.com/natfriedman/status/1372917225993080849

Thanks #4129

Ah, sorry then, I didn't notice 😬
Closing...

No worries

parse-backticks also native for commits, post here so it doesn't get lost:

I don't like the way it looks and its buggy

We can extend parse-backticks to detect them and style them correctly. Ideally just via CSS

I opened a more specific issue


[BEAM-9147] Make VideoIntelligence use PTransform on user-facing API

After the remark in #11261 I modified the code to be in line with the PTransform creation guide.
Thanks, @jkff for your keen eye!

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @jkff
CC: @lukecwik

Run Java PreCommit

Run Java PreCommit

@mwalenia Please resolve merge conflicts.

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

@ibzib @jkff Can we merge this?

Yes, feel free to merge.


capture loss values during training

Currently loss values are not reported to ray. These can be useful as metrics to measure performance.

Resolved by PR #45