Natively support CHIPS cookies

Adds native support for https://developer.mozilla.org/en-US/docs/Web/Privacy/Privacy_sandbox/Partitioned_cookies.

I have mixed feelings about this. It's simple enough, but it's a chromium feature —neither gecko nor webkit implements it— it's still experimental, and there ain't a RFC to back it up, barely a draft that expired almost a year ago :confused:
Let's note that it can already be accessed by looking at HTTP::Cookie#extension, though it's not as nice as proposed in this PR, obviously.

I don't have strong feelings either way. I just saw Symfony implemented it a while ago and was easy enough so I just did it. My only 2 cents is Chrome is like 65% of the market share and based on https://privacysandbox.com/open-web/#the-privacy-sandbox-timeline it seems like we're only a quarter away from it being in GA.
I'll close this for now I guess, then later this year when this feature rolls out we can re-asses as people would be somewhat required to start using it.


period?: TimePeriod：Add option for "All Time" or custom start date in TimePeriod selection

Currently, the TimePeriod selection in the author's period only allows a maximum duration of one month. It would be useful to have an option for "All Time" so that users can view the data for the entire available period. Alternatively, it would be great to be able to input a specific start date using Date.now() as the current time and subtracting the date the user inputs. This would provide more flexibility in analyzing the data over longer or customized periods.
Could you please consider adding these features to improve the usability of the author's period selection? Thank you!

Or simply add a period like -99 years to show all the time data

Hello! :wave: I no longer work in web development, and do not have a lot of free time or interest in maintaining this package anymore. I am closing all issues and PR for it and will archive the repository, but if anybody is interested in maintaining it, I am willing to transfer the repository and NPM package.


Tooltips cannot be dismissed on iOS

Tooltips can be shown on mobile by clicking, but you cant get rid of them.
They swallow up click events too so you can't add click handlers to the body to hide them.
Same as the problem noted in #3417 #6232 - both full of exasperated users..
If this isn't going to be fixed, at least a note could be put in the docs saying don't use tooltips if you want it to work on mobile without custom code disabling them for mobile devices...

You're referring only to iOS and not Android, correct?
We could give body { cursor: pointer; } a try.

Yes. That would make it more intuitive for iOS users but the problem is you
can't get them to disappear after the tap on iOS
On Tuesday, 10 March 2015, Chris Rebert<EMAIL_ADDRESS>wrote:

You're referring only to iOS and not Android, correct?
We could give body { cursor: pointer; }
https://developer.mozilla.org/en-US/docs/Web/Events/click#Safari_Mobile
a try.
—
Reply to this email directly or view it on GitHub
https://github.com/twbs/bootstrap/issues/16028#issuecomment-77989258.

Uh, no, I mean that should literally theoretically fix the dismissibility problem. See linked article.

Woops! True, that's convenient. Good find
On Tuesday, 10 March 2015, Chris Rebert<EMAIL_ADDRESS>wrote:

Uh, no, I mean that should literally theoretically fix the dismissibility
problem. See linked article.
—
Reply to this email directly or view it on GitHub
https://github.com/twbs/bootstrap/issues/16028#issuecomment-78025205.

@cvrebert is this a css issue?

@fat It's an iOS Safari quirk/bug: https://developer.mozilla.org/en-US/docs/Web/Events/click#Safari_Mobile

@cvrebert i just meant more, that if we wanted to pursue a fix, woudl we just add that css snippet to the tooltip component… or did you expect the js to fix this somehow? (label wise)

@fat I guess it would need to be in the JS. Something like:
if ('ontouchstart' in document.documentElement) { // or whatever "is this a touch device?" test we want to use
  $('body').css('cursor', 'pointer');
}

or whatever "is this a touch device?" test we want to use

there is no bullet-proof way for this part though...and it would likely cause quirky effects on hybrid devices like touch-enabled laptops, surface, etc

I guess we'd ought to toss in some iOS Safari detection/UA-sniffing for good measure.

@cvrebert Why not just use the Touch object safari defines on mobile?
// Safari Mobile
if(window.Touch) { /* JavaScript for your touch interface */ }

@kkirsche I'm pretty sure that's not specific enough. There are browsers besides Safari that support Touch Events.

Ah, ok. Thank you for the information. I wasn't aware of that :smiley:

If JavaScript will fix this bug, it would be cool to have auto-hiding tooltips (after 2sec for ex).

auto-hiding would potentially cause issues for keyboard (and particularly assistive technology) users, depending on who it's implemented...

@patrickhlauke : problems are related with keyboard be hiding when DOM changes?
Maybe if we can preserve input focus and did not reset viewport - all will be ok?

I'd need to see an example implementation to give a definitive yes/no, but in principle: what happens if a user moves focus to something which then triggers a tooltip. Will they have enough time to read it before it disappears. And with assistive technologies, will AT still announce the content if it disappears suddenly. Even for sighted mouse users, will they have enough time to see the tooltip before it disappears again. etc

I see this is still a problem in v4 as well in iOS.
I don't know if it's worth mentioning, but whatever they're doing in this jquery plugin over here - it works in iOS. It ain't smooth (unless that's just the crappy iPhone 4S I was testing on), but at least it works:
http://swisnl.github.io/jQuery-contextMenu/demo/trigger-left-click.html

solution http://jsfiddle.net/stereotipo/suhq88b0/17/
test on iOS (ipad and iphone), android and windows

Hi @stereotipo!
You appear to have posted a live example (http://fiddle.jshell.net/stereotipo/suhq88b0/17/show/light/), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 96, column 362 thru column 368: Stray end tag span.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

solution http://jsfiddle.net/stereotipo/suhq88b0/18/
test on iOS (ipad and iphone), android and windows

Hi @stereotipo!
You appear to have posted a live example (http://fiddle.jshell.net/stereotipo/suhq88b0/18/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 94, column 3: W013: Bootstrap version might be outdated. Latest version is at least 3.3.5 ; saw what appears to be usage of Bootstrap 3.1.1

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

oh yeah… i think the best solution imho for ios is using an invisible screen… surprised i didn't already do that in v4

Turns out it's not possible to make the  clickable in iOS Safari using either cursor:pointer or onclick="void(0)". You can make its descendants clickable, but not the  itself. This means e.g. tapping on the empty space between top-level
s or
s wouldn't dismiss tooltips, which would make for kinda weird, suboptimal UX.
Filed https://bugs.webkit.org/show_bug.cgi?id=151933 regarding this weirdness.
Agreed that a backdrop looks like the only viable option.
@fat Is switching to an invisible screen approach within scope or out of scope for v3?

My current workaround (#page wraps all my content):
function closePopovers() {
  $('.popover').popover('hide');
  $("#page").unbind("click", closePopovers);
};

// Popovers
$('[data-toggle="popover"]').popover({html: true});

// Bootstrap popovers don't close on outside click
$('[data-toggle="popover"]').on('shown.bs.popover', function () {
  setTimeout(function() {
    $("#page").bind("click", closePopovers);
  }, 0);
});

Now I need to figure out how to get around the double click bug after a hide.

For people looking for an alternative solution that closes on an outside click by default and doesn't require two clicks after that, this worked perfectly out of the box for me with the default options:
https://github.com/sandywalker/webui-popover

@stereotipo in iOS when open tooltip and then close it by click somewhere outside, the only way to open closed tooltip again is to open another tooltip and then first one will be able to open

The issue is still reproducing on iOS devices. Is it going to be fixed in any of the nearest releases? Does anybody know a good solution until the library is updated ?

@sleepydisaster Yep, check out my solution posted above - https://github.com/sandywalker/webui-popover - currently using that instead in my production app and it works great.

@gregblass managed to get around the multiple tooltip issue with this code (uses isMobile to run for iOS-only):
  if (isMobile.apple.device) {
    // isolate the fix to apply only when a tooltip is shown
    $("[data-toggle="tooltip"]").on("shown.bs.tooltip", function() {
      $('body').css('cursor', 'pointer');
    });

    // Return cursor to default value when tooltip hidden.
    // Use 'hide' event (as opposed to "hidden") to ensure .css() fires before
    // 'shown' event for another tooltip.
    $("[data-toggle="tooltip"]").on("hide.bs.tooltip", function() {
      $('body').css('cursor', 'auto');
    });
  }

Bootstrap 3 is no longer being officially developed or supported.
All work has moved onto our next major release, v4. As such, this issue or pull request is being closed as a "won't fix." For additional help and support, we recommend utilizing our community resources. Thanks for your understanding, and see you on the other side of v4!
<3,
@mdo and team

Reopening since this also has the v4 label.

I recently had this issue and resolved it by using touch events and ignoring mouse events that come immediately after said touch events. I used Bootstrap's trigger: 'manual' option when initializing to avoid hacks. This solution uses hover on desktop, but can be expanded to work with click, focus, etc. There are a few issues with the solution: 1) on some Android devices, the touch events tend to fire unreliably, and 2) on Opera Mini, you can still touch through the tooltip, which is undesirable, but would require a 360ms delay when closing the tooltip to work around. On Android, 10ms was sufficient.
Here is a gist with the solution. Let me know if this is something that could be adapted as an official solution, if there are any major flaws with it, and/or if there's really a much better way of doing things already brewing. I'd like to be able to help with resolving this issue and would definitely like to improve what I have as well.

@alekseyg I confirm your solution is working today at version alpha 5.
Just used it in order to fix this issue and got it working.

@alekseyg - just chiming in to second that confirmation of success with the solution - thank you!

this worked for me...
            $('[data-toggle="popover"]').popover();             // close on body click             // iOS doesnt recognise 'body' click so using :not             $(':not(#anything)').on('click', function (e) {                 $('[data-toggle="popover"]').each(function () {                     if (!$(this).is(e.target) && $(this).has(e.target).length === 0 && $('.popover').has(e.target).length === 0) {                         $(this).popover('hide');                     }                 });             });

Actually probably the reason why the invisible screen was never implemented is probably because this doesn't make sens if you have a clickable element in the page, you will need to click twice to focus into an input...I guess it's going to be a waiting game on IOS at this point =/

probably the reason why the invisible screen was never implemented is probably because this doesn't make sens if you have a clickable element in the page, you will need to click twice to focus

counter-intuitive, but would
pointer-events: none;
on the screen solve the problem?

@alekseyg Is there a way to update your code so it doesn't close on scroll?

@jlavoie13 I've run into several tiny issues with this approach and have been working on improving it. I'll update the gist soon with some improvements.

see the contortions one has to go through for iOS here https://github.com/twbs/bootstrap/pull/22426
i'd really like to avoid having an invisible backdrop, as that just causes new problems (on touch-enabled devices with additional inputs, like touchscreen laptops/tablets with paired mouse).
i really wish iOS followed what Android and co do, which is to NOT have weird quirks relating to event bubbling/delegation...

@jlavoie13 I've updated my gist. Here's a summary of what I changed:

The wasTouchedRecently function used event timestamps to calculate when a touch happened. Unfortunately, different browsers use different timestamps, so it was unreliable. I replaced it with a data attribute and a timeout for better reliability.
I added e.preventDefault() on touchend of the element with the tooltip and on the body if a tooltip is shown to prevent tap-through actions from taking place when showing or hiding a tooltip. This also allowed me to get rid of the delay when hiding the tooltip.
I added a wasTapped check on the body in order to differentiate between taps and other gestures, like when toggling the tooltip. This should prevent scrolling from hiding the tooltip.

not tested this yet, but as a note: adding a touchstart to the body indiscriminately will lead to bad scroll performance (since the browser can then only scroll sync rather than async, and can't thread), unless using passive event listeners (which removes the problem, but only in modern supporting browsers)

#22481 ports the same hack i used for dropdowns to tooltips. while hacky, it's relatively small and has no known side-effects - all it does is coax iOS into doing event delegation/bubbling like all other touch-enabled browsers (grumble grumble)

@gregblass I checked out https://github.com/sandywalker/webui-popover and it worked for me as well right out of the box! Thanks! That saved me a lot of time in resolving this problem in my application.

While @turigeza solution works so tooltips are dismissible, this is only for iOS Safari, and in cases where a button invokes a modal or similar, the tooltip remains until you tap elsewhere.
I really think a solution that targets touch-enabled devices (not just iOS Safari) that auto-dismisses a tooltip after [x] seconds would be the best, and with Bootstrap 4 being mobile-first, I think should be part of the framework.

so let's be clear...is there still a current issue even after fixes etc? if so, please file a fresh issue with a reduced test case

I agree with Joyrex. I have just removed every single tooltip from a site because I noticed in iOS they stack and won't go away.

@patrickhlauke - well, yes - there really never was an adequate “fix” to begin with, for the reasons I pointed out.

and again, i'll ask you to post a reduced test case to show the issue, and post a fresh issue. the workaround implemented at the time covered the common scenario of tooltips like http://getbootstrap.com/docs/4.1/components/tooltips/#examples and they work fine on iOS. if there's further situations that currently fail...post a new issue instead of adding to a closed thread started in 2015

On iOS after click tooltip does not disappear BS 3.

@turigeza: FYI, this no longer works :(

If you have an issue please create a new one with a live test on a CodePen thanks


Documentation examples

Hi there.
First of all, congrats on this extensive library. I followed for some time your development effort and I must say, and saw the adjunction of documentation (mostly based on type signature), and I think that is great.
However I think that users like me would benefit enormously from a documentation which also portrays examples. A good example in that aspect is Ramda's, which I guess you all know (http://ramdajs.com/docs). Leaving aside the bells and whistles of ramda's doc (playground, etc.), what is great is the examples and the categorization (Function, Map, List, Object). Current documentation for fp-ts consist mainly of the name of the function and the corresponding type, which makes the whole thing not very friendly to absorb for beginners.
A part of the docs already do some of this :

https://github.com/gcanti/io-ts
https://github.com/gcanti/newtype-ts

Something I was looking at recently with a view to using it and I could not figure out exactly how to do so :

https://github.com/gcanti/fp-ts/blob/master/docs/api/md/Store.md
https://github.com/gcanti/fp-ts/blob/master/docs/api/md/Traversable.md

That http://ramdajs.com/docs/#traverse reads better than traverse: <F>(F: Applicative<F>) => <A, B>(f: (a: A) => HKT<F, B>, ta: HKT<T, A>) => HKT<F, HKT<T, B>>

I can probably figure out all of what I need to figure out but my fear is that I would spend too much time doing so. I can see in my code that I can benefits from functional abstraction (for instance I have a contract library which check assertions and aggregate errors, all of which could benefit from the applicative programming tools you have in fp-ts). But with the perceived syntax, abstraction, and documentation barriers, I feel like it is safer to keep things in plain and simple js/ts. Even supposing I figure everything out in a relatively short time, my colleagues or whoever comes after me, will have to do the exact same job, which compounds the perceived productivity loss.
Now, I am aware that there are a HUGE number of functions, and functionalities addressed in this library, so it looks like a large quantity of work to add examples everywhere. I still wanted however to give you guys my feedback, as I think it is also interesting to hear about the people who are not using the library, and why.
When I am between projects and with more time, I will be happy to properly dedicate resources to see how to integrate this library in my work.

@brucou

Something I was looking at recently with a view to using it and I could not figure out exactly how to do so

The reason is that ramda and other fp libs use Hindley–Milner notation (which is common for Haskell) when fp-ts being designed for TypeScript uses TypeScript signatures to express the type.
I don't know which one would be the best, just drawing your attention.

related https://github.com/gcanti/fp-ts/issues/157

Maybe signatures could be duplicated with Haskell version in the docs?

@raveclassic Too much work and you likely end up out of sync.
The distinctive feature of fp-ts is faking HKTs and abstract over them, no other lib is trying to do that.
Writing a data structure like Option or Either is relatively trivial,
defining Traversable and then sequence in a type-safe and usable manner is not.
However you end up with

verbose signatures
tons of overloadings

IME there are some informal rules to move back and forth though:
Type constructors
f a

-> HKT
HKT<F, A>

Type classes
class Functor f where
  map :: forall a b. (a -> b) -> f a -> f b

-> interfaces
interface Functor<F> {
  map<A, B>(f: (a: A) => B, fa: HKT<F, A>): HKT<F, B>
}

Instances
instance semigroupString :: Semigroup String where
  append = concatString

-> static dictionaries
const semigroupString: Semigroup<string> = {
  concat: x => y => x + y
}

Type contraints
instance semigroupMaybe :: Semigroup a => Semigroup (Maybe a) where
  append Nothing y = y
  append x Nothing = x
  append (Just x) (Just y) = Just (x <> y)

-> functions with additional initial arguments and returning instances
const getSemigroup = <A>(S: Semigroup<A>): Semigroup<Option<A>> => {
  return {
    concat: x => y => x.fold(() => y, ax => y.fold(() => x, ay => some(S.concat(ax)(ay))))
  }
}

@gcanti Nice explanation actually, should it be included into readme?

Sure, I'll gladly accept any PR which improves the documentation with such explanations and/or adds some examples.
I tried hard to follow those rules across the whole code base, for example here's the signature of sequence in PureScript
sequence :: forall t a f. Applicative f => Traversable t => t (f a) -> f (t a)

and here's the fp-ts counterpart
//                Applicative f =>   Traversable t =>     t (f a) ->                 f (t a)
sequence<F, T>(F: Applicative<F>, T: Traversable<T>): <A>(tfa: HKT<T, HKT<F, A>>) => HKT<F, HKT<T, A>>

is almost a one-to-one translation ;)

fp-ts Not for everyone. Only for people with a lot of Typescript experience.
No examples, no playground. Just only the name of the function and the corresponding type.
When trying to use fp-ts, I cried a lot, even the most basic feature such as Option, Either, pipe.

@nghiepit  I can agree with that. A lot of the blame I think is on TypeScript in the first place. After trying to use a variety of TS functional programming libraries I came to the conclusion that there isn't much to be gained from using formal functional patterns like monad and so on in JS. For types I use JSDoc. There is far too much syntactic noise involved in TS types, and TS functional libraries only compound that. The resulting code is hard to read for everybody, No amount of type safety compensates for that.
But again, the team has done a great job I think over the years with the documentation.

fp-ts Not for everyone. Only for people with a lot of Typescript experience.
No examples, no playground. Just only the name of the function and the corresponding type.
When trying to use fp-ts, I cried a lot, even the most basic feature such as Option, Either, pipe.

You are more than welcome to contribute in developing a playground and examples, it would be great!


Add file extensions to generated imports.

Files generated by the protoc plugin, currently, import witht he following syntax import {x} from 'y' however for reasons outlined in https://github.com/nodejs/modules/issues/444, the following syntax should be used for forward compatibility with esmodules import {x} from 'y.js'
Further reading:
https://nodejs.org/api/esm.html#import-specifiers
https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-beta/

@timostamm I could make an attempt at implementing this, if you could lead me in the right direction.
This is currently a blocker for me.

I'm happy to. The following function creates import paths:
https://github.com/timostamm/protobuf-ts/blob/fbce12b7259cacea5d45ebf3503c8ac8a0200c73/packages/plugin-framework/src/typescript-imports.ts#L285-L288
The function is local to the typescript-imports.ts module (of the package @protobuf-ts/plugin-framework), and exports the class TypeScriptImports.
The only place the class is used is in the plugin, on this line:
https://github.com/timostamm/protobuf-ts/blob/fbce12b7259cacea5d45ebf3503c8ac8a0200c73/packages/plugin/src/protobufts-plugin.ts#L161
So TypeScriptImports could take a boolean argument in its constructor, enabling the .js extension in imports. (Or, maybe better, make the .js extension the default behavior and let the argument disable it.)
To add a new plugin option, in protobufts-plugin.ts:
// add below the other option definitions:
enable_import_extension: {
    description: "...",
},
// further below:
imports = new TypeScriptImports(symbols, !params.enable_import_extension),

There is also the deprecated packages/plugin-framework/src/typescript-import-manager.ts, which can be ignored - it is not used anymore.
There is a spec file for parts of typescript-imports.ts. It is probably best to extend the test coverage a bit (its not actually covering TypeScriptImports yet) and implement against it.
I don't think it will be feasible to add test coverage in @protobuf-ts/plugin, because if I'm not mistaken, it uses a TypeScript version that does not support the .js imports yet.

#233


"Direct3d texture load: parameter incorrect" Error when loading into mission.

This error pops up whenever I load into a mission itself in XWA. I'm not the only one who's seen this. This error doesn't seem to occur in Jeremy's version.

Not sure it'll help, but can you say which graphics card that is and if you have the latest drivers installed?
I've not seen this issue or heard of someone having it before...

Ok I just tried on an old cd install and it worked fine. Justagai's vanilla campaign co-op version seems to cause this so will have to check that install further.


Mocking of APIs in retrofit, Canceling API update.

Added mocking of the APIs.
Updated gradles.
Updated canceling call from retrofit.
And other minor updates.

All changes reflected.
Although for ClipData  foreach loop is not applicable .

Thanks @DearDhruv for building an example and sharing.

Thanks, @PareshMayani
I shall make the example more richer as time permits.


Fix inconsistency between type libraries for markdown-it and linkify-it

Hey there! 😄
I was updating apocrypha to the latest version of Markdoc and started running into some type errors:
><EMAIL_ADDRESS>build:types
> tsc --emitDeclarationOnly --outDir dist

../../node_modules/@types/markdown-it/lib/index.d.ts:151:33 - error TS2694: Namespace '"/Users/nkohari/Work/apocrypha/node_modules/@types/linkify-it/index"' has no exported member 'LinkifyIt'.

151     readonly linkify: LinkifyIt.LinkifyIt;
                                    ~~~~~~~~~

Found 1 error in ../../node_modules/@types/markdown-it/lib/index.d.ts:151

Turns out, this is because @types/markdown-it depends on any version (*) of @types/linkify-it, but the latter wasn't reverse-compatible. This patch pins the version of @types/linkify-it to the one which is compatible with the the version of the actual markdown-it library that Markdoc uses.
Let me know if you have any questions or need more info!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


E2E: go workflow_dispatch branch1 SLSA3 config-ldflags

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/2310902175
Workflow name: go workflow_dispatch branch1 SLSA3 config-ldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Thu May 12 02:59:30 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/2317237109
Workflow name: go workflow_dispatch branch1 SLSA3 config-ldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Fri May 13 03:25:32 UTC 2022


NoClassDefFoundError when using code completion under Win10 x64

Hi,
I get this error when pressing TAB to autocomplete commands.
Uncaught error from thread [Remote-akka.actor.default-dispatcher-2] shutting down JVM since 'akka.jvm-exit-on-fatal-error' is enabled for ActorSystem[Remote]
java.lang.NoClassDefFoundError: scala/tools/nsc/interpreter/jline/JLineDelimiter
        at notebook.kernel.Repl.argCompletor$lzycompute(Repl.scala:134)
        at notebook.kernel.Repl.argCompletor(Repl.scala:133)
        at notebook.kernel.Repl.complete(Repl.scala:275)
        at notebook.client.ReplCalculator$$anonfun$receive$2.applyOrElse(ReplCalculator.scala:473)
        at akka.actor.Actor$class.aroundReceive(Actor.scala:467)
        at notebook.client.ReplCalculator.aroundReceive(ReplCalculator.scala:26)
        at akka.actor.ActorCell.receiveMessage(ActorCell.scala:516)
        at akka.actor.ActorCell.invoke(ActorCell.scala:487)
        at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:238)
        at akka.dispatch.Mailbox.run(Mailbox.scala:220)
        at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:397)
        at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
        at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
        at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
        at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
Caused by: java.lang.ClassNotFoundException: scala.tools.nsc.interpreter.jline.JLineDelimiter
        at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 15 more
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=1073741824; support was removed in 8.0
[error] application - Process exited with an error: -1 (Exit value: -1)
org.apache.commons.exec.ExecuteException: Process exited with an error: -1 (Exit value: -1)
        at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404)
        at org.apache.commons.exec.DefaultExecutor.access$200(DefaultExecutor.java:48)
        at org.apache.commons.exec.DefaultExecutor$1.run(DefaultExecutor.java:200)
        at java.lang.Thread.run(Thread.java:745)

I'm running SparkNotebook under Windows 10 x64 with following options/packages:
Build: |  buildTime-Thu Oct 29 21:23:32 UTC 2015 | formattedShaVersion-0.6.2-SNAPSHOT-81e597df3397535977a855046e218b278e0ef434 | sbtVersion-0.13.8 | scalaVersion-2.11.6 | sparkNotebookVersion-0.6.2-SNAPSHOT | hadoopVersion-2.6.0 | jets3tVersion-0.7.1 | jlineDef-(jline,2.12) | sparkVersion-1.5.1 | withHive-true | withParquet-true |.

My JDK Version is 1.8.0_66
Regards,
Harris

After some googling I found this info that seems to be related to the missing class path (JLine)
http://qnalist.com/questions/5488768/missing-jline-for-scala-2-11-0-rc1
It seems to have something to do with a private API.
Citation:
> I know we haven't been very clear about this, but scala.tools is
> internal API, so we offer no guarantees there.

damn, does that appear all the time? You run a scala 2.10 notebook? or 2.11?

Sadly, it appears all the time. I use scala 2.12.0-M3

Sorry, the last comment was misleading. In the Spark-Notebook I use scala 2.11.6.

ah okay, it might be then indeed the version of (12 I think) used by the scala repl.
is this happening with scala 2.10?.

Haven't tested it yet. I'll download another version of notebook with scala 2.10.

I'm now waiting for the build of the following config:
notebook: master
scala: 2.10.4
spark: 1.5.1
hadoop: 2.6.0
with hive: true
with parquet: true
package: zip

It works with the above configuration! :smile:


Training Data Issue

Hi!
I'm trying to train a custom dataset with your network with COCO and stable diffusion subset each 200K images.
I tried with the r1 i.e [Real, Synthetic] with 0,1 labels in the text file ,first but the loss is not dropping.
Then I tried to divide my data with r3 [Real, Synthetic, Real Painting, Synthetic Painting] each 200k images and assigned them labels of 0,1,2,3 accordingly. The loss increased instead with same BS. I see maybe there is some confusion in how to prepare the training file with labels. Can you provide a sample training txt file with image paths?
Thanks in advance

Thanks for your asking. It is very strange that loss cannot decrease in both labeling (e.g., r1 or r3). Could you provide more detailed information? Also, try using pre-trained weights (e.g., ImageNet), which will accelerate convergence.

I've tried similar training data with r3, but if we can reproduce your results so if its possible to release the training data?
That'd be very helpful

Thanks for your attention. The training dataset will be released soon.

The training dataset can be downloaded from the following link. Due to Google Drive's capacity limitations, we are currently only able to share it via Baidu Pan: https://pan.baidu.com/s/1ZgSiNX_Dd7cZcwiHv1ujVg?pwd=h4p7


Some versions of SALib don't work

The following versions of SALib don't yield numeric outputs, instead the return NAN.
If you encounter this issue and have a version of SALib installed which is not listed, add the version below:

<IP_ADDRESS>
1.4.4

@Tousif34344 : It's still an open issue.


Can't pause/rewind/ff new depth-anything beta build videos

The new Unity beta build with depth-anything works great for me, the only issue I have is the numpad 5, 6, 4 no longer fast forward rewind or pause when using the depth-anything model when playing a video. Any way to fix this?

Weird, in my environment it works with vitb14 loaded. You aren't using ffpymq.py, right?
See if the key is being pressed using Debug.Log(): here

Oh I am using mostly the large model with 4090 here, does it work on large model for you? I am once again out of town so I've been less active.

Works for me. The model selected should not influence that behavior.

Still doesn't work for me and did a fresh download, what keys should I be pressing? I did numberpad 5 for pause, etc. It used to works on older version when I test it.

Well, it should be not different from loading a midas onnx file. Does the console output any error?
Test if the key is pressed by changing here:

//CHECK `Keymapper.Inst` is not null
if (Keymapper.Inst == null)
	Debug.LogError("Keymapper.Inst is null");
else
	Debug.Log($"Pause: {Keymapper.Inst.VideoPause}");

if (Input.GetKeyDown(Keymapper.Inst.VideoRewind))
	Skip(-5f);
else if (Input.GetKeyDown(Keymapper.Inst.VideoPause)) {
	//CHECK IF THE KEY IS BEING PRESSED
	Debug.Log("Pause button pressed");

	PausePlay();
}
else if (Input.GetKeyDown(Keymapper.Inst.VideoForward))
	Skip(+5f);

Sorry for delay, I will get back to this soon. I didn't see a console error. I will try what you wrote above soon.


$ fails to auto-import

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:  1.80.0
Commit: 660393deaaa6d1996740ff4880f1bad43768c814
Date: 2023-07-04T13:40:17.963Z
Electron: 22.3.14
ElectronBuildId: 21893604
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.5.0

Steps to Reproduce:

npm install @builder.io/qwik
Create a test.tsx file with this content:import {} from<EMAIL_ADDRESS>
const fn1 = component$(() => <span />);
const fn2 = $(() => null);

Notice that Command-. on component$ correctly imports component$ from @builder.io/qwik

Now go to $() and perform Commant-. and notice that this time it fails to import from @builder.io/qwik

The correct behavior is to give me the choice to import from @builder.io/qwik and to update the code as:import { component$, $ } from<EMAIL_ADDRESS>

It appears that VSCode fails to recognize $ as a valid symbol which could be imported from an existing library.

Just tried to reproduce the issue and it is still persisting.
Version: 1.81.1 (user setup)
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:22:42.175Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

Just tried to reproduce the issue and it is still persisting.


Dev-3950

Changes / Comments
Moving the official publisher sheets to the top of the yaml. Check out internal documentation in Confluence for explanation.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Thanks this will help keep it organized for the official sheets


Training instructions for MOT 17

Hello! Can you please upload instructions to use the the training script for MOT17? Thank you!!

My bad. I forgot to upload this config file into configs but only put it here.
Now, as this commit, I have already uploaded the config file. Thanks a lot for your reminder.

Thank you so much!!

I think you may be conducting experiments on MOT17, and there are some things that I need to explain to you. I did not reply earlier because I was too busy in the past several days. Sorry about that.
First of all, due to the merging of several versions of code, there was a problem in passing parameters during data processing, which I have corrected in this commit.
Moreover, there are some differences in the configuration on MOT17 (compared with DanceTrack/SportsMOT):

The optimizer setting:LR_POINTS: 2.0e-5    # 1.0e-5 on DanceTrack
WEIGHT_DECAY: 0.0001    # 0.0005 on DanceTrack

I set the lr_points and weight_decay to 2.0e-5 and 0.0001 because of the stable convergence. This setting requires more training epochs, e.g. 18 (in our paper) to 20 (in our open-source code) on DanceTrack. However, as I discussed in #11, training on MOT17 is a delicate balance, so I haven't tried this new training configuration yet to see if it can achieve the desired results.
The image size during augmentation:COCO_SIZE: True    # False on DanceTrack

This setting comes from MOTR. I don't quite understand the reason for this, but it does achieve better results.
Whether the bounding boxes can exceed the image size:OVERFLOW_BBOX: True    # False on DanceTrack

Referring to some previous work, this approach can achieve better detection performance, but it will have a loss on the AssA metric. This is a difficult balance to choose.

BTW, it is also very common in MOT17 that newborn objects are suppressed by tracked targets, resulting in detection failure. Several recent research (CO-MOT/MOTRv3) focus on this. We hope we can resolve this issue in the future.


Generated app not starting with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

How often can you reproduce it?

[x] Always
[ ] Sometimes
[ ] Rarely
[ ] Unable
[ ] I didn’t try

After creating an application with donejs add app pwa-test, when I open the root directory and run donejs develop, I get the following error:

I see that done-serve is in the package.json dependencies, but it's not getting installed into node_modules/.bin:

Maybe this is an npm bug.  I'm using<EMAIL_ADDRESS>with<EMAIL_ADDRESS>
Steps to reproduce:

npm install -g npm donejs
donejs add app pwa-test
cd-pwa-test
donejs develop

Expected results:
The app should start without a problem.
Actual results:
The above error is thrown.

Environment:

Software
Version

donejs -V
1.0.0

node -v
7.6.0

npm -v
5.0.3

Operating system
macOS 10.12.5

@obaidott can you look into this while you're working on adding Node 8 to CI?

My guess is that the way donejs add app works is that the new lockfile gets created prevents additional packages from being installed. We might want to use the flag to disable the lockfile (if that is indeed the problem, just a guess here).

@matthewp this can be closed can't reproduce error. donejs add app + donejs develop works under node 7.6 even under node 8.1.2

Thanks.

This is still an issue. I just tested with npm 5.0.3 & Node 8.1.2 and I got the same issues as what @marshallswain originally reported.

Looks like others are having this same issue, related to package.lock.json: https://codeburst.io/disabling-package-lock-json-6be662f5b97d
It might be a quick easy fix to use --no-package-lock during the first npm install.

@chasenlehara why do i not get that error? maybe because using yarn right?

Probably! The original issue makes it pretty clear that npm was being used. Please don’t leave comments saying issues are fixed if you haven’t reproduced the original issue and can confirm it was fixed. 😊

@marshallswain i reproduced it i runned a donejs app a fresh one  under node 7.6 and 8.1 but i am using docker that means i mount the project dir and then on startup use yarn :)

This has been solved. It took making changes to both donejs/donejs and donejs/cli, but now neither step will create a package-lock.json file. In order to close this issue, a donejs/donejs patch release will have to be made with @chasenlehara's #978 changes, the donejs/cli changes are in its v1.0.2.

@andrejewski  so you mean
npm install -g<EMAIL_ADDRESS>

@frank-dspeed No, the fix for donejs will be released as DoneJS v1.0.1. At which point people can update using npm install -g donejs and this issue can be closed.


pytest - MLIR binary ops

@slyalin I took test_add.py as my test template. So far, when I run my test, I end up with:
AssertionError: Operation mlir::binary_ops type doesn't exist in provided graph
Not sure what I'm missing.

Can you also add the test from #139, but change input_shape to 1024 and output_shape to 128 and changed all instances of 10 and 1 to input_shape and output_shape respectively?

Not sure what I'm missing.

Okay, I think I get it now. This kind looks for equivalent type of node in the input graph. For this test, I'm interested whether the model can run at all. So, I can probably set my return value mlir::binary_ops to None as it is checked before compile_model happens.
It would be nice if I could somehow run validation on MLIR but maybe we can leave that for later.

Existing tests provide already decent coverage, for the rest benchmarks are currently enough.
Closing for now.


NotImplementedError: Data has duplicate values

data_model = ItemColdStartData(
training_data,
*training_data.columns, # userid, itemid
item_features=content_feature_df,
seed=seed)
print(data_model)
HERE IM GETTING ERROR: NotImplementedError: Data has duplicate values
My dataframe has multiple entries for a user. cant drop them. any help here

Hi!
The problem is not that your data contains multiple entries for a user, but that your data contains multiple entries of the same user-item pair. It's like having multiple ratings for the same movie from the same user. This is not a standard collaborative filtering scenario.
You need to deduplicate such entries, e.g., like this:
dedup_data = data.drop_duplicates(subset=['userid', 'movieid'])

Understood thanks for the help.
Facing one more blocker. data_model.prepare() kind of takes a lot of time and freezes when I run the step. Any idea why? i know my dataset is big but any optimisation that can be followed?


Rewrite Cowell's method with new ODE solvers

SciPy 1.0.0b1 is out:
https://github.com/scipy/scipy/releases/tag/v1.0.0b1
And the new ODE solvers are here!
http://scipy.github.io/devdocs/generated/scipy.integrate.solve_ivp.html
With a more functional approach, better support for dense output, new support for events, pure Python solvers... Everything we always wanted!
However, DOPRI853 (Dormand-Prince 8(5,3)) has not been implemented in this new framework, see:
https://github.com/scipy/scipy/pull/6326#issuecomment-229208306
I'm 100 % in favor of moving to the new solvers, but we should do some accuracy benchmarks before. If RK45 is not accurate enough, we will have to either stay where we are now (sad) or implement DOPRI853 ourselves (gasp).

On second thought, perhaps implementing DOPRI853 ourselves is not so difficult, see the implementation of RK45:
https://github.com/scipy/scipy/blob/v1.0.0b1/scipy/integrate/_ivp/rk.py#L324-L355
As always, the difficult bit would be validation. If I understood correctly, proper quantitative validation of the precision of the schemes was not carried out, see
https://github.com/scipy/scipy/pull/6326#issuecomment-250830082
So it should be enough to carry our own validation and make sure we are not making big errors with respect to the current situation.

Last note: if performance is an issue, we can use LowLevelCallable with numba cfunc decorator like this:
https://ilovesymposia.com/2017/03/12/scipys-new-lowlevelcallable-is-a-game-changer/

Moving this to the next milestone. Getting it right will require careful validation on our side, and it would be nice if we don't harm performance too much.

Closed in #368!


Don't auto-convert strings in traces to other types

When producing IR from traces, don't auto-convert strings to ints and bools. This was causing us to generate incorrect specs.

We need to selectively enable the auto-conversion. Seems like it's desired in some contexts (e.g., query-encoded inputs), but not in others (e.g., JSON bodies).


Cannot Connect to Node from Whitelisted IPV6 address

Describe the bug
Attempting to connect to a node which has my ipv6 address whitelisted results in the following error

I can confirm this is an issue with zap because the exact same QR/connection string works fine in Zeus.
To Reproduce
Steps to reproduce the behavior:

Enable IP whitelisting for an ln node
Add your ipv6 address to whitelist
Attempt to connect via zap

Expected behavior
Node should connect properly
Screenshots
See above screenshot
Your environment

Device: iPhone X
OS: iOS 14.3
0.5.2

Additional context
N/A

Issue was the port number. I was trying to use an http port. I thought the issue came from having an ipv6 address. GRPC port is 10009


[BUG] Numerical instability in loss curve over epochs when training on A100 with TF32 precision

Bug description
We have been reported by a user that when they train a TT model on P4 instance on AWS they observe the unstable loss curve as below. And this is mostly because of TF32 precision on Ampere GPU. The blue line below is TF32 and green is FP32 on the same machine.

@rnyak , please triage this bug.

@rnyak As you know, I performed a number of experiments with Two-Tower models (V1) on both V100 and A100 trying to reproduce the issue with a public dataset. I was able to find some situations where the loss became unstable, but not much due to the usage of Ampere (A100 x V100) or to the usage of the new TensorFloat32 (TF32) support in Ampere compared to FP32 ops, but to other factors like high Learning Rate.
One thing to notice is that the loss metric reported for each step by Keras is the cumulative average of the loss within the epoch. The plot provided above is the default logging with TensorboardCallback, which logs the (avg per-epoch) loss in the end of each epoch. To be able to better investigate the loss instability, I introduce in PR #862 the loss_batch metric, which reports the actual loss per-batch and not the cumulative per-epoch average loss.
In the following plot for A100 runs, we have the loss_batch on the left for FP32, in the middle for TF32, and on the right the cumulative per-epoch avg. loss for both.
P.s. Those peaks at the avg loss in the beginning of each epoch happen because the cumulative per-epoch average is more sensitive to the peaks (high values) in the first training steps of each epoch.
We can notice that with TP32 the peaks are slightly higher than with FP32 but the general trend of avg loss is the same.
.
The most important factor we could find related to loss instability was the usage of high LR. For example, below we plot in red the loss_batch with LR 1e-3 and in purple with LR 1e-4 (both with Adam optimizer on A100 with TP32). With the smaller LR we don't observe such instability.

Could the reported of the issue try using a smaller constant LR or a learning rate schedule (e.g. tf.keras.optimizers.schedules.ExponentialDecay) to try and stabilize the loss. If the issue persist, could the reporter try to log in TensorBoardCallback or WandbCallBack (W&B) the metrics per batch, including the new loss_batch metric.

Oi @gabrielspmoreira !! I'm the original author of the graphs on the top of the ticket. So just to clarify those two learning curves were generated using the same set of hyperparameters. Including the same LR. The only thing that I changed was TF32 and FP32 format. So I'm still not sure if different learning rates would explain everything.
That said, I also used AWS P4s to get those GPUs. I don't know if the way AWS provides those instances would have any extra configurations affecting the results. But I wouldn't expect so... Do you have any previous experience with nvidia drivers or anything like that affecting numerical stability?

oi @EderSantana ! Nice to meet you!
I understand you have observed the difference by just enabling/disabling TF32.
I used in the experiments both TwoTowerModel and your custom implementation of it (with shared embeddings between towers), Adam and LR 1e-3. But unfortunately I could not reproduce the issue with a public dataset (TenRec).
Would you be able to provide a reproducer (exact code, hparams and data sample), so that we isolate if the issue is within Merlin Models, TF or Nvidia drivers?
May I ask if the issue also happens with the MatrixFactorizationModel? As that one uses only user and item id and a dot product operation, that could be a good test to better isolate whether the issue comes with additional features and dense layers.
In addition, have you tried the InputBlockV2 and TwoTowerModelV2 example I think @rnyak has provided you? Porting from the "V1" of those classes to V2 should be straightforward and then you could check if the loss instability issue remains with the latest version.

It would be hard for me to share more due to data privacy issues and I talked to Ronay...
But I'll give InputBlockV2 a try as soon as possible let you know how it goes.
Thanks a lot for checking it out and clarifying to me here!

Closing this ticket as we couldn't reproduce the loss instability with synthetic data. Please re-open a new issue if the instability is observed with the InputBlockV2 as well.


Where is the Prometheus image?

Hi Luxas - I need to find your Dockerfile for this image so I can rebuild it.
https://hub.docker.com/r/luxas/prometheus-arm64/tags/
Can you help? It doesn't appear to be documented on the Hub repo.

It's here: https://github.com/luxas/kubeadm-workshop
Run make -C images/prometheus on an amd64 machine, and it will do everything for you


Fix for Multiple Users?

Hello again,
I understand that you said the project doesn't work for multiple users but is there anyway it could? Since it works with only one account, even after using set_cookies(), it means that if a user wanted to grab their stats, it's not possible unless their account is public and I understand that not everyone wants to do this.
If it's not possible, the name set_cookes() is a bit misleading since it seems like it allows for multiple users to be connected.

If you want to connect multiple users I could add the cookie parameter to more functions as I did with authkeys. I'm pretty sure I won't be making that functionality through set_cookies though.
PS: If you are unsatisfied with a feature/bugfix you can always reopen an issue, no need to make a new one.

Ah, apologies with the multiple issues; will do next time. And if you don't mind, supporting multiple users would be really helpful!

Got an error using claim_daily_reward with cookie parameter.
"/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/genshinstats/daily.py", line 80, in claim_daily_reward
    rewards = get_monthly_rewards(chinese, lang=lang)
  File "/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/genshinstats/daily.py", line 40, in get_monthly_rewards
    return fetch_daily_endpoint(
  File "/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/genshinstats/daily.py", line 27, in fetch_daily_endpoint
    return fetch_endpoint(url, **kwargs)
  File "/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/genshinstats/genshinstats.py", line 146, in fetch_endpoint
Error:     raise NotLoggedIn('Login cookies have not been provided')
genshinstats.errors.NotLoggedIn: Login cookies have not been provided

the code I tried
for index, uid in enumerate(uIds):
	gs.claim_daily_reward(lang="ko-kr", cookie={'ltuid': int(uid), 'ltoken': tokens[index]})

while the code below work properly
for index, uid in enumerate(uIds):
	gs.set_cookie(ltuid=int(uid), ltoken=tokens[index])
	gs.claim_daily_reward()

Since get_monthly_rewards, which is used to get the reward claimed, always returns the same data no matter the user requesting I didn't think of adding a cookie parameter for it. I think I should just add the cookie argument to every function to avoid these kinds of problems completely.

Could you please look if the dev branch fixes these bugs?
You can install it with
pip install -U git+https://github.com/thesadru/genshinstats.git@dev

the job with gs.claim_daily_reward(cookie={...})  done work without error. but I can't check if it actually works right now.

claiming daily reward works itself, but there was an error I got.
    gs.claim_daily_reward(cookie={'ltuid': int(uid), 'ltoken': tokens[index]})
  File "/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/genshinstats/daily.py", line 84, in claim_daily_reward
    rewards = get_monthly_rewards(chinese, lang, cookie)
TypeError: unhashable type: 'dict'```

and setting the `lang` parameter to it seems to do nothing.

I called `claim_daily_reward` as like
```py
gs.claim_daily_reward(lang="ko-kr", cookie={'ltuid': int(uid), 'ltoken': tokens[index]})

but I still got an in-game mail reward wrote in English.

The TypeError seems to be caused by improper caching with lru_cache.
As for the mail language, I had no idea it was determined by the language used on hoyolabs. I'll see what I can do about that one.

It works without any error for now.
and also setting language parameter work properly as well, don't know why It didn't at that time though.

Alright great, I pushed the changes to master.


Implement Redux and Custom Utilities for API Readiness

Feature
Why is this feature being added?
While we're refactoring the nav components, let's go ahead and start merging some Redux files for the GitHub API. I've got some files I've been working on for this, and they will complement the backend feature for aggregating contribution data, etc. I will make a PR, and it will serve as a basis for the "grunt work" for this major change to the app. Let's take our time and make sure everyone is satisfied with the results.
What should your feature do?
It should not interfere with the topnav branch! It will provide frontend utilities for displaying data from the backend endpoints using Async / Await and other middleware / custom utilities. It should be a service(s) that is shared across the frontend for use in any component.

Why did you close #305 for this? Move this issue's content there.


knowledge graph embedding examples - Bin Shang

My name is Bin Shang. As requested by professor Yong You, I add three knowledge graph embedding examples DistMult, ComplEx and RotatE.  Please check the code and feel free to contact me if you have any questions.

您好，我已收到您的邮件。

Hi, can you add a section Prepare Dataset in your README.md so that others know how handle the data processing. Meanwhile, have you verified the convergence of this model? If so, please attach the logs/plots here.

Hi, can you add a section Prepare Dataset in your README.md so that others know how handle the data processing. Meanwhile, have you verified the convergence of this model? If so, please attach the logs/plots here.

Hi, can you add a section Prepare Dataset in your README.md so that others know how handle the data processing. Meanwhile, have you verified the convergence of this model? If so, please attach the logs/plots here.

OK， I would remove the dataset and add Prepare Dataset in  README.md. The convergence of the model has been verified, and these three methods are the classic KGE algorithm.


subsys: bluetooth: host: Add a user data pointer in struct bt_conn

Add user_data pointer to struct bt_conn.
Define two functions to set and get the user_data pointer related to a
connection; bt_conn_set_user_data() and bt_conn_get_user_data().
An application which supports several simultaneous Bluetooth
connections and needs to maintain some state information related
to each connection does not have a simple way to link that state
information to the particular connection.
One way for the application to link the application data to the bt_conn
structure is to loop over all known connections and search for a match
with the bt_conn-pointer which is passed to the callback function.
This method will become CPU-inefficient if there are many callback
activations during the connection.
Therefore we propose to add a user_data pointer in the bt_conn
structure. The memory which the user_data pointer points at
is "owned" by the application and not touched by the stack.
To set and read the pointer, two functions are added to conn.c,
bt_conn_set_user_data() and bt_conn_get_user_data().
The application may choose to make user_data point to one of it's data
structures upon establishment of the connection through
bt_conn_set_user_data().
All callback functions which has the bt_conn pointer as parameter will
be able to access the application specific user_data through the
returned pointer from bt_conn_get_user_data().
Signed-off-by: Kim Sekkelund<EMAIL_ADDRESS>

Btw, we have an internal bt_conn_get_id() API which eliminates the need to do look-ups of the right context (sorry, missed this detail of the PR description initially). We should probably look for a way to make it public - the main reason it's not is that it's easily confused with the local identity (it's possible to have multiple ones). Perhaps naming id to index might make it clearer that it returns an array index that can directly be used on an array with CONFIG_BT_MAX_CONN elements.

FWIW, currently the bt_conn_get_id() is exposed through subsys/bluetooth/host/conn_internal.h. It'd need to be moved (along with the renaming) to include/bluetooth/conn.h

I'd also like to add that one other reason this API hasn't been made public is that it then locks us into an implementation where the bt_conn objects are internally stored in a single array, i.e. we couldn't internally transition to, say, heap-allocated objects since then the concept of array index goes away.

Example bt_conn_get_id() usage:
https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/bluetooth/host/gatt.c#L290-296

Codecov Report

Merging #11581 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #11581      +/-   ##
==========================================
- Coverage   48.42%   48.42%   -0.01%
==========================================
  Files         270      270
  Lines       42126    42131       +5
  Branches    10139    10139
==========================================
  Hits        20400    20400
- Misses      17645    17650       +5
  Partials     4081     4081

Impacted Files
Coverage Δ

subsys/bluetooth/host/conn.c
32.15% <0%> (-0.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d51f138...30ca943. Read the comment docs.

@jhedberg, thanks for your comments. We currently use the approach that you mentioned in the first comment which is as you say less elegant.
If bt_conn_get_id() will be exposed in conn.h it would be just as fine for us, and we would use that as table-index for the connection. All we need is to link the bt_conn to the application's state data in a simple and efficient way.
I understand the concerns of locking the design to be array based by exposing the bt_conn_get_id().


Try adding nix cache

Depends

[ ] #100

Problem

Solution

Related

#99

Doesn't really seem to work


Make MessageID mandatory

As far as I understand, from your docs and after asking your customer support team, MessageID should always be in the response if it's a successful send. I'm just updating the MessageSendingResponse interface to reflect that.
If this is not the case, could you let me know in which scenarios could we not get a MessageID for a successful response from your API?

Hi
this is fixed in the latest 3.0.0 release.

@ibalosh thanks! We'll wait for 3.0.0 to be published then.


Allow custom decks via JSON [Feature request]

Since CardCast has shut down and (as of time of writing) api.cardcastgame.com returns NXDOMAIN, there is currently no easy way to add custom decks other than importing them into the database. To avoid reliance on third parties in the future, adding custom decks via URL in JSON format could be a way to achieve this:
/addcardcast <deck code> is replaced by /addurl <url>, where <url> is a link to a hosted JSON file (or an API that returns JSON for that deck). The format of the JSON could be similar to Cardcast's to aid compatibility, although finding documentation on that is harder now.
Obviously for some servers the ability to load these files is a concern, so I propose an option (perhaps in build.properties) firstly to allow/disallow this feature, and later on to whitelist certain domains.

That is a fantastic idea, I can write a PR if @ajanata will merge it.

I like the idea and I'll merge it (probably not difficult to change the existing cardcast code, which I won't delete when I disable the commands later today), but I will not enable it on my own servers. I've had too many issues with DDoS in the past, which stopped when I put the servers behind Cloudflare... Letting users make the servers connect to arbitrary URLs will expose their actual IP addresses, which would make DDoSes possible again.
There also should be some sort of check on the content-type and content-length response headers before the entire response is downloaded, to avoid intentional large responses trying to crash the servers.
Now, if there'd be a whitelist of domains (in addition to the size checks), I'd consider having that enabled; e.g. gist.github.com is trustworthy.
Obviously this wouldn't be as easy to use for the end user, but it'd at least enable the functionality again.
I still have some sample cardcast json files somewhere. The existing code does hit two endpoints (to get metadata about the deck (mainly its name), and to get the cards themselves). This should be combined into a single file for something like this. Additionally, deck ID numbers will need to switch to something like the card ID numbers (monotonically increasing), but also probably still be negative. And the watermark needs some thought. It's definitely doable without a huge amount of effort.
I believe the format for the cardcast files were something like (at least for the relevant fields)
(info endpoint)
{
  "name": "name of the deck",
  "description": "I actually don't see this in my example files, so... remove references to it?"
}

(cards endpoint)
{
  "calls": [
    {
      "text": [
        "",
        " and ",
        " are the next hit comedy duo."
      ]
    },
    {
      "text": [
        "What's that smell?",
        ""
      ]
    }
  ],
  "responses": [
    {
      "text": [
        "The biggest, blackest dick."
      ]
    },
    {
      "text": [
        "Two midgets shitting in a box."
      ]
    }
  ]
}

The calls (black cards) are joined with ____, and len(text) - 1 is the pick value (there must always be at least two things in that array). The responses (white cards) are simply taken as-is.

What about providing the JSON directly to the server instead of fetching it from an URL?
We could have both: either from an URL if the user uploads it to a trusted source or from the user itself. Would that expose any vulnerability?

Direct uploads should be fine. In fact, that should provide size protection automatically if the servers are being reverse proxied (mine are behind nginx).
Honestly it might be worth just overhauling the system entirely to take black cards in ____ and ____ are the next hit comedy duo. format directly (and it can count the number of ____ to determine the pick amount), and just a list of white cards. Possibly in two text fields.
Shit, I almost want to do this myself (haven't had motivation to do much of anything in months), but I have too many other things going on this weekend. :(

I've done some work with #241.

If I am reading the code right, we can't currently upload custom decks directly on the website, can we?

@StarburstGalexy  When #241 will be merged, you'll be able to upload custom decks to the server and use them in game.

I'm taking a look at it this weekend. The last week was incredibly busy at my day job...

@ajanata Do you mind if I reformat the files I'm modifying to use 2 spaces indentation consistently? Various PRs messed the formatting quite a lot. What's the minimum Java version this needs to run on? There are some optimizations that can be done in this regard.

Do you mind if I reformat the files I'm modifying to use 2 spaces indentation consistently? Various PRs messed the formatting quite a lot.

 Go for it.

What's the minimum Java version this needs to run on?

My servers are still on 8. I'd prefer it if it'd still work there, cuz I haven't tried upgrading any of them and fully expect things to break.

I've setup my own server based on #241. Available at: https://pyx.gianlu.xyz/ZY/, the Android app has also been updated for beta testers (3.2.0).

@devgianlu I don't know what the future plans are for #241  if it still going to be developed might good to implement the solution of having the system identify cards with "___" in order to have compatibility with CRCAST JSON format, as @ajanata already suggested.
For the time being it could be useful to provide a helper script in your branch like the one I posted below that converts CRCAST decks into PYX compatible json, since it seems like there is no "official" way to do this as of right now.
import json
from re import split

in_file = 'input.json'
out_file = 'output.json'

with open(in_file) as json_in:
    data = json.load(json_in)

data['watermark'] = data['deckcode']
del data['deckcode']
for response in data['responses']:
    response['text'] = [response['text']]

for call in data['calls']:
    if '_' in call['text']:
        call['text'] = split(r'_+', call['text'])
    # No fill? No problem.
    else:
        call['text'] = [ call['text'], '' ]

with open(out_file, 'w') as json_out:
    json.dump(data, json_out)


Needs to give data on who won

It would be very useful for my current project if this gave me data on who won each game.

Thanks for the interest in the project :smile:. For my use case, I only need the teams and I don't really want to add more complexity to this, so for now I don't have any plans to add results. Good luck on your current project!

Okay. Thank you!


feat(metadata): import section metadata

Importing section metadata from the boilerplate.

Moved the readBlockConfig function up
Imported toCamelCase
Imported section metadata logic

The changes can be tested here:
https://section-metadata--blog--webistry-development.hlx.page/
https://section-metadata--blog--webistry-development.hlx.page/en/drafts/williambsm/content-toggle
This demo contains three sections with metadata.

@williambsm what are you looking to use out of section-metadata? I think we want to pull in Milo's version, but depending on what you need, we may need to add features to it.
cc @fullcolorcoder


CI failure: error, failed to find any spider controller pod

Set title to be in the format CI:
error, failed to find any spider controller pod
Copy-paste the output the test failure.
make -C test e2e_test
make[1]: Entering directory `/root/code/spiderpool/test'
 Run e2e test on the cluster spider
 [E2E] Run E2E with ginkgo label=R00006 , timeout=60m GINKGO_OPTION=
find cluster node: spider-control-plane,spider-worker
debugEnv.sh : E2E_KUBECONFIG /root/code/spiderpool/test/.cluster/spider/.kube/config
error, failed to find any spider controller pod
make[1]: *** [e2e_test] Error 1
make[1]: Leaving directory `/root/code/spiderpool/test'
make: *** [e2e_test] Error 2

Upload the zip file generated from that test failure.
The zip file is empty

Copy-paste the link of the CI build where that test failure has happen.
https://github.com/spidernet-io/spiderpool/runs/7940139227?check_suite_focus=true
Include any output from logs that you think may be relevant (to ease GitHub searches).

Direct error when running the test case，error, failed to find any spider controller pod
There may be a problem with the code here

CONTROLLER_POD_LIST=$( kubectl get pods --no-headers --kubeconfig ${E2E_KUBECONFIG}  --namespace kube-system --selector app.kubernetes.io/component=spiderpoolcontroller --output jsonpath={.items[*].metadata.name} )
AGENT_POD_LIST=$( kubectl get pods --no-headers --kubeconfig ${E2E_KUBECONFIG}  --namespace kube-system --selector app.kubernetes.io/component=spiderpoolagent --output jsonpath={.items[*].metadata.name} )
[ -z "$CONTROLLER_POD_LIST" ] && echo "error, failed to find any spider controller pod" && exit 1
[ -z "$AGENT_POD_LIST" ] && echo "error, failed to find any spider agent pod" && exit 1

#603


Crossterm backend input is not working

I noticed, and I hear from some other people that the input of the crossterm backend is not working correctly, especially talking about the crossterm demo example. The keys seem not to be recorded. I can have a look at this in a few days, but if there are people that can do that as well it will be appreciated.

This should be fixed since this commit: 9a73ead88da495ba5103f1872ec427e0b126a0cf

Alright, will have a check, would be great if the problem is already fixed :)

The crossterm demo example is wrong:
    let (tx, rx) = mpsc::channel();
    {
        let tx = tx.clone();
        thread::spawn(move || {
            let input = input();
            let reader = input.read_sync();
            for event in reader {
                match event {
                    InputEvent::Keyboard(key) => {
                        if let Err(_) = tx.send(Event::Input(key.clone())) {
                            return;
                        }
                        if key == KeyEvent::Char('q') {
                            return;
                        }
                    }
                    _ => {}
                }
            }
        });
    }

make it like:
    // Setup input handling
    let (tx, rx) = mpsc::channel();
    {
        let tx = tx.clone();
        thread::spawn(move || {
            let input = input();
            let mut reader = input.read_sync();
            loop {
                match reader.next() {
                    Some(InputEvent::Keyboard(key)) => {
                        if let Err(_) = tx.send(Event::Input(key.clone())) {
                            return;
                        }
                        if key == KeyEvent::Char('q') {
                            return;
                        }
                    }
                    _ => {}
                }
            }
        });

@TimonPost Is it that the iterator might returns None on Windows while it does not on Linux ?

You are correct, I just discovered that in the case of windows, crossterm checks if there is an input event available for reading. If not it returns None directly, therefore it isn't it a blocking call. In the case of linux, a tty file read is done, which is blocking. So this should be fixed and updated in crossterm.

Can be closed, notice that this problem is fixed in crossterm 0.11

Can be closed, notice that this problem is fixed in crossterm 0.11

Shouldn't the dependencies get updated before the issue gets closed? After all, it's still reproducible on the current master.

#193 fixes this


logic in Linq Expression is not allowed？

Op system: Windows 11 x64
Engine : Unity + il2cpp + netframework
exception：
SQLiteException: near ",": syntax error
SQLite.SQLite3.Prepare2 (System.IntPtr db, System.String query) (at Assets/Scripts/SQLite.cs:4983)
SQLite.SQLiteCommand.Prepare () (at Assets/Scripts/SQLite.cs:3441)
SQLite.SQLiteCommand+<ExecuteDeferredQuery>d__12`1[T].MoveNext () (at Assets/Scripts/SQLite.cs:3274)
System.Collections.Generic.List`1[T].AddEnumerable (System.Collections.Generic.IEnumerable`1[T] enumerable) (at <6073cf49ed704e958b8a66d540dea948>:0)
System.Collections.Generic.List`1[T]..ctor (System.Collections.Generic.IEnumerable`1[T] collection) (at <6073cf49ed704e958b8a66d540dea948>:0)
System.Linq.Enumerable.ToList[TSource] (System.Collections.Generic.IEnumerable`1[T] source) (at <1e18c5a6594041c9844bfd0b6618ee4a>:0)
SQLite.SQLiteCommand.ExecuteQuery[T] () (at Assets/Scripts/SQLite.cs:3244)
SQLite.TableQuery`1[T].ToList () (at Assets/Scripts/SQLite.cs:4778)
SQLite.TableQuery`1[T].FirstOrDefault () (at Assets/Scripts/SQLite.cs:4804)
DataService.GetPerson (System.Linq.Expressions.Expression`1[TDelegate] value) (at Assets/Scripts/DataService.cs:85)
ExistingDBScript.Start () (at Assets/Scripts/Foo.cs:45)

code snippet: (code that not so important has been ignored)
class DataServers
{
   private SQLiteConnection _connection;
    internal Person GetPerson(Expression<Func<Person, bool>> value)
    {
        return _connection.Table<Person>().Where(value).FirstOrDefault();
    }
}

class Foo
{
        IEnumerate<Person>  people = ds.GetPersons();
        // this line throw exception I paste above.
        var person = ds.GetPerson(v => v.Name == "Johnny" && v.Id == people.Count());

        // write like this is ok
        var idx = people.Count();
        person = ds.GetPerson(v => v.Name == "Johnny" && v.Id == idx );
}

is  this a bug or designed.

I've had similar issues with this library in the past, what I've found is that the LINQ expressions aren't actually executed as LINQ, they're broken down into pieces and turned into SQL queries. This process doesn't understand e.g. people.Count() and tries to turn it into an SQL function which fails because it doesn't exist, while calling that function outside the expression and using the value works as expected.

Yeah, the expression is used to examine its structure and write the correspoding SQL bits, but it's never executed.
It probably expects binary operations where terms are literals or primitive assignments, but not method calls.


Tracking list of models per oseries

See discussion in #50

Will close this PR if the #62 is approved.


add email exists validation

When a user's email doesn't exist in wink_author during password-reset, validation error will show up.

That's kind of opinionated because some people may think it'll expose if an email is in the system or not, so you type an email and try if you get validation error you know that email address isn't in the system, otherwise it is.


[Timed out] Installing 'IntelliJ-IDEA' (2020.1.2-201.7846.76) [64bit]

Terminal:
Scoop was updated successfully!
Installing 'IntelliJ-IDEA' (2020.1.2-201.7846.76) [64bit]
The operation has timed out URL https://download.jetbrains.com/idea/ideaIC-2020.1.2.win.zip is not valid

Resolved


Drop the sequence type syntax in constraints

Use the same cardinality syntax from members

Done, replaced with sequence constraints on types and values


RFC; change backend from go to nodejs

Just a personal preference here, since i don't know Go at all :)
Considering we already heavily use js for the frontend, it may be easier for new contributors to start out if the backend also is js rather than a 2nd language.
Some of the ideas I have for the project I could easily implement in node, but won't be impossible for me to do in Go.
Considering the fairly simple backend, it should be somewhat easy to it to node - and since the project is shipped through docker, it should be a safe change to do there as well, as there would be no additional complexity for just consuming the project.

My personal preference is Go, because I don't know how to create a backend in Node :-)
Kidding aside, there is a big advantage to using Go and that is that we get to piggyback on the Nomad API package which will always be maintained and developed as part of Nomad. This way we don't have to bother with keeping in sync with API and just get to use all the good stuff.
Backend work is definitely different from frontend work even if it is the same language and I think that Go is more suited to this particular task. Another aspect is that people are also just running the binary (with Nomad) and not relying on Docker. Using Go makes this trivial but Node would require a suitable runtime environment (on all platforms).
Like you said, the backend is fairly simple at this moment and Go has enough packages to provide flexibility when we need it. For now I would like to keep using Go. Please tell me what you want to achieve and we'll implement it :)

I agree that it is the best thing to distribute nomad-ui same as nomad itself i.e. via native binaries.

ok, I yield then :)


audio-echo bugfix

when tearing down echo engine, close play stream first, then close record stream

I think another problem might be that stopStream() calls stream->requestStop which is asynchronous. This means there's no guarantee that the streams have actually stopped before they are restarted. Maybe stopStream() should block until the stream state changes to STOPPED, although this may not be desirable behaviour if called from the UI thread.
Phil - what do you think?

the behavior is exposed through stopStreams(), the stop then close logic is there already. The ones inside destructor may not be the cause of the problem, just add the similar change there to make is consistent.

Close() will block until the stream is stopped. Then it deletes the stream.

Good. Closing the output stream first will stop the data callback. If you close the input stream first then the output callback could try to read from a closed stream, which has been deleted. So this is the correct order.
Do you want to merge it? Or do you want me to merge it?

Phil, do you mean AAudioStream_requestStop() will block until the stream is stopped? The docs explicitly state that the call is async: https://developer.android.com/ndk/reference/group___audio.html#ga6727be00b9cb4330981c20242ce32299

Oh, I see:
AAudioStream_requestStop() - asynchronous
AAudioStream_close() - synchronous
I will comment the code to this effect.


Permit the unfold '...' at end of line to unfold recursively (not just fixed to 1 level)

Currently the '...' at the end of the header line of a folded function only unfolds 1 level, would like a preference to have this unfold recursively

Just to mention: Shift+click on the folding indicator already unfolds recursively.

Just to mention: Shift+click on the folding indicator already unfolds recursively.

The Shift-click def what I want, thanks. Now what I'd like is a way to swap the click and shift-click behavior (make the unfold recursively the default)

The Shift-click def what I want, thanks. Now what I'd like is a way to swap the click and shift-click behavior (make the unfold recursively the default)


fix(timer-controller): Slight change in order of operation

:tada: This PR is included in version 6.8.7 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Create servicemonitor.yaml

Creating service monitor for vault

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no

Deprecations?
no

Related tickets
NA

License
Apache 2.0

What's in this PR?

This PR is raised to include a new 'service monitoring' feature for vault. A ServiceMonitor is used to define an application you wish to scrape metrics from within Kubernetes, the controller will action the ServiceMonitors we define and automatically build the required Prometheus configuration. Currently we do not have a service monitor for vault due to which we do not receive any metric related to vault
Why?

We can get vault related metrics post implementing a service monitor
Checklist

[x] Code meets the Developer Guide

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please bump the chart version @aravind-bluescape

Please bump the chart version @aravind-bluescape

Chart version bumped. Could you please review and merge?


random_seed is not set in def change_model() of class ProstheticsEnv(OsimEnv)

Though stated in the document of interface.

seed - starting seed for the random number generator. If the seed is None, generation from the previous seed is continued.

and here is the source code:
def change_model(self, model='3D', prosthetic=True, difficulty=0, seed=None):
    if (self.model, self.prosthetic) != (model, prosthetic):
        self.model, self.prosthetic = model, prosthetic
        self.load_model(self.model_paths[self.get_model_key()])

seed is not set.

Thanks for catching that. There is no stochasticity in the first round, but there will be in the second round https://github.com/stanfordnmbl/osim-rl/issues/159 and the seed will become relevant

I am trying to see if it is possible to make the training deterministic.
Is there any non-deterministic introduced by OpenSim environment? Any known computations (besides GPU computation)? Any other random seeds to be set besides the following?
 tf.set_random_seed(x)
 np.random.seed(x)
 random.seed(x)

Cheers.

I suppose there might be potentially some stochasticity in sampling for the integrator. @carmichaelong is there any stochasticity on the OpenSim side during forwarding simulations?

There shouldn't be any stochastic events during integrations.

Thanks, @carmichael.
@huschen closing, for now, let us know if you experience any nondeterministic behavior.


Replace the built in conversation id with the plugin model's conversation id

We are implementing the JinChat model as a plugin and to continue the conversation the JinaChat has it's own conversation id that we can reference in the API.
Currently, it seems we cannot override the built in conversation id with our own which creates the new conversation in our end.
https://github.com/simonw/llm/blob/101795f858952278027c8b4d10c3a0de237756b0/llm/models.py#L33-L37
Is there any workaround to replace the conversation id?
JinaChat API: https://chat.jina.ai/api
Thank you.

Here's some details on how Jina AI's LLM ( JinaChat ) handles the conversation:

User starts a chat and continues the conversation.
For every new messages following the conversation, we don't send the whole history, we send the conversation chatId with the last prompt.

In this manner, our users get charged only for the most recent message and not for the entire chat history, thereby making it more cost-effective.


Fix indexes introduced in #6348.

The indexes introduced in #6348 were on the wrong table. The tests
did not catch them due to retries on the create table steps (the
first try created the table but not the bogus indexes; the second
try noticed that the table already existed and did nothing). This
patch doesn't fix the issue with the tests, since the best way to
do that would be to do the table and index creation in a
transaction; but, this is not supported by all of our supported
database engines.

Thanks @QiuMM for the catch!


Fix: user reset for Thanks after Review

Fixes #5174
In the ReviewImageFragment.java file, the "THANKS" case got the username through an if statement. This if saved the username from the previously reviewed image in "savedInstanceState" and kept using it whenever the review screen was loaded again (wether or not it was the same image being reviewed).
I believe this was added in order to avoid the app crashing whenever the app got rotated while on that screen (since "user" could have been null). However, it meant showing the same username even with the next image.
By removing the if statement, The app does not crash while it is rotated on that screen, but the message that includes the user disappears. Still, it doesn't affect the next user displayed. I do believe it is better this way for now, while this new "disappearing message issue" is dealt with.
https://user-images.githubusercontent.com/108767897/226074991-4cd5d990-be45-4b7e-99f5-b4d1835b31fa.mov
https://user-images.githubusercontent.com/108767897/226075288-031fca1d-f8c4-4773-a25a-e870bc3318bc.mov

Review by student
Before:
https://user-images.githubusercontent.com/83745993/226091841-b13b224f-53d6-47b0-90e8-6bd9d6f56bd0.mp4

After:
https://user-images.githubusercontent.com/83745993/226091856-a9a7c056-1b16-49a2-8c7e-160230d3c031.mp4

The name of the uploader is getting changed now 👍🏻

The app does not crash while it is rotated on that screen, but the message that includes the user disappears.

I tested for this and the user is appearing with your changes too. I don't think the earlier code included a null check to handle the orientation changes. It was simply using the saved name as stated in the comments:
// Get existing user name if it is already saved using savedInstanceState else get from reviewController

I think we can still use savedInstanceState. We can use the username if that is available or go for the SAVED_USER in case the user is null.

The fact that the message disappears on rotation is not ideal, but the new behavior is still better than showing an erroneous username.
Thanks!

Ah, I believe SAVED_USER is not used anywhere? Would you mind removing it? Either in this pull request or in a new one.

The change in this MR certainly does improve the status quo. The change which @RitikaPahwa4444 seems to demonstrate in her comment above seems better, though. Ritika, it would be great if you could raise an MR with your suggest change :-)

Sure! I'll create a pull request soon.


Add AWS::EC2::CustomerGateway support

I think I have it using IPAddress now.

Please squash to a single commit and I'll get it merged and released.

The commits should be squashed.


bug: isVisible API always return true

In windows 10 the isVisible() always return true if the app is minimized or not focus.

After some talk in discord, I think this works as intended except when its minimized.
What i need is a isFocus api :) to check if the app is focused or not..


Adds VOLUME instruction to Dockerfile

The VOLUME instruction allows this image to to be used with persistent data via the OSX Kitematic App. https://kitematic.com/

Thanks for the pull request.


[FEATURE] Redesigning the UserCard

Description
Hi,
I hope you are doing well.
I came across and saw that User Cards seem to be a simple design, I thought it would be great to design a new User Card.
That's why I have designed one and I want to show them to you, if you liked it, then I can work on this and implement the new card.
I am waiting for your Replies :)
Screenshots

Additional information
No response

Looks good and we appreciate you taking the time to do this, but as we are in the process of redesigning the website and all of this will change I am closing this issue.


Fix jdk detection

Fixed JDK detection for case when java and javac are in different locations.
Added test for JDK detection
Fixed test for unique paths of java home locations (/usr/lib/jvm/default and /usr/lib/jvm/default-runtime/jre were considered identical)

Ah, excellent edge case! Thanks for documenting your code and adding tests. I'll merge in and update the NPM package.


How do i get my USB Bluetooth adapter to work? Ubuntu 12.04 LTS

I bought an USB bluetooth adapter and tried to plug it in, but Ubuntu 12.04 LTS does not start it up. Ubuntu recognize it but no more. My laptop is Acer C7 Chromebook.
If i write the command lsusb i got this message:
"Bus 002 Device 007: ID 0a12:0001 Cambridge Silicon Radio, Ltd Bluetooth Dongle (HCI mode)"

If i go the the system settings and then to Bluetooth it says with a locket grey text.
"No Bluetooth adapters found".
I have installed this:
"sudo apt-get install bluetooth blueman bluez-hcidump bluewho python-bluez bluez-tools"

If i then open "Bluetooth manager" i got this message:
"Bluez daemon is not running, blueman-manager cannot continue. This probably means that there were no Bluetooth adapters detected or Bluetooth daemon was not started"
I have heard that the solution is that i need to update the kernel to a newer one. Is it possible to update kernel 3.4.0 to 3.11.0 on Ubuntu 12.04 LTS without any troubles?

Anyone figure this out? I am experiencing similar problems.

sudo apt-get install pulseaudio-module-bluetooth
pactl load-module module-bluetooth-discover
Delete the device from bluetooth devices and pair it again.


ALT + L (Find in Selection) doesn't highlight the selection when CTRL + F (Search) is not shown.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.56.2
OS Version: Ubuntu 18.04 (same issue on Docker Ubuntu 16.04 using Remote Development Containers).

Version: 1.56.2
Commit: 054a9295330880ed74ceaedda236253b4f39a335
Date: 2021-05-12T16:45:26.313Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.4.0-73-generic snap

Steps to Reproduce:

Select a region using ALT + L then use CTRL + F2 to perform a quick replace.
No region is highlighted, however, we can see that the selection is working since only words within it are replaced.
The desired behaviour can be seen by repeating the steps with CTRL + F activated prior to them.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Remove checks in UR[M]BP.Iterator.next()

Swift tends to emit unnecessary checks and traps when iterating unsafe raw buffer pointers. These traps are confirming that the position pointer isn't nil, but this check is redundant with the bounds check that is already present. We can safely remove it.
Resolves #62964.

@swift-ci please smoke test

@Lukasa let's clone this for 5.8 once we're happy with it.

@stephentyrone Yup, will do.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please test

@swift-ci please benchmark

@swift-ci please test

@swift-ci please benchmark


JPEG example

Simple JPEG example. Also some fixes. WIP as it depends on #293 to build properly on Travis. Also the drawing to the screen is currently a memcpy.

Thank you!


Handle server errors related to blank API exclusion clauses

When we upgraded to 0.6, we started getting server errors from pages using wagtail-autocomplete.
The autocomplete forms were generating faulty API calls like these:
/admin/autocomplete/search/?query=mortgage&type=ask_cfpb.AnswerPage&exclude=,,
/admin/autocomplete/search/?query=&type=ask_cfpb.AnswerPage&exclude=

I found two problems:

There was a mix of variable names 'id' and 'pk' used for primary keys in React code.

line 62
line 94

The search view wasn't catching bad parameters because it was testing an unevaluated query. was swallowing exceptions caused by bad parameters.

These are addressed in PR #77.

This issue can be closed. Any chance of cutting a release?


Fix CRA template. MaterialUI v4.x.x works with React 16.8.x or 17.x.x

This PR fixes #338
Changelog:

Updates CRA template to rollback React to v17.x.x
Updates devDepencies to maintain compatibility

Thanks very much for your PR! Sorry, we overlooked it. Could you please remove changes to other dependencies and leave only react-related stuff?

Sure! PR now includes some devDependencies cleanup

Thank you very much for the PR @santteegt


Specifying multiple collectCoverageFrom paths

Do you want to request a feature or report a bug?
bug
What is the current behavior?
Calling:
jest --collectCoverageFrom foo/**/*.js bar/**/*.js

Does not assume both patterns as collectCoverageFrom. Though, this works:
jest --collectCoverageFrom foo/**/*.js --collectCoverageFrom bar/**/*.js
jest --collectCoverageFrom '["foo/**/*.js", "bar/**/*.js"]'

If the current behavior is a bug, please provide the steps to reproduce and
either a repl.it demo through https://repl.it/languages/jest or a minimal
repository on GitHub that we can yarn install and yarn test.
See above.
What is the expected behavior?
The expected behavior is that the first form should work. The current behavior is inconsistent with collectCoverageOnlyFrom and many other options. This is due to the collectCoverageFrom type being a string instead of an array, see https://github.com/facebook/jest/blob/8549900b8e98d5cf6c9983cdd34d4a089c9f2bed/packages/jest-cli/src/cli/args.js#L143.
Please provide your exact Jest configuration and mention your Jest, node,
yarn/npm version and operating system.
The jest configuration does not apply here.
Jest 22.0.0
Node: 8.9.3
npm: 5.6.0
OS: Mac

#5537