AIMResponse->getTransactionReference

Why is there a check to see if the transaction is successful in order to return the transaction reference object.
https://github.com/thephpleague/omnipay-authorizenet/blob/master/src/Message/AIMResponse.php#L120
Whether it's successful or not we should be able to still get that object since it provides valuable information. Right now it returns null which i can't even pull the response code, authcode etc when it fails. i have to to getData()->transactionResponse[0]->...
Thoughts?

Certainly looks like it can be improved. It should return everything it can return.
There are a number of different XML formats from Authorize.Net, depending on just where the error occurred (e.g. error codes and messages will be found in different places depending on whether there was an authentication or field error, or an authorisation error), so that needs to be taken into account.

@judgej i am willing to submit a PR to have this fixed. is this even being maintained?

Yes, it is maintained, and relies on fixes from the community.

@judgej Perfect. i'll submit a PR to remove that check to have the transaction reference available when the transaction fails as well.

Change merged - works okay on my test account. Thank you.

I'm struggling with the getTransactionReference for a different reason
The standard per the docs is for the transactionReference to be a reference code or string. When implementing multiple processors it's really important to have some consistency on key methods - otherwise the integration code has to know about the workings of every processor. So I would argue the correct thing to do would be to have a method like getTransactionReferenceObject that returns 'whatever it is that is A.net specific & can't fit a generic model', and for getTransactionReference to return the value that getTransId currently does

Successful Response

For a successful responses, a reference will normally be generated, which can be used to capture or refund the transaction at a later date. The following methods are always available:

$response = $gateway->purchase(array('amount' => '10.00', 'card' => $card))->send();

$response->isSuccessful(); // is the response successful?
$response->isRedirect(); // is the response a redirect?
$response->getTransactionReference(); // a reference generated by the payment gateway
$response->getTransactionId(); // the reference set by the originating website if available.
$response->getMessage(); // a message generated by the payment gateway

I realise that the change I'm proposing would break backwards-compatibility so I think it should be considered at the point of going to 3.0.
In the meantime I think I have to fork this gateway if I want to integrate it alongside others

Could you give some examples of the inconsistencies? The transactionReference should be returned as a string, just an arbitrary length string, with no shared patterns between the gateways, but a string that can be stored and reused.
Some gateways have multi-part transactionReference values, and OmniPay serializes those to bring them into line with the reference being a string. I can see how an object would help there, since parts of that reference can be useful in their own right, but being able to serialize/deserialize for storage can be handled by the class.

You are right, I do wind up with the object json'd to a string. But the string is not similar to the transaction references for any of the other processors. ie. I get
{"approvalCode":"Z0FTGK","transId":"60019251799","card":{"number":"1111","expiry":"022018"}}
Whereas for other processors I would see
$response->getTransactionReference()//<PHONE_NUMBER>9
I see
{"approvalCode":"Z0FTGK","transId":"60019251799","card":{"number":"1111","expiry":"022018"}}
At the moment we use the transactionReference on the receipts - and it is a part of a database key. The longer format isn't really appropriate for either of those uses.
I can see that the purpose of the longer format is to provide all the details that might be used to do a refund later.  Which is kind of vexing. The idea of Omnipay is to create a layer where the application developer does not need to know about the internals of every gateway. In the case of Authorize.net we already have the credit card pan & expiry as they are entered on our site, but that would not always be the case.
OK, I'm stuck now..... The assumption that works on other gateways that the transactionReference can be used for auditing purposes and presenting to the customer is inconsistent with the refund process here.
I've been working on creating some actions to retrieve the transactions from authorize.net to do a nightly audit. It's working well & I'll create a PR so you can see. But, I think I'm going to have to stay forked because I can work around the refund issue much more easily in my own code than I can the fact the transactionReference is not actually the gateway reference for the transaction

Hmm, if there was a consistent way to get the actual transactionReference I guess it could be a different function name & if there was evidence of json I could call that e.g
$transactionReference = $response->getTransactionReference();
if (substr($transactionReference, 0, 1) == '{') {
  $refundReference = $transactionReference;
  $transactionReference =  $response->getTransactionReferenceString();
}

I'll sleep on it. There is a part of my mind that won't accept the idea that the merchant's unique reference is not being treated like a unique identifier. Perhaps in the morning I'll be better able to think of a way to get the data that is important for auditing etc in a generic way

Oh last thought on this - the query() action in the PR I mentioned (#79 ) can actually retrieve the card_number & expiry_date from Authorize.net - although I might have left off the latter at this stage

@eileenmcnaughton We ran into a similar issue when implementing Omnipay into our system. We also need to implement multiple gateways at the same time which was the main draw to Omnipay. Our situation was actually made worse by the fact that we were moving from another solution to implementing Omnipay so we needed a way to be able to run refunds when the data was not stored in the serialized object as is done with the Authorize.net driver. Other issues that we ran into included the fact that different drivers require different methods/credentials for setting up the gateway and different data requirements to run things like a purchase or a refund. Our solution was to use polymorphism by creating an abstract class that acts basically the way that you expect a generic Omnipay driver to act and then create a concrete class for each gateway that makes any needed adjustments for that gateway driver. It's not the ideal situation that we were hoping for and you probably weren't either but it is a fairly elegant way to make sure that you are not duplicating code while keeping the solution fairly clean. In the case of the issue that you are running into, because of our need to be backwards compatible with old transactions, we actually don't store our references as the serialized object. We already store all the data from that object in separate fields so we recreate the object every time we need it. Again, it's not ideal but it works.

So, I guess the options are

maintain a fork
maintain a wrapper class
find something that would be acceptable in the Omnipay library - so far I can think of changing the refund class so that it can handle either a json or a transaction reference, and if the latter queries A.net for the extra details, or the rather unclean variant about

I guess the disadvantage of a fork is that it needs to incorporate changes from  upstream. On the bright side however, it's fairly easier just to point at my fork through composer and I tend to be happy to lose history on forks, making a rebase over master flow work well.
I guess a last option I hadn't thought of would be to create my own Authorize.net plugin which basically extends this one but overrides the specific method getTransactionReference and the Refund class. I guess that is not incompatible with the fork.

Unfortunately, because of the issues I stated above with the different drivers requiring different parameters in each transaction type, we didn't really see a better way then to create a wrapper class. If you try to do it by creating your own fork of the different drivers or creating your own driver that extends the existing one, there is a good chance you are going to end up having to do that for every driver so you can compensate for the differences and make them uniform.

hmm so far I haven't found others that are unresolvable, but you may be right. Do you just have something that basically has a handling for each non-standard driver?

(I guess I had hoped that with the v3 it would be possible to standardise things like this - I can see the issue with refund, but would also imaging that if all refunds actions supported setExpiryDate & setCardNumberTruncated then we could add a look up within refund to query these if not set

In release 2.5.0

Sorry, meant to leave this one open.

@eileenmcnaughton I went back and looked at our implementation again this morning and realized that I may have misled you a little on how we solved this issue. Basically what we do is we have our own version of an AbstractGateway class. This class CAN interact with the Omnipay driver in a standard way but it doesn't have to. In fact, depending on your system's requirements, you might be able to accomplish this with an interface instead of an abstract class. The methods needed in the interface/abstract class are something like getRefundData, getPurchaseData, etc. Those methods are very similar to the getData methods that you see in the drivers but it is getting the specific data needed for that driver in that method.
Then for each gateway driver that we are using, we create a concrete class or a class which implements the interface. The constructor of that class runs the Omipay::create method to instantiate the object and initializes it with whatever credentials that driver needs. Then since we are extending the abstract class (or implementing an interface) we define the getRefundData method and any other methods needed to take a standard set of data from our system and create the specific data set that is needed for that driver with that method. This is where we have the logic to recreate the TransactionReference Object for Auth.net but this only happens in the Auth.net's version of getRefundData. You may also need to create methods for extracting what you need from the TransactionReference object which is one reason why we are using an abstract class so we can have a method that just calls getTransactionReference in the abstract class but does more complex stuff in the Auth.net concrete class. Another reason for using an abstract class is because our system requirements actually necessitate that we take this a step further and actually run the purchase and refund methods in either the abstract or concrete class depending on the driver.
I am curious, what was your solution for creating your Omnipay objects with different drivers needing different credentials? Also, how did you resolve the issue that one driver requires different fields then another for a specific method like a purchase or refund?

Is your code in a public space? I think I am following you but it would be good to see it.
Regarding credentials. Our database implements other non-Omnipay gateways and has a row for each type it supports. It has  fields like the password_label, user_label, subject_label. These were intended for UI display but I make sure they are a camel case of the credential fields.
"how did you resolve the issue that one driver requires different fields then another for a specific method like a purchase or refund"
Mostly I have integrated gateways that are pretty good so far, I've done a few PRs to address things, but Authorize.net is more challenging on that front than many, so I haven't fully worked through it.

Sorry that I didn't respond to this sooner. Unfortunately, we have some stuff in that code that makes it so we can't put it in the public space. I did, however, create a new repo in my account that has the stripped down version that I think will illustrate what I am talking about. The repo is at https://github.com/caswell-wc/omnipay-multi-gateway-demo. I tried to explain what I could in the comments of the code. Hopefully it makes a little more sense to you with that.

Hey - that's for that! you rock!

Closing as fixed.


Upgrade to Ember CLI 2.12.1

Also upgraded ember-cli-node-assets and pikaday to latest versions.

Thank you :)


No notifications on Android 13 on Pixel 6 Pro and Pixel Watch

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App version
6.602
Where did you get the app from?
Google Play
Android version
13
Device model
Pixel 6 Pro
Steps to reproduce

Turn on alerts
Receive new email by IMAP idle

Expected behavior
The phone should provide an audible alert and vibration in accordance with the K-9 alert settings.  Other apps on my phone function as configured, sending audible alert or vibration or both to the phone and/or watch.
Actual behavior
The phone receives the new mail silently, with no audible alert and no vibration. It does show briefly on the lock screen and does display the new email icon in the status bar.  The watch displays an unread alert dot, but also does not provide an audible alert and does not vibrate.
Logs
I have changed the username to "user" and the actual domain to "domain".
k9mail-logs.txt

Update: I just discovered a setting "Don't ring/vibrate notifications on your phone while wearing watch" and disabled it.  K-9 now delivers notifications correctly on the phone, though still not on the watch. It's still a bug because all of the other apps on my phone that are allowed to send notifications do so correctly to the phone or the watch.

According to the log the app creates the notification just fine. Make sure the notification category is properly configured (you can get to the system configuration screen from the app via *Settings → [Account] → Notifications → Messages).
Setting vibration/sound on the notification directly has been deprecated (all notifications now have to belong to a category and the category defines the vibration/sound settings). If the software sending the information to the watch requires this information to also be set on the notification itself, I'd consider this a bug in the watch software, not K-9 Mail.

Thanks for your fast reply! Your answer makes sense. The software sending the notification to the watch is written by Google, so you would think they would follow standards, but apparently not.


HttpGraphQlTester not available in Spring Boot Mock environment

While a HttpGraphQlTester is available for auto wiring in the full end to end spring boot test, it fails in a Mock environment.
The underlying WebTestClient is made available in both, so I would have expected that HttpGraphQlTester is also available. Instead I needed to create the HttpGraphQlTester manually:
        WebTestClient graphQlWebTestClient = webTestClient
                .mutateWith((builder, httpHandlerBuilder, connector) ->
                        builder.baseUrl("/graphql"));
        HttpGraphQlTester graphQlTester = HttpGraphQlTester.create(graphQlWebTestClient);

Could you clarify "Mock environment", i.e. what was the test setup more specifically?

I mean the environment for the spring boot test:
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.MOCK)

vs
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)

for a full service.

After digging a bit more let me rephrase it:
When running an end to end SpringBootTest (e.g. SpringBootTest.WebEnvironment.RANDOM_PORT) HttpGraphQlTester is automatically availabe.
But when running with SpringBootTest.WebEnvironment.RANDOM_PORT I either need to create the HttpGraphQlTester myself or use @AutoConfigureHttpGraphQlTester.
This seems inconsistent and I am wondering why this is.

This is the expected behavior.
We're consistent here with the other test integrations. The auto-configured GraphQlTester instances build on top of the WebTestClient variants already configured, as shown int he previous link.
With Spring for GraphQL, we're getting the following (see reference docs):

Annotations on Test class
Server
Web Test Beans configured

@GraphQlTest
None

@SpringBootTest
Mock

@SpringBootTest @AutoConfigureGraphQlTester
Mock
ExecutionGraphQlServiceTester

@SpringBootTest @AutoConfigureHttpGraphQlTester
Mock
HttpGraphQlTester

@SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT)
Live
HttpGraphQlTester

On top of that, HttpGraphQlTester extends GraphQlTester - so if we were to try and auto-configure everything, we could end up in a situation where developers ask for an @Autowired GraphQlTester and would get several candidates (the execution one, the HTTP one).

Indeed with just @SpringBootTest it's unclear what transport you want to test with. It could be HTTP, WebSocket, RSocket, and while in some cases it may be possible to rule some out, that's not always possible.


Add ability to change production templates empire-wide

TL;DR it's be nice to have a big button in the production report screen that would apply the listed template to all planets (omitting inapplicable build orders where applicable), replacing any existent auto build orders at the same time.

There was another request to automatically upgrade production plans on all planets that used them. Is that what you mean?

More or less.
I was thinking of just having a big red "apply all" button, but that probably makes more sense come to think about it.


[Add Project] Deferred

Pull Request Description
This PR adds Deferred, a small futures library, to the Swift compatibility suite. The specified commit builds and passes under 4.0.3 (in 3.2 and 4.0 modes) and the 4.1 beta 2 compilers.
The codebase has not had a pattern of source compatibility problems, except in early betas of major releases. Inclusion of the library might help identify those earlier in development. The code is not notably tricky in its use of Swift features, but includes uses of: C header annotations, typealiases in protocol extensions used for overloading, tuples in generics, the Dispatch overlay, and the modern pointer APIs.
Acceptance Criteria
To be accepted into the Swift source compatibility test suite, a project must:

[x] be an Xcode or swift package manager project
[x] support building on either Linux or macOS
[x] target Linux, macOS, or iOS/tvOS/watchOS device
[x] be contained in a publicly accessible git repository
[x] maintain a project branch that builds against Swift 3.0 compatibility mode
and passes any unit tests
[x] have maintainers who will commit to resolve issues in a timely manner
[x] be compatible with the latest GM/Beta versions of Xcode and swiftpm
[x] add value not already included in the suite
[x] be licensed with one of the following permissive licenses:

BSD
MIT (✅)
Apache License, version 2.0
Eclipse Public License
Mozilla Public License (MPL) 1.1
MPL 2.0
CDDL

[x] pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

@swift-ci please test

Thanks!


Suppression doesn't seem to be working for the GM

Currently running build 305 for Foundry v11 on Forge and module is installed.  Still getting flooded with compatibility warnings for several virtual dice sets that have not been tested for V11.  Not sure if there was a change in V11 or if I'm missing the intent of the module but it's not really helping.

To be more specific, the errors are for 'unmaintained modules' and not really compatibility - not sure if that was swept with this module.


Incompatible with go-ethereum v1.9.14

The latest release of go-ethereum included a refactor which moved abi.U256 from "github.com/ethereum/go-ethereum/accounts/abi" to math.U256Bytes in github.com/ethereum/go-ethereum/common/math. This will allow projects that make use of this package to bump to the latest go-ethereum version.
For context, here is the PR which made the breaking change: https://github.com/ethereum/go-ethereum/pull/21020.

I've opened a PR(https://github.com/miguelmota/go-solidity-sha3/pull/11) to fix this in case it's wanted/useful

Closed by https://github.com/miguelmota/go-solidity-sha3/pull/11


How to disable leading 0 on datepicker popup?

How to disable leading 0 on the datepicker popup?

If you look at the documentation you'll see that there is a formatDay option. If not specified, the default value of "DD" will be used. To remove the leading 0 just add it to your component like formatDay="D".

@adrianfaciu thanks!

[formatDay]="d"
Still shows up "dd" instead.
This option seems to be ingored.
Other options are working fine

formatDay="d" is different than formatDay="D". Have a look here.


SubprocessImpl to remove shutdown hooks on kill

Unless the shutdown hook is removed it will remain there forever, causing a memory leak.

Rebased, tweaked to be Java 7 source compatible (not that it really matters…), and committed in de81f5a0cf6350e7036bc98712a237287d85a4ec


WIP - support poetry with url

Use the package level version since poetry file entry does not include version
When PackageFile urls exist, use the first url without checking LinkEvaluator since it may not use the same pattern

it does not support pdm with url
it currently fails with "build._exceptions.BuildBackendException: Backend 'setuptools.build_meta:legacy' is not available."

Thanks @chulkilee. Looks like all of the tests are failing with this change in its current state.


Ability to create a shared dotfile of custom commands for collaboration

Is your feature request related to a problem? Please describe.
Currently, the tool is opinionated about the commands that developers want to execute. As a developer, I would like to maintain a library of commands that I can easily execute from the extension. Also, the default commands should be configurable. For example, I prefer to include the "-o wide" parameter when using the kubectl get commands.
Mention what platform you want to support the new feature
VSCode
Describe the solution you'd like
A dotfile, preferably named .aks that I can commit to the code repo with a dictionary of custom commands and options to modify the behavior of existing ones.
Describe alternatives you've considered
This is a common method used by many tools to customize their behavior and hence I did not consider other alternatives.
Additional context
An advantage of using dotfiles is that they can be easily distributed to the wider community through popular repositories: https://github.com/webpro/awesome-dotfiles

Tagging @nellysattari for additional recommendations.

Hiya, I am moving this to the discussion forum now, given this is now U/X'd well with new design (#226 ), which is well improved, lets get the feelers for how many use-cases will need specific online file support.
#226 - was the drop of the pull request which did re-design for the this kubectl commands for helpful developer experience.
Thank you so much.


flutter: error Connection failed - Mac OS only   Version  supabase_flutter: ^1.0.0-dev.4

Will build and run on all devices (Windows Desktop, Web, iOS phone and Android) BUT WILL not work on MacOS
Error flutter: error Connection failed

Yes got to work - sorry


Added Orca Mini prompt strategy

I successfully finetuned orca mini with these setting, as you mentioned you are interested in contributions for prompt_strategies i figured i could also open a PR for that, because the prompt template is different from the recently merged Open Orca format.
Will also try to work on Vicuna which is much more complicated due to masking/tokenizing...

@jphme could you run pre-commit run --all-files to catch any pre-commit lint issues pls? thanks!

pre-commit run --all-files

did so, sorry (originally implemented the prompt stratgies only for myself and didn't plan to PR them; so didn't install dev recs)!

Thank you! Sorry for the late merge.


⚠ Website has degraded performance

In d03af33, Website (https://rheinklang.events) experienced degraded performance:

HTTP code: 200
Response time: 5175 ms

Resolved: Website performance has improved in a71619c after 12 minutes.


MINOR: Rename uniform assignor's internal builders

This patch renames the uniform assignor's builders to match the SubscriptionType which is used to determine which one is called. It removes the abstract class AbstractUniformAssignmentBuilder which is not necessary anymore. It also applies minor refactoring.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks, @rreddy-22. I addressed your comments.

I have re-trigger QA

@dajac Could you please rebase code to include #16249?

Merged to trunk and to 3.8.


use bucketName instead of bucketName and bucketInstanceName

The previous design had the two values be different, now that the backend bucket name and the name of the bucket object are the same, it doesn't make sense to have two different field names for the same value. @bswartz

/lgtm

/hold

/lgtm


The keyboard opens in the browser Safari (IOS 8) when pressing in any place on the page

Step to reproduce:

Open page with input when you use ng-pattern-restrict on your iPhone
Tap in any place on the page
Keyboard opens and form filed becomes focused
When you refresh the page, you can reproduce this bug again

The problem in function detectSetCaretPositionMethods().  When I have commented this function everything works fine.

Fixed on cae78314fe1d6529166a472c46bf101153e6a42c.


API bug: when creating trees without top-level answers provided, top-level honest workspace not stale

Of course, the next workspace that needs work should always be stale.
Worth testing this for all possible sets of info provided via API -- just top-level Q, also honest top-level answer, also malicious top-level answer

Getting started here. @brachbach does the 3 cases you mentioned:

[ ] just top-level Q
[ ] honest top-level answer
[ ] malicious top-level answer

encapsulate all possible sets?

yep!
TBC, the possibilities are actually:

top level Q
top level Q + honest top-level A
top level Q + honest top-level A + malicious top-level A

Still learning the stale system. It looks like workspaces and their honest/malicious children each can be stale or not. Call them W, HC, and MC, respectively. I'm assuming W corresponds to Q, HC to honest, and MC to malicious.
I've found the place in the codebase where staleness is determined (bulkCreateExperiments in server/lib/schema/index.ts).
I'm trying to figure out who (W, HC, MC) should be stale, under what circumstances. It seems that the behavior that you want is when a workspace is created without an honest answer, the HC should be stale. So is it something like:
top level Q -> W is stale, HC & MC not-stale
top level Q + honest top-level A -> MC stale, W & HC not-stale
top level Q + honest top-level A + malicious top-level A -> W & MC & HC not-stale.
But what about:
top level Q + malicious top-level A? I guess HC stale, W & MC not-stale
Is this accurate?

I think the simplest way to do it would be to make the leaf workspace stale and the ancestors not stale. So if there's no honest answer, then honest workspace stale. If there's an honest answer, then malicious workspace stale. If there are both answers, then the judge workspace stale. In all cases, the other workspaces not stale.

Current behavior on master, created using a new CSV that runs every configuration:
Top-level Q only ❌
-> Workspace 50 should be stale

Top-level Q + honest answer❌
-> Workspace 53 should be stale

Top-level Q + honest answer + malicious answer ✅
-> Workspace 57 is correctly stale

What's going on with the text: undefined? Is that something we should be worried about? Could I see the CSV file?

@zjmiller Yeah that does look like strange behavior from the scratchpad. I looked into it and it comes from the mosaic-api-scripts line here https://github.com/oughtinc/mosaic-api-scripts/blob/master/createExperiments/getExperimentData.ts#L12


A couple of trivial spelling corrections

On the homepage the words Nanded and Pune should be started with uppercase letters. Thanks.

Hey @JMCrawf , can I work on this issue for Hacktobrfest 2021?


HIVE-24109 : Load partitions in parallel for managed tables in the bo…

…otstrap phase

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Can you please rebase the patch.


Fitting only works the first time

🐛 Bug
Reusing a Trainer on different model instances only fits the first model.
I'm unsure exactly what state a Trainer object keeps. It feels like an immutable class that shouldn't behave differently depending on whether I already used it to fit something else.
To Reproduce
https://colab.research.google.com/drive/1Md3lyREm0biHaq9hn5uh4I9EmpE2DZM_?usp=sharing
I just added this:
model = BoringModel()
trainer.fit(model, train_dataloaders=train_data, val_dataloaders=val_data)
trainer.test(model, dataloaders=test_data)
model2 = BoringModel()
trainer.fit(model2, train_dataloaders=train_data, val_dataloaders=val_data)
trainer.test(model2, dataloaders=test_data)

Expected behavior
I would expect both model to train and report about the same error.
Instead it only fits the first model, so the second one goes completely untrained.
I couldn't find any documentation of this behaviour, so I consider it a bug.
Even if it is intended, it opens questions such as "what happens if I test the same model twice?"
Environment

CUDA:

GPU:

Tesla T4

available:         True
version:           11.1

Packages:

numpy:             1.21.5
pyTorch_debug:     False
pyTorch_version:   1.10.0+cu111
pytorch-lightning: 1.6.1
tqdm:              4.64.0

System:

OS:                Linux
architecture:

64bit

processor:         x86_64
python:            3.7.13
version:           #1 SMP Tue Dec 7 09:58:10 PST 2021

Just a thought. Is there anything like trainer end/reset or just create a new trainer will solve this?

Creating a new trainer fixes this.

It's not even clear to me if I need to keep all the trainers around for testing? Or if I just need to use different trainers for each fit, but then can reuse the last one for all the testing?

It feels like an immutable class that shouldn't behave differently depending on whether I already used it to fit something else.

This is far from the case. The trainer is VERY stateful.
You should only reuse the same instance if the same model is passed and you want to continue the previous run or checkpoint.
For example, you to re-run for 2 extra epochs, you need to modify the state
model = ....
trainer = Trainer(max_epochs=2)
trainer.fit(model)
# if you don't do this, the next fit call will not run
# any training because the 2 max epochs have already happened
trainer.fit_loop.max_epochs = 4
trainer.fit(model)

@carmocca What about running trainer.test, should I also make a new trainer every time I do that? Should it be the same trainer as was used to fit the model?
Sorry for all the questions. If you can refer me to a place with information about this, I'll happily read it.

should I also make a new trainer every time I do that?

You don't need to, as the concept of max_epochs only applies to fit.

Should it be the same trainer as was used to fit the model?

Only if you want trainer.test(ckpt_path="best") to work, otherwise it's not necessary.
Closing, feel free to ask any further questions


Test removing 2005 route table

This PR reverts 3ed62d51d5ac27bbe2c60372850d4ec78c17bb6e to see if we can reproduce #23258

/test

/test

Close as completed by other PRs


Update dip-201.md

@sasha8 can you submit a PR add the link - and perhaps remove the old paper?

@aching Looks like I do not have write access to diem/dip.
(Here is the link: https://developers.diem.com/papers/diem-consensus-state-machine-replication-in-the-diem-blockchain/2021-08-17.pdf)

I'll update the link


build: update pr-agent configuration

Type
enhancement

Description

Added a new GitHub Actions workflow named PR Agent to automate pull request handling.
The workflow triggers on various pull request and issue comment events, enhancing the project's automation capabilities.
Configured to use Codium-ai/pr-agent@main, it includes settings for automatic review, description, and improvement of PRs.

Changes walkthrough
Relevant filesEnhancement

pr_agent.ymlIntroduce PR Agent Workflow for Automated PR Handling

.github/workflows/pr_agent.yml
Introduced a new workflow for PR Agent with triggers on pull request events and issue comment events.  Configured PR Agent job to run on ubuntu-latest with necessary permissions for issues, pull-requests, and contents.  Utilized Codium-ai/pr-agent@main with environment variables for OPENAI_KEY, GITHUB_TOKEN, and various github_action_config settings.

+35/-0

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

/describe


Add back the DisplayName setting

#391 @PinpointTownes @DamianEdwards

@Tratcher thanks!
Did you consider directly exposing AuthenticationSchemeBuilder so you could also change the scheme name?
Something like:
public AuthenticationSchemeBuilder Scheme { get; } = new AuthenticationSchemeBuilder
{
    HandlerType = typeof(AuthenticationHandler),
    Name = IISDefaults.AuthenticationScheme
};

services.Configure<IISOptions>(options =>
{
    options.Scheme.DisplayName = "Intranet";
});

That seems more dangerous, I don't think we want to allow people to change the HandlerType at all

That's interesting, bug I agree exposing the handler would be problematic.

I don't think making the scheme name configurable is that critical, but if we want to expose that as well, its harmless and matches what Security auth does

Well, if that's your only concern, you still can add a check to ensure the type wasn't changed before calling Buid():
if (!typeof(AuthenticationHandler).IsAssignableFrom(_options.Scheme.HandlerType))
{
    throw new InvalidOperationException("You're doing something wrong, bro'.");
}

That just seems like a more error prone alternative to exposing only AuthenticationScheme / DisplayName

The structure would be nice..

Sure. But that was a clever way to save one property while adopting the same pattern as the one you've used for CookieBuilder... :trollface:

Yeah but unlike CookieBuilder, the Handler IS the main thing, so throwing when you set that defeats the whole purpose of exposing that.

I would go minimal, we can always add the builder later if things get more complicated.


throw Error when using onChange in ReactNative

Are you submitting a bug report or a feature request?
bug report
What is the current behavior?

When using onChange like this:
const CustomComponent = (props) => {
  const value = props.input.value;
   return (
      <Text>{value}</Text>
      <Button onPress={() => props.input.onChange(value + 1)} />
   );
};

<Field
  name='field1'
  component{CustomComponent}
  onChange={() => {}}
/>

It will show error in react-native:

Although it works fine in web.
What is the expected behavior?
It should work fine in both react-native and web.
What's your environment?

redux-form: v6.8.0.
react-native: v0.42.3.

Other information
From what i see in redux-form source code, the handleChange function in ConnectedField.js is trying to merge the event to the object.
if (onChange) {
        onChange(
          {
            ...event,
            preventDefault: () => {
              defaultPrevented = true
              return event.preventDefault()
            }
          },
          newValue,
          previousValue
        )
      }

but if the event param is a primitive value, then it can not be merged on react-native and will throw the error.

I'm also seeing a similar error using onBlur:

Which ultimately is because in this case, the event parameter is a proxy, and React Native's polyfills don't allow that.

Published fix in v7.1.0.

I got the same error when using redux: 3.7.2 and redux-form 7.3.0

@Vishal1419 please open a new issue with a sandbox that reproduces it.


Possible fogger to request to send code to this phone as it was in fast lane

https://github.com/fb929/pyappstoreconnect/blob/a11fc948285afbf397880f478e304446ba150dba/pyappstoreconnect/client.py#L229
This code should be there, otherwise no code has sent
payload = {
            "phoneNumber": {
                "id": phoneId,
            },
            "mode": pushMode,
        }
        headers = self.appleSessionHeaders()
        r = self.session.put(f"https://idmsa.apple.com/appleauth/auth/verify/{codeType}", json=payload,
                              headers=headers)
        self.logger.debug(f"{defName}: response.status_code={r.status_code}")
        self.logger.debug(f"{defName}: response.json()={json.dumps(r.json())}")
        if r.status_code != 200:
            return False

but it's works, the code is sent on this step:
https://github.com/fb929/pyappstoreconnect/blob/a11fc948285afbf397880f478e304446ba150dba/pyappstoreconnect/client.py#L181


Add ItemRequires Constraint

Implemented Item requires constraint as part of #2354

@wetneb: Can you help me understand why the Travis checks are failing? :(

@darecoder1999 sorry about this, we have had a few issues with Travis lately - it's definitely not related to your PR. We are working on fixing this.

#2894 is my attempt at improving the build settings. If your CI build succeeds on at least one of the platforms, it's probably safe to assume that it's Travis' fault, not yours. You can restart the build jobs individually if you want to get everything green, but I wouldn't worry too much about it.


Unsuccessful ELT run produced LOG with no useful information with target-csv

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1224
Originally created by @dmor on 2019-10-30 19:10:21

This is is a bug I am generating from dogfooding the Meltano UI

What is the current bug behavior?
I set up:

Extractor: Carbon Intensity
Target: CSV
Transforms: Run
Interval: @once

When I saved the pipeline, the log image above appeared, but never populated. It looks like the ELT run was unsuccessful, but I have no idea why, what I did wrong, or how to proceed.
What is the expected correct behavior?
The logs should have a final message expressing whether or not the ELT was successful
If not successful, I should receive an error message telling me what is going on
Steps to reproduce

Meltano version: 1.3.0
Extractor: Carbon Intensity
Target: CSV
Transforms: Run
Interval: @once

Command Line Output
[http://localhost:5000/api/v1/orchestrations/run] as <meltano.api.security.identity.FreeUser object at 0x115a3e908>
INFO:meltano.api.app:[http://localhost:5000/api/v1/orchestrations/run] as <meltano.api.security.identity.FreeUser object at 0x115a3e908>
[http://localhost:5000/api/v1/orchestrations/job/state] as <meltano.api.security.identity.FreeUser object at 0x1151d4ba8>
INFO:meltano.api.app:[http://localhost:5000/api/v1/orchestrations/job/state] as <meltano.api.security.identity.FreeUser object at 0x1151d4ba8>
[  Thread-3][WARNING][2019-10-30 13:08:55,208] Could not generate dbt docs: 'target-postgres' is missing.
[  Thread-3][INFO][2019-10-30 13:08:55,208] Awaiting task
[2019-10-30 13:09:05 -0600] [44196] [INFO] Handling signal: ttin
[2019-10-30 13:09:05 -0600] [44754] [INFO] Booting worker with pid: 44754
/Users/daniellemorrill/virtualevns/meltano/lib/python3.7/site-packages/psycopg2/__init__.py:144: UserWarning: The psycopg2 wheel package will be renamed from release 2.8; in order to keep installing from binary please use "pip install psycopg2-binary" instead. For details see: <http://initd.org/psycopg/docs/install.html#binary-install-from-pypi>.
  """)
[2019-10-30 13:09:06 -0600] [44196] [INFO] Handling signal: ttou
[2019-10-30 13:09:06 -0600] [44725] [INFO] Worker exiting (pid: 44725)

View 3 previous comments from the original issue on GitLab


Add custom lmdb files

Thank you for the awesome work. Can you please tell me how to add custom lmdb folders for training and validation?
Thanks

Crate a make_lmdb_data.py using following code:

""" clone from deep-text-recognition-benchmark repositpry https://github.com/clovaai/deep-text-recognition-benchmark/blob/master/create_lmdb_dataset.py, a modified version of CRNN torch repository https://github.com/bgshih/crnn/blob/master/tool/create_dataset.py """

import fire
import os
import lmdb
import cv2

import numpy as np

def checkImageIsValid(imageBin):
    if imageBin is None:
        return False
    imageBuf = np.frombuffer(imageBin, dtype=np.uint8)
    img = cv2.imdecode(imageBuf, cv2.IMREAD_GRAYSCALE)
    imgH, imgW = img.shape[0], img.shape[1]
    if imgH * imgW == 0:
        return False
    return True

def writeCache(env, cache):
    with env.begin(write=True) as txn:
        for k, v in cache.items():
            txn.put(k, v)

def createDataset(inputPath, gtFile, outputPath, checkValid=True):
    """
    Create LMDB dataset for training and evaluation.
    ARGS:
        inputPath  : input folder path where starts imagePath
        outputPath : LMDB output path
        gtFile     : list of image path and label
        checkValid : if true, check the validity of every image
    """
    os.makedirs(outputPath, exist_ok=True)
    env = lmdb.open(outputPath, map_size=1099511627)
    cache = {}
    cnt = 1

    with open(gtFile, 'r', encoding='utf-8') as data:
        datalist = data.readlines()

    nSamples = len(datalist)
    for i in range(nSamples):
        imagePath, label = datalist[i].strip('\n').split('\t')
        imagePath = os.path.join(inputPath, imagePath)

        # # only use alphanumeric data
        # if re.search('[^a-zA-Z0-9]', label):
        #     continue

        if not os.path.exists(imagePath):
            print('%s does not exist' % imagePath)
            continue
        with open(imagePath, 'rb') as f:
            imageBin = f.read()
        if checkValid:
            try:
                if not checkImageIsValid(imageBin):
                    print('%s is not a valid image' % imagePath)
                    continue
            except:
                print('error occured', i)
                with open(outputPath + '/error_image_log.txt', 'a') as log:
                    log.write('%s-th image data occured error\n' % str(i))
                continue

        imageKey = 'image-%09d'.encode() % cnt
        labelKey = 'label-%09d'.encode() % cnt
        cache[imageKey] = imageBin
        cache[labelKey] = label.encode()

        if cnt % 1000 == 0:
            writeCache(env, cache)
            cache = {}
            print('Written %d / %d' % (cnt, nSamples))
        cnt += 1
    nSamples = cnt-1
    cache['num-samples'.encode()] = str(nSamples).encode()
    writeCache(env, cache)
    print('Created dataset with %d samples' % nSamples)

if __name__ == '__main__':
    fire.Fire(createDataset)

Run the scrip as follows

python make_lmdb_data.py --inputPath image_path --gtFile txt_file.txt --outputPath save_path

Thank you. Just one last thing, I can just replace the lmdb file path in cfg with my custom , train, test and validation files, right?
Thanks again

Yes.

Hey!
I've added an extra lmdb file and made the necessary changes in 'concat-dict'. However, the balance sampler gives me an error (related to oversample), and I didn't quite figure a way around it.
I set the oversample (bool) variable to False, and it seems to train fine with the new added data.
How does setting oversample to False affect the new dataset?
I'm not familiar with balance samplers.
Thank you.

Hey!
I've added an extra lmdb file and made the necessary changes in 'concat-dict'. However, the balance sampler gives me an error (related to oversample), and I didn't quite figure a way around it.
I set the oversample (bool) variable to False, and it seems to train fine with the new added data.
How does setting oversample to False affect the new dataset?
I'm not familiar with balance samplers.
Thank you.

Can you show me the erro infos?
If you set oversample to True, the dataset with less length will be oversampled to ensure balance in each batch.  If you set it as False, it will do nothing which means the batch may not always be balanced.

2021-04-14 05:34:37,562 - INFO - Use GPU 0
2021-04-14 05:34:37,562 - INFO - Set cudnn deterministic False
2021-04-14 05:34:37,562 - INFO - Set cudnn benchmark True
2021-04-14 05:34:37,562 - INFO - Set seed 1111
2021-04-14 05:34:37,564 - INFO - Build model
2021-04-14 05:34:38,059 - INFO - GResNet init weights
2021-04-14 05:34:38,509 - INFO - AttHead init weights
2021-04-14 05:34:51,723 - INFO - current dataset length is 3096 in /content/gdrive/MyDrive/mlt_hin_drive/training/train_hin/Real/realhin_train
2021-04-14 05:34:53,947 - INFO - current dataset length is 8000 in /content/gdrive/MyDrive/mlt_hin_drive/training/train_hin/Syn/hindi_train
2021-04-14 05:34:55,349 - INFO - current dataset length is 3656 in /content/gdrive/MyDrive/mlt_hin_drive/training/train_hin/MLT
2021-04-14 05:34:55,349 - INFO - The truly used batch ratios are [0.5 0.5]
Traceback (most recent call last):
File "tools/train.py", line 42, in
main()
File "tools/train.py", line 37, in main
runner = TrainRunner(train_cfg, deploy_cfg, common_cfg)
File "tools/../vedastr/runners/train_runner.py", line 19, in init
train_cfg['data']['train'])
File "tools/../vedastr/runners/base.py", line 85, in _build_dataloader
sampler = build_sampler(cfg['sampler'], dict(dataset=dataset)) if cfg.get('sampler', False) else None
File "tools/../vedastr/dataloaders/samplers/builder.py", line 6, in build_sampler
sampler = build_from_cfg(cfg, SAMPLER, default_args)
File "tools/../vedastr/utils/common.py", line 14, in build_from_cfg
return obj_from_dict_registry(cfg, parent, default_args)
File "tools/../vedastr/utils/common.py", line 79, in obj_from_dict_registry
return obj_cls(**args)
File "tools/../vedastr/dataloaders/samplers/balance_sampler.py", line 62, in init
self._generate_indices()
File "tools/../vedastr/dataloaders/samplers/balance_sampler.py", line 100, in generate_indices
indices = self.oversample(indices, need_len)
File "tools/../vedastr/dataloaders/samplers/balance_sampler.py", line 125, in _oversample
need_num = need_len[idx] - current_nums
IndexError: list index out of range

Here is the error info.
Thank you!

Here is the error info.
Thank you!

It looks you use three datasets for training, so you should change the batch_ratio in config. For example, batch_ratios = [0.3, 0.3, 0.4].
I will add a assert to make the erro information clearly.

Thank you very much again :)

Thank you very much again :)

You're welcome.


Store data for the API in an opaque field in the format in which it is served.

Currently, when we store data in Elasticsearch, we index all the fields in situ.  This brings some challenges:

Deeply nested objects get flattened
The API code is more complex than it needs to be
The Elasticsearch Mappings have to be updated with any changes
The Internal Model and Elasticsearch Mappings for all stages are common to all stages in the pipeline, and also the API, regardless of what that stage needs to know.

One Elasticsearch pattern I have used in the past has been to store the entire document, in the form it is presented in the API, as an opaque block of JSON (an object field with enabled=false), and copy values into separate fields for indexing.
This is not dissimilar to the Elasticsearch copyTo parameter, but handled by the application outside of Elasticsearch instead, in creating the document to insert.
Storing the data in an opaque field, and matching that shape to the shape the API serves will:

Simplify the API code - it simply needs to extract the opaque field and pass it on, possibly filtering unwanted fields.
Help to break up some of the reliance on the Internal Model and its need to represent all information for all stages.

See also: https://github.com/wellcomecollection/platform/issues/5448

Doing this (for the whole pipeline) would mean that we could only index those fields that are relevant for the corresponding stage.
This could bring with it a performance benefit

It’s done. 🎉
The works and images API are both rendering their responses by reading a document from the display field in Elasticsearch.


Slack and Skype stopped working since update to V3

Since my update to the new version, both the Slack and Skype channels stopped working.
On Skype, the messages I send seemingly don't reach my bot and I'm getting Unauthorized. I'm using HTTPS, it works on other channels. On the My Bot page the status is Error (Unauthorized).
On Slack, the messages reach my controller but my responses don't reach Slack. On the My Bot page the status is Error (Sorry, [Bot Name] is having a problem responding right now).
Other channels work fine. (Tried Facebook, Telegram, Kik, GroupMe.)

http://docs.botframework.com/en-us/support/upgrade-code-to-v3/#navtitle , I guess you haven't done this.

@AmineI I have actually. Had to change many lines due to the changes to messages and bot state handling. Also updated Web.config (MicrosoftAppID, MicrosoftAppPassword) and updated my registration to use V3. As mentioned, it works on other channels, and also in the new Channel Emulator.

Oh, okay then ! Which language are you working with ?

C#.

I am also having trouble with Slack, Skype seems to work fine though. I am working with C#.
I created a new project using the new V3 bot application template, deploy it to an azure API app. All the bot connector stuff is already configured. When attach a remote debugger to my deployed app, I get a Microsoft.Rest.RestException with the message "Unable to deserialize the response."

The inner exception is {"Unexpected character encountered while parsing value: <. Path '', line 0, position 0."}

The web chat also seems to work too.

thegram what is your bot id?

I'm seeing the same exception when trying to reply to a message on the slack channel only.

"Microsoft.Rest.RestException: Unable to deserialize the response. ---> Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0. at Newtonsoft.Json.JsonTextReader.ParseValue()
...
at Microsoft.Bot.Connector.Conversations.d__7.MoveNext()

@tomlm bot handle: platform_service, Microsoft App ID: 12fadc94-5c73-42e4-b2f6-01ea53fc62f5.
Checked again, it seems like on Slack I get the same exception as the others (on sending the reply from my dialog). On Skype the message doesn't even reach my controller (or at least the Post method).

My guess according to the source code is that the connector's response to the following request is ill-formatted (for Slack): POST v3/conversations/{conversationId}/activities/{activityId}
The exception is from Microsoft.Bot.Connector.Conversations.ReplyToActivityWithHttpMessagesAsync. Here's the stacktrace:
Microsoft.Rest.RestException: Unable to deserialize the response. --->
Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.
at Newtonsoft.Json.JsonTextReader.ParseValue()
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.ReadForType(JsonReader reader, JsonContract contract, Boolean hasConverter)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
at Microsoft.Rest.Serialization.SafeJsonConvert.DeserializeObject[T](String json, JsonSerializerSettings settings)
at Microsoft.Bot.Connector.Conversations.<ReplyToActivityWithHttpMessagesAsync>d__7.MoveNext()
--- End of inner exception stack trace ---

It looks like the Activity sent from skype has a < character at the beginning.
Could you post the JSON being sent to the bot from Slack and compare it to the request sent from Skype?

I just meant to add I am having the same problems (Slack & Skype) as @Thegaram, but with the Node version.
In the bot framework dashboard, Slack's status is "error" and the message given is:

Sorry, test_bot is forbidden for us to talk to.

I am not really sure what it means though, and I am not sure how to debug this.

@ChuckkNorris You mean the Activity from Slack has a < character? I don't think so, as the exception occures during reply, not during the first deserialization. The stacktrace above suggests that, when posting the reply message, the answer from https://slack.botframework.com/ begins with that character.
Nevertheless, here's the Activity from Slack:
{
  "type": "message",
  "id": "5bfc91b30c6a4b6eb50f5c503af62cc2",
  "timestamp": "2016-07-11T17:26:35.0869918Z",
  "serviceUrl": "https://slack.botframework.com/",
  "channelId": "slack",
  "from": {
    "id": "U1KSC3SEM:T1KS69V8F",
    "name": "admin"
  },
  "conversation": {
    "isGroup": false,
    "id": "B1KSCS94Z:T1KS69V8F:D1KRYTP5L"
  },
  "recipient": {
    "id": "B1KSCS94Z:T1KS69V8F",
    "name": "platformservice"
  },
  "text": "test",
  "attachments": [],
  "entities": [],
  "channelData": {
    "SlackMessage": {
      "type": "message",
      "channel": "D1KRYTP5L",
      "user": "U1KSC3SEM",
      "text": "gfh",
      "ts": "1468257994.000362",
      "team": "T1KS69V8F"
    }
  }
}

we have a fix for this which should be available by end of day.

@tomlm Great news! I'm still getting Unauthorized on the Skype channel though. Should I open a separate issue for that?

Hi, I'm getting an error in slack. the line in question is
await connector.Conversations.ReplyToActivityAsync(reply);

The problem seems to have been resolved, Slack works fine for me now. I'm closing the issue.

Slack started working automatically or you have to create a new slack bot? I'm still facing this issue.

@gosha1 yeah automatically. Are you still getting the deserialization exception? Maybe try removing and readding Slack on your bot page. (Sorry, I have no better idea.)

Its working for me now. I had given my BotHandle value for BotId in web.config. When I changed it to the Name of the AppId created in the apps.dev.microsoft.com portal, Slack started working. Wondering how skype and web chat worked previously.

Thanks! Confirmed to be working.


Remove pricing plan walkthrough

Description of changes

Removes the pricing plan walkthrough from add/update commands. Set the PricingPlan value for a geo resource to always be RequestBasedUsage
Warn when Esri data provider is chosen that the resource cannot be used for tracking/routing commercial assets.

Issue #, if available

Description of how you validated changes
unit testing, JS sample app
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #9453 (5d2c906) into amplify-geo-staging (d26fa71) will decrease coverage by 0.04%.
The diff coverage is 80.95%.

@@                   Coverage Diff                   @@
##           amplify-geo-staging    #9453      +/-   ##
=======================================================
- Coverage                55.70%   55.66%   -0.05%
=======================================================
  Files                      877      877
  Lines                    49219    49097     -122
  Branches                  9761     9725      -36
=======================================================
- Hits                     27419    27330      -89
+ Misses                   20920    20887      -33
  Partials                   880      880

Impacted Files
Coverage Δ

...plify-category-geo/src/provider-controllers/map.ts
45.76% <ø> (ø)

...-geo/src/service-stacks/geofenceCollectionStack.ts
100.00% <ø> (ø)

...mplify-category-geo/src/service-stacks/mapStack.ts
100.00% <ø> (ø)

...category-geo/src/service-stacks/placeIndexStack.ts
100.00% <ø> (ø)

...mplify-category-geo/src/service-utils/constants.ts
100.00% <ø> (ø)

...y-geo/src/service-utils/geofenceCollectionUtils.ts
56.57% <0.00%> (+2.82%)
:arrow_up:

...amplify-category-geo/src/service-utils/mapUtils.ts
60.46% <0.00%> (+2.68%)
:arrow_up:

...-category-geo/src/service-utils/placeIndexUtils.ts
56.41% <0.00%> (+2.75%)
:arrow_up:

...y-category-geo/src/service-utils/resourceParams.ts
100.00% <ø> (ø)

...geo/src/provider-controllers/geofenceCollection.ts
50.00% <100.00%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26fa71...5d2c906. Read the comment docs.


Redirect VS help link

Docs Build status updates of commit d2d3828:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Drum-kit using javascript

This is a simple project developed using javascript data-key, dom-manipulation and CSS animation In this project, seven button are there by clicking each button a sound would be played. This is an interesting project for listening to self-made drum tunes.

@bishalshaw-164 Drum Kit Already Present in our code base. Checkout out If you want to modify it. Let me know will assign it you.

Can i work on this  @ridsuteri @harshgupta20 . I will modify it further .

@Ankita297 Can you describe the changes you want to make ?

@harshgupta20  right now there is only mouse clicking option we can key board event listener and also image is small we can enhnace the image and we can add some animation to button when it get clicked .

So can i work on this @ridsuteri ?

Can i work on this @ridsuteri Sir ?

@Ankita297 keypress events are active on this project so if you want to improvise the project on any other basis please give a brief description of the changes you are going to make also if possible please share img/gifs :)

@ridsuteri Sir you can check previously if keypress event occurs there is no animation in button and also theme toggler button does not work and it is not mobile responsive
https://user-images.githubusercontent.com/67833077/119236102-39b86e80-bb53-11eb-8685-9499b9fde1bd.mp4

ok got it @Ankita297 , go ahead :)


"Create a launch.json file" does not get initial configs from debug adapter

Open workspace with no launch.json
In the debug viewlet click "Create a launch.json"
Pick "Node"
Empty launch config is created, when it should have asked the debug adapter for the initial launch configs and added those to the created launch.json

From https://github.com/microsoft/vscode/issues/153388

The flow to create a launch.json from the button in the debug viewlet is broken, although users would not be entirely stuck - even though they end up with an empty launch.json, the "Add Configuration" button will still work at this point. I think it's worth getting in to .0 if possible, though.


Use infallible conversion into instead of try_into

A new clippy lint https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_fallible_conversions has been added to rust 1.75.0 that is causing the CI failure. The use of try_into when into is available will be reported by the lint now.
Signed-off-by: Gowtham Suresh Kumar<EMAIL_ADDRESS>

Nightly Ci failure: https://github.com/parallaxsecond/rust-cryptoki/actions/runs/7391892330


[fixes] Add bug fixes from asan

[fixes] Add bug fixes from asan

**Changes proposed in this PR:**
- Fix issues from address sanitizer
- Enable deprecated-declaration warning but disable for some files

**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1483. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.


Cannot build browser version from npm install

After installing escoden into my project (with npm install escodegen) I tried to build the browser version as instructed (npm install followed by npm run-script build). However, this fails in the second step because tools/entry-point.js is not part of the installation.
I was able to work around it (I think) by running ./node_modules/.bin/cjsify -a path: escodegen.js > escodegen.browser.js manually.
Ideally, I think the browser version would be included in the npm install which would avoid the need for any further steps.

Same here.

+1.  I also had to change your command slightly to ./node_modules/.bin/cjsify -a path: escodegen.js > escodegen.browser.js -e escodegen, otherwise it didn't export the module correctly.  Using that, I could finally do:
import { escodegen } from './node_modules/escodegen/escodegen.browser'

Additionally, the pre-built browser version available with recent releases is broken (at least with require and similar), as escodegen is undefined below and the import fails.
require.define('/tools/entry-point.js', function (module, exports, __dirname, __filename) {
    (function () {
      'use strict';
      global.escodegen = require('/escodegen.js', module);
      escodegen.browser = true;  // Uncaught ReferenceError: escodegen is not defined
    }());
  });

Ideally, I think the browser version would be included in the npm install which would avoid the need for any further steps.

👍

after 2 years this is still a problem :/


build master branch failed

Make sure these boxes are checked before submitting your issue - thank you!

[ok] I have checked the superset logs for python stacktraces and included it here as text if any
[ok] I have reproduced the issue with at least the latest released version of superset
[ok] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version master branch clone from https://github.com/apache/incubator-superset.git
Expected results
build superset from source code with success
Actual results
no success, stuck at exec "python setup.py install"
Steps to reproduce
build as the Make your own build .
cd $superset-master/superset/assets
yarn
yarn run build
cd $superset-master
python setup.py install
GET STUCK every time when exec python setup.py install
error: can't copy 'superset/static/assets': doesn't exist or not a regular file
superset/static/assets is a Symbolic Link of ../assets
yarn & yarn run build just work success, but i got the error on master branch everytime.
any helps?!!

superset  isn’t officially supported on Windows, and the kombu module needed by superset is not supported on Windows, so, you better try linux OS

I have no idea...

If you're cmofortable with Docker, you can try to see if this works for you : https://hub.docker.com/r/amancevice/superset/

how to sovle this problem,I have same issue


Documentation upgrade?

Hi @kohya-ss!
I reached out on twitter, wondering if you'd like some help with documentation.
I was thinking it might be helpful to set up github pages ( at https://kohya-ss.github.io/ ) or maybe run the amazing python documentation tool: sphinx ( https://www.sphinx-doc.org/en/master/ )
Let me know if I can help! I've worked on the pytorch docs https://pytorch.org/docs/stable/index.html in the past, and I think Kohya deserves the same kind of attention. Would love to put something together for Kohya to make it easier and more accessible for users.
LMK your thoughts & if you have any plans for docs already.

I could do a mock setup in a branch/fork?
Github pages is fairly easy to integrate and works best for simple docs.
Sphinx is better when you want to point from the documentation to specific functions in the codebase & you want to have the site hosted off of github.
I can fork the repo and set up github pages, and make a quick mock site ... you can let me know what you think?


test-branch/execute-job/quoted-authorization/d37653f6-6788-4e4a-b5a0-a633228c0336

PR for testing 10e019895d42a2bb562ec5b5a681973f2d56e491

/canonical/self-hosted-runners/run-workflows 10e019895d42a2bb562ec5b5a681973f2d56e491


Date picker component

Summary of the changes
Tell us, in a few words, what the changes are.
Related issue
Tell us the issue number. If suggesting an improvement or component, please discuss it with us in an issue first.
Checklist

[ ] I have added relevant unit and visual regression tests.
[ ] I have manually accessibility tested any changes, if relevant.
[ ] I have ensured any changes match the Figma component library.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.5 out of 6 committers have signed the CLA.:white_check_mark: ad9242:white_check_mark: GCHQ-Developer-299:white_check_mark: GCHQ-Developer-530:white_check_mark: jd239:white_check_mark: j212122:x: github-actions[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


Handling URLs

URLs get parsed as commands (i.e. protocol://blahblah is interpreted as protocol (//blahblah)), which is a bit awkward when writing curl/git/ssh/scp commands. Is it reasonable to parse something like 'http://blahblahblah' as a symbol, and only make it a command when there's a space following the colon? i.e. 'http: //blahblahblah' uses a command called HTTP.
Alternatively, URLs could be matched as their own data type (which might be nice since oh has a stronger type system than most shells). Or the ':' shorthand could be replaced with another symbol like '$' a la ocaml or '@' a la haskell (though it would still have to be surrounded with spaces since scp/mail use @)?
I know that you can wrap it in quotes to make it a string, but URLs are extremely prevalent in shell commands, so wrapping them all in quotes can get tedious.

Yeah, I've thought about allowing single colons inside symbols. I've also thought about removing the '@' operator (but keeping splice) and changing backtick to automatically splice. Doing that would allow URLs and email addresses to be entered without quotes. This would also mean that variadic methods would have to have a space following the colon in their parameter list. (Something I have not been consistent about). The drawback is a more complicated syntax with one more special case which is something oh has tried hard to avoid.

I think it's worth pointing out that URLs have to be quoted in BASH and probably any shell. URLs are common, but they also complex and they utilize a large number of special characters.

I'm wondering if it's possible to build a sufficiently smart completer so that quotes can be added (suggested?) when they are needed in order to keep oh keystroke competitive without complicating oh as a language.

I've been playing around with ways to reduce the differences between what needs to be quoted in oh vs other shells. In retrospect, I think : and :: were poor choices. Leading, trailing and interior colons can be found in many Unix shell commands. Double colons too and probably increasingly so with the rise of IPv6.
The current plan is to replace : with the single $. so instead of writing:
define r: cons () ()

we would write:
define r $ cons () ()

Using $ this way feels similar to the way it is used in regular expressions, vi, etc. "This sublist extends to the end of the current list". I believe Haskell does something similar.
The $ needs to appear on its own so the space after is required. I will probably put a space before (except after =) just to make them easier to spot. In my opinion, the colon looked nicer but using $ instead will reduce pointless differences between oh and other Unix shells.
Expressions of the form: a::b will be rewritten as ```{a}{b}. So instead of writing:
p::_reader_close_

we would write:
{p}{_reader_close_}

These changes will allow colons to appear unquoted.
The splice operator @ and the rarely used %a b% reference syntax will also be removed. _splice_ will still exist but there will be no shorthand syntax for it. References will be replaced by meta-commands that will have the form $[a b ...]. These changes will allow @ and % to appear unquoted.


fix: [FluentRadio] Not displaying initial "checked" state

🐛 Bug Report
I have two FluentRadio buttons within a column in a FluentDataGrid.  I'm using a boolean value from the data context to try to set the Checked state.
           <TemplateColumn Title="Is this an Event Attribute?" Align="Align.Center">
                 <FluentRadioGroup Orientation="Orientation.Horizontal">
                    <FluentRadio Id="radioYes" Value="true"<EMAIL_ADDRESS>                    <FluentRadio Id="radioNo" Value="false" Checked="@(!(context.UseAttribute))">No</FluentRadio>
                </FluentRadioGroup>
            </TemplateColumn>
When the grid renders with the data, these radios are not "checked"
💻 Repro or Code Sample
Repo is here:   https://github.com/BulldogCTISolutions/DnisMaintenance.git
🤔 Expected Behavior
When the grid renders, either the "Yes" radio is displaying checked or the "no" radio is displaying checked.
😯 Current Behavior

💁 Possible Solution
Been trying StateHasChanged().  But I cannot figure out the lifecycle of the DataGrid.  Is there an AfterRenderred or DataLoaded event?
🔦 Context
My users need to see what values are set when the DataGrid loads.
🌍 Your Environment

OS & Device: [Windows 10] on [PC]
Browser [Microsoft Edge]
.NET 7 and FAST Version [2.0.4]

You need to set the value on the group like so:
 <FluentRadioGroup Orientation="Orientation.Horizontal" Value="@(context.UseAttribute.ToString())">
                    <FluentRadio Id="radioYes" Value="True">Yes</FluentRadio>
                    <FluentRadio Id="radioNo" Value="False">No</FluentRadio>
                </FluentRadioGroup>

Fixed in V2.0.5

Confirmed. Fixed.  Thanks Vincent!
On Sun, Feb 12, 2023 at 4:50 AM Vincent Baaij @.***>
wrote:

You need to set the value on the group like so:

Yes
No

—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/fast-blazor/issues/319#issuecomment-1427025094,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMC7GD3DZFASFJEX7GVT6CDWXDMAJANCNFSM6AAAAAAUYGGDBI
.
You are receiving this because you authored the thread.Message ID:
@.***>


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 10:09:29 on 2023.08.14
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 1, errors out: 0
Original problem ID: 36126
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=36126

Problem has been resolved in 3m 0s at 10:12:29 on 2023.08.14
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 36126


[PLAT-579] Remove hidden canvas renderer

Summary
Updates to remove the hiddenCanvasRenderer in favor of providing a predicate for dimensions matching on resize to the existing canvasRenderer.
Test Plan

Test resizing (should not see "blank frames")

Release Notes
N/A
Possible Regressions
Resizing
Dependencies
N/A

Would like to take a look locally before merging.


ZombieMonster/TextScripts/JumpScript

Thanks
On Jun 30, 2017 11:46 PM, "Amy Jiang"<EMAIL_ADDRESS>wrote:

@AyeEmWhy https://github.com/ayeemwhy requested your review on:
so0p/unity2dgame#7 https://github.com/so0p/unity2dgame/pull/7
ZombieMonster/TextScripts/JumpScript.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/so0p/unity2dgame/pull/7#event-1146871799, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AWBA4_BtRozQDRBbOZeU9y1og84B3VwRks5sJesfgaJpZM4OLPHk
.


To string

Compatibility with the current core library.
Moved allocation to the C adapter where the exact size is known as opposed to reserving an excessive amount.

👍


Using deployment keys for private repositories with deis builder

Is it currently possible for the deis builder to access private repositories hosted on services like github / bitbucket using SSH?

currently no. We don't have a way to attach docker auth credentials for a build.

Relevent: we now have support for private buildpacks through #3259
ping @iancoffey as I believe this is something we discussed :)

awesome! :+1:

Now that #3305 is merged, the original issue might be fixed by using deis config:set SSH_KEY=.

indeed, but I believe this issue is around telling the builder to pull a private repository from a git URL, rather than cloning a private repository locally then pushing it to the builder. We don't have support for the former, but we do for the latter!
Note that this is how Engine Yard deploys apps.

Actually, #3305 implemented setting BUILDPACK_URL to a private GitHub repository specifically.

@mvgijssel what was your requirement here specifically? Deis now handles the case where a private buildpack needs an SSH key for access, but we weren't sure if you implied larger changes.

We have this issue also. Using the official Heroku Node.js buildpacks we need to pull in various GitHub private repos (modules) to build our app. Dokku gets around this with plugs to share deployment and host keys. However to date I have seen no way to build with private dependencies in our package.json file(s).
npm ERR! fatal: Could not read from remote repository.
npm ERR!
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.```

@Crispy1975 this seems related to https://github.com/heroku/heroku-buildpack-nodejs/issues/208, so yes it sounds like a buildpack-specific issue.

@bacongobbler going to try their solution locally to see if that works. Will report back here.

Nope, no luck. Forced 2.6.x of npm in package.json also logged in to the deis-builder and make sure it had known_hosts and relevant keys for GitHub access (assuming that is correct) and still getting the same error.

@Crispy1975 would you mind opening a separate issue so we can track this independently? This sounds like a separate issue than the OP. Thanks!

Was about to file a new issue and I noticed that I actually got a different error this time...
   $ git push -f deis testing/deis:master
   Counting objects: 424, done.
   Delta compression using up to 8 threads.
   Compressing objects: 100% (197/197), done.
   Writing objects: 100% (424/424), 45.00 KiB | 0 bytes/s, done.
   Total 424 (delta 249), reused 366 (delta 218)
   -----> Node.js app detected

   -----> Reading application state
          package.json...
          build directory...
          cache directory...
          environment variables...

          Node engine:         0.12.x
          Npm engine:          2.6.x
          Start mechanism:     npm start
          node_modules source: package.json
          node_modules cached: false

          NPM_CONFIG_PRODUCTION=true
          NODE_MODULES_CACHE=true

   -----> Installing binaries
          Resolving node version 0.12.x via semver.io...
          Downloading and installing node 0.12.5...
          Resolving npm version 2.6.x via semver.io...
          Downloading and installing npm 2.6.1 (replacing version 2.11.2)...

          ...

   npm ERR! ssh: connect to host github.com port 22: No route to host
   npm ERR! fatal: Could not read from remote repository.
   npm ERR!
   npm ERR! Please make sure you have the correct access rights
   npm ERR! and the repository exists.

ssh having issues getting through to GitHub on port 22. Yet inside the builder I had connectivity.

Have started a new issue on the above here #3923

ping @mvgijssel. Quoting @mboersma:

What was your requirement here specifically? Deis now handles the case where a private buildpack needs an SSH key for access, but we weren't sure if you implied larger changes.

Sorry for the late reply! Besides private buildpacks I was also interested in pulling private repositories for dependencies (gems, js modules, pip packages, ...). One of these issues is now fixed and the other is referenced in #3923.


Seems to eat the body

Adding this to the middleware on my Gin server seems to make the request body become empty, and return EOF on read.

I believe the defect is the wrapper trying to restore the body.
	// Restore the request body for further processing
	c.Request.Body = io.NopCloser(bytes.NewReader(body))

This works, but the existing code which wraps the (now empty) c.Request.Body in the NopCloser fails to pass any content along.

hi @skandragon Thank you for raising the issue; I will check this problem soon.

hi @skandragon the bug should have be fixed in the version v1.0.1, thanks again for your contribution!
v1.0.1


Update API as discussed in #53

As discussed in #53 , we need to make a number of changes to the API to make it easier to avoid tripping ourselves up later and to make this more generally useful.
Change to a model where the constructor just initializes and then components are added piecewise as desired
For example
mixture = MixtureSystem()
mixture.addComponent(label='phenol', smiles='c1ccc(cc1)O', number=1)
mixture.addComponent(label='toluene', smiles='Cc1ccccc1', number=10)
mixture.addComponent(label='cyclohexane', smiles='C1CCCCC1', number=500)
mixture.build(prmtop_filename='mixture.prmtop', inpcrd_filename='mixture.inpcrd')

Note that (see below) number will be an optional argument, as will label. i.e., this is a more low-level API and a higher level is possible.
Make the build option take a variety of arguments to only get out what file types we want
See example above. The build() function would take a bunch of optional arguments for the file types desired to be saved. It should store .sdf and .mol2 files of all components anyway, and a .pdb of the final system, but then optional arguments should be used to control whether AMBER .prmtop/.crd files, GROMACS .top/.gro, etc. are saved.
Make it so this can easily and transparently be used for pure solutions, mixtures, and infinite dilution setups
For example, we want to be able to do something like this:
liquid = MixtureSystem()
liquid.addComponent('water')

binary_mixture = MixtureSystem()
binary_mixture.addComponent(name='water', mole_fraction=0.2)
binary_mixture.addComponent(name='methanol') # assumed to be rest of mixture if no mole_fraction specified

ternary_mixture = MixtureSystem()
binary_mixture.addComponent(name='ethanol', mole_fraction=0.2)
binary_mixture.addComponent(name='methanol', mole_fraction=0.2)
ternary_mixture.addComponent(name='water')

infinite_dilution = MixtureSystem()
infinite_dilution.addComponent(name='phenol', mole_fraction=0.0) # infinite dilution
infinite_dilution.addComponent(name='water')

Note that this means:

The addComponent will need to be able to accept a name argument (which would serve BOTH as the label AND as a source of canonical isomeric SMILES if these are not provided)
Provision of label will be used for file names whether or not name is provided, i.e. binary_mixture.addComponent(name='ethanol', label='test', mole_fraction=0.2) means all ethanol files get called test and the name is only used in generating SMILES
Provision of name, label AND smiles results in label and smiles being used and results in a warning that the name is not being used
Given that this uses mole fraction, the code needs to make a sensible decision as to target box size which should be able to be overridden (i.e.  via the constructor) if the user desires
If mole fractions of no components are provided (and not solute numbers), it will successfully set up the system only if a single component is provided (in which case it's a pure solution) and raise an exception if not (since solute numbers or mole fractions must be provided then) (get a recommendation from @bannanc as to what she's typically using as she's studied this).
If mole fractions of all components are provided than it can set them up based on the default box size
In the infinite dilution case, it will need to recognize that a mole_fraction of 0.0 means only a single solute of each component with this mole fraction is desired. It should be acceptable to combine this with a mixture, i.e. you should be able to have components with mole fractions 0.4 and 0.6 that comprise the majority of the system, along with a single molecule of several components at mole fractions 0.0 and 0.0.

minor cleanup
Strip out the run option from the class for now, including self.equilibrate and self.productionandjust_build` options.
Please do open an WIP PR as soon as you begin working on this and commit to/push to it regularly so I can monitor.

I'm starting working on this now

I was discussing the best way to implement the mole fraction with Gaetano this afternoon. We are concerned about having default box sizes as then you also need a density for each molecule or an average density for the system in order to get a total number of molecules. We are thinking the most simple way to implement would be to have a default number of total molecules (maybe how many water molecules needed to make a large enough box for one of our simulations). Then there is no dependence on density.

@davidlmobley and @nividic

I was discussing the best way to implement the mole fraction with Gaetano this afternoon. We are concerned about having default box sizes as then you also need a density for each molecule or an average density for the system in order to get a total number of molecules.

So, the thought is that one will always run a constant pressure equilibration on these systems which will bring things to the right density and pressure.
One can't avoid the density issue, I don't think. Our current protocol uses a rough estimate of the density (currently, that of water) to get the box volume from the number of molecules specified. Unless we are willing to require the user to input a target number of molecules and target volume, there is no way around this, I believe.

We are thinking the most simple way to implement would be to have a default number of total molecules

I don't see how this avoids the issue; actually in my view it makes it worse, as if you have large molecules then having 1000 (for example) of them will result in very large large boxes whereas having 1000 small molecules will result in small boxes.
In my view the best solution is to say something like, "Well, we know we typically need a box which is at least as large as X, so let's specify we want a box of that size, and then use a rough guess of the density to convert that to an approximate number of molecules." How to guess the density? Well, my approach was to use that of water, since it's towards the heavier end of common solvents (https://www.organicdivision.org/orig/organic_solvents.html) so if the actual density is lower than that of water you'll end up (after constant pressure equilibration) with a larger box than is really needed. That's a "safe" error to make, as problems only will arise when you end up with a smaller box than you wanted.
That explains my rationale. But:

We are thinking the most simple way to implement would be to have a default number of total molecules (maybe how many water molecules needed to make a large enough box for one of our simulations). Then there is no dependence on density.

I still don't see how this would remove any density dependence, i.e. if you say you want 1000 cyclohexane molecules to simulate pure cyclohexane, you still have to figure out what size box you want to put them in, so you either need to know the density of cyclohexane, or just guess the density (i.e., that it has the same density as water) and let the equilibration sort it out.
Or maybe there is some density dependence you're concerned about that I'm still missing?

Resolved by #64


Adds proof harnesses for aws_byte_cursor_eq_byte_buf* functions

Description of changes:

Updates implementation of aws_byte_cursor_eq_byte_buf* functions with pre- and post-conditions;
Adds proof harnesses for aws_byte_cursor_eq_byte_buf* functions;

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tautschnig @karkhaz @angelhof @danielsn @markrtuttle could you review the proof harnesses?


CTCP-4731-para: Adding the missing paragraph

@joecefnhedog there is an a11y issue associated with your screenshot. The 'additional HTML' should be nested between the radios and the label, like in this example here:

Could you look into why that isn't the case in yours and whether it's an issue in the other 'add another document' views?

@joecefnhedog has attached the latest screenshots. Above comment can be ignored 😄


Validating attribute converter on a reflect attribute does not reflect the updated value of the attribute

Which package(s) are affected?
Lit Core (lit / lit-html / lit-element / reactive-element)
Description
Expected behavior: all asserts pass in the given playground
Actual behavior: final assert fails
Reproduction
See this playground: https://lit.dev/playground/#gist=f35179f470281763a9b58b743c4f0b25
Workaround
No workaround yet.
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
Failing in LitElement 3.2.0
Browser/OS/Node environment
Browser: Chrome 111.0.5563.146
OS: macOS Version 13.3

Chatted with Kevin, this is intended behavior, we generally don't reflect synchronously in response to a property set


Build errors - Dictionary, JSONObject

Dictionary and JSONObject cannot be resolved to a type
org.json not added to repo
not sure what 'Dictionary' object is required

Is this still in there? I looked (briefly) and didn't see these. I had added dictionary and then changed it to hashtable. And I got a different version of json just because I found much better examples and was starting to work through it. But I thought I added those to the classpath etc.

I will update again when I get home and get back to you.
On Jan 23, 2015 9:31 AM, "Keith"<EMAIL_ADDRESS>wrote:

Is this still in there? I looked (briefly) and didn't see these. I had
added dictionary and then changed it to hashtable. And I got a different
version of json just because I found much better examples and was starting
to work through it. But I thought I added those to the classpath etc.
—
Reply to this email directly or view it on GitHub
https://github.com/kiarnold/RiskSimlutator/issues/27#issuecomment-71200615
.


[$250] Admin's name is showing as blank after Editing anything on profile page - Reported by @Tushu17

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open website.
Go to settings > profile > edit anything and save
Then go to workspace manage member page and see admin's name.

Expected Result:
Name shouldn't be showing as blank
Actual Result:
It's showing blank until user refreshes the website.
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
Mobile Web

Version Number: 1.1.96-0
Reproducible in staging?: Y
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/189038101-228df7d0-eab0-42ba-abcc-0cc36b44fb58.mp4
https://user-images.githubusercontent.com/43995119/189038104-6e37003a-4479-4e7c-91a1-ef172b8b166c.mov
Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661322811349869
View all open jobs on GitHub

Proposal
User profile has First Name and Last Name already updated

Workspace Manage member page then

First Name and Last Name removed (made blank) from User profile and Saved.

Workspace Manage member page then

Again User profile page opened and saved without changing anything and visited Workspace Manage member page.

Will it be okay if we only display LoginID only once.

will look at this tomorrow

We can export this one.

Posted to Upwork: https://www.upwork.com/jobs/~013fb8003f81392003
As the reporter, @Tushu17 has right of first refusal on this one.

Hey @stephanieelliott, the policy has changed now the reporter doesn't get dibs on an issue. Anyone can post a solution.

Oh cool, thanks @Tushu17!

Re-applied the External label, it didn't apply the assignments correctly the first time. @rushatgabhane we have a proposal here when you get a chance!

Almost sure this is a dupe of https://github.com/Expensify/App/issues/11134 and we can close this

Almost sure this is a dupe of #11134 and we can close this

Hey @iwiznia, This issue was reported and created before #11134. So I think we should close the other issue.

Sounds good to me

Cool! Ok, removing the Help Wanted label since we have a fix for this already.

Oh, BTW, this is already fixed too. @stephanieelliott reporting payment is needed, please check if you agree with my message above.

@rushatgabhane is technically correct, but in this case, there were a few mishaps in the issue, like there were 2 issues created (but only one was needed) and they were marked as external when they were really internal. Due to that and the fact that you did spend time debugging it and helped @parasharrajat, I think we should pay out $250 (same as reporting bonus) in good faith.
One minor note: if the issue is in the backend, we should not attempt to fix it in the frontend. so saying  for next time if there's a similar issue, it's better to not add frontend proposals and instead commenting something like:

This issue is coming from the backend, data in the property X of the onyx key Y, that gets set after calling the API command Z is sending bad data: it should not return & symbols html escaped.

Thanks for your help and look forward to working with you again!
@stephanieelliott can you pay @aimane-chnaif $250 please?

Thanks, @iwiznia for following up. There is something I want to add.
We strictly follow our documented guidelines. There can be exceptions but no one should expect those. If someone feels that something is not done as per the guidelines, we will be happy to help you understand or fix our mistake.
For this issue,

As per guidelines, no solution was accepted thus technically none of those proposals is eligible for payment. The same can be seen in my comment. I explained the reasons why solution 1 and solution 2 were not the best things to do.

At last, I agree with @iwiznia's decision and look forward to more contributions from you and I am sure there won't be many such cases.
Thank you.

Hey @aimane-chnaif, can you please grab the job on Upwork? We’ll use that to pay you https://www.upwork.com/jobs/~013fb8003f81392003

All paid up!


Make AsyncDrain only take AsyncReceivingStream

No need for it to be Sending as well, this respects the contract better.

/cc @open-swift/contributors

Merging this with 3 upvotes.


Add helpful wiki links

[ ] All Roles
[ ] How to play
[ ] GIM main page
[ ] wiki main page
[ ] list of staff
[ ] terminology
[ ] voting terminology

Where would I be adding these? Please be at least a little specific, thanks

Hmm, I'm not sure. But here's what we originally discussed.

We did talk about this a little while ago.
For /help role (may be called differently) you could put a text field, and if a correct role (that exists) is entered a wiki link / the rolecard is provided:

INSERT ROLECARD
For further reading consult our wiki page:

Some of the stuff could just be you type this and the bot DMs you it??
Thinking terminology, how to play, or otherwise it DMs/shows you the wiki link.
Same for main page stuff ig?

@LunexSan
DMs are probably something to avoid for once-off information since ephemeral is clearly the superior option. If I am able to get the core down, are you able to fill out the data for the remaining roles. Just so I am doing what nobody else can do rather than wasting that time doing something majority can do.
Probably better to have the data stored externally, such as on the database,  so they can be updated without the need for a server restart.

Showing a wiki page is probably a good "read more" concept but having most relevant information shown in-chat is ideal

If it's just filling in strings, I can do that.


Public recipe

Hi @Peter1907, please review this PR:
PUBLIC RECIPE LIST

Public recipe list
Bullet gem installed and N+1 problems resolved
root page change to the public recipe list

Happy review!!!

Thank you @Peter1907 !!!


Problem with new Hybrid platform view rendering on certain devices

Steps to Reproduce
Run hybrid version of platform view on API 19 device in this case Samsung SM-T231.
Expected results: Not crushing platformview
Actual results: Platformview cant call render part connected with android.media.ImageReader.nativeImageSetup;

Logs

E/flutter (19832): [ERROR:flutter/shell/platform/android/platform_view_android_jni_impl.cc(43)] java.lang.UnsupportedOperationException: The producer output buffer format 0x5 doesn't match the ImageReader's configured buffer format 0x1.
E/flutter (19832):      at android.media.ImageReader.nativeImageSetup(Native Method)
E/flutter (19832):      at android.media.ImageReader.acquireNextSurfaceImage(ImageReader.java:292)
E/flutter (19832):      at android.media.ImageReader.acquireNextImage(ImageReader.java:338)
E/flutter (19832):      at android.media.ImageReader.acquireLatestImage(ImageReader.java:242)
E/flutter (19832):      at io.flutter.embedding.android.FlutterImageView.acquireLatestImage(FlutterImageView.java:203)
E/flutter (19832):      at io.flutter.embedding.android.FlutterView.acquireLatestImageViewFrame(FlutterView.java:1101)
E/flutter (19832):      at io.flutter.plugin.platform.PlatformViewsController.onEndFrame(PlatformViewsController.java:803)
E/flutter (19832):      at io.flutter.embedding.engine.FlutterJNI.onEndFrame(FlutterJNI.java:856)
E/flutter (19832):      at android.os.MessageQueue.nativePollOnce(Native Method)
E/flutter (19832):      at android.os.MessageQueue.next(MessageQueue.java:138)
E/flutter (19832):      at android.os.Looper.loop(Looper.java:131)
E/flutter (19832):      at android.app.ActivityThread.main(ActivityThread.java:5602)
E/flutter (19832):      at java.lang.reflect.Method.invokeNative(Native Method)
E/flutter (19832):      at java.lang.reflect.Method.invoke(Method.java:515)
E/flutter (19832):      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1283)
E/flutter (19832):      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1099)
E/flutter (19832):      at dalvik.system.NativeStart.main(Native Method)
E/flutter (19832):
F/flutter (19832): [FATAL:flutter/shell/platform/android/platform_view_android_jni_impl.cc(1241)] Check failed: CheckException(env).
F/libc    (19832): Fatal signal 6 (SIGABRT) at 0x00004d78 (code=-6), thread 19832 (exmapkitexample)

[√] Flutter (Channel stable, 1.22.2, on Microsoft Windows [Version 10.0.19041.572], locale ru-RU)
• Flutter version 1.22.2 at C:\src\flutter
• Framework revision 84f3d28555 (6 days ago), 2020-10-15 16:26:19 -0700
• Engine revision b8752bbfff
• Dart version 2.10.2
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at C:\Users\username\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Android Studio (version 4.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 50.0.1
• Dart plugin version 193.7547
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] VS Code (version 1.50.1)
• VS Code at C:\Users\username\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.15.1
[√] Connected device (1 available)
• SM T231 (mobile) • 3100425c93096200 • android-arm • Android 4.4.2 (API 19)
• No issues found!

@kemphack
Can you elaborate when you say run hybrid version of platform view?  Can you point to the document / code sample that you are trying to run ? Also can you provide a reproducible code sample that we can copy paste and run in IDE that will show the issue ?

https://github.com/kemphack/yandex_mapkit/commit/13b488ff116844322cbacbaea52df95150ce08a7
all in example app works properly until params.onPlatformViewCreated is called

@kemphack
Although I am able to replicate the issue on api 19 emulator, I think it could be related to this issue, ie, platformviews are not visible on api 21 and below.  Would you be okay to close this as duplicate and follow-up in related issue ?
Thanks.


new methods to configure using service or serviceProvider predefined viewBoxes for icons using its name

new methods to configure using service or serviceProvider predefined viewBoxes for icons using its name

:+1:


Object.extname is deprecated.

Argument to path.extname must be a string
Object.extname (/opt/atom/resources/app/src/electron-shims.js:20:10)
LessAutocompileView.handleSave (/home/sagar/.atom/packages/less-autocompile/lib/less-autocompile-view.coffee:35:29)
HTMLElement.LessAutocompileView.atom.commands.add.core:save (/home/sagar/.atom/packages/less-autocompile/lib/less-autocompile-view.coffee:21:26)
CommandRegistry.handleCommandEvent (<embedded>:23418:36)
KeymapManager.dispatchCommandEvent (<embedded>:69815:22)
KeymapManager.handleKeyboardEvent (<embedded>:69606:28)

https://github.com/loeck/less-autocompile/pull/72


Fixed an issue which caused slug links on notes to become corrupted.

The refresh hook was being instantiated even for notes highlighted on the scene, causing their slug links to be overridden.

Nevermind, I realized this won't work for newly created notes

This is definitely fixed in v3.4.7, releasing soon...