python setup.py install fails on OSX & Linux

This is OSX 10.9.5 & python 2.7.5 failure
cc  -o upnpc-static upnpc.o libminiupnpc.a
ld: warning: ignoring file libminiupnpc.a, file was built for archive which is not the architecture being linked (i386): libminiupnpc.a
zip_safe flag not set; analyzing archive contents...
No eggs found in /tmp/easy_install-7K357E/miniupnpc-1.9/egg-dist-tmp-voMPw_ (setup script problem?)
error: Could not find required distribution miniupnpc
I tried brew install miniupnpc, which worked, removed the miniupnpc requirement from setup.py, and then the install runs to completion, but produces many errors while compiling. The resulting pyeth crashes as follows:
Traceback (most recent call last):
File "/usr/local/bin/pyeth", line 8, in
load_entry_point('pyethereum==0.7.51-1-gd442c11-dirty', 'console_scripts', 'pyeth')()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", line 318, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", line 2221, in load_entry_point
return ep.load()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", line 1954, in load
entry = import(self.module_name, globals(),globals(), ['name'])
File "/Library/Python/2.7/site-packages/pyethereum-0.7.51_1_gd442c11_dirty-py2.7.egg/pyethereum/init.py", line 2, in
import utils
File "/Library/Python/2.7/site-packages/pyethereum-0.7.51_1_gd442c11_dirty-py2.7.egg/pyethereum/utils.py", line 7, in
import db
File "/Library/Python/2.7/site-packages/pyethereum-0.7.51_1_gd442c11_dirty-py2.7.egg/pyethereum/db.py", line 5, in
from pyethereum.slogging import get_logger
File "/Library/Python/2.7/site-packages/pyethereum-0.7.51_1_gd442c11_dirty-py2.7.egg/pyethereum/slogging.py", line 71, in
structlog.stdlib._nameToLevel['trace'] = TRACE
AttributeError: 'module' object has no attribute '_nameToLevel'
This is Ubuntu on amd64 with python 2.7.5 after making similar effort to circumvent troubles with miniupnpc.
Processing pysha3-0.3.zip
Writing /tmp/easy_install-Vv5ERU/pysha3-0.3/setup.cfg
Running pysha3-0.3/setup.py -q bdist_egg --dist-dir /tmp/easy_install-Vv5ERU/pysha3-0.3/egg-dist-tmp-54ewfF
Modules/_sha3/sha3module.c:18:20: fatal error: Python.h: No such file or directory
#include "Python.h"
^
compilation terminated.
error: Setup script exited with error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
So ... no joy for Python users who want to experiment with Ethereum :-(

Regarding your ubuntu problems:
#include "Python.h"
^

-> seems you're missing the python-headers. Try installing the ubuntu package python-dev.

@nealrauhauser I assume this is resolved. Feel free to reopen if not.


support for 3d canvas / 3d portait (theRipper93 modules)

hovering over assets while in the 3d canvas does not show the image

Hi Halfd0rk,
Currently thisRipper93 modules are behind a paywall.
Thus this will be put on the backburner for now as I do not have access.


Add missing offset_adjust member in sync_info field of extended advertising header

Add missing offset_adjust member to pdu_adv_sync_info. Size of the pdu_adv_sync_info was correct, missing field was set as bit in RFU member.
Fix periodic_adv and periodic_scan samples, by selecting missing CONFIG_BT_CTLR_ADV_EXT config entry.

Failing tests is caused by: https://github.com/zephyrproject-rtos/zephyr/issues/32344

Removed commit that added nrf52833dk board to periodic advertising samples.
It is provided as separate PR: https://github.com/zephyrproject-rtos/zephyr/pull/32535


Filename Too Long when you clone this repo

Bug Report
Description
Cloning the repo produces an error from powershell on windows
Steps to Reproduce
$ git clone https://github.com/calebmeyer/terra-core.git
Cloning into 'terra-core'...
remote: Enumerating objects: 107, done.
remote: Counting objects: 100% (107/107), done.
remote: Compressing objects: 100% (60/60), done.
remote: Total 69516 (delta 44), reused 80 (delta 29), pack-reused 69409
Receiving objects: 100% (69516/69516), 90.91 MiB | 17.70 MiB/s, done.
Resolving deltas: 100% (47364/47364), done.
error: unable to create file packages/terra-responsive-element/tests/wdio/__snapshots__/reference/en/chrome_medium/responsive-element-spec/should_render_the_default_element_at_all_viewports_if_the_parent_remains_the_same_width[default].png: Filename too long
Checking out files: 100% (3721/3721), done.
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

Additional Context / Screenshots
Expected Behavior
I expected no errors
Possible Solution
If we can truncate these auto-generated file names, or come up with a new naming scheme, that would help
Environment

Operating System and version (desktop or mobile): Windows 10 Enterprise Version 10.0.17134

@ Mentions
@mjhenkes

I'm curious, does this suggestion mitigate the issue? Seems like this is a Windows API issue, not a Terra issue.
There's a recent issue logged to git-for-windows similar to this: https://github.com/git-for-windows/git/issues/2075

Yep, issue solved. Thanks for the help!


feat(api): merge api-metrics into api

Which problem is this PR solving?
Merge stable API packages @opentelemetry/api-metrics into @opentelemetry/api.
Fixes https://github.com/open-telemetry/opentelemetry-js/issues/3368
Notably, those packages that depend on the metrics API now declare peer dependency on @opentelemetry/api ">=1.2.0 <1.3.0" and "^1.,2.0". The version range should be updated to ">=1.3.0 <1.4.0" and "^1.3.0" respectively when metrics API is released in @opentelemetry/api v1.3.0.
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?

[x] Tree-shaking tests in @opentelemetry/api.

Checklist:

[x] Followed the style guidelines of this project
[x] Unit tests have been added
[ ] Documentation has been updated

@MSNev @dyladan updated with explicit exports moved to index.ts. PTAL :)


ci(java): run dependency test on Java 8 and 11

This PR was generated using Autosynth. :rainbow:
Synth log will be available here:
https://source.cloud.google.com/results/invocations/eeae4746-3508-43c9-a72e-6d6d9b4f6782/targets

[ ] To automatically regenerate this PR, check this box.

Source-Link: https://github.com/googleapis/synthtool/commit/4f2c9f752a94042472fc03c5bd9e06e89817d2bd

@chingor13 shall I go ahead and close this PR?


Change dummy Lorem IPSUM sentence.

Football World Community is a project that was created with the aim of bringing football and cryptocurrencies together so that users can enter the world of crypto football. FWC is a digital currency platform that allows users to create digital currencies while maintaining security and safety.


[CARBONDATA-1750] Fix NPE when tablestatus file is empty

[x] Any interfaces changed?
no
[x] Any backward compatibility impacted?
no
[x] Document update required?
no
[x] Testing done
no
[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1204/

LGTM


Type Expectation Documentation

Since there's so much use of auto and variable length argument lists, It's quite difficult to understand both what types the operators expect,whether or not they expect template parameters, and which types they return.
For example buffer and window would seem on the surface to be quite similar, but one returns an observable<std::vector> and the other returns an observable<observable>. These are not documented. Further, the compiler errors generated for not getting these things right are not helpful. In the same case, I was told that "Delegate[largehash]" did not have a member "on_error".

Agreed, the code is not explicit  :(
At the moment the best way is to look at documentation and examples.


limit memory on usage service

Right now the way it is working in production one pod keeps growing memory forever. This way we restrict pod budget so we don't grow infinitely. I am hoping that it will instead scale pods out when we hit limits.

Limiting memory can lead to data being dropped


glowroot only accessible on localhost

Perhaps instead of exposing this, we should just instead provide instructions so people can expose this  on their own.
tcp port 12675
Below are the instructions, taken directly from this glowroot link

By default, the Glowroot UI binds to <IP_ADDRESS> and is only accessible from localhost. If you wish to access the Glowroot UI from remote machines, change the bind address to <IP_ADDRESS> under Glowroot UI > Configuration > Web. Alternatively, the bind address can be changed by creating (or editing) admin.json (in the same directory as glowroot.jar), e.g.

{
  "web": {
    "bindAddress": "<IP_ADDRESS>"
  }
}

the above workaround is all we've got time for now, closing this.


Copying files from a public S3 bucket -- feature request?

Which version of the AzCopy was used?
azcopy version 10.6.1
Which platform are you using? (ex: Windows, Mac, Linux)
Azure Cloud Shell (bash)
What command did you run?
azcopy copy 'https://s3.us-east-1.amazonaws.com/irs-form-990/' 'https://myblob.blob.core.windows.net/forms-990' --recursive=true
What problem was encountered?
The error message:
failed to perform copy command due to error: AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY environment variables must be set before creating the S3 AccessKey credential
I attempted to set "dummy" key and secret (they do not exist on the source bucket https://s3.us-east-1.amazonaws.com/irs-form-990/ as it is open to public for read access) by running
export AWS_ACCESS_KEY_ID=123
export AWS_SECRET_ACCESS_KEY=123

The error message has changed to:
failed to perform copy command due to error: cannot start job due to error: cannot list objects, The AWS Access Key Id you provided does not exist in our records..
Is the key necessary when reading from public bucket? Essentially, is there an equivalent of --no-sign-request parameter in the official AWS CLI?
How can we reproduce the problem in the simplest way?
Run azcopy copy 'https://s3.us-east-1.amazonaws.com/irs-form-990/' 'https://myblob.blob.core.windows.net/forms-990' --recursive=true
Have you found a mitigation/solution?
No

Hi Egor,
I am also facing the same issue exactly like you have mentioned above. I tried searching it but couldn't find the solution.
Were you able to fix this issue?
My use-case is same, copying files from AWS S3 to Azure Storage.
Thanks a lot in advance!
Purvi

Hi, @purvi-pj
No, I moved on to other things and didn't look into this further. Let's hope Microsoft will implement this enhancement in the upcoming releases.
~Egor

Do not set the variable with set AWS_ACCESS_KEY_ID
Set the varialbes as amazon explains
https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html
PS C:\> $Env:AWS_ACCESS_KEY_ID="AKIAIOSFODNN7EXAMPLE"
PS C:\> $Env:AWS_SECRET_ACCESS_KEY="wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"

Do not set the variable with set AWS_ACCESS_KEY_ID
Set the varialbes as amazon explains
https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html
PS C:\> $Env:AWS_ACCESS_KEY_ID="AKIAIOSFODNN7EXAMPLE"
PS C:\> $Env:AWS_SECRET_ACCESS_KEY="wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"

This documentation needs to be updated to match the format that roncansan shared: https://docs.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-s3


Suggestion: Add one line in CRA-originated index.html that disable Chrome's automatic translation

Is your proposal related to a problem?
A deployed CRA-originated app ran into crashes. The error text:

react-dom.production.min.js:4260 DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

This is caused by Chrome's automatic translation feature. It seems it can modify a DOM node such that React's rendering process then fails. It is probably a fairly unusual error, but tricky to diagnose.
Describe the solution you'd like
The suggestion is to add

which according to Googles support pages (and in practice) then disables the automatic translation feature, and in turn React's rendering does not crash.
Describe alternatives you've considered
It is likely that React already tries at least somewhat to handle effects of browser plugins that change the DOM under the renderer process' feet, but maybe the Chrome translation is able to hide or somehow surprise any such protections. So there might be more interesting ways to solve this.
Other alternatives is to educate all users on how to disable this translation feature.
Additional context
Only Chrome has been specifically investigated. There are likely other browsers that offer automatic translation that can cause similar issues.

Hi @sesam, is this happening in dev and production modes?

Hi, we've since found this was already discussed in https://github.com/facebook/react/issues/11538#issuecomment-350110297
but in that issue thread nobody suggested handling this through changing CRA.
At least this means we're not alone, and that another alternative is to replace any {"content"} with {"content"}
and maybe find a code linter that helps make that replacement happen.


Installer stalls at "Downloading asar file" on Ubuntu 20.04

Describe the bug
The installer is stuck on "Downloading asar file" on Ubuntu Linux 20.04
To Reproduce
Steps to reproduce the behavior:

Mark the latest downloaded AppImage as executable
Execute the AppImage
Go through the installation
Installer stalls at "Downloading asar file"

Expected behavior
A successful installation
Screenshots

System Information:

OS: Ubuntu 20.04

Additional Info
I have tried disabling Ubuntu's firewall to no avail, the same installer works on the same PC on windows (I have a dual boot setup)

I'm still unsure of the origin of the bug, but I fixed it by replacing the line
downloadUrl = asset.url;
with
downloadUrl = "https://github.com/rauenzi/BetterDiscordApp/releases/download/v1.1.1/betterdiscord.asar";
under
installer/src/renderer/actions/instasll.js
and running script
npm run dev

Since this bug is pretty new, I compiled the installer with the fix in place. I had to use macOS to compile since Ubuntu wouldn't, so for anyone else having problems fixing it, here's the fixed installer. If anyone has problems installing, let me know.


Ability to select an already running instance of an application

📝 The new feature will be part of PowerToys Run. The idea is that PowerToys Run provides the feature similar to that of win + tab to cycle through currently running applications as well.
For example: when I have an application like visual studio code running but doesn't have the focus, I would be able to hit alt + space, type in vscode and the PT Run gives me an option to select an already running instance or open a new instance.
Currently for vscode it opens a new instance, which technically is what Run is supposed to do I guess, but is not the desirable behavior in most cases.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

Please read the documentation
https://github.com/microsoft/PowerToys/wiki/PowerToys-Run-Overview#15-action-key


Incomplete support for "User Collections" plugin

The support matrix mentions that User Collections plugin is supported, yet it does not seem to be possible to individually add pictures to a collection from the album's list view (or if it is, I didn't find how to do it).
Compare with the dark theme, where hovering the mouse over a thumnail displays an Add to collection option

Currently the mouse hover works with gdThumb/gThumb+ only, true.

I'm not sure how to interpret your answer - is this something that can (and will eventually) be fixed in the theme ? Or do I need to do something on the User Collections side ?
This is the only issue that makes me hesitate to set bootstrap darkroom as default theme, and would love to make the switch.

The default grid uses a completely different HTML structure than the preg_replace voodoo in the plugin expects. So I cannot support it.
But as said, it does work fine with the GThumb+ plugin.

Great!
Typo corrected, thanks.


Set opacity=0 instead of removing and allow to reverse this on toggle

I've modified the logic to set the elements opacity instead of removing it from the DOM. To be able to reverse this operation, the previous opacity is stored in a data attribute: data-kill-sticky-original-opacity on the element.
Additionally, I added a toggle logic so that clicking the extension icon again will show/hide the elements.
Let me know what you think. Instead of the opacity, one could also set the top, left to very large negative values to move them out of screen and bring them back by storing the original offsets in a data attribute.

Something like this might work, but it does need to be an option rather than changing the default; at least my own usage benefits from the node removal also taking care of e.g. auto-playing videos with sound (yeah, those unfortunately exist) as well as other sticky features that take up resources.
Also, just setting opacity isn't enough, as the elements will still stay rendered and capture events. Moving them off-screen by some offset might work. Also note that some elements switch to and from being sticky depending on the scroll position, so a proper undo will need to use some other marker to find the elements that it needs to fix back to how they were.

Something like this might work, but it does need to be an option rather than changing the default; at least my own usage benefits from the node removal also taking care of e.g. auto-playing videos with sound (yeah, those unfortunately exist) as well as other sticky features that take up resources.
Also, just setting opacity isn't enough, as the elements will still stay rendered and capture events. Moving them off-screen by some offset might work. Also note that some elements switch to and from being sticky depending on the scroll position, so a proper undo will need to use some other marker to find the elements that it needs to fix back to how they were.

Yepp, makes sense. Haven't thought about videos. Maybe add different treatment for media tags?
Agreed, Moving offscreen would be a better solution.

Closing this after some experimentation I agree this should only be done manually by a shortcut rather than automatically onload.


🐛 [firebase_messaging] ios notifications not working in production

Bug report
I saw there were older threads with what seems to be a very similar issue, but that it was supposed to be resolved in what are now earlier versions. However, ios notifications are simply not working when using the app when downloaded from the store. I saw some old post with something like the equivalent of Messaging.messaging.setAPNSToken("production"), but the closest thing I can find with the current version is only a get, like: FirebaseMessaging.instance.getAPNSToken()
Steps to reproduce
use   firebase_messaging: ^11.2.4
construct request like:
 var request = {
      'notification': {
        'title': title,
        'color': '#E91E63',
        'sound': 'default',
      },
      'data': {'click_action': 'FLUTTER_NOTIFICATION_CLICK'},
      'registration_ids': to,
      'priority': 'high',
    };

send request to FCM. I get notifications for Android when debugging and in production without any problems whatsoever.
iOS has been an absolute headache. After several days of experimentation, I finally figured out some magical combination of certificate/provisional profile/keys/keychain states so that notifications actually are received and make a noise when debugging through a computer. However, the latest release from the store, when downloaded, doesn't receive any notifications. guh.
Expected behavior
iOS notifications are received and displayed when the app is closed / in the background.
Sample project
Providing a minimal example project which demonstrates the bug in isolation from your main App greatly enhances the chance of a timely fix.
Please link to the public repository URL.

Additional context
none

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
takaomatt@Matthews-MBP-2 signal % flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.5.3, on macOS 12.0.1 21A559 darwin-x64, locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.2)
[✓] VS Code (version 1.62.3)
[✓] Connected device (3 available)

! Doctor found issues in 1 category.

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
takaomatt@Matthews-MBP-2 signal % flutter pub deps -- --style=compact
Dart SDK 2.14.4
Flutter SDK 2.5.3
signal 1.0.4+5

dependencies:
- audioplayers 0.20.1 [uuid path_provider http flutter flutter_web_plugins]
- auto_size_text 2.1.0 [flutter]
- cupertino_icons 1.0.4
- firebase_core 1.10.2 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_database 8.2.0 [firebase_core firebase_database_platform_interface firebase_database_web flutter]
- firebase_messaging 11.2.4 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- http 0.13.4 [async http_parser meta path]
- in_app_review 2.0.3 [flutter in_app_review_platform_interface]
- material_design_icons_flutter 4.0.5955 [flutter]
- shared_preferences 2.0.9 [flutter meta shared_preferences_android shared_preferences_ios shared_preferences_linux shared_preferences_macos shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]

dev dependencies:
- flutter_launcher_icons 0.9.2 [args image path yaml]
- flutter_lints 1.0.4 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- archive 3.1.6 [crypto path]
- args 2.3.0
- async 2.8.1 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.1.0
- charcode 1.3.1
- clock 1.1.0
- collection 1.15.0
- crypto 3.0.1 [collection typed_data]
- fake_async 1.2.0 [clock collection]
- ffi 1.1.2
- file 6.1.2 [meta path]
- firebase_core_platform_interface 4.2.3 [collection flutter meta plugin_platform_interface]
- firebase_core_web 1.5.3 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_database_platform_interface 0.1.0+4 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_database_web 0.1.2+1 [firebase_core firebase_core_web firebase_database_platform_interface flutter flutter_web_plugins js]
- firebase_messaging_platform_interface 3.1.4 [firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 2.2.5 [firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- http_parser 4.0.0 [charcode collection source_span string_scanner typed_data]
- image 3.1.0 [archive meta xml]
- in_app_review_platform_interface 2.0.2 [flutter url_launcher plugin_platform_interface platform]
- js 0.6.3
- lints 1.0.1
- matcher 0.12.10 [stack_trace]
- meta 1.7.0
- path 1.8.0
- path_provider 2.0.8 [flutter path_provider_android path_provider_ios path_provider_linux path_provider_macos path_provider_platform_interface path_provider_windows]
- path_provider_android 2.0.9 [flutter path_provider_platform_interface]
- path_provider_ios 2.0.7 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.2 [flutter path path_provider_platform_interface xdg_directories]
- path_provider_macos 2.0.3 [flutter]
- path_provider_platform_interface 2.0.0 [flutter meta platform plugin_platform_interface]
- path_provider_windows 2.0.4 [ffi flutter meta path path_provider_platform_interface win32]
- petitparser 4.4.0 [meta]
- platform 3.1.0
- plugin_platform_interface 2.0.2 [meta]
- process 4.2.4 [file path platform]
- shared_preferences_android 2.0.9 [flutter meta shared_preferences_platform_interface]
- shared_preferences_ios 2.0.8 [flutter meta shared_preferences_platform_interface]
- shared_preferences_linux 2.0.3 [file flutter meta path path_provider_linux shared_preferences_platform_interface]
- shared_preferences_macos 2.0.2 [flutter shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.0.0 [flutter]
- shared_preferences_web 2.0.2 [flutter flutter_web_plugins meta shared_preferences_platform_interface]
- shared_preferences_windows 2.0.3 [file flutter meta path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- sky_engine 0.0.99
- source_span 1.8.1 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test_api 0.4.2 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0 [collection]
- url_launcher 6.0.17 [flutter meta url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- url_launcher_android 6.0.13 [flutter meta url_launcher_platform_interface]
- url_launcher_ios 6.0.13 [flutter meta url_launcher_platform_interface]
- url_launcher_linux 2.0.2 [flutter]
- url_launcher_macos 2.0.2 [flutter]
- url_launcher_platform_interface 2.0.4 [flutter plugin_platform_interface]
- url_launcher_web 2.0.5 [flutter flutter_web_plugins meta url_launcher_platform_interface]
- url_launcher_windows 2.0.2 [flutter]
- uuid 3.0.5 [crypto]
- vector_math 2.1.0
- win32 2.3.1 [ffi]
- xdg_directories 0.2.0 [meta path process]
- xml 5.3.1 [collection meta petitparser]
- yaml 3.1.0 [collection source_span string_scanner]

@emptyopen
Does the notifications work on iOS in debug mode ?
Does either of the streams such as onBackgroundMessage, onMessageOpenedApp get triggered in debug mode ?
Does background callback work if you send a notification through FCM ?
{
  "notification":{
    "title": "This is the title",
    "body": "This is the body",
  },
  "content_available": true,
  "priority": "high",
  "data": {
    "id": 15,
    "type": "comment"
  },
  "to": "FCM token"
}

this one can be closed - it's working now. i'm not sure i changed anything to fix it, but oh well. hope it keeps working consistently.

Closing based on above comment.


Update to coincide with PR #422

Not sure how I missed this go by. @stuwilkins is this good to go?

LGTM Thanks for catching this @stuwilkins


Object streams not generated with newline before endstream when requested

If a QPDFWriter is configured like so
QPDFWriter w(...);
w.setObjectStreamMode(qpdf_object_stream_e::qpdf_o_generate);
w.setNewlineBeforeEndstream(true);
w.write();

where the input to w was a PDF/A, then verapdf complains that
The stream keyword shall be followed either by a CARRIAGE RETURN (0Dh) and LINE FEED (0Ah) character sequence or by a single LINE FEED (0Ah) character. The endstream keyword shall be preceded by an EOL marker

In short it seems that the object streams qpdf generates do not contain a newline before endstream.

Sorry I took me a while to get back to you. I reproduced it on the command line using 8.0.2 using one of the test files in ocrmypdf.
input.pdf
veraPDF confirms that input.pdf is a valid PDF/A. (FWIW Acrobat disagrees, and is probably correct, on account of an unrelated problem within the XMP metadata.)
Then run
qpdf --object-streams=generate --newline-before-endstream input.pdf output.pdf

The hope in doing that was to rewrite the file with object streams to make it smaller, while preserving PDF/A.
The output file will fail PDF/A validation with veraPDF, giving the same error as above.

The issue is not in the --newline-before-endstream part, but in --object-streams=generate.
For instnace, this keeps PDF/A validity using @jbarlow83's test input.pdf:
qpdf --object-streams=preserve --newline-before-endstream input.pdf output.pdf

@kilburn The input file has no object streams in it, so preserve has no effect here (and --newline-before-endstream works correctly on regular streams).

Well, I also tested with the example file I added to #133, which is one of the bugs that lead to the implementation of the newline-before-endstream option.
That file does have streams, and its PDF/A compliance is broken with --object-streams=generate but not with object-streams=preserve. Thus, I was only adding information that the bug seems to be in the content stream generation code, not in the newline-before-endstreams code.

The input test file has stream objects, but not object streams. Object streams are always marked /Type /ObjStm. (To make the naming even sillier, an object stream is a type of stream object. For the leading creative software company, Adobe's naming decisions are not exactly inspired.)

I'm guessing this will be as easy fix. I'll look at it soon. Thanks for the additional information.

If you could please check to see if the fix is correct, that would be great. If you're on Linux, the easiest way to do this is to download the AppImage associated with this commit, which will be available for two weeks, or of course you can build from source. See README-appimage.md for details on using the AppImage, but basically, download it and execute it in place of the qpdf binary.

Also the above-linked commit will work as a patch against any recent version. It's a trivial change.

AppImage works for me - thank you!


chore: Npm audit fix

Updating  - lots of packages security fixes by running npm audit fix
Had to fix breaking changes of web3 sign and web3-utils

I'm still getting fixable audit errors around jest<EMAIL_ADDRESS>& babel-jest@24.8.0). Can you update those as well?

updated

https://github.com/GoodDollar/GoodDAPP/pull/90/commits/8bbef56a007df88b738fa1525e4c0d3840da8b4a thanks!


Mesh processing interface?

I have implemented AMD's Tootle and another mesh optimizer library. They both worked similarly and took an hour or so to implement. This library look promising but the code is pretty convoluted. Is there a simple function that accepts a vertex array, indice array, and processes the mesh? I don't need to save this to a file, I just want to see how the results compare to the other libs I have tried.

Wrong repo


Add "Following" Feed Filtering/Sub Feeds

Is your feature request related to a problem? Please describe.
I often skip subscribing to users specifically to avoid having my feed getting too noisy and unmanageable.  And other times, there are channels I'd like keep track of, but may only be in the mood for their type of content on specific occasions, such as horror or creepy pasta during Halloween.
Also, if I'm just generally in the mood for a particular type of content such as news or gaming, this would, help zero in on that content without needing to be channel specific.
Describe the solution you'd like
Having the ability to categorize channels and view that subset of my subscription feed would allow me to narrow it down to the subset of related channels I'm looking for.
Example mockup:

Describe alternatives you've considered
Without a way to group channels, there's no way to accomplish this that I'm currently aware of.
Additional context
To accomplish this, there would of course need to be additional UI elements to make the categorizations and matching changes in the API.  I haven't done a deep dive on the API yet beyond just poking around after getting it running.  But I'd imagine that this would be an Odysee specific value-add stored in the postgres.  Assuming this is a feature you guys would want to incorporate, I'd make the related ticket in that repo and start there.

I like this idea, I think we had it filed somewhere on the previous repo to assist in sidebar categorization also. We can see if this would work in the preference data where we store following/notifications - not sure if other apps that use the structure would break or overwrite when they sync. That area is also going to be getting a revamp, so something like this can be taken into account.

I think the ability to create folders in the left panel (where followed channels are) would be very useful.

In this example there are music channels, software channels, news channels, crypto channels and even more. It would be useful to have an "Add folder" button at the end of the list, and then move the channels inside the created folders, so that users can expand a folder and scroll the channels inside it.


O.P.Pick — issue with multiple nested picks from a single object

🐞 Bug Report
Describe the bug
For this signature:
function pick<T extends Record<string, any>, K extends string> (obj: T, keys: F.AutoPath<T, K>[]): O.P.Pick<T, S.Split<K, '.'>>

this works:

however, adding a second key breaks the nested pick:

Reproduce the bug
// REPL or a link to your repository if applicable.
// A *self-contained* demonstration of the problem.

Is it possible to use TS Toolbelt in the typescript TS Playground? If so it's easy for me to replicate this.
Otherwise I can set up a branch on my package if you like.
Possible Solution
I'm not sure!

Yes, it works in the playground. AutoPath cannot work on arrays like this, the inference won't work. Please, set a playground up and I'll look what I can do.


How do you link the feature selector with the schema selector?

I cannot understand how I can create a selector to get the feature entities.
Trying to get them using the schemaSelectors.getEntities selector throws an error:
ERROR TypeError: Cannot read property 'entities' of undefined
at normalize.js:99
at store.js:577
at memoized (store.js:519)
at defaultStateFn (store.js:546)
at store.js:585
at memoized (store.js:519)
at store.js:545
at Array.map ()
at defaultStateFn (store.js:545)
at store.js:585
import {
  ActionReducerMap,
  createFeatureSelector
} from '@ngrx/store';
import {
  NormalizedState,
  normalized,
  createSchemaSelectors
} from 'ngrx-normalizr';
import { Section } from '../../models/section.model';
import { sectionSchema } from '../../schemas/section.schema';

export interface ReportingState extends NormalizedState {
}

export const reducers: ActionReducerMap<NormalizedState> = {
  normalized
};

export const getReportingState = createFeatureSelector<ReportingState>(
  'reporting'
);

export const getReportingSchemaSelectors = createSchemaSelectors<Section>(sectionSchema);

export const getSectionEntities = createSelector(
  fromFeature.getReportingState,
  fromFeature.getReportingSchemaSelectors.getEntities
);

I don't understand this either. Have you found a solution yet?

I was able to do it. In my application when we started we had the state without the normalizr and now we are adding features that use the normalizr.
To make the selector work I did the following.
const myFeatureSchemaSelector = createSchemaSelector(Schema);
export const featureState = createFeatureSelector(State)('yourFeatureStateName');
export const getMyFeatureStateDenormalized = createSelector(
featureState,
myFeatureSchemaSelector.getEntities
);
I hope it helps @irinelpascu @parallactic-zurich


How to save file to disk?

Here is my code:
        let document = $.message.document;
        (document) ? $.sendMessage('Greate i\'m going to convert it...') : $.sendMessage('Please send me a document...');

        if(document) {
            $.api.getFile(document.fileId).then(function(data){
                          // HOW I SAVE THIS FILE TO HARD DISK OR SOMEWHERE ELSE
            });
        }

you should probably use node's inbuilt fs

I know fs of course but how to pipe File type object in my code to fs?

hmm, yeah I investigated a bit, and I initially thought data would contain the file's data in some way... it apparently didn't. however data.file_path can be used to download the file from https://api.telegram.org/file/bot/<file_path> the file must be no larger than 20mb. see https://core.telegram.org/bots/api#getfile

Yes I know it too but I think the path it's wrong the URL sends error if you try, let's try by yourself please

Help me with this please I like this module I don't want to change it!


Adding an image watermark

Hi,
I know this project is pretty much abandoned, but I would like to know if it's possible to add an image as a watermark on all pages. I've tried adding a background image with CSS, but it doesn't seem to work. Does anybody have any ideas how to do that?

Hi @myuce , I am looking for exactly the same.
Will you let me know if you find a suitable solution to this ?

Hey, I kinda coincidentally read this. I suggest not using CSS to watermark images, the CSS can easily be removed, the watermark is pointless. Essentially you'd only be faking the watermark.
I suggest watermarking the image on the server side if possible.
Check this package out.

Is this watermark static, i.e. is it the same for all the documents you want to generate? If so, maybe you can create an empty document in Word and then use it as a template?

Is this watermark static, i.e. is it the same for all the documents you want to generate? If so, maybe you can create an empty document in Word and then use it as a template?

It's pretty much the same image that is repeated on all pages. I'm using this library on a system that generates exam papers and we add the school's logo on all papers. Currently we have to add the watermark manually. That's why I was wondering if it was possible to add an image watermark automatically.


PHOENIX-6395 Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.

Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 46s
4.x passed

+1 :green_heart:
compile
1m  6s
4.x passed

+1 :green_heart:
checkstyle
0m 33s
4.x passed

+1 :green_heart:
javadoc
0m 48s
4.x passed

+0 :ok:
spotbugs
3m 16s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 47s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
0m 32s
phoenix-core: The patch generated 9 new + 321 unchanged - 4 fixed = 330 total (was 325)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 47s
the patch passed

+1 :green_heart:
spotbugs
3m 29s
the patch passed

_ Other Tests _

-1 :x:
unit
192m 21s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
1m  1s
The patch does not generate ASF License warnings.

230m 56s

Reason
Tests

Failed junit tests
phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT

phoenix.end2end.PermissionNSEnabledIT

phoenix.end2end.PermissionsCacheIT

phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

phoenix.end2end.PermissionNSDisabledIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1152

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 909155496d5f 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 358ace8

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/testReport/

Max. process+thread count
4839 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
20m 30s
4.x passed

+1 :green_heart:
compile
1m  5s
4.x passed

+1 :green_heart:
checkstyle
0m 33s
4.x passed

+1 :green_heart:
javadoc
0m 48s
4.x passed

+0 :ok:
spotbugs
3m 20s
phoenix-core in 4.x has 957 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
11m 55s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

-1 :x:
checkstyle
0m 35s
phoenix-core: The patch generated 17 new + 313 unchanged - 12 fixed = 330 total (was 325)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 49s
the patch passed

+1 :green_heart:
spotbugs
3m 28s
the patch passed

_ Other Tests _

-1 :x:
unit
205m 12s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

253m 49s

Reason
Tests

Failed junit tests
phoenix.end2end.PermissionsCacheIT

phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

phoenix.end2end.index.PartialIndexRebuilderIT

phoenix.end2end.PermissionNSDisabledIT

phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT

phoenix.end2end.PermissionNSEnabledIT

phoenix.end2end.AuditLoggingIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1152

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 8c679e5fca3b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / dd9b8af

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/testReport/

Max. process+thread count
4716 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
20m  7s
4.x passed

+1 :green_heart:
compile
1m  5s
4.x passed

+1 :green_heart:
checkstyle
0m 59s
4.x passed

+1 :green_heart:
javadoc
0m 48s
4.x passed

+0 :ok:
spotbugs
3m 21s
phoenix-core in 4.x has 958 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
11m 37s
the patch passed

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

-1 :x:
checkstyle
0m 59s
phoenix-core: The patch generated 15 new + 130 unchanged - 9 fixed = 145 total (was 139)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 46s
the patch passed

+1 :green_heart:
spotbugs
3m 27s
the patch passed

_ Other Tests _

-1 :x:
unit
195m 54s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 41s
The patch does not generate ASF License warnings.

244m 43s

Reason
Tests

Failed junit tests
phoenix.end2end.PermissionsCacheIT

phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

phoenix.end2end.index.PartialIndexRebuilderIT

phoenix.end2end.PermissionNSDisabledIT

phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT

phoenix.end2end.PermissionNSEnabledIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1152

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux f56f53f6fd45 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 9dc5e2e

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/testReport/

Max. process+thread count
4718 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Closing as 4.x has been EOLed


Feature request - assist the user which lines he can select for review comments/suggestions

When I select lines to comment or make a suggestion for, I sometimes get errors because the selection was too big. GH only allows to select lines somehow relative to changed hunks. For the user this is not obvious to see and know what he can select and what not. It would be cool if we could figure out an approach how to assist the user here. But I don't know if such information is actually available.
If it should be possible to somehow get this information which lines are selectable, my proposal would be to add a sign into the sign column for these lines. Something super simple like a bar in the color of the change (added, changed, ...).

Implemented in #6ee8741


tabzilla broken, shows as unformatted text

When I visit platform-status.mozilla.org, I see the tabzilla as an unformatted piece of text.

On first look, the tabzilla CSS doesn't seem to be included in the build output.

Maybe caused by postcss update #294

could be related to fe4930189f7f05044c0b170bb21111174614597c ?

On first look, the tabzilla CSS doesn't seem to be included in the build output.

If that's the case, this would have been caught by the test we removed in 84d9b9deb9d1916b7c1f0996ff6f36309788b96d
I'm morphing #291 to track us re-adding a less burdensome version of that test


Missing regression tests

Still missing regression test files:

test_attachements.scad
test_beziers.scad
test_bosl1_compat.scad
test_bottlecasp.scad
test_constants.scad (?)
test_distributors.scad
test_hingesnaps.scad
test_involute_gears.scad
test_joiners.scad
test_knurling.scad
test_masks.scad
test_metric_screws.scad
test_nema_steppers.scad
test_partitions.scad
test_paths.scad
test_phillips_drive.scad
test_regions.scad
test_rounding.scad
test_screws.scad
test_sliders.scad
test_threading.scad
test_torx_drive.scad
test_triangulation.scad
test_walls.scad
test_wiring.scad

The regression tests:

hull.scad
polyhedra.scad

should be called

test_hull.scad
test_polyhedra.scad

This is redundant with issue #102. The issue is a long task, in progress.

My intention is to have a picture of what has to be done. As soon as a test file is created, I would edit the above list. Another suggestion is to begin each test file with the test calls in the order the functions are defined in the main file so that it would be easier to check if all function has been checked. I know it is a long task.

Makes sense. You can edit your list comment, and use the markup [ ] and [x] to get clickable/checkable checkboxes, so we can check them off as they are done.  The percentage checked will also be shown in the project level.
- [ ] Unchecked
- [x] Checked

[ ] Unchecked
[x] Checked

Note that hull.scad and polyhedra.scad aren't regression tests, but more like demos.  I wrote test_hull.scad.   Since we don't have a way of doing regression tests for modules, also I think many of those files aren't testable.

Makes sense. You can edit your list comment, and use the markup [ ] and [x] to get clickable/checkable checkboxes, so we can check them off as they are done. The percentage checked will also be shown in the project level.

There is another issue: how complete is each test. I am working on geometry.scad and found that around 40% of the functions have no test in the test_geometry,scad.

We have a script, scripts/func_coverage.py that lists all public functions that have no regression tests, by file. It would be possible to make PR submissions annotate themselves with that.

Current output of func_coverage.py:
WARNING!!! Function count_true re-defined at math.scad:1011
           Previously defined at math.scad:1001
WARNING!!! Function poly_mult re-defined at math.scad:1237
           Previously defined at math.scad:1220
WARNING!!! Function sortidx re-defined at arrays.scad:860
           Previously defined at arrays.scad:838
NOT COVERED:
  quaternions.scad: 1 uncovered functions
    Q_is_quat
  common.scad: 1 uncovered functions
    is_finite
  wiring.scad: 2 uncovered functions
    hex_offset_ring
    hex_offsets
  hull.scad: 2 uncovered functions
    hull2d_path
    hull3d_faces
  screws.scad: 2 uncovered functions
    screw_info
    thread_specification
  edges.scad: 3 uncovered functions
    corners
    is_corner_array
    normalize_corners
  polyhedra.scad: 3 uncovered functions
    regular_polyhedron_info
    stellate_faces
    trapezohedron
  skin.scad: 5 uncovered functions
    associate_vertices
    path_sweep
    slice_profiles
    subdivide_and_slice
    sweep
  torx_drive.scad: 5 uncovered functions
    torx_depth
    torx_inner_diam
    torx_outer_diam
    torx_rounding_radius
    torx_tip_radius
  nema_steppers.scad: 6 uncovered functions
    nema_motor_plinth_diam
    nema_motor_plinth_height
    nema_motor_screw_depth
    nema_motor_screw_size
    nema_motor_screw_spacing
    nema_motor_width
  vnf.scad: 6 uncovered functions
    vnf_bend
    vnf_centroid
    vnf_compact
    vnf_quantize
    vnf_validate
    vnf_volume
  triangulation.scad: 7 uncovered functions
    face_normal
    find_convex_vertex
    is_only_noncolinear_vertex
    normalize_vertex_perimeter
    point_in_ear
    triangulate_face
    triangulate_faces
  attachments.scad: 8 uncovered functions
    anchorpt
    attach_geom
    attach_geom_2d
    attach_geom_size
    attach_transform
    attachment_is_shown
    find_anchor
    reorient
  involute_gears.scad: 12 uncovered functions
    adendum
    base_radius
    bevel_pitch_angle
    circular_pitch
    dedendum
    diametral_pitch
    gear2d
    gear_tooth_profile
    module_value
    outer_radius
    pitch_radius
    root_radius
  metric_screws.scad: 12 uncovered functions
    get_metric_bolt_head_height
    get_metric_bolt_head_size
    get_metric_iso_coarse_thread_pitch
    get_metric_iso_fine_thread_pitch
    get_metric_iso_superfine_thread_pitch
    get_metric_jis_thread_pitch
    get_metric_nut_size
    get_metric_nut_thickness
    get_metric_socket_cap_diam
    get_metric_socket_cap_height
    get_metric_socket_cap_socket_depth
    get_metric_socket_cap_socket_size
  regions.scad: 14 uncovered functions
    check_and_fix_path
    cleanup_region
    close_region
    difference
    exclusive_or
    intersection
    linear_sweep
    offset
    point_in_region
    region_faces
    region_path_crossings
    split_nested_region
    split_path_at_region_crossings
    union
  rounding.scad: 15 uncovered functions
    angle_between_lines
    bezier_patch_degenerate
    offset_stroke
    os_chamfer
    os_circle
    os_flat
    os_pointed
    os_profile
    os_round
    os_smooth
    os_teardrop
    round_corners
    rounded_prism
    smooth_path
    vnf_tri_array
  paths.scad: 23 uncovered functions
    assemble_a_path_from_fragments
    assemble_path_fragments
    decompose_path
    path3d_spiral
    path_closest_point
    path_curvature
    path_cut
    path_length
    path_length_fractions
    path_normals
    path_pos_from_end
    path_pos_from_start
    path_segment_lengths
    path_self_intersections
    path_subselect
    path_tangents
    path_torsion
    path_trim_end
    path_trim_start
    points_along_path3d
    resample_path
    split_path_at_self_crossings
    subdivide_path
  geometry.scad: 25 uncovered functions
    align_polygon
    circle_circle_tangents
    closest_point_on_plane
    line_ray_intersection
    plane_from_normal
    plane_from_polygon
    plane_intersection
    plane_line_angle
    plane_line_intersection
    plane_offset
    plane_point_nearest_origin
    plane_transform
    point_left_of_segment2d
    points_are_collinear
    points_are_coplanar
    polygon_is_convex
    polygon_line_intersection
    polygon_normal
    ray_closest_point
    ray_intersection
    ray_segment_intersection
    reindex_polygon
    split_polygons_at_each_x
    split_polygons_at_each_y
    split_polygons_at_each_z
  beziers.scad: 25 uncovered functions
    bezier_close_to_axis
    bezier_curvature
    bezier_curve
    bezier_derivative
    bezier_offset
    bezier_patch
    bezier_patch_flat
    bezier_patch_points
    bezier_path_closest_point
    bezier_path_length
    bezier_path_point
    bezier_points
    bezier_polyline
    bezier_segment_closest_point
    bezier_segment_length
    bezier_surface
    bezier_tangent
    bezier_triangle_point
    fillet3pts
    fillet_path
    is_patch
    is_rectpatch
    is_tripatch
    patch_reverse
    path_to_bezier
Total coverage: 401 of 578 functions (69.38%)

Another issue regarding the regression tests is to assure all arg options are considered in the tests of a function. For instance, test_find_circle_2tangents() in test_geometry.scad miss any test with with arg tangent=true.

I think this is part of the broader problem of whether tests cover all cases.  I am dubious that we can automate assessment of whether regression tests are complete.  It's something we just have to check by hand.  When I was adding requested regression tests to test_math I noticed several other regression tests that missed edge cases...and I actually found some bugs when I added the missing edge cases.

 You can edit your list comment, and use the markup [ ] and [x] to get clickable/checkable checkboxes, so we can check them off as they are done. The percentage checked will also be shown in the project level.
- [ ] Unchecked
- [x] Checked

[ ]  Unchecked
[x]  Checked

Done

Note that hull should actually be fully covered because the main hull calls hull2d and hull3d depending on the dimension of the input.  Should we write dummy tests?  Recopy the tests?


Android : No Audits logged for success and failure cases of wallet binding.

Describe the bug
No Audit for successful attempt of "Activation of VC"
No Audit for failure attempt of wallet binding
To Reproduce
Prerequisite : Download VC and store in app
For successful attempt:

Unlock the app
click on Add ID
Enter VID
click on Generate ID
Click on on the link "Activation pending for online login " on the card.
Click on Activate button.
Click on "Yes I confirm"
Enter Otp which is prompted
--- VC will be activated for online login

Current behavior
VC activated for successful login but no history captured in history Tab
Expected behavior
As per the story https://github.com/mosip/inji/issues/278
Enabling verification for a VC should be captured in the audit/history
Success scenario message -> 'Verification was enabled for<PHONE_NUMBER>'
Failure scenario message -> 'Enabling verification for<PHONE_NUMBER> failed'
Screenshots
https://user-images.githubusercontent.com/102220709/219331289-1be13591-02f0-499c-800c-16ef11aade56.mp4
Smartphone (please complete the following information):
Device: Redmi 7A
OS: 10
Inji app version: https://github.com/mosip/inji/actions/runs/4123991786
MOSIP Version: <IP_ADDRESS>
MOSIP server: qa-1201-b2.mosip.net
BLE : 4.2
Commit ID  in app:

Additional context
Failure case : Json Parse error which was caused due to pod down
https://github.com/mosip/inji/issues/452

Verified this issue in qa-1201-b2 environment, now we get activate or failure message of wallet binding in audit log. I attached the video for reference. hence closing the Bug.
Video:
Uploading Untitled (4).mp4…

Tested in: -
Device: Vivo Y73
Android Version: 12
BLE version: 5.0
Inji app link: https: https://github.com/mosip/inji/actions/runs/4447486079
Mimoto version: <IP_ADDRESS>
MOSIP Version: qa-1201-b2.mosip.net


Cannot cast to display, receive SocketClient object has no attribute isAlive

OS: HomEassistant OS core-2021.12.8 (Supervised)
Ptyhon: 3.9.7
OS 5.10.88
Installed on HomeAssistant using SSH with the command:  python3 -m pip install catt==0.11.3 there were dependencies I couldn't address with HomeAssistant to get to the latest.
Trying to run : catt -d "Kitchen Display" cast_site http://<IP_ADDRESS>:8123/lovelace/security
Receive error: Attribute Error: 'SocketClient' object has no attribute 'isAlive'.
I have rebooted the server to try and resolve with no success. Searching doesn't come up with much, so open to any suggestions. Please let me know if there is any additional information I can provide as well.

This sounds like an issue with the dependencies, can you try with pipx or in a virtualenv?

I did a pip uninstall catt, and then did a pipx install catt. This failed.
Pip failed to build package: pycryptodomomex.
error: command 'gcc' failed: No such file or directory.
I then tried to install gcc, to find that no matching distro found for gcc.
Seems the HomeAssitstant OS doesn't support gcc at least with a pipx install?
Thanks!

That might be your issue, try installing build-essential and see if that fixes it. Unfortunately, non-standard OSes are not supported.


branch.io not passing details after clicking link and installing app

Hey @ethanneff, I'm having the same issue, when I open the link (in Safari) and I install the app, sometimes the Deep Link doesn't work at all, this is what the logs looks like at that moment:
BNCNetworkService.m(219) Debug: Network finish operation https://api.branch.io/v1/install 0.639s. Status 200 error (null).
{"session_id":"516029442108308059","identity_id":"516029442087709188","link":"https://mel2.test-app.link?%24identity_id=516029442087709188","data":"{\"+clicked_branch_link\":false,\"+is_first_session\":true}","device_fingerprint_id":"516029441995093675"}.
2018-04-20 19:07:13.041211-0500 New Stand[31130:4815900] [branch.io] BNCServerInterface.m(771) Debug: Server returned: Status: 200; Data: {
    data = "{\"+clicked_branch_link\":false,\"+is_first_session\":true}";
    "device_fingerprint_id" =<PHONE_NUMBER>95093675;
    "identity_id" =<PHONE_NUMBER>87709188;
    link = "https://mel2.test-app.link?%24identity_id=516029442087709188";
    "session_id" =<PHONE_NUMBER>08308059;

It's weird because sometimes it works, this is so frustrating.
This is the same log, it says install but I'm not sure what those it means because my app couldn't read that:

I'm using the branch-cordova-sdk (v2.6.24).

"+is_first_session":true is an install.
"+is_first_session":false is an open.
Can you elaborate on the issue? I'm not too sure what the problem is. Thanks,


Revert "update packages"

Reverts flutter/flutter#68569
Broke several tests with compilation errors due to url_launcher. TBR @dnfield

LGTM or whatever

2020-10-20T08:39:04.595944: stderr: [ +960 ms] /Users/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_web-0.1.4+1/lib/url_launcher_web.dart:22:7: Error: The non-abstract class 'UrlLauncherPlugin' is missing implementations for these members:
stderr: [   +3 ms]  - UrlLauncherPlatform.linkDelegate
2020-10-20T08:39:04.597064: stderr: [        ] Try to either
stderr: [        ]  - provide an implementation,
stderr: [        ]  - inherit an implementation from a superclass or mixin,
stderr: [        ]  - mark the class as abstract, or
stderr: [        ]  - provide a 'noSuchMethod' implementation.
2020-10-20T08:39:04.598055: stderr: [        ] class UrlLauncherPlugin extends UrlLauncherPlatform {
stderr: [        ]       ^^^^^^^^^^^^^^^^^
stderr: [        ] /Users/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_platform_interface-1.0.9/lib/url_launcher_platform_interface.dart:43:20: Context: 'UrlLauncherPlatform.linkDelegate' is defined here.
2020-10-20T08:39:04.598385: stderr: [        ]   LinkDelegate get linkDelegate;
stderr: [        ]                    ^^^^^^^^^^^^
2020-10-20T08:39:29.296377: stdout: [+24696 ms] Syncing files to device Web Server... (completed in 27.4s)
2020-10-20T08:39:29.297128: stdout: [   +1 ms] Synced 0.0MB.
2020-10-20T08:39:29.297719: stderr: [        ] Failed to compile application.
2020-10-20T08:39:29.302169: stdout: [   +4 ms] "flutter run" took 30,049ms.
2020-10-20T08:39:29.307892: stderr: [   +5 ms]
stderr:            #0      throwToolExit (package:flutter_tools/src/base/common.dart:14:3)

Sorry, logs took a while

/cc @mdebbar added a linkDelegate recently; he might not have had time to publish all the packages he's worked on.

Closing the loop here: Mouad published the fix for this one. Apologies for the breakage! /cc @dnfield @jonahwilliams


Max retries exceeded with url /api/v1/ping

Hi guys, today i got this error:

File "/Library/Python/2.7/site-packages/binance/client.py", line 94, in init
self.ping()
File "/Library/Python/2.7/site-packages/binance/client.py", line 362, in ping
return self._get('ping')
File "/Library/Python/2.7/site-packages/binance/client.py", line 206, in _get
return self._request_api('get', path, signed, version, **kwargs)
File "/Library/Python/2.7/site-packages/binance/client.py", line 180, in _request_api
return self._request(method, uri, signed, **kwargs)
File "/Library/Python/2.7/site-packages/binance/client.py", line 174, in _request
response = getattr(self.session, method)(uri, **kwargs)
File "/Library/Python/2.7/site-packages/requests/sessions.py", line 521, in get
return self.request('GET', url, **kwargs)
File "/Library/Python/2.7/site-packages/requests/sessions.py", line 508, in request
resp = self.send(prep, **send_kwargs)
File "/Library/Python/2.7/site-packages/requests/sessions.py", line 618, in send
r = adapter.send(request, **kwargs)
File "/Library/Python/2.7/site-packages/requests/adapters.py", line 506, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='api.binance.com', port=443): Max retries exceeded with url: /api/v1/ping (Caused by SSLError(SSLError(1, u'[SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:590)'),))

Any thoughts? Thank you.

@dash61 thanks, solved
Also solved with a fresh installation of binance-python on a virtualenv

Hello,
I wrote the code below
"klines = client.get_historical_klines(ccy, Client.KLINE_INTERVAL_1MINUTE, "30 min ago UTC")"
I run the code every five seconds on binance.
My system Python 3.6, I use Jupyter notebook and I have windows 10.
The code runs for a few hours and then I have the following message:
ConnectionError: HTTPSConnectionPool(host='api.binance.com', port=443): Max retries exceeded with url: /api/v1/klines?interval=1m&limit=1&startTime=0&symbol=BTCUSDT (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x000001D3ECBBF0F0>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed',))
Is there anyone who saw the same issue?
Many thanks,
Pascal

@scalpounet that's a network connection error, not an error due to python-binance. If it happened every time you tried to get new data, it would likely be a setup issue somewhere, but if it runs OK most of the time for you, it's more likely just an internet connection issue. This could be on your side or on Binance's side, but most likely somewhere between you and your ISP.
Do you have intermittent connection issues on your normal internet connection (or home Wi-Fi)? Do you have the same issue if you run the code from a different internet connection (work/school/coffee shop/etc?)

Hi anson-vandoren,
Thank you very much for your quick answer. It might effectively be my ISP as sometimes there are intermittent interruptions. It happened twice in the last two days and I started to run this code over the last two days. I will give time and see how it goes. I thought it was an error due to python-binance because "Max retries exceeded with url..." but I am a beginner in coding so I had it wrong.
I have not tried on another network so far as I run the code at home the whole day.
Let's see how it goes and thank you very much for your help. I consider this issue closed.
Happy New Year!

@scalpounet I faced the same problem. I has tried many times but always get the ConnectionTimeoutError as below:
ConnectTimeoutError(<urllib3.connection.VerifiedHTTPSConnection object at 0x10fcc2438>, 'Connection to api.binance.com timed out. (connect timeout=10)'))

My env info:
python-binance          0.7.1
Python 3.6.3

Does anyone have a solution for this issue?

Install pyopenssl (pip install pyopenssl) and if possible try to put small delay in code .


Dual Channel LoRaWAN gateway?

Is it possible to extend the library to support Dual Channel LoRaWAN gateway?
Inspired from https://forum.chirpstack.io/t/dragino-lg01-n-no-live-lorawan-frames/11377/6
If we have an ESP32 board with 2 SX127x modules and we can support 2 LoRaWAN channels, then we could use most of the LoRaWAN functionalities.
Most LoRaWAN frequency plans only require a minimum of 2 frequencies for OTAA....
Any idea?
Thanks a lot.

I'm working in something similar, maybe we can help each other. I'm intested in add a new channel in the lora-gateway-esp32, but I'm not sure if this is more easy add channel for uplink or downlink?

Stuck with daily work.
May be easier to try with two single gateway instead?
Each gateway to listen for a frequency.

I have the first example for a gateway with two channel for uplink based on ESP32

I have the first example for a gateway with two channel for uplink based on ESP32

Would you mind sharing it?
I will be back to this issue soon end of Sep.
Thanks millions.

I have the first example for a gateway with two channel for uplink based on ESP32

Would you mind sharing it? I will be back to this issue soon end of Sep.
Thanks millions.

Hello
Sure, I was uploading the files, maybe you can check the code. For until now the gateway work without system errors for long time. https://github.com/Zupayruna1/update_LoraWan_gateway_ESP32
Best regards!

Great. Thanks a lot.
Let me try.


Feature request: Optimisation switches

It would really nice to be able to change the miners optimisation setting which as far as I know is POWER_MODE in the API.
Idea is to use low when on grid power and high when there's enough solar.
I can try implement but worth a discussion first.

implemented in #18

Since #18 is merged, I'll close this issue


More empire/empire to just empire.

Now that /relay is gone,  we can more empire/ to the root of the repository.

:+1:

Hooray


Fix update after delete errors in reconciler.

This bug fixes Status updates after object deletion due to the removal
of the finalizer. As soon as the finalizer is removed the object will be
deleted from the kube-apiserver and the status update call fails on
Precondition failed: UID in precondition error.
Note that the Addon is not waiting for all resources to be gone, which
is the default for kubernetes. If clients want to ensure all child
objects are garbage collected and removed, they can use foregroundDeletion.
https://kubernetes.io/docs/concepts/architecture/garbage-collection/#foreground-deletion
Signed-off-by: Nico Schieder<EMAIL_ADDRESS>

/lgtm


Fixing ZDCChat/ZDCChat.h not found, by adding FRAMEWORK_SEARCH_PATHS.…

… taskrabbit/react-native-zendesk-chat#21

@taskrabbit
Let me know if there are other things that needs to be done for this to be merged

Please merge this :)

lol, 1 year later...

Hey I have tried adding the framework paths and yet I get this error. Tried making changes in project.pbxproj of my RNZendesk library yet i get the same error. Any other thing that i need to add?


Issue 510

@peterLaurence not a huge rush on this one, I still need to get #511 done, and you're welcome to wait on this one (510) until 511 is up as well (or you can do this one now that's more convenient for you - your call).
TBH I'm not 100% sure what solved this, I just kept trying things, and TBF the remote version on an emulator is very very slow, but on a real device it's pretty snappy and I can't get it to ever miss a tile.  I'm inclined to close, despite funky emulator behavior sometimes (it's always slow, but only very rarely misses tiles).

Ok, will try that tomorrow.

Thanks!  Working on save/restore as we speak...
On Mon, May 20, 2019 at 4:22 PM peterLaurence<EMAIL_ADDRESS>wrote:

Ok, will try that tomorrow.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/moagrius/TileView/pull/521?email_source=notifications&email_token=AAFLHIHINBTHL76P2PZNUATPWMJALA5CNFSM4HOE6KKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV2DPOQ#issuecomment-494155706,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFLHIAMXTWCV5DE7JMF72LPWMJALANCNFSM4HOE6KKA
.

So my testing didn't reveal any gaps. But it doesn't really mean it won't happen in some scenario.
We know it happened (rarely) in v2.
Looking at your changes, I can see that you introduced a retry (a single one). The probably of having a tile decoding failing twice in a row is very low, but I'm wondering if we should set a limit to retries.
Also, before attempting a another tile decoding, should we check if the tile is still visible in the viewport?

So my testing didn't reveal any gaps. But it doesn't really mean it won't happen in some scenario.
We know it happened (rarely) in v2.

That's a very good point and I don't want to pretend that it's perfect, but I never get gaps in a real device.  I think I've seen a couple missing pieces on an emulator.  It might be worth trying that whole "unfilled area" thing again...  I'm not sure if the Tile thinks it's decoded but isn't rendering, or the bitmap is null, or that it knows it's not decoded.  Once I get the hot issues out of the way, I'll spend some time doing deep investigation on this (like hotspots over every tile so I can tap and check the state - but that's a pretty heavy lift).

I'm wondering if we should set a limit to retries.

so pass an int indicating the number of times it should retry?

Also, before attempting a another tile decoding, should we check if the tile is still visible in the viewport?

That's a very good idea, I'll include that.

so pass an int indicating the number of times it should retry?

I was thinking of removing the limit of retries, provided the tile is still in the viewport. But it's just a suggestion.

Gotcha.  I think we need some kind of limit in case of missing files or 404s, which would create an infinite loop

You're right. I had more in mind tiles from assets or sd card.

So yeah maybe we let them pass in a limit?

With a default of 1 or 2, yes passing a limit could be interesting.

will do

so i'm going to make the updates and merge and don't think i need you to re-review.  i have a nutty weekend so it'll probably be early next week.  if you could check out #511 and see if you agree that works as a temporary workaround, i'd love to merge that into this, before merging this into master.  if not, it's not the end of the world.
fwiw, just in case, i had the tiles stored in google cloud but under my work email, which was linked to my employers account.  i deleted that project and am re-uploading to a persona email, but the urls for the remote demo may fail in the branch.  you probably wouldn't even have noticed, but i figured worth a mention.
thanks as always

Ok omw to test it.


Show related words in popup but not in quiz

This is blocked by #153

Please add your planning poker estimate with ZenHub @Fattimo

identical to #161 ?


[v1.3] UGDG updates

Included share command in UGDG

Pull Request Test Coverage Report for Build 208

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.027%

Totals

Change from base Build 206:
0.0%

Covered Lines:
2043

Relevant Lines:
2220

💛  - Coveralls


Add EnergyDistanceEvaluator

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a197038) to head (fcb889d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #518   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          123       124    +1
  Lines         3397      3425   +28
  Branches       181       181
=========================================
+ Hits          3397      3425   +28

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Parametrized tests

Any chance to see parametrized tests/sections? I don't think I need to elaborate on how useful this would be. Right now the best way I've found to emulate it is to extract the body of the test into a macro, eg:

#define CharacterCanBePushedBy(identity) {\
    SECTION( #identity " character should be able to push the character"){\
            AddPushableCharacter(10, 9); \
            CCharacter* character = RoomBuilder::AddVisibleCharacter(10, 8, S, identity); \
            RoomBuilder::AddCommand(character, CCharacterCommand::CC_VarSet, ScriptVars::P_MONSTER_WEAPON, ScriptVars::Assign, WT_Off); \
            RoomBuilder::AddCommand(character, CCharacterCommand::CC_MoveRel, 0, 1); \
            CCurrentGame* game = Runner::StartGame(10, 15, N); \
            Runner::ExecuteCommand(CMD_WAIT); \
            REQUIRE(game->pRoom->GetMonsterAtSquare(10, 10)); \
            REQUIRE(game->pRoom->GetMonsterAtSquare(10, 10)->wType == M_CHARACTER); \
        }\
    }

    CharacterCanBePushedBy(M_DECOY);
    CharacterCanBePushedBy(M_MIMIC);
    [snipped out 22 lines]
    CharacterCanBePushedBy(M_TARTECHNICIAN);
    CharacterCanBePushedBy(M_CONSTRUCT);

#undef CharacterCanBePushedBy

This works but leaves a lot to be desired - stepping doesn't work correctly when debgguing (it just keeps showing me the macro call) and it isn't as readable.

FWIW, I use a simple list of structs with test cases to do something similiar currently:
TEST_CASE("Invalid incoming CAN packets", "[horch2can][invalid]")
{
    CANProto::Packet packet;
    memset(&packet, 0x00, sizeof(packet));
    int ret;

    using namespace CANProto;
    using namespace CANProto::Horch;

    typedef struct {
        const char* name;
        const char* buf;
        ErrorCode::ErrorCode error;
    } Test;

    Test tests[] = {
        // Completely invalid packets
        {"Empty buffer",
         "", ErrorCode::partialData},
        {"Hello World",
         "Hello World! I'm not a CAN packet.\n", ErrorCode::unexpectedChar},
        {"Some structure",
         "/:::\n", ErrorCode::unexpectedChar},
        {"non-ascii garbage",
         "\a\b\t\v\f\r\xff\xfe\n", ErrorCode::unexpectedChar},
        {"Only a timestamp with newline",
         "1234567890\n", ErrorCode::unexpectedNewline},

        // [...]
        // Sentinel value
        {"", "", ErrorCode::success}
    };

    int len;
    int expected_consumed;

    for (int i = 0; tests[i].name != ""; i++) {
        Test test = tests[i];
        len = strlen(test.buf);
        if (test.error == ErrorCode::partialData) {
            expected_consumed = 0;
        } else {
            expected_consumed = len;
        }
        SECTION(test.name) {
            ret = horch2can(test.buf, len, &packet);
            INFO("error: " << CANProto::ErrorCode::toString(packet.error));
            INFO("expected: " << CANProto::ErrorCode::toString(test.error));
            CHECK_FALSE(packet.valid);
            CHECK(packet.error == test.error);
            CHECK(ret == expected_consumed);
        }
    }
}

(note: I'm not very experienced with C++, so there might be things which are odd here - but you get the idea)

I have a version of Generators "working: with sections on a local branch. It's not fully formed - and it's not fully tested. It's something I need to spend time getting right. I am ticking it over, though (after leaving it for a couple of years!).

@philsquared Error starting at line 1: quote waiting to be paired-up ;)

I'm using sth like this: https://gist.github.com/thechristopher/8eaa6dad18c5cfefba32

I'm closing this issue in favour of a dedicated generators/ property based testing ticket, #850.
Be sure to watch that issue for notifications if you're interested,


Alias for latest dxvk release?

Some projects like winetricks can benefit from linking to a fixed URL that always points to the latest release of dxvk, to avoid constantly bumping the version in their code. Is there any way to do it?
This suggests that it can be https://github.com/doitsujin/dxvk/releases/latest but it doesn't seem to do anything.

https://api.github.com/repos/doitsujin/dxvk/releases/latest also produces:
{
  "message": "Not Found",
  "documentation_url": "https://developer.github.com/v3/repos/releases/#get-the-latest-release"
}

I'm not aware of any way to do this on github.
There might be some workarounds like adding a text file to the repo containing a URL pointing to the latest release or something, but that's kind of cumbersome.

You could create a tagged release called latest. Then edit the tag to update the binaries each release if you want.

You can also use Github "pages" and simply create some fixed link that always points to the latest release.

Editing tags is bad practice, afaik..

@austin987 : May be winetrick can simply calculate the latest tag? It can use git for that.

@shmerl, that would require checking it the git repo, currently we just download the binaries.
Brainstorming: Do you have a release script? The script could provide a stable URL when publishing a release.

There could be a file named RELEASE or VERSION, containing the latest version number/release, and the url can be deduced with just that (I do this for the dxvk-bin PKGBUILD).

Looks like the links pointing to the raw repository files are stable (such as https://raw.githubusercontent.com/doitsujin/dxvk/master/README.md) so i guess that's actually an option.

@doitsujin works for me, thanks. For reference, it's at https://github.com/Winetricks/winetricks/commit/c423a85b3cfda1e6181fc8164b089842964a0794

Great, thanks for reporting back.


Feature: Allow User to control their VM

Summary
This feature introduces new capabilities for users to manage their virtual machines (VMs) directly. The following functionalities are included:

Notify instances
Stop VMs
Reboot VMs
Erase VMs
Expire VMs
Get Logs

Can you add tests on the new code ?

Isn't this whole PR missing any form of documentation '-'?

there are still some possible amelioration on the test and doc but these can be done in a separate PR

Have you open a clickup ticket for that?

@Psycojoker https://app.clickup.com/24395970/v/l/6-901502681758-1


Rename /e2e to /integration

Ref: https://issues.redhat.com/browse/MTSRE-86
Signed-off-by: Nico Schieder<EMAIL_ADDRESS>

/retest
OpenShift CI internal failure on teardown - code runs green! :)

/retest

/hold
will revisit this after #40

Also waiting on #40 to stamp.

/retest

/lgtm

/unhold


Added Sawtooth waveform generator to DAC, and refactored COMP

Please review and provide any suggestions.
DAC Sawtooth generation was added to the DAC module, as well as a standalone example app that works on a Nucleo G474RE board. I have also tested with HRTIM as the set/reset event sources.
I refactored the comparator module to use PAC accessors rather than direct bit manipulation and generics using CxCSR type aliases, but it would have some breaking API changes and is targeting G474 with 7 comparators.

Great stuff! Love the additions for DAC and COMP/G4, and the refactor.


LISPER program: long-lived lisper branch

@capr The intention of this PR is to register the lisper branch while we are still working on preparing it for merge upstream, right?
In that case I think you want to create a new topic-branch on top of master and cherry-pick the branch registration onto that (i.e. commit cc0f867). That way we can merge the branch registration right away and continue working out the upstreaming of the branch itself.

Ok i get it now. Coming up.


Broker should recover from panics and not get into a crash loop

Feature:

As outlined in the following Bug issue https://github.com/openshift/ansible-service-broker/issues/612 it is possible for a Job to panic which causes the broker to crash. The broker pod is restarted however if the Job that caused the crash is in a pending state, the broker attempts to recover and restart the Job. This creates the potential for the broker to go into a crash loop where the Job continues to panic and the broker continues to crash.
We should probably have some mechanism to guard against this situation.
One way to do this would be to have a recover function which is a builtin function in go to recover a panicking go routine:
More info https://blog.golang.org/defer-panic-and-recover
Although this would stop the broker from crashing, exiting quickly when the broker enters an unexpected state (ie a panic) can be a nice way to recover from a crash as it forces a restart of the process from scratch. A drawback here is the broker would be unavailable until it the pod was restarted (unless there were more than 1 replica).
As we attempt to recover Jobs that are in a "in progress" state when the broker starts, we may also want a mechanism to discard / delete a job if it appears during recovery more than a configured number of times. This could potentially be achieved with a field on the JobState that is set and persisted before a job recovery is attempted.
Interested to know others thoughts.

requires proposal

/close


Allow sending isTyping events to other slack channels

Related: https://github.com/nlopes/slack/blob/0afac90b917f77d7c59d638420d5d40fe65eee61/websocket_misc.go#L51-L56
While this would show the "bot" typing, I could be an indicator to show whether a reply might be expected soon.

Use case here is when using the Google Translation feature (upcoming) to translate between channels. Would be great to know when someone is writing back. That's one of the only parts that doesn't feel seamless about the experience :)

Fixed in #559


QRCoder 1.3.6 on NuGet does not have strong name (signed)

Our app(s) have strong name and then all assemblies used must have strong name signature.
Can you add this?

I got around it by using https://www.nuget.org/packages/Brutal.Dev.StrongNameSigner/ and signing with a .snk I generated myself (strong name key). Would be nice to not have to do this for new versions:-)
To sign it on your end I think you generate your own .snk file that you specify during compilation. I think this .snk file should not be public.

You can see the author reply at this link: https://github.com/codebude/QRCoder/issues?q=is%3Aissue+is%3Aclosed+signed


Copy icon does not work on Safari

Copying to clipboard results in error - "could not access clipboard"
CC: @radical

Duplicate - closed this one


API SSL - how to config?

API SSL - how to config?
"api":{
    "enable": true,
    "ssl":true.
    "sslKey":"path..",

    "listenAddress: "<IP_ADDRESS>",

}
any guide how set SSL to API?

I got help in discord channel,
to fix ssl for api you need to  reverse proxy in apache conf file.


Improve Hubble Relay Kubernetes Readiness/Liveness check

Please ensure your pull request adheres to the following guidelines:

[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.

This commit improves the exiting Hubble Relay Readiness and liveness checks by using the gRPC Health Checking Protocol.
To do that we add the grpc_health_probe binary to the hubble relay container image and use exec probes. We can't use the built-in gRPC health checking as it doesn't yet support TLS and because we still support k8s versions before v1.23.
We also update the the existing gRPC health server to check connectivity to the peer service and hubble backends. The health server is only  serving, if the peer service and at least one hubble observe service is available.
This PR also contains a relatively unrelated fix for graceful shutdown of hubble relay. It simplified the tests, but I can also split it into two PRs if requested
closes #23542

/test

/test

/test

This PR will be ready-to-merge once all conversations are resolved. @glrf, can you take care of that? Then I'll click the big green button.

@glrf could you please rebase? The PR picked up some conflicts :/.

/test

Hi @glrf, PR https://github.com/cilium/cilium/pull/29111 is hitting some CI issues with hubble-relay starting up (link), do you think that this could be somehow related to this change? I haven't done much investigation, but I just noticed that this change went in recently and the other PR is hitting issues with hubble-relay. I don't know if this PR is related or not.


Adding requirements files and gcl code

Adding requirements files where requirements were manually being installed in cells
Adding gcl import and init lines in notebooks
Adding the GCL dataset to settings.yaml
Adding env vars and scripts for getting them
Some cleanup of notebooks

Closing as we will move to Graphcore HF repo


Add cumulative biosphere flows from static or cutoff nodes

Maybe need to add filter so we don't get overwhelmed with too many different flows

We won't do this explicitly, but are adding the attributes direct_emissions_score_outside_specific_flows and remaining_cumulative_score_outside_specific_flows to the Node class.


Add check for IPFIX install

Add check for downloading IPFIXcol repository. Now cannot be downloaded when provisioned for the second time.

solved in 1ff75cc


Use correct shape for obsm/varm layers in anndata export

Overview
This addresses a bug in the ExperimentAxisQuery anndata exporter that is specific to obsm/varm arrays.
Details
Currently, the number of columns needed for the resulting numpy array is taken from the SparseNDArray's shape property, which provides the maximum capacity of the underlying TileDB array, rather than the occupied capacity. This results in the exporter allocating a far larger numpy ndarray than necessary when obsm/varm layers are included in the output.
This issue is specific to obsm/varm arrays because, unlike X/obsp/varp, and as described here, their second dimension doesn't map to the obs or var axis and can include an arbitrary number of columns.
Solution
With this PR the correct number of columns needed for the resulting numpy array is computed using the number of unique values present in the COO-formatted arrow table's "soma_dim_1" column, which is already in-memory and doesn't require any additional TileDB queries.
This solution is a temporary workaround, as SparseNDArray.shape's behavior will change in an upcoming release of TileDB-SOMA (see here for status).
Note: The TileDB-SOMA SparseNDArray class does provide a used_shape property that returns the occupied capacity of the underlying TileDB array that could be used, however, this is specific to the TileDB implementation and is not part of the SOMA API specification.

This will be well-tested in TileDB-SOMA 🚢


Update continuous-integration.yml

try to locate python on osx runner
Fixes issue #<issue_number>
Brief summary of changes
Testing I've completed
CHANGELOG.md (choose one)

no need to update because...
updated...

@carmichaelong Builds now succeed, but this uses mac osx 12, can you test if the artifact (x86_64) works? Thanks

Awesome, thanks @carmichaelong 🥇


Enable PictureInPicture feature for Video Activity

Since Android 8.0 (API 26) allows activities to launch in PictureInPicture mode it would be very useful and helpful that you integrate this in the twilio-video-app example that you have.

Hi @james04gr . Thanks for reaching out regarding this enhancement! This would definitely be a great feature to add to the app. We'll add this to our backlog as an enhancement. Also, feel free to open a pull request if you'd like to see this integrated into the app sooner.

Hi, I have achieved PIP mode in my video calling app. I will try to generate PR for it.

Hi, I have achieved PIP mode in my video calling app. I will try to generate PR for it.

Hello. I would really appreciate if you could do so, since i want to integrate it in my webrtc app also! Thank you

Any update on this feature?

嗨，我已经在我的视频通话应用程序中实现了 PIP 模式。我会尝试为它生成 PR。

Can you share the demo of pip?

    private boolean startPictureInPicture() {
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
            enterPictureInPictureMode(
                    new PictureInPictureParams.Builder()
                            .setAspectRatio(getPipRatio()) //new Rational(2, 4) // This has lower and upper
                            .build()
            );
            return true;
        }
        return false;
    }


cmd/link: too many open files on high object-count dependencies

I think this issue is a continuation of https://github.com/golang/go/issues/21621, just in a later step when using a huge package, not when building it.
What version of Go are you using (go version)?

$ go version
go version go1.11.2 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/karalabe/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/work"
GOPROXY=""
GORACE=""
GOROOT="/opt/google/go"
GOTMPDIR=""
GOTOOLDIR="/opt/google/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build076342095=/tmp/go-build -gno-record-gcc-switches"

What did you do?
I've built a Go library consisting of more than 1024 Go files (wrapper for Tor): github.com/ipsn/go-libtor. I can successfully build this library into a package (note, only Linux and Android is supported for now).
When using this package in another project however, Go's linker uses as many file descriptors as the number of object files the package has. Exceeding the 1024 object file limit, Go cannot link against this package any more on Linux without raising the ulimit.
What did you expect to see?
Successful compilation.
What did you see instead?
Link fails with too many open files.
Reproduction
I figured it's easier to show-and-tell. First up, prepare an empty GOPATH so we don't mess with anything else:
$ mkdir -p /tmp/gopath
$ cd /tmp/gopath/
$ export GOPATH=/tmp/gopath/

Download and build the Tor wrapper, this takes about 3 minutes on my laptop (verbosity added so you can track the progress, there are 919 files (yes, this is not the case that exceeds 1024 because I didn't want to break the lib, but we'll adjust ulimit to repro nonetheless)):
$ go get -x -v github.com/ipsn/go-libtor

Ok, lets create a tiny repro program that just imports the library we packaged up previously. Create a small package and dump the contents into it:
$ mkdir -p /tmp/gopath/src/repro
$ cd /tmp/gopath/src/repro
$ cat main.go
package main

import (
	"os"

	"github.com/cretz/bine/tor"
	"github.com/ipsn/go-libtor"
)

func main() {
	t, err := tor.Start(nil, &tor.StartConf{ProcessCreator: libtor.Creator, DebugWriter: os.Stderr})
	if err != nil {
		panic(err)
	}
	t.Close()
}

Fetch any missing dependencies and run it, you should see some logs from Tor:
$ go get -v -x
$ go run main.go
[... logs from Tor ...]

Now lower the open file descriptors to below the library file count of 919 and try again:
$ ulimit -n 512
$ go run main.go
# command-line-arguments
/opt/google/go/pkg/tool/linux_amd64/link: cannot create /tmp/go-link-924865611/000536.o: open /tmp/go-link-924865611/000536.o: too many open files
/opt/google/go/pkg/tool/linux_amd64/link: cannot create /tmp/go-link-924865611/000540.o: open /tmp/go-link-924865611/000540.o: too many open files
/opt/google/go/pkg/tool/linux_amd64/link: cannot create /tmp/go-link-924865611/000538.o: open /tmp/go-link-924865611/000538.o: too many open files
/opt/google/go/pkg/tool/linux_amd64/link: cannot create /tmp/go-link-924865611/000539.o: open /tmp/go-link-924865611/000539.o: too many open files
/opt/google/go/pkg/tool/linux_amd64/link: cannot reopen /tmp/gopath/pkg/linux_amd64/github.com/ipsn/go-libtor.a(_x470.o): open /tmp/gopath/pkg/linux_amd64/github.com/ipsn/go-libtor.a: too many open files
/opt/google/go/pkg/tool/linux_amd64/link: cannot create /tmp/go-link-924865611/000470.o: open /tmp/go-link-924865611/000470.o: too many open files

I see the problem, sending a CL.

@gopherbot, please backport to Go 1.11.

Can confirm this fix solved the issue. Thank you!


Marshaler does not give an opportunity to indicate an error

Consider:
type Marshaler interface {
	MarshalYAML() (tag string, value interface{})
}

Then an example implementation:
func (b *BinaryContainer) MarshalYAML() (tag string, value interface{}) {
	var buffer bytes.Buffer
	encoder := base64.NewEncoder(base64.StdEncoding, &buffer)
	_, err := encoder.Write(b.bytes)
	if err != nil {
		// Uh oh, what do! PANIC
	}
	encoder.Close()
	return ("", string(buffer.Bytes()))
}

A similar type in exists in https://github.com/go-yaml/yaml/blob/v2/yaml.go which allows for returning an error:
type Marshaler interface {
	MarshalYAML() (interface{}, error)
}

Changing this would break the API, which you may not be comfortable with. Perhaps we could introduce an alternative Marshaler interface which allows returning an error?

Thanks for the suggestion, @excepttheweasel. From my reading of the Encoder's Encode method and the recovery function it defers, it will attempt to recover from panics during marshaling and return them as errors, so it might actually be appropriate to panic in MarshalYAML() in an error case. It's kind of an exception-y flow, but I imagine it simplifies the marshaling logic. @fraenkel, can you confirm? Any other thoughts on this?
Thanks again,
Eric, CF Runtime Diego PM

The panic would work as a temporary solution. The proper solution is to support an error and have the library handle how errors are propagated within.

Fixed.


Build blog card component

See https://tabler.github.io/tabler/blog.html

Can I take this one too?

@KhaldiAmer we're sticking to one at a time how now just in case but I doubt anyone will take this by the time you finish the other :)

Can I take this one now? 😄

:tada: This issue has been resolved in version 1.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: