Enable Tally Wallet in web3 modal

We just participated in the Tally Ho community call! Let's enable Tally in the app connection modal.

It do already work tho

Yeah I think it will appear as "Web 3 Wallet" but there should be a simple option in the modal to enable it appearing with the Tally Logo, like MetaMask does

@adamgall actually you're right, we support it, and the logo not appearing is a web3modal bug:
https://github.com/tallycash/extension/issues/1859


Trimmed data-sets

Hello,
Is it correct to run the pipeline after trimming adaptors in paired-end data-sets? I get different read lengths.
Raquel

Yes, chipseq pipeline does not have any adapter-trimming step.
Jin


How to generate dictionary in another language than english ?

Hello,
I'm trying to port all data in zxcvbn to french, but I don't found any explanations about the 'crc' (?) which are into password.txt. for example :
123456          55893
password        20785
12345678        13582
Is the method to generate those crcs public ?
Thanks
Thierry

Hi,
Any news ? I'm also interested in French dictionary.
Thanks
Flavien

hello Flavien,
after some research, my conclusion is that the crc is not used in the dictionary.
I create some dictionary based on wikipedia (most used words, list of most used names/firstnames, etc) and added in the sources in the same way as the english version.
https://fr.wiktionary.org/wiki/Wiktionnaire:Listes_de_fréquence
Regards
Thierry

Hi Thierry,
Thanks for the tips. How do you evaluate the "score" (I'm not sure what is the meaning of the number in the dictionary) of each entry ? Do you think it is possible to share your work ?
We are not going to use the lib right know but it is still interesting for the future.
Regards
Flavien

Hi Thierry,
Thanks for the tips. How do you evaluate the "score" (I'm not sure what is the meaning of the number in the dictionary) of each entry ? Do you think it is possible to share your work ?
We are not going to use the lib right know but it is still interesting for the future.
Regards
Flavien

I also decided not to use the library for now because there are some issues and it’s not maintained anymore, but for French, I was going to use the list of words from the Lexique database. @thierrymaurel39 is right, build_frequency_lists.py does not care about the actual frequency values in the lists you add to the data/ folder, the token order from most frequent to least frequent is only thing that matters. For each list, the script just starts with a rank of 1 for the most frequent word, and increments it for each word then. The final result doesn’t even have ranks anymore


PostgreSQL base64_image needs stream_get_contents

Bug report
base64_image Widget:
With PostgreSQL a $table->binary('image') is a of the bytea type. Saving an Image with that works as expected but reading it after, doesn't seem to work as I get this error:
htmlspecialchars() expects parameter 1 to be string, resource given (View: /var/www/vendor/backpack/crud/src/resources/views/crud/fields/base64_image.blade.php)

What I did
Defined a $table->binary('image1'); for PostgreSQL and used the base64_image widget on top of it, saving works as expected but reading it after doesn't seem to work.
What I expected to happen
Reopen the Data with a saved image works.
What happened
Open fails with error message above.
What I've already tried to fix it
I have added the following code to before line 36:
            @elseif(isset($field['value']) && is_resource($field['value']))
                @php
                    $data = stream_get_contents($field['value']);
                @endphp
                <img data-handle="mainImage" src="{{ $data }}">

For me this works, but i'm not sure if this is the right way to fix it(tm).
Backpack, Laravel, PHP, DB version
PHP VERSION:
PHP 7.4.3 (cli) (built: Feb 26 2020 12:17:01) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
LARAVEL VERSION:
laravel/framework                     v6.17.1   The Laravel Framework.
BACKPACK VERSION:
backpack/crud                         4.0.41    Quickly build an admin interfaces using Laravel 6, CoreUI, Boostrap 4 and jQuery.
backpack/generators                   2.0.6     Generate files for laravel projects
backpack/permissionmanager            5.0.6     Users and permissions management interface for Laravel 5 using Backpack CRUD.
Database
PostgreSQL 11.7 Docker

Hello @pcdummy , thanks for reporting in.
I am not a PostGres user, maybe you could help me out here.
$table->binary is an alias for BLOB (atleast mysql), what is produced in PostGres?
Why it return a resource instead of the usual value ? Is some switch you can have on your database to return a resource instead of the base64 encoded image?
Best,
Pedro

Hi @pxpm ,
I'm also not a PostGres Pro, but let's try to fix that. I didn't change anything on the Database Docker Image.
In PostGres is binary a bytea field.
Maybe this gives some info?

@pxpm
If you want I share you the code somewhere privat.

Hello! According to the PDO PGSQL documentation https://www.php.net/manual/en/ref.pdo-pgsql.connection.php The bytea fields are returned as streams (Note section). I think the casting of attributes is out of scope of this package. It should be done in the Model layer ($casts or in getter).

@codercms I'm doing it wrong?

@pcdummy you're doing fine, but stream_get_contents should be placed in your model.
https://laravel.com/docs/6.x/eloquent-mutators
use function stream_get_contents;

class YourModel
{
    /**
     * @param resource $value
     * @return string
     */
    public function getYourAttributeName($value)
    {
        return stream_get_contents($value);
    }
}

Or in Laravel 7 you can use "custom casters" - https://laravel.com/docs/7.x/eloquent-mutators#custom-casts


Support for Cake.Core 0.26

Please provide a version supporting Cake.Core 0.26.

Thanks for the suggestion, @AdmiringWorm are you cool with this?

@larzw sure, but it would probably be best to add it in a non-breaking way.
By just targeting 0.26 for netstandard2.0 IMO, and keeping the rest frameworks with the existing dependencies.

Seems like it will be a Breaking change anyhow, unable to target previous versions for the .NET 4.6 Framework


Provide a way to augment global interfaces from external modules

We get "bug reports" of this nature very often:

I wrote this code
interface Window {
  myPlugin: any;
}
let x = window.myPlugin;
class Foo { }

then I added 'export' and I get compile errors, wat?
interface Window {
  myPlugin: any;
}
let x = window.myPlugin;
export class Foo { }

Our current answer today is "Move your stuff to another .d.ts file". This is an OK workaround, but not great. The real sticker is when there's a type defined inside an external module -- it's impossible to use those types to augment a global interface, even though this is a thing that actually happens. It gets even trickier because this encourages people to move types into the global namespace when they didn't want to in the first place, exacerbating the problem.
We need some proposal for how to make this work.

Am I being too ignorant, but why wouldn't the following be acceptable?
interface global.Window {
  myPlugin: any;
}
let x = window.myPlugin;
export class Foo { }

My particular use case was extending other global interfaces within a module that was going to try to offload to native if present:
interface ObjectConstructor {
    assign(target: any, ...sources: any[]): any;
}

const assign = 'assign' in Object ? Object.assign : function assign(target: any, ...sources: any[]): any {
    // shim...
}

export default assign;

Too bad there is no [discussion] tag, gonna add my few cents anyway. It's shocking how a big new feature is coming out of a tiny problem: to get something out of a standard object something that is not supposed to be there. If so, what could be easier than this:
export function toSomethingCrazy(window: Window) : SomethingCrazy {
    return (<any> window).stupidPlugin;
}

That's it, the problem has gone. No need for a new expensive feature. Thank to one single guarded place in code.

@aleksey-bykov that does not allow for modeling global side-effects. a library author would want to declare that their library is adding certain definitions to the global scope, so that their users get to use them.
for context, we have rejected this in the past on the basis of discouraging bad practices. however, like them or not, there are existing JS libraries that relay on global extensions to work. the only way to do this today in TS, is to define your global polluters in a .d.ts file, then add a /// reference to it from your module.

well, can't say you have any other choice other than to add it
:+1: for global polluters, I like the idea

It isn't just global polluters...  The other use case is trying to extend the globals without having to load the full lib.es6.d.ts from within a module that is related to that bit of functionality.

@kitsonk can you elaborate..

@kitsonk, you sound like such pollutions would be localized in a module where they are introduced (rather than leaking to the global namespace) which sounds opposite to what @RyanCavanaugh originally said

All that is being suggested is that there is a language mechanism to access global interfaces from within a module.  The reasons for it were originally thought to be useless which is why #983 got closed, then re-opened, and now closed again in lieu of this one.  There can be many use cases, like having to do with other libraries that pollute the global namespace, which is bad, or my particular use case which is that I wanted to "shim" the global interfaces so I could better handle when the native ES6 functionality wasn't there.  So one is the living in the sad reality of the wild west of the web and one might be actually a good thing, though it was better in the end for my use case to extend the global interface (#3889).

Will this help fix code like
//file: frobulatorComponent.ts
namespace Components {
  export namespace Frobulator {
     export class ViewModel {
       public x = ()=> {
        var frobModel: Frobulator.Frob;   //.Frob isn't in intellisense (and this doesn't compile)
             //since the global::Frobulator namespace is inaccessible
             //("global::" chosen since it's used in other issues discussing this and nicely conveys what I mean)
        }
     }
  }
}

//file: frobulatorData.ts
namespace Frobulator {
  export interface Frob {

  }
}

I know there's a workaround where I could have
type Frobulator_Frob = Frobulator.Frob;

as the first line in frobulatorData.ts, but then I've got Frobulator.Frob and Frobulator_Frob in my global scope which is a bit untidy.   If I have many interfaces in my global Frobulator namespace then I've got a lot of duplication to do.
I can fix this by changing some namespaces of course but global:: would be very handy.  As I said in another discussion on this topic, the generated JavaScript is easy in this case - there is none since I'm just worrying about interfaces.  I appreciate this would be more difficult with classes but not impossible (some auto-generated type aliases, with some sort of consistent name mangling, at the start of each ts file's emit would do the trick)
Note: I'm just letting VS 2015 build separate *.js files and using ASP.Net bundling to get them on to my page - no ES6 modules, gulp tasks, requireJS or anything like that.

I wish we had a "pimping" mechanism à la Scala (http://www.artima.com/weblogs/viewpost.jsp?thread=179766).
An oversimplified view is that when an implicit converter exists between type A and type B, methods of type B can be called on type A (implicit conversion happens in the background). The great thing about this mechanism is that it avoids monkey patching and that the conversion only happens when a converter is "in scope/visible" (so conversion does not have to be global).
Implicits is a whole subject in itself, but at least with Typescript if we could have a way of "registering" a converter on a type, that would be great.

Were the referenced design notes #5292 fleshed out as a proposal?

PR #6213, should already be in master and available in our nightly builds (typescript@next on npm)

I think I have this problem. I have a d.ts file that I want to extend global with. This works fine:
interface Window {
    foo:number
}

declare module 'bar' {
    export const baz:string;
}

But I'd like to import a type for the Window augmentation:
import SomeClass from './somewhere'

interface Window {
    foo:SomeClass
}

declare module 'bar' {
    export const baz:string;
}

But then I get something like
49 declare module 'bar' {
                  ~~~~~~~~

src/externals.d.ts(49,16): error TS2665: Invalid module name in augmentation. Module 'bar' resolves to an untyped module at '/path/to/bar.js', which cannot be augmented.

with no clear indication what the problem was, until I found the link in @mhegazy's comment https://github.com/Microsoft/TypeScript/issues/9748#issuecomment-232822688.
It seems not possible to import something into a non-module declaration file that has ambient modules in order to make a type definition? What's the solution? Do I need to make a separate module declaration file and keep ambient stuff in a second non-module declaration file?

Ah, yep, that worked. I moved the Window type augmentation into an external module and made it the first import in my entry point, and the other ambient stuff is still in the non-module .d.ts file.


Title screen picker

It would be cool to choose between the Project Zero, Zero, and Fatal Frame title screens.

Swapping the Japanese one is easy, in fact, it's already been done and pushed ;)
The US one is a little bit trickier as it also requires the US ISO to make the swap. For now, I'll leave the issue open while I think about how to do this properly.


Access_token still empty

Everything works fine except that access_token(Environment) is still empty
JSONPath-filter :  $.body.access_token
{
  ...
  "body": {
    "access_token": "abcdef1234"
  },
}

or
JSONPath-filter :  access_token
{
  ...
    "access_token": "abcdef1234"
}

Everything works fine except that access_token(Environment) is still empty
JSONPath-filter : $.body.access_token
{
  ...
  "body": {
    "access_token": "abcdef1234"
  },
}

or
JSONPath-filter : access_token
{
  ...
    "access_token": "abcdef1234"
}

Have you ran this as an Authorize request (the first example)? I had the same issue but clicking on the little down arrow next to the request then "Authorize requests" worked.


Fix for missing write reference count of children (issue #93).

Original pull request by Thomas Moeller (Bitbucket: TheHubbit, GitHub: TheHubbit).

Resolves issue #93. Output of test program from issue description is now:
#!iv

#Inventor V2.1 ascii

Separator { # writeref: 1

  DEF B Separator { # writeref: 2

    renderCaching AUTO =
    DEF A Separator { # writeref: 2

      USE B # writeref: 1

    }    . renderCaching

  }
  USE A # writeref: 1

}

Original comment by Roy Walmsley (Bitbucket: walroy, GitHub: walroy).

Misspelling of 'reference'.

Original comment by Roy Walmsley (Bitbucket: walroy, GitHub: walroy).

Thomas,
Another good catch. Are you happy with this now? If so, I will merge it.
I did also have a look at SoVRMLParent and SoVRMLGroup. I don't think they are affected. You might just want to confirm that.
Roy

Original comment by Thomas Moeller (Bitbucket: TheHubbit, GitHub: TheHubbit).

Roy,
Thanks for your review! I corrected the spelling mistake. This morning I also looked through all places where write() is overloaded, including the VRML classes. Only SoGroup and SoSwitch did traverse children in the COUNT_REFS stage and had to be adapted.
I finished the testing on my side so you can go ahead with the merge. Also I did pay attention to setting "close branch after merge". Could you check that this option is still checked when you merge? I noticed a lot of the issue branches stayed "open" after merging, which is not desired. Maybe you could manually close them since we don't want to accept additional commits on those.
Regards,
Thomas


return key map to 'Encrypt' button

in a recent build you can tab+spacebar to click the button and kick off encryption, but return would be ideal

Seconded.

Not going to fix this, it's not applicable to the soon to be released version.


What's the real LICENSING

We release the resources associated with QLoRA finetuning in this repository under MIT license. In addition, we release the Guanaco model family for base LLaMA model sizes of 7B, 13B, 33B, and 65B. These models are intended for purposes in line with the LLaMA license and require access to the LLaMA models.

but the LICENSE file say it's Apache License 2.0

Chinese-Guanaco is released under the Apache 2.0 license


Font in flutter page different from the one in the native side.

Steps to Reproduce
 I wrote simple code below to reproduce my problem:

  Widget build(BuildContext context) {
    return new Container(color: Colors.white,child:
    Column(children: <Widget>[
      SizedBox(height: 100.0),
      Text("将",style: new TextStyle(fontWeight:FontWeight.w400,fontSize:16.0,fontFamily: ".SF UI Text"),textScaleFactor: 1.0,maxLines: 10)
    ])
  );
}

Then when I switch my iPhone's system language to Simplified Chinease and English, the flutter page is what I want as below:

However, When I switch the language to Japanese, the flutter page shows unexpected:

I checked the ios's fonts in http://iosfonts.com and think that it could be using different font when rendering.
Currently, in native side(our app is a typical hybrid scenario of native and flutter), we use codes below to set the fonts:
+ (UIFont *)fm_fontWithBold:(BOOL)isBold size:(CGFloat)size {
    NSString *regularFontName = @"PingFangSC-Regular";
    NSString *boldFontName = @"PingFangSC-Medium";
    NSString *fontName = isBold? boldFontName:regularFontName;
    UIFont *fmFont = [self fontWithName:fontName size:size];
    if (!fmFont) {
        if (isBold) {
            return [self boldSystemFontOfSize:size];
        }
        return [self systemFontOfSize:size];
    }

    return fmFont;
}

We want to force the flutter and native side use the safe fonts.
However, I failed to change the flutter side's behavior for rendering. It can't be done by setting fontFamily for TextStyle in flutter side.
So I think i should do it in the engine side. After some digging, I think the key point could be function below(engine/src/third_party/skia/src/ports/SkFontHost_mac.cpp):

Is the fallbackFont got here based on currentFont hit another font? If I want to force the flutter side use the "PingFangSC" too, what's the best approach?

[✓] Flutter (Channel xy_beta_v0.8.2, v0.8.3-pre.19, on Mac OS X 10.14 18A389, locale en-CN)
    • Flutter version 0.8.3-pre.19 at /Users/kylewong/Codes/fwn_idlefish/flutter
    • Framework revision f5da19a849 (17 hours ago), 2018-10-11 08:53:38 +0800
    • Engine revision 58a1894a1c
    • Dart version 2.1.0-dev.3.1.flutter-760a9690c2

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/kylewong/Library/Android/sdk
    • Android NDK at /Users/kylewong/Library/Android/sdk/ndk-bundle
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices (Xcode 10.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.0, Build version 10A254a
    • ios-deploy 1.9.2
    ! CocoaPods out of date (1.5.0 is recommended).
        CocoaPods is used to retrieve the iOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without resolving iOS dependencies with CocoaPods, plugins will not work on iOS.
        For more info, see https://flutter.io/platform-plugins
      To upgrade:
        brew upgrade cocoapods
        pod setup

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 29.0.2
    • Dart plugin version 181.5540.11
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

@eseidelGoogle  @jason-simmons

@GaryQian

Hi, I'm Japanese.
In the screenshot when setting to Japanese, the font of the character is correct Japanese font.

@najeira
Yes, you're right.
The problem occurs as we specify "PingFangSC" in native side. However, the flutter's implementation use CoreText and its fallback font is related to the default"global cascade lis" which is related to current locale and language. With  the work around  below, this problem disappears.

@kangwang1988 than you for your reply.
I set "Hiragino Sans" to ThemeData.fontFamily and pass the ThemeData to MaterialApp for iOS. How is that way?
It is an excerpt from my code:
const Locale kLocale = const Locale("ja", "JP");

final String _kFontFamilly = (defaultTargetPlatform == TargetPlatform.android)
  ? null : "Hiragino Sans";

final Typography _kTypography = new Typography(platform: defaultTargetPlatform);

final TextTheme kTextThemeWhite = _kTypography.white.copyWith(
  display4: _kTypography.white.display4.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  display3: _kTypography.white.display3.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  display2: _kTypography.white.display2.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  display1: _kTypography.white.display1.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  headline: _kTypography.white.headline.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  title: _kTypography.white.title.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  subhead: _kTypography.white.subhead.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  body2: _kTypography.white.body2.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  body1: _kTypography.white.body1.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  caption: _kTypography.white.caption.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  button: _kTypography.white.button.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
);

final TextTheme kTextThemeBlack = _kTypography.black.copyWith(
  display4: _kTypography.black.display4.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  display3: _kTypography.black.display3.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  display2: _kTypography.black.display2.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  display1: _kTypography.black.display1.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  headline: _kTypography.black.headline.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  title: _kTypography.black.title.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  subhead: _kTypography.black.subhead.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  body2: _kTypography.black.body2.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  body1: _kTypography.black.body1.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  caption: _kTypography.black.caption.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
  button: _kTypography.black.button.copyWith(fontFamily: _kFontFamilly, locale: kLocale),
);

    final themeData = new ThemeData(
      textTheme: kTextThemeBlack,
      primaryTextTheme: kTextThemeWhite,
      accentTextTheme: kTextThemeWhite,
    );

    return new MaterialApp(
      locale: kLocale,
      home: child,
      theme: themeData,
      navigatorObservers: navigatorObservers,
      localizationsDelegates: GlobalMaterialLocalizations.delegates,
      supportedLocales: [kLocale],
      debugShowCheckedModeBanner: false,
    );

@najeira
It doesn't work. Even I specify a _kFontFamilly in my flutter code,the result will also be unexpected, due to the font search&matching logic in skia.

@eseidelGoogle
I think this problem is an urgent thing. Though I've made an workaround to solve our problem, however, other guys might face the problem too.Based on flutter betav0.8.2 and the flutter_gallery example,I used some Chinease characters and change the system language to Japan(iOS8), certain characters become an empty box. This problem is serious in iOS8.
Before my modification:

After my modification:

When it comes to iOS9+, it might behavior unexpectedly. In my case, my iOS12 and system setting remains, however, sometimes, for the same Chinease article, the font used for rendering alters.

@GaryQian Have you taken a look at this one perchance?

Haven't gotten to it yet. Should have some time to look at it now.

@GaryQian Any luck getting time to look at this? Thanks! Let me know if we should find someone else to help with it.

Replicated on an assortment of iOS 8.1-8.4 device simulators. This problem is not present in any iOS version 9.0+.

Update on the status of this, I chased the bug around and it looks like it may be skia-related. I will verify this and send it off to skia if need be.

So I would like to clear up that the original post of this issue is actually working as expected. The Chinese character is rendering using a Chinese font when the locale is Chinese, but when changed to a Japanese locale, since Chinese and Japanese Kanji share the same encoding, the character is interpreted as Japanese kanji and rendered with a Japanese font. There is no way to distinguish Chinese vs Japanese characters out of context from just the UTF-16 encoding, so the locale is used to determine how to draw them.
The later bug reported is different. Some Chinese does not exist as Japanese Kanji, and those glyphs are missing from the Japanese fonts. What should happen (it is correct in iOS9+) is that the missing glyphs should fall back to a Chinese font, but in iOS8.x, this fallback is not happening, and we are rendering tofu instead.

There also exists glyphs where the same base glyph with slight variations between languages have different codepoints. For example:
http://unicode.org/cldr/utility/character.jsp?a=984C
http://unicode.org/cldr/utility/character.jsp?a=9898
Are derived from the same character, but have different codepoints.
These seem to be the characters that are unable to be rendered.

In my understanding, @kangwang1988 want to Flutter uses specified font.
If font is not specified, it is correct that Flutter selects and renders fonts according to language settings.

So we did research into this topic and found that when no font is provided via a TextStyle, we delegate the font fallback to iOS's platform fallback. With iOS8, the Apple API does not provide an easy way to access/extend/modify the Cascade list, and the method that resolves fonts per-glyph is not sufficient in determining the correct font in this case. The cascade list in this case is not sufficiently populated to be able to resolve the correct glyphs.
The conclusion is that with iOS8, the platform system is not sufficient to decide to properly perform fallback.
A proposed solution to this is to add support for TextStyle.fontFamilyFallback, which would be a list of strings of the names of font families that the user would like the text to fall back with. This would offload the font fallback away from iOS onto LibTxt/minikin, which is able to better resolve a correct font if possible.

https://github.com/flutter/engine/pull/7241 and https://github.com/flutter/flutter/pull/25585/files will expose the font fallback API that allows users to specify custom font fallback that will be handled by the engine instead if the platform.


translating how to contribute section.

Translation:
Contributing

How to Contribute

@alejandronanez, @carburo, @dmoralesm
Please let me know if everything is looking good.

Hello @maudel. It has been 13 days since the first request for changes. Are you able to check it? Let me know if you don't have enough time. I could help in editing so this can be merged.

I applied the changes myself. I think this is good to go. Thanks!


ci: add production tests stage

Summary

The "what"; a concise description of each logical change
Another change

The "why", or other context.
Test plan
Issues

"THING-1234" or "Fixes #123"

Coverage remained the same at 99.561% when pulling e4f871153ddffd39da18428c2ee61cd37e1652d3 on oakbani/prod-ready-stage into 3a687f2c1dd982451326269a11677034b53a0946 on master.


Clarification on create and view

In order to target only a group of users in your organization to be able to create Loop content in workspaces, create a second group that targets All users, set this group to Disabled, and make it a lower priority than your target group that is set to Enabled. This will override the default Not Configured state to Disabled for all users but your target group.
This comment is not clear enough as the policy itself is named "Create and view Loop workspaces in Loop". Is this to

target a certain group to create and view content OR
target a certain group to create  content

Better would be: In order to target only a group of users in your organization to be able to create and view Loop content in workspaces

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 093c11ef-791c-c4bd-71e6-c3e6ecc347e1
Version Independent ID: 093c11ef-791c-c4bd-71e6-c3e6ecc347e1
Content: Manage Loop workspaces in Syntex repository services
Content Source: microsoft-365/loop/loop-workspaces-configuration.md
Service: sharepoint-online
GitHub Login: @v-smandalika
Microsoft Alias: v-smandalika

@LennartaeHoefer Thank you for your feedback. You are right, it should be to create and view Loop content in workspaces. I have made the changes in the document and can be tracked via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/13092
Once the author approves, the changes will be live.
Thanks
Sri

[heart]         Lennart Hoefer reacted to your message:

From: Sriraman M S @.>
Sent: Sunday, November 5, 2023 6:19:29 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Lennart Hoefer @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Clarification on create and view (Issue #13062)
@LennartaeHoeferhttps://github.com/LennartaeHoefer Thank you for your feedback. You are right, it should be to create and view Loop content in workspaces. I have made the changes in the document and can be tracked via PR##13092https://github.com/MicrosoftDocs/microsoft-365-docs/pull/13092
Once the author approves, the changes will be live.
Thanks
Sri
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/microsoft-365-docs/issues/13062#issuecomment-1793649953, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWSN3W4YBLI6O7MUQ52KOUDYC4VXDAVCNFSM6AAAAAA6Y7UR2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGY2DSOJVGM.
You are receiving this because you were mentioned.Message ID: @.***>


ParserError: Source<EMAIL_ADDRESS>not found: File not found.

Hi All, I didnt think i would return with another error so soon. I checked all the 4 google search pages for answers and tried what was mentioned there, it included npm install @openzeppelin/contracts, installing solc@latest and also trying to import directly:"https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/ERC20.sol"
but none of these worked. :(
I also tried the Linting issues mentioned here: https://github.com/smartcontractkit/full-blockchain-solidity-course-py/blob/main/chronological-issues-from-video.md
but the error still persists.
On trying to investigate this on my own i checked if there was this file in the node_modules folder  and it was there but colored red. so not sure if that is ok or not, here is a picture

I am not sure why this file cannot be found, I am hoping someone here can help me. :)
terminal with error:
PS D:\Python projects\Solidity dev\demo\ERC20-BROWNIE> brownie run scripts/1_deploy_token.py
INFO: Could not find files for the given pattern(s).
Brownie v1.17.2 - Python development framework for Ethereum

Compiling contracts...
  Solc version: 0.8.11
  Optimizer: Enabled  Runs: 200
  EVM Version: Istanbul
CompilerError: solc returned the following errors:

ParserError: Source<EMAIL_ADDRESS>not found: File not found.
 --> contracts/OurToken.sol:5:1:
  |
5 | import<EMAIL_ADDRESS>  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

PS D:\Python projects\Solidity dev\demo\ERC20-BROWNIE>

OurToken.sol:
// contracts/OurToken.sol
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

import<EMAIL_ADDRESS>
contract OurToken is ERC20 {
    constructor(uint256 initialSupply) ERC20("OurToken", "OT") {
        _mint(msg.sender, initialSupply);
    }
}

brownie-config.yaml:
dependencies:
-<EMAIL_ADDRESS>
compiler:
  solc:
    remappings:
      -'<EMAIL_ADDRESS>
dotenv: .env

wallets:
  from_key: ${PRIVATE_KEY}

1_deploy_token.py:
from brownie import OurToken
from brownie.network import account
from scripts.helpful_scripts import get_account
from web3 import Web3

initial_supply = Web3.toWei(1000, "ether")

def main():
    account = get_account()
    our_token = OurToken.deploy(initial_supply, {"from": account})
    print(our_token.name())

helpful_scripts.py:
from brownie import (
    accounts,
    network,
    config,
    MockV3Aggregator,
    Contract,
    VRFCoordinatorMock,
    LinkToken,
    interface,
)

# from brownie.convert.datatypes import ReturnValue
# from brownie.network import contract

FORKED_LOCAL_ENVIRONMENTS = ["mainnet-fork", "mainnet-fork-dev"]
LOCAL_BLOCKCHAIN_ENVIRONMENTS = ["development", "ganache-local"]

def get_account(index=None, id=None):
    # account[0]
    # accounts.add("env")
    # accounts.load("id")
    if index:
        return accounts[index]
    if id:
        return accounts.load(id)
    if (
        network.show_active() in LOCAL_BLOCKCHAIN_ENVIRONMENTS
        or network.show_active() in FORKED_LOCAL_ENVIRONMENTS
    ):
        return accounts[0]

    return accounts.add(config["wallets"]["from_key"])

contract_to_mock = {
    "eth_usd_price_feed": MockV3Aggregator,
    "vrf_coordinator": VRFCoordinatorMock,
    "link_token": LinkToken,
}

def get_contract(contract_name):
    """This function will grab the contract addresses from the brownie config
    if defined, otherwise it will deploy a mock version of that contract and return that mock contract.

        Args:
            contract_name(string)

        Returns:
            brownie.network.contract.ProjectContract: The most recently deployed version of this contract.

    """
    contract_type = contract_to_mock[contract_name]
    if network.show_active() in LOCAL_BLOCKCHAIN_ENVIRONMENTS:
        if len(contract_type) <= 0:
            # MockV3Aggregator.length
            deploy_mocks()
        contract = contract_type[-1]
        # MockV3Aggregator[-1]

    else:
        contract_address = config["networks"][network.show_active()][contract_name]
        # address
        # abi
        contract = Contract.from_abi(
            contract_type._name, contract_address, contract_type.abi
        )
    return contract

DECIMALS = 8
INITIAL_VALUE =<PHONE_NUMBER>00

def deploy_mocks(decimals=DECIMALS, initial_value=INITIAL_VALUE):
    account = get_account()
    MockV3Aggregator.deploy(decimals, initial_value, {"from": account})
    link_token = LinkToken.deploy({"from": account})
    VRFCoordinatorMock.deploy(link_token.address, {"from": account})
    print("deployed!")

def fund_with_link(
    contract_address, account=None, link_token=None, amount=100000000000000000
):  # 0.1LINK
    account = account if account else get_account()
    link_token = link_token if link_token else get_contract("link_token")
    tx = link_token.transfer(contract_address, amount, {"from": account})
    # link_token_contract = interface.LinkTokenInterface(link_token.address)
    # tx = link_token_contract.transfer(contract_address, amount, {"from": account})
    tx.wait(1)
    print("Fund contract!")
    return tx

Sorry everyone for yet another stupid mistake.
I forgot to indent
dependencies:
-<EMAIL_ADDRESS>
after changing to
dependencies:
   -<EMAIL_ADDRESS>
all works!


zephyr: boot: added support for nrf52840_pca10056 board

Added configuration file for nrf52840_pca10056.
Fixed UART name required for pca10056.
Signed-off-by: Chris Bittner<EMAIL_ADDRESS>

cc @nvlsianpu

Hi @ChristopherBittner , why are you changing the default configuration to enable Serial recovery?

Hi @lemrey
I've built this configuration based on the nrf52840_pca10059.conf where serial recovery is already enabled. So I just followed what we had there but to be used with the development kit.


Manual IP input

Hi,
It would be awesome If I could put in an IP to the app as my home network is weird and the wap is somehow separate to the rest of the network and the phone can't find the PC, but If I move my phone over to the router wifi it works excellently.
Thanks
Alex

I sincerely apologize for the late reply. I'll implement this feature in the next version.


ui: single-threaded CameraView

continue https://github.com/commaai/openpilot/pull/30397
Fixed issue: Early return from paintGL during initial VIPC server connection resulted in reduced FPS as fps_filter.update wasn't called until a frame was received.
The solution: Draw a blank frame when no frame is available instead of returning early from AnnotatedCameraWidget::paintGL, similar to the original multithreaded approach.

@deanlee this still seems to have some issues:
selfdrive/ui/qt/widgets/cameraview.cc: Skip frame 1581
selfdrive/ui/qt/widgets/cameraview.cc: Drawing same frame twice 1581
selfdrive/ui/qt/widgets/cameraview.cc: Skip frame 1586
selfdrive/ui/qt/widgets/cameraview.cc: Drawing same frame twice 1587
system/loggerd/loggerd.cc: 104000 messages, 1297.60 msg/sec, 579.33 KB/sec
selfdrive/ui/qt/widgets/cameraview.cc: Skip frame 1589
camerad logcatd proclogd logmessaged micd timed dmonitoringmodeld encoderd loggerd modeld sensord ui soundd locationd calibrationd torqued controlsd deleter dmonitoringd navd pandad paramsd ubloxd pigeond plannerd radard thermald tombstoned uploader statsd
camerad logcatd proclogd logmessaged micd timed dmonitoringmodeld encoderd loggerd modeld sensord ui soundd locationd calibrationd torqued controlsd deleter dmonitoringd navd pandad paramsd ubloxd pigeond plannerd radard thermald tombstoned uploader statsd
selfdrive/ui/qt/widgets/cameraview.cc: Drawing same frame twice 1590
selfdrive/ui/qt/widgets/cameraview.cc: Skip frame 1593
selfdrive/ui/qt/widgets/cameraview.cc: Drawing same frame twice 1593
selfdrive/ui/qt/widgets/cameraview.cc: Skip frame 1595
selfdrive/ui/qt/widgets/cameraview.cc: Drawing same frame twice 1595
selfdrive/ui/qt/widgets/cameraview.cc: Skip frame 1599
selfdrive/ui/qt/widgets/cameraview.cc: Drawing same frame twice 1599

@adeebshihadeh : This happens because the UI relies on a timer for updates, which can lead to missed frames during updates. I've submitted a separate PR https://github.com/commaai/openpilot/pull/32551 to solve this.


Refactoring for Binance: filter out delisted symbols

Description
It seems there are many symbols in SPDB that are not currently quoted on exchange(i.e have been delisted), Perhaps the exchange stores information on all old instruments, but it is no longer relevant for the purpose of trading, these symbols could be filtered
Related Issue
NA
Motivation and Context
I would rely on the list of symbols in SPDB to  upload the latest historical data updates. If any of symbols in list are delisted, Binance would return an empty object and exceptions will be thrown by the brokerage(history provider). Good to update the list of active symbols from time to time.
Requires Documentation Change
NA
How Has This Been Tested?
Run --app=binancesymbolpropertiesupdater
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ X] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[ ] My code follows the code style of this project.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Hey @IlshatGaripov!
Do not think we can remove these delisted symbols from the SPDB, their are still valid for backtesting and require valid properties set. Whats missing in Lean is a way to determine delisted crypto assets in general but we haven't get around to it yet.

Closing for now - Maybe mind expanding of what issue was this causing, if any? maybe we can handle it more gracefully instead for now

Hey @Martin-Molinero thanks,I believe Bitfinex has abolished some cross pairs for some coins. It seems that in most of the case all the coins are still listed and quoted alright by the exchange, which is a good sign


Failed to install quasar-app-extension-ssg

quasar ext add ssg
App · Installing "ssg" Quasar App Extension
App · Retrieving "quasar-app-extension-ssg"...
App · [sync] Running "npm install --save-dev quasar-app-extension-ssg"
npm ERR! path git
npm ERR! code ENOENT
npm ERR! errno ENOENT
npm ERR! syscall spawn git
npm ERR! enoent Error while executing:
npm ERR! enoent undefined ls-remote -h -t https://github.com/freddy38510/critters.git
npm ERR! enoent
npm ERR! enoent
npm ERR! enoent spawn git ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR!      C:\Users\hamana.keigo\AppData\Roaming\npm-cache_logs\2020-12-30T01_48_54_977Z-debug.log
App · ⚠  Command "npm" failed with exit code: 1
App · ⚠  Failed to install quasar-app-extension-ssg

Seems to be the same error than this issue.
The Critters dependency in the AE requires git to be installed on your system, to let npm fetch it.
This is because i fork Critters and i didn't publish it yet on npm. I will do it later, but for now, you should install git on your system.


[winpr,pool] fix winpr_SetThreadpoolThreadMaximum

unlock the arraylist, don´t lock it twice.

@freerdp-bot test again please


S3 lifecycle configuration through CLI.

Amplify CLI Version
11.0.3
Question
Is your feature request related to a problem? Please describe.
Not really, it's just that I couldn't find a way to configure lifecycle rules through the amplify CLI or through any cloud formation template.
Describe the solution you'd like
I would love to have a way in my amplify project to set up a lifecycle rule for an S3 bucket, whereby I can delete some files after a certain amount of time and mostly develop this as infrastructure as code and replicate it automatically, instead of configuring it manually via console or AWS CLI.
Describe alternatives you've considered
I could set the rules through the console or through the AWS s3api put-bucket-lifecycle-configuration but since that's not infrastructure as a code, every time I deploy my app in a different env, I will have to do that manually and it's not the result that I am looking for.
Psdt: I was trying to manually update the cloud formation template of my amplify/backend/storage/build but it seems this file cannot be updated, the cli-inputs can be updated but I couldn't find any resources of what parameters are allowed in that file.
Thanks in advance.

Hey @dloaizarico :wave: thanks for raising this! This sounds like a great use case for overrides, where you can leverage the power of CDK to make modifications to the resources Amplify creates! To get started run
amplify override storage

Amplify CLI will then create an override.ts file with access to the S3 bucket resource, which we can then use to set the lifecycle
import {
  AmplifyProjectInfo,
  AmplifyS3ResourceTemplate,
} from '@aws-amplify/cli-extensibility-helper'

export function override(
  resources: AmplifyS3ResourceTemplate,
  amplifyProjectInfo: AmplifyProjectInfo
) {
  resources.s3Bucket.lifecycleConfiguration = {
    rules: [
      {
        id: 'delete-old-files',
        status: 'Enabled',
        expirationInDays: 7,
        prefix: 'tmp/',
      },
    ],
  }
}

then push with amplify push and visit the storage console with amplify storage console, and voila! The lifecycle rule is set on the bucket and will stay modified across subsequent amplify push executions and environments

Closing due to inactivity


chore(ci): update package json validator to check all dependencies

:pencil: Description
:link: Related Issues

:tada: This PR is included in version 1.7.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.7.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Set WELLKNOWN path per subdomain

Hi,
I'm currently running into the issue when trying to validate a domain + multiple subdomains.
The script tries to validate the acme challenge file under:
WELLKNOWN="${BASEDIR}/public_html/.acme-challenge"
Which is the challenge directory in the website root. This works for validating example.com & www.example.com, but it doesn't work for subdomain.example.com
This subdomain is located under /public_html/subdomain/
Is it possible to set up multiple WELLKNOWN paths for the different subdomains I'm trying to validate?
One of the docs recommends to set up an alias but I'm unable to modify the apache config file. Modifying this file is restricted on the server I'm running this website on.
https://github.com/lukas2511/letsencrypt.sh/blob/master/docs/wellknown.md

Currently there is no way for a per-domain configuration of this path.
I'd suggest creating a symlink if that is possible, or create a hook script that moves the files to the correct directory using the deploy_challenge hook.
In the future this may change, kinda related to #105.

Thank you!


Add Berzsenyi Daniel Secondary School

@Ponder-deeply First stage of verification passed, official domain is berzsenyi.hu as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@Ponder-deeply Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Depend on whatever version of mongodb that Meteor is using

...instead of having Npm.depends for ourself and always having to update that.
There was a thread about this and MongoInternals; figure out how to make that work and to do anything more advanced if appropriate.

I think that Meteor is just moving to 2.6, so the npm dependency will probably have to be updated.

 Is there any way that I can achieve this?

I do not know. I was just looking around the code but I do not know. They are working on providing access to assets and NPM content, so maybe then we can get absolute path to NPM content of mongodb NPM package and fake node_modules in the right place. But no idea how this would work with isopackages.

Fixed this by depending on a custom fork of ShareJS that does not do an undeclared require("mongodb"):
https://github.com/mizzao/ShareJS/commit/05b625ea1e7f7f27bd13ba7ed05102b38dd175e5


Read sites / stores directly from the database

Currently the site / store config is read from the config file, as seen in #57. We're close to having this not required at all, meaning it could use the structure in the Documents tree, root documents made sites (Pimcore feature) and then Stores from Coreshop stores.
This would remove the requirement of having these be hardcoded in config, making it much more flexible.

See #34.


How do i add or remove environments from the pipeline

Is there a way to easily add or remove environment from the pipeline manually?  Could this be documented? Could VNext possibly have this added as 2 sub commands:

akamai promotional-deployment remove-environment
akamai promotional-deployment add-environment

Great idea. I think there are a few possibilities and corner cases to consider.
Add scenario:

what position should the environment be added. We could use options -a  for after or -b  for before environment.
Akamai pd would just create the environment property as if it was running the new pipeline command
After insertion of the new environment all promotions on environments after that would be blocked until the new environment has been promoted.

Remove scenario

Just remove the environment name from the list in projectInfo.json.
Delete environment folder or move it into an archive folder.
What about the environment property? It would just continue to exist outside of the pipeline.

Is there a manual workaround for this at the moment?
/cc @jumenzel

There is one. It's not very straight forward. It goes roughly like this:

In Property Manager UI look for one of the properties of your pipeline. Let's say "qa.pipeline"
Clone this property and give it a name corresponding to the new environment you want to add, for example "dev.pipeline".
Once done click on save to save the cloned property (this might not even be necessary)
in Akamai PD, search for the new property: akamai pd search dev.pipeline
Deep copy on of the environment folder to a new folder with the name of the new environment.
(in environemnts do a "cp -a qa dev" for example)
Add the new environment name to the list in projectInfo.json
Edit hostnames.json file. If you also change the edgehostnames set the ids to null so that Akamai PD creates new edgehostnames.
In the new environment folder edit envInfo.json and remove all the keys except for 'name', 'propertyName', 'propertyId', 'latestVersionInfo', 'suggestedRuleFormat', 'groupId'.
Edit the values name = 'dev', propertyName = 'dev.pipeline', propertyId = 'property Id from search'
Edit latestVersionInfo, set version to 1. Set both networks to INACTIVE.
Now try to save: akamai pd -v save dev
This should blow up with a etag exception. Luckily the correct etag value shows up in the error message. Replace with the wrong etag in latestVersionInfo.
Try save again. This time it should work.
I only tried adding a new environment by adding it to the front of the pipeline. I think the same mechanism should  work for any position in the pipeline.


Publicly available APIs

By the current concept the API is publicly available.
Due to copyright concerns I would suggest that we restrict the publicly available APIs to the song titles, artists and maybe artwork.
I think we should discuss this...

#51 adds support for this in the API spec. The PR marks some endpoints as potentially publicly available. Additionally there should be some kind of setting to control this on a per-deployment basis.


[doc] Add PlantUML diagrams for Venice

Summary, imperative, start upper case, don't end with a period

Added plantUML codes to the repo.
How was this PR tested?

https://adamxchen.github.io/venice/docs/architecture/venice_write_path
Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

Is there any way to render it for the venicedb.org ?

Is there any way to render it for the venicedb.org ?

Yes, we can do it!

@FelixGV please review when you get the chance! Appreciate the feedback and have updated the docs per the suggestions.


rename package so that it doenst mix with parent repo

Is your feature request related to a problem? Please describe.
Ive just spent a really long time not understanding why it ionic/cordova kept telling me that the plugin i was trying to remove was not added.
turns out to remove the old plugin i was taking you add command and replacing it with rm but since the order of the words changed
i also tried doing the oposite. i went to the ionic docs copy pasted their recommended install script and removed the autoh assuming it you pick up yours
Describe the solution you'd like
a rename of the project in the repos so something move obvios like 'https://github.com/HarelM/cordova-plugin-background-geolocation-sdk31'

I've tried to open an issue for the ionic docs, but nothing happened there, so I'm unable to fix this.
Regarding the name, is not specific to android etc so I don't have a better general name.
I also don't want to create a new package and deprecate this one.
Bottom line, changing the name will do more harm than good I believe...
Sorry...

can you maybe add something in the readme?

Feel free to send a PR :-)

Will do


Can you provide version update logs

Do you have version update logs? I used libraries from version 1.5.5-5 and experienced some JNI layer crashes. I would like to check if there are any fixes in your library

I am not planning to write separate change log. I will try to make my commit description more useful for that purpose


Fails to build Docker image

I'm trying to build the Docker image from master (80f7a24550e2633473cb3f0bc46916f6c72dcb32)  or the latest released version (v4.2.0) following these directions without success.
Here's the abbreviated output of docker build --rm -t passcore .:
...
Step 11/19 : RUN dotnet restore
 ---> Running in 20aec670e369
/usr/share/dotnet/sdk/2.2.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(137,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Core 3.0.  Either target .NET Core 2.2 or lower, or use a version of the .NET SDK that supports .NET Core 3.0. [/app/src/Unosquare.PassCore.Web/Unosquare.PassCore.Web.csproj]
/usr/share/dotnet/sdk/2.2.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(150,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Standard 2.1.  Either target .NET Standard 2.0 or lower, or use a version of the .NET SDK that supports .NET Standard 2.1. [/app/src/Unosquare.PassCore.Common/Unosquare.PassCore.Common.csproj]
/usr/share/dotnet/sdk/2.2.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(150,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Standard 2.1.  Either target .NET Standard 2.0 or lower, or use a version of the .NET SDK that supports .NET Standard 2.1. [/app/src/Zyborg.PassCore.PasswordProvider.LDAP/Zyborg.PassCore.PasswordProvider.LDAP.csproj]
/usr/share/dotnet/sdk/2.2.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(150,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Standard 2.1.  Either target .NET Standard 2.0 or lower, or use a version of the .NET SDK that supports .NET Standard 2.1. [/app/src/Unosquare.PassCore.PasswordProvider/Unosquare.PassCore.PasswordProvider.csproj]

When I back down to 4.1.0, the build gets much further, but then fails with the same error message as reported in #363.
Thus, it appears that this is a breakage due to the .NET 3.0 update. I see 2.2 all over in the Dockerfile so I'm assuming that was missed.

I am working through build issues now.

Great! Thank you.

@JonathonReinhart can I close this issue?

Yes thank you


Error running packer build in centos7 directory of geerlingguy/packer-boxes repo

Hi,
I run the above command and everything works fine until I get to this break point, which is in main.yml of this repo. Has anyone seen this before?
virtualbox-iso: TASK [geerlingguy.packer_rhel : Get Vagrant's public key.] *********************
virtualbox-iso: fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "dest": "/home/vagrant/.ssh/authorized_keys", "elapsed": 0, "msg": "Request failed: <urlop
en error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:618)>", "url": "https://github.com/mitchellh/vagrant/raw/master/keys/vagrant.pub"}

Thanks,
Eoghan

I see that the above URL now redirects to https://raw.githubusercontent.com/hashicorp/vagrant/master/keys/vagrant.pub
Unsure if this would cause an issue

Tried same again while not on the company network and it worked! Must be firewall-related


Reply to this email directly, view it on GitHub https://github.com/datasciencemasters/go/issues/169?email_source=notifications&email_token=AAJMXIGBL3QWD4RPUR6VJM3RFALKXA5CNFSM4K5CCP42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFXQFI#issuecomment-592148501 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMXIBVSWXY43GW4LUJ3CLRFALKXANCNFSM4K5CCP4Q .


Instance-level history fullUrl is wrong when resource id begins with resource type name

Describe the bug
While testing instance-level history, I noticed that the Bundle.entry.fullUrl we are returning are duplicating the resource type in their paths when the resource id starts with the resource type name (e.g. "Patient1")
Looks like this is the same as #2965 except for fullUrls (instead of location URIs)
Environment
main
To Reproduce
Steps to reproduce the behavior:

create a resource on the server with an id that begins with a resource type name (e.g. Patient/Patient1)
retrieve the instance-level history (e.g. Patient/Patient1/_history)

Note that the fullUrl contains an extra type in the path (e.g. https://localhost:9443/fhir-server/api/v4/Patient/Patient/Patient1)
Expected behavior
The fullUrl should be the correct URL to the resource
Additional context
I also noticed a couple other differences between our instance-level history and the new system and type-level history endpoints.

instance-level history returns a fullUrl that includes the full base url of the server whereas our new system and type-level history responses which include only a relative URL.
instance-level history includes (Response.status, Response.etag, and Response.lastModified) whereas the system and type-level history responses include (Response.status, Response.location, and Response.lastModified)
instance-level history sets Response.status to "200" for creates; system and type-level history set these to "201 Created"

For number 1, I actually think the instance-level interaction is more correct... @punktilious how costly would it be to return full url instead of relative url in our system and type-level history responses?
For number 2, I think we should add Response.location to the instance-level response.  Maybe a separate ticket?
For number 3, I think we should modify the instance-level response to use 201 for creates to match.  We should also be consistent as to whether we include just the numerical HTTP response code ("200") or also include the response code title ("200 OK").  Separate issue?

pointed to account for the changes in "additional context" as well

For number 3 (200 vs 200 OK) I check our current batch processing code and we use the number without the string there, so lets normalize on that (i.e. change the system-level history to match)

verified that the _history full url is now correct with a couple of different resources. Closing issue


Can not change notebook font family and font size

Description
I can't change notebook font family and font size while I can do it with non-app jupyterlab.
Reproduce

Go to 'Settings'
Click on 'Notebook'
Fill 'Font family' with 'Roboto Mono'
Fill 'Font Size' with 16
Save, but nothing been changed.

Does restarting app help?

I just tried changing Font Size and it worked even without restart. There are three fields for Font Size (separate for code cells, markdown cells, and raw cells). Can you double-check that you edit the right one?

@flerxu is this still an issue? can you test with the latest version and update the issue?

I cannot change the fontFamily for the code cell after setting it in theme settings, notebook settings, text editor, code mirror.
Jupyter lab abb 4.0.0
macos 13.3
I've restarted the app, server, and computer several times
The output changes to the correct font but the cell is unchanged

The same is true with a console:

Theme preferences:
{
    "theme": "JupyterLab Dark",
    "theme-scrollbars": true,
    "overrides": {
        "code-font-family": "consolas",
        "code-font-size": null,
        "content-font-family": null,
        "content-font-size1": null,
        "ui-font-family": null,
        "ui-font-size1": null
    }
}

Notebook prefs
{
    "codeCellConfig": {
        "codeFolding": true,
        "lineWrap": false,
        "customStyles": {
            "fontFamily": "consolas",
            "fontSize": null,
            "lineHeight": null
        },
        "fontFamily": "consolas"
    }
}

text editor prefs:
{
    "scrollPastEnd": true,
    "toolbar": [],
    "editorConfig": {
        "fontFamily": "consolas",
        "customStyles": {
            "fontFamily": "consolas",
            "fontSize": null,
            "lineHeight": null
        }
    }
}

same issue... confused me a day

Installing a version earlier than 4.0.0 fixed the font issue.

@mef51 @lcd522 JupyterLab v4.0.1 was released yesterday fixing font family setting (https://github.com/jupyterlab/jupyterlab/pull/14601). Could you please try the latest release and confirm whether this is still an issue?

@krassowski looks fixed! The font is correct. Thanks

Hi, I still experience this issue on the latest version of JupyterLab desktop. Updating to the latest version seems to have "overwritten" the original font family (it is now a different font after the upgrade) and also made it impossible to change to other font family. Not sure if related but I'm on a mac

Hey @krassowski
could you take a look and possibly reopen this? Thank you :)

What happens if you remove the custom theme?

If by "remove" you mean "unselect" - I can adjust the font family using one of the 2 default themes.
I guess that means adjusting the font family is not possible with the custom theme. However the custom theme has been rendering just fine until I recently upgraded to the latest version of JupyterLab - since the recent update, the theme's default font seems to have been overwritten and cannot be adjusted.
The custom theme itself is via pip install and has not been updated for more than a year so I would think this has to do with JupyterLab.

I found in 4.0.9 and 4.0.10, the font family issue is still exist. I can't change the font in "notebook" settings, but finnaly I successfully change the font by modify the "fontFamily" in "theme" settings.


Improve article 1909.10893 : overlap between 2 side-by-side tabular-in-minipage-in-resizebox

Exact location of issue
The problem occurs in Table 1: Copying task ...,  of Section 4.1.1 "Copying Task", of article /html/1909.10893, "Recurring Independent Mechanisms"
Problem details

The authors are laying out two results tables, side by side, in one table-with-caption float.
In the source, they do this with a \begin{table*} environment, which contains two \resizebox; each resizebox contains a \minipage, which contains a  \tabular environment.
In the rendered HTML, the two results tables are both about one-sixth of their width over the centerline, and as a result have 30% overlap. They leave empty space on either side, compared to the normal-width caption.
NB: it may look like there are 3 tables being smooshed together; but it's just 2 tables. The right table has some header cells that stick out and break up its silhouette.

(Optional) Expected behavior
Two tables, side by side.
Desktop

OS: Linux Mint (based on Ubuntu, based in Debian)
Browser: both Firefox and Vivaldi (based on Chromium) display this problem

Screenshots
This is what the Ar5iv rendering looks like:

And this is what the PDF rendering looks like:

Additional context: source code
This is the source code of the table* environment:
\begin{table*}[t]
%\vspace{-5mm}
\footnotesize
%\centering
\resizebox{0.36\columnwidth}{!}{
\begin{minipage}[t]{0.4\textwidth}
  % --- language table
  \begin{tabular}{p{1.3ex}rrr|r|r}
  \toprule
  \multicolumn{4}{l|}{\textbf{Copying}} &
  \multicolumn{1}{c|}{\textbf{Train(50)}} &
  \multicolumn{1}{c}{\textbf{Test(200)}} \\
  & \parbox{2em}{$k_\textrm{T}$} & $k_\textrm{A}$ & $h_\textrm{size}$ &
  CE &
  CE \\
  \midrule
  \multirow{4}{*}{\rotatebox{0}{\parbox{2.5em}{\textbf{RIMs}}}}
  %& 6 & 5 & 600 & 0.01 & 0.35 \\
  & 6 & 4 & 600 & \textbf{0.00} & \textbf{0.00} \\
  & 6 & 3 & 600 & \textbf{0.00} & \textbf{0.00} \\
  & 6 & 2 & 600 & \textbf{0.00} & \textbf{0.00} \\
  & 5 & 2 & 500 & \textbf{0.00} & \textbf{0.00} \\
%  & 5 & 2 & 500 & \textbf{0.00} & \textbf{0.00} \\
%  & 5 & 2 & 500 & \textbf{0.00} & \textbf{0.00} \\
%  & 4 & 2 & 400 & \textbf{0.00} & \textbf{0.00} \\
%  & 4 & 2 & 400 & \textbf{0.00} & \textbf{0.27} \\
  \midrule
  \multirow{2}{*}{\rotatebox{0}{\parbox{2.5em}{\textbf{LSTM}}}}
  & - & - & 300 &  0.00 & 4.32 \\
  & - & - & 600 &  0.00 & 3.56 \\
  \midrule
  \multirow{1}{*}{\rotatebox{0}{\parbox{2.5em}{\textbf{NTM}}}}
  & - & - & - &  0.00 & 2.54 \\
  \midrule
  \multirow{1}{*}{\rotatebox{0}{\parbox{2.5em}{\textbf{RMC}}}}
  & - & - & - & 0.00 & 0.13 \\
  \midrule
  \multirow{1}{*}{\rotatebox{0}{\parbox{2.5em}{\textbf{Transformers}}}}
  & - & - & - & 0.00 & 0.54 \\
  \bottomrule
  \end{tabular}
\end{minipage}}
\hspace{3.3em}
\resizebox{0.36\columnwidth}{!}{
\begin{minipage}[t]{0.4\textwidth}
  % --- language table
  \begin{tabular}{p{1.3ex}rrr|r|r|r}
  \toprule
  \multicolumn{4}{l|}{\textbf{Sequential MNIST}} &
  \multicolumn{1}{c|}{\textbf{16 x 16}} &
  \multicolumn{1}{c}{\textbf{19 x 19}} &
  \multicolumn{1}{c}{\textbf{24 x 24}} \\
  & \parbox{2em}{$k_\textrm{T}$} & $k_\textrm{A}$ & $h_\textrm{size}$ &
  Accuracy &
  Accuracy &
  Accuracy \\
  \midrule
  \multirow{4}{*}{\rotatebox{0}{\parbox{2.5em}{\textbf{RIMs}}}}
  & 6 & 6 & 600 & 85.5 & 56.2 & 30.9\\
  & 6 & 5 & 600 & 88.3 & 43.1 & 22.1 \\
  & 6 & 4 & 600 & \textbf{90.0} & \textbf{73.4} & \textbf{38.1}  \\
  \midrule
  \multirow{2}{*}{\rotatebox{0}{\parbox{2.5em}{\textbf{LSTM}}}}
  & - & - & 300 &  86.8 & 42.3 & 25.2 \\
  & - & - & 600 &  84.5 & 52.2 & 21.9\\
  \midrule
  \multirow{1}{*}{\rotatebox{0}{\parbox{2.5em}{\textbf{EntNet}}}}
  & - & - & - &  89.2 & 52.4 & 23.5 \\
  \midrule
  \multirow{1}{*}{\rotatebox{0}{\parbox{2.5em}{\textbf{RMC}}}}
  & - & - & - &  89.58 & 54.23 & 27.75 \\
  \midrule
  \multirow{1}{*}{\rotatebox{0}{\parbox{2.5em}{\textbf{DNC}}}}
  & - & - & - &  87.2 & 44.1 & 19.8 \\
  \multirow{1}{*}{\rotatebox{0}{\parbox{2.5em}{\textbf{Transformers}}}}
  & - & - & - &  \textbf{91.2} & 51.6 & 22.9 \\
  \bottomrule
  \end{tabular}
\end{minipage}}
\caption{Performance on the copying task (left) and Sequential MNIST resolution generalization (right).  While all of the methods are able to learn to copy for the length seen during training, the RIMs model generalizes to sequences longer than those seen during training whereas the LSTM, RMC, and NTM degrade much more.  On sequential MNIST, both the proposed and the Baseline models were trained on 14x14 resolution but evaluated at different resolutions (averaged over 3 trials).
}
\label{tb:copy_mnist}
\vspace{-4mm}
\end{table*}

Thank you for the detailed report!
Cross-referencing latexml #1797.
I am indeed aware (and saddened by) minipages currently almost always looking broken on the ar5iv site. They need a bit of focused attention on the latexml side, possibly deciding on a flexbox approach, and then a little bit of CSS styling.
Certainly to be fixed in the mid-term future.

I made some progress here (as part of a wider CSS styling run), and the tables will no longer clash.
Sadly, in some browsers there is now an over-correction. In Firefox in particular, the two subtables end up even vertically spaced out. So I'll keep this issue open a little while longer.

Sadly, in some browsers there is now an over-correction. In Firefox in particular, the two subtables end up even vertically spaced out. So I'll keep this issue open a little while longer.

This has flipped back to a clash, as we just had an update with latexml v0.8.8 where the subfigure markup was adapted, and the CSS hasn't caught up. Making a note to revise table 1.


Xp Tracking overlay

Hey there,
Really love your work with the CustomizableXpDrops plugin, I use it all the time, and really appreciate that you built it!
I made a few changes to add a custom Xp Tracker overlay. By default this overlay would be turned off, and the user can turn it on in the config settings under a new config section called xp_tracker_settings. It's a more minimalist approach to the xp tracker, removing the default xp tracker overlay, and showing only the numbers and icon of the skill you're currently tracking. Icons can also be turned off. There is a picklist of the skills that you can display on the xp Tracker, including your overall xp, or showing the xp of the most recent skill the player gained xp in. Other small adjustments can be made including the font size, and color of the xp tracker numbers.
Really hoping to see this added into your plugin. It's something that I would love to use personally, and I don't believe that it detracts from any of the other work that you've done on this plugin, and instead is just a simple addition.
Thanks again!

Thanks i will check it when i have time.

See https://github.com/runelite/plugin-hub/pull/2663 for final implementation. I hope I kept your intended behavior. Thank you for your contribution.

Yeah appreciate the updates! This was my first attempt at contributing to a plugin, so I'm more than happy with changes that bring it more inline with the rest of your implementation. Thanks for taking the time to look over it, and accepting my contributions!


Add a istioctl manifest uninstall option

users should be able to run istioctl manifest uninstall in favor of using manifest generate > file.yaml and then kubectl delete -f file.yaml
there could be a flag to delete everything (crd's, other global resources) or just the control plane?

I think this will be a nice addition and quite easy to implement, bumping up to P1.

Should https://github.com/istio/istio/issues/19292 (removing non-current CRDs) be part of this?

What should we uninstall?  The namespace where Pilot was deployed, the webhook, and some resources deployed to other namespaces?
The intention of this issue is to reverse Apply, not Create.  We don't always know which things in the manifest were created and which existing things were used by the manifest.
On PR https://github.com/istio/istio/pull/20766 @howardjohn pointed out that if we uninstall all the namespaces "apply", we are in danger of deleting a namespace such as "telemetry" because the install put some configs there.
For my initial prototype PR I started with the strategy @jwendell asked for in the issue "users should be able to run istioctl manifest uninstall in favor of using manifest generate > file.yaml and then kubectl delete -f file.yaml".  My first version just generated and deleted.  A correct implementation can't do that for the reasons discussed on the PR.

users should be able to run istioctl manifest uninstall in favor of using manifest generate > file.yaml and then kubectl delete -f file.yaml
there could be a flag to delete everything (crd's, other global resources) or just the control plane?

CRDs, as per environments workgroup prior policies, should never be deleted - they should instead always be leaked to prevent data loss of configuration information.
Deleting the control plane sounds good in theory - in practice, it is very difficult to properly clean a control plane. One major source of trouble are webhooks. When a namespace is deleted that a webhook is connected with, the webhook fails on future installs to that namespace. I believe this is a fundamental design flaw in K8s, but what do I know, I'm just an expert in strategic analysis.

The condition of deleting CRs needs careful consideration. Deleting CRs that Istio installs, and are exact duplicates of the intalled CRs is ok - any other CR deletion is not ok. @esnible I think this is the logic you seek.
The challenge with deleting a namespace as @howardjohn implied, is some of these (shouldn't be deleted CRs because they were installed by the end user) end up in the namespace of the application. In this case a namespace deletion isn't the right solution.
The @istio/wg-environments-maintainers has a strict policy of no customer data loss.

The problem gets worse when we have multiple control planes as well. We will need to be careful about what is a shared resource (not many, likely just webhooks+CRD) and what is not. If we want, we could go with a --really-really-really-delete-everything flag and just kill everything, but the default should be err on the side of caution I think

Besides, who wants to delete Istio :wink:

One implementation option you have availble to you is to delete any resource created by the operator. These have ownerrefs (K8s will clean these up automatically) - or annotations (not clear on why we use annotations rather than ownerrefs to the control plane CR...).
One possible solution to this is to ensure ownerrefs are used in all objects installed by the operator (rather than a mix of annotations and ownerrefs as used today). If this were the case, simply deleting the control plane CR would delete the installation correctly.
Getting the ownerrefs set properly is not an easy implementation.

The problem gets worse when we have multiple control planes as well. We will need to be careful about what is a shared resource (not many, likely just webhooks+CRD) and what is not. If we want, we could go with a --really-really-really-delete-everything flag and just kill everything, but the default should be err on the side of caution I think

As long as --really-really-really-delete-everything still results in leakage of the user's CRs, and Istio's CRDs, this meets the no data loss policy and wfm 👍

The problem gets worse when we have multiple control planes as well. We will need to be careful about what is a shared resource (not many, likely just webhooks+CRD) and what is not.

Great point @howardjohn - If you can list the shared resources you are aware of (CRDs and webhooks are the obvious ones, wonder if there are any others lurking in the implementation) - we must not delete these on a cleanup.

Definitely shared is the namespace, CRDs, possibly some of the default CRs we install (mesh policy, default destination rules, etc), the validation webhook. We will also likely share the addon stuff (part of why the "bring your own addon" is appealing), which is probably the most problematic here since we can't just do some heuristic like "delete all deployments"

This is a very difficult problem to solve correctly, however, adds significant value to Istio.
The use case of Istio deletion is simple:
When evaluating Istio, you might install and uninstall it 30-60 times (this has been my experience in prior projects) - trying different things out until you find the setup that works for you. If deletion = I gotta delete my cluster (as is the case today.... GROAN) - the user experience during product evaluation - where the experience should be gold plated - is pretty terrible.

@ayj in the linked PR, you mentioned something about webhooks and their ownerrefs that I didn't quite understand. Would you mind explaining what would be the best way to proceed given the exchange in this thread and assuming helm used in prior versions is long gone?
Cheers
-steve

For a while I have been asking that the IstioOperator/IstioControlPlane CR used to install Istio be preserved on the cluster to document the user's intention.  https://github.com/istio/istio/issues/20000
If the command line creates the CR in cluster we could use OwnerRef against that resource for everything that is unique to that install.

Here are some options for how we can manage the lifecycle of webhook configuration.
Option 1

validatingwebhookconfiguration ownerRef is the istio-system namespace. Deleting the istio-system namespace deletes the validation. helm template | kubectl delete will leak the config.

Option 2

validatingwebhookconfiguration ownerRef is the istiod/istio-galley clusterrole
Deleting the clusterrole deletes the webhook.  helm template | kubectl delete works (good) but deleting the istio-system namespace now leaks the config (bad). From personal experience, option (1) is more obvious than option (2). I frequently delete the namespace to "reset" during development. I rarely cleanup the clusterroles and instead rely on updating to the latest during testing.

Option 3

make validatingwebhookconfiguration at top-level resource that is applied directly just like the mutatingwebhookconfiguration. istiod only needs to patch the caBundle and not reconcile the entire config.
update istioctl / operator / templates to always install the Istio custom resources before applying the validatingwebhookconfiguration. Document that the user shouldn't apply their own config until the webhook is patched. istioctl could also enforce this.

Option 3 is my first choice. It is consistent with how we manage the mutatingwebhookconfiguration. Also, we want to eventually get the webhook control logic out of istiod anyway. This would require some notion of a 'post-installphase in istioctl. istioctl already has apost-install` subcommand to create/patch the webhook config. We could make that the default for 1.5. cc @lei-tang
My second choice would be option 1. This seems more obvious to me than option 2.

This item was briefly discussed at the UX meeting.
@sdake pointed out that currently there is no way to uninstall for technical reasons.  He will work on getting agreement for Uninstall RFC.
Someone, I think Jason, asked "Would uninstall remove sidecars and restart?"
I pointed out that there is a user expectation that the data plane should be removed FIRST before we remove control plane for a version.  No user wants to uninstall istio-system with a bunch of sidecars dependent on it for config.  Whatever we decide on, it must include removing pods from a mesh before removing the control plane.
(Or, once we have multiple control planes working smoothly, pointing those pods at the new global master Istio control plane).

We should probably have a "uninstall" page under "setup" on istio.io. This is especially important if we don't have an uninstall command and the recommended sequence is non-trivial.

Note: on the unrelated document https://docs.google.com/document/d/1d1z5PC8wvh9QiR3NesAaPm6w2HnE4-KIfjB7GB-_Wf8/edit Brian Wolf points out that we "apply" a manifest.  We should use a word that is the opposite of "apply".  "delete?"

Yesterday I learned that Kiali expected istio.io/key-and-cert secrets.  We no longer make them.  manifest delete should probably get rid of them.
It seems manifest apply can't get rid of them because 1.4 sidecars might be using them until those pods restart.  Yet it is confusing for the user to see secrets from an older control plane that are no longer being rotated still living in the cluster.  I propose remove and apply purge any istio.io/key-and-cert secrets containing expired certificates.

Deleting secrets is pretty dangerous, I would recommend we make it an explicit action and not implicit. Would it make sense to offer an extra step to do kubectl delete -listio.io/key-and-cert --all when a user determines its appropriate, or a --delete-secrets to istioctl to explicitly do this? They do not hurt anyone if they are there, but deleting them may cause quite a few issues

@ostromart Added you because we need to work on this together.
I have no problem doing the CLI pieces but I have concern about the removal itself.
Related is https://github.com/istio/istio/issues/23889 , promoting a canary to master.  When we do this we should uninstall the original master at the end of a successful promotion.  That will probably be a manual step.  I am thinking the flow to be something like:
istioctl install --revision canary
kubectl label default istio.io/rev=canary
// wait a few hours, look at metrics, etc
istioctl experimental promote-canary-to-master --revision=canary
kubectl label default istio-injection=enabled
// wait an hour or so
istioctl manifest uninstall --revision canary

@ostromart Is there a design for what will be removed?

Do we think this can be contained for removing a single control plane?
If the master control plane is uninstalled, and there are canaries, will the canary become the master.  (Master means "handles istio-injection=enabled namespaces)
Will removing the CRDs be a different operation or will it happen automatically when the last/master control plane is removed?

https://github.com/istio/istio/issues/23479 may be a dependency for this work.

@richardwxn @ostromart Is this handled by https://github.com/istio/istio/pull/25076 ?  May I close it?


add staticError helper to throw @nogc Errors

Hopefully throwing Error while an Error is in flight shouldn't happen.
After all Error is not recoverable so LGTM

@MartinNowak - address comment by @schuetzm and it should be good to go

Done

Auto-merge toggled on

This pull request introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=14993


Need improved/HTTPS-centric GKE Ingress + ESP + gRPC example

I had a tough time figuring out how to get an Ingress on GKE to behave with ESP, with HTTPS end-to-end. I believe the underlying issues have to do with health checks and readiness probes and how ingress-gke handles those. I commented on the following issue in that project: https://github.com/kubernetes/ingress-gce/issues/18#issuecomment-418262864
Once health checks can be customized, perhaps an update can be made to esp_echo_gke_ingress.yaml.

Hi,
same issue here.
As ESP does not allow root path (https://cloud.google.com/endpoints/docs/openapi/openapi-limitations#operations_on_url_root_path) and Ingress GLB does a health check on / (https://cloud.google.com/kubernetes-engine/docs/tutorials/http-balancer), it seems impossible to configure the GKE Ingress + ESP + gRPC stack.
I'll migrate to another load balancer for the time being

Did you ever make progress on getting grpc-web support through google endpoints?

@jcramb Yes I did.
You can find more details on the grpc-web PR on the esp code.
https://github.com/cloudendpoints/esp/pull/283
It works but only if you use the binary grpc-web wire format which does not support streaming

Hello @alethenorio,
If it's not too much trouble, could you please post the rest of your configuration for grpc endpoint with ssl (service, ingress)? I don't manage to make it work and can't find what I am missing.
thanks

@unludo sure
The configurations above are based on the fictional config I posted in my previous post (so, for example, it should be obvious the secret name pointed by ingress is the same secret mounted in the pod)
My service looks like this (assuming the pod it points to has the label app: myApp)
apiVersion: v1
kind: Service
metadata:
  name: myService
  annotations:
    cloud.google.com/app-protocols: '{"http2":"HTTP2"}'
spec:
  type: NodePort
  ports:
  - name: http2
    port: 8080
    targetPort: 8080
    protocol: TCP
  selector:
     app: myApp

And my Ingress looks like this (Assuming use of let's encrypt through cert manager
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: myService-ingress-endpoints
  annotations:
    kubernetes.io/tls-acme: "true"
    kubernetes.io/ingress.class: "gce"
    certmanager.k8s.io/acme-http01-edit-in-place: "true"
    certmanager.k8s.io/cluster-issuer: "letsencrypt-prod"
    certmanager.k8s.io/acme-challenge-type: "http01"
 spec:
   tls:
   - hosts:
     - "myapp.endpoints.myprojectID.cloud.goog"
     secretName: ingress-tls
   backend:
     serviceName: myService
     servicePort: 8080


Demo Bitcoin SPV (Simplified Payment Verification) in smart contract

#798 demos how to verify a Bitcoin transaction. But what does this tell us? A signer signed a transaction. We don't know if this transaction is valid and was executed.
However, we can also do SPV, which checks that a transaction is included in a Bitcoin block. This is more interesting to know, as it is a way for a CosmWasm smart contract to read the Bitcoin chain in a secure way.

Out of scope for now


Nox has been broken by #3551

#3551 has removed nox -s fmt, but it's still used in noxfile line 14:
nox.options.sessions = ["test", "clippy", "fmt", "docs"]

So you get this error:
nox > Error while collecting sessions.
nox > Sessions not found: fmt

I can fix that in a PR, but I need to ask what to do:

put back fmt session
remove fmt from  nox.options.sessions
replace fmt from nox.options.sessions by either rustfmt or ruff, or both.

Ah, my mistake. Please add rustfmt and ruff jobs 👍


[Bug Report] - Multiple controllers are connected to one group of solar panels.

Describe the bug
Multiple controllers are connected to a group of solar panels, and energy is produced from each.
To Reproduce
Steps(2way)
1.Install panels at least 3x3 in size.
2.Place the controller on the west or south side (make sure that there is no controller within a 3 x 3 area around the controller at this time.)
3.A second controller can be placed at any location in any direction except north. Even in the case of north, it can be placed in almost any location. (The law when the second controller is north is not so well understood.)
4.A controller can be installed to the north only if it is installed to the west and south.
4.1 If the second controller is in the opposite direction of the first, no controller can be placed in the third direction.
Another way
1.If the controller is installed first, it is not affected in any way by the direction in which the controller is installed. (The same applies even if the surrounding blocks are updated.)
Expected behavior
As a result, each controller outputs exactly the same amount of energy as the output energy for the same number of panels.
As an example, assuming 200 panels connected by one controller outputs 200, 200 panels connected by 3 controllers output 600.
Screenshots
If applicable, add screenshots to help explain your problem.
Mod Info (please complete the following information):

Forge: 40.1.76
MC Version: 1.18.2
Mod Version: Miniutilities 2.0.0 Lemonlib 2.1.1

Additional context
We recommend trying multiple patterns because the behavior is very puzzling when the panel is already in place.
Although the generation rate appears to have been changed, the behavior was exactly the same before the change.

Fixed


ani-cli: 2.2 -> 3.2

Description of changes
https://github.com/pystardust/ani-cli/releases/tag/v3.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested on:

[ NixOS ]

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Please also rebase on master to resolve the merge conflict after #183135

Please also rebase on master to resolve the merge conflict after #183135

@SuperSandro2000
should I change the git commit message too ??If yes what to ?  because ani-cli is already been updated to 3.3 , which is broken and my commit will just fix it not actually update the package.

Oops just now rechecked ani-cli is working as expected, so need for this.


What should the EXE be?

Should the exe configuration given to the new MSICreator point to he application setup .exe file (generated from electron packager / electron builder) or the .exe file of the installed application itself?

@felixrieseberg this is very confusing!
I thought it would be the .msi 's name, otherwise there will be no way to set the msi's name!

How to set msi name?


current quicksettings version is incorrect

https://cdn.jsdelivr.net/quicksettings/3.0/quicksettings.min.js
search for version

it still version 2.1

fixed. not that it was used for anything.

sure, it is kinda stupid I found out. I was updating old <3 code
Great work btw: thx

All good. Keep any feedback coming. I appreciate it.


[libyuv]Build corresponding type library according to BUILD_SHARED_LIBS.

Related: #8786.

@vicroms ready to merge now.


[WIP] Release 0.26.0

Preview at https://github.com/bcardiff/crystal/blob/changelog/0.26.0/CHANGELOG.md
Note: I still need to convert PR references to links and there are a couple of PR to be merged before this.

I think the last two changes belong to Standard Library. And maybe mention that #6333 also added an optional argument to String#check_no_null_byte.

Are there still concerns about this PR?
https://github.com/crystal-lang/crystal/pull/6358

Is #6419 going to be included in 0.26.0 or is that going to have to wait until the next release?

Windows should be uppercase, not lowercase.

@wdhwg001 it was, but I double check with in other places in docs and lower case was used.


[FR] Full support for OSB Context + originating-identity-header in request variable

Is your feature request related to a problem? Please describe.
As a brokerpak author

in order to apply some processing depending on OSB client metadata (such as opening network ACLs depending on caller, or recording audit traces for caller metadata such as  organization_name, space_name, instance_name or K8S namespace)
I need Osb context and Originating Identity Header to be exposed to brokerpak Terraform templates

Describe the solution you'd like
A new request.context field in the existing request variable. This field would contain the full context JSON object as a map, including the platform field with values among cloudfoundry and kubernetes
A new request.x_broker_api_originating_identity field in the existing request variable. This field would contain the base64 decoded full JSON object as a map, eg.
for cloudfoundry
{
  "user_id": "683ea748-3092-4ff4-b656-39cacc4d5360"
}

and for K8S:
{
  "username": "duke",
  "uid": "c2dde242-5ce4-11e7-988c-000c2946f14f",
  "groups": [ "admin", "dev" ],
  "extra": {
    "mydata": [ "data1", "data3" ]
  }
}

Describe alternatives you've considered
The existing request.default_labels are exposing and mapping part of the Osb context for cloudfoundry but are missing

the kubernetes profile fields such as namespace
the cloud foundry profile fields organization_name, space_name, instance_name,

Additional Context

Priority

Priority Context

Platform

Applicable Services

/CC @mlesaout

@gberche-orange We have marked this issues as "help wanted" which means we are seeking contributions to help close out this issue. Unfortunately, not a top priority for the team at the moment, please let us know how we can assist.
CC: @erniebilling @svennela

thanks @omerbensaadon for reviewing this suggestion.
My team might be able to contribute this support in the future. Graduating the project as a Cloud Foundry Foundation project will certainly foster our contributions to the project. Any chance to progress on this topic (related slack thread available for community interest) ?

@gberche-orange Looks like we were accepted! Speaking with someone from the CF Extension team today 👍🏼

awesome, thanks @omerbensaadon !

@gberche-orange We took a shot at implementing this functionality for provision/deprovision. Would you mind taking a look at the PR and checking that's what you were expecting? If so we can add to bind/unbind as well.
Thanks!

thanks a lot @pivotal-marcela-campo ! I plan to review PR by monday.

@pivotal-marcela-campo

Would you mind taking a look at the PR and checking that's what you were expecting? If so we can add to bind/unbind as well.

This perfectly matches my use-case. Thanks !
This would be great to have the same for bind/unbind, and possibly update service instance

Glad to see some movement on this! Thank you @pivotal-marcela-campo :)

This has been implemented and available to use from any custom brokerpak. Closing.


Update Master

Update master

Better to let the PR do the merge.

I went ahead and did the merge locally, rather than let the PR do the merge.


qnamakerTools ends dialog twice

In the answerSelection dialog the second function the endDialog is called twice once with Result and once more later... any reason why twice?
            function (session, results) {
                if (results && results.response && results.response.entity) {
                    var qnaMakerResult = session.dialogData.qnaMakerResult;
                    var filteredResult = qnaMakerResult.answers.filter(function (qna) { return qna.questions[0] === results.response.entity; });
                    if (filteredResult !== null && filteredResult.length > 0) {
                        var selectedQnA = filteredResult[0];
                        session.send(selectedQnA.answer);
                        session.endDialogWithResult(selectedQnA);
                    }
                }
                else {
                    session.send("Sorry! Not able to match any of the options.");
                }
                session.endDialog();
            },

This is causing parent dialogue calling qnamakerdialog behave erratically esp when overriding the defaultWaitNextMessage which is doing some beginDialog work...
Can we remove the second endDialog? which is anyway the last statement in the answerSelection dialog?

Thank you for opening an issue against the Bot Framework Cognitive Services repo. As part of the Bot Framework v4 release, we’ve moved all the Luis and QnA work to platform SDK repo. We will continue to support and offer maintenance updates via this repo.
From now on, https://github.com/Microsoft/botframework-sdk repo will be used as hub, with pointers to all the different SDK languages, tools and samples repos.
As part of this restructuring, we are closing all tickets in this repo.
For defects or feature requests, please create a new issue in the Bot Framework repo found here:
https://github.com/Microsoft/botframework-sdk/issues
For product behavior, how-to, or general understanding questions, please use Stackoverflow.
https://stackoverflow.com/search?q=bot+framework
Thank you.
The Bot Framework Team


[ISSUE #4332] Remove duplicate code

What is the purpose of the change
Remove duplicate code in Level#toLevel.
Brief changelog
Remove duplicate code in Level#toLevel.

Codecov Report

Merging #4331 (5704c0c) into develop (7982c9c) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4331      +/-   ##
=============================================
- Coverage      48.19%   47.97%   -0.22%
+ Complexity      5085     5057      -28
=============================================
  Files            642      642
  Lines          42767    42765       -2
  Branches        5598     5597       -1
=============================================
- Hits           20610    20516      -94
- Misses         19649    19728      +79
- Partials        2508     2521      +13

Impacted Files
Coverage Δ

.../java/org/apache/rocketmq/logging/inner/Level.java
39.58% <ø> (+1.58%)
:arrow_up:

.../broker/subscription/SubscriptionGroupManager.java
64.70% <0.00%> (-16.48%)
:arrow_down:

...rg/apache/rocketmq/common/stats/StatsSnapshot.java
84.61% <0.00%> (-15.39%)
:arrow_down:

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
66.07% <0.00%> (-10.72%)
:arrow_down:

.../apache/rocketmq/common/stats/MomentStatsItem.java
38.09% <0.00%> (-9.53%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
44.77% <0.00%> (-8.96%)
:arrow_down:

...ache/rocketmq/common/stats/MomentStatsItemSet.java
39.13% <0.00%> (-8.70%)
:arrow_down:

...in/java/org/apache/rocketmq/test/util/MQAdmin.java
38.88% <0.00%> (-5.56%)
:arrow_down:

...va/org/apache/rocketmq/common/stats/StatsItem.java
50.83% <0.00%> (-4.17%)
:arrow_down:

...lient/impl/consumer/DefaultMQPushConsumerImpl.java
39.96% <0.00%> (-3.88%)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7982c9c...5704c0c. Read the comment docs.

Coverage decreased (-0.2%) to 52.052% when pulling 5704c0cd1c0d6c79a83b7ab06edd260d7535284b on coderbruis:REMOVE_DUPLICATE_CODE into 7982c9c09a9da754f42d0cf46dd5ddaa9d2c7be1 on apache:develop.

Coverage decreased (-0.2%) to 52.052% when pulling 5704c0cd1c0d6c79a83b7ab06edd260d7535284b on coderbruis:REMOVE_DUPLICATE_CODE into 7982c9c09a9da754f42d0cf46dd5ddaa9d2c7be1 on apache:develop.


Not working on my machine. Does it on yours?

As per the README, I wrote nothing:

and then ran the correct build command:

but it still isn't working. HALP.

The problem is that you ran a build command. If you run the following command instead, it should work perfectly:
``