Solomon/pagination filtering sorting

Add pagination, filtering and sorting for questions, and populate.go to reset and repopulate the firebase.
Supports filtering by:

title
complexity
categories

Supports sorting by:

complexity
createdAt
id
title
Note Only one sort field query parameter should exist.

TODOS:

Currently, filtering by categories works by checking if categories array in firebase match any of the categories in the query parameters. This will be changed displaying questions where selected categories ⊆ categories array in firebase.
Currently, complexity is being sorted by lexicographical order, this will be changed to be sorted by actual order of complexity.
This changes are internal backend implementations and will not affect the API, this version is being pushed to enable frontend.

Testing:

Manual test cases included at the end of list.go
Will be good reference to understand how the API works

Possible amendments to TODOS point 1:

I think we can implement it such that as long as selected categories ⊆ categories array in firebase, we can display it.

Possible amendments to TODOS point 1:

I think we can implement it such that as long as selected categories ⊆ categories array in firebase, we can display it.

Agreed, updated TODOs


Problem when executing defects4j test for the bug 1 project lang

After succesfully checkout and compiling the source code I have the following problem with the compilation of the unit test.
 defects4j test

Buildfile: /home/moar82/r/xx/defects4j/framework/projects/defects4j.build.xml
init:
[echo] -------- commons-lang3 3.2-SNAPSHOT --------
compile:
compile.tests:
[javac] Compiling 42 source files to /home/moar82/r/xx/lang_1_buggy/target/tests
[javac] warning: [options] bootstrap class path not set in conjunction with -source 1.5
[javac] warning: [options] source value 1.5 is obsolete and will be removed in a future release
[javac] warning: [options] target value 1.5 is obsolete and will be removed in a future release
[javac] warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
[javac] /home/moar82/r/xx/lang_1_buggy/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java:524: error: incompatible types: inferred type does not conform to upper bound(s)
[javac]         final Integer max = TypeUtilsTest.stub();
[javac]                                               ^
[javac]     inferred: G
[javac]     upper bound(s): Comparable,Integer
[javac]   where G is a type-variable:
[javac]     G extends Integer
[javac] 1 error
[javac] 4 warnings
BUILD FAILED
/home/moar82/r/xx/lang_1_buggy/build.xml:71: Compile failed; see the compiler error output for details.
Total time: 14 seconds

Any suggestion?

Hi @moar82 ,
What Java version are you using?
Thanks,
René

Hi, I'm using Java 1.8. I modified the build.xml of the ant script  to pass
the argument source=1.5.  That solved the error when compiling the source
code , but not for the unit tests.
Any idea?
On Nov 2, 2016 8:11 PM, "René Just"<EMAIL_ADDRESS>wrote:

Hi @moar82 https://github.com/moar82 ,
What Java version are you using?
Thanks,
René
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rjust/defects4j/issues/48#issuecomment-258037270, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFRDrZ2NGrQ4rvd6Z5KIC5dDnebswP88ks5q6SbIgaJpZM4Kn4gb
.

Please note that Defects4J requires Java 7. Using Java 8 causes some of the developer-written tests to fail, even though they are unrelated to the defect. This might lead to unexpected results.
Can you use Java 7 for your project? If not, can you please briefly explain what you are trying to do? Depending on your use case, you might be able to work with the java-8-support branch, which solves the compilation issues, but you will still face the problem of unexpectedly failing developer-written tests.

I see René.  I have another question.  Is it possible to generate the unit
tests with evosuite or randoop to substitute the original tests from the
developer, and then compute the coverage over those tests?
I want to modify the code and then generate the new unit tests, do you know
how can I achieved that?
Kind regards,
Rodrigo.
On 2 November 2016 at 21:54, René Just<EMAIL_ADDRESS>wrote:

Please note that Defects4J requires Java 7. Using Java 8 causes some of
the developer-written tests to fail, even though they are unrelated to the
defect. This might lead to unexpected results.
Can you use Java 7 for your project? If not, can you please briefly
explain what you are trying to do? Depending on your use case, you might be
able to work with the java-8-support branch, which solves the compilation
issues, but you will still face the problem of unexpectedly failing
developer-written tests.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rjust/defects4j/issues/48#issuecomment-258049414, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFRDrRqXcTIH78LHtgUq5wseYVZBlMzIks5q6T7tgaJpZM4Kn4gb
.

You can generate unit tests using Randoop and EvoSuite with the following scripts:

run_evosuite

run_randoop

You can compute the code coverage ratios for generated test suites using the
defects4j coverage command. This command takes an optional -s flag, which allows you to specify a generated test suite archive.
Hope this helps,
René

I have some issues when running run_evosuite and run_randoop, because they invoke a wrong jar, for example:

Error: Could not find or load main class randoop.main.Main
Executed command: cd /tmp/run_randoop.pl_12512_1478201914 && java -ea -classpath /tmp/run_randoop.pl_12512_1478201914/target/classes:/home/moar82/r/xx/defects4j/framework/lib/test_generation/generation/randoop-current.jar randoop.main.Main gentests --classlist=/home/moar82/r/xx/defects4j/framework/projects/Lang/loaded_classes/2.src --junit-output-dir=randoop --timelimit=200 --randomseed=1002  --clear=10000 --string-maxlen=5000 --forbid-null=false --null-ratio=0.1 --no-error-revealing-tests=true --ignore-flaky-tests=true --only-test-public-members=true 2>&1
Failed to generate tests! at /home/moar82/r/xx/defects4j/framework/bin/run_randoop.pl line 193.

I manually invoked the command replacing randoop-current by randoop-2.1.3.jar which is the current version of my jars.  However, when I tried to compute the coverage:
perl /home/moar82/r/xx/defects4j/framework/bin/d4j/d4j-coverage -w /tmp/run_randoop.pl_12512_1478201914
I got the following error:

Can't locate Constants.pm in @INC (you may need to install the Constants module) (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at /home/moar82/r/tarfplus/defects4j/framework/bin/d4j/d4j-coverage line 96.
BEGIN failed--compilation aborted at /home/moar82/r/tarfplus/defects4j/framework/bin/d4j/d4j-coverage line 96.

I have perl 5.22.2 and I also installed DBI.  I also tried to manually installed the missing library from CPAN, but I cannot find the correct one, since in the script the declaration is not qualified, ex.
use warnings;
use strict;

use FindBin;
use File::Basename;
use Cwd qw(abs_path);
use Getopt::Std;
use Pod::Usage;

use lib abs_path("$FindBin::Bin/../core");
use Constants;
use Coverage;

Do you know what can I do to solve this issue?

Defects4J's init script sets up symbolic links to whatever version of Randoop and EvoSuite it downloads. So, for example for Randoop, the following symlink should exist:
<path>/defects4j/framework/lib/test_generation/randoop-current.jar -> <path>/defects4j/framework/lib/test_generation/randoop-2.1.3.jar
Is this not the case for your set up?

Thanks for mentioning.  Now I found out that because I mounted at windows
drive, I cannot create symlinks.  So probably the initial setup failed, but
the error was hidden in the execution.
For example if I try
[moar82@localhost framework]$ ln -s ./home.txt ./home
ln: failed to create symbolic link ‘./home’: Read-only file system
Which is not completely true as I can create new files, but the symlinks
cannot be created.
Thanks.
On 3 November 2016 at 21:02, René Just<EMAIL_ADDRESS>wrote:

Defects4J's init script sets up symbolic links to whatever version of
Randoop and EvoSuite it downloads. So, for example for Randoop, the
following symlink should exist:
/defects4j/framework/lib/test_generation/randoop-current.jar ->
/defects4j/framework/lib/test_generation/randoop-2.1.3.jar
Is this not the case for your set up?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rjust/defects4j/issues/48#issuecomment-258318780, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFRDrVIPiG-1j0USgyWs6bjwynwasrZsks5q6oQXgaJpZM4Kn4gb
.

I see, the init script should fail but it doesn't. We should definitively fix this. Can I trouble you to file another issue for this?
Does fixing the symlink issue solve your problem?

Concerning the symlink issue, I'm not able to tell, because the problem of the symlink is related to a known bug in virtualbox that I was not aware:
[(https://forums.virtualbox.org/viewtopic.php?f=3&t=47014)]
If I install DefectsJ4 in my linux partition, I guess the symlinks will be created without error.  However, I cannot fix the issue with the current setup, as I cannot create  symlinks in my ntfs partition.
Concerning opening another issue for the initial setup script that did not failed when creating the symlink, I think this would be useful for the people that 1) runs virtualmachine with access to ntfs partitions.

I have created a new issue #49 for the init script, which should fail if an error occurs. That way the issue is more prominent in the issue tracker -- the title of this issue (#48) doesn't indicate the root cause of that problem.
A workaround for your set up (symlinks are not supported on an ntfs partition) is the following:
You can adapt the init script to copy the downloaded versions of the jar files to xyz-current.jar rather than creating symlinks (i.e., replace ln -sf with cp -f).
A more general solution would be to:

check whether symlinks are supported
create a symlink for the jar files if possible
copy the jar files otherwise

If you end up implementing the changes above, it would be great if you could submit a pull request -- I am happy to review and merge these changes in.
Thanks,
René

I am closing this issue for now. Please open a new issue if you run into other problems with Defects4J.
Thanks,
René

$ defects4j info -p Lang
bash: defects4j: command not found
Any help?


Error when starting gdb

When I installed as instructed in README,
$ bash -c "$(curl -fsSL https://raw.githubusercontent.com/lebr0nli/GEP/main/install.sh)"

I've got this error when starting GDB.
File "~/GEP/.gdbinit-gep.py", line 77
    fzf_cmd = [f"awk '!seen[$0]++' {shlex.quote(HISTORY_FILENAME)}"]
                                                                  ^
SyntaxError: invalid syntax

Hi, can you provide the Python version of your GDB? (You can pi sys.version inside GDB)
And it is probably because f-string is a Python 3.6 syntax, and you are using maybe Python 3.5 or something.

@lebr0nli
You're right. Then version of Python(usr/bin/python) was 3.5.2.
Is it possible to use python3 rather than python to avoid this error? This is because python command is often for prebuilt one and what I install is python3.

Is it possible to use python3 rather than python to avoid this error? This is because python command is often for prebuilt one and what I install is python3.

@diohabara, I'm afraid we can't. The only solution is compiling the GDB manually with --with-python=/the/path/to/your/python3 IIRC.
But actually, we can fix this problem by using %-formatting for better compatibility for the lower version.
But yeah, Python 3.5 is really old, should we change the code just for that?
I didn't have this kind of experience, so feel free to share your ideas with me :)

@diohabara
Anyway, I use %-formatting eventually, so the issue should be fixed now.
Let me know if it doesn't work for you.

@diohabara
Anyway, I use %-formatting eventually, so the issue should be fixed now.
Let me know if it doesn't work for you.

Seems there are bugs introduced.
https://github.com/lebr0nli/GEP/pull/4

@qiuwei, I merged that PR now
Thanks for pointing it out!


Cant access codespaces when on VPN

I work for the Department of Veterans Affairs and we need to access Codespaces for a Conference. We have access to Github through our firewall but cannot access Codespaces. In order to access the site, we need to know what is preventing the Codespace from opening up - be it a download, a server issue, a port issue (any other ports besides 443 that we need?) etc.
I attached a photo below of the error

Version: 1.74.3
Commit: 97dec172d3256f8ca4bfb2143f3f76b503ca0534
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/108.0.1462.46
Embedder: codespaces

I was having connectivity issues when connecting via VS Code when connected to VPN. Tried debugging by tinkering with VPN config by switching protocol to OpenVPN (UDP), OpenVPN (UDP), and Wireguard with no luck.
Ended up using a different VPN provider all together and started working. Not sure if the VPN server IPs I was connecting to before were blacklisted... 🤷

Please file an issue in the Codespaces Discussion Forum


Create "defaultProps" type

We can create a DefaultProps type that we join with all our Component types for properties that are present for all our components along with jsdoc that explains it. Much like we have used useFormFieldProps in our form components.
First candidate for this type would be style and className with appropriate jsdoc that describes how they are applied and what users can expect when using them, such as always applied to outermost element.
Related issue #1226

In an effort to reduce code and complexity we decided to close this for now


kubernetes provisioning state succeeded but kubernetes is not installed either.

Facing this issue where provisioning state is successful but kubernetes is not installed. version tried is 1.8.11.
acs engine version is 0.16.0.

deleted resource group multiple times and redeployed kubernetes with different versions as well but same result. Recreated Service principal and tried access to subscription it works
Debugged master node for logs
Kubectl command give below error
The connection to the server 172.18.X.X:8001 was refused - did you specify the right host or port?
Had a look at /var/log/azure/cluster-provision.log and i have copied content below

echo 'Install complete successfully'
Install complete successfully
false
++ date
++ hostname
echo Thu May 3 15:10:06 UTC 2018,k8s-master-26527143-0, endscript
mkdir -p /opt/azure/containers
touch /opt/azure/containers/provision.complete
ps auxfww
root@k8s-master-26527143-0:/var/log/azure# ~docker ps
No command '~docker' found, did you mean:
Command 'kdocker' from package 'kdocker' (universe)
Command 'docker' from package 'docker.io' (universe)
~docker: command not found
root@k8s-master-26527143-0:/var/log/azure# docker ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
root@k8s-master-26527143-0:/var/log/azure# ^C
root@k8s-master-26527143-0:/var/log/azure# kubectl cluster-info dump
The connection to the server 172.18.X.X:8001 was refused - did you specify the right host or port?
root@k8s-master-26527143-0:/var/log/azure# ^C
root@k8s-master-26527143-0:/var/log/azure#

Any help is appreciated.

Hi @gaurav218, can you share the original api model json (excluding credentials) that you used to build the cluster?


Compatible with Symfony 7.0?

Hello,
Just upgraded my Symfony project to 7.0. I'm using PHPFlasher 1.15.3, but when I try composer install, I get the message:
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - php-flasher/flasher-symfony[v1.15.0, ..., v1.15.3] require symfony/console ^2.0 || ^3.0 || ^4.0 || ^5.0 || ^6.0 -> found symfony/console[2.0.4, ..., v2.8.52, v3.0.0, ..., v3.4.47, v4.0.0, ..., v4.4.49, v5.0.0, ..., v5.4.32, v6.0.0, ..., v6.4.0] but it conflicts with your root composer.json require (7.0.*).
    - Root composer.json requires php-flasher/flasher-symfony ^1.15 -> satisfiable by php-flasher/flasher-symfony[v1.15.0, v1.15.1, v1.15.2, v1.15.3].

Is PHPFlasher compatible with Symfony 7.0?
Regards,
Fred

Apparently @yoeunes is busy with it in #163, so we'll just have to be patient 😉

Hello @frdemoulin and @ToshY,
I've just released PHPFlasher v1.15.4 with support for Symfony 7.0. It's not fully tested yet, so I'd appreciate if you could test it in your environment. Please update using:
composer require php-flasher/flasher-symfony ^1.15.4

Let me know if there are any issues. Your feedback will help in deciding whether to close this issue.
Thanks!
Younes

Hey @yoeunes 👋
I can't exactly test it properly until other dependencies in my project support Symfony 7 🙁. I will test it when I'm able to. In the meantime, maybe @frdemoulin could check if it works.

Hello,
I've just updated a project to Symfony 7.0.1. For the moment, I don't see
any problem with php-flasher. Great!
Regards,
Fred
Le sam. 23 déc. 2023 à 19:55, ToshY @.***> a écrit :

Hey @yoeunes https://github.com/yoeunes 👋
I can't exactly test it properly until other dependencies in my project
support Symfony 7 🙁. I will test it when I'm able to. In the meantime,
maybe @frdemoulin https://github.com/frdemoulin could check if it works.
—
Reply to this email directly, view it on GitHub
https://github.com/php-flasher/php-flasher/issues/162#issuecomment-1868351342,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALIIEDF2L5GCDVYBA2MIQLYK4SLJAVCNFSM6AAAAABABZONUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGM2TCMZUGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks guys 🙏🏼

Hi @frdemoulin @ToshY,
Since you’ve confirmed that PHPFlasher works with Symfony 7, I’ll close this issue.
If you encounter any problems, feel free to reopen it or create a new one.
Thanks.


Print warning when two Dates are compared

Code
const dateA = new Date()
const dateB = new Date()

if (dateA === dateB) {
  console.log('Can I haz warning?')
}

Expected behavior:
TypeScript compiler prints a warning because comparing if dateA and dateB are the same Date object is probably not what I want to do.
Actual behavior:
Nothing happens.

Duplicate of #15506

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


result from parse no longer has hasOwnProperty method

in 3.0.1, parse had the following behavior:
> qs.parse('my-param=my-val')
{ 'my-param': 'my-val' }
> qs.parse('my-param=my-val').hasOwnProperty
[Function: hasOwnProperty]
> qs.parse('h=j').hasOwnProperty
[Function: hasOwnProperty]
> qs.parse('').hasOwnProperty
[Function: hasOwnProperty]

in 3.0.2, the object returned no longer has the hasOwnProperty method:
> qs.parse('hbud-fixture=not-logged-in')
{ 'hbud-fixture': 'not-logged-in' }
> qs.parse('hbud-fixture=not-logged-in').hasOwnProperty
undefined
> qs.parse('hbudfixture=not-logged-in').hasOwnProperty
undefined
> qs.parse('hbudfixture=notloggedin').hasOwnProperty
undefined
> qs.parse('').hasOwnProperty
[Function: hasOwnProperty]
> qs.parse('h=j').hasOwnProperty
undefined

I am unsure whether this was considered part of the API, but some consumers rely on the behavior - https://github.com/mjackson/history/blob/master/modules/useQueries.js#L13

This is because of https://github.com/sindresorhus/query-string/issues/47
hasOwnProperty could be a query string property which interfered with the hasOwnProperty method of the object. Maybe the change should've been released as breaking @sindresorhus ?

:+1: on this – #47 is a good change, but it'd be best to roll it back and release a v3.0.3 to avoid breaking people who are using the for ... in/hasOwnProperty pattern, then re-release as v4.0.0 so we can update our code.

Actually, on second thought, this is somewhat problematic – it means that we need to not use obj.hasOwnProperty on anything coming out of parseQuery here, which is quite a lot to keep track of.

@taion: The for ... in / hasOwnProperty pattern should usually be done like this:
for(var key in obj) {
    if(Object.prototype.hasOwnProperty.call(obj, key) {
        // ...
    }

However, to avoid using Object.create(null) in 3.x.x you could use Object.defineProperty() when attaching properties to the returned object.  That would avoid issues with __proto__.
Or, to keep things modular, you could use a microlibrary that implements safe get(), set(), and has() functions for using objects as dictionaries.

You're right, but a lot of people write it as obj.hasOwnProperty instead of going up to Object.prototype.hasOwnProperty. It's a pretty big usability caveat.
Either way, though, this change in practice triggers enough bugs in consumers of this code that it should be released as breaking.

Instead of Object.create(null) could you just do `Object.create({})

No, because the prototype of {} is still === Object.prototype.  You'd
just be inserting another object into the prototype chain, when what you
want is to remove Object.prototype from the chain.
On Fri, Mar 18, 2016 at 2:04 PM, Brandon Dail<EMAIL_ADDRESS>wrote:

Instead of Object.create(null) could you just do `Object.create({})
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/sindresorhus/query-string/issues/50#issuecomment-198474590

Sorry, I removed my comment because I accidentally submitted it before I was done.
What I meant to write was something like:

No, that wasn't what I was recommending.  What if someone relied on the toString method of an object?  You'd have to define that as well.  What if someone tried to parse "hasOwnProperty=hello+from+a+cheeky+user"?  To even allow overwriting hasOwnProperty, you'd have to specify writable: true.  Even when you did, the 'hasOwnProperty' property would be non-enumerable so Object.keys(parsedParams) would return an empty array.
I am recommending something like this:
/**
 * Safely set a value on a dictionary.  Do *not* trigger special behavior from any setters.  An example of a setter is `Object.prototype.__proto__`
 */
function safeSet(obj, key, value) {
    if(key in obj) {
        Object.defineProperty(obj, key, {
            value: value,
            enumerable: true,
            configurable: true,
            writable: true
        });
    } else {
        obj[key] = value;
    }
}

All that work just to keep Object.prototype in the prototype chain, even though any properties might be overwritten by parsed query params.  With Object.create(null) or {__proto__: null}, you avoid ever giving anyone a false sense of security about calling methods on the returned object.

I think the current implementation in v3.x is mostly okay. Object.create(null) is clearly just the right thing to do, but it's breaking some downstream libraries. I plan to update the ones to which I commit to support null-prototype objects, but right now this is causing breakages to users.

I reverted that change and did a patch release. Sorry for the trouble. I didn't realize users were dependent on the behavior...

Thanks! I think it would make a lot of sense to release this as 4.0.0. It looks quite a lot more correct – it just unfortunately happens to be breaking in practice.

Actually, the correct solution would be to return a Map, but since people use this in the browser it's probably not feasible.

An equally correct solution is to use defineProperty as explained above.
It's browser compatible and is not a breaking change.  There are also safe
Dictionary libraries that can be used.
On Mar 20, 2016 12:35 PM, "Sindre Sorhus"<EMAIL_ADDRESS>wrote:

Actually, the correct solution would be to return a Map
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Map,
but since people use this in the browser it's probably not feasible.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/sindresorhus/query-string/issues/50#issuecomment-198960172

Maps are semantically more correct, but they're a lot less fun to work with than objects, because you can't use destructuring assignment with them.
It's really convenient for me to be able to do
const { foo } = query;

when working in ES6+ environments, and it would be an inconvenience to lose that for more proper map semantics.
It looks like the bulk of the breaking issues here came via React Router/history, and we have fixed our code with the null-prototype object handling.

Fair point, though objects are used as dictionaries often enough that the
semantics should hopefully be obvious to all JS devs.
This also raises another question: which browsers are being supported?
Map isn't available in all browsers, but neither are some of the other
built-in methods being used.  Forgive me if this is specified in the readme
and I missed it.
On Mar 20, 2016 12:56 PM, "Jimmy Jia"<EMAIL_ADDRESS>wrote:

Maps are semantically more correct, but they're a lot less fun to work
with than objects, because you can't use destructuring assignment with them.
It's really convenient for me to be able to do
const { foo } = query;
when working in ES6+ environments, and it would be an inconvenience to
lose that for more proper map semantics.
It looks like the bulk of the breaking issues here came via React
Router/history, and we have fixed our code with the null-prototype object
handling.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/sindresorhus/query-string/issues/50#issuecomment-198962590

You're talking about IE8 support, right?
The difference is:

Object.create(null) is handled by es5-sham, which I think many people still supporting IE8 already use
Object.prototype.defineProperty can't really be polyfilled well on IE8 at all
Map has much narrower browser support, so in practice will require more users to bring in a polyfill, or else would require using something like babel-runtime here

Ok, I didn't remember exactly when those features were added to the various
browsers.
According to my tests, defineProperty is unnecessary on IE8 since setting
__proto__ won't modify the prototype; it's just a normal property.
Agreed that far fewer browsers support Map than support methods like
Object.keys and reduce.
On Sun, Mar 20, 2016 at 1:10 PM, Jimmy Jia<EMAIL_ADDRESS>wrote:

You're talking about IE8 support, right?
The difference is:

Object.create(null) is handled by es5-sham, which I think many
people still supporting IE8 already use
Object.prototype.defineProperty can't really be polyfilled well on
IE8 at all
Map has much narrower browser support, so in practice will require
more users to bring in a polyfill, or else would require using something
like babel-runtime here

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/sindresorhus/query-string/issues/50#issuecomment-198966610

:+1:
(I can't leave a reaction on the "commit added" message)


fix template params

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.455%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
601

Relevant Lines:
747

💛  - Coveralls


feat(foxEth): consolidate getAddress() calls in FOX-ETH LP/farming hooks

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #2628

PR #2629   👈

This comment was auto-generated by Graphite.


multiple scopes

Hello.
What if I need to specify multiple scopes? (it's monorepo)
gcam "fix(web)(mobile): appointment issue"
or
gcam "fix(web, mobile): appointment issue"

How to do that?

Hi @legend80s
Please review my PR regarding "multiple scopes"
https://github.com/legend80s/git-commit-msg-linter/pull/54.


Create separate framework test targets

When you attempt to build the Expecta-iOS framework scheme via the following command with the iOS 7.1 Simulator installed:
xcodebuild build -scheme 'Expecta-iOS'

You'll receive the following error:
xcodebuild: error: Failed to build project Expecta with scheme Expecta-iOS.
	Reason: The run destination iPad 2 is not valid for Running the scheme 'Expecta-iOS'.

This is due to the fact that the Expecta-iOS framework scheme is currently configured to run tests using the Expecta-iOSTests target. However, this is an incorrect configuration, as the Expecta-iOSTests target does not actually depend on the framework target, but rather depends on the static library target. As such, running the Expecta-iOSTests target will not actually test the framework target. To fix this, I've:

Renamed the old test targets as libExpectaTests and libExpectaTests-iOS
Created new test targets ExpectaTests and ExpectaTests-iOS for the framework targets, to ensure that both integration options (framework or static library) can be properly tested

looks like Tests/Support/objc-build-scripts/cibuild needs to be updated too 👍

@orta doesn't look like that file needed to be modified, but we did need to add the framework to the test target's runpath search paths and copy it in. Should be good now though!

Looks good to me, for @orta too?

Yep


Store number of enrolled validators in block header validators field

I propose to wrap the BitField!ubyte field with a BlockValidators struct which includes the number of the validators enrolled that could potentially sign the block. This struct could also provide some useful functions to simplify code. For example a function to count the number of validators that signed or to return the indexes of the validators who signed.
It will also enable safe guarding against accessing the bits beyond the active set of bits.

Wouldn't this come at the cost of increasing the size of the block?

Wouldn't this come at the cost of increasing the size of the block?

Yes probably a couple of bytes extra would be needed. Depends on the maximum number of validators we want to support.

Yes, it would increase it by 4 or 8 bytes, but if we think our block size will be 10 - 100MB anyways, then this size increase might not be that much, and could really simplify our code.

The chosen solution was to create a new struct named BitMask which has a length value, which is set when constructed, and a byte array with required bytes to have a bit per active validator. When the bit is set then the validator's signature has been added.


Wrong file displayed if using docked windows

If "use open editor" is checked

Perhaps use a different logic to determine the current editor
http://wiki.netbeans.org/DevFaqGetOpenEditorWindows

I made a change, would you be interested to merge it back?
I can make a PR.
However it's quite a big patch, so I am not sure if I can reliably compare the performance of the two.
(So no fancy profiler data I think)
It's always instant though, and I use useEditorAsReference where I noticed that in the files tree, the node changes are processed, even when using useEditorAsReference.
This change makes it so you either have the one code path, or the other.
Let me know what you think.

@Shredder121: Oh, I missed the github notification mail about this. I will have a look at your PR this weekend!

Well, actually it is not yet a PR, but I was wondering if it's something you'd want to include.
I'll open up one if you like it. :smile:

The thing I need feedback on the most is the handling of the useNodeAsReference.
Did it also 'count' the selected editor as reference?
Is the current handling in line with what it used to do?

Also, what is your opinion on making getPath behave more like updatePath?
If we make it a void method, and pass in the window to set the title of, we can return early, instead of returning null and having the 'default' title.
Anyway, I appreciate your support!
p.s. this new handling (only updating on the right propertyChange) can also be applied to show-branch-in-statusbar I believe

@Shredder121: Try https://github.com/markiewb/show-path-in-title-netbeans-module/releases/tag/v2.2.0
If you give me an OK, i will put it on the plugin center! Thanks for your contributions!
I integrated your changes and refactored the code again.

I do not why the display should be faster than before, but at least this bug is fixed. The update has already been asynchronous.
Did it also 'count' the selected editor as reference? -> It did not count. Now a different text is shown #3
I updated the handling for useNodeAsReference. As a fallback I use the node instead of the current editor. The original idea of that is to see the label of the selected node. You can check that behaviour in the Services-window.
What is your opinion on making getPath behave more like updatePath? -> I took a different direction. I introduced a TitleBuilder (not a real builder), but this way it is easier to implement #6. getPath is only a collector and the TitleBuilder is the renderer (... I should rename it this way)

Offtopic

... can also be applied to show-branch-in-statusbar I believe -> file an issue and a pull-request. I guess you are one of the few users. I got seldom feedback on that plugin.
Your avatar image shows CPH, correct?! I was there this summer and remember the statue and the opera in the back :grinning:

If you give me an OK, i will put it on the plugin center! Thanks for your contributions!

No problem, and thank you for the plugin!
TLDR: I think it's good to go boss.

I do not why the display should be faster than before, but at least this bug is fixed. The update has already been asynchronous.

Well, maybe 'faster' was a poor choice of words.
What I meant was, that now the title is only updated once per switch of editors AND only when it needs to be updated (so useEditorAsReference ignores the tree views, which makes the IDE respond faster).
For reference I opened a profiler, I admit it's a very bad profiling session, since the logic in two modules can't really be compared, but bear with me.
In the image, every time 'something' changes in the TopComponent.Registry the propertyChange is called (see 1).
Now in showbranch all the events are handled, which means that actually the label is updated a few times too much. For showpathintitle the amount of calls to updateTitle is a great deal less that the amount of events. (see 2 and 3)
I hope the picture made at least some sense.
I at least see considerable improvements in the performance, well done! :+1:

Did it also 'count' the selected editor as reference? -> It did not count. Now a different text is shown #3

I actually meant, did it take the current editor in account when updating the title?
I ran the useNodeAsReference for a while, and side by side with the old logic in my development IDE, and I think it's the same behavior.
Is that true? I don't use it personally.

I updated the handling for useNodeAsReference. As a fallback I use the node instead of the current editor. The original idea of that is to see the label of the selected node. You can check that behaviour in the Services-window.

Ah so I guess that is my answer to my question ^there.
Good that it's now better.

What is your opinion on making getPath behave more like updatePath? -> I took a different direction. I introduced a TitleBuilder (not a real builder), but this way it is easier to implement #6. getPath is only a collector and the TitleBuilder is the renderer (... I should rename it this way)

Sounds fair. although I meant the suggestion mostly for this flow:

make new document tab group
open the project view
the project view is not an editor, so it looks up the current editor (which looks up the default editor TopComponent)
now the title changes to the editor in the original document tab group

Off topic

... can also be applied to show-branch-in-statusbar I believe -> file an issue and a pull-request. I guess you are one of the few users. I got seldom feedback on that plugin.

That's a shame, I really like your plugins though! And that one helps me remember when I forgot to switch branches, or when I am on a particular branch.

Your avatar image shows CPH, correct?! I was there this summer and remember the statue and the opera in the back :grinning:

HAHA! Yes correct! :100: points for you!
I was there last year with a few friends.
P.S. sorry for this wall of text

@Shredder121: Thanks for the kudos!


Is it correct way null safe works?

From your example-gradle-simple-master test app, I've added few fields and was checking how null safe works:
private static final var ExistenceMarkers : Map<String, String> = {
      "1" -> "f",
      "2" -> "g",
      "3" -> "h"
  }
  private static final var ExistenceMarkersAutoMap = ExistenceMarkers.toAutoMap(\k -> "nene")
  @Test
  function makeAFoo() {
    print("newing a Foo")
    var foo = new Foo()
    Assert.assertNotNull(foo)
    print(foo.doSomething("eureka") + ExistenceMarkersAutoMap[foo.STR])
    foo = null
    print(foo.doSomething("eureka") + ExistenceMarkersAutoMap[foo.STR])
    Assert.assertEquals(42, foo.MeaningOfLife)
  }

and foo gosu class:
public class Foo {
  private var str : String as STR = null
  function doSomething(arg : String) : String {
    return "Hello, got the argument '${arg}'"
  }
}

'org.gosu-lang.gosu' version '0.2.2'
'org.gosu-lang.gosu:gosu-core-api:1.14.3'
'junit:junit:4.12'
AND part of what have been built(part of compiled class):
public void makeAFoo() {
        GosuShop.print("newing a Foo");
        Foo foo = new Foo();
        Assert.assertNotNull(foo);
        GosuShop.print(foo.doSomething("eureka") + `(String)ExistenceMarkersAutoMap.get(foo.getSTR()));
        foo = null;
        GosuShop.print(foo.doSomething("eureka") + `(String)ExistenceMarkersAutoMap.get(foo.getSTR()));
        if (foo == null) {
            throw new NullPointerException();
        } else {
            Assert.assertEquals(42L, (long)FooEnhancement.getMeaningOfLife(foo));
        }
    }

and output:
newing a Foo
Hello, got the argument 'eureka'nene

java.lang.NullPointerException
...

it is not null safe, should it be?

and output:
newing a Foo
Hello, got the argument 'eureka'nene
java.lang.NullPointerException
...

Gosu provides operators to handle null values.  For instance, you can use ?. to avoid null checks and access a member from a potentially null receiver e.g., foo.doSomething() if foo is null, the expression short-circuits to null.

In Gosu from Guidewire it looks quiet different, is it normal that compiler there is different from this one?


HTML

#HTML
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed

User story:
As a boot camp student, I want to use Git version control so that I can keep track of the content changes I make to my project in my prework-study-guide GitHub repository.
Acceptance criteria:
It is done when I add, commit, and push up the HTML code in a feature branch.
It is done when I open a pull request with my feature branch as the comparison branch and the default branch as the base branch.
It is done when I merge the PR so that the main branch holds the HTML code for the project.


bindableArrayChanged function of custom element not called for bindableArray property

Please see the following plunker to demonstrate:
https://plnkr.co/edit/6lrE7K1NITssUeSzoUoj?p=preview
bound array property behaves differently than bound simple properties (string/number).
For simple property the Changed function is called but for array it is not.

Hi @genadis, this is a common misunderstanding, let me attempt to explain.
There's a difference between a property change (eg foo.bar = ['baz']) and array mutation (eg foo.bar.push('baz')). In the former, the bar property's value change to a different array instance.  In the latter, the bar property remains the same array instance. The changed callback is only invoked for property changes, not for array mutation.

Got it, thank you for the explanation.
I'll keep using ObserverLocator for array/map mutation tracking.


v0.3.21 - Monthly release

📆 Monthly release

Universal - Unpin docker-in-docker Feature
[Python] Adds support for v3.12

Good point, didn't realize https://github.com/devcontainers/images/pull/769 was merged in. Added lockfile updates!


Move Ledger State to JSON5 format and add QoL features

Amongst other things;

Document the ledger_state.json5
Add support for using token names in the initial balance map
Add a validation field for the full id of an account, and not just its subresource id.

Oh I need to update many-rs, my bad.

Please note that JSON5 is backward compatible with JSON.


Driver support for types arrow and json

These two formats are used in the getting started document.

See https://github.com/rstudio/pins/issues/605 -- should support type "feather" and/or "parquet", and support only reading of type "arrow" (as feather) for backward compat.


added store env var

Please check below, if the PR fulfills these requirements:

[X] Commit(s) and code follow the repositories guidelines.
[X] Test(s) have been added or updated to support these change(s).
[X] Doc(s) have been added or updated to support these change(s).

Associated Links:

N/A

Types of Changes:

Feature

Proposed Changes:

Added environment variable of HAULER_STORE_DIR to allow users to set the store directory

Verification/Testing of Changes:

N/A

Additional Context:

N/A

branch based off of PR https://github.com/hauler-dev/hauler/pull/368


Adds an example to render triangle

Adds very basic example that renders a static triangle

Thanks! Looks good. Can you please add the copyright header as is done elsewhere?

I'll review this this evening.
@depy, have you seen the CONTRIBUTING.md file? Can you please provide some motivation for why how this example is helpful. It looks very similar to the cube example, except it draws a triangle.
Maybe we should replace the cube example with this triangle example, or do you think there's value in having both?

I see value in it in that it's quite a bit shorter than the other example. Short is good for examples if you want to get started! But variety is also good, in that it gives a sense of the range of possible approaches.

Modulo my tiny comments, looks reasonable to me.

Done. Remove depth buffer calls, added copy right lines and made replace 'var' with ':=' on most lines to make it more consistent.
I think having a simple triangle without MVP matrices and spinning and texture is a way easier thing to reason about. And maybe try out and play with vertex and fragment shaders. :)

I've briefly looked over and I will have a few code style suggestions and some questions. Please give me a few days to post a full review.
Since these examples are meant to serve as high quality canonical examples for how to write code that uses the go-gl packages, I think we should continue to have really high standards here. Taking a little more time to get this right should be worth it.
Thanks again!

@shurcooL no problem. I understand. :)

@depy, thanks again for your contribution. This repo hosts example code that serves as the canonical examples for using go-gl packages, and code quality is more important than on average. We want to provide good examples for others to start with. That's why contributing to this repo is harder than usual.
I've reviewed the code more closely, and I notice the style/template you use in your example is quite different than the existing example we have for the cube.
I understand your point of having a simpler example that just renders a triangle. However, things like initializing GLFW and opening a window are common between examples and should not change. We need to find one consistent style that is the best, and use it everywhere.
That would allow people to try out the triangle example, then seamlessly "upgrade" to the more advanced cube example and the code change should be added functionality, not change in style.
For example, compare these differences:
func main() {
	runtime.LockOSThread()
	initGlfw()
	setOpenGlVersion()
	win := makeWindow()
	printOpenGlVersionInfo()

vs.
func init() {
	// GLFW event handling must run on the main OS thread
	runtime.LockOSThread()
}

func main() {
	if err := glfw.Init(); err != nil {
		log.Fatalln("failed to initialize glfw:", err)
	}
	defer glfw.Terminate()

	glfw.WindowHint(glfw.Resizable, glfw.False)
	glfw.WindowHint(glfw.ContextVersionMajor, 4)
	glfw.WindowHint(glfw.ContextVersionMinor, 1)
	glfw.WindowHint(glfw.OpenGLProfile, glfw.OpenGLCoreProfile)
	glfw.WindowHint(glfw.OpenGLForwardCompatible, glfw.True)
	window, err := glfw.CreateWindow(windowWidth, windowHeight, "Cube", nil, nil)
	if err != nil {
		panic(err)
	}
	window.MakeContextCurrent()

Since this code has nothing to with rendering simple triangle vs. spinning textured cube, I don't think that code should be different.
I think for a short example like this it will be better to avoid having small helper funcs like printOpenGlVersionInfo and setOpenGlVersion. Instead, they should be just inlined into main since they're used only once, to make things more readable without having to jump in code. Reusable funcs like createProgram or createVbo are okay to keep in funcs.
With that in mind, I suggest you re-write your simple triangle example to use the same style/template as the other cube example (https://github.com/go-gl/examples/blob/master/glfw31-gl41core-cube/cube.go), but do fewer things (no texturing, no spinning cube, just 1 triangle instead of many).
Does that sound reasonable to you?
Also, one of our requirements for contributing examples is a reasonable expectation that someone will maintain the code if it needs to be updated (due to better practices being discovered, APIs changing, etc.). From https://github.com/go-gl/examples/blob/master/CONTRIBUTING.md:

We want to ensure the examples here are high quality, well maintained, few and well organized. The goal is to be helpful to people who are interested in examples.
We will accept new examples if those criteria are met and if it's reasonable to expect that the contributed examples will be maintained.

Are you willing to maintain this example code?

Left a few comments, but assuming someone will maintain this and we make the code as clean-and-concise as possible (i.e. only what is literally needed to render a triangle) then I think it's an okay idea.

Are you willing to maintain this example code?

Given the lack of response, I will take that as a "no".
I'll close this since it's a stale PR that we cannot merge since there's no active maintainer for this new code. If desired, this PR can be revisited at a later time.
Thanks for the contribution anyway!


Package Deterministic (dll/exe):Non deterministic

Make deterministic

wontfix due to https://github.com/NuGet/Home/issues/8599 Disable pack determinism because of unforeseen impact on deployment tools
Reconsider if this issue is completed
https://github.com/NuGet/Home/issues/8601 Revisit deterministic pack


Add test for get application details with filter

Add test for get application details with filter

Related to https://github.com/wso2/product-is/issues/12197

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/1081809433

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/1081809433
Status: success


Feature not installed in SharePoint Online

I get the following error when running this.
Feature with Id '29deab23-c821-460e-822f-790eb7ff3cea' is not installed in this farm, and cannot be added to this scope.
Obviously as this is SharePoint Online we have no custom solutions or features. This was also running between to sub-sites in the same site collection.
Full stack trace below
Microsoft.SharePoint.Client.ServerException was unhandled
HResult=-2146233088
Message=Feature with Id '29deab23-c821-460e-822f-790eb7ff3cea' is not installed in this farm, and cannot be added to this scope.
ServerErrorCode=-1
ServerErrorTraceCorrelationId=0604599d-50de-2000-09c1-44c7fdfd38b4
ServerErrorTypeName=System.InvalidOperationException
ServerStackTrace=""
Source=Microsoft.SharePoint.Client.Runtime
StackTrace:
at Microsoft.SharePoint.Client.ClientRequest.ProcessResponseStream(Stream responseStream)
at Microsoft.SharePoint.Client.ClientRequest.ProcessResponse()
at Microsoft.SharePoint.Client.ClientRequest.ExecuteQueryToServer(ChunkStringBuilder sb)
at Microsoft.SharePoint.Client.ClientRequest.ExecuteQuery()
at Microsoft.SharePoint.Client.ClientRuntimeContext.ExecuteQuery()
at Microsoft.SharePoint.Client.ClientContext.ExecuteQuery()
at Microsoft.SharePoint.Client.ClientContextExtensions.ExecuteQueryImplementation(ClientRuntimeContext clientContext, Int32 retryCount, Int32 delay)
at Microsoft.SharePoint.Client.FeatureExtensions.ProcessFeatureInternal(FeatureCollection features, Guid featureID, Boolean activate, FeatureDefinitionScope scope)
at Microsoft.SharePoint.Client.FeatureExtensions.ActivateFeature(Web web, Guid featureID, Boolean sandboxed)
at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectFeatures.ProvisionFeaturesImplementation[T](T parent, List`1 features)
at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectFeatures.ProvisionObjects(Web web, ProvisioningTemplate template)
at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyRemoteTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation provisioningInfo)
at Microsoft.SharePoint.Client.WebExtensions.ApplyProvisioningTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation applyingInformation)
at Provisioning.Framework.Program.ApplyProvisioningTemplate(ConsoleColor defaultForeground, String webUrl, String userName, SecureString pwd, ProvisioningTemplate template) in C:\Users\toby\Source\Repos\PnP\Samples\Provisioning.Framework.Console\Provisioning.Framework.Console\Program.cs:line 128
at Provisioning.Framework.Program.Main(String[] args) in C:\Users\toby\Source\Repos\PnP\Samples\Provisioning.Framework.Console\Provisioning.Framework.Console\Program.cs:line 36
at System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()
InnerException:

Thanks @statto1974 for reporting this. It seems that there has been a momentary time when sites have been associated a oob feature, which no longer exists in the farm. This could be due numerous reasons, but engine should not actually break on this situation.
This means that we'll adjust the code for the Feb 2016 release to gracefully handle possible missing feature exceptions and only log that in the logs, but we will not shut down the provisioning.

Just to follow up on this. Code in the engine has been changed to catch possible missing features, log about those and then move on. This is needed to manage these kind of situations where the feature suddenly has been removed in the farm. Code change is already in the dev branch and will be released as Nuget update as part of the February 2016 release.


[expense] Created admin dashboard panel

Motivation and context
I've created the UI and functionality needed to operate with the Expense entity in the admin dashboard.
Operations such as: create, edit, view and delete an Expense record are now possible.
Demo:
I think a short demo will be most sufficient.
https://user-images.githubusercontent.com/71282381/160602474-02253c3d-040e-42e0-bd84-0d9be1d0773b.mp4
close #477

@kachar Thanks for all the input and tips.
I did the required changes.
About the 'deleted' field. I changed it to checkbox and left it disabled.

Additionally I removed the DeleteCheckbox from the create form. It makes no sense to be there.

Let me know if something needs improving.

I made a quick check that everything still works and translations are loaded correctly. It looks ok to me.
All done.

Thanks, @dpmarkov for this tremendous progress for the app, a lot of effort has been set in and the results are outstanding.

Thank you too. Your suggestions were very helpful along the way of improving this PR.


Documentation for Automate-deployed on-prem Builder.

:nut_and_bolt: Description: What code changed, and why?
Document how to deploy on-prem Builder with Automate.
TODO:

[x] the docs don't build locally due to relref issues with the IAM v2 docs.
[x] cover package population
[x] update existing oauth builder page

:chains: Related Resources
#1795
:+1: Definition of Done
:athletic_shoe: How to Build and Test the Change
:white_check_mark: Checklist

[ ] Tests added/updated?
[ ] Docs added/updated?

:camera: Screenshots, if applicable

ran into client intended to send too large body when trying to upload all of the core pacakges. I had to modify the load balancer config to allow for the larger size. I ended up setting client_max_body to unlimited (0)


Remove version: Ghisler.TotalCommander version 10.00

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

For moderators or/and anyone else

[!Caution]
As a result of several personal problems I've had over the last few months + my final exams coming up very soon, I'm currently unable to look at my GitHub notifications every day and maintain my executions correctly.
If you detect a certain problem on a certain pul request:

Either you can close the pull request directly without mentioning me.
Or you can send me a message on X (Twitter): @Exorcism0666

Thank you for your understanding, and I'm sorry if some pull requests can't be approved due to the situation I'm in.

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

URL: https://totalcommander.ch/win/tcmd1000x64.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 910)

Only the x64 version is missing - the other 2 are still available. I'm removing this, but the other versions might be readded later.


Add a __asonNameof method to every class

__asonNameof() is a virtual method that simply returns nameof(). This is useful for debugging objects whose types are only known at runtime, i.e. objects in ASON deserialization.

This enhancement basically bloated signature types into oblivion.

We need to revert the part of this pull request that inserts a virtual nameOf() in every class. As it turns out, this is detrimental and causes out of memory errors when compiling.
We need a better way to lookup object types, and I'm guessing adding an --output-rtti ./path/to/file.txt would be the correct call here.


WIFI doesn't work?

So I'm trying to install Visual Studio Code in xenial on the Unity Desktop and when I try, it exits saying that it can't download the files required because it's not connecting to the internet. Can someone help me with this? I tried to figure out how to use the Network App, but I couldn't make it work.

@TechFishe,
crouton uses the Chrome OS networking processes, nothing to setup or do in the chroot.
If it downloads in Chrome OS it should also download in the chroot.
Hope this helps,
-DennisLfromGA

Huh, I didn't think that was the case. Thanks for the help and happy holidays!

No problem, Happy Holidays.


Add markdown document

A section about configure markdown-it settings

Hi.
Thanks! Instead of including directly the typings in the code, I think it's better to link to the deno's documentation of this module: https://doc.deno.land/https/deno.land%2Fx%2Flume%2Fplugins%2Fmarkdown.ts, it's more maintainable.
Maybe this can be included in the frontmatter, to create the link in the layout automatically for any page with a link to the documentation.

Hi.
Thanks! Instead of including directly the typings in the code, I think it's better to link to the deno's documentation of this module: https://doc.deno.land/https/deno.land%2Fx%2Flume%2Fplugins%2Fmarkdown.ts, it's more maintainable.

Thanks for your review. I have made some changes. If you have more suggestions, please comment.

Maybe this can be included in the frontmatter, to create the link in the layout automatically for any page with a link to the documentation.

This is a good idea!

Thanks! I'll made some changes in the layout to include this link automatically in all plugins, but this is a good start for now :)


update readme

add codebase integrates laravel with graphql

Sorry. Not enough stars: https://github.com/chiraggude/awesome-laravel/blob/master/CONTRIBUTING.md


⚠ Bofrost.at has degraded performance

In a9396b6, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1128 ms

Resolved: Bofrost.at performance has improved in dbe3373 after 7 minutes.


Sync eng/common directory with azure-sdk-tools for PR 1508

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/1508  See eng/common workflow

/check-enforcer override


Get rid of shared const.

Split const.js into the semantically separated groups of constants and put them in the appropriate places. Remove shared const term from the code BTW. As an addition: rename service-msg-cmd to commands (like with test-run in testcafe package) and move it to the /session dir with the session.js and cookie.js (session.js being an index.js there).

I think we need to split constans from const.js as follow:
1)DOM_SANDBOX_PROCESSED_CONTEXT
Using only on client.
Move to /src/client/utils/dom/.js
and create two methods:
getProcessingContext()
setProcessingContext(wnd)
rename to PROCESSED_CONTEXT
2)EVENT_SANDBOX_WHICH_PROPERTY_WRAPPER
Using only on client.
Move to separate file /src/client/event/which-property-wrapper.js
rename to WHICH_PROPERTY_WRAPPER
3)DOM_SANDBOX_OVERRIDE_DOM_METHOD_NAME
DOM_SANDBOX_STORED_ATTR_POSTFIX
HOVER_PSEUDO_CLASS_ATTR
Using on client and on server.
Move to separate file /src/processing/dom/attributes.js
File will be contain these constants and utility functions with them
4)FOCUS_PSEUDO_CLASS_ATTR
Using only on client.
Move to separate file and change structure to:
src/client/sandbox/event/focus-blur/index.js -  with focusBlurSandbox
src/client/sandbox/event/focus-blur/pseudo-class-attrubute.js  - with constant
5)IS_STYLESHEET_PROCESSED_COMMENT
Using on server and in client tests.
Move to static method of StyleProcessor:
StyleProcessor.hasProcessedComment(text)
rename to PROCESSED_COMMENT
6)UPLOAD_SANDBOX_HIDDEN_INPUT_NAME
Using only on client.
Move to /src/upload/info-hidden-input-name.js
rename to INFO_HIDDEN_INPUT_NAME
7)DOCUMENT_CHARSET
Used only on client.
Move to /src/client/utils/dom.js and create two methods:
getDocumentCharset(doc);
setDocumentCharset(doc, value)
/сс @inikulin @churkin please review

Disagree what we should place any constants in utils. Also, I don't like whole file for just single constant, can we make them instance constants, or statics?

Ok. Updated version:
1)EVENT_SANDBOX_WHICH_PROPERTY_WRAPPER
Instace constant - EventSandbox.WHICH_PROPERTY_WRAPPER
2)DOM_SANDBOX_OVERRIDE_DOM_METHOD_NAME    DOM_SANDBOX_STORED_ATTR_POSTFIX    HOVER_PSEUDO_CLASS_ATTR    DOM_SANDBOX_PROCESSED_CONTEXT,    FOCUS_PSEUDO_CLASS_ATTR,   DOCUMENT_CHARSET
Move to separate file /src/processing/dom/attributes.js
Content:
export default {
         processedContext: <value>,
         overrideMethodName: <value>,
         storedAttrPostfix: <value>
         hoverPseudoClassAttr: <value>,
         focusPseudoClassAttr: <value>,
         documentCharset: <value>
}

3)IS_STYLESHEET_PROCESSED_COMMENT
Using on server and in client tests.
Move to static method of StyleProcessor:
StyleProcessor.hasProcessedComment(text)
rename to PROCESSED_COMMENT
4)UPLOAD_SANDBOX_HIDDEN_INPUT_NAME
Using on client and on server.
/src/client/sandbox/upload/hidden-info.js
/src/upload/form-data.js
Using in both places to find hidden input with upload info.
I think in this case we need to place into separate file /src/upload/info-hidden-input-name.js
and rename it to INFO_HIDDEN_INPUT_NAME
or move to /src/processing/dom/attributes.js (see point 2)
/сс @inikulin @churkin please review again

regarding 2:
We can remove Attr from field names, since it will be used as constants union (always with the host object), e.g.:
INTERNAL_ATTRS.focusPseudoClass,

I think it should be named internal-attributes.js or something like that, since it's our internal, processing-related attrs. @VasilyStrelyaev will help with better naming
regarding 4:

or move to /src/processing/dom/attributes.js (see point 2)
I vote for this

Well, without actually delving into where they are used, I tend to say "okay". Names seem fair as long as all these constants really have something to do with internal attributes, and abbreviations like INTERNAL_ATTRS are allowed according to js style best practices (I still can't get used to it after .NET).
Though we are going to leave Attr in storedAttrPostfix since it's determinative here, aren't we?
The only thing I doubt about is overrideMethodName. What is it actually used for?

looks good

Like being ignored so much!

@VasilyStrelyaev :laughing:

Actually we've missed the point here, we definitely should rename INTERNAL_PROPS.overrideDomMethodName to INTERNAL_PROPS.overrideDomMethod.
\cc @churkin @miherlosev


web container failed to boot

Describe the bug
I am trying to view example stackblitzes from material.angular.io.
Following the instructions, I have turned off Enhanced security for stacklitz.io.  Initially, I got the warning about this.
Now the page loads but I get this error

So I am unable to view any examples any longer.  This is with Edge Dev 105.0.1300.0 (Official build) Dev (x86_64) on Mac OS 11 and 12.
Link to the blitz that caused the error
https://stackblitz.com/run?file=src%2Fapp%2Fcdk-portal-overview-example.ts
Steps to reproduce

go to any stackblitz from material.angular.io
the example will not run dues to web container failing to boot

Expected behavior
it should run
i cannot run it locally, since it i someone's example i am trying to learn from
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
No response
Platform
Browser name  = Chrome
Full version  = 104.0.5112.0
Major version = 104
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.5112.0 Safari/537.36 Edg/105.0.1300.0
performance.memory = {
  "totalJSHeapSize": 121476778,
  "usedJSHeapSize": 95586630,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Hash = e40b17327b4f777f5dccacbb86b346b09cdd4176

Additional context
No response

https://stackblitz.com/run?file=src/app/sidenav-overview-example.ts
i would up having to turn off the enhanced security options in Edge settings.


run error for create frame (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)

run error for create frame in rust code .
(exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)

Sciter version?

@pravic Thanks ,I upgrade to 4.4.7 , Everything works ok !


Build the enhanced plugin page

See https://github.com/alphagov/govuk-prototype-kit/issues/2298
Changes included:

Change plugins page as per design and changes as requested
Support plugin config meta data
Add /plugins-installed route
Add search and filter behaviour for available plugins
Update Acceptance tests to handle separate Installed and Find Plugin pages
Added unit tests for the new post route for search
Cleaned up some Acceptance tests to allow them to retry correctly
Added meta data for the jquery proxy config
Added a proxy config for notify so meta data could be added

Changes not included:

Pagination will be done in a separate PR

I'm curious about the search rules...
Would users expect step by step govuk prototype kit to come up with:

Would users expect templates common to come up with:

Would users expect SMS to come up with:

These cases would be catered for if we both include the metadata in the search logic and search for each word individually rather than the complete string.
(I don't think this is necessary for a first release but I think it's worth discussing)

If I try to access these pages offline it claims that everything has upgrades available, I think it should do the opposite and not claim that any have upgrades available.  Screenshot attached.

In the design the installed plugins also display in the "find plugins" section with a tag to say "installed".  Was changing that an intentional decision?

In the design the installed plugins also display in the "find plugins" section with a tag to say "installed". Was changing that an intentional decision?

I worked with @joelanman on this.  The designs were not complete and so for an MVP, this is what we have and it can be extended later.


Error running on PBS cluster

I am trying to run juicer on a PBS cluster using the new PBS scripts. When I run the juicer.sh script I get the following error:
 Starting job to launch other jobs once splitting is complete
207474.merlot.bis.vcu.edu
below is the jID_alignwrap jobid
207474.
#PBS -W depend=afterok:207474.
qsub: illegal -W value

I think this is because of the period after the job ID number. For reference on our cluster jobs are named like this: 206998.merlot and can be called using only the number.
How can I modify the script to only use the number and drop the period from the job ID being used for the PBS -W command?

I haven't worked with PBS, but my guess is you'll want to modify the lines containing
$( qstat | grep AlnWrp${groupname} | cut -c 1-7 )
@mzhibo suggestions?

I am modifying the this line also.
Two simple fix:

replace the text in quotes "cut -c 1-7" with text in quote "cut -c 1-6" in all the script. You will need to do this in juicer.sh   launch_stats.sh and   postprocessing.sh scripts.
This will fix your problem but specifically to PBS cluster with job ID number set to be 6 digits instead of 7.

Another way is replace      cut -c 1-7        with        cut -d ' ' -f 1
Notice that there is a space between the quote after -d.
I haven't tested this second way, but in theory it should work and won't cause such problem on different PBS clusters. I will modify the scripts in this way once I have tested it.
Zhibo

Merged the pull request to fix this.

Hi,
a simple fix for your cluster specifically would be replacing the "cut -c 7" to "cut -c -6" in juicer.sh and launch_stats.sh and postprocessing.sh
I think it might also be OK to simple delete

I changed the lines you suggested and it is submitting to the queue now. I
think it is working, but I will let you know if I encounter any more issues.
On Wed, Sep 27, 2017 at 1:58 PM, mzhibo<EMAIL_ADDRESS>wrote:

Hi,
a simple fix for your cluster specifically would be replacing the "cut -c
7" to "cut -c -6" in juicer.sh and launch_stats.sh and postprocessing.sh
I think it might also be OK to simple delete
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/theaidenlab/juicer/issues/36#issuecomment-332605032,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATJE8GqlU5cHw99H6T1HsgYaTiN5V2dvks5smoy0gaJpZM4PmBt7
.

2 years later I'm having similar problems with the newest Juicer and an updated PBSpro. Help??
`(-: Starting job to launch other jobs once splitting is complete
waitstring_alnwrp is #PBS -W depend=afterok:
4261798.hpc-batch14
below is the jID_alignwrap jobid
4261798.hpc-batch
#PBS -W depend=afterok:4261798.hpc-batch
waitstring_RDpWrp is below:
#PBS -W depend=afterok:
4261799.hpc-batch14`
ERROR: qsub: illegal -W value

Hello,
We don’t have access to PBS servers and so can’t debug. Is there
potentially a newline character or an extra quote mark that shouldn’t be
there?
Le ven. 5 juil. 2019 à 15:17, ViriatoII<EMAIL_ADDRESS>a écrit :

2 years later I'm having similar problems with the newest Juicer and an
updated PBSpro. Help??
`(-: Starting job to launch other jobs once splitting is complete
waitstring_alnwrp is #PBS -W depend=afterok:
4261798.hpc-batch14
below is the jID_alignwrap jobid
4261798.hpc-batch
#PBS -W depend=afterok:4261798.hpc-batch
waitstring_RDpWrp is below:
#PBS -W depend=afterok:
4261799.hpc-batch14`
ERROR: qsub: illegal -W value
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aidenlab/juicer/issues/36?email_source=notifications&email_token=AAK2EW4LFWNWNG2GKNBY6SLP55CVDA5CNFSM4D4YDN52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZJP6II#issuecomment-508755745,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAK2EWYC4JY26NBDCFHLGWLP55CVDANCNFSM4D4YDN5Q
.

--
Neva Cherniavsky Durand, Ph.D.
Staff Scientist, Aiden Lab
www.aidenlab.org


[SR-2711] Migration guide related to dispatch_queue_attr_make_with_qos_class() needs to be updated

Previous ID
SR-2711

Radar
None

Original Reporter
@nevil

Type
Bug

Status
Reopened

Resolution

Additional Detail from JIRA

Votes
0

Component/s
Project Infrastructure

Labels
Bug, Website

Assignee
None

Priority
Medium

md5:<PHONE_NUMBER>d6e5d2f0e7fa22debd5421

Issue Description:
swift.org has a swift 2 to 3 migration guide: https://swift.org/migration-guide/
The description in the migration guide for how to migrate dispatch_queue_attr_make_with_qos_class() is incorrect.
The suggestion does not compile with Xcode 8 GM / Swift 3.

The Dispatch queue APIs now use the DispatchAttributes OptionSet. If you previously used dispatch_queue_attr_make_with_qos_class(DISPATCH_QUEUE_SERIAL, QOS_CLASS_DEFAULT, 0)), you should now use use the option set, as in DispatchQueue(label: name, attributes: [.serial, .qosDefault])

@shahmishal Please transfer this to the website repo.


Maven publishing retries PUT but doesn't retry metadata download

Expected Behavior
Using options like
-Dorg.gradle.internal.network.retry.max.attempts=5
-Dorg.gradle.internal.network.retry.initial.backOff=5000

will cause maven publisher to retry PUT operations that fail with network errors that appear recoverable but if a server you are publishing to is struggling, the failure can occur while retrieving metadata and that is not retried. If it retried using the same retry logic, that would make publishing more likely to succeed.
Current Behavior (optional)
No response
Context
When the Apereo CAS project publishes snapshots to the Sonatype Nexus repository there are occasional failures (e.g. a 502 failure presumably from a proxy in front of Nexus when the Nexus server is under load or possibly restarting after a crash). The retry logic in gradle was enabled but then it still failed and the failure occurred during retrieval of existing metadata from the remote maven repository.

Thank you for providing a valid report.
The issue is in the backlog of the relevant team, but this area of Gradle is currently not a focus one, so it might take a while before a fix is made.

Thanks for adding a PR for fixing that!


PLAT-128620: Add Routable sampler

Enact-DCO-1.0-Signed-off-by: Jeonghee Ahn<EMAIL_ADDRESS>Checklist

[x] I have read and understand the contribution guide

[ ] A CHANGELOG entry is included

[ ] At least one test case is included for this feature or bug fix

[x] Documentation was added or is not needed

[ ] This is an API breaking change

Issue Resolved / Feature Added
Currently, there is no sample to test Routable that using relative path.
Resolution
Add Routable sampler
Additional Considerations
Links
https://github.com/enactjs/enact/pull/2856
PLAT-128620
Comments

@jeonghee27 Please update changelogs.


Allow Minors to Change age_range on Source

Thanks!
On Mon, Dec 11, 2023, 15:29 Cassidy Symons @.***> wrote:

@.**** commented on this pull request.
In microsetta_interface/templates/new_participant.jinja2
https://urldefense.com/v3/__https://github.com/biocore/microsetta-interface/pull/306*discussion_r1423235224__;Iw!!Mih3wA!GRhP66cHrp6JNRGy8S5SySBzst0TwEh_7mk9ovLF44iTCdj4rjlqQBIsRSCNrX2M6CXLBHfWppklP_Ga0qk8umH58Fhl8zFEP-vG5g$
:

@@ -243,18 +258,24 @@

{% if language_tag != "ja_JP" %}

       <input type="radio" id="age-range-1" name="age-range" value="0-6" onchange="change_consent_div(this)">

       {{ tl['PARTICIPANT_FORM']['AGE_0_6'] |e}}

       <input type="radio" id="age-range-2" name="age-range" value="7-12" onchange="change_consent_div(this)">

       {{ tl['PARTICIPANT_FORM']['AGE_7_12'] |e}}

       <input type="radio" id="age-range-3" name="age-range" value="13-17" onchange="change_consent_div(this)">

       {{ tl['PARTICIPANT_FORM']['AGE_13_17'] |e}}

       {% if cur_age_index <= 0 %}

Changed the magic number situation. The age ranges are now string literals
in implementation.py, but I agree that copying them into the jinja2
template would be both weird and clunky. Other than that, this PR is ready
for re-review, but it won't pass integration tests until the corresponding
Private API PR has been merged.
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/biocore/microsetta-interface/pull/306*discussion_r1423235224__;Iw!!Mih3wA!GRhP66cHrp6JNRGy8S5SySBzst0TwEh_7mk9ovLF44iTCdj4rjlqQBIsRSCNrX2M6CXLBHfWppklP_Ga0qk8umH58Fhl8zFEP-vG5g$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AADTZMV6YZHZF2D7EXVEL7TYI6JNRAVCNFSM6AAAAABAOJRUYOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONZWGM2DMMRZHA__;!!Mih3wA!GRhP66cHrp6JNRGy8S5SySBzst0TwEh_7mk9ovLF44iTCdj4rjlqQBIsRSCNrX2M6CXLBHfWppklP_Ga0qk8umH58Fhl8zGu3pozZQ$
.
You are receiving this because your review was requested.Message ID:
@.***>

@wasade Workflow is passing now after merging the corresponding Private API PR. Any further feedback or is this also good to merge?

Nah, +1, thanks!


Fix package.json

Actually, my PR is also wrong. We should be publishing the dist folder, but I don't think we are. I need to look at it more.

Current pika build doesn't work, even if I install the dist folder locally, it still throws this:
$ node test.js
internal/modules/cjs/loader.js:613
    throw err;
    ^

Error: Cannot find module './body.js'
Require stack:
- /Users/df/git/node-fetch/dist/dist-node/index.js

Maybe it's due to my lack of understanding of this tool, but this is not working as I imagine. @Richienb @xxczaki


{#Chart Builder} Dimension mapping is not clearly described to user

Solution 1: draw a graph to point out the dimension mapping place

solution

add type constrict check

add demo


Invalid size provided for UploadedFile; must be an int.

Hi guys, I'm working on an iOS project and I'm required to send documents, such as pdfs, to my laravel server. The issue is, every time I try to send a post request for a PDF, I get this error message: Invalid size provided for UploadedFile; must be an int. I'm at my wit's end trying to solve this issue. Any ideas?

That exception is thrown here https://github.com/zendframework/zend-diactoros/blob/167607290e79c396fd947cedeadccce0173c0e47/src/UploadedFile.php#L113-L115
That is all I can derive from the description, you need to be more specific. Stack traces, anything?

Increase upload_max_filesize in php.ini
;Maximum allowed size for uploaded files.
; http://php.net/upload-max-filesize
upload_max_filesize = 16M

This repository has been closed and moved to laminas/laminas-diactoros; a new issue has been opened at https://github.com/laminas/laminas-diactoros/issues/10.


Missing arguments in UPDATE

Version
1.21.0
What happened?
When writing an UPDATE query like:
UPDATE mytable SET
  name = slqc.arg('name')
WHERE code = sqlc.arg('code');

The only recognized parameter is the one in the WHERE clause.
Relevant log output
Nothing relevant. Generation runs without errors.

Database schema
create table mytable (
	code	       varchar(250) primary key,
	name	       varchar(250) not null,
    notes	       varchar(250) not null
);

SQL queries
UPDATE mytable SET
  name = slqc.arg('name'),
  notes = slqc.arg('notes')
WHERE code = sqlc.arg('code');

Configuration
version: "2"
sql:
  - engine: "postgresql"
    queries: "query.sql"
    schema: "query.sql"
    gen:
      go:
        package: "query"
        sql_package: "pgx/v5"
        out: "."
        emit_interface: true
        emit_pointers_for_null_types: true

Playground URL
https://play.sqlc.dev/p/796e32f4c69f7b9d174731eb41f9de6e3e5151adf1c4b867698d75a90484e30e
What operating system are you using?
Linux
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go

Related to #2748

You have mistaken sqlc.arg for slqc.arg.
https://play.sqlc.dev/p/72a3d7751224ad0d281bcf57da50c0d947c4107eb49257668936a10034a0a299

interesting. The typo is clear although shouldn't have that triggered some error?

@orisano good catch! My bad! Thanks!  :-)
Regarding the error triggering, it might be the case that some strange-looking SQL were actually valid sentences (like, e.g., using some non-standard or custom made PostgreSQL extensions).  I would agree to issuing a warning in such cases, not an error.

Regarding the error triggering, it might be the case that some strange-looking SQL were actually valid sentences (like, e.g., using some non-standard or custom made PostgreSQL extensions). I would agree to issuing a warning in such cases, not an error.

This is correct I think. It will also be a little tedious to issue a warning since we'd need to come up with a list of common misspellings for all of the sqlc-specific preprocessor functions. If that's desirable then I think we can open a new issue.


Version number considerations

General practice disagrees with a statement made about version numbers in the (otherwise great, I already recommend this to projects!) draft. The draft states:

in well-designed APIs, backwards-compatible changes in the service should not update a version number.

However, a lot of people follow semantic versioning, which has the benefit that it is possible to tell, by comparing two version numbers, whether the difference is bugfixes (1.2.7 to 1.2.8), new features (1.2.7 to 1.3.0), or compatibility-breaking changes (1.2.7 to 2.0.0).
I would like to interpret version to be a version that ideally would follow semantic versioning, and releaseID can be something quite customized, like a git commit hash or build number.
Therefore I suggest to change the statement "in well-designed APIs, backwards-compatible changes in the service should not update a version number" to "in well-design APIs, it can be told from update of a version number whether the changes are backwards-compatible".
In case readers haven't heard of semantic versioning, here's a link: https://semver.org/

From the sample JSON, version appears to be a single digit. Since the RFC lacks an implementation, version could be just two numbers, “1” for this RFC, then “1.1” for the first backwards compatible RFC, etc.
SemVer is kind of overkill of the RFC (and, FYI, OSGi’s 2010 Semantic Versioning whitepaper is better than SemVer anyway).

But I think maybe the RFC is saying it will define “1”, and if you extend “1” you don’t need to change the version number.
What I’m curious about, are we waiting for “2” from a future RFC? Or are implementators and users expected to increment version without a future RFC?

I'm not saying the RFC shall say people have to use SemVer. But people should be free to use SemVer and find that compliant with SemVer.
I did not know about OSGi's Semantic Versioning. I've tried to find the whitepaper, and what I found was this: https://www.osgi.org/wp-content/uploads/SemanticVersioning.pdf Having skimmed through it, my first impression is that it's actually not better than SemVer, I think its examples are too implementation-specific. Still, I'll read it in detail. Anyway, with SemVer vs OSGi's SemVer we're discussing something that probably shouldn't be referenced directly by the RFC anyway, the RFC should just make it possible and even suggest that people use something like these.

Semantic versioning was designed for and is commonly used in libraries and applications. It is not widely used for web APIs and is actually considered an anti-pattern because it is bad user-experience to break an API client for non-breaking changes in APIs. APIs and libraries are not the same thing. Several major APIs, widely praised for their API design excellence such as Stripe and Twilio actually use dates as their versions, so clearly they do not use semantic versioning,
Case in point, Stripe API (https://stripe.com/docs/api/versioning):

When we make backwards-incompatible changes to the API, we release new, dated versions. The current version is 2018-09-24. Read our API upgrades guide to see our API changelog and to learn more about backwards compatibility.

On the flip side of the coin, Google API versioning does claim that they use semantic versioning, but actually they don't because in the URIs they only use major version:

Note that the minor version is not encoded in the URL. That means that if we enhance the Cool Cloud API by adding a new field, you may one day be surprised when a call to coolcloudapi.googleapis.com/v1/coolthings/12301221312132 starts returning some additional data. But we’ll never "break" your app by removing fields.

the semantic version is returned in the headers, so it is actually more of what the health check RFC defines as releaseID, except instead of having two different things and calling both of them "version", we tried to make things less confusing.

I actually had a conversation with SemVer.org’s author and got him to admit SemVer is identical to OSGi’s Semantic Versioning.
While I think Semantic Versions can and does apply to web services, I want the client to negotiate the major (and possibly minor) version via hypermedia content type parameters. (Minor version negotiation might be desirable when added attributes can crash clients, e.g., JAXB JSON implementations like Jackson.)

Versioning of APIs is one of those things that people do in wildly different ways and there is no agreement on (as witnessed by some of the examples I posted above). Given how this subject surfaced here as well, here's a thought (with two options):

Mild options: remove any assumptions about how versions are used, remove releaseId property from this spec and just leave the losely-defined "version" property.

Remove both "version" and "releaseId" properties from health check response, since it could be argued that they have no place in health check response and other things (e.g. "health" link relation from the API itself or a mapping in kubernetes deployment etc.) will make it evident which API and version the response in question pertains to.

cc: @dret @randallsquared

Remove both "version" and "releaseId" properties from health check
response, since it could be argued that they have no place in health
check response and other things (e.g. "health" link relation from
the API itself or a mapping in kubernetes deployment etc.) will make
it evident which API and version the response in question pertains to.

what about recommending that a health resource SHOULD have a "home" link
to the home resource (whatever that is) of the API it is reporting
about, and then expecting that service metadata (if required) can be
found that way?
this could use a new home property, or could recommend to use the "home"
link relation in the links section.

Now I see a much bigger issue with version, from this discussion.
Some people interpret version to be the version of the /health API itself, and thus the RFC.
Some people interpret version to be the version of the API for which /health is reporting the health status. That's how I interpreted /version.
The RFC should be clear about what it means with version. Currently, the RFC says:

version: (optional) public version of the service.
releaseID: (optional) in well-designed APIs, backwards-compatible changes in the service should not update a version number. APIs usually change their version number as infrequently as possible, to preserve stable interface. However implementation of an API may change much more frequently, which leads to the importance of having separate “release number” or “releaseID” that is different from the public version of the API.

I interpreted this as being the version and releaseID of the service for which the health is reported. But now I'm not sure whether I'm interpreting the RFC draft correctly.
@inadarei When applying semantic versioning to path-versioned APIs, using only the major version is not a deviation from semantic versioning, it is implicitly and effectivly a mandatory requirement by semantic versioning. The path is part of the API, and changing the path is a breaking change, thus the path has to be stable as long as there are no backwards-incompatible changes. So, the path must be the same between 1.0.0 and 1.0.1 or 1.1.0, and thus only the major version must appear in the path. Google is doing everything right there. It could be argued that it could be done with changes in the path, but that in turn would be break HTTP caching and make clients unnecessarily complicated. Google is actually following semantic versioning by the letter.

@randallsquared why would a health check endpoint report any version or releadeId of the main API?
@dret I think home link should be a MAY statement. I can see many people deciding that the pointer should be from the API to the healthcheck and not vice versa, while other may like the direction, so this spec should avoid over-prescribing either of the approaches?

On Oct 28, 2018, at 18:56, Irakli Nadareishvili<EMAIL_ADDRESS>wrote:

@dret I think home link should be a MAY statement. I can see many people deciding that the pointer should be from the API to the healthcheck and not vice versa, while other may like the direction, so this spec should avoid over-prescribing either of the approaches?

sure, sounds good, too. it's simply helpful to tell readers about patterns they might find useful. any level of making it their choice to follow these patterns is fine, i think.

To avoid confusion about version it may be removed and 2 optional fields introduced with clear names:

apiVersion
monitoredServiceVersion


Collatz Conjecture contribution

link to demo here:
https://editor.p5js.org/cshep99/full/DtAf8BXc-
this is Danny's code but i figured out what he did wrong and now it draws the lines in the same place as the Numberphile's video!
Community Contribution
Link to live project, video, or image:
https://editor.p5js.org/cshep99/full/DtAf8BXc-
Sharing

[x] I would be happy to have my project shared on The Coding Train's social media!

Thanks for sharing!


Release Tracking

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#1869 53b99f6a Thanks @keithamus! - Make Overlay headings optional

#1873 125861b8 Thanks @camertron! - Remove ability to show trailing action buttons in ActionList and NavList on hover

#1875 8bbeb72a Thanks @camertron! - Allow ActionList dividers to be added manually

#1871 6b1170ae Thanks @camertron! - Deny tag argument for ActionList headings

#1876 b3b94e98 Thanks @antn! - Upgrade octicons to >= 18.0.0

Dotcom PR (internal only): https://github.com/github/github/pull/264145


UCP Backup doc enhancements

Remove the interactive tag from backup as the command does not run as shown in the example

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for modest-edison-79d82e ready!
Built with commit a96dc071996fd6cff468a36952a726138f51ad07
https://deploy-preview-7198--modest-edison-79d82e.netlify.com