Is share_plus available for win32 ^4.1.1in the latest master flutter?

What is your question?
After building the project it fails and says:
Because it depends on share_plus ^6.3.1 which depends on win32 ^3.0.0, so win32 ^3.0.0 is required.
So, because Project depends on win32 ^4.1.1, version solving failed.
Checklist before submitting a question

[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I am using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

6.3.1 has older win32 in dependencies, but nothing blocks you from using dependency overrides to make your project work with latest win32

@vbuberen file_picker update is blocked when using share_plus
Because file_picker >=5.2.11 depends on win32 ^4.1.3 and share_plus 6.3.2 depends on win32 ^3.0.0, file_picker >=5.2.11 is incompatible with share_plus 6.3.2.

Read my comment above and use dependency overrides till share_plus updates to latest dependencies as well.


Fixes in Util and Store packages.

This changes make almost all Util's test pass. The exceptions are the "ignored" tests, and the TestIndexableBinaryStringTools' ones. The latter ones won't succeed unless we change IndexableBinaryStringTools' implementation, which is wrong. Nevertheless this class is used nowhere in the project.
Also, they fix some of the Store's tests and related classes.

Thanks
However, this fixes too many things, some of the fixes are wrong or needs further discussion.
I'll cherry-pick some commits based on what I think are good fixes, and then for the rest please open a dedicated PRs on a branch tracking apache/lucene.net/master for each fix and we will discuss each separately in its own PRs.
Sorry but there are too many intrusive changes in this PR that need discussions separately.

Following Itamar's suggestion, I started to create separate PRs for each group of related fixes.
I'll close this PR as soon as I finish the new ones.


GTK themes and icons can be selected, but not loading.

Basic info

System: 16.03pre77568.40c586b (Emu)
Nix version: nix-env (Nix) 1.11.2
Nixpkgs version: "16.03pre77568.40c586b"
XFCE version: Xfce 4.12.1

Describe your issue here
Imagine some casual user. Person who likes to have full-fledged desktop environment, but no too polluted, like XFCE is. He also cares a lot about appearance of his desktop, so he got an idea to find some icon and GTK themes to make his UI look a bit better. But after installing arc-gtk-theme and elementary-icon-theme nothing went like he'd expected to.
Expected result
When user runs xfce4-appearance settings and chooses "Style" tab, changing to any style results in reloading GTK style in every running app (if app doesn't support DBus messages or is run as root, it might be restarted to apply this), same thing with "Icons".
Actual result
After choosing 3rd party theme, like previously mentioned Arc, it keeps selected, but falls back to default Raleigh one, without any message about what the hell happened right now. But after rebooting, theme is applied correctly (only if installed as systemPackages). Logging off and on doesn't help.
The icon theme doesn't apply even after reboot, and xfce4-appearance-settings shows red triangle on selected icon theme, with information about missing icon cache, which can't be regenerated manually, because /run/current-system/sw/ is read-only.
Steps to reproduce

Install  NixOS with standard, automatically generated configuration, just add:

services.xserver.desktopManager.xterm.enable = false;
services.xserver.desktopManager.xfce.enable = true;
services.xserver.displayManager.lightdm.enable = true;

As user, run:

# adding to systemPackages in configuration.nix was tested too with same effect
nix-env -i arc-gtk-theme elementary-icon-theme
xfce4-appearance-settings

Be lost and try to figure how it can be fixed. I think icon themes should have post-install hook to run gtk-update-icon-cache, but I'm not sure what's happening with GTK themes.

/cc @lethalman. I know too little about gtk* themes.
Icon themes
It depends on the theme. I use the tango theme installed via nix-env and it works, because the theme did generate its icon-theme.cache when building itself. I'd think we should fix the individual themes to do so. (It means introducing extra build-time-only dependencies, but I personally don't think that's a problem, especially if we allow building the stuff on Hydra.)
There's this problem of not regenerating on installation into an user/system env, but IMO it's better done individually except for themes that are meant to compose (probably just the "hicolor" theme).

Can we just make single icon-theme template for all of them, which will take care of updating icon cache and so on?

See also: https://github.com/NixOS/nixpkgs/issues/10577

And this one (https://github.com/NixOS/nixpkgs/issues/5053) suggests a workaround but I haven't tested it.
I do experience this as well. Chromium gets styled, nautilus doesn't; for example.

I wonder if removing the cache altogether from system, makes everything work ok. That is, even without the "cache", icons should work, right? I have to try...

What's going on with that?

I am also affected by this problem.
Wouldn't just adding
 postInstall = '''${gtk.dev}/bin/gtk-update-icon-cache' "$out/share/icons/Elementary" '';

be enough to make at least the elementary-icon-theme package work?
(I unfortunately can't test it right now, as I did set up NixOS just one hour ago and don't know how to change packages locally yet.)

I think that something similar is happening to me with
$ nixos-version
17.03.1395.9b948ea439 (Gorilla)

$ nix-env --version
nix-env (Nix) 1.11.11

I use lxappearance to select the theme. To have it show widget and icon themes installed with nix-env I had to symlink ~/.nix-profile/share/icons and ~/.nix-profile/share/themes to ~/.icons and ~/.themes respectively. However, the changes are not saved.
Normally lxappearance saves its settings to ~/.gtkrc-2.0, but nothing happens for me (even when I manually create that file and make it world-writeable).

Has this been solved or no?
I installed some numix themes and they didn't work.
GTK theme a no show in lxappearance, icon theme showed up but does nothing.

@Nobabs27 you may have to symlink ~/.nix-profile/share/themes to ~/.themes to have them shown in lxappearance but they won't be applied anyway.

So how do I get them applied?

Also, there is no ~/.nix-profile/share/themes for me.

@Nobabs27 maybe you need to install a theme as your user with nix-env.

Also, if you edit manually you ~/.gtkrc-2.0 some applications will be able to pick up the theming.

Installing via nix-env no change.
Created a .gtkrc-2.0 with this line: gtk-theme-name="Arc-Dark"
No change still...
Although lxappearance works fine in XFCE, it does not work in i3wm.

tl;dr: add the following to your nixos config, logout+login
environment.sessionVariables = {
  GDK_PIXBUF_MODULE_FILE = "$(echo ${pkgs.librsvg.out}/lib/gdk-pixbuf-2.0/*/loaders.cache)";
};

I tried using elementary-icon-theme and ran into the icons being blank
Next I tried numix-icon-theme and had the same issue - blank icons
Then I tried arc-icon-theme and it worked!
scratched my head and figured out elementary-icon-theme and numix-icon-theme are SVG whereas arc-icon-theme uses PNGs

💡 ah-hah that's the difference

little bit of research told me that gdk-pixbuf is used to load icons in GTK

researched svg support for gdk-pixbuf
found out that svg support is provided by librsvg

inspected the librsvg nix package and noticed a line about: The loaders.cache can be used by setting GDK_PIXBUF_MODULE_FILE to point to this file in a wrapper.
searched issues for GDK_PIXBUF_MODULE_FILE and found https://github.com/NixOS/nixpkgs/issues/16268#issuecomment-226964988
made changes and icons worked 👍

Hope this helps!

BTW I used the xfce settings to change icon sets - not lxappearance

This should be largely solved by now except for icon theme cache: to fix missing cache, there should be a an additional step to generate it during the build.

As I just noticed during the test drive of NixOS 17.09 after about two years, the problem still exist.
Every time I choose icon theme added to the user environment (via nix-env -i) or system (via environment.systemPackages) it shows previously selected theme without any changes.
For GTK2/3 themes, when I try to switch on any of these, I'm getting something like the default GTK (Raleigh) theme (used on Windows platform, for example) with colors set from newly selected one, but somewhat ommiting all the CSS it has.
Logging off and on does not resolve this, sadly.
I don't want to be rude or offending, but I want to ask – why such simple problem can't be fixed? I see there's a massive work put into the development of NixOS and Nixpkgs, but such little bug still resist, and many new or less-knowledgeable users can be easily took off.
Of course majority of developers here are using i3/dwm/something-wm and Emacs running constantly and rarely seeing ~the light of sun~ any other GUI applications. But there are also "desktop" users who want their windows and icons look as they used to be on other Linux distributions. Is that so hard?

I don't want to be rude or offending, but I want to ask – why such simple problem can't be fixed?

Contributions are welcome.

Is that so hard?

Trivial but menial; see: https://github.com/NixOS/nixpkgs/pull/35466/files


Backport HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor

https://issues.apache.org/jira/browse/HBASE-26551

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
8m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

-1 :x:
hbaseanti
0m  0s
The patch appears use Hadoop classification instead of HBase.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 26s
branch-1 passed

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 51s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 54s
branch-1 passed

+1 :green_heart:
shadedjars
3m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 21s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 17s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 18s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
compile
0m 51s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 51s
the patch passed

-1 :x:
checkstyle
1m 42s
hbase-server: The patch generated 3 new + 27 unchanged - 2 fixed = 30 total (was 29)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 21s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 34s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 33s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
158m 10s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 41s
The patch does not generate ASF License warnings.

212m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4028

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4f3aa8c7a76a 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-4028/out/precommit/personality/provided.sh

git revision
branch-1 / e8a8523bb0

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/1/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/1/testReport/

Max. process+thread count
4721 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

-1 :x:
hbaseanti
0m  0s
The patch appears use Hadoop classification instead of HBase.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 31s
branch-1 passed

+1 :green_heart:
compile
0m 45s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 51s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 55s
branch-1 passed

+1 :green_heart:
shadedjars
3m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 24s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 20s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 18s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
compile
0m 52s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 52s
the patch passed

-1 :x:
checkstyle
1m 43s
hbase-server: The patch generated 3 new + 27 unchanged - 2 fixed = 30 total (was 29)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 22s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 33s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 13s
the patch passed

_ Other Tests _

-1 :x:
unit
156m 59s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

204m  2s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4028

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 63bb8e022fe7 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-4028/out/precommit/personality/provided.sh

git revision
branch-1 / e8a8523bb0

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/2/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/2/testReport/

Max. process+thread count
4810 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

-1 :x:
hbaseanti
0m  0s
The patch appears use Hadoop classification instead of HBase.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 36s
branch-1 passed

+1 :green_heart:
compile
0m 47s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 51s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 52s
branch-1 passed

+1 :green_heart:
shadedjars
3m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 25s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 23s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 19s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
compile
0m 52s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 52s
the patch passed

+1 :green_heart:
checkstyle
1m 45s
hbase-server: The patch generated 0 new + 27 unchanged - 2 fixed = 27 total (was 29)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 21s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 34s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 15s
the patch passed

_ Other Tests _

-1 :x:
unit
160m 38s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 39s
The patch does not generate ASF License warnings.

208m  2s

Reason
Tests

Failed junit tests
hadoop.hbase.namequeues.TestNamedQueueRecorder

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4028

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4ceae5aa1ee7 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-4028/out/precommit/personality/provided.sh

git revision
branch-1 / e8a8523bb0

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/3/testReport/

Max. process+thread count
4855 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 44s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

-1 :x:
hbaseanti
0m  0s
The patch appears use Hadoop classification instead of HBase.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
11m 15s
branch-1 passed

+1 :green_heart:
compile
0m 52s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 57s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
2m  7s
branch-1 passed

+1 :green_heart:
shadedjars
4m 14s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 53s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 47s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 43s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 39s
the patch passed

+1 :green_heart:
compile
0m 54s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 54s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
checkstyle
1m 46s
hbase-server: The patch generated 0 new + 27 unchanged - 2 fixed = 27 total (was 29)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
6m 10s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 52s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 24s
the patch passed

_ Other Tests _

-1 :x:
unit
176m 27s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

229m 24s

Reason
Tests

Failed junit tests
hadoop.hbase.master.TestMasterBalanceThrottling

hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint

hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4028

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4942aafa8361 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-4028/out/precommit/personality/provided.sh

git revision
branch-1 / e8a8523bb0

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/4/testReport/

Max. process+thread count
4742 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@YutSean
-1 The patch appears use Hadoop classification instead of HBase.

@YutSean
-1 The patch appears use Hadoop classification instead of HBase.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

-1 :x:
hbaseanti
0m  0s
The patch appears use Hadoop classification instead of HBase.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 35s
branch-1 passed

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 51s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 53s
branch-1 passed

+1 :green_heart:
shadedjars
3m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 21s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 19s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 20s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 46s
the patch passed

+1 :green_heart:
compile
0m 52s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 52s
the patch passed

+1 :green_heart:
checkstyle
1m 41s
hbase-server: The patch generated 0 new + 27 unchanged - 2 fixed = 27 total (was 29)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 22s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 38s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 14s
the patch passed

_ Other Tests _

-1 :x:
unit
154m  2s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

201m 14s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4028

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux bbe2157346a3 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-4028/out/precommit/personality/provided.sh

git revision
branch-1 / e8a8523bb0

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/5/testReport/

Max. process+thread count
4705 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/5/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

-1 :x:
hbaseanti
0m  0s
The patch appears use Hadoop classification instead of HBase.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 30s
branch-1 passed

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 53s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 54s
branch-1 passed

+1 :green_heart:
shadedjars
3m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 25s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 21s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 20s
the patch passed

+1 :green_heart:
compile
0m 48s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 48s
the patch passed

+1 :green_heart:
compile
0m 53s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 53s
the patch passed

+1 :green_heart:
checkstyle
1m 42s
hbase-server: The patch generated 0 new + 27 unchanged - 2 fixed = 27 total (was 29)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 24s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 26s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 15s
the patch passed

_ Other Tests _

-1 :x:
unit
156m 56s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

204m  8s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint

hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4028

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 548edf4ff283 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-4028/out/precommit/personality/provided.sh

git revision
branch-1 / e8a8523bb0

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/6/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/6/testReport/

Max. process+thread count
4713 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/6/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

-1 :x:
hbaseanti
0m  0s
The patch appears use Hadoop classification instead of HBase.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 40s
branch-1 passed

+1 :green_heart:
compile
0m 45s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 52s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 58s
branch-1 passed

+1 :green_heart:
shadedjars
3m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 27s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 25s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 20s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
compile
0m 53s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 53s
the patch passed

+1 :green_heart:
checkstyle
1m 43s
hbase-server: The patch generated 0 new + 27 unchanged - 2 fixed = 27 total (was 29)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 22s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 32s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
154m 19s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

201m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4028

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux e63c97e970bd 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-4028/out/precommit/personality/provided.sh

git revision
branch-1 / e8a8523bb0

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/7/testReport/

Max. process+thread count
4764 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4028/7/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Have removed all the hadoop.InterfaceAudience import in the new created files. But the QA still reports the hadoop interface usage. It seems a little bit strange. Does the QA also report which files used hadoop classification somewhere? @Reidddddd


enhancement: external stt

Is your feature request related to a problem? Please describe.
Would it be possible to allow running whisper on another server?
Describe the solution you'd like
Adding the ability to connect to whisper via some kind of API.
Additional context
I am running open-webui on a server without GPUs, and LLMs, TTS on another server.

I've recently developed faster-whisper-server which provides an OpenAI compatible transcription/translation (and some extras as well) which could be used as a transcription backend if OpenWebUI adds support for having an external STT

STT & TTS settings have been refactored and you can now configure external OpenAI STT from Admin Settings!

I tried this and the model name for STT is not correctly used.

ValueError: Invalid model size 'whisper-1', expected one of: tiny.en, tiny, base.en, base, small.en, small, medium.en, medium, large-v1, large-v2, large-v3, large, distil-large-v2, distil-medium.en, distil-small.en, distil-large-v3

@colaber2
STT & TTS settings have been refactored on dev and you can now configure external OpenAI STT from Admin Settings!

Amazing.. well done!!

I tried this and the model name for STT is not correctly used.
ValueError: Invalid model size 'whisper-1', expected one of: tiny.en, tiny, base.en, base, small.en, small, medium.en, medium, large-v1, large-v2, large-v3, large, distil-large-v2, distil-medium.en, distil-small.en, distil-large-v3

@tjbck The model name is being ignored. As a result we can't use @fedirz's faster-whisper-server because it doesn't know what "whisper-1" is.
I modified faster-whisper-server to treat "whisper-1" as the default model and it worked great! @fedirz, maybe this is a good feature you could add? @tjbck, could you make the fix so we can choose the models?
Thank you both for your work!

Hey, yeah, I'll add special handling for whisper-1

I tried this and the model name for STT is not correctly used.
ValueError: Invalid model size 'whisper-1', expected one of: tiny.en, tiny, base.en, base, small.en, small, medium.en, medium, large-v1, large-v2, large-v3, large, distil-large-v2, distil-medium.en, distil-small.en, distil-large-v3

@tjbck The model name is being ignored. As a result we can't use @fedirz's faster-whisper-server because it doesn't know what "whisper-1" is. I modified faster-whisper-server to treat "whisper-1" as the default model and it worked great! @fedirz, maybe this is a good feature you could add? @tjbck, could you make the fix so we can choose the models?
Thank you both for your work!

How did you get it to work with faster-whisper-server? I keep getting 404 errors in openwebui. I know my faster-whisper-server endpoint is working because I can use it fine with whisper-writer on my Windows 11 computer.


Remove title prefixes and old labels

Related to #https://github.com/neurobagel/planning/issues/202

Changes proposed in this pull request:

Remove title prefixes
Remove blank issue (now comes default)
Remove labels (they are being refactored) and issue types don't seem to work yet (beta?)

Checklist
This section is for the PR reviewer

[ ] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
[ ] PR links to GitHub issue with mention Closes #XXXX
[ ] Tests pass
[ ] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

@surchs, I think the wrong issue is linked here in the description - mind updating that? :)


what import parser are you using

a good friend of mine showed me this once, and I borrowed the idea from him


Phase 3: OS settings and browsers

This adds packages for Linux, macOS, and Windows to configure recommended settings and install all major browsers.

@alekzz, please let me know if you think this is an improvement: https://github.com/shaka-project/shaka-lab/pull/17/commits/7eac8d739ffbe31d19b9ee2514293076f0e48e64


SolrObject should be treated like SimpleXMLElement or stdClass: It can have dynamic properties of unknown type

I think the types of its properties include SolrObject and scalars.
For $x being a SolrObject
$x->response->arbitaryProp should not emit errors. Currently, it emits errors about undefined properties (The properties it has depends on the unknown solr schema)
$x['response'] should be treated the same way as $x->response
See the example output in http://php.net/manual/en/solr.examples.php#zookeeper.delete.example.basic

solr 2.4.0 was used

http://php.net/manual/en/class.solrobject.php

Maybe allow this to be configurable? Mocked objects have similarly magical properties


Interpolating objects in React Native

We had an issue in the css-to-react-native project. Somebody tried to do,
export const AppName = Text.extend`
  ${{
    textShadowColor: 'black',
    textShadowOffset: { width: -4, height: 1 },
    textShadowRadius: 14,
  }}
`;

This doesn't work, (I assume) because the object will go through css-to-react-native. What is the expected behaviour here? Should we treat the style as complete, or process it? Or should we only process string values?
A note on if we only process string values: interpolating { margin: '10%', margin: 10 } will use margin: 10%, because it gets expanded to margin{Top,Right...}, which have higher priority.

I’m pretty sure I’d suggest ppl to use “.attrs” in this case. If you use the style prop explicitly there’s nothing you lose and it’s pretty clear then that it bypasses our logic

People might use that to use polished in React Native, which always returns objects.

@jacobp100 since nested rules are not a thing in react native, would it make sense to alter the object stringification for it to pass css-to-react-Native some more useful info?

So convert objects to something that looks enough like CSS to parse?

We support objects now

Hi @probablyup, I have upgraded styled-components^3.3.3, but I still can't use objects
const StyledShadowView = styled(View)`
  ${{
    shadowColor: 'rgb(255, 0, 255)',
    shadowOffset: {
      height: 2,
    },
    shadowOpacity: 1.0,
    shadowRadius: 4,
  }}
`;

It got Node of type rule not supported as an inline style warn

Yeah don’t use a template literal, just call styled(View)(yourStyleObject)
On Tue, Jul 3, 2018 at 10:56 PM Amo Wu<EMAIL_ADDRESS>wrote:

Hi @probablyup https://github.com/probablyup, I have upgraded
styled-components^3.3.3, but I still can't use objects
const StyledShadowView = styled(View)  ${{    shadowColor: 'rgb(255, 0, 255)',    shadowOffset: {      height: 2,    },    shadowOpacity: 1.0,    shadowRadius: 4,  }};
It got Node of type rule not supported as an inline style warn
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/1509#issuecomment-402356019,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiy1hA6EQsaGvk2C53sBYrRLurX4Eikks5uDDzsgaJpZM4SAO1P
.

Hi @probablyup, I tried to change to this version, but the result is still the same Node of type rule not supported as an inline style, Is the v3.3.3 version correct?
const StyledShadowView = styled(View)({
  shadowColor: 'rgb(255, 0, 255)',
  shadowOffset: {
    height: 2,
  },
  shadowOpacity: 1.0,
  shadowRadius: 4,
})

Hmm maybe just use the combined syntax?
boxShadow: “0 2 4px rgb(255, 0, 255)”
On Wed, Jul 4, 2018 at 12:47 AM Amo Wu<EMAIL_ADDRESS>wrote:

Hi @probablyup https://github.com/probablyup, I tried to change to this
version, but the result is still the same Node of type rule not supported
as an inline style, Is the v3.3.3 version correct?
const StyledShadowView = styled(View)({
shadowColor: 'rgb(255, 0, 255)',
shadowOffset: {
height: 2,
},
shadowOpacity: 1.0,
shadowRadius: 4,
})
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/1509#issuecomment-402370125,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiy1u8txZf8PNMZafEeuFcoV1OTbdYlks5uDFb2gaJpZM4SAO1P
.

This should really be documented more clearly as the official RN docs suggest to use exactly this nested syntax. Is it welcome for me to contribute a PR?

PRs always welcome. If you wanna see some test cases for parsing, you can look here. Feel free to ping me if you have any questions.


Renew only if certificate is close to expiry

I have just started using lego to request and renew certificates using the DNS challenge. While everything works fine, it looks like the renew command always renews the certificates, even if the certificate is far away from expiring.
Would it be possible to add an option which prevents the renewal if a certificate is not yet close to expiring? This would facilitate executing the renew command regularly without the certificates being actually renewed on each run. E.g. the official Let's Encrypt client only does a renewal if less than 30 days remain for the expiry date.

Hello there!
That would be the --days switch for the renew command.
You pass it the number of days you want the cert to have left in order to renew it.

hi @xenolf :)
sorry for missing this.. I had just checked the global options in the docs and hadn't seen that there is a command specific option which does exactly what I want! thanks!


[Charting] Combo charts - area and line

Summary
Carbon Charts have been working on the ability to overlay 2 different charts on top of each other, and we want to leverage that capability to show an area chart with one value and show a line chart with other values on top of it.
Additional context
Issue in chart repo: https://github.com/carbon-design-system/carbon-charts/issues/527
This issue indicates that it should have been delivered in 2Q2020
Proposed design that needs it

Health score is the area chart and drivers are the line chart another.  They share the same Y axis values.  Additionally, we would like to overlay an event timeline on the same X axis, but I'm not sure if Carbon Charts has that option available yet.
Specific timeline issues / requests
Do you want this work within a specific time period? Is it related to an
upcoming release?
This chart is scheduled for Health / MAS October release.
NB: The core contributors will try to work with your timeline, but it's not
guaranteed. The earlier you make a request in advance of a desired delivery
date, the better!
Available extra resources
What resources do you have to assist this effort?
Predict team will be working on this chart.  It's possible that @navjeets or others might be able to contribute this to IoT.
Carbon add-ons for Watson IoT is a collaborative system. We encourage teams to build components and submit them for integration.

Carbon chart issue for area+line combo chart - https://github.com/carbon-design-system/carbon-charts/issues/723

The bounded area chart from Carbon looks similar to these occupancy count graphs from TRIRIGA:


fix: bump go core to 5.9.3

PR summary

This PR updates the Go core version in the project.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

:tada: This PR is included in version 0.22.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Please check Status Ok for Chebi: 89484, 89719, 89891, 89828, 88764, 80946 and 58784

Hello,
I have just noticed that the ChEBIs still have status OK:
89484
89719
89891
89828
88764
80946
58784
Can you please check them? We need them for RHEA.
TIA,
Lucila

Hi Lucila,
All these entries have now been upgraded to checked status.
Cheers,
Steve


Uncaught Error: ENOENT: no such file or directory, lstat '~/AppData\Local\atom\app-1.46.0\ C  '

[Enter steps to reproduce:]

...
...

Atom: 1.46.0 x64
Electron: 4.2.7
OS: Microsoft Windows 10 Pro
Thrown From: Atom Core
Stack Trace
Uncaught Error: ENOENT: no such file or directory, lstat 'C:\Users\thoma\AppData\Local\atom\app-1.46.0\ C  '
At fs.js:115

Error: ENOENT: no such file or directory, lstat 'C:\Users\thoma\AppData\Local\atom\app-1.46.0\ C  '
    at Proxy.realpathSync (fs.js:1435:7)
    at Proxy.fs.realpathSync (ELECTRON_ASAR.js:306:40)
    at TreeView.moveEntry (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:14:1002525)
    at TreeView.onDrop (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:14:1009454)
    at HTMLDivElement.<anonymous> (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:14:983085)

Commands

Non-Core Packages
atom-material-syntax 1.0.8
script 3.26.0

..


Don't use the data function from within a package

here: https://github.com/USGS-R/mda.streams/blob/master/R/init_nwis_sites.R#L15
Causes the variable to be exported to the global environment. Similar to issue with dataRetrieval. @ldecicco-USGS do you have a link to your solution in dR?

Put the states data in a file called sysdata.rda. You can also export that data.  When it's in the sysdata.rda file, you can just call it:
https://github.com/USGS-R/EGRET/blob/master/R/plotFluxHist.R#L77
here's how to export it (the whole chunk, not just that line):
https://github.com/USGS-R/EGRET/blob/master/R/EGRET.R#L50
If that doesn't make sense, let me know.
Better question, why did you write that site query (for state) and not just tell me there was a simple option in readNWISdata that was missing???? All I need to do is allow 'site' as a service argument (in addition to dv, and iv), and you don't need the get.state.sites and get.site.data functions. If there's ever something you can't get from dataRetrieval that goes to the waterservice or waterdata web services, let me know.

I guess Luke asked specifically about the dataRetrieval data. I switched over to sysdata on the last update to CRAN. That means that functions that laz-ily call parameterCdFile can be used as Imports to other packages. Same process as EGRET (put data in sysdata instead of the data folder)

@ldecicco-USGS I am tackling this today and would like to revisit the above conversation if you are willing

sure. readNWISdata can do sites now on the latest dataRetrieval version. Not sure if you are refactoring those functions, or adding states to sysdata. Either way, let me know what you need.


[#4272] Refactor DispatchHandler

Add TCPServerResponse

Codecov Report

Merging #4280 into master will decrease coverage by <.01%.
The diff coverage is 32%.

@@            Coverage Diff             @@
##           master    #4280      +/-   ##
==========================================
- Coverage   41.11%   41.11%   -0.01%
==========================================
  Files        2382     2384       +2
  Lines       74528    74540      +12
  Branches    10077    10079       +2
==========================================
+ Hits        30643    30646       +3
- Misses      41067    41077      +10
+ Partials     2818     2817       -1

Impacted Files
Coverage Δ

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
80.41% <ø> (+0.21%)
:arrow_up:

...orp/pinpoint/rpc/client/DefaultPinpointClient.java
64.1% <ø> (-0.9%)
:arrow_down:

...corp/pinpoint/io/request/DefaultServerRequest.java
50% <ø> (+27.77%)
:arrow_up:

...rp/pinpoint/io/request/AttributeServerRequest.java
0% <0%> (ø)

.../pinpoint/profiler/receiver/CommandDispatcher.java
10.52% <0%> (ø)
:arrow_up:

...pinpoint/collector/cluster/ClusterPointRouter.java
0% <0%> (ø)
:arrow_up:

...orp/pinpoint/rpc/client/SimpleMessageListener.java
36.36% <0%> (ø)
:arrow_up:

...inpoint/web/websocket/ActiveThreadCountWorker.java
0% <0%> (ø)
:arrow_up:

...pc/server/LoggingServerMessageListenerFactory.java
90% <100%> (-10%)
:arrow_down:

...om/navercorp/pinpoint/io/request/EmptyMessage.java
66.66% <100%> (+16.66%)
:arrow_up:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc1c786...07bf0e4. Read the comment docs.


✨ [Feature]: 能给个支持Naive UI的示例吗

What problem does this feature solve
如题
What does the proposed API look like
如题
What is your project name
1

打日志看起来没问题

import { NButton } from 'naive-ui'

cdn方式也不行


add: short url backend

Hey, I just made a Pull Request!

This backend plugin will create, retrieve and redirect short urls in a db.
$ curl -X PUT -H "Content-Type: application/json" -d '{
  "fullUrl": "http://example.com/my/long/path",
  "usageCount": 0
}' "http://localhost:7007/api/shorturl-backend/create"
{"status":"ok","id":"2XC3U0BV"}

$ curl http://localhost:7007/api/shorturl-backend/go/2XC3U0BV
Found. Redirecting to http://example.com/my/long/path

$ curl http://localhost:7007/api/shorturl-backend/go/nomatch
{"status":"ok","message":"Not found"}

$ curl http://localhost:7007/api/shorturl-backend/getAll | jq
{
  "status": "ok",
  "data": [
    {
      "short_id": "LCNJGXT0",
      "full_url": "http://example.com/my/long/path",
      "usage_count": 1
    }
  ]
}

:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[X] Added or updated documentation
[X] Tests for new functionality and regression tests for bug fixes
[X] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

All of these changes are in #1222. Even a few modifications as well after integration. Closing


Rewrite module and add streaming

Hi Mike,
As I mentioned previously, this is a pretty big set of changes. There are still more tests to write~~, for instance testing partials, helpers, and filters~~. In order to get "100% coverage" failure of dustjs in the internal render function needs to be tested, and I'm not sure how to make that happen.
I have not updated the README as of yet.
Thanks for taking a look.
Edit: Basic partials, helpers, and filters tests are there now.

As an experiment, a method for injecting dust, or explicitly loading dust-helpers. This isn't included in this PR at the moment.
See here: dboune/hapi-dust@d59dcd4519935ca4f135b3623c286d04e259fe20


Change default config for Prom metrics

By default, the following metrics are now enabled:

graphql_envelop_deprecated_field
graphql_envelop_request
graphql_envelop_request_duration
graphql_envelop_request_time_summary
graphql_envelop_phase_parse
graphql_envelop_phase_validate
graphql_envelop_phase_context
graphql_envelop_error_result
graphql_envelop_phase_execute
graphql_envelop_phase_subscribe
graphql_envelop_schema_change
graphql_yoga_http_duration

This information should also be documented within the docs.

Fixed, thanks!


Update html-webpack-plugin v5

This PR fixes some typing errors for webpack and updated the html-webpack-plugin to v5 (alpha).
Also fixes a deprecation error with webpack. (see #144)

Apparently a dependency from the terser-webpack-plugin dropped node 8/9 support:
https://github.com/sindresorhus/p-limit/commit/b35faf54fb0871d9ae592069a18083a2ba15d8a9

Apparently a dependency from the terser-webpack-plugin dropped node 8/9 support:
https://github.com/sindresorhus/p-limit/commit/b35faf54fb0871d9ae592069a18083a2ba15d8a9

html-webpack-plugin  now has a 5.x series out of alpha FYI

Is there anything stopping this from merging?
I'm also waiting on the Typing updates eagerly 😄

I've updated the html-webpack-plugin and the webpack package to their latest versions.

@arthurbergmz any chance to review / complete this?

+1

I try install your branch, but I get error.
npm uninstall webpack-pwa-manifest && npm install strootje/webpack-pwa-manifest#update-webpack-v5 --save-dev

[webpack-cli] Failed to load '/app/webpack.config.js' config
[webpack-cli] Error: Cannot find module './dist/index.js'
Require stack:
- /app/node_modules/webpack-pwa-manifest/index.js
- /app/webpack.config.js
- /app/node_modules/webpack-cli/lib/webpack-cli.js
- /app/node_modules/webpack-cli/lib/bootstrap.js
- /app/node_modules/webpack-cli/bin/cli.js
- /app/node_modules/webpack/bin/webpack.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
    at Function.Module._load (internal/modules/cjs/loader.js:725:27)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (/app/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (/app/node_modules/webpack-pwa-manifest/index.js:1:80)
    at Module._compile (/app/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/app/node_modules/webpack-pwa-manifest/index.js',
    '/app/webpack.config.js',
    '/app/node_modules/webpack-cli/lib/webpack-cli.js',
    '/app/node_modules/webpack-cli/lib/bootstrap.js',
    '/app/node_modules/webpack-cli/bin/cli.js',
    '/app/node_modules/webpack/bin/webpack.js'
  ]
}

I try install your branch, but I get error.

I just tried installing my branch as well and for me it is working. Can you maybe provide more info as to what you are trying.
For anybody trying to get this package to work install it like this: npm install strootje/webpack-pwa-manifest#update-webpack-v5. This will grab the version from github and build it on the spot.
@arthurbergmz a review would be nice.

I try install your branch, but I get error.
npm uninstall webpack-pwa-manifest && npm install strootje/webpack-pwa-manifest#update-webpack-v5 --save-dev

[webpack-cli] Failed to load '/app/webpack.config.js' config
[webpack-cli] Error: Cannot find module './dist/index.js'
Require stack:
- /app/node_modules/webpack-pwa-manifest/index.js
- /app/webpack.config.js
- /app/node_modules/webpack-cli/lib/webpack-cli.js
- /app/node_modules/webpack-cli/lib/bootstrap.js
- /app/node_modules/webpack-cli/bin/cli.js
- /app/node_modules/webpack/bin/webpack.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
    at Function.Module._load (internal/modules/cjs/loader.js:725:27)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (/app/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (/app/node_modules/webpack-pwa-manifest/index.js:1:80)
    at Module._compile (/app/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/app/node_modules/webpack-pwa-manifest/index.js',
    '/app/webpack.config.js',
    '/app/node_modules/webpack-cli/lib/webpack-cli.js',
    '/app/node_modules/webpack-cli/lib/bootstrap.js',
    '/app/node_modules/webpack-cli/bin/cli.js',
    '/app/node_modules/webpack/bin/webpack.js'
  ]
}

Same issue. Did you solve it?


Question: Omit required fields?

Hello!
The way my app is made, is that you have to input your name first, (to init some db things in the callback), and then the whole form appears.
The problem is, is that I had to set all the fields to optional: true to make this work. Unless, the form wouldn submit at the first page (where only the name input is shown), since optional fields were not populated since they were hidden.
Is it possible to fix this in a way? To omit all the required fields but the name at the first page for example.

Nobody knows?

Maybe make the first form with the name a regular non-autoform form and on submit, get the value, do whatever needs to be done and then open an autoform form with the rest of the fields. If You need the name in db, you can later add it to the doc in the autoform before/onSubmit hooks .

It's hard to say without seeing the actual form, but generally for this situation, you just need to use a schema on your form that is different from the schema attached to your collection. One that includes only the visible field.
Or use multiple forms, or set the required values to something in the beforeInsert hook. There are lots of potential ways to make it work depending on the situation.


Include the response type in ProducesResponseType for client errors

Refactor ActualApiResponseMetadata discovery in to a separate more manageable type
Annotate action result ctors and helper methods that specify the "object" value with attribute
Modify the discovery of parameters to match ActionResultObjectValueAttribute and ActionResultStatusCodeAttribute by name
to allow users to write and annotate custom helper methods and action results, a la NotNullAttribute.

Fixes #8345

🆙 📅


feat: Update "download datasets" copy caption (#5586)

Reason for Change

#5586

Changes

Modified download datasets copy caption text as per mocks to include a link to the schema and Discover API.
Schema URL is updated to https://github.com/chanzuckerberg/single-cell-curation/blob/main/schema/3.1.0/schema.md as per slack thread.

Hi @danieljhegeman!

Where is the accompanying change to display a Discover API url or similar download url that actually is "valid forever"?

I split the caption copy and the actual URL update into separate tickets (copy update and URL update). @frano-m will have the URL update ready for a PR shortly and we can revisit this update to the copy then.

Superseded by https://github.com/chanzuckerberg/single-cell-data-portal/pull/5835.


Propose a tag to map variables directly to the browser JS scope

Please see: https://stackoverflow.com/a/59136857/1951298
So I kept a long painful to see file like the following:
<% if(typeof announcements != 'undefined'){ %>
<script>
  __announcements__ = <%- JSON.stringify(announcements) %>
</script>
<% } %>
<% if(typeof success != 'undefined'){ %>
<script>
  var getTest = "<%= success  %>"
  if (getTest)
    __successes__.push(getTest)
</script>
<% } %>
<% if(typeof error != 'undefined'){ %>
<script>
  __errors__ = <%- JSON.stringify(error) %>
</script>
<% } %>
<% if(typeof toFocus != 'undefined'){ %>
<script>
  var __toFocus__ = "<%= toFocus  %>"
</script>
<% } %>
<% if(typeof data != 'undefined' && typeof data._id != 'undefined'){ %>
<script>
  var __id__ = "<%= data._id  %>"
</script>
<% } %>
<% if(typeof data != 'undefined' && typeof data.lat != 'undefined'){ %>
<script>
  var __lat__ = "<%= data.lat  %>"
</script>
<% } %>
<% if(typeof data != 'undefined' && typeof data.lng != 'undefined'){ %>
<script>
  var __lng__ = "<%= data.lng  %>"
</script>
<% } %>
<% if(typeof context != 'undefined'){ %>
<script>
  var __context__ = "<%= context  %>"
</script>
<% } %>
<--! and much more -->

This is a hack to have my server variables pushed to their equivalent JS variables. So that later they are accessible by other JS scripts on client side.
A definition tag like
<define%>
var __announcements__ = announcements
var __errors__ =  JSON.stringify(error)
var __lng__ = data.lng
<%>

would be great !!! To put it simple, this tag just creates new JS variables and hopefully permissive as well when variables are not present !
see https://github.com/eta-dev/eta/issues/184

As with #183, this seems like it would very large and out of the scope of the project.

agreed


⚠ ClamAV has degraded performance

In 76d6e36, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 448 ms

Resolved: ClamAV performance has improved in d67fbbe.


TypeScript support

TypeScript and typedoc are very similar to JavaScript and jsdoc so this should be rather straightforward (or so I hope).

:+1:

Jumping in here with additional info:
There is typedoc that parses typescript for doc comments and outputs both html docs as well as a parsed abstract syntax tree (AST) when called with the --json outfile.json parameter.
Maybe its as easy as swap out the jsdoc parser against typedoc and if we are lucky the typedoc AST is the same or a very similar format than the jsdoc one that can be processed and analysed by the inch backend.

:+1:

This issue is related to a newer one: https://github.com/inch-ci/inch_ci-web/issues/177


Thermocycler: API: Reliable Execution of Long Protocols

As a protocol designer, I would like to be able to reliably run extended protocols without issue, so that I can run long library prep protocols on the thermocyler, and/or handle protocols with long 'storage' temp pauses.
Acceptance Criteria

[ ] Robot and App able to run 3+ hour protocols reliably

Implementation Notes

Current problems may have something to do with smoothie timeout

See Doc here for results from testing.


(#11786) Fixing specs' running in Ruby 1.9

Fixed specs' running through the renaming of required files
in lib/puppet/util/rdoc/parser.rb, also added one tiny condition
for Ruby 1.9.3 and 1.9.2. Ugly fix, but it works. Anyway, there
are still some failing specs.
Also fixed some tab intendation characters.

I still get failures out of this on 1.9.3 here, so I am going to reject it for the moment.  Happy to see it reopened if you update it, though.

Daniel, what kind of failures you get? Failing specs or rSpecs even don't start to execute, as it described in the ticket? Thanks.

The specs failed; let me reproduce that: https://gist.github.com/9403f4ef547227064adb

Yeah, truly failed. I'll try to fix that, sure. Hope i can beat this.
But without this commit i still get https://gist.github.com/1684670 (running on current SHA: 7d890ae0b8c)

#572 actually fixes this properly - we can't work with the newer RDoc, so we detect that and fail hard.


Create conda package

Create a bioconda package for genomics-data-index.
I have a template for bioconda at https://github.com/apetkau/bioconda-recipes/blob/gdi/0.1.0/recipes/genomics-data-index/meta.yaml, however it's missing some conda packages as dependencies. Mainly:

[ ] - https://github.com/ga4gh/vrs-python
[x] - https://github.com/biocommons/biocommons.seqrepo

I will need to create conda packages for these to get everything to work.

Looks like seqrepo exists in bioconda now https://anaconda.org/bioconda/biocommons.seqrepo

I need to look into if I still need vrs-python for my application. If not, I could try to remove it, otherwise I will have to add it to bioconda.

Added in https://github.com/bioconda/bioconda-recipes/pull/38188


Do not set "alsologtostderr" flag

LGTM

add --logtostderr to hyperd in the travis test.

@ptptptptptpt could you update the PR to add the --logtostderr flag to .travis.yaml just as @laijs  said?


#2021 Remove web uploader page

✅ DoD

[x]  Disable web uploader #2021

https://github.com/rfcx/arbimon-legacy/assets/51106210/77c2644d-5c8b-4134-9454-5c454824dccf

good job!


fix: asset search auto focus

Description
This enables auto focus on asset search input box for trade asset / search asset / buy and sell asset modals
Notice

[X] Have you followed the guidelines in our Contributing guide?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[X] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
https://github.com/shapeshift/web/issues/1723

Risk
No particular risk identified

Testing

Navigate to assets page
Verify input field is auto focused
Click on one asset in the trade window
Verify input field is auto focused
Click on buy / sell crypto => Gem / Buy => Select an asset to buy
Verify input field is auto focused

Screenshots (if applicable)

@NeOMakinG @chxash if either of you want to make an issue/PR that

removes the lint rule
removes existing comments that disable the lint rule for housekeeping

i'll gladly approve and merge as per @reallybeard
as far as this PR goes, LGTM

I will do that !

@chxash we've had flaky cypress tests recently, but i've rerun this multiple times and it seems to fail in the same place.
can you please check with yarn test:cypress or yarn test:cypress:headless locally to reproduce, debug the issue, and update the cypress test case?

please see comment - i believe this is causing cypress tests to fail

I have ran cypress tests multiple times, and I had the same failure at first try, then they passed everytime.
It's the same issue as always, following line is timing out waiting for requests in dashboard_spec.ts:
cy.get('[data-test=trade-form-preview-button]').contains('Insufficient Funds', {       timeout: 60000, })
I could increase the timeout again ? but I am not sure

@chxash confirmed - apologies, we did think this was related to trade tests failing as this component is used by the swapper, but indeed it did just pass CI when i ran it again now.

@chxash confirmed - apologies, we did think this was related to trade tests failing as this component is used by the swapper, but indeed it did just pass CI when i ran it again now.

@0xdef1cafe  no need for apologies really ! I was doubting as well.


Control + MouseWheel to change workspaces breaks xnview functionality

I used to zoom in and out with this keybinding in xnviewmp. Under lumina it brings me to another workspace...

You can change this within the keyboard shortcuts file 'fluxbox keys'.  We've made this easy to do within lumina-config. Look for the shortcuts page.  The entry you need to look for is the ones for: Scroll wheel (Buttons 4 and 5).
If you have any problems with this, let us know! :)


redemption QR code Page should show more ticket details on asset card, not only 1 Voucher

Eg.
For FIFA tickets should be "1 FIFA WC2018 Vouchers" instead of "1 Vouchers"

fixed


Training time and parameters

Hi, you mentioned that your model took under 10 hours to train on 4 gtxforce 1080Ti GPUs.
I'm running mostly the same configuration as DMFNet_GDL_all.yaml

267 training patient data
DataLoader workers = 8
batch_size = 8
4 P100 GPUs (which are faster and higher memory than 1080Ti)

However, without altering your code, each epoch takes me around 15minutes, which means that I'll be taking 125hrs to finish training 500epochs.
What other setups did you have? Or do you know what might be wrong on my end?
Thank you!

Hi. (1) I have checked the config and it seems not problems, without other setups. (2) It runs on  four 1080Ti just need 10 hours, I ever tried on four 2080Ti gpus which run at a faster speed. I believe that P100s should achieve the same performance of the running time though I have not tried. (3) Could you provide more information about the time bottleneck during training, i.e., data loading? network forward computing? loss or gradient computing? Please let me know if anyone encounter the similar issue?

Hi thank you for getting back to me.
My main time consumption seems to be from the data loading. Once it finishes the dataloading part, the rest are pretty fast. I've played around with different amounts of data workers, 3 seems to work best for me. When I try 8, it often takes a really long time.
I will run it again on my side, time the different subprocess and I'll let you know.

You mentioned that training over 288 patients, batchsize=8 for 500 epochs would be 10hrs, which means that one epoch (36 batches) would take around 1 min 12s per epoch. Some batches alone for me are nearly that long.
I just setup 4 P100 GPUs and ran the train_all.py file on 267 patients, batchsize=8, data workers=8

Each batch for me (batchsize=8) varies. Most batches are 3s but some others are as long as 35s, 45s, 60s.
Total time taken for 1 epoch from the start of the training iteration is 8mins.

---- Here are a few of my logs -----
Number of patients training files = 267

| From start -> setup of model: Time taken = 6.9183571338653564
| Setup of datasets and train_loader: Time taken = 0.0037386417388916016
0 | Time to load first batch: Time taken = 65.07010841369629
1 | Retrieve data before feeding into model: Time taken = 0.0035915374755859375
2 | Model in -> Model out: Time taken = 18.821953773498535
3 | Calculate loss & update: Time taken = 0.8617253303527832
4 | Zerograd, backprop, optimizer step: Time taken = 14.86911416053772
6 | Time between batches of train_loader: Time taken = 0.00020647048950195312
1 | Retrieve data before feeding into model: Time taken = 0.09489107131958008
2 | Model in -> Model out: Time taken = 0.34704089164733887
3 | Calculate loss & update: Time taken = 0.4055967330932617
4 | Zerograd, backprop, optimizer step: Time taken = 1.6324901580810547
5 | Finished one batch: Time taken = 2.480588912963867
6 | Time between batches of train_loader: Time taken = 6.747245788574219e-05
2019-08-24 05:53:26,200 Iter 2, Epoch 0.0599, Loss 0.9904894
1 | Retrieve data before feeding into model: Time taken = 0.0002377033233642578
2 | Model in -> Model out: Time taken = 0.06069469451904297
3 | Calculate loss & update: Time taken = 0.6516270637512207
4 | Zerograd, backprop, optimizer step: Time taken = 1.6323268413543701
5 | Finished one batch: Time taken = 2.3456132411956787
2019-08-24 05:53:28,546 Iter 3, Epoch 0.0899, Loss 0.9738502
1 | Retrieve data before feeding into model: Time taken = 0.0002281665802001953
2 | Model in -> Model out: Time taken = 59.20406985282898
3 | Calculate loss & update: Time taken = 0.7082192897796631
4 | Zerograd, backprop, optimizer step: Time taken = 1.6912016868591309
5 | Finished one batch: Time taken = 61.634665727615356
2019-08-24 05:57:05,227 Iter 20, Epoch 0.5993, Loss 0.9007623

It seems that the training process is blocking with multiply workers here and confused me as well. Maybe you could check your torch version (0.4 or 1.0). I have ever met the dataloader issue that my code (not this one) works well under python2+torch0.3 but failed under python3+torch0.3, it is dead in the dataloader (always waiting....), I tackled the issue by updating the torch to 1.0 version.
The healthy training log should be (batchsize=8, four 1080Ti):
2019-01-19 23:01:23,700 Iter 1, Epoch 0.0316, Loss 0.9967
2019-01-19 23:01:25,539 Iter 2, Epoch 0.0632, Loss 0.9880
2019-01-19 23:01:27,364 Iter 3, Epoch 0.0947, Loss 0.9813
2019-01-19 23:01:29,190 Iter 4, Epoch 0.1263, Loss 0.9693
2019-01-19 23:01:31,016 Iter 5, Epoch 0.1579, Loss 0.9390
2019-01-19 23:01:32,840 Iter 6, Epoch 0.1895, Loss 0.9832
2019-01-19 23:01:34,664 Iter 7, Epoch 0.2211, Loss 0.9250
2019-01-19 23:01:36,546 Iter 8, Epoch 0.2526, Loss 0.9647
2019-01-19 23:01:38,374 Iter 9, Epoch 0.2842, Loss 0.9490
2019-01-19 23:01:40,242 Iter 10, Epoch 0.3158, Loss 0.9510
2019-01-19 23:01:42,139 Iter 11, Epoch 0.3474, Loss 0.8744
2019-01-19 23:01:44,129 Iter 12, Epoch 0.3789, Loss 0.8663
2019-01-19 23:01:45,973 Iter 13, Epoch 0.4105, Loss 0.8082
2019-01-19 23:01:47,851 Iter 14, Epoch 0.4421, Loss 0.8032
2019-01-19 23:01:49,803 Iter 15, Epoch 0.4737, Loss 0.8322
2019-01-19 23:01:51,981 Iter 16, Epoch 0.5053, Loss 0.8499
...
2019-01-19 23:02:55,920 Iter 47, Epoch 1.4842, Loss 0.5505
2019-01-19 23:02:57,926 Iter 48, Epoch 1.5158, Loss 0.5341
2019-01-19 23:03:00,582 Iter 49, Epoch 1.5474, Loss 0.5660
2019-01-19 23:03:02,725 Iter 50, Epoch 1.5789, Loss 0.5569
2019-01-19 23:03:04,738 Iter 51, Epoch 1.6105, Loss 0.6413
2019-01-19 23:03:06,975 Iter 52, Epoch 1.6421, Loss 0.5356
2019-01-19 23:03:09,081 Iter 53, Epoch 1.6737, Loss 0.5404
2019-01-19 23:03:11,155 Iter 54, Epoch 1.7053, Loss 0.6251
...
My final converged loss would fluctuate about 0.32~0.40. By the way,  BraTS 2019 it also works.

Hmm that's weird. I have no idea why it's so different. So your current version with no dataloader delays is with python3 and pytorch 1.0? Does yours work with pytorch 1.2?
I am currently running python 3.7.4 and pytorch 1.2.0.

I am not sure why it crashed in python 3.7 and pytorch 1.2 just like you described.  I have tried that Pytorch 0.4 and 1.0 with python 3.6 both work OK. Hoping my answer would be helpful.

I downgraded pytorch 1.0 and it still trains with the same speed but that's okay. I will make do with it. Thank you for your help!

Hi I thought I'd follow up on this.
I've shifted to using 4x2080Ti GPUs and they've gotten training times as you've reported of around 10-11hrs. I think Google Cloud Platform's P100s seem to be quite a bit slower, not sure why. Also the dataworkers don't seem to be stuck anymore.

I’ve faced the dataloader delay problem with python 3.7 and pytorch 1.0/1.4. Has anyone solved this problem.


Fix issue 9

A fix for issue #9

This fix worked for me. Thank you, man! My laptop is an Avell G1513 MxTI and I'm running Mint 19.

Thanks for verifying.

I realised that the brightness wasn't actually adjusting when used with -V or -H. Should be fixed now in the latest commit in this pull request.

Thank you

Hi, does anyone have the problem where the LEDS's blink for a second then turn themselves back off?


Fix mtab warning for mkfs commands

Docker image debian:bullseye-slim does not contain /etc/mtab symlink. While docker is setting it automatically for every container, containerd is not doing this.
This affects Kubernetes deployments with containerd, which are report the following warning every time when attaching a new volume to pod:
mke2fs 1.44.5 (15-Dec-2018)
ext2fs_check_if_mount: Can't check if filesystem is mounted due to missing mtab file while determining whether /dev/drbd1000 is mounted.

This confuses the end users of linstor-csi plugin.

Should I create a similar PR for piraeus-server image?

linstor-csi: this error is shown every time when any other error occurs with linstor-csi.
piraeus-server: this error is shown only when user manually exec into linstor-node pod and run mkfs.ext4 /dev/drbd1000 there. If I remember correctly. linstor-satellites are never run mkfs commands by themself.

linstor-satellites are never run mkfs commands by themself.

That's changed with https://github.com/piraeusdatastore/linstor-csi/commit/1ffbefb8f4ae74012f3b04855649fb1c4e3041d2


Hira cel5 symbol and others

Added cel 5 symbol to celestial glyph cosmetic set
Reduced multiplier entry blinking speed
Removed multiplier entry flashing effect on touch (this only happens on a PC with touch panel)
Widen android perk layout to make it look nicer
Reword change log entry to make it clear

I'm on Chrome124 + Win11, and I don't see the glyph icon offset issue :blobsad:
And about the multiplier tab flashing issue, please refer to the screen recording for your reference.
https://github.com/IvarK/AntimatterDimensionsSourceCode/assets/56225774/9f0e7449-af0d-48be-bad0-02a607857b60


Overlapping of parameters on Rx labels

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Allows overlapping of parameters on Rx labels so that label information can be viewed and consumed in multiple ways within the UI and models as needed.  No overlapping is allowed for Tx labels as this would create a conflict with multiple writers to the same label. This PR imposes new restrictions that would be backwards compatible with existing working configurations.
Imposed restrictions for Rx Labels:

Start Bit: 0-31 was bit 8-30, now includes label number and parity
Number of Bits: 1-32
Overlapping allowed

Imposed restrictions for Tx Labels:

Start Bit: 8-30
Number of Bits: 1-23 was 1-32 bits, now excludes label number and parity
Overlapping not allowed

Why should this Pull Request be merged?
It is often requested to view the raw label value along with individual parameters representing engineering values within a label at the same time.  This could be handled with a single raw label and multiple models and perhaps scaled channels, but this approach would not scale well.  Fixes #210
What testing has been done?

Successful completed all VI Tester Steps.
Create a system definition with a raw parameter that overlapped with an existing parameters on a Rx label.
Imported, deployed and observed the correct behavior with overlapping parameters on the Rx label.
Create a system definition with a raw parameter that overlapped with an existing parameters on a Tx label.
Observed Error -732252 as expected during import.

/AzurePipelines run


feat: Allow configuration of Replicas

@davidgubler an Idea I just had: Ommit replicas entirely if it's not defined in the compose file. This would leave whatever is already configured on the cluster, eg. for manually scaled deployments

Omit replicas entirely if it's not defined in the compose file.

I am not entirely sure if that works but if it does work I it certainly sounds like a good solution.

I did a few tests to determine the behavior, and it's, uh, "interesting". Now for context, it's important to know that kubectl apply will, for each resource created, save a JSON-serialized version of whatever you wrote in the input file into an annotation  kubectl.kubernetes.io/last-applied-configuration. This annotation is updated each time kubectl apply is re-run.

If spec.replicas is set in the YAML file, kubectl apply will overwrite whatever is configured on the cluster. (so far so good)
If spec.replicas is unset, and the version in the "last-applied-configuration" did also NOT contain a value, kubectl apply will leave whatever is set on the cluster.
If spec.replicas is unset, but the version in the "last-applied-configuration" DID contain a value, kubectl apply will overwrite whatever is set on the cluster with what was saved to "last-applied-configuration". (Subsequent kubectl apply runs will then ignore the replicas since now there is no value set in "last-applied-configuration" anymore.)

I think switching between having replicas configured explicitly and not is an edge case. I'll therefore update the PR, I think this causes the least surprises.

LGTM, given the behavior of kubectl I agree that this variant seems reasonable. Feel free to merge.


Add support for aggregated grouped_lights commands

No more need to send light commands to each individual light of a group as Signify added support to send aggregated commands on the API.

No more need to send light commands to each individual light of a group as Signify added support to send aggregated commands on the API.

I am still seeing the one-at-a-time behavior with HomeAssistant 2022.3.7/aiohue 4.4.1.  Is this expected?

No more need to send light commands to each individual light of a group as Signify added support to send aggregated commands on the API.

I am still seeing the one-at-a-time behavior with HomeAssistant 2022.3.7/aiohue 4.4.1. Is this expected?

Yes, you'll have to wait for a new version (2022.4) of HA as this is a new feature.


[WIP] patch-v0.7.x updates for v0.7.2 - DRAFT WIP

(updated)

drop support for Rollup pre-0.68
switch to @rollup/plugin-replace in patch-v0.7.x

resolves #8
GENERAL RATIONALE:

It would be ideal to switch away from outdated Rollup plugin, if possible (for v0.7.x)
Considering that @rollup/plugin-replace is not officially supported with Rollup pre-1.0, it would be ideal to avoid the need for testing & support with older Rollup 0.x versions if possible

TODO:

[ ] update some more dependencies
[ ] regenerate yarn.lock
[ ] ensure that downstream react-recompose is upgraded to Rollup 0.68 as I proposed in: https://github.com/react-recompose/react-recompose/pull/25
[ ] consider adding the rationale to the commits in this proposal
[ ] consider adding some rationale to the react-recompose updates proposed in react-recompose/react-recompose#25

IMPORTANT NOTES:

removing support for Rollup pre-0.68 is a BREAKING CHANGE and assumes:

the recent v0.7.1-rc1 version of this fork is not to be considered "stable" (as described in a commit message)
downstream react-recompose is upgraded to Rollup 0.68 (see TODO item above)

switch to @rollup/plugin-replace with Rollup pre-1.0 results in an ugly installation warning message (tradeoff vs using unsupported Rollup plugin package, as described in a commit message)

MERGE STRATEGY:

[ ] My plan is to push the commits directly to the patch-v0.7.x branch.

patch-v0.7.x branch support has been retired, closing


Minor bugfixes in API examples, CHANGELOG fix

Minor bugfixes for the API examples
CHANGELOG fix: 0.4.7 has not been released, it is still 0.4.7-dev. For a release, I'd merge dev into master and follow the release steps described at the bottom of the README

Coverage remained the same at 75.21% when pulling c88426f0d161f37e4f3e6fcde3c81645145b3aad on examples-fixes into 0ae04a46ae238a60de137a26c4146ad22b3f1c82 on development.

👍


Add auth BE to subs

Task/Issue URL: https://app.asana.com/0/488551667048375/1205077126622549/f
Description
This PR adds auth to subs
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3508   👈

This comment was auto-generated by Graphite.


Question regarding best practices

Hey all. Thank you so much for the enlightening tutorial.
This snippet got me thinking:
class Fighter(BaseComponent):
    entity: Actor

As the Fighter class uses properties of Actor that do not exist in Entity, would it be more proper to name this property actor instead?
I know this type of feedback can come across as criticism, but I genuinely do not know as I am a novice when it comes to python (outside of data processing).

It inherits from BaseComponent which I assume has entity: Entity.  The line entity: Actor is used to narrow which type is expected in that slot for Fighter while staying compatible with other BaseComponent methods.
This wasn't my best work and there could be some other issues which come from doing things like this, but MyPy considered this valid when it was written and probably still does.

Ah. “Narrowing” the acceptable type for the SubClass jives with me. That seems right now. Thanks!