GE: DWI: Create a protocol with FOCUS that matches the recently-updated non-FOCUS protocol

Hello Julien,
Our team would appreciate this as well. We are currently setting up this protocol at another GE site with the FOCUS license.
Respectfully,
Ken

Hello Julien,
Our team would appreciate this as well. We are currently setting up this protocol at another GE site with the FOCUS license.
Respectfully,
Ken

@kennethaweberii it would be great if you could generate the protocol and send it to me so I can add it to the repository.
You can download the latest versions of:

https://github.com/spine-generic/protocols/blob/main/GE/GE_750_no-FOCUS/spine_generic_ge_750_no-FOCUS.html
https://github.com/spine-generic/protocols/blob/main/GE/GE_750_DO_NOT_USE/spine_generic_ge.html

And in the "no-FOCUS" protocol, replace the "DWI" sequence by the one from the "GE_750_DO_NOT_USE" protocol.
I'm happy to assist and review the images afterwards. Thanks!

@kennethaweberii it would be great if you could generate the protocol and send it to me so I can add it to the repository.
You can download the latest versions of:

https://github.com/spine-generic/protocols/blob/main/GE/GE_750_no-FOCUS/spine_generic_ge_750_no-FOCUS.html
https://github.com/spine-generic/protocols/blob/main/GE/GE_750_DO_NOT_USE/spine_generic_ge.html

And in the "no-FOCUS" protocol, replace the "DWI" sequence by the one from the "GE_750_DO_NOT_USE" protocol.
I'm happy to assist and review the images afterwards. Thanks!


out of memory

Traceback (most recent call last):

jaxlib.xla_extension.XlaRuntimeError: RESOURCE_EXHAUSTED: Out of memory while trying to allocate<PHONE_NUMBER>2 bytes.
BufferAssignment OOM Debugging.
BufferAssignment stats:
parameter allocation:  959.50MiB
constant allocation:  136.16MiB
maybe_live_out allocation:   12.84GiB
preallocated temp allocation:   14.64GiB
preallocated temp fragmentation:       480B (0.00%)
total allocation:   28.56GiB
total fragmentation:  136.17MiB (0.47%)
Peak buffers:
Buffer 1:
Size: 8.91GiB
Operator: op_name="jit()/jit(main)/while/body/remat/mesh2grid_gnn/_process/mesh2grid_gnn/_process_step/mesh2grid_gnn/concatenate[dimension=2]" source_file="/root/miniconda3/envs/large/bin/ai-models" source_line=33
XLA Label: fusion
Shape: bf16[3114720,1,1536]
==========================
    Buffer 2:
            Size: 2.97GiB
            Operator: op_name="jit(<unnamed wrapped function>)/jit(main)/while/body/remat/mesh2grid_gnn/_embed/mesh2grid_gnn/sequential/encoder_edges_mesh2grid_mlp/linear_1/dot_general[dimension_numbers=(((2,), (0,)), ((), ())) precision=None preferred_element_type=bfloat16]" source_file="/root/miniconda3/envs/large/bin/ai-models" source_line=33
            XLA Label: custom-call
            Shape: bf16[3114720,512]
            ==========================

Maybe you could try the larger GPU memory instance


📄 Antitrust policy [due 23 Aug]

Antitrust policy
akin to: https://www.linuxfoundation.org/legal/antitrust-policy
voting group: @commonhaus/cf-egc
Do one of the following:

Approve the PR or react with 👍 (:+1:) if it looks good to you
Review with Comments or react with 👀 (:eyes:) if you're "ok" with it (it may not be your favorite)
If you think it needs discussion or revision

Create a review, add your comments and require changes
Use the +- button to make a suggestion (instead of just adding a comment).

I have enough of a reset that I'm going to close this and re-open to reset the vote w/ a new timeline.
vote::result withdrawn


Improve Web export presentation

Web export still fails to run with ES3, but now looks nice while doing so
Give it a try (in 2.2-alpha): http://godot.eska.me/temp/web-presentation/

Check for WebGL support, don't load if unsupported, fixes #3570
Check for IndexedDB support, fixes #2758
Make canvas failure message visible
Colored debug output for warnings and errors
Make it obvious status can be closed by clicking
Don't use status to display non-critical errors
Limit output message count
Add output clear button
Fix setting total memory
Some style changes

Also add 'Droid Sans' as default font. I'm not including it as a web font though, I don't want to contact a CDN by default. Users can manually link it in the export options (style or head include)
Some build system tuning:

Emscripten injects its loader script when linking, so force relinking whenever the HTML shell changes
Remove useless FULL_ES2 flag, which should've been a linker flag, but would impact performance too much

Improved the status handling a bit


RealSR training results with demo project using pre-trained model

OVERVIEW OF PL: LINK
COMPLETED

[x] EDSR demo project using PRE-TRAINED opencv model.
[x] Dataset generation using RealSR's kernel estimation method.
[x] Train RealSR model using above dataset.

In NVDIA P100 GPU, it takes up to 6 hours 30 minutes.
It may not be able to train in personal desktop or laptop, therefore If you want to train, I recommended you to train using a colab pro(or pro+) condition.

[x] Added sample result(DIV2K 998).

TODO (Future plan)

[ ] Make a RGB dataset for EDSR/ESPCN, to train model using kernel estimation
[ ] Train EDSR/ESPCN model using above NEW dataset.
[ ] Check if there are any improvement in the result. (Not only PSNR/SSIM, MOS, ...)

Ref this link, to overview my PL.

Can you add .gitignore by referring to the link below?
https://github.com/github/gitignore/blob/main/Python.gitignore

Can you add .gitignore by referring to the link below? https://github.com/github/gitignore/blob/main/Python.gitignore

Thank you for your information.

[x] Added .gitignore to avoid to push _pycache_ and .DS_Store file.
[x] Deleted all of _pycache_ related file/folder.

Please mention if there are any other issues in my work.
Thank you.

Thanks for the correction:) There is one more thing I would like to comment. As the RealSR follows the Apache 2.0 license, so it seems that the code you write must also specify the license as Apache2.0. Can you add a license too?
https://github.com/jixiaozhong/RealSR/blob/master/LICENSE

Thank you for your information.
I completely forgot to set the relevant license when creating the repository.
If I proceed with Video SR later, I will add an appropriate license to the  VideoSR repository too.

[x] Added license (Apache 2.0) to repository.  (You can check License update in my repository. )

Please mention if there are any other issues in my work.
Thank you.


Followed readme, ran into problem

After following instructions on README, running elixir --sname visualixir --hidden -S mix phoenix.server gave me ** (Mix) The task "phoenix.server" could not be found
Not being experienced with Elixir leaves me stumped! Thanks

mix phx.server should work. It seems as if the Readme hasn't been updated after the bump to phoenix 1.3…

sorry about that dudes, i'll fix that up.

It may help to remind the user to cd .. out of the assets folder for ease of use.


[Suggestion] Remove gpu-only configuration

Is there anything that's missing or inappropriate in the docs? Please describe.
As GPU-only search is no longer supported in v0.5.0, doc about resource configuration needs to be changed.
Describe your suggestion
Remove doc about configuring gpu as the only resource.
Additional info
GPU-only search might be supported in future releases.

Fixed in #100


refactor for async and smarter LLM use

I'm cooking on the Database stuff right now, and it's clear that there's a few things we can do to make the daily run much more efficient.
The searches, summaries, and action item generation are all done sequentially, which is slow (especially if we are working with more than just the 3 top search results like I am currently testing with).
This is compounded by our performing of the whole summary and action item generation before DB insert. We had discussed way back at the hackathon that we should probably insert the day's searches into the DB, then retrieve them and do LLM stuff. That would save a lot of undue processing.

Yes, rather than a data pipeline, what we have now is lumpy data porridge. That's a legacy from the 20hr sprint that we'll want to refactor, as you say, once we have the properly MMF launched (imminent!).

after some reconsideration and code reformatting, the "smarter LLM use" part of this is done. Async is still a "nice to have", but this is a low urgency task, since we have a long time to process between each "firing"


bug: example1 too mum about fetch and install kcp

Describe the bug
example1 is AKA the "extended example".
(1) This doc has two alternate paths for how to "deploy kcp and KubeStellar" --- either as bare processes or as workload in a Kubernetes cluster.  In the first path there are words about how to get kcp.  In the second path there are no words at all.
(2) In the first path, the pointer given for kcp is not good.  It does not point to instructions for what the user needs to do.  A better pointer would be to the beginning of https://docs.kcp.io/kcp/v0.11/#quickstart .
(3) It is important to remember that not every user is the one who installed the central components.  We must not suppose that the way to get what a user needs is part of deploying.
Steps To Reproduce
See above.
Expected Behavior
Users know how to get what they need.
Additional Context
No response

@eaepstein
@francostellari
@dumb0002

#986 fixed points 1 and 2 here.  Point 3 is part of a larger issue, clearly separating the role of platform deployer from general user.

closing this issue.  need to open a new issue that separates deployer and user in the form of useful documentation

@KPRoche please supply the issue number for the item that addresses/describes this concern.

Issue 1023
https://github.com/kubestellar/kubestellar/issues/1023


PB-Assembly

Operating system
Linux, CentOS7
Package name
falcon-kit 1.2.3
pypeflow 2.1.0
Describe the issue
I am running the falcon job in our Moab PBS system, so I don’t have the -W block=T option available. And given this post:https://github.com/adaptivecomputing/torque/issues/268, I don’t think Moab will implement some blocking function in the near future.
So instead of using “pwatcher_type=blocking”, I used “pwatcher_type=fs_based”.
It turned out this option is not well implemented, for example, for some of the tasks, it worked, but for others, it failed.
When it fails, the error message will (always) be something like:
[INFO]CALL:
qdel Pedec92ba939bd0
qdel: illegally formed job identifier: Pedec92ba939bd0
I suspect this means falcon tries to kill an already-killed job after it detects the "run.sh.done" file.  Normally A simply re-submission of the same job script will resume the whole pipeline. But I am just wondering whether we could fix this issue so that people don't need to re-submit the same job over and over.
Then I tried to use a combination of “-I -x” in hope to make an equivalent case for -W block=T (see this post: https://stackoverflow.com/questions/5982857/making-qsub-block-until-job-is-done). This time, the job keeps running, however, even the pbs job is “done” (status C in queue), there is no “run.sh.done” file generated in the designated directory. I am not sure whether this is the default behavior, or I hit another bug.
Error message
when using "pwatcher_type=fs_based":
[INFO]CALL:
qdel Pedec92ba939bd0
qdel: illegally formed job identifier: Pedec92ba939bd0

Then I tried to use a combination of “-I -x” in hope to make an equivalent case for -W block=T (see this post: https://stackoverflow.com/questions/5982857/making-qsub-block-until-job-is-done). This time, the job keeps running, however, even the pbs job is “done” (status C in queue), there is no “run.sh.done” file generated in the designated directory. I am not sure whether this is the default behavior, or I hit another bug.

The fs_based process-watcher is very difficult to maintain. Please file an issue at

https://github.com/PacificBiosciences/pypeFLOW/issues

And try to create a simpler example, so we can focus solely on pypeFLOW.


emac_hal_set_phy_data, declared but neither defined nor used (IDFGH-8474)

I'm wondering, what's with this declaration? There is no corresponding definition/implementation.
https://github.com/espressif/esp-idf/blob/c18a72134d649aa1985b9e43f8e98198c4eaebf8/components/hal/include/hal/emac_hal.h#L216
There is a emac_ll_set_phy_data (note the LL, not HAL), used in conjunction with emac_hal_set_phy_cmd inside of emac_esp32_write_phy_reg.

nice catch, it's a leftover during emac HAL driver refactor. It should be a simple wrapper over emac_ll_set_phy_data.

I'm only sniffing around in those parts because I need to use the SMI/SDIO individually, to set some registers in two PHYs I've got attached to the bus. unfortunately, the LL+HAL+IDF interfaces don't give me clean access.
I think I instantiated some IDF-level mac object, but then couldn't call the init() on that because that also assumes the existence of a "mediator", which ropes in a phy object and already starts some task that's only required for actual ethernet comms (which I don't need), so I copy-pasted the GPIO setup from that... I guess my use case (no actual ethernet comms) is unusual.


ActiveRecord::RecordNotFound in StaticPagesController#index

Session stores user id, if account is deleted or id changed, etc. then error occurs.

This shouldn't really be a problem .. session should reset by the time (if) an account gets deleted..  no? @kylekthompson

Ideally, they should even be deleting their own accounts.. or trying to log back in if they did delete it.
Quick solution is to just set the session to nil on destroy of User


CANBUS ERROR: Failed to create can client

System information

Linux Ubuntu 18.04:
Apollo installed from binary:
Apollo version 3.0:

Hello,
I am trying to run apollo 3.0 with carla 0.9.5 using a ROS bridge (https://nemodrive-docs.readthedocs.io/projects/nemodrive-apollo/en/latest/config_run.html#running).
When I open dreamview I am getting an error, saying that the can client could not be created.
Full error from log file:
Log file created at: 2019/08/10 12:01:54
Running on machine: in_dev_docker
Log line format: [IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg
E0810 12:01:54.188791 10747 factory.h:112] Factory could not create Object of type : 1
E0810 12:01:54.189450 10747 can_client_factory.cc:57] Failed to create CAN client with parameter: brand: ESD_CAN
type: PCI_CARD
channel_id: CHANNEL_ID_ZERO
E0810 12:01:54.192387 10747 apollo_app.cc:59] canbus Init failed: CANBUS_ERROR: Failed to create can client.

I dont know where this error is coming from, or how to solve it.
Can someone please help me with that?
Thanks

Do not try launch Canbus modules in simulation environment, especially when you do not have a physical canard installed in your computer..

Can you resolve this problem? I encounter the same problem....helping


MarkdownToHtml pipe shouldn't add additional HTML

Currently, when using the pipe the output HTML markup is wrapped in a
 HTML paragraph.
Actual Output

        foo bar

Imho the expected behaviour is not to add any additional HTML.
Expected Output

    foo bar

In my case it made the layout change since I had some span text before which is now in a paragraph and became a block element.
Input

Hi @takahser. Thanks for your report.
Unfortunetly the p-tag comes from marked and thus cannot be removed.
As a workaround you could set a class on your span to inline inner paragraphs.
.inline p {
  display: inline;
}

@vknabel I took a look at the documentation for marked and noticed there is a way to output inline. They provide an inline lexer for this purpose. I am including the update in your code below, perhaps you can allow an option in your pipe to allow for inline output or with a wrapping p tag.
    MarkdownToHtmlPipe.prototype.transform = function (markdown, options) {
        if (markdown == null)
            return '';
        return marked.inlineLexer(markdown, [], options);
    };

Found the information here: https://github.com/markedjs/marked/issues/395


Issue in starting the plugin application

My configuration's
Elasticsearch -2.0.0
Kibana -4.2.1
Node version - v5.0.0
npm version - v3.4.1
Started my elasticsearch and kibana
And followed the steps given in Kibana Plugin Yeoman Generator - Getting Started
Created a  new plugin directory with yo kibana-plugin
and started using npm start
root@root:~/my-new-plugin$ npm start
it shows the following error
npm ERR! Linux 3.13.0-68-generic
npm ERR! argv "/usr/local/bin/node" "/usr/bin/npm" "start"
npm ERR! node v5.0.0
npm ERR! npm  v3.4.1
npm ERR! missing script: start
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     https://github.com/npm/npm/issues
npm ERR! Please include the following file with any support request:
npm ERR!     /home/guidanz-kavi/my-new-plugin/npm-debug.log
Found that the start script in missing in package.json.
So started using the following command
root@root:~/my-new-plugin$ node index.js
But it's exiting.
Kindly advice me to get started with the plugin.

We have to start using the following command gulp dev

@kavipreetha thank you for the hint.

I followed the steps in Getting Started
ran gulp dev  ( hit ctrl-c to exit )
went to my kibana directory and entered $npm start


Style highest-rated-comment caret

Description
The highest-rated-comment feature adds a border around the highest rated comment. But it bothered me that the caret was not styled. This PR fixes that.
Before

After

Closes
Closes #2237
Test

https://github.com/isaacs/github/issues/50#issuecomment-29907848

Since it's style-related, do you mind also changing the color so this can be closed as well? https://github.com/sindresorhus/refined-github/issues/2237

@fregante commented on Sep 2, 2019, 9:14 PM GMT+2:

Since it's style-related, do you mind also changing the color so this can be closed as well? #2237

I applied the green #2cbe4e color.


Create shipping address model

Kindly review this PR.

You have changed the database design again? No problem. I will update it. Thanks.


Wait on multiple GPIO pins/Expose PinFuture

I'd like to have a task, which waits on any of x GPIO pins falling edge. I'm not super deep into async Rust, so please forgive me if I'm overlooking something fundamental here.
There is the embassy-futures function select, which does what I want, but I can't call it on wait_for_falling_edge, as this function does not return a future. Internally, it uses a PinFuture and I think if it returned that future instead, it'd be possible to select multiple GPIO events.

Ok, apparently this is possible. Don't know what I did wrong in the first place, but this already works.


playtesting doesn't support unknown modded entities

steps to reproduce:

open a map with entities whose mods are installed but do not have snowberry compatibility
verify that they do not render in snowberry
playtest the map
verify that they do not render or have behaviour ingame

i would expect that playtesting a map would behave the same as loading it, but this is not the case.

This is partially resolved by work on the lönn support branch, but still requires work for entities without supported lönn plugins.

i don't understand how not having a lönn plugin would prevent an entity from appearing when playtesting - surely the actual entity code itself would be enough?
generally i'd expect playtesting a map to simply load it in celeste, which wouldn't know about snowberry/lönn plugins.

When a map is opened in playtest mode, or saves to a file, Snowberry generates a new MapData object from which rooms and entities are loaded - anything that isn't saved by Snowberry won't exist, currently including entities that don't have their own plugin (since they aren't loaded by Snowberry yet otherwise).

that makes sense, but it would probably be good to have a fallback plugin to store these entities to avoid this

yeah that's planned, a lot of the lua support work can be reused there too

neat

hasn't been fixed yet

oh ok


Study summary charts

Render charts on sidebar.
Donut charts currently rendered like this:

Number charts are only being rendered not styled.
@ricardoduplos over to you for styles.
@olafveerman I changes the data format so that data always refers to the chart data, even for numbers:
  - name: Total additional capacity (MW)
    type: donut
    data:
      - name: Grid
        value: 1500
      - name: Mini-grid
        value: 150
      - name: Stand-alone
        value: 600
  - name: Total lengh of T&D
    type: number
    data:
      value: 60
      unit: km

I imagine the schema needs to be updated.

@danielfdsilva Validation of mixed types is a bit of an issue. Would it be possible to use data for an array (donut), and datum for an object (number). See above commit.


Update calculate_frequency.py

Docstring added for freq. calculator.

@uarif Thank you for your concern. However, we modified this file to estimate actual frequency for some reason.


Warning at ...SSViewer.php line 788: None of the following templates could be found (no theme in use): templates/StringTagField.ss

I get the following warning when trying to use the StringTagField...
Warning at \framework\view\SSViewer.php line 788: None of the following templates could be found (no theme in use): templates/StringTagField.ss

Yes, there is no StringTagField template. I've tried changing this to TagField.ss. This seems to fix that problem, although other problems pop up with StringTagField later on.
Should StringTagField be calling templates/TagField.ss instead of templates/StringTagField.ss ? Or is there meant to be a StringTagField.ss file?

@assertchris know if this is a quick fix?


added integration test to CopyDbaAgentProxy

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[X] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Added integration test to the Copy-DbaAgentProxy test
Approach

Integration test request for help
Commands to test

Screenshots

Learning

YESSSSSSSSSSSSSSSSSSSSS! Thank you, Garry!! awesome 💃

Failed :(

I cannot test locally since I only have one instance.  I am looking for the bits to install a 2016 instance.  And our security is so tight I cannot get docker to work.
If anyone can tell why this failed I can update the PR.

when i tested your code, it failed on the second batch of deletes. Maybe try naming it $server2 instead? shouldn't have to but this is what I got:
 The specified @proxy_name ('dbatoolsci_agentproxy') does not exist.
 Cannot drop the credential 'dbatoolsci_credential', because it does not exist or you do not have permission.
but my setup is slightly different. may need to login to htat server to see what's up. try to do it w/o $sql = "DROP CREDENTIAL dbatoolsci_credential"
$server.Query($sql)?
maybe it's not copying the credential?

You have to execute the sql.  Did not have $server.Query on the credential create on Instance3.

Double green....

boooooooooooom! 🎉

thank you 💃


Show Similar Works on works pages (from 368)

Problem:
LUX should offer an option to show Works related based on elements shown in wireframe (add here)
Expected Behavior/Solution:
LUX should offer 5-10 similar results on a Works, with the option of running a search to see all similar results. Expectation is that there may be millions of similar results.
Requirements:
What critieria are used for similar people? How is "relevance" determined?
Keywords from description statement, itemName, itemPrimaryName

Keywords from description statement, itemName, itemPrimaryName
Classification
Material
produced in a similar time period
-- (+/- 10 years if from after 1900)
-- (+/- 20 year if from after 1700)
-- (+/- 35 years if from 1700 or earlier)

Needed for promotion:

[ ] review similar searches results/requirements definition - Peter/Kelly
[ ] placement of similar on Works page -  Mike
[ ] ~Review potential for Visual Image image similarity (AI matching)~
[ ] Wireframe/mockup
[ ] committee discussion
[ ] feasibility/team discussion
[ ] front end req
[ ] back end req
[ ] questions

UAT/LUX Examples:

Example endpoints from LUX to use for development and testing, if applicable.

Dependencies/Blocks:

ML Research Ticket: https://git.yale.edu/lux-its/marklogic/issues/519

Related Github Issues:

https://github.com/project-lux/lux-frontend/issues/5 (objects)
https://github.com/project-lux/lux-frontend/issues/202 (people & groups)
https://github.com/project-lux/lux-marklogic/issues/17
https://github.com/project-lux/lux-marklogic/issues/18

Related links:
Wireframe:
Old wireframe that may need work: https://nj46vq.axshare.com/?id=kc0vxl&p=similar&g=1 (from original ticket convo)

Is there something we can do for this to be moved along? or is this more for the future?
One of the first req was for Kelly and Heather to build req for what constitutes as "similar" for each attribute.
Would this still be our next step?
Same questions for the related issue: #5
@prowns @miketullo95 @kkdavis14

Bring to Core Team meeting. Is there a user need for this?

Core team: this is valuable; continue to prep

12/16 - Core team has decided to pause this work in favor of other priorities(My Collections, Advanced Search, and Unit Portals). All Similar tasks have been moved to Future Work.


Creating new instances of Value

I'd like to create new instances of each type of value. Specifically, I'm using gjson to read settings from a JSON object, but I need a fucntion that produces a default value for the setting for each accessible key. I'd like to be able to do things like this
let str = Value::String("Foobar");
let num = Value::Number(10);
let ok = Value::Bool(true);
let nothing = Value::Null;

Is this possible?

{
"str":"Foobar",
"num":10,
"ok":true,
"nothing":Null
}
Obtain these values as default values


API docs, /stacks?filters=

Bug description
According to the API docs (on Swaggerhub), the parameter filters is a map[string]string, but that's not the case:
Error: Invalid query parameter: filters
Status Code 400
Details: json: cannot unmarshal string into Go struct field stackListOperationFilters.EndpointID of type int

See this line:
https://github.com/portainer/portainer/blob/b24891a6bc57bc76faf73d3566260de04dc219f4/api/http/handler/stacks/stack_list.go#L14-L17
Should be updated that filters is of type stackListOperationFilters. And that should be included on SwaggerHub.

Closing this issue as the documentation provides the correct way to pass the filters to the stackList operation.
The filters must be specified as JSON using your API client tool. Here is an example with httpie:
http GET :9000/api/stacks "Authorization: ${jwt}" filters:='{"EndpointID":1}'
HTTP/1.1 200 OK
Content-Length: 3
Content-Type: application/json
Date: Thu, 31 Oct 2019 22:01:11 GMT
X-Content-Type-Options: nosniff
X-Xss-Protection: 1; mode=block

[]

An object is pretty much a map (or a dictionary) in JSON.


Unexpected behavior when syncing pf-configuration

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
Hi,
i use a pair of systems with pf-sync and several carp IPs. When creating the firewalls i created the interfaces on both sides but in creating i did not follow the same sequence for several site2site links.
Therefore there exist two wireguard interfaces (I call them s2s1 (wg0) and s2s2 (wg1)) which are present on both sides. When i switch it from master to slave the firewall rules from s2s1 (wg0)  on fw1 are applied to s2s2 (wg1) on fw2 which is incorrect.
When analzing the beaviour further i noticed that on one firewall the gui link to the ruleset for s2s1 is https://fw1/interfaces.php?if=opt1  and on the other one it is https://fw1/interfaces.php?if=opt2.  I could fix this by deleting all the interfaces on fw2 and re-creating them in the exact order that i did on fw1 becuase i could not alter the mapping of the wireguard interfaces (wg0,wg1) towards the internal opt1/opt2 names anywhere in the gui.
To Reproduce
Steps to reproduce the behavior:

Create a pair of opnsense clusters with two wireguard interfaces
map and activate the interfaces in another order on the second fw
create a dummy rule for both wireguard interfaces
activate the seconadry fw (e.g. enter persistenc carp maintainance mode)
see that the firewall rule lands in the wrong table

Expected behavior
I would either:
expect the rules from one link to land in the correct link on the second fw when syncing (based on interface name)
or:
have an alternative to change the mapping of for example op1 from one wireguard interface to another
or:
get a clear warning when entering maintainence mode that the ruleset on one firewall will be transferred to a different interface
Describe alternatives you considered
It might just be a user error on my sight or generally understood that devices have to be created on both sides in the exact order (i was creating around a dozend so i forgot to keep track of the order)
Environment
2x :
OPNsense 21.7.4-amd64FreeBSD 12.1-RELEASE-p20-HBSDOpenSSL 1.1.1l 24 Aug 2021
Intel(R) Xeon(R) E-2224 CPU @ 3.40GHz (4 cores)

https://docs.opnsense.org/manual/how-tos/carp.html#setup-interfaces-basic-firewall-rules
Read the Warning box, you need to assign both in the correct order

Fair enough i did not read the manual thoroughly enough.

I would still be great to get a warning because the results are horrible once the firewall switches over and every interface get another table.


Various peerDependencies are missing

Have you noticed various peerDependency warnings are output on every install?
How to reproduce
npm ci
npm ls

Output (excerpt):
npm ERR! peer dep missing: gulp@>=4, required by<EMAIL_ADDRESS>npm ERR! peer dep missing: gulp@>=4, required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>|| ^4.0.0 || ^5.0.0, required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>
One of these (eslint) is easy to resolve, but one (gulp) will require an upgrade to Gulp v4.
I'd recommend running npm ls before the tests to ensure no package dependencies are broken. I'll open a pull request 😊

I'll update some out-of-date packages too.
Before
found 290 vulnerabilities (67 low, 210 moderate, 13 high) in 26039 scanned packages
  run `npm audit fix` to fix 30 of them.
  260 vulnerabilities require semver-major dependency updates.

After
found 11 vulnerabilities (3 low, 2 moderate, 6 high) in 884815 scanned packages
  6 vulnerabilities require semver-major dependency updates.
  5 vulnerabilities require manual review. See the full report for details.

Without any breaking changes.

I went ahead and upgrade every single package in https://github.com/alphagov/govuk-frontend/pull/1277, and fixed all the breaking changes:
found 5 vulnerabilities (2 low, 1 moderate, 2 high) in 890376 scanned packages
  5 vulnerabilities require manual review. See the full report for details.

There are still a few vulnerabilities in sassdoc, node-sass and gulp-sass but I'm sure these will be fixed in due course.

This can be closed now https://github.com/alphagov/govuk-frontend/pull/1277 has been merged

Thanks again for your work on this @colinrotherham 👍


Sponge Port

Do you have any plans for porting ViaVersion to the Sponge API? I'd really like to use this plugin on my Sponge Servers.

See
https://forums.spongepowered.org/t/1-9-clients-connecting-to-1-8/12210/7?u=myles
It's a lot of work to do unfortunately, hence we'd only do it if there was sufficient want to make it worthwhile.

Fu** sponge! xD

Just throwing in that this is something that would've potentially helped out a few things in the past where Spigot/Bukkit were not a reasonable option but Sponge was.

@Cecer for example?

It's not something I am at liberty to disclose, sorry. By no means would my needs alone warrant the effort for a sponge port but consider me interested in seeing it happen if enough other people are too.

:/ I see you're started working on sponge support ... , I had it working for months in a dev environment with Pore but haven't released it yet (Time to do that I guess), Anyways +1 for modularity

@Maxqia Yeah we're working towards being more multiplatform, which I wasn't expecting to be able to add sponge compatibility so early on but it seems just like an obfuscation mapping thing. Sadly pore is discontinued which is one of the reasons we wanted "native" ish support.
Otherwise this is my first ever Sponge plugin, if there's any mistakes or things that could work better on the Sponge environment i'd love your input / contribution. (Some things are obviously WIP at this point in time)
Or simply if you want to test and find bugs, there will be one of two... because they slip in but hey,

We created basic support for Sponge now, we still have to implemented some minor functionality.
If anyone of you owns/runs a Sponge server, please help us improve the Sponge support by testing and reporting bugs at #505.
please follow #505 for further updates about this topic.


[FLINK-15635][table] EnvironmentSettings supports to accept the user ClassLoader

This is a continued work of contribution #19410.

This PR solves the issue of allowing the user to provide its own classloader for UDFs and at other places where it's more appropriate than the current Thread context classloader.
The PR also contains a couple of hotfixes (mergeable separately):
Deprecate CatalogFunction#isGeneric
Remove CodeGeneratorContext#apply which makes the code unnecessarily more complicated
Fix singleton config in EnvironmentSettings, which among various issues, it's also causing in this case to select the wrong user class loader

Besides, there are many cases are failed, could you take a look?

There are too many commits. I will squash them into 2 commits.

@lsyldliu could you help to have a look at the test? It seems {{SplitAggregateITCase.testMinMaxWithRetraction}} is failed.

@flinkbot rerun

Merging...


Emit Signal method and delegate to provide hook into events for Non-Azure scenarios.

Emit Signal method and delegate to provide hook into events for Non-Azure scenarios.
If no event is attached to EventListener, making it null, invocation will be skipped.

/azp run


Ratios not respecting commands

The values for minWHRatio & maxWHRatio dont seem to do what's advertised in the instructions. I'm trying to get landscape only photos.
I've changed both the two above, and fiddled with the show height/width.
Config File
{
		module: "MMM-GooglePhotos",
		position: "fullscreen_below",
		config: {
			  albums: ["MagicMirror"], // Set your album name. like ["My wedding", "family share", "Travle to Paris"]
			  updateInterval: 1000 * 60, // minimum 10 seconds.
			  sort: "random", // "old", "random"
			  uploadAlbum: null, // Only album created by `create_uploadable_album.js`.
			  condition: {
				  fromDate: null, // Or "2018-03", RFC ... format available
				  toDate: null, // Or "2019-12-25",
				  minWidth: 1080, // Or 400
				  maxWidth: null, // Or 8000
				  minHeight: null, // Or 400
				  maxHeight: null, // Or 8000
				  minWHRatio: null,
				  maxWHRatio: 1,
				  // WHRatio = Width/Height ratio ( ==1 : Squared Photo,   < 1 : Portraited Photo, > 1 : Landscaped Photo)
			  },
			  showWidth: 1080, // These values will be used for quality of downloaded photos to show. real size to show in your MagicMirror region is recommended.
			  showHeight: 1920,
			  timeFormat: "YYYY/MM/DD HH:mm", // Or `relative` can be used.
		}
	},

CSS File
#GPHOTO_INFO {
display:none;
}

Please try with this config:
minWHRatio: 1,
maxWHRatio: null,


type 'RenderConstrainedBox' is not a subtype of type 'RenderRepaintBoundary' in type cast

Uint8List? thumbData = await DavinciCapture.click(globalKey, fileName: "Hello", openFilePreview: false, returnImageUint8List: true);

result:
I/flutter (27697): type 'RenderConstrainedBox' is not a subtype of type 'RenderRepaintBoundary' in type cast

Hey @mingV2019,
I'll test this and Fix it soon. Thanks for bring this to my notice.


Add start/stopPreview for Camera

Attempting to resolve battery drain for iOS/Android by adding functionality to start/stop preview for Camera. Might also help against slow down when Camera is running in background view.
See issue #460, #569.
The recommended approach today is to not display the view when you want the camera to be inactive. This nukes the capture session, and you have to re-display the view when you want to use camera again. This can be slow for some devices.
The idea is that instead we allow the developer to choose when to pause the current capture session with stopPreview and startPreview. Can be used in conjunction with AppState, and other logic like navigation events, to decide when to have the camera running.
I've only tested this on my own devices, and not 100% sure yet how much impact this will have this will have on battery/perf. Opening up this PR for discussion and feedback/testing from others.
Test app here: https://github.com/cbrevik/cameraPreviewTest

Thanks @cbrevik. This seems like valid addition!

Thanks @ptomasroos!
From my testing, the biggest impact on battery is for Android. Seems like iOS is pretty good at turning off the camera when not needed anyway.
I haven't seen that much of a difference on perf yet, but only been testing with a smaller app.

Thanks. I will review this next week! Sorry for being a bit fed up

@cbrevik  @ptomasroos I think this is very important feature for production use.

Seems solid. Going to fully test on our devices on Monday to ensure that the flow of stopPreview then capture works properly - this would make the picture taking "seamless".

yes, I need this feature.

When is this going to be merged? I need this feature too.

I would also like to know when this change will be merged,  I too need this feature for my app.

Great work @cbrevik
the test app https://github.com/cbrevik/cameraPreviewTest is working fine!
and this will only affect users calling these 2 new functions
let me know if somebody find any regression on this one

Thanks @sibelius! 🎉

I see this is only available in 0.13.0 and was removed from 1.0.0

Oh i see. It's now under receiveCommand in https://github.com/react-native-community/react-native-camera/blob/5be1f0e727b292ba08ce36a87c3ff53ce2bcf880/android/src/main/java/com/lwansbrough/RCTCamera/RCTCameraViewManager.java

@SirNeuman feel free to send a pr for this on RNCamera

@sibelius I'd be happy to. Problem is I've only done Android development though so I don't think I'd be able to create an IOS implementation.

it won't be so hard to implement on iOS side either, just copy from the RCTCamera


doc: Update deadline scheduler doc

If CONFIG_SCHED_DEADLINE is enable, all thread is deadline task and zephyr dose not mix normal tasks and deadlie tasks currently.

@peter-mitsis Can you take a look?
I find deadline scheduler is incompatible with CONFIG_SCHED_SCALAE.
You can check by modifying here.

That's actually not correct.  The effect of deadline scheduling is to compare the deadlines if the priorities are equal.  If two threads never had a deadline set they'll compare as equal, and fall back to the next level of comparison (which in this case is "order in which they were added to the queue").   Basically two threads that never use the API will work identically to the case where SCHED_DEADLINE=n.
The edge case that we might want to fix (in code, not docs) is the situation where a thread "had" a deadline, but you don't want it to have one anymore (maybe because you changed its priority to a "non-deadline" level, etc...).  We have no way in the current API to "clear" a deadline value, it just keeps the last one it had forever, which will result in essentially arbitrary sorting vs. other threads at the same priority.


Add "add seconds to the elapsed timestamp"

It should be look like this

I set my value to 9000 seconds (= 2.5 hours = 02:30:00). Default is 0

Thanks for your contribution, may I know what is the purpose of this feature? Why would you want it to start at a certain time?

Thanks for your contribution, may I know what is the purpose of this feature? Why would you want it to start at a certain time?

Because i lost timestamp (it reset to 0) after i add a folder to my workspace... So now i made it :v

I found an issue, after i changed file or line, it subtracted timestamp, so i fixed with e5008ea

I am unsure if we should merge this because it is very specific


RFC: help not understanding

Problem:
Give a 1 sentence description of a problem with the current OSSU Curriculum. Successful critiques of the curriculum will point out ways that OSSU is failing to uphold our curricular guidelines. Examples are:

OSSU lists course X as required when the course's topics are elective in our curricular guidelines.
OSSU does not having a course to cover required topic X from our curricular guidelines.
OSSU lists courses X, Y and Z that cover the same topics when fewer courses could suffice.
OSSU recommends course X to teach a topic, but there exists a higher quality course that covers the same material.

Duration:
This should most often be 1 month from the date of posting.
Background:
Give an in depth description of the problem. Describe a solution to the problem. Describe the advantages and disadvantages of this solution. This section should be a few paragraphs.
Proposal:
Give a bullet point list of changes that are being proposed. These can link to a Pull Request.
Alternatives:
Give a bullet point list of alternative ways to address the problem.

Hi @XDVD271BT
If you are having trouble understanding the curriculum, I encourage you to join the Discord and ask questions there: https://discord.gg/wuytwK5s9h


U16: Create titlescreen art

I added the Saboteur Titlescreen into the titlescreen.
Two things:

I didn't rebase the branch to the refactored code as it wasn't reviewed yet. I think only the titlescreen will have issues when merging onto the refactored code but I don't think that will be difficult to resolve... I hope this is okay (if not i can still add it onto the refactored code)
As the art hasn't the same size as the screen I opted for a black background, because I don't wan't to stretch the image

@Croxsy Ah and btw very good work...
...but please look out for the branchname, it shouldn't contain the userstory. 👀

@Croxsy Ah and btw very good work...
...but please look out for the branchname, it shouldn't contain the userstory. 👀

Oh my bad, didn't think about that

Oh my bad, didn't think about that. Should I do a new PR with all the changes and the correct branchname?

No no, its okey for this one. Next time is fine.

Btw its a good practice to write the commit message in the present not past.

Btw its a good practice to write the commit message in the present not past.

Good to know, thanks! :)


China's public holidays for 2024

ref: https://www.gov.cn/zhengce/content/202310/content_6911527.htm
refs #

[x] Tests with a significant number of years to be tested for your calendar.
[x] Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.

@brunobord
close #710

why not pull yet？

The 2024 Chinese New Year's Eve issue needs to be fixed.

Hi @vimt , I just fix this and create a PR to your repo.
https://github.com/vimt/workalendar/pull/1

why not pull yet？why not pull yet？why not pull yet？why not pull yet？why not pull yet？why not pull yet？why not pull yet？

This change has been merged into the 7.8.0 release of calendra.


Add MRTK inspector preferences

Overview
This change adds MRTK editor preferences to save the view state of certain foldouts. This way when user enters play mode or inspector refreshes, it doesn't repaint to default state.
Also fixed missing issue for input system that causes MRTK to reset when showing/hiding input foldouts which become considered as "changes"
Changes

Fixes: #4997

Verification
Enter/exit playmode
Drill down into input profile

/azp run

Are these per-project or global prefs?

@keveleigh these should just be global preferences for a local user on a particular Unity version as they are saved in the Windows registry. I saw the EditorPreferences class which wraps around EditorPrefs Unity class. But I don't care for saving a unique key for every product name. This preference isn't shared between developers or in the git repo. If a developer is switching between projects and a particular fold out is still shown, that's fine. I'd rather not create a million keys and have it just be shared across the environment. It's a short term lived use (like between play mode & edit mode). Thanks for the callout though!


[BUG] The flip effect makes long item hard to click

I like the new flip effect and reveal effect very much, but there is a small issue.
For an item that is very wide or very long, the flip effect will break its interactivity. It is hard to click buttons on it, as shown in the video.
https://github.com/user-attachments/assets/51b092db-4376-4676-937a-2ee6da984d50

I made some changes to the algorithm. Try the latest version.

It fixed! ❤❤❤


unable to make APK

Hi, im unable to build the APK.
where can I find the APK?
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.

Where:
Build file 'C:\flutter.pub-cache\hosted\pub.dartlang.org\audioplayers-0.17.1\android\build.gradle' line: 23

What went wrong:
A problem occurred evaluating root project 'audioplayers'.

Plugin with id 'kotlin-android' not found.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================

The apk can be found in the release. Flutter sometimes complains that before compiling the release it is not compiled in profile or debugging mode so you can try to compile with the flags "--debug" or "--profile".

The apk can be found in the release. Flutter sometimes complains that before compiling the release it is not compiled in profile or debugging mode so you can try to compile with the flags "--debug" or "--profile".


azurestore: Buffer upload data on disk instead of in-memory

Closes https://github.com/tus/tusd/issues/1031
Instructions for testing this out locally:

npm install -g azurite
brew install azure-cli or similar depending on OS
Start Azurite: azurite --location ./azurite/ --debug ./azurite/debug.log
Create container: az storage container create --name mycontainer --connection-string "DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://<IP_ADDRESS>:10000/devstoreaccount1;"
Start tusd: AZURE_STORAGE_ACCOUNT=devstoreaccount1 AZURE_STORAGE_KEY=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw== go run cmd/tusd/main.go -azure-endpoint http://<IP_ADDRESS>:10000/devstoreaccount1 -azure-storage mycontainer

I'm wondering if writing to disk always makes sense since some azure hosting services (like azure container apps) only allow mounting files from azure storage account so you'd be writing to a storage account before uploading to a storage account.
Looking at the s3store_part_producer it seems to solve this already since it supports a _memory option for the parts producer. There also seems to be nothing s3 specific to the producer. Wouldn't it be possible to use the parts generator here?

I'm wondering if writing to disk always makes sense since some azure hosting services might only allow mounting files from azure storage account (not sure, need to check - just got it for container apps env wrong).

It would seem odd to me that no temporary directory is provided for storing intermediate results. I would expect some temporary storage to always be available.

Looking at the s3store_part_producer it seems to solve this already since it supports a _memory option for the parts producer. There also seems to be nothing s3 specific to the producer. Wouldn't it be possible to re-use the parts generator here?

I am not sure about this. For S3, we split a PATCH request into multiple parts of a fixed size (by default 50MB), which are uploaded and then discarded as they come in. There is a limit on how many parts can be buffer concurrently (by default 20), so there is an upper limit on the memory consumption.
For the azurestore, there is not such chunking, but instead the entire PATCH request is read into a temporary storage before being uploaded. If we want to reuse the part generator from S3, the azurestore must be adjusted so that it also uploads in smaller parts or otherwise we will have the same unlimited memory usage as without this PR.
Does that make sense?

True, it is unusual to have no local storage, but there are VMs Dasv5 and Easv5 without any temp disk. But it is possible to attach "remote" storage disks so it sould be ok.
Regarding the parts generator also true. I was just wondering why the S3 store has such sophisticated logic while the azurestore is a bit dumb :P.

Regarding the parts generator also true. I was just wondering why the S3 store has such sophisticated logic while the azurestore is a bit dumb :P.

Well, the S3 API has a few restrictions (minimal size of upload parts and maximal number of total parts) that make this kind of logic necessary. I would prefer it if we didn't have to do much of this :)
Would you be interested in testing this PR? Maybe you can run it locally and see if it works well for you? I don't use Azure normally, so a second pair of eyes would help catch issues.

I did some testing running the container both locally and as Azure Container App and was unable to reproduce any high memory or out-of-memory problems. Existing upplication / test suite also worked "as normal".

Ok, thank you very much! Then let's get this released!


[FLINK-4602][State] Add constructors for o.a.f.contrib.streaming.state.EmbeddedRocksDBStateBackend to maintain interface compatibility.

What is the purpose of the change
Add constructors for o.a.f.contrib.streaming.state.EmbeddedRocksDBStateBackend to maintain interface compatibility.
Brief change log
Add EmbeddedRocksDBStateBackend(boolean enableIncrementalCheckpointing) and  EmbeddedRocksDBStateBackend(TernaryBoolean enableIncrementalCheckpointing)
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@Zakelly This resolves the incompatibility of the constructors of EmbeddedRocksDBStateBackend. Can you take a look?


SDK can't download frames from a task for video uploaded with a frame step

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce
Create a new task, lets say the video has 452 frames. When uploading set frame step = 4.
In python do:
task.download_frames(frame sequence)
numbers in sequence: 0, 4, ..., 112 - success
numbers in sequence not divisible by 4, eg 1,2,3,5 - HTTP response body: "The frame number should be in the [0, 448] range"
numbers in sequence: 116, 120, ... HTTP response body: "Incorrect requested frame number: 116"
Expected Behavior
There's two conceivable ways it should work:
frame numbers specify after the step has been applied: 0,1,...,112
frame numbers specify before the step has been applied: 0,4,..., 448
Possible Solution
No response
Context
I'm trying to download the frames & annotations of all completed jobs
Environment
CVAT 2.7.0
CVAT-SDK 2.7.0

Also getting this issue as well.

I think the issue is here:
https://github.com/opencv/cvat/blob/f52f0f3e0ea09b72bc3efdead9780ca2fb2a858c/cvat/apps/engine/views.py#L630
frame_range = range(self._start, self._stop + 1, self._db_data.get_frame_step())
        if frame not in frame_range:
            raise ValidationError(
                f'The frame number should be in the [{self._start}, {self._stop}] range'
            )

@nmanovic, can you please assign this issue to me? I was able to reproduce the problem. The issue is due to the following code:
            elif self.type == 'frame' or self.type == 'preview':
                self._check_frame_range(self.number)

                if self.type == 'preview':
                    cache = MediaCache(self.dimension)
                    buf, mime = cache.get_local_preview_with_mime(self.number, db_data)
                else:
                    buf, mime = frame_provider.get_frame(self.number, self.quality)

                return HttpResponse(buf.getvalue(), content_type=mime)

In this code, the get_frame function retrieves the frame using the new frame number which is after applying step size (0,1,2,3 .. 112 are valid). However, in the _check_frame_range function, we are checking the frame range before applying the step size (0,4,8,12 ...448 are valid):
    def _check_frame_range(self, frame: int):
        frame_range = range(self._start, self._stop + 1, self._db_data.get_frame_step())
        if frame not in frame_range:
            raise ValidationError(
                f'The frame number should be in the [{self._start}, {self._stop}] range'
            )

To resolve this issue, we can either Perform the frame range check after applying the step size, similar to how the frame is retrieved or divide the self.number with self._db_data.get_frame_step() while retrieving the frame to get the correct frame.

@umangapatel123, assigned. Please send us a PR with the fixes and tests.

@zhiltsov-max can you please guide me on how can I generate a video for testing? is there any existing method for it?

@umangapatel123, please check if any of the existing test tasks fit your needs - just run the test server with pytest --rebuild --start-services tests/python, then open the localhost:8080 in the browser, login with the credentials admin1 and this password, and investigate the available tasks. There should be several video/image tasks with frame step. If there is no such, please check if you can use a task with a set of images with frame step (probably, it also has the same problem). If no, I can suggest to use ffmpeg of opencv to generate a video from a set of frames.


Trace HystrixCommand

Adds propagation of spans across threads during HystrixCommand tracing
Adds support for traceable HystrixCommand

Fixed #51 started by @kameshsampath. The original was working fine, It just needed reset concurrency strategy between tests. It was also rebased and added some cosmetic fixes.


Bootstrap plugin preview

Hi,
I just wanted to share this with you as a peek preview:
http://dagnelies.github.io/ractive-bootstrap/
My boss was kind enough to let me share some side products of my work, so here it goes. It's not yet finished, nor polished nor fully functional but it should give you an idea of what I'm working on and I hope you'll find it useful.
Granted, it has nothing to do with data-binding and is just style shortcuts ...but hey, I think it might come pretty handy for some people, given bootstrap's popularity. Once it's done, I'll make a nice plugin out of it, etc. However, you're still welcome to give early feedback or concerns.
Also, it would come in handy with #1535 , but I'll try to find a workaround for this in the meantime.
Cheers,
Arnaud

Having problems with CDN'ed resources and HTTPS.

@fskreuz I changed it to local links, is it all right now?

:+1:

Nice!

Very nice @dagnelies !

I like where this is going :+1:

I have developed Ractive decorators for Bootstrap Select and Switch (but I need to do its docs). Are you interested in these decorators in this early stage, without documentation?

Glad you like it!
@paulocoghi this looks interesting. Of course it's welcome ...I'll just have to think wether I'd put it in the main repo or another "ractive-bootstrap-extras" repo.

Here are also some components using some bootstrap https://github.com/codler/Ractive-UI written in TypeScript and using Ractive 0.5.5

@dagnelies I'm going to mark this closed as you've since had it added to the plugins section of the docs. Cool plugin all the same, though! :+1:

@Madgvox  Thanks

@dagnelies The col component is too strict. You can't specify different columns for different sizes. I think it should be something like this:
<col xs=6" md="5"></col>

@Skyrpex ok, I'll take your point in account and make a new col. Feel free to post directly in the repository too.


Additional stress tests for Azurite

Which service(blob, file, queue, table) does this issue concern?
Blob, queue, table
Which version of the Azurite was used?
V3.17.1
Where do you get Azurite? (npm, DockerHub, NuGet, Visual Studio Code Extension)
npm -> executable -> nuget package
What's the Node.js version?
n/a
What problem was encountered?
We found that on stress testing with multi-threaded block and leasing enabled uploads cause in-consistent results with Azurite.
Steps to reproduce the issue?
blob-v11.zip
Have you found a mitigation/solution?
Additional stress test surrounding complex multi-threading is required. We also need tests to be written on all supported client libraries (.Net v11 & v12)

@vigneashs
Thanks for the feedback!
We will first investigate this MD5 issue, and evaluate the stress test request per our bandwidth.
Besides that, Azurite welcome contribution!
It would be great if you can raise PR to add some stress test cases.


Volume control keys don't work on Logitech K760 and 10.12.1

After installing Karabiner Elements volume keys (F10, F11, F12) don't work.
However FN+Fn works (inverted)

Same problem also reported in #458 and for other external keyboard in #525


add tips when user got 400 error.

fix #365

Closing this issue PR and issue #365 as this is no longer an issue with this sample.


Error: node not deployed. marantz avr in node-red.

I have configured a flow for marantz. But, whenever I inject the node, it shows the Error: node not deployed.

Hi @manishsuperhome
That is not a core Node-RED node, so not something we provide support for on this issue list.
What module did you install to get that node?

Closing as this isn't a core Node-RED node. We can point you in the right direction if you provide more information on what nodes you are using.


pixi7.0

can support pixi7.0？

I'll start working on it soon. V7 is a big change so it may take some time.

can support pixi7.0？

I'll start working on it soon. V7 is a big change so it may take some time.

How is the current development progress going regarding the compatibility with PIXI.JS v7.x?
请问现在关于适配PIXI.JS v7.x的开发情况如何了?

I'll start working on it soon. V7 is a big change so it may take some time.

Looking forward to v7

I guess its already using v7

I'll start working on it soon. V7 is a big change so it may take some time.

现在怎么样了


quit() throws when prefix option is set on client

When the redis client has the prefix option set, any call to client.quit() will throw an error:
> var redis = require('redis');
undefined
> var client = redis.createClient({prefix: 'foo:'});
undefined
> client.quit();
Error: Unknown command quit
    at Object.exports.getKeyIndexes (/Users/mwiller/test/node_modules/redis/node_modules/redis-commands/index.js:62:11)
    at RedisClient.send_command (/Users/mwiller/test/node_modules/redis/index.js:814:32)
    at RedisClient.(anonymous function).RedisClient.(anonymous function) (/Users/mwiller/test/node_modules/redis/index.js:971:21)
    at repl:1:8
    at REPLServer.defaultEval (repl.js:248:27)
    at bound (domain.js:280:14)
    at REPLServer.runBound [as eval] (domain.js:293:12)
    at REPLServer.<anonymous> (repl.js:412:12)
    at emitOne (events.js:82:20)
    at REPLServer.emit (events.js:169:7)

It looks like this is because the QUIT command is not technically listed as a Redis command, either in the redis-commands module or in the output of the redis COMMAND INFO command (as of redis 3.0.3):
$ redis-cli
<IP_ADDRESS>:6379> command info quit
1) (nil)

Fixed and released on npm. Please run npm update.


Is Optional Bundle Identifier?

In fetch_app_status.rb  using environment for bundle_identifier
bundle_id = ENV["BUNDLE_IDENTIFIER"]

but , in README.md  has no content.

Oh! Great catch, that's my bad - merely poor documentation. I'll fix the README, to also include the BUNDLE_IDENTIFIER, just like the Heroku config file already enforces 💪
Thanks for catching this, @techinpark !

Just to clarify: the BUNDLE_IDENTIFIER is a required environment variable. Please set it 🙏
The PR is up and will be merged once it passes CI 🎉 thanks again for reporting this issue!


OSD-19605 Use managed-scripts for validate-pull-secret to avoid elevation

What this PR does:

It uses the managed-script to get the pull-secret's email.

If the managed-script fails to run due to the pull-secret couldn't pull the managed-script image, it will send a SL.

It moves the current existing logic to --elevate, which requires backplane elevation.

Why this PR:

The current workflow gets the pull-secret to local, but we only need to know the email in the pull-secret for validation. We can use a managed-script to only get the email from the cluster, so we don't need to get any sensitive data locally.

Note:

I didn't add related test cases since it is calling external commands which is not easy to mock. Appreciate if any reviewer can share some ideas.
Calling the ocm backplane managedjob directly because it doesn't have easy library to call, yet.

Tests:
Case 1:  Normal case.
$ osdctl cluster validate-pull-secret xxxxxxxxxxxxx
Getting email from OCM
email from OCM<EMAIL_ADDRESS>Creating a managedjob to get pull-secret email in the cluster
managedjob id: openshift-job-8h6kd
Waiting for managedjob to finish
email from managedjob<EMAIL_ADDRESS>Email addresses match.

Case 2: The email address doesn’t match.
$ osdctl cluster validate-pull-secret xxxxxxxxxxxxxxx
Getting email from OCM
email from OCM<EMAIL_ADDRESS>Creating a managedjob to get pull-secret email in the cluster
managedjob id: openshift-job-vzm92
Waiting for managedjob to finish
email from managedjob<EMAIL_ADDRESS>Pull secret email doesn't match OCM user email. Sending service log.
INFO[0049] The following clusters match the given parameters:
Name                ID                                 State               Version             Cloud Provider      Region
siwu-test           xxxxxxxxxxxxxxx   ready               4.14.4              aws                 us-west-2

INFO[0049] The following template will be sent:
{
xxxxxxxxxx
}
Continue? (y/N): y

Case 3:  The pull secret fail authentication causing the managed-script fail running.
$ osdctl cluster validate-pull-secret xxxxxxxxxxxx
Getting email from OCM
email from OCM<EMAIL_ADDRESS>Creating a managedjob to get pull-secret email in the cluster
managedjob id: openshift-job-2vc2v
Waiting for managedjob to finish
managedjob failed due to failed pulling image, run the below command for more detail:
oc describe pod openshift-job-2vc2v -n openshift-backplane-managed-scripts
Sending service log
xxxxxxxxxxxx

Case 4: The managed-script fails to run for other reasons.
$ osdctl cluster validate-pull-secret xxxxxxxxxxxx
Getting email from OCM
email from OCM<EMAIL_ADDRESS>Creating a managedjob to get pull-secret email in the cluster
managedjob id: openshift-job-th7ss
Waiting for managedjob to finish
error: managedjob timeout, try --elevate to validate pull-secret without a managed job

Case 5: Use --elevate to get pull secret.
$ osdctl cluster validate-pull-secret 2820u3k6rj9gv9kes1hk04mnacntgc1h --elevate
Getting email from OCM
email from OCM<EMAIL_ADDRESS>Getting the pull-secret in the cluster with elevated permissions
email from cluster<EMAIL_ADDRESS>Email addresses match.

Great work @feichashao - I think the main logic does makes much sense to me.
Regarding the test, yeah, it can be tricky when we use the external commands that don't have a direct lib interface. Personally, I think at this stage, as long as we tested with the external commands against actual clusters, should be good but in the future, may be request/add go SDK for testable interfaces.
Open to get ideas from other reviewers.

I would like to note the discussion of this PR: #479
There are clear downsides to using managed scripts over direct elevated commands, we should consider them and evaluate if we want to move towards managed scripts in the first place.

I think it is true that we shouldn't force to use a managed script. This PR keeps the --elevate flag to execute the current routine, while moving the default routine to use the managed-script.
I did a test to measure the time consumed:
In the --elevate mode (the current routine), it takes 6s to complete.
In the default mode (the managed-script route), it takes 28s to complete.
With the 22s extra cost, we gain the benefits:

No need to touch the pull-secret in our local environment.
One less compliance workflow.

If it brings trouble to oncall, we can flip the default behavior to the elevation one.
WDYT?

@xiaoyu74 @NautiluX  thank you for reviewing and provide suggestions!  I put a new commit to address comments, could you help another look with you have time?

the change lgtm

Re-based.  @bmeng


Retry the Google POST/GET/DELETE requests

If the request fails, do a retry

Don't want to use AOP


warlock.empower does not work

Warlock.empower, and warlock.empower.missing is not working. warlock.minions is counting correctly, but the tracking of which minions have the buff (or not) is not working.

SUP WITH WARLOCK.EMPOWER. I HAS NEEDS.


HttpRequest "normalizing" headers assumes all callee's are case insensitive

Current Behavior
When setting headers for an HttpRequest, it appears to "normalize" all of them to lowercase, which means requests to endpoints that are actually case sensitive have no avenue to actually function.
Expected Behavior
Headers should be piped through as specified for all headers rather than transforming them.
Steps To Reproduce
Send a request to any device / endpoint that makes a case-sensitive header evaluation (In my case, it was the "Host" header always being translated to "host", and the callee not liking that.
Example flow
var newMsg = {};
newMsg.url = "endpointThatCaresAboutHostHeaderCase";
newMsg.headers = {};
newMsg.headers["Host"] = "<IP_ADDRESS>";
return newMsg;

Environment

Node-RED version: 2.0.2
Node.js version: Docker
npm version: Docker
Platform/OS: Docker
Browser: Chrome

(One of) Location where I believe the "header normalization" / "toLowerCase" is occuring: https://github.com/node-red/node-red/blob/master/packages/node_modules/%40node-red/nodes/core/network/21-httprequest.js#L200

The HTTP 1.1 spec says that header names should not be case sensitive
https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2

Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive.

(Not saying we won't look at this, but your end point is not to spec if it's case sensitive)

I know the old request module went to great lengths to be consistent with the headers it set. Looks like the new module we use doesn't take the same care.
Spec aside, this is a regression in behaviour from 1.x so we need to do something.

Unfortunately, not my endpoint so I can only control one side of the equation here. Don't disagree with you, and I'll try reporting this to the device manufacturer, but its one of those standalone basic devices that I'm guessing me complaining about them being out of HTTP spec is gonna get summarily ignored 😄

Looking at the code that line shouldn't be changing the case unless it's content-type or content-length (unless I'm miss reading the if statement under it)
But I have wiresharked the actual request and it looks like got (or one of the agents) is normalising all the headers to lowercase

This looks promising - https://github.com/sindresorhus/got/pull/1336

@hardillb sadly not - its closed without being merged. If you review all the linked issues, they standard response is "headers should be case insensitive - fix your server"
In one, they say "maybe you should be using the request module if thats what you want"... oh the irony.
It looks like this is what we need - https://github.com/sindresorhus/got/pull/1103#issuecomment-620364057 - using their hooks api to 'fix' the headers before it sends the request.

Whilst writing some unit tests for a different HTTP Request issue, I spotted we have a unit test that checks headers are always sent lower-case. That test is from 1.x, so I just checked our 1.x behaviour and it is the same - headers are lower-cased.
I was under the impression this was a regression in behaviour, but maybe not.
@i8beef can you confirm whether this is something that was working in 1.x for you, or are you only just trying to do this with 2.x?

Yes this worked in 1.0, nothing else has changed except the upgrade to 2.x...
The only symptom I have really is that, and the error:
HTTPError: Response code 400 (Bad Request: No Host Header)
    at Request.<anonymous> (/usr/src/node-red/node_modules/got/dist/source/as-promise/index.js:117:42)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

I fired up a .NET project to make the same request... but .NET has a series of headers (Host among them) that are "special" and always sent the same way... so I can't actually reproduce there because Microsoft won't LET me send a "host" header, it will ALWAYS be "Host". That's rather interesting though I have no idea if its due to any sort of standard for those since that particular heads is part of the main HTTP 1.1 spec...
Thats my best educated GUESS as to what changed that is breaking, but this is the core SYMPTOM I could be incorrectly disagnosing...

I played with a curl a bit with this device... I can't actually figure out how to change the 'Host' header (how curl sends it) since its automatic there... but I CAN change the "Authorization" header to be lowercase and said device fails to recognize the authentication anymore.
It also appears that if I don't inject a new headers object, but instead apply the Authorization in the node itself, two things change: (1) It doesn't complain about the Host header anymore (assuming that deep in the bowls of this got library, its actually auto generating the Host header TitleCased if left to its own devices?), but (2) the basic auth of course doesn't work because THAT is being changed to "authorization" instead of "Authorization".
I.e., I think I confirmed the device in question is in fact case sensitive here (incorrectly)... but also that other large frameworks, curl, etc. automatically generate TitleCased headers for these common use headers... interesting data point if nothing else about the "just lowercase" it community... I would argue they are PRACTICALLY wrong even if TECHNICALLY right 😄
Note I can probably run this through my proxy server to fix this if you find you don't want to change this (or can't), no hard feelings.

Whilst writing some unit tests for a different HTTP Request issue, I spotted we have a unit test that checks headers are always sent lower-case. That test is from 1.x, so I just checked our 1.x behaviour and it is the same - headers are lower-cased.

Looking again, I was wrong on this analysis. The way the tests worked, they were seeing lower-cased headers because thats what the Express server used in the test does to normalise the received headers. When I looked at the rawHeaders object, I could see the request was sending headers with unmodified case.
I've pushed a fix that will restore the case of any headers the user has set - and fixed the test case to properly verify that works.

It does seem to respect the header capitalization now, thank you. I am also following up with the device manufacturer (AVTech Room Alert) to see if I can get their engineers to bring themselves into spec.


[skip ci] tests: test podman against atomic os instead rhel8

the rhel8 image used is an outdated beta version, it is not worth it to
maintain this image upstream, since it's possible to test podman with a
newer version of centos/atomic-host image.
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>

depends on ceph/ceph-build#1303

jenkins test dev-centos-container-lvm_osds

jenkins test dev-centos-container-podman

jenkins test dev-centos-container-lvm_osds

jenkins test dev-centos-container-podman

@guits I found the issue with podman + reboot on atomic host.
Because we don't execute the ceph-container-common prerequisites on atomic host [1] then we don't create the tmpfile rules for the ceph socket directory (/run/ceph) [2] so this directory isn't persistant on reboot (tmpfs).
That's why the container aren't up & running after a reboot.
May 29 20:52:23 atomic.novalocal systemd[1]: Started Ceph Monitor.
May 29 20:52:23 atomic.novalocal podman[2968]: error checking path "/var/run/ceph": stat /var/run/ceph: no such file or directory
May 29 20:52:23 atomic.novalocal systemd[1]<EMAIL_ADDRESS>main process exited, code=exited, status=125/n/a

Note that /var/run/ is a symlink to /run.
I've tried to add the rule manually on an atomic host and it solves the issue.
I'm pretty sure we can safely remove the not is_atomic ansible condition in [1].
[1] https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-container-common/tasks/main.yml#L2-L4
[2] https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-container-common/tasks/prerequisites.yml#L10-L18

@guits I've updated the PR

@guits only the OSD nodes don't come back after the reboot

@guits I tried the updated flags 'dz' in tmpfiles but it doesn't seem to work.
The /run/ceph directory isn't created.


Roll python deps & add pigweed's

This will help avoid issues like the one fixed by #4165, where a pip
package used by pigweed updated underneath us and broke.
These are gathered from install_requires in setup.py of packages we
install. Currently we don't have a way to fail the build if there's an
unpinned dep; they'll have to be found manually and added to
requirements.in.

@saurabhst @hawk248 @BroderickCarlin @chrisdecenzo @jelderton


One more step for iOS instruction

In all (most?) cases, "Add to Home Screen" button is hidden under the bottom edge of the screen and Share Panel must be scrolled down to reveal that button.
Suggesting to add "Scroll Down" step between "Press Share in Navigation bar" and "Press Add to Home Screen".

Open in Safari browser (maybe hide this item if user is already in Safari? 🤔)
Press Share in Navigation bar
Scroll Down 👈
Press Add to Home Screen

You can't hide it because of existence SFSafariViewController

AFAIK you can't add to home screen from this state. And detect this state not sure is possible...

I mean, after clicking on the Share button in the nav bar, user can't see "Add to Home Screen" button and needs to scroll down to find it.

Yeah I got this point. But do you think it's a real problem? Have any real life experience or just a clue?

Noticed that when explained to my friends how to install my PWA.
2 of 3 told me that they "don't see Add to Home Screen button" 🫠
I think the problem is real for not-so-technically savvy users.

@khmyznikov also check this project out:
https://github.com/philfung/add-to-homescreen

@s0xDk nice project. Interesting why he is not reached me to collaborate.

@khmyznikov I like how it detects different kinds of Safari WebViews and points an arrow to right places.

One more thing:
If a user is already within Safari, step “1) Open in Safari browser” may be misleading.
So the instruction could be updated to this:

Press Share in Navigation bar
Scroll Down the Share menu
Press Add to Home Screen

Maybe:

Press Share in Navigation bar
Scroll down to Add to Home Screen

Maybe:

Press Share in Navigation bar
Scroll down to Add to Home Screen

Yeah, it's more concise and keeps the point.

Here's how I do it:

Here's how I do it:

The language is directly borrowed from Apple - https://support.apple.com/en-sg/guide/iphone/iph42ab2f3a7/ios

In all (most?) cases, "Add to Home Screen" button is hidden under the bottom edge of the screen and Share Panel must be scrolled down to reveal that button.
Suggesting to add "Scroll Down" step between "Press Share in Navigation bar" and "Press Add to Home Screen".

Open in Safari browser (maybe hide this item if user is already in Safari? 🤔)
Press Share in Navigation bar
Scroll Down 👈
Press Add to Home Screen

In all (most?) cases, "Add to Home Screen" button is hidden under the bottom edge of the screen and Share Panel must be scrolled down to reveal that button.
Suggesting to add "Scroll Down" step between "Press Share in Navigation bar" and "Press Add to Home Screen".

Open in Safari browser (maybe hide this item if user is already in Safari? 🤔)
Press Share in Navigation bar
Scroll Down 👈
Press Add to Home Screen

In all (most?) cases, "Add to Home Screen" button is hidden under the bottom edge of the screen and Share Panel must be scrolled down to reveal that button.
Suggesting to add "Scroll Down" step between "Press Share in Navigation bar" and "Press Add to Home Screen".

Open in Safari browser (maybe hide this item if user is already in Safari? 🤔)
Press Share in Navigation bar
Scroll Down 👈
Press Add to Home Screen

As iOS Chrome and Edge now supports 'Add to Home Screen' there is no need for '1. Open in Safari browser'.

Added in 0.5.0
Happy new year! 🎄


#4923 Fix String convert issue and overwrite putAll method in Typed…

…Properties.java
Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
I'm running Flink with Hudi in Java 11 environment(Even through I know Hudi might only support Java8/9/10), But we cannot change our JDK version. Based on this situation, We meet a NPE problem during HoodieWriteConfig.getIndexType(), but I test that it works in my local Java 8 environment. It seems that we implemented a TypedProperties class inherit  from java.util.Properties class, and overwrite stringPropertyNames method & put method from this PR.
There are some difference of Properties.putAll(Map<?,?> t) between Java 8 and Java 11.
Java 8: TypedProperties  will use HashTable's putAll method, which will call TypedProperties.put method, and the latter will add the incoming keys in TypedProperties.keys field.
public synchronized void putAll(Map<? extends K, ? extends V> t) {
        for (Map.Entry<? extends K, ? extends V> e : t.entrySet())
            put(e.getKey(), e.getValue());
    }

Java 11: Properties overwrite putAll method, and delegate the  incoming map to ConcurrentHashMap. It won't call TypedProperties.put method anymore, which lead the TypedProperties.keys fields miss some keys, and then it cause that we miss the hoodie.index.type configuration.
@Override
    public synchronized void putAll(Map<?, ?> t) {
        map.putAll(t);
    }

So we also need to overwrite putAll method to better  suitable high Java version runtime.
The exception trace with Java 11 runtime.
Caused by: java.lang.NullPointerException: Name is null
	at java.base/java.lang.Enum.valueOf(Enum.java:238)
	at org.apache.hudi.index.HoodieIndex$IndexType.valueOf(HoodieIndex.java:143)
	at org.apache.hudi.config.HoodieWriteConfig.getIndexType(HoodieWriteConfig.java:1347)
	at org.apache.hudi.index.FlinkHoodieIndexFactory.createIndex(FlinkHoodieIndexFactory.java:47)
	at org.apache.hudi.client.HoodieFlinkWriteClient.createIndex(HoodieFlinkWriteClient.java:105)
	at org.apache.hudi.client.BaseHoodieWriteClient.<init>(BaseHoodieWriteClient.java:145)
	at org.apache.hudi.client.BaseHoodieWriteClient.<init>(BaseHoodieWriteClient.java:131)
	at org.apache.hudi.client.HoodieFlinkWriteClient.<init>(HoodieFlinkWriteClient.java:96)
	at org.apache.hudi.util.StreamerUtil.createWriteClient(StreamerUtil.java:402)
	at org.apache.hudi.sink.StreamWriteOperatorCoordinator.start(StreamWriteOperatorCoordinator.java:166)
	at org.apache.flink.runtime.operators.coordination.OperatorCoordinatorHolder.start(OperatorCoordinatorHolder.java:194)
	at org.apache.flink.runtime.scheduler.DefaultOperatorCoordinatorHandler.startAllOperatorCoordinators(DefaultOperatorCoordinatorHandler.java:85)

Brief change log

Overwrite putAll method in TypedPropertis
Add class type checking before convert to String hardly

Verify this pull request
This change added tests and can be verified as follows:

Add unit test case to test putAll cases in TestTypedProperties.java

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@stayrascal : this does not looks like minor. can you please file a jira and link it.

CC @codope.

Thanks @nsivabalan review this PR. I failed to create a Jira card, not sure where I can create the card or I didn't have the permission. Instead, I create an issue here.


Is there a working better-bibtex extension for Zotero <IP_ADDRESS>

I am asking the question since I cannot install the bbt extension in my Zotero <IP_ADDRESS>. The dialog reads that the plugin is not compatible with my version of Zotero Standalone.

I suppose https://github.com/retorquere/zotero-better-bibtex/releases/tag/1.6.100 probably still works, but it's unmaintained, and I won't be able to help much with any problems you might run in to. I don't know what new functionality has been added to BBT since, nor what bugs have been fixed since, but I don't accept feature requests or bug reports for Zotero 4-compatible BBT.

I managed it to work. I needed the proper zotfile (for those who need it) in version 4.2.8, which is available here https://legacycollector.org/firefox-addons/284723/zotfile-4.2.8.xpi
I have solved my problem. Closing the issue!

That's a different extension though, not BBT.

Surely, but they conflict.


[C++][Parquet] The patch for PARQUET-1508 leads to infinite loop and infinite memory allocation when reading very sparse ByteArray columns

In this loop
https://github.com/apache/arrow/commit/3d435e4f8d5fb7a54a4a9d285e1a42d60186d8dc#diff-47fe879cb9baad6c633c55f0a34a09c3R739
The branch of if dealing with null values does not increment variable 'i'. Therefore on chunks containing only NULLs once a thread enters the loop, it stays in that loop forever. I'm not entirely sure whether 'num_values' variable was meant to be the number of non-NULL values, yet the total number of values is passed here https://github.com/apache/arrow/blob/3d435e4f8d5fb7a54a4a9d285e1a42d60186d8dc/cpp/src/parquet/arrow/record_reader.cc#L528

On my local machine adding ++i to the NULL-handling branch seems to fix the problem. Unfortunately, I'm not familiar with the codebase enough to be certain it's a proper fix.
Reporter: Valery Meleshkin
Assignee: Hatem Helal](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=hatem) / @hatemhelal
Original Issue Attachments:

example.parquet

Note: This issue was originally created as PARQUET-1537. Please see the migration documentation for further details.

Wes McKinney / @wesm:
I moved this issue to PARQUET

Hatem Helal / @hatemhelal:
I have a fix for this in this PR:

https://github.com/apache/arrow/pull/3721

Could you help with a review?

Hatem Helal / @hatemhelal:
Issue resolved by pull request 3721
https://github.com/apache/arrow/pull/3721

Valery Meleshkin:
I have attached a file generated by the script from my previous comment. It reproduces the issue in my setup.

Wes McKinney / @wesm:
Can you post a file that reproduces the issue? I can take a look

Valery Meleshkin:
I can't attach the original file, but I was able to reproduce it by writing something like the following with pyarrow:

import pyarrow.parquet as pq
import numpy as np
import pandas as pd
import pyarrow as pa

df3 = pd.DataFrame({'id': [x for x in range(1000000)], 'nullstr': [''] + [None for _ in range(1000000 - 1)] })
table3 = pa.Table.from_pandas(df3)

with pq.ParquetWriter('example.parquet', table3.schema, use_dictionary=False) as writer:
    writer.write_table(table3)

Hatem Helal / @hatemhelal:
On closer inspection, that was hasty to claim that I had a fix.  I'm working on a proper fix + some tests.


[Android] RuntimeException com.google.android.gms.cast.framework.CastContext.

Coming from a Google Pixel XL.
java.lang.RuntimeException:
  at android.app.ActivityThread.handleCreateService (ActivityThread.java:3414)
  at android.app.ActivityThread.-wrap4 (Unknown Source)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1683)
  at android.os.Handler.dispatchMessage (Handler.java:105)
  at android.os.Looper.loop (Looper.java:164)
  at android.app.ActivityThread.main (ActivityThread.java:6541)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.Zygote$MethodAndArgsCaller.run (Zygote.java:240)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:767)
Caused by: java.lang.RuntimeException:
  at com.google.android.gms.internal.zzni.zzbg (Unknown Source:35)
  at com.google.android.gms.internal.zzni.zza (Unknown Source)
  at com.google.android.gms.cast.framework.CastContext.<init> (Unknown Source:123)
  at com.google.android.gms.cast.framework.CastContext.getSharedInstance (Unknown Source:36)
  at guichaguri.trackplayer.cast.GoogleCast.<init> (GoogleCast.java:32)
  at guichaguri.trackplayer.logic.MediaManager.<init> (MediaManager.java:45)
  at guichaguri.trackplayer.logic.services.PlayerService.onCreate (PlayerService.java:76)
  at android.app.ActivityThread.handleCreateService (ActivityThread.java:3404)

Seems to be a problem with the Cast SDK itself. Is Google Play Services updated?

On the user's phone, you mean?

I'm worried this problem is caused by the outdated Cast SDK, which I can't update unless React Native updates to the latest support library
The problem in #47 might have the same cause: outdated support library.

Ahhh, interesting. Okay so we might have to wait and see...

I've added a fail-safe, so if a crash is caught, the cast support will be disabled.

Haven't seen this in a while so closing it! Fail-safe probably worked.


enhance: additional browser improvements

Notable new things:

tab management (and new close tool)
screenshot tool
better handling of iframes and shadow DOMs

Moved to here: https://github.com/gptscript-ai/browser/pull/34
because I need to start pushing stuff to my main branch again in order to test more changes.


About command params

Summary
Suggesting an commands.Parameter class
What is the feature request for?
discord.ext.commands
The Problem
Currently, assigning names, descriptions, and autocomplete to command options is very ugly and messy. Take this as an example:
@commands.command(
  add_slash_command=True,
  param_descriptions={
    "a": "The first number",
    "b": "The second number",
    "mode": "The math mode",
  },
  autocomplete_params=["mode"],
)
async def addition(
  self, ctx: commands.Context, a: int, b: int, mode: str = "normal"
):
  """
  An example addition command.
  """

  if mode == "scuffed":
    await ctx.send(f"{a} + {b} = {a // -b}")
  await ctx.send(f"{a} + {b} = {a + b}")

The Ideal Solution
I propose a params attribute to discord.Ext.commands.Command. Here would be the syntax for it:
@commands.command(
add_slash_command=True,
params=(
  commands.Param("a", description="The first number"),
  commands.Param("b", description="The second number"),
  commands.Param("mode", description="The math mode", autocomplete=True),
)
)
async def addition(
self, ctx: commands.Context, a: int, b: int, mode: str = "normal"
):
"""
An example addition command.
"""
if mode == "scuffed":
  await ctx.send(f"{a} + {b} = {a // -b}")
await ctx.send(f"{a} + {b} = {a + b}")

This discord.Ext.commands.Param would roughly function as:
(class) Param(self, name: str, *, description: Optional[str] = None, autocomplete: Optional[bool] = False)

The Current Solution
No response
Additional Context
No response

This kind of system brings up an interesting disparity between the parameters of the slash command and the parameters of the message command. The message command system uses type hinting to describe how inputs are parsed, but with slash commands the inputs are pre-parsed for you.
With something like what you've described here it would make sense to also include the TYPE of the parameter, but that ALSO is incompatible with the previous message-based system of argument parsing. I'm not super sure of how to go about doing this.
I do agree that the current system is kinda cumbersome, but I want to think more on this before committing to a new design choice.


Verify All rules

First of all, Thank you for such kind of Pod. It is very helpful.
Hi, I have form of different textfield and i've set all validation. Individually these are working fine. I need to check while submit while are field are valid or not. I read documentation but i didn't understand how can i do that?
You know some kind of check i.e. rule.allValid -> true or false (Something like that or anything else that can help to achieve the solution of this problem.

This is explained in the docs. Closing this because you're probably past this now :)


1.0.29 not properly ignoring files

Setting a file priority to DoNotDownload does not appear to be working in 1.0.29. Unless I am doing it incorrectly. I've tried setting this value before a torrent is started and after but it still downloads the files in question.

How are you determining this is not working correctly? Are you measuring how much data is downloaded, or can you see pieces associated with files marked as 'do not download' actually being downloaded, or are you simply looking at the files created in the output directory?
If you're looking at the files created by the engine, it's worth noting that the engine will create the file on disk if the first, or last, piece of the file needs to be downloaded due to it containing data for other files in the torrent.
On windows a sparse file is created so this is extremely efficient. On unix a full file is created so the full disk space will be consumed, but the data in the middle of the file won't be downloaded.
I'll double check this later to be sure there's no regression which was missed by the tests.

After the torrent was in the seeding state I was checking the file structure on the drive and found that the I previously ignored were downloaded.

If I understand you correctly - this is normal and expected behaviour for files which are not downloaded.
Files marked as DoNotDownload will exist on disk. A 1GB file may appear to be 1GB, but at most 2 x PieceLength bytes will actually be allocated - this will accommodate any data which is required to validate files which were downloaded.
When the torrent is marked as Seeding what is the value of Progress and PartialProgress.foe the torrent manager? Also, what is the value of both of these properties if you call HashCheckAsync?

It seems like you're correct; the progress & partial progress are both giving the correct percentages. My mistake for misinterpreting the result.

Great! Thanks for checking that for me. If you any other issues, or potential issues, please do open a ticket and I'll take a look!
I ran a quick test after work today anyway and things looked OK for me too.


Testing tensorboard image saving

Test for tensorboard_save_image function

Pull Request Test Coverage Report for Build 228764526

0 of 26 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 225971370:
0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls


cpu_utilization calculation is slow in processor.cpp

The problem is bla bla

kangkelvin@4fdfa4f
kangkelvin@60ef7f2f63caffdc50ff90c0db0d4d0c118beacc


Some outdated comments inconsistent with the code

Outline & Motivation
https://github.com/Lightning-AI/lightning/blob/e958c6f1dcf05b70985c472a37c59ffefa223a40/src/lightning/pytorch/trainer/connectors/logger_connector/result.py#L299-L307
these comments are inconsistent with the usage of _ResultCollection, Since _ResultCollection has no device argument and positional argument follows keyword argument is also not allowed.
Pitch
No response
Additional context
No response
cc @borda @justusschock @awaelchli

@0x404 Would you like to send a PR removing the typo?

Sure:)


Add tensor save / read test

This Pr adds tensor save / read test.
Not directly related to the PR though, save & read better
need error handling
Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #230. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.