System VMs on Managed Storage

This PR makes it easier to spin up system VMs on managed storage.
Managed storage is when you have a dedicated volume on a SAN for a particular virtual disk (making it easier to deliver QoS).
For example, with this PR, you'd likely have a single virtual disk for a system VM. On XenServer, that virtual disk resides by itself in a storage repository (no other virtual disks share this storage repository).
Same concept for vSphere. The virtual disk of the system VM would reside by itself in a datastore (no other virtual disks share this datastore).
It was possible in the past to spin up system VMs that used managed storage, but this PR facilitates the use case by making changes to the System Service Offering dialog (and by putting in some parameter checks in the management server).

Here is a screen capture on the changes to the System Service Offering dialog.

@blueorangutan package
@mike-tutkowski LGTM, we don't have any hardware to test it. I guess since builds have passed and if packaging passes too, we can merge with enough reviews.

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1642
Job ID-88

Thanks @rhtyd for the review!
I believe @syed will provide a review when he has time, as well.

@mike-tutkowski  the code LGTM. We have a managed storage in-house. I will run it there and report if I see any problems.

Thank you both for providing your reviews and subsequent LGTMs. :)
I believe this PR is ready to be merged.
Who is responsible for doing that these days? Can I or do we specifically have the release manager(s) do this again? Thanks!

@mike-tukowski any committer may merge a PR with at least one code review LGTM, at least one test LGTM, and no -1s.  For this PR, I don't see a test LGTM with test results.  Until it has at least one test LGTM, it is not ready to merge.

@jburwell Have we as a community defined what a test review must encompass? Is there a set of particular tests that must generally be run for each PR?

@mike-tutkowski determining the required tests to run for a PR is at the top of my TODO list.  For now,   I would say running all smoke tests and associated component tests on hardware would be required for this PR.
As an aside, do we have Marvin test cases to verify this enhancement?

I have been performing additional tests manually on this PR and noticed one issue that I want to investigate:
When I put the managed primary storage that the system VMs are running on into maintenance mode, the three system VMs were moved to my NFS primary storage (so far, so good).
However, the SRs and SAN volumes that stored the root disks of each of these system VMs were not cleaned up (I had to do so manually).
Also, when I tried to delete the managed primary storage later, it said there were associated volumes, so I had to force delete the primary storage.
I want to investigate why those resources weren't cleaned up automatically.

Ah, I think I "jumped the gun" on this. It looks like the three SRs (and corresponding volumes on the SAN) were to be deleted by a background thread (which I didn't wait for).
I plan to set this up again and see if they get automatically deleted.

@mike-tutkowski we usually increase the garbage collection frequency and reduce any wait time global settings  in order to speed up tests.  Coupled with the wait_until Marvin, you build fairly quick, deterministic automated tests for these types of scenarios.  If you like more info on this strategy, let me know.

Sounds good, @jburwell

@syed @rhtyd @jburwell I have provided new integration tests for this PR.
Also, I have run the following tests (all successfully):
TestVolumes.py (both with and without XenServer resigning)
TestSnapshots.py
TestVMSnapshots.py
TestAddRemoveHost.py
TestManagedSystemVMs.py (this is a new test suite that was added with this PR)

@mike-tutkowski started our internal CI run on this PR(xen server advanced). It will run the smoke tests and post the results here. once it confirms there are no regressions, I will merge this PR. Thanks.

ACS CI BVT Run
Sumarry:
Build Number 97
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=0
Skipped=4
Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
Failed tests:
Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_ssvm.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

@mike-tutkowski can you address @jburwell's comment? other than that, its ready to merge.

@karuturi there remains the issue of the hard coded template name.  Therefore, I am -1 until the issue of the hardcoded template name is addressed.  These hardcoded values cause massive portability problems across environments and we have a standard way to acquire the correct template to run from the Marvin environment.

That is exactly what I said in my last comment. I am waiting for mike to resolve it so that I can merge. That is the only pending item on this PR.

@mike-tutkowski Thanks for adding marvin tests. Some observations regarding the tests.
I see that you have put the tests under solidfire folder. Currently is solidfire the only managed storage provider? Do you think the test can be easily reused with another managed storage by just changing some configuration? Also there are system VM (SSVM) related smoke tests. Please see if you can run them with solidfire as primary store.

@koushik-das didn't notice that path, but completely agree.  I'd like to see a generic test requirement for managed storage which make the test cases more reusable for future storage drivers.
@karuturi did those tests run against an environment with managed storage (i.e. SolidFire)?  We need test results from such an environment.  Also, for regression purposes, I would like to see the test suite run against a KVM and VMware environment to ensure no secondary storage operations have been inadvertently impacted.
@mike-tutkowski @abhinandanprateek the test should be skipped if the environment is not XenServer.  Therefore, I don't see any reason for a hard-coded template name.

@jburwell Do you know what that standard way of acquiring a template name is? Thanks!

@koushik-das "Currently is solidfire the only managed storage provider?" CloudByte is a managed-storage provider, but I have not seen them active in our community for years now. These SolidFire tests are specific to SolidFire in that they make API calls to a SolidFire cluster to verify state after CloudStack performs some activity. If we ever get another managed-storage provider who wants to make use of these as a template for there own, that would, of course, be perfectly fine.

@karuturi I had posted this earlier in the PR. Is this OK?

Also, I have run the following tests (all successfully):
TestVolumes.py (both with and without XenServer resigning)
TestSnapshots.py
TestVMSnapshots.py
TestAddRemoveHost.py
TestManagedSystemVMs.py (this is a new test suite that was added with this PR)

@mike-tutkowski Currently, all the info in the TestData is hardcoded. Would it be possible to add a system to override some values so that I can test this as well (IP addresses for example)? Today when you run nosetests you cannot provide a test data file although the marvin plugin supports it [1].
I have an idea which could work. I can send a PR for this, we can continue the discussion there.
[1] https://github.com/apache/cloudstack/blob/master/tools/marvin/marvin/marvinInit.py#L217

@syed Yeah, I'd like to externalize that data. I just haven't taken the time to investigate how that works with Marvin. :)

Hey @syed I like your idea here. How's about we work on a separate PR for it so that I can incorporate your idea into all of the integration scripts I have?

I think I know how to acquire the template name without hard-coding it now:
    cls.template = get_template(
        cls.apiClient,
        zone.id,
        cls.configData["ostype"])

When I look at cls.template.name, it has the expected name.
I can update the test with this approach.

@jburwell I now retrieve the template in a non-hard-coded manner. I attached a diff because I squashed the commit and force pushed it up to GitHub.

@mike-tutkowski sorry I forgot the precise way to do it -- thanks for digging it out.  It makes tests far more resilient to differences between test environments.
As I mentioned previously, the only other item I would like to see is a regression test against VMware and KVM.

@jburwell At present, this is really only supported on XenServer. As long as our other integration tests don't fail due to anything in here, we should be OK.

@mike-tutkowski the reason I would like the regression tests run is to confirm that assumption.

Oh @jburwell I thought you were asking for new regression tests to be created. I think you and I are on the same page now.

@jburwell
My test run is on NFS. I dont have managed storage.
Are you running the tests on managed storage with KVM and VMWare?

@karuturi I think John is just asking if we can run test_ssvm.py (a smoke test) on VMware and KVM.

Just a note that @syed and I discussed his idea and decided to open a separate PR for it.

@jburwell I changed the sleep/delay to a wait_until.
Here is the most recent test run for this integration test:
test_01_create_system_vms_on_managed_storage (TestManagedSystemVMs.TestManagedSystemVMs) ... === TestName: test_01_create_system_vms_on_managed_storage | Status : SUCCESS ===
ok
test_02_failure_to_create_service_offering_with_customized_iops (TestManagedSystemVMs.TestManagedSystemVMs) ... === TestName: test_02_failure_to_create_service_offering_with_customized_iops | Status : SUCCESS ===
ok

Ran 2 tests in 2692.276s
OK

@mike-tutkowski @karuturi it seems like this PR should have all smoke tests + system VM integration test suites (SSVM, CPVM, and VR) + the new test integration test suite added for this PR run on XenServer.  Additionally, all smoke tests + system VM integration test suites (SSVM, CPVM, and VR) should be run on VMware and KVM as a regression test.  These tests do not have to be run in the same environment or person.  I would just like see results for all of these scenarios from posted to this PR.  Does that make sense?

@mike-tutkowski is there a JIRA ticket for this enhancement?  Also, are there any documentation updates necessary?

@jburwell Let me provide a bit of additional background for this PR.
As noted in the initial comment, it was possible to spin up system VMs on managed storage prior to this PR.
This PR adds three items:

There are a couple checks added when creating a system offering that uses managed storage. For example, it doesn't really make sense to allow "custom IOPS" and now we prevent that if you try to create a system offering as such.

If you transition managed storage into maintenance mode and system VMs were running on that managed storage, the host-side clustered file systems (SRs on XenServer) were not removed. This is not a big issue since putting a managed storage like a SAN in maintenance mode is not too likely.

I added a call to a method that removes these client-side file systems, if you're using managed storage. In the event of any failure here, I catch the exception, print an error message to the log, and allow the storage-cleanup thread to continue its tasks.

I added an extensive set of tests with regards to system VMs on managed storage.

How are we doing on this one? Do my comments above make sense to everyone?

@mike-tutkowski  I am +1 on the changes and ready to merge from my end. Once you and @jburwell come to an agreement, I will merge.

@mike-tutkowski the background makes sense.  I would like to see that comment amended to commit message.  I have the following outstanding questions/items:

Is there a JIRA ticket for this enhancement?  If not, please create one.  Also, please reference it in the commit message.
Test results for the following test scenarios:

[ ] Smoke test suite + system VM integration test suites (SSVM, CPVM, and VR) + the new test integration test suite added for this PR against XenServer using Managed Storage for System VMs
[ ] Smoke test suite + system VM integration test suites (SSVM, CPVM, and VR) against XenServer using Unmanaged Storage for System VMs
[ ] Smoke test suite + system VM integration test suites (SSVM, CPVM, and VR) against VMware using Unmanaged Storage for System VMs
[ ] Smoke test suite + system VM integration test suites (SSVM, CPVM, and VR) against KVM using Unmanaged Storage for System VMs

As I mentioned previously, these tests can be run across separate labs.  We simply need to collect the results for each of these test scenarios to verify the patch functionality and no regressions were introduced.

@karuturi Do you happen to have any resources we can use to fulfill John's test requests? Thanks

@mike-tutkowski sorry mike. 2.b(xen+unmanaged) is what I ran. I dont have others.

@karuturi That config is actually one of the ones John is asking for. :)
Smoke test suite + system VM integration test suites (SSVM, CPVM, and VR) against XenServer using Unmanaged Storage for System VMs

I already posted the results for that configuration(a comment form @cloudmonger with test results) its all good there.

Thank you, @karuturi!
Does anyone know who can run the VMware test that @jburwell asked for? I can't due to this issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9144 (but perhaps someone is using an Advanced Zone and doesn't see the problem described in 9144).

@mike-tutkowski  and @jburwell I think nobody has the test configurations requested. There is no point waiting indefinitely on a configuration which nobody has or wants to test. Let wait for 2 more days and if no one responds, lets merge.

@karuturi VMware with NFS primary/secondary storage.  It is one of the most commonly deployed CloudStack configurations.  Therefore, I am -1 on merging this PR until this regression test is performed.
The good news is that blueorgangutan is now back online and will be able to run such a test shortly.  @rhtyd is working to address a VMware Ansible/Marvin bug.  We will kick a CentOS 7.2/VMware 5.5u3 smoke test/integration test run for this PR when it is ready.  I expect that it will addressed today (22 Sept 2016).

@jburwell 'most commonly deployed' - I doubt.
As @blueorangutan is ready to test, we can wait. In general, waiting for test results on a configuration which no one has(Hardware is hard), just halts a PR with no further steps to do.

@karuturi I am not going to debate the commonality of VMware.  It is the market leader in the hypervisor space, and NFS is one of the most popular storage protocols used with it.  Like the general hypervisor market, we have a large portion of our user community that relies on VMware with NFS.  Therefore, I will not remove my -1 from this PR until the necessary regression tests have been run.
Generally speaking, quality is the primary driver for merging PRs.  Selective test coverage (both in the number of tests run and diversity of environments tests are run against) is one of the largest quality issues we are currently working to address.  A test scenario being "hard" is not a valid reason to ignore it and move a PR forward.  Given that quality is the primary driver for the community, then PRs must wait to be adequately tested.

@mike-tutkowski I only see results for the new test suites for XenServer + Managed Storage.  Have you also run the entire smoke test suite with require_hardware set to true?  If so, could you please add the test results to the PR?

@jburwell Let me run those tests next week (probably Monday) as I'm just about ready to head out on a flight to a customer site for an upcoming meeting and won't be back until the weekend. Thanks

@jburwell I never asked you to remove your -1.  I am not even trying to convince you to remove your -1.
If Vmware + nfs is such an important combination, it should be the prerequisite for every PR not just this one.
I do understand the necessity of quality(which why we started with PRs in the first place) and all that is said makes sense in an ideal(or atleast corporate) world. There is lot of difference between being technically 'hard' and monetarily 'hard'.
Quality is not going to improve by just waiting on test results. It will only improve if we make such an effort to run tests.

@blueorangutan matrix

@blueorangutan test matrix

@jburwell a Trillian-Jenkins matrix job (centos6 mgmt + xs56sp1, centos7 mgmt + vmware55u3, ubuntu mgmt + kvmcentos7) has been kicked to run smoke tests

@mike-tutkowski @karuturi I have asked blueorganutan to test this PR across VMware, KVM, and XenServer (I accidentally told it to all 3).

That is great. Let us wait for @blueorangutan to post the results.
There still is a pending request for 'system VM integration test suites (SSVM, CPVM, and VR)'

@karuturi discussing with @rhtyd being able to specify a list of additional component tests to blueorgantan on the test command.  Hopefully, we can get something together by tomorrow (23 Sept 2016).

Great!! Hopefully, we can merge this by Monday then.
This is one of the good PRs we have with good description, screenshots, demo, new tests and test runs by author. (Thanks @mike-tutkowski)

LGTM testing on Vmware hardware. RHEL 6 management servers, ESX 5.5 and 6  hypervisors, advanced networking
test DeployVM in anti-affinity groups for project ... === TestName: test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS ===
test DeployVM in anti-affinity groups ... === TestName: test_DeployVmAntiAffinityGroup | Status : SUCCESS ===
Test Deploy Virtual Machine from ISO ... === TestName: test_deploy_vm_from_iso | Status : SUCCESS ===
Test deploy virtual machine with root resize ... === TestName: test_00_deploy_vm_root_resize | Status : SUCCESS ===
Test proper failure to deploy virtual machine with rootdisksize of 0 ... === TestName: test_01_deploy_vm_root_resize | Status : SUCCESS ===
Test proper failure to deploy virtual machine with rootdisksize less than template size ... === TestName: test_02_deploy_vm_root_resize | Status : SUCCESS ===
Test to deploy vm with a first fit offering ... === TestName: test_deployvm_firstfit | Status : SUCCESS ===
Test deploy VMs using user concentrated planner ... === TestName: test_deployvm_userconcentrated | Status : SUCCESS ===
Test deploy VMs using user dispersion planner ... === TestName: test_deployvm_userdispersing | Status : SUCCESS ===
Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | Status : SUCCESS ===
Test userdata as POST, size > 2k ... === TestName: test_deployvm_userdata_post | Status : SUCCESS ===
Test to create disk offering ... === TestName: test_01_create_disk_offering | Status : SUCCESS ===
Test to create  a sparse type disk offering ... === TestName: test_02_create_sparse_type_disk_offering | Status : SUCCESS ===
Test to create  a sparse type disk offering ... === TestName: test_04_create_fat_type_disk_offering | Status : SUCCESS ===
Test to update existing disk offering ... === TestName: test_02_edit_disk_offering | Status : SUCCESS ===
Test to delete disk offering ... === TestName: test_03_delete_disk_offering | Status : SUCCESS ===
Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Test to check role, role permissions and account life cycles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Tests that default four roles exist ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Tests role update when role is in use by an account ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Tests concurrent order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Tests creation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Tests listing of default role's permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
Tests order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test
test update configuration setting at zone level scope ... === TestName: test_UpdateConfigParamWithScope | Status : SUCCESS ===
Test guest vlan range dedication ... === TestName: test_dedicateGuestVlanRange | Status : SUCCESS ===
Test create public & private ISO ... === TestName: test_01_create_iso | Status : SUCCESS ===
Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS ===
Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS ===
Test for extract ISO ... === TestName: test_04_extract_Iso | Status : SUCCESS ===
Update & Test for ISO permissions ... === TestName: test_05_iso_permissions | Status : SUCCESS ===
Test for copy ISO from one zone to another ... SKIP: Not enough zones available to perform copy template
Test delete ISO ... === TestName: test_07_list_default_iso | Status : SUCCESS ===
Test listing Volumes using 'ids' parameter ... === TestName: test_01_list_volumes | Status : SUCCESS ===
Test listing Templates using 'ids' parameter ... === TestName: test_02_list_templates | Status : SUCCESS ===
Test listing Snapshots using 'ids' parameter ... === TestName: test_03_list_snapshots | Status : SUCCESS ===
Test to create Load balancing rule with source NAT ... === TestName: test_01_create_lb_rule_src_nat | Status : SUCCESS ===
Test to create Load balancing rule with non source NAT ... === TestName: test_02_create_lb_rule_non_nat | Status : SUCCESS ===
Test for assign & removing load balancing rule ... === TestName: test_assign_and_removal_lb | Status : SUCCESS ===
Tests that SAML users are not allowed CloudStack local log in ... === TestName: login_test_saml_user | Status : SUCCESS ===
test_nic_secondaryip_add_remove (integration.smoke.test_multipleips_per_nic.TestDeployVM) ... === TestName: test_nic_secondaryip_add_remove | Status : SUCCESS ===
Test network ACL lists and items in VPC ... === TestName: test_network_acl | Status : SUCCESS ===
# 1. Register a template for VMware with nicAdapter vmxnet3 ... SKIP: VCenter API Integration Remaining
Test to add and update added nic to a virtual machine ... === TestName: test_01_nic | Status : SUCCESS ===
Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS ===
test update configuration setting at storage scope ... === TestName: test_UpdateStorageOverProvisioningFactor | Status : SUCCESS ===
test_create_pvlan_network (integration.smoke.test_pvlan.TestPVLAN) ... === TestName: test_create_pvlan_network | Status : SUCCESS ===
Test for create region ... === TestName: test_createRegion | Status : SUCCESS ===
Test reset virtual machine on reboot ... === TestName: test_01_reset_vm_on_reboot | Status : SUCCESS ===
Test volume detail ... === TestName: test_01_updatevolumedetail | Status : SUCCESS ===
Test scale virtual machine ... SKIP: Skipping scale VM operation because                    VMware tools are not installed on the VM
Test to create service offering ... === TestName: test_01_create_service_offering | Status : SUCCESS ===
Test to update existing service offering ... === TestName: test_02_edit_service_offering | Status : SUCCESS ===
Test to delete service offering ... === TestName: test_03_delete_service_offering | Status : SUCCESS ===
Test to change service to a small capacity ... === TestName: test_04_change_offering_small | Status : SUCCESS ===
Test List secondary storage VMs ... === TestName: test_01_list_sec_storage_vm | Status : SUCCESS ===
Test List console proxy VMs ... === TestName: test_02_list_cpvm_vm | Status : SUCCESS ===
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS ===
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS ===
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS ===
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS ===
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS ===
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS ===
Tests allowed APIs for common account types ... === TestName: test_static_role_account_acls | Status : SUCCESS ===
Test create public & private template ... === TestName: test_01_create_template | Status : SUCCESS ===
Test when createTemplate is used to create templates having the same name all of them get ... === TestName: test_CreateTemplateWithDuplicateName | Status : SUCCESS ===
Test Edit template ... === TestName: test_02_edit_template | Status : SUCCESS ===
Test delete template ... === TestName: test_03_delete_template | Status : SUCCESS ===
Test for extract template ... === TestName: test_04_extract_template | Status : SUCCESS ===
Update & Test for template permissions ... === TestName: test_05_template_permissions | Status : SUCCESS ===
Test for copy template from one zone to another ... SKIP: Not enough zones available to perform copy template
Test only public templates are visible to normal user ... === TestName: test_07_list_public_templates | Status : SUCCESS ===
Test System templates are not visible to normal user ... === TestName: test_08_list_system_templates | Status : SUCCESS ===
Check events in usage_events table when VM creation fails ... === TestName: test_01_positive_tests_usage | Status : SUCCESS ===
Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
Tests for basic zone virtual router ... === TestName: test_basicZoneVirtualRouter | Status : SUCCESS ===
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
Test migrate VM ... === TestName: test_08_migrate_vm | Status : SUCCESS ===
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS ===
Test for attach and detach ISO to virtual machine ... === TestName: test_10_attachAndDetach_iso | Status : SUCCESS ===
Test Volume creation for all Disk Offerings (incl. custom) ... === TestName: test_01_create_volume | Status : SUCCESS ===
Attach a created Volume to a Running VM ... === TestName: test_02_attach_volume | Status : SUCCESS ===
Download a Volume attached to a VM ... === TestName: test_03_download_attached_volume | Status : SUCCESS ===
Delete a Volume attached to a VM ... === TestName: test_04_delete_attached_volume | Status : SUCCESS ===
Detach a Volume attached to a VM ... === TestName: test_05_detach_volume | Status : SUCCESS ===
Download a Volume unattached to an VM ... === TestName: test_06_download_detached_volume | Status : SUCCESS ===
Test resize (negative) non-existent volume ... SKIP: Resize Volume is unsupported on VmWare and Hyper-V
Test resize a volume ... SKIP: Resize Volume is unsupported on VmWare and Hyper-V
Delete a Volume unattached to an VM ... === TestName: test_09_delete_detached_volume | Status : SUCCESS ===

----------------------------------------------------------------------
Ran 103 tests in 12228.674s

OK (SKIP=20)

Thanks for running that, @serg38!

@blueorangutan @jburwell any update on the tests?

@karuturi awaiting feature enhancement to blueorangutan which was delayed due to an medical emergency.  Also, I want to wait to perform further testing until #1692 is tested and merged as it fixes a number of smoke test errors.  Tests for it are running now, and I expect it to be merged tomorrow (28 Sept 2016).  I apologize for the wait.

Travis issue?

@mike-tutkowski The Travis build is failing with the following error:
0.04s$ ./tools/travis/script.sh ${TESTS}
Running tests:  smoke/test_usage_events smoke/test_vm_life_cycle smoke/test_vm_snapshots smoke/test_volumes smoke/test_vpc_redundant smoke/test_vpc_router_nics smoke/test_vpc_vpn smoke/misc/test_deploy_vm smoke/misc/test_vm_ha smoke/misc/test_escalations_templates smoke/misc/test_vm_sync
./tools/travis/script.sh: line 44: nosetests: command not found
./tools/travis/script.sh: line 44: nosetests: command not found
./tools/travis/script.sh: line 44: nosetests: command not found
./tools/travis/script.sh: line 44: nosetests: command not found
./tools/travis/script.sh: line 44: nosetests: command not found
./tools/travis/script.sh: line 44: nosetests: command not found
./tools/travis/script.sh: line 44: nosetests: command not found
./tools/travis/script.sh: line 44: nosetests: command not found
./tools/travis/script.sh: line 44: nosetests: command not found
./tools/travis/script.sh: line 44: nosetests: command not found
./tools/travis/script.sh: line 44: nosetests: command not found
Traceback (most recent call last):
  File "./tools/travis/xunit-reader.py", line 27, in <module>
    import texttable
ImportError: No module named texttable

I don't know if that is due to a change in the PR or Travis just need to be re-kicked.

@jburwell I think it's Travis. I've changed the commit SHA twice now and it failed both times plus it fails with #1600, as well (even though I pushed that one multiple times, too). Not sure why it can't find nosetests.

@rhtyd any ideas?

@jburwell @mike-tutkowski  looks like marvin fails to get installed properly, one of the dependency fails with following:
Command "/opt/python/2.7.10/bin/python2.7 -u -c "import setuptools, tokenize;file='/tmp/pip-build-wNNQnH/cryptography/setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" install --record /tmp/pip-ELOxnP-record/install-record.txt --single-version-externally-managed --compile --user --prefix=" failed with error code 1 in /tmp/pip-build-wNNQnH/cryptography/
Feel free to try to fix it, else I'll open a new PR and see if it works with latest 4.9 and master branches, and fix anything necessary tomorrow. I'll keep you posted.

Travis, which was failing for a similar reason for #1600, passed, so I will (once again) change the commit SHA and re-push. In fact, while I'm at it, I'll rebase it against the latest from master before re-pushing.

I still got a weird Travis failure, so I decided to close and re-open this PR.

Closing and re-opening the PR fixed the Travis issue.

@jburwell Excellent...closing and re-opening the ticket fixed the CI issue.

Just following up on this one. Is there any pending work item that remains or are we able to merge? Thanks!

@mike-tutkowski If the LGTMs are there, this can get merged. There are lot of comments so difficult to go through all of them.

LGTM. @mike-tutkowski can you check why Travis failed?
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-79

@rhtyd I changed the SHA and re-pushed the commit. Hopefully that will clear up Travis.

Looks like re-pushing the commit did the trick, @rhtyd. I think we are good to go here.

@blueorangutan test matrix

@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-163)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25326 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1642-t163-kvm-centos7.zip
Test completed. 46 look ok, 2 have error(s)

Test
Result
Time (s)
Test File

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
367.82
test_vpc_redundant.py

test_07_reboot_ssvm
Failure
355.37
test_ssvm.py

test_oobm_zchange_password
Failure
20.30
test_outofbandmanagement.py

test_05_stop_ssvm
Error
370.57
test_ssvm.py

test_01_vpc_site2site_vpn
Success
159.16
test_vpc_vpn.py

test_01_vpc_remote_access_vpn
Success
55.75
test_vpc_vpn.py

test_01_redundant_vpc_site2site_vpn
Success
224.90
test_vpc_vpn.py

test_02_VPC_default_routes
Success
263.39
test_vpc_router_nics.py

test_01_VPC_nics_after_destroy
Success
565.10
test_vpc_router_nics.py

test_05_rvpc_multi_tiers
Success
524.24
test_vpc_redundant.py

test_04_rvpc_network_garbage_collector_nics
Success
1319.89
test_vpc_redundant.py

test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers
Success
557.64
test_vpc_redundant.py

test_02_redundant_VPC_default_routes
Success
800.81
test_vpc_redundant.py

test_09_delete_detached_volume
Success
15.40
test_volumes.py

test_08_resize_volume
Success
15.26
test_volumes.py

test_07_resize_fail
Success
20.34
test_volumes.py

test_06_download_detached_volume
Success
15.22
test_volumes.py

test_05_detach_volume
Success
100.22
test_volumes.py

test_04_delete_attached_volume
Success
10.15
test_volumes.py

test_03_download_attached_volume
Success
15.20
test_volumes.py

test_02_attach_volume
Success
73.71
test_volumes.py

test_01_create_volume
Success
750.46
test_volumes.py

test_deploy_vm_multiple
Success
292.63
test_vm_life_cycle.py

test_deploy_vm
Success
0.02
test_vm_life_cycle.py

test_advZoneVirtualRouter
Success
0.01
test_vm_life_cycle.py

test_10_attachAndDetach_iso
Success
26.38
test_vm_life_cycle.py

test_09_expunge_vm
Success
125.12
test_vm_life_cycle.py

test_08_migrate_vm
Success
35.57
test_vm_life_cycle.py

test_07_restore_vm
Success
0.08
test_vm_life_cycle.py

test_06_destroy_vm
Success
125.72
test_vm_life_cycle.py

test_03_reboot_vm
Success
125.59
test_vm_life_cycle.py

test_02_start_vm
Success
10.12
test_vm_life_cycle.py

test_01_stop_vm
Success
35.21
test_vm_life_cycle.py

test_CreateTemplateWithDuplicateName
Success
135.73
test_templates.py

test_08_list_system_templates
Success
0.02
test_templates.py

test_07_list_public_templates
Success
0.03
test_templates.py

test_05_template_permissions
Success
0.05
test_templates.py

test_04_extract_template
Success
5.12
test_templates.py

test_03_delete_template
Success
5.08
test_templates.py

test_02_edit_template
Success
90.07
test_templates.py

test_01_create_template
Success
40.32
test_templates.py

test_10_destroy_cpvm
Success
136.34
test_ssvm.py

test_09_destroy_ssvm
Success
163.42
test_ssvm.py

test_08_reboot_cpvm
Success
131.78
test_ssvm.py

test_06_stop_cpvm
Success
161.63
test_ssvm.py

test_04_cpvm_internals
Success
1.28
test_ssvm.py

test_03_ssvm_internals
Success
2.89
test_ssvm.py

test_02_list_cpvm_vm
Success
0.07
test_ssvm.py

test_01_list_sec_storage_vm
Success
0.09
test_ssvm.py

test_01_snapshot_root_disk
Success
10.89
test_snapshots.py

test_04_change_offering_small
Success
239.47
test_service_offerings.py

test_03_delete_service_offering
Success
0.02
test_service_offerings.py

test_02_edit_service_offering
Success
0.05
test_service_offerings.py

test_01_create_service_offering
Success
0.07
test_service_offerings.py

test_02_sys_template_ready
Success
0.10
test_secondary_storage.py

test_01_sys_vm_start
Success
0.12
test_secondary_storage.py

test_09_reboot_router
Success
55.43
test_routers.py

test_08_start_router
Success
25.20
test_routers.py

test_07_stop_router
Success
10.11
test_routers.py

test_06_router_advanced
Success
0.04
test_routers.py

test_05_router_basic
Success
0.02
test_routers.py

test_04_restart_network_wo_cleanup
Success
5.59
test_routers.py

test_03_restart_network_cleanup
Success
65.38
test_routers.py

test_02_router_internal_adv
Success
0.90
test_routers.py

test_01_router_internal_basic
Success
0.47
test_routers.py

test_router_dns_guestipquery
Success
76.68
test_router_dns.py

test_router_dns_externalipquery
Success
0.04
test_router_dns.py

test_router_dhcphosts
Success
240.84
test_router_dhcphosts.py

test_01_updatevolumedetail
Success
5.07
test_resource_detail.py

test_01_reset_vm_on_reboot
Success
160.80
test_reset_vm_on_reboot.py

test_createRegion
Success
0.02
test_regions.py

test_create_pvlan_network
Success
5.14
test_pvlan.py

test_dedicatePublicIpRange
Success
0.27
test_public_ip_range.py

test_04_rvpc_privategw_static_routes
Success
474.54
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Success
483.89
test_privategw_acl.py

test_02_vpc_privategw_static_routes
Success
394.54
test_privategw_acl.py

test_01_vpc_privategw_acl
Success
92.12
test_privategw_acl.py

test_01_primary_storage_nfs
Success
35.66
test_primary_storage.py

test_createPortablePublicIPRange
Success
15.13
test_portable_publicip.py

test_createPortablePublicIPAcquire
Success
15.29
test_portable_publicip.py

test_isolate_network_password_server
Success
89.63
test_password_server.py

test_UpdateStorageOverProvisioningFactor
Success
0.09
test_over_provisioning.py

test_oobm_multiple_mgmt_server_ownership
Success
16.52
test_outofbandmanagement.py

test_oobm_issue_power_status
Success
10.51
test_outofbandmanagement.py

test_oobm_issue_power_soft
Success
15.51
test_outofbandmanagement.py

test_oobm_issue_power_reset
Success
15.51
test_outofbandmanagement.py

test_oobm_issue_power_on
Success
15.51
test_outofbandmanagement.py

test_oobm_issue_power_off
Success
15.51
test_outofbandmanagement.py

test_oobm_issue_power_cycle
Success
15.52
test_outofbandmanagement.py

test_oobm_enabledisable_across_clusterzones
Success
57.45
test_outofbandmanagement.py

test_oobm_enable_feature_valid
Success
5.12
test_outofbandmanagement.py

test_oobm_enable_feature_invalid
Success
0.07
test_outofbandmanagement.py

test_oobm_disable_feature_valid
Success
0.14
test_outofbandmanagement.py

test_oobm_disable_feature_invalid
Success
0.07
test_outofbandmanagement.py

test_oobm_configure_invalid_driver
Success
0.07
test_outofbandmanagement.py

test_oobm_configure_default_driver
Success
0.06
test_outofbandmanagement.py

test_oobm_background_powerstate_sync
Success
24.43
test_outofbandmanagement.py

test_extendPhysicalNetworkVlan
Success
15.22
test_non_contigiousvlan.py

test_01_nic
Success
675.33
test_nic.py

test_releaseIP
Success
247.53
test_network.py

test_reboot_router
Success
428.35
test_network.py

test_public_ip_user_account
Success
10.17
test_network.py

test_public_ip_admin_account
Success
40.21
test_network.py

test_network_rules_acquired_public_ip_3_Load_Balancer_Rule
Success
66.69
test_network.py

test_network_rules_acquired_public_ip_2_nat_rule
Success
61.56
test_network.py

test_network_rules_acquired_public_ip_1_static_nat_rule
Success
124.31
test_network.py

test_delete_account
Success
262.40
test_network.py

test_02_port_fwd_on_non_src_nat
Success
55.45
test_network.py

test_01_port_fwd_on_src_nat
Success
111.60
test_network.py

test_nic_secondaryip_add_remove
Success
227.75
test_multipleips_per_nic.py

login_test_saml_user
Success
21.35
test_login.py

test_assign_and_removal_lb
Success
133.67
test_loadbalance.py

test_02_create_lb_rule_non_nat
Success
187.10
test_loadbalance.py

test_01_create_lb_rule_src_nat
Success
219.68
test_loadbalance.py

test_03_list_snapshots
Success
0.04
test_list_ids_parameter.py

test_02_list_templates
Success
0.03
test_list_ids_parameter.py

test_01_list_volumes
Success
0.02
test_list_ids_parameter.py

test_07_list_default_iso
Success
0.04
test_iso.py

test_05_iso_permissions
Success
0.04
test_iso.py

test_04_extract_Iso
Success
5.12
test_iso.py

test_03_delete_iso
Success
95.16
test_iso.py

test_02_edit_iso
Success
0.05
test_iso.py

test_01_create_iso
Success
21.31
test_iso.py

test_04_rvpc_internallb_haproxy_stats_on_all_interfaces
Success
273.15
test_internal_lb.py

test_03_vpc_internallb_haproxy_stats_on_all_interfaces
Success
177.37
test_internal_lb.py

test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80
Success
540.68
test_internal_lb.py

test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
Success
464.18
test_internal_lb.py

test_dedicateGuestVlanRange
Success
10.40
test_guest_vlan_range.py

test_UpdateConfigParamWithScope
Success
0.10
test_global_settings.py

test_rolepermission_lifecycle_update
Success
6.35
test_dynamicroles.py

test_rolepermission_lifecycle_list
Success
6.25
test_dynamicroles.py

test_rolepermission_lifecycle_delete
Success
6.21
test_dynamicroles.py

test_rolepermission_lifecycle_create
Success
6.19
test_dynamicroles.py

test_rolepermission_lifecycle_concurrent_updates
Success
6.44
test_dynamicroles.py

test_role_lifecycle_update_role_inuse
Success
6.19
test_dynamicroles.py

test_role_lifecycle_update
Success
11.24
test_dynamicroles.py

test_role_lifecycle_list
Success
6.18
test_dynamicroles.py

test_role_lifecycle_delete
Success
11.21
test_dynamicroles.py

test_role_lifecycle_create
Success
6.27
test_dynamicroles.py

test_role_inuse_deletion
Success
6.16
test_dynamicroles.py

test_role_account_acls_multiple_mgmt_servers
Success
7.47
test_dynamicroles.py

test_role_account_acls
Success
7.82
test_dynamicroles.py

test_default_role_deletion
Success
6.23
test_dynamicroles.py

test_04_create_fat_type_disk_offering
Success
0.04
test_disk_offerings.py

test_03_delete_disk_offering
Success
0.03
test_disk_offerings.py

test_02_edit_disk_offering
Success
0.04
test_disk_offerings.py

test_02_create_sparse_type_disk_offering
Success
0.04
test_disk_offerings.py

test_01_create_disk_offering
Success
0.07
test_disk_offerings.py

test_deployvm_userdispersing
Success
20.37
test_deploy_vms_with_varied_deploymentplanners.py

test_deployvm_userconcentrated
Success
45.47
test_deploy_vms_with_varied_deploymentplanners.py

test_deployvm_firstfit
Success
45.37
test_deploy_vms_with_varied_deploymentplanners.py

test_deployvm_userdata_post
Success
10.23
test_deploy_vm_with_userdata.py

test_deployvm_userdata
Success
45.52
test_deploy_vm_with_userdata.py

test_02_deploy_vm_root_resize
Success
6.27
test_deploy_vm_root_resize.py

test_01_deploy_vm_root_resize
Success
6.26
test_deploy_vm_root_resize.py

test_00_deploy_vm_root_resize
Success
237.50
test_deploy_vm_root_resize.py

test_deploy_vm_from_iso
Success
197.83
test_deploy_vm_iso.py

test_DeployVmAntiAffinityGroup
Success
75.70
test_affinity_groups.py

test_03_delete_vm_snapshots
Skipped
0.00
test_vm_snapshots.py

test_02_revert_vm_snapshots
Skipped
0.00
test_vm_snapshots.py

test_01_test_vm_volume_snapshot
Skipped
0.00
test_vm_snapshots.py

test_01_create_vm_snapshots
Skipped
0.00
test_vm_snapshots.py

test_06_copy_template
Skipped
0.00
test_templates.py

test_static_role_account_acls
Skipped
0.02
test_staticroles.py

test_01_scale_vm
Skipped
0.00
test_scale_vm.py

test_01_primary_storage_iscsi
Skipped
0.02
test_primary_storage.py

test_06_copy_iso
Skipped
0.00
test_iso.py

test_deploy_vgpu_enabled_vm
Skipped
0.02
test_deploy_vgpu_enabled_vm.py

test_3d_gpu_support
Skipped
0.02
test_deploy_vgpu_enabled_vm.py

Tests out-of-band management change password feature ... === TestName: test_oobm_zchange_password | Status : FAILED ===
FAIL
That might be a problem with the test.

======================================================================
FAIL: Create a redundant VPC with two networks with two VMs in each network
Traceback (most recent call last):
File "/marvin/tests/smoke/test_vpc_redundant.py", line 582, in test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
self.do_vpc_test(False)
File "/marvin/tests/smoke/test_vpc_redundant.py", line 727, in do_vpc_test
self.check_ssh_into_vm(vm.get_vm(), vm.get_ip(), expectFail=expectFail, retries=retries)
File "/marvin/tests/smoke/test_vpc_redundant.py", line 571, in check_ssh_into_vm
self.fail("Failed to SSH into VM - %s" % (public_ip.ipaddress.ipaddress))
AssertionError: Failed to SSH into VM - <IP_ADDRESS>
That might be a problem with the test.

2016-10-23 19:32:49,315 - CRITICAL - EXCEPTION: test_05_stop_ssvm: ['Traceback (most recent call last):\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 369, in run\n    testMethod()\n', '  File "/marvin/tests/smoke/test_ssvm.py", line 733, in test_05_stop_ssvm\n    self.waitForSystemVMAgent(ssvm_response.name)\n', '  File "/marvin/tests/smoke/test_ssvm.py", line 81, in waitForSystemVMAgent\n    raise Exception("Timed out waiting for SSVM agent to be Up")\n', 'Exception: Timed out waiting for SSVM agent to be Up\n']
2016-10-23 19:41:26,319 - CRITICAL - FAILED: test_07_reboot_ssvm: ['Traceback (most recent call last):\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 369, in run\n    testMethod()\n', '  File "/marvin/tests/smoke/test_ssvm.py", line 920, in test_07_reboot_ssvm\n    self.test_03_ssvm_internals()\n', '  File "/marvin/tests/smoke/test_ssvm.py", line 440, in test_03_ssvm_internals\n    "Check for warnings in tests"\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 553, in assertEqual\n    assertion_func(first, second, msg=msg)\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 546, in _baseAssertEqual\n    raise self.failureException(msg)\n', 'AssertionError: Check for warnings in tests\n']
Off hand I'm not sure how this PR would cause these failures. Perhaps we could run these tests again?

 Or can I go ahead and merge this?

@karuturi @mike-tutkowski the oobm related error was an env issue, the vpc/vr related failures are know (and fixes are on its way). I'm not sure what to make of the ssvm/storage related failures.

Any way to easily just re-run test_05_stop_ssvm and test_07_reboot_ssvm?
I'm not sure how this PR would cause such failures. The only changed Java code does the following:

Validates IOPS parameters in a certain situation when creating a new System Offering. (should not apply here)

For managed storage, when the storage-cleanup thread runs, attempts to remove the remaining SR.  Do you agree?

yes. I am merging this now.

LGTM. The one failing test is due to environment issue, I've fixed it and will send a PR shortly.


Add support traefik, for expose Kibana

[x] Chart version not bumped (the versions are all bumped and released at the same time)
[x] README.md updated with any new values or changes
[ ] Updated template tests in ${CHART}/tests/*.py
[ ] Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Hmmm... I'm signed CLA, but check not passed. What am I doing wrong

Hi @zorgzerg, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Hi @zorgzerg, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Ohhh... Sorry, apparently I was in a hurry. Now everything is ok

Fixed

jenkins test this please


TDD-Ex4

@ItamarShDev
https://github.com/AlumaK/ex4-tdd.git

you need to do at least 7 tests as written in the instructions
also you need to submit here as always

:+1:

:+1:


Remove original flutter_tester integration test

I'm working on fixing up all tests that rely on fs.currentDirectory to allow us to run tests concurrently. This one proved to be really tricky because it calls a lot of code and spawns multiple processes that have a mix of absolute and relative paths passed to them. I managed to handle some of it with a ChrootFileSystem, but the paths passed to the external processes were then incorrect.
The functionality here is covered by all of the integration tests that use flutter_tester that were added after this, including flutter_run_test.dart, lifetime_test.dart etc. in this same folder but because they're run through flutter run as a separate process they get to set their own working directories without affecting other tests if run concurrently.
(Original PRs are https://github.com/flutter/flutter/pull/21119, https://github.com/flutter/flutter/pull/21482)
If we want to keep this, we may be able to do it by threading a working directory through all of the code, but for the benefit of only this test it may be an unnecessary risk.

@fkorotkov seems like the bots are having some issues:

Fatal exception on the agent! Failed to report command pub: rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:8239: connectex: No connection could be made because the target machine actively refused it."

@DanTup made the retry logic a little bit smarter about such network issues. Let's see if it helps since other windows tasks around that time were unaffected.

Okey, I'll let you know if I see it again (FWIW it did affect two Windows tasks the same here, though they may have started at the same time).


Training log update

thanks for sharing your excellent job!
can you update your training logs? when I have runned
configs/distillers/fgd/fgd_retina_rx101_64x4d_distill_retina_r50_fpn_2x_coco.py , I only got 30.4 mAP
Epoch(val) [24][625]   bbox_mAP: 0.3040, bbox_mAP_50: 0.4980, bbox_mAP_75: 0.3140, bbox_mAP_s: 0.1640, bbox_mAP_m: 0.3300, bbox_mAP_l: 0.4160, bbox_mAP_copypaste: 0.304 0.498 0.314 0.164 0.330 0.416
I don't konw why
thank your~

The log cannot help you to solve the problem. There must be something wrong with the codes. What's your mmdet version?

The log cannot help you to solve the problem. There must be something wrong with the codes. What's your mmdet version?

mmdet==2.25.0 mmcv-full==1.6.1

Please refer README for the higher mmdet version. You might initialize the student and teacher wrongly.

In my training log, I found
2022-08-05 17:52:24,038 - mmdet - INFO - Set random seed to 0, deterministic: False
2022-08-05 17:52:26,558 - mmdet - INFO - initialize ResNeXt with init_cfg {'type': 'Pretrained', 'checkpoint': 'open-mmlab://resnext101_64x4d'}
2022-08-05 17:52:27,039 - mmdet - INFO - initialize FPN with init_cfg {'type': 'Xavier', 'layer': 'Conv2d', 'distribution': 'uniform'}
2022-08-05 17:52:27,095 - mmdet - INFO - initialize RetinaHead with init_cfg {'type': 'Normal', 'layer': 'Conv2d', 'std': 0.01, 'override': {'type': 'Normal', 'name': 'retina_cls', 'std': 0.01, 'bias_prob': 0.01}}
2022-08-05 17:52:27,234 - mmdet - INFO - initialize ResNet with init_cfg {'type': 'Pretrained', 'checkpoint': 'torchvision://resnet50'}
2022-08-05 17:52:27,452 - mmdet - INFO - initialize FPN with init_cfg {'type': 'Xavier', 'layer': 'Conv2d', 'distribution': 'uniform'}
2022-08-05 17:52:27,509 - mmdet - INFO - initialize RetinaHead with init_cfg {'type': 'Normal', 'layer': 'Conv2d', 'std': 0.01, 'override': {'type': 'Normal', 'name': 'retina_cls', 'std': 0.01, 'bias_prob': 0.01}}
It seems that student and teacher all init from pretrained model, right?

For mmdet>2.12, you have to change the tools/train.py and mmdet/distillation/distillers/detection_distiller.py.  You can refer MGD to change this.

OK, I will change code refer MGD.
Thanks for your reply!!


map<k,v> doesn't support bigint and boolean keys

The map<k,v> field type currently uses a simple object as a representation. However, that doesn't work for bigint keys.
Same for boolean keys. That's also theoretically supported and there's even a possible pitfall here (stringified serializing and deserializing booleans that is). So I'd personally prefer to use Map<k, v>() here unless something speaks against that?

Hey @fubhy.  That was actually a design choice when writing the library.  See our docs on maps here.
That being said, though, we are investigating whether we still want to stick with this simple object representation or instead migrate to using an ES Map.  It is on our roadmap as something to decide before our v1.0 release, which should be out soon.
I'll keep this issue open until a decision is reached.  Thanks for the issue, definitely on our plate to consider.

Sorry, I must've missed that in the docs.

No worries.  Something we're thinking about also.

Hi @fubhy.  After a lot of deliberation on this, we've decided not to switch to Map at this time and are sticking with simple objects.   Apologies for any inconveniences this causes.


fix spark-6033, clarify the spark.worker.cleanup behavior in standalone mode

jira case spark-6033 https://issues.apache.org/jira/browse/SPARK-6033
In standalone deploy mode, the cleanup will only remove the stopped application's directories.
The original description about the cleanup behavior is incorrect.

Can one of the admins verify this patch?

LGTM merging into master and 1.3, thanks.


Add support Firefox ESR 52.0

Hello, our product has requirements for browsers versions so is there opportunity to create new image with Firefox ESR 52.0?

Duplicates https://github.com/aerokube/selenoid-images/issues/25.


add docs for Viewer configurations

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@MarkvanMents please help review and merge.

Thanks for fixing the error @digital-engineering-services-sample-app
Could you allow me to push changes to this PR, that would make things go quicker.

Thanks for fixing the error @digital-engineering-services-sample-app Could you allow me to push changes to this PR, that would make things go quicker.

Thanks for the quick action, please go ahead!


Boolean Value of TLS registry settings

Considered Part of Documentation
https://learn.microsoft.com/en-us/windows-server/security/tls/tls-registry-settings?tabs=diffie-hellman#tls-dtls-and-ssl-protocol-version-settings
Description
It is not clear to me why according to #6845 the non-zero value should be incorrect. I do have other values than 1 in use practically and they are interpreted as expected.
From my understanding all valid DWORDs that are strictly greater than zero can be considered as True, although I'm aware that it also depends on how an implementation interprets a value.
Just because only one case is shown in the example pictures, doesn't mean others are incorrect or invalid. If setting the registry key to 1 is the preferred/recommended value I'd suggest to make the documentation more precise by indicating that all non-zero values are possible, but it is recommended to use one as a value.
If there is a misunderstanding on my end I would like to learn more about:

Why it is that only 1 can be used?
Why other non-zero values still work on all Windows Server version from 2012 up to the latest?

One example I was referring to above is given in this issue:
https://github.com/fbprogmbh/Audit-Test-Automation/issues/365

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


fix: DEFINES is not defined is env

Description
fix issue https://github.com/antfu/vitesse-webext/issues/19 in https://github.com/vitejs/vite/pull/4187

Additional context

What is the purpose of this pull request?

[x] Bug fix

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

@antfu Uhm... what? You restored the license file and after that the tests fails?! :eyes:

Oh, I think Evan broke something: https://github.com/vitejs/vite/commit/57cad09492d47ea5d85b439d7bff4ec4109d73ec


[HOLD for payment 2024-04-25] [POLISH][Members] Address issues with members profile

Coming from this PR, we have a few small issues to fix.

Navigate to global profile if not an admin of paid policy. We shouldn't just early return here, instead let's navigate the admin of a free policy to the global profile, like we do above.

Can't see owner's profile. We should probably just navigate to the global profile here.

https://github.com/Expensify/App/assets/22219519/516ef386-02d9-4f97-b8fe-7accdeac7d3e

Info icon has active green color by default. We need to fix this.

https://github.com/Expensify/App/issues/37941

https://github.com/Expensify/App/issues/37940 - Backend PR here

cc @burczu
Issue OwnerCurrent Issue Owner: @Santhosh-Sellavel

@kadiealexander @luacmartins Please assign this issue to me - I'll take care of it as na author of the original issue. Thank you.

@luacmartins Ad. 2:

Can't see owner's profile. We should probably just navigate to the global profile here.

This is intended and I'm addressing it here: https://github.com/Expensify/App/issues/35716 - for owners we will show the Members Details page (if another admin selects it) but with the button that will allow to change the ownership.

Info icon has active green color by default. We need to fix this.
Screenshot 2024-03-07 at 2 56 15 PM

@shawnborton Could you please confirm this is a bug and we need to change the color of the Icon here? I recall we had similar situation with Bulk Actions - icons were grey on the design and green in the existing component...

Info icon has active green color by default. We need to fix this.

If we change this, we should globally change all of our option rows. It is something we've talked about given that now the rows in places like Settings don't use green icons anymore. So yeah, definitely open to this but only if we do it as a global change across all option rows/menu rows. Thoughts @Expensify/design ?

Hmmm, so this sounds like a separate issue? @luacmartins

Oh so the green icon is intentional? I thought it was a bug since we apply that style on hover to icons elsewhere, e.g. workspace settings page in the LHN

It's intentional, yup. But we should update it to match the the rows in the Settings page, and then make sure we update the hover styles as well.

@burczu we also have this issue - https://github.com/Expensify/App/issues/37940

@luacmartins This is caused by the backend issue we've already discussed on Slack.

Added https://github.com/Expensify/App/issues/37941 to the scope of this issue.

Are we waiting on something to keep this issue open?

@trjExpensify I'm still working on some polishing of the Members page, that are related to this issue (back button issues mostly), so it should be still open.

@luacmartins I mean this issue: https://github.com/Expensify/App/issues/37941

Ah ok. It seems like we have a draft PR. What's the ETA to get it in review?

Last PR for this merged, right? https://github.com/Expensify/App/pull/37961

Yes

Waiting on deploy to prod to process payment

Reassigning for someone to handle payment as I'll be OOO!

Payouts due:

[ ] Contributor+: $500 @Santhosh-Sellavel

No Upwork job, payment via manual requests. Santhosh please request payment once the checklist is done. Thanks!

@Santhosh-Sellavel please complete the checklist!

This was part of a new feature, so I don't think the checklist applies here. Are we good to close this issue?

Oh, the bug label was applied. Closing, please apply for payment via newdot.

Requested on ND

$250 approved for @Santhosh-Sellavel


Tensorflow version

I am really happy seeing question generation work like this. However, i am not familiar with torch, is there any resource written in tensrflow that can reproduce your work?

I see that you implemented seq2seq model in tf. Could you provide the source code or which toolkit you use? I have tried many times with various seq2seq models. However, the generated questions are strange and unrelated with the source sentence. The generated questions even don't share words with source sentences. Could you give me some suggestions?

sorry, but i don't have the tf code easily available now. i think a bunch
of small tricks might affect a lot.
On Sun, Mar 25, 2018 at 12:18 AM, zhezhaoa<EMAIL_ADDRESS>wrote:

I see that you implemented seq2seq model in tf. Could you provide the
source code or which toolkit you use? I have tried many times with various
seq2seq models. However, the generated questions are strange and unrelated
with the source sentence. The generated questions even don't share words
with source sentences. Could you give me some suggestions?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/xinyadu/nqg/issues/16#issuecomment-375944359, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJb8YYjleBuoPrU7wqp0J1kc0FGEA_Erks5thxqJgaJpZM4S4d0a
.

Hi, thank you very much for your kind suggestion~
I am a rookie in seq2seq and now I am confused with the evaluation. I directly use the opennmt-tf and multi-bleu-detok.perl is used for evaluation. The returned Bleu result is 2.21 (or 0.0221?)  However, with the same output, the returned results of eval.py (the evaluation script in this toolkit) are Bleu1: 0.263 Bleu2: 0.10017 Bleu3: 0.04796 Bleu4: 0.026. It seems that results obtained from your evaluation script are much higher than the results from opennmt-tf. I wonder why there is a big gap between opennmt evaluation and evaluation script in your toolkit. I am look forward to your reply~ This toolkit is extremely useful and important to me!


Flexy: Refactor with CSS-in-JS

Flexy: Refactor with CSS-in-JS

This update converts the Flexy component's CSS into CSS-in-JS styling,
via the @helpscout/fancy library.
Additional Stories were added for Flexy to test out the various
configurationsm such as align, gap, and just.
Flexy has also been modernized with the latest Blue component standards,
which include namespacing and propConnect.
Lastly, the tests were updated to use mount instead of shallow for better
reliability.
Bonus lastly: Since the CSS will be compiled using CSS-in-JS, this allowed me
to remove seed-flexy as a dependency :raised_hands:

Coverage remained the same at 100.0% when pulling d83fd04fab8a28a88f053d0e3f74504fd1334d18 on flexy-css-in-js into e462eefb7b7c7f658142d2f9fe47bc204ef16917 on master.

Did a beta release: https://github.com/helpscout/blue/releases/tag/v1.4.2-0
And tested locally within Beacon 2 Embed. Things are working as expected!
Gonna merge this up to unblock.
🙏


Neotest with dap strategy in very large repo causing nvim to freeze

NeoVim Version
NVIM v0.10.0
Build type: Release
LuaJIT 2.1.1716656478
Describe the bug
Apologies for the vagueness but I'm not really sure how to pinpoint this issue.
I work in a very large monorepo at work. I've previously been able to run neotest DAP with
nvim-dap without any issues to debug the application. Since upgrading neotest to version
that required neotest-nio, whenever I try to run neotest with DAP strategy my neovim freezes
and I end up having to close the tab in my terminal. I can see the neovim process at around 99%
CPU. I'm not sure if this is an issue with neotest or nvim-dap or a combination of the two. I'm also
not sure how to provide any useful information here
Logs
The log file is 1.8m lines long. A huge amount the lines have this form:
DEBUG | 2024-09-11T10:44:26Z+0100 | ...al/share/nvim/lazy/neotest/lua/neotest/lib/file/find.lua:26 | Scanning directory: path/in/monorepo

I can also see that it's scanning through e.g. node_modules that are buried within the monorepo. Is there a config option I can be setting to to make sure I don't scan the entire monorepo here?
My setup looks like this:
    neotest.setup({
      adapters = {
        neotest_python({
          args = { "-vv" },
        }),
      },
      output = { open_on_run = true },
      discovery = {
        enabled = false,
      },
    })

                                                      *neotest.Config.discovery*
Fields~
{enabled} `(boolean)`
{concurrent} `(integer)` Number of workers to parse files concurrently. 0
automatically assigns number based on CPU. Set to 1 if experiencing lag.
{filter_dir} `(nil)` | fun(name: string, rel_path: string, root: string):
boolean A function to filter directories when searching for test files.
Receives the name, path relative to project root and project root path

Checkout this


Crash in auto loading fastapi sentry plugin

How do you use Sentry?
Sentry Saas (sentry.io)
Version
1.12
Steps to Reproduce
Try and init sentry:
Sentry attempts to load fastapi.routing but fails.
Crash.
Expected Result
No crash.
Actual Result
-snip-
File "/usr/src/app/common/external/sentry.py", line 101, in initIndexer
--
_init(
File "/usr/src/app/common/external/sentry.py", line 40, in _init
_ = sentry_sdk.init(
File "/usr/local/lib/python3.9/site-packages/sentry_sdk/hub.py", line 119, in _init
client = Client(*args, **kwargs)  # type: ignore
File "/usr/local/lib/python3.9/site-packages/sentry_sdk/client.py", line 89, in __init__
self._init_impl()
File "/usr/local/lib/python3.9/site-packages/sentry_sdk/client.py", line 123, in _init_impl
self.integrations = setup_integrations(
File "/usr/local/lib/python3.9/site-packages/sentry_sdk/integrations/__init__.py", line 124, in setup_integrations
type(integration).setup_once()
File "/usr/local/lib/python3.9/site-packages/sentry_sdk/integrations/fastapi.py", line 31, in setup_once
patch_get_request_handler()
File "/usr/local/lib/python3.9/site-packages/sentry_sdk/integrations/fastapi.py", line 61, in patch_get_request_handler
old_get_request_handler = fastapi.routing.get_request_handler
AttributeError: module 'fastapi' has no attribute 'routing'

In a local shell fastapi.routing is never set, however import fastapi.routing works fine.

Hey @SimonSchick !
Thanks for reporting this. My first guess is that FastAPI has releaed an update, where the fastapi.routing module was moved. I put this on our agenda near the top.

Hey @SimonSchick  I have now tried to reproduce this but had no luck. I have used FastAPI 0.79.0 and Sentry SDK 1.12.0.
My init code is:
sentry_sdk.init(
    dsn=os.getenv("SENTRY_DSN", None),
    environment=os.getenv("ENV", "local"),
    traces_sample_rate=1.0,
    send_default_pii=True,
    debug=True,

And everything works fine.
Can you send me a minimum project where I could reproduce this?
Has your project worked before with Sentry, or has the crash appeared when upgrading Sentry?


error when building the development server

Im getting an error that is preventing me from building the development server. When I run:
cd cmd/server
go build -tags dev

Im getting the following error:
# github.com/ssbc/go-secretstream/secrethandshake
../../../../go/pkg/mod/github.com/ssbc/go-secretstream@v1.2.11-0.20221019175226-fa042d4912fe/secrethandshake/string.go:21:24: cannot use s.appKey (variable of type [32]byte) as type []byte in argument to hex.Encode

NOTE: I only received this error yesterday upon pulling in the latest changes from master in the past 5 days or so.

@chereseeriepa Opened up https://github.com/ssbc/go-secretstream/pull/21 https://github.com/ssbc/go-ssb-room/pull/353 to fix + help catch in the CI before breaking dev workflows. Hoping someone might review shortly, will merge later on tomorrow if now. If you need to move fast, you can see the fixing patch inhttps://github.com/ssbc/go-secretstream/pull/21 (and docs on how to load that into the build / go.mod in https://github.com/ssbc/go-ssb#building) :+1:

Should be fixed now, thanks for the report :heart_decoration:


DataClass object accept Json with key snake case type

DataClass only accept json with key that have the same type with table class, So if i choose to use camel case in table class like this:
class Episodes extends Table {
  IntColumn get episodeId => integer()();
  TextColumn get type => text()();
  BoolColumn get explicit =>
      boolean().withDefault(const Constant(false)).nullable()();
  TextColumn get title => text()();
  TextColumn get description => text().nullable()();
  IntColumn get duration => integer().nullable()();
  TextColumn get siteUrl => text().nullable()();
  TextColumn get imageUrl => text().nullable()();

  @override
  String get tableName => 'episodes';

  @override
  Set<Column> get primaryKey => {episodeId};
}

DataClass that related to that table only accept json with key camel case to like this:
factory Episode.fromJson(Map<String, dynamic> json,
      {ValueSerializer serializer}) {
    serializer ??= moorRuntimeOptions.defaultSerializer;
    return Episode(
      episodeId: serializer.fromJson<int>(json['episodeId']),
      type: serializer.fromJson<String>(json['type']),
      explicit: serializer.fromJson<bool>(json['explicit']),
      title: serializer.fromJson<String>(json['title']),
      description: serializer.fromJson<String>(json['description']),
      duration: serializer.fromJson<int>(json['duration']),
      siteUrl: serializer.fromJson<String>(json['siteUrl']),
      imageUrl: serializer.fromJson<String>(json['imageUrl']),
    );
  }

But some developer maybe only use camel case on dart code but json from some API (like my case) maybe use snake case. Yeah maybe i just need to use some tweak for that but since moor already give us this functionality to generate DataClass maybe is better to add option for user to choose between camel case or snake case when they use DataClass.fromJson.

You can annotate getters in your table with JsonKey to change the expected json key.


Error installing dev version in R

Project Robyn
Describe issue
I've tried to install the latest deV version from GitHub but I get the following error:
Downloading GitHub repo facebookexperimental/Robyn@HEAD
Error in utils::download.file(url, path, method = method, quiet = quiet,  :
no fue posible abrir la URL 'https://api.github.com/repos/facebookexperimental/Robyn/tarball/HEAD'
To install the version, I put this code: remotes::install_github("facebookexperimental/Robyn/R") and I've installed library remotes.
Environment & Robyn version
Make sure you're using the latest Robyn version before you post an issue.

Check and share Robyn version: actually 3.10.3
R version (Please, check and share: 4.2.1

Sorry I can't reproduce your error. Might be OS related. Have you checked this?
https://github.com/forestgeo/learn/issues/102
Please try goggle the error first

I see you're running the models already and thus closing this.


Handle decimals in k8s resource usage calculation

When one of the numerator/denominator is a number and other is bigint this was failing. decimals cannot be converted to bigints
Hey, I just made a Pull Request!
This does include some loss of precision, but I assume it's negligible enough to disregard it
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks for the fix!

@benjdlambert need an approval for the voccab changes


Not maintaining transaction isolation level when set via query

Environment

nanodbc version: 2.12.4
DBMS name/version: SQL Server 2016
ODBC connection string: driver=SQL Server;server=localhost;database=mydb;uid=test;pwd=test1
OS and Compiler: windows 10, visual studio 2017
CMake settings: ?

Actual behavior
When I execute the state SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED, then check the transaction isolation level of the session, it stays at read committed (2) when what I want is UN committed (1).
Expected  behavior
It should maintain the transaction isolation level when set via query, like it does when using other tools (e.g. the .net sql server tooling).
Minimal Working Example
#include "nanodbc.h"

int main()
{
    nanodbc::connection *conn = new nanodbc::connection(NANODBC_TEXT("driver=SQL Server;server=localhost;database=mydb;uid=test;pwd=test1"), 100);
    nanodbc::statement *statement = new nanodbc::statement(*conn, NANODBC_TEXT("SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED"), 100);
    statement->execute();
    // set a break point here and run the query below in some other tool
    return 0;
}

requires admin privs but lets you see the transaction isolation level of all active sessions
SELECT
    c.session_id, s.program_name, s.transaction_isolation_level,
    s.login_name, s.original_login_name, c.connect_time
FROM sys.dm_exec_connections AS c
JOIN sys.dm_exec_sessions AS s
    ON c.session_id = s.session_id
group by
    c.session_id, s.program_name, s.transaction_isolation_level,
    s.login_name, s.original_login_name, c.connect_time

Fixing it
In terms of fixing this, the query method shown above is preferable, but I have not been able to debug why that's not working.  I did find a workaround by setting connection attributes however.
Adding the following code in the connect function (nanodbc.cpp line 926) around line 943 will set the transaction isolation level on the connection prior to connecting and maintain it throughout the session.
NANODBC_CALL_RC(SQLSetConnectAttr, rc, conn_, SQL_ATTR_TXN_ISOLATION, (SQLPOINTER)(std::intptr_t)SQL_TXN_READ_UNCOMMITTED, 0);
if (!success(rc))
    NANODBC_THROW_DATABASE_ERROR(conn_, SQL_HANDLE_DBC);

I think this would be some sort of optional thing you set on the connection prior to connecting instead of just jamming it in there, but of course I'd still much prefer setting it with the sql statement.

This is an interesting issue and I'd like to find out what is reason of the SQL command not making the setting persist. It might be nanodbc bug, but since it is a very thin wrapper...I'd be surprised if it is. It could be driver bug/incompatibility or even database instance configuration issue, I suspect.
I haven't run any tests myself though, yet.

ODBC connection string: driver=SQL Server

This is a very old driver. Could you try with one the modern once?

ODBC Driver 11 for SQL Server
ODBC Driver 13.1 for SQL Server

It might be a good idea to avoid the version 13.0 ODBC Driver 13 for SQL Server, as I found it buggy, comparing to version 11. Bugs have been fixed in 13.1.

CMake settings: ?

This detail applies if you build nanodbc yourself, then we would like to know what CMake configuration options do you use.

When I try to install the ODBC 13.1 you linked to, my computer tells me I already have a newer version installed even though the only stuff that shows up in the list is "ODBC Driver 13 for SQL Server".  I went ahead and tried all of the installed odbc drivers on my machine and they all exhibited the same behavior.

The actual thing I was trying to do is get this updated here so it could make it's way back to an R package that uses nanodbc.  The dev for that project added something similar to your workaround and has solved our issue.  He noted that another workaround was to set the transaction level in t sql by appending that statement to the top of every query submitted.  The full details are here, and you can consider this handled.

@NickLarsen I've reopened this issue as it is worth to investigate and perhaps even cover with some tests.

This issue was moved to nanodbc/nanodbc#10


krt: optimize FilterKey

In a test of how long it takes to reconcile a massive setup:
Baseline: 16.8s https://flamegraph.com/share/8177d161-0cc2-11ef-a542-36adf59c1176
With this PR: 8.8s https://flamegraph.com/share/9af9343d-0cc2-11ef-8204-e6b38c1ccd74

In response to a cherrypick label: new pull request created: #50935


Deploy Python FlaskApp - Error calling sync triggers (BadRequest)

Does this occur consistently? Yes
Repro steps:

Clone https://github.com/Hazhzeng/functions-wsgi
Test locally - It will work
Deploy to python azure function
Got the following error

Action: azureFunctions.deploy
Error type: BadRequest
Error Message: Encountered an error (InternalServerError) from host runtime.
Version: 1.0.1
OS: win32
OS Release: 10.0.19041
Product: Visual Studio Code
Product Version: 1.51.1
Language: en

Call Stack
new RestError extension.bundle.js:46:109835
extension.bundle.js:48:167633extension.bundle.js:48:167633
processTicksAndRejections task_queues.js:94:5

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this issue has received less than 5 community upvotes and we closed it. Still a big Thank You to you for taking the time to create it! To learn more about how we handle issues, please see our documentation.
Happy Coding!


hashdos security vulnerability in QueryStringDecoder and possibly other components

<EMAIL_ADDRESS>We could limit the maximum number of decoded parameters in QueryStringDecoder and HTTP Header decoder.  We also need to review all components that uses map-ish data structure and limit its max size if they can lead to a security hole.

We actually are immune on the header decoder side because we already limit the max size of total header data.  The default is 8192, and that means at the worst case there can be only 2048 header entries, and to exploit the vulnerability the attacker should have longer header names, which means the header decoder is immune.


Pub package with multiple pubspec.yaml files

This issue was originally filed by<EMAIL_ADDRESS>
Package:
https://pub.dartlang.org/packages/clean_router
https://storage.googleapis.com/pub.dartlang.org/packages/clean_router-0.3.6.tar.gz
Error after pub get:
Pub get failed, [1] Resolving dependencies...
> clean_router 0.3.6 (was 0.3.5)
Downloading clean_router 0.3.6...
Could not un-tar (exit code 2). Error:
7-Zip (A) 9.20  Copyright (c) 1999-2010 Igor Pavlov  2010-11-18
Processing archive: C:\Users\ivan\AppData\Local\Temp\pub_7688c9bc-5391-11e4-ae72-f452b527bf87\data.tar
Extracting  .idea.name
Extracting  .idea\clean_router.iml
Extracting  .idea\encodings.xml
Extracting  .idea\misc.xml
Extracting  .idea\modules.xml
Extracting  .idea\scopes\scope_settings.xml
Extracting  .idea\vcs.xml
Extracting  .idea\workspace.xml
Extracting  .gitignore
Extracting  AUTHORS
Extracting  LICENSE
Extracting  README.md
Extracting  example\example.dart
Extracting  example\example.html
Extracting  example\redirect.dart
Extracting  example\redirect.html
Extracting  lib\client.dart
Extracting  lib\client_browser.dart
Extracting  lib\common.dart
Extracting  lib\server.dart
Extracting  pubspec.yaml
file pubspec.yaml
already exists. Overwrite with
pubspec.yaml?
(Y)es / (N)o / (A)lways / (S)kip all / A(u)to rename all / (Q)uit?
ERROR: Can't allocate required memory!
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\pub\lib\src\io.dart 890  _extractTarGzWindows.<fn>.<fn>
dart:isolate

This issue has been moved to dart-lang/pub#1169.


Refactor expert console

Refactor expert console

I think there was an error during the merge. Why I see commits from https://github.com/pastelnetwork/pastel-electron-wallet/pull/61 here?

Please see my comment above

Thanks, @br4in3x

I think there was an error during the merge. Why I see commits from #61 here?

Got it.


undefined reference to `YAML::detail::node_data::push_back(YAML::detail::node&, boost::shared_ptrYAML::detail::memory_holder)'

I got this error while running catkin build:
Errors     << mav_trajectory_generation:make /home/kadhir/catkin_ws/logs/mav_trajectory_generation/build.make.003.log
/home/kadhir/catkin_ws/devel/lib/libmav_trajectory_generation.so: undefined reference to `YAML::detail::node_data::push_back(YAML::detail::node&, boost::shared_ptr<YAML::detail::memory_holder>)'
/home/kadhir/catkin_ws/devel/lib/libmav_trajectory_generation.so: undefined reference to `YAML::detail::node_data::convert_to_map(boost::shared_ptr<YAML::detail::memory_holder>)'
collect2: error: ld returned 1 exit status
make[2]: *** [/home/kadhir/catkin_ws/devel/lib/mav_trajectory_generation/polynomial_timing_evaluation] Error 1
make[1]: *** [CMakeFiles/polynomial_timing_evaluation.dir/all] Error 2
make: *** [all] Error 2
cd /home/kadhir/catkin_ws/build/mav_trajectory_generation; catkin build --get-env mav_trajectory_generation | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -

When following the installation instructions, I first ran into Could not find a package configuration file provided by "yaml_cpp_catkin". To solve that, I ran git clone https://github.com/ethz-asl/yaml_cpp_catkin.git inside ~/catkin_ws/src, and then reran catkin build, which is when I got this error. What steps do I take to fix it? Any help would be greatly appreciated!

Fixed the error by reverting to a previous copy of catkin_ws that I had made, and following the instructions in #106


[azservicebus, azeventhubs] Updating to take in the new AMQP version.

Pulling in a new AMQP version with my fix for the "body size < frame size" that would cause to hang for 26 seconds while closing a session on a link that was idle.
Fixes #21684

NOTE to reviews: the go.mod's will be updated before merging once we release go-amqp including my latest fix. Everything else will remain the same.

/azp run go - azservicebus

/azp run go - azeventhubs


fix: generate markdown linter compliant changelog headers & lists

In #594, I missed that there are 2 places where the version header is formatted, one with dates and one without.
In this PR, I add the extra newline to make the generated changelogs markdownlint compliant when the date is included in the header.

@bernardcooke53 does this look okay?


Fix cmdline long description

Closes #2
Also ran goimports, which separated stdlib/3rdparty/project imports and
did the gofmt job of indenting things.

thank you for this fix

No problem


--enable-swift-testing doesn't work on MacOS 14.6.1

Hi Daniel,
Following your swift testing book and when I get to page 34 and try to create a package using swift testing from the command line it fails
swift package init --type=library --enable-swift-testing
error: Unknown option '--enable-swift-testing'
Usage: swift package init [--type ] [--name ]
See 'package init -help' for more information.
I'm currently running MacOS 14.6.1 is this why?

When I try running swift test from the command line in the sample package directory it tells me I need swift tools 6 and I only have 5.10. I'm currently using 5.10 for production work. Can I have two versions of swift tools installed or is there no downside of installing the beta version of swift tools?

Sorry if you’re using Xcode 16 b5 we don’t need the flag anymore. Just type swift test.You need beta 5 or above for the bookOn Aug 24, 2024, at 11:18 AM, DaveBrennanEMS @.***> wrote:
When I try running swift test from the command line in the sample package directory it tells me I need swift tools 6 and I only have 5.10. I'm currently using 5.10 for production work. Can I have two versions of swift tools installed or is there no downside of installing the beta version of swift tools?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Also I will check the book instructions to make sure I haven’t left in old information- thank youOn Aug 24, 2024, at 11:25 AM, dimsumthinking @.> wrote:
Sorry if you’re using Xcode 16 b5 we don’t need the flag anymore. Just type swift test.You need beta 5 or above for the bookOn Aug 24, 2024, at 11:18 AM, DaveBrennanEMS @.> wrote:
When I try running swift test from the command line in the sample package directory it tells me I need swift tools 6 and I only have 5.10. I'm currently using 5.10 for production work. Can I have two versions of swift tools installed or is there no downside of installing the beta version of swift tools?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Sorry, perhaps I'm not being clear:
I have Xcode 16 beta 6 installed next to Xcode 15.4
At the command line if I type swift test it tells me I need swift tools 6 and I have 5.10
If I try to init a package without the --enable-swift-testing flag I get an XCTest based set of tests
If I try to init a package with the flag it says that flag is an unknown option
How can I force the upgrade to swift tools 6 and if I do so will I still be able to use Xcode 15.4?

Daniel,
I found the answer - by default even when you’re running Xcode 16 beta 6 Xcode doesn’t set the tools to v6 - they stay on 5.10. You can fix this by going to Xcode settings//locations and setting Command line tools to Xcode-beta 16.0. IF I used the command line tools more often I guess I would have known that. Anyway I guess this won’t be a problem in a couple of weeks as we’ll all be running Xcode 16 release.
There’s a typo on page 42 - rever should be refer
I am loving the book. I really like the whole command line approach to testing - it has great promise for automation and I wasn’t aware this was available.
I look forward to seeing your workshops at iOSDevUK next week.
Dave
On 24 Aug 2024, at 16:28, editorscut @.***> wrote:
You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
Also I will check the book instructions to make sure I haven’t left in old information- thank youOn Aug 24, 2024, at 11:25 AM, dimsumthinking @.> wrote:
Sorry if you’re using Xcode 16 b5 we don’t need the flag anymore. Just type swift test.You need beta 5 or above for the bookOn Aug 24, 2024, at 11:18 AM, DaveBrennanEMS @.> wrote:
When I try running swift test from the command line in the sample package directory it tells me I need swift tools 6 and I only have 5.10. I'm currently using 5.10 for production work. Can I have two versions of swift tools installed or is there no downside of installing the beta version of swift tools?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>
—
Reply to this email directly, view it on GitHubhttps://github.com/editorscut/ec016swifttesting/issues/2#issuecomment-2308430640, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AV7GQYZWY2PMRGJR472ZKGDZTCRAJAVCNFSM6AAAAABNBVNFQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYGQZTANRUGA.
You are receiving this because you authored the thread.Message ID: @.***>


Update glam dependency to 0.19

Checklist

[x] cargo clippy reports no issues
[x] cargo deny issues have been fixed or added to deny.toml
[x] relevant examples/test cases run
[x] changes added to changelog

[x] Add credit to yourself for each change: Added new functionality @githubname.

Problems PR Solves
Update glam to latest 0.19 version
Related Issues

I uh, snuck in few fixes for the previous camera view commit that I noticed while going through the checklist here 🤦