Dev fix multi pane feature 20210823

Type of PR:
PR checklist:

[ ] Addresses an existing issue: fixes #
[ ] Includes tests
[ ] Documentation update

Overview of change:
Is there anything you'd like reviewers to focus on?

Merge to master


Backlight control requirements

According to contact with a variety of screen backlight control, can be classified as the following:

GPIO Control

High and Low Levels:
The backlight is controlled by a GPIO pin directly, where setting it to high turns on the backlight, and setting it to low, turns it off, Or vice versa
PWM Signal Control:
The backlight is controlled by a GPIO pin generating a PWM signal, with the brightness adjusted according to the duty cycle.

Control via I2C Chip like custom MCU or IOExpander

The brightness (0x00~0xFF) is adjusted by writing to a specific register of the backlight control chip via the I2C bus.

Control Process: The MCU communicates with the backlight control chip over I2C and writes the brightness value to a specific register address.

Control via QSPI or MIPI-DSI or others

The brightness (0x00~0xFF) is adjusted by sending the value to a specific register via the QSPI or MIPI-DSI protocol.

QSPI: Uses high-speed serial communication to write to the register.
MIPI-DSI: Typically used with integrated display control, enabling direct backlight brightness control through the MIPI protocol.

so, i know you have the plan to implement backlight control next. Maybe you can consider the above several types of backlight control scheme? Please let me know if you need anything

Hi @Y1hsiaochunnn,
Thank you very much for your suggestions. They are extremely comprehensive. Although I haven’t encountered the last method using QSPI or MIPI-DSI protocols for control.
I also realize that the current library’s approach to backlight control, using Switch (GPIO) and PWM (LEDC) methods, doesn’t meet the requirements of many development boards. Therefore, I am restactoring this library and plan to introduce a Custom method on top of the Switch and PWM methods to accommodate different development board requirements. The expected updated configuration file is as follows:
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////////////////// Please update the following macros to configure the backlight ////////////////////////////
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
#define ESP_PANEL_USE_BACKLIGHT         (1)         // 0/1
#if ESP_PANEL_USE_BACKLIGHT
/**
 * Backlight control mode. Choose one of the following:
 *  - ESP_PANEL_BACKLIGHT_TYPE_SWITCH_GPIO: Use GPIO switch to control the backlight, only support on/off
 *  - ESP_PANEL_BACKLIGHT_TYPE_PWM_LEDC:    Use LEDC PWM to control the backlight, support brightness adjustment
 *  - ESP_PANEL_BACKLIGHT_TYPE_CUSTOM:      Use custom function to control the backlight
 *
 */
#define ESP_PANEL_BACKLIGHT_TYPE        (ESP_PANEL_BACKLIGHT_TYPE_PWM_LEDC)

#if ESP_PANEL_BACKLIGHT_TYPE != ESP_PANEL_BACKLIGHT_TYPE_CUSTOM
/* IO num of backlight pin */
#define ESP_PANEL_BACKLIGHT_IO          (47)
#define ESP_PANEL_BACKLIGHT_ON_LEVEL    (1)         // 0: low level, 1: high level
#else
/**
 * @brief Custom backlight control function
 *
 * @param[in] percent   Brightness percentage, 0-100
 * @param[in] user_data User data, default is a pointer of `Board`
 *
 */
#define ESP_PANEL_BACKLIGHT_CUSTOM_FUNCTION( percent, user_data )  \
    {  \
        Board *board = static_cast<Board *>(user_data);  \
    }
#endif /* ESP_PANEL_BACKLIGHT_TYPE */

/* Set to 1 if you want to turn off the backlight after initializing the panel; otherwise, set it to turn on */
#define ESP_PANEL_BACKLIGHT_IDLE_OFF    (0)         // 0: on, 1: off

#endif /* ESP_PANEL_USE_BACKLIGHT */

Great! I'm looking forward to it.

Hi I have changed the settings in esp32_s3_touch_lcd_7.h as followed
#define ESP_PANEL_USE_BACKLIGHT         (1)         // 0/1
#if ESP_PANEL_USE_BACKLIGHT
/* IO num of backlight pin */
#define ESP_PANEL_BACKLIGHT_IO          (2)
#define ESP_PANEL_BACKLIGHT_ON_LEVEL    (1)         // 0: low level, 1: high level

/* Set to 1 if turn off the backlight after initializing the panel; otherwise, set it to turn on */
#define ESP_PANEL_BACKLIGHT_IDLE_OFF    (0)         // 0: on, 1: off

/* Set to 1 if use PWM for brightness control */
#define ESP_PANEL_LCD_BL_USE_PWM        (0)         // 0/1
#endif /* ESP_PANEL_USE_BACKLIGHT */

the I am trying to disable the backlight, but it does nothing
   ESP_PanelBacklight* backlight = panel->getBacklight();
   backlight->off();

Is that correct or do I missing something?

According to Waveshare's product schematic, the LCD power supply is controlled by the EXIO6 of the IO expansion chip. You can try calling the CH422G call, which is very common.
According to @Lzw655 , the library should now be able to control the backlight with an io extension chip in a future v1.0.0 release, which is partly why I opened the issue. It's the same thing we wanted


Separated touch and mouse delay options

Hi!
Forgive me, this is my first pull request, so I'm not accustomed to the process. Also many thanks for this project as I would currently be lost without it.
My research leads me to believe that mobile detection isn't very reliable, and if possible the best solution is to handle both touch and mouse events. I've been using this backend for both touch and mouse devices. The only issue I've run into is that a single delay option isn't suitable; with the mouse you expect drags to start immeidately, but on touch devices an immediate drag interferes with scrolling.
I've just made it so separate delays can be specified for the touch and mouse drag start events. Now this backend can use a single configuration to handle both types of user controls intuitively.

Need this PR in master :)

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

CLA is valid!

👍

@alexandercrichton left a couple of comments

Thanks @longlho! Still learning this PR business. I gather my last commit is now part of this PR?
I've tidied up your first comment and retained support for the original delay option

@alexandercrichton looks good :) 1 last step is to squash the 2 commits (git rebase -i HEAD~2) then I'll merge

Ok I think I've done that right

👍


pylint use with multiple files open in GUI ends up becoming unusable

From<EMAIL_ADDRESS>on 2010-09-14T14:03:00Z
What steps will reproduce the problem?

Open multiple python files.
Run pylint on different files.
Close some files and continue to pylint some files.
At some point the PyLint Panel will "randomly" choose one of the other
open files (not the active tab) and run PyLint on that file instead.  I've also seen it choose files that are no longer open.  It's really not random, it's based on the way the GUI operates on an internal array of data. What is the expected output? What do you see instead? PyLint the active tab, not one of the other tabs or a closed file. What version of the product are you using? On what operating system? Spyder 2.0.0beta3, python 2.6.1, Windows XP

Please provide any additional information below
. I've detailed information about this in ticket 144 and 145 in the past.  It ended up getting closed but there was never a resolution to this issue.  I previously submitted a patch, but it must have never gotten integrated.  Ticket 144 claims to have fixed this issue, but it must have not as the issue still persists.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=360

From<EMAIL_ADDRESS>on 2010-11-18T13:35:35Z
Is there any chance this can get fixed for the final version of 2.0.0?  I'd really like to see this happen.

From pierre.raybaut on 2010-11-18T13:37:48Z
Absolutely, I completely forgot about it.
I'll have to try and reproduce the bug and then I'm on it.
Status: Accepted
Labels: Milestone-Release2.0

From pierre.raybaut on 2010-11-23T10:40:45Z
This issue was closed by revision d2a1354da6 .
Status: Fixed

From pierre.raybaut on 2011-04-24T07:37:30Z
This issue was closed by revision d2a1354da6ef .


fix : requesting invoice with any amount and cleans code

Removes the numberpad and button and adds the feature of requesting payments with having 'any' amount.
Potential fix : #134

Just come git comments

Removes the numberpad and button and adds the feature of requesting payments with having 'any' amount.

Usually these are two commits
One for remove the button and the numberpad, and the other one for fixing any invoice


[WIP] Add cuda_convnet local-connected wrapper.

TODO:

[ ] need to finish the tests. They compare again the old results. We need to add the expected value in the new case.
[ ] code clean up

Is it intended to replace the implementation in pylearn2/packaged_dependencies/theano-linear/unshared_conv/?


Keep workaround for package-list

Some tools (like Dokka) require package-list still. This isn't generated by the version of Java we use to build Gradle.
We copy element-list to package-list to keep these tools working.

@bot-gradle test and merge

I've triggered a build for you.


Atom type name issues for GB

In parameterizing a molecule for simulation with GB, I am running into this problem:
Traceback (most recent call last):
  File "tests/test_alchemy.py", line 578, in <module>
    test_systembuilder_lysozyme_pdb_mol2()
  File "tests/test_alchemy.py", line 533, in test_systembuilder_lysozyme_pdb_mol2
    print "%s has %d particles" % (name, thing.system.getNumParticles())
  File "/Users/choderaj/code/yank/install/lib/python2.7/site-packages/yank-0.9.0-py2.7.egg/yank/systembuilder.py", line 176, in system
    self._create_system()
  File "/Users/choderaj/code/yank/install/lib/python2.7/site-packages/yank-0.9.0-py2.7.egg/yank/systembuilder.py", line 164, in _create_system
    self._system = forcefield.createSystem(self._topology, **self.system_creation_parameters)
  File "/Users/choderaj/code/yank/install/lib/python2.7/site-packages/simtk/openmm/app/forcefield.py", line 507, in createSystem
    force.createForce(sys, data, nonbondedMethod, nonbondedCutoff, args)
  File "/Users/choderaj/code/yank/install/lib/python2.7/site-packages/simtk/openmm/app/forcefield.py", line 1245, in createForce
    raise ValueError('No GBSAOBC parameters defined for atom type '+t)
ValueError: No GBSAOBC parameters defined for atom type MOL-C1

For the near term, I believe we have decided that users must go through AmberTools for setting up GB simulations.

Correct.  Is it all right if I create an issue to remind me that we need to add an AmberGBSAGenerator in the future?

We already have an issue on the OpenMM tracker, so why not leave it at that.
I think the issue tracker should be reserved for things that we have plans to fix on some finite timescale, as otherwise it becomes impossible to triage tasks effectively.

I believe labels and target releases can be used for this purpose.

Also, we already have code for this---we just have to move it from our gbff project.  So I don't think it's unreasonable to say this can be done on a finite timescale.

It's not clear to me that the code even belongs in this repo.

Eventually, there are a number of things (like this) that belong in the OpenMM repo, but we can't put unstable code in that repo since it is a stable codebase that many people use.  Putting it here is logical, since without it, you can't use small molecules with GB.

We can use the AmberTools pipeline, though.  I personally think we should deprecate the ffXML pipeline for small molecules because we do not have enough software engineers to maintain more our own forcefield codebase.
Again, you are free to do what you like here--I'm just giving my advice on how we can get science done given the limited number of developer-hours that we have.

This sounds like a larger discussion best had in person.


Add ic-pos to motoko examples

Overview
This PR adds the ckBTC Point of Sale example app (Motoko) to the repository. The original repo can be found here: https://github.com/kristoferlund/ic-pos

IC-POS is an experimental app to demonstrate a real world use case for ckBTC on the Internet Computer. It is a simple Point of Sale app that allows users to accept ckBTC payments.

For more details about IC-POS, see the README.

hey @kristoferlund , thank you for adding this example! very happy to see community contributions 🎉
i'll create PRs for potential changes in your repo instead of on this PR. do you have a good flow in mind to keep this example updated with future changes from the upstream repo?

@kristoferlund see here
https://github.com/kristoferlund/ic-pos/pull/4

Looks great @letmejustputthishere, thanks! Have been on vacation but am back in business now. I'll take a closer look and merge the coming days.
I have not considered a good flow keeping the main repo and dfinity-examples in sync. Don't know to what extent that is possible. As I am not planning any more development on ic-pos for now, this time I will copypaste your changes between repos.

@kristoferlund if you merge this with upstream i think we are good to go :)
are there any changes that need to be done here https://github.com/dfinity/portal/pull/1892?


Generate docs for components from mjml.io

Idea from @psugihara:
The biggest pain point I see with the package is documentation. My process is looking at mjml docs then kind of guessing on props or looking at the source code for each component. I think there’s a good argument for keeping mjml docs as the source of truth but I wonder if there’s some way of generating docs for the components or even adding.

generated from this workflow: https://github.com/mjmlio/mjml/blob/master/.github/workflows/build-documentation.yml
Collects all the package readme.mds and concatenates them.
2 options I see

Move the parsing work upstream by adding jsDocs to the components and writing a pre-processing step that generates the readme from the component documentation.

Benefit:

easier to manage documentation in mjmlio/mjml (adding a prop and updating docs happen at the same place)
less fragile than a script to read from the readme.md files

cons:

probably more work
requires upstream collaboration

Parse the readme files to extract the prop values.

Pros:

relatively easy to get 80% completion

Cons:

most likely brittle
getting to 100% completion will be very difficult

@emmclaughlin (and other) any thoughts on these or other options you would propose?
@iRyusa I'd be interested in hearing your thoughts on this as the upstream library maintainer


added python script for combining git shortlogs across multiple repos#19044

https://github.com/zulip/zulip/issues/19044
Running the script through terminal commands

Made those changes through another commit

@ericluoliu it would be great if you could post an example of the output.

Running bash command:
$ python3 totalContributors.py 3.0 | sort -nr
Produces the given output

Strange. Why aren't the highest committers not shown first? Should look like this
  1017        Anders Kaseorg
   634        Steve Howell
   403        Tim Abbott
   ...

Also, I noticed that you didn't specify the version for the latest release, say, current_version, and set the timestamp of this version as the boundary for other repos. The fact that it is not specified means that the commits go all the way to today, not the most recent release.

The output looks correct to me. I only posted the bottom of the output because the list is too big but if I scroll up the top matches similarly to what you have.

Sorry can you explain what you mean by the commits go all the way to today rather than the most recent release. I just set version 4.3 as the default if the user doesn't specify a version so wouldn't the commits go to this version date?

AFAIK "Rishi Gupta" hasn't contributed to any of the repos since 4.3, which means that your shortlog somehow includes commits that are far older than 4.3.

I just set version 4.3 as the default if the user doesn't specify a version so wouldn't the commits go to this version date?

If you look at the original command, it specifies a range of versions, not just 1 version:
git shortlog -s 3.0..4.0 | sort -nr

Oh, then I must have misunderstood the original issue. I was under the impression that you just wanted a version number and all the contributors from before that version. Can you confirm that my new understanding is correct: we are supposed to have a range of versions e.g. 3.0..4.0 and the contributors list are all the people who contributed within this time frame?

Yes, that's correct.

Made the changes
python3 totalContributors.py 3.0..4.0 | sort -nr

The numbers differ slightly because I pull from multiple repos. When the user does not give any arguments I set the default as 1.3.0..4.3

@ericluoliu can you fix the CI failures in this PR, and write a proper commit message?
It'd also be nice to add tests for it to the tools/tests test suite, if we can figure out a reasonable way to do it (Perhaps the tests have a fixture file with some example git shortlog output, and can verify the merging logic that way?)

I have been wondering if the script should be put in a separate repo, because it can be used by other projects. But I don't know of any other FOSS projects that list contributions every time they release. This is just a thought. It is fine to just put it in zulip/zulip for now.

@timabbott I fixed the CI failures and added a [--help] [-h] method but fixing my previous commit messages is giving me a bit of trouble. I am trying to use git rebase -i HEAD~5 to change "pick" to "reword". Supposedly when I run this command, a text document should open with my previous 5 commits but when I run this command, the 5 commits show up in the terminal instead and I do not know how I could change and save that. Any ideas? Thanks!!

Can you take a screenshot of your terminal screen? The default editor is probably nano, which always lists the keyboard shortcut in the screen, i.e. ctrl-x to save IIRC.

Here's what it looks like. It gives a list of commands but I am not sure how to use any of them. When I change pick to reword nothing really happens.

What is the output of echo $EDITOR? What is your OS?

Mac OS. echo $EDITOR doesn't give me any output. Or at least it seems empty.

Those tildes on the screenshot looks like vim. If you want to make it default to nano, try https://unix.stackexchange.com/questions/501862/how-can-i-set-the-default-editor-as-nano-on-my-mac. Make sure to test it by doing echo $EDITOR after restarting your terminal. If you want to stick to vim, you should save-quit by doing :wq (you can look this up on the internet).

Got it, thanks for the pointers!
I ran into a few problems the other day with the git and the Zulip repository and I ended up deciding to delete my local repository and re-fork it and clone everything again. Do you think it would be possible to create a new PR for this issue to have a clean slate or would it be better to find a way to rename these commits to keep the record?

Making a new PR works, but it is a useful skill to be able to rename commits and squash them as well.

Yeah, you are right. I am just going to create a new PR for this one though because I no longer have the local-branch "total-contributors" that I was previously working on.


Add option to omit xterm-style -e flag for terminal program's commands output by handlr get --json

When getting the command for a terminal program, an -e flag is always inserted between the terminal emulator's command and the program's command. This can mess things up for terminal emulators that either do not use it or do not use it in the same manner that terminal emulators such as xterm do.
For the purposes of not breaking compatibility, this may have to either be a command-line or config file option or put off until the next major release.

On second thought, this might be best implemented as a config option that allows one to specify whatever flags/subcommands their terminal emulator requires to launch a program, probably defaulting to -e. This way, this works for terminal emulators that neither support -e nor have the appropriate flags/subcommands in their respective .desktop file.


Search broken is broken after TC 2020.1 upgrade

After TC 2019.1.2 to TC 2020.1 upgrade, I don't see the search field, which causes to scroll long list if there is large list of items.
TC 2019.1.2

TC 2020.1

I just upgraded from 2019.2.4 to 2020.1.1. We are using version 1.7.0 of the plugin. The search box is there for a list with 30 entries.

@ogerovich Even with a smaller list of items we are seeing the same behavior.

TC 2020.1.2, Plugin version is 1.7.0


fix(sdk.ts) - error handling

REASON:

Using optional chaining ensures that if response.error is undefined or null, the code won't throw a runtime error. Instead, it gracefully checks whether error exists before attempting to access its type property.

ACTUAL CHANGE MADE:

fix from

if (response.error.type === 'rejected_by_user') {
        throw new SignIn.RejectedByUser()
      }

to

  if (response.error?.type === "rejected_by_user") {
        throw new SignIn.RejectedByUser();
      }

other same fixes in file sdk.ts to handle type of error.

Hi @deodad
Feel free to let me know if you have any questions regarding this PR


feat(NumberTheory/SmoothNumbers): multiplicativity

Prove that the product of two n-smooth numbers is an n-smooth number. Uses two helper lemmas.

Thanks for the improvements. I'm learning.

Here it is!

LGTM

awaiting-author

I would like to deal with the comments in a sequential way, not the least in order to preserve the optimization steps that were done.

@MichaelStollBayreuth
I have flagged the PR as WIP, to signal that there is an alternative (and mathematically cleaner) way to do this. I will now open a new branch for that work. Once that is done and merged, this one should be closed.


AO-14040: Limit the size of the RPC requests

This PR enforces a limit against all the RPC channels to the collector.
See https://swicloud.atlassian.net/browse/AO-14040

Codecov Report

Merging #122 into master will decrease coverage by <.01%.
The diff coverage is 79.62%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   83.74%   83.73%   -0.01%
==========================================
  Files          35       35
  Lines        4300     4341      +41
==========================================
+ Hits         3601     3635      +34
- Misses        591      598       +7
  Partials      108      108

Impacted Files
Coverage Δ

v1/ao/internal/config/config.go
87.18% <ø> (ø)
:arrow_up:

v1/ao/internal/reporter/reporter_grpc.go
68.93% <100%> (+1.28%)
:arrow_up:

v1/ao/internal/config/reporter.go
100% <100%> (ø)
:arrow_up:

v1/ao/internal/reporter/methods.go
87.56% <68.57%> (-4.46%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0876763...14ac2b5. Read the comment docs.


Vgk next game

Added the game time in PST. Changed the colors a little bit to differentiate information.

Merge conflicts on this one. Please rebase on master.


View.center seems not work

Actually, as https://openlayers.org/en/latest/apidoc/module-ol_View-View.html says and as https://openlayers.org/en/latest/doc/tutorials/bundle.html show, View.center should accept an array like [5, 45]
To Reproduce
Steps to reproduce the behavior:

Simply test with https://openlayers.org/en/latest/doc/tutorials/bundle.html
Change

 center: [0, 0], zoom: 0

by something like
// longitude 5.72, latitude 45.17 : you must be in France Alpes, in Grenoble city
 center: [5.72, 45.17], zoom: 11

Result : your are not in France Alpes !
Tested today, either with the last npm version of ol : 5.3.0
Note: it works well with
            center: proj.fromLonLat([5.72, 45.17]),
            zoom: 11

Thanks in advance ;-)

If you have a suggestion to improve the documentation to make it clearer that the center is to be provided in view coordinates, a pull request would be greatly appreciated.

i mean, the docs are extremely unclear. coordinates are never well defined, and they way they have to be transformed from projection to projection is never said outright. and then on top of that there's no working example of a transformation. and then worse, completely out of step with everyone else it's LonLat intead of LatLon.
there are a lot of things here that need to be said up front instead of implied and implicit.


Make delete cache public

For https://github.com/the-blue-alliance/the-blue-alliance-ios/pull/187

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   93.05%   93.05%
=======================================
  Files          15       15
  Lines        2058     2058
=======================================
  Hits         1915     1915
  Misses        143      143

Impacted Files
Coverage Δ

TBAKit/TBAKit.swift
92.3% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b361e2...0313836. Read the comment docs.


Narwhal emoji

Narwhal, the unicorn 🦄 of whales 🐋 U+1F40B, 🐳 U+1F433, 🐬 U+1F42C.
Petitions

change.org: Narwhal
change.org: Narwhal

Font Awesome has a Narwhal pictograph.


Avoid Circular Deps with MRIReco v0.7

Closed because avoid-circular-deps is meant to be merged to master


Add a skeleton generator structure

Reason/Context
At the moment it takes a lot of effort to set up new language support.
A code skeleton with the bare minimum would help along way.

Still relevant.

@jonaslagoni @magicmatatjahu i would like to work on this issue 😊

@jonaslagoni @magicmatatjahu i would like to work on this issue 😊

Great @ritik307! Feel free to ping us if have any questions.


Test Issue

test

stgsdg

sdgsd

sfsdfsdf

sdfsdf

sdfsdfg

dgfhdfghd

asdfasdf

sdfasdf

asdfasdf

asdfasdf

sdfgsdfg

rrfgsdfg

asdfasdf

werwer

sdfgsdfg

asdfasdfasdf

asdasdfadfadsfasdf

asdasdf

asdasdf

asdfasdf

adsfasdfasdf

sdfgsdfg

טרגדגכי

שדגשגכשדגכ

שדגכשדגכ

שדגכשדגכשדגכ

שדגכשדגכשדגכ

asfasdfasdfasdf

sdfasdf

fdsafdasdf

asdfasdfasdf


Upgrade to tc-platform 5.3.0-pre2

test this please

test this please

ah ah! artfact were missing :)


Update astropad to 2.2.3

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 0e22b7d8ec7c0dbce75646a2de86fa55e2a07c03. Your contribution is still credited to you.


Save as broken

Looks like your last update broke something.

We're using the same library:
import {saveAs} from 'file-saver';
...
 saveAs(f.blob, f.name);

Sorry about that. Obviously my tests are not good enough.
Will fix it as soon as possible.

thx

Fixed with v0.14.
In fact it was just the wrong import of file-saver.


[Dev Experience] Add dev container configuration for GitHub Codespaces

Motivation
I would like to propose adding a dev container configuration for GitHub Codespaces. This would make it easier for developers to set up their environment and work on the project without much hassle and effort. Setting up the project for the first time requires CMake, Docker, node, yarn, awslocal protoc and other tools. However, installing and configuring these tools manually can be time-consuming and error-prone, especially for new contributors or low-end machines.
Solution
It would be nice to have a dev container configuration for GitHub Codespaces that would automate the setup of the development environment and provide a consistent and reproducible experience. This would make contributing to the project easier as it would:

Lower the barrier to entry for new contributors due to the ability to quickly spin up a fully set up environment and focus on making a contribution instead of spending hours trying to get the right version of some tool installed.

That sounds like a good idea!

Okay! I'll get started on it.


[CARBONDATA-3905] NPE due to null length while querying in Presto

Why is this PR needed?
NPE due to null length.
What changes were proposed in this PR?
Handled the same
Does this PR introduce any user interface change?

No
Yes. (please explain the change and update document)

Is any new testcase added?

No
Yes

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4774/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3016/

@akkio-97 : Please update the description. why null length is coming and what is the scenario

@akkio-97 : Please update the description. why null length is coming and what is the scenario

done

LGTM


feat(ingest/metabase): Allow to configure a different url for links

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 any chance you may have a look at this? :pray:


Compute eigenvalues  to determine if a matrix is positive definite

Some Hessians that are singular are currently not filtered out in is_posdef by using the Cholesky factorization because of numerical reasons. For example, the problem HS51 in the MM test set is clearly singular, but is_posdef still returns true.
A more robust (although more expensive) approach is to directly ensure that all eigenvalues are positive.


Redisson throw out of memory

We are running the application while using Redisson to read and write values and after a while the memory utilization of the application grows incrementally and then it throws out of memory
Expected behavior
No Memory leaks.
Actual behavior

Application threw out of memory and after analyzing the dump file, Redisson is found to consume the largest portion of the memory
-
and this screenshot also give more details about the Redisson objects

Steps to reproduce or test case
Redis version
5.0.5-1
Redisson version
3.15.0
Redisson configuration

Two issues related to AsyncSemaphore memory leak there resolved since then.
https://github.com/redisson/redisson/issues/4215
https://github.com/redisson/redisson/issues/3703
Please update to the latest version


Read from relay

Implementation of reading events from relays

Have you done any work on this PR? I might start working on this if you don't mind.

I finished this one. Can you please give me write access so I can push changes for this PR

@kriptonix To which repo are you trying to push? I'm checking the permissions and you should be able to create a PR from your own (forked) repo.


Colourful Pendulum

Community Contribution
Link to live project, video, or image:

Sharing

[ ] I would be happy to have my project shared on The Coding Train's social media!

Instagram:
Twitter:

Duplicate of #3069


network: Support more IP and netmast formats

In order to get Clear Containers 2.1 working, we have to accept
slightly different formats from what we were previously expecting
regarding the netmask and the destination IP of a route.
About the routes, we now accept the destination IP without the
netmask attached, meaning the agent has to find it and concatenate
it to the IP provided.
About the interfaces, if the netmask is in IP format <IP_ADDRESS>
for instance, the agent will ignore it and will rely on the IP
address to determine the netmask in decimal format.
Fixes #40

Tested with 2.1 and 3.0. Both are working fine.


MagicNumber rule throw report for null initialized variable

Code below
private var pair: Pair<String, Int>? = null
will broken by MagicNumber rule.
Is that an expected behaviour?
I could prepare PR

Nope it should not.

I have a fix ready, waiting for #275 to be merged to open a PR for that. It's one of many bugs in MagicNumber, which was added in the RC phase IIRC. Use M13.2 for now!

Cool thx for the report and fixes. Will try to review everything after I'm home and have a laptop :). I flied over your fix @rock3r. Remove the wildcards ;)

...done :) I think I'll need to do a PR to make sure the IDE project settings are consistent with your code style, cause that was the IDE :D

There is a code-style.xml in this repo if your working with intellij :)

Can this one be closed now that #278 is merged?

I will add a test case for this and close it together with #280 :+1:

This seems to be triggered for 'true' and 'false' too.

It was addressed in #278


How to initialize swiper without swiper-slide class

I use directive style approach to initialize the swiper, but the swiper is only working if I apply swiper-slide class to the swipable elements. That sets a limitation to what can be passed to swiper as children elements. Is there any way to tell swiper what to slide by reference or in some other way?

API Namespace  slideClass
e.g.

slider 1

slider 2

slider 3

swiperOptions: {
  slideClass : 'my-slide'
}

Hm...ok, but my question was more about whether I can use another mechanism of getting items rather than specifying a class?
I would like to iterate items in the slider outside the component and pass generated code inside swiper via slots. With the current logic, everyone that will use swiper should always specify a class on the generated markup, so I would like to somehow escape this limitation


A way append to svelte-kit package's exports output.

Describe the problem
svelte-kit package's current implementation does not export components if I've included exports in my package.json.
Describe the proposed solution
I propose making appending exports to be the default behaviour, since if I don't want svelte-kit package to touch my exports I can just do exports:{ exclude: ["**"] }.
Alternatives considered
Scripting to add a custom export after svelte-kit package is done running.
Importance
would make my life easier
Additional Information
No response

Why would you add exports to your package json when you don't want these to be the ones appearing in you package? The current logic is "if the user defined something there, they did that to manually specify it and don't want it changed"

I want the exports I add to the package json in addition to the ones that svelte-kit generates. Unless I'm missing something, the current logic says "if the user defined some there, do not generate any other exports at all".

Yes that's the case currently. What's the use case for additional exports the generated ones don't add?

Convenience exports.
For example, for a long path like "./components/Input/Password": "./components/Input/Password/index.js", I might have a convenience export with "./Password". This allows you to import Password from "package/Password" rather than import Password from "package/components/Input/Password".
Maintain compatibility after refactor.
For example, if I moved "./components/Input/Password" to "./components/Password", in order not to break downstream users, I would include a custom export "./components/Input/Password" pointing to the new location.

I still think 'merge' should be the default. As @ًdummdidumm hinted at above, I wouldn't put anything in my package.json if I expected svelte-kit package to replace it.
Are the any use cases for the 'replace' behaviour?
I doubt switching to the 'merge' behaviour breaks any projects/setups.
Given that we're in beta, and that svelte-kit package is still pretty young, I think this "breakage" is acceptable. Others here may have other thoughts.

This would be thoroughly explained in the docs later, but the replace value there is referring to our current behavior

"if the user defined something there, they did that to manually specify it and don't want it changed"

We could arguably come up with a better option name than replace, but I think it's clear enough (with some docs) that "existing config in package.json will replace svelte-kit generated exports"
Also, this shouldn't break anything as the old options are still there. I'll leave this open for some time before I open a PR, in case others have another approach, and in case no one beats me to the PR.


CVE-2018-21234 in Hive 3.1.2, should upgrade to 4.0.0

Describe the bug
CVE-2018-21234 in Hive 3.1.2
To Reproduce
See also https://issues.apache.org/jira/browse/HIVE-25054
Expected behavior
Upgrade to Hive 4.0.0
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hive has been upgraded to 3.1.3. Hive 4.0.0. is still in alpha.

Hello @jnturton , Hive 3.1.3 is vulnerable to CVE-2018-21234.
Please see the pom.xml of Hive 3.1.3:
<jodd.version>3.5.2</jodd.version>

And, please see Jodd version 3.5.2 is still vulnerable to CVE-2018-21234: https://nvd.nist.gov/vuln/detail/CVE-2018-21234
Because Drill -> uses Hive 3.1.3 -> uses Jodd 3.5.2 that is vulnerable, thus, Drill is vulnerable to CVE-2018-21234.
Could you please reopen? Should I create a new defect?

Ah, thanks. I guess we'll have to wait for a bug fix release or the release of 4.0.0 then.


Dropdown not to show up when an item has been added using showDropdow…

…nIfEmpty

Codecov Report

Merging #226 into master will decrease coverage by -0.01%.
The diff coverage is 80.55%.

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   65.16%   65.15%   -0.01%
==========================================
  Files          15       15
  Lines       33616    33616
  Branches      125      126       +1
==========================================
- Hits        21905    21904       -1
  Misses      11638    11638
- Partials       73       74       +1

Impacted Files
Coverage Δ

...omponents/dropdown/tag-input-dropdown.component.ts
75.59% <ø> (-0.2%)
:x:

modules/components/tag-input.ts
77.34% <100%> (-0.31%)
:x:

modules/components/tag/tag.component.ts
67.44% <50%> (ø)
:white_check_mark:

...ponents/tag-input-form/tag-input-form.component.ts
76.78% <80%> (ø)
:white_check_mark:

modules/components/pipes/highlight.pipe.ts
65% <83.33%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1bf0d3...1654919. Read the comment docs.


Introduce wildcards support for aws_s3 input

Hey there 😃
TL;DR: It would be great to introduce wildcards support for the aws_s3 input.
LONG:
I'm trying to read from an aws_s3 inputs a bunch of csv in a bucket+prefix with a csv codec (codec: "csv:|")
I noticed that I am able to do that only if in the specified prefix there are only *.csv files
The problem is that, because I am generating those files via spark, I often get also a _SUCCESS file or other meta stuff

With wildcards we could easily specify a prefix like bucket/prefix/*.csv

For anyone looking at this issue, a temporary fix suggested by @Jeffail is the following:

If the files are small enough to process them in-memory then use all-bytes and then add a processor that removes the messages from _SUCCESS files before parsing it as CSV, something like this should work:

pipeline:
  processors:
    - bloblang: |
        root = if meta("s3_key").has_suffix("_SUCCESS") {
          deleted()
        } else {
          content().parse_csv()
        }


downgrade go-ethereum

#3  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @berdim99 and the rest of your teammates on  Graphite


fix the problem with complex observable error handling

fix complex observable error estimation problem.
Close #11

Codecov Report

Merging #12 (21b8add) into master (0575fc0) will decrease coverage by 1.67%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   60.59%   58.91%   -1.68%
==========================================
  Files           8        8
  Lines         670      628      -42
==========================================
- Hits          406      370      -36
+ Misses        264      258       -6

Impacted Files
Coverage Δ

src/montecarlo.jl
55.83% <46.15%> (+0.46%)
:arrow_up:

src/utility/color.jl
7.69% <0.00%> (-4.81%)
:arrow_down:

src/sampler.jl
48.22% <0.00%> (-3.73%)
:arrow_down:

src/variable.jl
75.90% <0.00%> (-1.37%)
:arrow_down:

src/updates.jl
96.10% <0.00%> (-0.29%)
:arrow_down:

src/utility/utility.jl
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0575fc0...21b8add. Read the comment docs.


key format in Pear API update messages

According to docs,
1- Pear.updates should send a version object with a key that takes the format <String(hex)> docs
2- Pear.versions should send a key with format <Buffer> (https://github.com/holepunchto/pear-docs/blob/main/reference/pear/api.md#pearversions-object)
3- Pear.config should send a key as an object with format { z32: <String>, hex: <String>},(https://github.com/holepunchto/pear-docs/blob/main/reference/pear/api.md#pearconfig-object)
At the moment,
1- Pear.updates sends a key with different format depending on if it's an App update or a Platform update:

Platform updates: <String(z32)>
App updates: <String(hex)>

2- Pear.versions sends  an object that contains a key with format:

Platform updates: <String(z32)> or String(path_to_repo) if we are in localdev
App updates: <String(z32)>

closing for backlog


CI: Address TODO regarding a single failing rake suite test when JRuby is used

In November 2022 we started testing with JRuby v<IP_ADDRESS> and noticed several issues with our rake multiverse test suite.
With #1651, most of these issues were fixed by updating test/multiverse/suites/rake/Envfile to insist that rack v3+ be used for the tests when JRuby v<IP_ADDRESS> is in play (JRuby v<IP_ADDRESS> identifies itself as Ruby 3.1).
However, one single failure persisted and was updated to skip JRuby testing. This is the test_records_transaction_trace test specified by test/multiverse/suites/rake/rake_test.rb.
We should get to the bottom of why that test fails with JRuby.
NOTE that the test does not appear to ever fail locally and requires the GitHub Actions tech stack to reproduce the problem

this one has been rolled into #1663


Implement sub-map functionality

This includes sub-map working with n-of-1 (pivot transfers to new sub-map)

Requested again at presentation 2/28/2018.

This could be implemented along with #79, submaps, and maybe add it to the highlight attrs & nodes, #32


tvOS 12 and Xcode 10 errors and crashes

Have you experienced any issues running a TVMLKit (and specifically TVDML) on tvOS 12 and xcode 10?  Since upgrading I'm getting quite a few Styles errors as well as application crashes these happen in both the simulator and on an actual device.
The style errors look like (there are 100s of these errors)
[Styles] Registering a style (color) that already has an existing type (0) that doesn't match the new type (4)
and
[Styles] Unexpected declartion type for style "text-shadow"
and the app crashes after navigating around a few page with the following errors
AppName(5399,0x700001de8000) malloc: *** error for object 0x600003bc79c0: pointer being freed was not allocated
AppName(5399,0x700001de8000) malloc: *** set a breakpoint in malloc_error_break to debug
(lldb)

libsystem_kernel.dylib`__pthread_kill:
    0x10a5a8b7c <+0>:  movl   $0x2000148, %eax          ; imm = 0x2000148
    0x10a5a8b81 <+5>:  movq   %rcx, %r10
    0x10a5a8b84 <+8>:  syscall
->  0x10a5a8b86 <+10>: jae    0x10a5a8b90               ; <+20>
    0x10a5a8b88 <+12>: movq   %rax, %rdi
    0x10a5a8b8b <+15>: jmp    0x10a5a2e67               ; cerror_nocancel
    0x10a5a8b90 <+20>: retq

I don't see any mention of these kind of errors with tvOS/TVMLKit anywhere else so I was wondering if others using TVDML were experiencing the same thing.

I did notice a lot of those actually
On Oct 5, 2018 12:58 PM, "Frank Febbraro"<EMAIL_ADDRESS>wrote:
Have you experienced any issues running a TVMLKit (and specifically TVDML)
on tvOS 12 and xcode 10? Since upgrading I'm getting quite a few Styles
errors as well as application crashes these happen in both the simulator
and on an actual device.
The style errors look like (there are 100s of these errors)
[Styles] Registering a style (color) that already has an existing type (0)
that doesn't match the new type (4)
and
[Styles] Unexpected declartion type for style "text-shadow"
and the app crashes after navigating around a few page with the following
errors
AppName(5399,0x700001de8000) malloc: *** error for object
0x600003bc79c0: pointer being freed was not allocated
AppName(5399,0x700001de8000) malloc: *** set a breakpoint in
malloc_error_break to debug
(lldb)
libsystem_kernel.dylib`__pthread_kill:
0x10a5a8b7c <+0>:  movl   $0x2000148, %eax          ; imm = 0x2000148
0x10a5a8b81 <+5>:  movq   %rcx, %r10
0x10a5a8b84 <+8>:  syscall
->  0x10a5a8b86 <+10>: jae    0x10a5a8b90               ; <+20>
0x10a5a8b88 <+12>: movq   %rax, %rdi
0x10a5a8b8b <+15>: jmp    0x10a5a2e67               ; cerror_nocancel
0x10a5a8b90 <+20>: retq
I don't see any mention of these kind of errors with tvOS/TVMLKit anywhere
else so I was wondering if others using TVDML were experiencing the same
thing.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/a-ignatov-parc/tvdml/issues/39, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqKL2pxCydjvIDa3l3u_fvyNClcAnbGks5uh53agaJpZM4XKq88
.

This is definitely something new 🤔 I'll investigate it.
@febbraro are you using color and text-shadow styles in your application?

Well, empty TVML app still generates a lot of style warning even when there is nothing to show. I guess Apple broke something either in XCode or tvOS 12 🤷♂
I'll post a bug report for this issue.

@spunkedy you were talking about style warnings or app crashes?

@febbraro I've tested three apps with different navigation structure and complexity and there were no crashes. Can you share a hint or a minimum app with a repro case?

@a-ignatov-parc style warnings. I haven't seen any crashes that weren't directly caused by me doing something silly like accessing a property that didn't exist on an object.

I've submitted a bug report for these styles warnings in the tvOS 12. When Apple responds I'll post an update.

I'll see what I can pull together that can recreate the crash

Ok I have a sample project here, https://github.com/febbraro/xcode10-tvos12
To test, go into the web/ directory and run npm install and npm run serve to get the test server running (http://localhost:9001/application.js)
Then run the xcode project in the simulator.  To get the crash, select the single video tile to get to the detail page, then hit menu(esc) to go back and enter for the details page again and esc to go back....do this about 4 or 5 times and it will crash.

@febbraro nice! Thanks! Will check it soon 👍

Well, there is some reference leak happening that crash app. I'll continue my investigation and will post updates here.

@febbraro created a fix for this problem. I need more time to test it and if everything will be ok I'll release it.

That’s great! Thanks. Would you mind sharing how you figured out what the problems were? I was unsure how to start debugging this problem. I would have loved to do more exploration to help get to the problem.

Sure! I started from deleting everything until it starts to work and then added small parts to localize the problem part of the code.
Unfortunately, XCode doesn't help with debugging TVML apps 😞

So in your fix you are adding unique IDs to each node and using those to find their references later on for comparison. Is that making a stronger reference to the object? or is it really just calling console.info with a reference to the node that is holding a tighter reference on the object?
(or do I have the idea behind the fix completely wrong?)

We use IDs instead of storing references to nodes and console.info give us time to clean react runtime before OS will GC everything on the document's disposal. We could store nodes in Map but that would require us to clean everything manually on unmount or we'll get a memory leak. console.info is a cheap workaround that handles cleanup by the OS itself.

@febbraro sorry for a long silence was very busy. Checked all cases that I was concerned of and everything seems to look good.
Released fix under v6.2.0. Please take a look and if the issue persists don't hesitate to reopen this issue 😉

@a-ignatov-parc Thanks so much for getting the fix out.  The bad news is that I still get the error, it just does not occur so quickly.  I have had the same crash after a fe wminute break and then start using the app again. I have seen it spontaneously after some heavy app usage it randomly crashed while the app was idle.
My real app has quite a few more video tiles, I will see if I can replicate a good amount of data in the test app and get the same crash.

Ok, I added a lot more data here: https://github.com/febbraro/xcode10-tvos12
And following the same steps (and doing a bunch of scrolling on the main screen) I can get the crashes to happen every time.

@febbraro I think I have managed to fix this problem in v6.2.1. Please check it and let me know.

@a-ignatov-parc Thanks for the update. I will test it out today and get back to you.

So, after some testing, the sample project I provided does execute without error.  My actual project, however, still contains errors. They are a bit different now.
The style warnings are still there in the real project and simulator.
This "error" is logged each time a new page is pushed onto the navigationDocument.
<Error>: Unable to create elements for document <undefined itmlID="id_2"/>
The itmlID is always 2, but I get this with the test project too and there are no crashes with that
The error I get now is ITMLKit (10): EXC_BAD_ACCESS (code=1, address=0x51)
libxml2.2.dylib`xmlSetTreeDoc:
    0x10588a06a <+0>:   pushq  %rbp
    0x10588a06b <+1>:   movq   %rsp, %rbp
    0x10588a06e <+4>:   pushq  %r15
    0x10588a070 <+6>:   pushq  %r14
    0x10588a072 <+8>:   pushq  %rbx
    0x10588a073 <+9>:   pushq  %rax
    0x10588a074 <+10>:  movq   %rsi, %r15
    0x10588a077 <+13>:  movq   %rdi, %r14
    0x10588a07a <+16>:  testq  %r14, %r14
    0x10588a07d <+19>:  je     0x10588a0f1               ; <+135>
    0x10588a07f <+21>:  movl   0x8(%r14), %eax
    0x10588a083 <+25>:  cmpl   $0x12, %eax
    0x10588a086 <+28>:  je     0x10588a0f1               ; <+135>
    0x10588a088 <+30>:  cmpq   %r15, 0x40(%r14)
    0x10588a08c <+34>:  je     0x10588a0f1               ; <+135>
    0x10588a08e <+36>:  cmpl   $0x1, %eax
    0x10588a091 <+39>:  jne    0x10588a0c4               ; <+90>
    0x10588a093 <+41>:  movq   0x58(%r14), %rbx
    0x10588a097 <+45>:  jmp    0x10588a0bf               ; <+85>
->  0x10588a099 <+47>:  cmpl   $0x2, 0x50(%rbx)
    0x10588a09d <+51>:  jne    0x10588a0ab               ; <+65>
    0x10588a09f <+53>:  movq   0x40(%r14), %rdi
    0x10588a0a3 <+57>:  movq   %rbx, %rsi
    0x10588a0a6 <+60>:  callq  0x105896b48               ; xmlRemoveID
    0x10588a0ab <+65>:  movq   %r15, 0x40(%rbx)
    0x10588a0af <+69>:  movq   0x18(%rbx), %rdi
    0x10588a0b3 <+73>:  movq   %r15, %rsi
    0x10588a0b6 <+76>:  callq  0x10588a0fc               ; xmlSetListDoc
    0x10588a0bb <+81>:  movq   0x30(%rbx), %rbx
    0x10588a0bf <+85>:  testq  %rbx, %rbx
    0x10588a0c2 <+88>:  jne    0x10588a099               ; <+47>
    0x10588a0c4 <+90>:  movq   0x18(%r14), %rbx
    0x10588a0c8 <+94>:  testq  %rbx, %rbx
    0x10588a0cb <+97>:  je     0x10588a0ed               ; <+131>
    0x10588a0cd <+99>:  cmpl   $0x12, 0x8(%rbx)
    0x10588a0d1 <+103>: je     0x10588a0ed               ; <+131>
    0x10588a0d3 <+105>: cmpq   %r15, 0x40(%rbx)
    0x10588a0d7 <+109>: je     0x10588a0e4               ; <+122>
    0x10588a0d9 <+111>: movq   %rbx, %rdi
    0x10588a0dc <+114>: movq   %r15, %rsi
    0x10588a0df <+117>: callq  0x10588a06a               ; <+0>
    0x10588a0e4 <+122>: movq   0x30(%rbx), %rbx
    0x10588a0e8 <+126>: testq  %rbx, %rbx
    0x10588a0eb <+129>: jne    0x10588a0d3               ; <+105>
    0x10588a0ed <+131>: movq   %r15, 0x40(%r14)
    0x10588a0f1 <+135>: addq   $0x8, %rsp
    0x10588a0f5 <+139>: popq   %rbx
    0x10588a0f6 <+140>: popq   %r14
    0x10588a0f8 <+142>: popq   %r15
    0x10588a0fa <+144>: popq   %rbp
    0x10588a0fb <+145>: retq

I will try to setup another test project that actually fetches real data from the API I'm using in an attempt to see if the collection of different data is leading to this problem.

Well, at least we fixed SIGABRT.

The style warnings are still there in the real project and simulator.

As I mentioned earlier they are shown even without TVML app at all. I've posted a bug report to Apple, but there still no response.

This "error" is logged each time a new page is pushed onto the navigationDocument.

I'll check it. Thanks!
And, I'll be very appreciated for new app build with steps to reproduce EXC_BAD_ACCESS.

Ok, here goes.  If you pull the same repo, but use the fetching-from-api branch I have this crashing consistently.  Here is the crazy part, this is the commit that gets the crashes to happen:
https://github.com/febbraro/xcode10-tvos12/commit/8eced2a6d3fcd05349dbc09473c4f6ec77d1c135
Basically, I added a couple { '' } and that did it.  I could not get the same crashes when adding those to the master branch, the only real difference I could tell was that this fetching branch loads a document with a loadingTemplate during each HTTP request and then replaces that with the actual video document.
So select the video tile and then go back to the main journal screen. Doing that 10 or so time should cause the crashes.  Sorry for the delay I was having a hard time reproducing it in my TestApp, but think I got it.

You are awesome! Thank you! I'll check it soon 👍

@febbraro I think I managed to fix this issue once and for all. Please check v6.2.2 release.

@a-ignatov-parc Great! I'm testing it now and for that main page it looks like you have fixed the crashes. Thanks!
I have found another page in my app that can produce some crashes, its a search page, working up an example to demonstrate it now.

I have found another page in my app that can produce some crashes

Whoa! You've got some mighty skills for bug hunting 😂
Thanks a lot!

I know, I know. :) Thanks for working with me to track down the causes. I REALLY appreciate it.

Ok @a-ignatov-parc, I have merged and added to the master branch, so use that.  If you go to search and you can search for workout, then remove the last t and add it back. Perform the search around 5-10 times and you will get crashes.
 Woohoo!!!! 🎉
I will hit it pretty hard over the next day or so to see what comes of it, but so far it is looking good.
Thanks for looking into it so quickly! 👍

Yay

I have not been able to reproduce any of the crashes

We did it! 🙂

I will hit it pretty hard over the next day or so to see what comes of it

Great! Let us know about the results! And feel free to open new issues if you'll find something 👍

Just tested a bit more on a real device (running tvOS 12.0.1) and things are still looking good. Going to get a build together today and distribute to some users via TestFlight today and will report back if things pop up.
Also, any word back on the bug report for styles?  I have reported a few bugs in the past and have never heard anything back, not sure what your experience is with these things.

any word back on the bug report for styles?

Nope. Two weeks and still no response.
Well, at least 3 bug reports (from minor to critical) had a response 🙂


Opener not detected

Hello,
I installed the plugin, that worked very well. The problem now is, that my Nuki Opener is not detected by the plugin. The opener is connected with the bridge and is working totaly fine, but the plugin does not recognize it.
Best wishes
Kengo

Please attach the Homebridge log file.  Also, please list the output of nb list.

Same issue here
[Nuki] Nuki_Bridge_28AB2C52: warning: heartbeat error: RangeError: : invalid name
at Opener.set name [as name] (/usr/local/lib/node_modules/homebridge-nb/node_modules/homebridge-lib/lib/Delegate.js:132:13)
at new Delegate (/usr/local/lib/node_modules/homebridge-nb/node_modules/homebridge-lib/lib/Delegate.js:39:15)
at new AccessoryDelegate (/usr/local/lib/node_modules/homebridge-nb/node_modules/homebridge-lib/lib/AccessoryDelegate.js:43:5)
at new NbAccessory (/usr/local/lib/node_modules/homebridge-nb/lib/NbAccessory.js:14:5)
at new Opener (/usr/local/lib/node_modules/homebridge-nb/lib/NbAccessory.js:407:5)
at Bridge.addOpener (/usr/local/lib/node_modules/homebridge-nb/lib/NbAccessory.js:230:24)
at Bridge.heartbeat (/usr/local/lib/node_modules/homebridge-nb/lib/NbAccessory.js:287:24)
at processTicksAndRejections (node:internal/process/task_queues:95:5)

Make sure to assign a name to the opener in the Nuki app, and power-cycle the Nuki bridge so it picks up that name.

Thanks. That solved the problem for meAm 27.07.2023 um 23:48 schrieb Erik Baauw @.***>:
Make sure to assign a name to the opener in the Nuki app, and power-cycle the Nuki bridge so it picks up that name.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Also fixed on my side. Thank you


Upgrade in Docker with persistent data doesn't upgrade version

Hello.
I'm using portainer in Docker for a development team (no swarm) with a volume for persistent data and I upgraded from 1.14.0 to 1.14.2 and then to 1.14.3 and the version at the bottom of the menu didn't change, only showed 1.14.0.
I dropped everything, including the volume, rebuilt everything, started fresh and now the version is correctly shown.
Is the version saved in the .db file and not updated/checked on the service/container start?
Thanks
Best regards,
Luis Nabais

Actually, this is a bug related to the UI state management. The version number displayed is persisted in the browser cache, you just need to either clean your browser cache to update it (or use a private navigation session).
I'm working on a overhaul of the state management that should fix this.

Is there a timeframe when you expect to work on this overhaul?
I wouldn't mind to spent some time to do a quick fix for this specific problem. In Safari you need to do more than just clear your cache. On an iPad it is also some work to remove the website settings. Further more I don't like loosing my settings every time I update portainer.

@Duvel no ETA yet, feel free to open a PR to quick fix this issue.


[/boss battle] switching Pokemon after death makes the player stuck on "Waiting..."

When participating in the new boss battle, after one of your Pokemon is defeated, you are prompted to switch to another Pokemon as usual. Upon selecting another Pokemon, the battle will be stuck on "Waiting...".
Steps to reproduce the behavior:

type /boss battle
make your Pokemon die to the boss
Upon being prompted to select another Pokemon, do exactly that.

Expected behavior
The Pokemon gets switched out normally.
Username: Uschalabamba
Server name: Orion
Logs are have been added:
latest.log
Additional Infos: When the boss is defeated by other players, the battle ends and you still get rewards. This will take a hot minute though.

Does this always happen or is this a one off? If so, I need a full party log.

Closing, feature was overhauled. If issue persists, please open a new ticket.


Drop Python 2

Once this is merged into master, I'll probably release a 3.0.0a1 so people can start testing early.

Remove _compat module and other compat code.
Run pyupgrade, use f-strings everywhere, replace x and y or z with y if x else z.
Remove deprecated code from Jinja 2.x.
Stop building universal wheel.
Bump bytecode cache version.
~I18N doesn't look for ugettext.~
Remove old docs.

Still have some things left that I'll either hit later or get help with at the PyCascades 2020 sprint:

Inline asyncsupport instead of patching where possible. Keep in mind performance reasons for patching.
Refactor compiler to extract some helper functions so things like "async for" if self.is_async else "for", Markup if ctx.volatile else str, etc. aren't written by hand all over the place.
Use super instead of BaseClass.method where appropriate.
Apply pyupgrade and code style fixes to docs.
Apply pyupgrade and code style fixes to generated code.
Add tests for using Babel for translations.

Unpopular opinion: let's rip the band-aid off and get this done with.

You already know my stance that I'm strongly against dropping 2.x support this early for a popular library.

Yes, not planning to release this until April at least, but I want to get it into master early so I can make alpha releases for people to test.

I definitely agree with getting this into the master branch early to ensure that it gets proper testing. We know this will be a breaking change, especially considering we are planning on bumping the major version, so let's get as many eyes as possible on it.
Yes, people are still using Python 2.7. People are also using Python 2.6 (I used to work for a company which did) but you don't see people arguing that we should continue supporting it. RHEL 6 is still supported and that ships with Python 2.6 out of the box.

It will be a very weird world where I have to fork my own library.

I work at a fairly large organization that uses python3.5. We use primarily el6 and el7. I'm not exactly sure of the default version of python3 that ships with those. But we have production systems on both using 3.5. Despite the fact that this is anecdotal I am sure my team is not unique. Recently a tox dependency called zipp broke our build process by dropping support for 3.5. Suffice to say I was not too happy about it. But that was a relatively small dependency. If something like that were to happen with jinja, I would be even more upset.

For what it's worth, I'm in favor of dropping Python 2 because it's legacy Python and officially EOL. I'm indifferent on Python 3.5 and other versions in the 3 line that aren't EOL yet.

I work at a fairly large organization that uses python3.5.

Python 3.5 is approaching EOL and is only receiving security patches right now.

We use primarily el6 and el7. I'm not exactly sure of the default version of python3 that ships with those.

RHEL 6 ships with Python 2.6
RHEL 7 ships with Python 2.7
RHEL 8 ships with Python 3.6 when you opt to install it

Recently a tox dependency called zipp broke our build process by dropping support for 3.5.

In theory, setting the python_requires to not allow Python 3.5 should prevent the package itself from being installed by pip. zipp appears to have done this so I'm not sure what went wrong in your case.

In theory, setting the python_requires to not allow Python 3.5 should prevent the package itself from being installed by pip. zipp appears to have done this so I'm not sure what went wrong in your case.

The specifics of my situation don't really matter for this discussion. Suffice to say if you have tox as a build dependency, you have not pinned zipp and you are using 3.5, you will not be able to install tox. What matters is that the error that got raised in my situation was about f-strings.
If this MR indeed breaks compatibility with 3.5 just because of use of f-strings, that seems like a mistake to me. If there is a more substantial reason to break with 3.5 then I would be willing to change my opinion.

Dropping support doesn't mean you can't continue to download existing compatible versions. 2.11 still exists, you'll still be able to install it on Python 3.5, and can use that as a pin or as a step during an upgrade.
Regardless of our timeline for Python 3.5 (or our use of f-strings), it goes EOL very soon. We dropped 3.4 in a similar way. You're going to have to deal with dropped support one way or another, from Jinja and/or the language, so it's better to pin now to 2.11 (which will still receive security/bug fixes during that time), and start addressing what you plan to do in general if dropped support is an issue.
You're taking on the risk of a language version that will never get updates (2.7) or will not in a few months (3.5). The risk of Jinja not getting updates either is comparatively minimal, especially given the fact that it's stable and I've said I will accept fixes to 2.11.x and merge them forward for a while. Given how rarely such issues or fixes are actually submitted by the community, I don't expect much churn.

Dropping support doesn't mean you can't continue to download existing compatible versions. 2.11 still exists, you'll still be able to install it on Python 3.5, and can use that as a pin or as a step during an upgrade.

I want to re-iterate that this is a major departure to how Jinja2 was maintained in the past. I kept 2.4 and 2.5 support alive long after they stopped being supported because CentOS users kept getting supported Python versions.
The argument that we have to drop support because Python itself stops being updated is one that I did not subscribe to back then and I still don't do it. It does not make maintenance of Jinja any easier (if anything it makes it worse because now we need to maintain two branches) and it also does not add anything to the user.
2.x will stay around for years to come. Why do we commit ourselves to having to maintain two branches for years? RedHat and Centos will carry Python 2 until 2024 and I expect large 2.x deployments to stay around for at least that period of time.
I understand I'm not very active on this project any more but this departure from the status quo I am not happy about and it's inconsistent with how I used to develop this library.

In theory, setting the python_requires to not allow Python 3.5 should prevent the package itself from being installed by pip. zipp appears to have done this so I'm not sure what went wrong in your case.

That's not very useful. It just prevents installing the package. It does not cause pip to auto select a compatible version.

python_requires does cause pip to select the highest version that supports the version of Python in use. When 3.0 is released, users who pip install Jinja2 on Python 2 will get 2.11. If this is not actually working, please report that to pip, as it would be a major bug.

AFAIK iit should (for any somewhat recent pip version), unless the package was built with distribute instead of setuptools (or possibly uploaded with setup.py upload instead of twine upload).


TT Pull Req

As per our email exchange, here's a pull request.  I thought I made one already but Github seems to think otherwise.  If this is a dup, please ignore.

I just realized my master branch was actually a few commits behind you, so I've merged in those changes too.


Adding in Array::iter and Array::to_vec

There's a few reasons for this:

Using array.to_vec() is more convenient and more efficient than using array.values().into_iter().map(|x| x.unwrap_throw()).collect::<Vec<_>>()

Using array.iter() is much more efficient than using array.values().into_iter()

The iterator returned by array.iter() supports size_hint, ExactSizeIterator, and DoubleEndedIterator, all of which cannot be supported by array.values()

Looks great to me, thanks!

👍


osxphotos sync: add support for location

With --set use origin location in the destination photo
With --merge

and property is set in the destination then no action is taken;
if property is not set in the destination but is set in the source then the value is copied to destination.

Thanks @oPromessa for this!


[FLINK-21612][table-planner-blink] Support StreamExecGroupAggregate json serialization/deserialization

What is the purpose of the change
Support StreamExecGroupAggregate json serialization/deserialization
Brief change log

Support AggregateCall json serialization/deserialization
Support StreamExecGroupAggregate json serialization/deserialization

Verifying this change
This change added tests and can be verified as follows:

Added GroupAggregateJsonPlanTest & GroupAggregateJsonPlanITCase to verify this pr

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure

@flinkbot run azure


cannot import crosscat.LocalEngine

Has anyone else seen this issue?
import crosscat.LocalEngine as LE
Traceback (most recent call last):
File "", line 1, in
File "/anaconda3/envs/python2/lib/python2.7/site-packages/crosscat/LocalEngine.py", line 28, in
import crosscat.cython_code.State as State
File "init.pxd", line 155, in init crosscat.cython_code.State (src/cython_code/State.cpp:17827)
ValueError: numpy.dtype has the wrong size, try recompiling. Expected 88, got 96
It appears to be a numpy versioning issue from a quick google search.. does anyone happen to have a shareable env with this package working?

resolved - pandas was missing in my python2 virtualenv


Feat : Add scroll to top

PR Template 🚀
🐛 Fixed Issue
Resolves 43
🛠 Proposed Changes

Add a "Scroll to top" button on the bottom right of the results page, clicking it will scroll to the top

🖼

https://www.loom.com/share/83c2201c461f44ff96dfec16f5f41405 (note: sometimes the video won't play/freezes)
📝 Notes for Reviewers

Don't know what the design of the button should look like, but I'm using the same styles currently in the repo.
I'm not too familiar with front-end development, so please let me know if I need to make changes!

Checklist ✅

[x] Starred this repo ⭐.
[x] Code adheres to the project's coding standards 💻.
[x] No sensitive information is inadvertently exposed 👀.
[x] Commit history is clear and concise 📃.

Hi @Peteredwardj, there's a minor fix in the PR. Can you please make the button visible only when the user scrolls to some points. And would you mind improving the button style a bit more, like giving the border of 2px of that yellow shade after removing the background color and the icon stroke to 5px, something like that. Thanks

Hi @anand346, for sure I can change the style.
Regarding the visibility of the button though, at which point do you think it should be visible?
I guess it's a bit difficult to determine when exactly we can show it because the user could be in the middle of the list on a larger window but on a smaller window they might be 3 issues deep and the button is expected to show. Please let me know if you have any ideas and I can work on it.

Hi @anand346 , made the changes!
https://www.loom.com/share/f518a09342064c9fa654ef0c5fb56b4e?sid=d8698781-7a72-41f2-9aa5-88040c21ef72

That looks good

That looks good

Awesome, thanks for letting me work on this issue!


AB#7692 Switch Kiosk and TV apps to use Delivery Edge for Content Hub endpoint instead of Preview endpoint

The PR changes looks good!
Before we proceed with the change to delivery API for CH content I realized that we need to test if the content is available in Edge for CH after creating a new instance. If it is not available than we may need to investigate how we could trigger a content and schema publish from the demo portal before switching to Delivery API.


Highlighting while searching is absent

Highlighting while searching anything with "/" seems to have no effect. It would be great if someone included that in this awesome theme! Thank You!

Update it ;) it's working here. Glad that you liked it :)


Is it possible to create an open Select?

Hello!
I am looking for an open Select, a Select with values I take from a model but that it can also permits to add new values by UI. I read the documentation for Select and Relation components but it seems they are not enabled for doing this. Any help?

You can inherit the selection field and add the desired functionality.


append-to-config option does not run unless --silent flag is passed

Based on the fact that the append-to-config check is in an else statement, the only way to get it to run is to also pass the silent flag. This conditional needs to be reworked. The silent check should probably be separated into another conditional.
https://github.com/Bash-it/bash-it/blob/71116f785f2701a5a2cbf39420131ecd1b786bf1/install.sh#L133

Hey @kirkmadera, thanks for the report!
#1830 tries to fix this bug,  try to use it and see if it solves your problem :smile:


Create Product “ger-eastbourne”

Automatically generated by Netlify CMS

👷 Deploy Preview for eluglab processing.

Name
Link

🔨 Latest commit
3d32171c70b5d0ee0ef3bc7226390460f909d4ad

🔍 Latest deploy log
https://app.netlify.com/sites/eluglab/deploys/64172aa4eaea300007ff566b


Update the selected input value when the options changed

Is your feature request related to a problem? Please describe.
I cannot reset the value of the select input that uses external data for options when the options data were updated.
This could be a bug rather than enhancement, still torn on that.
Describe the solution you'd like
Reset the selected input value when the selected item in the options has been removed.
Describe alternatives you've considered
No alternative so far. Any suggestions are welcomed
Additional context
Initial options contain Engineer and it was selected
https://user-images.githubusercontent.com/26282828/220018817-f0cca6d7-c934-4f8c-a6bd-345f3f40ab34.mov
All options were removed and the Engineer was still selected
https://user-images.githubusercontent.com/26282828/220019485-edc4bbf3-c368-4647-8974-309e626464fb.mov
Upon debugging, when the form was submitted the value for the Role field was still Engineer

Hi there, and sorry for the late response! Unfortunately, I'm not sure how the library could solve that particular issue, since its job is to provide an abstraction over the API. This sounds like it might best redirected to the folks at Slack. But if there is way for you to sync the two, the best way would be to track those changes and use the Update View endpoint preemptively and remove that selected value when you know that an option is no longer there.
Cheers!


'insulin' for square bolus not shown in Nightscout

See screenshot.
When giving a square bolus or a combo bolus, the 'insulin' of the square bolus is not shown in Nightscout with a low IOB as result.

Expected:
When giving a square bolus the 'insulin' is provided to Nightscout including it's duration.
When giving a combo bolus, maybe the message should be split in to (one for the square and another one for the normal bolus)
uploader version 0.6.1
nightscout version 0.10.3

In NS terms a combo bolus is a immediate bolus (IOB) and a extended basal increase.
NS knows noting about Medtronics 'square' and thus this type of bolus will only reflect the combo extended amount as there is no immediate bolus.

Strange thing is: I do see it in the graph, but in the reports the 'insulin' field is empty

Treatment:

@Pogman or @pazaan is there a way to read what exactly the uploader sends to Nightscout?
I like to know where in the chain my 'insulin got lost'. uploader -> Nightscout -> AndroidAPS.

The pump can be doing a square and temp simultaneously and must be handled separately. The IOB in NS is the IOB value taken from the pump.
Does AndroidAPS deal with combo bolus types? If it does it should understand the extended part even when there is no upfront insulin.
You can see the treatment entries as sent to NS in your mLab db.

@Pogman you are right; they should not be logged as tempbasal.
AndroidAPS uses ExtendedBolus for this.
In mlab this is the treatment. How can I trace if this was provided by 600seriesUploader or by XXX (manually in Nightschout or AndroidAPS)? Is this the format the uploader uses? -->
{     "_id": {         "$oid": "5b7a8fe13d9b8e16f59cf3a3"     },     "carbs": 47,     "created_at": "2018-08-20T11:51:28+02:00",     "duration": 30,     "enteredinsulin": "5.8",     "eventType": "Combo Bolus",     "key600": "BOLUS85758357",     "notes": "Square Bolus: 5.8U, duration 30 minutes : carb 47g 5.8U, {4.5~6.0} 0.0U, iob 0.2 0.0U (8g/u, isf 2.7/u)",     "relative": 2,     "splitExt": "100",     "splitNow": "0" }
If so, it seems ok from this side and might be an issue on Nightscout/AndroidAPS side.
Nightscout should IMO in some way take this insulin into account in reporting and not only graphically..
AndroidAPS should read the combo bolus as a Normal + ExtendedBolus.

That's the correct combo entry sent and the "enteredinsulin" field is the full programmed amount. The "key600" field is unique to the uploader.
BTW there is a bug in v0.6.1 that's fixed for the next version #203 that relates to the "relative" field part of the combo treatment and that may be causing an issue for aps users.

thank you - I created an issue at AndroidAPS.
sometimes a little struggle to pinpoint the location in the chain (uploader, NS, or AAPS) of information where things get interpretated :)


Cherry pick Mutablebuffer::shrink_to_fit

Automatic cherry-pick of 7f37a7f2a119dd83c497766265707a64d9b82307

Originally appeared in https://github.com/apache/arrow-rs/pull/318: Mutablebuffer::shrink_to_fit

@jorgecarleitao and @ritchie46  -- here is the first (of hopefully many) cherry pick PRs to active release.
The goal is that this code will be released in arrow 4.2.0
I plan to backport changes semi-manually at first to optimize the backport process and then automate the process more and more (culminating with making a PR like this on each commit to master)

I wrote up what I am doing https://github.com/apache/arrow-rs/issues/292#issuecomment-847313452 in case anyone is interested


[AMBARI-22966] ambari-agent fails to start (dgrinenko)

What changes were proposed in this pull request?
RM wildcard module resolving cased sudo module to be imported twice, causing circular import issue. Moving sudo import inside function will help to broke  circular import chain.
How was this patch tested?
Before:
# ambari-agent start
Verifying Python version compatibility...
Using python  /usr/bin/python
Checking for previously running Ambari Agent...
Checking ambari-common dir...
Starting ambari-agent
Verifying ambari-agent process status...
ERROR: ambari-agent start failed. For more details, see /var/log/ambari-agent/ambari-agent.out:
====================
  File "/usr/lib/ambari-agent/lib/resource_management/__init__.py", line 23, in <module>
    from resource_management.libraries import *
  File "/usr/lib/ambari-agent/lib/resource_management/libraries/__init__.py", line 23, in <module>
    from resource_management.libraries.functions import *
  File "/usr/lib/ambari-agent/lib/resource_management/libraries/functions/__init__.py", line 48, in <module>
    from resource_management.libraries.functions.log_process_information import *
  File "/usr/lib/ambari-agent/lib/resource_management/libraries/functions/log_process_information.py", line 22, in <module>
    from ambari_commons.shell import shellRunner
ImportError: cannot import name shellRunner
====================
Agent out at: /var/log/ambari-agent/ambari-agent.out
Agent log at: /var/log/ambari-agent/ambari-agent.log

After:
# ambari-agent start
Verifying Python version compatibility...
Using python  /usr/bin/python
Checking for previously running Ambari Agent...
Checking ambari-common dir...
Starting ambari-agent
Verifying ambari-agent process status...
Ambari Agent successfully started
Agent PID at: /var/run/ambari-agent/ambari-agent.pid
Agent out at: /var/log/ambari-agent/ambari-agent.out
Agent log at: /var/log/ambari-agent/ambari-agent.log

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/546/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/552/
Test FAILed.
Test FAILured.

Ignoring test result as python tests passed. Java deadlock test have no relation to this patch


Not able to read excel cell data

Hi,
I came across this issue when I was trying to Load an excel file exported from SSRS. The issue in question was because the the Cell class does not support the structure that my file has. The structure is as follows.

Exchange

So the ElementText value is always null and nothing comes up on the UI.

Hi, can you upload an Excel sample file that causes the problem happen?

Hi Jing,
I have also raised the issue on github.com and also have provided a sample
of why the data was not visible. I cloned the source and made some changes
to make it work.
On 12-Mar-2017 08:50, "Jing"<EMAIL_ADDRESS>wrote:

Hi, can you upload an Excel sample file that causes the problem happen?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/unvell/ReoGrid/issues/5#issuecomment-285918896, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB9zoERQ3J9ocA4Ke9_J3g1TSWUTRmstks5rk2RjgaJpZM4MaQnZ
.

Thanks. Can you share and submit your changes as a pull-req?


facing issues with network connection when using this plugin

1)Server issued an error response (8) - http://url
2)Network failure (4) - http://url
The above 2 errors are not continuously recorded
Please Help

Could you please elaborate a bit on this? Both mentioned cases always lead to a CRITICAL output, which is the result that should be expected.
There is nothing being recorded from this plugin. I think you have an issue with your monitoring software and not this script.


Deprecate the condition attribute and related functionality

Summary
This commit deprecates the Instruction.condition and c_if() method for removal in 2.0. This functionality has been superseded by the more sophisiticated IfElseOp for some time now. Removing the condition property will simplify the Qiskit data model as it is implemented in a kind of ad-hoc manner that adds additional overhead to manually check it in many places.
For the unittest modifications the deprecation warning for the .condtion getter is suppressed for the entire suite because this gets triggered internally by the transpiler and a lot of other places, including from rust code as until it is removed we need to use it to check that piece of the data model.
Details and comments
Fixes #9556

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

21 of 23 (91.3%)  changed or added relevant lines in 9 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 88.743%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/qpy/binary_io/circuits.py
1
3
33.33%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
5
92.23%

Totals

Change from base Build<PHONE_NUMBER>3:
0.02%

Covered Lines:
73830

Relevant Lines:
83195

💛  - Coveralls


crash pls help :/ <3

updated from 1.3.4 to 1.3.99 and got this crash on startup. :/
crash-2022-02-18_22.18.39-client.txt

thinking maybe something to do with the support of certain mods if there installed or not, idk sir what do you think? <3

yes we know, i just fixed it

thank you king


Moment.js vulnerability

Hi,
I've just ran a vulnerability scan on my app and got a known vulnerability for moment.js in 2.5.1:
https://nodesecurity.io/advisories/55
As moment didn't have any breaking changes, I'd propose to update moment dependency to latest 2.22.1.
Cheers
Marcel

@TomFrost are you still with us? :-)


Use consistent version names in the release notes

As agreed on the hacking session, let's use the full version number for all releases listed on the page.

Documentation-only change, merging.


getAdminURL.py bugs

getAdminURL.py does not initalizevarstr This causes the script to fail if no routes are found.
The script needs to exit with non-zero exit code on failure to let Terraform know it has failed.
result may not have been initialized either.

Being addressed in https://github.com/terraform-ibm-modules/terraform-ibm-mas/pull/56


Page feedback

Suggested improvements for page: ADD PAGE-URL-HERE
I have a client program that calls the RollDice sample service.
How do I initialise tracing in the client program so that when the call to RollDice fails, the client program can log a message "error calling RollDice, check traceID xxxx"
I imagine I need to create a new root span / trace in the client program, then use that to call RollDice, but I can't see anyway to create a new root span.  Every time I call AddSpan to an empty context, the traceID and spanID are empty strings.

Hi @mccallua! Could you state which page you sent the feedback from? Thanks!


Bugfix: Resolved a release mode crash for SelectableText

Resolves #164
@matthew-carroll

This was fixed in another PR. I'm going to close this one.


Flash Attention for AMD GPUs

❓ The question
Hi,
In the official OLMo-1B.yaml config file, I see that the flash attention is not available for AMD GPUs:

Line 17: flash_attention: false  # not available on AMD

Can you suggest a way OLMo can be run with flash attention on the AMD GPUs?
When I enable the tag here, although there is a slight increase in the throughput, the training diverges quickly.

It would be great if someone can point on the right way to run OLMo training with Flash Attention on AMD GPUs.
Thanks!

@dirkgr @schmmd did you also face similar issue in your experiments?

We did also face this issue. This is why flash attention is disabled by default on OLMo.

Thank you for answering.


Amend example in readme to be wrapped in a

Currently, the example provided in the readme won't work properly out-of-the-box, and will throw a You must wrap your <Subscribe> components with a <Provider> error, so I chucked in a <Provider>.
Also, would it be worth adding the // @flow flag as type annotations are used? :)
Cheers! 😄

fantastic @jxom 💯 🎉


Supported on React Router v4 for React Native

Thanks so much for creating this @maisano, I got it working on our React web app and it's awesome!
A question on support for React Router v4 for React Native - will this work in RN? I tried looking through the source for this project but I'm a bit new to this so I thought I'd ask directly here as well.
Getting this error currently:
Unable to resolve module './factoryWithThrowingShims' ; doesn't exist
Tried rm -rf node_modules && npm install but no luck.

hi @tyhopp!
currently, react-router-transition is not compatible with react-native. that said, it could be, though it would seemingly require a few small changes:

swapping the react-router-dom package (& references) in favor of react-router
removing any DOM-specific code in favor of something more configurable.

after these things happen, it should be compatible with react-native, though i am curious how performant it would be.

that said, the error you're currently getting is referencing a file from the prop-types package. it should get installed as a transitive dependency of this package–is it not in the node_modules directory of your project?

Thanks for the reply @maisano! I tried forking and translating the code to RN supported code, but in the end decided to just use the base animated library instead.
Also you're right, it was from prop-types!
Cheers


refactor: move trace configuration to infra crate

This change is

Codecov Report
Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.21%. Comparing base (c7fa63e) to head (042456e).

Files
Patch %
Lines

crates/mempool_infra/src/trace_util.rs
0.00%
9 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   83.21%   83.21%
=======================================
  Files          36       37    +1
  Lines        1692     1692
  Branches     1692     1692
=======================================
  Hits         1408     1408
  Misses        209      209
  Partials       75       75

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🎨 Design Login Container

Feature Request
[C-FEATURE]: 🚀 Design Login Container
Description:
Design a sleek and user-centric login container. This component should prioritize user experience, ensuring a smooth login process, while also adhering to the app's overall design principles and aesthetics.


Test library on Mac

Make sure we support Mac in general and especially with psycopg2 connections

Hey! Reopening this because it's still not working for me.

Closed because this was resolved in #164


Add the document about idioms

Instead of prividing a new features, we provide some idioms as the document.

This change is

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.

docs/IDIOM.md, line 19 at r1 (raw file):

```typescript
function unwrapOrUndefined<T>(option: Option<T>): T | undefined {
  let result: T | undefined = option.isSome ? option.unwrap() : undefined;

Would you like to use 'let' here? is not 'const'?

docs/IDIOM.md, line 24 at r1 (raw file):

function unwrapOrNull<T>(option: Option<T>): T | null {
  let result: T | null = option.isSome ? option.unwrap() : null;

here too

docs/IDIOM.md, line 59 at r1 (raw file):

  }, (v: T) => {
    result.ok = true;
    result.value = v;

It's seem to entirely new result. Do you like update existent result?

Comments from Reviewable

That's great work!
In addition, I hope to add links to original Rust documentation for example,

https://doc.rust-lang.org/std/result/
https://doc.rust-lang.org/book/generics.html

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.

docs/IDIOM.md, line 59 at r1 (raw file):
Previously, nekoya (Ryo Miyake) wrote…
It's seem to entirely new result. Do you like update existent result?

This result will be created newly on calling this functions.

Comments from Reviewable

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

@homu r+

:pushpin: Commit 0cbe661 has been approved by saneyuki

:zap: Test exempted - status