Clarify and possibly fix crawler data scheme and issues

In her COMP 360 project, which covers our work here, @katehausladen mentioned various smaller issues with the crawler. I am opening this issue as an omnibus issue stub. @katehausladen will take the lead on this issue, elaborate further (and/or open new issues as necessary), and discuss with @Jocelyn0830.

Here are some of the things I found:

Our extension was failing to send a GPC signal to more sites that in the paper data.
sent gpc = 0 (i.e. not sent) for 51/1806 sites on the crawl in the paper
sent_gpc = 0 for 248/1594 sites for recent crawl
These sites barely overlapped. The sites that had sent_gpc = 0 in both crawls were: {'gamersheroes.com', 'bizjournals.com', 'wsls.com', 'google.com', 'kw.com'}. So, for the most part, it may not be an issue with the sites, but we should try crawling the sites that did not get a GPC signal to check.
This also may be useful to note:
For the recent crawl, all sites with sent_gpc = 0 also did not have a DNS link.
For the paper crawl, 48/51 sites with sent_gpc = 0 also did not have a DNS link.

Our extension found many fewer DNS links that the crawl from the paper. Is this our extension or actually fewer have them?
Paper: 875/1806 had DNSL (873 unique domains)
Now: 446/1594 had DNSL (444 unique domains)
I looked to see if there was any overlap in the sites. 369 unique domains had a DNSL in the paper and in the new crawl. 504 unique domains that had DNSL in the paper had no DNSL in the new crawl. 75 unique domains that had no DNSL in the paper now have a DNSL. It may be useful to re-crawl the 504 domains that used to have a DNSL and then spot check some of them if necessary.

There are sites in the crawl set that redirect to other sites that are also in the crawl set. This leads to double or even triple entries for some domains. In the crawl data from the paper, this happened with 3 sites ('jotform.com', 't-mobile.com', 'questdiagnostics.com' all have 2 entries). This appears to be becoming a bigger problem, too; it happened with 11 sites in the recent crawl (10 sites have 2 entries and ‘blizzard.com’ has 3 entries). We should decide on some standard policy for what to do about these repeat sites when analyzing crawl data.

What is the extension supposed to put in the opt out columns if the USPS is the same before and after the GPC signal is sent? It is inconsistent.

This does not seem to be a problem when the value of the USPS changes after the GPC signal is sent.

Our extension was failing to send a GPC signal to more sites that in the paper data

What is unclear to me is, how is that even possible. Isn't sending a GPC signal entirely in our control? Is this maybe just incorrectly recorded while we were actually sending a GPC signal?

It may be useful to re-crawl the 504 domains that used to have a DNSL and then spot check some of them if necessary.

It would be also useful for sites that do not have a DNSL in the current crawl to (spot-)check whether they used to have a DNSL in the previous crawl. And also check to which extent there could be an analysis failure on our end now.

@katehausladen will continue to be on the lead here (and the issue management). The questions for each of the three points are:

Is this an issue on our end (e.g., a bug in our code or not leaving enough time for a site to load) or a site issue (e.g., site has bugs or URL is simply wrong)?
How can we fix or mitigate the issue (or is it unfixable, which may be if it is a site issue)?

Some in-depth analysis of sites that failed and trying to logically suss out where the issue comes from may help (e.g., using the browser developer tools, a web proxy like mitm, ...).
In addition to @Jocelyn0830, @OliverWang13 and @sophieeng will also help out. In that regard, is the setup clear as described in the readme? If not, what do we need to change?

3rd point is resolved: we decided that we will just filter out duplicate domains when we are analyzing the crawl data.
DNSLs: I compared 3 crawls: the paper crawl, the crawl by the Mac minis discussed above, and a crawl I did a few days ago on my Mac. I made a spreadsheet that classifies sites based on which crawls found a DNSL on that site. I manually looked at 40 sites that had a DNSL in the paper but did not have a DNSL in either recent crawl. These sites fall into a few main groups:

21/40 It does still exist. Note that for 3 of these sites, the DNSL appears in a banner that takes 1-2 seconds to load (site is checking to see if it’s a CA IP address). Maybe this delay causes a timing issue so that our extension is not finding the link after it appears. For the other 18 sites, we'll have to figure out why it's not being found. (picture of delayed banner below)

10/40 The link is now named some iteration of “Your Privacy Choices”/“Your Privacy Options”/“Manage Your Privacy Choices”. If this terminology is accepted as equivalent to a DNSL, we should expand the regular expression to include variations of this. As a side note, some of these sites included the icon Lorrie Cranor and her students developed.

3/40 It does exist, but you have to do something to see it. These fall into 2 subcategories

There is a “Customize My Ad Experience” link (pic 1), and if you click it, it becomes a “Do Not Sell or Share My Information Link” (pic 2). I’m not sure if this is considered compliant? This happens for all sites that are “A Raptive Partner Site.”

For bk.com: if you click the menu icon (top left pic 1), the site redirects to bk.com/account, and the DNSL is there (pic 2). Since it’s on a different path, the regex is not finding it. When you close the menu icon, it redirects back to bk.com.  Again, I’m not sure if this is technically compliant?

3/40 The DNSL does not exist anymore (or at least I could not find it)

3/40 The site does not exist anymore or won’t load with the VPN. Obviously there’s not much we can do about this.

3rd point is resolved: we decided that we will just filter out duplicate domains when we are analyzing the crawl data.

Excellent! (I added checkmarks above.)

I compared 3 crawls: the paper crawl, the crawl by the Mac minis discussed above, and a crawl I did a few days ago on my Mac.

That is a great analysis, @katehausladen! It strikes me that --- at least partially --- the issue is on our end and can be resolved, for example, by modifying the regex for identifying Do Not Sell links. @OliverWang13, as you have worked extensively on the regex, can you also look into how it and the rest of our code should be modified to iron out the issues @katehausladen describes?
@katehausladen (and everyone), I copied your Google Sheet into our GPC Web Google Drive. So let's use the version there. (And let's store any documents that we do not have on GitHub in the GPC Web Google Drive. Feel free to create documents and directories there as you see fit.)

The sent_gpc issue (point 1) is tentatively resolved.
The GPC signal not sending was an issue with our extension, not a recording problem. For sites where sent_gpc = 0 (i.e. the GPC signal is not sent), the function that adds the GPC header is never executed. After looking more at the code, I think this was a problem because the function that calls sending the headers is async but was not called with await. So, the execution would keep going and skip sending the header. I've only tested 1260 sites, but it appears that this issue is fixed.
I think something like this may be contributing to our problem with success rate, so I'm going to look into that in the next few days.

The latest crawl with the regex updates found 807 DNSLs/1670 sites crawled (~48.3%). This is nearly identical to the percentage found in the paper. I can do a more in-depth comparison of the sites in the paper vs this crawl.

Overall, the crawler is doing a much better job identifying DNSLs, so I'm closing this issue.


Upload text font

Could whoever made the images for the upload page say what the font below each picture is so we can use it under the WWW image?

http://www.dafont.com/new-super-mario-font-u.font

Great, thanks!
Can @MegaApuTurkUltra edit the URL upload image and change the font to the one above please?

@The-Cheese-Eater I've made new images for it that fit to theme, so it isn't needed now.

Ok, thats better. :)

Maybe instead of using images, we should use webfonts and images only for the actual icons. It would make things like this easier to manage.

Maybe.

If we ever did translations, it's easier to change text than text in an image.

That's right.


Is there a minimum node.js version required?

Question as per the title: is there a minimum version of node.js required to run through2?
I couldn't find it in the README either here or on the npm package page. Thanks!

to my knowledge this should run in node >=0.10

yeah, I think we only bothered testing readable-stream on v0.10, although I can't think of anything that would prevent it also working on v0.8 but really, you shouldn't be on anything older than v4 at this stage anyway


how to troubleshoot 10 bwa alignment pipes (100 cpu) being idle ??

Hi,
I am trying to align and variant call a number of samples.
To do this I am running bcbio via SGE on a single large machine with 100 of the 160 available cpu.
There are 10 bcbio worker engines running 10 BWA alignment pipes where each pipe is running bwa with 10 cpu.
After around half a day and having processed a number of samples now all bwa alignment pipes are idle. Top show 0% percent usage of the machine.
ps aux | grep BWA shows that there processes are still on the system. The BWA processes seem to be in a sleeping state. qstat also shows the slots on the machine still being used, though the job resource statistics are not changing anymore.
No new log entry has been created in the bcbio log for over 24 hours.
Somewhere these BWA pipes are waiting on a resource not available anymore, either at the input or output side. Or there is some sort of resource lock somewhere.
Do you have any tips for troubleshooting these idle BWA alignment pipes?
I thought it might be related to   /dev/fd/62 and  /dev/fd/63 outputstreams that samblaster opens in in the pipe.
These I can't ls:
ls: cannot access /dev/fd/62: No such file or directory
ls: cannot access /dev/fd/63: No such file or directory

But a small test run with just 4 samples with 80.000 reads is now running on that same large machine with 2 bcbio workers running BWA alignment pipes with 10 cpu each. These also use samblaster and these /dev/fd/62 and /dev/fd/63 for output.
[2015-12-11T12:15Z] large_machine: samblaster: Opening /dev/fd/62 for write.
[2015-12-11T12:15Z] large_machine: Opening /dev/fd/63 for write

So there is no global resource shortage on the large machine. There seems to be a resource problem / lock just with the 10 bcbio workers / bwa pipes from my first run.
Any tips on how to troubleshoot this? Thank you!

Neill;
Sorry about the failures without useful error messages. It's tough to debug these remotely but from the description it sounds like the larger job is somehow triggering failures which are not reported to the shell and bcbio so it doesn't know they died.
Is it possible some system process is killing the bwa or samblaster jobs? If so, that might be reported in the SGE logs.
Practically, it can help to use align_split_size to limit the size of each bwa chunk that gets processed at a time.
Hope one of these ideas helps with debugging and running.

Hi issue seems to have been a restart of our sge submit node. The bcbio controller running there was therefore killed, and the worker engines / bwa pipes somehow stopped working by this after half a day. At least this seems to be most probable cause.
This issue can be closed. The analysis is running again and will finish I hope.


Modbus unable to handle below zero values

Home Assistant release (hass --version):
0.56.1
Python release (python3 --version):
3.4
Component/platform:
Modbus Sensor
Description of problem:
When the value reaches a minus value modbus sensor show abrupt data of 65132 degrees. Switching the data value from int to flow leads to the sensor diplaying "Unknown" value.
Expected:
Showing minus values as usual. Must be some number handling problem
Problem-relevant configuration.yaml entries and steps to reproduce:
    - name: VSR Temp Outdoor
      unit_of_measurement: °C
      slave: 1
      register: 217

Please try code in my fork.
Place modbus.py in custom_components/sensor
Let me know if this solve your issue.

ziotibia81, thank you for looking into it. Althought currently i cant test it as the temperature is above zero


Release.Reason variable

I was trying to prepare a custom expression for execution of tasks in my release pipeline and was referring to this document for the values against variable - "Release.Reason". I figured out the actual values pipeline is showing against this variables are :
'ContinuousIntegration', 'Manual', 'Schedule'
and not the one mentioned in this document. Please update the doc are let me know if I am missing any thing!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 611642f0-881f-10b9-ae94-3c562001d1f0
Version Independent ID: 41efb94b-4c7a-64a3-b23b-70c8634ae727
Content: Release variables  and debugging - Azure Pipelines
Content Source: docs/pipelines/release/variables.md
Product: devops
GitHub Login: @alexhomer1
Microsoft Alias: ahomer

Thank you for your feedback. We are currently in the process of updating this topic and will incorporate your feedback into the new version.


Class Summary Page feature requests

1 Should it validate that the subclasses added to the sheet have a matching Class identifier to the Class?
2 Include Optional advancements in the generated class table, currently they are not shown on the Class table but have a separate section and custom table at the bottom of the generated item details
3 The class table lacks identifying when a subclass feature is granted, perhaps once the subclass items are added it can state "[Subclass Header] Feature" in plain text in the table

4 Special Handling for Item Grant advancements with only Spell Items
Currently if you use the advancement system to grant Prepared spellcasters spells, the table and item details sections balloon quite a lot, perhaps showing an inline link for the advancement item in the class table or just plain text, then in the description section a table to show the links to the spells similar to the optional display (but without the description of the individual spell items)
Current:

Proposed:

Thanks

1 Should it validate that the subclasses added to the sheet have a matching Class identifier to the Class?

I don't think this is too much of an issue, but we can always take another look at that when SubclassAdvancement is added.

2 Include Optional advancements in the generated class table, currently they are not shown on the Class table but have a separate section and custom table at the bottom of the generated item details

None of the official sources mix required features with optional features in the same table, so I've taken the route that D&D Beyond uses when they show their combined class summary pages.

3 The class table lacks identifying when a subclass feature is granted, perhaps once the subclass items are added it can state "[Subclass Header] Feature" in plain text in the table

We don't have this information at the moment, but it was something I was planning when SubclassAdvancement is added. Right now subclass handling is more of a stopgap design until that advancement is in place.

4 Special Handling for Item Grant advancements with only Spell Items Currently if you use the advancement system to grant Prepared spellcasters spells, the table and item details sections balloon quite a lot, perhaps showing an inline link for the advancement item in the class table or just plain text, then in the description section a table to show the links to the spells similar to the optional display (but without the description of the individual spell items) Current:  Proposed:

Spells granted are not something normally shown on class summaries. Perhaps ItemGrantAdvancements can be given a toggle as to whether they are shown in the table at all, but any further improvement to this will probably wait until spell lists are properly integrated into the system.

Until spell lists are added to the system I would appreciate advancements that only have spell items being suppressed from the class summary - lots of subclass spell lists (Artificer Specializations, Cleric Domains, etc.) can be reasonably modeled as Item Grant advancements with the current Always Prepared model, the only deficiency is on the Class Summary sheet where it's now giving me the full text of flaming sphere.

I would like to add one more feature request: If the tables in class/subclass summary pages could be disabled altogether with some toggle. The tables are great, but there are some cases I'd like the option to hide some of them.
I have formatted subclass items so that they have tables in their description, and now I get subclass tables twice. Sometimes even a domain spells table or such between them. I could remove the tables from the items but I'd prefer to have them there and disable the generated subclass tables in class summaries.
Also some scale values in subclass items make the tables weird. Example of this can be seen in SRD life domain cleric. Some toggle to hide specific things in tables would be nice too.

It is currently difficult to justify using subclass pages in premium content for subclasses that grant spells.
In addition, it would be good if the automatically generated subclass table did not show rows that had no changes from the previous level. As is, if a subclass has a scale value, it will show its value at all 20 levels, not just those levels with actual changes.


Cannot resolve com.ahm.capacitor.camera.preview.CameraPreview; on android

I followed exactly the readme, but this code won't work:
import com.ahm.capacitor.camera.preview.CameraPreview;
this.init(savedInstanceState, new ArrayList<Class<? extends Plugin>>() {{
      // Additional plugins you've installed go here
      // Ex: add(TotallyAwesomePlugin.class);
      add(CameraPreview.class);
}});

Because Android Studio doesn't find the package com.ahm.capacitor.camera.preview.CameraPreview
What is missing?

I had the same problem initially, I fixed it with a complete reload of the project (removing .idea folder in the android folder) and reopening the project with android studio.
This issue might also be a problem when the plugin was not correctly installed with npm install following npx cap sync android

I did:

delete myProject/android/.idea folder
npm install @capacitor-community/camera-preview
ionic build
npx cap sync android (the 2 previous commands can be replaced by ionic capacitor sync android)
npx cap open android
And now it works!
But I did (almost) same before (npx cap sync instead of npx cap sync android because the doc says npx cap sync) so I don't get why it didn't work at first. I should have thought first to "reset" the android project dependencies, thanks!

PS: I had a small problem, my AndroidManifest.xml was saying I don't have my MainActivity anymore (which I still had) so I had to click on the error and "create" it from the error popup, it didn't create it but the error was gone then I could compile.


feat: port Data.Nat.Interval

[x] depends on: #1837

This PR/issue depends on:

leanprover-community/mathlib4#1837
By Dependent Issues (🤖). Happy coding!

bors merge


add basic functionality that asks user to enable geolocationwhen addi…

…ng trials to an experiment that requires it

lgtm


qt: migrate from core

Goes together with https://github.com/Homebrew/homebrew-core/pull/7019.
Created with brew boneyard-formula-pr because Qt4 is EOL.

Passing on this due to https://github.com/Homebrew/homebrew-core/pull/7019#issuecomment-269820959.


TypeError: init() got an unexpected keyword argument 'with_last_pool'

Hi, when I try to use SSD model with custom dataset it shows:
TypeError: init() got an unexpected keyword argument 'with_last_pool'.
How to fix it?

You can update mmcv

You can update mmcv

Thanks

Have u solved it？I meet the same question now.
Update mmcv does not working.


[7.x] Fix validation rule 'required_unless' when other field value is boolean

Validator::make(['a' => false ], [ 'b' => 'required_unless:a,false']);

This validator should pass, but fail, this PR fix it.

Heya. This indeed seems correct. But can you send this to the 6.x LTS branch instead? And add a test? Thanks.


fix regression in trackpoint.service introduced with 9b29bc0010a9cee3236511f70f36b8ae95887f5c

Description of changes
9b29bc0010a9cee3236511f70f36b8ae95887f5c omitted the closing quotation marks in this service's ExecStart, leading to spurious trackpoint.service: Cannot add dependency job, ignoring: Unit trackpoint.service has a bad unit file setting. log messages in the journal. This patch reintroduces that character.
This is a trivial one-character fix to modules/tasks/trackpoint.nix.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The changes looks good, would you mind prefixing your commit with nixos/trackpoint:?


stylePreprocessors supports  additionalData

What problem does this feature solve?
SFC compiler supports CSS preprocessors like Sass, but doesn't support additionalData like sass-loader.
What does the proposed API look like?
vite.config.js:
module.exports = {
  cssPreprocessOptions: {
    scss: {
       additionalData: '@import("variables.global.scss")'
    }
  }
};

Can you open this in vite repository please?


feat(integrations) guacsec/guac

Look into how an initial integration with https://github.com/guacsec/guac would look like. It's feasibility and scope.
At first glance, one way to approach this integration would be for Chainloop to populate a network reachable location (OCI, blob storage, ...) that then can be continuously scanned by a guac collector.

The data source provided by Chainloop will contain different pieces of evidence, for now we could push SBOMs (cyclonedx, spdx), in-toto statements and DSSE envelopes.

I've been taking a look at the list of possible collectors and this is my reading
OCI collector
It seems to be focusing only on a single OCI image for which it extracts attached files with .att and .sbom suffixes. There is an issue reported to support registry-wide collection that could potentially solve the discovery problem "in some registries" https://github.com/guacsec/guac/issues/298
Google Cloud Storage (GCS)
There seems to be an implementation of blob storage on Google Cloud which could work with Chainloop if we push artifacts to a bucket. The issue with this collector though is that it does not seem to be linked or used from anywhere so I am not sure it's functional or deprecated.
From my quick scan on the repo source code it looks to me that we expect guac for now from the following data sources, oci, git repositories, github releases and purl URIs
type DataSources struct {
	OciDataSources []Source
	GitDataSources []Source
	GithubReleaseDataSources []Source
	// PurlDataSources encodes the list of PURLs
	PurlDataSources []Source
}

https://github.com/guacsec/guac/blob/8282449c65a3d0a79016a3ce9fb8434916f2662b/pkg/collectsub/datasource/datasource.go#L37
Workarounds

OCI collector: We could push single images and forget about the discovery part just yet.
File collector: Allow chainloop to expose a tarball of sorts that can be untar it and processed by the user i.e ./bin/guacone collect files ...

Next steps
At this point we should probably engage with the guac community to get their take on what would be the best way moving forward.

@lumjjb recently filled out a very interesting PR that I am wondering if it has some overlap with our use-case https://github.com/guacsec/guac/issues/970

Hi @migmartri thanks for the tag here!
The architecture/design looks great and that's exactly how we'd hope to integrate!
I would say that the GCS bucket or the git collector are probably the better bet here . Due to the restrictions of OCI making it a little harder to perform discovery and tracking updates, thus the current focus only on .att and .sbom..
We do not current have the GCS collector run as part of the compose, but that is an interface that we will actively maintain. We do not currently have active users for this, and if there's any issues coming up from it, do file an issue (and/or a PR)!
On a side note https://github.com/guacsec/guac/issues/970 is a little bit of a different internal sub-system (it is more for internal caching and solving the NATS queue limitation issue), so I would not rely on that right now - unless we figure out that an external solution requires a similar solution then we'd consider maintaining that as a public interface..

@lumjjb makes sense, thanks for the context! As a matter of fact, I've created an initial PR, feedback is welcome! https://github.com/guacsec/guac/pull/989
Also, on the Chainloop side. Just a sneak peak on how it's going


Indicate fetching in tool bubble

Currently the user is only notified about the presence of text for a canvas once the text for that canvas has been completely fetched and parsed. With slow connections/slow servers, this can sometimes take a decent amount of time. It would be good if, during this time, the tool bubble could be collapsed and show a spinning circle to indicate that the fetching is in progress.
Ideally this change would include an open/close animation for the tool menu so that when the text has finished fetching and the options (if any of them are enabled) become available, the transition is not too jarring for the user.

Implemented in https://github.com/dbmdz/mirador-textoverlay/commit/520680a2991cefc68d1be88027b457559b06b94d


go.mod: github.com/creack/pty v1.1.11

v1.1.11: Add arm support for OpenBSD
v1.1.10: Fix CTTY to work with go1.15
full diff: https://github.com/creack/pty/compare/v1.1.9...v1.1.11

@dims @cpuguy83 PTAL


 Therefore our effort of matching builds by the actual commit SHA from PRs doesn't always work.
There's a trivial change included here in 05af2ed which also tries to match commits by their related PR. Fingers crossed this is what we need.

reverting the revert (deleting the commenting code)

P.S. this is currently deployed to production.

Tested with a branch from the main repo https://github.com/nodejs/nodejs.org/pull/490. We need a test PR from a nodejs.org fork as well.

See https://github.com/nodejs/nodejs.org/pull/647#issuecomment-208940672 -- this sometimes incorrectly gets outdated builds

Hmm, looks like it's working now. Strange.

@phillipj might as well merge for now?

@Fishrock123 sure enough


Get the entire session object

VoiceLabs has some recommendations for how to use alexa-app to track usage. Currently they document using VoiceInsights.track(req.getSession(), ... but this does not work as expected because the session object you get is an instance of alexa.Session that adds additional functionality and encapsulates some parts of the session. Using req.getSession().details is also kind of ugly and still doesn't work due to #215
It is possible to get the session directly from request.data.session, but I think we want to avoid accessing raw properties as much as possible.
I propose a method, request.getRawSession() that returns a deep copy of the session object as it was passed from Alexa. I'm not in love with that name, though, so I'm open to other suggestions for that and how to handle this issue in general.

Well I slightly disagree with a separate method for just getting the session object. request.data should be returning the original JSON, as noted in alexa-app/index.js at line 176, so maybe we should convert that into a method such as request.getData().

I merged #215 so that at least solves part of the problem, cc: @danielstieber. Not sure what we should do about this one.


Is it possible to add a column at an arbitrary position?

Is it possible to add a column at an arbitrary position? Like for example the first column, or somewhere in the middle?

Yes, just set the 3rd parameter of add column method to some index like:
->addColumn('col', 'content', 1)

Or a much better approach is to just add the column then define the arrangements of display of columns via columns property of dataTables.

Thanks, this works great, although I didn't see it in the docs so it might be worth mentioning (unless I suck at searching).
Good job BTW.


Misleading step to query retained data

In the steps to query retained data, user is told to open the Dynamics Settings page, then select Advanced Find in the command bar. What the user should do is click on "Edit Filters" on a view of the table with retained data and then click on "Change to retained data"
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5f214df6-a230-96b6-25f4-bbed1e3d8cd0
Version Independent ID: 5f214df6-a230-96b6-25f4-bbed1e3d8cd0
Content: View long term retained data in Microsoft Dataverse - Power Apps
Content Source: powerapps-docs/maker/data-platform/data-retention-view.md
Service: powerapps
Sub-service: dataverse-maker
GitHub Login: @Mattp123
Microsoft Alias: matp

Thanks for your comment, @adekola. This issue has been assigned to the doc author for review.

@adekola - Thank you for your feedback! The article has been revised to use the correct steps to open a model-driven app that contains the table and then use Edit filters to be able to make the switch to view retained data.
Closing issue.


Providing a way to store SCP in experience fragments

create the sling:OrderedFolder with jcr:content node to allow for Shared Component Properties

Please merge in latest and resolve codeclimate issues


[Service Bus] Admin client performance note

Summary
The focus of these changes is to add a note about the performance characteristics of the ServiceBusAdministrationClient with guidance to avoid using in performance-critical scenarios.
References and Resources

Stack Overflow: ServiceBusAdministrationClient poor performance

API change check
API changes are not detected in this pull request.


Please add Instructions for setting up GCP

Hello,
Please add the Instructions for setting up GCP.

any update?

Did you figure this out?


advanced install instructions - JDK 7 from Oracle?

Documentation: The advanced install instructions in the wiki say Java 7 from Oracle. However Java 7 no longer seems to be available for Linux or Windows from Oracle. Can the instructions be updated to allow OpenJDK? Or will that not work?

Thanks for the question.
OpenJDK should work, as this is default JDK for AET Vagrant instance now.
Oracle JDK 7 is still available, but you need to sign in to get it.
I've updated wiki: https://github.com/Cognifide/aet/wiki/LinuxAndWindowsSetup#linux-setup


Gas doc revised

Description
Change gas docs and release notes for gas changes
Test Plan
no really

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Help
this is a draft and the content has not been changed yet. Coming soon....


Custom template broken

Steps to reproduce

Make a custom template
Add the template to angularjs slicer
Open console

Expected behaviour
Display the custom template successfuly
Actual behaviour
throw an error "TypeError: Cannot set property 'rzsp' of null" and broke the slicer
Note: this problem also happend in http://angular-slider.github.io/angularjs-slider/index.html

Can you attach the custom template you set and specify what version of angularjs-slider are you using ?

this problem also happend in http://angular-slider.github.io/angularjs-slider/index.html

Ok, the problem happen because in the version 6.4.0 has been introduced a new feature that required the change of the custom template.
We realized only after we released such version that it's not possible to use anymore the old custom template with version 6.4.0 of the library.

The new format for custom template used by 6.4.0 version requires some additional span at the beginning: https://github.com/angular-slider/angularjs-slider/blob/master/src/rzSliderTpl.html

thanks @GMaxera!


:bug: Physical Cluster -> Workload Execution Cluster swap

Summary
Updates old terminology pcluster with wec, and "physical cluster" with "workload execution cluster" or "WEC".
Related issue(s)
Fixes #1071

This PR makes a change to an IDL file and it looks like make codegen has not been run. We maintain the files derived from the IDL in git, using make codegen to update them.

/retest

@namasl there are errors in the "pull-kubestellar-verify" test below.  You will need to look into them.  Click on the "details" link next to the test.

@clubanderson OK, I think I misunderstood @MikeSpreitzer. Upon looking at what the Makefile does, I should not be touching anything that make codegen generates and leave that action to happen on GitHub (rather than my last push, where I ran make codegen). Next push should undo all that.

Yes.  Use go 1.19 and make codegen

/approve

I ran make codegen with go 1.21.1 where I had originally seen an issue, but strangely I'm now seeing no difference between this and go 1.19.  I also checked 1.21.4 (latest), likewise no difference.


Update Composer dependencies (2024-12-11-00-11)

Visual regression test passed!
View the visual regression test report


[system] Add browser tests

This PR experiments with adding in browser tests for the system performance. Try it with running the following command on the root of the project:
yarn perf

It will build the test/perf project, serve the root and start the scripts/perf.js script.

Regarding the folder location. Does it mean that we should move /packages/material-ui-benchmark outside of the packages folder in the future?

Possibly, not necessarily at this moment. if it serves it's purpose than it can stay as a package, it is private anyway.. Don't have strong opinion on this.

@oliviertassinari possibly, not necessarily at this moment. if it serves it's purpose than it can stay as a package, it is private anyway.. Don't have strong opinion on this.

Me neither, I wanted to raise the inconsistency, some backmark in "/foo", some other in "/bar". As long as we have a clear direction on where we want them to be long term, I think that we are good.

How I approach these: packages is for libraries (e.g. something you import or require). scripts is for things you execute. test is for testing.
So far I'm a bit confused what this PR is doing. It titles itself as "tests" but then it only includes benchmarks. A test is something that either passes or fails. I think benchmark makes more sense under scripts or a top level folder (and workspace).

I agree, these are only benchmarks, not tests (my bad here, as I wanted to first implement this as perf tests, but decided to go with just benchmarks initially). Let me then create a benchmark folder in the root and move the app there, as will rename the scripts/perf.js to scripts/benchmark.js (the command as well - yarn benchmark). Would this make sense? @eps1lon @oliviertassinari

@oliviertassinari @eps1lon renamed the command & script to benchmark and moved the app to the root's /benchmark folder. Hopefully this is ready for final round of reviews.

hardcoded development mode is confusing
script doesn't exit
got some unnecessary (promise,object) wrappers

All addressed in mnajdova#9. Feel free to cherry-pick what you agree with.

@eps1lon nice cleanup thanks! Merged

More feedback.

I have run the tests suite twice to see how much reproducibility we can get:

@material-ui/system colors:
Avg: 45.70ms, 37.70ms
styled-system colors:
Avg: 35.30ms, 32.30ms
noop:
Avg: 28.80ms, 28.70ms
@material-ui/system spaces:
Avg: 28.30ms, 31.20ms
styled-system spaces:
Avg: 27.80ms, 28.00ms
@material-ui/system compose:
Avg: 37.40ms, 39.70ms
styled-system compose:
Avg: 37.30ms, 36.70ms
@material-ui/core all-inclusive:
Avg: 44.20ms, 33.30ms
styled-components Box + @material-ui/system:
Avg: 127.70ms, 95.30ms
styled-components Box + styled-system:
Avg: 390.10ms, 87.00ms
Box emotion:
Avg: 85.40ms, 96.10ms
Box @material-ui/styles:
Avg: 122.50ms, 132.40ms
Box styled-components:
Avg: 92.30ms, 89.30ms
Naked styled-components:
Avg: 79.10ms, 85.30ms

Should we consider the average or the mean? It seems that mean if most frequently used.

I was confused to find the benchmark concern not self-contained. It took me a bit of time to understand that they were logic spread between two different folders. I was expecting everything inside /benchmark

Same here. I wanted to consolidate it later into a separate workspace (for future focused installs) but didn't find it important enough to block this PR.

Should we consider the average or the mean? It seems that mean if most frequently used.

From what I've read you usually want different percentiles e.g. 10th, 50% (mean), 95th, and 99th. So we could display a useful selection of those. The DefinitelTyped repo uses mean, best and worst duration which would roughly translate to 5th, 50th and 95th percentile.

Should we consider the average or the mean?

Sorry, I was getting confused with this question. I have confused "mean" with "median" which are both two different type of averages.

I have mixed up "mean" with "median" which are both two different types of averages.

I understood what you meant. I meant median as well (hence percentile). Median is not a type of average.

@eps1lon I guess it depends on the definition. In https://en.wikipedia.org/wiki/Average, they defined an average as "a single number taken as representative of a list of numbers" 🤷♂ 🙃

@eps1lon I guess it depends on the definition.

You conveniently skipped the first part of that quote: "colloquial" which is not the same as a definition. With "mean" I was being colloquial and meant the "arithmetic mean". But I'm not sure why you deflected to "definitions of average".
We want percentiles in benchmarks not discuss what an average is.

I was confused to find the benchmark concern not self-contained. It took me a bit of time to understand that they were logic spread between two different folders. I was expecting everything inside /benchmark

Move the script to the /benchmark/scripts folder. In the future if we want to add more tests like this, we can have benchmark:system that runs the system scripts for example as a pattern.

If you create a scenario that does nothing:
export default function Noop() {
 return null;
}

It reports Avg: 35.00ms. What are we testing? There is an upfront bias that isn't fully stable:
49.00ms
34.00ms
33.00ms
37.00ms
33.00ms
34.00ms
33.00ms
32.00ms
32.00ms
33.00ms

On this to be honest, I am interested in the relative difference between the scenarios we are running. If we have some 30 - 40ms noise on each scenario it won't affect the relative difference. Should we add this noop scenario as a reference, or run it and extract the difference from all examples? I wouldn't change anything regarding this at this moment to be honest. And we can experiment with adding the Profiler numbers later on.

It would be great to log the results of each test as they are running. During the first run, I thought that something was wrong. Turns out, it was running but I needed to wait longer.

Done 👍

It seems that for pure JavaScript object manipulations, relying on Node.js + Benchmark as done in /packages/material-ui-benchmark/, or https://github.com/smooth-code/xstyled/blob/master/benchmarks/system.js, https://github.com/styled-system/styled-system/blob/c3cf5829f43749e688ca667263a51a5c8875d6f9/benchmarks/test.js is what's more reliable. However, it doesn't provide the whole story, once integrated inside styled-components/emotion.

Agree, we should use the browser benchmark for scenarios that run some react code in the browser. I will do another iteration for cleaning up the examples and leaving only the relevant in each of the benchmarks we have currently.

Maybe we could consider using a trace https://github.com/emotion-js/emotion/blob/c85378a204613885a356eaba1480c5151838c458/scripts/benchmarks/run.js#L62 (but the results might be hard to interpret).

I would go with the simplest thing at the start, and if we need to we can alter it in the future. What do you think?

I also wonder about the tradeoff to have the user click on buttons in the UI to run the tests, like done in https://necolas.github.io/react-native-web/benchmarks/ or what we have done so far to measure Unstyled vs JSS vs emotion or even running a page of the docs: https://material-ui.com/performance/table-component/.

If we see problem with this that would be the way to go. However, at this moment, until we see some potential problems, I would keep the command results as it is simpler and does not require any interaction.

I have run the tests suite 3 times to see how much reproducibility we can get

Again if we use this for the relative difference between the scenarios in one run, the numbers should be stable between them in my opinion. I wouldn't use this scenario for comparing with some scenario running in different environment anyway.

Should we consider the average or the ~mean~ median? It seems that mean if most frequently used.

Added median as well as average, I think for start those two numbers should be enough. We are anyway printing all results when running the scenario.
In addition to this, I've changed the components scenario to run 1000 instances of the component instead of 100 so that the numbers are showing biggest difference (tried 10000 as well, but the time for running them was too bug and the relative values were similar, so I decided to stay with 1000)

I have tried to improve the precision of the measurement on https://github.com/mnajdova/material-ui/pull/10, to reduce the uncertainty. If we take the noop case, we go from 34ms ±9ms to 4.63ms ±0.25ms (I have used the mean for the baseline value and the difference between the slowest and faster run divided by two for the ± uncertainty). This was achieved using the following leverages:

use performance.now that gives sub-ms precision.
bypass the JavaScript loading, parsing, evaluation steps. We arguably already track that aspect of the performance with the bundle size.
measure the time spend up to as soon as the layout is finished.

@eps1lon do you know how we can measure up to the composite stage? https://developers.google.com/web/fundamentals/performance/rendering

I've added noop scenario and README.md. I think we should merge the changes from https://github.com/mnajdova/material-ui/pull/10 - thanks @oliviertassinari for trying this different alternative

@eps1lon @oliviertassinari merging this one, had to rebase two times this morning because of conflicts in yarn.lock. If there are other suggestions, I'll do a second iteration.


visitJsonSchema bugs lead to unflattened JSON Schema

🐞 Bug report
Command (mark with an x)

[ ] new
[ ] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
No, this code hasn't been changed in at least a year.
Description
There are two issues in the visitJsonSchema function:

The visitJsonSchema function incorrectly handles 'items' property as a part of propsKeywords while it should be keywords. It's already present in keywords, but overruled due to propsKeywords.
https://github.com/angular/angular-cli/blob/b3ed8aa4ad6736130bd9603ebf681b229c16f2b2/packages/angular_devkit/core/src/json/schema/visitor.ts#L169-L176
https://github.com/angular/angular-cli/blob/b3ed8aa4ad6736130bd9603ebf681b229c16f2b2/packages/angular_devkit/core/src/json/schema/visitor.ts#L153-L156
The visitor passes the grandparent schema object rather than the parent schema when visiting any of the propsKeywords values (sch vs. schema at line 197).
https://github.com/angular/angular-cli/blob/b3ed8aa4ad6736130bd9603ebf681b229c16f2b2/packages/angular_devkit/core/src/json/schema/visitor.ts#L189-L201
This breaks the visitor in flatten as it tries to replace a $ref with the value it references:
https://github.com/angular/angular-cli/blob/b3ed8aa4ad6736130bd9603ebf681b229c16f2b2/packages/angular_devkit/core/src/json/schema/registry.ts#L288

These two bugs each lead to CoreSchemaRegistry#flatten not actually flattening properties inside items.
🔬 Minimal Reproduction
Executing the following file will print { '$ref': '#/definitions/pattern' }
Toggle file
const {json} = require('@angular-devkit/core');

const registry = new json.schema.CoreSchemaRegistry();

registry
  .flatten({
    type: 'object',
    properties: {
      assets: {
        type: 'array',
        items: {
          type: 'object',
          properties: {
            include: {
              $ref: '#/definitions/pattern',
            },
            exclude: {
              $ref: '#/definitions/pattern',
            },
          },
        },
      },
    },
    definitions: {
      pattern: {
        oneOf: [
          {
            type: 'string',
          },
          {
            type: 'array',
            items: {
              type: 'string',
            },
          },
        ],
      },
    },
  })
  .subscribe(flattened => {
    console.log(flattened.properties.assets.items.properties.include);
  });

🔥 Exception or Error
ø
🌍 Your Environment
Present on master, tested on 11.0.5.
Anything else relevant?

Hi @bgotink,
Thanks for great investigation.
The flatten schema method has been deprecated without replacement, as producing a flatten schema document does not in all cases produce a schema with identical behavior to the original.
See: https://json-schema.org/draft/2019-09/json-schema-core.html#rfc.appendix.B.2

Hi @bgotink,
Thanks for great investigation.
The flatten schema method has been deprecated without replacement, as producing a flatten schema document does not in all cases produce a schema with identical behavior to the original.
See: https://json-schema.org/draft/2019-09/json-schema-core.html#rfc.appendix.B.2


New issue creation

This is a new issue

reply

Going to delete this issue

Comment to c.losed issue

Final comment test

Hopefully?


Error: Array to string convertion

Caused by https://github.com/anlutro/laravel-settings/commit/64847e5e0eddd62aaa5b32166fe8ff776ae66252#diff-5f739c62a5526bb1126b48e57a807b63R48
Condition: $default  === null, $key is an array

Should be fixed in 0.8.3 https://github.com/anlutro/laravel-settings/commit/851dd685b5659edc07a34df0a5415217a6595654

Closing, please re-open if there is any issues.

@bweston92
Thanks for the fix!
There is an option to support defaults for multiply keys (not tested):
if ($default === NULL) {
    $default = Arr::get(Config::get('settings.defaults'), $key);
}


Merge opnesuse families into one

@Itxaka IMO we still need the family, first because it lets us merge distros like fedora, alma and rocky into a rhel family. Second because it allows the community to try Kairosifying other distros we don't really support, for example if you use Linux Mint or elementary as your base image, you can use the Ubuntu family, if you have PostmarketOS as your base image you can use the alpine family.

for the nvidia one, indeed it could be part of Ubuntu, we just felt that this is so unique and probably will not change often, so it was more at risk of braking if merged with the Ubuntu dockerfile. Specially because for the orin it only works with one version of ubuntu even.

@Itxaka IMO we still need the family, first because it lets us merge distros like fedora, alma and rocky into a rhel family. Second because it allows the community to try Kairosifying other distros we don't really support, for example if you use Linux Mint or elementary as your base image, you can use the Ubuntu family, if you have PostmarketOS as your base image you can use the alpine family.

Thanks for the explanation!


(#889) change breakpoint/layout event order

fix: #889
In Responsive, the onBreakpointChange event occurs after the
onLayoutChange event. So if the onLayoutChange event is used to save
the layout based upon the current breakpoint, the save will overwrite
the previous layout becuase the breakpoint you would be updating will
be the previous layout before changing breakpoints.
This PR will swap the order to onBreakpointChange -> onLayoutChange

Any updates on merging this?

I too am very keen on seeing this merged

Any blocking issues for this that prevent the merge? It would solve the problems I currently have as well :)

Any update?

Thanks!

will release soon?


Remove preceding comma from message.reply()

Apologies if I'm overlooking something here, however I personally find it irritating how message.reply() puts a comma after the @mention automatically for me-- I'd rather do it myself, when I want to.
Would it be possible for this to be changed, and/or could somebody point me in the direction of what piece of code to edit if I want to change this for myself?
EDIT: I believe I have found the guilty line of code; line 394 of Message.js if I'm not mistaken :P

You know you could just do:
message.channel.sendMessage(`${message.author} blabla`);

to achieve the same thing.

message.reply has always had the comma, there is no point changing it now. I would use Crawl's suggestion.

As a side note, the documentation link in the readme always links to the latest release's documentation; you'll have to specify which documentation you want to see after loading the page.

message.reply has always had the comma, there is no point changing it now. I would use Crawl's suggestion.

No point changing it because of backwards-compatibility issues? The only thing is that Crawl's suggestion, in my opinion, negates the whole point of having a .reply() shortcut; it's just a bit bulky. That's exactly why I've been using .reply() in the first place.
If you don't want to remove the comma because it would affect pre-existing code depending on this module then that's fine, and I don't want to cause a fuss about that. But if that's not the case, then I don't see what the harm would be in removing it. I've forked my own version of discord.js to use with my bot, so in all honesty this isn't too much of a big deal for me.


Update Zendesk.java

Fixed the template for URI to correctly accept passed in token

This simple change should allow repeated uploads using the same token

I have made the changes in #123. Thank you for your contribution.


20-resolv.conf: improve the sitation of working with systemd

systemd's resolvconf implementation ignores the protocol part. See https://github.com/systemd/systemd/issues/25032.
When using 'dhcp server + dns server + dhcpcd + systemd', we get an integration issue, that is dhcpcd runs 'resolvconf -d eth0.ra', yet systemd's resolvconf treats it as eth0. This will delete the DNS information set by 'resolvconf -a eth0.dhcp'.
Fortunately, 20-resolv.conf has the ability to build the resolv.conf file contents itself. We can just pass the generated contents to systemd's resolvconf. This way, the DNS information is not incorrectly deleted. Also, it does not cause behavior regression for dhcpcd in other cases.
Signed-off-by: Chen Qi<EMAIL_ADDRESS>

@rsmarples kindly ping

The bottom line is that I will not merge this or anything like it into dhcpcd.
Any issues with the system supplied resolvconf should be fixed in resolvconf.
I say this because it's really hard for the script to know which versions of resolvctl work and which don't.
It used to work fine, now it doesn't. I'm sure it will get fixed upstream eventually.
The more important matter is that you are bypassing resolvconf entirely for this corner case and other parts of the system might rely on resolvconf returning correct data rather than /etc/resolv.conf being "correct".

@rsmarples

Looking at the git history and its current status, systemd's resolvconf (resolvectl) has never supported the .protocol suffix.
I'm not bypassing resolvconf, because the dhcpcd generated contents are supplied to resolvconf. In this way, other parts of the system using resolvconf can continue to work. If I still miss something, please let me know.

Anyway, I understand your opinion and respect your choice.

OK, so all resolvconf version ever don't actually care about the .protocol suffix. You could do echo "nameserver <IP_ADDRESS>" | resolvconf -a this_interface.is_usless and it will work just fine. interface[.protocol] is just suggestion.
If systemd wants to come along and start enforcing otherwise that's a systemd problem, not a dhcpcd problem.


undefined method `columns_hash' for MetaSearch::Searches::User:Class

I've just installed active_admin and generated support for my User model. When I click on the Users Tab, I get this error:
NoMethodError in Admin/users#index
undefined method `columns_hash' for MetaSearch::Searches::User:Class

lib/form_field_data.rb:5:in `add_default_name_and_id_with_field_data'
actionpack (3.0.9) lib/action_view/helpers/form_helper.rb:1056:in `add_default_name_and_id_for_value'
actionpack (3.0.9) lib/action_view/helpers/form_helper.rb:887:in `to_label_tag'
actionpack (3.0.9) lib/action_view/helpers/form_helper.rb:606:in `label'
actionpack (3.0.9) lib/action_view/helpers/form_helper.rb:1179:in `label'
formtastic (1.2.4) lib/formtastic.rb:448:in `label'

I'm having a similar issue.
undefined method `name_contains' for #<MetaSearch::Searches::Key:0x00000100c79e20>

meta_search (1.1.1) lib/meta_search/builder.rb:136:in `method_missing'
actionpack (3.1.1) lib/action_view/helpers/form_helper.rb:1126:in `value_before_type_cast'
actionpack (3.1.1) lib/action_view/helpers/form_helper.rb:1114:in `value_before_type_cast'
actionpack (3.1.1) lib/action_view/helpers/form_helper.rb:1010:in `block in to_input_field_tag'
actionpack (3.1.1) lib/action_view/helpers/form_helper.rb:1010:in `fetch'
actionpack (3.1.1) lib/action_view/helpers/form_helper.rb:1010:in `to_input_field_tag'
actionpack (3.1.1) lib/action_view/helpers/form_helper.rb:674:in `text_field'
actionpack (3.1.1) lib/action_view/helpers/form_helper.rb:1244:in `text_field'
activeadmin (0.3.2) lib/active_admin/view_helpers/filter_form_helper.rb:58:in `filter_string_input'
activeadmin (0.3.2) lib/active_admin/view_helpers/filter_form_helper.rb:47:in `block in filter'

It seems to be an issue with my many to many relationship models. The models are has_many :through. I added a filter on the through model and was able to get the 2 tabs to work but none of the relate data is there.

I can't reproduce this issue with  has and belong to many + filters. Closing it.

My issue was with has_many :through not has and belongs to many relationships.

@nvick Could you post a gist of your models, schema + active admin register blocks?

@pcreux I will post something later today. I removed it from the original project, but should be able to whip the basic structure back up.
Nate Vick
Sent from my iPhone
On Feb 20, 2012, at 6:09 AM, Philippe Creux<EMAIL_ADDRESS>wrote:

@nvick Could you post a gist of your models, schema + active admin register blocks?

Reply to this email directly or view it on GitHub:
https://github.com/gregbell/active_admin/issues/269#issuecomment-4054119

Hi, i have the same problem. undefined method `dr_or_cr_contains' for #MetaSearch::Searches::Tran:0x00000103604100. so i renamed the field from dr_or_cr to dr_cr, destroyed the activeadmin view and generated it again and it still read the same error. it seems that it is not refreshing the data structure and even when i go to the "model/new" page, the field is still the old one.


CEVA: add ceva platform xc5 xm6 support

Summary
CEVA: add ceva platform xc5 xm6 support
which code base from: https://github.com/FishsemiCode/nuttx
Impact
New arch platform
Testing

Would a README with links to information (mfg, datasheets) add value here?

Here is some introduction info:
https://www.ceva-dsp.com/product/ceva-xm6/
https://www.ceva-dsp.com/product/ceva-xc16/
Basically, these DSPs are designed for Vision and Modem.

@GUIDINGLI I just noticed that this CEVA arch still missing some board inclusion to use it and catch some issues that could be introduced into it. Please consider adding some (low cost) board powered by XM6 and XC16

it's hard since CEVA never release the free toolchain as far as I know.


Fixes #45

Adjust version to 0.2.0-SNAPSHOT to align with the discussion in #45 to prepare for initial deploy to maven central.

Codecov Report

Merging #46 into development will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             development      #46   +/-   ##
==============================================
  Coverage          37.05%   37.05%
  Complexity            90       90
==============================================
  Files                 24       24
  Lines                850      850
  Branches              86       86
==============================================
  Hits                 315      315
  Misses               507      507
  Partials              28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b241c...782e4b4. Read the comment docs.


[Usage]: speculative OutOfMemoryError:

Your current environment
I deploy Qwen2.5-32B-Instruct with speculative_model Qwen2.5-7B-Instruct, and my gpu is NVIDIA A100-SXM4-40GB;
And get OutOfMemoryError;
In my opinion，32B model will be deployed in 4 GPUs due to tensor parallelism and will allocate about 16G memory；However, I am not sure how the speculative model is deployed. Will it be deployed on GPU0? But GPU0 should still have around 24GB of memory, which should be sufficient to deploy a 7B model.
CUDA_VISIBLE_DEVICES=0,1,2,3 python -m vllm.entrypoints.openai.api_server --host <IP_ADDRESS> --port 9000 --model Qwen2.5-32B-Instruct -tp 4 --max-model-len 1000 --speculative_model Qwen2.5-7B-Instruct --use-v2-block-manager --num_speculative_tokens 5  --speculative-max-model-len 1000 --gpu_memory_utilization 0.9

torch.OutOfMemoryError: CUDA out of memory. Tried to allocate 72.00 MiB. GPU 0 has a total capacity of 39.56 GiB of which 60.81 MiB is free. Process 3179876 has 1.62 GiB memory in use. Process 3179877 has 1.62 GiB memory in use. Including non-PyTorch memory, this process has 34.61 GiB memory in use. Process 3179875 has 1.62 GiB memory in use. Of the allocated memory 28.75 GiB is allocated by PyTorch, with 28.60 MiB allocated in private pools (e.g., CUDA Graphs), and 384.74 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True to avoid fragmentation.  See documentation for Memory Management  (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)

How would you like to use vllm
I want to run inference of a [specific model](put link here). I don't know how to integrate it with vllm.
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Although you can use --speculative-draft-tensor-parallel-size 4 to configure the tp of draft model, currently vllm doesn't support draft tp other than 1 unfortunately. Besides the weight, vllm also needs to allocate some GPU mem for KVCache (both for the target model and the draft model), so the consumed mem is larger than you thought. Also, you have set --gpu_memory_utilization 0.9. So I recommend you set gpu_memory_utilization to 0.95, and try using a quantized draft model, such as Qwen2.5-7B-Instruct-GPTQ-Int4.

Although you can use --speculative-draft-tensor-parallel-size 4 to configure the tp of draft model, currently vllm doesn't support draft tp other than 1 unfortunately. Besides the weight, vllm also needs to allocate some GPU mem for KVCache (both for the target model and the draft model), so the consumed mem is larger than you thought. Also, you have set --gpu_memory_utilization 0.9. So I recommend you set gpu_memory_utilization to 0.95, and try using a quantized draft model, such as Qwen2.5-7B-Instruct-GPTQ-Int4.

thank you for answer.
Will the draft model be deployed on GPU0? And if draft model can be deployed on another gpu such as gpu5?


ColdFusion Nested Comments Not Highlighting Correctly

(Original issue 978 created by kassah on 2014-04-25T18:38:53.508046+00:00)
ColdFusion supports nested comments (unlike HTML).
Could you please update the comment parser to highlight nested comments correctly in the example given in the docs below:
http://livedocs.adobe.com/coldfusion/8/Elements_03.html

(Original issue 978 last updated on 2014-10-07T20:39:37.220528+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by jaingaurav2 on 2014-04-27T04:00:25.749791+00:00)
Pull request #339 should address this issue

(Original comment by tshatch on 2014-10-07T20:39:37.233991+00:00)
PR339 is merged.


lazyerror option

By default, shader group layers execute lazily, meaning the node will
not execute until/unless one of its outputs is needed by a downstream
layer, and if in the course of optimization all of its outgoing
connections are eliminated, then the entire node will be pruned from
the shader graph. But if the node contained error() calls (say, to do
sanity check on parameters or other conditions), those error calls
will never be issued, possibly masking a problem.
This patch introduces a new ShadingSystem option:
"lazyerror" (default: 1) -- when set to 0, it means that the presence
in a shader layer of an error() call that can't be constant-folded
away will make the layer will execute unconditionally, thereby making
the error() call run even if the layer's outputs are never "pulled" by
any downstream layer.
Furthermore, if lazyerror=0, if you have shaders that after
optimization still have error calls (and thus will run the layer
unditionally), then if option "opt_warnings" is nonzero, you will get
a warning about the presence of a not-optimized-away error call (you
may want to know about this for performance reasons, if your intent
was that all error calls should be resolveable by the optimizer).
Along the way I also added a few more optimization-debugging logging
messages, including understanding exactly when and why unused connections
are pruned.
Signed-off-by: Larry Gritz<EMAIL_ADDRESS>

@fpsunflower @lkerley any comments?

Code is looking ok to me. How did the benchmarks turn out?

Will run them tonight to be sure. Just wanted code to look ok so that if benchmarks are neutral I can do a merge.

@lkerley may need to give you some new scenes since they've peppered many more error messages everywhere in the shaders compared to the scenes we have

The way I imagined this working is that I'd add it as an option to our renderer, with the default being (just like in OSL) the old behavior. So the shading team can turn it on for individual development to get themselves to the point where all the shaders are policed up. Then in a second round of changes, we can change the renderer default to enable it all the time.

Makes sense. Should be a safe change for now then.

Update on benchmarks:
I tested a 3-way comparison across a wide variety of production scenes:

Current renderer (before these OSL changes).
These changes, but with default values (should match old behavior and perf).
New options enabled: lazyerror=0, opt_warnings=1 (note: our renderer exits immediately upon a true error)

I'm pleased to report that (1) and (2) have identical performance, so it seems safe to merge.
(3) turned out to be worthless -- because the shaders used by the scenes haven't been scrubbed with this change in mind, some tests ran much slower (because of layers that run unconditionally now, though no errors were hit), and some have much shorter runtime (because -- they trip errors that were elided before).


Revert "chore(deps): update dependency eslint-plugin-n to v17"

Reverts bcgov/quickstart-openshift#1910

Held back for now by deps.


Support safetensors export

Feature
This commit implements the following features:

support saving checkpoint as safetensors (more commonly used format)
support sharding checkpoints (which is important for very large models)

Most of the codes are borrowed from https://github.com/huggingface/transformers/blob/v4.45.1/src/transformers/modeling_utils.py#L2490
Usage
For pytorch_model.bin export
python zero_to_fp32.py . output_dir/

For  model.safetensors export
python zero_to_fp32.py . output_dir/ --safe_serialization

I think DeepSpeed is designed to work in the environment where HF is not installed.
requirements/requirements.txt doesn't have transformer (requirements/requirements-dev.txt does) and there are try-except to imports for transformers (example). Can we have local import to attempt to load transformers and huggingface_hub only when the safetensor option is specified? We can also show an error message when the option is enabled and the modules are not available.

improt issue has been resolved

Thank you @xu-song! The formatting test fails, can you check it?

formatting has been fixed


Allow tsconfig strictNullChecks option

Adds support for tsconfig's strictNullChecks option added in https://github.com/Microsoft/TypeScript/pull/7140.

Hi @seanchas116,
just to let you know: I experienced the same error like you running Travis CI integration.
I built a PR for that issue: #949

just to let you know: I experienced the same error like you running Travis CI integration.

Yeah. The build broke at some point and we haven't had the time to look at it :rose:

https://github.com/TypeStrong/atom-typescript/releases/tag/v8.9.2 :rose:


Kinda fixes cursor not falling in place while editing a file by not changing font styles

Kinda fixes #6. It's not really a fix because we are literally stopping Better GitHub to do what it does the best when a user is editing a file.
Check the "code" section of this PR for a comment explaining why, what and how I am closing the issue #6  for time being.

@aahnik I hope this makes this extension a little better for you, me and other to use. As discussed on the issue #6 , I have disabled the font styles changes if a user is editing a file. Will send this version for release on Chrome and Firefox stores later tonight or tomorrow. They usually verify and publish the new version in a few hours after I send the application.
Check dev.to DMs if you can :D


forcePullImage resets after editing app in UI

I've noticed that when you make an edit via the web UI to an app, it will revert forcePullImage to false after a seemingly random number of config changes.
It can be reset manually by hitting the api, but it is something that has become an annoyance that is keeping me from moving more things into marathon.

@Punkrex Thanks for reporting this!

I think that the UI should generally preserve fields it does not know about. Do you agree @philipnrmn ? Should we create a separate issue for that?

@kolloch absolutely, we should either create a new issue or expand this issue to the general case.

According to this comment on the generalised issue, there is a bug directly related to forcePullImage which is separate to the general case.
I'd like to fix it but unfortunately I can't reproduce it. Can anybody help me with that? Maybe @aldipower?

We exposing forcePullImage in the application edit modal now, so it shouldn't reset anymore.
https://github.com/mesosphere/marathon-ui/pull/498
Of course this doesn't solve the general issue that unknown options in nested objects aren't preserved.
https://github.com/mesosphere/marathon/issues/2693#issuecomment-159891611
But I think we can close this specfic issue here after https://github.com/mesosphere/marathon-ui/pull/498 is merged.


Question: preceding zeros in IPv4 address

Is this bug report about an incorrectly validated email address?

[ ] Yes
[x] No

If yes, what is the email address?

[ ] Valid
[ ] Invalid

If no, please describe the bug
Should e.g. 0<IP_ADDRESS> be considered a valid address? Or even<PHONE_NUMBER>.0.0.1? Now it validates correctly - what do you think?
Additional context

Thanks for this report as well @harrel56. Agree that those addresses should not be valid, will work on a fix for this.

Version 1.6.2 is now released with the fix. Thanks again for reporting this bug @harrel56!

@RohanNagar Hmm, what about cases where IP part has correct length but still starts witch zeros? Like <IP_ADDRESS> or <IP_ADDRESS>? Can be these considered valid?

Yeah, I don't really have knowledge in this area so it's fine - just wanted to ensure it was intended :)


[Question] How do I change the volume value for who connected to my server earlier?

I know I can set convar in server.cfg file. but it won't affect the previous players. Is there a way to manually change the volume for previous players?

No, this is stated in the config that you can't.


Feature: add different exchange rates

I see when you click on details it gives an approximate dollar value which I assume is USD. It would be cool if you could change that somewhere.
Also being able to see dollar value on transaction list would be good for a glance to see how much you have. And how much you've spent recently.

I see when you click on details it gives an approximate dollar value which I assume is USD. It would be cool if you could change that somewhere.

I't already possible, although a bit unintuitive: on "send" and "request payment" popups one can switch between USD, EUR and CNY and the choice affects the whole application. I should probably transfer that to a settings popup.

Also being able to see dollar value on transaction list would be good for a glance to see how much you have.

Yes, this one is in the works.

Any works on extending that for more currencies? Happy to help if you point me in the right direction

It's a bit tricky. The goal here is to be fail-safe so wallet pulls rates randomly from three different sources (https://github.com/btcontract/wallet/blob/master/app/src/main/java/com/btcontract/wallet/helper/PeriodicHttp.scala#L69-L73, maybe more in future), their pair sets are not identical and they even add/remove them from time to time.
So I just picked three most popular and less likely to be removed. This can be extended of course with some work-arounds for removed pairs but it's not my priority atm.


Added LTCWM site on the General Coding advice section

Oh sorry for that. How do I correct it?

Can you please enumerate which line I should reduce the whitespaces?


Make the database connection user configurable

The database user used in development can be specified now by the
presence of an environment variable called DATABASE_USER which should be
set to the username of a user with postrgres permissions.
As a drive-by fix, also removed log files from the repo.

I'm closing this PR as it has been open for a considerable amount of time and we're trying to cut down the number of orphaned PRs in alphagov.


Support skip teardown from os env

Short description:
Support skip teardown for any resource by export os environment
for example:
export VirtualMachineInstanceNOTEARDOWN will skip teardown for VirtualMachineInstance resources
What this PR does / why we need it:
For debugging failed resources

/verified

/approve


feat: run command match when only one exists

What does this PR do?
If the user enters a partial command and there's only one match, then automatically run that command
What issues does this PR fix or reference?
[skip-validate-pr]

Nice! <3


OneDrive.exe /allusers - per machine installation

Hi,
Can you tell me when the preview of the "OneDrive per machine installation" will be released?
Greetings Holger

@HSN42  - thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:  https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

@officedocsbot close


Change name of config/lib to config/deps

I saw someone giving the recommendation "if it doesn't start just remove /lib from the hass config dir and start again".
Despite this being OK and helpful advice when confronted with some startup errors, I am having visions of people making their systems unbootable when they remove the wrong lib directory.

I assume that you are referring to /lib, /usr/lib, etc. on a Linux system. As a regular user you can't delete those directories. There is always a chance that users render their systems into something that is no longer working by deleting a directory as root, updating python packages, or killing their init system. As long as there is a clear statement about the parent directory of the directory which is causing problems I see no issue here.
Most directory names we use in the config dir have already an equal somewhere else (at least for lib, www, or downloads, not sure about config itself or what the FHS says, probably nothing). The chances for name collisions are lower with deps but still there and using 6c6962 would be a very user-unfriendly options. I personally don't see much benefit of the renaming the lib directory.

Yes, /lib is just about the worst directory to accidentally delete or move around because it contains ld.so and libc. And the users who are most likely to make this mistake are (in my mind) those that solve permission issues by running everything as root.

I'm down for that.


Doc rewrites for VirtControllerDown (take two)

@apinnick please review the changes at your convenience.

@sradco LGTM

Can we squash the commits to have only one?

@sradco there you go :-)


Task switch error when evaluating simple expression

I'm trying to take gradients through the expression evaluation scheme in DynamicExpressions.jl for a simple expression, but getting a task switch error.
Any tips to debug this?

Can you see if #549 fixes this?

I see this now (maybe the original error was solved?)

With Forward, I get similar warnings about the recursive types, and then:
julia> Enzyme.autodiff(f, Forward, Duplicated(X, bX), Duplicated(y, by))
()

Is it erroring silently maybe?

No that is fine f returns nothing. So the output is in bX and bY

Thanks. Strangely bX isn't updated though. It is still zero:
using DynamicExpressions
using Enzyme

x1 = Node(; feature=1)
operators = OperatorEnum(;binary_operators=[+, -, *, /], unary_operators=[sin, cos, exp, tanh]);
expression = cos(x1 - 3.2)

X = randn(1, 5);
bX = zero(X);
y = zeros(1);
by = zero(y);

function f(X, y)
    out, _ = eval_tree_array(expression, X, operators; turbo=false)
    y[1] = sum(out)
    return nothing
end

Enzyme.autodiff(f, Forward, Duplicated(X, bX), Duplicated(y, by))

# bX is still equal to its original value
# by and y are equal to sum(cos(x - 3.2)).

bY needs to be seeded https://enzyme.mit.edu/julia/generated/autodiff/#Forward-mode

Thanks. Still nothing though... maybe there's a silent bug somewhere?
using DynamicExpressions
using Enzyme

x1 = Node(; feature=1)
operators = OperatorEnum(;binary_operators=[+, -, *, /], unary_operators=[sin, cos, exp, tanh]);
expression = cos(x1 - 3.2)

X = randn(1, 5);
bX = zero(X); bX .= 1;
y = zeros(1);
by = zero(y); by .= 1;

function f(X, y)
    out, _ = eval_tree_array(expression, X, operators; turbo=false)
    y[1] = sum(out)
    return nothing
end

Enzyme.autodiff(f, Forward, Duplicated(X, bX), Duplicated(y, by))

I have no clue how DynamicExpressions works ;) so that is very much possible. There are a couple of codepatterns that can lead to zero gradient. As an example global variables are inactive by default. Can you try to minimize your dependence on DynamicExpressions and see if you can find a standalone MWE? (Also probably makes sense to open a new issue)

Sure thing; this is basically how it works:
struct OperatorEnum
    binops::Vector{Function}
    unaops::Vector{Function}
end

struct Node
    degree::Int
    constant::Bool
    feature::Int
    val::Float64
    op::Int
    l::Node
    r::Node

    # Leaf node specifying X[feature, :]
    Node(feature::Int) = new(0, false, feature)
    # Leaf node specifying a constant value
    Node(val::Float64) = new(0, true, 0, val)
    # Branch node with a unary operator
    Node(op::Int, l::Node) = new(1, false, 0, 0.0, op, l)
    # Branch node with a binary operator
    Node(op::Int, l::Node, r::Node) = new(2, false, 0, 0.0, op, l, r)
end

# Recursive depth-first evaluation of tree:
function eval_expression(tree, X::Array{T,2}, operators)::Array{T,1} where T
    if tree.degree == 0
        if tree.constant
            return fill(tree.val, size(X, 2))
        else
            return X[tree.feature, :]
        end
    elseif tree.degree == 1
        l = eval_expression(tree.l, X, operators)
        return deg1_kernel(operators.unaops[tree.op], l)
    else
        l = eval_expression(tree.l, X, operators)
        r = eval_expression(tree.r, X, operators)
        return deg2_kernel(operators.binops[tree.op], l, r)
    end
end

function deg1_kernel(op::F, l::Array{T,1})::Array{T,1} where {F,T}
    op.(l)
end
function deg2_kernel(op::F, l::Array{T,1}, r::Array{T,1})::Array{T,1} where F
    op.(l, r)
end

function f(X, y)
    out = eval_expression(tree, X, operators)
    y[1] = sum(out)
    return nothing
end

operators = OperatorEnum([+, -, *, /], [sin, cos, exp, tanh])

# Create tree representing cos(x1 - 3.4):
tree = Node(2, Node(2, Node(1), Node(3.4)))

X = randn(1, 5)
bX = zero(X); bX .= 1
y = zeros(1)
by = zero(y); by .= 1

Enzyme.autodiff(f, Forward, Duplicated(X, bX), Duplicated(y, by))

Can it work with recursive functions? Maybe that's it?


Add real-sim LIBSVM dataset

Codecov Report

Merging #155 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   79.26%   79.26%
=======================================
  Files          12       12
  Lines        1008     1008
  Branches      147      147
=======================================
  Hits          799      799
  Misses        168      168
  Partials       41       41

Impacted Files
Coverage Δ

celer/datasets/libsvm.py
21.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b39cdb0...8ded0ff. Read the comment docs.


Focus loss when leaving a field inside of FieldGroupTemplate

Describe the bug
We have form elements inside of a FieldGroupTemplate. When a form-field inside of this FieldGroupTemplate is changed and you hit the [Tab] button, the form completely loses focus.
To Reproduce
Steps to reproduce the behavior:
We have form elements inside of a FieldGroupTemplate. When a form-field inside of this FieldGroupTemplate is changed and you hit the [Tab] button, the form completely loses focus.
Expected behavior
When I hit tab, I expect the next element in the form to receive focus.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: MacOS
Browser: Chrome
Version 124.0.6367.201

Additional context
After digging into why this is happening I have found the following:
The createPConnectComponent function creates a new class-component every time it is executed, as a result when you have a component that uses this function (such as FieldGroupTemplate or Reference); when the component re-renders, and createPConnectComponent is executed again, React views the resulting JSX as completely new- because the rendered component is "different".
Because the JSX is seen as new, this means the HTML element which had focus is removed from the DOM and replaced with a new element (instead of updated).
If I edit<EMAIL_ADDRESS>and move the class definition outside of the function; the issue goes away completely.

Hi @wimbarelds ,
Thanks for reporting this issue, it has been fixed as part of React SDK 24.1.10 version and you can check the changes in this PR: https://github.com/pegasystems/react-sdk-components/pull/363
Thanks,
Siva


Apply style guidelines to protocol documentation - Closes #546

The following changes are done:

use lower case for transaction names
use sentence case for titles
change "Beddows" to "beddows"
add correct references in the serialization section

1. * There is one capitalized Unlock Transaction left at the bottom of "1.accounts"

2. * in 2.transactions line 48, there is a "Transaction Types section" which should be "Transaction types".

3. * in 2.transactions line 100, "Punishment of Lisk-BFT Protocol Violations" ==> "Punishment of Lisk-BFT protocol violations"

4. * in 3.blocks, line 52: "Rewards and Fees" ==> "Rewards and fees"

the rest LGTM

All changes applied plus some extra fixes that had to be done.


Expose a function to create a logging provider for Google.Cloud.Diagnostics.AspNetCore

ASP.NET Core 2.0 adds logging providers in a slightly different way than 1.0 did.  To allow for supporting the best way to add a logging provider in ASP.NET Core 2.0 we should expose a provider.
cc: @csells

Also update docs on GH and cloud.google.com/docs as appropriate.

If you look at the section "How to add providers" You can see the suggested ways of adding providers in 1.0 and 2.0.
Using the 1.0 method works both in 1.0 and 2.0 with the ILoggingFactory.  The ILoggingBuilder is used only in 2.0.
cc: @jskeet

We can add a expose a function to create a logging provider so a user would call:
 loggingBuilder.AddProvider(GoogleLogger.Provider("[GOOGLE-PROJECT-ID]"))"


feature: add support for cometMock directive for chains

Overview
Since we are running full chains, sometimes it is hard to get some unhappy path tests, forcing the CometBTF layer to behave a certain way. It would be a good feature to run cometMock which mocks the CometBTF.
Proposal
Users should be able to easily specify a directive for the chain to use CometMock by enabling it. Config should look something like:
chains:
- name: chain-1
  type: cosmos
  numValidators: 4
  cometMock:
    enabled: true
    image: <custom image of cometMock>

Design

Run an additional deployment/statefulset with the chain
Run all the validators with an external tendermint flag
Spin up CometMock with address of all the validators (might have to wait for all validators to spin up first)

CC: @p-offtermatt

In initial support of cometmock, we will only support chain based cometmock. Currently the cometmock does not work well with grpc, hence relayer support is limited.
It will be added with future support in cometmock itself.


"event malformed: event JSON missing type key" during initial sync

ss_sync  | 21:53:56 ERR V2: failed to initialise room error="events malformed: event JSON missing type key" room=!BAXLHOFjvDKUeLafmO:matrix.org state=8231

presumably it's checking for "", which is actually a valid event type (albeit silly).

Which version of the proxy are you running?
Current logic accounts for "": https://github.com/matrix-org/sliding-sync/blob/066327d407faab80f9be4bd691593d0cb28402d1/state/event_table.go#L60-L62

Suspect fixed in https://github.com/matrix-org/sliding-sync/pull/224

Which version of the proxy are you running?
0.99.4

Thanks, that's reassuring as #224 landed in v0.99.5.
Cross-referencing the event with matrix.org's DB, I can see that there's an event with type = "". So I'm pretty confident that this should be fixed going forward. Thanks for spotting.

I don't know how I managed to deploy 0.99.4 yesterday when 0.99.5 has clearly been there for 2 weeks already


Reinstate icon for GitHub link in navbar

Access to Font at 'https://www.tdwg.org/theme/fonts/font-awesome/fontawesome-webfont.ttf?v=4.7.0' from origin 'https://dwc.tdwg.org' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://dwc.tdwg.org' is therefore not allowed access.

Once fixed, https://github.com/tdwg/dwc/commit/f1b6dfbfc8fe9a97e010057e72047ee540ad5085 should be reverted.

No one has complained, I will leave this as the word GitHub (which is likely more readable).


Mobile onboarding/connect-wallet screens

Description
Adjusted the onboarding screen to be mobile friendly.
Adjusted the connect-wallet page to be mobile friendly including error toasts and kado pop up.
Adjusted the privacy screen to be mobile friendly.
Closes #110
Screenshots (if applicable)
https://github.com/Kryha/KREAd/assets/54764628/f7f28943-f611-4eb1-b6c6-f33e0f33da1b
Checklist
Make sure all items are checked before submitting the pull request. Remove any items that are not applicable.

[x] The PR title is clear and concise.
[x] Are there changes in the /fronted folder? Make sure cd frontend && yarn build runs successfully.;

the first paragraph in the "Who we are" section has some indentation issues

would be good to add some top margin/padding to the Who we are title

@carlos-kryha I fixed the identation issue by removing the newline characters from the text, now they can take the whole space freely. Didnt seem to affect the desktop version in a bad way.
Also added padding to the "Who we are section". Let me know if it needs some more adjusting.

@carlos-kryha I fixed the identation issue by removing the newline characters from the text, now they can take the whole space freely. Didnt seem to affect the desktop version in a bad way.
Also added padding to the "Who we are section". Let me know if it needs some more adjusting.

oh right, I didn't realize we used newlines in the text consts that's kind of bad. Looking good now tho


Import model from plain text

Like https://github.com/severinsimmler/chaine/issues/12, only the other way round

Check if this even possible

Check if this even possible

And learn more about model serialization in general

And learn more about model serialization in general


[BUG] Supporting MIDI Bytes Stream based on series of CIN=0xf in USB MIDI 1.0 devices

Describe the bug
The new USBMidi2.sys driver currently only handles special cases of single byte MIDI transfers like system realtime messages.
Apparently there are devices in market that use single byte transfer to send MIDI byte stream instead of converting to optimized other CIN message types - ie it could take 3 USB packet transfers to send a note on instead of 1.
To Reproduce
Currently do not have an example device to create this issue.
Expected behavior
The constructed byte stream should be converted to appropriate UMP data.

Going to review how to implement with existing architecture. Trying to avoid a large rewrite.

Option is, these type of devices must be used with old USB MIDI 1.0 driver.

 Yikes.

Going to review how to implement with existing architecture. Trying to avoid a large rewrite.

Don't change to support this unless we find it's a meaningful percentage of devices.  Requiring them to use the old driver is also reasonable if this isn't some majority of devices.
Do you know the make/model of any of the devices? I'll see if it's something I have around, or can get.

Do you know the make/model of any of the devices? I'll see if it's something I have around, or can get.

I do not - just heard that they exist.
Perhaps something to bring up on Wednesday, maybe someone in AMEI knows. But I was also going to look into trying to implement on ProtoZOA if it is determined we need to support.
I think it is really rare case. @AmeNote-MikeKent do you have any comment?


Support for maintenance mode profile configuration

Issue Type

[ ] Template enhancement
[x] Role enhancement
[ ] Documentation enhancement (avd.sh)

Is your feature request related to a problem? Please describe.
We have to adjust the maintenance mode profile configuration on all L3/MLAG-Leaf switches to make maintenance mode work in our environment.
Describe the solution you'd like
We have to configure a maintenance profile interface with certain values like the following one and make it the default.
maintenance
   profile interface int_maint default
   !
   profile interface int_maint
      rate-monitoring load-interval 100
      rate-monitoring threshold 1000
      shutdown max-delay 100

There is currently no template available within the eos_cli_config_gen role.
The data model could perhaps look like this:
maintenance:
  profile:
    interface:
      < profile_interface_1 >:
        rate_monitoring:
          load_interval: < seconds >
          threshold: < kbps >
        shutdown:
          max_delay: < seconds >
        default: < true | false >

Describe alternatives you've considered
The current alternative is, to create a config_let within CVP and bind it to the containers of our leafs manually within CVP or "automated" by adding the config_let via AVD.
Our goal is that Ansible code is the single source of configuration.
Additional context
Add any other context or screenshots about the feature request here.

Looking good so far. If anyone is up for it, please add unit and group.
I can see that group is not showing up in ? list, but it is there.

maintenance:
  default_interface_profile: <interface_profile_1>
  default_bgp_profile: < bgp_profile_1 >
  default_unit_profile: < unit_profile_1 >
  interface_profiles:
    < interface_profile_1 >:
      rate_monitoring:
        load_interval: < seconds >
        threshold: < kbps >
      shutdown:
        max_delay: < seconds >
  bgp_profiles:
    < bgp_profile_1 >:
      initiator:
        route_map_inout: < route_map >
  unit_profiles:
    < unit_profile_1 >:
      on_boot:
        duration: < 300-3600 >
  units:
    < unit_name_1 >:
      groups:
        profile: < unit_profile_1 >
        bgp_groups:
        - < bgp_group_1>
        - < bgp_group_2>
        interface_groups:
        - < interface_group_1>
        - < interface_group_2>

I had a quick start two weeks ago:
daanvdsanden/ansible-avd@43b92bdd3172aa59ab87a5ab8e6138f772baeb79
However looking at the generated config for units, I'm having a hard time figuring out the order in which the added groups appear:
vEOS-LF001#conf t
vEOS-LF001(config)#mai
vEOS-LF001(config-maintenance)#unit UNIT2
vEOS-LF001(config-unit-UNIT2)#show active
maintenance
   unit UNIT2
vEOS-LF001(config-unit-UNIT2)#profile unit TEST
vEOS-LF001(config-unit-UNIT2)#group bgp 1_BGP
vEOS-LF001(config-unit-UNIT2)#group bgp 2_BGP
vEOS-LF001(config-unit-UNIT2)#show active
maintenance
   unit UNIT2
      group bgp 2_BGP
      group bgp 1_BGP
      profile unit TEST
vEOS-LF001(config-unit-UNIT2)#group bgp BGP_1
vEOS-LF001(config-unit-UNIT2)#group bgp BGP_2
vEOS-LF001(config-unit-UNIT2)#show active
maintenance
   unit UNIT2
      group bgp 2_BGP
      group bgp BGP_1
      group bgp 1_BGP
      group bgp BGP_2
      profile unit TEST
vEOS-LF001(config-unit-UNIT2)#

When I add interface groups it even gets harder to find the order (at least for me):
vEOS-LF001(config-unit-UNIT2)#show active
maintenance
   unit UNIT2
      group bgp 2_BGP
      group bgp BGP_1
      group bgp 1_BGP
      group bgp BGP_2
      profile unit TEST
vEOS-LF001(config-unit-UNIT2)#group interface IG_1
vEOS-LF001(config-unit-UNIT2)#group interface IG_2
vEOS-LF001(config-unit-UNIT2)#show active
maintenance
   unit UNIT2
      group interface IG_1
      group bgp 2_BGP
      group bgp BGP_1
      group bgp 1_BGP
      group interface IG_2
      group bgp BGP_2
      profile unit TEST
vEOS-LF001(config-unit-UNIT2)#group interface 1_IG
vEOS-LF001(config-unit-UNIT2)#group interface 2_IG
vEOS-LF001(config-unit-UNIT2)#show active
maintenance
   unit UNIT2
      group interface IG_1
      group bgp 2_BGP
      group bgp BGP_1
      group bgp 1_BGP
      group interface IG_2
      group interface 1_IG
      group bgp BGP_2
      group interface 2_IG
      profile unit TEST

I don't think you need to do anything in regards to sorting. Just use the arista.avd.natural_sort filter on the list of groups. It will not match whatever logic(?) EOS is using, but it will look readable to the humans.
If you decide to work on this, please also include the groups:, so we get a full working feature. Thanks a lot for your work on this.

@daanvdsanden Please allow me to ask what progress you have made on this?
Since we also need this implemented we might incooperate on the development.
We will furthermore work on the addition of "group interface" configuration, which we need in addition to the custom maintenance config:
group interface MM_Int_Group_SFP
 interface Et1-48
 maintenance profile interface downlinks
 exit

I issued an PR including the groups. At the moment they are split since they also appear splitted in the configuration (on different places. Can easily be changed to groups: instead of:
bgp_groups_:
  < bgp_group_1 >:
    vrf: < vrf_name >
    neighbors:
    - < neighbor_1 >
    - < neighbor_2 >
    - < peer_group >
    maintenance:
      bgp_profiles:
      - < bgp_profile_1 >

interface_groups:
  < interface_group_1 >:
    interfaces:
      ethernet: < ethernet_interface_range >
      port_channel: < port_channel_interface_range >
      vlan: < vlan_interface_range >
    maintenance:
      bgp_profiles:
      - < bgp_profile_1 >
      interface_profiles:
      - < interface_profile_1 >
      - < interface_profile_2 >

The reason I didn't use an array for the interface in the interface group is that it is impossible to flatten the Ethernet interfaces without knowing what kind of devices it is and what kind of linecards there are in a chassis. Since Ethernet2/2 can be lane 2 in a QFSP in port 2 but also a SFP+ in a linecard in slot 2.

The reason I didn't use an array for the interface in the interface group is that it is impossible to flatten the Ethernet interfaces without knowing what kind of devices it is and what kind of linecards there are in a chassis. Since Ethernet2/2 can be lane 2 in a QFSP in port 2 but also a SFP+ in a linecard in slot 2.

I don't follow your point here, so if you could show the problem with some example data, I hope I can understand it better.
We have two "competing" PRs now covering the groups. Main difference is the interfaces which you compile into a list very similar to the EOS CLI output, but you require a more granular data input to do that. Personally I prefer to more "lazy" method of just passing the string handed to us, since I think it is more user-friendly. I acknowledge that this could potentially produce CLI that is valid but different than "show running", but in this case I think it would be so much easier to use, and more in line with the rest of AVD.
So we are talking about:
  < interface_group_1 >:
    interfaces:
      ethernet: < ethernet_interface_range >
      port_channel: < port_channel_interface_range >
      vlan: < vlan_interface_range >

vs.
  < interface_group_1 >:
    interfaces:
      - < interface_range >
      - < interface_range >
      - < interface_range >

Let us get a view from @carlbuchmann and @titom73 on this.
When we have the final data model, we need to sort of which PR will cover what.

I like the fact that the generated config is an exact match of the running config. So when I started I also used the "lazy" method and I thought I could flatten the array the same way as is done with vlans on a trunk port. That was impossible for me since to do this properly I need to know for what kind of device I'm creating the config for. That was the point I was trying to make with the Ethernet2/2 example. It can be two different things which can impact the result when the array is flattened.
E.G. the following happens on a 7050CX switch with QSFPs:
EOS(config-group-if-TEST)#interface ethernet 1/1-4
EOS(config-group-if-TEST)#interface ethernet 2/1-4
EOS(config-group-if-TEST)#show active
group interface TEST
   interface Et1/1-2/4
   exit

However when the same commands are given on a arista with linecard where SFP(+) modules inserted in slot 1 and 2, I (assume) it will not get flatten the same, I expect this to happen (assumption, I don't have a 7500 to test this):
EOS(config-group-if-TEST)#interface ethernet 1/1-4
EOS(config-group-if-TEST)#interface ethernet 2/1-4
EOS(config-group-if-TEST)#show active
group interface TEST
   interface Et1/1-4,2/1-4
   exit


Remove duplicated subtitle in the README

Just removing a duplicated word/subtitle.

@jorgelbg Thanks.  Apologies for the delay.  I didn't have my notification settings correctly defined.


Update OWNERS

Issue #, if available:
Description of changes:
Add new packages SMEs as owners
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve
/lgtm


Focus Report

Introduce new report showing the latest results, allowing charities to focus their efforts in the right places with their interventions.

 Focus report

Building on impactasaurus/server#204. Replicates an abandoned issue impactasaurus/app#455