Sierra Leone Error

The tools work for all countries except Sierra Leone. Service Overview works for Sierra Leone, but the tools that require inputting an administrative zone results in an error (attached).

Can you share the Inputs that you used during these failed attempts - or expand the "Inputs" section of the message you posted?

The below is one example. I've tried all the administrative zones and still get the same error.

@dcgull any ideas here? I think Southern may not be a valid administrative area.

This is because Southern exists in both Zimbabwe and Sierra Leone so there was a conflict. Do you want to change the tool to have a Country selector as the first parameter? @kiranpande

add the highlighted text in wpdx.py:

I think all of the districts (Northern, Eastern, Western, Southern) all get the same error, probably because they exist in other countries too?
Would adding a country selector help if its already pulling from the world pop data for Sierra Leone?

Yes because it is using one global ADM2 boundary layer to find the polygon to analyze. So we need to add either a country selector or a variable that allows the tool to only be used for one country at a time. See above to get it working and let's see if that gets you going for your demonstration.

Ok that makes sense, thank you! Where can I find wpdx.py?

@kiranpande it should be in the same folder as the .pyt toolbox file.

Thanks, Sam!
So, I right clicked on the toolset in GIS and added the code in the right place (I think... based on the other text surrounding it), saved it, refreshed, and tried to run the tools but none of the tools had a country selector.
Am I missing something or did I make the edit in the wrong place? Sorry if this is super simple and I'm just missing it... I'm not too familiar with this side of things!

@kiranpande that edit is just to fix it so that Southern will work - it basically hard-codes Sierra Leone as the country. No selector yet, that will require more code + time.

Ok that makes sense! Thanks for the clarification.
I tried to run the unserved pop and update rural pop and got the errors below. Do you think I made an error adding in the code?

Not an issue, just an issue with my "fix" - this is the kind of thing that we need time to improve. Stand by.

Hey, sorry I don't have time to help with this right now, but it looks like you guys are on the right track. I should have realized district names would not be unique!

Ok thank you both so much!

@kiranpande change the section in wpdx.py for setEnvironment to this block of text:
def setEnvironment(zone, query_type):
    """Limits the processing extent to the given administrative zone"""
    arcpy.env.overwriteOutput = True
    adm_zones = join(dirname(__file__), "Data", "ToolData.gdb", "Admin")
    if zone in ["Northern", "Southern", "Eastern", "Western"]:
        mask = arcpy.FeatureClassToFeatureClass_conversion(adm_zones, "in_memory", "mask",
                                                            "{0}='{1}' and CC = 'SL'".format(query_type, zone))
    else:
        mask = arcpy.FeatureClassToFeatureClass_conversion(adm_zones, "in_memory", "mask",
                                                            "{0}='{1}'".format(query_type, zone))
    if mask.maxSeverity==1:
        arcpy.AddError("ERROR: Database error in {}. Please alert system administrator".format(zone))
        sys.exit(1)
    else:
        extent = arcpy.Describe(mask).extent
        arcpy.env.extent = extent
        #arcpy.env.mask = mask
        return mask

Thanks, Sam! I just got home, but I'll test this out first thing. Should I remove the text i added earlier?

Hi Sam,
Sorry for the delay. I replaced the old text and got the error below. My methods have just been to open GIS, right click on the toolset, click edit (opens the text in notepad) and edit from there. Have the errors been caused on my end? Let me know if there is a better way I should be updating!

These are some of the fixes I am trying to make to the tool.
Find line 684 in the .pyt file and add wpdx. to the front of the queryWPDx variable. You may find other places where you have the same issue.
It would be easiest if I get logged in via the VPN, and we'll get everything working for your demos if we can.

@kiranpande I believe it is working properly now - can you please verify? I tried a number of different workflows in SL and they all seemed to work well.

Thank you so much, Sam! We really appreciate you taking the time to help sort this out.
I downloaded the toolset again and ran the tools but got this new error. If they're working for you it is probably an issue on our side. I'm accessing the server from my laptop right now but will check it again tomorrow morning when I have access to a better computer in the office.

@kiranpande unfortunately downloading the tools again overwrote the fixes that I applied to your system - do you still have the 8.8.18 folder? That is where I had applied changes.

I tried the toolset in the 8.8.18 folder initially but got the same error. So I downloaded it again to try fresh. I apologize if I did something along the way to mess up the toolset... Let me know if there is something I can do on my end to fix it - I don't want to make you duplicate your efforts!

@kiranpande It still working OK for me, can you contact me on skype at slibbs and we'll try to get it going for you.


Description field in CorrectionSet

As discussed in XPOG, it might be useful to have an optional description field in CorrectionSet to document the content, changes, and perhaps the version, e.g. here: https://github.com/cms-nanoAOD/correctionlib/blob/6c4d761ef0458ce651222341e121294073d5e8ef/src/correctionlib/schemav2.py#L351-L354
we can simply add
class CorrectionSet(Model):
    schema_version: Literal[VERSION] = Field(description="The overall schema version")
    corrections: List[Correction]
    description: Optional[str] = Field(
        description="A nice description of what is in this CorrectionSet means"
    )

Maybe for future use, a dedicated version field, which is also optional, to keep track of CorrectionSet version, could be useful, although I do not have an immediate use case for the TauPOG.

An optional description field might also be useful for any other type of node (Binning, Category, Transform, ...) to leave extra comments/documentation. If it's optional, it should not cause extra overhead.

I was planning to keep all nodes semi-private from a user perspective. In that case I would prefer not to include descriptions for them, since the highlevel interface and inputs all have description tags. If you see some particular use case for it I'd be happy to hear it. Meanwhile I will add a description to the CorrectionSet.


break line , different behaviour in different brawsers

Hi,
Thanks for a nice tool. I have noticed that each browser encode break line differently. For example IE threats each line as  , chrom puts each line in separate div (except first line :( ) and firefox create br tag.
I am parsing html content of WYSIWYG editor to PDF format , how ever its a big headache because of not consistent text formatting. Is it any chance to have the same   output regardless which browser is in use ?
for example using  function wysiwyg.getHTML() for sample text formated as below  :
test
test
test
we have :
in firefox :
test<.br>test<.br>test<.br>
in chrome :
test<.div>test</.div><.div>test</.div>
in IE
<.p>test</.p><.p>test<./p><.p>test<.p/>
thanks for advance,

Any response on this?

@jbhamilton @kozilla this behavior is an issue for a long time, unfortunately there is no way to deal with the inconsistency of browsers when it comes to content-editing.

+1 for this. It would be useful if there is a way to unify the way the enter key is handled, an option for  tag when hit enter, and another option for  when hit enter! or at least one of them which work cross browsers.


Develop procedure to dump production DB and load to development DB

Description
Should be able to dump all current production data  and load into same or different database.
Possible Solutions
Current Approach:

Run script on DB host to dump production DB (gresq_production).
Create empty DB using production models and sqlalchemy.  This can run remotely.
Run script on DB host to load data from step 1 to development DB (gresq_development).

We used mysql workbench and it handled the migration automatically.


Milestone 2: SubstraTEE PoC2: Running WASMI inside SGX enclave with simple STF

Same as #2 with a running WASMI inside the Intel SGX enclave
WASMI: WebAssembly Interpreter (https://github.com/paritytech/wasmi)

Milestone 2 ready: https://github.com/scs/substraTEE/tree/M2


feat(lineage source): add fine grained lineage support

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Waiting on https://github.com/datahub-project/datahub/pull/8135 for docs to get fixed

Doc build will be fixed in the linked PR.

please excuse me hijacking this PR - I'm just wondering if there's a roadmap entry to allow querying the transformOperation via GraphQL and / or visualising it in the UI? We have a case for this specific feature where our users would like to see the actual operation in the UI to better understand the lineage.
Could someone maybe point me in the right direction if this is planned already? Otherwise happy to try and contribute back.

@githendrik we don't have any concrete plans for it, but I think it probably does make sense do to that.
Surfacing it via GraphQL feels like a no-brainer, and we'd definitely accept a PR there.
I'm less sure where we'd want to surface it in the UI - might be worth thinking about more / mocking. The reason is that it's an "edge annotation", but there's a bunch of other edge annotations that we might also want to support in the future e.g. the actual SQL logic, confidence scores on our lineage generation, etc

Surfacing it via graphql is a no-brainer - we'd definitely accept a PR for that
I'm less sure where to surface it in the UI - might be worth building some mocks for that. Specifically, there's a lot that we'd want to show as "edge annotations" - transform operation, the raw SQL logic, lineage confidence scores, where the lineage came from, created/updated timestamps per edge. I don't want to do something that we'd need to undo later.


[GHSA-fwr7-v2mv-hh25] Prototype Pollution in async

Updates

Affected products

Duplicated of #202


output command aliases

fix todo: output command aliases
/assign @geeknoid

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @islinwb. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@islinwb: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
5eb1412a74bb1ce39fc03884a21224a0eaecddbf
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@islinwb: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/retest


[BUG] StrIncome does not get filled

StrIncome does not get filled
In general the parsing of data read is disabled for numeric states. Miust be fixed.

fixed at 1.2.0

fixed with 1.2.0


Wrong ttl used when respect_dns_ttl is set

I have an upstream with type: STRICT_DNS and respect_dns_ttl: true. However, when I change the DNS entry, envoy does not update the origin IP as expected.
I have done a quick debug, and it appears that envoy uses the TTL from the CNAME resolved entry in the DNS response, instead of the base entry TTL. For example with an entry.example.com upstream and the observed below response:
dig entry.example.com
…
;; ANSWER SECTION:
entry.example.com.	10 	IN	CNAME	host1.example.com.
host1.example.com.	86400	IN	A	<IP_ADDRESS>

Here I can observe that envoy chose the value 86400 for ttl, rather than 10. I can confirm this with upstream debug logging, which returns something like this when envoy starts:
[2023-08-09 12:04:43.386][233471][debug][upstream] [source/extensions/clusters/strict_dns/strict_dns_cluster.cc:149] DNS hosts have changed for entry.example.com
[2023-08-09 12:04:43.386][233471][debug][upstream] [source/extensions/clusters/strict_dns/strict_dns_cluster.cc:177] DNS refresh rate reset for entry.example.com, refresh rate 86400000 ms

I would expect envoy to refresh it as a normal DNS client would, ie. after 10s.
This was tested with v1.27.0 on Linux.
Cause investigation
I expect this is an issues with the c-ares resolver interface. Looking at the logic, it seems that the cnames field in the ares_getaddrinfo response is completely ignored:
https://github.com/envoyproxy/envoy/blob/27218f51ba9a9fe5932deb26a949aadc7387e883/source/extensions/network/dns_resolver/cares/dns_impl.cc#L202-L228
The correct way to handle this, is probably to use the minimum TTL of all CNAME entries and the ai_ttl of the used node.
It could potentially be a problem with the apple resolver as well.

cc @yanavlasov

I would like to work on this if no one else has started

Thank you @kanurag94 , I don't know of anyone else who has started working on this.

Thank you so much @KBaichoo for assigning this. I will start working on it :)


find in editor does not find all characters

From<EMAIL_ADDRESS>on 2010-09-09T12:19:20Z
find does not detect the charater ""
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=344

From pierre.raybaut on 2010-09-09T11:02:42Z
Yes it does, but you have to use regular expression syntax (escape characters).
Maybe I should add a toggle button like in "Find in files"

From<EMAIL_ADDRESS>on 2010-09-09T14:48:36Z
Any point that could show users how to search for such characters would be useful.
A scientist may not know all RexEx by heart. And people are used from other editors that such characters are found right away.

From pierre.raybaut on 2010-09-11T03:10:41Z
Status: Fixed


changing labels unexpends the tree

Hello,
I have a tree that is supposed to have that structure :
<treecontrol class="tree-light"
        tree-model="ts_data.ts_json0"
	options="treeOptions"
	on-selection="showSelected(node)">
	{{node.name}} {{node.info}}
</treecontrol>

node.name is always the same but node.info changes every 2 seconds. (there are bitrates and things like that)
I would like to know if it is possible to change node.info every 2 seconds without making the tree enexpending nodes when that value changes?
I tried with making the equality option return true and false ... but no success.
Thank you in advance :)

You need to use the equality function to ignore the info change.
E.g. compare just node I'd or just node name
On Mar 3, 2015 12:33 PM, "Benjamin CARADEUC"<EMAIL_ADDRESS>wrote:

Hello,
I have a tree that is supposed to have that structure :

{{node.name}} {{node.info}}
node.name is always the same but node.info changes every 2 seconds.
(there are bitrates and things like that)
I would like to know if it is possible to change node.info every 2
seconds without making the tree enexpending nodes when that value changes?
I tried with making the equality option return true and false ... but no
success.
—
Reply to this email directly or view it on GitHub
https://github.com/wix/angular-tree-control/issues/108.

ok,
I made that :
$scope.treeOptions = {
	    nodeChildren: "children",
	    dirSelectable: false,
	    equality : function(a,b){
	    	if (a === undefined || b === undefined)
				return false;
			return angular.equals(a.name, b.name);
	    }
}

it seems working but I don't know if it's sufisent,
could you check and tell me if this is secured and robust einough ?
Thank you though for the help and this rapid answer !

it is sufficient, if for your application the node.name is a unique
identifier of a node. If it is possible to have multiple nodes with the
same name, you should probably add another unique identifier and compare on
it.
On Tue, Mar 3, 2015 at 12:59 PM, Benjamin CARADEUC<EMAIL_ADDRESS>
wrote:

ok,
I made that :
$scope.treeOptions = {
nodeChildren: "children",
dirSelectable: false,
equality : function(a,b){
if (a === undefined || b === undefined)
return false;
return angular.equals(a.name, b.name);
}
}
it seems working but I don't know if it's sufisent,
could you check and tell me if this is secured and robust einough ?
Thank you though for the help and this rapid answer !
—
Reply to this email directly or view it on GitHub
https://github.com/wix/angular-tree-control/issues/108#issuecomment-76925411
.

Ok,
Thank you very much for your help.
This is sufficient for my application, Those node.name will always be the same ! :)


update gitops communication in ops recipe

What does this PR do?
This PR iterates on the troubleshooting gitops procedure to include the scenario where a Giant Swarm engineer cannot fix an issue due to customer managed gitops resource or configuration.
How does it look like?
Customer Communication heading added
Any background context you can provide?
This is for a story within Giant Swarm to clarify and make public the process of "handing back the pager" for problems that arise as the result of gitops configuration and management that Giant Swarm does not have access to.
What is needed from the reviewers?
Please add/edit the customer communication section as you see helpful. The main goal here is to clarify what is done in the event that Giant Swarm operations cannot fix an issue by pausing reconciliation and a manual fix.
Why is this piece of content here?
The support docs outline the scope of support while this handbook entry is a public way to show the operations procedure and expectation.
Have you maintained the front matter?

LGTM

@LolloneS  values.schema.json specifies an empty object at the root of values.yaml: I added one


Dynamic Menus?

I noticed Scratch's extension documentation has information on dynamic menus. Is this something that can be added to the Turbowarp Docs or do Turbowarp extensions have different syntax/standards?

i think this is something that can be added to the turbowarp docs, some extensions already use this (like clones plus)

I don't mind writing a bit for it if everyone else doesn't mind


CacheMap shared between all DataLoaders

Hi,
Could you please elaborate why the CacheMap is shared between all DataLoaders by default? This gave me all kinds of weird results whereby the promises of different entities were shared. For example, the following query would work if I either included the productType or location field, but not with both.
query {
  products {
    id
    productType {
      id
      description
    }
    location {
      id
      name
    }
  }
}

I traced the error by inserting a few lines at https://github.com/overblog/dataloader-php/blob/master/src/DataLoader.php#L66 echo'ing $cacheKey and the $batchLoadFn (as a string) which showed me that the promise of productType would be returned for a location with the same id.
Manually overwriting the service definition as
services:
  overblog_dataloader.cache_map:
    public: false
    shared: false
    class: Overblog\DataLoader\CacheMap

solved all my problems and gave me the expected results. Is this a bug or am I doing something wrong?

Hi,
This is a bug! The cacheMap should not be shared, can you open a PR please?


Comments are not included into hash calculation

I did some testing and it looks like that adding NOLINT* comments does not affect hash calculation. As a result ctcache might report source file as "good" after NOLINT comment is removed. Although the previously suppressed check might produce a warning.
I tried to override co_args with and empty list here in order to skip compiler invocation. It seems to be working as expected after that - NOLINT comments included in the hashing.
I also tried to dump the compiler output as well. The output doesn't have any comments hence causing the issue. clang does have an option for preserving comments. Other compilers might have similar options as well. Although I think it might be easier to add an option to skip compiler call completely.
Any thoughts on this ?

The compile invocation is there by design. I want the whole preprocessed source to be included in the hash calculation and I want to keep it as it is because #if-s and #include-s influence the checks as well. Maybe preserving comments would be an option.

We're running into this limitation due to the omission of // NOLINT-style comments in preprocessed sources as well, making it hard to add same-line // NOLINT suppressions, remove existing same-line // NOLINT suppressions, or adjust // NOLINT[NEXTLINE|BEGIN](rule) suppressions.
I think the suggestion to preserve comments, potentially as an opt-in (or opt-out, given that // NOLINT is flaky without it) flag, would rectify this issue. Both clang-tidy and the MSVC compiler invocation support the -C flag to control this behavior, so it seems it'd be easy to append.
If you think this is worth pursuing, I can propose a PR. I'll experiment with it locally regardless.

Hi, Feel free to create the PR when you have a working solution ready.


feat: add nydusify commit command

Relevant Issue (if applicable)
support nydus commit operation
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Go over all the following points, and put an x in all the boxes that apply.

[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.

Thanks for the implementation! Please also add a test case in https://github.com/dragonflyoss/nydus/tree/master/smoke/tests (maybe create a commit_test.go ?).

Thanks for the implementation! Please also add a test case in https://github.com/dragonflyoss/nydus/tree/master/smoke/tests (maybe create a commit_test.go ?).

I am sorry for I was too late because of my Spring Festival holiday. Commit smoke test was added.
Have a nice day!

very nice pr

Thanks for your pr, please fix the golang-lint.

@imeoer  which release will contain this pr？ we are waiting for this pr for a long time. thanks

@imeoer which release will contain this pr？ we are waiting for this pr for a long time. thanks

Thanks for waiting, it should be included in the next release, v2.3.0.

@PerseidMeteor Please also update the docs in https://github.com/dragonflyoss/nydus/blob/master/docs/nydusify.md, better be a workflow like nydusify convert -> nerdctl run -> nydusify commit -> nydusify run.

It seems the CI is broken.

It seems the CI broken.

It made me confused. Is there any idea to slove this problem?


Revert back to display name and tname

Description
Separate the display name and the tname
Related Issues
https://github.com/threefoldtech/js-sdk/issues/1445

Codecov Report

Merging #1544 into development will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##           development    #1544   +/-   ##
============================================
  Coverage        32.97%   32.97%
============================================
  Files              127      127
  Lines            11606    11609    +3
============================================
+ Hits              3827     3828    +1
- Misses            7779     7781    +2

Impacted Files
Coverage Δ

jumpscale/packages/admin/actors/admin.py
32.87% <25.00%> (+<0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb24b03...c7005e7. Read the comment docs.


Refactor findAllReferences. Now supports renamed exports and imports.

Don't think there was an issue for this but was mentioned here: https://github.com/Microsoft/TypeScript/pull/13643#issuecomment-274975010.
Fixes #13663.
Update: Now also fixes #10894.
Update: Fixes #14103.
We now use an algorithm to search for imports of a given export. This is in the new importTracker.ts. Previously we would just globally search for identifiers with the same name.
Note: This breaks find-all-refs for untyped modules since we want to match the symbol and not just the name. See #14002.

Some comments:

getReferencesForStringLiteral, why does it use type

getReferencesInContainer, consider passing in the containig sourceFile

searchForImportsOfExport, consider changing the switch in the IIFE to just set a variable

sourceFileHasName, consider inlining this at use site

getSymbolScope, consider making the comment more detailed for export as namespace

getDirectImportsMap, I would change the map to use a Map object instead

export assignment handling, export = foo, export default foo

consider renaming isProperImportEquals to isExternalModuleImportEqual

forEachImport, consider storing the require calls on the sourceFile like we do with the imports
this makes forEachPossibleImportOrExportStatement jsut a walk over ambient modules

getImportOrExportSymbol, consider changing the return expression to return comingFromExport ? getExport() : getExport() || getImport();

getExport, make sure to check comingFromExport before return an import

isNodeImport, in case for ImportEqualsDeclaration, check for is it an import .. = require or just an import .. = X

nodeIsEligibleForRename, check the parent of the node to make sure it is an import or export specifier, and worth adding a test of x.default vs a case of import * as ns from "mod"; ns.default;

@andy-ms can you also validate that this change addresses https://github.com/Microsoft/TypeScript/issues/14346 and

@mhegazy Should all be done except for #14880, which I assigned to myself.

@andy-ms i still do not see #14346 with this change..

Should be in https://github.com/Microsoft/TypeScript/pull/14001/commits/28a3604714f110eb6680f785b9a4759171a53aa2


CCD-3675 temporary PR to test with ES enabled [DO NOT MERGE]

JIRA link (if applicable)
CCD-3675 "CCD-3675 Global Search - Access Process should take into account mapped access profiles"
Change description
Temporary PR to test hmcts/ccd-data-store-api#2103 with ElasticSearch FTAs enabled

NB: both this PR and hmcts/ccd-data-store-api#2104 can be closed once hmcts/ccd-data-store-api#2103 is merged.

Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Closing this temporary PR as the parent branch it was used to test with ElasticSearch FTAs enabled has now been merged: see hmcts/ccd-data-store-api#2103.


Update to latest Rider version

Hello!
Would it be possible to update the current version of the plugin to Rider 2023.1?
At the moment it does not work completely due to compatibility with the latest builds

Hi @EnergyNick, currently I don't have enough time capacity to bump all necessary versions and test, sorry :(
But any contributions are very welcome!

Hi @EnergyNick, just want to let you know about the status - I'm currently working on the release for Rider 2023.1.


Added translation logic for "Upload documents(optional)" in _UpgradeRecordModal.cshtml

In _UpgradeRecordModal.cshtml the translation logic was missing for "Upload documents(optional)"

Added a bunch of code cleanup, see the 2nd commit.
Most of it is only fixing code warnings, introducing const strings for often used strings, introducing a function for the often used "OperationResponse"-Type. So there shouldn't be any breaking changes.

Thanks for the PR, but we can't merge this.  You cannot submit a PR with 500+ line changes and describe it as 'a bunch of code cleanup', because

We're not going to review a PR that large masquerading as a small fix.
We don't fully understand the reasoning behind some of the changes.

Would it be okay to split the changes up?  Then it's maybe easier to review and I also can give you better reasoning for the change?

Yes please split up the commits into incremental changes that are easier to review.


Refactor cli docs

Closes https://github.com/inveniosoftware/invenio-cli/issues/6 (invenio-cli --help kind of closes that one)
Closes https://github.com/inveniosoftware/invenio-cli/issues/13
Closes https://github.com/inveniosoftware/invenio-cli/issues/85

Pushed changes to cover all comments.
Something I wasn't able to do yet is get all the top-level sections to appear on the left side correctly.
Only the ones with a direct index.md show up...

I find that left table of content very strange anyway since it's already at the top. Would be in favour of removing it.


Search extension

Added a filter menu for the search box (#4813).
This pr creates the menu and the structure to manage the filters.

Search in subfolders
Size of file
Date (created, modified, accessed)
Group (and, or, not)

I disabled closing the search box when it loses focus, as it prevents us from using the menu search button.
I put the menu in a button next to the SearchBox, because it didn't require modifying all of the SearchBox code.
I can move this menu (directly in the searchbox, in the toolbar, in a sidebar, ...). This will be the subject of another pr after decision.
Improvements to be added in other pr:

It will be necessary to change the filter icons, ideally a different one for each one.
Filter Filename (start with, ....). The searchbox use the filename, but not the complex queries.
Filter Kind/Extensions (audio, document, pdf, folder, ...)
Filter Metadata (image resolution, ...)
Others filters
Add filters in SearchBox, by parsing. This has been removed temporarily because this pr is big. A pr with the overlay will be created after the commit.
Add options of location (search in compressed files, in a folder list, ...)

I thank all the people who gave their vision of this menu, often with magnificent mockups. I hope I have been able to synthesize them as well as possible.

This is looking very nice! Pushed a small change to avoid showing incorrect results when filters exclude all items and to fix a crash I was getting when hitting "Save" (SearchPicker.xaml ->

I disabled closing the search box when it loses focus, as it prevents us from using the menu search button.

What's the menu search button?

@gave92 Thank you for this correction.
@yaichenbaum It's the "Search" button in the filter menu. This button starts the search without having to click on the icon in the SearchBox. Disabling the closing of the SearchBox when it loses focus allows you to use filters with a text to search, otherwise you have to type your text, you lose your text as soon as you do something.

@gave92 I have modify to use IServiceProvider. I also added a tooltip on the menu button, it was missing.

@gave92 Thank you for this correction.
@yaichenbaum It's the "Search" button in the filter menu. This button starts the search without having to click on the icon in the SearchBox. Disabling the closing of the SearchBox when it loses focus allows you to use filters with a text to search, otherwise you have to type your text, you lose your text as soon as you do something.

Would it make sense to apply the filter after the flyout is closed without the need of an additional button?

@yaichenbaum It's an interesting idea. It makes me think that often only one filter will be used. Allowing the search to be triggered without having to click on "Save" then "Search" would be easier. We can add a "Search" button on all pages. I'll think about it.

Personally, aside from the long list in file explorer, I think it's a pretty good UX. I think a future PR can cover an advanced option that lets users add filters quicker directly from the search box by typing something like date-created:11/3/2021 etc.

@yaichenbaum that you can do it already, anything that this filters do you can do the same by typing.

@gave92 I have code to parse the query and automatically create the filters. It also displays syntax explanations in the suggestions. This will allow the 2 methods to work together (manual + assistant). This will make a new pr when this one is integrated.

@cinqmilleans can you upload screenshots?

@yaichenbaum You just have to ask

@cinqmilleans looking good! I know you made some changes for usability purposes and those look good. In terms of the UI, can you try to match the design spec a little closer?

@yaichenbaum Ok, I'm doing this. Can you give me the codes used by your icons?

Tag: 
Grid: 
Size: 
Date: 

@yaichenbaum Here are some changes.
Regarding the visual:

The SizePicker is thicker and rounded.
The picker header has been adapted, the icon removed, and the back button is at the top.
Styles have been improved.
The active filter buttons have been changed, and the close button is included inside, but visible on mouse over.
I modified the "SubFolders" checkbox. I didn't used double buttons because 1) You need 2 short texts, and it depends on the language 2) other checkboxes are planned but not yet functional.

Regarding behavior:

It is no longer necessary to save in the pickers, it suffices to modify the value.
Search/Clear buttons are on all pages. We can therefore do a search on a single filter without having to return to the main page.

@cinqmilleans that's getting very close 🚀
Can you try to match the font sizes and usage of the accent color?

@yaichenbaum Yes, I'll try.

@yaichenbaum Could you explain the requested change in more detail? I do not understand.

@yaichenbaum Could you explain the requested change in more detail? I do not understand.

Yair asked to try to match FontSize and FontWeight and where accent color is used so it looks like in the picture. @cinqmilleans

@yaichenbaum @gave92 I applied the modification.

@cinqmilleans is there a way to make the filter button only show when there is an active search?

Can you also switch the arrow for a chevron?

@yaichenbaum Can you also switch the arrow for a chevron?

Ok, I do that.

@cinqmilleans is there a way to make the filter button only show when there is an active search?

Like @BanCrash, I think the user should be able to search on filters only (and without having to use *, which is too technical).
I can put the filter button in the search box, like in thread #4813. It will be more integrated.
Another solution is to use a panel, as the preview pane, which contains the field and the filters. The toolbar only displays a toggle button.

@cinqmilleans I was originally thinking it would only be used when doing searches, but I see how it can be useful to filter within a directory as well. Considering the use case, I think the way you originally had it inside the search box makes more sense.

@yaichenbaum I incorporated the chevron. I'll put the button back in the search box.

@cinqmilleans it's looking amazing! I know we requested a lot of changes but I want to let you know that I'm very impressed with all the work you've done on this.

@yaichenbaum Thank you so much. I too am impressed with how many different things you are doing for this project.
I committed the modification.

@cinqmilleans thanks! Can you see if you can add back the rounded corners?

@yaichenbaum It is done.

@yaichenbaum It is done.

Is it possible to do the same to the search box?

@yaichenbaum Do what exactly?

@cinqmilleans add round corners to match how it currently looks in main.

@yaichenbaum It is done.

@yaichenbaum It's done.

Could you resolve conflicts?

It is done.

@cinqmilleans I've found a bug. Groups are not saved on the root page:
https://user-images.githubusercontent.com/53011783/143764079-e4b81e09-28dc-4311-b9ac-32b836e88ca5.mp4

@d2dyno1 Indeed it does not work any more. I look at it. Thank you.

It is fix.

@cinqmilleans Still getting some issues. This time different ones 😅

Adding three items to "And" group doesn't update the collection - i.e. shows only one item (did you forget ObservableCollection<T> or INotifyPropertyChanged?) (- the items are added but not shown)
Going back correctly displays "3 items" in the group
Entering the group again, UI doesn't get updated when trying to remove the first and second item only the last item is removed (did you forget INotifyPropertyChanged?) (- when going back (to the main page) the items are updated as they should)

https://user-images.githubusercontent.com/53011783/143770778-eb05831c-f17c-4cda-8378-4cc26e82bc12.mp4

@d2dyno1 Thank you. The problem was in the morning's fix, which only registered a new instance instead of updating it. This implies that the new filters were added on the old instance of the group, but the new one was displayed. It's fix.

@mdtauk can you look over the UI in this PR?

@cinqmilleans can you change the mouse cursor when hovering over the filter button to match the cursor used on other buttons?

@cinqmilleans can you change the mouse cursor when hovering over the filter button to match the cursor used on other buttons? As a sidenote, I was comparing the options between Files and File Explorer and I feel that the UI in File Explorer is cleaner and easier to use, curious to hear your feedback on that.

Are there options for "And", "Or", "Not"?

@d2dyno1 there aren't.

@d2dyno1 there aren't.

The existing design is pretty intuitive and user-friendly already. Why oversimplify it taking away features?

@d2dyno1 there aren't.

The existing design is pretty intuitive and user-friendly already. Why oversimplify it at a cost of features? There is only so much stuff you can fit inside a dropdown menu, and if we are trying to match Everything's high standards, taking away features isn't going to do good.
@yaichenbaum

@d2dyno1 anytime you start having flyouts with menus and then submenus with submenus in turn, it starts to become confusing. A simple menu with a submenu or two is a little easier to use.

@d2dyno1 anytime you start having flyouts with menus and then submenus with submenus in turn, it starts to become confusing. A simple menu with a submenu or two is a little easier to use.

But a menu limits you and doesn't allow you to add new features without expanding beyond it. Probably something better could be found that is equal between these two and that doesn't sacrifice on features. @yaichenbaum

@yaichenbaum @d2dyno1 Great debate.
Here are some elements to help in the decision. This concerns the main page. The details pages seem to me a good compromise between ease and possibilities (Microsoft is too limited, Apple is not easy enough).
Apple offers this: https://www.youtube.com/watch?v=J09jrt9FNO8&t=5s
This system constructs sentences. It is very complete but very long to implement and visually heavy.
The number of filters is impressive and it is possible to assemble them at will.
Here is the mockup of @mdtauk
https://user-images.githubusercontent.com/7389110/124290630-93955680-db4b-11eb-9f0f-82a1fb3f9e32.png
The current implementation has flaws.

The type of filter is not displayed in the summary. We cannot differentiate the type of date, for example.
Important and frequent filters will be drowned in the menu among the filters of lesser importance.
The rounded button layout is nice for short settings, but less so when the text is long. You can't always prevent a long text.

An easy to implement solution.

We replace the rounded buttons by a title and a value (as in the image).
The user can pin a type of filter, which will always be displayed in the menu even if empty by default.
We initialize the list of pinned filters with the most common ones (date, size, kind).
The additional filter menu will only be used infrequently.

@yaichenbaum Regarding the cursor bug, the fix is not straightforward because the cursor is changed by the AutoSuggestBox control. My attempts to force the cursor are unsuccessful on this control. I will read the controller code to find a solution. It will take a few days.

@yaichenbaum Can this pull request be reviewed and merged without design decisions in it. This PR is too big to be constantly put off.

@yaichenbaum Can this pull request be reviewed and merged without design decisions in it. This PR is too big to be constantly put off.

@d2dyno1 cinqmilleans is still working on this and it's best to wait for everything to be figured out before merging it. Unlike most features, this is a little more complicated and we're still figuring out the details on the best UX and I don't want to merge it before it's ready.

@yaichenbaum @d2dyno1 The improvements on this pr are

Fix the bug with the cursor. It is progressing.
UI for the main page. I await your feedback on my comment before implementing an improvement project.

The rest is planned for the following phases #7124.

@d2dyno1 what kinds of features are limited by the menu?
@cinqmilleans have you looked at the search filters in the Microsoft Store? Maybe we can borrow some design principles from that.

@d2dyno1 what kinds of features are limited by the menu?

The addition of logic gates

@d2dyno1 what kinds of features are limited by the menu?

The addition of logic gates

Those are a little hard to do in a menu, have you seen how it works in Discord?

@yaichenbaum @d2dyno1 There are many others. The File Explorer menu does not allow you to search for a specific date, metadata, ...
Filters in Microsoft Store are very limited. The presentation is pretty, but we chose something else. What are the advantages that you see?

The addition of logic gates

Those are a little hard to do in a menu, have you seen how it works in Discord?

Discord doesn't have logic gates, that's why dropdown menu should be ditched.

@d2dyno1 what do you mean by logic gates?

@d2dyno1 what do you mean by logic gates? And/or?

@yaichenbaum @d2dyno1 Adding pinned filters results in a layout that looks a lot like a menu where you can easily choose values for frequent filters. This does not prevent having a button to add rarer filters. I had planned to offer this feature later, but it might gather your views.

@d2dyno1 what do you mean by logic gates? And/or? Those can easily be added to a design like the one in Discord.

I don't recall logic gates for search working on discord. Either way, having them in search box and managing them there will result in one big mess.

@d2dyno1 it's not supported in Discord, that was just a demonstration about how it can easily be adapted. It can be a bit messy but it's cleaner than the current solution. I'm not sure the best way to move forward but I'm not a fan of putting everything in a flyout.
@cinqmilleans my apologies for dragging this PR out for so long, I just want to make sure we reach a good design before merging it.

@d2dyno1 it's not supported in Discord, that was just a demonstration about how it can easily be adapted. It can be a bit messy but it's cleaner than the current solution. I'm not sure the best way to move forward but I'm not a fan of putting everything in a flyout.

How is it cleaner than the current solution?

The And/Or/Not filters will be used very little. If I put them first, it's to test the solidity of the model, and because the main menu is a hidden And filter. It should not be highlighted, just available for the advanced user. It will be available in basic (flyout) and advanced (parsing) mode.

@d2dyno1 it's not supported in Discord, that was just a demonstration about how it can easily be adapted. It can be a bit messy but it's cleaner than the current solution. I'm not sure the best way to move forward but I'm not a fan of putting everything in a flyout.

How is it cleaner than the current solution?

@d2dyno1 because you don't need to go through a couple different menus to find what you're looking for. Typing the simple keyword will open the exact flyout you need as opposed to going back and forth in a separate flyout. I agree with the point @cinqmilleans made about the advanced filters not being uses as often. Putting them inline in the text box like in Discord seems like a balanced solution of having the options for advanced users but not over complicating the feature for standard users.

How is it cleaner than the current solution?

@d2dyno1 because you don't need to go through a couple different menus to find what you're looking for. Typing the simple keyword will open the exact flyout you need as opposed to going back and forth in a separate flyout. I agree with the point @cinqmilleans made about the advanced filters not being used as often. Putting them inline in the text box like in Discord seems like a balanced solution of having the options for advanced users but not over complicating the feature for standard users.

How about we made both solutions possible - that is using words like "before" or "after" in the search box to set a filter, and also using a flyout for more advanced options (and, or, size range etc.) @yaichenbaum

@d2dyno1 I was thinking more the other way around of the simple options in the flyout (range can be one of them) and the more advanced filters such as and/or in the text box.

How about

@d2dyno1 I was thinking more the other way around of the simple options in the flyout (range can be one of them) and the more advanced filters such as and/or in the text box.

That wouldn't make sense because we end up with the mess in the searchbox

@d2dyno1 keep in mind, this would be for the advanced options that aren't used as often.

@d2dyno1 keep in mind, this would be for the advanced options that aren't used as often.

So advanced options + logic gates in the flyout, and more common ones in the searchbox, right?

@d2dyno1 no, the other way around 😂
Simple logic will be handled in the flyout. Advanced logic will be handled in the search box. Perhaps adding an and or or can insert an additional filter button in the search box which in turn will open a new flyout for the user to define the new logic. This will keep the search box clean but will have support for the advanced logic while keeping everything nice and simple for everyone else.

@yaichenbaum @d2dyno1
Here are more details on the implementation, including phase 2 which is already well advanced.

The filters model is very generic. The menu pickers must be able to display all the possible cases, but not necessarily to create them.
For example, the file size filter can contain any minimum and maximum size, but the picker only allows you to select specific sizes. The size parsing does not have this limit. The picker is designed to correctly display the size received by the filter, even if it cannot be selected. If the user opens the picker on this size and modifies it, he can no longer put it back with the picker.
When a filter is parsed in the search bar, it is deleted from the search bar and added to filters in the menu. This makes it possible not to clutter up the search bar, the small size of which does not allow you to accumulate filters. This displays the filters in a nicer, more structured and readable way.
A badge is added to the filter menu to indicate the number of active filters (at the first level). This bagde is hidden when there is no filter. This gives feedback to the user. When his filter is removed from the search bar, the bagde appears to let him know that the filter is in the menu.
It is clearly useful to offer more direct access to frequent filters in the menu.

We have several points of view on the interface.

For some, the menu should be very simple, and not allow everything.
For others, the menu should do it all but highlight frequent options.

I am of the opinion that the menu should do it all, but currently it does not sufficiently emphasize the frequent options.
If that's okay with you, I can suggest (in video) a new layout for the main page that will make the frequent options much more accessible, while making the others available.

I am of the opinion that the menu should do it all, but currently it does not sufficiently emphasize the frequent options.
If that's okay with you, I can suggest (in video) a new layout for the main page that will make the frequent options much more accessible, while making the others available.

I think everything can be placed inside the flyout, but we need a better design for the advanced options. Do you think you can hide the advanced operations for now so we can merge the rest since we all agree on the UX for the basic options?

Hi @cinqmilleans! Do you mind joining Files discord? https://www.discord.gg/Files. We would like to discuss the future of the search PR

@d2dyno1 I added to Discord.

@yaichenbaum @d2dyno1 Here is a demo of the new main research page. Everything does not work perfectly, but it is to validate the concept.

Some filters are pinned. The pinned filters appear first, even if they do not contain any values.
The list of pinned filters can become a user parameter to allow him to add or remove some (only at the first level, not in the and/or/not filters). To be discussed whether this functionality will be retained.
I changed the date filter names to match the rest of the app.
In the add menu, I no longer display a description when it is not necessary.
It is no longer possible to add 2x the same filter in the same parent. In the video, active or pinned filters are disabled. After some thought, we should leave them active but reach the picker of the active filter to modify it.
I added the name of the filter in the main page. It was missing a lot. This is even more important when you need to display the filter even without a value. Just displaying the name of the filter instead is unattractive.
I think values in a rounded button are not the best solution. It is difficult to display a long value, such as an aggregate of several values (especially for kinds). I made an example of what we can easily have by displaying more structured values. I am attaching this in pictures.

https://user-images.githubusercontent.com/46631671/145720771-50155774-160b-4db3-ba00-1f4b8f53a7fb.mp4

@cinqmilleans the UX pattern looks much better now.

I think values in a rounded button are not the best solution. It is difficult to display a long value, such as an aggregate of several values (especially for kinds). I made an example of what we can easily have by displaying more structured values. I am attaching this in pictures.

What if the font was made smaller?

@yaichenbaum I have already tried, it did not convince me. Importantly, this is inconsistent with the rest of the app, which never displays this kind of button. I will post different images to show the problem with some values too long (especially in other languages).

@yaichenbaum I have already tried, it did not convince me. Importantly, this is inconsistent with the rest of the app, which never displays this kind of button. I will post different images to show the problem with some values too long (especially in other languages).

I don't prefer one way or the other but it would be good to see what @itsmichaelwest and @mdtauk say since they worked on this design.

@yaichenbaum @d2dyno1 @itsmichaelwest @mdtauk @gave92 Here is the news of the ticket.

I am invited to discuss it orally. My level of English does not allow me an oral discussion, but we can organize a written discussion.
I won't have much time in the next 2 weeks to work on code. I don't think I'm the only one in this case. However, the chat can take place in December.
I am attaching some elements of reflection to improve the interface. We can always improve the interface. All this is to be discussed.

Suggestions:

Do not allow to have several instances of the same filter in a group has an inconvenience. It is not possible to choose separate ranges. For example: May 2018 or May 2019 or May 2020 (If we know the month but not the year). I therefore propose to authorize several instances of the same filter (via the add menu).
The big question is how to display the chosen parameters? I think that offering a structured display (as in the image) has advantages: more readable, more complete, allows certain sub-elements to be removed directly from the main page, displays the details of the groups (at least on one level).

Here are some examples for dates. The dates will probably be the more complex case to manage.
2021-12-16..2021-12-16
Today
2021-12-13..2021-12-15
from:Monday
to:Yesterday
2021-10-01..2021-10-31
October
2020-10-01..2020-10-31
October 2020
2021-04-01..2021-06-30
from:April
to:June
2021-01-01..2021-12-16
from:2021
2021-04-02..2021-04-07
from:4/2/2021
to:4/7/2021
..2019-06-30
to:June 2019
2021-12-10..
from:This week
2021-01-01..2021-01-15
from:1/1/2021
to:1/15/2021

The big question is how to display the chosen parameters? I think that offering a structured display (as in the image) has advantages: more readable, more complete, allows certain sub-elements to be removed directly from the main page, displays the details of the groups (at least on one level). Consistency with the parsing mode which will offer the same possibilities.

I thought the tag like design from one of your earlier iterations looked fairly good. Your latest iteration in that screenshot is almost there. I would recommend hiding the filter name once a filter is added in order to take up less space and because more text can make it harder to know what you're supposed to be looking at. Adding a background color to the chosen parameters is also a common pattern to indicate that it's an element that can be removed in case the user wants to change their search query.

@yaichenbaum

I don't think hiding the label when there is value is effective. The value does not indicate the filter (eg for different date filters). This is a problem in the current commited version.
I do not understand your comment about colored backgrounds. Could you give an example in another software?
Being able to apply filters to unfiltered content is a suggestion to investigate. I will test. You have to look at the behavior of the subfolders. Should we hide a subfolder that does not match? You also have to pay attention to performance. I am excited about the idea if it is feasible.

I don't think hiding the label when there is value is effective. The value does not indicate the filter (eg for different date filters). This is a problem in the current commited version.

I meant the part that says "Size" or "Modified, not the "before" and "after".

I do not understand your comment about colored backgrounds. Could you give an example in another software?

Being able to apply filters to unfiltered content is a suggestion to investigate. I will test. You have to look at the behavior of the subfolders. Should we hide a subfolder that does not match? You also have to pay attention to performance. I am excited about the idea if it is feasible.

I guess it's up for discussion, perhaps we should finish up with this PR and come back to this question later on.

@yaichenbaum I understand better the idea of "colored backgrounds". This control is interesting but I think it is not suitable in our case. Here are some arguments.

Tags are suitable when there are mainly yes / no options (contains attachments, ...). This is not our case. If we use tags we will also have to replace the checkboxes (include the subfolders) to make it consistent.
Tags are made to be displayed in lines. This implies not to display them after an icon. The icon must be part of the tag.
Tags must be short but complete. In our case, if the user chooses "Modification date between this week and yesterday", how to display it?
"after: This week" + "before: Yesterday" (but we don't know if this is the modification or creation date)
"modified: This week - Yesterday" (but can be very long in some languages, see too long)
"{icon} This week - Yesterday" (but you need a different icon for each filter class)
Tags are also useful when they are pre-filled. For example, in github, you can easily access a page containing the tags "is: open is: issue author: @me". We do not have any pre-filled cases.

Regarding the fact of hiding the label, I was talking about the difference between "Modification date" and "Creation date" for example. This difference should appear.

Tags are suitable when there are mainly yes / no options (contains attachments, ...). This is not our case. If we use tags we will also have to replace the checkboxes (include the subfolders) to make it consistent.

There are many cases where tags are used without there being an action required, in fact we already use this for the tag feature in Files for labeling Files. Another example where it's used otherwise is on GitHub, and besides, we already have an action on the flyout to apply the arguments. Can you explain what you mean by the checkboxs?

Tags are made to be displayed in lines. This implies not to display them after an icon. The icon must be part of the tag.
Tags must be short but complete. In our case, if the user chooses "Modification date between this week and yesterday", how to display it?

The tag feature in Files and GitHub both display them in line with other text and icons. If we do move the flyout back out of the search box so that it can be used as a regular filter feature separately from the search box, we can make the flyout widget and the text in the labels a little smaller so that more can fit in the flyout at once.

Tags are also useful when they are pre-filled. For example, in github, you can easily access a page containing the tags "is: open is: issue author: @me". We do not have any pre-filled cases.

Wouldn't the date/size/type be the prefilled data?

@yaichenbaum I started a demo which uses tags. I redefined the style to show more. It looks better than I expected, but still struggles to display long values. It will also be necessary to manage the groups. I will publish 2 videos, one with a structured menu, one with tags. I am using predefined tags with no values for Size and Date.

@cinqmilleans did you try moving the flyout button out of the search box again and making the flyout wider?

@yaichenbaum This is not the problem. The problem is that too much tag is ugly. In French, we can have as text "Modifié: La semaine dernière - Plus tôt cette semaine".

@yaichenbaum This is not the problem. The problem is that too much tag is ugly. In French, we can have as text "Modifié: La semaine dernière - Plus tôt cette semaine".

Modifié: doesn't have to be in the tag as that's the header.

Can we have a checkbox to automatically wrap the string that is being searched for into * ?

@R3voA3 I do not understand your request. Could you concretely explain your suggestion?

@R3voA3 I do not understand your request. Could you concretely explain your suggestion?

Nevermind. Seems like the search does already what I want by default.
On another note, will the new UI allow users to save search patterns?

@R3voA3 It is envisaged but not yet decided. We could add backups of search parameters, and include test cases (all empty folders, this week's documents, ...). It is not the priority, but a lot of things are planned to improve research.

@yaichenbaum Here are some tag mockups. I did not delete the titles because it is very detrimental to understanding. There are several versions: tags, labels, with or without delete button, with button visible on mouse over, with collapsible or pinnable filters.

@yaichenbaum Here are some tag mockups. I did not delete the titles because it is very detrimental to understanding. There are several versions: tags, labels, with or without delete button, with button visible on mouse over, with collapsible or pinnable filters.

@cinqmilleans those look much closer to my vision. Have you tried making the flyout a bit wider so there is more room for the filters?

@cinqmilleans those look much closer to my vision. Have you tried making the flyout a bit wider so there is more room for the filters?

@yaichenbaum With this presentation, the width is not a problem. However, it can be widened a bit if needed.
I will add the modifications this weekend (tags, pinned filters, ...). I need to know if the pinned filters are fixed or if it is a default choice which allows the user to pin/unpin filters.

@yaichenbaum With this presentation, the width is not a problem. However, it can be widened a bit if needed.
I will add the modifications this weekend (tags, pinned filters, ...). The list of pinned filters will be fixed. We can add the edition later, it is desirable.

What are pinned filters and how can you set them?

@cinqmilleans the UI takes up a lot more vertical space than initially anticipated. I think we should consider moving it to a pane like @mdtauk originally suggested.

@yaichenbaum

Regarding the panel vs flyout choice. The example images are intentionally very full but the user will rarely select so many elements. By default, there are only 2 items with no values.
If we opt for a panel, we must decide what to do with the search field:

Leave it in the navigation bar and only use the panel for filters. It's practical, but the elements are scattered.
Display it only in the panel. It's unified but less practical, especially with phase 2 which will provide parsing.
Only display it in the navigation bar if the panel is closed. It is effective but can be confusing.

I can do demo screenshoots with a panel when I'm done implementing the new UI for the page.

Regarding the pinned filters. In the current implementation, there are 2 filters that are always visible (Size and Date Modified). The list is fixed. However, an easy evolution will be to allow pinning / unpinning certain elements on the main page (as seen on some screenshoots.

Regarding the implementation. I have reviewed the code completely.

The model is more complete to provide for each filter the possibilities directly in the model. It's easier.
For the developer, it is easier to create a new type of filter, without having to edit many switches as before. You just have to create the model and the view.
The dates and sizes have been revised to have a more maintainable and efficient code.
The model manages labels and tags better.
Date tags are richer to display information in a concise way (only the month, year or day of the week when relevant).
The ViewModel has been greatly reduced. It was too complex and redundant with the model and the view.
The view has been clipped into more controls when it was relevant. This saves the viewmodel when it made more sense to have a dedicated controller.
The page navigation system has been moved to one centralized service instead of being in many viewmodels.

I still need to complete the group filters UI. Sorry in advance to the reviewers who will have to reread everything.

@yaichenbaum Here is a video of the new version (fully implemented) and pictures of the panel version (demo). We can not put the searchbox there. I've included the edits from the previous post and the badge. To decide which version to use.
https://user-images.githubusercontent.com/46631671/149631129-1a55fbc4-f038-4eb0-9bd4-256118521e22.mp4

@cinqmilleans I'd opt for leaving the search box in the navigation toolbar. Other than that, I think those changes are satisfactory.

@yaichenbaum For information, here is how I will proceed.

I will refactor the pane display to make it generic. This will make it easy to add new panels but only one can be visible.
Add the search panel and all the model layer and associated controls.
I would do 2 prs because it's easier for reviewers.

@yaichenbaum For information, here is how I will proceed.

I will refactor the pane display to make it generic. This will make it easy to add new panels but only one can be visible.
Add the search panel and all the model layer and associated controls.
I would do 2 prs because it's easier for reviewers.

@cinqmilleans great! Will you add a seperate button next to the preview pane button for filters?

@yaichenbaum Yes it is planned.

@cinqmilleans can you confirm that this will resolve #2588?

@yaichenbaum No, this is not planned. I didn't know this feature existed in File Explorer.
This feature is not related to search (which allows searching in a set of folders). It is a simple display filter in the Detail view. You can filter any folder without doing a search. It's a nice feature, but unrelated to the SearchBar.
However, we could implement it in the SearchPanel. This would make it possible to have it in all views. This requires some thought and will not be part of phase 1.

@yaichenbaum No, this is not planned. I didn't know this feature existed in File Explorer.
This feature is not related to search (which allows searching in a set of folders). It is a simple display filter in the Detail view. You can filter any folder without doing a search. It's a nice feature, but unrelated to the SearchBar.
However, we could implement it in the SearchPanel. This would make it possible to have it in all views. This requires some thought and will not be part of phase 1.

That's more or less what I meant, I think having consistency between the search and filter feature makes sense.

@cinqmilleans Could you resolve conflicting files?

Un subscribe
On Fri, 28 Jan 2022, 2:08 pm d2dyno, @.***> wrote:

@cinqmilleans https://github.com/cinqmilleans Could you resolve
conflicting files?
—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/pull/6679#issuecomment-1023997822,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU2UJ2UXMYNFNDA5UL5WRHDUYJI2BANCNFSM5HEBOXCA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@d2dyno1 No, I wouldn't because this pr is no longer meant to be committed.
As mentioned above, I've completely reworked the code for more efficiency, performance and maintainability but haven't released it yet. I do not publish in this pr because the code has changed too much. It was also decided not to place the filters in the search bar but in a new right panel (like the previews). For this I created a pr, waiting for acceptance, to be able to incorporate new right panels.
When this pr is integrated, I will publish a new pr containing the search options panel and the associated model. I did not close this pr to leave the discussion on the content of the options.

@d2dyno1 No, I wouldn't because this pr is no longer meant to be committed.
As mentioned above, I've completely reworked the code for more efficiency, performance and maintainability but haven't released it yet. I do not publish in this pr because the code has changed too much. It was also decided not to place the filters in the search bar but in a new right panel (like the previews). For this I created a pr, waiting for acceptance, to be able to incorporate new right panels.
When this pr is integrated, I will publish a new pr containing the search options panel and the associated model. I did not close this pr to leave the discussion on the content of the options.


VIDEO Intro to statistics. Shows "Height", but "Weight" is meant

Describe the bug
At 2:32  and until 4:42 Dmitry mentions "Height" and a table showing baseball players heights is shown. Most likely Weight is meant.
Expected behavior
The video should be edited again
Screenshots

Thanks for catching this, @bromero26!
@shwars let us know what you'd like to do - I think an edit (adding a note/voiceover/background edit) would be fine

Hello @paladique!
I am an openforce 2022 contributor. I would love to work on this issue and make PR as soon as I resolve the issue. Please do assign this to me.
ThankYou:)

@purohitmansi we are not assigning issues in this repo and you won't be able to edit Dmitry's video.


build: add missing conditions for linux/ppc

Use the Linux platform API implementations for PPC on Linux builds.
Risk Level: Low
Testing: ran tests for PPC with internal Bazel fork that supports them
Docs Changes: none
Release Notes: n/a

/assign htuch

/assign @cmluciano
@akonradi I'm running this through the ppc64le CI now to verify the change. Can you comment on what the build error is that you're seeing? A static compile of envoy has been successful for the past month so I'm not sure what may have changed.

A compile on bazel 0.25.2 with & without this build on gcc-7 passes in ppc64le CI. It would be great to know if this is a test or other compile toolchain difference that makes this fail on your side @akonradi .

This is to fix build failures for //test/server:options_impl_test. On PPC on Linux, it attempts to instantiate MockLinuxOsSyCalls which depends on the Linux-specific syscalls header. Since Bazel isn't providing the header by default, the build fails (without this PR).

Ah I thought it might be a test case, let me try running that again. I think I need to start running all the test cases in our CI instead of just compiling the binary :P


add way to provide list of output produced

This forces consideration of all data we expect to write and gives us a way to separate which things are configuration versus management versus guest in a structured way.

please also squash the commits.


2.0-preview _clearSuggestion not working on Firefox

I'm calling sevral times suggestions() from <paper-autocomplete> to refresh the suggestions and realize the _clearSuggestion from paper-autocomplete-suggestion` isn't removing the "suggestions nodes" (Firefox + Polymer 2).
On this line : https://github.com/ellipticaljs/paper-autocomplete/blob/2.0-preview/paper-autocomplete-suggestions.html#L546
children[0] always references the first child on Firefox.

Fixed by #75


Build issue for Viewer

Describe the Bug
I am trying to build the Viewer for iframe in React but it give error as below. This error coming when we load the build in iframe for our React project. Can you please help to resolve the issue?

Steps to Reproduce

npm run build in Viewer app
Place build in public folder of new React app
Issue will be found

The current behavior
It's giving error.
The expected behavior
It must be load for the iframe.
OS
All
Node version
20.9.0
Browser
All

Could you please provide additional details for your reproduction steps? The current information is insufficient for me to implement. It would be great if you could include a zip file as well.


v0.1.0

TODO

[x] Specify which base model you want to deploy with .env files, quickly deploy them with bash file.
[x] Refactor inference code with LoRA manager (done here https://github.com/cloneofsimo/lora/pull/172) , because SRP i guess
[ ] Allow inputs from webui format LoRAs.
[ ] Better readme so people can launch their own

Since this seems to work, ill merge this as it fixes extra bugs as well. @andreasjansson want to have a look?
https://replicate.com/p/7vzfczi3b5bxlomtficluk5nue


Deprecate the final_step_result parameter of TrialResult

Follow-up to #5260, as that PR makes final_step_result unnecessary.
Also deprecate DensityMatrixSimulatorState and StateVectorSimulatorState
Closes #5271

@95-martin-orion This ended up being bigger than I thought, but should end up making things simpler once all these things get fully removed. The removal of mocks from a bunch of tests is a good sign. No rush on this one.


New-BCContainer with databaseparams fails at Import Encryption Key

PLEASE DO NOT INCLUDE ANY PASSWORDS OR TOKENS IN YOUR ISSUE!!!
Describe the issue
New-BCContainer with databaseparams fails at Import Encryption Key.
I have installed SQL server on host, and enabled mixed mode authentication.
I have created sa user in SQL Server on host.
I have disabled all firewall on host.
Scripts used to create container and cause the issue
# new-navbccontainer with sql server database created in host machine

$containerName = 'bcserver4'
$password = 'P@ssw0rd'
$securePassword = ConvertTo-SecureString -String $password -AsPlainText -Force
$credential = New-Object pscredential 'admin', $securePassword
$auth = 'UserPassword'

#$licenseFile = $licenseFileSecret.SecretValueText

#$artifactUrl = Get-BcArtifactUrl -country us
$artifactUrl = "https://bcartifacts.azureedge.net/sandbox/22.5.59966.60187/au"

$databaseParams = @{
    "databaseServer" = 'host.containerhelper.internal'
    "databaseInstance" = ''
    "databasePrefix" = "$containerName-"
    "databaseName" = 'CRONUS'
    "databaseCredential" = New-Object pscredential 'sa', $securePassword
    "multitenant" = $true
}

New-BcContainer @databaseParams -replaceExternalDatabases `
    -accept_eula `
    -containerName $containerName `
    -credential $credential `
    -auth $auth `
    -artifactUrl $artifactUrl `
    -updateHosts

Full output of scripts
S C:\Windows\system32> C:\Users\jorda\Desktop\docker shortcuts\Create BCContainer with local database.ps1
BcContainerHelper is version 6.0.0
BcContainerHelper is running as administrator
HyperV is Enabled
UsePsSession is True
Host is Microsoft Windows 11 Pro - 10.0.22621.2715
Docker Client Version is 24.0.6
Docker Server Version is 24.0.6
Removing Session bcserver4
Removing container bcserver4
Removing Desktop shortcuts
Removing C:\ProgramData\BcContainerHelper\Extensions\bcserver4
Setting database bcserver4-tenant offline
Removing database bcserver4-tenant
Setting database bcserver4-CRONUS offline
Removing database bcserver4-CRONUS
Starting Database Restore job from https://bcartifacts.azureedge.net/sandbox/22.5.59966.60187/au
C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\6.0.0\Import-BcContainerHelper.ps1
Fetching all docker images
Fetching all docker volumes
Using image mcr.microsoft.com/businesscentral:10.0.20348.2031
Creating Container bcserver4
Style: sandbox
Multitenant: Yes
Version: 22.5.59966.60187
Platform: 22.0.60139.0
Generic Tag: <IP_ADDRESS>
Container OS Version: 10.0.20348.2031 (ltsc2022)
Host OS Version: 10.0.22621.2715 (22H2)
Using process isolation
Using locale en-AU
Disabling the standard eventlog dump to container log every 2 seconds (use -dumpEventLog to enable)
Files in C:\ProgramData\BcContainerHelper\Extensions\bcserver4\my:
- AdditionalOutput.ps1
- MainLoop.ps1
- SetupDatabase.ps1
- SetupVariables.ps1
- updatecontainerhosts.ps1
Creating container bcserver4 from image mcr.microsoft.com/businesscentral:10.0.20348.2031
ae202d052745af028715b57add1727ccb1d81ef27b7cf77e3dc694bd4df49056
Waiting for container bcserver4 to be ready
Using artifactUrl https://bcartifacts.azureedge.net/sandbox/22.5.59966.60187/au
Using installer from C:\Run\210-new
Installing Business Central
Installing from artifacts
Starting Local SQL Server
Starting Internet Information Server
Copying Service Tier Files
c:\dl\sandbox\22.5.59966.60187\platform\ServiceTier\Program Files
c:\dl\sandbox\22.5.59966.60187\platform\ServiceTier\System64Folder
Copying PowerShell Scripts
c:\dl\sandbox\22.5.59966.60187\platform\WindowsPowerShellScripts\Cloud\NAVAdministration
c:\dl\sandbox\22.5.59966.60187\platform\WindowsPowerShellScripts\WebSearch
Copying Web Client Files
c:\dl\sandbox\22.5.59966.60187\platform\WebClient\Microsoft Dynamics NAV
Copying ModernDev Files
c:\dl\sandbox\22.5.59966.60187\platform
c:\dl\sandbox\22.5.59966.60187\platform\ModernDev\program files\Microsoft Dynamics NAV
Copying additional files
Copying ConfigurationPackages
C:\dl\sandbox\22.5.59966.60187\au\ConfigurationPackages
Copying Test Assemblies
C:\dl\sandbox\22.5.59966.60187\platform\Test Assemblies
Copying Extensions
C:\dl\sandbox\22.5.59966.60187\au\Extensions
Copying Applications
C:\dl\sandbox\22.5.59966.60187\platform\Applications
Copying Applications.AU
C:\dl\sandbox\22.5.59966.60187\au\Applications.AU
Copying dependencies
Copying ReportBuilder
Importing PowerShell Modules
Skipping restore of Cronus database
Modifying Business Central Service Tier Config File for Docker
Creating Business Central Service Tier
Installing SIP crypto provider: 'C:\Windows\System32\NavSip.dll'
Installation took 38 seconds
Installation complete
Initializing...
Setting host.containerhelper.internal to <IP_ADDRESS> in container hosts file
Starting Container
Hostname is bcserver4
PublicDnsName is bcserver4
Using NavUserPassword Authentication
Waiting for database creation to finish
Success
Import Encryption Key
Cannot establish a connection to the SQL Server/Database.

This could be due to one of the following reasons:

* SQL Server is not started.
* The database does not exist.
* Proper permissions have not been given to the NAV Server Account.

Try again later or contact your system administrator.
at <ScriptBlock>, C:\run\setupDatabase.ps1: line 152
at <ScriptBlock>, C:\Run\my\SetupDatabase.ps1: line 2
at <ScriptBlock>, C:\Run\navstart.ps1: line 138
at <ScriptBlock>, C:\Run\start.ps1: line 384
at <ScriptBlock>, <No file>: line 1Error
Using artifactUrl https://bcartifacts.azureedge.net/sandbox/22.5.59966.60187/au
Using installer from C:\Run\210-new
Installing Business Central
Installing from artifacts
Starting Local SQL Server
Starting Internet Information Server
Copying Service Tier Files
c:\dl\sandbox\22.5.59966.60187\platform\ServiceTier\Program Files
c:\dl\sandbox\22.5.59966.60187\platform\ServiceTier\System64Folder
Copying PowerShell Scripts
c:\dl\sandbox\22.5.59966.60187\platform\WindowsPowerShellScripts\Cloud\NAVAdministration
c:\dl\sandbox\22.5.59966.60187\platform\WindowsPowerShellScripts\WebSearch
Copying Web Client Files
c:\dl\sandbox\22.5.59966.60187\platform\WebClient\Microsoft Dynamics NAV
Copying ModernDev Files
c:\dl\sandbox\22.5.59966.60187\platform
c:\dl\sandbox\22.5.59966.60187\platform\ModernDev\program files\Microsoft Dynamics NAV
Copying additional files
Copying ConfigurationPackages
C:\dl\sandbox\22.5.59966.60187\au\ConfigurationPackages
Copying Test Assemblies
C:\dl\sandbox\22.5.59966.60187\platform\Test Assemblies
Copying Extensions
C:\dl\sandbox\22.5.59966.60187\au\Extensions
Copying Applications
C:\dl\sandbox\22.5.59966.60187\platform\Applications
Copying Applications.AU
C:\dl\sandbox\22.5.59966.60187\au\Applications.AU
Copying dependencies
Copying ReportBuilder
Importing PowerShell Modules
Skipping restore of Cronus database
Modifying Business Central Service Tier Config File for Docker
Creating Business Central Service Tier
Installing SIP crypto provider: 'C:\Windows\System32\NavSip.dll'
Installation took 38 seconds
Installation complete
Initializing...
Setting host.containerhelper.internal to <IP_ADDRESS> in container hosts file
Starting Container
Hostname is bcserver4
PublicDnsName is bcserver4
Using NavUserPassword Authentication
Waiting for database creation to finish
Success
Import Encryption Key
Cannot establish a connection to the SQL Server/Database.

This could be due to one of the following reasons:

* SQL Server is not started.
* The database does not exist.
* Proper permissions have not been given to the NAV Server Account.

Try again later or contact your system administrator.
at <ScriptBlock>, C:\run\setupDatabase.ps1: line 152
at <ScriptBlock>, C:\Run\my\SetupDatabase.ps1: line 2
at <ScriptBlock>, C:\Run\navstart.ps1: line 138
at <ScriptBlock>, C:\Run\start.ps1: line 384
at <ScriptBlock>, <No file>: line 1
New-BcContainer Telemetry Correlation Id: b7d0b592-3a37-4405-a23a-e046314deb32
Initialization of container bcserver4 failed
At C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\6.0.0\ContainerHandling\Wait-NavContainerReady.ps1:42 char:17
+ ...             throw "Initialization of container $containerName failed" ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Initialization ...cserver4 failed:String) [], RuntimeException
    + FullyQualifiedErrorId : Initialization of container bcserver4 failed

Screenshots
None
Additional context
Database were successfully created and restored on Host.
Host is on windows 11 Pro.
I have successfully ran dockers before but with SQL server express installed in docker container itself. This is 1st time attempting to create docker with connection to host sql server.

so the Host machines runs the SQL Server DB ?  Have you added the users you provide here to the DB Server, mapped to the DB in question, and set the SQL server to allow mixed mode auth? ...oh you wrote that in the top.... check it once more :) not sure you have to map the sa user....
you can use the broken container to test a couple of things: like : can you reach the host ( ping) can you reach the SQL server invoke-sqlcmd ) you might also want to check the SQL Logs to see if the SQL server had a reason to kick the login from the user you provide.

I've the same issue, thx to @KristofKlein, first step to check some details, ping host.containerhelper.internal.
Pinging host.containerhelper.internal [<IP_ADDRESS>] with 32 bytes of data:
Request timed out.
Request timed out.
Request timed out.
Request timed out.
Ping statistics for <IP_ADDRESS>:
Packets: Sent = 4, Received = 0, Lost = 4 (100% loss),
so I find out, hosts file in bc-container is written (name host.containerhelper.internal-><IP_ADDRESS>).
Maybe the network adapter seems to be lost. Is there an idea to check the next gear?

-updateHosts causes ContainerHelper to set host.containerhelper.internal to the IP number of the gateway inside the container, which should work if you are using the default NAT network.

-updateHosts causes ContainerHelper to set host.containerhelper.internal to the IP number of the gateway inside the container, which should work if you are using the default NAT network.

Yes, I understood that too. Currently you can only install containers with Hyper-V. Is it possible that this results in an overlap in the IP address? Then that might be an explanation for why it doesn't ping for me.

If you are running Windows Server 2016, 2019 or 2022 - you can run process or hyperv isolation (with an advantage in perf to process isolation)
If you are running Windows 11 - you can run process or hyperv isolation (with an advantage in perf to hyperv isolation on my machine at least)
If you are running Windows 10 - you can run hyperv isolation.
The network stack is orthogonal to whether you are running process or hyperv isolation.
If you run:
ipconfig /all

on the host and in the container.
then you should on the host have something like:

Which is the virtual network adapter, which your containers are using as their default gateway to connect to the outside world.
Inside the container, you should have a default gateway pointing to that IP, like:

It is important that your SQL Server listens on ALL IP addresses - not only on <IP_ADDRESS> or the public IP.
If host.containerhelper.internal points to the default gateway and you can ping <IP_ADDRESS>:

Then your network stack is working. Whether you can ping the host.containerhelper.internal depends on the firewall on the host. The host firewall also needs to be open for port 1433


[RESEARCH] Semantic Versioning

When the delevopment branch is ready to be merged into main, it should come with a new release version.
Info on semantic versioning: Link

Seems possible to automate version releases: Link


SubscribeCommand doesn't handle indication

So far i could find out is the type when invoking SubscribeCommand.start() always Type.SUBSCRIBE_NOTIFICATION. It looks this feature to make this decision is not implemented?

indications aren't supported at the moment and the only reason being is that we don't have any BLE devices that would make use of the and we could not really test them.
Happy though to merge in a pull request :)

Dear Tomaz,
thank you for the answer, i will see if i find a proper way to integrate this.
Thank you,
Daniel


Fudge scale data to become white-only

This is useful for exporters that read data linearly.
User-defined padding value.
For 7-note scales: Pad to 12-notes.
(Black-only) For 5-note scales: Pad to 12-notes.
Everything else: Start from a low MIDI note and repeat the scale until it's a multiple of 12 with padding added for black keys.

0.5° 🥨 — Today at 7:18 PM

BTW that should probably be sovable using KBM which allows both subscaling an SCL scale and adding dummy notes that don’t play anything from the SCL. Warning users that the feature works only when they export (and use) both SCL and KBM seems like an UX pain, also I don’t know how other formats handle that


Python 3.X migration of README.md

Coverage remained the same at 60.19% when pulling ce4621cec36a4b644d201074df429b0f7519be3d on dongbohu:master into c08c226879fd6cb81e2f10e53cb1170f51243baf on bbengfort:develop.


xlsx-cli refactor

Closes #1922
Refactored the CLI into packages/xlsx-cli and published the NPM package here.
With this refactor, we have completely commander and exit-on-epipe as dependencies in the main library and the submodules.
For convenience, here are the PRs for the CLI refactors of the submodules in one place:

alder32
ssf
crc32
cfb

To run the cli, install it with npm i -g xlsx-cli, then run npx xlsx-cli.

The xlsx-cli package.json should have the repository config, so that npmjs.com can link to the source repository.

@garrettluu the codepapage package also needs such a refactoring

c1f5f04


fix(autoware_mpc_lateral_controller): fix bugprone-misplaced-widening-cast

Description
This is a fix based on clang-tidy bugprone-misplaced-widening-cast error.
/home/emb4/autoware/autoware/src/universe/autoware.universe/control/autoware_mpc_lateral_controller/src/lowpass_filter.cpp:128:16: error: either cast from 'int' to 'size_t' (aka 'unsigned long') is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast,-warnings-as-errors]
      tmp += u[static_cast<size_t>(i + j)];
               ^

Related links
Parent Issue:

Link

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

Other errors also exist, but they are not corrected at this time because of their low severity.

@kobayu858
Your change seems to be incorrect. Please check again.

@veqcc
I forgot that it is a negative value. Thank you for pointing that out.

The index is now calculated first to make sure it does not exceed the range before casting.

@TakaHoribe @takayuki5168
Please confirm the PR. Thank you very much.


Code completion does not complete when function is defined within the script

When a function is defined within a script, code completion for this function won't work for some scenarios.
This painfully surfaces in editors such as ISE and VSCode: when working on code in one editor pane, intellisense stops working inside of this editor pane.
It does work on other editor panes. However, when a typical script author works on a solution with more than one function and tries to reference one of these functions from other places in the same script, Intellisense is broken.
Steps to Reproduce
Example 1: Complete Corruption of Parameter Completion
When a function parameter uses PS-defined enums, all function parameters become invisible:
Actual Behavior
$script1 = '
enum Cities
  {
    Hannover
    Redmond
    NewYork
  }

  function Test-It
  {
    param
    (
      [Cities]
      $City
    )

    $PSBoundParameters
  }

  Test-It -'

TabExpansion2 -inputScript $script1 -cursorColumn $script1.Length | select -ExpandProperty CompletionMatches

Result: none
Expected Behavior
To simulate the expected behavior, simply remove the enum from the code and place it into a parent scope:
enum Cities
  {
    Hannover
    Redmond
    NewYork
  }

$script1 = '
  function Test-It
  {
    param
    (
      [Cities]
      $City
    )

    $PSBoundParameters
  }

  Test-It -'

TabExpansion2 -inputScript $script1 -cursorColumn $script1.Length | select -ExpandProperty CompletionMatches

Result: Completion Match for parameter -City
Example 2: Corruption of Argument Completion
When a function parameter uses the attribute [ArgumentCompleter()], the argument completion fails if the function is defined in the same script:
Actual Behavior
$script = '
  function Test-It
  {
    param
    (
      [ArgumentCompleter({"Hannover","Redmond","NewYork"})]
      $City
    )

    $PSBoundParameters
  }

Test-It -City '

TabExpansion2 -inputScript $script -cursorColumn $script.Length | select -ExpandProperty CompletionMatches

Result: default path completion
Expected Behavior
To simulate the expected behavior, place the function definition into the parent scope:
function Test-It
  {
    param
    (
      [ArgumentCompleter({"Hannover","Redmond","NewYork"})]
      $City
    )

    $PSBoundParameters
  }

$script = 'Test-It -City '

TabExpansion2 -inputScript $script -cursorColumn $script.Length | select -ExpandProperty CompletionMatches

Result: Completion Matches for the three cities defined by the attribute
Note: Register-ArgumentCompleter is unaffected by this issue because the associated scriptblocks are defined outside the current scope.
Environment data
Name                           Value

PSVersion                      7.0.0
PSEdition                      Core
GitCommitId                    7.0.0
OS                             Microsoft Windows 10.0.18363
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

I tried example 1 in WinPS 5.1 and it also fails.  I thought this might have been a regression, but it appears that has never worked?

It in fact seems to be a bug carried over from the old code base. It actually surfaced in VSCode where it messes up IntelliSense but is present in ISE as well.
It is surfacing with a delay probably because it is triggered by techniques that only recently became increasingly popular and were newly added in WPS 5.


After commit 1f9d055 I can't connect anymore to aria2

Worked like charm for two years, and suddenly today stopped working. Looking at the repo saw the last commit (1 day ago) and just to be sure, cloned the repo, checked out an older commit and started the server, and it works.
My enviroment is entware (an embbeded linux distro for routers), inside an old ASUS RT-N16.
Aria2 Version 1.32.0 with this features enabled:
BitTorrent, GZip, HTTPS, Message Digest, Metalink, XML-RPC, SFTP

Closing since there has be no activity in a long time. Please reopen if you still have issues


Example for chrono::NaiveDateTime in qs

Description
Is there an example of how to pass a chrono::NaiveDateTime in a querystring?
Here's a sample of what i'm struggling with
Playground
use serde_urlencoded; // 0.6.1
use chrono::{NaiveDate, NaiveDateTime}; // 0.4.13

fn main() {
    // ✅ Good
    let qs = "foo=2015-09-05%2011%3A01%3A01";
    let res = serde_urlencoded::from_str::<Vec<(String, String)>>(qs);
    println!("{:?}", res);

    // ✅ Good
    let qs = "foo=2020-01-01";
    let res = serde_urlencoded::from_str::<Vec<(String, NaiveDate)>>(qs);
    println!("{:?}", res);

    // ❌ Bad
    let qs = "foo=2015-09-05%2011%3A01%3A01";
    let res = serde_urlencoded::from_str::<Vec<(String, NaiveDateTime)>>(qs);
    println!("{:?}", res);
}

// Ok([("foo", "2015-09-05 11:01:01")])
// Ok([("foo", 2020-01-01)])
// Err(Error { err: "input contains invalid characters" })

End goal

Specify start/end dates in a querystring
Parse and deserialize them
Use them in a tokio-postgres SQL query for date filtering, where the column is timestamp

Something like (which might be absurd, but I'm curious if it's possible)
http://localhost:3000/users/a5f5d36a-6677-41c2-85b8-7578b4d98972/attempts?limit=15&offset=15&start=2020-08-09%2003%3A10%3A07%2E813517&end=2020-08-09%2003%3A10%3A07%2E813517

Did you check what [("foo", some_naive_date_time)] encode to? Does it work? Does it then fail to roundtrip?

Hey @nox thanks for responding!
I hope I'm doing this "roundtrip test" correctly:

encoding NaiveDateTime to string works ✅
encoding str to NaiveDateTime does not work ❌

Playground
use serde_urlencoded; // 0.6.1
use chrono::{NaiveDate, NaiveDateTime}; // 0.4.13

fn main() {
    // ✅ Good
    // let's encode `[("foo", some_naive_date_time)]`
    let some_naive_date_time = NaiveDateTime::from_timestamp(1_000_000_000, 0);
    assert_eq!(some_naive_date_time, NaiveDate::from_ymd(2001, 9, 9).and_hms(1, 46, 40));

    let res = serde_urlencoded::to_string(&[("foo", some_naive_date_time)]);
    println!("{:?}", res);
    // Ok("foo=2001-09-09T01%3A46%3A40")

    // "round trip" fails! 😭
    let qs = "foo=2001-09-09T01%3A46%3A40";
    let res = serde_urlencoded::from_str::<Vec<(String, NaiveDate)>>(qs);
    println!("{:?}", res);
    // Err(Error { err: "trailing input" })
}

Interesting, will look into that, I guess I have quite some free time right now hah.

That would be awesome.
I'm using https://github.com/seanmonstar/warp, which uses serde_urlencoded internally

Note that I didn't forget about that but I got laid off so I'm just a bit distracted. :D

Hold on, were you a part of the Mozilla layoffs?!? 🙄


Update Composer dependencies (2024-10-04-00-11)

Visual regression test passed!
View the visual regression test report


Invalid document link

In Prerequisites section, there is invalid document link:
The resources and their configuration created in the [previous article][./tutorial-deploy-python-web-app-azure-container-apps-02.md] of this tutorial series.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ad995982-9156-c13c-5295-a52b2bd3cdd2
Version Independent ID: ad995982-9156-c13c-5295-a52b2bd3cdd2
Content: Configure CI/CD for a Python web app in Azure Container Apps - Python on Azure
Content Source: articles/python/tutorial-deploy-python-web-app-azure-container-apps-03.md
Service: azure-python
GitHub Login: @bobtabor-msft
Microsoft Alias: rotabor

Hi @hund030,
Thanks so much for your feedback, and your help improving our documentation! The link has been fixed and the updated topic is now live. I'm going to go ahead and close this issue.
Thanks again,
Jimaco

#please-cl;ose

@bobtabor-msft @KarlErickson Can one of you please close this. The topic has been updated.


Include reported memory usage in results

Currently several metrics can be exported from the perf logs and included in the tabular results of the benchmark.
Similarly, the memory usage, which is tracked by runsolver and logged in the respective log file, should be extracted and included as well.

added


[DOC] Broken links in Testing framework overview

Describe the issue linked to the documentation
Many of the links in the Testing Framework Overview page are broken and lead to pages that do not exist.
https://www.sktime.org/en/stable/developer_guide/testing_framework.html

Suggest a potential alternative/fix
This is most probably caused by issues in how the links are mentioned in the .rst files and need to be fixed.

Hi, I want to work on this.


Stop using a matrix section in .travis.yml

It has been deprecated and was overwriting the docs generation job

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   84.91%   84.91%
=======================================
  Files           4        4
  Lines         232      232
=======================================
  Hits          197      197
  Misses         35       35

Impacted Files
Coverage Δ

src/svd.jl
91.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d67f5...8b67b55. Read the comment docs.


Formal third party security audit of Ambient

I am pushing for this to happen within the GA timeframe but it might not be likely.
Generally, the OSTIF will put out an RFP to vendors, who have time to respond, and then one is chosen, scheduled, run etc.  Can take several months.
I've registered the project's preferred vendors for this project and hopefully that will cut down the RFP time.

Kick-off meeting Tue 22 Oct.


Add guarding against resubmitting the same bio

Addressed a couple of other issues as part of this PR:

Bio pathway titles are now user friendly
Corrected the ability to 'Restart' a bio (preventing overriding the previously completed one)


Integers in Signatures, Pilots, Starbases, do not update on commit

As per this image, the tabs along the top of the wormhole details page do not update after inputting data. Selecting a different wormhole, then coming back updates the tabs.

That's been the case for a while.  My guess is we need to sprinkle some refresh commands or whatever django calls them throughout certain functions.