PMTUD may be implemented incorrectly

Hi,
We talked about the DF bit on Windows a while ago, and I submitted https://github.com/lucas-clemente/quic-go/pull/3155. But apparently it led to this unforeseen problem https://github.com/lucas-clemente/quic-go/issues/3273 so PMTUD ended up being disabled on Windows as a dirty fix. As I revisited this today I realized that perhaps there is something fundamentally wrong with the way quic-go currently implements PMTUD, and it's not really a Windows issue.
Previously we both assumed that the DF bit is enabled by default on Linux. But that's not true, as the man page says this:

The default behavior on Linux (IP_PMTUDISC_WANT) is to only set DF bit when the packet is smaller than the path MTU, and fragment the packet otherwise. This implies that right now even if quic-go sends a packet larger than the path MTU, it will still be fragmented, sent, and received, nullifying PMTUD altogether. And if you explicitly set it to IP_PMTUDISC_DO, you will get a similar behavior as on Windows - errors when trying to send packets larger than the path MTU, instead of discarding them silently.
I wrote a demo and verified this on my Ubuntu 20.04 server, which has an MTU of 1500. When it sends packets smaller than 1500, the DF bit is set. When it sends packets larger than 1500, it fragments them and sends them successfully nonetheless.

I also wrote a custom PacketConn that adds some padding bytes to every packet to make it larger, and passed it to quic-go. The QUIC payload reaches MaxPacketBufferSize regardless of the MTU and the actual packet size going out.

Does setting the DF socket option resolve this?

That would lead to the same problem as in https://github.com/lucas-clemente/quic-go/issues/3273 - the kernel returns error instead of silently dropping the packet, at least on Linux. Haven't tried it on any other platform.

The error looks like this on Linux: write udp [::]:52857->x.x.x.x:6003: sendto: message too long

We can either catch that error, or just ignore it and let loss recovery kick in after an RTT or so. This is not the main purpose of PMTUD anyway. You really shouldn't be sending packets larger than your local link MTU anyway. The more interesting use for PMTUD is finding the MTU of a path over the internet, for which the current code still works fine (or doesn't it)?

I'm not sure how the current code handles this error, I'll have a look tomorrow. But I can confirm that this error does NOT only occur when sending a packet larger than the local MTU. It occurs when sending a packet larger than the path MTU.

How does the kernel know about the path MTU in the case of UDP?

We can either catch that error, or just ignore it and let loss recovery kick in after an RTT or so. This is not the main purpose of PMTUD anyway. You really shouldn't be sending packets larger than your local link MTU anyway. The more interesting use for PMTUD is finding the MTU of a path over the internet, for which the current code still works fine (or doesn't it)?

No it doesn't. quic-go doesn't do anything about DF bit on Linux right now. Since by default it's IP_PMTUDISC_WANT, Linux WILL fragment and send the probe packets.

How does the kernel know about the path MTU in the case of UDP?

I'm not sure how the kernel would do that for UDP. There's no acknowledgements, so the kernel can't know if a packet of a certain size has been delivered (ICMP can't be relied upon on the internet).

ICMP can't be relied upon on the internet

But ICMP does work in most cases. I assume that's how Linux implements it (RFC 1191)

Then the right solution would be to ignore this error message. PMTUD packets don't carry any application data, so there's no benefit in declaring them lost right away. If we wanted to be fancy, we could tell the MTU discoverer right away, but I'm not sure if that's worth the extra complexity.
Do you want to send us a PR?

Tried this code on a VPS with a local MTU of 9000 but a path MTU of 1500.
package main

import (
	"fmt"
	"golang.org/x/sys/unix"
	"net"
)

func main() {
	conn, err := net.ListenUDP("udp", nil)
	if err != nil {
		panic(err)
	}
	defer conn.Close()
	rc, err := conn.SyscallConn()
	if err != nil {
		panic(err)
	}
	err = rc.Control(func(fd uintptr) {
		err := unix.SetsockoptInt(int(fd), unix.IPPROTO_IP, unix.IP_MTU_DISCOVER, unix.IP_PMTUDISC_DO)
		if err != nil {
			panic(err)
		}
	})
	if err != nil {
		panic(err)
	}
	bs := make([]byte, 7000)
	fmt.Println(conn.WriteToUDP(bs, &net.UDPAddr{
		IP:   net.IPv4(8, 8, 8, 8),
		Port: 53,
	}))
}

First packet went through. Subsequent attempts all returned errors.

Then the right solution would be to ignore this error message. PMTUD packets don't carry any application data, so there's no benefit in declaring them lost right away. If we wanted to be fancy, we could tell the MTU discoverer right away, but I'm not sure if that's worth the extra complexity.
Do you want to send us a PR?

Maybe 🤔 I'll see what I can do

Then the right solution would be to ignore this error message. PMTUD packets don't carry any application data, so there's no benefit in declaring them lost right away. If we wanted to be fancy, we could tell the MTU discoverer right away, but I'm not sure if that's worth the extra complexity.
Do you want to send us a PR?

Maybe 🤔 I'll see what I can do

I'm too busy with school to dive into this. If you are able, would greatly appreciate your effort!

@marten-seemann Are we ignoring all errors from WritePacket or just MTU-related ones? I'm not sure if the former would have any side effects. As for the latter, the only way to tell is... not so elegant:
	bs := make([]byte, 7000)
	_, err = conn.WriteToUDP(bs, &net.UDPAddr{
		IP:   net.IPv4(8, 8, 8, 8),
		Port: 53,
	})
	if opErr, ok := err.(*net.OpError); ok {
		if syscallErr, ok := opErr.Err.(*os.SyscallError); ok {
			if syscallErrno, ok := syscallErr.Err.(syscall.Errno); ok {
				if syscallErrno == unix.EMSGSIZE {
					// This is what we are looking for.
					fmt.Println("EMSGSIZE")
				}
				fmt.Println(syscallErrno)
				fmt.Println(syscallErrno.Error())
			}
		}
	}

This is undocumented and platform-specific.

I think it would be nicer to just ignore the MTU-related ones. At least that would be a requirement if we want to feed the information back into the MTU discoverer immediately.
Your code might become a bit more elegant if you use errors.As, but of course that doesn't change the fact that we'll need a platform-specific isMTUError function.

This was fixed in #3328.


BUG: ResultTables.NodesSupportForces fails in ConvertResultsToListOfDct

Describe the bug
Trying to access the nodal support forces of a model using ResultTables.NodesSupportForces with the load-case-no and the node-no.
results = ResultTables.NodesSupportForces(CaseObjectType.E_OBJECT_TYPE_LOAD_CASE.name, load_case_no, node_no, model)`

In GetResultTableParametersit tries to access i.row.__keylist__ but the .row of entry with index 01 of the results is just a Text type, hence it fails with an AttributeError.
The index 1 refers to a row which says something like :"Min/Max Analyse mit Werten", so it's not an actual result row, but rather a row shown in the RFEM frontend to structure the result table.
Expected behavior
Should properly parse the result.
Or are we accessing the NodalSupportForces wrong?
Additional context
Workaround is currently to directly access:
model.clientModel.service.get_results_for_nodes_support_forces

and then get the support_forces (just interested in the first row anyways) like this:
                raw_results = model.clientModel.service.get_results_for_nodes_support_forces(CaseObjectType.E_OBJECT_TYPE_LOAD_CASE.name, load_case_no, node_no)
                nodal_result = {"nodal_support_force_p_z": float(raw_results.nodes_support_forces[0].row.support_force_p_z.value)}
                results_per_lc_per_node[load_case_no][node_no] = nodal_result

this works, but it's not great, because we have to do the parsing ourselves.

Hi @MaximilianFranz,
I'm taking over this issue. If I understand correctly, your problem is that the GetResultTableParameters() function is parsing incorrectly? IS it tru. Is it still an issue with the latest RFEM Python Client?

We're using the workaround mentioned above, I have not tried again since.

OK. 25.8.2023 there was an update (SHA-1:199515e476b3fb0d55bfd6cc5af722dc82fa78ae) to condition 'if 'row' in i.keylist:' since then we didn't notice any issue.

tested with RFEM version 6.06.0002 and RFEM pip version 1.19.5.


Page to list users with a given badge

This would be cute!

Lots of relevant code in #4246

@bakeiro Maybe there is something wrong with the way I'm using react-query but the useBadges hook seems to not run in the BadgesPage component when I first load the page /badges. In ReactQueryDevTools, I can run Refetch on the "badges" query, which does return the correct data. Why do you think it isn't running on page load? You should be able to reproduce this by:
cd app
docker run --pull always --rm -w /app -v $(pwd):/app registry.gitlab.com/couchers/grpc ./generate_protos.sh
docker-compose up --build &
cd web
yarn start:localdev

(FYI I made a separate script to actually use the docker database, which isn't used by yarn start)

@schradert Are you still working on this, or is it okay if someone else picks it up?
(I am going through the board to make sure things are active)

Closing as #4389 is the source of truth for this feature.


Ja feature population

added the Colab Notebooks for

ETL of population Data from census api
Join the datasets for Population, Crime Rate, Rental Rates, and Walk Score
NearestNeighbors Model to create list of recommend city_states.

Will make additional branch to add Colab notebooks


Translate: Strict mode

I've done translating Strict mode to Spanish. #4
I'm having some doubts with some stuff in the translation and I hope you can help me with them if you have a better way to translate it:

commit phase: I'm translating this as fase de confirmación.
refs: This article talks about refs in multiple ways: string ref, callback ref, object ref. I've basically left them as is; I can instead translate them referencia de string (to comply with the translation guideline table), referencia de objeto and referencia de callback. What do you think it's better?

cc: @alejandronanez @dmoralesm @carburo

Great job David 😁! I've added some comments.

Thanks Jonathan! I just made a commit applying those comments.

Hey @alejandronanez, they were very valuable! I have made a new commit applying those suggestions and also modifying the "Advertencia" in the bullet points section..


Request: Reed/Door Sensor Integration

Just wondering if this is possible at all?
I was looking to use these with a relay to send a signal of open or close when a light is on or off, giving me realtime active feedback on the state of a light, it won't give me brightness level, but it will give me the state.
We could use an S1C alarm kit to make this happen, these will run 16 door sensors, I can remove the magnetic contact switch and wire this to the NO/NC circuit on a relay, to mimic open or close, this can then be used to interpret a lights state, these sensors have active monitoring so I believe the S1C poles the sensors periodically.

Sorry @Kung-Foo-Kamel that's far beyond the scope of this plugin.


Move AgentWorker construction and registration out of AgentPool

This is another take on #954 that reduces the diff somewhat.
The aim here is to decouple the AgentPool from the creation of AgentWorkers and registration. This allows better composition and pushes the construction of dependencies up to the caller, which is the cli command level.
The only practical difference in how things work here is that there is a single signal handler for the whole AgentPool vs one for each AgentWorker. This shouldn't have anything other than aesthetic difference.
Registration and fetching of tags are now different things too, and the results are passed into things that need them.

💪🏻


enable prow build for ibm-crossplane-operator

What this PR does / why we need it:
Enable prow build for ibm-crossplane-operator
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Specify your PR reviewers:

/cc @gyliu513 @morvencao
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@cheewaio
Please add ibm-crossplane-operator
repo in  https://github.com/IBM/test-infra/blob/master/prow/config.yaml#L18 and https://github.com/IBM/test-infra/blob/master/prow/config.yaml#L80

@horis233 config.yaml updated


List Win11 SDK as requirement to build the solution

[x] Have you signed the Contributor License Agreement?
[ ] Are you working against an Issue?

The solution fails to build when Windows 11 SDK 10.0.22000.0 is not installed. This PR lists it under the Building the Client > Prerequisites section in README.md, so future users can contribute easily.
@ryfu-msft @yao-msft @mdanish-kh
Microsoft Reviewers: Open in CodeFlow

/azp run


1.10 backport 7234  COPS-6533

backports #7236

jira.d2iq.com/browse/MARATHON-8773
jira.d2iq.com/browse/COPS-6590
https://jira.d2iq.com/browse/COPS-6533

@timcharper cherry-picked some commits from master and factored a commit from 19a2d7af1a74538305de57e01d3ef380d21010f6 to have newAppDefinition callable.


track users from multiple user models (multiple authentication drivers)

How to configure tracker.php configuration file in order to track users from multiple authentication drivers

Will be available in the next version.  Add the bindings to all of your drivers here:
'authentication_ioc_binding' => ['auth'],


Default env python maybe different from python selected in config step

Python that is default in the environment maybe different from the one selected in the  configure step. File
calls #!/usr/bin/env python, it should instead be the one defined in the configuration step.

Thanks for reporting.
@vrv Could you take a look at this please?

I'm really not sure what we can do here, short of rewriting all python files during configure (which would be insane) -- I would suggest using an environment where the python you use in your configure step matches the environment.  If someone else has any suggestions, please let us know.


How to set RepositoryFolder as environmental variable in docker-compose

Could you give me a hint how to do it correctly?
My docker-compose:

services:
planningpoker:
image: duracellko/planningpoker
container_name: planningpoker
network_mode: host
environment:
RepositoryFolder: "/planningpoker"
user: "1002:100"
restart: unless-stopped

Thanks a lot for your support!!!

You have to specify full name of environment variable:
services:
  planningpoker:
    environment:
    - PlanningPoker__RepositoryForlder: /planningpoker

Explanation: https://learn.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-7.0#non-prefixed-environment-variables
Btw, when you specify repository like this, probably it would fail, because /planningpoker directory does not exist in the container. Also there is no need to store data in the container.
The goal of repository was to store data outside of the container, so that when the container is restarted, the data are not lost. For that you would need to define a volume, map it in the container and use that for repository.
I found this that describes how to define volumes in docker compose: https://github.com/compose-spec/compose-spec/blob/master/spec.md

Thanks for your answer.
I use several container with bind mounts (volumes).
In which file / folder are the data stored that should be stored between restarts? Then I can bind mount this folder to a folder on the host.
Thanks

It would be the same folder that you configure in the environment variable. For example:
services:
  planningpoker:
    environment:
    - PlanningPoker__RepositoryForlder: /planningpoker
    volumes:
    - /host/planningpoker/data:/planningpoker

/host/planningpoker/data should be directory. Then each team is stored as separate file there.

This is my compose file:
services:   planningpoker:     image: duracellko/planningpoker     container_name: planningpoker     network_mode: host     environment:       PlanningPoker__RepositoryFolder: /planningpoker     volumes:        - /planningpoker:/planningboker     restart: unless-stopped
When trying to change the deck to Fibonacci sequence, I get this:
fail: Microsoft.AspNetCore.SignalR.Internal.DefaultHubDispatcher[8]       Failed to invoke hub method 'GetMessages'.       System.UnauthorizedAccessException: Access to the path '/planningpoker' is denied.        ---> System.IO.IOException: Permission denied

The application inside docker runs under special app user. I assumer that the directory /planningpoker in the host was created by you and only you have access there. But not the app user.
Simple solution is to make the directory public:
chmod -R o=rw /planningpoker
Better option is to setup access explicitly to the app user. At first you have to find user-id. You would need run id command in the existing container: docker exec planningpoker id
Then you can set the user to be the owner of the /planningpoker directory.
chmod -R u=rw /planningpoker && chown -R {user id from the container} /planningpoker

Usually I do not create directories which I use for bind mounts, but let docker-compose create them. As the container is running as root, the directory was created with root:root.
The user app has id 1000. So I changed ownership of the directory to 1000:root and 1000:1000. But no success. I get still the same error message.
And it seems, I cannot run the container as another user like I do for others.

I didn't even know, that docker-compose creates directories for volumes.
Mu suggested next steps for investigation:

Check if the mount actually works.

Create file in the host in the directory.
Run bask inside the container and check, if you can see the file.

Try setting read-write for others (public). See, if the problem is with the permissions.
Run bash inside the container and check the permissions of the directory.


tiltfile: change k8s_service -> k8s_resources, composite_service -> composite_resources

Hello @dbentley,
Please review the following commits I made in branch nicks/ch55/resources:
d0dcb130ca52bc3fd90db6da21882f4552fe2ce0 (2018-09-14 14:54:42 -0400)
tiltfile: change k8s_service -> k8s_resources, composite_service -> composite_resources

decided this is not important right now and might change more radically anyway!


Total time tracked version 2

Total time will be rendered on demand. There is a refresh button next to Total time title. If user clicks it total time is fetched from the backend. Probably similar to how data is fetched in project dashboard.
First version will be created for Trello. If it works properly we'll start adding other tools.

👍 vote for this

Thank you for the feedback. This is still in our roadmap. No clear release date just yet.


Workload Insights page not showing even with logging enabled.

Even after enabling Opni logging, the workload insights page within Opni is not showing and asking for Opni logging to be enabled.

https://github.com/rancher/opni-ui/pull/138


Add a WordPress API example

I've found an example showing how to fully convert a wordpress site to 11ty, but nothing showing the less extravagant use case of building pages off the API. That's what this aims to demonstrate.
I took a susprisingly long time to understand how this was done - it turned out I was drastically overcomplicating it! Perhaps this will help others.
Here's a tutorial I wrote outlining the same principles.

Excellent, thank you!

Excellent, thank you!

If you find a good place on the site to link up that tutorial, please PR that too!

If you find a good place on the site to link up that tutorial, please PR that too!


Phraze tokenized as single token

I was trying to follow instruction on the official website:

For example, we want a search for 空港 (airport) to match 関西国際空港 (Kansai International Airport), but most analyzers don’t allow this since 関西国際空港 tends to become one token.

For me it gets tokenized as single word:
kuromoji.builder({ dicPath: "dict/" }).build((err, tokenizer) => {
  console.log(tokenizer.tokenize("関西国際空港"));
});

// => [ { word_id: 1271160,
//        word_type: 'KNOWN',
//        word_position: 1,
//        surface_form: '関西国際空港',
//        pos: '名詞',
//        pos_detail_1: '固有名詞',
//        pos_detail_2: '組織',
//        pos_detail_3: '*',
//        conjugated_type: '*',
//        conjugated_form: '*',
//        basic_form: '関西国際空港',
//        reading: 'カンサイコクサイクウコウ',
//        pronunciation: 'カンサイコクサイクーコー' } ]

@takuyaa , is it an issue with dictionary? Is there a way to convert Ipadic dictionary to .dat format?

@epaminond Thanks for your feedback!
That is not feature of kuromoji.js (JavaScript), but Kuromoji (Java).
It is not supported yet on kuromoji.js, but could be supported in the future.

OK, I've made use of https://github.com/leungwensen/tiny-segmenter for now.

That's great idea for some use cases.
I close this issue.


Usage of payer field for a transaction

Is it possible to use a different fee payer for a transaction ?
Suppose userA wants to send some funds to userB, can we involve userC to pay for this transaction ?
So that userA and userC signs the transaction and transaction proceed
Ref: https://docs.cosmos.network/v0.42/core/proto-docs.html#fee

Not yet. This is tracked as Feegrant support (Cosmos SDK 0.43) in #1105.
I once saw a CosmJS fork implementing that but I never heard from the authors again and do't recall where/who that was.

Thanks for quick reply, will track


Update deploy-two-node-clustered-file-server.md

The file server role would not start because the object could not be created in AD. I should think most people will encounter this.

The end of your sentence looks a bit odd, at least when viewing the source code in plain text.
Would you be able to update the whole numbered list, so it uses all the correct numbers 1-18?
Repeating the numbers 6-7-8 (making the rest of the numbers incorrect when viewing the text in source  view) seems confusing for ordinary git review.
If you find it too difficult to edit those numbers yourself, I may just be able to help you by creating a PR to your personal repository, to have those number changes submitted.

The end of your sentence looks a bit odd, at least when viewing the source code in plain text.
Would you be able to update the whole numbered list, so it uses all the correct numbers 1-18?
Repeating the numbers 6-7-8 (making the rest of the numbers incorrect when viewing the text in source view) seems confusing for ordinary git review.
If you find it too difficult to edit those numbers yourself, I may just be able to help you by creating a PR to your personal repository, to have those number changes submitted.

Thanks @illfated, I had not touched the list but have re-ordered as per your suggestion.

Thank you for adding the correct order in the numbered list. This makes it a lot easier to understand the reference to "Step 8" in the Note you added.
Other than the suggested changes above, this looks quite good to me.
I will add my approval after you have committed the latest changes.

Thanks, committed. Now that I better understand the process, I'll be tempted to repeat the process in future. Appreciated.

#sign-off

@leonwear  Thank you for your efforts! I will go ahead and merge these changes.


Expose default bootstrap hooks

Say I want to override checkout for certain repositories, but not others. Maybe it's an optimization, maybe some repos use mercurial or another source control mechanism. I create a checkout hook on my agent, and implement my custom behaviour. But I also have to copy the original git hook into my hook for the "else" case. And this problem gets worse with the new beta agent — there is no default hook which is easily copyable, although we can still grab the old bash version for now.
It would be great if we exposed hooks a little more and instead I could do something like buildkite-agent hook --default checkout or something.

Sounds like a neat idea!

When I discussed this with @keithpitt he was concerned that this exposes additional api that we'd then have to support. Feels @keithpitt?

I think we came to an alternative solution for this? (just in talking about it, not implementing it).
A pre-checkout hook could say BUILDKITE_CHECKOUT=false which would tell the agent "don't checkout plz". And that pre-checkout hook could do it's own checkout before we go to ours.
Checkout-less builds is something we've wanted to do anyway, so BUILDKITE_CHECKOUT=false would solve both problems I think!

Yup, I think I agree. 👌🏻

Nice.

Will close for now, since this feature matches really well into "repository-less checkouts". The idea would be in the pre-checkout hook, set BUILDKITE_REPOSITORY="", and then do the checkout yourself in the pre-checkout hook.


Update fb comments plugin

Add two config settings about fb comments plugin, width and scheme.

I found that there doesn't have comments counter for FB comments plugin, so I add it :wink:

Thanks. :+1:


Why should we have an Entity on Domain and a class inheriting the Entity on the Infrastructure Layer?

Why should we have an Entity like Debit on Domain project (Domain Layer) and another one inside Infrastructure with the same name (Debit) which inherits from the Debit on Domain Project?
I know it's hard to see advantages on this project yet but what are the real advantages using this approach?

Throwing my hat in the ring: at least one reason I can see for inheriting the Domain entities in the Infrastructure project:
Infrastructure frameworks like EFCore may require certain class elements (empty constructor) that may not be present in the Domain entities;
Maybe there are some other reasons, but I can think of at least this one.

Thanks @bommen, I'll keep it open for one day or two if someone else want to contributes, but make sense!

Hey all,
I am happy these question came up. @bommen is correct to say that certain class elements are required for EFCore and they are not needed (not desired) in the Domain. Let me try clarify it more.

The entity interfaces (eg. IAccount, ICustomer, ICredit, IDebit) are the Highest Level in our design and they are consumed by the Use Cases, they are designed to fulfil the Use Cases needs only! If you need to change their signature it should be motivated by the Use Cases implementation. Please notice the getters/setters are unnecessary because use cases consume the very specific methods available.
Domain Entities (eg. Account, Customer) implement the business rules and the Use Cases are their consumer. At this level we don't need to think about persistence, I decided to have protected setters and not implement the foreign properties (eg. Account class does not have CustomerId property).
The Output/Output messages are low level, very specific to interact with the user and serializable.
The Infrastructure Entities are the lowest level, they target the database and should be serializable, we need to add these elements (setters) and together with the MangaContext we create rules that make possible persist these objects in the database (eg. Account has a CustomerId property).

I explain a little bit in the Clean Architecture Essentials video.
These is what I remember at this time.

You got my like and my subscribe!
Nice job Ivan! Thank to you for and @bommen, your hat fits well ;)


Fix example solution lists

Closes #458

Removes unused example.cpp files from the files array. Those exercises only use an example.h file for the example solution.
Sets the header file for hello-world to the hello_world.h file, which is reused without modification for both the example solution and the skeleton for the students.

Thanks @ErikSchierboom!


Enhance EF to enable dynamic command lists

This will make sure that new commands make it into DSLIDE

This issue was moved to electric-cloud-community/EC-DSLIDE#14


version notes are not uploaded / updated (or it takes weeks)

Describe the problem and steps to reproduce it:
upload a new version of my ADd-on  (this happens every time)
I usually add version histories as html unsigned list with links to my bugzilla
What happened?
version notes to not appear for several days
See:
https://addons.thunderbird.net/en-GB/thunderbird/addon/smarttemplate4/versions/?page=1#version-2.0
What did you expect to happen?
version notes should be uploaded immediately. they are definitely stored in "manage versions"
I also notice that I cannot enter version history during uplooad of the add-on I can only edit it aftere it has been submitted for review (this used to be different)
Anything else we should know?
here is an example release note text:
st4-release2.0.txt

I'm not sure what you're reporting here. Your version 2.0 had an empty en-GB localization listed at https://addons.thunderbird.net/en-US/developers/addon/smarttemplate4/versions/2469054 in the top right. Deleting that localization made the en-US notes, which are correct, show up.
There is not any kind of delay with version notes, they're just stored in the database for each language. If your language has a localization that is empty, you won't see any notes.

thanks - I will see if it works the next time. It obviously made the version notes field disappear on the upload version stream, it wasn't obvious to me that this was caused by an empty translation. The addon does not contain an en-GB locale but I am located in Ireland. maybe that's what caused it to appear. I am pretty sure I had the samee problem with QuickFolders, so I am going to check there wheteher an empty En-gb locale has been createed. It may be from the migration from AMO.

Feel free to reopen if you have steps to reproduce, it's entirely possible that something in the upload process is creating empty localizations, but it's hard to fix without knowing what or if it's repeatable.

I don't know how to reopen, but I can definitely reproduce it. I uploaded a new version for quickFilters yesterday, and noticed my page always reads "en-GB" once I go to
https://addons.thunderbird.net/
it auto-redireects me to the GreatBritain domain:
https://addons.thunderbird.net/en-GB/thunderbird/
which then produces the behavior (no version notes field visible) - the actual Add-ons never have a en-GB localisation, I think it is the server that decides to bring me to the en-GB version because of my location (Ireland)
By editing the URL, changing en-GB part to en-US I was able to enter the version notes without a hitch.

Um yes, but the problem is that they DO have an en-GB localization and that it's empty. That's the cause. The question is where that empty localization is coming from.

I just ran into this exact problem. My add-on (Toggle Headers) itself contains two localizations (en and de) but I only enter English descriptions on the add-on page.
Is it possible that this is the problem? I suspect that it automatically adds all locales of the add-on. But even then, it would be better, IMHO, to fallback to the default if no description was provided for additional locales.


Cannot upload to app store

With pod 'Siesta', '>=1.0-beta.6'
building archive is successful and validation is successful but when I try to upload to iTunes connect I am presented with the following:

ugh...  My workaround was to change my version to something like 0.1.6.

Thanks for this, Ray, Are you using Cocoapods? If so, it’s probably a dup of #24, which is really https://github.com/CocoaPods/CocoaPods/issues/4421.

It looks like Cocoapods 1.0b2 fixes this:
gem uninstall cocoapods
gem install cocoapods --pre

(I had to uninstall the existing versions to get the pod command to start picking up the beta.)
Could you give that a try and let me know if that fixes it for you? Assuming that you’re using Cocoapods, that is….

Thanks for the reply!  Yes, I am using Cocoapods.  Probably works but I will verify it either today or tomorrow.

Great! Close the issue if it works, and keep sending the diagnostics if it doesn’t!

Worked like a charm!  Thank you as always @pcantrell


No Data Available.

Every time it selects a server it says
Fetching data...
Chosen server: https://overpass-api.de/api/interpreter
Error! No data available
and here's an image of the data I have

That sounds like the city name input parameters are not correct, how do you run the program?

That sounds like the city name input parameters are not correct, how do you run the program?

python arnis.py --debug --city “bayonne” --state “new-jersey” --country “united-states” --path /Users/tadsandy7/Downloads/bayonneandstatenisllandattept

That sounds like the city name input parameters are not correct, how do you run the program?

I dont know Bayonne in open street map form

That sounds like the city name input parameters are not correct, how do you run the program?
so do you know Bayonne in this form? new jersey?

Hi there, better late then never! I just merged an awesome PR and a refactoring which should address this issue. Try to use the bbox method described in the README instead of the city/state/country input.


task about vagrant box

can you please help me out sir :
**1. Write a bash script that creates and boots Vagrant box
(https://vagrant.io)  with Ubuntu.
2. Write an Ansible script that connects to this Vagrant box
and does the following on it:

Creates a user "testuser"
Sets the system's timezone to
"Asia/Kolkata"
Uploads a random local file from the host into the
/home/testuser/ directory
Installs python, supervisord, and the latest version of
consul (https://consul.io)

Refer #162


Visual C++ Compiler Error C2326 using Constexpr Array from Lambda in a Test Case in a Throws Assertion

Expected Behavior
A function with a throws / nothrow assertion should compile with the Visual C++ Compiler when given a lambda which uses a constexpr std::array variable... right? This is a very specific issue 😩
#include <array>
#include <boost/ut.hpp>

int main() {
  using namespace boost::ut;
  "example_test"_test = [] {
    constexpr std::array<int, 1> i{{10}};
    expect(nothrow([] { return i.front(); }));
  };
}

It is also interesting to note this only occurs in a test case and not when used directly from main, hence the following compiles:
#include <array>
#include <boost/ut.hpp>

int main() {
  using namespace boost::ut;
  expect(nothrow([] {
    constexpr std::array<int, 1> i{{10}};
    return i.front();
  }));
}

Using a constexpr int instead of a std::array also compiles:
#include <boost/ut.hpp>

int main() {
  using namespace boost::ut;
  "example_test"_test = [] {
    constexpr int i{10};
    expect(nothrow([] { return i; }));
  };
}

Perhaps this is a bug in the MSVC compiler?
Actual Behavior
Error C2326 is given stating that the lambda function cannot access the constexpr variable.
I can workaround this issue by putting the constexpr variable within the lambda itself, as follows:
#include <array>
#include <boost/ut.hpp>

int main() {
  using namespace boost::ut;
  "example_test"_test = [] {
    expect(nothrow([] {
      constexpr std::array<int, 1> i{{10}};
      return i.front();
    }));
  };
}

Steps to Reproduce the Problem
Compiling the preceding snippets above using C++20 / MSVC 16.4.4 should showcase the error.
By the way, Clang compiles the problematic code just fine.
Specifications

Version: 1.1.6
Platform: Windows
Subsystem: MSVC 16.4.4

Hmm, isn't the case that you are just missing the capture of i?
The following works just fine with MSVC :+1:
int main() {
  using namespace boost::ut;
  "example_test"_test = [] {
    constexpr std::array<int, 1> i{10};
    expect(nothrow([i] { return i.front(); }));
  };
}

Full example -> https://godbolt.org/z/PMYVyk
Alternatively, you can make it static too if it's constant :thinking:
int main() {
  using namespace boost::ut;
  "example_test"_test = [] {
    static constexpr std::array<int, 1> i{10};
    expect(nothrow([] { return i.front(); }));
  };
}

Full example -> https://godbolt.org/z/TVJJPE
Please let me know if I misunderstood your issue, thanks @jwillikers :+1:

Thanks @krzysztof-jusiak. I must have some misunderstanding of lambda captures here. Why does your first example work given i explicitly in the capture but not work when using the generic = or & captures?

Capturing using = should work as well and it does in gcc/clang, so it seems like MSVC issue :bug:

https://godbolt.org/z/dB6J4n

@krzysztof-jusiak Thanks for your help! I found a bug report for the Visual C++ Compiler here which seems to capture this issue and it looks like the fix is complete and will be in an upcoming release. Thanks again for all your help 😀😀😀

Nice @jwillikers, thanks for following it up and the link :+1:


TortoiseSVN

Registry keys from here.
Should solve issue #2466 in scoop.

@rasa Like this? I still copy the reg files into the apps folder, since I have to replace in one of the files. Better have them all together for the end user, right?
vscode.json and its siblings also downloads from github, maybe we should update them too?

Should be okay now, I think.


Help wanted! How can i train structLM to an custom dataset? Or how can i train an structLM originally from the beginning?

nothing, thank you all.


Unclear docs for identity-shorthand

The docs for this rule are noting the max method in regard of the identity shorthand, but max receives only 1 argument, so it doesn't make sense.
https://github.com/wix/eslint-plugin-lodash/blob/master/docs/rules/identity-shorthand.md

You're right. They were written before version 4 and not updated, back before it was split into _.maxBy.


Getting negetive wallclock time in the sparklens UI

Hi,
Thank you for the amazing tool for the performance monitoring of spark jobs. I was trying out some long running spark query using sparklens. However I was getting some strange output in the sparklens UI regarding the job time,  like wallclock time etc.

Could you please help me to resolve this issue?

@shahidki31 Thanks for raising this. We will take a look at get back to you.
I know of couple of reasons why this happens. The first one is missing job end events in the event log file. When the job end time is not known, we try to estimate it. If these are bad estimates, we can run into negative job time issues. The second reason is multiple jobs running in parallel. Sparklens computes driver time by subtracting "time spent in jobs" from the total wall clock time. With parallel jobs, it becomes a bit tricky to find out "time spent in jobs". We had made some changes to deal with this problem, but perhaps running is something new here.  We will check and get back to you.

@shahidki31 Parallel jobs were not getting considered at one place in the code, which is why you were getting a negative driver wallclock time. I have fixed it and updated the jar. Please check now, it should work correctly. Thanks for reporting 👍

Thanks @iamrohit @mayurdb for the replies. Yes, I am running jobs in parallel (TPCDS queries basically).  Seems, console output is giving the correct results, only UI has the problem. Will check again. Thank you.


I got some issues w this

Github Issue Basics

[x] Create an issue
[x] Create this task list in initial comment of issue
[x] Convert the following two tasks into issues:

[x] #5
[x] #6

[ ] Add emoji reaction to a comment

Github Flavored Markdown in Issue Comments

[ ] #7
[ ] #9
[ ] #12
[ ] #11
[ ] #14

Reference Issues

[ ] Mention in issue comment another issue that is in the same repo
[ ] Mention in issue comment another issue that is in a different repo
[ ] Mention in git commit message an issue in the same repo

we got some issues


Minimize synchronously

Minimize synchronously as minimize.parseSync

what are your requirements for doing it sync?

For example, If I caches templates
templates.forEach(function(template) {
    templatesCache.push(minimize.parseSync(template))
})

or other minor situations when it is uncomfortable to work with callbacks

Hmm i can see the usecase. However this is slightly out of minimizes' control. E.g. the DOMParser which is used by htmlparser2 is working with a callback https://github.com/fb55/domhandler#example. The only way this could work is if all 3 modules (minimize->htmlparser2->domhandler) would be working sync. Alternative solution to you caching.
require('async').map(templates, minimize.parse.bind(minimize), function (err, results) {
  templatesCache = results;
})

or similar

I made issue https://github.com/fb55/domhandler/issues/21
https://github.com/kangax/html-minifier works synchronously, but has verbose API and has not gulp plugin.

@Swaagie Calling the functions of the modules is a synchronous operation. Simply process the file, then access domhandler's dom property. The callback is also synchronous, you could have the handler assign the value to a local variable, then return it (not a nice solution, but works as well).

@fb55 thanks for replying :) I hope I can spend a cycle on it this weekend.

Kinda fell of the radar, I'll try to spend a cycle on it asap

Looking for the sync feature :)

Finally fixed with https://github.com/Swaagie/minimize/pull/80 and released as 2.0.0


add mermaid extention

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.11%. Comparing base (ebe8e6f) to head (ddcc272).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   94.11%   94.11%
=======================================
  Files           8        8
  Lines         391      391
  Branches       84       84
=======================================
  Hits          368      368
  Misses         15       15
  Partials        8        8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Expand manifest validation for all settings

There are some practical difficulties arising from the fact that manifest files are not always validated. I want to collect such cases, so we can improve the user experience, specially for newbies, by showing warnings about bad manifest entries, as soon as possible.
One important fact here is that we almost never want to throw an error on invalid entries, because it will affect forward-compatibility: would make many future changes non-backward-compatible.
Some Examples
I think almost every config item can have some sort of validation. This list only presents possible validation methods for different types of values.

package.keywords: Having invalid keywords strings only surface during packaging/publishing. See https://github.com/rust-lang/cargo/issues/4300 for details.

package.categories: This is a bit harder, because the list is maintained in crates.io repo. But, like any other index-related data, it can be fetched, cached, and checked against.

package.include, package.exclude, workspace.exlucde, workspace.members: These are configs with pattern-matching and warning on invalid patterns can help users track down packaging issues easier and faster, and make changes in those areas easier. (See https://github.com/rust-lang/cargo/issues/4268)

package.readme and other file paths: Need to check the existence of the file, if linked. In addition, we can also warn on missing the config, if a best-guess file is present.

package.homepage and other URLs: Perform URL validation and check URLs against the newly-implemented blacklist. (blacklist is maintain in crates.io, so this would be another index-dependent check.)

features.<name> #5554

Banning of wildcard dependencies #5941

cc @alexcrichton, @carols10cents

Seems plausible to me! All this validation happens on crates.io though which I'd prefer to not duplicate, although we can perhaps do simple things like validate homepage is a URL locally for sure. (also agreed with warnings-for-now)

Some more background and my rational for this proposal: The other day, for a new release for UNIC, I was updating a dozen of manifests, mostly their metadata.  This resulted in a handful of commits just catching all the small nits from the publish command, like "don't use space in the keywords list".
Agreed that we better have one source of truth. However, I also believe we can benefit a lot by moving this one source of truth to a library that can be used in client side (cargo CLI, clippy, etc), as well as server side (crates.io, etc). I call it the cargo-manifest crate, which I think should spin out of cargo proper (which hosts all the CLIs, etc). This would allow cargo, crates.io and third-party CLIs to share the same manifest read/validation logic, without the need to have cargo execution details imported as dependency.
What do you think?

https://github.com/rust-lang/cargo/issues/3069 is also related to this (see point 2.)

Would it be possible to implement a preflight like endpoint in crates.io to do the validation before the publish?

The solution should come from a discussion with crates.io team. I don't have the answer to it, but Zulip t-crates.io is a better place to have such a chat with crates.io team I believe.

The solution should come from a discussion with crates.io team. I don't have the answer to it, but Zulip t-crates.io is a better place to have such a chat with crates.io team I believe.

Would it be possible to implement a preflight like endpoint in crates.io to do the validation before the publish?

In our previous crates.io team meeting, we expressed concerns regarding the potential performance issues that could arise from introducing this validation to the publish API. The API is resource-intensive as it requires unzipping the tarball to retrieve metadata, which could also lead to the consumption of your rate limit.
Thus, we're inclined first to unify the validation rules of Cargo and crates.io. This would be a good initial step, and I am currently working on this.
See: https://github.com/rust-lang/crates.io/pull/7379

Even if the rules are unified, a divergence between crates.io and cargo can occur if the cargo version is outdated.
I fail to see how uploading a bit of metadata via some simple API request is a problem. Admittedly I do not know how the API looks like at all.

In going through cargo's triage (or talking to people about it), I remember seeing somewhere that some differences were intentional.
An alternative route to go, once we have #12235, is to have the crates-io specific validation rules in a crate and a cargo linter would expose lints for crates-io and "all registries" published packages that don't conform to those validation rules.  During the times where crates-io is out of sync with someone's MSRV, they can allow certain lints.

I fail to see how uploading a bit of metadata via some simple API request is a problem. Admittedly I do not know how the API looks like at all.

For the publish workflow, crates.io has been shifting away from "trust the metadata" to "parse Cargo.toml".  That is what is expensive.  Yes, there are a lot of design decisions that can be made, with various trade offs, that might get us to having server-side validation.
For example,

we could have a dry-run today and they just validate the metadata but (1) they might now be checking more than we upload and (2) this can require them to duplicate a lot of logic
We could POST the Cargo.toml but that file is incomplete without the associated project (I do want to auto-fill in most fields that are implied from the file system)
If we post an entire .crate then we run in the server-side performance issues

Yeah I see that sending just an extract might be error prone.
Also, upon further reflection, I think just syncing the two checkers or at least having a crates.io-oriented validation crate would be enough. For people that do not want to keep up with the release cadence of cargo it will fail, but for everyone else this is perfect :)

One thought on how to solve this

crates.io split their limits into a package for cargo to pull in
Cargo check the limits in a crates.io-specific set of lints (#12235).  These could even be deny by default as the user can workaround limit changes (global or per user) by making the lint an allow lint.

One question is when should these lints fire.  With publish = true (which is default though we've talked about changing that in #6153), all registries are matched.  At least with #12786, we have truly private packages, more easily.  So do we emit them on all commands, even if they won't apply?  Do we reserve this for package and publish but then people won't find out until its too late?  Do we do this in cargo's linter that we've talked about?  imo no real solid "this is the way" answer.
In the lint, we should

Mention making the package private as a way to disable
Narrow down the list of registries if they aren't using crates.io (only if other registries are configured)
Disable the lint if it doesn't apply
Reach out to crates.io about limit issues


Feat: Toast library update

What feature?
Currently we are using react-toastify for showing the toasts. This issue is created to replace that library with https://sonner.emilkowal.ski/
Add screenshots
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

assign me

@Girishbari assigned to you. Make sure to use these properties:

richColor property should be implemented
expand should be true
position should be top right

BTW its really nice Lib, how did you find it

BTW its really nice Lib, how did you find it

Just got to know it from some open source developers

should I change styling or let it be how it is

should I change styling or let it be how it is

What styling, can you explain a little bit?

https://sonner.emilkowal.ski/styling
I saw we could apply custom styles here, that's why I thought but light version of toast is also matching with theme, I guess

https://sonner.emilkowal.ski/styling
I saw we could apply custom styles here, that's why I thought but light version of toast is also matching with theme, I guess

I didn't know about this. I think for now, the default UI is already great so you can use that

oh ok..


Example files

Hello,
Could you upload some simple example files? I'm trying to use this on my own depth maps, but the output is nonsensical. I assume that my depth maps or extrinsics are in the wrong format, so it would be useful to have a sample set of depth_maps, Ks, Rs, and Ts so that we could run the example code on the readme.
Thanks!

There is this script that I used to create data. Does this help?


Changes to support Mattermost 5.9.

I've booted up this PR and can reproduce the failure. The logs aren't immediately helpful:
# cat /var/vcap/sys/log/mattermost/mattermost.stderr.log
Error: LoadConfig: utils.config.load_config.decoding.panic,
Usage:
  mattermost [flags]
  mattermost [command]

Investigating.

Changes made in 7b87b2d1f0a - let's see what happens when testflight-pr kicks off again. :-)


Drop support for python 3.5

This PR edits the travis builds and environment files to drop support for Python 3.5.  Closes #366

Hello @bourque, Thank you for updating !

In the file setup.py:

Line 45:64: E502 the backslash is redundant between brackets
Line 46:9: E128 continuation line under-indented for visual indent
Line 62:1: E124 closing bracket does not match visual indentation

@nespinoza Builds are passing!
I had to remove numba dependency to get this to work, but I think it is fine?  I did a search on all of the libraries that exoctk is importing, and I didn't see numba in there, so I'm not entirely sure why it has been included in our environment.  Perhaps a relic from the past.

Sorry for arriving late to this --- the merge was a good call :)!


vbox driver: scope DHCP address range based on CIDR

VPN restrictions can necessitate specifying a CIDR with a narrower subnet than /24 in the --virtualbox-hostonly-cidr parameter. The previous code assumed it could create a DHCP server with address ranges that are valid for a /24 subnet, but not for a /25 subnet (for example).
VirtualBox validates that the supplied address range is within the subnet specified for the DHCP server. So with the previous code, we would see errors like this:
Error setting up host only network on machine start: /usr/local/bin/VBoxManage dhcpserver modify --netname HostInterfaceNetworking-vboxnet0 --ip <IP_ADDRESS> --netmask <IP_ADDRESS> --lowerip <IP_ADDRESS> --upperip <IP_ADDRESS> --enable failed:
VBoxManage: error: Invalid range upper address
VBoxManage: error: Details: code NS_ERROR_INVALID_ARG (0x80070057), component VirtualBoxWrap, interface IVirtualBox, callee nsISupports
VBoxManage: error: Context: "SetConfiguration ( Bstr(pIp).mutableRaw(), Bstr(pNetmask).mutableRaw(), Bstr(pLowerIp).mutableRaw(), Bstr(pUpperIp).mutableRaw())" at line 384 of file VBoxManageDHCPServer.cpp
VBoxManage: error: Failed to set configuration

This commit keeps the previous behavior for CIDRs with a /24 or smaller subnet mask. For CIDRs with a /25 or larger subnet mask, this change will set the DHCP server's address range to a range which fits in the specified subnet.
Signed-off-by: Mike Grass<EMAIL_ADDRESS>

Nice! I like that you included a test too.
LGTM

Thanks @mikegrass !

Thank you @nathanleclaire for the quick review!


Renamed UNetInvokeType to MirrorInvokeType.

This is to finish off the removal of all unnecessary references to UNet.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Failures in combining preempt with enumeration-based inference in Pyro

In the course of working on #240 and #236, @rfl-urbaniak ran into problems when attempting to use infer_discrete and TraceEnum_ELBO  in conjunction with causation and explanation queries defined via chirho.counterfactual.ops.preempt. This issue tracks progress on diagnosing and fixing those problems.

@rfl-urbaniak it's been a few weeks since you showed us this, and I'm afraid I've lost track of the context since then. Could you please create a failing test that illustrates this behavior and paste it here or push it to a branch in this repository and put a link to the branch here? Once you do that I will work on a fix.

A pytest test capturing the problem is now available in #253, also listed in the main description of that PR.

@eb8680  A most recent version of a notebook illustrating what seems to be a problem with using enumeration with explanation-related handlers is now in the ac-archive (PR #403 ), in the enumeration-explanation.ipynb notebook. If this gets resolved, the notebooks will need some updating, otherwise, I'm using sampling at least for now, and this shouldn't make much difference, as the number of possible combinations in the examples used in the notebooks is somewhat limited.


IE 11 - Remove suffix

On IE11, when you add a mention, then add the next one without typing anything else, the space suffix is removed and the 2 mentions are stuck together.

add setting like this :  insertTpl: "${name}",
reference: https://github.com/ichord/At.js/wiki/Base-Document#settings


Add coverage of the ref readonly modifier to the C# language reference.

Add the description for ref readonly to the language reference.

Internal previews

📄 File
🔗 Preview link

docs/csharp/language-reference/builtin-types/struct.md
Structure types (C# reference)

docs/csharp/language-reference/keywords/method-parameters.md
Method Parameters

docs/csharp/language-reference/keywords/readonly.md
"readonly keyword - C# Reference"

docs/csharp/language-reference/keywords/ref.md
ref (C# reference)

docs/csharp/language-reference/operators/conditional-operator.md
?: operator - the ternary conditional operator

docs/csharp/language-reference/statements/declarations.md
Declaration statements

docs/csharp/language-reference/statements/iteration-statements.md
Iteration statements - for, foreach, do, and while

docs/csharp/language-reference/statements/jump-statements.md
docs/csharp/language-reference/statements/jump-statements

docs/csharp/whats-new/csharp-11.md
What's new in C# 11

docs/csharp/whats-new/csharp-12.md
What's new in C# 12 - C# Guide

The snippets error is a false positive. Those are files and projects that were removed.

The snippets 5000 errors are false positives. Those source files and the associated project were moved / deleted as part of the consolidate of multiple articles.


Services ts

Fixes

Fixes #1149 by @obulat
Description

This PR typescriptifies the api and media services.
There are still 2 issues left that I don't know how to solve:
 ERROR  ERROR in src/data/media-service.ts:32:7                                                                                13:11:16
TS2322: Type 'Record<string, DetailFromMediaType<T>>' is not assignable to type 'T extends "image" | "audio" ? Record<string, DetailFromMediaType<T>> : never'.
    30 |     return {
    31 |       ...data,
  > 32 |       results: mediaResults.reduce((acc, item) => {
       |       ^^^^^^^
    33 |         acc[item.id] = decodeMediaData<T>(item, this.mediaType)
    34 |         return acc
    35 |       }, {} as Record<string, DetailFromMediaType<T>>),

ERROR in src/data/media-service.ts:92:7
TS2322: Type '(ImageDetail | AudioDetail)[]' is not assignable to type 'T extends "image" | "audio" ? DetailFromMediaType<T>[] : never'.
    90 |     return {
    91 |       ...res.data,
  > 92 |       results: res.data.results.map((item) =>
       |       ^^^^^^^
    93 |         decodeMediaData(item, this.mediaType)
    94 |       ),
    95 |     }

Testing Instructions

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat Those errors are pretty unfortunate... I think for now we can fix them with a cast:
diff --git a/src/data/media-service.ts b/src/data/media-service.ts
index 8fc2a12c..d5016cbf 100644
--- a/src/data/media-service.ts
+++ b/src/data/media-service.ts
@@ -32,7 +32,7 @@ class MediaService<T extends FrontendMediaType> {
       results: mediaResults.reduce((acc, item) => {
         acc[item.id] = decodeMediaData<T>(item, this.mediaType)
         return acc
-      }, {} as Record<string, DetailFromMediaType<T>>),
+      }, {} as T extends 'audio' | 'image' ? Record<string, DetailFromMediaType<T>> : never),
     }
   }

@@ -91,7 +91,7 @@ class MediaService<T extends FrontendMediaType> {
       ...res.data,
       results: res.data.results.map((item) =>
         decodeMediaData(item, this.mediaType)
-      ),
+      ) as T extends 'image' | 'audio' ? DetailFromMediaType<T>[] : never,
     }
   }
 }

Once we've updated the media store to TypeScript after the Pinia conversion and are able to pass regular generic parameters, we won't have to rely on a string parameter to deduce the media type and should be able to convert MediaService<T extends FrontendMediaType> to MediaService<T extends MediaDetail> and also get rid of the generic parameter on MediaDetal (currently called BaseMediaDetail but the Base prefix is probably unnecessary).


Add ZStandard compression codec. Fixes #438

I think Compression can be simplified with a good refactor.  I can make a follow on issue.  Other than that, I think this PR is good to go.


GUI internationalized (french to start)

GUI should handle many languages.
Language should be detected from the system or choose in a configuration panel of the application.

I initialized the work to be done there : https://github.com/ucoin-io/cutecoin/commit/ed099703267b9f9129f1f11a774c7efda1d01625

Maybe more than just in the GUI: internationalization support in the comment of transaction.

What do you mean ? :o

I would like to be able to write: facture de méditation instead of facture de meditation in the comment of a transaction.
meditation -> méditation
electricite -> électricité
voila -> voilà
etc.

This is a ucoin limitation, not a cutecoin one. You should post about it in https://github.com/ucoin-io/ucoin

Ok sorry my bad, thanks

https://github.com/ucoin-io/cutecoin/commit/0f83e3041e7a00d5c09cd4c3269357969b65cdaa


CMake error on qdldl_sources

I'm getting the following error:
CMake Error at lin_sys/direct/qdldl/CMakeLists.txt:2 (add_subdirectory):
  The source directory

    ./osqp/src/osqp/lin_sys/direct/qdldl/qdldl_sources

  does not contain a CMakeLists.txt file.

Here is my CMakeOutput.log: https://pastebin.com/F4cucd6e
I'm building from source at ArchLinux:
	cmake -DCMAKE_INSTALL_PREFIX:PATH=${pkgdir} -G "Unix Makefiles" ..
	cmake --build .

It seems that your qdldl_sources directory is empty. Have you cloned the repository with git clone --recursive https://github.com/oxfordcontrol/osqp? Note that QDLDL is a submodule in the OSQP repository.

Have a look here on how to build OSQP from sources.

@gbanjac I've actually missed to clone the submodules. Thank you very much!

The --recursive option work in the command line.
However the instructions offer another way to get source code which is from bintray.com.
_You first need to get the sources from one of these two options:
Download the compressed file from bintray.com.
Clone the repository_
The same error occurs if we try to cMake using the source code in the zip files from bintray.com.
What to do then?

It should not occur. Please run it from the file from the bintray sources of the latest osqp release 0.6.0. It should have the qdldl sources inside.

Thank you, bstellato.  This link worked.
Do you by any chance have analogous links for versions 5 and 4.1?  I tried getting these versions from bintray.com and ran into the same error.
On a related note, if I have version 6, do you see any reason why I would try any prior versions?


Request to remove dbxref descriptions in obo export

CHEBI's use of the dbxref description field is different from other obo ontologies, where it's usage is either deprecated, or used to store the label for the xreffed entity
For example, CHEBI says:
xref: HMDB:HMDB34355 "HMDB"

All other obo ontologies would say either:
xref: HMDB:HMDB34355 "5-Hydroxymethyl-2-furancarboxaldehyde"

Or simply:
xref: HMDB:HMDB34355

Can CHEBI switch to either of these schemes? The current usage is making the owl export incompatible with other ontologies.
Background:
https://github.com/owlcollab/oboformat/issues/89
Reported by: cmungall

@cmungall, thanks for reporting its fixed now in this release files.


Linting Fixes Utils.js

Part of #905
2 Linting Issue fixed

Coverage remained the same at 84.266% when pulling 964911d6e5194ec56a9c8dc7475a03e5c55affc2 on YashKumarVerma:utils.js into f652ecafe7e9822670c01d402e043af7538480c7 on CircuitVerse:master.


Probably a brazen and daring request for help

I really wanted to start my journey to Godot “right”, and therefore I immediately thought about a linter. The installation was successful (sort of). If you run the linting command from a third-party code editor (vs code), the result is working, but, unfortunately, the gdlint window says that the path to gdlint was not found.
I was looking for a solution to this problem, but it feels like I'm the only one who encountered this

You're welcome! Thank you for releasing a new version :D


Add withRequest param to allow assertions on request

Closing in favour of https://github.com/redhwannacef/msw-when-then/pull/2.


Use external __jit_debug_descriptor when IR_EXTERNAL_GDB_ENTRY is defined

If there are multiple __jit_debug_descriptor symbols, GDB may pick any, and ir_gdb_register_code() has no effect.

Where do you see the problem? (PHP+linux_x86_64 seems to work fine).
Probably, you are right. I just like to know more about the problem.

I've had the problem on the same environment (php + linux x86_64). The exact problem I'm having is that GDB is not aware of JIT symbols (so I don't see stubs in backtraces for example).
My understanding is that the main binary's definition should be given precedence by the linker (so ir_gdb_register_code() would use the __jit_debug_descriptor of the php binary), but the behavior I'm observing is that ir_gdb_register_code() uses the symbol of opcache.so. I'm not sure why. Maybe it's due to dlopen().
Building with IR_EXTERNAL_GDB_ENTRY + this patch fixes the issue for me.


Cannot read properties of null (reading 'Symbol(isProxy)') - inside testing environment

Wavesurfer.js version(s):
6.2.0 (latest)
Browser and operating system version(s):
JSDOM 20.0.0 (latest)
macOS 12.5
Code needed to reproduce the issue:
Minimal configuration required:
https://stackblitz.com/edit/vitest-dev-vitest-tc5dnw?file=src/App.tsx
Use behaviour needed to reproduce the issue:

Write a test for a component that calls Wavesurfer.create
Run it in JSDOM

UPDATE:
The issue is occuring because waveform packages relies on html canvas api. I haven't added canvas support to JSDOM (by adding 'canvas' package to package.json) so canvas.getContext called by waveform was returning null.
I added then the 'canvas' package, but was forced to disable 'threads' option of vitest in order for it to work. After disabling threads 24/30 of my test suites were failing and i reverted everything back and just mocked the wavesurfer :)

This issue is specific to Vitest + JSDOM. It doesn't occur in Jest (just make sure to add 'canvas' dependency for JSDOM).
So for everyone getting this issue in VITEST just mock the wavesurfer package.


[ART-4172] handle non-visible tracker bugs in first fix

Codecov Report

Merging #366 (62636af) into master (7c70d79) will increase coverage by 5.75%.
The diff coverage is 49.34%.

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   30.65%   36.41%   +5.75%
==========================================
  Files          55       59       +4
  Lines        5349     5797     +448
  Branches     1179     1248      +69
==========================================
+ Hits         1640     2111     +471
+ Misses       3608     3525      -83
- Partials      101      161      +60

Impacted Files
Coverage Δ

elliottlib/assertion.py
100.00% <ø> (+21.05%)
:arrow_up:

elliottlib/cli/__main__.py
0.00% <0.00%> (ø)

elliottlib/cli/advisory_drop_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/attach_bugs_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/change_state_cli.py
0.00% <ø> (ø)

elliottlib/cli/create_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/create_placeholder_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/create_textonly_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/rhcos_cli.py
0.00% <0.00%> (ø)

elliottlib/gitdata.py
19.41% <0.00%> (ø)

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3993ee1...62636af. Read the comment docs.


Add unit tests for field access completions

Purpose
$subject for field access on method call expressions.
Fixes #38799
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[x] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Blocked by https://github.com/ballerina-platform/ballerina-lang/issues/39023


update g9 schemas using first draft of hosting/software questions

Updated g9 schemas for cloud hosting/software/support, generated from first draft of questions. This will allow viewing the flow on preview to see the current state and spot things which need changing.

Assuming these are from the latest content PR I just thumbsed-up, :+1:
Be aware that merging this will break the supplier frontend until new content is pulled in there, so maybe get that PR ready to go before merging this. (Buyer frontend will be fine to lag behind for now).


How to make cluster config persistent?

Hello, how can I make the cluster config persistent? For example, if I have 3 servers instances online that are already part a cluster and all of them get offline at the same time. There is a way to make them reconnect to the same cluster? The first one to reconnect become master, and the others followers?
To achieve that, the only thing I need to do is implement the in_memory state_mgr.hxx file to save to the disk instead of use memory?

Hi @felipeasf
Yes, as we commented here
https://github.com/eBay/NuRaft/blob/89d7bd3469c2aeb3fe3658f5fd4a3c755ade8506/examples/in_memory_state_mgr.hxx#L51
you need to implement save_config and load_config, as well as save_state and read_state. Once those APIs are working, Raft server will automatically call them and reconstruct the last cluster info.

Thanks for the answer @greensky00 !
I didn't know about that part of the calls being automatic. I got it working =)
Another question is: There is a way to know when a slave becomes a master?

You can register a callback function for hooking up a few events:
https://github.com/eBay/NuRaft/blob/972f02dd84aa2bcc4b9d7da5fdc1a63da21463ef/include/libnuraft/context.hxx#L58
The event for becoming a leader is defined here:
https://github.com/eBay/NuRaft/blob/972f02dd84aa2bcc4b9d7da5fdc1a63da21463ef/include/libnuraft/callback.hxx#L53

To register this callback I need the current context, right? As the context is created when the launcher.init function is called, how can I get the current context in order to set the callback?

context is given at the initialization of Raft server and then becomes read-only. You need to set your callback function at the init time.
And now I realized that if someone uses raft_launcher, there is no way to set the callback function. A simple workaround for now is writing your own init function.
Seems to me the API that setting the callback function should be exposed outside. Will fix that soon. Thanks.

I wrote my own init function and is all good now!
Thanks for your kindly support!


Netherlands with school holidays

Any interest in adding optional school holidays?
refs #

For information, read and make sure you're okay with the Contributing guidelines.

[x] Tests with a significant number of years to be tested for your calendar.
[x] Docstrings for the Calendar class and specific methods.
[ ] Use the workalendar.registry_tools.iso_register decorator to register your new calendar using ISO codes (optional).
[x] Calendar country / label added to the README.rst file.
[x] Changelog amended with a mention like: "Added <country> by @pseudo (#)". Note Please do NOT change the version number here. It's the project maintainers' duty.

[x] Tests with a significant number of years to be tested for your calendar.
[ ] Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.

Thanks for the feedback. I made changes accordingly. I also refactored my tests a bit so that others should find it easier to set up tests for new school dates.
One more note of interest: for a calendar that includes school days, information is lost when transforming the list of holidays into a dictionary, using:
>>> dict(calendar.holidays(year))

This is because some days are both a school holiday and a national holiday (January 1st for example), whereas the resulting dict has unique date keys. To preserve all information when turning the list of date-name tuples into a dict, I used:
>>> holidays = {}
>>> for h in self.cal.holidays(year):
        holidays.setdefault(h[0], []).append(h[1])

Then holidays becomes a dictionary (still with unique date keys) in which the values are a list of names, like:
{datetime.date(2020, 1, 1): ['Christmas holiday', 'New year']}

That looks fine fine fine, @Flix6x!
I was in the making of a new release and I've stopped to eventually integrate your latest branch. But even though there's no conflict here, I saw that the changelog entry was not positioned at the right place, because you've forked before the last release Spain...
Could you please rebase from master? if you can't or don't have time, I'd be glad to do it myself and add your great contribution to the next release!

all right, hold your horses. Since your change introduces the kwargs arguments to the core class, I think I'll add it to the next major release...
I'll handle this if you don't mind and don't worry, your great contribution will be honored! ;o)

Okay, thanks for the heads-up.
FYI, I have another feature branch on hold to become a PR, which introduces the carnival holiday (and carnival school holidays), being relevant to the southern NL region. I am waiting for the present PR to be merged with master. Alternatively, I could merge that work into this PR. Let me know if you prefer the latter approach.

@Flix6x I prefer to keep the scopes of the PRs as limited as possible, to make sure we don't have nasty side-effects.
The #569 is ready to be merged, and you may want to branch off master right after that :o)

Netherlands extra calendars are now part of the newest (13.0.0) release:

https://github.com/peopledoc/workalendar/releases/tag/13.0.0
https://pypi.org/project/workalendar/13.0.0/

Happy upgrading!


Implement more language highlighting

Why does Remark only ship with a subset of languages? Highlight.js has so much more to offer than the few bundled ones. Is there a way to quickly override the language list and provide a custom Highlight build?
I'm looking for Sass and Lua both, neither of which are support out of the box, but are in Highlight.js.

+1 to this. I also need Lua.

All languages supported by Highlight.js 9.0.0 is now available in the recently released version 0.13.

@gnab awesome! Thanks.


bias_correction.XBiasCorrection does not import after installing via pip

Hi @pankajkarman, thanks for this nice code. I especially like the xr.apply_ufunc capabilities.
However, I noticed that XBiasCorrection does not import when installing via pip:

I and students from the ASP summer school https://asp.ucar.edu/asp-colloquia want to use your code for bias reduction and to then compute skill with climpred https://github.com/pangeo-data/climpred. Some quantile mapping is required for precip.
(So far I just copied https://github.com/pankajkarman/bias_correction/blob/master/bias_correction.py into climpred in the PR below, but I'd prefer to just add bias-correction to the requirements).
PR how to integrate this into climpred: https://github.com/pangeo-data/climpred/pull/638

Hi @aaronspring, thank you very much for pointing out this issue.
You got this issue because the latest version of the repository was not uploaded to pypi. I have updated it there now.


Add changeset for #757

#757 was missing changesets, so got partially published breaking downstream importers:
node_modules/.pnpm/@definitelytyped+definitions-parser@0.0.180_typescript@5.3.0-dev.20231018/node_modules/@definitelytyped/definitions-parser/dist/packages.d.ts:1:10 - error TS2305: Module '"@definitelytyped/header-parser"' has no exported member 'Contributor'.

1 import { Contributor, Header, License } from "@definitelytyped/header-parser";
           ~~~~~~~~~~~

Note that this is technically wrongish because I'm bumping packages that would have already been bumped for the same change but indirectly, but doing all of the above is a good idea IMO.


Check possibility for throttling Ask Astro requests

Context: https://astronomer.slack.com/archives/C05QJA9LTR9/p1703159886303619
Check the possibility of throttling repeated requests coming from the same user in a stipulated amount time.

Create PR: #235

I have address the review comments received so far on the PR. PR is waiting for reviews/approval.


DeviantArt Ripper not working anymore

The big nasty bug:
DeviantArt updated their design some time ago - therefor the DeviantArt ripper does not find any images anymore.
Small bug: the login also does not work (fixable easily by exchanging url to get token / change select parameters).

Duplicate of https://github.com/4pr0n/ripme/issues/425


Add a cron test when all-tokenization is disabled

To avoid having this issue again (https://github.com/meilisearch/meilisearch/pull/3687), we would like to add a test in our CI running every week.
A new job should be created into this file: https://github.com/meilisearch/meilisearch/blob/main/.github/workflows/test-suite.yml
The name of the job should be test-disabled-tokenization.
This job should only run for the event schedule.
The following command should be done, in two separated steps:
cargo tree -f '{p} {f}' -e normal --no-default-features | grep lindera -vqz

and then
cargo tree -f '{p} {f}' -e normal | grep lindera -qz

You can take inspiration from this already existing cron test job: https://github.com/meilisearch/meilisearch/blob/918ce1dd674f99a41545c50272507a275ca53baf/.github/workflows/test-suite.yml#L80-L106

Hi @curquiza may I put my hand on this ticket?

Hello @gentcys
Sorry for the mistake on my side, this issue is done by https://github.com/meilisearch/meilisearch/pull/3779
I forgot to link the PR to this issue. Closing this then, and thanks @gentcys anyway for your involvement.


henrykhosasih VirtuCard

Zero To Mastery - Webblocks 2022 📦📦
PR contains:
New virtual bank card web block inspired by the virtual card design from CommonWealth Bank.
Breaking changes
None
Screenshots

Thanks team for reviewing my PR 🙏
I am more than happy to replace the MasterCard logo with something else if necessary.
I'll be waiting for your suggestion 😊

I think it's fine.
Looking over their website they provide branding assets.


Feature Request: External Theme Support

Such as those provided here https://github.com/jimeh/tmux-themepack, currently using both causes conflicts.

Hello @markfaine 👋
Oh my tmux! comes with TPM integration. From what I saw when visiting https://github.com/jimeh/tmux-themepack, this can be used as a TPM plugin.
If you edit your ~/.tmux.conf.local copy,
You can do
set -g @plugin 'jimeh/tmux-themepack'
set -g @themepack 'powerline/block/blue'

That being said, this tmux plugin takes the entire control of tmux status-left and status-right which may conflict with some of Oh my tmux! features.
Please give it a try and report your findings

Hello @markfaine 👋
Oh my tmux! comes with TPM integration. From what I saw when visiting https://github.com/jimeh/tmux-themepack, this can be used as a TPM plugin.
If you edit your ~/.tmux.conf.local copy, you can do
set -g @plugin 'jimeh/tmux-themepack'
set -g @themepack 'powerline/block/blue'

That being said, this tmux plugin takes the entire control of tmux status-left and status-right which may conflict with some of Oh my tmux! features.
Please give it a try and report your findings

This is how I was using it, as a tpm plugin, however, it was breaking some functionality in oh-my-tmux, so I have since disabled it.  I guess it makes sense that they might not play nice together.  I was occasionally able to get some of the themes to work with oh-my-tmux and in some cases it produced great results but it was always fragile and sometimes there would be surprise glitches. It would be nice if they could work well together, though I understand that is probably a large undertaking.  If the theme that oh-my-tmux uses was a tpm plugin itself  that might present a way to make oh-my-tmux more customizable.  I know it's a lot easier said than done but it's just a suggestion.  The themes aspect of oh-my-tmux isn't really the main selling point for me. it's the other features and the bindings.  I see it as  a way to get tmux up and usable quickly without a lot of googling how to do x in tmux.

Hello @markfaine 👋
You may want to try the gh-536 branch

Hello @markfaine 👋
You may want to try the gh-536 branch.
That being said, if a plugin overwrites status-left and/or status-right entirely, then you will likely lose some of Oh my tmux! features.

Dupe of #536


Training Timesteps for Stable Baselines3 Agent and Data Collection Process for Diffusion Model

Hi,
I'm currently training a stable_baselines3 agent on ViZDoom and came across your gamengen_test_dataset on Hugging Face. I have a couple of questions regarding your setup:

Training Timesteps: How many timesteps did you use to achieve your current results? So far, I've experimented with 1,000,000 and 3,000,000 timesteps.

Data Collection for Diffusion Model: Are you collecting data during the RL agent's training for later diffusion model training, or do you only start data collection after the RL agent is fully trained to ensure the gameplay data is more "human-like"?

Looking forward to your insights.

Hey, those frames were generated without a trained agent, just by selecting random actions. Looking at the samples, you still get to see some variety of "events" happening (loosing health, shooting a target etc..) so it's a good base to start off doing some first passes on the diffusion model.
Eventually, it'll have to be trained, but for some "simpler" vizdoom scenarios, I think the random action route is not a bad place to start.
Re. your second point, I think it's probably better to wait for the agent to be trained before doing some actual data collection. Using some random policy in the meantime can help you parallelize the two IMO.

Thanks a lot! One more thing...
It's a pity they didn't release any code, but I'm thinking about the part where they fine-tune Stable Diffusion v1.4 by replacing text conditioning with game-action sequences and frames for DOOM. How are you planning to replace the text-conditioning layers with game-specific embeddings, and then fine-tune the latent decoder and other parameters using the game data?


Server hangs on DB exceptions

On CI test RestrictedTest#testFilteredDirectDeleteAsWriter from tests project, if adminRecord.delete(); line is uncommented, this will produce the ORecordNotFoundException and the server will hang on the next test case executed in the suite. Was unable to isolate the issue into a separate test case, the only way reproduce it is to run the suite in CI environment on remote storage.

Rechecked. Since we dropped the support of implicit transactions, the adminRecord.delete() line must be wrapped into explicit transaction to reproduce it. Apparently the problem is in the remote client, not server, the client is deadlocked in OChannel#acquireReadLock.


Add Ruby API for checking feature flags

That way it would be possible to for instance only warn on sudo or os if the repository isn't feature flagged.

:+1:


featadd deadlock detection tool and monitored lock implementations #39015

This issue proposes the addition of new features to the project, including a deadlock detection tool and monitored lock implementations. These features will help in identifying and debugging potential deadlocks and monitoring lock usage. Features:
A monitored version of Lock that tracks and logs lock acquisition and release times. Functionality:
Overrides lock(), unlock(), tryLock(), and tryLock(long timeout, TimeUnit unit) methods. Logs information about lock acquisition time, release time, and any failure to acquire the lock within the specified timeout. ##### eg
2024-08-07 12:02:59  [ Thread-2:2006 ] - [ WARN ]  Thread ID: 12, Thread Name: Thread-2 - Lock held for 1912 ms, exceeding hold timeout of 1000 ms
Thread stack trace:
	at java.lang.Thread.getStackTrace(Thread.java:1564)
	at org.example.lock.AbstractMonitoredLock.afterUnlock(AbstractMonitoredLock.java:49)
	at org.example.lock.MonitoredReentrantLock.unlock(MonitoredReentrantLock.java:32)
	at org.example.ExampleService.timeout(ExampleService.java:17)
	at org.example.Main.lambda$test2$1(Main.java:39)
	at java.lang.Thread.run(Thread.java:750)

Uses ScheduledExecutorService for periodic deadlock checks. Logs deadlock information including thread names, states, lock info, and stack traces.
ThreadMXBean accesses thread information in the local JVM, which is already in memory, so accessing it is less expensive than fetching data from external resources such as disk or network. Thread state cache: The JVM typically maintains a cache of thread states, reducing the need for real-time calculations or additional data processing. ##### eg
Thread Name: Thread-0
Thread State: WAITING
Lock Name: java.util.concurrent.locks.ReentrantLock$NonfairSync@1d653213
Lock Owner Name: Thread-1
Lock Owner Id: 12
Waited Time: -1
Blocked Time: -1
Lock Info: java.util.concurrent.locks.ReentrantLock$NonfairSync@1d653213
Blocked by: java.util.concurrent.locks.ReentrantLock$NonfairSync@1d653213
Stack Trace:
	at sun.misc.Unsafe.park(Native Method)
	at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)
	at java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209)
	at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285)
	at org.example.lock.MonitoredReentrantLock.lock(MonitoredReentrantLock.java:22)
	at org.example.Main.lambda$testDeadLock$3(Main.java:79)
	at org.example.Main$$Lambda$1/1221555852.run(Unknown Source)
	at java.lang.Thread.run(Thread.java:750)

2024-08-07 14:11:28  [ pool-1-thread-1:2001 ] - [ WARN ]  Deadlocks detected:
Thread Name: Thread-1
Thread State: WAITING
Lock Name: java.util.concurrent.locks.ReentrantLock$NonfairSync@13a2dfcf
Lock Owner Name: Thread-0
Lock Owner Id: 11
Waited Time: -1
Blocked Time: -1
Lock Info: java.util.concurrent.locks.ReentrantLock$NonfairSync@13a2dfcf
Blocked by: java.util.concurrent.locks.ReentrantLock$NonfairSync@13a2dfcf
Stack Trace:
	at sun.misc.Unsafe.park(Native Method)
	at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)
	at java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209)
	at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285)
	at org.example.lock.MonitoredReentrantLock.lock(MonitoredReentrantLock.java:22)
	at org.example.Main.lambda$testDeadLock$4(Main.java:93)
	at org.example.Main$$Lambda$2/1556956098.run(Unknown Source)
	at java.lang.Thread.run(Thread.java:750)

    @Warmup(iterations = 5, time = 1, timeUnit = TimeUnit.SECONDS)
    @Measurement(iterations = 2, time = 2, timeUnit = TimeUnit.SECONDS)
    @Threads(1)

Benchmark                                                          Mode  Cnt       Score   Error   Units
LockBenchmark.testMonitoredLock                                   thrpt    2   15889.407          ops/ms
LockBenchmark.testMonitoredLock:·gc.alloc.rate                    thrpt    2     678.061          MB/sec
LockBenchmark.testMonitoredLock:·gc.alloc.rate.norm               thrpt    2      56.000            B/op
LockBenchmark.testMonitoredLock:·gc.churn.PS_Eden_Space           thrpt    2     668.249          MB/sec
LockBenchmark.testMonitoredLock:·gc.churn.PS_Eden_Space.norm      thrpt    2      55.080            B/op
LockBenchmark.testMonitoredLock:·gc.churn.PS_Survivor_Space       thrpt    2       0.075          MB/sec
LockBenchmark.testMonitoredLock:·gc.churn.PS_Survivor_Space.norm  thrpt    2       0.006            B/op
LockBenchmark.testMonitoredLock:·gc.count                         thrpt    2      20.000          counts
LockBenchmark.testMonitoredLock:·gc.time                          thrpt    2       6.000              ms
LockBenchmark.testNativeLock                                      thrpt    2  103130.635          ops/ms
LockBenchmark.testNativeLock:·gc.alloc.rate                       thrpt    2      ≈ 10⁻⁴          MB/sec
LockBenchmark.testNativeLock:·gc.alloc.rate.norm                  thrpt    2      ≈ 10⁻⁶            B/op
LockBenchmark.testNativeLock:·gc.count                            thrpt    2         ≈ 0          counts

    @Warmup(iterations = 5, time = 1, timeUnit = TimeUnit.SECONDS)
    @Measurement(iterations = 2, time = 2, timeUnit = TimeUnit.SECONDS)
    @Threads(100)

Benchmark                                                          Mode  Cnt       Score   Error   Units
LockBenchmark.testMonitoredLock                                   thrpt    2   10994.606          ops/ms
LockBenchmark.testMonitoredLock:·gc.alloc.rate                    thrpt    2     488.508          MB/sec
LockBenchmark.testMonitoredLock:·gc.alloc.rate.norm               thrpt    2      56.002            B/op
LockBenchmark.testMonitoredLock:·gc.churn.PS_Eden_Space           thrpt    2     481.390          MB/sec
LockBenchmark.testMonitoredLock:·gc.churn.PS_Eden_Space.norm      thrpt    2      55.163            B/op
LockBenchmark.testMonitoredLock:·gc.churn.PS_Survivor_Space       thrpt    2       0.020          MB/sec
LockBenchmark.testMonitoredLock:·gc.churn.PS_Survivor_Space.norm  thrpt    2       0.002            B/op
LockBenchmark.testMonitoredLock:·gc.count                         thrpt    2      18.000          counts
LockBenchmark.testMonitoredLock:·gc.time                          thrpt    2       9.000              ms
LockBenchmark.testNativeLock                                      thrpt    2  558652.036          ops/ms
LockBenchmark.testNativeLock:·gc.alloc.rate                       thrpt    2       0.016          MB/sec
LockBenchmark.testNativeLock:·gc.alloc.rate.norm                  thrpt    2      ≈ 10⁻⁴            B/op
LockBenchmark.testNativeLock:·gc.count                            thrpt    2         ≈ 0          counts

Issue Number: close #xxx

Proposed changes
Issue Number: close #xxx

WIP...
This PR will test in our cluster.
If it is stable, we consider incorporating it into 2.0.

run buildall

Delay merging this pr since it's a feature and large.


one-line + check-open-brace rule

These two blocks:
public ok(): Boolean
{
return true;
}

public notOk(): any
{
return true;
}

.. give different outcomes. The first gives a "misplaced opening brace" (as expected) the second does not. If i remove the ": any" return type, everything is fine.

class A {

    public ok(): Boolean
    {
        return true;
    }
}

and
class A {

    public ok(): any
    {
        return true;
    }

}

Are both producing test.ts[4, 5]: misplaced opening brace on the most up-to-date version of tslint. Can we close this one?

Closing this for now. Please comment if this issue persists.

class A
{

    public ok(): boolean
    {
        return true;
    }

}

my autoformat vs-settings put all braces in new lines (valid code)
same TsLint: misplaced opening brace


Update index.md

@hansthen - I'm afraid I don't understand this release note at all.
Did you release a new version of something - if so what.  If it was a new release, did it potentially solve the problem for other users as well? I think that the amount of information here is just going to worry the users that new software is going out with specific code for a specific customer.

@hansthen Yes, we need more specific details here, otherwise there is no reason to publish such a release note. Release notes should detail the issue/fix, but they do not need to specify whether something was fixed for a specific customer. This is already over a week old - can we update or should we close the PR? Thanks.

Yes please close.
On Mon, Oct 29, 2018 at 8:58 AM Adam Dupaski<EMAIL_ADDRESS>wrote:

@hansthen https://github.com/hansthen Yes, we need more specific
details here, otherwise there is no reason to publish such a release note.
Release notes should detail the issue/fix, but they do not need to specify
whether something was fixed for a specific customer. This is already over a
week old - can we update or should we close the PR? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mendix/docs/pull/1401#issuecomment-433818462, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACGa5kyqvGlUO58-co458IVjQ57p81_2ks5uprUTgaJpZM4X1DDp
.

@hansthen Thanks for the confirmation. Will close this PR.


Pokecolor no work

The command /pokecolor doesn't work and /pokenick at rune rank doesn't have perms

Should be fixed


how can use this singer for ci/cd

i write a bash for use this singer but i can not pass  --ks-pass  .
is there any sample for this issue?

Hi there! To address your concern, you can refer to the documentation on how to use bundletool by visiting this link: Android Developers - bundletool.
If you need to provide a plain password, I would recommend exercising caution. However, if you still want to proceed with it, you can use the flag --ks-pass=pass:password when executing the bundle tool command.
For more assistance and guidance, you can also take a look at our CI/CD setup in the following GitHub repository: Cafebazaar - bundle-signer CI/CD.
Feel free to reach out if you have any further questions or need additional support!


Web/refactor/convert mui components to styled

Change styling from JSS to Emotion so we can upgrade MUI.
part of #5299
Web frontend checklist

[x] Formatted my code with yarn format
[ ] There are no warnings from yarn lint --fix
[x] There are no console warnings when running the app
[ ] Added any new components to storybook
[ ] Added tests where relevant
[x] All tests pass
[x] Clicked around my changes running locally and it works
[ ] Checked Desktop, Mobile and Tablet screen sizes

Okay tested the branch and seems to be working well. Also on mobile! Just that one small change then I'll approve!