Save and restore problem

Thank you for this excellent example. I tried to implement my model which is similar to this. But I have been facing a problem during saving and restoring the model. When the training is going on everything is fine and weights are saved. But when I am stopping the iterations and then load the model with saved weights then CTC loss is showing some previous values and not the last one where it has been saved. Any help will be highly appreciated.

Hi, @xisnu ! Could you provide your code?

Thanks for your interest @igormq
This is the part where I am creating the computation graph
graph=tf.Graph()
with graph.as_default():
    print("Graph Creation")
    x=tf.placeholder(tf.float32,[None,ms,nb_features],name="x")

    y=tf.sparse_placeholder(tf.int32,name="y")
    seq_len=tf.placeholder(tf.int32,[None],name="seq_len")

    f_cell=tf.nn.rnn_cell.LSTMCell(nb_hidden,state_is_tuple=True)
    f_stack=tf.nn.rnn_cell.MultiRNNCell([f_cell]*nb_layers)

    b_cell=tf.nn.rnn_cell.LSTMCell(nb_hidden,state_is_tuple=True)
    b_stack=tf.nn.rnn_cell.MultiRNNCell([b_cell]*nb_layers)

    outputs,_=tf.nn.bidirectional_dynamic_rnn(f_stack,b_stack,x,sequence_length=seq_len,dtype=tf.float32)

    merge=tf.concat(2, outputs,name="merge")

    shape = tf.shape(x)
    batch_s,maxtimesteps=shape[0],shape[1]

    output_reshape = tf.reshape(merge, [-1, nb_hidden*2])#batch*timesteps,nb_hidden

    W = tf.Variable(tf.truncated_normal([nb_hidden*2,nb_classes],stddev=0.1),name="W1")

    b = tf.Variable(tf.constant(0., shape=[nb_classes]),name="b1")

    logits = tf.add(tf.matmul(output_reshape, W) , b,name="logits") #818622,52

    logits_reshape = tf.transpose(tf.reshape(logits, [batch_s, -1, nb_classes]),[1,0,2],name="logits_reshape")#534,1533,52

    loss =tf.nn.ctc_loss(logits_reshape, y, seq_len,time_major=True)
    cost = tf.reduce_mean(loss,name="cost")

    optimizer = tf.train.RMSPropOptimizer(lr).minimize(cost)

    decoded, log_prob = tf.nn.ctc_greedy_decoder(logits_reshape, seq_len)

    actual_ed=tf.edit_distance(tf.cast(decoded[0], tf.int32),y,normalize=False)
    ler = tf.reduce_sum(actual_ed,name="ler")
    saver=tf.train.Saver() #for storing last state
    bestsaver=tf.train.Saver() #for saving best state
    print("Network Ready")

Now I am running the session according to
with tf.Session(graph=graph) as session:
    #saver = tf.train.Saver()
    if(sys.argv[1]=="load"):
        saver.restore(session, "Weights/model_last")
        print("Previous weights loaded")
    else:
        init_op = tf.global_variables_initializer()
        session.run(init_op)
        print("New Weights Initialized")

    best=0
    acctest=0
    bestloss=10000

    for e in range(nb_epochs):
        f=open(logfilename,"a")
        totalloss=0
        totalacc=0
        starttime=time.time()

        for b in range(trainbatch):
            p=b+1
            print("Reading Batch ",p,"/",trainbatch,end="\r")
            feed = {x:inpx[b],y:inp_sparse_y[b],seq_len:inpseqlen[b]}#These arrays are batches
            batchloss,batchacc, _ = session.run([cost,ler,optimizer], feed)

            totalloss=totalloss+batchloss
            totalacc=totalacc+batchacc

        avgloss=totalloss/trainbatch
        avgacc=1-(totalacc/nctr)
        saver.save(session, "Weights/model_last")

        testloss=0
        testacc=0
        for t in range(testbatch):
            testfeed = {x:test_inpx[t],y:test_inp_sparse_y[t],seq_len:test_inpseqlen[t]}
            outcome,testbatchloss,testbatchacc=session.run([decoded[0],cost,ler],testfeed)
            if(t==0):
                first_batch_outcome=outcome
            testloss=testloss+testbatchloss
            testacc=testacc+testbatchacc

        testfile=open("Results.txt","w")
        testfile.write("Epoch "+str(e)+"\n")
        for tc in range(len(testcases)):
            predicted=label_from_sparse(first_batch_outcome,testcases[tc])
            testfile.write(str(true[tc])+" As "+str(predicted)+"\n")
        testfile.close()

        testloss=testloss/testbatch
        testacc=1-(testacc/ncts)

        endtime=time.time()
        if(testacc>best):
            best=testacc
            print("Test Result Improvement")
            bestsaver.save(session, "BestWeights/model_best")
        timetaken=endtime-starttime
        msg="Epoch "+str(e)+"("+str(timetaken)+ " sec ) Training: Cost is "+str(avgloss)+" Accuracy "+str(avgacc)+" Testing: Loss "+str(testloss)+" Accuracy "+str(testacc)+"\n"
        print(msg)
        f.write(msg)
        f.close()

I am loading my data (online handwriting) prior to the creation of graph. The training is running fine. Accuracy is increasing upto 81%. But whenever I am stopping the model and loading it again it is showing some previous loss and accuracy value instead of last saved one.

I'm using this to initialize the Saver object and it saves / restores well
saver = tf.train.Saver(tf.global_variables())

Thanks @abrari , I think the issue was solved. Closing.


Remove the About HELM Webeditor from the canvas

We don't need an 'About HELM Web Editor ' popup on right-click either on monomers or the blank canvas.

fixed in 2016-12-08

Confirmed fixed.


Rust: snatch is unmaintained

Snatch has been marked unmaintained.  The README suggests that one uses Zou instead

@BrainBlasted Thank you for feedback. I have removed it from our list.


Allow Char to be compiled

Also adds StaticPaddedString, which is used by BMSLD's FunctionArgument

Changed how this works by adding StaticPaddedString.


default EditText color

the default EditText background color is white !
it is annoying when i have dark theme (commentBackgroundColorResId and commentTextColorResId is white!!)

Hi Anastr,
Thank You very much for feedback.
I will change it in next release (1.3). Edit text background color will inherit from theme's "colorAccent" by default, so it is not be white anymore.
For now you can set properties programically by "setCommentTextColor" and "setCommentBackgroundColor "
BR,
Piotr

looks great.
i suggest to add setCommentHintText(String/ res) method, it will be nice.

We released version 2.0.
It contains fixed for this issue and additionally has api for customise hints.


Feature request: public function to get default stroke color by index before creating the series

I am displaying my data in two different visual elements from which only one is LiveCharts. I would, however, like to use the automated colors for the LineSeries stroke of LiveCharts for consistent display in both elements.
Therefore it would be handy to know the colors of LineSeries in advance, before creating them.
Until now I am using LiveCharts.Wpf.Charts.Chart.Chart.Colors(_ValueIndex) or, since 0.7.3, LiveCharts.Wpf.Charts.Base.Chart.Colors(_ValueIndex) to return the color.
This, however, requires _ValueIndex to be within [...]Colors.Count. I could, of course, create a function on my own that cycles through this color array, but I think this function actally belongs to LiveCharts (and is already implemented).
Is that function publicly accessible?
Regards,
Pusaken

The problem is that the functionLiveChart uses can only be called once, it increments an internal count so the colors do not repeat, but the function is really simple no need to cycle anything, try
var mytargetSeries = new LineSeries();

var myCollection = new SeriesCollection()
{
     new LineSeries(),
     new LineSeries(),
     new LineSeries(),
     //and many more....

     myTargetSeries
}

var seriesIndex = Chart.Colors.IndexOf(myTargetSeries);
var nextColor = Chart.Colors[seriesIndex%Chart.Colors.Count];


Nested Scrolling support

I tried to use this library with a RecyclerView inside of a CoordinatorLayout that also contains a AppBarLayout with a Toolbar that uses app:layout_scrollFlags="scroll|enterAlways|snap":
<?xml version="1.0" encoding="utf-8"?>
<android.support.design.widget.CoordinatorLayout
    android:id="@+id/coordinator_layout"
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:layout_width="match_parent"
    android:layout_height="match_parent">

    <android.support.design.widget.AppBarLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content">

        <android.support.v7.widget.Toolbar
            android:id="@+id/toolbar"
            android:layout_width="match_parent"
            android:layout_height="?attr/actionBarSize"
            app:layout_scrollFlags="scroll|enterAlways|snap"/>

    </android.support.design.widget.AppBarLayout>

    <android.support.v7.widget.RecyclerView
        android:id="@+id/store_list"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:scrollbars="vertical"
        app:layout_behavior="@string/appbar_scrolling_view_behavior"/>

    <com.futuremind.recyclerviewfastscroll.FastScroller
        android:id="@+id/fastscroll"
        android:orientation="vertical"
        android:layout_gravity="right"
        android:layout_width="wrap_content"
        android:layout_height="match_parent"
        android:layout_marginTop="?attr/actionBarSize"
        android:layout_marginBottom="?attr/actionBarSize"
        app:layout_behavior="@string/appbar_scrolling_view_behavior"/>

</android.support.design.widget.CoordinatorLayout>

This has the following problems:

the FastScroller isn't collapsing/expanding the AppBarLayout
this prevents the FastScroller to scroll to the last entry in the list if the AppBarLayout is expanded
parts of the FastScroller are not visible (I quick fixed this problem with using marginTop/marginBottom for the FastScroller)

It seems that RecyclerView doesn't handle Nested Scrolling if you scroll with scrollToPosition. Sadly I couldn't find any proper documentation how Nested Scrolling is supposed to work. So I can't say if this is a bug in RecyclerView or this is supposed to be handled by the scroll initiator. But I think it is possible to handle it with:

ViewCompat.startNestedScroll
ViewCompat.dispatchNestedPreScroll
RecyclerView.scrollBy
ViewCompat.dispatchNestedScroll
ViewCompat.stopNestedScroll

This snippet demonstrates a way that let's the RecyclerView scroll by 300px while also collapsing the AppBarLayout. However I don't know this is the proper way to do it:
if (ViewCompat.isNestedScrollingEnabled(recyclerView) && ViewCompat.startNestedScroll(recyclerView, ViewCompat.SCROLL_AXIS_VERTICAL)) {
	int[] consumed = new int[2];
	ViewCompat.dispatchNestedPreScroll(recyclerView, 0, 300, consumed, null);
	int unsconumed = 300 - consumed[1];
	recyclerView.scrollBy(0, unsconumed);
	ViewCompat.dispatchNestedScroll(recyclerView, consumed[0], consumed[1], 0, unsconumed, null);
	ViewCompat.stopNestedScroll(recyclerView);
}

I'm not sure if it is possible to fix this problem with the current approach in this lib to scroll with scrollToPosition.

This is an interesting problem. I think that what you wrote about nested scrolling makes a perfect starting point. One should probably look into how RecyclerView handles various scroll methods internally and move to another method if scrollToPosition doesn't work as expected. Filing a RecyclerView bug in Google would tell us if this is intended or not. Anyway this has to be fixed. The problem is that I currently have no time for maintaining the lib, so if you wanted to contribute, investigate this issue and post a PR, that would be great.

Also, if you decide to file a bug to Google, reference it here, please.

https://code.google.com/p/android/issues/detail?id=221455


Disclaimer

Describe the solution you'd like
Add a disclaimer to the app that you have to approve before you can use the app
Additional context
Content of the disclaimer:
https://github.com/TriPSs/popcorn-time-desktop/blob/develop/app/components/Disclaimer/DisclaimerComponent.js

Released in v0.6.1


Occasional corruption of parquet files , parquet writer might not be calling ParquetFileWriter->end()

We have a high volume streaming service which works most of the time . But off late we have been observing that some of the parquet files written out by write flow are getting corrupted. This is manifested in our reading flow with the following exception
Writer version - 1.6.0 , Reader version - 1.7.0
Caused by: java.lang.RuntimeException: hdfs://Ingest/ingest/jobs/2017-11-30/00-05/part4139 is not a Parquet file. expected magic number at tail [80, 65, 82, 49] but found [-28, -126, 1, 1]
at org.apache.parquet.hadoop.ParquetFileReader.readFooter(ParquetFileReader.java:422)
at org.apache.parquet.hadoop.ParquetFileReader.readFooter(ParquetFileReader.java:385)
at org.apache.parquet.hadoop.ParquetRecordReader.initializeInternalReader(ParquetRecordReader.java:157)
at org.apache.parquet.hadoop.ParquetRecordReader.initialize(ParquetRecordReader.java:140)
at org.apache.spark.rdd.SqlNewHadoopRDD$$anon$1.(SqlNewHadoopRDD.scala:180)
at org.apache.spark.rdd.SqlNewHadoopRDD.compute(SqlNewHadoopRDD.scala:126)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:306)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:270)
at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:306)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:270)
at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:306)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:270)
at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:73)
at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:41)
at org.apache.spark.scheduler.Task.run(Task.scala:89)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:227)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)```
After looking at the code , i can see that one of the possible causes is/are
1] footer not being serialized in the writer due to end not being called
but we are not seeing any exceptions on the writer.
2] data size - does data size has impact ? There will be cases when row group sizes will be huge as it is activity data of a user
We are using default parquet block size and hdfs block size . Other than upgrading to the latest version and re-test , what are the options we have to debug a issue like this
Reporter: venkata yerubandi
Note: This issue was originally created as PARQUET-1176. Please see the migration documentation for further details.

venkata yerubandi:
Any suggestions from the core team ?


Google play error warnings: blacklisted non-sdk-api violaitons

We're looking to get an app out on Google Play.  We target sdk 29. Both of these are marked red with API (blocked in all versions):
Lcom/android/org/conscrypt/ConscryptEngineSocket;->setHostname(Ljava/lang/String;)V
Lcom/android/org/conscrypt/ConscryptEngineSocket;->setUseSessionTickets(Z)V
We use com.squareup.okhttp3:okhttp:3.10.0 which I know is not the newest, but will upgrading resolve anything? Have looked around but have not seen many people having issues with actually blacklisted API's, only graylisted.

Apologies for my laziness, it appears you don't do those reflections from 3.12.9 and onward, right? Get now logs for using them with that version at least. Will go forward and try with that!


Landscape / Deprecations

Hey,
Looks good, however, I'd like to show the chart in landscape.
Also there are some depreciations.
Would have loved to have used this...
I think I'd also like to economize the background, not looked to see if that is possible.
Also again not looked, but I'd have a date filter, so I would need this to redraw after selection of a new date.
Jules.

OK,thanks for using my source,I'll take your advice into consideration and improve it when I have time.


Is macOS-latest really macOS-10.14? The latest is 10.15

Not sure what is really being used when I define macOS-latest in my build yaml

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 99af681d-41ad-da15-0b72-08b5cd5a11ac
Version Independent ID: 2fa0df36-a437-8cbb-b019-b49b31b1e116
Content: Microsoft-hosted agents for Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/agents/hosted.md
Product: devops
Technology: devops-cicd
GitHub Login: @steved0x
Microsoft Alias: sdanie

@ajklotz -- Anthony, thank you for your question.  You may find answers here:

Azure DevOps Support Bot
Azure DevOps on Stack Overflow

@steved0x -- Steve, please look into this potential documentation issue.

@ajklotz There is some more information here about macOS-latest - we are transitioning over so that macOS-latest points to the new 10.15. I'm checking right now, and if the switchover has happened, I'll get the article updated. If not, I will continue to monitor this and update the article once the change is complete.

@ajklotz macOS-latest now points to macOS-10.15, you can verify that by adding a - script: sw_ver command to your pipeline, you should get:
ProductName: Mac OS X
ProductVersion: 10.15.3
BuildVersion: 19D76

I am updating the docs to reflect this. Thank you.


Why not linked optional type?

Why not linked optional type?
type LinkedOptions = LinkedOptionalType<{a: number, b: number, c: number}>
const a: LinkedOptions   // {a?: number} | {a: number, b?: number} | {a: number, b: number, c?: number}

At first glance, it looks convenient and cool: such a type would allow very quickly prototyping types in which the presence of some fields depends on others. But this is only at first glance. Consider the following example:
let a: {a?: string} | {a: string, b?: string} | {a: string, b: string, c?: string} = {
	a: '',
	c: ''
}

First of all, the Union used to narrow down the type to a single field a. This is the only field that you can use without type guard. For all other (optional) fields, you will need type guarding. And the only type guarding that allows you to do this is the in operator. But in this case it is not safe:
if ('c' in a){
	a.b.toString()   // ts is ok, but runtime error
}

From the typescript point of view, everything is ok here, but if you run it, then in fact you will get a runtime error. This defect can be eliminated by setting the suppressExcessPropertyErrors option to false. However, by default, this option is set to true. So such a unique type would not work by default
An alternative solution could be this:
let a: {a?: string, b: undefined, c: undefined} | {a: string, b: string, c: undefined} | {a: string, b: string, c: string} = {
	a: '',
	c: ''
}

if (typeof a.b == 'string'){
	a.b.toString()
}

Then typescript will say directly that variable a lacks field b and it cannot be deceived, as in the example above.
But using this type is even less convenient, and the universal type implementation is very complicated to this. Also I can definitely say that its implementation is impossible with such a signature:
type LinkedOptions = LinkedOptionalType<{a: number, b: number, c: number}>

since, according to the standard, it is impossible to regulate the sequence of keys in an object. If you have a strong desire, you can implement such behavior using a conditional type. It is more difficult to write, but is type-safe:
type T<A extends string|undefined, B extends string|undefined> = {
	a: A,
	b: A extends string ? B : never,
	c: A extends string
		? B extends string ? string : never
		: never
}

unfortunately, creating such a universal type is very difficult to implement and I consider it impractical. Therefore, my advice is to avoid such cases or use conditional types for manual prototyping.

since, according to the standard, it is impossible to regulate the sequence of keys in an object.

Despite the fact that according to the standard, the order of the keys is not guaranteed, I seem to have found a hack (which cannot be relied on, but it works):
type ChainingRequired<O extends object, R = never, K extends keyof O = LastOf_<keyof O>> = [K] extends [never]
    ? R
    : ChainingRequired<Omit<O, K>, R | O>

type OP = ChainingRequired<{ a: string, b: string, c: string }>

Expexted properly behavior:
const a: OP = { a: '', }
const ab: OP = {
    a: '',
    b: ''
}
const abc: OP = {
    a: '',
    b: '',
    c: ''
}
const ac: OP = {
    a: '',
    c: ''
}

Expected errors:
//@ts-expect-error
const bc: OP = {
    b: '',
    c: ''
}
//@ts-expect-error
const c: OP = {
    c: ''
}
//@ts-expect-error
const b: OP = {
    b: ''
}

Side effect:
And unsolvable confusion related to type covariance. The actual output type is here - {a: string}:
const ac: OP = {
    a: '',
    c: ''
}

However, this type is relatively type-safe:
function f(o: OP){
    if ('b' in o){
        console.log(o.b.toString())
        if ('c' in o){
            console.log(o.c.toString())
        }
    }
    if ('c' in o){
        a.c.toString()   // ts error
    }
}

Despite the fact that according to the standard, the order of the keys is not guaranteed, I seem to have found a hack (which cannot be relied on, but it works):

it was discovered on version 5.2.0-dev.20230705 (and then the rest) that this type can generate an unpredictable chain order (since the union order is not regulated and the Last type can return absolutely any type from union instead of the last). Therefore I don't see any further point in working on this.


07/10/2018 18:57 : Create Pull Request for branch master -> prTesting1_2018071018

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Initial Issue: Project Workflow Documentation

Project Formation
comments, questions, concerns, resources, and more related to developing project workflow documentation strategies for our institutions

I just finished meeting with the head of our web department. He is going ot help me set up a Jira service desk for internal documentation. I have also been working in Confluence to set up "project dossiers" for each active project we have. The project dossiers will be accessible to our web department in Jira through the knowledge base function.
I am developing some intake materials using the Yale DH Lab's Defining Your Project: A DHLab Toolkit. I have rewritten our MoU to document specifics about our commitments to projects, and have started writing letters of support for projects that document exactly what our partnership will look like.
I am SUPER EXCITED about this project!

ADHC_Needs and Wants for a JIRA workflow.docx
notes_lance_sara_jira_adhc_service_ticket_request_draft.docx
Template Email for Project Request Confirmation.docx


Enforce canonical CBOR encodings

Quoting @dcoutts:

Our new impl in general does not check for canonical encodings because it doesn't need to care any more (yay).
But the old impl does care. So to avoid an unfortunate disagreement with the old nodes we should still make sure that new stuff uses canonical encodings.
We still enforce canonical encodings when decoding addresses, but not elsewhere.
I think the only other place we really have to enforce this for the Byron rules is in accepting new transactions.  So it's only txs that come in from users where we need to check we don't accept txs with non-canonical encodings and put them into blocks.
So my thought is that we do a canonical check when we're adding new txs to the mempool and nowhere else. And we do that canonical check generically, rather than by changing our cbor decoders.
The canonical check is simple: re-encode and check the bytes are the same. This is more expensive, but if we're only doing it in the mempool for new txs then that's fine.
And where should it go? Is the right place in the ledger function that is used by the mempool, or should it go where the function is used by the mempool?

To check whether a transaction is canonical, we need access to the original bytes so we can compare them with a fresh, canonical encoding of the transaction.
Let's look at the current situation. We are using the following type for generalised transactions:
data GenTx (ByronBlockOrEBB cfg) = ByronTx
  { byronTx   :: !(CC.UTxO.ATxAux ByteString)
  , byronTxId :: CC.UTxO.TxId
    -- ^ This field is lazy on purpose so that the TxId is computed on
    -- demand.
  }

We decode it using:
decodeByronGenTx :: Decoder s (GenTx (ByronBlockOrEBB cfg))
decodeByronGenTx =
    mkByronTx . annotate <$> fromCBOR
  where
    annotate :: CC.UTxO.ATxAux ByteSpan -> CC.UTxO.ATxAux ByteString
    annotate CC.UTxO.ATxAux{aTaTx, aTaWitness} =
      CC.UTxO.ATxAux{
        aTaTx      = reAnnotate aTaTx,
        aTaWitness = reAnnotate aTaWitness
      }

Note the use of reAnnotate, which throws away the annotation (the bytes) and reserialises the given value to use as its new (and thus canonical) annotation. We will compute the hash of the ATxAux in mkByronTx using the hash of the aTaTx field (the witness is ignored?), which actually involves serialising again. So we're serialising twice and losing access to the original bytes! The upside is that we always have a canonical encoding :grin:.  I'm not 100% sure, but I suspect there's a danger that the sender of the transaction has a different hash (TxId) for the transaction than we have, which is not what we want.
I think the next step to take is to avoid throwing away the original bytes, which will make it possible to do the canonical check, and which will also improve performance as we will avoid two serialisations per incoming transaction.
I have been told the ledger team are planning to rework the annotations. I hope that will improve things.
P.S. #999 will not fundamentally change the situation, it will just add more constructors with types that have the same problem.

Conclusion of a discussion with @edsko and @dnadales: the ledger will detect and reject transactions with non-canonical encodings. It will compute the hash of the ByteString annotation of the transaction and compare that with the signed hash that is stored in the transaction witness. If the hashes do not match, it will return a TxValidationWitnessWrongSignature error. Although the error does not explicitly say the transaction is invalid because of a non-canonical encoding, this is good enough.
It is important to make sure the ByteString annotation of the transaction is canonical. If the non-canonical encoding we received via the network is used as the annotation, then the hash will match and the transaction will be accepted. So the solution is to serialise each incoming transaction from scratch and to reuse that encoding, which must be canonical, as the annotation.

Conclusion of a discussion with @edsko and @dnadales: the ledger will detect and reject transactions with non-canonical encodings.

@mrBliss I think we should be careful here. As you pointed out later on in the paragraph, the ledger cannot detect (without de-serializing with some sort of "canonical decoder") non-canonical encodings.

Addressed by #999.


Improvement for k8s.io/docs/tasks/administer-cluster/configure-upgrade-etcd/

The restoration command should be clear containing the new -to-be-created directory and the path containing the backup file.
Like:
ETCDCTL_API=3 etcdctl  --data-dir /opt/dir-to-be-created/etcd-from-backup snapshot restore /path/containing/backup/snapshot.db

/language en
/kind support

Hey @EricoCartmanez, are you talking about this passage ?

/remove-lifecycle rotten

Hi @EricoCartmanez, The command -
ETCDCTL_API=3 etcdctl snapshot restore --data-dir <data-dir-location> snapshotdb

seems fine to me

As here it is already mentioned that snapshotdb is a backup file.

/remove-kind support
Seems reasonable to do
/lifecycle frozen
/priority backlog
/triage accepted
/help

/assign


Update jsonmerge version requirement

Status
READY
Description
Certain older jsonmerge versions restrict the jsonschema version to a really old one. Let's restrict to a set of versions that support the newer ones.

Pull Request Test Coverage Report for Build 1003

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.514%

Totals

Change from base Build 960:
0.0%

Covered Lines:
4998

Relevant Lines:
7088

💛  - Coveralls


graph_s

[출처]:https://laboputer.github.io/ps/2017/09/29/graph/

트리

[출처]:https://laboputer.github.io/ps/2017/09/29/graph/

[출처]:https://m.blog.naver.com/occidere/220921661731

[출처]:https://www.medianet.cs.kent.edu/surveys/IAD06S-p2psearch-alok/index.html


winget instal does not detect package is ambiguous

Brief description of your issue
winget instal does not detect package is ambiguous, it offers to install the first matching package
Steps to reproduce
winget install fluent
Expected behavior
I expect behaviour similar to what you get with
winget install git
Multiple packages found matching input criteria. Please refine the input.
Name   Id           Source
My Git 9NLVK2SL2SSP msstore
Git    Git.Git      winget
winget install fluent
Multiple packages found matching input criteria. Please refine the input.
Name                                          Id                            Source
Fluent Flyouts Battery (Preview) [9NWXR2MKSNX7] msstore
Fluent Screen Recorder              xxxxxxxxxxxxxxxxx
Fluent HN
Fluent Tic-Tac-Toe
Actual behavior
winget install fluent
Found Fluent Flyouts Battery (Preview) [9NWXR2MKSNX7] Version Unknown
This package is provided through Microsoft Store. winget may need to acquire the package from Microsoft Store on behalf of the current user.
Agreements for Fluent Flyouts Battery (Preview) [9NWXR2MKSNX7] Version Unknown
Environment
Windows Package Manager v1.5.2201
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19044.3086
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.2201.0

Which package would you have expected to install?
winget search fluent
Name                             Id                              Version     Match              Source
-------------------------------------------------------------------------------------------------------
Fluent Terminal                  9P2KRLMFXF9T                    Unknown                        msstore
Fluent Search                    9NK1HLWHNP8S                    Unknown                        msstore
Fluent Video Player              9P0JWPR9VN80                    Unknown                        msstore
Fluent Screen Recorder           9MWV79XLFQH7                    Unknown                        msstore
Fluent Flyouts Battery (Preview) 9NWXR2MKSNX7                    Unknown                        msstore
Fluent Sticky Notes              9PK6R3QT7G6B                    Unknown                        msstore
Fluent Emoji Gallery             9N965R0G2SND                    Unknown                        msstore
Fluent Translator X              9N06KCVCQZZK                    Unknown                        msstore
Fluent Ink Board                 9NXM0GZRP5D7                    Unknown                        msstore
Fluent Flowchart                 9NV5SZHNPR0B                    Unknown                        msstore
Password Wallet Sync Fluent      9ND2RVC55331                    Unknown                        msstore
Fluent Editor                    XPDDZSQ57XQ0WG                  Unknown                        msstore
Fluent XAML Theme Editor         9N2XD3Q8X57C                    Unknown                        msstore
Fluent rooler demo               9NTSZW9K2KG7                    Unknown                        msstore
FluentCast                       9PM46JRSDQQR                    Unknown                        msstore
FluentWeather                    9PFD136M8457                    Unknown                        msstore
Fluent Reader                    yang991178.fluent-reader        1.1.3                          winget
Listen1 Fluent                   listen1.listen1.fluent          2.17.1                         winget
Fluent Search Beta               BlastApps.FluentSearch          <IP_ADDRESS>95                    winget
Td-agent                         TreasureData.TDAgent            4.3.0       Tag: fluentd       winget
ModernFlyouts (Preview)          ModernFlyouts.ModernFlyouts     <IP_ADDRESS>     Tag: fluent-design winget
Xplorer                          JustinMaximillianKimlim.Xplorer 0.3.1       Tag: fluent-design winget
Notepads                         JackieLiu.NotepadsApp           <IP_ADDRESS>     Tag: fluent-design winget

The search algorithm for the "msstore" source will try to find a "best match" and offer that back. Since there is no "best match" in the default "winget" source, the one chosen by the "msstore" source is defaulted. If there had been a package in the "winget" source with the exact name or moniker, you would have seen the disambiguation message.


Getting started documentation for Mac OS X inconsistent

The following is from the above for v1.9.1. It states that there is a ct-ng configuration for ARM toolchain generation, there is no such configuration.

In the Zephyr kernel source tree we provide two configurations for both ARM and X86 that can be used to pre-select the options needed for building the toolchain. The configuration files can be found in $ZEPHYR_BASE/scripts/cross_compiler/.
Currently the following configurations are provided:
i586.config: for standard ABI, for example for Galileo and qemu_x86
iamcu.config: for IAMCU ABI, for example for the Arduino 101
nios2.config: for Nios II boards

For ARM we recommend using https://developer.arm.com/open-source/gnu-toolchain/gnu-rm/downloads, but this needs to be fixed, agree.

Thx, will take that advice ( new to Zephyr )


Support other RTOS

Hi, I have a question for threadx-eclipse teams
It is possible to rework architecture to support other RTOS ? (i see that USBX will be ported to PX5)  so it is possible to do that with other RTOS like POSIX or FreeRTOS or chibios ??

Any chance to support it.
I know that it can break the actual stack api/architect but it target more embedded users.

Hi @EmbWareHouse.
For the time being, ThreadX and its companion modules are maintained by the same small team. We cannot currently provide support for other RTOSes. That said, I am personally not against it in principle. We would consider seriously code contributions that add explicit support for other platforms. On the other hand, such support would be out of the scope of our safety certification efforts.


Query versioning + Sharding Support

I've been trying to figure out how to slowly roll out changes to queries, and I've been pointed to sharding, which looks like an excellent solution for new queries, but I feel could provide a better experience for modifying existing queries.
New queries: Create new query with, say, 5% rollout, then gradually increase to 100% rollout over time.
Existing queries (current situation): Create new query with a different name (since queries can't have the same name), with rollout 5%. Gradually increase to 100%, then delete the old query. This also involves alerting config (on logs or whatever) to be modified to look at both names, and there's likely to be some overlap where you'll log duplicate data (once for old query, once for new query, as the changes are rolled out).
Existing queries (proposal): Add version support for queries. As a user, you might start with v0 of the query, rolled out similar to "New queries" above. When you want to modify the query, you create a v1 of the query, with 5% rollout, and decrease rollout of v0 to 95%. Gradually you shift the balance until v1 has 100% rollout and v0 has 0% rollout.
Additional impacts: fleetctl would somehow need to support this concept, so one example (pretty rough, definitely would want to polish this with the community):
---
apiVersion: v1
kind: query
spec:
  name: example_query
  description: Example Query
  queries:
    - query: select * from foo;
      version: 0
      rollout: 95
    - query: select foo as foo_rename, bar from foo;
      version: 1
      rollout: 5

Alerting config must be specified in a way that it is resilient to changes to the schema of the output logs.
Alerting seems likely to miss alerts unless it is properly configured to use both old and new columns.

I think these are both great concerns, and I think that they're problematic in either scenario (keep things the way things are or change to this proposal). I didn't intend this proposal to primarily address these problems. I think you could end up with the exact same scenario with alerting config either way.
Keep things the way they are:

alert 0: name=query_v0 <some_other_search>
alert 1: name=query_v1 <some_maybe_changed_search_fields>

Proposal:

alert 0: name=query version=0 <some_other_search>
alert 1: name=query version=1 <some_other_search>
Or alternately, the name field could append a version, maybe with fleet options.

It doesn't really do much to solve the alerting config problems, but it makes it much easier to support progressive rollout of query changes.
For example, let's say that I have a query that I know is expensive. I want to modify the query to JOIN on a new table to get some additional field added to the results. If it's an expensive query, I don't want to run the query essentially multiple times on the same host because of the potential impact to the normal workload of the system. I am also concerned that there may be problems with the new query, so I don't want to roll out the changes to all of my hosts at once.
In the current system, I'm really not sure how to do this. The best I can think of is to somehow divide the hosts by decorators and create separate queries to target each decorator, but this involves duplicating query config in addition to the alert config. As in query_v0 targets decorator_0, query_v1 targets decorator_1, etc, and then the alert configs now need to be duplicated as well, alert_query_v0, alert_query_v1, ...
In the proposed system, I would be able to apply different versions of the query to some different % of hosts, meaning I don't have to manage a complicated decorator / query config, while also providing benefits of progressive rollouts of new queries.

After writing this out, I imagine the actual implementation would have the targeting of the versions applied in the pack config rather than directly in the query config to be more consistent with the separation of concerns of packs vs  queries.
Maybe you still would use separate queries, but add additional targeting abilities to the pack config:
---
apiVersion: v1
kind: pack
spec:
  name: example_pack
  queries:
    - name: my_awesome_query # assume this will be the `name` in logs
      interval: 7200
      snapshot: true
      versions:
        - name: my_query_v0 # this is a query defined elsewhere, called my_query_v0
          version: 0         # to possibly tag the query, could be auto-generated
          rollout: 95
        - name: my_query_v1 # this is a query defined elsewhere, called my_query_v0
          version: 1         # to possibly tag the query, could be auto-generated
          rollout: 5
---
... definitions for my_query_v0, my_query_v1 here ...

tl;dr: I think the proposal doesn't as much target the alerting config, but rather is aimed at providing progressive rollouts of new / modified queries.


refactor(*): rearranged files and styled code

There are no additions or subtractions of functions, classes, methods, etc. Only the files has been rearranged and the code has been altered. If there is any mistakes in the altered code, kindly let me know.

Everything looks fine, but fyi i don't think re-formatting the code with prettier would be a good pull request. Since git commit always automatically runs prettier. tl;dr pull request's good to be merged 🙂

Yeah, I noticed it later that it had pre-commit, but apart from the prettier commits, I made changes like reducing files and making the code efficient in terms of conditional operators.


Add support for Zero Copy Send

A new Response class should be created to allow a Zero Copy Send response to be sent: https://asgi.readthedocs.io/en/latest/extensions.html#zero-copy-send

Added in commit: ca0ecb2525387d4cc973fc70c779cfa6027534b6


Add option to clear fields on save using config

At times you might want to make sure that things like publish date is not set to the article which was cloned. So this will remove values before saving - dates would be handled by Symphony. Also supports clearing checkboxes like a publish checkbox to ensure an article is in draft. More details in readme.

Great, job, I'll merge after the requested changes gets pushed !


Onvis Motion Sensor Pairing

Been at this for days now. Followed all instructions. If I dont list the accessory in the config homebrige comes up it shows it found the unpaired item but never auto pairs it.
When I put the device into config I get the following and homebridge crashes.
Config:
{
"bridge": {
"name": "Extender",
"username": "CC:26:3D:E5:CE:30",
"port": 8085,
"pin": "031-45-160"
},
"platforms": [
{
"platform": "Ranger",
"devices": [
{
"name": "Onvis-SMS1-3cf5c4",
"address": "c7:be:d1:ab:c5:57",
"pin": "943-66-752"
}
]
},
{
"platform": "config",
"name": "Config",
"port": 8080,
"sudo": true,
"restart": "sudo -n systemctl restart homebridge",
"log": {
"method": "systemd",
"service": "homebridge"
}
}
],
"accessories": []
}
Log:
[2019-9-2 15:23:12] Loaded config.json with 0 accessories and 2 platforms.
[2019-9-2 15:23:12] ---
[2019-9-2 15:23:13] Loaded plugin: homebridge-config-ui-x
[2019-9-2 15:23:13] Registering platform 'homebridge-config-ui-x.config'
[2019-9-2 15:23:13] ---
[2019-9-2 15:23:15] Loaded plugin: homebridge-ranger
[2019-9-2 15:23:15] Registering platform 'homebridge-ranger.Ranger'
[2019-9-2 15:23:15] ---
[2019-9-2 15:23:16] Loading 2 platforms...
[2019-9-2 15:23:16] [Ranger] Initializing Ranger platform...
[2019-9-2 15:23:16] [Ranger] Ranger Platform Plugin Loaded
[2019-9-2 15:23:16] [Ranger] Found device in config: "Onvis-SMS1-3cf5c4"
[2019-9-2 15:23:16] [Ranger] Waiting for accessory: Onvis-SMS1-3cf5c4
[2019-9-2 15:23:16] [Ranger] Not all accessories have their devices. Not publishing yet.
[2019-9-2 15:23:16] [Config] Initializing config platform...
[2019-9-2 15:23:16] [Config] Spawning homebridge-config-ui-x with PID 5940
[2019-9-2 15:23:16] Loading 0 accessories...
[2019-9-2 15:23:16] [Ranger] DidFinishLaunching
[2019-9-2 15:23:17] [Ranger] Found paired accessory Yale Lock address=e8:cf:08:0b:94:3c rssi=-87dB
[2019-9-2 15:23:20] [Ranger] Found unpaired accessory Onv address=c7:be:d1:ab:c5:57 rssi=-64dB
[2019-9-2 15:23:20] [Ranger] Accessory 'Onvis-SMS1-3cf5c4' found.
[2019-9-2 15:23:28] [Ranger] Discovered services.
[2019-9-2 15:23:28] [Ranger] Discovered GATT services and characteristics of Onvis-SMS1-3cf5c4
[2019-9-2 15:23:28] [Ranger] Connected to Onvis-SMS1-3cf5c4
[2019-9-2 15:23:33] [Ranger] Disconnected from Onvis-SMS1-3cf5c4
(node:5916) UnhandledPromiseRejectionWarning: Error: Disconnected
at HapBleDevice._rejectPendingOperations (/opt/node-v9.3.0-linux-armv6l/lib/node_modules/homebridge-ranger/src/hap/HapBleDevice.js:248:17)
at HapBleDevice._onDisconnected (/opt/node-v9.3.0-linux-armv6l/lib/node_modules/homebridge-ranger/src/hap/HapBleDevice.js:131:12)
at Peripheral.emit (events.js:159:13)
at Noble.onDisconnect (/opt/node-v9.3.0-linux-armv6l/lib/node_modules/homebridge-ranger/node_modules/noble/lib/noble.js:206:16)
at NobleBindings.emit (events.js:159:13)
at NobleBindings.onDisconnComplete (/opt/node-v9.3.0-linux-armv6l/lib/node_modules/homebridge-ranger/node_modules/noble/lib/hci-socket/bindings.js:259:10)
at Hci.emit (events.js:159:13)
at Hci.onSocketData (/opt/node-v9.3.0-linux-armv6l/lib/node_modules/homebridge-ranger/node_modules/noble/lib/hci-socket/hci.js:443:12)
at BluetoothHciSocket.emit (events.js:159:13)
(node:5916) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:5916) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[2019-9-2 15:23:33] [Ranger] Device Onvis-SMS1-3cf5c4 issued a disconnected event.
[2019-9-2 15:23:33] [Ranger] Reported reachability for Onvis-SMS1-3cf5c4: true
[2019-9-2 15:23:42] [Config] Homebridge Config UI X v4.6.1 is listening on :: port 8080
homebridge : TTY=pts/0 ; PWD=/var/lib/homebridge ; USER=root ; COMMAND=/bin/journalctl -o cat -n 500 -f -u homebridge
pam_unix(sudo:session): session opened for user root by (uid=0)
homebridge : TTY=pts/2 ; PWD=/var/lib/homebridge ; USER=root ; COMMAND=/bin/journalctl -o cat -n 500 -f -u homebridge
pam_unix(sudo:session): session opened for user root by (uid=0)
homebridge : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/bin/kill -9 5993
pam_unix(sudo:session): session opened for user root by (uid=0)
pam_unix(sudo:session): session closed for user root
[2019-9-2 15:24:26] [Config] Multiple Instances Of Homebridge Found Installed
[2019-9-2 15:24:26] [Config] /opt/node-v9.3.0-linux-armv6l/lib/node_modules/homebridge
[2019-9-2 15:24:26] [Config] /usr/local/lib/node_modules/homebridge
homebridge : TTY=pts/2 ; PWD=/var/lib/homebridge ; USER=root ; COMMAND=/bin/journalctl -o cat -n 500 -f -u homebridge
pam_unix(sudo:session): session opened for user root by (uid=0)
homebridge : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/bin/kill -9 6011
pam_unix(sudo:session): session opened for user root by (uid=0)
[2019-9-2 15:26:01] [Config] Multiple Instances Of Homebridge Found Installed
pam_unix(sudo:session): session closed for user root
[2019-9-2 15:26:01] [Config] /opt/node-v9.3.0-linux-armv6l/lib/node_modules/homebridge
[2019-9-2 15:26:01] [Config] /usr/local/lib/node_modules/homebridge
homebridge : TTY=pts/2 ; PWD=/var/lib/homebridge ; USER=root ; COMMAND=/bin/journalctl -o cat -n 500 -f -u homebridge
pam_unix(sudo:session): session opened for user root by (uid=0)

@grover do you have any idea what I’m doing wrong here. I’ve been stuck for weeks now
@grover

Hi @bryangauvin ! Do you have any progress on that problem?


Mariadb migrate deployment

Rename deploymentconfig.yaml -> deployment.yaml
Migrate DeploymentConfig -> Deployment
Bump helm chart version and remove obsoleted function
Add mariadb-persistent helm chart package

[test]

Mariadb helm-chart test is failing:
Server is accepting connection:
---> 11:22:14     Starting MySQL server with disabled networking ...
---> 11:22:14     Waiting for MySQL to start ...
2023-12-11 11:22:14 0 [Note] Starting MariaDB 10.3.39-MariaDB source revision ca001cf2048f0152689e1895e2dc15486dd0b1af as process 88
2023-12-11 11:22:14 0 [Note] InnoDB: Using Linux native AIO
2023-12-11 11:22:14 0 [Note] InnoDB: Mutexes and rw_locks use GCC atomic builtins
2023-12-11 11:22:14 0 [Note] InnoDB: Uses event mutexes
2023-12-11 11:22:14 0 [Note] InnoDB: Compressed tables use zlib 1.2.11
2023-12-11 11:22:14 0 [Note] InnoDB: Number of pools: 1
2023-12-11 11:22:14 0 [Note] InnoDB: Using SSE2 crc32 instructions
2023-12-11 11:22:14 0 [Note] InnoDB: Initializing buffer pool, total size = 256M, instances = 1, chunk size = 128M
2023-12-11 11:22:14 0 [Note] InnoDB: Completed initialization of buffer pool
2023-12-11 11:22:14 0 [Note] InnoDB: If the mysqld execution user is authorized, page cleaner thread priority can be changed. See the man page of setpriority().
2023-12-11 11:22:14 0 [Note] InnoDB: 128 out of 128 rollback segments are active.
2023-12-11 11:22:14 0 [Note] InnoDB: Creating shared tablespace for temporary tables
2023-12-11 11:22:14 0 [Note] InnoDB: Setting file './ibtmp1' size to 12 MB. Physically writing the file full; Please wait ...
2023-12-11 11:22:14 0 [Note] InnoDB: File './ibtmp1' size is now 12 MB.
2023-12-11 11:22:14 0 [Note] InnoDB: 10.3.39 started; log sequence number 1625419; transaction id 20
2023-12-11 11:22:14 0 [Note] InnoDB: Loading buffer pool(s) from /var/lib/mysql/data/ib_buffer_pool
2023-12-11 11:22:14 0 [Note] InnoDB: Buffer pool(s) load completed at 231211 11:22:14
2023-12-11 11:22:15 0 [Note] Plugin 'FEEDBACK' is disabled.
2023-12-11 11:22:15 0 [Warning] 'user' entry 'root@mariadb-6d7dffd447-jtbv4' ignored in --skip-name-resolve mode.
2023-12-11 11:22:15 0 [Warning] 'proxies_priv' entry '@% root@mariadb-6d7dffd447-jtbv4' ignored in --skip-name-resolve mode.
2023-12-11 11:22:15 0 [Note] Reading of all Master_info entries succeeded
2023-12-11 11:22:15 0 [Note] Added new Master_info '' to hash table
2023-12-11 11:22:15 0 [Note] /usr/libexec/mysqld: ready for connections.

Helm chart test is:
run_helm_command: helm test mariadb-persistent -n helm-sclorg-mariadb-persistent-48425 --logs
------------------------------ Captured log call -------------------------------
ERROR    container_ci_suite.utils:utils.py:136 failed with code 1 and output:
W1211 06:22:51.242186   12954 warnings.go:70] would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "mariadb-connection-test" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "mariadb-connection-test" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "mariadb-connection-test" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "mariadb-connection-test" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
NAME: mariadb-persistent
LAST DEPLOYED: Mon Dec 11 06:20:22 2023
NAMESPACE: helm-sclorg-mariadb-persistent-48425
STATUS: deployed
REVISION: 1
TEST SUITE:     mariadb-persistent-connection-test
Last Started:   Mon Dec 11 06:22:51 2023
Last Completed: Mon Dec 11 06:22:57 2023
Phase:          Failed

POD LOGS: mariadb-persistent-connection-test
ERROR 2002 (HY000): Can't connect to MySQL server on 'mariadb' (115)

Error: 1 error occurred:
	* pod mariadb-persistent-connection-test failed
--------------------------- Captured stdout teardown ---------------------------

Locally it passed:
[root@root-1mt-rhel-8 container-ci-suite]# helm test mariadb-persistent --logs
W1211 09:30:41.720572   78152 warnings.go:70] would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "mariadb-connection-test" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "mariadb-connection-test" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "mariadb-connection-test" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "mariadb-connection-test" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
NAME: mariadb-persistent
LAST DEPLOYED: Mon Dec 11 09:28:21 2023
NAMESPACE: mariadb-helm
STATUS: deployed
REVISION: 1
TEST SUITE:     mariadb-persistent-connection-test
Last Started:   Mon Dec 11 09:30:41 2023
Last Completed: Mon Dec 11 09:30:44 2023
Phase:          Succeeded

POD LOGS: mariadb-persistent-connection-test
testval
42

[test]


ABI 1 demo broken on website

http://vcglab.org/vials/caleydo-altsplice/index.html?file=data/abi1_bm_2k.json&exonLength=60

It seems to affect all examples....

Reads view is also affected

As I understand this was a caching problem and is now resolved


Read values in advopt.txt from environment variables

As a Noso node operator
I would like to set values found in advopt.txt using environment variables
So that I can grammatically set those values at deploy time

advopt.txt values are loaded at the program start. It actually contains almost all user and config values. It can be modified before the app is launched. Depending on what value, it could need an app restart to make changes effective.


[REQUEST] Delete File and Delete Folder >> Utility Block

Hi,
Please add DELETE File and DELETE Folder in Utility block
THANKS

NO NO NO PEOPLE CAN MAKE FAKE CONFIGS AND DELETE YOUR PERSONAL DATA! NEVER!

lol
bro don't scare that much
+ OpenBullet configs have no Encryption
++ OpenBullet path is limited to the OB Folder
also scare of abuse, should not prevent upgrades and limit a nice program like OB
if the dev was a guy like you-
there was no plugins section and many more features in OpenBullet

@shlok8749831769 the recent changes make it so that all file/folder commands can only be executed inside the working directory of OB so there's no risk whatsoever

@shlok8749831769 the recent changes make it so that all file/folder commands can only be executed inside the working directory of OB so there's no risk whatsoever

what if they corrupt your OB or delete your hits DB? Make an option in settings "allow configs to delete files in OB Folder"

I think if the file is being used they can't delete it but I haven't tried

@shlok8749831769 You can "ruin" your files already without the delete option. If you choose e.g. the "write" option for a file and choose an important one, all the content in the file will get deleted and the new text will be written into it. So you basically cannot use the file anymore after the "write" operation. Therefore, I dont see an argument to not implement the delete option because the "risk" is already there.


ImageNotWritableException

Hello,
I m trying to upload an image using intervention, but it gives me error
Intervention \ Image \ Exception \ ImageNotWritableException
Here is my code
$fileName = Input::file('logo')->getClientOriginalName();
$path = public_path().'/images/'. Auth::user()->id .'/';
$image=Image::make(Input::file('logo')->getRealPath())->save($path . $fileName);
On, line 3rd I m getting error.
Thanks.

Hi im having the same issue, but in my case the directory is writable.
        $parentDir = public_path() . '/pois/images/';
        $fileName = $input->getClientOriginalName();
        $saveDir = $parentDir;

        File::exists($saveDir) or File::makeDirectory($saveDir, 0777);

        if (is_writable($saveDir)) {
            $image = Image::make($input->getRealPath())
                ->save($saveDir);
        } else {
            echo "dir not writable";
        }

If i just do the $input->move($saveDir)  it works. Im using version 2.2.0

Was my bad, I forgot to include the image name in the save function parameter.
->save($saveDir . '/' . $fileName)
Thanks anyways ;)


For dev builds, keep track of resource names in the Vulkan driver

I was diagnosing some memory leaks, if we forget to free resources we get a non-descript WARNING: 5 RIDs of type "Texture" were leaked. which result in searching for needle in a very large haystack.
We often record resource names in the Vulkan system by calling set_resource_names but these names are only recorded in the Vulkan driver, Godot forgets them. This PR simply keeps a HashMap of IDs and records the strings if DEV_ENABLED is set.
When resources are leaked we now dump the resource names.

Not sure if we want to keep this or maybe want something nicer, but figured I would raise a PR in case we want further discussion.

Aren't we already able to rescue the object name from VkDebugUtilsObjectNameInfoEXT (if set via vkSetDebugUtilsObjectNameEXT)? I'm replying without being able right now to check the code to see what is done exactly in that regard.

Aren't we already able to rescue the object name from VkDebugUtilsObjectNameInfoEXT (if set via vkSetDebugUtilsObjectNameEXT)? I'm replying without being able right now to check the code to see what is done exactly in that regard.

We don't save the VkDebugUtilsObjectNameInfoEXT anywhere. It is created on the fly and passed into vkSetDebugUtilsObjectNameEXT. Perhaps there is a way to retrieve a debug name from Vulkan somehow? Otherwise this is probably the best approach to make debugging on the CPU-side much easier

I totally misinterpreted what the PR is about. That's what happens when you (me, at least 😅) review code first thing in the morning before sipping some coffee...

Thanks!


An error occurred while starting the application.

Hello,
I got the following exception when trying to run the StandaloneApp :

@MaherJendoubi a silly question, your not running the project in release?

@grahamehorner  no, I'm running the project in debug.

@MaherJendoubi another silly question tried running VS as Administrator? I'm sure you would have, but just thought id ask.

@MaherJendoubi try deleting the netcoreapp2.0 directory, fixed mine by doing that. If I recall the aspnet team switch from netcore to netstandard on the project type for Blazor.
I'd guess that netcoreapp directory is a remnant of a past build before the change.

See https://github.com/aspnet/Blazor/commit/a79775a28e9bc4bda8a05658985617fbc0b3c82b

Do a "git clean -xdf" on your local copy if you get runtime errors after
updating to this.

@RyoukoKonpaku By deleting the netcoreapp2.0 directory, it works now! Thanks a lot.

It's also fixed in the source code thanks to @SteveSandersonMS : https://github.com/aspnet/Blazor/commit/4f0330b1f10798fcdd625541db952e5380e7867c


Machine name no longer accepts '.'

Describe the bug
I have a set of scripts which set up a VM containing licensed software, where the licensing mechanism relies on a specific hostname. I create the Orb VM using a compliant machine name, which was reused as the hostname. That behaviour has changed, and '.' is no longer accepted.
I'm going to try working around the issue by sanitizing the machine name and setting the hostname after the VM is created, but it would be simpler if the restriction didn't exist.
To Reproduce
orb create ubuntu some.name
Expected behavior
I should have a new machine with the $HOSTNAME some.name.
Diagnostic report (required)
OrbStack info:
Version: 0.17.1 (170100)
Commit: 542d71ebea7b190bb932c1cc60c5a0d6f2fc89e4 (v0.17.1)
System info:
macOS: 13.4.1 (22F82)
CPU: arm64, 8 cores
CPU model: Apple M1 Pro
Full report: https://orbstack.dev/_admin/diag/orbstack-diagreport_2023-09-07T09-08-04.273435Z.zip

Screenshots and additional context (optional)
No response

It also doesn't accept _.

I guess it does make sense to allow ., but _ is not technically allowed in hostnames. https://man7.org/linux/man-pages/man7/hostname.7.html
Machine name validation was made stricter when automatic domain names were added, and I do think it probably makes sense to keep the _ limitations in order to guarantee that $MACHINE.orb.local is a valid DNS name.

Actually, the . restriction was added because NixOS rejects hostnames that contain ..
error: A definition for option `networking.hostName' is not of type `string matching the pattern ^$|^[[:alnum:]]([[:alnum:]_-]{0,61}[[:alnum:]])?$'. Definition values:

. is now allowed. Let me know if _ is also an issue for you.

Perfect, thanks for the rapid update.
I'm not using _.

Released in v0.17.2.

@kdrag0n Testing on 0.17.2:
I can create a test.name VM with the CLI. 👍
GUI still rejects . in the creation dialog and the rename dialog.

Fixed for the next version.


Update CMakeLists for use as submodule

CMAKE_SOURCE_DIR refers to the top level of the source tree which could be a user's project using us as a submodule.
Instead, we can use <PROJECT-NAME>_SOURCE_DIR to find the top level of this project.
Additionally, some previous target includes were being made PRIVATE which need to be public for include files to resolve for someone using them. Core already does this:
https://github.com/Azure/azure-sdk-for-c/blob/3011f16b299e5aaf5a752d36918c0bfc48444269/sdk/core/core/CMakeLists.txt#L67-L72
I have updated those.

This is pretty much correct, however in some cases it may be shorter to use PROJECT_SOURCE_DIR and friends (that is, the source dir for the most recent project() call) that can happen in another PR, however.

This is pretty much correct, however in some cases it may be shorter to use PROJECT_SOURCE_DIR and friends (that is, the source dir for the most recent project() call) that can happen in another PR, however.

Yup in some cases it can but we have several calls to project() which can muddy that. I can double check in another like you said 👍🏽


Replace WP REST API menus

Replace WP REST API menus with custom api call or make WP REST API menus pluggable

WP REST API menus replaced with custom api call in 1da4c02eda7a678627898afd057f6cd835fbe24d


chore: release  common 0.1.1

:package: Staging a new release
0.1.1 (2023-07-27)
Bug Fixes

chart/common/java-client/upload-java-client/service: use new parent (#57) (84901e7)
introduce release-please process (#51) (39a21ec)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/carbynestack/castor/releases/tag/common-v0.1.1 :sunflower:


Enforce context timeout in ES persistence implementation

What changed?
Enforce context timeout in ES persistence implementation

Why?
https://github.com/uber/cadence/issues/3519

How did you test it?
Tested locally.

Potential risks
May result in more timeout error when es is having high latency.

Coverage increased (+0.004%) to 68.816% when pulling 569b9deeed21b8362bbeeee9ebdaf14baa7eb9c9 on yycptt:es-ctx into<PHONE_NUMBER>c2838a12723f97a4c8e1dac99ebce9 on uber:master.


Add silence sensor to Aqara smart natural gas detector JT-BZ-01AQ/A

Model: JT-BZ-01AQ/A (lumi.sensor_gas.acn02)
Vendor: Xiaomi
Description: Aqara smart natural gas detector
Exposes: gas, gas_density, gas_sensitivity, selftest, test, buzzer, buzzer_manual_alarm, buzzer_manual_mute, linkage_alarm, linkage_alarm_state, state, power_outage_count, linkquality
Request add Buzzer manual mute.Thank you very much
https://home.miot-spec.com/spec?type=urn:miot-spec-v2:device:gas-sensor:0000A022:lumi-acn02:1
https://www.zigbee2mqtt.io/devices/JT-BZ-01AQ_A.html#xiaomi-jt-bz-01aq%252Fa

Just for information, this is a sensor whose value cannot be changed.

https://github.com/AlexxIT/XiaomiGateway3/releases/tag/v4.0.8


Surface issues with caching of applied rules when sorting decks

Sometimes for reasons unknown _applied_rules will not contain the correct
information. Rebuilding _applied_rules from scratch is very expensive.
However /admin/archetypes is already in the business of selecting from a kind
of "live" _applied_rules (just for the set of decks that have not yet been
classified) rather than using the cache table. So we piggy back off that to
find decks/rules that are in the funky state and display it inline in the deck
sorting table.
It's not entirely beautiful but it's practical.

The end result is as follows:


Corrected button trailing-icon

On https://material-web.dev/components/button/, both the icons are at the front. The correct attribute is trailing-icon. Source code:
https://github.com/material-components/material-web/blob/573caaee1b7fe64b57b84e2b287b6c5c74666de1/button/internal/button.ts#L59

To maintainers: I already signed the CLA but clicking Rescan results in 400 Bad Request error.


Add lolinez.com

New Issue Checklist (tick off like this: [x])

[x] I checked existing issues (open and closed) for possible duplicates
[x] I can reproduce the problem on the latest stable version (not nightly!)
[x] If you have a problem a specific website: adding the domain to your no-skip-urls-list does not solve the problem
[x] The issue is not about adding entries to the default no-skip-urls-list

What is your browser?

[x] Firefox
[ ] Chrome

What is your operating system?

[x] Linux
[ ] Mac
[ ] Windows

Description (please include examples/screenshots where applicable)
This is the URL with the destination site http://www.lolinez.com/?https://github.com

Why would anyone do something like that? lol

Why would anyone do something like that? lol


Redirect to Empty after creating Wiki Page that contains "/"

Hello,
after creating a Wiki Page that contains a "/", the page will be redirected to a empty Page. I have look at some url's in my Wiki and it seems that there a more characters that are not replaced for a pretty url.

Gitea version (or commit ref): 1.0.1
Git version: 2.10
Operating system: Ubuntu 16.04
Database (use [x]):

[ ] PostgreSQL
[*] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[*] Yes (provide example URL)
[ ] No
[ ] Not relevant

I think it's not supported second tree level wiki now.

The Problem is, some Title contains a "/". I work on a Project were i describe Bundles of a Symfony Project, title looks like "league/csv". The Questions is, feature or bug ;-) I think is more a Bug...

Sorry to bump this, but I have discovered this by accident as well, it is not even possible to remove such wiki pages since I can only remove them from the detail (The detail is an empty page with only content printed out)
I have tried searching through the database (postgres), but could not find the table containing the wiki page
This is on gitea version 1.2.0-rc2
Any idea on how to remove such a page without erasing the whole wiki?

@Sharsie wiki pages are stored in special git repository

Sorry I don't think this issue should be closed; better would be to resolve it! It would be really nice to be able to work with subfolder structrures in the wiki.
@Sharsie: I personally removed the pages I inadvertently created (before knowing about this bug) by locally pulling the repo, removing the files, committing and pushing back to origin.

@jscaux Thanks for the tip, I sort of ignored it since then :)

This appears fixed: https://try.gitea.io/mrsdizzie/parsing-errors/wiki/test%2Fme
Guessing it was fixed by: fd274ff


Added merge sort

This is my very first open source contribution. I have added merge sort with efficient time complexity .Please accept my Pull request under the hacktoberfest2021 event .

hey can you please add the label hacktoberfest

i added my name .please check it once


Documentation link to Utilities page on v4 goes to 404

The Typography page of v4's documentation points to a page that doesn't exist right below the title, in "For even more control, check out the textual utility classes.".

Fixed by #21058.


feat: Implement widget archiving functionality

Introduce the ability for users to archive and unarchive widgets directly from the canvas. This feature allows for efficient canvas management by enabling temporary removal of widgets without deletion.
Description
Key implementation details include:

Widget Removal: Archived widgets are shifted from their parent's children list to a designated archived list within the same parent.
Visibility in UI: The side pane displays archived widgets based on their specific page, consistent with active widget display.
Hierarchical Archiving: Archiving a widget also archives its children. Previously archived widgets are regrouped if a parent or ancestor is later archived.
Operational Restrictions: Archived widgets are non-editable, with disabled operations like copy and cut to preserve archive integrity. They can be unarchived or deleted.
Handling Copies and Deletion: Copied and then archived widgets retain their position when pasted. If a widget with archived children is deleted, those children are moved to the main container but stay archived.

Fixes #32977
Note: The original issue for this feature was closed, but since implementation had already begun, we decided to complete it for review.
Automation
/ok-to-test tags=""
:mag: Cypress test results

[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.

@LuisVicenteCorreia I'm sorry but we will not be able to accept your contribution because we mentioned in the issue #32977 we don't fully understand the need for such a feature and agree with it. This can cause certain negative effects to the product such as DSL bloat, & a hit to performance.
As such we will not be able to accept this contribution but you are welcome to fork the repository and use this contribution in your forked repo.


storage and crafting grid not searching

Issue description:
The storage and crafting grids won't let me search any more
What happens:
When I try to search in the grids, nothing happens
What you expected to happen:
Usually a search on the grid will find the item I am looking for.
Steps to reproduce:

Open Grid of any kind
Try to search for something
Nothing happens
...

Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge:
Refined Storage:

Does this issue occur on a server? [yes/no]
haven't tried
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]

This report is very incomplete. What version if RS? Other mods installed? Does it happen with just RS installed?

Rather unclear and incomplete issue. Reopening when you have more info.

It's really not that hard to understand. Nothing incomplete or unclear about it.
-------- Original message --------
From: Raoul<EMAIL_ADDRESS>Date:11/23/2016 7:07 AM (GMT-06:00)
To: raoulvdberge/refinedstorage<EMAIL_ADDRESS>Cc: theonlygrime<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [raoulvdberge/refinedstorage] storage and crafting grid not searching (#664)
Rather unclear and incomplete issue. Reopening when you have more info.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/raoulvdberge/refinedstorage/issues/664#issuecomment-262508011, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWjjhVCKUJQcoYBYmXilmTW95aAXa4iAks5rBDqRgaJpZM4K5FFa.

Nah you just don't want to try to fix the issue. Generic form letter response from someone who doesn't want to be bothered.
-------- Original message --------
From: Raoul<EMAIL_ADDRESS>Date:11/23/2016 7:07 AM (GMT-06:00)
To: raoulvdberge/refinedstorage<EMAIL_ADDRESS>Cc: theonlygrime<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [raoulvdberge/refinedstorage] storage and crafting grid not searching (#664)
Rather unclear and incomplete issue. Reopening when you have more info.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/raoulvdberge/refinedstorage/issues/664#issuecomment-262508011, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWjjhVCKUJQcoYBYmXilmTW95aAXa4iAks5rBDqRgaJpZM4K5FFa.

Tell me how it is incomplete when I answered every question you saw fit to put into the form?
-------- Original message --------
From: way2muchnoise<EMAIL_ADDRESS>Date:11/22/2016 3:32 AM (GMT-06:00)
To: raoulvdberge/refinedstorage<EMAIL_ADDRESS>Cc: theonlygrime<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [raoulvdberge/refinedstorage] storage and crafting grid not searching (#664)
This report is very incomplete. What version if RS? Other mods installed? Does it happen with just RS installed?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/raoulvdberge/refinedstorage/issues/664#issuecomment-262190655, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWjjhcN6rALoJy4aHPVBph49guQ0ce9Hks5rAraMgaJpZM4K5FFa.

As for version - all I see is 1.2.4. No idea but I assume it's the latest version. No other mods. My computer isn't the issue.
-------- Original message --------
From: Raoul<EMAIL_ADDRESS>Date:11/23/2016 7:07 AM (GMT-06:00)
To: raoulvdberge/refinedstorage<EMAIL_ADDRESS>Cc: theonlygrime<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [raoulvdberge/refinedstorage] storage and crafting grid not searching (#664)
Closed #664https://github.com/raoulvdberge/refinedstorage/issues/664.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/raoulvdberge/refinedstorage/issues/664#event-869662437, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWjjhVCKUJQcoYBYmXilmTW95aAXa4iAks5rBDqRgaJpZM4K5FFa.

Did you supply enough power to the controller? Do you have any disk drive? Or storage blocks.

Well. Considering that I stated that I had been using it prior I would come to the conclusion that it means I have power and storage disks.  I said that the search doesn't work.
-------- Original message --------
From: way2muchnoise<EMAIL_ADDRESS>Date:11/24/2016 5:51 AM (GMT-06:00)
To: raoulvdberge/refinedstorage<EMAIL_ADDRESS>Cc: theonlygrime<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [raoulvdberge/refinedstorage] storage and crafting grid not searching (#664)
Did you supply enough power to the controller? Do you have any disk drive? Or storage blocks.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/raoulvdberge/refinedstorage/issues/664#issuecomment-262758711, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWjjhWoIQc7GnKAv5CijCyxL7ZKPjJ_sks5rBXoRgaJpZM4K5FFa.

If this is consistently happening are you capable of making a screenshot or a vid/gif. Cause I have never had this happen.

I can. But it will be tomorrow before I get to my computer again.
-------- Original message --------
From: way2muchnoise<EMAIL_ADDRESS>Date:11/24/2016 12:54 PM (GMT-06:00)
To: raoulvdberge/refinedstorage<EMAIL_ADDRESS>Cc: theonlygrime<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [raoulvdberge/refinedstorage] storage and crafting grid not searching (#664)
If this is consistently happening are you capable of making a screenshot or a vid/gif. Cause I have never had this happen.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/raoulvdberge/refinedstorage/issues/664#issuecomment-262831989, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWjjhUKj_o0sb57TNMniisR9uFCyERG-ks5rBd1LgaJpZM4K5FFa.


Make it so you can index Expr by Id

egg does this and it's nice on their EGraph class. Right now it's a pain to index into these things.

or honestly do away with Ids completely?

yes we will do away with them entirely https://github.com/mlb2251/lambdas/issues/4


io error exception when trying to write dev.null in google app engine

Hey, we are deploying the code in google app engine, where we will be having the read-only file system.
below source code and line:
https://github.com/asweigart/pyscreeze/blob/master/pyscreeze/__init__.py#L50
trying to write to file system, we need handle the IO Exception here

What's the underlying OS? pyautogui uses scrot output to temporary files to capture the screen in Linux, so I'm not sure it can work with a read-only file system.

Fixed in https://github.com/asweigart/pyscreeze/commit/ca1f0e68600f7caceb3d91f4eb9d22e8dd638de4 by taking out the devnull stuff, which is only in there for a hyptothetical deadlock fix. We can revisit that issue if it actually comes up for someone. I'm not too concerned about it.

Thanks everyon!


Improved the documentation of SFML-specific statuses in sf::Ftp

This PR slightly improves the documentation of SFML-specific FTP statuses.

:+1:

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

:+1:


Fix system message for custom tags on expense report

Details

The system message displays tag instead of the custom name for Tag
Fixed Issues

$ https://github.com/Expensify/App/issues/30377
PROPOSAL: https://github.com/Expensify/App/issues/30377#issuecomment-1780011566
Tests

Go to the workspace chat.
Click on request money.
Enter any amount on manual request.
Click on Next > Request.
Open the new expense report.
Click on the custom tag, choose any tag.
Ensure that in the system message, the custom tag is used.

[x] Verify that no errors appear in the JS console

Offline tests

If the policy has custom tags, then the system message will use the custom tag correctly.
QA Steps

Same as above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome
https://github.com/Expensify/App/assets/54214654/f4098112-bf50-4314-8f78-deee84d6dbe0

iOS: Native
https://github.com/Expensify/App/assets/54214654/fb588ba6-4730-4cc8-819a-00d883befe0d

iOS: mWeb Safari
https://github.com/Expensify/App/assets/54214654/982e2aa0-b7e6-4569-b430-16fe41fb9d96

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/54214654/9555a7f4-84e0-4f70-be5f-cd4fa64129fb

MacOS: Desktop
https://github.com/Expensify/App/assets/54214654/c3c9d7c4-fd46-4417-bd8c-0a63f01da951

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Hi @GItGudRatio, I'm not able to see Tags. I've enabled them in Permission.ts
Could you please help me out here

@GItGudRatio i think this will be fixed after merging the latest main.

@rushatgabhane Merging the PR since it's a critical item, and you've previously approved the code too.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/lakchote in version: 1.3.99-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.0-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Get django-sockpuppet up to par with SR 3.3.0

The following PR adds a number of features and improvements.

You can subscribe and unsubscribe from other channels. The default is still that you'll be subscribed to a channel that is the user session.
By overriding the method get_channel_id in the reflex you can decide to what channel you want to broadcast to.
We now also use the same handlers that stimulus-reflex uses. Ie we use received and connected.
We can also send broadcasts from within a reflex using the morph method. If we do no broadcast will be sent at a later stage. This can be used as an optimization to avoid rendering the entire view.

Codecov Report

Merging #30 into master will decrease coverage by 0.32%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master     #30      +/-   ##
=========================================
- Coverage    2.96%   2.64%   -0.33%
=========================================
  Files          12      12
  Lines         270     303      +33
  Branches       27      32       +5
=========================================
  Hits            8       8
- Misses        262     295      +33

Impacted Files
Coverage Δ

sockpuppet/channel.py
0.00% <0.00%> (ø)

sockpuppet/consumer.py
0.00% <0.00%> (ø)

sockpuppet/reflex.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a35dac...d27a8aa. Read the comment docs.


Sentry is required to run app locally

Probably we should import Sentry dynamically (via require()) depending of presence / absence of REACT_APP_SENTRY_DSN
In this case, when sentry havent't imported, it's bootstrap script shouldn't be added to the build folder

this is part of the build process of sentry, each developer need to have the key defined in
android/sentry.properties and ios/sentry.properties, these files are in .gitignore
defaults.url=https://sentry.io/
defaults.org=gooddollar
defaults.project=gooddapp
auth.token=
cli.executable=node_modules/@sentry/cli/bin/sentry-cli


new feature compute skew

Could you please add functionality to compute skew as well for the case of non-normal distributed data

actually we are only expecting normally distributed data


Check license html

I can not assure that this license page is correct. So it is better to check by someone.
https://github.com/konifar/droidkaigi2016/blob/master/app/src/main/assets/license.html

Done


Add new sample for VK_EXT_host_image_copy

Description
This PR adds a new sample for the VK_EXT_host_image_copy. It shows how to replace traditional image staging with host image copies and also comes with a tutorial on how to use this extension.
I have tested the sample on Windows 11 with an nvidia RTX 4070.
Fixes #1076
General Checklist:
Please ensure the following points are checked:

[x] My code follows the coding style
[x] I have reviewed file licenses
[x] I have commented any added functions (in line with Doxygen)
[x] I have commented any code that could be hard to understand
[x] My changes do not add any new compiler warnings
[x] My changes do not add any new validation layer errors or warnings
[x] I have used existing framework/helper functions where possible
[x] My changes do not add any regressions
[x] I have tested every sample to ensure everything runs correctly
[x] This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

[x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[x] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[x] I have tested the sample on at least one compliant Vulkan implementation
[x] If the sample is vendor-specific, I have tagged it appropriately
[x] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[x] Any dependent assets have been merged and published in downstream modules
[x] For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
[x] For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
[x] For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

The sample runs fine for me, just a few minor comments on the documentation.

Thank you very much for your review. I have incorporated your suggestions :)

I have incorporated your suggestions

Have you? You just adjusted the copyrights.

My bad. I forgot to actually commit the other changes. Please check again.

CI now fails with files I did not touch in this PR. No idea why :(

Merging - 3 approvals


Unit tests for function PrintSummaryTable

Description

Unit tests for function PrintSummaryTable
100% code coverage of this function

Fixes #154
Type of change

Unit tests (no changes in the code)

Testing steps
To be performed on CI.
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Patch coverage has no change and project coverage change: +3.09 :tada:

Comparison is base (1fca774) 57.74% compared to head (8946238) 60.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   57.74%   60.83%   +3.09%
==========================================
  Files           3        3
  Lines         549      549
==========================================
+ Hits          317      334      +17
+ Misses        209      192      -17
  Partials       23       23

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Markdown in name of node

I would like to be able to add small icons on categories titles... For example : i want to ask to add a tactile paving category and associate that with icon for blind people.

Hi @ViolaineDo, why not adding a description (with Markdown support) as for the layers?

@ViolaineDo It's a hack but instead of icons, you can add emoji.

Hi @ViolaineDo, why not adding a description (with Markdown support) as for the layers?
Yes would help!


Create font-hyppolit.rb

[x] Checked there aren’t open pull requests for the same cask.
[x] Checked there aren’t closed issues where that cask was already refused.
[x] When naming the cask, followed the reference.
[x] Commit message includes cask’s name.
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.

Thanks!

Thank you for adding my font!


Change normalize function

fn normalize_angle_division(mut deg: f32) -> f32 {
    let c360 = 360.0_f32;
    deg - ((deg / c360).floor() * c360)

}

Faster than using mod and as fast as while. No slowdown for large numbers. Putting it here so I don't forget.

:+1:


Applying Transform Filter

The outputImage of a Transform Filter remains the same size of the inputImage. Is this an expected result? Because I expected the outputImage size to be bigger or smaller according to the Transform applied.
Reading the code, I saw that it may be intentional since the MTIRenderPassOutputDescriptor and MTIRenderCommand are constructed with inputImage size. However, if that's the case how do you scale images to be bigger or smaller accordingly using MetalPetal?
ps: I was also wondering if it might be annoying for you to answer these questions here instead of Stackoverflow. I read the Contributing guidelines and I didn't see anything talking about asking questions or what type of issues are allowed to be opened here on Github. Thank you again much appreciated!

The transform filter SHOULD have at least two output modes. 1. Output a image with the size of the input image. 2. Output a image with the size of the Minimum Enclosing Rectangle of the transformed image.
Currently only mode 1 is implemented.
I’ll try to add some other output modes to the transform filter, stay tuned.

Hello @YuAo, I was wondering if I could help out with the additional output modes? I have never implemented Metal code, but I'm pretty sure I could pull it off with some direction and guidance. I'll gladly work on it and submit a Pull Request

Added a viewport property on the transform filter. See 30a46e86d675b819ee74496fc5d11dca7febb922
If you'd like to use the Minimum Enclosing Rectangle mode. Set the viewport property to the filter's minimumEnclosingViewport property after you set the transform.

@YuAo I will read over the code and try out the new output mode right now! No need for thanking me I did absolutely nothing. Thank you for implementing it and thank you for the great work you have done! <3


Fixing typo

Missing "A"

@vellotis could you merge this in when you get a chance?

@MarkHerhold Sorry. I once already was in the middle of merging it but something got in the way. Thanks again.