document rbac setup

I've talked with @DirectXMan12 in the past about this and am trying to get it working and document it.

Permission whack-a-mole at one step. We should probably create a role or whatever the RBAC concept is to hold all the needed permissions in one bundle..

Yep, each different API server should probably have it's equivalent of the bootstrap policy -- minimal policy required for the API server and controllers to function.
Feel free to assign me to this one as well.

@liggitt @DirectXMan12 here's a basic summary of the RBAC after installing the service catalog and doing some operations. (running our very basic e2e tests, manually doing some create and get and delete of objects). I hope we can use some of this to start and then go look in the code to find the full set of operations once I understand how to make a role and package it up.
https://gist.github.com/MHBauer/1c2a2d2a2f7122bad9f20edda8d4a9a3

WIP RBAC objects at https://gist.github.com/liggitt/ded7f8abb305b5545258e560df667009
things you'd probably want to make variables:

service account name for the service catalog server ("server" in the example)
service account name for the service catalog controller manager ("controller" in the example)
namespace containing the service catalog ("catalog" in the example)

also, you'll want to make the service-catalog-controller do leader election on an object within it's own namespace, not hard-coded to kube-system (and ideally use an object other than an endpoint object)
there are a few other TODOs as well, and it's possible once you get past the initial startup, more API operations will be attempted and you'll need to add to these, but this should be a solid start
@deads2k, we'll likely want a role that encompasses the permissions required for a standard admission chain (get/list/watch on namespaces, notably)

With #936 in I think this is done enough. Updates can be made to the merged configuration, and new issues can be created when found.


Use PageHooks.beforeRenders

Right now it's just running the hooks without using the output value in rendering. To
fix this, we'll need to change the type of render. It has to be context => String. Or
something else.

Wrote a separate render(up: IObj) method to handle updates sent to the context from outside.


Sometimes get NaN values for the background from radial_brightness

This is obviously a bit of a problem, I don't yet know why it happens.

It was happening for a specific cluster (Abell 3158), because it is quite large and low redshift - so basically the background region was all off the chip. I've added an exception that triggers if the background region area is 0.


Markdown version of the blogpost?

Thanks for your awesome blogpost!
It is rather inconvenient to read the black text in deep dark grey background. I'm not sure whether it is from my browser, though I tested in incognito mode and appears to be same. Is this the style you expected?

Oh I found the problem.
It turns out to blame my VPN configurations. In China there is a Nation-wide Firewall blocking many of the websites including google.com, wordpress.com and many others. My VPN was in an 'automatic' mode to decide whether go through the VPN or not by a whitelist. Some of the stylesheets (not sure which) was newly blocked but not yet added to the VPN whitelist so could not be fetched. Opening global VPN results in a page looks exactly as your screenshot.
Thanks for your grest post!

Happy the issue is solved then, and thanks for reading!


Worker startup timeout leads to inconsistent cluster state

Describe the issue: I am using dask_jobqueue on a Slurm cluster. I noticed that frequently, a cluster that I scaled up to 50 jobs would only actually scale to 45 or so. If I called wait_for_workers, it would hang indefinitely. The Slurm logs showed that the workers that never joined had failed with Reason: failure-to-start-<class 'asyncio.exceptions.TimeoutError'>. However the SlurmCluster object didn't seem to be picking up that these jobs had failed, and continued to list them as running.
Minimal Complete Verifiable Example: I have yet to be able to consistently reproduce this, since the timeouts are intermittent. Any pointers on how to cause this timeout on command would be appreciated, and help me create an MCVE.
Anything else we need to know?: Nope
Environment:

Dask version:
Python version:
Operating System: Linux
Install method (conda, pip, source): pip

Hi @zmbc,
I've seen that on some HPC cluster. Somehow, launching a lot of jobs using the same software environment at the same time can cause slow down of Workers starting up.
It is true that currently, dask-jobqueue does not enforce the number of really started Workers, because there is no way to tell wether Workers are not there because of queue congestion, walltime reached, or in your case start-up failure. But I might be missing something, what do you mean by:

SlurmCluster object didn't seem to be picking up that these jobs had failed, and continued to list them as running.

There is probably a way of increasing Worker start-up timeout though.

Somehow, launching a lot of jobs using the same software environment at the same time can cause slow down of Workers starting up.

Ah, that sounds like a good theory on why the timeouts occur: it is probably that the software environment itself (code files) are stored on a network file system, and are trying to be concurrently read on a large number of different nodes.

because there is no way to tell wether Workers are not there because of queue congestion, walltime reached, or in your case start-up failure

Really? On Slurm, it is trivial to check this: use squeue or sacct to see whether the job is in the failed state. A failed job always needs to be restarted, a pending job doesn't. In fact I have automated this as a workaround.

Really? On Slurm, it is trivial to check this: use squeue or sacct to see whether the job is in the failed state. A failed job always needs to be restarted, a pending job doesn't. In fact I have automated this as a workaround.

Yes, I know that there are meaning to do this in all Scheduler abstractions. But this might not be as simple to implement this in this package, there has been discussion already just to retrieve the real "HPC Scheduler" status: https://github.com/dask/dask-jobqueue/issues/11.
This would be really nive to have contributions here!


Exception in Rider 2024

I starting to get errors like this after installing Rider 2024
com.intellij.diagnostic.PluginException: `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. 'core.ToggleAction' must override `getActionUpdateThread` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: com.noorts.toggler]
	at com.intellij.diagnostic.PluginProblemReporterImpl.createPluginExceptionByClass(PluginProblemReporterImpl.java:23)
	at com.intellij.diagnostic.PluginException.createByClass(PluginException.java:90)
	at com.intellij.diagnostic.PluginException.reportDeprecatedUsage(PluginException.java:125)
	at com.intellij.openapi.actionSystem.ActionUpdateThreadAware.getActionUpdateThread(ActionUpdateThreadAware.java:21)
	at com.intellij.openapi.actionSystem.AnAction.getActionUpdateThread(AnAction.java:200)

Hey @timurproko, thanks for the report!
The latest update (Toggler v1.4.0) should have resolved this deprecation. Could you please confirm that the Toggler version you are running is v1.4.0?
If you are already running Toggler v1.4.0 and the error remains, could you please specify the exact Rider version you are using and potentially your platform (OS) as well? This would greatly help me reproduce the issue. Thanks!

I was previously using version Toggler-1.3.1, I've updated to Toggler-1.4, and I'm pleased to report that the issue has been resolved. I apologize for any inconvenience caused and want to express my gratitude for your diligent efforts!

No worries! Again, thanks for reporting!


hang when creting new issue

steps to reproduce:
1)docker-compose up
2)login and create project
3)create new issue -> save

log entries:
Completed 500 Internal Server Error in 60316ms (ActiveRecord: 40.4ms)
Net::ReadTimeout (Net::ReadTimeout):
app/models/mailer.rb:455:in deliver_mail'   config/initializers/10-patches.rb:154:in deliver'
app/models/mailer.rb:61:in block in deliver_issue_add'   app/models/issue.rb:909:in each_notification'
app/models/mailer.rb:60:in deliver_issue_add'   app/models/issue.rb:1626:in send_notification'
app/models/issue.rb:175:in create_or_update'   app/controllers/issues_controller.rb:141:in create'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'

@dmrzh  May be you need to load default data in Admin area ?

@dmrzh as @allustin indicated, before creating any projects/issues you need to login to admin area and load default configurations. Only then you can create issues. Please check this.

I fixing this bug by correcting smtp confoguration.  Probably this bug of redmine.

Oh. Redmine does not use background job processing. So creation of issues will hang while it is trying to send emails. Which means that if SMTP configuration is not corrent, then redmine hangs.

There is an async mail option for that,  (async_smtp, async_sendmail) http://www.redmine.org/projects/redmine/wiki/EmailConfiguration

@fzerorubigd remember checking it out. but cannot recollect if i got it working or if there was some issue. Will take a look when I find the time.

@fzerorubigd actually it is already support using the SMTP_METHOD option. Please refer the README for details.


Make LN payments more private

When I woke up today I remembered #278 and thought we should fix it before 0.2, turns out a later fix would be annoyingly inefficient because we'd need to put dummy invoices into the outgoing contracts.

@justinmoon do you think this is reasonable to backport to 0.2? If not in full I'd like to at least get the first commit in, otherwise we'll need dummy invoices in the contracts going forward.
I could also add functionality for gateway operators to turn off private payments in case there is a bug with it (e.g. some stuff from the invoice we aren't passing on).

Seems to apply cleanly to 0.2 (#3817), let's see if CI runs through too.


search covers only dynamic content

We index the book and manpage content for the search feature, but not any of the static content. So searching for "trademark", for example, will not turn up the trademark page (nor will "downoad" find the download page, etc).
We probably could feed the static pages into the index, but I'm not sure of the details.

There are a few search related topics from a deprecated TODO file that should be considered when addressing this issue (https://github.com/git/git-scm.com/blob/2c4281d6bfd1fab54cf6f1c8a47318f3c49607f1/TODO.txt) :

weighting

weigh porcelain over plumbing
weigh by total views

add book content to search
add video shownotes to search
add stackoverflow to search
search internal pages, too

Probably a few can be discarded (adding stackoverflow to search seems an overkill for instance), but let's reflect on them when implementing

Hi. What does the search in the upper right of the site? It always returns Sorry, no search matches no matter the browser used and what I search. It is a bug ? Thanks.

thanks for reporting @cornel001 , it seems like a bug.
@peff I have a vague memory of we having a similar problem due to the ES instance being down?

I never figured out the exact reason, but yes, a year or so ago the search database stopped working, which was solved by doing a rake search_clear && rake search_index && rake search_index_book. Unfortunately, that doesn't seem to work anymore, as the tire gem depends on an outdated rest-client (I get KeyError: key not found: :ciphers; some searching reveals that this is fixed in more recent versions).
The tire gem itself is deprecated. I suspect the right path forward is moving to a better supported elasticsearch client gem.

on the Tire README file they recommend to look at https://github.com/elastic/elasticsearch-rails

With the switch to Pagefind in #1804, this seems to be addressed. Searching for "trademark" finds the "About - Trademark" page first.


Add months and then diff doesn't return the same added value

Description of the Issue and Steps to Reproduce:
var startDate = moment('2016-11-29 13:00:00');
var endDate = startDate.clone().add(3, 'month');
console.log(endDate.diff(startDate, 'month'));
**Expected output
Output should be 3
check url: https://runkit.com/embed/rglhuftgpnvv
Environment:
Chrome 61 on on Ubuntu 16.0.4*
If you are reporting an issue, please run the following code in the environment you are using and include the output:
Wed Nov 29 2017 14:35:45 GMT+0000 (WET)
11/29/2017, 2:35:45 PM
0
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36
2.19.1
undefined

Ensure your issue is isolated to moment. Issues involving third party tools will be closed unless submitted by the tool's author/maintainer.

Not really, no. Adding and subtracting months isn't symmetrical toward the end of months. The specific problem is that 3 months after Nov 29 is Feb 28 because there's no Feb 30. But Feb 28 minus Nov 29 isn't a full three months. So you end up with 2 months.
You can also avoid the truncation if you want:
endDate.diff(startDate, 'months', true) // => 2.966666666666667


How to tell vscode about bqn?

This is my settings.json
"security.workspace.trust.untrustedFiles": "open",
"window.zoomLevel": 2

}
{
"editor.formatOnSave": true,
"haskell.hlint.logLevel": "warn",
"haskell.hlint.run": "onSave",
"haskell.formattingProvider": "ormolu",
"bqn.executablePath": "/usr/local/bin/bqn",
// May be necessary

// "haskell.hlint.executablePath": ""
}
on my Ubuntu 22.10. But it errors out with Ctr-Shift-Enter with The terminal process failed to launch: Path to shell executable "cbqn" does not exist. Should I just do a symbolic link? Total Beginner to vscode, BTW.

i'm sorry, this feature is a little broken now. However, some fixes from #12 will be merged soon, and i will notify you on this thread when it's pushed to marketplace.

It should be available now, is the problem fixed?

I've created a symbolic link between bqn and cbqn and now it appears to work with Ctr-Shif-Return. But now I can't figure out how to get a glyph tablet up. How can I display the symbol table in VS Code? Sorry I'm a total beginner.

There was an idea adding the symbol table to the sidebar. As of now if you press \ and then do Ctrl+Space, you should get completion prompts for all the primitives.

I've added a symbol table as a todo. thanks

I've added a symbol table as a todo. thanks


Extract information directly from images？

Thank you very much for your research. I have downloaded your data and code, and try to run and debug it. I would like to ask how this project can extract lines, junctions, depth and vanishing points from only one image. I would appreciate it and hope you can give me some suggestions.

Your question is too general. I would suggest starting from reading the paper and getting you familiar with the literature.

非常非常感谢您的回复，我的问题简单来说就是，我尝试只用我的png照片就获取边缘信息、连接点等各类信息。但是呢，我看数据集SU3和预训练数据集pretrained中，全部都是已经提供了照片的各类边缘、连接点、消失点、深度信息的npz文件了，假如我想利用您的项目仅仅使用一张照片就重建建筑物的曼哈顿线框，我该怎么做呢？希望您能简单说一下您的建议！！！非常感谢

The shapeunity is a supervised learning algorithm, so it needs labels for training. During inference, the information you mentioned above (lines, etc) is not required.
If your goal is to use the algorithms without training data, that you can only refer to the traditional algorithms like LSD and J-LINKAGE. Of course, that would be much harder.


Passenger Type Bug

Hi i got error in passengers model
from ..models import LoyaltyProgrammeAccount
class Passenger:
"""The passenger travelling"""
please add here infant_without_seat because when i search with child with age 1 in passenger response i got infant_without_seat type and code got Exception
allowed_types = ["adult"]
class InvalidType(Exception):
    """Invalid passenger type provided"""

def __init__(self, json):
    for key in json:
        value = json[key]
        if key == "type" and value and value not in Passenger.allowed_types:
            raise Passenger.InvalidType(value)
        if key == "loyalty_programme_accounts":
            value = [
                LoyaltyProgrammeAccount(loyalty_programme_account)
                for loyalty_programme_account in value
            ]

        setattr(self, key, value)

Hi Jibran! Thanks for supplying the details of this error that you've encountered. Using a type for an infant passenger is deprecated and we suggest that you supply an age of 0 or 1 instead when searching for flights.
https://duffel.com/docs/api/offer-requests/create-offer-request#offer-requests-create-an-offer-request-body-parameters-passengers-passengers-passengers-age

There's a note about this in the API reference documentation but it's buried in the description of the type field which you were trying to use:

If the passenger is aged 18 or over, you should specify a type of adult. If a passenger is aged under 18, you should specify their age instead of a type. A passenger can have only a type or an age, but not both.

https://duffel.com/docs/api/offer-requests/create-offer-request#offer-requests-create-an-offer-request-body-parameters-passengers-passengers-passengers-type

I hope that makes sense – let us know if you have any further queries about this!

@jibranmazhar: I've added an example of how to search and book with infant passengers in #90. Hopefully it'll be useful for you.

hi @sgerrand Please check this i got this error when i do and i follow the step which is documented in duffel i add children by there age like this {'age': 1} when i create offer and creating offer request works well but after that i call client.offers.list() call and see this error please help me on this.

Thanks Jibran – I'll look into this for you later on today.

@sgerrand OK Thanks.


Enable Fulltext Search by default

Description
User Stories

As a user I want that the standard search searches in fulltext so that I get maximum searchresults.

Value

improve file search behaviour
consistent behaviour of search filters (all filter narrow down; currently "search only in content" extends the search results)

Acceptance Criteria

klick on 🔍 searches in content and title per default
replace filter "~search only in content~" with "Title only"

click on "Title only" narrows down search results for matches in the title only

Definition of ready

[ ] Everybody needs to understand the value written in the user story
[ ] Acceptance criteria have to be defined
[ ] All dependencies of the user story need to be identified
[ ] Feature should be seen from an end user perspective
[ ] Story has to be estimated
[ ] Story points need to be less than 20

Definition of done

Functional requirements

[ ] Functionality described in the user story works
[ ] Acceptance criteria are fulfilled

Quality

[ ] Code review happened
[ ] CI is green (that includes new and existing automated tests)
[ ] Critical code received unit tests by the developer

Non-functional requirements

[ ] No sonar cloud issues

Please Clarify why this is a backend issue?
We support the KQL queries for searching for title OR content, what is missing?

Please Clarify why this is a backend issue?
We support the KQL queries for searching for title OR content, what is missing?

We need a) title AND content or b) title only

Create emptytext.txt and new.txt with some new text content
try to find by text
<oc:pattern>content:"text" OR name:"*text*"</oc:pattern> - 207 text.txt and new.txt in response
<oc:pattern>content:"text" AND name:"*text*"</oc:pattern> - 207 empty response.
<oc:pattern>content:&new;text" AND name:"*new*"</oc:pattern> - 207 and only new.txt in response

Updated my comment, title AND content was my fault, not what I intended to say, sorry.

Ok, thanks @ScharfViktor - works like we need it. Transferring back to web.


Stepper Event Handlers documentation section is confusing

Link to the Page
https://www.skeleton.dev/components/steppers
Describe the Issue (screenshots encouraged!)
The examples on Next, Step and Previous Event Handlers are confusing ( its applies to latest 1.8.0 version of Skeleton).
The docs are saying:

And the handler function example
function onStepHandler(e: {step: number, state: {current: number, total: number}}): void { 	console.log('event:step', e); }
should be changed to:
function onStepHandler(e: {step: number, detail: { state: { current: number; total: number }; step: number }; 	}); }
The TIP section below:

TIP: e.state.current contains the step shown to the user after navigation, e.step contains the step where navigation occurred.

Should be changed to:
TIP: e.detail.state.current contains the step shown to the user after navigation, e.detail.step contains the step where navigation occurred.  in order to reflect to correct CustomEvent object type.
There is another issue with Stepper Handlers  e.detail.step within CustomEvent shows correct step number until Back button is pressed. If you play with Back and Next buttons you'll see that this property living its own life :) Perhaps another issue needs to be raised for this.

@Sarenor Yes, I can give a try. Should I raise a separate issue for e.detail.step behavior?

Since it's not docs-related, probably yes.
I'm looking at the step code now though and I can't see the additional detail object that you seem to expect:
https://github.com/skeletonlabs/skeleton/blob/dev/packages/skeleton/src/lib/components/Stepper/Step.svelte#L63
so we might want to slow this down a bit and investigate


Add support for other architectures

Monerod supports x86_64, x86, armv8 (aarch64), and armv7 (aarch32).
Currently we download only the x86_64 release. If we add a check at the start of the script for what architecture the system is, we can download the right binaries for monero. This feature will be added in the next release.

Added in v0.3.

Added in v0.3


Event loop blocked for quite ofter and long.

Report Issue Guide

Please run the following command and check whether the problem has been fixed：

rm -rf package-lock.jsonrm -rf node_modulesnpm install

Please search in FAQ List first, and make sure your problem has not been solved before.
2.
Please search in the issue first, and make sure your problem had not been reported before

Versions

What is your wechaty version?

Answer:
0.23.40

Which puppet are you using for wechaty? (padchat/puppeteer/padpro/...)

Answer:
padchat

What is your wechaty-puppet-XXX（padchat/puppeteer/） version?

Answer:
0.0.57

What is your node version? (run node --version)

Answer:
v11.9.0

What os are you using

Answer:
mac os

Describe the bug
Give a clear and concise description of what the bug is.

start a robot with large number of groups and contracts, the js event loop is blocked quite often
:09.27.321 INFO -=============BLOCKED FOR 2473 ms
05/08-11:09.29.120 INFO -=============BLOCKED FOR 259 ms
05/08-11:09.35.294 INFO -=============BLOCKED FOR 1347 ms
05/08-11:09.37.022 INFO -=============BLOCKED FOR 97 ms
05/08-11:09.44.435 INFO -=============BLOCKED FOR 1484 ms
05/08-11:09.46.561 INFO -=============BLOCKED FOR 166 ms
05/08-11:09.49.852 INFO -=============BLOCKED FOR 1223 ms
05/08-11:09.52.004 INFO -=============BLOCKED FOR 833 ms

To Reproduce
This part is very important: if you can not provide any reproduce steps, then the problem will be very hard to be recognized.
Steps to reproduce the behavior:

1)start a bot,
const { Wechaty, config, log } = require('wechaty')
const { PuppetPadpro } = require('wechaty-puppet-padpro')
var blocked = require('blocked');
bot.on('ready' ,()=>{
accountReady = true;
})
.on('logout', async(user) => {
    //bot_loginSuccess = false;
    logger.info("user:" + user.name() + " has logouted")

    process.exit(-1)
})
.on('login', async(user) => {

    logger.info("user:" + user.name() + " login")
   })

.on('scan', async(qrcode, status) => {
    logger.info("start scan, qrcode:" + qrcode + "\tstatus:" + status)
    if (status == -2007) {
        let logoutParam = {
            "id": id,
            "status": 3
        }

        process.exit(-1)
    }

})

.on('message', async(msg) => {

    switch (msg.type()) {
        case bot.Message.Type.Recalled:

            break;
        case bot.Message.Type.Text:

            break
        case bot.Message.Type.MiniProgram:
        case bot.Message.Type.Url:

            break
        case bot.Message.Type.Image:

            break

        default:
            break
    }

})

bot.start()
.catch(async e => {
console.error('Bot start() fail:', e)
logger.error('Bot start() fail:' + e)
await bot.logout()
await bot.stop()
process.exit(-1)
})
blocked(function(ms){
logger.info(token + "=============BLOCKED FOR " + ms  + " ms");
},{threshold:50});

Expected behavior
Give a clear and concise description of what you expected to happen.

we should not have too many block ....

Actual behavior
If applicable, add screenshots to help explain your problem.  Additional context
Add any other context about the problem here.
[bug]

wecahty-puppet-padpro/dist/src/manager/padrpo-manager.js
已经尝试 将上面文件中的队列延时 修改到500ms，，，问题依然存在，

wecahty-puppet-padpro/dist/src/manager/padrpo-manager.js
已经尝试 将上面文件中的队列延时 修改到500ms，，，问题依然存在，

貌似调越小，阻断越大，就算阻断时间小于50ms，收发消息还是很慢。

We had some event loop issues at #1450 #1459 and https://github.com/Chatie/wechaty-puppet/issues/6
Please have a look and let me know if there's something related to them.
Thanks.

cool, so when is it possible to solve or opt this problem??

Sorry, we have no time to investigate more on this issue recently.
It would be fantastic if you could dig into it and let us know whether you can fix it.
PR will be welcome.


Test building a noarch package

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

See https://github.com/conda-forge/cc-plugin-glider-feedstock/pull/7. Will wait until conda-build is fixed.


PR referencing #16 and minor readme update

Minor readme update and issue #16

THanks for letting me contribute 🚀

Pls add jwoc labels @adarshanand67 😅

Ok


Fix probable typos

In the smirff99Frosst, I noticed two probable typos:
 <Bond smirks="[#6X2:1]-[#6X4:2]" id="b23" k="700.0" length="1.468"/>
 <Bond smirks="[#6X2:1]-[#6:2]" id="b24" k="700.0" length="1.440"/>
 <Bond smirks="[#6X2:1]=[#6X3:2]" id="b25" k="1098.0" length="1.35"/>

The second line should come before the first, correct? Otherwise, the second will override the first and thus never be used...?
Also, this angle pattern contains a typo, 1~ which should be just ~, I think?
<Angle smirks="[*r3:1]1~@[*r3:2]~@[*r3:3]1" angle="60." id="a4" k="700.0"/>

On the second of these -- this is just how a ring is defined in SMARTS/SMIRKS, which makes sense how it transfers from SMILES. But per @cbayly13 , the first is indeed a typo.
I'll get a fix in.

Would it be worthwhile to develop a tool to figure out how many times each type is applied to a very large dataset (e.g. ZINC) to catch errors like this?
For types that are used zero times, simply flagging them for examination is probably enough for someone to figure out what the bug is.

@jchodera - yes, we have such a tool, we just haven't had time to do large datasets yet, but we're working on that.
I just happened to notice this while showing someone the file. There are certainly going to be other issues and we have plans to catch them....
(Before even getting to what you propose, we're first working on ensuring we have coverage of all teh chemical space we think we cover...)


Publish Academy recordings to Vimeo

Migrated from GitLab: https://gitlab.com/meltano/academy/-/issues/19
Originally created by @aaronsteers on 2021-08-09 16:10:27

View 4 previous comments from the original issue on GitLab


feat(with-sentry): update with-sentry examples to align with shared environments

I went through a lot of variations when upgrading/using Sentry in extensions.
While Sentry does provide guidance when it comes to shared environments, recommending v8, this guidance really only applies to code executed in the content scripts. This is because content scripts are the only thing executed in the same window as the website currently in the browser.
But, what I found out the hard way is that even using Sentry's default way of initialising in the popup script can cause issues, specifically, rejections from the stores.

Violation: Including remotely-hosted code in a Manifest V3 item.

With this code snippet being the one in question.
Code snippet: popup.cc3817b7.js: " let u = function(e) { let t = (0, o.getClient)(), r = t && t.getOptions(), n = r && r.cdnBaseUrl || "https://browser.sentry-cdn.com/"; return new URL(`/${(0,o.SDK_VERSION)}/${e}.min.js`, n).toString() }(r), c = (0, s.WINDOW).document.createElement("script"); c.src = u, c.crossOrigin = "anonymous", c.referrerPolicy = "origin", t && c.setAttribute("nonce", t); let p = new Promise((e, t) => { c.addEventListener("load", () => e()), c.addEventListener("error", t) }), d = s.WINDOW.document.currentScript,"

After a deep-dive, this code is included when using the Sentry.init function. This is because of how the import works (e.g. import * as Sentry from '@sentry/browser [or from the react version]), as it actually imports all things, which includes the lazy loading integration [this integration isn't needed when you're bundling code, but hey ho).
I've modified the example to show how to set up Sentry for usage in a content script, which shouldn't have this problem, but I've left the popup initialisation as standard with a comment. Open for discussion!

@louisgv any chance you could have a look?

@louisgv one more please whenever you have a moment?

@louisgv I've updated this PR. If you wouldn't mind giving it a final review and merging if you see fit

@louisgv sorry to keep on poking, but this is ready


DB file is being overwritten everytime I run the App

Whenever i run my app, the db file is overwritten and all past data is erased. The documents added earlier cannot be found.
public class MainActivity extends AppCompatActivity {

    private Nitrite db;
    //private ObjectRepository<Rules> repository;
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        if (db == null) {

            String fileName = getFilesDir().getPath() + "/test.db";
            Log.i("Nitrite", "Nitrite file - " + fileName);
            db = Nitrite.builder()
                    .filePath(fileName)
                    .openOrCreate("test-user", "test-password");

            NitriteCollection collection = db.getCollection("Rules");
            Document doc = Document.createDocument("firstName", "#12345")
                    .put("lastName", "Doe")
                    .put("birthDay", new Date())
                    .put("data", new byte[] {1, 2, 3})
                    .put("fruits", new ArrayList<String>() {{ add("apple"); add("orange"); add("banana"); }})
                    .put("note", "a quick brown fox jump over the lazy dog");
            collection.insert(doc);

            Exporter exporter = Exporter.of(db);
            String fileName1 = getFilesDir().getPath() + "/Rules.json";
            exporter.exportTo(fileName1);

        }
    }

The exported file is not adding the document again as it should be after running again.
Could you please let me know what could be causing this?

Also, if i try to run db.close() or db.commit(), I get the following error
java.lang.IllegalArgumentException: can't parse argument number: firstName=#12345

Using the code provided here, I could not reproduce this issue. Is it possible for you to send me a sample project? You can upload the sample zipped project here directly.

Hi, so i found out why that document is not being added. Whenever i create a document using the following code I am not facing any issues.
private Nitrite db;
//private ObjectRepository<Rules> repository;
@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    if (db == null) {

        String fileName = getFilesDir().getPath() + "/test.db";
        Log.i("Nitrite", "Nitrite file - " + fileName);
        db = Nitrite.builder()
                .filePath(fileName)
                .openOrCreate("test-user", "test-password");
       ArrayList<String> s = new ArrayList<String>();
            s.add("orange");
            s.add("banana");
        NitriteCollection collection = db.getCollection("Rules");
        Document doc = Document.createDocument("firstName", "#12345")
                .put("lastName", "Doe")
                .put("birthDay", new Date())
                .put("data", new byte[] {1, 2, 3})
                .put("fruits", s)
                .put("note", "a quick brown fox jump over the lazy dog");
        collection.insert(doc);

        Exporter exporter = Exporter.of(db);
        String fileName1 = getFilesDir().getPath() + "/Rules.json";
        exporter.exportTo(fileName1);
    }
}

Although if i use
.put("fruits", new ArrayList<String>() {{ add("apple"); add("orange"); add("banana"); }})
the document seems to be overwritten if i run the app again.
In the example_android_project i added this same line in the write method present in User class and i faced the same issue. On adding a user again the past user is no longer present in the repository.

You should not create list like that. What this is actually doing is creating a class derived from ArrayList<String> and then declare a static initializer. This is actually an inner class of the containing class, and so it'll have an implicit this (this$0) pointer.
While saving data in nitrite, this this pointer is failing with NotSerializableException, but somehow mvstore is consuming it silently without coughing up any error message. This unhandled exception is corrupting the database.
I'll raise an issue with h2 database team to get this addressed properly. For the time being try to avoid this static initializer to create a list.

For reference, raised an issue with mvstore team https://github.com/h2database/h2database/issues/1864

Fix has been provided to mvstore repository. It will be available to nitrite after the next release of mvstore.


Fix for spacing of sitetree panel, reportAdmin, and toggle on Member details page

Includes improvements to spacing of buttons in the toolbar.

Rebased with master to fix failing tests, and added a fix to the upload layout as mentioned here https://github.com/silverstripe/silverstripe-cms/issues/1491#event-794987275

Added fix for spacing above campaign alert, area was using legacy classes so updated them to the newer panel classes.
After


WIP: method-chaining for Mesh

In partial fulfillment of #536.

I've built this atop #530.  I think that's ready to merge now?

I've built this atop #530.  I think that's ready to merge now?

Continuing this work in #538.

Continuing this work in #538.


Add validations for SparkContext sample

Current coverage is 69.00%

Merging #251 into master will increase coverage by +0.16% as of 6240d8f

@@            master   #251   diff @@
=====================================
  Files           40     40
  Stmts         3926   3926
  Branches       348    347     -1
  Methods
=====================================
+ Hit           2703   2709     +6
+ Partial        143    142     -1
+ Missed        1080   1075     -5

Review entire Coverage Diff as of 6240d8f

Powered by Codecov. Updated on successful CI builds.


Refactoring CLI and Core Functionality

Subject: CLI Refactoring Approach and Library Selection for Octoffers Python Migration
As we embark on the critical task of refactoring the Command-Line Interface (CLI) and core functionality of Octoffers for the Python migration, it is imperative to choose a library that aligns with our project goals of simplicity, maintainability, and user-friendliness. After careful consideration, I propose the following libraries for your review:

Click:

Overview: Click is a widely-adopted Python package renowned for creating elegant and user-friendly command-line interfaces. Its declarative syntax and automatic help page generation make it a strong contender for our refactoring efforts.

Advantages:

Clear syntax for defining commands and options.
Automatic generation of help pages.
Support for intricate command structures.

Example:
import click

@click.command()
@click.option('--resume', help='Path to the resume file')
@click.option('--cover-letter', help='Path to the cover letter file')
def submit_job_application(resume, cover_letter):
    """Submit job application with resume and cover letter."""
    # Implementation resides here

if __name__ == '__main__':
    submit_job_application()

Fire:

Overview: Fire, developed by Google, offers automatic CLI generation from existing Python code. It's particularly useful for projects where simplicity and quick implementation are crucial.

Advantages:

Minimal code required for CLI implementation.
CLI generation based on function signatures.

Example:
import fire

def submit_job_application(resume, cover_letter):
    """Submit job application with resume and cover letter."""
    # Implementation resides here

if __name__ == '__main__':
    fire.Fire(submit_job_application)

Typer:

Overview: Typer is a fast and user-friendly library for building command-line applications, built on top of Click. It supports type hints, providing automatic type checking and interactive help message generation.

Advantages:

Automatic type checking using Python type hints.
Interactive help message generation.

Example:
import typer

def submit_job_application(resume: str, cover_letter: str):
    """Submit job application with resume and cover letter."""
    # Implementation resides here

if __name__ == '__main__':
    typer.run(submit_job_application)

Please review these options, considering the project's requirements and our collective development preferences. Your feedback and insights are invaluable as we strive to enhance the Octoffers CLI in our Python migration.

I've decided to use fire as the main cli library

The best thing about fire as cli library
You don't have to build any boilerplates for arguments, or help infromation. Everything is auto-generated from classes and functions. So far, this library has made the migration to python a good decision.

It's done
The CLI has been refactored, with necessary core features


Unable to deploy the ldap

Please could you tell me what am doing wrong why I can't get the crowd-ldap-server working
and how the resolve the issue
stoke on
02:57:20] INFO [net.wimpi.crowd.ldap.CrowdLDAPServer] - Configuration directory: /home/ubuntu/crowd-ldap-server/etc [02:57:20] INFO [net.wimpi.crowd.ldap.CrowdLDAPServer] - Starting up CrowdLDAP Server [02:57:20] INFO [net.wimpi.crowd.ldap.CrowdLDAPServer] - Working directory: /home/ubuntu/crowd-ldap-server/work [02:57:20] DEBUG [net.wimpi.crowd.ldap.CrowdLDAPServer] - Loading configuration. [02:57:22] DEBUG [net.wimpi.crowd.ldap.CrowdLDAPServer] - org.apache.directory.server.core.authn.AuthenticationInterceptor@21ca139c [02:57:22] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - ==> CrowdPartition::init [02:57:22] INFO [net.wimpi.crowd.ldap.CrowdPartition] - Initializing CrowdPartition with m_Suffix dc=crowd [02:57:22] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - <== CrowdPartition::init [02:57:24] ERROR [org.apache.directory.shared.ldap.entry.DefaultServerAttribute] - ERR_04450 The value {0} is incorrect, it hasnt been added [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - search((dn=0.9.2342.192003<IP_ADDRESS>=crowd, filter=(objectClass=referral:[9223372036854775807]), scope=sub) [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - findSubTree()::dn=0.9.2342.192003<IP_ADDRESS>=crowd [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - Name=crowd [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - search((dn=0.9.2342.192003<IP_ADDRESS>=crowd, filter=(objectClass=accessControlSubentry), scope=sub) [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - findSubTree()::dn=0.9.2342.192003<IP_ADDRESS>=crowd [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - Name=crowd [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - search((dn=0.9.2342.192003<IP_ADDRESS>=crowd, filter=(|:[9223372036854775807](objectClass=groupOfNames:[9223372036854775807])(objectClass=groupOfUniqueNames:[9223372036854775807])), scope=sub) [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - findSubTree()::dn=0.9.2342.192003<IP_ADDRESS>=crowd [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - Name=crowd [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - search((dn=0.9.2342.192003<IP_ADDRESS>=crowd, filter=(objectClass=subentry:[9223372036854775807]), scope=sub) [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - findSubTree()::dn=0.9.2342.192003<IP_ADDRESS>=crowd [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - Name=crowd [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - search((dn=0.9.2342.192003<IP_ADDRESS>=crowd, filter=(objectClass=triggerExecutionSubentry), scope=sub) [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - findSubTree()::dn=0.9.2342.192003<IP_ADDRESS>=crowd [02:57:24] DEBUG [net.wimpi.crowd.ldap.CrowdPartition] - Name=crowd [02:57:24] INFO [net.wimpi.crowd.ldap.CrowdLDAPServer] - Starting directory listener
And on crowd I get
2019-08-20 02:42:31,528 http-nio-8095-exec-10 INFO [plugin.rest.filter.BasicApplicationAuthenticationFilter] Invalid authentication for application with name 'crowd-ldap-server' 2019-08-20 03:00:00,818 Caesium-2-1 INFO [manager.token.reaper.UserTokenReaper] No expired user tokens were found
Here is what my config looks like
session.lastvalidation=session.lastvalidation session.isauthenticated=session.isauthenticated application.password=*********** application.name=CrowdLDAPServer session.validationinterval=30 crowd.server.url=http://<IP_ADDRESS>:8095/crowd/ session.tokenkey=session.tokenkey application.login.url=http://<IP_ADDRESS>:8095
Thanks

Issue was due to wrong firewall setting and after changing firewall it is now working.


[Bug] MySQL CDC may throw error when handling TINYINT(1)

Search before asking

[X] I searched in the issues and found nothing similar.

Paimon version
master
Compute Engine
flink
Minimal reproduce step
MySQL TINYINT(1) ;
insert 21.
What doesn't meet your expectations?
Current implementation use bool to transfer TINYINT(1), which may cause error.
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

hi, @yuzelin , I would like to take this issue, would you help assign it to me?
Thanks.

same with https://github.com/apache/incubator-paimon/issues/1395;

Thanks, @john8628 , I will close this.
cc @legendtkl


Thread Pinging - Issues

Currently, when pinging Claude inside a thread, instead of it being "@ClaudeAssistant:", it is "<@MEMBER_ID>Assistant:", with the actual Claude member ID being put.
Comparing an older version and the current one, I can confirm that I am getting filtered in the current one way more than in the older one.
I don't know if this is intended or not, but I would like the developer to review the current pinging method as in my experience it's worse.

Sorry for not addressing it earlier but I was busy. Even if you should no longer care about this I'm just putting the answer here for future reference.
This was part of the last major update I did. Before, the Slack message was assembled in the JSON blocks format used by the Slack API (which we aren't using directly but the blocks format is the same). As part of that the Claude ping and the message contents were each a separate segment in the blocks definition. As part of my experimentation I found out that we don't actually need to send a blocks JSON at all. Merely setting the text parameter causes Slack to just create the relevant blocks on its end automatically. Doing it that way is much less error prone because we can just send the text as is instead of having to squeeze it into stringified JSON and hope there are no special characters that will break Slack's attempts to parse that JSON string. The downside with that just sending the message as text is that we can no longer make a user-type segment for the ping, but it turned out that adding <@MEMBER_ID> to any message, blocks or otherwise, also triggers a ping. If USE_BLOCKS is false in the settings the ping actually still shows up normally but if we put it in a rich_text element it will look weird as you describe, but still function normally as a ping. Claude will also still, for better or worse, see either version of the ping as just "Claude" in his prompt. So no matter if the message says @Claude or <@MEMBER_ID>, Claude will always just see it as the text Claude in his context.
I've tested both variants extensively and neither had more or less of an impact on the response than the previous method of pinging had. But I released these changes at almost exactly the same time as something changed with Claude on Slack's end after a ban wave so a lot of the its new idiosyncrasies might have gotten falsely attributed to these changes.
That doesn't mean I completely rule out that these changes might have had unforeseen side effects that I merely never encountered in my testing, but I consider it very unlikely.


📝 Add npm's badge for version and download

@antharuu Mmmh is there a reason why you closed this PR ? 😅

@antharuu Mmmh is there a reason why you closed this PR ? 😅

@antharuu Mmmh is there a reason why you closed this PR ? 😅

No sorry, it was by mistake ^^"

@antharuu Mmmh is there a reason why you closed this PR ? 😅

No sorry, it was by mistake ^^"


Hide all non Temurin tests from public view

For now, I've chosen to allow everyone in adoptium-aqavit-committers to see all non Temurin tests. We can always change this with different team memberships if required.

I do not believe this PR is required.  The testJobTemplate is for generating test jobs (not build jobs), so there is no need to restrict the view of non-Temurin test jobs.

Closing for now then, thanks


Add openfoam taskflow

Might be good enough to be merge before a global cleanup between taskflows...

Current coverage is 61.77% (diff: 100%)

Merging #574 into master will decrease coverage by 0.02%

@@             master       #574   diff @@
==========================================
  Files            59         59
  Lines          2788       2789     +1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1723       1723
- Misses         1065       1066     +1
  Partials          0          0

Powered by Codecov. Last update 66d0842...640e73e

This should be fine too now. Can you review it? @cjh1


My Internet Browser

My Internet Browser #418

Coverage remained the same at 100.0% when pulling 9d014fe1ce1c2bbbfcccc00f0d7945995dff3f84 on ayumi-cloud:My-Internet-Browser- into 4899110cd2f87b01e04ced62dbb9dec541031dee on WhichBrowser:master.

Closing this as browser has been dead over 10 years and this package is not finding anything.


V0.2.0

Rewrite half of the code
Documentation improved,

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@566e9b9). Click here to learn what that means.
The diff coverage is 29.26%.

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage          ?   33.64%
=========================================
  Files             ?        8
  Lines             ?      217
  Branches          ?        0
=========================================
  Hits              ?       73
  Misses            ?      144
  Partials          ?        0

Impacted Files
Coverage Δ

src/special.jl
100% <ø> (ø)

src/chain.jl
0% <0%> (ø)

src/KnetLayers.jl
40% <100%> (ø)

src/loss.jl
56.52% <20%> (ø)

src/rnn.jl
15.84% <20.28%> (ø)

src/cnn.jl
31.81% <26.66%> (ø)

src/primitive.jl
52% <47.36%> (ø)

src/nonlinear.jl
68.18% <63.63%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566e9b9...609537c. Read the comment docs.

Codecov Report

Merging #10 into master will decrease coverage by 7.46%.
The diff coverage is 29.45%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   40.50%   33.03%   -7.47%
==========================================
  Files           8        8
  Lines         200      221      +21
==========================================
- Hits           81       73       -8
- Misses        119      148      +29

Impacted Files
Coverage Δ

src/chain.jl
0.00% <0.00%> (ø)

src/loss.jl
54.16% <16.66%> (+12.23%)
:arrow_up:

src/rnn.jl
15.84% <20.28%> (-8.61%)
:arrow_down:

src/cnn.jl
31.81% <26.66%> (-34.85%)
:arrow_down:

src/primitive.jl
52.00% <47.36%> (-9.12%)
:arrow_down:

src/nonlinear.jl
68.18% <63.63%> (+5.02%)
:arrow_up:

src/KnetLayers.jl
40.00% <100.00%> (+15.00%)
:arrow_up:

src/special.jl
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c8ac2...724dbdd. Read the comment docs.


Simple changes to appease Typescript

This PR addresses the issue of compilation errors I've found when running typescript v2.6.1 on the current master branch of this repository. I see the three errors addressed here when I try to build after I run npm i from npm v5.0.3 for node v8.0.0.
Problems Solved

Unused visibleChunksChanged in chunk_manager/backend.ts
Maybe null window in /webgl/shader.ts
Maybe null window in util/google_oauth2.ts
Output of new constructorFunction might not extend ChunkSource

I've just taken the simplest steps I could imagine to successfully compile the master branch.

I signed it!

One thing, I can remove the package-lock.json before someone accepts this PR.

Thanks for fixing these issues!  I am also committing a change that pins the typescript version (which I thought had already been done) in order to avoid this type of breakage in the future.


Add wrf version

I get a lof of questions on the LCZ labels, and related errors because of using a specific WRF version.
See example here: https://github.com/matthiasdemuzere/w2w/issues/122
So I worked towards a more structural solution, where the user is required to provide the wrf version as an argument.
Based on this argument, the required parameters are set using this dict:
    wrf_versions_dict = {
        'v4.3': {'ADD_LCZ_INT': 30, 'NUM_LAND_CAT': 41},
        'v4.3.1': {'ADD_LCZ_INT': 30, 'NUM_LAND_CAT': 41},
        'v4.3.2': {'ADD_LCZ_INT': 30, 'NUM_LAND_CAT': 41},
        'v4.3.3': {'ADD_LCZ_INT': 30, 'NUM_LAND_CAT': 41},
        'v4.4': {'ADD_LCZ_INT': 30, 'NUM_LAND_CAT': 41},
        'v4.4.1': {'ADD_LCZ_INT': 30, 'NUM_LAND_CAT': 41},
        'v4.4.2': {'ADD_LCZ_INT': 50, 'NUM_LAND_CAT': 61},
        'v4.5': {'ADD_LCZ_INT': 50, 'NUM_LAND_CAT': 61},
        'v4.5.1': {'ADD_LCZ_INT': 50, 'NUM_LAND_CAT': 61},
        'v4.5.2': {'ADD_LCZ_INT': 50, 'NUM_LAND_CAT': 61}
    }

I tested the code locally, from a W2W perspective using the sample data.
As far as I can see it seems to work.
@jkittner and @andreazonato: could you have a look?
Also:

@jkittner: could you check if the tests still work?
@andreazonato: perhaps you can check whether the produced outputs actually work in relevant versions? If this is considered needed?

Yes! Defininetely makes sense. Thanks @matthiasdemuzere !
I'l try it tomorrow

Thanks for reviewing @jkittner. I see now that all tests pass. That is great.
I have now also updated the README file to reflect the wrf version as a required argument.

I have now also updated the README file to reflect the wrf version as a required argument.

oh of course - I always forget about docs :rofl:

Also tested locally on my end with my custom data and v4.5.2, it works fine as well. Outputs look correct.

Hmmm the truth is that the new version doesn't calculate the NoUrban well, my guess is that it is looking for the previous categories. I'll need to fix that. It probably broke in previous versions, not this PR. I'll look at it.

Hmmm the truth is that the new version doesn't calculate the NoUrban well, my guess is that it is looking for the previous categories. I'll need to fix that. It probably broke in previous versions, not this PR. I'll look at it.

Mmmm, what is the LU_INDEX you are having in this file?

Mmmm, what is the LU_INDEX you are having in this file?

So the attribute ISURBAN still 13 despite the fact that urban areas are actually categories 50-60. This means that the code looks for LU_INDEX that matches ISURBAN and replace them, but there are none and the urban areas are still there with there original category in the range 50-60. I've got this fixed now and will commit to this PR once I've tested it.
However, the resulting file does not work with my setup in which I have 3 domains, a larger one and then 2 identical domains, except for the urban areas. The file with LCZ_params doesn't work either and it looks like its related to GREENFRAC

I've also fixed the issue with the GREENFRAC. The problem was that the urban areas were also identified with ISURBAN to replace GREENFRAC. Now it will check the number of categories and select urban areas including LCZ categories too.

Hi @dargueso, thanks for your feedback on this.
Thus far I did not consider the fact that users might feed W2W a geo_em file that already contains LCZ labels, numbered from 50-61, and derived from the MODIS-CGLC-LCZ dataset.
This makes things even more confusing.
What I'd like to suggest:

When launching W2W, it checks for the existence of LCZ labels 50..61

if yes, relabel these pixels to 13 => continue the tool (removing urban, adding LCZs, adding parameters, ...)

if no, continue the tool (removing urban, adding LCZs, adding parameters, ...)

This starts to become a bit of a circular behaviour, but at the moment I do not see another solution?
I briefly checked this with @andreazonato as wel, and he also thinks this is fine.
So, I can try to add this, and then hopefully you can test again (with a WRF version that understand labels 30..41 and labels 50..61)?
M.

I’ve done that already, it does something similar to what you suggest, except that those changes are implemented only where the code checks ISURBAN.
I can add the changes to your pull request, or create a new pull request, but I’m inheriting your pull request anyway because I built on it.
On 18 Mar 2024, at 14:53, Matthias Demuzere @.***> wrote:
Hi @darguesohttps://urldefense.com/v3/__https://github.com/dargueso__;!!D9dNQwwGXtA!SfYJ9mqClESjywhHvYKXq8q8HEOybxxNa10Lpy_YiYvG4Pcy3dj_mu3j-JbIuXgHSVfZ-efxEA8_rxy1P4stAuLJ$, thanks for your feedback on this.
Thus far I did not consider the fact that users might feed W2W a geo_em file that already contains LCZ labels, numbered from 50-61, and derived from the MODIS-CGLC-LCZ dataset.
This makes things even more confusing.
What I'd like to suggest:

When launching W2W, it checks for the existence of LCZ labels 50..61

if yes, relabel these pixels to 13 => continue the tool (removing urban, adding LCZs, adding parameters, ...)

if no, continue the tool (removing urban, adding LCZs, adding parameters, ...)

This starts to become a bit of a circular behaviour, but at the moment I do not see another solution?
I briefly checked this with @andreazonatohttps://urldefense.com/v3/__https://github.com/andreazonato__;!!D9dNQwwGXtA!SfYJ9mqClESjywhHvYKXq8q8HEOybxxNa10Lpy_YiYvG4Pcy3dj_mu3j-JbIuXgHSVfZ-efxEA8_rxy1PwSAnm5n$ as wel, and he also thinks this is fine.
So, I can try to add this, and then hopefully you can test again (with a WRF version that understand labels 30..41 and labels 50..61)?
M.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/matthiasdemuzere/w2w/pull/127*issuecomment-2003979333__;Iw!!D9dNQwwGXtA!SfYJ9mqClESjywhHvYKXq8q8HEOybxxNa10Lpy_YiYvG4Pcy3dj_mu3j-JbIuXgHSVfZ-efxEA8_rxy1P1ThzG_c$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABAA5Y6OXHB2ONLSMEWLWALYY3WXHAVCNFSM6AAAAABESJ2WD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBTHE3TSMZTGM__;!!D9dNQwwGXtA!SfYJ9mqClESjywhHvYKXq8q8HEOybxxNa10Lpy_YiYvG4Pcy3dj_mu3j-JbIuXgHSVfZ-efxEA8_rxy1P0mb9z_8$.
You are receiving this because you were mentioned.Message ID: @.***>

I’ve done that already, it does something similar to what you suggest, except that those changes are implemented only where the code checks ISURBAN.

I see. And is ISURBAN == True the same as LU_INDEX isin [50...61]?
Note that I am not sure what ISURBAN does? Is it used elsewhere in WRF? The reason I am asking is that I don't think W2W changes this layer, after implementing the new LCZ-based extent?
If your code does more or less what I suggested, then feel free to add it to this branch. Then I can have a look! Thanks!

ISURBAN is an attribute of the netCDF file and it is a number (13) not a boolean.
So if you check which grid points meet ISURBAN, in the new files with CGLC-MODIS, it will be none.
I will add my changes to the branch.
On 18 Mar 2024, at 15:22, Matthias Demuzere @.***> wrote:
I’ve done that already, it does something similar to what you suggest, except that those changes are implemented only where the code checks ISURBAN.
I see. And is ISURBAN == True the same as LU_INDEX isin [50...61]?
Note that I am not sure what ISURBAN does? Is it used elsewhere in WRF? The reason I am asking is that I don't think W2W changes this layer, after implementing the new LCZ-based extent?
If your code does more or less what I suggested, then feel free to add it to this branch. Then I can have a look! Thanks!
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/matthiasdemuzere/w2w/pull/127*issuecomment-2004054014__;Iw!!D9dNQwwGXtA!RTkum9YXmFWLue_g8e6pPytoF6s2jqDVPdIqSSBMAgY9clhqc6AXOnHejVJ-mqczdMGBUc7K0DH_D0PPamYBRYWK$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABAA5Y3KZG5K4HEJZ5LCCXDYY32CVAVCNFSM6AAAAABESJ2WD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGA2TIMBRGQ__;!!D9dNQwwGXtA!RTkum9YXmFWLue_g8e6pPytoF6s2jqDVPdIqSSBMAgY9clhqc6AXOnHejVJ-mqczdMGBUc7K0DH_D0PPalit7x7R$.
You are receiving this because you were mentioned.Message ID: @.***>

ISURBAN is an attribute of the netCDF file and it is a number (13) not a boolean. So if you check which grid points meet ISURBAN, in the new files with CGLC-MODIS, it will be none. I will add my changes to the branch. On 18 Mar 2024, at 15:22, Matthias Demuzere @.> wrote: I’ve done that already, it does something similar to what you suggest, except that those changes are implemented only where the code checks ISURBAN. I see. And is ISURBAN == True the same as LU_INDEX isin [50...61]? Note that I am not sure what ISURBAN does? Is it used elsewhere in WRF? The reason I am asking is that I don't think W2W changes this layer, after implementing the new LCZ-based extent? If your code does more or less what I suggested, then feel free to add it to this branch. Then I can have a look! Thanks! — Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/matthiasdemuzere/w2w/pull/127*issuecomment-2004054014__;Iw!!D9dNQwwGXtA!RTkum9YXmFWLue_g8e6pPytoF6s2jqDVPdIqSSBMAgY9clhqc6AXOnHejVJ-mqczdMGBUc7K0DH_D0PPamYBRYWK$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABAA5Y3KZG5K4HEJZ5LCCXDYY32CVAVCNFSM6AAAAABESJ2WD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGA2TIMBRGQ__;!!D9dNQwwGXtA!RTkum9YXmFWLue_g8e6pPytoF6s2jqDVPdIqSSBMAgY9clhqc6AXOnHejVJ-mqczdMGBUc7K0DH_D0PPalit7x7R$. You are receiving this because you were mentioned.Message ID: @.>

@dargueso: hold your horses! I was just thinking about an alternative strategy ... see email for follow-up!

Hi @andreazonato, @dargueso,
Here a quick summary of what we discussed at EGU24, including some tasks:
The enhancement of W2W is still an intermediate solution, to make sure it still works with WRF versions >= v4.4.2.
Andrea has been working on integrating W2W completely into WPS/WRF itself, a development that will hopefully be available in the next WRF release.
Until that time, users can use W2W in three different ways, depending on WRF version:
Case A (WRF < v4.4.2)

natural land use is the default MODIS map
LCZ information provided by the LCZ .tif file
LCZ information used with labels 40-51
set use_wudapt_lcz =1, so that also the LCZ parameter table will be used.

Case B (WRF >= v4.4.2)

B.1: geog_data_res = “default” (WPS namelist)

natural land use is the default MODIS map
LCZ information provided by the LCZ .tif file
LCZ information used with labels 50-61
set use_wudapt_lcz =1, so that also the LCZ parameter table will be used.

B.2: geog_data_res = “cglc_modis_lcz+default” (WPS namelist)

natural land use is the new CGLC-MODIS-LCZ map
LCZ extent is initially provided by CGLC-MODIS-LCZ. By using W2W, this LCZ extent will be overwritten by the LCZ extent provided in the .tif file. The use of W2W is still required in this case, as the cglc_modis_lcz product only adds the LCZ extent, and not yet the LCZ-based parameters required for WRF.
LCZ information used with labels 50-61
set use_wudapt_lcz =1, so that also the LCZ parameter table will be used.

Required steps to finalize this development:

[ ] @dargueso check if code works for the three use cases above
[ ] @andreazonato @dargueso @jkittner: anything missing/wrong in the above description of the use cases? I think the sentence "The use of W2W is still required in this case, as the cglc_modis_lcz product only adds the LCZ extent, and not yet the LCZ-based parameters required for WRF" is at the core of all of it, but I am not sure this is clear enough? Perhaps we should have a more extended paragraph to explain this?
[ ] @jkittner and @matthiasdemuzere: make sure tests align with new implementations
[ ] @matthiasdemuzere: document these changes, both in the repo README, and perhaps also in JOSS .pdf version?
[ ] @jkittner merge final changes in new major version and push to pypi

If something is not clear or missing, please report in this space!

I'm already testing that the code works for the three cases and that the generated files work with their respective WRF versions.
@andreazonato, I mentioned this before to you but it was never clear to me to what extent you're aware of the issue. If only a few LCZ are actually represented  in the input file (geo_em.d01.nc), WRF crashes. This is regardless of where the geo_em file comes from and it crashes even if the file is directly generated with WPS. For example, I've tested a domain in the Sahara desert to make sure there are no cities and I get this error message:
Climatological albedo is used instead of table values
INITIALIZE THREE Noah LSM RELATED TABLES
Skipping over LUTYPE = USGS
 LANDUSE TYPE = MODIFIED_IGBP_MODIS_NOAH FOUND          20  CATEGORIES
 INPUT SOIL TEXTURE CLASSIFICATION = STAS
 SOIL TEXTURE CLASSIFICATION = STAS FOUND          19  CATEGORIES
-------------- FATAL CALLED ---------------
USING URBPARM_LCZ.TBL WITH OLD 3 URBAN CLASSES. SET USE_WUDAPT_LCZ=0
-------------------------------------------
Abort(1) on node 0 (rank 0 in comm 0): application called MPI_Abort(MPI_COMM_WORLD, 1) - process 0

It is obviously not the purpose of this repo or this discussion because it is a more general issue, but it affects w2w users when using the domains with urban areas removed.  It is linked to this https://github.com/wrf-model/WRF/issues/1878 and this https://github.com/matthiasdemuzere/w2w/issues/125

Hi guys,
@matthiasdemuzere , thank you for summarizing. I do not think there are additional issues. Maybe we will still reply and help W2W users until the W2W is inside WRF ( I guess, end of the year, depending on the reviews on the paper)
@dargueso Yes, this issue does not depend on w2w. I discussed it with Cenlin He, and we actually did not come to a solution actually, since there is no variable to stick to put a flag and decide whether to use LCZ or not. I will try to reach him again and see if we can find a possibility to solve it.
Thank you for testing

I'm already testing that the code works for the three cases and that the generated files work with their respective WRF versions.

Thanks @dargueso. I hope all works?
When you are done, we can continue finalizing the last adjustments, including treatment of 11 BUILT_LCZs and  appropriate tests.
Also, @andreazonato mentioned the existence of a new matrix that was added, that contains, per pixel, the fraction of each LCZ label from the sub-grid scale information? I believe this variable should be added as a dummy, no? Should this be added only for WRF >= v4.4.2? @andreazonato ?

@matthiasdemuzere I think there is no need to add additional variables.
@dargueso  is simply taking advantage of this variable (LANDUSEF, B.2: geog_data_res = “cglc_modis_lcz+default”) , to derive the percentage of each LCZ, and therefore compute the average. So it is simply something in the pre-processing and there is no need to bring it to the simulation step.
@dargueso, correct me if I'm wrong

@matthiasdemuzere I think there is no need to add additional variables.
@dargueso is simply taking advantage of this variable (LANDUSEF, B.2: geog_data_res = “cglc_modis_lcz+default”) , to derive the percentage of each LCZ, and therefore compute the average. So it is simply something in the pre-processing and there is no need to bring it to the simulation step.
@dargueso, correct me if I'm wrong

@andreazonato, just to make sure I 100% understand.
At EGU you mentioned that, when users use “cglc_modis_lcz+default”, a matrix was added in geo_em, that contains the LCZ fractions for every pixel. Information that is then used within WRF to get the appropriate morphological parameters.
But this functionality will only become available when your new WRF version is released?
Until that time, this matrix variable is not needed / used?
I just want to avoid that, when users use their own LCZ map from the .tif, in reality LCZ information from "cglc_modis_lcz+default" is used within the model?

So I've tested most cases now. There are still issues with LANDUSEF that I need to figure out.  With use_wupdat_lcz = 1 we need to be extra careful because WRF may remove cities if LANDUSEF is not consistent with LU_INDEX. For example when using LCZ_extent.  I need to fix that, but I'm struggling with covering all possible cases.
Also, I would like to ask you what should we set LANDUSEF to. @andreazonato said it is useful to contain sub grid information, but do we really need to incorporate that information in LANDUSEF. Could I just set it to 1 for the corresponding LCZ category? Would that work?

Also, I would like to ask you what should we set LANDUSEF to. @andreazonato said it is useful to contain sub grid information, but do we really need to incorporate that information in LANDUSEF. Could I just set it to 1 for the corresponding LCZ category? Would that work?

That is exactly why I keep on asking about this.
I believe that in the new version of Andrea, this info is needed, for assigning urban parameters at the sub-grid scale, and then averaging them out at the grid scale.
This is what we do in W2W, for which LANDUSEF is not needed.
So I would think that, when users work with W2W and their own .tif, LANDUSEF is not used.
Once Andrea's version is out, and users have set geog_data_res = “cglc_modis_lcz+default”, then this info is required.
Correct @andreazonato?

Hi all, did you have the chance to look at the code? Is there anything else I should test from my side?
Dani

Hello @matthiasdemuzere  i am running W2W in WRFv 4.3 where i am getting this error. I am attaching the namelist.input file here too.
namelist_input.txt

Just to let you know: we've been using this branch in setting up our experiments recently. It runs without problems, although we haven't had a good look at the output yet. In any case, it would be great to see it merged at some point 👍

okay, I rebased this against the main branch and resolved a few dozen conflicts.
There is just one thing left before this is ready to go:
The test test_main_shanghai_data is failing because it only provides 20 categories, so it raises:
Number of land categories 20 in original file not supported. Only 21, 41 or 61 are supported.

Can someone check why this is the case? Have the test files been wrong all along or did we change/break behavior?
so just to make sure, this did work before this patch (see main branch).
I think then, finally, this would be ready to be merged and released to pypi.
After my rebase onto main, you will likely have to reset your branch using
git fetch --all
git reset --hard origin/add_wrf_version

otherwise you will have to resolve all these conflicts locally once again.

I think I can check the Shanghai case this week.  I also found geo_em files with 20 categories last month.

okay, I rebased this against the main branch and resolved a few dozen conflicts.
There is just one thing left before this is ready to go:
The test test_main_shanghai_data is failing because it only provides 20 categories, so it raises:
Number of land categories 20 in original file not supported. Only 21, 41 or 61 are supported.

Can someone check why this is the case? Have the test files been wrong all along or did we change/break behavior? so just to make sure, this did work before this patch (see main branch).
I think then, finally, this would be ready to be merged and released to pypi.
After my rebase onto main, you will likely have to reset your branch using
git fetch --all
git reset --hard origin/add_wrf_version

otherwise you will have to resolve all these conflicts locally once again.

This is really nice @jkittner, well done!
And thanks also @dargueso for looking into the Shanghai number of land use classes.
Perhaps another thing that should be done: add more information in the README on the various WRF versions, and how w2w relates to the automated use of the hybrid land cover datasets that already includes LCZs?
Is this description still valid? @andreazonato @dargueso?

Hi all,
I think that the problem of 20 categories is not linked to LCZ. It should be linked to the 21th category, that is LAKE. Maybe there are no lakes there, so 20 categories is still ok. Maybe we can avoid the failing putting 20 categories in the numbers allowed?
Andrea

That makes sense. It may also be the case that the user asks for input data without lakes. All the conditionals could be changed to num_cat_land is 20 or 21 whenever it says num_cat_land==21.
On 19 Sep 2024, at 10:20, andreazonato @.***> wrote:
Hi all,
I think that the problem of 20 categories is not linked to LCZ. It should be linked to the 21th category, that is LAKE. Maybe there are no lakes there, so 20 categories is still ok. Maybe we can avoid the failing putting 20 categories in the numbers allowed?
Andrea
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/matthiasdemuzere/w2w/pull/127*issuecomment-2360306547__;Iw!!D9dNQwwGXtA!WueCwoyw335LgjgklkKICz0d_WMzom_6A2VoXtxElsfY9fPdYF_YplHCW1G_gPqWZF2eoh8gx4Uukzf4N8ibkh1P$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABAA5YYXE4JNIKB4DIN3YXDZXKCM7AVCNFSM6AAAAABESJ2WD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRQGMYDMNJUG4__;!!D9dNQwwGXtA!WueCwoyw335LgjgklkKICz0d_WMzom_6A2VoXtxElsfY9fPdYF_YplHCW1G_gPqWZF2eoh8gx4Uukzf4N9rjPZst$.
You are receiving this because you were mentioned.Message ID: @.***>

I allowed 20 categories as well. Tests are now passing, but we reduced test coverage meaning we are not testing:

61 categories
an invalid file which has an incorrect number of land use classes

I attached the test coverage here:
htmlcov.zip
you can generate that by running tox -e py311 and after that coverage html.
Would be great if someone could add a test for that - could be similar to the test_main_shanghai_data test but with different files. If you want to test for an error, use with pytest.raises(ValueError) as excinfo and then check the excinfo to contain the correct message.


[Zoomable] New Zoomable composable

Fixes #266

Hi @Tlaster! Thanks for the PR. After thinking about this some more, I'm not sure that I want to include this layout in Accompanist. Accompanist's main goal is to provide key missing 'things', so that developers can continue to move to Compose.
I'm not sure that a zoomable layout is a high priority right now. Each library we add to Accompanist increases the maintainance, build, test and support burden.

Thanks! I might release Zoomable myself.
Accompanist give me many idea on how to release a control library correctly. Thanks for your great job!


Rename feature flag for evaluator fine-grained parallelism

There was a bug in the implementation of fine-grained parallelism in 2.14.x, making it unsafe to enable the feature flag. By renaming the feature flag, we can safely enable it without turning the feature on for people using 2.14.x and old versions of the Action.
Merge / deployment checklist

[ ] Confirm this change is backwards compatible with existing workflows.
[ ] Confirm the readme has been updated if necessary.
[ ] Confirm the changelog has been updated if necessary.

Marking ready for review, since we've now reached sufficient confidence in the feature to begin rolling it out for 2.15.1 onwards.


Register new payment methods in the documentation

Currently these payment methods are documented by @nihilist001 but not registered in mkdocs.yml to be published with the docs.

I'm learning mkdocs. Should the Payment Methods menu look like this?
Should we add all payments from @XMRZombi?

Yeah, we should add all payment methods.

The payment methods have been merged to master.

Side Menue works: https://boldsuck.github.io/haveno-docs/the-project/assets/#payment-methods-and-fiat-currencies
Links maeh: https://boldsuck.github.io/haveno-docs/the-project/payment_methods/F2F.md
All Payments: https://boldsuck.github.io/haveno-docs/the-project/payment-methods/A_all-methods/
Markup in all files still needs to be revised.

I think we can close this. Some are still missing eg: Moneygram
https://boldsuck.github.io/haveno-docs/the-project/payment_methods/0-all-methods/
Some help: https://en.bitcoin.it/wiki/Payment_methods


bubble sort in livescript

By the way, welcome to the Arcane Algorithm Archive! Thanks for the contribution.
What I think about your code is pretty much the same as what @Gustorn already said. If you make these changes, we can add it to the Archive no problem!
If you want, you can add your name at the end of the CONTRIBUTORS.md file as well. And since you're the first person to contribute livescript, you could do us a favor and add the language to book.json.

I will actually block this merge until the commit names are actually respectable. Not because I have any problem with you personally but because it sets a bad precedent. In case @leios or @Butt4cak3 wants to veto me, go ahead and I'll approve.

I would like better commit names as well. What they are like now, is horrible.

@Gustorn I won't stop you. This is a community project, so a certain willingness to cooperate should be expected.

It has been over a week and there was not a single sign of cooperation. So... @Gustorn, it's your call to do whatever you deem necessary.

Thank you for your contribution, unfortunately I don't think I can merge this in good conscience with the current commit names. Feel free to either message me here or open a new PR if you decide to follow the advice.


Adding "object_lock_configuration" variable

what
Adding "object_lock_configuration" variable which is used in module "cloudposse/s3-bucket/aws"
why
Must be able to use the Object Lock option for S3 in this module
references
https://github.com/cloudposse/terraform-aws-s3-bucket/blob/6837ed7b2f2460043d6be3981f16ed90563fd12a/main.tf#L5
https://github.com/cloudposse/terraform-aws-s3-log-storage/pull/84

/test all

please fix error @ramses999

/test all


WSOD due to breaking change in Exception Handler

A recent commit (526fbe0d3b1831488c427a50a1ef75afe2eb1dce) breaks the default exception handler that ships with Laravel (https://github.com/laravel/laravel/blob/master/app/Exceptions/Handler.php). It causes a WSOD and also stops Laravel/Monolog error logging.
The problem is that the \Exception typehint was removed from the report() method in Illuminate\Foundation\Exceptions\Handler. Because of this, the contract is broken by the default Handler (App\Exceptions\Handler) that ships with Laravel since it still typehints \Exception in report().
A simple fix (remove the typehint in the child class) but will cause anyone who updates or freshly installs to run into a WSOD when an exception occurs.

So if you remove the Exception typehint here it will be fixed?

@ArjanSchouten Yes, that's all that needs to be done to comply with the changes in the parent class.

Not breaking. That change was only made on laravel 5.2.

Yeh it's on Master I know. Although nice work from @tampadesign

Ok, yea -- my composer.json has "laravel/framework": "~5.0", so I got the 5.2 changes.
Thanks @ArjanSchouten and @GrahamCampbell

You know laravel 5.1 is stable and 5.2 dev?

Nobody should be using 5.2.

Ok, yea -- my composer.json has "laravel/framework": "~5.0"

VERY bad idea. Laravel does NOT follow semver.

5.1.* is what you want.

Gotcha, thanks!

This way you'll get feedback :smile:


Missing images in jumpstart "Deploy AKS cluster on Azure IoT Edge and connect it to Azure Arc using Terraform"

The last section of "Deploy AKS cluster on Azure IoT Edge and connect it to Azure Arc using Terraform" has a number of missing images:

and

Is your feature request related to a new Jumpstart scenario you would like to contribute?

Is your feature request related to a problem? Please describe.

Describe the solution you'd like.

Describe alternatives you've considered.

Additional context.

Hello @sandervandevelde
Thank you for using Jumpstart and flagging this. I am addressing this in a new PR

Thanks. Let me know when it's done.

Closed via #232


Get code from Code Flow (client request)

Excute me, can you show me exactly the link after click Allow from:

to get the code. I use WPF client and i try this code:

__
I plays the debug (of your code flow sample) and it shows code in ViewBag.Code but i don't know how it can return that code.
And where i can change this url "https://localhost:44303/callback" of Code Flow? I mean only text, example: http://abc.com/callback

I dont know why but today i can not upload image or edit comment here so i comment this:
__ I try:
private void WBrowser_OnNavigated(object sender, NavigationEventArgs e)
{
if (e.Uri.ToString().StartsWith("the-link-after-clicking-ALLOW")) //
{
// Is the-link-after-clicking-Allow https://localhost:44303/callback?code=... ?
// If yes, i'll try this:
CodeToken = e.Uri.Fragment.Split('?')[0].Replace("code=", "");
// ...
}
}

We don't do any active support anymore. Think of AS as a sample.


Strongly Sign the DotKEGG Assembly

Sign the main DotKEGG assembly with a .pfx file.

It's kind of a security hole to include a signing key in version control, but that's why we were going to include a .pfx file, which is password-protected, rather than a .snk file which is not.  However, this article still suggests that there is no security benefit to strongly signing an assembly, and all it does is make life difficult for developers that reference the assembly.  It sounds like strong-signing is only really for legacy environments, like COM, where it was required for uniquely identifying assembly versions.  The kicker for me was this commit on GitHub, where a Microsoft assembly had its strong-signing removed.  If Microsoft isn't doing it, then we probably shouldn't either.


Incorporate more complex family structures

KC and I think this probably doesn't apply to gnomAD production and is more related to RDG loading pipeline issues


TypeError: type object got multiple values for keyword argument 'log'

Hi everyone,
When i use Qira ./bin/ls i got this error
Ubunutu x64 bits on /bin/ls :
Traceback (most recent call last):   File "/home/reverse/qira-1.2/middleware/qira.py", line 104, in <module>     qira_webserver.run_server(args, program)   File "/home/reverse/qira-1.2/middleware/qira_webserver.py", line 437, in run_server     socketio.run(app, host=qira_config.HOST, port=qira_config.WEB_PORT, log=open("/dev/null", "w"))   File "/home/reverse/qira-1.2/venv/local/lib/python2.7/site-packages/flask_socketio/__init__.py", line 529, in run     log=log, **kwargs) TypeError: type object got multiple values for keyword argument 'log'

Thanks if somebody can help me ^^

Same here, ubuntu 17.04 x86-64, one week after installation, everything up to date.
The installation of qira ended without any errors.

Flask-SocketIO got an update (to 2.9.2) which obviously broke qira. You can simply downgrade this module.
Here is how I did it:
source <qira-dir>/venv/bin/activate
pip uninstall Flask-SocketIO
pip install Flask-SocketIO==2.9.1
deactivate
After that qira starts properly

Seems like requirements.txt should be updated to specify
flask-socketio==2.9.1


Is it something like:

Is it something like:
fail2ban-regex --out-action 'my-action[prm1="val1",...]' $log $filter

Or:
fail2ban-regex --out-tags $log $filter

Could you provide an example, just for better understanding, what do you mean with supply a function. E. g. something like the command-line you wish.
Originally posted by @sebres in https://github.com/fail2ban/fail2ban/issues/2036#issuecomment-361867203

Closing as this issue it out of context and doesn't appear to be related to Azure SDKs for Java.


Don't update moves_evaluated if exiting.

Would be a mostly pointless optimization but it does save 2 bytes.

Would be a mostly pointless optimization but it does save 2 bytes.

Agree, well 2 bytes is 2 bytes anyway


#1006 drop null'ed translation

Might require further testing (and require UnitTests).
Current state: hot-fixed null'ed translation for standard-storage type - including fallback-translation case.
Untested is the personal translation.
Likely to match all cases it would be best to abstract the removal to the adapter or maybe inject the removal at an earlier point of execution. The current approach however is minimal and does not touch fallback-translations behaviour.
May add a UnitTest in march (please remind me if needed).

There are two edge-cases:

unsetting the translation through $om->getRepository('Gedmo\\Translatable\\Entity\\Translation')->translate(..); is not handled (it currently fails!)
unsetting a translation might not trigger when the fallback-translation not set (or null) the UnitOfWork will consider the field unchanged and not trigger the listener

Considering the related issues it would seem that this is rather a feature-request to allow translation removal by language and the behaviour currently is not defined.
It is kind of  a problem that the troublesome exception is not documented otherwise it is not exactly documented that unsetting translations should work.

removing translation should be users responsibility, it is a part of general migration. Null if field is nullable is also a valid translation. this looks like a magic feature, which would just confuse people, cannot accept that.

@l3pp4rd Okay.
Null is not a feasible translation with ODM and the current handler as the field is dropped from the Translation-Collection (#1006).
Got confused when a customer made his app unreachable this way for one language and only realised removal (null-setting) is not intended after the pull-request was completed.
#1007 tries to implement the same logic by the way and is pending for some time.
Would a proper feature-pull-request for configurable on-null-remove be acceptable? It is somewhat hard to patch the listener without a full copy due its many private methods.
Or would a fix for the missing translation content field in ODM be better? Maybe I did look at it the wrong way altogether.
An undefined behaviour remains for the null-translation in regard to fallback-translations: should the value be 'null' or the fallback?

In this case add a listener which ensures that field is not nullable or removed. Extensions are mainly focused on ORM and different changes to ODM behavior won't be applied to satisfy 5% of users, they have enough options to prevent that.

create a listener and hook it before the translatable
remove every translation which is null. (you can read listener configuration easily)

Though, ODM does not support php 7 still, which also says the community is very fragile, I would not invest much into it. Using a tool like ODM in general looks a little off topic to me, sqlite is a way better database, which probably you do not yet scale anyway..

That is a definite response. Thanks!
I understand your point too well, if only I could decide the storage more often.


Add Hello World in Opa

For you web devs: https://en.wikipedia.org/wiki/Opa_(programming_language)

Sounds like a great idea! To be honest, I've never used Docker, but I get the idea. Be careful though 😉 you might be making a lot of work for yourself! Haha


IDK what is this error

Describe your bug here.
I was porting the Tabi mod and when I launch Genocide I got an error. And I don't think it's due to Lua (I don't use source code)
I've checked but there was the data, the song, the character, I haven't put the icon because I've changed the name of Berzerk Tabi's icon but otherwise I don't see any problem.
Here is a screenshot of the error

Hope the problem get fix in 0.6.2
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
I've ported Tabi, otherwise no. I've put Lua because I'm forced I don't have a choice.

show lua scripts

there is no lua script except for the stage but here it is
function onCreate()
makeLuaSprite('bg','youhavebeendestroyed',-500,-300);
addLuaSprite('bg',false);
makeLuaSprite('table', 'overlayingsticks', -510, -230);
addLuaSprite('table',false);
makeLuaSprite('thing','glowyfurniture',-500,-310);
addLuaSprite('thing',false);
makeLuaSprite('boomdead','boomdead',350,410);
addLuaSprite('boomdead',false);
end

your note texture xml is missing animations

i got the same error ngl

oh ok


Nick: Watch jointokyo.org

Nick requests the watch of the watch_keyword jointokyo\.org. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

jointokyo\.org has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


added new favicon

closes #75

make sure to reopen browser so it doesn't pick up old icon

Looks great!


CLI: implement the preflight checks

What this PR does / why we need it:
This PR implements a kubecarrier preflight command, and also enable the preflight checks in the kubecarier setup.
If you do kubectl kubecarrer preflight or kubectl kubecarrier setup, you can see the following output:
0.01s ✔  [preflight check] KubernetesVersion
0.04s ✔  [preflight check] CertManager

Currently, there are 2 preflight checks are implemented, one for checking the Kubernetes versions, and one for cert-manager.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related #53
Special notes for your reviewer:
Documentation:

Does this PR introduce a user-facing change?:

NONE

Two things:

[ ] preflight checks should be run before kubectl kubecarrier setup, that is as part of its functioning. Having a dedicated command for it...maybe.
[ ] This PR doesn't completely fix that issue, just implementing the basic minimum in our CLI

/retest

/retest

/retest


Raise exception in case categorical feature list doesn't have all string features

Description
All the rai insight components fail if any of the string features are not identified as categorical_features. This PR raises an UserConfigValidationException in such a scenario.
Checklist

[ ] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report

Merging #1720 (11bfb1d) into main (40108ea) will decrease coverage by 13.42%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1720       +/-   ##
===========================================
- Coverage   89.00%   75.58%   -13.43%
===========================================
  Files         105       10       -95
  Lines        5577      258     -5319
===========================================
- Hits         4964      195     -4769
+ Misses        613       63      -550

Flag
Coverage Δ

unittests
75.58% <ø> (-13.43%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...sibleai/responsibleai/rai_insights/rai_insights.py

...ranalysis/erroranalysis/analyzer/error_analyzer.py

responsibleai/responsibleai/_config/base_config.py

raiutils/raiutils/dataset/dataset.py

...ponsibleai/responsibleai/rai_insights/constants.py

...ai/responsibleai/_tools/causal/causal_constants.py

raiwidgets/raiwidgets/interfaces.py

...ibleai/responsibleai/managers/explainer_manager.py

responsibleai/responsibleai/__init__.py

raiutils/raiutils/common/retries.py

... and 85 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Equivalent of SamlConstants.HolderOfKey not present in NetCore

We are working on migrating our app from .NET Framework to .NET Core. In our app, certain flow uses SAML related code.
A snippet from the code is -
            SamlSubject subject = new SamlSubject(
                UpnUri,
                null, /* nameQualifier  */
                this.UPN, /* name */
                new string[] { SamlConstants.HolderOfKey }, /* confirmations */
                null, /* confirmationData  */
                proofKeyIdentifier /* securityKeyIdentifier */);

As seen from the above implementation, the SamlSubject (present in namespace System.IdentityModel.Tokens for .NET Framework) uses SamlConstants.HolderOfKey.
When moving to .NET Core, we found that the SamlConstants (present in namespace Microsoft.IdentityModel.Tokens.Saml) does not contains the constant for HolderOfKey.
We found that something similar is present in Saml2 namespace as -
Microsoft.IdentityModel.Tokens.Saml2.Saml2Constants.ConfirmationMethods.HolderOfKeyString.
We wanted to check if we can use this string from Saml2 inside SamlSubject? If not, what is the right way to get this constant for SamlSubject?
It looks like Saml2 constant might not be the right one because upon checking the value in .NET Framework, it has SAML:1.0 in the string, but the constant value for Saml2 contains SAML:2.0.
Please advise on what is the right way to proceed here.

@brentschmaltz can you please share your thoughts on this?


Change arguments of encode and decode functions

Codecov Report

Merging #5 (9386875) into master (0a188ba) will increase coverage by 0.39%.
The diff coverage is 86.07%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   89.49%   89.89%   +0.39%
==========================================
  Files           1        1
  Lines         238      287      +49
==========================================
+ Hits          213      258      +45
- Misses         25       29       +4

Flag
Coverage Δ

unittests
89.89% <86.07%> (+0.39%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/lyyjson.c
89.89% <86.07%> (+0.39%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a188ba...9386875. Read the comment docs.


How do you upgrade firmware?

Trying to use the latest version, it tells me I need to upgrade the firmware. Can't figure out how the command is supposed to work.
> fluxengine upgradefluxfile
Error: syntax: fe-upgradefluxfile <fluxfile>

> fluxengine upgradefluxfile FluxEngine.cydsn/CortexM3/ARM_GCC_541/Release/FluxEngine.hex
Error: database error: file is not a database

Sorry, that upgrades flux files to a new version of the client; to upgrade the board's firmware, you have to use the PSoC programmer tool (the same one you used to originally program the board).

Also, now I think of it, I didn't actually commit anything which would have upgraded the firmware version recently. If this happened via a PR and I didn't notice, then I'll need to build the new firmware and commit.

I was hoping to avoid having to use that awful PSoC tool again. I'm just trying to see if I can master some Victor 9000 disks from images I found online.
Not a recent commit that caused the need to upgrade that I'm aware of. I haven't messed with the fluxengine in a long time.
Error: your FluxEngine firmware is at version 8 but the client is for version 15; please upgrade


Create Page Types details page

I want to merge this change because...

PR intended to be tested with API branch:
Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Translated strings are extracted.
[ ] Number of API calls is optimized.
[ ] The changes are tested.
[ ] Data-test are added for new elements.
[ ] Type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

Task linked: SALEOR-1171 Add page type create/details view


Editor does not work: Cannot read property 'flattenLocaleTree' of undefined

In my VSCode installation (1.52.1) on macOS Catalina, the Editor does not show up in the sidebar. If I try to open it via the command bar, I get an error message:

I also don't see any inline i18n, but maybe that's because I still have to configure the plugin to understand my proprietary <T> tags which universe:i18n for Meteor uses.

Update: The editor appeared as soon as I placed a (still blank) i18n-ally-custom-framework.yml file under .vscode. It seems as if the plugin expects it to be in place?

Update: The editor appeared as soon as I placed a (still blank) i18n-ally-custom-framework.yml file under .vscode. It seems as if the plugin expects it to be in place?

Can you share a minimal reproduce of it? Thanks.

Can you share a minimal reproduce of it? Thanks.

I have the same issue.
Could fix it with @derwaldgeist solution, thanks 🙏

I have the same issue.
Could fix it with @derwaldgeist solution, thanks 🙏


test: write compilation failures to a log

Waiting on PlaceOS/driver-spec-runner#8
This change will render compilation failures as an uploaded artefact in the GH action pipeline

Closes #192


Configurable tweet text

Now, the tweets can differentiate what changed between both versions: the URL, the title and/or the summary.
For accomplish that, a new config is added
lang:
  change_in: "Change in"
  the_url: "the URL"
  the_title: "the title"
  and: "and"
  the_summary: "the summary"

Only if all the keys are defined in the lang dict inside the config.yaml then the tweet will include what's changed followed by the diff.url. The following are examples for the texts -in spanish with the old url, this PR will includes the new diff url-

Change in the title
Change in the summary
Change in the title and the summary

Also applies for URL changes, but I didn't see any event in real life yet.

@edsu this is ready to be reviewed/merged.

Sorry for the delay on this @nahuelhds -- this all looks good but I was wondering if by the_summary you actually mean the content of the page?

I assumed that the diff was done over the content given by the RSS feed. I
think it's not all the content inside the RSS, right? If that's not the
case, then maybe it actually is the content and not just the summary of it.
You know better than me here. Otherwise, I should check in deep later!
El mar., 5 may. 2020 a las 14:26, Ed Summers<EMAIL_ADDRESS>escribió:

Sorry for the delay on this @nahuelhds https://github.com/nahuelhds --
this all looks good but I was wondering if by the_summary you actually
mean the content of the page?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/DocNow/diffengine/pull/74#issuecomment-624195871, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOMLT74I5LGDROSCEBKSTDRQBD2XANCNFSM4MXZVXAQ
.

--
Nahuel Sotelo
Agile Developer
https://nahuelhds.dev

It is understandable that there is confusion about summary because the EntryVersion class uses a property named summary. The value of summary is actually not the text from the RSS feed, but text from the page itself, after the boilerplate of the page has been removed with Readability and had extraneous HTML removed with bleach. You can see the process here https://github.com/DocNow/diffengine/blob/master/diffengine/init.py#L166-L170
All that being said, maybe it's best to stick with summary since that is what Readability calls it, and its what is in the model. But I think the default string value should be "the page"?

Nice. I'll create an issue for that one!


[GUI] Duplicated items displayed in the sidebar of the main window

I have created one VM, but, for some reason, after reopening the app the sidebar displays two identical items:

Besides, if I click on an item, it is selected and immediately deselected. I can right-click on an item to display the contextual menu, however, and I can launch the VM, which appears to work normally. So, this seems just a GUI glitch. Any suggestions on how I can fix it?
Configuration

UTM Version: 3.1.5 (53)
OS Version: macOS 12.3.1
Apple Silicon

Ah, that has a consequence: I cannot open the VM configuration any longer. When I right-click and choose Edit the settings dialog opens and immediately closes.

Workaround: close UTM, move the VM image to a different folder, reopen UTM. Now the sidebar items have become symlinks, so they can be removed without deleting the VM. Close UTM, put the VM image back into its original folder, reopen UTM.

I would like to know how you got that to happen. If you can help me reproduce the issue, it can be fixed.

Unfortunately, I don't know. I have been adding and removing several VMs, then I noticed that. If I get to reproduce it again, I will certainly post how I get there.

Still happens from time to time when I clone a VM then rename the cloned VM. The original VM will occasionally show up twice with the same name, even though there's only one file.

Can you confirm that this is happening on 4.0.8?

Yes, this is still happening on 4.08 as of this afternoon.