[Event Request] Page 438 Issued Reminder

Can you expand the Event OnBeforePrintRecords with is Handled.
The same on Page 440 Issued Reminder List
    [IntegrationEvent(false, false)]
    local procedure OnBeforePrintRecords(IssuedReminderHeaderRec: Record "Issued Reminder Header"; var IssuedReminderHeaderToPrint: Record "Issued Reminder Header"; IsHandled: Boolean)
    begin
    end;

And insert the Event also on Action "Send by &Email"

            action("&Print")
            {
                ApplicationArea = Basic, Suite;
                Caption = '&Print';
                Ellipsis = true;
                Image = Print;
                Promoted = true;
                PromotedCategory = Category4;
                ToolTip = 'Prepare to print the document. A report request window for the document opens where you can specify what to include on the print-out.';

                trigger OnAction()
                var
                  IsHandled: Boolean:
                begin
                    IssuedReminderHeader := Rec;
                    IsHandled := false;
                    OnBeforePrintRecords(Rec, IssuedReminderHeader, IsHandled);
                    if IsHandled then exit;
                    CurrPage.SetSelectionFilter(IssuedReminderHeader);
                    IssuedReminderHeader.PrintRecords(true, false, false);
                end;
            }
            action("Send by &Email")
            {
                ApplicationArea = Basic, Suite;
                Caption = 'Send by &Email';
                Image = Email;
                Promoted = true;
                PromotedCategory = Process;
                ToolTip = 'Prepare to send the document by email. The Send Email window opens prefilled for the customer where you can add or change information before you send the email.';

                trigger OnAction()
                var
                  IsHandled: Boolean:
                begin
                    IssuedReminderHeader := Rec;
                    IsHandled := false;
                    OnBeforePrintRecords(Rec, IssuedReminderHeader, IsHandled);
                    if IsHandled then exit;
                    CurrPage.SetSelectionFilter(IssuedReminderHeader);
                    IssuedReminderHeader.PrintRecords(false, true, false);
                end;
            }

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


BodyPix error in p5.js instance mode

→ Description 📝

found a bug 🐛

Hi! Not sure if I should raise this issue here or in the library repo. The "BodyPix with Webcam" example doesn't work in p5.js instance mode–it throws ReferenceError: loadImage is not defined.
→ Screenshots 🖼

→ Helpful Information 🦄

Web browser and version Firefox version 67 and Chrome 74.
the ml5-examples branch you're using - release
Operating System macOS
Steps to reproduce the issue - add

 to the html and run the modified sketch below.
ml5 version you're using - 0.3.1

const s = (sketch) => {
    let bodypix;
    let video;
    let segmentation;
    let img;

    const options = {
        outputStride: 8, // 8, 16, or 32, default is 16
        segmentationThreshold: 0.3 // 0 - 1, defaults to 0.5
    }

    sketch.setup = function () {
        sketch.createCanvas(320, 240);

        // load up your video
        video = sketch.createCapture(sketch.VIDEO);
        video.size(sketch.width, sketch.height);
        // video.hide(); // Hide the video element, and just show the canvas
        bodypix = ml5.bodyPix(video, modelReady)
    }

    function modelReady() {
        console.log('ready!')
        bodypix.segment(gotResults, options)
    }

    function gotResults(err, result) {
        if (err) {
            console.log(err)
            return
        }
        // console.log(result);
        segmentation = result;

        sketch.background(0);
        sketch.image(video, 0, 0, sketch.width, sketch.height)
        sketch.image(segmentation.maskBackground, 0, 0, sketch.width, sketch.height)

        bodypix.segment(gotResults, options)
    }
}

let myp5 = new p5(s, document.getElementById('p5sketch'));

@nickmcintyre Hello!
Oh! Interesting. Thanks for flagging this. I haven't tested with p5 instance mode, but will try to give this a look soon. Let me know if you discover anything in the meantime. Thanks!

Hi @nickmcintyre - I just did a quick test and yes, my above hunch was correct. It seems that in our handy p5Utils of ml5 we need to directly target the browser's window object and the p5 instance living there.
in ml5-library/src/utils/p5Utils.js

// Load Image Async
const loadAsync = (url) => {
    return new Promise((resolve) => {
        window.p5.prototype.loadImage(url, (img) => {
            resolve(img);
        });
    });
};

I managed to get a quick version working with your helpful code.
The issue we will need to resolve is this error that is thrown by p5.

@nickmcintyre - I've made a PR to start the discussion here: https://github.com/ml5js/ml5-library/pull/481
We'll do our best to resolve this soon! Thanks again!

You rock @joeyklee! Thanks so much–can't wait to play around with the model further.

@nickmcintyre - Thanks! Looking forward to seeing your explorations!

This is fantastic @joeyklee! I've tinkered a bit with the development build in an existing project and it works well. A print dialogue occasionally opens on macOS but I'm not sure if it's due to ml5 or the surrounding components (React + Meteor)... I'll look into it.
Thanks man!

@nickmcintyre - Closing this up now. Thanks for reporting on this and testing!
@all-contributors please add @nickmcintyre for bug


setting hadolintPath using variable ${workspaceFolder} does not work

Describe the bug
A clear and concise description of what the bug is.
I use hadolint via a bash script that runs hadolint in a docker container and it is located inside my repository
Therefore I have my settings.json file set as "hadolint.hadolintPath": "${workspaceFolder}/scripts/hadolint.bash"
Then I get the error hadolint: Cannot find adolint from system $PATH, ....
If I set an absolute path in "hadolint.hadolintPath": "/the/path/to/scripts/hadolint.bash" then it works.
but that is very annoying for sharing the directory of course.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behaviour
using ${workspaceFolder} should resolve
Environment and version (please complete the following information):

hadolint: <replace with output of hadolint --version>
OS: <windows, macOS, linux, etc>. Please be specific, for Windows you may include build number, for Linux you may include distribution name.
ubuntu 22.04, latest vscode, latest hadolint/hadolint docker image

Hi! I'm getting the same error, although my use case is different.
Hadolint is installed as a binary in my devcontainer, and it's available in the PATH. I'm using the ${workspaceFolder} variable as part of the path to a workspace-specific Hadolint configuration. My configuration for the exiasr.hadolint extension is as follows:
"hadolint.cliOptions": [
  "--config",
  "${workspaceFolder}/config/lint/.hadolint.yaml"
]

With these settings, I get the following output:
[hadolint] hadolint: ${workspaceFolder}/config/lint/.hadolint.yaml: withBinaryFile: does not exist (No such file or directory)

If I use a fixed path for the configuration file option, hadolint works correctly:
"hadolint.cliOptions": [
  "--config",
  "/workspaces/workspace-name/config/lint/.hadolint.yaml"
]

In case it's helpful, here are some data points about the environment.
Environment and version (please complete the following information):

hadolint: Haskell Dockerfile Linter 2.12.0
OS: (linux) Debian 12
VS Code version: 1.92.2
exiasr.hadolint extension version: v1.1.2


feat(langchain): Add support for LangSmith and executing RunnableConfig for our Runnables

Overview
This PR introduces support for LangSmith and executing RunnableConfig for our Runnables, enhancing users' ability to trace, debug and monitor Guardrails and execute the Runnables with user defined configuration.
We have also introduced BaseRunnable to improve code reusability and maintain consistency across both Runnable implementations.
Guard Runnable
guard = Guard().use(CompetitorCheck(competitors=competitors_list, on_fail="fix"))
prompt = ChatPromptTemplate.from_template("Answer this question {question}")
output_parser = StrOutputParser()

chain = prompt | model | output_parser | guard.to_runnable()

result = chain.invoke({"question": "Tell me five Italian car companies?"})

Validator Runnable
regex_match = RegexMatch(
    "Ice cream", match_type="search", on_fail="refrain"
).to_runnable()
reading_time = ReadingTime(0.05, on_fail="refrain").to_runnable()
output_parser = StrOutputParser()

chain = prompt | model | regex_match | reading_time | output_parser
result = chain.invoke({"topic": topic})

@CalebCourier Fixed the tests. Could you please run (approve) the workflow?


Added backticks in a comment.

ObjectIdentifier refers to a specific Swift structure. To make this clear, I have added backticks around it's occurrence in a comment.

Awesome, thanks @marcusrossel! :+1:


What's going on here?

@NicolasDorier
/NTumbleBit.Common/TextFileConfiguration.cs
private void Add(string key, string value, bool sourcePriority)
{
	key = NormalizeKey(key);
	List<string> list;
	if(!_Args.TryGetValue(key, out list))
	{
		list = new List<string>();
		_Args.Add(key, list);
	}
	if(sourcePriority)
		list.Insert(0, value);
	else
		list.Add(value);
}

Seems like you are modifying a list that will be shortly garbage collected after.
Or does it actually modify the inside of the _Args dictionary?
If so could we add a _Args.AddOrReplace(key, list); at the end to be obvious?

Prefer keep it as is.


mirroredBoots with / on tmpfs build error:  Failed to get blkid info (returned 512) for / on tmpfs at /nix/store/-install-grub.pl line 202

Describe the bug
When using mirroredBoots with / on tmpfs, the following error occurs when building or rebuilding nixos:
...
evaluating file '/nix/var/nix/profiles/per-user/root/channels/nixos/pkgs/tools/misc/grub/2.0x.nix'
evaluating file '/nix/var/nix/profiles/per-user/root/channels/nixos/pkgs/development/tools/gnulib/default.nix'
updating GRUB 2 menu...
updating GRUB 2 menu...
updating GRUB 2 menu...
Failed to get blkid info (returned 512) for / on tmpfs at /nix/store/nvycxmg4g2q5jyqdxfvkgi95sqs48iw3-install-grub.pl line 202.
warning: error(s) occurred while switching to the new configuration

The build stops there.  However, the build is actually completed and Grub updated, so I can reboot into the new derivation.
This doesn't occur with a normal / on tmpfs installation, only / on tmpfs using mirroredBoots.
To Reproduce
Steps to reproduce the behavior:

Configure hardware-configuration.nix with / on tmpfs.
Configure configuration.nix and hardware-configuration.nix for mirroredBoots with two EFI boot partitions on different drives [1], [2]
nix-build or nix-rebuild (dry-build and dry-activate succeed with no error, only boot/switch/etc cause this error)

Expected behavior
Re/Build should complete as normal.
Additional context
It seems the problem is that blkid / returns nothing when / is on tmpfs.  Can verify this by calling blkid on the commandline.  However, this error does not occur on a normal, single-boot-partition / on tmpfs configuration, only when using mirroredBoots simultaneously with / on tmpfs.
configuration.nix (boot properties subset) and hardware-configuration.nix in this gist:  https://gist.github.com/byrongibson/ff2a6befdf53b94d9ea50fc8441fd35d
Full configuration.nix here:  https://github.com/byrongibson/nixos-setup/blob/main/config/configuration.tmpfsroot.zfscrypt.full.z11pa-d8.nix
Notify maintainers

@domenkozar
@teto
@xaverdh
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

system: "x86_64-linux"
host os: Linux 5.10.48, NixOS, 21.05.1408.9376bf7b342 (Okapi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.12
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

Update:  adding the following line to configuration.nix made no difference:
boot.extraModulePackages = [ config.boot.kernelPackages.nvidia_x11 ];

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/mirroredboots-with-on-tmpfs-build-error-failed-to-get-blkid-info-for-on-tmpfs-at-install-grub-pl/14065/1

There's a slightly updated build error now, says the same thing but with a bit more info:
...
evaluating file '/nix/store/xkjafds79w6s17nf0jkzdcfw09b1s2zj-nixos-21.05.3248.6120ac5cd20/nixos/pkgs/tools/misc/grub/2.0x.nix'
evaluating file '/nix/store/xkjafds79w6s17nf0jkzdcfw09b1s2zj-nixos-21.05.3248.6120ac5cd20/nixos/pkgs/development/tools/gnulib/default.nix'
updating GRUB 2 menu...
installing the GRUB 2 EFI boot loader into /boot1...
Installing for x86_64-efi platform.
/nix/store/8dkfnl4k7vjr5f88kbh389i61ympvrnd-grub-2.06/sbin/grub-install: warning: cannot open directory `/nix/store/8dkfnl4k7vjr5f88kbh389i61ympvrnd-grub-2.06/share/locale': No such file or directory.
Installation finished. No error reported.
updating GRUB 2 menu...
installing the GRUB 2 EFI boot loader into /boot2...
Installing for x86_64-efi platform.
/nix/store/8dkfnl4k7vjr5f88kbh389i61ympvrnd-grub-2.06/sbin/grub-install: warning: cannot open directory `/nix/store/8dkfnl4k7vjr5f88kbh389i61ympvrnd-grub-2.06/share/locale': No such file or directory.
Installation finished. No error reported.
updating GRUB 2 menu...
Failed to get blkid info (returned 512) for / on tmpfs at /nix/store/xh1sd9ms5b2ixhz61qqiz07j2b9xv4z9-install-grub.pl line 202.
warning: error(s) occurred while switching to the new configuration

It just happened to me with tmpfs on / but without mirroredBoots.

Thx, good to know it's a not a problem with mirroredboots then.  Fwiw I'm still getting this error on every rebuild, but it doesn't seem cause any actual problems in building or running the system, so I've just been ignoring it.

Oh, It's not happening anymore.
I'm installing NixOS from Debian recovery OS provided by my VPS provider.
So It's bit wonky anyway.
All nixos-install invocations have thrown that error but after rebooting the recovery it was working again. I might have mounted the partitions incorrectly  .

Related:  https://github.com/NixOS/nixpkgs/issues/94210#issue-668331547

This might have to do with the fact that you are specifying both boot.grub.device and boot.grub.mirroredBoots.*.devices. Remove the former.
Here is an excerpt from a nice well-behaved config I used just yesterday:
  boot = {
    loader.grub.enable = true;
    loader.grub.mirroredBoots = [{
      path = "/nix/boot";
      devices = [ "/dev/vda" ];
    }];
  };

Hold up, I just also noticed that you have both systemd-boot.enable = true; and grub.enable = true;. I don't think that's supposed happen.

Hold up, I just also noticed that you have both systemd-boot.enable = true; and grub.enable = true;. I don't think that's supposed happen.

Thanks, I do indeed have both those enabled in the example docs I linked.  However, I checked the ones I'm actually using to build the system and they have #systemd-boot.enable = true commented out.  Still same problem.  Need to update my examples.
From digging around on the internet, it seems this error occurs on other Linux's sometimes too, it's not just a NixOS thing.  Will keep digging and see what I can figure out.

This might have to do with the fact that you are specifying both boot.grub.device and boot.grub.mirroredBoots.*.devices. Remove the former.
Here is an excerpt from a nice well-behaved config I used just yesterday:
  boot = {
    loader.grub.enable = true;
    loader.grub.mirroredBoots = [{
      path = "/nix/boot";
      devices = [ "/dev/vda" ];
    }];
  };

Thanks for the example, but a question - how does mirroredBoots work with only one boot device specified?  For comprison, my mirroredBoots section is:
        mirroredBoots = [
          {
            devices = [ "nodev" ];
            path = "/boot1";
          }
          {
            devices = [ "nodev" ];
            path = "/boot2";
          }
        ];

mirroredBoots works with any number of devices. In the case of my config above, I just wanted to move the boot folder, and the mirroredBoots trick is cheaper than a bind mount.
So right, in your config you should not have boot.loader.device specified. mirroredBoots sort of makes that unnessecary. My suspicion is that it is trying to install in /boot1 and /boot2 because of mirroredBoots, and then also install in /boot dur to the extra device=, and since /boot is tmpfs, that breaks.

Oh man, you're exactly right.  I commented out boot.loader.device and it built perfectly with no errors.  Phew, thank you!  It's taken two years to solve this one, and solution was so simple.  Much appreciated!

So right, in your config you should not have boot.loader.device specified. mirroredBoots sort of makes that unnessecary. My suspicion is that it is trying to install in /boot1 and /boot2 because of mirroredBoots, and then also install in /boot dur to the extra device=, and since /boot is tmpfs, that breaks.

Oh man, you're exactly right.  I commented out boot.loader.device and it built perfectly with no errors.  Phew, thank you!  It's taken two years to solve this one, and solution was so simple.  Much appreciated!


ArtifactTransformation does not call builtBy from other project's artifact

Setup
One project p1 is registering an artifact and defining the task that builds it
e.g.
private fun Project.registerArtifacts() {
    artifacts.add(interopBundleConfiguration.name, buildInteropBundleKlib.map { it.archiveFile.get().asFile }) { artifact ->
        artifact.builtBy(buildInteropBundleKlib)
        artifact.type = INTEROP_BUNDLE_KLIB_ARTIFACT_TYPE
        artifact.extension = INTEROP_BUNDLE_CKLIB_FILE_EXTENSION
    }
}

Now another project p2 is adding p1 as dependency and registers some chain of ArtifactTransformations
e.g.
kotlin {
    sourceSets {
        getByName("commonMain").dependencies {
            implementation(project(":p1"))
        }
    }
}

Expected Behaviour
Running tasks relying on the "to transform" artifact will result in

built the original artifact
run all transformations
run the task

Actual Behaviour
The task specified using builtBy is not invoked.
The artifact transformation fails, because of a missing file.
e.g.
 What went wrong:
Could not determine the dependencies of task ':p2:compileNativeMainKotlinMetadata'.
> Could not resolve all artifacts for configuration ':p2:allSourceSetsCompileDependenciesMetadata'.
   > Failed to transform p1.cklib (project :p1) to match attributes {artifactType=org.jetbrains.kotlin.klib, commonizer-target=[linux_x64, macos_x64], org.gradle.usage=kotlin-api}.
      > Execution failed for UnzipTransform: /Users/sebastiansellmair/IdeaProjects/mpp-issue-bootstrap/p1/build/p1.cklib.
         > java.io.FileNotFoundException: /Users/sebastiansellmair/IdeaProjects/mpp-issue-bootstrap/p1/build/p1.cklib (No such file or directory)

Related:
https://discuss.gradle.org/t/artifact-builder-task-not-invoked-when-resolving-configuration/36077/2
https://partnerissuetracker.corp.google.com/issues/156530198

@sellmair Thank you for the bug report. Do you have a reproducer? builtBy should work for artifact transforms as well, so I wonder what is going wrong here.

Yes! You can check out
https://github.com/JetBrains/kotlin/tree/sellmair/kt-40975/commonize-user-defined-libraries
and install using gradlew install
After that, it can be reproduced in this sample project
https://github.com/sellmair/mpp-issue-bootstrap/tree/kt-40975
gradlew cNMKM will fail whereas gradlew mB will succeed!
I would be available on the JetBrains and Kotlin slack channels anytime to help you reproducing or answering further questions about this.

It looks like the transform is executed as part of resolving an artifact view which has not been added as an input to the task resolving it. In that case, Gradle cannot infer task dependencies. The only way to fix the problem is to declare the artifact view (or more precisely its files) as an input.

How do you sovle the problem finally ? @sellmair Thanks
And I find same question here http://<IP_ADDRESS>/61788634/gradle-artifacts-do-not-execute-the-builtby-task-when-the-configuration-is-resol

How do add actifactView as an input ? Could you give a demo ?  @wolfs  Thanks.


Update to ph-javacc-maven-plugin 4.1.4

This includes a change to the parser generator version.
Some links relevant to TokenMgrError vs TokenMgrException:
https://markmail.org/message/uc3e4jrkdj37zati
https://github.com/phax/ParserGeneratorCC/issues/7

Coverage increased (+0.05%) to 87.171% when pulling 12390b60890329560b1bb7219f8fdecec07b0d83 on csamak:master into 9d5cb5d13e06793877ea938f523a488f7d81bf92 on apache:master.


Simpler way to add new doctype

I use this package with C files which works well. I also work with plain configuration files for CNC machines which use .hal, .ini and .ngc files - all of these contain #TODO: comments but are not parsed because they are not of a recognised doctype. Request to make it simpler to add new doctypes.

I second this. I use .sql files and embed TODO in the comments, but files with the .sql extension don't seem to get parsed and there doesn't seem to be any way of including these file types? Or is there?
I'd have thought that by default ALL file types should be included unless specifically excluded via the .imdoneignore file or via the .imdone/config.json exclude filter.
Where exactly does it specify which file types should be parsed? Seems a bit magical unless you know exactly where to look.


Feign client timeout configuration (As in spring documentation) does not work

I try to configure feign client timeout to 5 seconds.
The application is just a simple demo app, and the configuration taken from official Spring documentation.
I configure it on application.yml, literally copy-paste the doc
feign:
  client:
    config:
      default:
        connectTimeout: 5000
        readTimeout: 5000
        loggerLevel: basic

But it does not works. Do I need to set something else?
I only use openfeign as dependency, no hystrix.
This happened on spring boot 2.2.2 with cloud Hoxton.RELEASE
I'm attaching my sample project below just in case you need them.
Thank you
demo.zip

I think you should create a server in your demo which would listen to the url:http://localhost:9047/payroll/api/master/asdasfas,and let it sleep 5000ms when it accept the connection ,do you think so? @timpamungkas


Message List doesn't scroll up on adding reaction

Currently, when we add a reaction to the bottom-most message in the list it doesn't automatically scroll up which is the ideal case. Only this much of the emoji is being displayed after being added w/o scrolling.
The list scrolls down when the emoji is removed though.

@zulipbot claim

Hello, @pulkonet have you able to figure it out? I am facing the same issue in Android, iOS is working fine

I wonder if this #3302 does not fix this issue too.

This looks potentially related to #3301 and/or #3264 -- meaning, a good solution to any one of them might also end up fixing others.

(Also: thanks @pulkonet for the report!)

Reproduces in v25.5.119 (on Android 9). The fix for #3264, in #3268, turned out to be pretty unrelated.
Still seems quite similar to #3301, though, and #3301 and this issue might have a single fix.

@zulipbot claim


Update publish-docs to operate on main and on branches prefixed with docs-v

Signed-off-by: Stephen Curran<EMAIL_ADDRESS>

@WadeBarnes -- check it out.  Should:

publish docs for any created branches or tags ("on", "create")
publish docs for pushes to branches that start with "docs-v" or main
if the pushed or created tag / branch is not "main" or has a "v-docs" prefix, exit happily.
otherwise, normal flow for mike (versioning support) and mkdocs

Looks like it should work.  Could add the - docs-v* filter to the on create?

I had just added the GHA extension to VS-Code when I did this. Turns out that create doesn’t support branches.  I think early versions might have (found a reference on the internet that it did), but the extension flagged it as an error and when I checked the GHA docs, it doesn’t take any parameters.


Save state of NVMe device(s) during servicing

This is a part of a bigger NVMe-keepalive feature. Since the feature became too big and still has some external dependencies, it was decided to start merging it using smaller chunks to simplify the understanding of the code path and also to prevent merge conflicts.
Added dummy restore functions to suppress compiler warnings, these will be updated in next stages.
On the test PC with single NVMe controller and 4 I/O queue pairs, the time to save is ~150us (total ~480us).

Closing - to be reopened since target went public.


Menu not showing all the tabs when editing .odt and .doc

Hi,
I successfully installed OnlyOffice document server, however, while I am able to see the full menu when editing a .docx file (changing the styles of the text and so on), I am only able to see "File" and "Plugin" tab when editing .doc or .odt files.
.doc and .odt are flagged in the "The default application for opening the format" setting.
If I flag .odt in the  Open the file for editing (due to format restrictions, the data might be lost when saving to the formats from the list below) I am also able to see the tabs when editing an .odt file but still missing for .doc.
Am I missing something?
Any help would be greatly appreciated!

Hello, @tubia,
in the list of settings 'Open the file for editing...' there is no .doc. It means .doc file can not be open for edit by default.


adds lower case containerd to the list of authors

The group wants to use "The containerd Authors" see https://github.com/containerd/containerd/pull/2108
IMO both containerd and Containerd seek to cover the same group from a copyright perspective.. so for the purpose of boilerplate verification I at least want to make sure we support the all lower case option. If desired I can sed through the files, remove "Containerd" and force "The containerd Authors" but for now I'd rather just support both in boilerplate verify.
Signed-off-by: Mike Brown<EMAIL_ADDRESS>

/lgtm


made header responsive

you will find header in components/page-header.tsx

I want to work on it, can you please assign this to me?

https://github.com/rahulsainlll/git-trace/pull/5 @rahulsainlll Please review

https://github.com/rahulsainlll/git-trace/pull/5 @rahulsainlll Please review

Sure sir


Replace depricated gulp-util

gulp-util has been deprecated. Continuing to use this dependency may prevent the use version 4 of Gulp.
See:

https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
https://github.com/gulpjs/gulp-util/issues/143

Pulled, ran locally, seems to work - @prog1dev are there any particular steps I should take to test and confirm this change?

@coopr Its a pretty straight forward change based on links in desc so everything should be ok


can light-switch x 1pc control lighting-app x 2pcs?

Reproduction steps
# all clusters are power off
# power on lighting-app 1
./chip-tool pairing ble-wifi 12344321 $SSID $PASS 20202021 3840

# power on lighting-app 2
./chip-tool pairing ble-wifi 12345678 $SSID $PASS 20202021 3840

# power on light-switch
./chip-tool pairing ble-wifi 43211234 $SSID $PASS 20202021 3840

./chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233], "targets": null },{"fabricIndex": 1, "privilege": 3, "authMode": 2, "subjects": [43211234], "targets": null }]' 12344321 0

./chip-tool binding write binding '[{"fabricIndex": 1, "node":12344321, "endpoint":1, "cluster":6}]' 43211234 1

./chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233], "targets": null },{"fabricIndex": 1, "privilege": 3, "authMode": 2, "subjects": [43211234], "targets": null }]' 12345678 0

./chip-tool binding write binding '[{"fabricIndex": 1, "node":12345678, "endpoint":1, "cluster":6}]' 43211234 1

Bug prevalence
everytime
GitHub hash of the SDK that was being used
commit 3897c9b12f4f16a8ad6bf73aa8f8d2272b60124a (HEAD -> v1.0-branch, origin/v1.0-branch)
Platform
esp32
Platform Version(s)
No response
Anything else?
43211234 could control only 12345678.
12344321 did not change LED on / off.
can 1pc light-switch-app control 2pcs lighting-app at the same time?
Environment
OS : ubuntu 20.04
ESP-IDF : v4.4.1
Module : ESP32-C3-devKitM-1 3pcs

You want:
./chip-tool binding write binding '[{"node":12344321, "endpoint":1, "cluster":6}, {"node":12345678, "endpoint":1, "cluster":6}]' 43211234 1

to set up bindings to both lighting-app instances.  The commands above bind to one thing, then overwrite with a binding to the other thing, but you want to be bound to both, so should just bind to both....


Removals

Remove link from author byline on posts.

Changes

Get rid of the authors filter and replace it with a languages filter.

How to test this PR

Pull branch and run a local server.
Language filter should appear and be functional on any filter with a Topics filter:

http://localhost:8000/activity-log/
http://localhost:8000/about-us/newsroom/
http://localhost:8000/about-us/blog/
http://localhost:8000/administrative-adjudication-proceedings/administrative-adjudication-docket/
http://localhost:8000/compliance/supervisory-guidance/
http://localhost:8000/data-research/research-reports/
http://localhost:8000/rules-policy/final-rules/
http://localhost:8000/consumer-tools/everyone-has-a-story/
http://localhost:8000/rules-policy/rules-under-development/
http://localhost:8000/data-research/cfpb-researchers/
http://localhost:8000/consumer-tools/credit-reports-and-scores/consumer-reporting-companies/companies-list/
http://localhost:8000/about-us/events/
http://localhost:8000/rules-policy/notice-opportunities-comment/open-notices/
http://localhost:8000/rules-policy/notice-opportunities-comment/archive-closed/
http://localhost:8000/compliance/amicus/briefs/
http://localhost:8000/about-us/events/archive-past-events/
Screenshots

Holding as we need to restrict this to certain filters and which is yet to be determined.

This filter should appear only on these pages:
https://www.consumerfinance.gov/activity-log/
https://www.consumerfinance.gov/about-us/newsroom/
https://www.consumerfinance.gov/about-us/blog/
However, we'll turn it off the others after deploy.


broken with react-native 0.12 & 0.13?

To reproduce:

react-native init AwesomeProject
replace AwesomeProject#render with return <WebView style={{flex:1}} html="
Hi
" />;
run the project and notice it works
install react-native-webview-bridge as per instructions
run the project and notice the blank screen you get
npm install<EMAIL_ADDRESS>run the project and notice that it works

Notice that it's WebView that's broken, which is really surprising.  Using WebViewBridge with or without injecting the bridge script doesn't help.

Same here. Considering reverting to 0.11.4 if Ali is too busy to address.

+1

I am extremely sorry, I've been very busy. I will address this issue ASAP. I will also accept PRs :+1:  if you guys can help me out!

@NoelBaron  @bryanlarsen
I was able to fix with this quick change: https://github.com/jjshammas/react-native-webview-bridge/commit/7c1cc248289a668300db119d077c2d80039e76be
But I'm not using the bridge very extensively in my project, so give it a shot. If it seems to be working for you guys as well, this may be the solution.

It solved the loading issue for me, but for some reason I cannot access WebViewBridge from the remote website's javascript. It looks like the injection fails.

@NoelBaron I was able to get it working on React Native 0.13 by converting webview-bridge-script.js into a minified JS string, and then manually retrieve the handlerId using:
var webviewRef = this.refs[WEBVIEW_REF];
webviewRef.getWebViewBridgeHandler(function (handlerId) {
    // inject JS
});

Finally, you can use your the injectedJavaScript property on the WebView to manually inject the JS without having to touch any Objective-C code.

@rick-li appears to have a fix in #32

OK guys, thanks to @rick-li, it is now fully functional in latest react-native. One other thing is, I have moved all the files into proper xcodeproj. You just have to add it to your project and make sure you to add to your Link Binary With Libraries project. I will update the Readme.


Add " Interface IP" display capability + More modern CSS style

Summary
This pull request enhances the tcgui project by adding the capability to display the IP addresses of each interface and updating the CSS to a more modern style.
Changes

Interface IP Display:

Modified the Flask application to fetch and display IP addresses alongside interface names.
Updated the HTML templates to incorporate IP addresses next to interface names in all relevant sections.

CSS Update:

Updated the CSS to improve the visual style, making it more modern and user-friendly.

Benefits

Enhanced Usability: Users can now easily see the IP addresses of each network interface directly in the web UI, improving the usability and convenience of the tool.
Modern Look: The updated CSS provides a cleaner and more modern look, enhancing the overall user experience.

Screenshots
Before:

After:

Testing

Verified that the IP addresses are correctly fetched and displayed for each interface.
Confirmed that the updated CSS renders correctly across various browsers.

Oh wow, I use TC and I really like the new design

Changes were applied, let me know what you think :)

@benjisho regarding the last rollback, could you try subprocess.run. see https://stackoverflow.com/a/39187984 as a reference. It looks like we mainly care about running the command and getting the output back.

I have replaced subprocess.Popen with subprocess.run for retrieving IP addresses and also decided to add a bit error handling to it, please let me know what you think

Looks good to me. Almost ready to merge. Let's just replace the old image with the new one. No need to keep the old image.

seems that CI is now failing because isort packege

I can take a look on Monday.
If you want to take some action, you could create a separate PR where you do a pre-commit autoupdate and then pre-commit run -a and commit these changes. If you encounter some failures it might be because Python 3.8 is no longer supported by the most recent hooks. So we might have to update to Python 3.10.

@hofbi Seems tha CI is failing due to pre-commit update of package pyupgrade
The new version of pyupgrade is requiring the user to use python version 3.9 or above, while ci.yml is using python 3.8.
Can we ignore the issue? or shall we change the ci.yml to use python 3.9 or above?

To finally get this PR merged, I suggest we downgrade pyupgrade to 3.16 which is the last version supporting python 3.8
Upgrading the entire thing would be a follow up PR. Here we could add support for Ubuntu 22.04 by switching to Python 3.10.


Increase the assume-role MFA expiry time to 8 hours (28800 seconds)

AWS recently increased the assume-role session token expiry time to a
maximum of 12 hours. This makes our sessions last for eight hours, the
length of the working day, to avoid having to re-assume role multiple
times a day.
This will revert the changes I made in
https://github.com/alphagov/govuk-aws/pull/498, and I'll have to
change the docs again, but it makes it simpler in the long run - you
only have to remember an assume-role command, not also
get-session-token.

(I'll test this in the test account first.)

That PR has been merged now, so I've implemented this in the correct way (hopefully). I'll test it in the test account and see if it works.

That appears to have been the correct setting. I did an apply in the test account and both govuk-users and govuk-administrators roles are coming up as:

Applied in all environments. Merging.


Cant enable the plugin...

Describe the bug
When I try to enable the plugin the engine just shows a popup that says:
"Unable to load addon script from path: 'res://addons/TerrainPlugin/TerrainPlugin.cs'. This might be due to a code error in that script.
Disabling the addon at 'res://addons/TerrainPlugin/plugin.cfg' to prevent further errors."
Desktop (please complete the following information):

OS: Windows 10
Engine: Godot 4.0
Version of the plugin: 1.0

Same here

same on MacOS

Thank you, There is probably another C# Code change in latest release of Godot 4. I try to fix it as soon as possible. Or maybe sboron does.

Same issue for me.

If possible please try pull #26 and see if that is working until @sboron merged it and made a new release.

The pull also does not work for me.

OS: Windows 11 Home 22H2
Godot V4.0.1-stable

Make sure you renamed the folder to TerrainPlugin and that all the files aren't in a second folder in that folder when you add it to the addons folder if it didn't work for you. Like addons/TerrainPlugin/a bunch of files
(Like in this zip: https://mega.nz/file/oZghUQZD#wylq9BFmAjjSz5KY2HZTaXtc1dK5HtkLRYDNlHsfpvM)

Same

Same for me as well

Make sure you've also Built the project or else the plugin won't work.

The build icon may not show up until you add a c# script to something in the project.

Can you maybe provide more details?

Sure. I see you haven't added any nodes to your project. Try adding one,

adding a script to it (right click and attach script)

Make sure it is a C# script

(Click load)

A build icon should then appear in the top right corner. Once you click it, the project should be built.
(More information here: https://docs.godotengine.org/en/stable/tutorials/scripting/c_sharp/c_sharp_basics.html)

Thank you so much. It works 😎
On Sat, 8 Apr 2023 at 23:02, furtherorbit @.***> wrote:

Sure. I see you haven't added any nodes to your project. Try adding one,
[image: image]
https://user-images.githubusercontent.com/61303866/230742310-c61daa99-b451-4805-933e-eec1d143fa06.png
adding a script to it (right click and attach script)
[image: image]
https://user-images.githubusercontent.com/61303866/230742330-67e2a618-5bbe-4ad0-8828-e88c42b3e813.png
Make sure it is a C# script
[image: image]
https://user-images.githubusercontent.com/61303866/230742341-72de0693-a4e6-4327-93a8-d9b957c9fe5c.png
(Click load)
[image: image]
https://user-images.githubusercontent.com/61303866/230742379-1886b514-3cc9-4c8d-b40d-2dccddffd631.png
A build icon should then appear in the top right corner. Once you click
it, the project should be built.
(More information here:
https://docs.godotengine.org/en/stable/tutorials/scripting/c_sharp/c_sharp_basics.html
)
—
Reply to this email directly, view it on GitHub
https://github.com/sboron/terrain-tool-godot4/issues/25#issuecomment-1500977371,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADBMVL64LZ6XRTLF77ILHBTXAHG7LANCNFSM6AAAAAAVNYGFMQ
.
You are receiving this because you commented.Message ID:
@.***>

Now I receive the following errors when trying to generate terrain:
scene/resources/resource_format_text.cpp:448 - res://addons/TerrainPlugin/Shader/TerrainVisualShader.tres:25 - ext_resource, invalid UID: uid://dly1js17gm0s5 - using text path instead: res://Terrain/Heightmaps/canyon01.png
Resource file not found: res://Terrain/Heightmaps/canyon01.png.
scene/resources/resource_format_text.cpp:174 - res://addons/TerrainPlugin/Shader/TerrainVisualShader.tres:896 - Parse Error: [ext_resource] referenced non-loaded resource at: res://Terrain/Heightmaps/canyon01.png
scene/resources/resource_format_text.cpp:735 - res://addons/TerrainPlugin/Shader/TerrainVisualShader.tres:896 - Parse Error: [ext_resource] referenced non-loaded resource at: res://Terrain/Heightmaps/canyon01.png
Failed loading resource: res://addons/TerrainPlugin/Shader/TerrainVisualShader.tres. Make sure resources have been imported by opening the project in the editor at least once.
Error loading resource: 'res://addons/TerrainPlugin/Shader/TerrainVisualShader.tres'.
modules/mono/glue/runtime_interop.cpp:1303 - System.NullReferenceException: Object reference not set to an instance of an object.
at TerrainEditor.TerrainPlugin.generateTerrain() in E:\Godot v4.0 stable\Projects\Projects2\addons\TerrainPlugin\TerrainPlugin.cs:line 655
at TerrainEditor.TerrainPlugin.InvokeGodotClassMethod(godot_string_name& method, NativeVariantPtrArgs args, godot_variant& ret) in E:\Godot v4.0 stable\Projects\Projects2\Godot.SourceGenerators\Godot.SourceGenerators.ScriptMethodsGenerator\TerrainEditor.TerrainPlugin_ScriptMethods.generated.cs:line 201
at Godot.Bridge.CSharpInstanceBridge.Call(IntPtr godotObjectGCHandle, godot_string_name* method, godot_variant** args, Int32 argCount, godot_variant_call_error* refCallError, godot_variant* ret) in /root/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/Bridge/CSharpInstanceBridge.cs:line 24

After creating the following folder res://Terrain/Heightmaps/ and adding a png image called canyon01.png it works, I'm now able to generate terain and sculpt.

I was having issues with this too. I'm very new to the godot eco-system, so there were several things I had to learn to get this working. This is what got things working for me, starting with the alpha branch @ 0440df7f120477bad5e5b0822a97638e2e8a26e7

Follow the guide here to make sure you have the .NET prereqs and the .NET version of godot installed.
Add a c# script and trigger a build, as mentioned above.
I got the same error mentioned above, but fixed it by removing that line from the TerrainVisualShader.tres file.

The first issue was just me getting up to speed.
I agree that the second issue should potentially be documented somewhere in the godot plugin documentation? Or perhaps, is this related to the "Needs a master godot 4 build with mono!" heading in the root readme?
I will open a PR soon for removing the line from the TerrainVisualShader, as it appears to be an artifact of some local work.

I copied parts of spockNinjas answer into our General Getting Started guide: https://github.com/sboron/terrain-tool-godot4/wiki/getting-started . Also there is finally a wiki now.
Thank you for that contribution.
I close this Ticket now.


[BUG] Failed to fetch memo list

method=GET uri=/api/v1/memo?creatorUsername=***&rowStatus=NORMAL&limit=20 status=500 error=code=500, message=Failed to fetch memo list, internal=SQL logic error: no such column: resource.memo_id (1)

built from source code with latest commit c54febd024c7ec8a37a358c3b07c1c1bbd88a79c

The main branch is under development and not for production. If you still want to use it, you should run memo in dev mode instead of prod.


added jenkins job for Ironic+HA

 (5) S60P2 Test automation - virtual infrastructure for Ironic

requires #1923


⚠ Processors has degraded performance

In 4fc0d27, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 48 ms

Resolved: Processors performance has improved in d290403.


BarrierColor in the Theme

Proposal
Add showModalBottomSheet.barrierColor and equivalents to the Theme.
Currently, this defaults to Colors.black54.

Hi @TheCarpetMerchant
Could you please describe the proposal in detail as listed in the  feature request issue template?

Issue Template (Proposal)
<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill out the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case

<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe the alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->

## Proposal

<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching something showing what you are imagining:
      * images
      * videos
      * code samples

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->

Thank you!

@huycozy Ok, but what I've written is completely useless, there isn't anything to say about this proposal...

@TheCarpetMerchant, thanks for the update.
But please correct me if I'm wrong. You propose showModalBottomSheet being able to change the barrierColor while it is showing (maybe you have a theme selection function on the bottom sheet)?

@huycozy No, I'm proposing the barrierColor be integrated into the Theme widget.
A side-effect of this happens to be the rebuilding of the bottom sheet if the theme is updated using Provider.

@hangyujin - sounds like this should be part of the bottom sheet M3 migration project

We will see
On Thu, Sep 22, 2022 at 12:31 PM Hans Muller @.***>
wrote:

@hangyujin https://github.com/hangyujin - sounds like this should be
part of the bottom sheet M3 migration project
—
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/111688#issuecomment-1255269477,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3GVZIW5ZCXLUNI2RGJXWJ3V7SCU5ANCNFSM6AAAAAAQNWXO2E
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Support GitLab & Bitbucket

It would be nice to have support for gitea (or the gogs, the fork it inherited from) and/or gitlab.
Or, what would be even better because both are open source, even integrate github-history in them.

I'll try to add support for gitlab and bigbucket. Not sure about the APIs from other providers, but you can always use the CLI locally.

Looking forward to Bitbucket support!

If anyone want to test GitLab support, use gitlab subdomain instead of github:
https://gitlab.githistory.xyz/inkscape/inkscape/blob/master/src/document-undo.h

Bitbucket should work too:
https://bitbucket.githistory.xyz/pomber/code-surfer/src/master/packages/mdx-deck-code-surfer/package.json
I still need to figure out why private repos sometimes fail.

This is awesome, any plan for self-hosted gitlab?

support coding.net

@QGB I'm not familiar with coding.net, but if anyone open a PR for it I'll merge it.


Added a note for nested virtualization support

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes  https://github.com/openshift/hypershift/issues/1735
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[x] This change includes docs.
[ ] This change includes unit tests.

thanks @ksingh7, are you planning to address @davidvossel comments or should we close this for now?

thanks @ksingh7! I'm closing due to inactivity, please reopen addressing David comments if still interested in helping out to improve this.


Accept AsRef filename arguments. (#20)

Generalize filename: &str arguments to filename: P where P: AsRef<Path>. See #20.

It looks like there's a problem with the CI settings.

Thank you!


Clickable Columns - Clicking Invalid URL

The clickable columns block sends visitors to the preview URL instead of a relative one.

@bstopp This issue is not reproducible. I am closing this as of now.
Feel free to reopen.


In-memory outbox behavior changed for batch consumers from 7.0.6 to 7.0.7

Context:
We use a unit of work filter to do 2 things:

handle domain events (which generally publish integration messages)
commit db transaction

For this, we relied on the outbox to only publish outgoing messages once the db is updated.
This used to work correctly before 7.0.7.
With the latest verion, the outbox is ignored and the messages are published (and handled) immediately.
I put togheter a reproduction here https://github.com/gschuager/MassTransitBatchTest/tree/uow/MassTransitTest
Output log for each versions is as follows:

Looking at the pipeline configuration I see the following differences:

The mentioned UnitOfWorkFilter works correctly for non-batching consumers.
Also, messages published directly from the consumer correctly respect the outbox, the problem is only present when publishing message from the filter.
I'm not sure if this is a MT issue or there is something wrong with the way I'm hooking the UoW filter into the pipeline.

So it isn't adding the outbox? I'll have a look at the test batch test and see what's up.

The outbox was previously added at 2 different places, but now it is gone from one of those.
The reproduction is in the uow branch.

That's what I wondered, there was a null configurator passed to an observer previously, and that was removed. I'm guessing that the change has put a single outbox at another point in the pipeline. Can you attach a Gist of the entire consume pipe for the receive endpoint?

https://gist.github.com/gschuager/79efba2a127fa9bcf2dc2b594704d203

So, the outbox is there, and it's only on the batch. It would seem that your UoW would need to get registered after the outbox. How is your UoW filter being added? Is that in the example?

https://github.com/MassTransit/MassTransit/blob/develop/src/MassTransit/Configuration/PipeConfigurators/InMemoryOutboxConfigurationObserver.cs
I'm thinking this is the issue, but I'll try to test with your sample.

Changed files and order is correct: https://gist.github.com/phatboyg/9d814ec52e6513de06faec1cd84a6f4b

I'm trying to understand to understand what did you do...
Anyway, with those changes alone, it doesn't work as expected for me.

With those changes, the pipeline looks correct:
                "consumePipe": {
                  "filters": {
                    "filterType": "dispatchPipe",
                    "outputType": "MassTransit.ConsumeContext<MassTransitTest.DoWork>",
                    "consumer": {
                      "type": "MassTransit.Pipeline.ConsumerFactories.BatchConsumer<MassTransitTest.DoWork>",
                      "consumerFactory": {
                        "source": "batch",
                        "consumerType": "MassTransit.IConsumer<MassTransitTest.DoWork>",
                        "timeLimit": "00:00:01",
                        "messageLimit": 10,
                        "consumerFactory": {
                          "source": "scope",
                          "consumerType": "MassTransitTest.DoWorkConsumer",
                          "provider": "dependencyInjection"
                        },
                        "batchCollector": {
                          "consumer": {
                            "type": "MassTransitTest.DoWorkConsumer",
                            "consumerFactory": {
                              "source": "scope",
                              "consumerType": "MassTransitTest.DoWorkConsumer",
                              "provider": "dependencyInjection"
                            },
                            "filters": [
                              {
                                "filterType": "split",
                                "consumerType": "MassTransitTest.DoWorkConsumer",
                                "filters": {
                                  "filterType": "logging"
                                }
                              },
                              {
                                "filterType": "split",
                                "messageType": "MassTransit.Batch<MassTransitTest.DoWork>",
                                "filters": {
                                  "filterType": "outbox",
                                  "type": "in-memory"
                                }
                              },
                              {
                                "filterType": "split",
                                "messageType": "MassTransit.Batch<MassTransitTest.DoWork>",
                                "filters": {
                                  "filterType": "uow"
                                }
                              }
                            ],
                            "consume": {
                              "method": "Consume(ConsumeContext<MassTransit.Batch<MassTransitTest.DoWork>> context)"
                            }
                          }
                        }
                      },
                      "consume": {
                        "method": "Consume(ConsumeContext<MassTransitTest.DoWork> context)"
                      }
                    }
                  }
                }
              }

With those changes, I get the following error "GreenPipes.PayloadNotFoundException: The payload was not found: System.IServiceProvider"

(I'm still trying to understand this one)
If I comment the body of the method UnitOfWorkConfigurationObserver.MessageConfigured to ingore the previous error, I get the following:

which indicates that the outbox is still being ignored for the domain event.

What does bus.json look like with 7.0.6?

https://gist.github.com/gschuager/7c0471db509d5438eb4b3c46963cc06e

So, the problem with the 7.0.6 code is that every message has its own outbox. So, in your scenarios, like 1000 outboxes, with no connection between them. With the 7.0.7 code it is creating the outbox prior to the batch consumer, just one, since that's the only consumer that's configured.

Ok, I understand that.
What I don't understand is how to configure the pipeline in 7.0.7 so that messages published in the uow filter go to the single outbox instead of being published right away (this works fine for non-batching scenarios).

Are you calling publish on the ConsumeContext<Batch<T>> or the individual consume contexts of each message? If it's the latter, that's why.

BatchConsumeContext<T> which implements ConsumeContext<Batch<T>>

So it seems your UnitOfWork, taking ConsumeContext on the constructor, is getting the wrong one. And I'm wondering if it's because the UOW is starting before the batch consumer, thereby not having a service provider available at the batch consumer level. Because if you look in the consumer, it's an outbox consume context wrapped in a consumer consume context.
So if you were able to create the unit of work in the filter using the proper consume context it would resolve the issue. I can't figure out why, except that the consumer factory is where the scope is created and the consumer scope isn't created until after the unit of work is added.

PR submitted that works.

I just checked your changes and I see that it still doesn't work as expected: the domain event is sent (and consumed) before the batch consumer completes:

But even if the issue can be worked around in this simple case by passing the correct context around, in a real application (like the one were I detected this) you'd have domain event handlers and their dependencies (all omitted in the reproduction) where you'd need access to the correct IPublishEndpoint: having to pass it as a parameter would break those interface (I wouldn't like to add an IPublishEndpoint to my domain event handler interface because that's an implementation detail and not all of them need it).
I'm looking at the code to see if I can find where the problem is but I'm having a hard time following some things.

Looking at this with a fresh perspective (and a night's sleep), the pipeline for a regular consumer resolved from the container using the in-memory outbox looks like this one:
"consumePipe": {
  "filters": {
    "filterType": "dispatchPipe",
    "outputType": "MassTransit.ConsumeContext<MassTransit.TestFramework.Messages.PingMessage>",
    "filters": {
      "filterType": "outbox",
      "type": "in-memory"
    },
    "consumer": {
      "type": "MassTransit.Containers.Tests.Common_Tests.ConsumeContextTestSubjects.DependentConsumer",
      "consumerFactory": {
        "source": "scope",
        "consumerType": "MassTransit.Containers.Tests.Common_Tests.ConsumeContextTestSubjects.DependentConsumer",
        "provider": "dependencyInjection"
      },
      "consume": {
        "method": "Consume(ConsumeContext<MassTransit.TestFramework.Messages.PingMessage> context)"
      }
    }
  }
}

You can see, the outbox is right before the consumer factory that resolves from the container. I'll need to look at creating unit tests for the batch consumer to ensure that batch consumer dependencies get the proper consumeContext.

Test confirmed, the pipeline isn't correct (and wasn't correct before either, it just didn't get fixed properly in 7.0.7).
"consumePipe": {
  "filters": {
    "filterType": "dispatchPipe",
    "outputType": "MassTransit.ConsumeContext<MassTransit.TestFramework.Messages.PingMessage>",
    "consumer": {
      "type": "MassTransit.Pipeline.ConsumerFactories.BatchConsumer<MassTransit.TestFramework.Messages.PingMessage>",
      "consumerFactory": {
        "source": "batch",
        "consumerType": "MassTransit.IConsumer<MassTransit.TestFramework.Messages.PingMessage>",
        "timeLimit": "00:00:00.2000000",
        "messageLimit": 4,
        "consumerFactory": {
          "source": "scope",
          "consumerType": "MassTransit.Containers.Tests.Common_Tests.ConsumeContextTestSubjects.DependentBatchConsumer",
          "provider": "dependencyInjection"
        },
        "batchCollector": {
          "consumer": {
            "type": "MassTransit.Containers.Tests.Common_Tests.ConsumeContextTestSubjects.DependentBatchConsumer",
            "consumerFactory": {
              "source": "scope",
              "consumerType": "MassTransit.Containers.Tests.Common_Tests.ConsumeContextTestSubjects.DependentBatchConsumer",
              "provider": "dependencyInjection"
            },
            "filters": {
              "filterType": "split",
              "messageType": "MassTransit.Batch<MassTransit.TestFramework.Messages.PingMessage>",
              "filters": {
                "filterType": "outbox",
                "type": "in-memory"
              }
            },
            "consume": {
              "method": "Consume(ConsumeContext<MassTransit.Batch<MassTransit.TestFramework.Messages.PingMessage>> context)"
            }
          }
        }
      },
      "consume": {
        "method": "Consume(ConsumeContext<MassTransit.TestFramework.Messages.PingMessage> context)"
      }
    }
  }
}

I think I understand.
I added the retry filter to see where it gets added in each case ... is this what we should be targeting?

So, not really. Your unit of work expects the container scope to be available, which means it needs to be after the consumer factory. Which sort of creates a problem, that I'm trying to understand.
I have made a change to the batch configurator, so that ConsumeContext<T> filters are added before the consumer factory resulting in the following pipeline. The unit test verifies that the dependent services are getting the outbox, instead of the undecorated ConsumeContext, IPublishEndpoint, etc.
"consumePipe": {
  "filters": {
    "filterType": "dispatchPipe",
    "outputType": "MassTransit.ConsumeContext<MassTransit.TestFramework.Messages.PingMessage>",
    "consumer": {
      "type": "MassTransit.Pipeline.ConsumerFactories.BatchConsumer<MassTransit.TestFramework.Messages.PingMessage>",
      "consumerFactory": {
        "source": "batch",
        "consumerType": "MassTransit.IConsumer<MassTransit.TestFramework.Messages.PingMessage>",
        "timeLimit": "00:00:00.2000000",
        "messageLimit": 4,
        "batchCollector": {
          "filters": {
            "filterType": "outbox",
            "type": "in-memory"
          },
          "consumer": {
            "type": "MassTransit.Containers.Tests.Common_Tests.ConsumeContextTestSubjects.DependentBatchConsumer",
            "consumerFactory": {
              "source": "scope",
              "consumerType": "MassTransit.Containers.Tests.Common_Tests.ConsumeContextTestSubjects.DependentBatchConsumer",
              "provider": "dependencyInjection"
            },
            "consume": {
              "method": "Consume(ConsumeContext<MassTransit.Batch<MassTransit.TestFramework.Messages.PingMessage>> context)"
            }
          }
        }
      },
      "consume": {
        "method": "Consume(ConsumeContext<MassTransit.TestFramework.Messages.PingMessage> context)"
      }
    }
  }
}

The issue I need to confirm is if it is consistent with how the other filters perform. Also, you would need to use your UnitOfWork filter with knowledge of the consumer type in order for it to work right. That's my next challenge.

Okay, this looks right:
"consumePipe": {
  "filters": {
    "filterType": "dispatchPipe",
    "outputType": "MassTransit.ConsumeContext<MassTransit.TestFramework.Messages.PingMessage>",
    "consumer": {
      "type": "MassTransit.Pipeline.ConsumerFactories.BatchConsumer<MassTransit.TestFramework.Messages.PingMessage>",
      "consumerFactory": {
        "source": "batch",
        "consumerType": "MassTransit.IConsumer<MassTransit.TestFramework.Messages.PingMessage>",
        "timeLimit": "00:00:00.2000000",
        "messageLimit": 4,
        "batchCollector": {
          "filters": {
            "filterType": "outbox",
            "type": "in-memory"
          },
          "consumer": {
            "type": "MassTransit.Containers.Tests.Common_Tests.ConsumeContextTestSubjects.DependentBatchConsumer",
            "consumerFactory": {
              "source": "scope",
              "consumerType": "MassTransit.Containers.Tests.Common_Tests.ConsumeContextTestSubjects.DependentBatchConsumer",
              "provider": "dependencyInjection"
            },
            "filters": {
              "filterType": "split",
              "consumerType": "MassTransit.Containers.Tests.Common_Tests.ConsumeContextTestSubjects.DependentBatchConsumer",
              "filters": {
                "filterType": "uow"
              }
            },
            "consume": {
              "method": "Consume(ConsumeContext<MassTransit.Batch<MassTransit.TestFramework.Messages.PingMessage>> context)"
            }
          }
        }
      },
      "consume": {
        "method": "Consume(ConsumeContext<MassTransit.TestFramework.Messages.PingMessage> context)"
      }
    }
  }
}

So this is built, develop packages are available. You might give it a shot.

Excellent!! It works flawlessly now.
Once again, thank you very much!


Missing comma in Cocoa migration docs

Thanks for the great documentation! In the Performing a Migration section of the documentation, the two Swift code samples missing a comma:
RLMRealm.setSchemaVersion(1, forRealmAtPath: RLMRealm.defaultRealmPath()
                         withMigrationBlock: { migration, oldSchemaVersion in ...

There should be a comma after RLMRealm.defaultRealmPath().

Thanks for pointing this out, just made a fix!


adapty.identify does not register customer user id

Description
A bug happened!
I doubled checked and the uid is being passed but it still does not saves to user account. Seems to be creating some issues for multiple users! Since the user id is being passed from this same place to multiple 3rd parties and they seem to save it correctly as well therefore i suspect there is some issue in the new update? Can you please check?

Checked in verbose logs as well, it doesn't seems to trigger identify function in verbose logs!
Version
v2.3.5
What platforms are you seeing the problem on?
iOS, Android
System info
Platform: iOS
Device: Iphone 14 pro (Simulator)
OS: iOS 16.2

@divanc No, customerUserId is not being passed in there.

@divanc I'm closing this ticket since it seems to work fine now. Thanks!


Possible "Use of memory after it is freed" in handler_ptr

Love your library. Using it for many different things.
I am using a modified version of http async ssl client example. clang-analyzer threw an error.
This could either be a bug in my code or the beast library (v144). I saw that handler_ptr was deprecated in the latest version but couldn't find out the reason.
/usr/local/include/boost/beast/core/impl/handler_ptr.ipp:54:8: error: Use of memory after it is freed [clang-analyzer-cplusplus.NewDelete,-warnings-as-errors]
    if(p_->t)
       ^
/build/build/../src/http-client-async-ssl.cpp:99:9: note: Assuming the condition is false
    if (req_data.empty()) {
        ^
/build/build/../src/http-client-async-ssl.cpp:99:5: note: Taking false branch
    if (req_data.empty()) {
    ^
/build/build/../src/http-client.cpp:108:5: note: Calling 'async_write<boost::asio::ssl::stream<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >, true, boost::beast::http::basic_string_body<char, std::char_traits<char>, std::allocator<char> >, boost::beast::http::basic_fields<std::allocator<char> >, std::_Bind<void (http::session::*(std::shared_ptr<http::session>, std::_Placeholder<1>, std::_Placeholder<2>))(boost::system::error_code, unsigned long)>>'
    http::async_write(
    ^
/usr/local/include/boost/beast/http/impl/write.ipp:786:5: note: Calling 'write_msg_op::operator()'
    detail::write_msg_op<
    ^
/usr/local/include/boost/beast/http/impl/write.ipp:373:12: note: Calling 'async_write<boost::asio::ssl::stream<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >, true, boost::beast::http::basic_string_body<char, std::char_traits<char>, std::allocator<char> >, boost::beast::http::basic_fields<std::allocator<char> >, boost::beast::http::detail::write_msg_op<boost::asio::ssl::stream<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >, std::_Bind<void (http::session::*(std::shared_ptr<http::session>, std::_Placeholder<1>, std::_Placeholder<2>))(boost::system::error_code, unsigned long)>, true, boost::beast::http::basic_string_body<char, std::char_traits<char>, std::allocator<char> >, boost::beast::http::basic_fields<std::allocator<char> > >>'
    return async_write(d.s, d.sr, std::move(*this));
           ^
/usr/local/include/boost/beast/http/impl/write.ipp:718:46: note: Calling implicit destructor for 'write_op<boost::asio::ssl::stream<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >, boost::beast::http::detail::write_msg_op<boost::asio::ssl::stream<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >, std::_Bind<void (http::session::*(std::shared_ptr<http::session>, std::_Placeholder<1>, std::_Placeholder<2>))(boost::system::error_code, unsigned long)>, true, boost::beast::http::basic_string_body<char, std::char_traits<char>, std::allocator<char> >, boost::beast::http::basic_fields<std::allocator<char> > >, boost::beast::http::detail::serializer_is_done, true, boost::beast::http::basic_string_body<char, std::char_traits<char>, std::allocator<char> >, boost::beast::http::basic_fields<std::allocator<char> >>'
            init.completion_handler, stream, sr}();
                                             ^
/usr/local/include/boost/beast/http/impl/write.ipp:718:46: note: Calling implicit destructor for 'write_msg_op<boost::asio::ssl::stream<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >, std::_Bind<void (http::session::*(std::shared_ptr<http::session>, std::_Placeholder<1>, std::_Placeholder<2>))(boost::system::error_code, unsigned long)>, true, boost::beast::http::basic_string_body<char, std::char_traits<char>, std::allocator<char> >, boost::beast::http::basic_fields<std::allocator<char> >>'
/usr/local/include/boost/beast/http/impl/write.ipp:718:46: note: Calling '~handler_ptr'
/usr/local/include/boost/beast/core/impl/handler_ptr.ipp:50:5: note: Taking false branch
    if(! p_)
    ^
/usr/local/include/boost/beast/core/impl/handler_ptr.ipp:52:5: note: Taking false branch
    if(--p_->n)
    ^
/usr/local/include/boost/beast/core/impl/handler_ptr.ipp:54:8: note: Assuming the condition is false
    if(p_->t)
       ^
/usr/local/include/boost/beast/core/impl/handler_ptr.ipp:54:5: note: Taking false branch
    if(p_->t)
    ^
/usr/local/include/boost/beast/core/impl/handler_ptr.ipp:65:5: note: Memory is released
    delete p_;
    ^
/usr/local/include/boost/beast/http/impl/write.ipp:718:46: note: Returning from '~handler_ptr'
            init.completion_handler, stream, sr}();
                                             ^
/usr/local/include/boost/beast/http/impl/write.ipp:718:46: note: Returning from destructor for 'write_msg_op<boost::asio::ssl::stream<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >, std::_Bind<void (http::session::*(std::shared_ptr<http::session>, std::_Placeholder<1>, std::_Placeholder<2>))(boost::system::error_code, unsigned long)>, true, boost::beast::http::basic_string_body<char, std::char_traits<char>, std::allocator<char> >, boost::beast::http::basic_fields<std::allocator<char> >>'
/usr/local/include/boost/beast/http/impl/write.ipp:718:46: note: Returning from destructor for 'write_op<boost::asio::ssl::stream<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >, boost::beast::http::detail::write_msg_op<boost::asio::ssl::stream<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >, std::_Bind<void (http::session::*(std::shared_ptr<http::session>, std::_Placeholder<1>, std::_Placeholder<2>))(boost::system::error_code, unsigned long)>, true, boost::beast::http::basic_string_body<char, std::char_traits<char>, std::allocator<char> >, boost::beast::http::basic_fields<std::allocator<char> > >, boost::beast::http::detail::serializer_is_done, true, boost::beast::http::basic_string_body<char, std::char_traits<char>, std::allocator<char> >, boost::beast::http::basic_fields<std::allocator<char> >>'
/usr/local/include/boost/beast/http/impl/write.ipp:373:12: note: Returning; memory was released
    return async_write(d.s, d.sr, std::move(*this));
           ^
/usr/local/include/boost/beast/http/impl/write.ipp:786:5: note: Returning; memory was released
    detail::write_msg_op<
    ^
/usr/local/include/boost/beast/http/impl/write.ipp:791:46: note: Calling implicit destructor for 'write_msg_op<boost::asio::ssl::stream<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >, std::_Bind<void (http::session::*(std::shared_ptr<http::session>, std::_Placeholder<1>, std::_Placeholder<2>))(boost::system::error_code, unsigned long)>, true, boost::beast::http::basic_string_body<char, std::char_traits<char>, std::allocator<char> >, boost::beast::http::basic_fields<std::allocator<char> >>'
            init.completion_handler, stream, msg}();
                                             ^
/usr/local/include/boost/beast/http/impl/write.ipp:791:46: note: Calling '~handler_ptr'
/usr/local/include/boost/beast/core/impl/handler_ptr.ipp:50:5: note: Taking false branch
    if(! p_)
    ^
/usr/local/include/boost/beast/core/impl/handler_ptr.ipp:52:5: note: Taking false branch
    if(--p_->n)
    ^
/usr/local/include/boost/beast/core/impl/handler_ptr.ipp:54:8: note: Use of memory after it is freed
    if(p_->t)
       ^

Version of Beast
#define BOOST_BEAST_VERSION 144
Steps necessary to reproduce the problem
Running clang analyzer on modified http async ssl client example.
All relevant compiler information
Ubuntu 18.10 -> clang analyzer tool

handler_ptr is deprecated because async_base is safer, more flexible, easier to use and generally better for achieving the same goal:
https://www.boost.org/doc/libs/1_70_0/libs/beast/doc/html/beast/ref/boost__beast__async_base.html
There is nothing "wrong" with handler_ptr, it just isn't as good. I am very confident that there are no bugs in handler_ptr, so either you have a false positive or your code is somehow breaking preconditions.

Thanks for your response. It seems to be a false positive in clang analyzer. I disabled that check.


use frobenius_map_in_place instead of frobenious_map

Description
Companion to https://github.com/arkworks-rs/algebra/pull/557

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (master)
[ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

no op as already added via https://github.com/arkworks-rs/r1cs-std/pull/109, merging for completeness.


Fixes the Track name list position issue

Fixes #1423
Changes

The track name list is now visible near the top of the page. Earlier, it went down to the bottom of the tracks page
To make sure this issue doesn't ever happen again, added selenium tests for it
Also, corrected some of the bookmark tests which were written in a slightly wrong manner and were failing after making the above changes

Test Server
http://secure-meadow-20680.herokuapp.com
Video for Demonstration
https://saucelabs.com/beta/tests/5e059ace942f4e0694ca8cf23654079e/watch#517
Test Website
https://princu7.github.io/websiteTest/index.html
@aayusharora @geekyd @sumedh123 Please review. Thanks :)

Some Screenshots. The track name list is visible on the front of the page. Also, the date tab and the session content below are horizontally aligned.

Schedule Page

Rooms Page

Tracks Page

Please resolve conflicts.

@mariobehling @geekyd Resolved conflicts. Please review again. Thanks!

Thanks. I wonder when you are following up on the new features and high priority issues, e.g. https://github.com/fossasia/open-event-webapp/issues/1317
Please focus now to get this system up to industry standard.

@mariobehling Yes. I have already started working on that issue. Will try to complete it as soon as possible.


feat(sqlsmith): enable sub-query generation

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:

Summarize your change (mandatory)
How does this PR work? Need a brief introduction for the changed logic (optional)
Describe clearly one logical change and avoid lazy messages (optional)
Describe any limitations of the current code (optional)

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Refer to a related PR or issue link (optional)
related to https://github.com/singularity-data/risingwave/issues/3935
close https://github.com/singularity-data/risingwave/issues/4215

Need to solve this first https://github.com/singularity-data/risingwave/issues/4215

@kwannoel @neverchanje , I have made the changes to the lateral_contexts already. It is ready for approval.


chore: adjust base image, dependency in Dockerfile

Purpose:

change base image from centos:centos7 to ubuntu:18.04
adjust the dependency in Dockerfile

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 77.135%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
3758

Relevant Lines:
4872

💛  - Coveralls


GenerateImage errors

Minetest 0.5.0-dev newest, newest maptools
ERROR[Main]: generateImage(): Could not load image "dye_purple.png" while building texture; Creating a dummy image
ERROR[Main]: generateImage(): Could not load image "dye_purple.png" while building texture; Creating a dummy image
ERROR[Main]: generateImage(): Could not load image "bones_bones.png" while building texture; Creating a dummy image
ERROR[Main]: generateImage(): Could not load image "bones_bones.png" while building texture; Creating a dummy image
ERROR[Main]: generateImage(): Could not load image "default_scorched_stuff.png" while building texture; Creating a dummy image
ERROR[Main]: generateImage(): Could not load image "default_scorched_stuff.png" while building texture; Creating a dummy image

dye_purple > dye_violet
bones_bones > bones_top
how about dry_grass as a replacement for scorched?

Literally 2 years later, ty and cheers!


missing ModuleOptions

export { default } from './module' seems to be missing ModuleOptions

Thanks for the report, will take a look at this

im not sure whether this is allowed by nuxt module bundler, as I checked it process the final outcome


sample cubemap

same as add a cubemap in shadertoy.com

Thanks for your input. I will investigate this in the future, but no work has been done towards it so far.


verify_digest shouldn't throw an error, but just return False if the signature is wrong.

Prerequisites

[X] I checked the documentation and found no answer to my problem
[X] I checked the existing issues and made sure there are no similar bug reports

Category
Bug (unexpected behavior)
Expected Behavior
If we have an Envelope with a wrong signature e.g. sigWrong and we call verify, it should return False.

envelope = Envelope(signature="sigWrong")

envelope.verify() #Should be False

Observed Behavior
If we have an Envelope with a wrong signature e.g. sigWrong and we call verify, it throws an error

envelope = Envelope(signature="sigWrong")

envelope.verify() #Needs to be catched

To Reproduce
No response
Version
v0.14.0
Environment Details (Optional)
No response
Failure Logs (Optional)
No response
Additional Information (Optional)
No response

cc @qati

You spotted indeed inconsistent behavior. The example you're describing raises an error because no sender address is specified. If you create a complete and valid Envelope, but provide a wrong signature, Envelope.verify() would not throw an exception and actually return False.
I would argue that the latter is the actually wrong behavior and following security common practices verify  should always throw an exception if not successful. The reasoning behind this is that there is no scenario which could come to a successful outcome, if the signature was not valid and in every case the developer would need to gracefully wind off the current process and return corresponding information to the user and/or communication partners. Which is the exact scope of exception handling.
Thoughts or objections @Archento @jrriehl @ejfitzgerald?

Agreed @Dacksus my feeling is that this function should always throw.
If python had a way to signal the return value should always be read then it might be different.
I would refactor this so all error cases cause exceptions to be thrown

Sorry my examples were a bit reductive and I have only highlighted the signature part, considering that all the other fields were put as such to generate a valid Envelope.
Actually, with a valid Envelope and the signature that I have provided the code should just return false since the signature by itself is compromised hence not valid.


⚠ API has degraded performance

In eb3455a, API ($ZESTY_API) experienced degraded performance:

HTTP code: 403
Response time: 1727 ms

Resolved: API performance has improved in f715f0c.


fix(NavigationManager): fix render order and storybook glitches

Description

Allows NavigationManager children components to run layout/updates before the parent does. This prevents a mis-rendered stack of children on the first render of column/row.
Also includes Storybook render glitch fixes to normalize storybook rendering. These changes are described here: https://github.com/rdkcentral/Lightning-UI-Components/pull/465
It helps to evaluate this PR, but we can merge separately or all together here.
Fixes the use of the centerKeys prop in keyboard to fix a mis-rendered first draw.

References
Related to: LUI-1328
Testing

Ensure Column/Row based layouts are functioning properly. Items should draw in place and not stacked on top of each other when chrome is throttled down.

Checklist

[x] all commented code has been removed
[x] any new console issues have been resolved
[x] code linter and formatter has been run
[x] test coverage meets repo requirements
[x] PR name matches the expected semantic-commit syntax

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

All the stories I tested are looking good, but I did see that the TextPanel portion of GridOverlay still has a Column that is showing the TextBoxes stacked when first rendering:
https://github.com/rdkcentral/Lightning-UI-Components/assets/2678766/f5974b6d-b632-461a-9c15-af839961ef04

All the stories I tested are looking good, but I did see that the TextPanel portion of GridOverlay still has a Column that is showing the TextBoxes stacked when first rendering:

So this would be an example of where waitForDimensions may still be relevant. In this case, the items don't have a height until the text textures are rendered and the textboxes update. If they had a height set beforehand, then would not stack

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

:tada: This PR is included in version @lightningjs/ui-components-v2.20.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Test Execution Failed.


How should I download and get an m4a audio file from youtube video ?

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question
How can I download a youtube video to extract an audio to m4a container ?
I have written this python code
from __future__ import unicode_literals
import youtube_dl
import argparse
import sys
import os

HOME = os.getenv("HOME")

DOWNLOAD_TO = os.path.join(
	HOME, "Music/iTunes/iTunes Media/Automatically Add to iTunes/")

def get_parser():
	"""Get options to parse.
	"""
	parser = argparse.ArgumentParser()
	parser.add_argument("urls", nargs="+")
	parser.add_argument(
		"--format",
		choices=('mp3', 'm4a'),
		default="mp3",
		help="file format of audio song.")
	parser.add_argument(
		"--quality",
		default='192',
		help="Quality for selected format.")
	return parser.parse_args()

class MyLogger(object):
    def debug(self, msg):
        print("> " + msg)

    def warning(self, msg):
        print("> "+ msg)

    def error(self, msg):
        print(msg)

def my_hook(d):
    if d['status'] == 'finished':
        print('Done downloading, now converting ...')

def run():
	args = get_parser()

	ydl_opts = {
	    'format': 'bestaudio/best',
	    'postprocessors': [{
	        'key': 'FFmpegExtractAudio',
	        'preferredcodec': args.format,
	        'preferredquality': args.quality,
	    }],
	    'logger': MyLogger(),
	    'progress_hooks': [my_hook],
	}
	os.chdir(DOWNLOAD_TO)
	with youtube_dl.YoutubeDL(ydl_opts) as ydl:
	    ydl.download(args.urls)

I tried to download m4a with quality 192
ydla https://www.youtube.com/watch?v=KkvSkWYobHk --format m4a
I am getting this error
File "/usr/local/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 2018, in download
    res = self.extract_info(
  File "/usr/local/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 808, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/local/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 863, in process_ie_result
    return self.process_video_result(ie_result, download=download)
  File "/usr/local/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 1644, in process_video_result
    self.process_info(new_info)
  File "/usr/local/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 2000, in process_info
    self.post_process(filename, info_dict)
  File "/usr/local/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 2067, in post_process
    self.report_error(e.msg)
  File "/usr/local/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 625, in report_error
    self.trouble(error_message, tb)
  File "/usr/local/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 595, in trouble
    raise DownloadError(message, exc_info)
youtube_dl.utils.DownloadError: ERROR: audio conversion failed: [aac @ 0x7f973780f600] The encoder 'aac' is experimental but experimental codecs are not enabled, add '-strict -2' if you want to use it.

I am not sure if I can add strict through ydl object ! or if my options are incorrect.
Thanks
san

managed to get it to work by removing the postprocessor hook
'postprocessors': [{
	        'key': 'FFmpegExtractAudio',
	        'preferredcodec': args.format,
	        'preferredquality': args.quality,
	    }]

ffmpeg has improved native aac encoder and removed experimental flag with version 3.0, date Feb 15, 2016.
I guess your ffmpeg was too old.


In dark mode "Contact support" from levels are not visible

Describe the bug
In light mode Levels name are visible:

Dake mode:

Expected behavior
Users can see the levels.
Screenshots / Logs
If applicable, add screenshots and log traces to help debug your problem with any sensitive data removed.
Platform (please complete the following information):

Firezone Version [e.g. 0.7.12]
OS: [e.g. Linux]
Distro: [e.g. Ubuntu 18.04]
Kernel version: [e.g. 5.10.11]
Deployment method: [e.g. Docker / Omnibus / Source]

Additional context
Add any other context about the problem here.

Hey @AndrewDryga , I would like to work on this issue. Please Assign it to me.

@sajdakabir Thanks for the report and offer to help! Feel free to give it a shot, but this form is pulled in from HubSpot and may need to be updated there. Let me know if you're not able to make the necessary changes.

Hey @jamilbk , You have to change it from HubSpot. I tried but I can't make the changes.


Filter out purged data from private data store

Signed-off-by: manish<EMAIL_ADDRESS>Type of change

New feature

Description
This PR  introduces support for the purge marker(s) and filters the data marked for purging. In addition, this PR removes the
unused code for V11 format as now we upgraded data format along with retroactively creating hashed index at peer start.
Related issues
Resolves #3028

/ci-run

/azp run


PP-7293: Add connectTimeout and readTimeout to Jersey client

WHAT YOU DID
Currently, Jersey client has both connectTimeout and readTimeout set to 0 by default. 0 means infinity. When the client sends a request to another application, it waits until it gets a response. If the request is dropped silently by a firewall or it goes missing, the client will wait forever and never log a timeout exception. This change will add both connectTimeout and readTimeout config items to Products application's config file and are set to 50 seconds by default because Nginx's default timeout is 60 seconds and these timeouts need to be less than 60 seconds to allow Products application to send its response before Nginx cuts off. It also updates RestClientFactoryTest to use JUnit5.
Code review checklist
Logging

[x] only emit log lines at ERROR level which require immediate attention from a support engineer. These will trigger a zendesk alert.

Documentation

[ ] Updated README.md for any of the following ?

Introduced any new environment variables / removed existing environment variable
No
Added new API / updated existing API definition
No

@adityapahuja The code looks fine, but I still have some questions:

The PR says "Currently, Jersey client has both connectTimeout and readTimeout set to 0 by default."
Is there documentation that says this?
I'm curious because from how I tested, I got a java.net.ConnectException: Connection timed out (Connection timed out), so I'm not sure what the point of this PR really is?

The PR says "Currently, Jersey client has both connectTimeout and readTimeout set to 0 by default."
Is there documentation that says this?
I'm curious because from how I tested, I got a java.net.ConnectException: Connection timed out (Connection timed out).

Yes, according to Dropwizard documentation, it says
"The Client that Dropwizard creates deviates from the Jersey Client Configuration defaults. The default, in Jersey, is for a client to never timeout reading or connecting in a request, while in Dropwizard, the default is 500 milliseconds."
Source: https://www.dropwizard.io/en/latest/manual/client.html (under Configuration section)
Products application is not using Dropwizard client. It is using Jersey client via ClientBuilder class and its connect timeout and read timeout are set to 0 by default as mentioned in Jersey client documentation.
Source: http://javadox.com/org.glassfish.jersey.core/jersey-client/2.6/org/glassfish/jersey/client/ClientProperties.html#READ_TIMEOUT

I'm curious because from how I tested, I got a java.net.ConnectException: Connection timed out (Connection timed out).

I ran curl command to post a request for regenerating an API token for a non-existent product to products application directly (bypassing Nginx) and got the following immediate response .

<meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
<title>Error 404 Not Found</title>

HTTP ERROR 404 Not Found

URI:	/v1/api/products/x/regenerate-api-token

STATUS:	404

MESSAGE:	Not Found

SERVLET:	jersey

When I ran curl command to post a request for regenerating an API token for an existing product to products application directly (bypassing Nginx), I never got a response in test environment. There were no exceptions (e.g. FailToGetNewApiTokenException) in Products application log file.
Please note that Products application is still blocked from talking to Public Auth application due to a firewall.

| I ran curl command to post a request for regenerating an API token for a non-existent product to products application
Yes I'd expect to get 404 response here.

When I ran curl command to post a request for regenerating an API token for an existing product to products application directly

This is what I tested. From the JIRA ticket I posted the stack trace:
javax.ws.rs.ProcessingException: java.net.ConnectException: Connection timed out (Connection timed out)
	at org.glassfish.jersey.client.internal.HttpUrlConnector.apply(HttpUrlConnector.java:261)
	at org.glassfish.jersey.client.ClientRuntime.invoke(ClientRuntime.java:297)
	at org.glassfish.jersey.client.JerseyInvocation.lambda$invoke$0(JerseyInvocation.java:619)
	at org.glassfish.jersey.client.JerseyInvocation.call(JerseyInvocation.java:654)
	at org.glassfish.jersey.client.JerseyInvocation.lambda$runInScope$3(JerseyInvocation.java:648)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:292)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:274)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:205)
	at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:390)
	at org.glassfish.jersey.client.JerseyInvocation.runInScope(JerseyInvocation.java:648)
	at org.glassfish.jersey.client.JerseyInvocation.invoke(JerseyInvocation.java:618)
	at org.glassfish.jersey.client.JerseyInvocation$Builder.method(JerseyInvocation.java:423)
	at org.glassfish.jersey.client.JerseyInvocation$Builder.post(JerseyInvocation.java:329)
	at uk.gov.pay.products.service.ProductApiTokenManager.getNewApiTokenFromPublicAuth(ProductApiTokenManager.java:44)
	at uk.gov.pay.products.resources.ProductResource.lambda$regenerateProductApiToken$16(ProductResource.java:207)
	at java.base/java.util.Optional.map(Unknown Source)
	at uk.gov.pay.products.resources.ProductResource.regenerateProductApiToken(ProductResource.java:206)

and I got the response
< HTTP/1.1 504 Gateway Time-out
< Date: Wed, 04 Nov 2020 13:21:07 GMT
< Content-Type: text/html
< Content-Length: 164
< Connection: keep-alive
<

<title>504 Gateway Time-out</title>

504 Gateway Time-out

localhost

which is why I'm not sure the connection is really timing out as this PR suggests. As in, I'm not getting a hanged response.

<title>504 Gateway Time-out</title>

504 Gateway Time-out

localhost

is the standard Nginx response.  When Nginx's read timeout is reached, it throws the following error message and sends the timeout message on behalf of Products application.
2020-11-04T13:21:07+00:00 ip6-localhost ecs-test-12_products-407-nginx-a2dcb88cd28e9fa1a901[1486]: 2020/11/04 13:21:07 [error] 38#38: *4220 upstream timed out (110: Operation timed out) while reading response header from upstream, client: <IP_ADDRESS>, server: $host, request: "POST /v1/api/products/4939a1f26d8e41d6becb99cc0ce0e558/regenerate-api-token HTTP/1.1", upstream: "http://<IP_ADDRESS>:8080/v1/api/products/4939a1f26d8e41d6becb99cc0ce0e558/regenerate-api-token", host: "localhost:9005"

Ok, that makes sense. Sorry to have been such a pain.

Thanks for providing the exception. It helps. The products application threw the timeout exception after 4 minutes and 22 seconds beyond Nginx's default timeout (60seconds). I ran the curl command to make a request for regenerating a new API token for an existing product with its timer and left it running. I got the following response!
< HTTP/1.1 500 Internal Server Error
< Date: Fri, 06 Nov 2020 12:02:00 GMT
< Content-Type: application/json
< Content-Length: 110
<
{ [110 bytes data]
* Connection #0 to host products left intact

It took 261.346300 seconds (4 minutes and 21 seconds). 260 seconds is set somewhere in a network device which decides to break the connection. I prefer the Products application to set its timeouts for both connect and read rather than relying on external sources so that the application can send its response before Nginx cuts off and sends its response.


Room for installation documentation improvement?

I had to run the following commands to get tiller working on my Raspberry Pi.
First to get the tiller pod running at all:
kubectl taint nodes --all node-role.kubernetes.io/master-

Then a service account, which is slightly mentioned in the documentation, but could perhaps be explained in more detail?
kubectl create serviceaccount --namespace kube-system tiller
  serviceaccount "tiller" created

kubectl create clusterrolebinding tiller-cluster-rule --clusterrole=cluster-admin --serviceaccount=kube-system:tiller
  clusterrolebinding "tiller-cluster-rule" created

kubectl patch deploy --namespace kube-system tiller-deploy -p '{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}'
  deployment "tiller-deploy" patched

Output of helm version:
Client: &version.Version{SemVer:"v2.8+unreleased", GitCommit:"5f4b260ae50544c6565f68db7079d8ce55c35b6e", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.8+unreleased", GitCommit:"5f4b260ae50544c6565f68db7079d8ce55c35b6e", GitTreeState:"clean"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.2", GitCommit:"81753b10df112992bf51bbc2c2f85208aad78335", GitTreeState:"clean", BuildDate:"2018-04-27T09:22:21Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/arm"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.2", GitCommit:"81753b10df112992bf51bbc2c2f85208aad78335", GitTreeState:"clean", BuildDate:"2018-04-27T09:10:24Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/arm"}

Helm/Tiller built from source, as no binaries available. Kubernetes from official apt repository.

Yep. Not sure what level the documentation should be wrt knowing about single k8s scheduling default settings. I'm very new to this, so it took a while to figure out the taint part. Now that I rechecked the documentation, what I did wrt tiller role ought to be equivalent to what is described here:
https://docs.helm.sh/using_helm/#role-based-access-control
..which I did read, but obviously gave too little attention to and instead jumped the google train and ended up filing this issue.

Hi @dsvensson
Im closing this issue since it sounds like your problem is resolved. Please let me know if that is incorrect and I will reopen it. Thanks!


As a player I want buttons indicating the flow of wares

Acceptance criteria

[ ] buttons imply whether it is a sell or a buy

Reference
https://steamcdn-a.akamaihd.net/steam/apps/12470/0000009114.1920x1080.jpg?t=1447352266

duplicate of https://github.com/proSingularity/parvenu/issues/134


Update behavior of Link component

The <Link> component used in the codebase is wrapper around react router's <Link> that changes the default behavior to maintain the query string of the current dataset (e.g. ?dataset=gnomad_r3).
This behavior seemed to fail when navigating to a page with multiple query strings, (in this case both a dataset and a variant). This component should be refactored and tested in the case of multiple query strings being passed to a <Link> in the default behavior.

Disregard this, I didn't read the code logic closely enough when on the time crunch.
To pass another query string argument, the to field of the <Link> component should be passed an object with both a pathname and search field, and it works as intended. Apologies.
e.g.
<Link to={{ pathname: "/foo", search: "foo=$bar" }}> Link Text </Link>


cli: 'popper add' command

For this issue, we will add an add command that takes a reference to a pipeline contained in a github repo (eg. popperized/quiho-popper/single-node) and adds it to the current project. The format of pipeline names is org/repo/pipeline.
This can be implemented using the https://github.com/PyGithub/PyGithub library

Working on this one

Sorry for the delay. I'll resume now


Proposal: pass object to convexPolyhedron

How do we feel about passing vertices, faces, normals and other information to the ConvexPolyhedron constructor as an object?
constructor({ vertices = [], faces = [], normals = [], axes, boundingSphereRadius }) {

I feel as if it makes passing available data, especially with gaps in it, a little easier.

Seems fine to me. I think it could even be an overload if there is a need to maintain backwards compatibility (not likely IMO)