CTest failure with windows build

Hello, i built OpenBLAS on Windows 10 with clang/flang as shown here
The build itself was successful but running ctest resulted in some errors possibly with the script test\test_helper.ps1.
OpenBLAS was build with:

cmake .. -G "Ninja"  -DCMAKE_C_COMPILER=clang-cl -DCMAKE_Fortran_COMPILER=flang -DCMAKE_MT=mt -DBUILD_WITHOUT_LAPACK=no -DNOFORTRAN=0 -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON

I run ctest in windows powershell and powershell 7 but both resulted in:

ctest --config Release --rerun-failed --output-on-failure
Test project C:/Users/George/source/libraries/openblas/build_rel
      Start  2: sblas1
 1/16 Test  #2: sblas1 ...........................Exit code 0xc0000135
***Exception:   0.10 sec

      Start  3: sblas2
 2/16 Test  #3: sblas2 ...........................***Failed    0.31 sec
& : The term 'file' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the
name, or if a path was included, verify that the path is correct and try again.
At C:\Users\George\source\libraries\openblas\build_rel\test\test_helper.ps1:3 char:31
+ If ((Get-Content $args[1] | & file - | %{$_ -match "BOM"}) -contains  ...
+                               ~~~~
    + CategoryInfo          : ObjectNotFound: (file:String) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : CommandNotFoundException

      Start  4: sblas3
 3/16 Test  #4: sblas3 ...........................***Failed    0.31 sec
& : The term 'file' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the
name, or if a path was included, verify that the path is correct and try again.
At C:\Users\George\source\libraries\openblas\build_rel\test\test_helper.ps1:3 char:31
+ If ((Get-Content $args[1] | & file - | %{$_ -match "BOM"}) -contains  ...
+                               ~~~~
    + CategoryInfo          : ObjectNotFound: (file:String) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : CommandNotFoundException

      Start  5: dblas1
 4/16 Test  #5: dblas1 ...........................Exit code 0xc0000135
***Exception:   0.01 sec

      Start  6: dblas2
 5/16 Test  #6: dblas2 ...........................***Failed    0.31 sec
& : The term 'file' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the
name, or if a path was included, verify that the path is correct and try again.
At C:\Users\George\source\libraries\openblas\build_rel\test\test_helper.ps1:3 char:31
+ If ((Get-Content $args[1] | & file - | %{$_ -match "BOM"}) -contains  ...
+                               ~~~~
    + CategoryInfo          : ObjectNotFound: (file:String) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : CommandNotFoundException

      Start  7: dblas3
 6/16 Test  #7: dblas3 ...........................***Failed    0.31 sec
& : The term 'file' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the
name, or if a path was included, verify that the path is correct and try again.
At C:\Users\George\source\libraries\openblas\build_rel\test\test_helper.ps1:3 char:31
+ If ((Get-Content $args[1] | & file - | %{$_ -match "BOM"}) -contains  ...
+                               ~~~~
    + CategoryInfo          : ObjectNotFound: (file:String) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : CommandNotFoundException

      Start  8: cblas1
 7/16 Test  #8: cblas1 ...........................Exit code 0xc0000135
***Exception:   0.01 sec

      Start  9: cblas2
 8/16 Test  #9: cblas2 ...........................***Failed    0.31 sec
& : The term 'file' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the
name, or if a path was included, verify that the path is correct and try again.
At C:\Users\George\source\libraries\openblas\build_rel\test\test_helper.ps1:3 char:31
+ If ((Get-Content $args[1] | & file - | %{$_ -match "BOM"}) -contains  ...
+                               ~~~~
    + CategoryInfo          : ObjectNotFound: (file:String) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : CommandNotFoundException

      Start 10: cblas3
 9/16 Test #10: cblas3 ...........................***Failed    0.32 sec
& : The term 'file' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the
name, or if a path was included, verify that the path is correct and try again.
At C:\Users\George\source\libraries\openblas\build_rel\test\test_helper.ps1:3 char:31
+ If ((Get-Content $args[1] | & file - | %{$_ -match "BOM"}) -contains  ...
+                               ~~~~
    + CategoryInfo          : ObjectNotFound: (file:String) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : CommandNotFoundException

      Start 11: zblas1
10/16 Test #11: zblas1 ...........................Exit code 0xc0000135
***Exception:   0.01 sec

      Start 12: zblas2
11/16 Test #12: zblas2 ...........................***Failed    0.32 sec
& : The term 'file' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the
name, or if a path was included, verify that the path is correct and try again.
At C:\Users\George\source\libraries\openblas\build_rel\test\test_helper.ps1:3 char:31
+ If ((Get-Content $args[1] | & file - | %{$_ -match "BOM"}) -contains  ...
+                               ~~~~
    + CategoryInfo          : ObjectNotFound: (file:String) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : CommandNotFoundException

      Start 13: zblas3
12/16 Test #13: zblas3 ...........................***Failed    0.31 sec
& : The term 'file' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the
name, or if a path was included, verify that the path is correct and try again.
At C:\Users\George\source\libraries\openblas\build_rel\test\test_helper.ps1:3 char:31
+ If ((Get-Content $args[1] | & file - | %{$_ -match "BOM"}) -contains  ...
+                               ~~~~
    + CategoryInfo          : ObjectNotFound: (file:String) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : CommandNotFoundException

      Start 14: xscblat1
13/16 Test #14: xscblat1 .........................Exit code 0xc0000135
***Exception:   0.01 sec

      Start 17: xdcblat1
14/16 Test #17: xdcblat1 .........................Exit code 0xc0000135
***Exception:   0.01 sec

      Start 20: xccblat1
15/16 Test #20: xccblat1 .........................Exit code 0xc0000135
***Exception:   0.01 sec

      Start 23: xzcblat1
16/16 Test #23: xzcblat1 .........................Exit code 0xc0000135
***Exception:   0.01 sec

0% tests passed, 16 tests failed out of 16

Total Test time (real) =   2.69 sec

The following tests FAILED:
          2 - sblas1 (Exit code 0xc0000135
)
          3 - sblas2 (Failed)
          4 - sblas3 (Failed)
          5 - dblas1 (Exit code 0xc0000135
)
          6 - dblas2 (Failed)
          7 - dblas3 (Failed)
          8 - cblas1 (Exit code 0xc0000135
)
          9 - cblas2 (Failed)
         10 - cblas3 (Failed)
         11 - zblas1 (Exit code 0xc0000135
)
         12 - zblas2 (Failed)
         13 - zblas3 (Failed)
         14 - xscblat1 (Exit code 0xc0000135
)
         17 - xdcblat1 (Exit code 0xc0000135
)
         20 - xccblat1 (Exit code 0xc0000135
)
         23 - xzcblat1 (Exit code 0xc0000135
)
Errors while running CTest

Broken by me in #3576, sorry. I had assumed any decent build environment would include the file command to determine file type, but that appears to be true for the CI machines only. (The intention was simply to skip the tests when their input got broken by addition of a byte order mark - which is what happens on one of the Azure CI hosts)


testsuite, how to run

Taking the last release -0.5.6 released the same day as -0.6.5

on running it it objects to the local import structure in the init.py
(from .. import SocketIO, LoggingNamespace, find_callback)
which might work once installed.

On changing that to an abs path:

It complete running with

python socketIO_client /tests/__init__.py

with nil output to the screen

Using

nosetests socketIO_client /tests/__init__.py

it then simply hangs.
Is it a normal testsuite?  When there is no output to tty it generally means the tests were no actually run. They require the output to confirm that something actually happened. This just leaves total doubt

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26354859-testsuite-how-to-run?utm_campaign=plugin&utm_content=tracker%2F388415&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F388415&utm_medium=issues&utm_source=github).

@idella These test suites assume that the test socket.io server is running (please see https://github.com/invisibleroads/socketIO-client/blob/master/.travis.yml).
You can launch the test socket.io server in another terminal with the following command:
DEBUG=* node socketIO_client/tests/serve.js


Vulkan API version auto selector

Draft PR https://github.com/bkaradzic/bgfx/pull/2273 for issue https://github.com/bkaradzic/bgfx/issues/2272 highlighted the need to split up the PR into two parts.
From @bkaradzic,

These are actually two different PRs, I would like you land first maximum version of VK, independent from shaders changes. And then shaderc changes can land without any changes to renderer. That way shaderc changes are similar to D3D profiles or GLSL versions.

This is the first PR for the above. The maximum version of VK.

cc: @pezcode @rinthel

Looks good, except for one thing:
The instance version determination code is not quite correct, since vkCreateInstance on Vulkan 1.1 and higher is supposed to accept any apiVersion. You'll have to call vkEnumerateInstanceVersion in that case and compare against the versions in your array. Or drop the array altogether and just save the instance version directly.

Thanks a bunch for your keen eye and suggestion there @pezcode !
Indeed, it will clean it up quite a bit if I actually use vkEnumerateInstanceVersion when it exists ! :)
I'll make the relevant changes and resubmit.

LGTM 😄


check enum values range

Try to fix #71

Why was this closed? What would you have done instead? The approach looked fine reading the code?... this could be enabled/disabled under the strict feature?

Why was this closed? What would you have done instead? The approach looked fine reading the code?... this could be enabled/disabled under the strict feature?

Because this check is already present in code:
https://github.com/rust-embedded/svd/blob/3ec09062ec854d04a9f01ef2c7d33b99283076e5/src/svd/enumeratedvalues.rs#L96
Saying about placing this under strict flag, I'm not sure.

Because this check is already present in code:
https://github.com/rust-embedded/svd/blob/3ec09062ec854d04a9f01ef2c7d33b99283076e5/src/svd/enumeratedvalues.rs#L96
Saying about placing this under strict flag, I'm not sure.

Ah, gotcha, then https://github.com/rust-embedded/svd/issues/71 can be closed I reckon?

Ah, gotcha, then https://github.com/rust-embedded/svd/issues/71 can be closed I reckon?


Generate tokens for Slurmrestd using python-jose

This PR applies a big change in the code which has potential to break current versions.
Currently, tokens for Slurmrestd are generated by using subprocess and then calling scontrol token. This PR changes it expecting either the JWT secret key or the JWT secret key path and then generating the token by python-jose. There are two main variables expected in the dotenv file:

SLURMRESTD_JWT_KEY_PATH
SLURMRESTD_JWT_KEY_STRING

Both are optional but at least one of them must be supplied. If both are supplied, the code will prioritize the key string.
The breakthrough this PR applies is the fact that the cluster agent will no longer need to be in the same node as the slurmrestd.

Task linked: ARMADA-438 Discovery: generate tokens for Slurm REST API auth


Charsequence

This patch adds CharSequence to the automatic conversion list.
Fixes #527

Thanks for the provided fix. I have a couple of question regarding the untyped usage of a string conversion class here. Is it now possible to literally set any jclass as a string conversion class? What would be the consequence, if this can be set somewhere, where we did not intend it and potentially harm security then?
If my concern is justified, wouldn't it be better to define a list of allowed string conversion classes?

Well the C++ conversion wrappers can be applied to any class,  but Java will not accept an object which is the wrong type.  In this case CharSequence accepts String as String is derived from it.  If this was applied to another type it would take the Python string convert it to a Java string and then produce an exception when Java checks the types.  Of course there are some cases this may not work as JNI is sometimes prone to failure to check which usually results in a segmentation fault.  For example, Java always checks the type of an object but it has no way to know if the item is actually an object because everything is passed as a union of types.  Thus passing an integer to an object will cause Java to try to access the memory that the integer points to even if that is outside of the memory space of the JVM.  We do a pretty good job of shielding the user from this with the exception of the memory backed array types where I have already noted issues.
In general, I have been working towards removing all of the specialized wrappers for Java object types and instead give a typehints structure with a list of accepted conversions supplied either by the system or the user.  Thus we would be able to hands Python Path to Java Path, Python Date to Java Date, Python SQL to Java SQL, etc transparently by simply adding a conversion to the typehints for the Java class.  It will consult either if the types is specific, derived from, or has an attribute (duck).  The hard part is getting reasonable performance out of it as I do not want to call arbitrary python code during the resolution phase of the process.  Once the method has been resolved, we can perform the conversion either in C++ or by calling back to Python to get the appropriate Java object type.  Thus rather than doing this in C++ with fixed tables, I would have just added Python String to Java String conversion to the CharSequence accepted conversion list.  You could apply this to other classes, but the result would just be Java receiving a Java String as one of the arguments something you can achieve already with casting.   The wrappers for primitives have to stay as they are as they require fixed rules to prevent passing arbitrary pointers to Java. Unfortunately, I am not there yet so the best I could do in this limited case is give the JPString conversion class to the CharSequence.
This may have some security implications.  As we provide generalized monkey patching to the Java classes there is always a possibility to insert arbitrary python code into our Java conversion process.  But I do not believe that Python has anything approaching a secure class model thus we aren’t adding anything that wasn’t there already, and as Java will force the type checking on its side, it shouldn’t be possible to call something which isn’t already available.

Thanks for the detailed explanation. It makes much more sense to me now.


bug in Localization

hi, great work.
There seems to be a bug in
image_patches = unfold(image).squeeze(0).reshape(-1, 3, *self.kernel_dim )
it's not unfolding correctly.
This worked for me
image_patches = unfold(image).squeeze(0).permute(1,0).reshape(-1, 3, *self.kernel_dim )
btw,  KDE is used for anomaly detection in the code, but in my experiments it's not necessary and slow. A simple Gaussian estimation using sklearn's mixture of gaussian estimator is fast and working fine. Just a suggestion.

hey, are you able to get localization.py to work? if yes, can you upload the code? Thanks in advance


Implement basic bot and responses.

[x] Implement basic bot
[ ] Ask for repeated input if don't understand
[ ] Respond to basic sentences like greetings.

Issue migrated to https://github.com/WaldurChatbot/FleepBot/issues/1

Associated functional requirement: 1


File not found error when drag and drop from a zip file

VSCode Version: 1.21.1
OS Version: Windows 7

Steps to Reproduce:

Open a zip file
Drag and a drop a file from the zip to the VSCode window
Unable to open 'setup.xml': File not found (file:///c:/Users/YELGUZ~1/AppData/Local/Temp/7zE8FA66FD2/setup.xml).

=> The folder 7zE8FA66FD2

doesn't exist !

Does this issue occur when all extensions are disabled?: Yes/No
Yes

@ysnjzl does it help if you configure "workbench.editor.closeOnFileDelete": false?

Hi,
No it does not solve the issue.
Please find the reproduction's GIF attached.
Thanks & Best regards

@ysnjzl I suspect that the zip program is not fast enough providing this file when you drag and drop. I suggest you file an issue to them.

@bpasero
Hi,
I am using 7zip as a default program, and I tried also with winrar and I have the same issue.
Please note that I am a new user of VsCode and I don't have this issue with :

SublimeText
Notepadd++
Atom
So my guess, it has nothing to do with the zip program, as it is working for the other editors...

Hope is clarifies,
Thanks & Best regards.


php artisan migrate failed

Describe the Bug
Hello,
I'd tried to install the Bookstack on a VPS server using MariaDB 10.6 and PHP 8.2, but I found an error during the php artisan migrate, please see below:
  SQLSTATE[HY000]: General error: 1364 Field 'password' doesn't have a default value (SQL: insert into `users` (`email`, `name`, `system_name`, `email_confirmed`, `created_at`, `updated_at`) values<EMAIL_ADDRESS>Guest, public, 1, 2023-08-02 18:46:58, 2023-08-02 18:46:58))

  SQLSTATE[HY000]: General error: 1364 Field 'password' doesn't have a default value

Steps to Reproduce

sudo su - bookstack
git clone https://github.com/BookStackApp/BookStack.git --branch release --single-branch www
composer install --no-dev

Expected Behaviour
"php artisan migrate" should be successful without error
Screenshots or Additional Context

Browser Details
No response
Exact BookStack Version
v23.06.2
PHP Version
82
Hosting Environment
AlmaLinux 9.2, installed using manual method.

Hi @donatid,

What's the output of running git status from your BookStack install directory?
Have you installed php and/or mariadb from external repos? I'm not seeing those versions within default Alma 9 repositories.
Have you applied any specific changes to mariadb-server config after install?

Hi @ssddanbrown

Here is the output from git status command:
git status
On branch release
Your branch is up to date with 'origin/release.'

Changes to be committed:
(use "git restore --staged ..." to unstage)
modified:   app/Config/database.php
Here is what I have added to databases.php:
        'mysql_ssl' => [
            'driver' => 'mysql',
            'url' => env('DATABASE_URL'),
            'host' => env('DB_HOST', '<IP_ADDRESS>'),
            'port' => env('DB_PORT', '3306'),
            'database' => env('DB_DATABASE', 'forge'),
            'username' => env('DB_USERNAME', 'forge'),
            'password' => env('DB_PASSWORD', ''),
            'unix_socket' => env('DB_SOCKET', ''),
            'charset' => 'utf8mb4',
            'collation' => 'utf8mb4_unicode_ci',
            'prefix' => '',
            'prefix_indexes' => true,
            'strict' => true,
            'engine' => null,
                        'sslmode' => env('DB_SSLMODE', 'prefer'),
            'options' => extension_loaded('pdo_mysql') ? [
                                PDO::MYSQL_ATTR_SSL_VERIFY_SERVER_CERT => false,
                                PDO::MYSQL_ATTR_SSL_CA => env('DB_MYSQL_ATTR_SSL_CA'),
                                PDO::MYSQL_ATTR_SSL_KEY => env('DB_MYSQL_ATTR_SSL_KEY'),
                                PDO::MYSQL_ATTR_SSL_CERT => env('DB_MYSQL_ATTR_SSL_CERT'),
            ] : [],
        ],

Yes, I'm using MariaDB 10.6 cluster and connected through SSL. The PHP was compiled and installed from the source. The MariaDB client version is MariaDB-client-10.10.5-1.el8.x86_64
I'm unsure about the questions. I'm using this server for several Laravel apps, which works fine.

Thanks

Okay, yeah, we don't support or advise custom changes to app files, like those you've made to the db config file.
Changes to app files may cause issues and/or interfere with updates.
It's specifically the 'strict' => true, part of the added config that's causing trouble, since we don't use strict mode in the default connection.

Hi @ssddanbrown
You're correct, the error is gone, and the migration was successful after I changed the strict value to false.
I'll close this issue.
Thank you very much


Fix broken rendering in case of Array with +oneOf+

If the schemas provided inside oneOf of array items is not a ref,
the rendering fails because it tries .upcase on an Integer.

@geemus I didn't add any failing schema examples because it's obvious that .to_s can't be used in an Integer. Please let me know if you like to see examples. Otherwise, would appreciate it if you could merge this and release a minor/patch version.

@geemus I didn't add any failing schema examples because it's obvious that .to_s can't be used in an Integer. Please let me know if you like to see examples. Otherwise, would appreciate it if you could merge this and release a minor/patch version.


Merge branch 'feature/core-#158' into develop

Quality of life improvements + new models

Codecov Report

Merging #161 (f27b106) into master (ff80129) will decrease coverage by 0.20%.
The diff coverage is 92.45%.

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   97.99%   97.78%   -0.21%
==========================================
  Files          53       61       +8
  Lines        2092     2306     +214
==========================================
+ Hits         2050     2255     +205
- Misses         42       51       +9

Impacted Files
Coverage Δ

glasses/nn/models/__init__.py
100.00% <ø> (ø)

...sses/nn/models/classification/resnetxt/__init__.py
92.85% <ø> (-4.12%)
:arrow_down:

glasses/nn/models/classification/senet/__init__.py
100.00% <ø> (ø)

...s/nn/models/classification/wide_resnet/__init__.py
100.00% <ø> (ø)

test/test_EfficienetNet.py
100.00% <ø> (+4.81%)
:arrow_up:

tmp.py
0.00% <0.00%> (ø)

...lasses/nn/models/classification/regnet/__init__.py
77.23% <77.23%> (ø)

glasses/utils/PretrainedWeightsProvider.py
96.29% <81.81%> (+0.03%)
:arrow_up:

glasses/__init__.py
100.00% <100.00%> (ø)

glasses/nn/__init__.py
100.00% <100.00%> (ø)

... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1967f29...f27b106. Read the comment docs.


Support | (\u007C) or ┆ (\u2506) as column separator.

Scenario: [nth]
   Given [nth]
   When [char]
   Then [name]

Examples:
    nth    ┆ char ┆ name
    First  ┆  -   ┆ dash
    Second ┆  |   ┆ pipe

Why:

It's important when | (\u007C)  is part of data and it's pretty than escaping (|)
Simple to parse: if line has ┆(\u2506) use it else use | (\u007C)  as column separator

The | character isn't used frequently in anything else than code.
Gherkin is not a language that is designed to embed code - it's designed to be used with human language.
Adding another separator to make it easier to use | in cell values sends a signal that we want to make it easier for people to embed code in Gherkin. That's the opposite of what we want people to do, so I'm not keen on adding this. I think escaping is sufficient. It's ugly, but that's good. If you're compelled to use | in cell values you're probably doing something wrong.

I would like to see a real-world example where this would be useful.

@aslakhellesoy, I sorry about disagree and and sorry too about my poor examples. I'm not a Gherkins founder and I'm learning it now. But, would be very nice if we can use it too in more complicated things, like transpiling, systems integration, text conversions, etc.
I don't wanna a scripting tool, sorry again about my examples. But it's my business work with complex data internally, with vendors and with customers.
@mattwynne , I work with medical systems. Often I need integrate with machine systems others vendors. Below is a real sample.
Scenario: HL7 Clinical Chemistry Integration
   Given a LIS integrated by HL7
   When LIS recieve [message]
   Then LIS must emit a [report]

Examples:
   message                                                                   ┆ report
   ----------------------------------------------------------------------------------------------------
   PID|1|1034157|012993817||SNOW^JOHN||19520101|M|||1234 MAIN^^DEARBORN      ┆ JOHN SNOW, Male, 63 years
   OBX|2|NM|2093-3^CHOLESTEROL^LOINC|138.000|MG/DL|100.000 - 200.000|N|||F|  ┆ Cholesterol 138 mg/dl

Thanks for the real-world example @thr0w - that makes a lot more sense now. I'm reopening this.


A2C saving and loading issues

I was unable to save my model with the save function in the Model class. I had to change it to:

def save(path, model_name):
ps = sess.run(params)
make_path(path)
joblib.dump(ps, path + model_name)

However, when I try to load the model, I get this error:

tensorflow.python.framework.errors_impl.InvalidArgumentError: Shapes must be equal rank, but are 1 and 4 for 'Assign_1' (op: 'Assign') with input shapes: [32], [1,32,1,1].

Are ther some example code that saves and loads a model?

I suspect tensorflow sessions don't play nicely with joblib.dumps serialization for some reason.
Could you provide more info on how were you trying to save and load the model?
Alternatively, the routines for saving / loading the default tensorflow session can be found here:
https://github.com/openai/baselines/blob/69f25c6028d71e23a7b267b0e1071ad216290f91/baselines/deepq/utils.py#L9
(this code will soon migrate into common.tf_utils)

my bad, I think this is still a problem

At a closer look, the save/load methods in A2C and PPO2 don't have a bug per se, but can be sensitive to the way the model is loaded.
For instance, the following snippet works (and loads trained model) in the master branch:
(assuming save_path is a non-existing path to the file where the model will be saved)
with tf.Graph().as_default(), tf.Session().as_default():
            # train and save the model
            model = a2c.learn(policy=MlpPolicy, env=env, total_timesteps=50000, seed=0)
            model.save(model_path)

with tf.Graph().as_default(), tf.Session().as_default():
           # load the model - train the model for zero steps and then load the parameters
           model = a2c.learn(policy=MlpPolicy, env=env, total_timesteps=0, seed=0)
           model.load(model_path)

Ideally though is to have more serialization (pickle, json)-like API, in which, for instance, a2c.load(path) returns the trained model. I'll mark this is as an enhancement instead of a bug, and we'll work on this as part of the trainer <-> policy api.

@pzhokhov Just to be clear, it seems like there's two ways to save the model: using the model.save and the tensorflow saver that deepq uses? And similarly for loading? Which one is the recommended way with A2C?

@DanielTakeshi the model.save and model.load are actually rather similar (at least in usage) to tensorflow saver used by deepq load_state and save_state - both save / restore the tf variables in the current tf session; both require re-initialization of the model when loading; both allow to continue training. Which one these to use is largely a matter or convenience / preference (at least at the moment).

Model.save in a2c.py:
def save(save_path):
    ps = sess.run(params)
    make_path(save_path)
    joblib.dump(ps, save_path)

raises IsADirectoryError, because indeed, save_path is a directory.

Instead, I guess it should be something like this
def save(save_file):
    ps = sess.run(params)
    path = os.path.dirname(os.path.abspath(save_file))

    if not os.path.exists(path):
        make_path(save_path)

    joblib.dump(ps, save_file)

And a2c.learn should return the model, instead of None.

Oh, I see. The pip version is outdated.

@saddy001 correct, the version in pypi is rather outdated. Please use the github instead.
We would like baselines to be less of a library, and more of a collection of algorithms for people (and AIs :)) to play with, so there was an decision to stop releasing the pypi package.
The fix for original problem went in with the recent refactor PR; so I am closing this issue.


Link component

Duplicates ❌

[X] I have searched the existing issues

Which Figma library is concerned?
Vitamin Web UI Kit
Summary 💡
Improve component with properties and token.
Apply specific text style.
Examples 🌈
[Link – Carbon Design System (https://www.carbondesignsystem.com/components/link/usage/)
Photon Design System
Motivation 🔦
No response
New 🆕

[ ] Validated in a grooming session

Backlog 📋

[ ] Has a good summary
[ ] Has example link(s)

Design in progress 🏗

[ ] Analysis (functional & technical)
[ ] Design refinement
[ ] Dev qualification (properties, breakpoints, tokens etc.)
[ ] Documentation refinement (inside the Figma branch)

Design review 👀

[ ] Figma branch merged
[ ] Documentation review _(and move the documentation into Vitamin Documentation Figma file)

Ready to dev 👍

[ ] Issues are created in all repositories affected (vitamin-<web,android,ios,compose>)

Dev in progress 💻

[ ] All issues are resolved (to replace with issues links)

We should include the possibility to change the right icon for example to have a right chevron instead of external link.
Do not allow the possibility to change with any icon : define a short list of icon available.

A new ticket has been created on an inner source repository


Pure Pytorch Implementation Model Export for Quantization

Hi all,
Is there a way to generate a pure PyTorch Python Model Implementation out of the model configuration ?
I'm looking something like tools/deployment/mmdet2torchserve.py to export a Python file with the PyTorch model.
I want to be able to tweak the pure model to be able to quantize it (optimization using quantization).
If not, is there a way to quantize a mmdetection model ?
Thank you,
Daniel.

Is there a way to quantize a mmdetection model?
Is there a way to quantize a mmdetection model, after it has been trained?
Thank you!

We have not considered model quantification.
If you can support it in MMDetection, we welcome your PR.


Feature/62 key sequences

Description
Introduce key sequences and combinations listeners.
Close #62
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Minor fixes
Use queryable_type_t in registry modifiers instead of getStorageType, which was discarding all the chained modifiers.
How Has This Been Tested?
New tests have been written
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Codecov Report

Merging #77 (ca9f811) into main (16a103f) will increase coverage by 2.07%.
The diff coverage is 68.57%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   47.92%   50.00%   +2.07%
==========================================
  Files          39       43       +4
  Lines         722      784      +62
  Branches      204      231      +27
==========================================
+ Hits          346      392      +46
- Misses        256      261       +5
- Partials      120      131      +11

Impacted Files
Coverage Δ

...rations/event/listeners/KeyCombinationListener.hpp
0.00% <0.00%> (ø)

...tegrations/event/listeners/KeySequenceListener.hpp
0.00% <0.00%> (ø)

.../ecstasy/integrations/sfml/demo/02_events/main.cpp
0.00% <0.00%> (ø)

src/ecstasy/query/modifiers/Maybe.hpp
84.61% <ø> (ø)

src/ecstasy/integrations/event/EventsManager.cpp
77.27% <60.00%> (-3.68%)
:arrow_down:

...rations/event/listeners/KeyCombinationListener.cpp
74.07% <74.07%> (ø)

...tegrations/event/listeners/KeySequenceListener.cpp
79.16% <79.16%> (ø)

src/ecstasy/registry/Registry.hpp
70.27% <100.00%> (+2.62%)
:arrow_up:

src/ecstasy/resources/entity/Entity.hpp
41.17% <0.00%> (-5.89%)
:arrow_down:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Path completer tests and expand user

@jonathanslenders
This PR adds tests for the PathCompleter and fixes #170
It replaces #171 which I am closing now.

@jonathanslenders After some laborious fixes of the Python 2/3 unicode issues, this PR is clean now. I can squash the commits in one if you prefer this.

@jonathanslenders any feedback?

Yes, sorry about the delay. I've not had the time yet to reply.
This looks good to me. I'm going to merge it. Don't worry about the squashing, I'll do that.
Thanks a lot! Also for all the tests!

Thank you for this! Verified and merged in https://github.com/jonathanslenders/python-prompt-toolkit/commit/d4cd4f7c6ae6d2ca8304a3c54087b314de0b3755

:+1:


Missing and inconsistent data

The database contains a lot of outdated/missing data in a lot of places.  As well as a lack of numerical value distinction (i.e. integers, percentages and kgs are all stored as integer values). Developing a parser for this database has served to be a very difficult task. I could also see this being very inconvenient for wiki maintainers, as incorrect information isn't very useful.
Will there be an update soon addressing this issue?
Note: Missing/outdated data is consistent between both realms (global and ru)

We've update the database today, now it schould include latest information about items. We've also added pre-formatted parameter string, it should make it easier to display percentages/kgs/etc.

Thank you :D


Fix Makefile and Add jwai7 to the reviewers list

What type of PR is this?
Minor fix
What this PR does / why we need it?

Fix Makefile for make serve
Add user jwai7 to the reviewers list

/lgtm


feat: add okpos for payments

Sorry @hewison-chris, I need to merge this first so order-service can continue to run and build

CI error:
https://github.com/Sicpama/order-service/actions/runs/9074718326/job/24935147306


186170914 XY Plot Attribute Selection

PT Story: https://www.pivotaltracker.com/story/show/186170914
This PR adds support for attribute selection in the XY Plot tile.

Attributes selected in other linked tiles (like columns in the table) will cause the corresponding dots in the xy plot tile to highlight.
The corresponding series dropdown in the legend will also become highlighted when the attribute is selected.
Setting a series in the legend will cause the associated attribute to become selected and highlighted in all linked tiles.

This PR also fixes a bug where deselecting all cases in another tile would not cause the highlights in the xy plot to disappear correctly.
One potential source of confusion is that selecting the attribute on the x axis for an xy plot will cause ALL of its dots to become highlighted. This is because all dots have two attributes associated with them, the x and the y, and since they all share the same x attribute, they will all become highlighted when that attribute is selected. For the time being, this is expected behavior. But I wouldn't be surprised if we wanted to change this behavior down the line.

@tejal-shah Whenever you're ready for another check, I addressed points 1-3 you brought up.
For 1, I ended up changing it so you no longer highlight the series when you add a new one. This was the easiest way to reach parity with removing a highlighted series, and I think it fits with the PT story as written. It also better follows how adding a column to a table works. It's probably worth considering alternatives for this moving forward, but for now I hope this behavior is ok.

@tealefristoe , both points  and 2 look fine now. Point 3 still seems to be happening at my end i.e when I click away in an xy-plot that has one or more points highlighted by clicking near the legend area or near the axes, the highlighting doesn't go away. Thi isn't a big deal but I just wanted to let you know that it still happens for me.

@tejal-shah I see what you mean--clicking the background of the actual graph will deselect everything, but clicking the background of the axes or legend won't. This is how it's worked previously for deselecting cases. I'm not sure why this design choice was made (or if it was intentional or just happened to go this way), but I think it would be appropriate to have a separate story for that behavior change.


complete to client needs to wait for complete on server

currently, complete on the active does not wait for complete on the passive before acknowledging back to the client.  active needs to wait for complete on passive before acknowledging back to the client that the operation is complete.

Fixed with PR#267.


Thank you!

This is not really an issue, just a message for you.  Feel free to close this after reading.
I wanted to thank you for this project.  My wine setup broke locally after another update and I was stuck without Zwift when I wanted to workout which is really annoying.
Found this project and it just works like a charm, so than you for all the work!

Nice to hear, thank you. Yes my intention with this project was to have a place where we can collaborate on creating a reliable Zwift setup that will hopefully work for all. And when there are issues, more people can help in resolving them.
It's not by any stretch a perfect solution today, but I think it gives the majority of its users a pretty pain free and simple setup. As all software should be!
Cheers.

Oh, and by any chance would you have the know how and willingness to support me on #28? I see you have som nix in you :wink:

I'd sure be willing, just need to understand what the concrete problem is you want to solve ;)

@markus1189 As said in the issue, i'd really like to explore a nix flake that could build the different described variants. However the concept of impure/pure builds as well as the sandboxed environment given for builds makes the building and installation of zwift quite challenging. Especially since nix is not my strong suit. I have tried a couple of experiments, but nothing that's produced anything concrete.


Updated project to Swift 3.0

Thanks @jameshurst - in the interest of my sanity, I'm not going to merge this until Xcode 8 goes GM.

Any chance we can get that merged now that Xcode 8 went GM?

@jameshurst - can you update your PR to specify osx_image: xcode8 at the top of .travis.yml? I'd like to make sure CI works before merging this to master.

@jflinter I've run the Swift migrator on the example application and updated .travis.yml.

Thanks @jameshurst - it looks like the new Travis Xcode VMs have some weird keychain issues; I'll try and figure them out over the weekend and merge this once I do.

Hey @jameshurst - will you give me permission to push to your fork, using github's new fork collaboration option? It'll be easier for me to figure out these Travis issues, and I'd like to see how the new fork thing works anyway : P

@jflinter that should be enabled now

Had to make some CI fixes, but this is now merged. Thanks @jameshurst !


Total Time reports hour rounded up

I have noticed that the Total Time formatting is wrong.
Here the 2362s run is reported to have taken 1h 39min and 22 sec.
However 2362s is just 39min 22 sec.
Total time: 01:39:22 (2362.03 sec)

// * Summary *

Host Process Environment Information:
BenchmarkDotNet=v<IP_ADDRESS>
OS=Microsoft Windows NT 6.2.9200.0

It appears to be the formatting in this method https://github.com/PerfDotNet/BenchmarkDotNet/blob/c6405a91bee90de6a12aee24755fbb783c2d9052/BenchmarkDotNet/Running/BenchmarkRunner.cs#L159
I would have thought that this line
var hhMmSs = $"{time.TotalHours:00}:{time:mm\\:ss}";

could just simply be
var hhMmSs = $"{time:hh:\\mm\\:ss}";

Or is this intended to cater for >24hr benchmark runs?
If so then, perhaps truncate the total hours first - http://stackoverflow.com/questions/2820141/stringformat-double-without-rounding

@LeeCampbell, thanks for the bugreport. Will be fixed in the next version.


Pocket MuuMuu Antipiracy screen

tonyhax version: 1.4.3
Game name: Pocket MuuMuu
Game code: SCPS-10076
Executable hash:
MD5: 84607a1febb810417e14d84024be1055
SHA-1: 143548b27fe15627481988feb0762f5399b336dc
Triggered at: immediately after loaded the disc, no logo appears
Is the console chipped?: yes
Is it an original disc or a burned copy?: original disc

Fixed in current version. Coming tonyhax v1.4.4 will properly support this game.

Available in tonyhax v1.4.4


move logic from /server/utils/user-databases.js to hoodie-store-server

see https://github.com/hoodiehq/hoodie/blob/82897fd/server/utils/user-databases.js#L2-L4

this is done :)


List papers page

Please do work for this task in a branch named issue-06.

allow users to see all papers that have been uploaded to website

add to navbar

future functionality: add filitering to page

cut off abstract, limit to 100-200 characters


missing Constructor

For
void nok1() {
    Botan p = new Botan(1);
    p.set_key(key); // not allowed as start
}

there is no constructorexpression in the cpg. seems to be a bug

cpg seems to be correct, had another error during execution...


Generalize generalize

Just the first step

Okay, I believe I've officially run out of things to further generalize.


Shl branch

Code rewritten efficiently. Extra functionalities added and some bug fixes. Will continue to be improved upon.


🧹 Use aliases instead of relative imports

Lots of updated files! Have fun @spolu 😛
closes #167

Hahah! Will review. Bullish on this 👍

By review I mean testing each page separately 😅

@gmpetrov  Do you manage to resolve paths from VSCode with path aliases ? I would have expected it to pick up the tsconfig.json but apparently it does not (things like cmd+click or go to definition don't work).
Is there a specific setting to turn on ?

@fontanierh Yes, it works well on my side with vscode. I'm able to go to def etc...
Do you load dust's root folder in vsode ? or just front?


Publish on npm

This should be published on npm for easier consumption

Hi,
There is already someone publishing it https://www.npmjs.com/package/readme-generator-for-helm

Hi @miguelaeh Can I open a PR to add it to the README?
It would save some hassle when contributing to the bitnami charts repo.

Sure!

Ok I just did some due diligence before adding it: the author's fork is not automatically updated and differs slightly from the official repo.
Current options I see:

@miguelaeh would it be possible to add a @bitnami NPM token in the GitHub actions secrets? I'm happy to draft an auto-publish action so this repo can publish to https://www.npmjs.com/package/@bitnami/readme-generator-for-helm
@alexjamesmalcolm would you consider replacing the https://www.npmjs.com/package/readme-generator-for-helm with code from this repo and auto-publish on a schedule? You can achieve this with GH actions as well and I'm happy to help
@alexjamesmalcolm if you don't want to be bothered, would you consider transferring the package to me?

Hello, sorry for accidentally publishing this, I made a mistake when I was trying to publish it as @alexjamesmalcolm/readme-generator-for-helm. @miguelaeh, do you have any thoughts on me transferring the NPM package to @politician?

Hi. Following this issue for a while now. Would there be any disadvantage of publishing it within the @bitnami namespace? It seems to be some sort of a deadlock situation right now; speaking from an external point of view.

Hi @alexjamesmalcolm, we need you to transfer that npm package to Bitnami (https://www.npmjs.com/org/bitnami) because we are the maintainers. Please, could you let me know when you addressed it in order to work on our side to publish updates there?
Cheers

Would it be a solution to rename the package in package.json to <at>bitnami/readme-generator-for-helm and publish it as such? That way the transfer wouldn't be necessary for this issue to be resolved.
Or do you want to publish it outside the org scope on NPM?
Drawback: Different package name. Package usages referring to GitHub might be broken?

Hi @justusbunsi, that's not the solution. The problem is @alexjamesmalcolm published our package under his scope and it shouldn't be in that way according to the product. That's why the easiest and cleanest solution IMHO is transferring the package to the org which it belongs to.
Thank you for the heads up!

Fair point. Sounds reasonable. 👍

Hello @agomezmoron.
I'm following this NPM documentation and trying to add "bitnami" as a maintainer and then remove myself, thus transferring ownership. The problem is that "bitnami" is an organization and you cannot invite organizations.
I was able to find @miguelaeh on NPM as angelrb so I have invited @miguelaeh to be a maintainer. Once @miguelaeh accepts the invitation I'll remove myself and then hopefully it can be managed under @bitnami somehow.

Hi @alexjamesmalcolm,
Thank you. @miguelaeh is not part of Bitnami currently so I think the easiest easiest way can be:

You unpublish it https://docs.npmjs.com/unpublishing-packages-from-the-registry
Once unpublished, we will publish it as owners.

Thanks

@agomezmoron I unpublished/deleted the package.

Thank you @alexjamesmalcolm , we will work in its publication then.

Waiting anxiously for this to get published as our CI is now broken! :)

The package was published on npm and will keep publishing with the incoming changes.
I'll close this issue then.
Cheers

It looks like @bitnami/readme-generator-for-helm is available on NPM, but the readme here still suggests installing from Git.


s3: refactor prefix code

Trying to contain the prefix logic in the package itself.
This would help https://github.com/coreos/etcd-operator/pull/689

fixed

lgtm


I can't go beyond version 7.9 in Docker  - In 7.9 I cant generate Ifra Certificates, export to pdf or add suppliers

Describe the bug
In version 7.9 nothing happens when I click on generate IFRA certificate. In the same dropdown nothing happens when I click on export to PDF. When I try to add a supplier it says I have not written the suppliers name even though I have. Its really important that I can generate an IFRA certificate, and docker doesn't let me go beyond 7.9
To Reproduce
Steps to reproduce the behavior:
selected formula from finished formulas, clicked on generate, went to the drop down and clicked on IFRA certificate. Nothing happens. All my formulas are in the green and I have uploaded IFRA 51.
Expected behavior
generation of IFRA certificate.
Screenshots
If applicable, add screenshots to help explain your problem.
Please complete the following information:

Platform: [docker]
Browser [e.g. chrome, edge and firefox]
PV Version [e.g. 7.9]

Additional context
Add any other context about the problem here, also provide details regarding your installation.

Version 7.9 isn't maintained, you have to upgrade to the current version. Please note that you cannot directly upgrade 7.9 as on version 8.0 the deployment method has been changed. For more details see https://www.perfumersvault.com/knowledge-base/howto-docker/


Adds WebsiteSubmission model.

Creating PR to get Travis on the case, but if you want to r? @ngokevin, I wouldn't be opposed.

looks good on skim

r+ for me


[1.16.5] can't open/create a world after quiting a other

The mod works fine, my Portals are working fine. but after I leafe a single player world and try to join it again, or a other, it doesn't work. I find this in the log:
[15:58:14] [main/WARN]: Failed to load datapacks, can't proceed with server load
java.util.concurrent.ExecutionException: java.lang.IllegalAccessError: tried to access field net.kyrptonaught.customportalapi.CustomPortalApiRegistry.portals from class net.kyrptonaught.datapackportals.DatapackPortalsMod
	at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357) ~[?:1.8.0_51]
	at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1887) ~[?:1.8.0_51]
	at net.minecraft.class_310.method_29604(class_310.java:1959) ~[intermediary-1.16.5.jar:?]
	at net.minecraft.class_310.method_29610(class_310.java:1808) [intermediary-1.16.5.jar:?]
	at net.minecraft.class_310.method_29607(class_310.java:1752) [intermediary-1.16.5.jar:?]
	at net.minecraft.class_525.method_2736(class_525.java:298) [intermediary-1.16.5.jar:?]
	at net.minecraft.class_525.method_19922(class_525.java:238) [intermediary-1.16.5.jar:?]

Hope this can be fixed.

1.0.3 was uploaded to curse with a fix for this


Fixing 404-ing documentation links

A recent documentation shuffle has broken or invalidated a lot of links used in our notification templates - either rehoming them into different OSD/ROSA links or removing them altogether due to unnecessary duplication with OCP documentation.
This PR fixes as many of the ones as I was able to find.

This fix is good as it fixes broken links, however some links are being replaced with links for OCP as those pages no longer exist for managed openshift. if we use those links, it can potentially imply that OCP docs are applicable to managed openshift, which is not always the case.
@rh-wadhwani  @sajeelirkal @cattias what do you think?


CSV file created with Excel for Mac fails

From<EMAIL_ADDRESS>on August 31, 2014 14:06:31
I tried importing the Excel file attached with the following code:
reader.onload = function(e){
var csv = e.target.result;
var csvArr = $.csv.toArrays(csv);
}
resulting in 'Error: CSVDataError: Illegal Data [Row:1][Col:1]'.
I noticed that most scripts use a regex like 'csv.split(/\r\n|\n/);', which isn't working for this file. But the regex 'csv.split(/\r/g);' is. Don't know if that is in any way related to the error above, but just in case...
Attachment: xlsx-file-upload-test-file-email.csv
Original issue: http://code.google.com/p/jquery-csv/issues/detail?id=44

From<EMAIL_ADDRESS>on December 14, 2014 21:12:41
Because Excel for mac uses CR (carriage return) as the default line line ending for formatting. A convention that even Mac quit using when they transitioned from OS9 to OSX.
I don't know if that's the cause of your problem but the code available in the repository properly handles old mac style line endings.
I'll be dropping a new release soon that should include the fix. I'll try it with your sample to see if it that's the issue.

From<EMAIL_ADDRESS>on December 15, 2014 02:10:59
I noticed indeed that it's just a difference between Excel for Mac and Excel for Windows; when you save files in Excel for Mac you can choose a specific format that is compatible, but it's not the default option. The default option, even after the latest updates, uses different line endings then Excel for Windows does. So it's not just old Mac's, it's also present on OS X Yosemity with the latest Office for Mac release.
If I can be of any assistance, I would be glad to help out and/or test it for you. Thanks so much for looking into it!

From<EMAIL_ADDRESS>on December 15, 2014 02:19:37
Thanks for chiming in. Sorry if I wasn't clear. What I meant was...
Even on the most recent versions of Excel for Mac, the default for line endings is CR. Despite CR being obsolete since the transition from OS9 to OSX. OSX -- as a Unix based system -- uses LF as the default line ending for everything.
I'm not sure if the Microsoft devs are just ignorant about OSX conventions or if they wrote it that way intentionally as a tongue-in-cheek FU to Apple.
If only MS Office had a public bug tracker. If only...
Either way, the source available in the repository (ie not the latest release) should contain a fix that properly handles CSV source with CR line endings.


I think there is serious issue with readme file

There is a full stop missing in the last paragraph

Are you sure?

yes i am sure about it as i have gone through whole readme file. I can solve this issue if you don't mind.


[Statistics cards] Start on a statistics card

Avoid duplicates

[x] This enhancement request has not already been raised before
[?] Enhancement request is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in CWA-Wishlist
[x] If you are proposing a new feature, please do so in CWA-Wishlist

Current Implementation

If you start the app and scroll down to the statistics, you start on the edit/add new incidence screen.
Suggested Enhancement

Start on a statistics card, probably the most right local or the nationwide card.
Expected Benefits

Start where you most likely want to be.

I can't see this issue on Android, so perhaps it is an intermittent iOS bug?
I see this issue was first posted to iOS anyway.
If it comes back or persists on iOS then probably a bug report for iOS would be good.

Yes. Seems fixed. Tested as follows:

start cwa, main screen, scroll statistics to the far left (edit / new incidence)
scroll up and down
see animated auto-scroll to a true statistics card

cwa 2.7.2 / iOS 14.4.1
@jucktnich please confirm

Couldn't reproduce close as fixed/implemented


Add apoc functionality

We need apoc functionality for loading JSON data; this PR adds that functionality. We need to copy a custom apoc file into the image, so we need a new Dockerfile (there's a bug when mounting the config folder, so we can't do it that way)

Great job!


goodreads test changed

Signed-off-by: lejinvarghese<EMAIL_ADDRESS>

Codecov Report
Base: 73.78% // Head: 74.49% // Increases project coverage by +0.71% :tada:

Coverage data is based on head (060d45a) compared to base (5846369).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   73.78%   74.49%   +0.71%
==========================================
  Files          11       11
  Lines         534      549      +15
==========================================
+ Hits          394      409      +15
  Misses        140      140

Flag
Coverage Δ

unittests
74.49% <100.00%> (+0.71%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

utils/api/goodreads.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


TASK: Create symbol address list

We need to create a generated list for each symbol, not each revision, somehow. Either macro or existing structure method.
Then we can use it in Cxbx-Reloaded project to make references for patch and trampoline to avoid workaround we have at the moment.

The list generation and HLE Cache file generation can remain in Cxbx-Reloaded, as they are function specific.
I was thinking that the Symbol Scanning engine would remain in this project, outside of Cxbx-Reloaded, so that it could be called in this manner
Cxbx-Reloaded code:
std::map<std::string, xbaddr> g_SymbolAddresses;
void SymbolCallback(char* symbolName, xbaddr symbolAddress) {
  g_SymbolAddresses[symbolName] = symbolAddress;
}

XbSymbolScan(SymbolCallback);  // Call into this library
CxbxApplyPatches(); // Iterate through g_SymbolAddresses & resolve patches

And everything else would remain in this project.
The ScanForXboxSymbols function would be part of this library and simply take a function pointer as input, and call it for every symbol found.
That way, the actual method of using the symbols is generic, and the application that uses this library can make all decisions on how to store or use the data returned.

You finally found the best solution! I'm glad you thought about this before I lose my hair. 😉

I'll be doing some work on Cxbx-Reloaded this weekend to decouple scanning and patching, so HLEIntercept/HLEDatabase will be renamed to SymbolDatabase and SymbolScan (so they can easily be removed later, once this project is mature) and there will be new function files for HLEPatch.
That way, the symbol scanning and patching will become entirely separate. Sorry it took so long to get here!

I'm afraid one thing is overlooked : the fact that symbol scanning is using XREF's to 'harden' searches.
An XREF is a pre-defined enumeration, that appears in a few forms :

as an ID for an OOVPA (registered in the XREF table once an OOVPA is found)
as derived XREF's (currently hard-coded from a select few D3D OOVPA)
as cross-checked XREF's (XREF's which have to be found already, and which have to match the potential hit)

Once symbol scanning is completed, it's important to not only return the located OOVPA-based symbol locations, but also include all XREF symbol address. How's that going to play together with the idea of a symbol-callback? Call it afterwards for all XREF's? But by what name? Please discuss...

That's not a problem, the hardening of the scanning using XREFs should remain in this library, as it is part of the scanning code itself and required for accurate symbol location.
The callback should be called for every single found, both XREF and not, so that the calling program can do whatever it likes with this information, but it shouldn't be necessary for the calling program to know anything about OOVPA or how scanning works internally, so it can switched out for other engines too

Sure, I already suggested to do a symbol-callback on each detected XREF too, but again : by what name?

Use the existing XREF enum from the library with by global variable which is XRefDataBase.
It will give you direct address after scanning is done. Unless you had manually input the address for the scan to do. In my opinion shouldn't do that.

Also closing in favor new proposal in #3 to have external project to store it.


Validation Check Failure in vscode yumrepo (linux)

OS Version: OpenSuse Tumbleweed 20191007

Steps to Reproduce:

Get GnuPG key from https://packages.microsoft.com/keys/microsoft.asc
Try to install vscode from https://packages.microsoft.com/yumrepos/vscode
Receiving Validation Check Failure:

"File repomd.xml from repository Visual Studio Code https://packages.microsoft.com/yumrepos/vscode
is signed with the following GnuPG key, but the integrity check failed:
ID: EB3E94ADBE1229CF
Fingerprint: BC52 8686 B50D 79E3 39D3 721C EB3E 94AD BE12 29CF
Name: Microsoft (Release signing<EMAIL_ADDRESS>Created: 10/29/2015
Expires: Never
The file has been changed, either by accident or by an attacker,
since the repository creator signed it. Using it is a big risk
for the integrity and security of your system."

Looks like a duplicate of #82317.


ENH: add annotations-to-metadata transformer

This PR adds two transformers:

eggnog annotations -> Metadata
eggnog annotations -> pd.DataFrame

to allow viewing the FeatureData[NOG] artifacts using metadata tabulate.
Additionally, it adds the annotation_dict method on OrthologAnnotationDirFmt to simplify retrieval of sample/MAG IDs and path to their respective annotation files.

Hey @ebolyen, @Oddant1 - could you have a look? If we merge this soon, we could potentially make use of that in our Monday workshop session...

@misialq and I discussed this in person - the general PR itself seems fine, but a bigger question is whether or not this transformer's functionality in the context of the associated visualization makes sense and is digestible for users. We will most likely refactor this in the future once we have a better approach for this.


Add back 'job' as a post option for retry

By switching from 'job' to 'jobs' in /retry we broke backwards compatibility. We should support to avoid breaking use cases as well as supporting retrying multiple jobs

working on it


CSS issues regarding ion-textarea

Short description of the problem:
We've been experiencing issues with ion-textarea and we're hoping someone can shed some light into the issue. This is our current situation:
We have a view with an ion-textarea element at the bottom of it. It is initially hidden, and the shown once a button is tapped.
When the user focuses into the textarea, the textarea moves to the top of the screen when they keyboard shows up. This is done by adding a padding at the bottom of the element. However, when we tap outside of that textarea, the keyboard hides but the fixed padding stays, thus leaving an empty space at the bottom of the page.
Another issue which might be related is that there is no way to hide the keyboard in iOS, even by tapping outside of the textarea. Is this a bug as well?
Thank you!
What behavior are you expecting?
Remove bottom padding after closing keyboard.
Also be able to close keyboard on iOS when tapping out of the ion-textarea.
Steps to reproduce:
I share with you the related post:
https://forum.ionicframework.com/t/css-issues-regarding-textarea/45919
Also an example of the issue:
http://codepen.io/anon/pen/GZZeov
Which Ionic Version? 1.x or 2.x
2.x
Run ionic info from terminal/cmd prompt: (paste output below)
Your system information:

Cordova CLI: 6.0.0
Ionic Version: 2.0.0-beta.3
Ionic CLI Version: 2.0.0-beta.19
Ionic App Lib Version: 2.0.0-beta.9
ios-deploy version: 1.8.5
ios-sim version: 5.0.6
OS: Mac OS X El Capitan
Node Version: v4.3.0
Xcode version: Xcode 7.2.1 Build version 7C1002

I don't know how to add android label as well :S

Thanks for the detailed issue we really appreciate it! I would recommend asking about how to add labels on android either on our forum: https://forum.ionicframework.com/ or on our slack channel: http://ionicworldwide.herokuapp.com/.

This may be the same issue as #5810

#5302

I have the same bug on android. Ionic 2.0.0-beta.2. It's very annoying.

Seeing this on iOS 1.7.14 as well

Sounds like #5432 getting reported again.

The keyboard is not hiding even when tapped outside of the text area. Android build is working fine, only iOS has this issue. Is there a fix for this?

i cant understand answers here, please give me the proper code how can i solve this problem ,keyboard is up screen and extra space is not going . page height increase when keyboard is open .please give me a proper code and answer.


Cannot Receive Ship Rewards on Savefile

The game does not seem to give me the ship rewards for the Ranger missions (War Eagle) or the Kid Stuff (Wanderwell) trait. In both cases, I receive the correct dialogue and other rewards (and the mission seems to complete normally) but the ship is not added to my ships (nor does the popup appear informing the player that they received a ship). I attempted to reload a save just before the ship reward should be given but that doesn't fix it and I'm no where near the ship limit (only two ships atm). Buying a ship from the vendor does work, but even doing so before attempting to receive the reward doesn't allow me to do so (nor does selling a ship or swapping home ships).
I DID get the Mantis ship way earlier, but I've heard of people being unable to get that one too. My guess is there's something that corrupts a save file that breaks all free ship rewards via quests. I have no idea what that something is, though, and everything else seems to be working.

Details
001A54F9 (The Hammer Falls)
Game Version
<IP_ADDRESS>
New Game
No
Reproduction Steps
Unfortunately I have no idea. I'm not the only one with this issue (see https://www.reddit.com/r/Starfield/comments/16butd8/spoiler_anyone_else_not_getting_the_star_eagle/ https://www.reddit.com/r/Starfield/comments/16butd8/comment/k0b5xpk/?context=3 and https://www.reddit.com/r/Starfield/comments/16abhgc/ship_wanderwell_bug/ )
I'm pretty sure something corrupts a save to prevent these ship rewards as I said, but I can't think of anything I did that would've done so, so I suspect it must be something one wouldn't expect.

Maybe of note: Enabling payprus logging, I see many ship related stacks frozen due to the guard: "playerShipsChangeLock"
stack:
[SQ_PlayerShip (000174A2)].sq_playershipscript.ResetPlayerShip() - "E:\BuildAgent\work\4c7f7506a0fb268b\Source\Scripts\SQ_PlayerShipScript.psc" Line 395
[SQ_PlayerShip (000174A2)].sq_playershipscript.::remote_Actor_OnSit() - "E:\BuildAgent\work\4c7f7506a0fb268b\Source\Scripts\SQ_PlayerShipScript.psc" Line 569
[09:20:40] warning: Stack potentially stalled - waiting on guard for at least 3572.83 seconds (possibly longer)

Here's one such stack trace:
[09:45:58] 	Stack trace:
[09:45:58] 		[SQ_PlayerShip (000174A2)].sq_playershipscript.ResetPlayerShip() - "E:\BuildAgent\work\4c7f7506a0fb268b\Source\Scripts\SQ_PlayerShipScript.psc" Line 395
[09:45:58] 			IP: 0	Instruction: 0	Line: 395
[09:45:58] 			[newPlayerShip]: [SpaceshipReference < (0014E2FA)>]
[09:45:58] 			[::temp116]: False
[09:45:58] 			[::temp117]: None
[09:45:58] 			[::nonevar]: None
[09:45:58] 			[::temp118]: None
[09:45:58] 			[::temp119]: False
[09:45:58] 		[SQ_PlayerShip (000174A2)].sq_playershipscript.::remote_Actor_OnSit() - "E:\BuildAgent\work\4c7f7506a0fb268b\Source\Scripts\SQ_PlayerShipScript.psc" Line 569
[09:45:58] 			IP: 643	Instruction: 9	Line: 569
[09:45:58] 			[akSender]: [Actor < (00000014)>]
[09:45:58] 			[akFurniture]: [pilotseatfurniturescript < (0117E567)>]
[09:45:58] 			[::temp191]: True
[09:45:58] 			[::temp192]: [Actor < (00000014)>]
[09:45:58] 			[::temp194]: [ObjectReference < (0014E2FA)>]
[09:45:58] 			[::temp196]: False
[09:45:58] 			[newShip]: [SpaceshipReference < (0014E2FA)>]
[09:45:58] 			[::nonevar]: None
[09:45:58] Dumping stack 265604:
[09:45:58] 	Frame count: 2 (Page count: 2)
[09:45:58] 	State: Waiting on guard (Freeze state: Freezing)
[09:45:58] 	Type: Normal
[09:45:58] 	Return register: [ObjectReference < (0014E2FA)>]
[09:45:58] 	Has stack callback: No
[09:45:58] 	Has unbind object: No
[09:45:58] 	Waiting on guard: playerShipsChangeLock

I found a way to seemingly correct this bug via console command by using these console commands to restart the SQ_PlayerShip system quest that these scripts are connected to:
stopquest 174a2
startquest 174a2
setstage 174a2 0
Once done, you'll receive a message as if you just changed your home ship. Then I'd recommend unassigning all crew, waiting for them to clear out, then assigning them to your ship again. After that, not only does my crew reappear and ship's door unlocked but I was able to collect both the War Eagle and Wanderwell.


Would this work with Operator Mono office?

I think its basically the ttf version of Operator Mono SSm with just three weights Regular, Bold, Italic, BoldItalic.

It should, but you'll need to convert it to OpenType format. You'll also probably need to play around with the names.
NOTE: Check the metrics to see which ligatures to use: Normal or ScreenSmart.
Here's a web site I found to get font info. https://fontdrop.info/
Drag the font to the window, then click on the Data tab. Scroll down to the hhea table and look at advanceWidthMax. If it is 625, then it is the ScreenSmart version. If it's only 550 then it's the normal width.

Thanks. The idea of using the Office fonts is to get fully hinted ttf fonts. Why do the fonts have to the OTF? Is it because the metrics are different?

@IceMan81, if I'm not mistaken, the ScreenSmart versions of HCo's fonts already use full TrueType hinting. The main difference as I understand it with their "Office" fonts is to simplify their use in MS Office type applications — i.e., removing the superfluous weights, making Ctrl+B/Ctrl+I switch to Bold/Italic correctly, etc. If all you're after is proper hinting, then the ScreenSmart fonts are what you need.
One caveat is that if you're using them in an application like VS Code or Atom that's built on Electron (i.e. web technology), I believe you need to install the TTF webfont version in order for that application to take advantage of the hinting. That's been my experience with trying to create my own font for use with VS Code.
Either way though, unfortunately I think @kiliman's utility is incompatible with TrueType hinted fonts, so you may be out of luck.

Yes, this tool only works on the OpenType versions. However it does support hinting as it still outputs the hstem and vstem instructions.
Try converting the TrueType fonts to OpenType and see if you see a noticeable difference. If not, then you should be able to run the tool as long as you rename the fonts correctly.
Good luck!


As a user I'd like to be able to create groups for sharing programs

Precondition: the user is logged in
People: user -- admin of the group
Group: the group to be created

From the menu "user" user chooses "go to groups".
User is redirected to a groups tab with the list of the groups with groups' creators' names -- the ones admined by user and the ones to which the user belongs.
User presses a button for group creation.
The system responses with a popup that contains the following:

a text input field for the program name
button to confirm and button to abort.

The user types a name of the group and confirms the creation by pressing the corresponding button.
The system checks the user's input and returns:

a message that the group was created if everything is fine; user will also immediately see the created group in the group list
a popup that the group already exist if the name has already been taken
a message that the name contains prohibited symbols in case the name contains potentially dangerous symbols

This can also be used as a test case.

@vlebedynska, I close this issue for you


"Failed to load API definition." when using swagger-config-file

When providing a swagger-config-file (for example swagger-config.yaml), it's copied in the GitHub Pages branch of the repo. However, the specification file path/URL declared in the config file is not. Therefore, when opening the Swagger UI, one gets "Failed to load API definition." with (for example):
Fetch error
undefined openapi.yaml

Workaround
Provide a specification file URL, accessible publicly via Swagger UI.
Proposed solutions

Read the config file, find the specification file path, copy it
Provide a GitHub Action setting to allow one to provide such a path

When using swagger-config-file it's up to the users of the action to copy all the required files, it is out of scope for this action to support all settings in the swagger-config.yaml.


Create a Docker Image

Hi there,
I would like to use this tool on my GitLab-Instance. And it would be easy for all incoming users to deploy gitpeach by Docker.
How about creating a Docker-Image for this pretty tool?
Greetings

This is very convenient likely!
But I have never used Docker :sweat_smile:

+1


PDI-11599 - Kettle is parsing the marketplace.xml incorrectly for CR/LF ...

...and spaces

@mattyb149, @brosander, review it please

closing this. This has probably been addressed by now with the new marketplace


Failed to activate the tool-bar package

Hi all.
I am working on an electron app using Atom and one of the things I want to implement (and can't by the way) is a toolbar at the top of the app that always stays on top of all the windows.
I added 2files for that in the root of my project: a toolbar.html and toolbar.js.
After that I got these error coming all the time.
Could not load your toolbar from C:\Users\User.atom\toolbar.cson
Now changed my files name to "top_bar" html and js but I still get this error.
It's no big deal cause the rest of functionality is still ok, but it's still an error that I thought should be reported.
[Enter steps to reproduce:]

...
...

Atom: 1.44.0 x64
Electron: 4.2.7
OS: Microsoft Windows 10 Home
Thrown From: tool-bar package 1.2.0
Stack Trace
Failed to activate the tool-bar package
At Cannot read property 'addEventListener' of null

TypeError: Cannot read property 'addEventListener' of null
    at Object.<anonymous> (~/electron-quick-start/toolbar.js:5:41)
    at Object.<anonymous> (~/electron-quick-start/toolbar.js:19:3)
    at Module.get_Module._compile (<embedded>:11:147429)
    at Object.value [as .js] (<embedded>:11:150977)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)
    at Function.Module._load (internal/modules/cjs/loader.js:533:3)
    at Module.require (/app.asar/static/index.js:72:46)
    at require (<embedded>:11:146745)
    at Object.loadConfig (/packages/flex-tool-bar/lib/flex-tool-bar.js:715:19)
    at Object.reloadToolbar (/packages/flex-tool-bar/lib/flex-tool-bar.js:491:30)
    at Object.consumeToolBar (/packages/flex-tool-bar/lib/flex-tool-bar.js:475:8)
    at Provider.provide (<embedded>:14:1121906)
    at ServiceHub.provide (<embedded>:11:3314762)
    at Package.activateServices (<embedded>:11:3323048)
    at Package.activateNow (<embedded>:11:3320024)
    at measure (<embedded>:11:3319348)
    at Package.measure (<embedded>:11:3316958)
    at activationPromise.activationPromise.Promise (<embedded>:11:3319208)
    at new Promise (<anonymous>:null:null)
    at Package.activate (<embedded>:11:3319151)
    at PackageManager.activatePackage (<embedded>:11:382452)
    at config.transactAsync (<embedded>:11:382068)
    at Config.transactAsync (<embedded>:11:331716)
    at PackageManager.activatePackages (<embedded>:11:382018)
    at PackageManager.activate (<embedded>:11:381568)
    at t.loadState.then (<embedded>:1:756241)

Commands
     -0:29.1.0 sync-settings:restore (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)

Non-Core Packages
atom-beautify 0.33.4
atom-formatter-jsbeautify 1.1.2
atom-ftp-editor 0.5.0
atom-html-preview 0.2.6
block-comment 0.4.3
block-comment-plus 0.5.1
color-picker 2.3.0
comment 0.6.1
compare-files 0.8.1
emmet 2.4.3
flex-tool-bar 2.1.4
goto-definition 1.3.4
php-cs-fixer 4.1.1
platformio-ide-terminal 2.10.0
project-plus 1.0.0
remote-ftp 2.2.4
sass-autocompile 0.13.5
sync-settings 4.1.0
tool-bar 1.2.0
tool-bar-main 0.0.12

I'm not entirely sure if you have the problem when using Atom or when developing your own electron app that is not Atom (or is it an electron app that you based on/forked from Atom, or is it based on electron-quick-start)? Could you clarify?
If you're trying to use this outside of Atom, then I don't think you should expect things to work out of the box as this project is package for Atom. Atom is most likely the thing that is providing the object on which the toolbar tries to call addEventListener. But because it is not running in Atom it is null.

 Because that should be:
- C:\Users\User.atom\toolbar.cson
+ C:\Users\User\.atom\toolbar.cson

If it is a type, then, are you sure there is a file named toolbar.cson in C:\Users\User\.atom?

if it helps
i got
Atom: 1.44.0 x64 [Portable]
OS: Microsoft Windows 10 pro x64
tool-bar package 1.2.0
no problems

Hi and sorry for the delay.
I am building an electron app based on "electron-quick-start", but I am using Atom as an editor.
In fact I am using Atom for other web projects and it works fine.
Just when I created the "toolbar.html" and "toolbar.js" files in my root folder I got this error starting to pop-up. Also I looked and I have the "toolbar.cson" file in the C:\Users\User.atom folder.
Sorry, that's a typo, yes. It says:
Could not load your toolbar from C:\Users\User.atom\toolbar.cson
Well, I eventually renamed the 2 files "top_bar" .html and .js and now I get no more errors, so there's got to be a naming issue.
Ayway, it's no big deal, but maybe it helps someone else that runs into this issue to not name the electron internal files "toolbar"...
Thanks.

Thanks for the clarification! As this is not directly related to regular usage of tool-bar, I'll close this issue. If anyone would look for this info they could still find this issue :)


Improve lab sim example objectives with story telling

Need to cherry pick this to main - can you do that @MikeWrock ?

@MikeWrock can you retarget this to 7.0 please? I'd like to get it merged for that release.

@jeremydbronson can you test this against 7.0 by navigating to the example workspace and git checkout improve_lab_sim_examples then git submodule update --recursive and moveit-pro build user_workspace. There are two objectives to test, I've tagged you in them.

[ ] Push Button
[ ] Move Beakers to Burners


Support Kotlin 2.0

This issue is here to discuss the path to supporting K2. It outlines the issues I've encountered as well as their possible workarounds. Feel free to enter the discussion, especially if you have any insight or wild idea ;)
MocKMP generates source code for the Test source-sets, which is not properly supported by KSP. KSP does support generating code for the commonMain sourceset, but not for the commonTest sourceset.
Up until now, we've used the following trick: register the MocKMP processor only in the kspJvmTest configuration and have the commonTest sourceset use the build/generated/ksp/jvm/jvmTest/kotlin directory. This requires some more Gradle configuration (namely having all targets compilation task to depend on kspTestKotlinJvm) but it worked allright (even though it made my heart ache).
Kotlin 2.0 brings a new issue:
e: Files '/[PROJECT]/build/generated/ksp/jvm/jvmTest/kotlin/tests/InjectionTests_injectMocks.kt', ... can be a part of only one module, but is listed as a source for both `jvmTest` and `commonTest`, please check you -Xfragment-sources options.

It looks like K2 is more restrictive than K1, and does not allow the same file to be in multiple sourcesets at once. I also haven't found a way to emulate running KSP to commonTest only, or to remove the generated/ksp/jvm/jvmTest/kotlin directory from the JVM test compilation.
I've tried another approach that consists of applying the processor to all test targets:
dependencies {
    configurations.names
        .filter { it.startsWith("ksp") && it.endsWith("Test") }
        .forEach {
            it(projects.mockmpProcessor)
        }
}

...but that brings a new issue: because K2 is also more restrictive as to which sources are accessed when compiling common code,  this approach does not compile at all (yielding unresolved symbol all around errors when compiling common code).
So far, the only approach I've thought of that would (I think) resolve the issue is to follow the KotlinX.RPC & KotlinX.Serialization paths and have a Compiler plugin that adds an AssociatedObjectKey annotation to each class annotated with @Mock or @Fake. This cannot be done with KSP as it notoriously cannot modify the sources of the code it is processing. Such annotations allow a Native & Js code to access an object associated to a class at compile-time (it does not exist in JVM, but the JVM provides reflection so there's no need for it). This in turn allows to have a common code that does not directly reference generated code.
This is a path I'd rather not take, because:

It requires maintaining a compiler plugin for each Kotlin compiler version (KotlinX.RPC maintains so far 17 artifacts for each version, corresponding to 17 different Kotlin compiler version).
It requires maintaining code that uses undocumented and unsupported Kotlin compiler API, which can break at anytime.
It bundles MocKMP to each specific supported version of the Kotlin compiler and requires a level of reactivity and investment at each minor Kotlin update that I cannot provide as an Open-Source library author (without patron or revenue source related to my Open-Source work).

MocKMP is now at a crossroad as I have found, at the moment, no satisfactory path to have it compatible with K2.
Let's keep looking!
Make sure to share any idea or knowledge I've missed ;)

Thanks for the detailed explanation of the problem. Even if I am pretty sure that I am only beginning to understand the basic setup maybe we can exchange a few thoughts here. If I understand the KSP docs here correctly there seems to be a kspTest task for multiplatform. Could we maybe hook into that? Also: Did you already investigate whether KSP 2.0 might or might not have an impact or helpful changes for the issue? I am struggling with finding specific information about it.

There's no kspTest in a Kotlin/Multiplatform project.
Here are the available configurations on my mac:
kspCommonMainMetadata
kspIosSimulatorArm64
kspIosSimulatorArm64Test
kspIosX64
kspIosX64Test
kspJs
kspJsTest
kspJvm
kspJvmTest
kspLinuxX64
kspLinuxX64Test
kspMacosArm64
kspMacosArm64Test
kspMacosX64
kspMacosX64Test
kspMingwX64
kspMingwX64Test
kspTvosSimulatorArm64
kspTvosSimulatorArm64Test
kspTvosX64
kspTvosX64Test
kspWatchosSimulatorArm64
kspWatchosSimulatorArm64Test
kspWatchosX64
kspWatchosX64Test
As I've explained applying KSP to each test sourceset does not work because of K2 Common / Target sourceset separation.

Thanks for the explanation! So it looks like the issue here is really just that KSP runs for anything except commonTest if I see it well. Does this mean we could generate files for jvm test for example and run the tests there? I know it is not the goal of a multiplatform library to limit tests to the different sub packages, I am just trying to understand the underlying issue. In the meantime I will add my vote to the KSP issue and ask the ksp team to shed a light on why they seem to exclude commonTest explicitly

Hello, i get the same issue, i choose to stay on ksp 1.9.24-1.0.20 for now instead removing MocKMP usage.
But has a workaround been found ? Or should i remove MockMP usage ?

Any solutions please , we are blocked due to this issue since we would like to migrate to kotlin 2.0

Good news : I found a way to make MocKMP work with Kotlin 2 !
It will be however through a breaking change, but the migration is quite simple.
I still need to soften some rough edges, but you can expect MocKMP 2.0 in a week or two max.

Here we are: MocKMP 2.0 has been released to Maven Central and to the Gradle plugin portal.
Migration guide
I truly apologize for the time it took me to port MocKMP to Kotlin 2.0. All I can say for my defense is that:

MocKMP 2.0 represents a considerable change in how it is applied to a project. It took me a lot of time to find a satisfactory way, and it meant a full re-write of the Gradle plugin, as well as an extension of the Kotlin Symbol Processor.
MocKMP, just like every other KOSI libraries, is freely maintained outside of any paid mission, and I've been quite busy lately. Having a kid changes your priorities...

The way MocKMP 2.0 is implemented is now much more robust and future-ready than version 1.x (at least, I think so, but I do not live in the future). I am quite satisfied at where the project is and I hope it will be less of a hassle to maintain for the coming Kotlin releases.


feat(values): add window mean array cursor

Adds the ArrayCursor implementation for window mean.
Also bumps the flux version v0.83.2 => v0.83.3 to import a duration conversion helper.

@wolffcm Yeah! Just added it. I was looking for blindspots. Appreciate it.


Error building posix_sitl_default

Hi,
I'm getting an error while building PX4 for SITL simulation with Gazebo. I installed the pre-requisites as stated in this page and ran make posix_sitl_default gazebo. I got the following error:
--   Found protobuf, version 3.0.2
Gazebo version: 7.3
CMake Error at CMakeLists.txt:80 (message):
  protobuf version: 3.0.2 not compatible, must be >= 2.5.0 and < 3.0.0

-- Configuring incomplete, errors occurred!

So it appears that the protobuf version I have is too new, therefore I downloaded the newest version below v3.0.0 (as the error log is suggesting) which is v2.6.1 and I installed it. Then I proceeded to re-run the build as follows:
make posix_sitl_default clean
make posix_sitl_default gazebo

I get a new error which is very long, but I'll only display the beginning since it says where it does come from:
In file included from SensorImu.pb.cc:5:
In file included from ./SensorImu.pb.h:27:
/usr/local/Cellar/gazebo7/7.3.1_4/include/gazebo-7/gazebo/msgs/quaternion.pb.h:12:2: error: This file was generated by a newer version of protoc which is
#error This file was generated by a newer version of protoc which is
 ^
/usr/local/Cellar/gazebo7/7.3.1_4/include/gazebo-7/gazebo/msgs/quaternion.pb.h:13:2: error: incompatible with your Protocol Buffer headers.  Please update
#error incompatible with your Protocol Buffer headers.  Please update
 ^
/usr/local/Cellar/gazebo7/7.3.1_4/include/gazebo-7/gazebo/msgs/quaternion.pb.h:14:2: error: your headers.
#error your headers.
 ^

So now it seems like some headers that are used by protobuf has been generated by a newer version, and thus it is not able to recognize them. The problem is that there is no other version in the releases of protobuf page so I don't know where the problem comes from.
I'm building all of this in a Mac with gazebo7 installed today and with the latest version of the master firmware.
P.S: If I change the CMakeLists.txt in Tools/sitl_gazebo and allow for having protobuf versions above 3.0.0 the simulation executes but without the world.

If I change the CMakeLists.txt in Tools/sitl_gazebo and allow for having protobuf versions above 3.0.0 the simulation executes but without the world

What do you mean exactly? If you see the quad on a ground plane, it's actually correct. There are no buiildings in this world.
I think @jgoppert could explain why the protobuf < 3.0.0 requirement was added.

@bkueng I couldn't get the code to build without protobuf < 3.0.0.  @nacho-carnicero  2.6.1 is the correct version, can you try deleting all build files and trying again. Also, try using gazebo 7.0.0:
gazebo --version
Gazebo multi-robot simulator, version 7.0.0
It looks like you are using a newer gazebo version, which may now use the 3.0.0 protobuf.

Ok @bkueng I got confused because I saw in the video of the dev page all the environment I was not seeing in my simulation, therefore the build worked.
@jgoppert  yes, I am using Gazebo 7.3.1. Maybe we could add a check on the CMakeLists in order to allow using higher versions of protobuf if the version of Gazebo is above 7.0.0. Or do you recommend downgrading to v7.0.0 for other compatibility issues?

For now as a workaround on Mac I found that switching back to the old version works:
brew switch protobuf 2.6.1

I've updated the instructions how to get to the older protobuf version in brew, see https://github.com/PX4/Devguide/pull/45.

I've reverted this but added a PR here for it:
https://github.com/PX4/sitl_gazebo/pull/53
If anyone could cross-test that would be great.

https://github.com/PX4/sitl_gazebo/pull/53 has gone in, this should be fixed now.


Using external variables for validation

Hi-
I've got an scenario where the validation rules needs to use references to external variables (a settings object, etc)
How can I achieve to compose a custom rule that uses that reference?
Seems requirement parameter should do that, but the documentation is very cryptic about its use.
I expected to pass those variables on validate invoke, but has no option either.

I am not very sure, that I completely understand your scenario, but following a documentation, you need to register your own rule validator. Like this:
Validator.register(name, callbackFn, errorMessage);
You can use javaScript closures to create your callbackFn
The abstract code may look like:
var validationFn = (function () {
  var scoped = {'external': 'test'};

  return function (value, requirement, attribute) {
  // Validation code goes here, also variable scoped is enclosed in function scope here
  }
})();

Validator.register('myRule', validationFn, 'myErrorMessage');

Thanks! but what is requirement meant for? Docs says is usually null
The nested function approach maybe not valid for me, as the external value is prone to change.
So I was expecting something like:
var settings = { XYZ }
var data = {
    height:200
}
const validationFn = function (value, requirement, attribute) {
  //being requirement or other parameter the object settings passed below
}

Validator.register('myRule', validationFn, 'myErrorMessage');
var validation = new Validator(data, rules);

validation.passes(...,{settings})


[ERROR] No .editorconfig properties applicable for files in a Maven module without .editorconfig

When building in a module directory of a multimodule Maven project, the .editorconfig file in the root of the source tree is not seen. Something like the following is logged:
[ERROR] No .editorconfig properties applicable for files under ...

on windows, i have a .editorconfig file in the root folder, but the error message come again. :-(

@flod1 could you please open a new issue with proper steps to reproduce?


How much the loss is acceptable?

I'm a rookie in neural network, so the question may be stupid. I changed the training data from referenced dataset and found the loss of decompressor reaches 1.9 after 500k iterations. Generated .bvh files also shows obvious difference. So I wonder if I choose bad training data and what can I do to reduce loss.

Ultimately the visual result is what matters when deciding how much difference is acceptable. I'm surprised you get an obvious difference on the referenced dataset. When I train this locally yes there is a small different between the generated bvh files but it is extremely subtle. Did you change any of the parameters or data for training?

Yeah, I changed batch size to 256 and use cuda instead of cpu to accelerate training. But it should not affect the training result too much. I have tried several times using different pieces of dataset and reached better results. Maybe I just used bad datasets when I tried first time. Thank you for your reply.


Can't reset the position of FrameRequestStream

I write a middleware to log the http request body, but after reading from Request.Body(FrameRequestStream), I can't read it again in other middleware.
Because the position of Body stream has been set to end.
Any ways to make me read it many times?

This requires fully buffering the request. Kestrel will not do this for you, but there are some helpers available. https://github.com/aspnet/HttpAbstractions/blob/3e69df87f89601a5ede32c6765b736ab922b8fee/src/Microsoft.AspNetCore.Http/Internal/BufferingHelper.cs#L41

That helper is "Internal" though.

Calling 'EnableRewind' method will change type of the 'Body' and it may affect the next execution of the middleware.

request.EnableRewind();
var body = request.body;
if (request.ContentLength != null && request.ContentLength > 0 && body != null)
{
    byte[] buffer = new byte[request.ContentLength.Value];
    body.Read(buffer, 0, (int)request.ContentLength.Value);
}
body.Read() will throw exception because the body has been disposed.

You're hitting a different bug in kestrel that was fixed in 1.0.1 https://github.com/aspnet/KestrelHttpServer/issues/1028.
Also, avoid synchronous reads on the body in general.

@563203132 you should upgrade to the released 1.0.1 patch https://blogs.msdn.microsoft.com/webdev/2016/09/13/asp-net-core-sept-2016-patch/

With 1.0.0 you have to restore the body at end to work around the bug:
request.EnableRewind();
var body = request.Body;
if (request.ContentLength != null && request.ContentLength > 0)
{
byte[] buffer = new byte[request.ContentLength.Value];
await body.ReadAsync(buffer, 0, (int)request.ContentLength.Value);
}
// Add this
request.Body = body;

I write a middleware to log the http request body

You might also want to consider just wrapping the request body and logging data as it's read rather than eagerly reading the thing into a byte[]. What happens if there's a large file upload on your site?

@benaadams I try your code and the 'body.ReadAsync' also throw exception because the body was disposed after calling the 'EnableRewind' method.
I upgrade to 1.0.1 and it's work.
@davidfowl I need to log the request at the begin of pipeline route.
Thank you very much.

@davidfowl I need to log the request at the begin of pipeline route.

Beware of the memory concerns listed before.


Normalize reprojection constraints

Reprojection constraints can skew the optimization by a lot. The goal of this is to normalize each images reproejction constraints to be in line with what would be its odometry constraint (relative pose)

compute shannon entropy (H) from the pose covariance
Divide H by # of features in the image to get H per reprojection constraint

https://github.com/locusrobotics/fuse/blob/vision_constraints/fuse_constraints/include/fuse_constraints/fixed_3d_landmark_cost_functor.h#L183-L200


Stop Displaying Retracted Registrations in Public Activity.

 Purpose
Stop displaying retracted registrations on the Public Activity page. Close #3671.
 Changes
simple change to /discovery/views.py
 Side Effects
None that I know of.

Simple change, good to go.


In the context of Key Vault, existing application properties that contain a mixture of dots and dashes don't map correctly

Environment

Spring boot starter:

azure keyvault secrets spring boot starter

OS Type: MacOS

Java version:

11.0.2

Summary
Existing application properties that contain a mixture of dots and dashes do not map correctly from Key Vault.  By "existing" I mean properties that I, myself, did not create and, therefore, whose names I cannot control.
Reproduce steps
Imagine working with an existing property named server.ssl.key-store-password.  I would have to store this in Key Vault as server-ssl-key-store-password.  However, the starter I reference above automatically converts the property name to server.ssl.key.store.password.  But of course, this is not correct.
Expected Results
To be honest, knowing your substitution algorithm, I expected this wouldn’t work since there's no way, it seems, for the starter to know which dashes should be preserved and which should be converted to dots.
Actual Results
Working within the logic of your design, to get the proper actual result, we would need to see one of the following:

For Key Vault to allow key vault secret names to contain dots (".") (the best solution); or
Provide a way to signal preservation (not too bad)

With respect to the latter, we could have something like this for a secret name: server-ssl-key--store--password, where the double dash indicates that the following dash should be preserved.  This might be the easiest to implement initially.

Thanks for bringing this up and we'll consider this approach.


Bug: particles_2d + lightmask + viewport

Godot version:
3.1.1.stable.official
OS/device including version:
Ubuntu 18.04.3 LTS
Issue description:

If you mask particles with a light (light_2d: mode = mask), weird visual bugs happen in the Editor. If you F6 ..., the visual bugs are gone and everything looks fine.
Now, if you instantiate this scene via a viewport, you still have the same visual bugs in the editor but now, if you F6 ... these visual bugs stay.

Steps to reproduce:
create 2 scenes
scene 2: particle-effect with light_2d as mask.
for the mask create a white/transparent image. (you know how to mask things with transparency)
scene 1: viewport instantiates scene 2 as child
create a sprite on the viewport-level -> new viewport texture and choose the viewport.
look attached file...

Minimal reproduction project:
see: Steps to reproduce:

Seems still valid in 3.2.4 beta4
Can't test in master, because GPUParticles2D are still missing.


fix: Detect changes in config.options

Due to how deep watching works, newOptions === oldOptions will always be true so callbacks is always going to be skipped. Deep watching doesn't check if newOptions !== oldOptions but recursively checks for changes.
This is fix for options parameter but I'd also remove such checks from the rest of deep watches.

Closing post 1.0.0 release


Incorrect user type when unsuspending inactive users

I was testing the manage user page today, and i found a bug that if you suspend then unsuspend an inactive user it sets their status to active in stead of back to inactive. This should probably be fixed because this could leave to users with active status with out confirming their email.

I think we need a conditional statement here to change based on cookie or something

Ummm..... I don't know a good solution to fix this. I don't really want to add another db field to store the previous status of the user. I guess we can change it to make the user's account inactive if they are unsuspended and they will have to reconfirm their email. It's not a great solution but it works. What do you think?


Update docs site for v19.1.4 release

Fixes #5147.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0f181fb0435625c4e0b30c02e8a0a2a6d276c963/
Edited pages:

releases/v19.1.4.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c2ebae55d2dcd7e7ca25fa0ba1eb161d4ec254b0/
Edited pages:

releases/v19.1.4.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/05338559d129db6257b00e3b0472098edc01d126/
Edited pages:

releases/v19.1.4.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d2a9a241586cd316fbe8fce5f0c789bae47a8a7a/
Edited pages:

releases/v19.1.4.md


Prebuild with leveldown on Elastic Beanstalk

Prebuild seems to be failing with leveldown on Elastic Beanstalk.
Full report: https://github.com/Level/leveldown/issues/326

Experiencing very same issue. Any workarounds?

Yes- it seems to be a permissions error, to work around it you need to create a file at .ebextensions/leveldownWorkaround.config that looks like this:
files:
  "/opt/elasticbeanstalk/hooks/appdeploy/pre/45makeDirectoriesWritable.sh":
    mode: "000755"
    owner: root
    group: root
    content: |
      #!/usr/bin/env bash
      chmod 777 -R /tmp/.npm
      chmod 777 -R /tmp/deployment/application/node_modules/leveldown

If you now eb deploy, then leveldown should build as expected.
-note that this fix is just to "get it to work", and is probably being a little generous with permissions.

@fergiemcdowall thanks!

Another possible solution here:
https://stackoverflow.com/questions/46001516/beanstalk-node-js-deployment-node-gyp-fails-due-to-permission-denied/46001517#46001517
tl;dr:
Add a file .npmrc to the application root with the content:
unsafe-perm=true

I was having difficulty with @fergiemcdowall's solution for some reason