Introduce meta actions

Observed
User may need to often execute the same suite of commands
Yet there is no way to execute multiple actions using only 1 single command
For instance, For each deploy, after having done some devlopments+bumped, user currently needs to run 4 actions
plasmactl compose --skip-not-versioned --conflicts-verbosity
plasmactl platform:compare-artifacts
plasmactl platform:components-propagate dev file.diff

Gradle has a way to do that "meta action": The common pattern there is to have a task that depends on tasks. One task that has ONLY dependencies will be a "meta" task
Expected
Would be great to have a way to define meta actions, where one command would run multiple actions

This should work for both commands brought by native plugins + commands brought by actions
Maybe meta action should be defined with a different kind of action.yaml

action:
  kind: Meta
  title: Build
  description: Handles every actions related to building artifact to be deployed
  actions:
    - compose --skip-not-versioned --conflicts-verbosity
    - platform:compare-artifacts
    - platform:components-propagate dev file.diff

Or maybe instead of creating a new kind of action, it could be handled solely by dependencies, like

action platform:components-propagate has an attribute that says it need to run platform:compare-artifacts before running itself
and action platform:compare-artifacts dev file.diff has an attribute that says it need to run compose --skip-not-versioned --conflicts-verbosity before running itself
but in this case need ability to run all actions with expected args and options

In any case, maybe this functionality should be brought by a launchrctl plugin, to keep functionality separate from core and keep it simple

Or maybe instead of adding this to launchrctl, we could simply use a Makefile (or something similar)

For now, meta action was built as a plugin : https://github.com/skilld-labs/plasmactl-meta

Re-opening this issue as plasmactl web-ui also have a need to visually represent actions that should run sequentially and in parallel
For now it's kind of hardcoded in plasmactl-meta action, which execute calls to other actions. But looks like we need a more generic approach to make a visual representation of that "flow" in UI
Most likely that will requre more thinking and refactor of meta action. If we need to show something in web-ui before that happens, we could duplicate logic in some config file (but that's obviously not a viable long term solution)

Got the wrong idea about the intent of this UI, it's related to integration flows; not actions


refactor(proofs): remove ProofProtocolVersion enum in 0.3.0-pre

Signed-off-by: Mike Richardson<EMAIL_ADDRESS>

Codecov Report

Merging #1062 (ecc0139) into 0.3.0-pre (6652520) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           0.3.0-pre    #1062      +/-   ##
=============================================
- Coverage      88.22%   88.21%   -0.01%
=============================================
  Files            680      679       -1
  Lines          15903    15897       -6
  Branches        2570     2569       -1
=============================================
- Hits           14030    14024       -6
  Misses          1865     1865
  Partials           8        8

Impacted Files
Coverage Δ

packages/core/src/modules/proofs/models/index.ts
100.00% <ø> (ø)

...e/src/modules/proofs/protocol/v1/V1ProofService.ts
80.40% <ø> (-0.05%)
:arrow_down:

...e/src/modules/proofs/protocol/v2/V2ProofService.ts
87.57% <ø> (-0.04%)
:arrow_down:

packages/core/src/modules/proofs/ProofsApi.ts
85.26% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I have run the failing test locally (using node 14) but it passes on my machine. Is there anything we can do to fix this or should we merge anyway?
tenants/tests/tenant-sessions.e2e.test.ts

Can this be merged now. I notice we had a test timeout but I don't think that is related to any changes here,


[FEATURE] Support Pydantic Models as ParamTypes

Is your feature request related to a problem
I would like to use Pydantic Models as type annotations in my Typer CLI program.
The solution you would like
Typer would call Model.parse_raw on the string that was passed to the CLI
Describe alternatives you've considered
Rather than having Typer be so aware of the Pydantic API, I tried to create a custom click.ParamType that did the parsing, but even that did not work as custom types do not currently seem to be supported in the get_click_type function.
Additional context
Here's a simple example:
#!/usr/bin/env python3
import click
import typer
from pydantic import BaseModel

class User(BaseModel):
    id: int
    name = "Jane Doe"

class UserParamType(click.ParamType):
    def convert(self, value, param, ctx):
        return User.parse_raw(value)

USER = UserParamType()

def main(num: int, user: USER):
    print(num, type(num))
    print(user, type(user))

if __name__ == "__main__":
    typer.run(main)

This currently throws:
Traceback (most recent call last):
  File "./typer_exp.py", line 26, in <module>
    typer.run(main)
  File "/usr/local/lib/python3.7/site-packages/typer/main.py", line 848, in run
    app()
  File "/usr/local/lib/python3.7/site-packages/typer/main.py", line 213, in __call__
    return get_command(self)()
  File "/usr/local/lib/python3.7/site-packages/typer/main.py", line 238, in get_command
    click_command = get_command_from_info(typer_instance.registered_commands[0])
  File "/usr/local/lib/python3.7/site-packages/typer/main.py", line 422, in get_command_from_info
    ) = get_params_convertors_ctx_param_name_from_function(command_info.callback)
  File "/usr/local/lib/python3.7/site-packages/typer/main.py", line 403, in get_params_convertors_ctx_param_name_from_function
    click_param, convertor = get_click_param(param)
  File "/usr/local/lib/python3.7/site-packages/typer/main.py", line 656, in get_click_param
    annotation=main_type, parameter_info=parameter_info
  File "/usr/local/lib/python3.7/site-packages/typer/main.py", line 586, in get_click_type
    raise RuntimeError(f"Type not yet supported: {annotation}")  # pragma no cover
RuntimeError: Type not yet supported: <__main__.UserParamType object at 0x7fc346234b10>

A major bonus would be if I could write the user: User type annotation directly, without creating the UserParamType.
Also - just want to say thank you for writing such an awesome python package and keep up the great work! 👏

I just noticed that this is very similar to #77.  I will leave this open and change the name to specifically request support for Pydantic in order to differentiate it.

As proof of concept of how support for Pydantic Models could be implemented, I built on the monkey-patched version of get_click_type that @ananis25 wrote in #77:
#!/usr/bin/env python3
from typing import Any

import click
import pydantic
import typer

_get_click_type = typer.main.get_click_type

def supersede_get_click_type(
    *, annotation: Any, parameter_info: typer.main.ParameterInfo
) -> click.ParamType:
    if hasattr(annotation, "parse_raw"):

        class CustomParamType(click.ParamType):
            def convert(self, value, param, ctx):
                return annotation.parse_raw(value)

        return CustomParamType()
    else:
        return _get_click_type(annotation=annotation, parameter_info=parameter_info)

typer.main.get_click_type = supersede_get_click_type

class User(pydantic.BaseModel):
    id: int
    name = "Jane Doe"

def main(num: int, user: User):
    print(num, type(num))
    print(user, type(user))

if __name__ == "__main__":
    typer.run(main)

$ ./typer_demo.py 1 '{"id": "2"}'

1 <class 'int'>
id=2 name='Jane Doe' <class '__main__.User'>

Also, Typer could settle on an API for custom types (e.g. in keeping with Pydantic, the Typer docs could declare "all custom ParamTypes must implement a parse_raw method") and this would then cover the use-case requested in #77 without needing to implement a registration process.

Oh, I didn't know about the parse_raw method provided by pydantic. This is definitely neater than keeping a global container of custom datatypes!
The only reason to prefer a registration api imo is that the code not using pydantic types/classes can also be used in a CLI without making any changes to it.
For ex - the typer app.command function also only registers the function being decorated instead of wrapping it, which is useful if the method hello is defined elsewhere where you don't want to make edits.
import typer

def hello(name: str):
    return f"Hello {name}"

if __name__ == "__main__":
    app = typer.Typer()
    app.command()(hello)

+1
I really like the idea of using Pydantic models.
Another approach to parse_raw could be to traverse Pydantic models until we reach a supported type.
Options of type BaseModel could be parsed into multiple cli options like for example the traefik cli does.
This does only work for options and not for arguments.
#!/usr/bin/env python3

import click
import pydantic
import typer

class User(pydantic.BaseModel):
    id: int
    name = "Jane Doe"

def main(num: int, user: User):
    print(num, type(num))
    print(user, type(user))

if __name__ == "__main__":
    typer.run(main)

The example above could then be called like this:
$ ./typer_demo.py 1 --user.id 2 --user.name "John Doe"

1 <class 'int'>
id=2 name='John Doe' <class '__main__.User'>

I was about to write a ticket along the lines of @Patdue's comment above, I would love something along those lines; I currently have several methods with large, almost identical signatures, which map to a pydantic model.
Something like that would be fantastic!

Another approach to parse_raw could be to traverse Pydantic models until we reach a supported type.
Parameters of type BaseModel could be parsed into multiple cli options like for example the traefik cli does.
This does only work for options and not for arguments.

I'm working on a pull request to support this behaviour. Because there is no longer a 1-1 mapping between the typed function parameters and the click.Parameters, it involves quite a lot of changes.
Btw. @tiangolo how do you feel about this feature?

@tiangolo can we get this green-lighted for a pull request?

Has anyone tried pydantic-cli ? though it uses argparse (from the README) rather than click

@tiangolo can we get this green-lighted for a pull request?

@jackric better to ask for forgiveness than permission 😉

This would also help many other use cases:

I wanted to use, my own formatting for datetime, ex: today %H:%M, %M:%H(automatically uses date as today)
typer would be able to serialize any custom object

It also doesn't seem, it would require a lot of changes on how typer works internally to implement this. There is already PR #304

Also would love to see this! Typer looks aweseom, but I like to manage my configs with Pydantic, and I don't want to describe all my params twice. So currently looking at https://github.com/SupImDos/pydantic-argparse or https://pypi.org/project/pydantic-cli/ instead. But, alas, argparse...

Going to try and implement this in #630, more or less exactly as described by @pypae

@tiangolo do you have a position on this feature request? If it were implemented well, would you accept? What might your definition of "implemented well" be?

I agree that this feature would be very useful !

An integration of typer and pydantic would be totally awesome! Currently one needs to write an annoying amount of boilerplate to map from CLI arguments to model fields. In an ideal solution, one could bind pydantic fields directly to cli params e.g. using some extra type hint inside Annotated (that way it would not interfere with the pydantic field config).
My dream solution would allow to have a well-integrated solution to have a common data model filled from various sources, such as:

CLI arguments (via typer)
config files (via pydantic)
interactive user inputs (via rich)

For the latter part I'm using currently this approach to prompt fields for my config model:
class MyBaseModel(BaseModel):
    """Tweaked BaseModel to manage the template settings.

    Adds functionality to prompt user via CLI for values of fields.

    Assumes that all fields have either a default value (None is acceptable,
    even if the field it is not optional) or another nested model.

    This ensures that the object can be constructed without being complete yet.
    """

    model_config = ConfigDict(
        str_strip_whitespace=True, str_min_length=1, validate_assignment=True
    )

    def check(self):
        """Run validation on this object again."""
        self.model_validate(self.model_dump())

    @staticmethod
    def _unpack_annotation(ann):
        """Unpack an annotation from optional, raise exception if it is a non-trivial union."""
        o, ts = get_origin(ann), get_args(ann)
        is_union = o is Union
        fld_types = [ann] if not is_union else [t for t in ts if t is not type(None)]

        ret = []
        for t in fld_types:
            inner_kind = get_origin(t)
            if inner_kind is Literal:
                ret.append([a for a in get_args(t)])
            elif inner_kind is Union:
                raise TypeError("Complex nested types are not supported!")
            else:
                ret.append(t)
        return ret

    def _field_prompt(self, key: str, *, required_only: bool = False):
        """Interactive prompt for one primitive field of the object (one-shot, no retries)."""
        fld = self.model_fields[key]
        val = getattr(self, key, None)

        if required_only and not fld.is_required():
            return val

        defval = val or fld.default

        prompt_msg = f"\n[b]{key}[/b]"
        if fld.description:
            prompt_msg = f"\n[i]{fld.description}[/i]{prompt_msg}"

        ann = self._unpack_annotation(fld.annotation)
        fst, tail = ann[0], ann[1:]

        choices = fst if isinstance(fst, list) else None
        if fst is bool and not tail:
            defval = bool(defval)
            user_val = Confirm.ask(prompt_msg, default=defval)
        else:
            if not isinstance(defval, str) and defval is not None:
                defval = str(defval)
            user_val = Prompt.ask(prompt_msg, default=defval, choices=choices)

        setattr(self, key, user_val)  # assign (triggers validation)
        return getattr(self, key)  # return resulting parsed value

    def prompt_field(
        self,
        key: str,
        *,
        recursive: bool = True,
        missing_only: bool = False,
        required_only: bool = False,
    ) -> Any:
        """Interactive prompt for one field of the object.

        Will show field description to the user and pre-set the current value of the model as the default.

        The resulting value is validated and assigned to the field of the object.
        """
        val = getattr(self, key)
        if isinstance(val, MyBaseModel):
            if recursive:
                val.prompt_fields(
                    missing_only=missing_only,
                    recursive=recursive,
                    required_only=required_only,
                )
            else:  # no recursion -> just skip nested objects
                return

        # primitive case - prompt for value and retry if given invalid input
        while True:
            try:
                # prompt, parse and return resulting value
                return self._field_prompt(key, required_only=required_only)
            except ValidationError as e:
                print()
                print(Panel.fit(str(e)))
                print("[red]The provided value is not valid, please try again.[/red]")

    def prompt_fields(
        self,
        *,
        recursive: bool = True,
        missing_only: bool = False,
        required_only: bool = False,
        exclude: List[str] = None,
    ):
        """Interactive prompt for all fields of the object. See `prompt_field`."""
        excluded = set(exclude or [])
        for key in self.model_fields.keys():
            if missing_only and getattr(self, key, None) is None:
                continue
            if key not in excluded:
                self.prompt_field(
                    key,
                    recursive=recursive,
                    missing_only=True,
                    required_only=required_only,
                )

So some instance can be completed interactively using
obj.prompt_field("key_name") to ask for a single field value or obj.prompt_fields(...) to walk through all (or configurable to ask only for missing values).
Would this somehow make sense inside of typer as well (because the intended use-case strongly correlates with use-cases for typer), or would it make sense to create a little library for that?


manpages have groff warnings

Describe the bug
lintian Debian linting tool shows manpage formatting warnings:
groff-message usr/share/man/man3/pappl-client.3.gz 235: warning: macro 'IN' not defined
groff-message usr/share/man/man3/pappl-device.3.gz 275: warning: macro 'IN' not defined
groff-message usr/share/man/man3/pappl-job.3.gz 156: warning: macro 'aborted-by-system'' not defined (possibly missing space after 'ab')
groff-message usr/share/man/man3/pappl-job.3.gz 160: warning: macro 'compression-error'' not defined
groff-message usr/share/man/man3/pappl-job.3.gz 164: warning: macro 'document-format-error'' not defined (possibly missing space after 'do')
groff-message usr/share/man/man3/pappl-job.3.gz 168: warning: macro 'document-password-error'' not defined (possibly missing space after 'do')
…

I'm by far not a (g)roff expert, but It seems that single quotes (') mark macro starters, and need escapes. I also haven't determined whether this is a direct formatting issue in man/pappl-job-body.man or in codedoc.

@OdyX Looks like something I need to fix in codedoc...

@OdyX Looks like something I need to fix in codedoc...

codedoc issue #12 will fix the generator issue, then I'll re-gen the documentation files here.

codedoc issue #12 will fix the generator issue, then I'll re-gen the documentation files here.

[master d369af3] Update man pages with new codedoc quoting (Issue #136)

[master d369af3] Update man pages with new codedoc quoting (Issue #136)


Fixes #81 - Batch import support for Excel format with object import template validation.

Fixes #81 ; refs #46, #81
Batch import support for Excel format with object import template validation.
Changes proposed in this pull request:

Implemented Batch Import support for Excel format.
Added support for object import template validation.
Refactored codes with the existing CSV Import functionality for more generic tabular data source support.
Updated import template, predicates and properties.
Implemented the support for the latest Excel import template.

@ucsdlib/developers - please review

Coverage increased (+1.9%) to 89.143% when pulling ceae3fb76e96b367168cb5363fdb0b9b82f515ab on feature/excel_import into ee46e67a07e9a80811b9633f33e0dadcf5331ec9 on develop.

@mcritchlow I've added the commit above to rename it to Batch Import and address your suggestions above. It's ready for review now. Thanks.

Coverage increased (+1.9%) to 89.149% when pulling 984e36148839c97eda5804861f830b75c7f9c84e on feature/excel_import into ee46e67a07e9a80811b9633f33e0dadcf5331ec9 on develop.

Coverage increased (+1.9%) to 89.149% when pulling 0273a66ff4e51c3cdb54ca22d851c8864f5a2dd1 on feature/excel_import into ee46e67a07e9a80811b9633f33e0dadcf5331ec9 on develop.

Coverage increased (+1.9%) to 89.136% when pulling b795192eec98fb7f251d8bfabe21bda435f97df5 on feature/excel_import into ee46e67a07e9a80811b9633f33e0dadcf5331ec9 on develop.

@ucsdlib/developers Please review, comments etc ...

Coverage increased (+2.0%) to 89.222% when pulling f108d921a783f48d57256ca0e4a9ca1fa666428a on feature/excel_import into ee46e67a07e9a80811b9633f33e0dadcf5331ec9 on develop.

:+1:

👍

@ucsdlib/developers Thank you all for your reviews and comments!


[REQ] Add an option to automatically translate all text

Describe the solution you'd like
Add an option to automatically translate text by default.

Sorry, I don't think this is something I can support in Fritter.
Fritter uses a third party, privacy friendly translation API, with strict limits, and automatically translating every non-native tweet would be much too high a load on this service, and probably be considered abuse.


chore(customization): fix undefined (environment) variable

Still getting a error with this branch

So I made some tests and the issue seems to be related to the upper case T/F in True / False. Switching it to the all lowercase values works. I don't know if the python code executes the migrations this way.

yep, that should still work

So I made some tests and the issue seems to be related to the upper case T/F in True / False. Switching it to the all lowercase values works. I don't know if the python code executes the migrations this way.

yep, that should still work

For reference, all (string) values passed to RUN_DATABASE_MIGRATIONS are lowercased using the unix command tr, also see https://github.com/Innoactive/Portal-Customization/blob/68977f5b3931804cb9e3097b520b8c38538f6671/django/entrypoint.sh#L10

:tada: This PR is included in version 7.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add max legal width

Inspired by #297
We should enforce a max legal width of wires. It appears that Verilator doesn't support widths over 1 billion:
Width of bit range is huge; vector of over 1billion bits: 0x40000000

This might be a reasonable place to start

Agreed.  As with Verilog, I don't think there's a compelling reason to make it part of the language spec; can just make it an implementation constant.

As long as the error messaging for dynamic left shift plays nice with this, it all seems fine. (Especially since << on a 32-bit register will trigger it almost every time). It seems like that is the most common pattern where this will come up anyway.
Basically, if the large wire is because of an inferred width being > 1 billion, the error message should be "Result of a << operation was >1 billion bits. Error." not "wire T65 is >1 billion bits. Error." The latter is, of course, acceptable in other cases such as the user trying to actually instantiate such a large signal.

Agreed, in general, since the dshl check in #318 and another check for max width in general will both be in the CheckWidths pass, they will both trigger at the same time so the additional information will be there.

Add to CheckWidths, pick same width as Verilator (and comment as much)


restored clk settings

Signed-off-by: Alexandre CASTELLANE<EMAIL_ADDRESS>

Seems last change broke something


Need PHP support

Thank you very much.

I think I've got an idea of how to implement this, at least for PHPUnit.
It will probably be a little while before I can get started on this, but will try to get around to it at some point

Looks like someone else has already taken care of this! Refs #68
https://marketplace.visualstudio.com/items?itemName=recca0120.vscode-phpunit


DialogNode.gd refactoring

After trying to make some custom choice menu I realized the code is not exactly easy to read and I heard the owner of the project on one of his youtube videos saying that the new direction of Dialogic is to make it more accessible for extension.
That said I decided to start cleaning the code and refactoring on my way to understand the workings of the plugin; Here's the first part of that.
Some highlights:

Standarized style to more closely follow GDScript's suggested styling (did what I could without changing the names of variables and/or functions that could be being used outside the script as to not break compatibility)

var example : type -> var example: type

enum state -> enum STATE

Spaced static dictionaries

Separated some 'magic' values to constants

Fixed mismatched indentation labels on empty lines

Replaced continuous invocations of $ operator to onready variables
Moved responsibility of next indicator visibility from DialogNode to TextBubble (simple wrapping)
Changed definition_visible to a setget variable (I noticed that every assignation to it did the same thing so I simplified the invocation)
Removed superfluous comments
Standardized comments spelling (Capitalization, spacing, maximum line length)
Separated obtuse functionality to their own functions (Increase modularity, reduce function line count, make methods more legible, makes functionality easier to find)
Removed unused update_custom_events() function
Rephrased some comments to better explain the code
Removed instances of internal developer banter from the code (Keep in the commits guys)
Replaced long chains of elifs to match statements
+Separated event handling to a function per type (way more legible and easier to modify)
Removed commented out code
Separated option creation to it's own _create_option(options) function, this will make overriding this functionality (like in my case) possible, further tweaking pending

There are still many very, very, very long functions that need to be decomposed further.
Some of the functionality that DialogNode.gd takes care of should be moved to children nodes, specially the Control node resizing/positioning, that behavior should be responsibility of the children nodes that have a script attached to them.
This same process needs to be applied to the rest of the scripts of the addon, but one step at a time.

I don't want this to be merged right away but I do want to start a discussion on refactoring to improve extensibility and readability.
I'll probably continue refactoring, let me know.

Hi, thanks for your work first of all.
the problem is that the development focus currently is on 2.0 which is basically a complete rewrite of the events and thus the dialog node.
the 1.x branch is currently maintained mainly by @zakary93, and we are mostly going for bug-fixes there.
So it's mostly his decision if he thinks it makes sense for these changes even tho 1.x won't be continued (at most get a few fixes) once 2.0 is out.
Your dedication is definitely appreciated tho. If you want, you can join emilios discord and discuss possible changes there, so no unnecessary work is done.
Just wanted to inform you about the state of affairs, this could still be merged.

Right, could you send me an invite to the server?

https://discord.gg/zNkKBzcXED

Thanks for the effort and it looks like you really thought about stuff to be improved. Unfortunately this won't be merged since the 1.X branch is going to stay as is and we will continue working on the 2.0 branch. Feel free to get familiar with the new branch and see if you can contribute in that one instead since it is our top priority. If you want to keep working on the 1.X branch there are still some bugs that need fixing but are not high priority; you can check the milestone: https://github.com/coppolaemilio/dialogic/milestone/7
Thanks again!


Distance helper function

Great library! I used to use the distance helper function in 2.x, and I'm wondering if there's any way to access it in 3.x.
For me it was useful to display a user's distance from a location immediately after they added it.

I don't think this will fit in with the new format of geofirestore. However I do have a super lightwight library (geohelper) which would probably be perfect for you => https://github.com/MichaelSolati/geokit#geokitdistancestart-latlngliteral-end-latlngliteral-unit-string-number


SHAP test fails with the new Elastic Net Classifier parameters

In this PR, we change the init params for ENC in order to pass the shap tests (test_shap) in the test_algoritthms.py file. Leaving the init params as alpha = 0.0001 and l1_ratio=0.15 caused a ZeroDivisionError while calculating shap, which is likely linked to this.
Filing this issue to determine why the test fails and figure out a good way to avoid this error.

I think this is a shap issue. I filed https://github.com/slundberg/shap/issues/2000 for discussion. In the short term, I think we can do the following:

Use link="identity" in the KernelExplainer for linear models
Use LinearExplainer with logit link, explainer = shap.LinearExplainer(classifier, X, link=shap.links.logit)

A further test that failed:
On main, using alpha=0.5, l1_ratio=0.5, which is what we have prior to this, if we add this test into evalml/tests/model_understanding_tests/prediction_explaination_tests/test_explainers.py:
@pytest.mark.parametrize("estimator", ["Extra Trees Classifier", "Elastic Net Classifier"])
def test_elastic_net(estimator, fraud_100):
    pytest.importorskip('imblearn', reason='Skipping test because imblearn not installed')
    X, y = fraud_100
    pipeline = BinaryClassificationPipeline(component_graph=["Imputer", "One Hot Encoder", "DateTime Featurization Component", estimator])
    pipeline.fit(X=X, y=y)
    pipeline.predict(X)
    importance = explain_predictions(pipeline, X, y, indices_to_explain=[0], top_k_features=4)
    assert report['feature_names'].isnull().sum() == 0
    assert report['feature_values'].isnull().sum() == 0

The test fails:

If we change the alpha and l1_ratio, it still fails.

Ok @bchen1116 , go do it.

Closing with this PR


Add views support in Snowflake

Feature request:
Add views to the lineage graph.
Requested on Slack, 2021-09-27.

This is already fixed :)


[Giveaways] NoneType object has no attribute 'id'

This seems to post to logs every once in a while.
Full traceback below:
Traceback (most recent call last):
   File "/home/max/redenv/lib/python3.9/site-packages/discord/client.py", line 343, in _run_event
     await coro(*args, **kwargs)
     File "/home/max/redbot/cogs/CogManager/cogs/giveaways/main.py", line 382, in on_command_completion
     settings = await get_guild_settings(ctx.guild.id)
AttributeError: 'NoneType' object has no attribute 'id'

Fixed


Include Fauxhai 3.8 and Inspec 0.29.0

Signed-off-by: Tim Smith<EMAIL_ADDRESS>

:+1:

:+1:

This is now on master already from a different PR


Alternative to im-select.exe on Windows

I find that we can use luajit ffi to call win32api to control keyboard layout and ime state on Windows, without the burden of a extra binary and another language pack.
I'm not a pro coder yet, so I'm not confident enough to make a good pull request.
Below code is my personal config which doesn't support switching between keyboard-layouts, I think it's doable by similar method.
If a pull request is needed, I can try to read im-select.nvim's source code and make a configurable pull request.
Feel free to use below code with ❤
-- Reference:
-- https://www.cnblogs.com/yf-zhao/p/16018481.html
-- https://zhuanlan.zhihu.com/p/425951648

local ffi = require "ffi"

ffi.cdef [[
    typedef unsigned int UINT, HWND, WPARAM;
    typedef unsigned long LPARAM, LRESULT;
    LRESULT SendMessageA(HWND hWnd, UINT Msg, WPARAM wParam, LPARAM lParam);
    HWND ImmGetDefaultIMEWnd(HWND unnamedParam1);
    HWND GetForegroundWindow();
]]

local user32 = ffi.load "user32.dll"
local imm32 = ffi.load "imm32.dll"

local ime_hwnd
local ime_group = vim.api.nvim_create_augroup("ime_toggle", { clear = true })

-- Get ime control's hwnd after InsertEnter or CmdlineEnter
-- to ensure getting correct foregroundwindow
vim.api.nvim_create_autocmd({ "InsertEnter", "CmdlineEnter" }, {
    group = ime_group,
    once = true,
    desc = "Get ime control hwnd attached to nvim window",
    callback = function()
        ime_hwnd = imm32.ImmGetDefaultIMEWnd(user32.GetForegroundWindow())
    end,
})

local WM_IME_CONTROL = 0x283
local IMC_GETCONVERSIONMODE = 0x001
local IMC_SETCONVERSIONMODE = 0x002 -- It's said this value differs on different ime, I'm not sure
local ime_mode_ch = 1025
local ime_mode_en = 0

local function set_ime_mode(mode)
    return user32.SendMessageA(ime_hwnd, WM_IME_CONTROL, IMC_SETCONVERSIONMODE, mode)
end

local function get_ime_mode()
    return user32.SendMessageA(ime_hwnd, WM_IME_CONTROL, IMC_GETCONVERSIONMODE, 0)
end

vim.api.nvim_create_autocmd({ "InsertLeave", "CmdlineLeave" }, {
    group = ime_group,
    desc = "Toggle ime to English mode on normal mode",
    callback = function()
        if ime_mode_ch == get_ime_mode() then
            set_ime_mode(ime_mode_en)
        end
    end,
})

Good idea!
I will try it ASAP. If it works as expect, I will merge it.

I don't abonden this issue, but in the last few months my PC has been far away from me, so I can't do the migration.
I will continue this work in May 2024.

Sorry for delay, but my computer is still on the way  _(:з」∠)_
I will test this solution as soon as possible when I receive my computer.

Sorry for delay, but my computer is still on the way (:з」∠)
I will test this solution as soon as possible when I receive my computer.

I tested, it's worked perfectly

Thinks for your help


golang-devtools - golangci

The repository github.com/coopnorge/go-services-interfaces cannot be fetched inside golang-devtool, so it fails.
Error:
level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/coopnorge/go-services-interfaces/coopnorge/customerdirectory/v1beta1\""
CI log:
https://github.com/coopnorge/member-customer-directory/actions/runs/5422540229/jobs/9859312983#step:3:102
For now, we added vendor otherwise linter will not work in GitHub

Found across another old project where it was solved by adding in CI git config --global url."https://${{ secrets.REVIEWBOT_GITHUB_TOKEN<EMAIL_ADDRESS>"https://github.com/coopnorge"


Update dependencies (Cats 1.0.0-MF)

This PR upgrades Fetch to Cats 1.0.0-MF (and monix to 3.0.0-M1, catbird to 0.18.0).
We are now also using sbt 1.0.2 (thanks to @suhasgaddam for his help here and in sbt-org-policies).

Codecov Report

Merging #137 into master will decrease coverage by 0.72%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   78.81%   78.09%   -0.73%
==========================================
  Files          15       16       +1
  Lines         321      315       -6
  Branches        2        2
==========================================
- Hits          253      246       -7
- Misses         68       69       +1

Impacted Files
Coverage Δ

monix/shared/src/main/scala/monix.scala
78.57% <ø> (ø)
:arrow_up:

shared/src/main/scala/FetchMonadError.scala
100% <ø> (ø)
:arrow_up:

shared/src/main/scala/interpreters.scala
100% <ø> (ø)
:arrow_up:

.../src/main/scala/interpreters/CoreInterpreter.scala
91.35% <100%> (-0.11%)
:arrow_down:

shared/src/main/scala/fetch.scala
88.23% <100%> (+5.3%)
:arrow_up:

shared/src/main/scala/freeinspect.scala
61.53% <100%> (ø)
:arrow_up:

...rc/main/scala/interpreters/MaxBatchSizePhase.scala
100% <100%> (ø)
:arrow_up:

shared/src/main/scala/datasource.scala
66.66% <50%> (ø)
:arrow_up:

shared/src/main/scala/Query.scala
62.5% <62.5%> (ø)

...rc/main/scala/interpreters/ParallelJoinPhase.scala
83.87% <92.85%> (-5.32%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a137c94...fbef2df. Read the comment docs.

II think if we merge this, merge master in #135 it will pass as well.
After that I'll open an new PR for a 0.7.0 release.


Custom context manager not respected when span processors / exporters are configured via env vars

What happened?
Steps to Reproduce
Configure env vars to any kind of trace exporter.
Use the NodeSDK and configure a custom context manager via the ctor.
Expected Result
custom context manager is used
Actual Result
custom context manager is not used
Additional Details
When setting a span processor or trace exporter via the NodeSDK ctor, this causes an internal TracerProvider config to be eagerly created. In this case, the context manager is copied over from the SDK config to the created TracerProvider config. Later, in the start call, this config is respected when registering the tracer provider by getting the context manager from the config object and passing it on to the register call.
When NOT setting a span processor or trace exporter, no config object is eagerly created. In this case, the register call does not check the config of the SDK (where the context manager would be) but passes on no context manager at all.
OpenTelemetry Setup Code
class EnvVarContextManager {
  inner;

  constructor(inner) {
    this.inner = inner;
  }

  enable() {
    return this;
  }

  disable() {
    return this;
  }

  active() {
    let context = this.inner.active();
    if (opentelemetry_api.ROOT_CONTEXT == context) {
      context = new opentelemetry_sdk.core.W3CTraceContextPropagator().extract(context, { traceparent: process.env.OTEL_TRACEPARENT }, opentelemetry_api.defaultTextMapGetter);
    }
    return context;
  }

  bind(...args) {
    return this.inner.bind(...args);
  }

  with(...args) {
    return this.inner.with(...args);
  }

}

let sdk = new opentelemetry_sdk.NodeSDK({
    contextManager: new EnvVarContextManager(new context_async_hooks.AsyncLocalStorageContextManager()),
    //spanProcessor: new BatchSpanProcessor(new OTLPTraceExporter()) // add this back in to fix the custom context manager
    instrumentations: [getNodeAutoInstrumentations({'@opentelemetry/instrumentation-fs': { enabled: false }})]
  });

sdk.start()

package.json
"@opentelemetry/resources": "1.25.0",
    "@opentelemetry/semantic-conventions": "1.25.0",
    "@opentelemetry/api": "1.9.0",
    "@opentelemetry/core": "1.25.0",
    "@opentelemetry/sdk-node": "0.52.0",
    "@opentelemetry/sdk-trace-base": "1.25.0",
    "@opentelemetry/exporter-trace-otlp-proto": "0.52.0",
    "@opentelemetry/auto-instrumentations-node": "0.47.0",
    "@opentelemetry/exporter-metrics-otlp-proto": "0.52.0",
    "opentelemetry-resource-detector-git": "0.30.0",
    "@opentelemetry/resource-detector-github": "0.28.2",
    "@opentelemetry/resource-detector-container": "0.3.10",
    "@opentelemetry/resource-detector-aws": "1.5.1",
    "@opentelemetry/resource-detector-gcp": "0.29.10",
    "@opentelemetry/resource-detector-alibaba-cloud": "0.28.10",

Relevant log output
No response

Yep, that's a bug. Thanks for the detailed report @plengauer.
I opened a PR (#4781) to fix this.


orange square merged but not showing on site

MillHaus33 merged https://github.com/ordinals-wallet/ordinals-collections/commit/118b6caad669c77243931e4ea3345c93d42439b9 but not showing the updates on site

Im aware - working on making this real


Peek / goto definition does not work on MacOS

Hi, trying to get up an running with Ionide for VSCode, but I'm still encountering some issues. Last one, that I didn't manage to google successfully is related to peek/goto definition. So, let's say I have:
open System

and I click Go to definition I got an error:

Similar, when I e.g. Go to definition for open Suave, I got

Moreover, when I peek definition on any of above, I got an empty result and no no error or anything.
Below the F# Language Services output colected during 'Peek definition':
[16:54:38 DEBUG] REQ (149) -> {tooltip}, File = "~/--no-prompt/Test/Test.fs"
Data={"FileName":"/Users/dominik/Projects/research/fsharp/--no-prompt/Test/Test.fs","Line":1,"Column":7,"Filter":""}
[16:54:38 DEBUG] RES (149) <- {tooltip} in 4 ms: Kind={"tooltip"}
Data=[[{"Signature":"namespace System","Comment":"","Footer":"Full name: System\nAssembly: System.Xml.XPath.XDocument"}]]
[16:54:39 DEBUG] REQ (150) -> {parse}, File = "~/--no-prompt/Test/Test.fs"
Data={"FileName":"/Users/dominik/Projects/research/fsharp/--no-prompt/Test/Test.fs","IsAsync":true,"Lines":["open System\r","open Suave                 // always open suave\r","open Suave.Successful      // for OK-result\r","open Suave.Web             // for config\r","\r","startWebServer defaultConfig (OK \"Hello World!\")\r",""],"Version":7}
[16:54:39 DEBUG] REQ (151) -> {finddeclaration}, File = "~/--no-prompt/Test/Test.fs"
Data={"FileName":"/Users/dominik/Projects/research/fsharp/--no-prompt/Test/Test.fs","Line":1,"Column":8,"Filter":""}
[16:54:39 DEBUG] RES (151) <- {finddeclaration} in 4 ms: Kind={"finddecl"}
Data={"File":"/Users/dominik/Projects/research/fsharp/--no-prompt/Test/startup","Line":1,"Column":1}
[16:54:39 DEBUG] RES (150) <- {parse} in 9 ms: Kind={"errors"}
Data={"File":"/Users/dominik/Projects/research/fsharp/--no-prompt/Test/Test.fs","Errors":[]}
[16:54:39 DEBUG] REQ (152) -> {signature}, File = "~/--no-prompt/Test/Test.fs"
Data={"FileName":"/Users/dominik/Projects/research/fsharp/--no-prompt/Test/Test.fs","Line":1,"Column":8,"Filter":""}
[16:54:39 DEBUG] REQ (153) -> {lint}, File = "~/--no-prompt/Test/Test.fs"
Data={"FileName":"/Users/dominik/Projects/research/fsharp/--no-prompt/Test/Test.fs"}
[16:54:39 DEBUG] REQ (154) -> {unusedOpens}, File = "~/--no-prompt/Test/Test.fs"
Data={"FileName":"/Users/dominik/Projects/research/fsharp/--no-prompt/Test/Test.fs"}
[16:54:39 DEBUG] REQ (155) -> {unusedDeclarations}, File = "~/--no-prompt/Test/Test.fs"
Data={"FileName":"/Users/dominik/Projects/research/fsharp/--no-prompt/Test/Test.fs"}
[16:54:39 DEBUG] REQ (156) -> {simplifiedNames}, File = "~/--no-prompt/Test/Test.fs"
Data={"FileName":"/Users/dominik/Projects/research/fsharp/--no-prompt/Test/Test.fs"}
[16:54:39 DEBUG] REQ (157) -> {projectsInBackground}, File = "~/--no-prompt/Test/Test.fs"
Data={"FileName":"/Users/dominik/Projects/research/fsharp/--no-prompt/Test/Test.fs"}
[16:54:39 DEBUG] RES (155) <- {unusedDeclarations} in 7 ms: Kind={"unusedDeclarations"}
Data={"Declarations":[]}
[16:54:39 DEBUG] RES (152) <- {signature} in 11 ms: Kind={"typesig"}
Data="namespace System"
[16:54:39 DEBUG] RES (157) <- {projectsInBackground} in 6 ms: Kind={"errors"}
Data={"File":"","Errors":[]}
[16:54:39 DEBUG] RES (156) <- {simplifiedNames} in 10 ms: Kind={"simpifiedNames"}
Data={"Names":[]}
[16:54:39 DEBUG] RES (153) <- {lint} in 14 ms: Kind={"lint"}
Data=[]
[16:54:39 DEBUG] RES (154) <- {unusedOpens} in 26 ms: Kind={"unusedOpens"}
Data={"Declarations":[{"StartColumn":6,"StartLine":1,"EndColumn":12,"EndLine":1},{"StartColumn":6,"StartLine":4,"EndColumn":15,"EndLine":4}]}
[16:54:39 DEBUG] WebSocket message: '{"Kind":"errors","Data":{"File":"/Users/dominik/Projects/research/fsharp/--no-prompt/Test/Test.fs","Errors":[]}}'

Here's my system details:
MacOs: 10.13.5
Mono: <IP_ADDRESS> (installed via Homebrew)
netcore: 2.1.103

Probably upstream issue in fsautocomplete.

I'm not really sure if failing when one try to go to definition of something defined in external library (System, Suave) is a problem at all. I mean, it shouldn't probably throw those error messages but other than that it works as expected - i.e. nothing happens.

Fixed attempts of going to not existing file in 0c5e8375538acf8f80a80ef373d10b48975a179c


Why I cannot run Fortran code with GFortran?

I have installed MinGW-w64 and set a path to environment variable.
But when I open a '.f90' file I cannot find a available environment to debug or run it.
Could you tell me the solution to me?
Thank you

Sorry but how I don't get what you mean by " available environment to debug or run it." Can you clarify on this?


Message bar & navbar positioning

When a messagebar has focus, the keyboard pops up and moves the entire page contents with it, including the navbar.
I was under the impression that the odd layout of putting the messagebar elements before the messages element was to control the layout a bit easier, but it seems not to be the case. Is there a way to keep the navbar literally fixed to the top and never let it go hidden?

Closing this. Thanks again.


array literal on constructor

Array literal (rest parameter) don't seem to work with constructor
example:
let a = [1, 2, ...arr, 4, 5]; //works
Math.max(...arr); //works
myFunction(...arr); //works
new myClass(...arr); //error

Should work with ES5 target, see #2369

Yup, @tinganho fixed this one. Thanks guys!


Docs suggestion

Hi Jonathan,
I hope you're well.
This is a bit presumptuous, to suggest an improvement to your docs.
There is a lot of very useful information on the methods reference docs.
I have forked your repository and wondered if you thought adding a table of contents at the top of the page would be useful, like this?
It might not be very sensible to have chopped it up like I have done - another option would be to have a simple list linking to every method since that keeps to the same alphabetical layout as the actual content.
It might be how my brain works but when scanning through the list of methods I find it useful to group them by the initial few characters of the method name (e.g. add, delete, follow, get etc), hence the nested lists layout.
I don't really know how GitHub works in terms of forks etc - but did the fork so I could edit the page on fork to show you what I mean.
Anyway, as I say, I don't want to be seen as saying I know better, it is just a suggestion.
Thanks
Jim

Hi Jonathan,
That's interesting about the script - thanks for the info.
However, I'll now quietly exit and stop pretending I know stuff 😂😆🤣.
Thanks
Jim

Hi again Jim!
Just wanted to let you know I've updated the script and method reference with a table of contents.
Cheers,
Jonathan

Hi Jonathan! That's great - thanks very much for that :-)
Wishing you a good weekend.
Thanks
Jim


fixed missing dependency for string-null? in sxml-parser

Problem:
> (load (spheres/markup sxml-parser))
> (xml-string->sxml "<title>CIAO</title>
MONDO
")
*** ERROR IN #<procedure #3> -- Unbound variable: spheres/core#base#string-null?

after fix:
> (load (spheres/markup sxml-parser))
> (xml-string->sxml "<title>CIAO</title>
MONDO
")
(*TOP* (html (head (title "CIAO")) (body (@ (background "white")) (p "MONDO"))))

Awesome!!
By the way, I think you have to put the all the imports inside the same import clause:
(import (spheres/core base)
            (spheres/string string))

Even if it works, I don't really know if it is expected to.

Sir, it's just the opposite, if I write (import (spheres/core base)             (spheres/string string)) then it does not work

That is wrong... something fishy is going on. I'll take a look.


Add syntax coloration for the Python snippet

Add syntax coloration for the Python snippet

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a49c874). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #42   +/-   ##
=========================================
  Coverage          ?   93.65%
=========================================
  Files             ?       17
  Lines             ?     2617
  Branches          ?        0
=========================================
  Hits              ?     2451
  Misses            ?      166
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49c874...c17cde8. Read the comment docs.

Thanks for the fix !


(Unit testing) using Karma test runner

Based on reply in Angular CLI project project thread.
https://github.com/angular/angular-cli/issues/4543#issuecomment-303364585

I was unable to write unit test for the contents shown on ngx-bootstrap modal, as the BsModalService requires
window.getcomputedstyle().getpropertyvalue(), which is hard to polyfill in jsDom (used by Jest)

Code coverage using istanbul

In favour of readme file

Unit testing with Jest (Going back to Karma soon)

Ideas taken from

JavascriptServices - Angular SPA
AngularClass/angular-starter

This is fantastic! Yeah I think ideally we might as well stick with the default as Jest doesn't offer the same type of testing. I'll move the Jest stuff into a HOW TO PR, for others to see at least!
👍👍🍻🍻

I deleted ngx-bootstrap from my app.  Do I need to worry about this?
Is this a bigger issue or is this PR just to fix testing ngx-bootstrap modal testing?

@davidsekar @MarkPieszak   Is this something I need to be pulling in?  Or just an issue with testing ngx-bootstrap which I don't use in my app

It's up to you, this is just if you want the traditional way Karma does testing (with a browser) as opposed to Jest, which can't do that. @jrmcdona


Ignoring files should not cause error

Problem
I am trying to run alex on a directory of markdown files, and one of the files there is ignored. And alex throws an error.
Expectation
I think it should just silently ignore the file, without exiting with an error failing the build.
Reproduce
To reproduce:

Have two files in root: README.md and MAINTAINERS.md
In .alexignore, ignore MAINTAINERS.md
Run $ alex *.md

And you will get an error.

Travis-CI build output for reference: https://travis-ci.org/Travix-International/frint/builds/231453498#L1895

if I modify unified-engine/lib/finder.js:148 (link) a bit, it works like I expect it to:
if (ignored) {
  try {
    // file.fail('Cannot process specified file: it’s ignored');
  } catch (err) {}

  return one(null, []);
}

Thanks for using alex, @fahad19, and hi!
This is intentional. Globs are expanded, and you’re saying like “get README.md and MAINTAINERS.md”, but then “don’t get MAINTAINERS.md”, and alex knows not what to do.
The simplest fix is probably to let alex find files itself: alex .
Could you check if that works?

@wooorm: that worked! I will close this issue.
thanks for being so quick and helpful!

Great!  Sure, no problem, and glad to hear!
👋

I want to re-open this issue because it still causes some issues in some cases.
Related:

https://github.com/get-alex/alex/issues/338


Lack of search date field causes records to be irretrievable by a search with a date range

There are 500,000 plus entries in the database without a search date field

The fix for the date range in a search needs a crawler rake task. Most of estimate of size is for shepherding the rake task

The fix for the date range in a search needs a crawler rake task. Most of estimate of size is for shepherding the rake task

Needs to be scheduled after the next monthly update

Needs to be scheduled after the next monthly update

checked 40,304,379 records there were 3,832,166 missing a search date or just under 10%

checked 40,304,379 records there were 3,832,166 missing a search date or just under 10%


Support for messages in transactions

Is your feature request related to a problem? Please describe.
Transactions can have messages attached....it is useful to see those messages.

Maybe it could be even more interesting to have a dedicated message page

Done in version 1.2


Add a method to profile a series of hyperparameter runs

Documented quite well in TensorFlow's tensorboard docs. The idea is we can set a series of tensorboard parameters and then use these to experiment with the effect of changing a variety of parameters. There is also pytorch documentation for this using: add_hparams(hparam_dict, metric_dict, hparam_domain_discrete=None, run_name=None) contained as a method in torch.utils.tensorboard.

hello，I meet this problem, but i do not konw how to solve it, can you help me? I do not konw the reason and where is wrong,  I am looking forword to you reply.
D:\Anaconda3\envs\Airsim\python.exe E:\computer\GitHub\Fixedwing-Airsim-master\src\main.py
In file D:/Anaconda3/envs/Airsim/Lib/site-packages/jsbsim/aircraft/x8/x8.xml: line 80
Engine location ignored, only thruster location is used.
In file D:/Anaconda3/envs/Airsim/Lib/site-packages/jsbsim/aircraft/x8/x8.xml: line 85
Engine orientation ignored, only thruster orientation is used.
Traceback (most recent call last):
File "E:\computer\GitHub\Fixedwing-Airsim-master\src\main.py", line 218, in
run_simulator()
File "E:\computer\GitHub\Fixedwing-Airsim-master\src\main.py", line 196, in run_simulator
env.simulation_loop(rectangle)
File "E:\computer\GitHub\Fixedwing-Airsim-master\src\main.py", line 93, in simulation_loop
image.get_np_image(image_type=airsim.ImageType.Scene)
File "E:\computer\GitHub\Fixedwing-Airsim-master\src\image_processing.py", line 44, in get_np_image
False)])
File "D:\Anaconda3\envs\Airsim\lib\site-packages\airsim\client.py", line 295, in simGetImages
responses_raw = self.client.call("simGetImages", requests, vehicle_name)
File "D:\Anaconda3\envs\Airsim\lib\site-packages\msgpackrpc\session.py", line 41, in call
return self.send_request(method, args).get()
File "D:\Anaconda3\envs\Airsim\lib\site-packages\msgpackrpc\future.py", line 45, in get
raise error.RPCError(self._error)
msgpackrpc.error.RPCError: rpclib: client error C0002: Function 'simGetImages' was called with an invalid number of arguments. Expected: 2, got: 3
JSBSim Flight Dynamics Model v1.1.13 [GitHub build 986/commit a09715f01b9e568ce75ca2635ba0a78ce57f7cdd] Dec  3 2022 12:36:17
[JSBSim-ML v2.0]
JSBSim startup beginning ...
Connected!
Client Ver:1 (Min Req: 1), Server Ver:1 (Min Req: 1)
Process finished with exit code


Nip42 (AUTH)

Seems to work fine, tested with 2 different relay implementations,
nostr-rs-relay and nostream are the 2 most popular relay softwares, we should also make sure to test it on these before merging
https://nip42.snort-social.pages.dev/

I tested it out a bit on my private relay, seems to be working well.
I noticed that it tries to AUTH against a server that is not marked to be read from, which I think it shouldn't do.
I noticed this because I thought my server had read settings set to true, but I only saw it AUTH successfully and not send any other REQ messages (or receive events).
https://github.com/v0l/snort/pull/145

Nostream doesn't seem to support NIP-42 according to README, neither does nostr-rs-relay. We should test with them when they release NIP-42 support, code lgtm.

The good thing about this is, it doesnt matter if the relay supports it or not, so we can merge this anyway it will only respond to AUTH if the relay asks for it

🎉


Sonoboy retrieve fails saving on a different path

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
Running sonobuoy retrieve fails if the path specified using -f contains a path to a directory.
$ sonobuoy retrieve -f /tmp/work/results.tar.gz
error retrieving results: non-zero data ¸ (byte 184) read after tar EOF
$ sonobuoy retrieve
202205050313_sonobuoy_9e1c1194-9068-4899-b8b2-000c8bb19fd1.tar.gz
$ sonobuoy retrieve -f /tmp/work/results.tar
error retrieving results: non-zero data ¸ (byte 184) read after tar EOF
$ sonobuoy retrieve -f results.tar
results.tar

What did you expect to happen:
Able to save the results tar ball on a directory different to where the  sonobouy binary  is located
Environment:

Sonobuoy version: v0.56.4

👍 thanks for the report. In reproducing this, it is actually just a problem if the directory path doesnt exist:
> sonobuoy retrieve
202204281423_sonobuoy_5e4ffa01-f4ea-495e-9dc4-20e962768631.tar.gz
> sonobuoy retrieve -f foo.tar.gz
foo.tar.gz
> sonobuoy retrieve -f ./doesntexist/foo.tar.gz
error retrieving results: non-zero data Ý (byte 221) read after tar EOF
> mkdir exists
> sonobuoy retrieve -f ./exists/foo.tar.gz
exists/foo.tar.gz

No reason we shouldn't make that path though; I would have thought we already did.

Looking at this further, you can do what you want but in a wonky way.
sonobuoy retrieve <dir path> -f <filename> will create the directories for you.
This needs corrected though just to be more predictable.

And it makes sense why the error is occurring now. It tries to make the file <dir doesnt exist>/<file> which fails for os.Create but the method has a defer block that checks we drained the reader. Since we didnt (because of the creation error) it complains.

@johnSchnake thanks for checking, I think that the issue is happening when using an absolute path.
$ ll /tmp/work/
total 0
$ ./sonobuoy retrieve -f /tmp/work/results.tar.gz
error retrieving results: non-zero data u (byte 117) read after tar EOF
$ mkdir report
$ ./sonobuoy retrieve -f report/results.tar.gz
report/results.tar.gz
$ mkdir /home/user/test
$ ./sonobuoy retrieve -f /home/user/test/results.tar.gz
error retrieving results: non-zero data u (byte 117) read after tar EOF


bcinsider.azurecr.io/bcsandbox cannot be pulled : unauthorized: authentication required

Hi all,
we e used to create containers with normal images pulled from docker pull mcr.microsoft.com/businesscentral/sandbox:update26-us-ltsc2016 but now we want to use BCinseder images for future development. facing issue while pulling images from docker pull bcinsider.azurecr.io/bcsandbox:us command. Can anyone help here get authorise to this command steps to download the image from bcinsider?
Error details:

PS C:\WINDOWS\system32> docker pull bcinsider.azurecr.io/bcsandbox:us
docker : Error response from daemon: Get https://bcinsider.azurecr.io/v2/bcsandbox/manifests/us: unauthorized: authentication required
At line:1 char:1

docker pull bcinsider.azurecr.io/bcsandbox:us

 + CategoryInfo          : NotSpecified: (Error response ...cation required:String) [], RemoteException
 + FullyQualifiedErrorId : NativeCommandError

Thanks
Sachin Chavan

@freddydk / @waldo1001 :  can you please help to resolve this issue.

You file an issue and 8 minutes after - you ping people to get your issue resolved faster?
I try to answer issues here as fast as possible, but to be honest, I see this behavior as rude.
Having said that...
Look at the error - authentication required.
I think you need to authenticate.
If you already did - then you might have used wrong credentials (they were changes x months ago, meaning you probably are not in a hurry here)
Since you are using bcinsider - you get credentials through collaborate and you also find the explanation there on how to authenticate.
In the future, please allow people at least 24 hours to respond before pinging people when filing something on github.

It is even explained here where you get the credentials https://freddysblog.com/2019/07/31/preview-of-dynamics-365-business-central-2019-release-wave-2/

To resolve error : unauthorized: authentication required
try to use VS code PowerShell rather than normal PowerShell
use below command
docker login "bcinsider.azurecr.io"
and here use bcinsider credentials (Username & Password) which you have received from Collaborate


Retire all Javadoc author tags

As discussed in the forum: http://forum.terasology.org/threads/removal-of-all-javadoc-author-tags-any-objections.1273/
No objections so far, so if anybody wants to get it over with doooo eeeet :-)
We probably should also look at Javadoc in modules, lest we forget and have them break when updated to Java 8.

I'll have a look at it in the frame of an update of code style checkers and also add the @author tag to the set of checkstyle rules.
Gradle 2.4 should bring a few niceties for improved integration and I might want to wait for it to be released. This should be the next 1-2 weeks, I hope.

Sounds good, no rush :)

Started looking at module javadoc some thinking maybe I could fix up a few modules real quick, switch them to Java 8 in Jenkins, then run good builds so we can have working binary releases again ... but I may be underestimating the amount of errors :D
I just started with a search for @author in *.java under modules in my mega-workspace and fixed 136 hits across AnotherWorld, BlockNetwork, Breathing, and Cities. But that didn't count other javadoc errors ;-)
It is a bit of a hassle to detect them too, takes forever if using gradlew javadoc on a particular module. Wonder if Checkstyle could catch it all specifically to make it easier to fix. I'm probably missing other easy options.
Just to get a list anywhere here are the modules in the lineup with author tags (about 500 file hits, not counting what I've got fixed locally):

[ ] AnotherWorld
[ ] Breathing
[ ] Cities
[ ] CommonWorld
[ ] CopperAndBronze
[ ] Core (wut? I thought that was covered and would break things if not)
[ ] Fences
[ ] Fluid
[ ] Genome
[ ] GrowingFlora
[ ] Hunger
[ ] Journal
[ ] LightAndShadow
[ ] Malicious
[ ] MarkovChains
[ ] MasterOfOreon
[ ] Maze
[ ] Miniion
[ ] Minimap
[ ] MultiBlock
[ ] MusicDirector
[ ] NameGenerator
[ ] OreGeneration
[ ] Pathfinding
[ ] PlantPack
[ ] PolyWorld
[ ] Portals
[ ] Sample
[ ] Seasons
[ ] Signalling
[ ] Spawning
[ ] WeatherManager (okay, may not be in the lineup yet, but I have it in my workspace)
[ ] WoodAndStone
[ ] Workstation

I just noticed Gradle 2.4 adds an ability to replace external dependencies with project dependencies, woo! That's what I've hacked in presently. That'll be nice to clean up - that release could indeed be sweet :-)

Temp hack in place to let the module builds work: https://github.com/MovingBlocks/Terasology/commit/e328c4ac69d73eaca8f3b80ac06c590658ab3f00
Includes a TODO to remove it again later, since you know that always ensures that it does in fact get removed later ...
Jenkins should log the warnings + errors so at least they'll be easy to spot, although I'm sure there's a better way in IDEs

I tried to configure CheckStyle to flag @author tags, but it just wouldn't do it. I suspect that it's a bug in CheckStyle (related issue).

Unfortunately, my assumption was confirmed and we need to find a workaround such as plain RegEx to make CheckStyle flag the remaining @author  tags.

I think that we can close this issue, since all MovingBlocks repositories have been updated.

Agreed! And we have warnings being issued for them now too, thanks for that :-)


Allowlist/Rejectlist of IPs on stratum port

Description
As an operator, I want to maintain IP ranges that I explicitly allow or reject from participating in connecting to the stratum port.
Acceptance Criteria

A series of configuration entries, CLI flags and environment variables, using the approach taken by Besu to manage its configuration, allows operators to enter allowlist and rejectlist ranges of validated IPs into Besu.
The values are used to block or accept miners.

@diega @atoulme  - still needed in PoW?

This is not a requirement that we currently have, but I think this is a nice feature and probably a fair candidate for good-first-issue. I would keep this open even unnasigned.

Ok to re-open if someone picks up the work.


Clarify Alice and Bob

Not sure that the "Move coins between Alice and Bob only by mixing!" message means.
Also not sure why there are two wallets Alice and Bob? What are they for? What's the difference between the two? There seems to be only one wallet file.

Great note, I was hoping it's clear, but I am actually hoping more it'll be clear after TumbleBit integration. If the confusion still persists I reopen the issue.

On second thought, it's better to keep it open until the issue is resolved.

Braindump. Account/Identity vs wallet files: https://github.com/nopara73/HiddenWallet/issues/24#issuecomment-301737782

With ZeroLink the accounts system will likely be redisigned. Keep the issue open: https://github.com/nopara73/ZeroLink/

I think this needs revisiting now.
For new users (and those participating in testing) it is unclear what the Alice and Bob wallets are.
I don't think many people will realise that they are essentially two wallets generated from the one mnemonic phrase.
It is also unclear as to why they are called Alice and Bob.
Perhaps we could have one of the following:
Pre-mix and Post-mix
Normal and Mixed
...that kind of thing.
To reduce the amount of bugs changing Alice and Bob could cause in the code I'd suggest keeping the back end code using "ALICE" and "BOB" and just changing the GUI text to show the new names.
Perhaps adding a mouse over pop up text explaining what they are used for would also be useful (it would).

I think this issue can be closed. Now that we have a mixer, which can move coins between Alice and Bob wallets, and also a couple of hint messages, it becomes more obvious what Alice and Bob is.
I realize this is not a complete, clean resolution, however I don't see any way to fix it without complete redesign of the GUI, which will be due for the stable version.
Maybe renaming the tabs can be a slight improvement.

Pre-mix and Post-mix
Normal and Mixed

Not good, because mixing is two way.

To reduce the amount of bugs changing Alice and Bob could cause in the code I'd suggest keeping the back end code using "ALICE" and "BOB" and just changing the GUI text to show the new names.

Agree in principle, if we want to change that's what we have to do. I'd just like to note multiple renamings would be needed. For example renaming the select box in the mixer tab, renaming some in some of the hints, etc...

If you'd like someone to do that chore work, I will.
I understood what they meant immediately, even without reading any explanation, but I'm crypto-savvy ... new users will be totally lost, ha.  I'd recommend instead of a rename a help modal/box be added or an introductory explanation on first launch.

Even Wallet A and Wallet B might be better. I am used to Alice and Bob now but I think it confuses new users. Anyway....

In the new version: Wallet Wasabi, this will be handled with good coin control, instead of separate wallets.


Replace deprecated URLopener in donwload.py

(Fancy)URLopener is deprecated since Python 3.3.
https://docs.python.org/3/library/urllib.request.html#urllib.request.FancyURLopener

Jenkins, test this please

Jenkins CI test (for commit ccb774b58ab7dbe704abfb7df3fa29915fad8f8f, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins, test this please.

Jenkins CI test (for commit ccb774b58ab7dbe704abfb7df3fa29915fad8f8f, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

LGTM! Test failures are not related to this PR.


Compilation fails on Windows

Thank you for making this library, it looks very nice!
Unfortunately, fake_input uses os::unix, preventing compilation on Windows.
I don't know if what fake_input does is possible in a cross-platform fashion, but since it appears to be a utility for testing, and not essential to the library itself, maybe the module could, for now, be omitted on Windows via cfg?

@hepptho Thank you for the report. Since there are no internal dependencies on fake_input currently, I will remove it from within promkit.

https://github.com/ynqa/promkit/pull/14/commits/73355151b504f0e6bd3f345f414174f5eb50b277

@hepptho Thank you for the report!
Since there are no internal dependencies on fake_input currently, I will remove it from within promkit.

https://github.com/ynqa/promkit/pull/14/commits/73355151b504f0e6bd3f345f414174f5eb50b277

In<EMAIL_ADDRESS>although on MacOS, I have confirmed that you can build binaries for Windows following these steps.
brew install mingw-w64
rustup target add x86_64-pc-windows-gnu
cargo build --target=x86_64-pc-windows-gnu

Can confirm dev-0.3.1 compiles on Windows with both gnu and msvc toolchains 👍
Thank you!

Handled the commit https://github.com/ynqa/promkit/commit/73355151b504f0e6bd3f345f414174f5eb50b277 in #14.


support Python 2.x, esp. 2.7.x?

Hi! :) Only compatible with python 3.0+, but soon I'll add support for python version 2.7+ :+1:

Evandrix Add compatibility with python 2.7.x+ , Actually I'm testing.

yay, thanks!


M19 Gift Pack cards missing

Following cards are missing: M19 Gift Pack (G18)

Think this can probably be closed now we fetch the list of cards from the MTGA data files, and they do include the G18 cards.


Create cryptographic functions

As a developer, I need to create a RSA key pair and save it to iOS keychain
Acceptance criteria:
1 - Create a RSA private key, save and retrieve from keychain

manual tests pass. Needs automated tests.


No Forward or Backwards Movement When Using LetMeLookDown

Looking straight down with Flipmods' LetMelookDown prevents forward and backward camera movement with altitude lock on
https://thunderstore.io/c/lethal-company/p/FlipMods/LetMeLookDown/

Steps to reproduce

Use LetMelookDown
Enable Poltergeist cam upon death
Enable altitude lock with keybind
Look straight down
Try to move forward and backwards with W and S

Side to side movement with A and D still work

Hm, that's weird, I'll look into it.

Should be fixed in the next release. Turns out it doesn't have anything to do with LetMeLookDown, was straight up just a Poltergeist bug.

Great. Sorry I didn't do much testing. Glad you got it sorted.


addition of informing the time feature

Fixes Issue #5
Key Changes:
get_greeting() function:
This function determines the appropriate greeting based on the current hour.
If the hour is before 12 PM, it says "Good morning."
Between 12 PM and 6 PM, it says "Good afternoon."
After 6 PM, it says "Good evening."
if 'time' in query.lower() block:
The assistant greets the user based on the current time using get_greeting().
It then provides the exact time in HH:MM:SS format.

It's Correct Working

@suryanshsk please add the gssoc-ext labels to this
Thank you!

Done.
On Sat, 5 Oct, 2024, 12:17 pm Shrishti, @.***> wrote:

@suryanshsk https://github.com/suryanshsk please add the gssoc-ext
labels to this
Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/suryanshsk/Python-Voice-Assistant-Suryanshsk/pull/8#issuecomment-2394953566,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVBBZFPNEZY3W6E6MYRWALLZZ6DQNAVCNFSM6AAAAABPHBY24WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUHE2TGNJWGY
.
You are receiving this because you were mentioned.Message ID:
@.***
com>


📚 Bantorra API updates

The error label InvalidRoutingTable was merged into InvalidRouter.

(I didn't look at the change to bantorra but I trust your judgment!)


Settings.json is not showing default settings after update

VSCode Version:Version: 1.35.1 (user setup)
OS Version: Windows_NT ia32 6.1.7601

After update Settings.json is showing my settings not the default settings where in previous version in vscode the defualt settings were shown in the side.

See https://github.com/microsoft/vscode/issues/68386#issuecomment-462247156


How to install to prefix withouth encoding prefix into the binary

I want to package ly version 1.0.0 but currently struggle to do so for various reasons (also see #628):

How can I install the binary without modifying/rebuilding it? (old "make install" that just copies everything in place)
How can I set a install prefix that does not get compiled into the binary?
Right now it seems like setting -Ddest_directory="$pkgdir" also includes it into the binary:$ strings ly-dm | grep /build
/build/ly/pkg/ly/etc/ly/xsetup.sh
/build/ly/pkg/ly/etc/ly/wsetup.sh
/build/ly/pkg/ly/etc/ly/config.ini
/build/ly/pkg/ly/etc/ly

This is an issue because it makes ly crash the session on login when the build package is installed onto a real system:Jul 02 19:10:26 meterpeter ly-dm[7603]: (==) Log file: "/home/chris/.local/share/xorg/Xorg.0.log", Time: Tue Jul  2 19:10:26 2024
Jul 02 19:10:26 meterpeter ly-dm[7603]: (==) Using config directory: "/etc/X11/xorg.conf.d"
Jul 02 19:10:26 meterpeter ly-dm[7603]: (==) Using system config directory "/usr/share/X11/xorg.conf.d"
Jul 02 19:10:26 meterpeter ly-dm[7617]: zsh:1: no such file or directory: /build/ly/pkg/ly/etc/ly/xsetup.sh
Jul 02 19:10:27 meterpeter ly-dm[7603]: (II) Server terminated successfully (0). Closing log file.

It would be nice if the value supplied by -Dname=... also did get templated into the systemd unit

For previous versions the install went something like this:
build() {
    make -C "$pkgname"
}

package() {
    cd "$pkgname"

    make DESTDIR="$pkgdir" NAME=ly-dm install installsystemd
    sed -i "s;/usr/bin/ly;/usr/bin/ly-dm;g" "$pkgdir/usr/lib/systemd/system/ly.service"
}

This is where I'm currently at:
build() {
    cd "$pkgname"
    zig build
}

package() {
    cd "$pkgname"

    zig build -Ddest_directory="$pkgdir" -Dname="ly-dm" installsystemd
    # https://github.com/fairyglade/ly/issues/628
    chmod 644 "$pkgdir/etc/pam.d/ly" "$pkgdir/usr/lib/systemd/system/ly.service"
    sed -i "s;/usr/bin/ly;/usr/bin/ly-dm;g" "$pkgdir/usr/lib/systemd/system/ly.service"
}

I can of course move the files into place by hand, but it would IMO be much better (also for packagers in other distros) to properly support this directly in ly.

Hey there! 👋🏻 Looks like you're running into some unexpected issues, to say the least. 😅

I'm not aware of any way to only run the custom build steps without actually running the build step. That's because the build.zig file is part of the build process, making everything tightly integrated. However, how is that a problem in your case? You could build with the same options as you currently have in build(), and in package() you could simply append installsystemd, and the Zig build system should be smart and not rebuild (since it should be able to tell everything's the same).

That is... unexpected. I checked and what the C version does is just hardcode the /etc/ly path into the binary instead. While I admit I don't like that behavior, we (I and another contributor who worked on this feature) didn't think of this potential (yet common) use case.

I think I'll just add a separate build option which would get embedded into the binary instead. How does that sound? Another way I see how this could be fixed is to chroot into a specific file system, but that's either overkill or not very possible from within Arch's build environment.

That's slightly more complicated, given that it's a separate file and would likely require the build system to open the file, replace a special string with the executable name, and write the changes.

[...] You could build with the same options as you currently have in build(), and in package() you could simply append installsystemd

Yeah this works once we solve the problem from 2). I thought this way I could first build the binary and then just move the already built binary 😅

[...] I think I'll just add a separate build option which would get embedded into the binary instead. How does that sound?

A separate build option sounds good! Makefiles use DESTDIR for this (https://www.gnu.org/prep/standards/html_node/DESTDIR.html), maybe we can make the current option into that and add a separate install_prefix or similar variable for the binary location? 🤔
I don't care much for the specifcs/naming but I thought I might aswell give some input 😆

That's slightly more complicated, given that it's a separate file and would likely require the build system to open the file, replace a special string with the executable name, and write the changes. But it's definitely doable.

Yeah no problem, this is also not changed since the old version so IMO it can stay as is for now 😄
Thanks for the fast response and the helpful comments! 🤗

Seems to work well, I have published the package to the testing repostories 🤗
https://gitlab.archlinux.org/archlinux/packaging/packages/ly/-/commit/32816171d54912886bc2328b0fe238bc598af823
Thanks for the speedy fix!


Inside built-in terminal - tabbing through folders makes text jump

VSCode Version: 1.7.2
OS Version: Windows 10 / 1607 / 14393.447

Steps to Reproduce:

Open up built-in terminal
Type cd<space<
Hit  a couple of times - and try +
Observe how text jumps around in the window

See below

Note Don't mind the white cursor block - that wasn't really there, that turned up after rendering the GIF

Merging into https://github.com/Microsoft/vscode/issues/14613

This should hopefully be fixed in tomorrow's Insiders build (via https://github.com/Microsoft/vscode/commit/63f1fa66800bf641de5e36027610503ba75085b5). Please let me know if it still reproduces.
See https://github.com/Microsoft/vscode/issues/13625 for more information.


Feat/exclude dep updates

Codecov Report

Merging #39 (e3aa759) into main (c5f8c83) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           28        28
  Lines          596       606   +10
=========================================
+ Hits           596       606   +10

Impacted Files
Coverage Δ

src/plugins/updates/cmd.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f8c83...e3aa759. Read the comment docs.


[KYUUBI #5873] Support to get operation progress with RESTful API

:mag: Description
Issue References 🔗

Since #2493, with jdbc conneciton, user can get TProgressUpdateResp to check the operation progress percentage, but for RESTful api, it is not supported yet.
As title, this PR supports to get operation progress with RESTful api.
This pull request fixes #5873
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklists
📝 Author Self Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

[ ] Pull request title is okay.
[ ] No license issues.
[ ] Milestone correctly set?
[ ] Test coverage is ok
[ ] Assignees are selected.
[ ] Minimum number of approvals
[ ] No changes are requested

Be nice. Be informative.

Codecov Report
Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (487dd08) 61.40% compared to head (0dbd450) 61.38%.
Report is 5 commits behind head on master.

Files
Patch %
Lines

...he/kyuubi/client/api/v1/dto/OperationProgress.java
56.25%
17 Missing and 4 partials :warning:

...kyuubi/client/api/v1/dto/KyuubiOperationEvent.java
28.57%
5 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5875      +/-   ##
============================================
- Coverage     61.40%   61.38%   -0.02%
  Complexity       23       23
============================================
  Files           612      613       +1
  Lines         36239    36310      +71
  Branches       4967     4974       +7
============================================
+ Hits          22251    22288      +37
- Misses        11593    11619      +26
- Partials       2395     2403       +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LGTM for this pr.
But I still have some confusion.

The API for obtaining session and operation details are inconsistent: @Path("{sessionHandle}") and @Path("{operationHandle}/event")
The naming of dto.KyuubiOperationEvent and dto.KyuubiSessionEvent is confusing, they represent the details of the current session and operation, maybe named KyuubiXXXDto is more appropriate.

Thanks, let us followup it in another pr.


Forbid ambiguous chip names

As suggested by dirbaio: Forbid ambiguous chip names.
(But ignore partial matches if exactly one exact match exists.)

I'm not really excited about all those if-statements, but I didn't see a better way to implement the suggested behavior.

bors r+


Alternative import attribute name to express lack of guarantee

As there is no guarantee that the imported module is evaluated lazily, e.g. it has already been evaluated, or it contains top level await. Perhaps a name that more clearly expresses this is a hint rather than an assertion would work better?
Bikeshed:
import {x} from "y" with { preferLazy: true };

import {x} from "y" with { lazyHint: true };

I like preferLazy! That communicates it pretty well. Feel free to add this to the bikeshedding doc (closer to the top, the bottoms ones are a bit more unsure...). I can also add it on monday.

I like preferLazy! That communicates it pretty well. Feel free to add this to the bikeshedding doc (closer to the top, the bottoms ones are a bit more unsure...). I can also add it on monday.

It should be less length in words for example just "lazy"

It should be less length in words for example just "lazy"

It should be less length in words for example just "lazy"

We can also consider it, but I already ran into issues with people confusing this proposal with lazy loading -- a process which must be async. This is why the proposal name change from "lazy modules" to "defer module evaluation". I suspect that lazy on it's own will be too overloaded a term to be precise here.

It should be less length in words for example just "lazy"

We can also consider it, but I already ran into issues with people confusing this proposal with lazy loading -- a process which must be async. This is why the proposal name change from "lazy modules" to "defer module evaluation". I suspect that lazy on it's own will be too overloaded a term to be precise here.

(also, the above applies to "preferLazy", but I think we should consider everything) -- feel free to make a pr with that one too.

(also, the above applies to "preferLazy", but I think we should consider everything) -- feel free to make a pr with that one too.

So what about defer import { } from 'str'?

Reopening so we can keep bikeshedding. If you folks don't open prs then I will add them on monday.

Reopening so we can keep bikeshedding. If you folks don't open prs then I will add them on monday.

I'm a strong 👍 on some name that communicates that there's no guarantee here. As I mentioned in #27, I don't think it's surprising that a deferred import can't prevent the evaluation of a module if it needed to be evaluated non-lazily elsewhere in the module graph, but I do think handling of top-level await is potentially confusing.
In #27, I proposed partialDefer or deferSync

I thought that import attributes would be a natural fit for this feature. I think it would be good to at least address in the proposal why there is new syntax instead of using import attributes.


Consistent benchmark file names

Config/Builder
The files used to get benchmark configs (rosparam) and/or to build queries should use this convention <benchmark_name>_builder.h/cpp.
Profiler
The files that are derived by the Profiler class, should use this convention <benchmark_name>_profiler.h/cpp. This is where the actual method/function is profiled or measured (time, memory, ...).
Benchmark
The files that do the benchmark (usually a node) should use this convention  <benchmark_name>_benchmark.cpp.
TODO

[ ] Document the file structure
[x] Benchmark suite
[X] Benchmark suite MTC (#21)

Real representation:
benchmarks
├── builder
│   ├── collision_check_builder.cpp
│   └── motion_planning_builder.cpp
├── profiler
│   ├── collision_check_profiler.cpp
│   └── motion_planning_profiler.cpp
├── collision_check_benchmark.cpp
├── motion_planning_mgi_benchmark.cpp
├── motion_planning_pp_benchmark.cpp


[BUG]Get-PnPUserOneDriveQuota (possibly Education tenant related?)

Reporting an Issue or Missing Feature
Reporting an Issue with the "https://pnp.github.io/powershell/cmdlets/Get-PnPUserOneDriveQuota.html" command. Other commands mostly work.
Expected behavior
A user's onedrive quota.
Actual behavior
On two different machines, using an app registration with permissions and cert, the command just hangs. The verbose output with the nightly build is:
VERBOSE: Already connect to the SharePoint Online Admin Center at 'https://ourtenant-admin.sharepoint.com/'
VERBOSE: Making call to SharePoint Online using the Client Side Object Model (CSOM)
VERBOSE: Evaluating application permissions in access token for audience SharePoint Online
VERBOSE: Access token contains the following 2 application permission scopes for resource SharePoint Online: User.ReadWrite.All, Sites.FullControl.All
VERBOSE: No required permissions have been defined on this cmdlet
(this just hangs as long as it is left)
Steps to reproduce behavior
(note this is an education tenant which may be a factor as another already closed bug report mentioned the same.)
Connect-PnPOnline -Url $SiteURL -ClientId $ClientID -Thumbprint $ThumbPrint -Tenant $Tenant
Connects fine and can run other get-commands, but the following just hangs:
get-pnpuseronedrivequota -account<EMAIL_ADDRESS>What is the version of the Cmdlet module you are running?
Both stable 2.12 and 2.99.37-nightly
Which operating system/environment are you running PnP PowerShell on?

[X] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

I think this is the same bug experienced and not solved by a few users (but solved as not able to be replicated):
https://github.com/pnp/powershell/issues/3539
The running theory is that for people experiencing the issue, they may be using an education tenant, which is somehow causing this command to fail.

Can confirm, still experiencing this issue as per comment on https://github.com/pnp/powershell/issues/3539 and are using an education tenant.

Same problem with connect-pnponline with clientid/thumbprint on education tenant
Get-PnPUserOneDriveQuota -Account "***" does not return


Add --ebc to Kiota quick start guides

Add tip to specify --exclude-backward-compatible in quick start guides for new Kiota clients.
Resolves #101.

@baywet I approved but didn't merge to give you a chance to review.


trigger push when networks change (#30070)

trigger push when networks change

add reason

lint

e2e unit test

revert fakexdsupdater changes

unused return

format

add release note

fixes https://github.com/istio/istio/issues/31453

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.8
abc8cc20befc802ec50263c67fd7ca22d7e7aa47
link
/test lint_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.8
abc8cc20befc802ec50263c67fd7ca22d7e7aa47
link
/test lint_istio_release-1.8

unit-tests_istio_release-1.8
abc8cc20befc802ec50263c67fd7ca22d7e7aa47
link
/test unit-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.8
abc8cc20befc802ec50263c67fd7ca22d7e7aa47
link
/test lint_istio_release-1.8

unit-tests_istio_release-1.8
abc8cc20befc802ec50263c67fd7ca22d7e7aa47
link
/test unit-tests_istio_release-1.8

integ-ipv6-k8s-tests_istio_release-1.8
abc8cc20befc802ec50263c67fd7ca22d7e7aa47
link
/test integ-ipv6-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.8
abc8cc20befc802ec50263c67fd7ca22d7e7aa47
link
/test unit-tests_istio_release-1.8

integ-ipv6-k8s-tests_istio_release-1.8
abc8cc20befc802ec50263c67fd7ca22d7e7aa47
link
/test integ-ipv6-k8s-tests_istio_release-1.8

lint_istio_release-1.8
c3dfffca9099ceef3c60d905764792d4991dfd58
link
/test lint_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio_release-1.8
abc8cc20befc802ec50263c67fd7ca22d7e7aa47
link
/test integ-ipv6-k8s-tests_istio_release-1.8

lint_istio_release-1.8
c3dfffca9099ceef3c60d905764792d4991dfd58
link
/test lint_istio_release-1.8

unit-tests_istio_release-1.8
c3dfffca9099ceef3c60d905764792d4991dfd58
link
/test unit-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio_release-1.8
00063d7e4f8bea86962c486f7fae3b6ccf0e839f
link
/test integ-telemetry-k8s-tests_istio_release-1.8

integ-security-k8s-tests_istio_release-1.8
00063d7e4f8bea86962c486f7fae3b6ccf0e839f
link
/test integ-security-k8s-tests_istio_release-1.8

integ-pilot-k8s-tests_istio_release-1.8
00063d7e4f8bea86962c486f7fae3b6ccf0e839f
link
/test integ-pilot-k8s-tests_istio_release-1.8

integ-telemetry-mc-k8s-tests_istio_release-1.8
00063d7e4f8bea86962c486f7fae3b6ccf0e839f
link
/test integ-telemetry-mc-k8s-tests_istio_release-1.8

integ-multicluster-k8s-tests_istio_release-1.8
00063d7e4f8bea86962c486f7fae3b6ccf0e839f
link
/test integ-multicluster-k8s-tests_istio_release-1.8

integ-ipv6-k8s-tests_istio_release-1.8
00063d7e4f8bea86962c486f7fae3b6ccf0e839f
link
/test integ-ipv6-k8s-tests_istio_release-1.8

integ-pilot-multicluster-tests_istio_release-1.8
00063d7e4f8bea86962c486f7fae3b6ccf0e839f
link
/test integ-pilot-multicluster-tests_istio_release-1.8

integ-security-multicluster-tests_istio_release-1.8
00063d7e4f8bea86962c486f7fae3b6ccf0e839f
link
/test integ-security-multicluster-tests_istio_release-1.8

unit-tests_istio_release-1.8
0e5d616029e05cd2a3ae18609e5b3de50d375c75
link
/test unit-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Try out spikeinterfaces pipeline for continuous wideband .ncs data

As for issue #4, but for wideband data.

[x] Test if we can get this to produce output at all. Yarik has a basic pipeline up and running for .ntt data here: https://github.com/vandermeerlab/data-formats/blob/master/yoh_try_spikeinterfaces.ipynb
[x] Use a recording site layout file
[ ] Compare to MClust sorted output. @jgmaz recorded a wideband file in parallel with .ntt files if I understand correctly, any chance you could prioritize spike sorting such a session?

I got the basic pipeline working for the wideband data using klusta-kwik sorter. See this notebook for more details.

As a next step, will try to set up a pipeline to run Kilosort on this wideband data.

Found a problem with the spikesorter implementation of KS2. Opened relevant issue here

First pass pipeline available [here!!] (https://github.com/vandermeerlab/data-formats/blob/master/ks2_30kHz_continuous.ipynb)

A missing feature in this whole pipeline is the absence of a way to programmatically exclude certain NCS files (For example: channels that are sampled for LFP purposes) from the spikesorting process. Spikeinterface will throw an error if any NCS file in the folder has a different sampling rate and certain other properties.
This can be fixed by making changes in this file of the neo code base, since spikeinterfaces leverages that for Neuralynx files:
https://github.com/NeuralEnsemble/python-neo/blob/master/examples/read_files_neo_rawio.py
I have opened an issue requesting a feature:
https://github.com/NeuralEnsemble/python-neo/issues/889
But until then I will fork the python-neo repo and make changes in that, so that people in the lab can use the pipeline more comfortably.

Update: This working example has been updated to elucidate File exclusion based on changes in a fork of the official python-neo repo.

Update: https://github.com/vandermeerlab/data-formats/issues/5#issuecomment-754996599

Update: https://github.com/vandermeerlab/data-formats/issues/5#issuecomment-754996599


add base64 decoder/encoder

Issue Id you have worked upon -
#434
Briefly explain your program logic -
added add base64 decoder/encoder using base-64 library
Screenshots -
https://github.com/SarthakKeshari/calc_for_everything/assets/54097365/40f48afd-8336-4fe1-86ec-8a76b45dd800

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.

[x] I have performed a self-review of my own code.

[x] I have commented my code.

[x] My code gives the correct output.

[x] I affirm that I strictly follow contributing guidelines and code of conduct.

@tejxv,
As per the code I don't see this library ("base-64": "^1.0.0") being used. Kindly revert package.json of the library added is not being used.

Hey, good catch! I was initially trying to use it but ended up doing it the vanilla way. It slipped from my mind while writing the PR lol, rest assured, I've reverted the package.json
Thanks!

Congratulations 🎉 @tejxv on your contribution.
Thanks for adding value to this repository. 😊
Let's celebrate this fest 😃 by providing more developers 👨💻👩💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.
Your efforts can make difference.

Hey 👋, may you also encourage us by clicking the star icon on the repository main page. ⭐


Add an option to hide a sidebar of PDF viewer

Hi, there. Thank you for the great software! I am surprised that this project covers numerous file types.
Especially, the function previewing PDF file is the fastest in other plugins. I request adding an option to hide a sidebar of the viewer because the sidebar takes a large space of the viewer. Is it possible to implement it? Please consider this option.
Best wishes,

You can click this button to hide sidebar.

Thank you. I mean, I'd like to hide the sidebar as the default option when I open a new file because the PDF viewer expands the sidebar as default.
The related issue of other similar project is here https://github.com/tomoki1207/vscode-pdfviewer/issues/79.

Hi,
any updates about this one?

Any updates about this one?


About the homebridge service termination caused by the highest temperature of the air conditioner

If the maximum temperature exceeds 30 degrees, homebridge will report the termination of the service, I tried to change the maximum temperature of 40 degrees, homebridge can continue to work, but adjust the temperature of the upper part of the fader will become idle, or set a fixed temperature value of pseudoDeviceTemperature, but the interface temperature display is locked. I wonder if there is any more reasonable solution？
The following is a display of service termination.
——————————————————————————————————————————————
if (state.currentTemperature > maxTemperature) throw new Error(The current temperature (${state.currentTemperature}) must be less than the maxTemperature (${maxTemperature}));
^
Error: The current temperature (31.9) must be less than the maxTemperature (30)
at AirConAccessory.processQueuedCallbacks (/usr/local/lib/node_modules/homebridge-broadlink-rm/accessories/aircon.js:373:58)
at device.onTemperature (/usr/local/lib/node_modules/homebridge-broadlink-rm/accessories/aircon.js:350:12)
at emitOne (events.js:96:13)
at device.emit (events.js:191:7)
at device.on (/usr/local/lib/node_modules/homebridge-broadlink-rm/node_modules/broadlinkjs-rm/index.js:384:22)
at emitTwo (events.js:106:13)
at device.emit (events.js:194:7)
at Socket.cs.on (/usr/local/lib/node_modules/homebridge-broadlink-rm/node_modules/broadlinkjs-rm/index.js:207:18)
at emitTwo (events.js:106:13)
at Socket.emit (events.js:194:7)

I got the very same problem.

I just tried setting the maxTemperature to 40 and didn't see any issues. Can you expand on what the problem is with that solution please?

when you dont set the maxTemperature value, and the currenttemperature go above 30, the homebridge process will crash. and now I have to delete the whole AIRCON from config.json to make the other stuff work.
At 2017-05-22 06:09:56, "Luke Rhodes"<EMAIL_ADDRESS>wrote:
I just tried setting the maxTemperature to 40 and didn't see any issues. Can you expand on what the problem is with that solution please?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

That doesn't explain why setting a maxTemperature of 40 or 50 doesn't fix this.

Feel free to re-open if this is still an issue after setting a maxTemperature of 40 or 50


Do not expose backtrace as weak symbol

do not interpose backtrace function
we do not want for the application that calls backtrace call our unw_backtrace function

Fixes: #1499

Looks great to me!  Merging!  @abetones, here's one more to consider for the 1.3.4 change log.


Providing a feedback option

Description
The Feedback option aims to collect user insights, suggestions, and issues related to the project, enabling continuous improvement and fostering user engagement.
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

Congratulations, @mahek0620! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Well I don't think we need this at this moment :p @mahek0620