The whole button area is not clickable

The mj-button does not work as expected in MSO PC desktop because it has specific instructions that produce the problem.
To Reproduce
Steps to reproduce the behavior:

use the usual:
<mj-button href="www.google.com" border="1px solid red">Unmodified button</mj-button>

The HTML produced is this one:

             Unmodified button

Expected behavior
This HTML:

             Modified button

In MSO,  is an inline but UNMODIFIABLE element (it can't become a block, nor an inline-block), unless you trick MSO into think that the  is "something" cause it has a border, triggering the use of the display declaration and therefore, the use of the padding (so removing the tool that provides the inner spacing of the button using mso-padding-alt: 0px; is kind of weird (taking into account that adding padding to the  in MSO has no real effect).
The previous code make the whole button clickable in MSO.
Screenshots
Unmodified MJML button HTML:

Modified MJML button HTML:

Is this something MJML team can take? Or should I make a branch?

Damn that would be such a nice fix to have if it have 0 side effects ! Great finding !
How does it work with transparent buttons ? You put a 1px solid transparent on a tag ?
Can we try to have a compatibility (emailonacid/litmus) test with fixed width button, multi lines button, and button with img inside it ?
We need to be sure it won't break anything else in other desktop clients.

This issue has been solved here by Maizzle: https://maizzle.com/docs/examples/buttons

    Read more

We don’t want VML inside mj button because it would require to check if the button is wrapped in an element that can produce VML.But for the general use case it’s a great solution.On 13 Nov 2022, at 01:59, robertmylne @.***> wrote:
This issue has been solved here by Maizzle: https://maizzle.com/docs/examples/buttons

Read more

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

OK, I did some tests and changes to the mjml-button\src\index.js file and that solves the clickable area.

First, removed the mso-padding-alt from the TD.
removed the mso-padding-alt from the Ahref ("content") and added:
border: this.getAttribute('background-color') + ' 1px solid', before the border-radius declaration, in the "content" area.

The colour of the "border" should be coordinated with the colour of the TD's background.
Here the MJML with the test:

and here the resulting HTML:

Results in EOA and Litmus show the button working everywhere.
I have to check with my company if I can share the links.
Or contact me directly to share them (I'll try to do it from my side anyway).
I'll check if the Maizzle implementation is usable/implementable in MJML.

Looks good then if you can open a PR about this ? I think it should just handle the case where user wants another border color on this one 👍

Sorry to come back very late about this, but can we test multi line button with this technique ?


Add subflow + layout example

Hello,
I'm having a hard time implementing auto layouting in the context of subflows. From what I understand the demo app should be able to handle this, but I can't manage to make a working example.
This is my workflow structure (using parentNode as we are using reactflow@11):
{
  "nodes": [
    {
      "id": "A",
      "type": "base"
    },
    {
      "id": "B",
      "type": "base"
    },
    {
      "id": "C",
      "type": "base",
      "parentNode": "A",
      "extent": "parent"
    },
    {
      "id": "D",
      "type": "base",
      "parentNode": "A",
      "extent": "parent"
    },
    {
      "id": "E",
      "type": "base",
      "parentNode": "A",
      "extent": "parent"
    },
    {
      "id": "F",
      "type": "base"
    }
  ],
  "edges": [
    {
      "id": "A#B",
      "source": "A",
      "target": "B",
      "sourceHandle": "A#source",
      "targetHandle": "B#target"
    },
    {
      "id": "B#F",
      "source": "B",
      "target": "F",
      "sourceHandle": "B#source",
      "targetHandle": "F#target"
    },
    {
      "id": "C#D",
      "source": "C",
      "target": "D",
      "sourceHandle": "C#source",
      "targetHandle": "D#target"
    },
    {
      "id": "D#E",
      "source": "D",
      "target": "E",
      "sourceHandle": "D#source",
      "targetHandle": "E#target"
    }
  ]
}

This is what react flow renders. As you can see the 3 nodes that should be part of the subflow are not rendered inside the parent node:

I tried with all available layout algorithms and the results look similar. Not sure what I'm missing but I appreciate any help 🙏
Thanks a lot!
P.S. I think this might be very useful as from what I see there are a lot of people having a hard time implementing this.

Based on the node and edge data you provided, the layout in your screenshot looks as expected.

It seems there might be some confusion regarding the concepts of subflows and groups.
I suggest posting your issue on the React Flow GitHub repository, as the functionality you're aiming for is unrelated to this project.


Fix phantom border switching

fixes the removal of the divider between checkbox and icons when the row is selected

Can one of the admins verify this patch?

Can one of the admins verify this patch?

[test]

[test]


NameError: name 'HelpWindow' is not defined

Your personas:
0 paul
1 paul
Would you like to use an existing persona? [y/n]: y
Select a persona to use: 0

ERROR - Function ( create_text_windows ) has encountered an error.
name 'HelpWindow' is not defined
TRACE
Traceback (most recent call last):
File "/Users/paul/code/python/./black_lager_app.py", line 270, in create_text_windows
display_help_info()
File "/Users/paul/code/python/./black_lager_app.py", line 851, in display_help_info
HelpWindow.scroll_print("C - CLEAR Screen", 7)
NameError: name 'HelpWindow' is not defined

removed some globals and it broke :-(

not a problem with current version


Add support for execution of shell commands in commented code

Originally filed here  by @janosh
IPython allows expanding Python variables into magic shell commands and also assigning the command's stdout to a variable:
https://github.com/microsoft/vscode-jupyter/issues/3263 introduced "jupyter.magicCommandsAsComments": true which allows to do:
slurm_cmd = """
sbatch --partition icelake --account=SL3-CPU --time 1 --nodes 1 --wrap "python -c 'print(42)'"
"""
slurm_msg = ""
#! slurm_msg = {slurm_cmd}

print(f"{slurm_msg=} at {datetime.now():%Y-%m-%d %H-%M}")
>>> slurm_msg='' at 2022-04-24 20-04

The shell command runs as expected but the variable assignment is lost. Any chance magicCommandsAsComments could get a feature upgrade?

We might want to consider adding a new setting shellCommandsAsComments, i don't think ! echo "Hello World" is a considered a magic command. I.e. to my knowledge these are referred to as shell commands in jupyter.


ci: Make more robust timer_test

On overloaded VMs, the timer_test is ureliable and fails spuriously too often.
Two strategies in this patch, hope some combination does the trick:

Increase the absolute error allowed for the timing tests when doing CI runs.

Add just a bit more relative error (via a new unit test macro, OIIO_CHECK_EQUAL_THRESH_REL).

Hopefully this will cut down on CI failures for unit_timer test case.

In these examples, I'm using an absolute error PLUS relative, so I think it's going to be ok.

This takes a stab at improving our hit rate on this test in CI, and I don't see how it hurts anything. If it doesn't fully solve the problem and we have to revisit again, so be it.

I can at least verify that this patch allows the unit_timer test to pass for me locally on windows :)
Also, here's output from a quick .exe I threw together to verify the timer resolution from Sleep(0) through Sleep(100). Just a FYI to put into perspective of actual timings you might see:
win_sleep_resolution.txt


elastalert2 2.5.1 support

Done: https://github.com/Karql/elastalert2-server/releases/tag/5.0.0-next.7
Btw.
I have got an error when building elastalert2:
#11 46.97 error: requests 2.28.0 is installed but requests==2.27.1 is required by {'tencentcloud-sdk-python'}
I see that new version of requests has been released on 9 JUN: https://pypi.org/project/requests/#history
Also new version of tencentcloud-sdk-python has been released too:  https://pypi.org/project/tencentcloud-sdk-python/#history
Maybe you should change it in your setup.py: https://github.com/jertel/elastalert2/blob/master/setup.py#L57
As workaround I add temporary this replacement:
RUN sed -i 's/requests>=2.27.1/requests==2.27.1/' setup.py

https://github.com/jertel/elastalert2/discussions/884#discussioncomment-2938636

Ok I see that they have changed it: https://github.com/TencentCloud/tencentcloud-sdk-python/commit/daacf4373293fd78c03758f944c745346c3d5b82
But it is not release yet:

https://github.com/TencentCloud/tencentcloud-sdk-python/blob/3.0.653/setup.py
I will monitor it and I will remove work around when it will be released.

tencentcloud-sdk-python 3.0.656
https://pypi.org/project/tencentcloud-sdk-python/

Yes I have seen it. Need to some free time 😉


tns run android fails for project downloaded from playground

Please, provide the details below:
Did you search for the problem in other open issues in this repo?
Yes
Tell us about the problem
I create a project in the playground and it works on my android device when I scan the QR code.
But when I download the project and try to run it using tns run android on the same device connected via USB it fails on the gradel build
If i create a new project locally on commandline then it works fine.
Did you try it outside of {N} Playground?

It's not working outside playground.

Which platform(s) does your issue occur on?

Android

Are there any entries logged in the Device Logs tab?
NO
Please provide the following information shown in devices tab in the playground:

Model : One Plus
OS version: Lineage OS Oreo 8.1
Preview app version : 1.15.1
Runtime version

Please tell us how to recreate the issue with as much detail as possible.
https://play.nativescript.org/?template=play-vue&id=Lx7z0x&v=1
Console logs
C:\Users\pkumar.gradle\caches\transforms-1\files-1.1\appcompat-v7-27.0.2.aar\420b41ec6139617156
6a2670f6c18039\res\values-v26\values-v26.xml:9:5-12:13: AAPT: error: resource android:attr/color
Error not found.
C:\Users\pkumar.gradle\caches\transforms-1\files-1.1\appcompat-v7-27.0.2.aar\420b41ec6139617156
6a2670f6c18039\res\values-v26\values-v26.xml:13:5-16:13: AAPT: error: resource android:attr/colo
rError not found.
C:\Users\pkumar.gradle\caches\transforms-1\files-1.1\appcompat-v7-27.0.2.aar\420b41ec6139617156
6a2670f6c18039\res\values-v26\values-v26.xml:17:5-93: AAPT: error: style attribute 'android:attr
/keyboardNavigationCluster' not found.
C:\Users\pkumar.gradle\caches\transforms-1\files-1.1\appcompat-v7-27.0.2.aar\420b41ec6139617156
6a2670f6c18039\res\values\values.xml:252:5-69: AAPT: error: resource android:attr/fontStyle not
found.
C:\Users\pkumar.gradle\caches\transforms-1\files-1.1\appcompat-v7-27.0.2.aar\420b41ec6139617156
6a2670f6c18039\res\values\values.xml:252:5-69: AAPT: error: resource android:attr/font not found
.
C:\Users\pkumar.gradle\caches\transforms-1\files-1.1\appcompat-v7-27.0.2.aar\420b41ec6139617156
6a2670f6c18039\res\values\values.xml:252:5-69: AAPT: error: resource android:attr/fontWeight not
found.
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:processDebugResources'.

Failed to process resources, see aapt output above for details.

@pkum11, what steps did you use to run the project?
Here are some steps that worked fine for me using the official CLI and android runtime versions (4.2.0):

Download the project from playground
Extract the zip into a folder
Open the folder and run npm i inside
Run tns run android --bundle to build and start the project (notice the --bundle flag which is required for NS-Vue 2.0 projects)

Thanks ... seems like all the documentation I saw or read never had the --bundle in it.
Works with the dashing bundle :)


📗 Docs: Change examples in the shared and views READMEs

I'm not sure what the difference is between the shared and views directories  after reading the READMEs. The example given in each README mentions layout.js, while the texts mentioned that the use case is different from each.
Couple of ideas:

Have the same example for the README's but have one file in shared and one in views and highlight why the file is in that directory
Reduce the README contents and link to hosted docs that explain the difference

Hey again! Sorry for the confusion. Both recent ish features. /src/shared is copied into ALL your lambdas (under node_modules/@architect/shared). The /src/views folder is copied to ONLY http lambdas that do GET requests (under node_modules/@architect/views.
Main motive here is to keep the lambdas lean. View code gets heavy and (generally) you do the heavy lifting inPOST so including all that view logic is a bummer on your payload budget when all you're going to do is a 302 redirect anyhow.
Agree w your changes! Would also like to also add that we should only create /src/views if @http exists.

We've updated docs in Project Layout and removed the requirement to even have these folders. Its my feeling they cause more confusion than help and are better left discovered once code sharing is a problem rather than before.


Help with deployment on Laravel Forge w/ let's encrypt

Hello,
Could someone help with how to configure the app to work on laravel forge w/ let's encrypt? The app would host it's own websocket, so it's not a separate subdomain.

I have the same situation. I got it working on local with my self signed certs from valet, but can't get it working on my forge server.
I also tried to open port 6001 on the forge firewall setup, but:
"WebSocket connection to 'wss://xxx:6001/app/a8f4975fa8b8dd5da1ca?protocol=7&client=js&version=4.3.1&flash=false' failed: WebSocket opening handshake timed out"

Disclosure, I am a RunCloud owner. Since I saw this package, we have modified our nginx config to allow a user to add their own proxy setting. In this case, Let's Encrypt will work on port 443 which proxying port 6001. I think you can suggest forge to allow this kind of modification.

Hey @Eldair and @sudden-break
I'm still trying to get things working locally (windows + homestead). I got a similar error as you guys. So I tried to connect to my local homestead server on port 6001 using telnet. This didn't work. However, if I run the sockets server on my "external" ip address I am able to connect:
artisan websockets:serve --host=<IP_ADDRESS>

I am getting other errors now, but that's inside php code, so getting closer... Also, I don't know the implications of running it this way since I'm not a server specialist. So I'll have to read up on server stuff I guess :-)

I think that the easiest solution would be to replace forge's current let's encrypt system with certbot, which would let us have a permanent cert. path instead of the current (ever changing) one.

I think the easiest method is to add a new host to forge (socket.yourdomain.tld for example) which has it's own cert and add the nginx rules to it to proxy the traffic from your server running on port 6001 (plain, no https) and let nginx do all the https stuff: https://docs.beyondco.de/laravel-websockets/1.0/basic-usage/ssl.html#usage-with-a-reverse-proxy-like-nginx
Replae the location / in the Forge nginx config with (assuming you are running the websocket server on port 6001 which should be the default):
  location / {
    proxy_pass             http://<IP_ADDRESS>:6001;
    proxy_set_header Host  $host;
    proxy_read_timeout     60;
    proxy_connect_timeout  60;
    proxy_redirect         off;

    # Allow the use of websockets
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection 'upgrade';
    proxy_set_header Host $host;
    proxy_cache_bypass $http_upgrade;
  }

This way Forge can manage the certificate itself and you don't have to worry about it 👍 (and also don't have to open any special ports on the server).

Hello,
One question: how can I test I'have configured Reverse Proxy ok? For example with following config:
$ cat /etc/nginx/sites-enabled/00_socket.scool.cat
server {
  listen        443 ssl;
  listen        [::]:443 ssl;
  server_name   socket.scool.cat;

  # Start the SSL configurations
  # ssl                  on;
  ssl_certificate      /etc/nginx/ssl/scool.cat/412609/server.crt;
  ssl_certificate_key  /etc/nginx/ssl/scool.cat/412609/server.key;

  location / {
    proxy_pass             http://<IP_ADDRESS>:6001;
    proxy_set_header Host  $host;
    proxy_read_timeout     60;
    proxy_connect_timeout  60;
    proxy_redirect         off;

    # Allow the use of websockets
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection 'upgrade';
    proxy_set_header Host $host;
    proxy_cache_bypass $http_upgrade;
  }
}

If i visit:
https://socket.scool.cat/
thows my a 502 Bad Gateway error.

@stayallive thank you for your explanation.. but honestly my head is spinning trying to wrap my head around all this! I think your solution seems the best and cleanest.. but can you please see if I understand correctly
currently on my dev, using laravel valet with the --secure flag
I have 3 apps
#1 socket.tld.dev which handles the websocket, this has a .crt and .key in the websockets.php config in order to make it work
#2 restapi.tld.dev which is the api for my front-end, and can broadcast to the front-end, via the dedicated socket app
#3 vue-frontend.tld.dev which is my front-end, this uses host: socket.tld.dev and connects over ssl
all 3 sites were https through Valet and it works great
now I tried to move all of this to my forge server and I can't connect. I realized the websocket ssl config was still pointing to my dev's .crt/.key so that was surely problem #1, and problem #2 is that I probably need to open up port 6001 first
But then I came here and saw your solution and it seems great since I may not have to do either of those things above.. worry about certs and open up a port
I already set up my 3 subdomains and made them all https through letsencrypt
Now is it my understanding that you're suggesting I set up a 4th subdomain, http only, and use the nginx block you provided to proxy to my internal port 6001 ?
Does this 4th domain need to be https with let's encrypt?
And then inside my socket.tld websocket's config I can leave the ssl config blank ?
And then in my vue-frontend I would set the host to https of this 4th domain?
This way all my domains are still https, and I can access my debug dashboard on the socket.tld, but the websocket config itself is not "SSL" thanks to the proxy trick?

@vesper8 you're almost there. The socket.tld.dev app you have should be it's own subdomain (with https) with that nginx block I mentioned earlier.
You will also need to run the php artisan websockets:serve command in Supervisor using the Daemons tab on your Forge server dashboard.
This way the websockets server runs on <IP_ADDRESS>:6001 on your Forge box (do not configure SSL in your websockets.php file for the sockets server).
Then any app on your server (a server side app) can talk to your websockets server on http://<IP_ADDRESS>:6001 (no https) or socket.tld.dev:443 (with ssl). The internal non-http path will be slightly faster since it doesn not go via the internet but only local network.
Your front-end clients should connect to socket.tld.dev:443 (with http).
That should be it 👍
A reverse proxy... proxies traffic, you might already guessed that but a default https host listens on port 443 and what that proxy_pass http://<IP_ADDRESS>:6001; does in the nginx config is pass any traffic on to http://<IP_ADDRESS>:6001 which is your local php artisan websockets:serve. So nginx handles the SSL/TLS stuff and passes un-encrypted content through to your websockets server which handles the connections. This way port 6001 does not need to be exposed and your websockets server does not have to handle the SSL/TLS handshakes itself.
Hope this makes more sense now for everyone 👍

@acacha if your are getting a 502 the proxy_pass failed. Make sure you have the php artisan websockets:serve running and it's running on <IP_ADDRESS> and port 6001. The config looks fine at a glance.

Again, you should not add the certificate in websockets.php 👍
Let nginx handle the SSL, run the websockets server as a plain one.

Oh thanks I'm sure I've tried this combination but not at least no more 502 gateway errors. Thanks! Let met try it in deep and If it works i will try to put here my full config for anybody like me with similar problems.

Working on it but now I have a 504 timeout error instead of 502 Bad gateway:
curl https://socket.scool.cat/

<title>504 Gateway Time-out</title>

504 Gateway Time-out

nginx/1.15.6

Also not working with Laravel Echo:
Laravel Echo config:
window.Echo = new Echo({
  broadcaster: 'pusher',
  key: '6f627646afb1261d5b50',
  wsHost: 'socket.scool.cat',
  disablestats: true,
  encrypted: true
})

Chromer Console error:
app.js:38721 WebSocket connection to 'wss://socket.scool.cat/app/6f627646afb1261d5b50?protocol=7&client=js&version=4.3.1&flash=false' failed: WebSocket is closed before the connection is established.

More info:https://github.com/beyondcode/laravel-websockets-docs/pull/1

Sorry 504 Gateway error resolved:
Changed in /etc/nginx/sites-available/00_socket.scool.cat:
  location / {
    proxy_pass             https://<IP_ADDRESS>:6001;
....

to http://<IP_ADDRESS>:6001; (without s)

@stayallive thank you very much for your help! I have it all working perfectly now using your solution!
I did end up creating a 4th subdomain for the proxy pass, because the socket.tld domain still needs to be accessible for the sole purpose of accessing the debug dashboard

@vesper8 ah yeah, ofcourse! Happy you got it working 🤘

Your comments helped me a lot @stayallive
Thank you.

Would love to know how to set this up locally using Laravel Homestead before trying to figure it out on forge! Reading up on nginx config now, will post the solution as soon as I can figure it out - unless anyone else already knows it, that would be great ?

@jafar-albadarneh how about: https://alex.bouma.me/installing-laravel-websockets-on-forge/

Thank you you helped me a lot


Reference correct version of remote files.

References incorrectly pointing to master.

This change is

LGTM. I think it's fine to merge this change for 21.2 and leave 21.1 alone for now.


CF_INSTANCE_INDEX env var should be available when deploying with Eirini

This is a needed feature + it breaks some CATs (e.g. https://github.com/cloudfoundry/cf-acceptance-tests/blob/46f2bb669c30fa03a46201980454f6b8beaca789/ssh/ssh.go#L67).
This has already been fixed in upstream Eirini (https://github.com/cloudfoundry-incubator/eirini/blob/master/cmd/instance-index-env-injector/main.go) but it's not yet part of any eirini-release release so we don't consume it yet in kubecf. If we need it before Eirini is released with that, we can just use the code in the Eirini repo to build it and consume it in kubecf like we do with the rest of the eirinix plugins.

@jimmykarily Eirni 1.9.0 is out with CF_INSTANCE_INDEX support and a bump card created in our board #1380

We needed that so we used the code from Eirini master (before the release) to build it. It can be added like this: https://github.com/cloudfoundry-incubator/kubecf/commit/2e75a190a4bdf515a4d17bfe60ea11a5d26f6ad2

@jimmykarily is there a release of Eirini we can use that has this available yet?

@viovanov 1.9.0 seems to have it: https://github.com/cloudfoundry-incubator/eirini-release/releases/tag/v1.9.0
(https://github.com/cloudfoundry-incubator/eirini-release/blob/master/helm/eirini/templates/instance-index-env-injector.yml). Given we no longer consume eirini-release directly but have our own copies of yaml in mixins, maybe this is a no-op. I mean, we just ported that component before we bumped the rest of them. If I'm not mistaken, we simply have to build the index injector image based on 1.9.0 code instead of master: https://github.com/SUSE/scf-eirini-ci/blob/master/pipeline.yaml.gomplate#L337 and make sure we consume the new image.


Credit Transfer | Revise rescind credit transfer messaging in modal window |1|

Context:

Credit transfer view page, BCeID users, Rescind button, modal window messaging

Current Messaging:

"Are you sure you want to rescind this transfer?"

Revised Messaging:

"Are you sure you want to rescind this transfer? This will cancel the Credit Transfer Proposal."

https://trello.com/c/lJwJoL7T/2073-credit-transfer-revise-rescind-credit-transfer-messaging-in-modal-window-0

 Credit Transfer | Revise rescind credit transfer messaging in modal window |1|


[Discussion] Basic plan and implementation

Things to go over

[x] What language
[x] How to store nodes
[ ] How to traverse nodes
[ ] How to display all possible end points

I think python is a good choice, at very least for prototyping.
Think we discussed an array of node objects which each contain all nodes they connect to.
Obviously we need some sort of loop, but not sure right now of how.
If we went with python we will need to find a good lib to deal with this, other languages may be easier with this.

Here is the image of the board.

Think ive got a good base grasp,
Python as the language, at least as a prototype.
Storing the nodes as a list of node objects, each node having a index and three lists that relate to Taxi, Bus and Underground.
Ive got @JayB7800 starting on node relationships since they were able to lend a hand.
Im going to start thinking about the pathing algorithm as it will have to respect the rules of the game. (which I haven't played the "standard" version of)


Documentation for properties of classes

The docs contain all methods available, but not the properties.
For example, the docs say to retrieve a specific submission with the command:
r.getSubmission('2np694')

However, there is no documentation about how to retrieve the title, score or upvote ratio of the submission.

Thanks for the report. However, this is intentional -- the properties are pulled directly from reddit, and snoowrap has no control over them. The list of properties could change or expand arbitrarily if something changes on reddit's backend, so any documentation on them would frequently become inaccurate.

Is there any documentation by reddit, then? I can't seem to find anything.

Not that I'm aware of. My recommendation would be to either console.log the object that you're examining to access its properties, or visit the corresponding URL in your browser (with .json at the end to view the JSON version).

Can this be reopened? The Typescript type definitions include the properties, why not use those to feed the documentation?

Can this be reopened? The Typescript type definitions include the properties, why not use those to feed the documentation?

Can this be reopened? The Typescript type definitions include the properties, why not use those to feed the documentation?

No, your issue is for something else so please open a new issue for it. TypeScript definitions do not have the same verbosity for documentation as our JSDoc currently have

Can this be reopened? The Typescript type definitions include the properties, why not use those to feed the documentation?

No, your issue is for something else so please open a new issue for it. TypeScript definitions do not have the same verbosity for documentation as our JSDoc currently have


Write readme and explain what each code does

Add comments as well to the code to make it more descriptive.
Update readme with challenges being uploaded

Partly resolved issue: https://github.com/akebu6/Kotlin-Code/commit/aa9790ad77a6c8285671c2e6933da2ec5eec7eae


Minor typo in Create virtual machine scale sets

Set-AzureRmVmssStorageProfile $vmssConfig     -ImageReferencePublisher MicrosoftWindowsServer
-ImageReferenceOffer WindowsServer     -ImageReferenceSku 2016-Datacenter
-ImageReferenceVersion latest
-OsDiskCreateOption FromImage
Should be:
Set-AzureRmVmssStorageProfile $vmssConfig     -ImageReferencePublisher MicrosoftWindowsServer
-ImageReferenceOffer WindowsServer     -ImageReferenceSku 2016-Datacenter
-ImageReferenceVersion latest `
-OsDiskCreateOption FromImage

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: caeded30-d872-2900-f916-fb21108237c6
Version Independent ID: 07d0ee8a-229f-84fa-2119-1b2e601cd497
Content: Create an application gateway with URL path-based redirection - Azure PowerShell
Content Source: articles/application-gateway/tutorial-url-redirect-powershell.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

@stprokho Thanks for the feedback! We are currently investigating and will update you shortly.

@stprokho Thanks for the feedback. I have fixed the script, and the changes should appear within 24 hours.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Returning an objects from the @ex.main without storing it in mongodb

We'd like to return the trained model from the @ex.main wrapped function and use it for other eval purposes later on.
@ex.main
def train_and_eval(_config):
    model = train_model()
    return model
run = ex.run()
model = run.result

This method isn't ideal because the whole object gets stored in the mongodb and is wasteful. We don't want to store it/log it, we just want to return it. Is there a supported way of doing this? If not, how do you recommend we modify the library to add support for this?

only log what you need.

I don't think the above is working as expected, you'd have to return mymodel.
@ex.main
def bypass(_config):
mymodel = train_and_eval(_config)
return mymodel
I'm not seeing how the bypass function solves this problem.

You can try the above example, it works(If it doesn't, please post the error log and the code snippet you used, I'll try my best to resolve it). The caveat is though that now all the results that you need to store will have to be stored as some matrix. So, you won't see then as a column in Omniboard but rather as a plot matrix on clicking the experiment.
Having said that, the issue that you have raised is very valid that being bounded to return from the main method is kind of restrictive( read irritating).
@Qwlouse What do you think about this? Could something be done to make the usage more modular or like something is already planned and being worked upon.

@skat00sh Your bypass code does not work, because the model is not accessible through run.result (and if it were it would be stored in the DB). The approach is ok though, and it can be made to work. But maybe a simpler solution would be to just store the model in a custom property of the run:
@ex.main
def train_and_eval(_run):
    _run.model, loss = train_model()
    return loss

run = ex.run()
model = run.model

Wouldn't it work to make it a global value?
model = None

@ex.main
def train_and_eval(_config):
    model = train_model()

run = ex.run()


php artisan queue:work mongodb not working

hi,
I use this lib for the job queue.
Right now, it could add the jobs to the queue successfully.
But, when i executed php artisan queue:work mongodb, i got nothing.
Could you tell me what things might be wrong?
Thank you very much.

BTW, I use version 3.3

hi @wiselyku, did you solve your problem?
I have the same issue.
I use mongodb for queues. I could add the jobs to the queue successfully, but php artisan queue:work mongodb not working

hi, @ypavlov  i did not solve the problem, so i used mysql instead

same here. my project doesn't use any other database but only mongodb. all the dispatched job was added to queue successfully.
when i run php artisan queue:work,it print nothing,and shutdown after a while.
and something like this appears in the log:
Symfony\Component\Debug\Exception\FatalThrowableError: Call to a member function beginTransaction() on null in /var/www/html/vendor/illuminate/database/Concerns/ManagesTransactions.php:109

https://jira.mongodb.org/browse/PHPORM-87

Fixed by https://github.com/mongodb/laravel-mongodb/pull/2838


FtpListOption.ForceList is not being honored

When connected to a FEAT MLST / MLSD server, the parser is set to "machine".
If you now specify FtpListOptions.ForceList, one would expect this to take precedence over the "machine" setting of the parser.
You absolutely need this if you are interested in seeing entries that are links - these are not supported by the MLSD "machine" parser, for understandable reasons (see this to realise that MLST might be very nice and fast, easier to parse, but sadly it currently does not support link entries in a standardized way.

Excellent find, thnk


securing

how can we secure the flask web access on public ip ?

I'm closing this. The wapp was never really designed to be exposed to the public.

thats perfectly fair :-)


Issues with Kanban plugin

Hello,
The sync didn't work when using this plugin with a Kanban board. I had to resolve conflicts manually after switching to Markdown view. Since everything is Markdown-based, I believe this should be an easy fix.
Thank you!

I'm having issues with syncing mgmeyers/obsidian-kanban as well, but unfortunately I wasn't able to fix it on iOS :(


[Backport-2.x] Bump com.azure:azure-storage-blob from 12.22.2 to 12.22.3 in /plugins/repository-azure

Description
Backport of https://github.com/opensearch-project/OpenSearch/pull/8572/
Related Issues
Resolves #[Issue number to be closed when this PR is merged]

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

https://github.com/opensearch-project/OpenSearch/pull/8591 needs to be in

Tests with failures:
 - org.opensearch.index.codec.CodecTests.testCodecServiceWithNullMapperService


[BUG] Not able to use driver when we have windows based authentication.

Driver version

SQL Server version

Client Operating System

JAVA/JVM version

Table schema

Problem description

Expected behaviour:
Actual behaviour:
Error message/stack trace:
Any other details that can be helpful:

JDBC trace logs

Reproduction code

Hi @parmodmalik, could you provide more details for this issue?


Buckling doesn't properly detach when outside of PVS?

Basically, if you buckle yourself to a chair, teleport far away, and then teleport back to the general area where the chair is without having moved, the client shows you as being back on the chair? But this doesn't seem to happen when you only teleport short distances?
I'm not sure what the cause is. The title is somewhat of a guess, but the issue can be reliably reproduced. This seems to have nothing to do with recent PVS changes, as this can also be reproduced before those were merged.
Example video:
https://user-images.githubusercontent.com/60421075/185775955-14c1fe24-26a1-48b9-b0c8-c36d1c53d628.mp4

Do you even get re-parented on tp?

Do you even get re-parented on tp?

Both client & server transform parent changes, the buckle alert disappears & the unbuckle sound plays.


POC task to implement CHES

Describe the task
A POC task to understand CHES implementation, check the feasibility of using it in a Camunda task

adding some reference links

https://api.gov.bc.ca/devportal/api-directory/3182?preview=false
https://bcgov.github.io/common-service-showcase/services/ches.html
https://ches.api.gov.bc.ca/api/v1/docs#tag/Email/operation/postEmail


Raise an error for document with supplement when edition year or stage is not provided

closes #122

Thank you @mico !


Update queue.go

Remove PILOT_THROTTLE env

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @hzxuzhonghu. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @nmittler

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @greghanson

/assign @gyliu513

/ok-to-test

Why ?

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d9197b0b4b8e76634bfacf3353a03ac30303a14b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d9197b0b4b8e76634bfacf3353a03ac30303a14b
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d9197b0b4b8e76634bfacf3353a03ac30303a14b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [rshriram]
pilot/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold

I think he removed it because you added a TODO to remove the variable after 0.7. If its trully unnecessary, we should get rid of it. I don't know how this behaves in concert with the rest of the knobs all over pilot.

+1 on killing all the environment variables. Our logging framework supports setting verbosity per component, other stuff like this should be driven by flags. Env vars are evil.

New changes are detected. LGTM label has been removed.

rebased

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [rshriram]
pilot/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

might be useful to send same Pr to releaes-1.0 branch


log_parser nodes stop processing messages after cluster is in "yellow" state

We had an extended outage where the elasticsearch nodes were in the "yellow" state for a few hours.
After the elasticsearch nodes had returned to green, the log_parser failed to start processing messages again (even though the monit log_parser & elasticsearch processes were reported as being running, and there were no error messages (or anything else) in the log_parser logs (/var/vcap/sys/log/log_parser/log_parser.*.log).
A monit restart log_parser restored processing.

Haven't seen this happen in a long time now, so closing. Going to assume something between the major elasticsearch upgrades and changes in how we're pushing data through has fixed it. We can reopen later if that's not the case.


training/update-dataset: lower consistency level of update transaction

According to the MySQL documentation:
https://dev.mysql.com/doc/refman/8.0/en/innodb-locking.html#innodb-next-key-locks
at REPEATABLE READ level, UPDATE and DELETE statements use gap & next key locking,
and may lock rows or index records that are not matched by the query
(to avoid phantoms).
This is likely the cause of deadlocks we're seeing when the update-dataset
task is run concurrently to a Thingpedia edit operation or a mturk
task, both of which try to insert into the example_utterances database
(Thingpedia also tries to delete & edit).
At READ COMMITTED level, on the other hand, only the rows matched
by the query are locked. In principle, this should be sufficient
to solve the problem, as the update-dataset task only deletes synthetic
data. (It also updates paraphrase data to mark obsolete sentences, but
it's fine if it misses some paraphrase sentences that are inserted concurrently,
because those won't be immediately obsolete).
I say in principle, because we've been played with locking for a while
now, and this has been a long-standing concurrency problem. But this
is a quick fix.

I will definitely appreciate expert review of the analysis in this PR.

Pull Request Test Coverage Report for Build 1911

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 66.858%

Files with Coverage Reduction
New Missed Lines
%

routes/my_conversation.js
1
67.26%

Totals

Change from base Build 1908:
-0.03%

Covered Lines:
6932

Relevant Lines:
9740

💛  - Coveralls


Not working in Android Studio 3.4

while using
implementation 'es.voghdev.pdfviewpager:library:1.0.5'
This is not working with new Android Studio 3.4
As per your documents in GitHub. It is using compile 'es.voghdev.pdfviewpager:library:1.0.5'
but  compile is deprecated now in new Android studio 3.4

Fixed in v1.0.6
You can now import
implementation 'es.voghdev.pdfviewpager:library:1.0.6'


Issues after migrating to aws provider 4.0.0

Hello,
We have used the updated module after the changes to use aws-provider version 4.x.
The module worked in some cases, but then we encountered an issue later. Not sure if the assumerole for the provider in the problematic case was causing some of the problems (at least the second one..?).
https://github.com/hashicorp/terraform-provider-aws/issues/13393#issuecomment-1126809777 - I had to use this workaround to get it working which finally allowed it to create buckets without errors like this "Error: "origin.0.domain_name": required field is not set". So, https://github.com/riboseinc/terraform-aws-s3-cloudfront-website/blob/master/cloudfront.tf#L11 we changed like the below:
- domain_name = aws_s3_bucket.main.website_endpoint
+ domain_name = aws_s3_bucket_website_configuration.main.website_endpoint

Also, in s3.tf, all 4 resources needed the below line to get it working without errors.
+ provider = aws.main
Hope this helps you guys make improvements if you find them as needed changes/fixes.

Thank you very much @girishadat !
@phuonghuynh could you please help update the module to support aws provider 4.0.0 and also provide details on how to migrate in the README? Thanks!

Yes, checking it

I will update Read Me for the migration steps; provider 4x supported already in https://github.com/riboseinc/terraform-aws-s3-cloudfront-website/releases/tag/v3.0.0

Thanks @phuonghuynh , once README is updated please close this issue. Thanks!

Readme updated, https://github.com/riboseinc/terraform-aws-s3-cloudfront-website/commit/bd719deab079a33075a082b1bbb0079c0b3941c8


Make it easier to understand valid liquidity price range

For an order to count towards a liquidity providers commitment it needs to within a reasonable range of the current mid price.
The Chore
There are two useful fields (to help an LP place valid orders) in the market info tab that have a misleading label 🟢  and incorrect Unit 🔴 .
It is also worth double checking they are using the correct decimal places 🟦 .
I would also expect these values to change as the mid prices change.

The intention of this field is to tell the user what the Liquidity price range (50%) means in terms of a price on the market.
LP need to place their orders within 50% (in this case) of the mid price. the filed say the lowest and highest prices these need to be within.
Tasks
The data type of this information is Quote. So...

[ ] Change the labels from LP Volume Min and LP Volume Max to something else that better describes (e.g. "Lowest price" or "highest price" see sketches below)
[ ] Change the unit to use market.quoteName rather than "settlement asset"
[ ] Check that the number of decimal places is coming from the right place. i.e. Quote. This number should not be truncated and displayed to the full precision as the quote
[ ] Ensure the min/max fields update as the mid price moves
[ ] Quotes should be right aligned where possible

Sketches
Options for label names

Lowest/Highest price
Lowest/Highest price within liquidity range
Lowest/Highest valid price
LP valid Price Min/Max
LP Price Min/Max

e.g.

Note: Some of these labels may be misleading if the Price monitoring bounds are in fact tighter...

[ ] Consider re-jigging further so price monitoring and liquidity bounds are displayed together...

In this example

Additional details / background info
https://vegaprotocol.slack.com/archives/CFXA4EGN7/p1676977474367579
Broader thinking about liquidity provision as part of https://github.com/vegaprotocol/frontend-monorepo/issues/1716

checked and they are using market decimal places and that should be correct

also, there might be multiple price monitoring triggers, it might not be just one to be brought together with LP price range


Ingest/Import Manifests from S3

We had a harbor instance running with S3 as the storage backend. The instance failed and we've re-created it, but the images are gone. We still have them on S3 and would like to import them into Harbor again. Harbor does not support this natively and we want to create a separate Docker reigstry were to import the images, and then sync with harbor. Is there anyway of importing/ingesting docker images/manifests from S3? Or to run up a docker registry using the existing S3 storage backend?
Thanks!

You should probably ask the Harbor team about this. I'm not sure what you mean by "the images are gone", but from this projects perspective, the images along with all the necessary metadata are stored in S3. Pointing at the same S3 storage shouldn't require any extra importing/ingesting. Making sure the S3 driver is configured the same is important.


recover soft delete

[x] Do only one thing

[x] Non breaking API changes

[x] Tested
What did this pull request do?
Can recover data that has been soft deleted

User Case Description
// recover soft delete

db.Where("name = ?", "nelson").Restore(&email)

sorry, but not going to accept this feature request, also refer https://github.com/go-gorm/soft_delete


Disable merge button for certain labels

What a cunning plan!
It would be nice to be able to disable the merge button while a PR has a certain label set.
E.g. https://github.com/astropy/astropy/pull/9282 needs to be tested in a downstream package, so ideally it should not be merged until the needs-downstream-testing label is present. I suspect this logic could be used for other labels, too.

by "disable merge button" I assume you mean set a failing check?

something stronger, to have the greyed out merge button, similarly when no one yet approved it.

Is that something you can do via the github API?

I'm not sure. Did I mention it was cunning plan? 😏

The way I know will work is that you setup a specific check for the label check, and then make it a required check using protected branches. I can't see anything in the API about blocking merge.

Oh, that would work quite nicely I suppose.

It would be neat to have this. Just landed here after skimage wanted the same, but I believe it would have to be implemented on a GH level.

I don't think we can grey out the merge button, but there could be a required workflow that fails when the label is present.
I think people with just write level permissions would not be able to override such a branch protection.

This is what we have on scikit-image, but it's not great when newcomers get a red cross on their PR, without the ability to turn it green themselves :/

Ah, the circle closes, I believe I was complaining about that failing labelling job myself 😂

FWIW I think this can be accomplished in Actions now, without baldrick. For example: https://www.neilmacy.co.uk/blog/github-action-to-block-merging + branch protection rules.

Yes, this is what we chatted about above that we can currently have a failing required workflow/job controlled by a label, but that red cross could be annoying and or confusing to contributors (and also reviewers, I certainly could get less attention from maintainers' on some of my PRs when there were CI failures, even if they were clearly unrelated)

If the red cross only shows up when a maintainer chooses to apply a label, then it would be green most of the time. Personally I will be okay with that.
There is also a totally unrelated request for GitHub to just make all PRs draft by default (merge button is automatically disabled) but after so many years, that request is still open.

Yeap, original use case for this issues, the downstream testing label, would indeed be rare, but skiimage's case is the opposite, it would not allow merging before adding certain labels.

Hmm... You could also require N number of approvals before merge. I think that disables the merge button until approvals given without any red X ?

Regardless, I feel like this has nothing to do with baldrick anymore. Is there an issue over at sklearn we can continue on?

Yes, agreed on closing this for baldrick. It was a cunning plan that didn't work out 🤣


[HOLD Web-Expensify#34842] Remove usages of onyxRates

Fixed Issues
Related to https://github.com/Expensify/Expensify/issues/226121
Tests/QA Steps
You'll need the changes from https://github.com/Expensify/Web-Expensify/pull/34842 to test

Open or create a workspace.
Navigate to "Reimburse expenses".
Update the custom unit rate. Click back, and reopen this page. Verify the changes are persisted correctly.
Refresh the page, and verify the changes are persisted correctly.

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Reviewing now 👀

The code looks good, but it's not testing well for an existing workspace. I'm not able to update the rate and there's a console error. Check out this video:
Screen.Recording.2022-09-15.at.9.13.52.AM.mov
I think the problem is that OpenWorkspaceReimburseView is still returning the rates as an array in Web here.

@neil-marcellini Ohhh that's bizarre, things were working last time I tested. I just pulled main on Web-Expensify and App and tested, and things appear to be working as expected. I think the OpenWorkspaceReimburseView changes were reverted recently, can you pull main on both those repos and try again?
https://user-images.githubusercontent.com/31285285/190458694-b70c703a-e108-4340-adef-4900e8b2f25a.mov

Adding the CP Staging label to unblock https://github.com/Expensify/App/issues/10978 sooner

Was merged before it could complete the checklist check, but complete checklist was posted here, removing Emergency label.

Did we really need to CP this PR? We had already reverted the PR that cause the issue, so it was just waiting on Applause to finish testing.

@francoisl With this code, the PR that was reverted should now work. I figured we would get it CP'd to staging so that https://github.com/Expensify/App/issues/10978 wouldn't be held on this and @arosiclair could get to testing and deploying faster.
Sorry of this wasn't the right move! I guess I just wanted to speed things along since I felt kinda bad for forcing the revert on https://github.com/Expensify/App/pull/10979

Just tested on staging and everything is working as expected
https://user-images.githubusercontent.com/31285285/190476091-012b6539-e786-4fd1-8885-d65ca1de1fd1.mov
cc @neil-marcellini

🚀 Cherry-picked to staging by @jasperhuangg in version: 1.2.0-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.


Projection with dependent creates extra fields in SQL SELECT statement

Hi,
Using the following code, I was expecting to see a more concise SQL query that includes only the projected fields, but instead the SQL query includes all fields:
var customer = _customers
	.AsNoTracking()
	.Select(e => new { e.Id, e.Referral, e.State, e.HomeAddress.City })
	.ToList();

info: Microsoft.EntityFrameworkCore.Storage.IRelationalCommandBuilderFactory[1]
      Executed DbCommand (6ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
      SELECT "e"."Id", "e"."CreatedBy", "e"."CreatedOn", "e"."Referral", "e"."RowVersion", "e"."State", "e"."UpdatedBy", "e"."UpdatedOn", "e.HomeAddress"."Id", "e.HomeAddress"."BillingAddressCustomerId", "e.HomeAddress"."City", "e.HomeAddress"."Country", "e.HomeAddress"."FormattedAddress", "e.HomeAddress"."HomeAddressCustomerId", "e.HomeAddress"."PostalCode", "e.HomeAddress"."Province", "e.HomeAddress"."StreetLine1", "e.HomeAddress"."StreetLine2"
      FROM "Application"."Customers" AS "e"
      LEFT JOIN "Application"."CustomerAddresses" AS "e.HomeAddress" ON "e"."Id" = "e.HomeAddress"."HomeAddressCustomerId"
      ORDER BY "e"."Id"

As you can guess, the Customer entity has a child HomeAddress entity navigation (one-to-one). If I omit the e.HomeAddress.City from the projection, the resulting SQL query is correct (as in, it only includes the Id, Referral and State fields in the SELECT statement).
Are my expectations incorrect?
Thanks
Further technical details
EF Core version: 1.1.2
Database Provider: NpgSql
Operating system: Windows 10
IDE: Visual Studio 2017

dupe of #6647
Can you try with 2.0.0-preview1 (or preview2) package?

Unfortunately I cannot.
Thanks for the reference to the similar issue, I will try to work something out or wait for final 2.0.
Regards


Added CI integration with Travis-CI

Next steps:

Go to https://travis-ci.org/
Click "Sign in with GitHub"
Click your user icon and click "Accounts"
Enable for CTFd

Thanks! Compared CircleCI and TravisCI and I think Travis is the way to go. Going to set this up right now.

Also you should just need to pip install -r development.txt since it installs the requirements as well.
https://github.com/isislab/CTFd/blob/master/development.txt#L1


⚠ Bofrost.at has degraded performance

In 10ad9b7, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1411 ms

Resolved: Bofrost.at performance has improved in 7092b3f.


Detox tests hang & fail if the app is using victory-native

Bugs and Questions
Checklist

[x] This is a victory-native specific issue. (Issues that also appear in victory should be opened here)

[x] I have read through the FAQ and Guides before asking a question

[x] I am using the latest version of victory-native

[x] I have checked to make sure that my versions of react-native and react-native-svg are compatible with this version of victory-native. Read about version requirements

[x] I've searched open issues to make sure I'm not opening a duplicate issue

The Problem
Running Detox tests with victory-native in the app, hangs the test, and fails eventually. This happens only on Android. iOS tests run successfully with victory-native
Reproduction
I have created a repo to demonstrate this. I've included instructions in the readme (with screenshots) on how to reproduce this issue. You can find it here: https://github.com/chaitanyadeorukhkar/detox_victory_demo

After digging into this a bit more I realized that the timers run in loops. Victory native uses https://github.com/d3/d3-timer which keeps running in never-ending loops. Because of this detox keeps waiting for the timers to resolve which they never do. Is this intentional to keep d3-timer in a never-ending loop?

Has anyone fixed this or found a workaround?

I did find a temporary workaround. Created a file called e2e/mocks/d3-timer.js with this code
function now() {}

function timer() {
  return {
    restart: () => {},
    stop: () => {},
  };
}

function timerFlush() {}

export { timer, now, timerFlush };

Used this file to "mock" d3-timer in our e2e tests by adding this to our .babelrc.js. You can read up on configuring module resolvers here
plugins: [
    [
      'module-resolver',
      {
        root: ['.'],
        extensions: [
          '.ios.js',
          '.android.js',
          '.js',
        ],
        alias: {
          'd3-timer':
            process.env.BABEL_ENV === 'e2e' ? './e2e/mocks/d3-timer.js' : './node_modules/d3-timer',
        },
      },
    ],
  ],

And finally changed the detox config in package.json to add BABEL_ENV
"android.emu.release": {
        "binaryPath": "android/app/build/outputs/apk/release/app-release.apk",
        "build": "cd android && BABEL_ENV=e2e ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release && cd ..",
        "type": "android.emulator",
        "device": {
          "avdName": "emulator"
        }
      }

Hope this helps!

This looks great. Thanks! Could you share the same "builld" line, but for iOS?

I did find a temporary workaround. Created a file called e2e/mocks/d3-timer.js with this code
function now() {}

function timer() {
  return {
    restart: () => {},
    stop: () => {},
  };
}

function timerFlush() {}

export { timer, now, timerFlush };

Used this file to "mock" d3-timer in our e2e tests by adding this to our .babelrc.js. You can read up on configuring module resolvers here
plugins: [
    [
      'module-resolver',
      {
        root: ['.'],
        extensions: [
          '.ios.js',
          '.android.js',
          '.js',
        ],
        alias: {
          'd3-timer':
            process.env.BABEL_ENV === 'e2e' ? './e2e/mocks/d3-timer.js' : './node_modules/d3-timer',
        },
      },
    ],
  ],

And finally changed the detox config in package.json to add BABEL_ENV
"android.emu.release": {
        "binaryPath": "android/app/build/outputs/apk/release/app-release.apk",
        "build": "cd android && BABEL_ENV=e2e ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release && cd ..",
        "type": "android.emulator",
        "device": {
          "avdName": "emulator"
        }
      }

This disables the graph animations & visuals but at least doesn't block the rest of our e2e tests. Hope this helps!

This looks great. Thanks! Could you share the same "builld" line, but for iOS?

@scaralfred It works fine on iOS. I only had an issue with Android. You can refer this for iOS

Thanks @chaitanyadeorukhkar, your solution worked for me.

Until now, I was able to test the production build with detox (extremely cool and valuable if you think about it), but with victory/d3 I'm forced to use mocks and thus a separate build.
How could someone external like me or a detox developer help with this?


Update standardiser to 0.1.9

We need the python3-compatible version for a tool.
@tsenapathi, I added myself as a maintainer, hope that's okay?

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

license_file entry is missing, but is required.

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

license_file entry is missing, but is required.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

We need the python3-compatible version for a tool.
@tsenapathi, I added myself as a maintainer, hope that's okay?
Checklist
* [x]  Used a fork of the feedstock to propose changes

* [x]  Bumped the build number (if the version is unchanged)

* [x]  Reset the build number to `0` (if the version changed)

* [ ]  [Re-rendered](https://conda-forge.org/docs/maintainer/updating_pkgs.html#rerendering-feedstocks) with the latest `conda-smithy` (Use the phrase `@conda-forge-admin, please rerender` in a comment in this PR for automated rerendering)

* [x]  Ensured the license file is being packaged.

Thanks @simonbray!!

Ready to merge I think

Cool, thanks Tharindu!

Cool, thanks Tharindu!
👍


Alpha 15 - Pawns Will Social Relax with any drug, including luciferium

Running the Alpha 15 branch head, pawns will take luciferium as a social relax drug (and I believe any other drug as well).

Oh, drug policy is ignored, as well.

Thanks for spotting, I still need to do the final check on the detours.  Right now the focus is on finishing the injector refactors and squashing existing bugs.  Once done I'll do a final round on the detours to verify their logic.

https://github.com/RimWorldCCLTeam/CommunityCoreLibrary/pull/183
Submitted an initial PR with the fix for when you get around to it.
Some additional work will be needed for Automated Factories. I don't understand them enough to do that at this time.
Sidenote, I think scheduled drug policies are still ignored, but that seems to be a different problem from the social relaxing issue.

The factories work like two different buildings depending on how they are configured.  They work similar to Building_WorkTable except they don't need a pawn to manually craft or they work similarily in concept to Building_NutrientPasteDispenser in that they only produce when a pawn explicitly uses the machine.
The new drug system I don't think will work with the factories any more as there isn't enough information passed to the functions that need it for the factories to "know" whether food or a drug is being requested.  Some investigation into how the new drug system works and some possible refactoring of the factories with respect to this may need to be done.
As to scheduling, I haven't looked at the drug system at all and only went through the detours enough to make sure they compile.  I have not yet done the comparisons to the A15 functions which are being detoured to make sure the logic is consistent.  Currently the logic in CCLs detours is that of A14 and they all need to be checked and updated.

I can investigate the factories and the drug system if you want. See if I can find a way to implement it. I made the mistake of not branching first so I'll close this pr and branch to keep my fork's alpha15 synced. If I find something that works I'll resubmit. That ok?

Sounds good.

I can investigate the factories and the drug system if you want. See if I
can find a way to implement it. I made the mistake of not branching first
so I'll close this pr and branch to keep my fork's alpha15 synced. If I
find something that works I'll resubmit. That ok?
On Monday, October 24, 2016, Eric<EMAIL_ADDRESS>wrote:

The factories work like two different buildings depending on how they are
configured. They work similar to Building_WorkTable except they don't need
a pawn to manually craft or they work similarily in concept to Building_NutrientPasteDispenser
in that they only produce when a pawn explicitly uses the machine.
The new drug system I don't think will work with the factories any more as
there isn't enough information passed to the functions that need it for the
factories to "know" whether food or a drug is being requested. Some
investigation into how the new drug system works and some possible
refactoring of the factories with respect to this may need to be done.
As to scheduling, I haven't looked at the drug system at all and only went
through the detours enough to make sure they compile. I have not yet done
the comparisons to the A15 functions which are being detoured to make sure
the logic is consistent. Currently the logic in CCLs detours is that of A14
and they all need to be checked and updated.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/RimWorldCCLTeam/CommunityCoreLibrary/issues/179#issuecomment-255655831,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ0nhzRjoC3268hnCV_PTuEl7rGxPup3ks5q3EwwgaJpZM4KYKET
.

Here's an update.
https://github.com/Kelnor277/CommunityCoreLibrary/tree/issue179
Fixes the issue, however automated factories still don't work.
Modified TakeDrugFromSynthesizer to only dispense drugs on pawn's policy  (Unless binging)
The commented code in JoyGiver_SocialRelax lines (125-126) detects if a factory can dispense the desired drug and sets the factory as a possible target. However this breaks everything. Cast class exceptions start spamming on any future job assignment.
Looks like assigning the factory as TargetC on the job is the problem. With that code commented out it's fine. Seems like the social relax job needs to be modified to allow taking from dispensers, but I'm new to Rimworld and CCL so I'm not sure yet. I can check more tomorrow.

At my end what I have done is commented all factory related code from the drugs side.  Factories for food should still work but I am yet to fully test that at the time of writing this.  It's in my current to do list, however.

I got it working with factories. I just need to confirm I didn't break anything else first. Then I'll make a pull request..

PR: https://github.com/RimWorldCCLTeam/CommunityCoreLibrary/pull/184
Automated factories with Meals is still broken. Looks like in JobGiver_GetFood.TryGiveJob() puts the building in foodDef instead of the food. This breaks the FoodUtility.WillIngestStackCountOf call when it tries to get foodDef.ingestible and it's null because it's a building and not food.

That means that FoodUtility.WillIngestStackCountOf needs to be detoured to properly handle having a npd/factory passed to it.

Yeah, I think detours might also be a better way of handling some of the hackey stuff I had to do for the drug factory. I'll look over your detours and see if there's a way to clean that up.

I've been looking over your last PR, I left a few comments.  It's looking good so far though.  I also did a commit where I simply commented most of the drug related code out.  You'll need to do a local merge in your local repo and basically discard my changes.

Merge complete, looks good and tests out well.

Sounds good, I will close this PR and wait for the new one with the complete set of changes.


Set up FPS limit for SDK7 scenes

In the scene-runtime

@menduz  what does this ticket mean exactly?
Are today systems in the scene not limited to running at 30 FPS? Are they running at whatever the machine is capable of running?

Correct. This was superseded by ADR-148 though. We should rename it to On the renderer, ensure the processing quota is being applied as ADR-148 suggests: Based on distance


[cmake] "unsubmodule" 3rdparty dependencies

Summary:

* unsubmodule fmtlib, yaml-cpp, libunicode, catch2
* remove git dependency
* all: add code to select system versions of libraries
* fmtlib: behavior change: remove -DFMT_USE_WINDOWS_H=0: fmt no longer
includes windows.h [1]
* yaml-cpp: add inline patch to:
    * turn off unneeded compilation targets such as tests
    * silence warnings when compiling contour code
* yaml-cpp: attempt to download only a single header, attempt failed,
reverted to downloading full tarball
* catch2: download only the header [2]
* all: add dependency on `patch` binary [3][4]
* all: pin dependencies [5]
* libunicode: temporary inline patch to make it work with this patch

[1]: <https://github.com/fmtlib/fmt/commit/253d63159f79762ebd40aea0c20704cd29acb3c9>

[2]: compilation times can be further improved by creating separate .cpp
file and defining main() there

[3]: perhaps temporary, for the lack of other ideas how to patch
dependencies. A dependency-free way would be to include complete files
that can be hot-swapped with cmake -E copy. However, this requires
careful following of patched dependencies development and manual
backporting "by eye", whereas if patch doesn't apply, it just fails. On
the other hand, it is just as easy to fetch a `patch` binary from the
Internet as it is to fetch any tarball dependency. Googling around,
there is even a native `patch` port for Windows. Not implemented in this
PR due to lack of working Windows machine to test, left as a TODO in
code

[4]: another incovenience of `patch` is that you must apply the patch
exactly once. This is the reason behind guarding it with an if() clause.
Since the patches are provided verbatim and inline, when developer
updates the patch, the clause doesn't update, which means the developer
needs to remember to completely remove the binary dir and cleanly
reconfigure CMake for the new patch to apply. This can come as
unexpected, therefore needs to be addressed, so leaving this as another
TODO for now

[5]: all dependencies (except libunicode) are pinned and
hashsum-checked. This is good for reproducible builds. If cutting edge
dependencies are desired often, such functionality can be added later.
Current implementation does no overly complicated abstraction to support
all possible cases.

Details:

This patch is aimed towards unbundling contour dependencies from git
submodules, or in other words, "unsubmoduling" them. This is a desired
change for a few reasons, as discussed on discord:

* git submodules are _git_ submodules, that is, they require git

* because they require git, tarball archives of code, which github
provides, are useless -- user needs to populate the submodules manually,
which requires git. And guess who downloads tarballs? Definitely not the
people who know how to use git and have it installed.

* even when you clone the repo with git, you need to clone recursively,
or if you didn't read the docs/forgot, you first need to realize that
this the actual problem (since the error message will be bogus), and
then you need to google "git sumbmodule populate", because who the hell
remembers how to do it. This is unpleasant experience from the get-go.
It can be fixed in CMake by probing and populating submodules at
configure time. But it's still inferior to the idea of having no hard
dependency on git.

Therefore, this patch attemtps to replace dependency management via
submodules functionality on best-effort basis.

One such limitation is having a hard dependency on CMake 3.10, which
does not have FetchContent module (CMake 3.11). FetchContent does
exactly what this patch tries to do, which is: download external
dependencies and make them available to the rest of the build at
configure time. As a workaround, ExternalProject_Add is used in a tricky
way.

Tests:

* tested with all pinned dependencies
* tested with all system dependencies (except libunicode) on Manjaro
Linux (Arch Linux derivative)

Expected to fail on Windows due to patch binary. Probably shouldn't fail on macOS.

No idea why it passes on Windows, even after looking at the full log. Perhaps need to add more message()s? Will wait for feedback.

Wir nice. Give me some time to properly read through this. I will reply as soon as possible.

@avemilia many thanks for the great work. I have also tested this with using local system dependencies, which is great.
One thing that did not work is using fmtlib as system dependency. I want to merge it nevertheless, since the default is using the embedded fmtlib. Maybe we can improve on that after this merge. :)

One thing that did not work is using fmtlib as system dependency.

If you want me to look at this, please open a new issue and ping me there, with commands you used and cmake output and cmake error log attached. I have tested -DCONTOUR_EMBEDDED_FMTLIB=0 on Manjaro (as per commit info) and it works with
❯ pacman -Qi fmt
Name            : fmt
Version         : 7.1.3-1
Description     : Open-source formatting library for C++
Architecture    : x86_64
URL             : https://fmt.dev
Licenses        : BSD
Groups          : None
Provides        : libfmt.so=7-64

Although I'm not sure if we want to dig into this. I did this with only one thought in mind, to allow distro maintainers to package this software and decouple it from external dependencies. When they will have problems with specific versions, I think they will open an issue themselves or just patch it.


Adding german language

Added german language.

Should be now fixed.  Used a additional commit instead amend. Hope that is so far okay.

The PR has been merged. Thank you very much @Huskynarr


Update extension for SQLFluff 3.0.0

Add Vertica Dialect.
Handle new outputs for line/position.
Removed --force from fix.
Enabled some basic testing.
VSCode dependency updates.

@keraion Thank you for the pull request, I will get this published to the extension soon


Revert Shift Anti-Drag and Disable in PvP Scenarios

The changes made reflect the exact same sentiments stated by @dekvall  in PR #10870.
The following features have been reverted/added to the anti-drag plugin:

Shift Anti-Drag plugin has been reverted back to original Anti Drag
Shift Only anti-drag still remains an option.
Any form of anti-drag is disabled in PvP scenarios. (Detected by the spec orb enabling/disabling). Including in PvP worlds and wilderness.
Anti drag is enabled for banking.

With the addition of removing all forms of anti-drag for PvP scenarios, I believe this sufficiently solves the issue/uproar in the PvP community that caused the plugin to get reverted in the first place.
Example on a PvP world:

I know there are still some discussions on how runelite should handle anti drag. I just haven't received any feedback on this pr yet. Where are the admins at in those discussions?

I think this approach of just disabling it in pvp via the specorb varbit is the way we want to go, but I haven't looked at this yet.


Better consider the channel in eventbus braodcasting

Component: websocket
Feature Description
Requirements
The event management during the brodcasting of the event bus could be improved by taking into account the channel of each event. The calculation time and filtering could be improved when the number of events to be processed is very big.
The aim of this feature is to change the broadcast rule as follows:

if the channel is empty, we check only the user's permission;
otherwise, if the channel is not empty, we check both that the channel is in the subscription list and the user's permission.

NOTE: Checking the channel will allow for better filtering of events, but this requires adding channels to events and subscribers. This can be done in another RP.

Code review
The Event.channel attribute should be a non-optional str that defaults to "".
Acceptance criteria
Considering events with the right user permissions:

[ ] the event manager must send events if the channel is empty (i.e.: ""),
[ ] the event manager must send events if the channel is a subscriber channel
[ ] the event manager must not send events if the channel does not correspond to any subscriber channel

Considering events with the bad user permissions:

[ ] the event manager must not send events to any subscriber

Currently, there is some Event creation that do not have permission assigned.
The permission field should be required so that the new channel permission check correctly send events to allowed clients.


[Event Request] codeunit 90 "Purch.-Post" - OnBeforePostItemTrackingForReceipt

New Event in function PostItemTrackingForReceipt analog to Sales-Post Codeunit.
UpdateInvoicedQtyOnPurchRcptLine(
    PurchInvHeader, PurchRcptLine, PurchHeader, PurchLine, QtyToBeInvoiced, QtyToBeInvoicedBase, TrackingSpecificationExists);

OnBeforePostItemTrackingForReceipt(PurchInvHeader, PurchRcptLine, QtyToBeInvoiced, QtyToBeInvoicedBase);

if PostItemTrackingForReceiptCondition(PurchLine, PurchRcptLine) then
    PostItemJnlLine(
        PurchHeader, PurchLine, 0, 0, QtyToBeInvoiced, QtyToBeInvoicedBase,
        ItemEntryRelation."Item Entry No.", '', TempTrackingSpecification);

[IntegrationEvent(false, false)]
local procedure OnBeforePostItemTrackingForReceipt(var PurchInvHeader: Record "Purch. Inv. Header"; var PurchRcptLine: Record "Purch. Rcpt. Line"; QtyToBeInvoiced: Decimal; QtyToBeInvoicedBase: Decimal)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 41884.


"Answer without revealing" not working on web

Firefox 78.0.2 64-bit for Windows 10, using NoScript and uBlock Origin but I've allowed everything except Google Analytics/Tag Manager and disabled uBlock for the page.
The first card I get seems to work fine, but if I try passing any cards afterward without revealing them, they just come back after the animation and won't let me continue to the next one unless I reveal the meaning/reading.

Sent pull request to fix this bug

@tiagoben Awesome, thanks you so much! Today I'll give it a test run and merge :)

It's merged https://github.com/oguzgelal/juken/pull/62


Following the license change, modify the boilerplates in crypto/err/

Merged.
4ad239b8a205d8d7278cd895503c8678438c2cb1 Following the license change, modify the boilerplates in crypto/err/


Default octodns_ref is v0.9.12

Description

Default octodns_ref is v0.9.12, which is not the most recent release of octodns/octodns.
Expected Behavior

I'd expect it to be v0.9.14 currently, or master.
Actual Behavior

Default octodns_ref is v0.9.12
Possible Fix

Automatically update it to the latest release; Pin it to master; Or explain why it'll stay v0.9.12.
Steps to Reproduce

Run solvaholic/octodns-sync without specifying octodns_ref
Context

Troubleshooting issues in solvahol/dns, I want to run the latest octodns/octodns.
Your Environment

Version used: main
Link to your project: solvahol/dns

The notion of "a version of octodns/octodns" is changing (see #86). So, for this issue, I'll just bump the default octodns/octodns to v0.9.14 for now.


Update runhcs options to include CRI Sandbox support

Signed-off-by: Justin Terry (VM<EMAIL_ADDRESS>

@saswatb - FYI

Codecov Report

Merging #2914 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2914   +/-   ##
=======================================
  Coverage   43.89%   43.89%
=======================================
  Files         101      101
  Lines       10800    10800
=======================================
  Hits         4741     4741
  Misses       5328     5328
  Partials      731      731

Flag
Coverage Δ

#linux
47.5% <ø> (ø)
:arrow_up:

#windows
41.07% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 231bff7...bc76e01. Read the comment docs.


Fix documentation link

Category

Bugfix

Overview
When using the demo board, after the onboarding, the "Welcome to Homarr" tile had a link that doesnt point to the correct url. This seems to have been an oversight in #1796
Issue Number

Related issue: #1792, specifically this comment.

Thanks ❤  and sorry for ignoring you, I haven't took a look when we released the latest version.


Fix isLatest calculation to handle internal version scheme

The fluid-build-version-tool is used to set build versions and the "latest" npm dist tag in CI. This PR updates it to work properly with the internal version scheme.

Closing in favor of #11628.


POST /api/teams/ - Name is not unique

Currently the name property is not unique, so duplicate teams can exist, we need to add a unique constraint to the column and re-seed the database to clear any duplicate teams.

 POST /api/teams/ - Name is not unique

Team decided to keep existing behaviour


Expose isNewUser information in IDPResponse

See:
https://github.com/firebase/FirebaseUI-Android/issues/1209#issuecomment-378708048
Currently we tell developers to rely on the created / signed in timestamps when checking to see if a FirebaseUser is new or not.  However these timestamps have some limitations that make them occasionally unreliable.
If we could expose this information in the response we provide at the end of the AuthUI flow, that would help developers launch follow-up flows.

Is there any reliable way to workaround this using the current version of the library?

@curiousily the timestamps are reliable with the edge case issue that if a new user signs up, signs out, and signs in within two minutes they will still look "new" because the timestamps wont change.

you guys can also send a flag in onActivityResult intent. like a boolean to represent if its new or existing.

guys, its me again. so i noticed one strange thing.  my business has both website and app but use same firebase authentication table.   so i signed up for a new account on our website as an email provider.  checked firebase console and saw the account there as email provider. waited almost 2 hours..... then logged into app with email provider, but to my surprise it found it as a new signup.  so i checked and the following was true, why ?
metadata.creationTimestamp == metadata.lastSignInTimestamp
after waiting almost 2 hours should this not be false.  is this check only local to the mobile application ?

Hey @samtstern,
Any progress on this issue? This really degrades the experience for our users.

This has been released in version 4.1.0

Hi @samtstern
I found this old issue after noticing that comparing timestamps
metadata.getCreationTimestamp() == metadata.getLastSignInTimestamp()
is not reliable. isNewUser seems to fix it.
Are there any drawbacks of using this method? Why is comparing timestamps still recommended in README?

@AndrazP I think I just forgot to update the README!  isNewUser is preferred.   Want to send a PR and fix the README?


python release notes for the 2021-04 release

This is an automated pull request to gather the python release notes for the 2021-04 release. See Producing Release Notes for details of the processing.

Please use https://github.com/Azure/azure-sdk/pull/2731/files for April releases


Dirichlet Noise Applied During Evaluation

Dirichlet noise should only be applied in self-play in order to aid in exploration in training, not during network evaluation or official play.

Resolved.


Hook for chunking pipelined commands

We ran into an issue with pipelining massive (25K+) redis commands using the context manager. We have had to break this up into chunks (we picked 500 for starts) because redis was closing the socket/connection reset by peer error.
It would be nice if there were a setting/hook in pyredis to chunk commands sent through the pipeline into sizes more digestible to redis.

bump


Update Dynamic inventory tags to make compatible

As the title suggests, fixes incompatibility with new runelite updates

Any updates on this? Seems to be a bit stale...


Kubb working only with react 18

What is the type of issue?
Documentation is missing
What is the issue?
Environment section does not contain  React version restriction

In react 17 error

Where did you find it?
No response

React is part of Kubb so normally you dont need to specify a React version. Which version of Kubb are you using and can you provide me a simple playground/example?

I found problem https://github.com/facebook/react/issues/20235#issuecomment-861836181. It's not a kubb problem

With this tsconfig working great
{
  "compilerOptions": {
    "target": "ES2022",
    "lib": ["ES2023"],
    "module": "ESNext",
    "skipLibCheck": true,
    "moduleResolution": "bundler",
    "allowImportingTsExtensions": true,
    "isolatedModules": true,
    "moduleDetection": "force",
    "noEmit": true,
    "strict": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "noFallthroughCasesInSwitch": true
  },
  "include": ["kubb.config.ts"]
}


Change Copyright Jear from 22 to 21

Change Copyright Jear from 22 to 21
Andreas Krämer

change  branch -readme file - footer - copyright jear 2022 to 2021
creat test thanks !!


Have try_load_entries create a stream

Currently, the try_load_entries_* commands create a Vec<&W> or a Vec<&mut W>.
It would be nice to be able to create a stream directly from it. That would likely decrease
some memory usage in some scenario and lead to simpler code.

This might have been the wrong track. Having a stream introduces many operations on the storage which while asynchronous are not very efficient.
Right now, the plan is to use the pre_load/ post_load in order to load the views efficiently. Those operations could be scheduled by block to make a stream.

The try_load_entries is now using the grouped load with pre_load/ post_load. Therefore this issue is now no longer relevant.


IAM Role support for authentication

Description
Some users want to use an IAM Role to authenticate (and not an AWS profile based on IAM keys).
Example
See AWS doc: https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-role.html

closed by updating documentation with #52


How do I get the returning array from mandrill?

I need the returning array from mandrill to track the ids of the emails I sent (to get click and read data), how would I do that?
result = mandrill.messages.send message, async, ip_pool, send_at
    # [{"_id"=>"abc123abc123abc123abc123abc123",
    #     "reject_reason"=>"hard-bounce",
    #     "status"=>"sent",
    #<EMAIL_ADDRESS>

Hi @echan00
Thank you for using my gem.
I think you can try return_response: true and call deliver instead of deliver! to get the response.
So, it should be something like
mail = YourMailer.your_action.deliver

@dtaniwaki thanks, its a great gem!
I ended up adding unique metadata to my emails instead and using that as a way to track :)