Added support for Derp based relay

This PR integrate HTTPS/TLS based relay (DERP) to Nexodus agent. User can run this relay in two modes

standalone - relay without onboarding to the Nexodus control plane. It will work as a shared relay.
onboarded - relay onboarded to a specific VPC by user using the usual device onboarding flow.
For more details please refer to the documentation added to the PR.

Apart from the integration, this PR has

Integration tests to test various relay scenario.
Documentation containing user level details of this feature.
Go version is bumped to 1.21 and has relevant fixes.

My two biggest concerns right now:

It's not clear to me where the line is between upstream tailscale derp code and our own code. I made a suggestion inline to put upstream code in a separate package under pkg/ instead of intermingled under internal/nexodus. I would also like some idea of how to check for updates to the upstream code. That could go in a developer doc somewhere.

Main derp server code is under internal/nexodus/derp directory. Apart from that we have two files derper.go (contains the code that provides the options and to execute the derp server), and derp.go, that where most of the code for derp integration with nexodus exist. At this point of time, both these go files are very nexodus specific and we need to maintain it, but the code in internal/nexodus/derp is untouched. I think moving it to pkg makes sense, i will work on that.

There's a whole lot of magic here. You have user docs, but not the design side that explains how this all works. Could you provide a design overview of the key decisions made in this implementation?
@russellb just to clarify, do you want the design document of the derp server ? or the design of the integration with nexodus ? I think for the first one, we can refer to tailscale docs, and I can work on the second documents.

My two biggest concerns right now:

It's not clear to me where the line is between upstream tailscale derp code and our own code. I made a suggestion inline to put upstream code in a separate package under pkg/ instead of intermingled under internal/nexodus. I would also like some idea of how to check for updates to the upstream code. That could go in a developer doc somewhere.

Main derp server code is under internal/nexodus/derp directory. Apart from that we have two files derper.go (contains the code that provides the options and to execute the derp server), and derp.go, that where most of the code for derp integration with nexodus exist. At this point of time, both these go files are very nexodus specific and we need to maintain it, but the code in internal/nexodus/derp is untouched. I think moving it to pkg makes sense, i will work on that.

Thank you. I was worried there might be more changes to their code. This is good to hear. If it's pretty clean already, I'm OK merging now and letting this be a follow-up PR.

There's a whole lot of magic here. You have user docs, but not the design side that explains how this all works. Could you provide a design overview of the key decisions made in this implementation?

@russellb just to clarify, do you want the design document of the derp server ? or the design of the integration with nexodus ? I think for the first one, we can refer to tailscale docs, and I can work on the second documents.

The nexodus integration. It can have a link to tailscale docs about the derp server. I just remember lots of discussions where you were talking about the details about how you get the integration working. An overview of that for people coming to this later would be great. I'm OK with this coming as a follow-up PR as well.


Investigate git pre-commit hooks

Investigate adding git pre-commit hooks that can ensure some level of validations before a PR can be opened. Possible checks could be

Linting passes
Link validity checking
CredScan doesn't fail
CSpell doesn't flag anything

I'm a fan of git pre-commit hooks for credscan / linters in personal projects.


When navigating responses with alt+[ and alt+], the next response is not read

Testing #188537

Press alt+F2, VoiceOver starts reading the response
Press alt+], the view shows the next response but VoiceOver is still reading that response and it never reads the next response

Maybe related, but sometimes, it also doesn't read the response when I press alt+F2. It will say "you are now on a text area" and just sit there. Then, it only wants to read the text a single character at a time when I move the cursor.

Are you in screen reader optimized mode?

Actually, I believe this might be working as expected - I have to move the cursor for the screen reader to move on to the next content.
@jooyoungseo and @rperez030 could you pls let us know if this is a bug or working as expected?

Unfortunately, this is a voiceover issue, but I believe last time we faced something like this it was resolved my slightly increasing the wait time for certain focus event. I don't remember the full context and cannot find the issue right now. @meganrogge  does it sound familiar? It was related to the opening and closing of the contextual help I believe.

Great recall @rperez030 the issue you are talking about is https://github.com/microsoft/vscode/issues/186514

Correct. I believe it could be the same underlying cause. By the way, having to move the cursor to read content is totally fine as you described. the real issue is that Voiceover is not announcing the change of context.

Makes sense - because without that announcement, you wouldn't know to move your cursor

I wonder if we have a way to calculate the total number of responses. if we do, we could issue an alert announcing position information when we move back and forth. This would resolve the lack of context for macOs and improve the experience in the other platforms. Thoughts?

Yes @rperez030 that makes sense to me - I linked an issue where this is a request for the notification a11y view and we could also support this for the responses

It might have to be an August thing - I'll investigate.

this is also an issue for notifications

I think we have to go with what you suggested @rperez030 i tried a bunch of hacks and setTimeouts and it didn't work

I think we have to go with what you suggested @rperez030 i tried a bunch of hacks and setTimeouts and it didn't work

I think it could make the feature more helpful for all platforms. Moving between suggestions is right now a bit confusing because I can't tell for sure if the one on focus is the last one, or if it truly moved to a different one after pressing the command. In the copilot chat panel, for example, I find much more practical and easier to simply move to the list of responses and go on from there. In addition, hacking assistive technology rarely justifies the effort, and often leads to undesirable outcomes that are not easy to anticipate.

it seems focus still gets trapped initially - even alert isn't taking precedent. i'm hoping it's just what I'm experiencing. about to make a PR with a change that does this for notifications and chat responses

yes, the linked PR please @rperez030 sorry I have been doing a lot atm 😓

Verified by @rperez030 with the follow up item of to be addressed in August https://github.com/microsoft/vscode/issues/189105


the control does not work in "Offline Mode"

Hi,
I noticed that the control does not retrieve records form the entity (which is enabled for offline mode and the records are available).
i am not sure if this is a bug or lack of functionality!

Hi, thanks for sharing this.
I will check it and will come back to you.
Right now I am using the xrm.webapi.retrieve... so probably I should look at using .webapi.offline method.

Yes that could solve the issue... looking forward to the new version.

Hi,
I have been cheching the PCF and played with the offline capabilities.
Could you let me know the query you are using in your filter?
I believe you are trying to use "contains" and this seems that is not supported by the offline webapi.
Please, look at this thread that's been opened as well https://github.com/MicrosoftDocs/dynamics-365-customer-engagement/issues/1916 refering to the same issue with the contains.
Could you try to use in your filter query an equals instead a contains, something similar to:
?$filter=firstname eq 'Firstname'
I have tried that in my form and that seems to work, so it seems there is a limitation based on the queries.


Dependency conflict: jakarta/ws/rs/ext/ContextResolver

Hello. I work at a company that is trying to integrate docuSign internally but we are having dependency problems.
There are several related to javax/jakarta/jersey.
The last log we have is this:
2023-10-19T18:43:47.732-03:00 DEBUG 26240 --- [nio-8080-exec-2] .m.m.a.ExceptionHandlerExceptionResolver : Resolved [jakarta.servlet.ServletException: Handler dispatch failed : java.lang.NoClassDefFoundError: jakarta/ws/rs/ext/ContextResolver]
My project uses Java 18 and Spring boot.
The error happens when initializing (ApiClient apiClient = new ApiClient();) With or without url
pom.txt
I added the project pom.xml.
I'm using the version:
<dependency>
    <groupId>com.docusign</groupId>
    <artifactId>docusign-esign-java</artifactId>
    <version>4.4.0</version>
</dependency>

However, I have already tried several others.
As solutions I have already tried the following dependencies:
<dependency>
    <groupId>javax.ws.rs</groupId>
    <artifactId>jsr311-api</artifactId>
    <version>1.1.1</version>
</dependency>
<dependency>
    <groupId>javax.ws.rs</groupId>
    <artifactId>javax.ws.rs-api</artifactId>
    <version>2.0.1</version>
</dependency>
<dependency>
    <groupId>org.glassfish.jersey.core</groupId>
    <artifactId>jersey-client</artifactId>
    <version>2.28</version>
</dependency>
<dependency>
    <groupId>org.glassfish.jersey.inject</groupId>
    <artifactId>jersey-hk2</artifactId>
    <version>2.28</version>
</dependency>
<dependency>
    <groupId>com.unboundid.product.scim2</groupId>
    <artifactId>scim2-sdk-client</artifactId>
    <version>2.3.6</version>
</dependency>
<dependency>
	<groupId>org.glassfish.jersey.containers</groupId>
	<artifactId>jersey-container-servlet</artifactId>
	<version>2.21</version>
</dependency>

<dependency>
	<groupId>org.glassfish.jersey.core</groupId>
	<artifactId>jersey-server</artifactId>
	<version>2.21</version>
</dependency>

<dependency>
	<groupId>com.fasterxml.jackson.jaxrs</groupId>
	<artifactId>jackson-jaxrs-json-provider</artifactId>
	<version>2.2.3</version>
</dependency>

<dependency>
	<groupId>org.glassfish.jersey.media</groupId>
	<artifactId>jersey-media-json-jackson</artifactId>
	<version>2.21</version>
</dependency>

<dependency>
	<groupId>org.glassfish.jersey.bundles</groupId>
	<artifactId>jaxrs-ri</artifactId>
	<version>2.21</version>
</dependency>

I also tried:
<dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>javax.ws.rs</groupId>
                <artifactId>jsr311-api</artifactId>
                <version>1.1.1</version>
            </dependency>
            <dependency>
                <groupId>javax.ws.rs</groupId>
                <artifactId>javax.ws.rs-api</artifactId>
<!--                <version>2.0-m01</version>-->
                <version>2.0</version>
            </dependency>
            <dependency>
                <groupId>org.glassfish.jersey.core</groupId>
                <artifactId>jersey-client</artifactId>
                <version>2.29.1</version>
            </dependency>
            <dependency>
                <groupId>org.glassfish.jersey.core</groupId>
                <artifactId>jersey-common</artifactId>
                <version>2.29.1</version>
            </dependency>
            <dependency>
                <groupId>org.glassfish.jersey.inject</groupId>
                <artifactId>jersey-hk2</artifactId>
                <version>2.29.1</version>
            </dependency>
            <dependency>
                <groupId>org.glassfish.jersey.media</groupId>
                <artifactId>jersey-media-multipart</artifactId>
                <version>2.29.1</version>
            </dependency>
            <dependency>
                <groupId>org.glassfish.jersey.media</groupId>
                <artifactId>jersey-media-json-jackson</artifactId>
                <version>2.29.1</version>
            </dependency>
        </dependencies>
    </dependencyManagement>

Hi Jonathan,
I've looked through our own pom.xml and see these are the dependencies we're using for jakarta for the eSignature SDK:
        <dependency>
            <groupId>com.fasterxml.jackson.jakarta.rs</groupId>
            <artifactId>jackson-jakarta-rs-base</artifactId>
            <version>2.14.2</version>
        </dependency>

        <dependency>
            <groupId>jakarta.ws.rs</groupId>
            <artifactId>jakarta.ws.rs-api</artifactId>
            <version>3.1.0</version>
        </dependency>

You can try importing a shaded version of the eSign sdk (creating an uber-jar and bundling the dependencies) like this:
<dependency>
    <groupId>com.docusign</groupId>
    <artifactId>docusign-esign-java</artifactId>
    <version>4.4.0</version>
    <classifier>shaded</classifier>
</dependency>

Also, feel free to review our preconfigured the Quickstart  (code-examples-java launcher). It is using SpringBoot 2.5 and I see your pom provided has SpringBoot 3.0, but otherwise I would try running the eSignature sdk as a shaded dependency in your project first to see if anything changes. Hope this helps, let me know if you have any other questions or if this suggestion wasn't helpful.

Your solution worked for my problem. Thanks.

Hi Aaron,
I tried to use the shaded version and it works fine. I understand that in shaded version the docusign lib will self includes all the deps it needs in its own package.
But why using non-shaded version, the transitive dependencies will not be included in our project like other libraries does? I see that the pom file in docusign META-INF includes all the deps defined. But for the pom file used in our project, it only has two Junit test dependencies.


All files for Pear Deck case study

Adding Pead Deck case study:

Images
Updated case study index file
Case study CSS and HTML files

This change is

@bobsky FYI


[W6.1f][T15-B3]Darren Chin Jhun Pyng

Made Command#execute abstract

@DarrenCzen
Nothing much to review here. Hence closing with minimal review


⚠ SceneTime has degraded performance

In c8a0186, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 8540 ms

Resolved: SceneTime performance has improved in cec0caf.


Notifications not synchronized (Mac < > iPhone)

Summary
Mobile notification not syncing with Application
Environment Information

Device Name: iPhone 11 Pro Max / Macbook Pro M1 2020
OS Version: 16.1 / 12.6.2 (Monterey)
Mattermost App Version: 2.0.0 (Build 452) / 5.0.4
Mattermost Server Version: 7.7.1

Steps to reproduce
How can we reproduce the issue (what version are you using?)
I am using the Application for Mattermost on my Mac (App not Web - latest version) and the latest version of the App on my iPhone. If someone is messaging me I'll get notifications on both devices. After checking the message on my Mac, the notification will disappear on my Mac - obviously. The notification (red number @ app icon on my iPhone) will stay until I open the app and Mattermost is syncing with the server.
I've activated any kind of background activity on my iPhone. Did not check vise versa.
Expected behavior
The notification on my app icon (iPhone) should disappear after I've read the message on my Mac. There should be a e. g. background service for that.
Observed behavior (that appears unintentional)
Happens for every notification.
Possible fixes
Open the Mattermost app on my iPhone and let is sync. Not the best solution for this.

Opened https://mattermost.atlassian.net/browse/MM-50383.

Hi @JonnyBDev! Question related to:

If someone is messaging me I'll get notifications on both devices

Is this your preference to always get notifications on both devices? We currently have a setting where you have choose to only have Push Notifications to your mobile app if you are Away and/or Offline. This way you don't get constant double notifications that seems to highlight this app sync issue more.

Hi @JonnyBDev, we have a second question to better understand this report:
Specifically for the following part,

Expected behavior
The notification on my app icon (iPhone) should disappear after I've read the message on my Mac. There should be a e. g. background service for that.

Observed behavior
Happens for every notification.

What do you mean by "Happens for every notification" as the observed behaviour? Are all the Mattermost notifications wiped when they shouldn't?


Update image clustering

Create and use a Clip filter which clips all values in an array to the min and max values provided by the user.

Codecov Report

Merging #100 into master will decrease coverage by 1.65%.
The diff coverage is 36.36%.

@@           Coverage Diff            @@
##           master   #100      +/-   ##
========================================
- Coverage   45.66%    44%   -1.66%
========================================
  Files          21     21
  Lines        1406   1468      +62
========================================
+ Hits          642    646       +4
- Misses        764    822      +58

Impacted Files
Coverage Δ

src/runner_.py
0% <0%> (ø)
:arrow_up:

src/problemgenerator/filters.py
52.87% <40%> (-0.24%)
:arrow_down:

src/plotting/utils.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d706ff...cec6f11. Read the comment docs.


First pass at implementing the feature requested in #134: allow the user to specify a custom location for the web.xml file.

To accomplish this, added a 'webXml' configuration parameter to the Gretty extension.

Hello, is there any plans for merging in this change? It would be a very useful feature to have in gretty. Is there something that I can do to help with the process of getting this merged?

6 months since the pull request... We need this feature. Is it possible to merge this ASAP?

@akhikhl anything I can do to get this accepted? Would be convenient to have.


Use $GO for go:generate

I'm trying to compile prometheus with go1.14-rc.1 and found that $GO env variable is not respected in go:generate rules.

Ok, need to patch promu to honour $GOfirst.

I do not see $GO as a standard here: https://golang.org/pkg/cmd/go/internal/generate/

It's in the Makefile:
https://github.com/prometheus/prometheus/blob/master/Makefile.common#L28

Changing go version  would also require to update the GOROOT env variable, no? Then what would prevent you to change PATH too?

If you were to want to compile prometheus with go1.14rc1 you would do:
go get golang.org/dl/go1.14rc1
go1.14rc1 download

Then the go binary would be named go1.14rc1
s.rabot@wmbpro-srabot$ which go1.14rc1
/Users/s.rabot/go/bin/go1.14rc1
s.rabot@wmbpro-srabot$ /Users/s.rabot/go/bin/go1.14rc1 env                                                                                19:23:34
GO111MODULE=""
GOARCH="amd64"
GOBIN="/Users/s.rabot/go/bin"
GOCACHE="/Users/s.rabot/Library/Caches/go-build"
GOENV="/Users/s.rabot/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/s.rabot/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/s.rabot/sdk/go1.14rc1"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/s.rabot/sdk/go1.14rc1/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/z0/rcywz4nn3jg6g96h67c_4xzdw31lvl/T/go-build667859159=/tmp/go-build -gno-record-gcc-switches -fno-common"

Thanks for opening the PR @sylr, we looked at this in our bugscrub and I'm going to tag the relevant maintainers to take a look at this change. @superQ and @simonpasquier. Is this something we'd like to support?

Yes, this seems fine.
Do we still need changes to promu?

I do not think this is needed, this is maybe a bug in promu?
 $ cat main.go
package main

//go:generate go version

func main() {
}

$ go generate
go version go1.15 linux/amd64
$ go1.16rc1 generate
go version go1.16rc1 linux/amd64

@sylr: could you check my last comment? I'd tend to think that go is already doing the right thing here.

You might be right and honestly I don't remember why I needed this so I'll close it.


Adding a slider image

Is your feature request related to a problem? Please describe.
There is only single image
Describe the solution you'd like
I would like to add feature where there would be a slider of images one by one
Describe alternatives you've considered
Additional context

Like here only single images is there.
Please assign me this issue under GSSoC'24.

This Page have to fix , taking a reference of
https://user-images.githubusercontent.com/84167034/218539183-e6cffd7d-08bc-45e9-a042-e7025172df8e.png


Old version of Flux being used?

This looks like a pretty old (and unsupported version?)
Should we bump this to a v0.30.x version?
https://github.com/weaveworks/weave-gitops/blob/761982b9be689655d3554943fe9d6cc005e539cd/gitops.dockerfile#L1

why is this even in here? I was under the impression we removed Flux from the CLI?

Since we are bringing it back in anyway we might as well update this and move it forward.

We need to upgrade Flux ASAP as Flux < v0.30 contains 3 CVEs.
Please also note that Source controller CRDs are v1beta2 in v0.30.

This file isn't used for anything, and this argument would be overriden by the makefile if we were to use it.

That is good to know.  Do we need to keep the file around then?


Modify --user flag for podman create and run

If an integer is passed into the --user flag, i.e --user=1234
don't look up the user in /etc/passwd, just assign the integer as the uid.
Fixes https://github.com/projectatomic/libpod/issues/631
Signed-off-by: umohnani8<EMAIL_ADDRESS>

Hi! Ignoramus here, but could we take a fresh look at #631? In particular, take a step back and review if we really want docker compatibility here? I kind of think that running as an undefined user is an undefined corner case, and still think that podman's current action (blocking it) is preferable to docker's.

@edsantiago I think you should be allowed to pick a random UID to run a container and not require the UID be defined in the /etc/passwd.
This is what OpenShift is doing where it takes a container and runs it as the users UID.
The problem with doing this in the past was a evil user could define an entry in /etc/passwd with
3267:*:0:0
Which would fool the container runtime as to run the account as the root user.   This patch prevents that.
What I would like to see is if the admin specifies --uid 3267
and the etc/passwd has
dwalsh:x:3267:3267:Daniel J Walsh:/home/dwalsh:/bin/bash
That the process runs with GID=3267.  Currently in docker and podman this process would run as GID=0.
Then the third problem would be that no entry for UID==3267 exists, should it run as GID=0, I believe it should NOT, and that we should just set the GID=UID, which does not match Docker, but I think is a good compromise.

@rhatdan Tend to agree on setting GID=0 in that case - GID=UID makes more sense from a security standpoint

Okay modified the code so that GID == UID if UID does not exist in /etc/passwd.  Thanks for the fixes @umohnani8

@rh-atomic-bot r+


create shell scripts files to run the server

Created the initial shell script (sh file) hence resolving the issue. Will create new issues for creating bat file. Need to create more issues for updating these scripts in future committed with commit f5621720d87c8ea7bc22071ba51ae929f7b7a288


Snippets/README.md new link

thanks for sharing, @typefounding :)

@benkiel I wonder why would one want to set UseTypoMetrics bit to false nowadays... That OS/2 flag was supposed to put an end to the old WinAscent/WinDescent mess. Using the OS/2 Typo vertical metrics for default line spacing should be the way to go for modern Windows apps.

@anthrotype Except that Word just started to respect that bit — but old documents opened in new Word with same font now can have different line spacing depending on how one sets the vertical metrics — and it seems that Word still uses the hhea metrics when printing, but not for on screen display, so it's a right mess.

Ideally hhea metrics should match OS/2 typo metrics, is there any reason for them to be different (just curious)?

@khaledhosny Yes, in an ideal world — however, that world doesn't happen inside of Word. If your accents are above the the hhea metrics, they'll be clipped off (not shown) in Word. This happens very often, so the way that many folks set metrics is hhea ascent/decent & win ascent/descent are set to the bounding box max/min of a family. No clipping. hhea linegap is set to 0. Typo metrics are set to be more rational, and sum to the UPM. Typo line gap is set to the difference of the sum of hhea (when I say sum, I mean the sum of the abs of each) minus the sum of the typo values.
Doing this makes things work well in Word and in design applications. Yes, this isn't 100% to the spec, but try telling customers that it's Word's problem — they just want their fonts to work.

That is weird, is this perhaps Word for Mac?

@khaledhosny largely Word for Mac, but not always.

Btw. @benkiel, why should sTypoAscender and sTypoDescender add to the UPM? I hear that all the time, but the MS spec doesn't say that.

@justvanrossum They don't have to — my apologies for implying that this was a must. It is a MS recommendation that they do (https://www.microsoft.com/typography/otspec/recom.htm#tad), but it's not a requirement. Making it sum means that you won't have overlap in things that calculate baseline to baseline with just the typoAscender + typoDescender.
Anyway, vertical metrics are no fun — and we may now have written too much for a pull of a link for something I wrote to solve an issue with setting one bit if you've set vertical metrics up one way!


Hide slider when image dimension is 1

closes #421

From email from @DanicaSTFC

I know you have a flag for this already but I preferr to keep the hide/show flag separate from the creation flag.

At the time I did not find a way to hide the slider widget, which you seem to have found. I used EnabledOn.
https://github.com/TomographicImaging/CILViewer/blob/cf6cb86489d1962caa8e2195d9499c3ffbc6e2a7/Wrappers/Python/ccpi/viewer/CILViewer2D.py#L1565-L1569
It would be useful to add a method setSliderWidgetEnabled to be able to control the visibility of the slider widget.

This PR seems to fix the last point at #365 (comment)
From email from @DanicaSTFC

I know you have a flag for this already but I preferr to keep the hide/show flag separate from the creation flag.

At the time I did not find a way to hide the slider widget, which you seem to have found. I used EnabledOn.
https://github.com/TomographicImaging/CILViewer/blob/cf6cb86489d1962caa8e2195d9499c3ffbc6e2a7/Wrappers/Python/ccpi/viewer/CILViewer2D.py#L1565-L1569
It would be useful to add a method setSliderWidgetEnabled to be able to control the visibility of the slider widget. This would allow a proper treatment of the visibility and creation of the widget.

I did not create a new method to control the visibility as the SetEnabled method already exists. The creation of the widget in a viewer is a different matter. I was not sure what you wanted to do with the enabled parameter. Perhaps we can discuss this in a meeting.


1.10.0 Release

We need to release a new version based on Camel 3.18.0 LTS.
What are the issues you want to add as mandatory in 1.10.0? Please add the issues here, so we can track and start a release soon.

There are a few open issues that are supposed to be in 1.10.0:
https://github.com/apache/camel-k/milestone/35
I think these three issues are just waiting for a new Camel K runtime release before getting merged:
https://github.com/apache/camel-k/pull/3376
https://github.com/apache/camel-k/pull/3373
https://github.com/apache/camel-k/pull/3317
cc: @christophd @claudio4j @squakez

I could start a release for camel-k-runtime and camel-kamelets

So we can point to staging repository.

Probably we should include this to 1.10.0 as well: #3552
cc: @astefanutti

https://github.com/apache/camel-k/pull/3561
For alignment

I'm releasing again camel-k-runtime as staging repository because of https://github.com/apache/camel-k-runtime/commit/857ec9add818bc3f03b133fe71a441429c605520

What's the general situation for releasing?

https://github.com/apache/camel-k/pull/3376 is ready to be merged IMO

#3376 Merged.

I think it is failing also because the staging repository is not updated on that branch.

#3317 has several tests failing. I'm having a look to understand why this is happening.

I noticed they are all the same errors happening on the main branch. In particular I can see:
org.graalvm.polyglot.PolyglotException: java.lang.IllegalStateException: Duplicate language id regex. First language [Language class com.oracle.truffle.regex.RegexLanguage, Loaded from file:/deployments/dependencies/lib/main/org.graalvm.regex.regex-22.1.0.jar]. Second language [Language class com.oracle.truffle.regex.RegexLanguage, Loaded from file:/deployments/dependencies/lib/main/org.graalvm.regex.regex-22.1.0.jar].

I think we either merge everything and solve on main or we solve on main, then rebase every pending PR and see each result. I'd go with the second approach which look safer.

Relates https://github.com/quarkusio/quarkus/issues/27085

#3373 fails are timeouts.

I've pushed remaining ones to 1.11.0 milestone. Now it's only #3373 that we are waiting to be merged.
https://github.com/apache/camel-k/milestone/35

I re-released camel-k-runtime and updated the staging repo in main branch. We just need to wait for #3373

Listing here the tests I can see are still failing:

[ ] All test local
[ ] --- FAIL: TestKitKnativeFullBuild (613.55s)
[ ] --- FAIL: TestOperatorUpgrade (286.91s)
[ ] [test-kamelet-cc3hvcg61tss6ro81ao0-98r28 test-1] INFO	|  Kamelets templates can use beans ............................... FAILED
[ ] [test-kamelet-no-props-cc3i7lo61tss6ro81arg-7bp28 test-1] INFO	|  Bind Kamelet to service ........................................ FAILED

Local testing are failing because the E2E is not using the staging repo. I'm working to see if it is easy to include it when present in the Makefile.

Knative tests seems to be resolved in https://github.com/apache/camel-k/runs/8011632479?check_suite_focus=true

I've just verified that the common is still failing as the runtime still uses the bugged quarkus dependency (ie, dependencies/lib/main/org.apache.camel.quarkus.camel-quarkus-js-dsl-2.11.0.jar). I am checking why this is happening.

I have had a look at the YAKS E2E tests and optimized with using a global operator: #3573
This also seemed to stabilize the tests

I finally manage to workaround the latest standing issue in the common check. Hopefully once this got staged, we should have a green flag to go :)

I released a new staging release for camel-k-runtime and updated in camel-k with https://github.com/apache/camel-k/commit/f44b5441266fd0d1959addf0538da4a280bc8bfe

Okey, in common check, we've solved some of the errors, but still others are there [1]. I'm listing them here:

[ ]     --- FAIL: TestKameletBinding/test_error_handler/throw_error_test (165.07s)
[ ]     --- FAIL: TestBindingWithImage/run_with_initial_image (2.44s)
[ ]     --- FAIL: TestErrorHandlerTrait/Run_errored_integration_with_error_handler (164.55s)
[ ]     --- FAIL: TestHealthTrait/Readiness_condition_with_stopped_route (756.85s)

@lburgazzoli I understood lately we changed something in the error handler. Any hints on places where we should look at by any chance?
[1] https://github.com/apache/camel-k/runs/8064025483?check_suite_focus=true

Okey, in common check, we've solved some of the errors, but still others are there [1]. I'm listing them here:
* [ ]      --- FAIL: TestKameletBinding/test_error_handler/throw_error_test (165.07s)

* [ ]      --- FAIL: TestBindingWithImage/run_with_initial_image (2.44s)

* [ ]      --- FAIL: TestErrorHandlerTrait/Run_errored_integration_with_error_handler (164.55s)

* [ ]      --- FAIL: TestHealthTrait/Readiness_condition_with_stopped_route (756.85s)

@lburgazzoli I understood lately we changed something in the error handler. Any hints on places where we should look at by any chance?

I don't think we made any change yet to the error handler, or at least not something I explicit recall, do you have any pointer ?

[1] apache/camel-k/runs/8064025483?check_suite_focus=true

@lburgazzoli you're right. I was mislead by this commit where you fixed some log comment only.

The format of the health probe has changed with the Camel upgrade, from something like map[route.context.name:camel-1 route.id:route1 route.status:Stopped] to map[check.kind:READINESS route.id:route1 route.status:Stopped]. The e2e tests assertions should be updated accordingly, and the integration monitor action might have to be adjusted as well. @davsclaus can probably provide some more insights on what change on the Camel side.

@squakez @astefanutti Thanks for your input. I can take care of TestHealthTrait fix.

@lburgazzoli you're right. I was mislead by this commit where you fixed some log comment only.

After all, my memory is not in that bad shape... I dug a bit more and indeed there was some change in the Error Handler managment in Camel 3.17. This one introduced a regression on Camel K runtime, as one supporting method was wiped off. In order to fix this, we'll probably need to reintroduce a workaround we had in place for pre 3.10 Camel releases. Without that check, there is no way we can verify if a default error handler, as the getErrorHandlerFactory() is in charge to create one, when it is called.
I'll test it locally to see if it works and report how it goes.
fyi @davsclaus

What's the situation? Do we need another staging release?

What's the situation? Do we need another staging release?

I'm still testing the fix on the camel-k-runtime. We'll probably need a new one. I'll let you know once everything is tested locally.

It seems only testBindingWithImage is failing now. Do we want to release or do we want to fix it?

@oscerd It must be just an issue with the test code. Should be fixed here: #3590  The other failure in install-it CI is also a test code issue #3583. I think it's good to proceed to release.

If we all agree I'll try to start the release today.

Started release process.

The release is on vote.

@oscerd Will  #3285   be included?  Camel-K use almost all resource of one api-server's node because of it.


Q5A assignement number pads

" kicad-pcblib/manuf.pretty/TEXAS-Q5A.kicad_mod"
Hi,
When i read the documentation CSD17501Q5A (N-Channel NexFET from TI) and compare with the package. I see that the pins are reversed.

Hm, my issue notification settings must be borked. This is old.
Anyway, looks fine to me - it's rotated vs the datasheet, not reversed, which is fine. I probably prepared it from a drawing that showed it the other way around.


quantile returns undefined on an empty array, differs from extent

More a suggestion than a bug: quantile() and extent() can both be used to determine the domain of a dataset and it's common to pass the results of these to a scale.domain(). However if your dataset is empty, the results of quantile() vs extent() are somewhat different:
quantile([], n) === undefined vs extent([]) === [undefined, undefined]
A difference here is the results of the extent call can be passed to a scale.domain() vs passing the results of quantile results in TypeError: undefined is not iterable
Granted, when your dataset is empty, you probably won't be using that scale anyway, but it'd be nice to not have to do an extra check when using quantile instead of extent to create your scales. Thus having quantile([], n) === [undefined, undefined] might be preferred

deleting, I'm a dummy


The make build command fails with permission denied on /srv/jekyll

Make fetch has ran without errors, but:
$ make build
---> Building documentation
Bundler 2.3.25 is running, but your lockfile was generated with 2.1.4. Installing Bundler 2.1.4 and restarting using that version.
Fetching gem metadata from https://rubygems.org/.
Fetching bundler 2.1.4
Installing bundler 2.1.4
Fetching gem metadata from https://rubygems.org/.............
Fetching public_suffix 5.0.1
Installing public_suffix 5.0.1
Using addressable 2.8.1
Using bundler 2.1.4
Using colorator 1.1.0
Fetching concurrent-ruby 1.2.0
Installing concurrent-ruby 1.2.0
Using eventmachine 1.2.7
Using http_parser.rb 0.8.0
Using em-websocket 0.5.3
Using ffi 1.15.5
Using forwardable-extended 2.6.0
Using i18n 1.12.0
Using sassc 2.4.0
Using jekyll-sass-converter 2.2.0
Using rb-fsevent 0.11.2
Using rb-inotify 0.10.1
Fetching listen 3.8.0
Installing listen 3.8.0
Using jekyll-watch 2.2.1
Using rexml 3.2.5
Using kramdown 2.4.0
Using kramdown-parser-gfm 1.1.0
Fetching liquid 4.0.4
Installing liquid 4.0.4
Using mercenary 0.4.0
Using pathutil 0.16.2
Using rouge 3.30.0
Using safe_yaml 1.0.5
Using unicode-display_width 1.8.0
Using terminal-table 2.0.0
Using jekyll 4.2.2
Fetching jekyll-regex-replace 1.1.0
Installing jekyll-regex-replace 1.1.0
Fetching jekyll-relative-links 0.7.0
Installing jekyll-relative-links 0.7.0
Fetching jekyll-titles-from-headings 0.5.3
Installing jekyll-titles-from-headings 0.5.3
Fetching webrick 1.8.1
Installing webrick 1.8.1
Bundle complete! 10 Gemfile dependencies, 32 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
  Logging at level: debug
    Jekyll Version: 4.2.2
Configuration file: /srv/jekyll/_config.yml
                    ------------------------------------------------
      Jekyll 4.2.2   Please append `--trace` to the `build` command
                     for any additional information or backtrace.
                    ------------------------------------------------
/usr/local/lib/ruby/3.1.0/fileutils.rb:243:in `mkdir': Permission denied @ dir_s_mkdir - /srv/jekyll/.jekyll-cache (Errno::EACCES)
	from /usr/local/lib/ruby/3.1.0/fileutils.rb:243:in `fu_mkdir'
	from /usr/local/lib/ruby/3.1.0/fileutils.rb:221:in `block (2 levels) in mkdir_p'
	from /usr/local/lib/ruby/3.1.0/fileutils.rb:219:in `reverse_each'
	from /usr/local/lib/ruby/3.1.0/fileutils.rb:219:in `block in mkdir_p'
	from /usr/local/lib/ruby/3.1.0/fileutils.rb:211:in `each'
	from /usr/local/lib/ruby/3.1.0/fileutils.rb:211:in `mkdir_p'
	from /usr/gem/gems/jekyll-4.2.2/lib/jekyll/cache.rb:184:in `dump'
	from /usr/gem/gems/jekyll-4.2.2/lib/jekyll/cache.rb:101:in `[]='
	from /usr/gem/gems/jekyll-4.2.2/lib/jekyll/cache.rb:45:in `clear_if_config_changed'
	from /usr/gem/gems/jekyll-4.2.2/lib/jekyll/site.rb:118:in `reset'
	from /usr/gem/gems/jekyll-4.2.2/lib/jekyll/site.rb:35:in `initialize'
	from /usr/gem/gems/jekyll-4.2.2/lib/jekyll/commands/build.rb:30:in `new'
	from /usr/gem/gems/jekyll-4.2.2/lib/jekyll/commands/build.rb:30:in `process'
	from /usr/gem/gems/jekyll-4.2.2/lib/jekyll/command.rb:91:in `block in process_with_graceful_fail'
	from /usr/gem/gems/jekyll-4.2.2/lib/jekyll/command.rb:91:in `each'
	from /usr/gem/gems/jekyll-4.2.2/lib/jekyll/command.rb:91:in `process_with_graceful_fail'
	from /usr/gem/gems/jekyll-4.2.2/lib/jekyll/commands/build.rb:18:in `block (2 levels) in init_with_program'
	from /usr/gem/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `block in execute'
	from /usr/gem/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `each'
	from /usr/gem/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `execute'
	from /usr/gem/gems/mercenary-0.4.0/lib/mercenary/program.rb:44:in `go'
	from /usr/gem/gems/mercenary-0.4.0/lib/mercenary.rb:21:in `program'
	from /usr/gem/gems/jekyll-4.2.2/exe/jekyll:15:in `<top (required)>'
	from /usr/gem/bin/jekyll:25:in `load'
	from /usr/gem/bin/jekyll:25:in `<top (required)>'
	from /usr/gem/gems/bundler-2.1.4/lib/bundler/cli/exec.rb:63:in `load'
	from /usr/gem/gems/bundler-2.1.4/lib/bundler/cli/exec.rb:63:in `kernel_load'
	from /usr/gem/gems/bundler-2.1.4/lib/bundler/cli/exec.rb:28:in `run'
	from /usr/gem/gems/bundler-2.1.4/lib/bundler/cli.rb:476:in `exec'
	from /usr/gem/gems/bundler-2.1.4/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	from /usr/gem/gems/bundler-2.1.4/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	from /usr/gem/gems/bundler-2.1.4/lib/bundler/vendor/thor/lib/thor.rb:399:in `dispatch'
	from /usr/gem/gems/bundler-2.1.4/lib/bundler/cli.rb:30:in `dispatch'
	from /usr/gem/gems/bundler-2.1.4/lib/bundler/vendor/thor/lib/thor/base.rb:476:in `start'
	from /usr/gem/gems/bundler-2.1.4/lib/bundler/cli.rb:24:in `start'
	from /usr/gem/gems/bundler-2.1.4/exe/bundle:46:in `block in <top (required)>'
	from /usr/gem/gems/bundler-2.1.4/lib/bundler/friendly_errors.rb:123:in `with_friendly_errors'
	from /usr/gem/gems/bundler-2.1.4/exe/bundle:34:in `<top (required)>'
	from /usr/local/bin/bundle:25:in `load'
	from /usr/local/bin/bundle:25:in `<main>'
make: *** [Makefile:45: build] Error 1

I assume that the /srv refers to inside the Docker image, right? In fact, nothing is produced in the installation /srv/ directory. I've tried to change its permissions, but the same error persists.
OS: Ubuntu 22.10
Docker version: Docker version 20.10.16, build 20.10.16-0ubuntu1

The problem is a mismatch between the local user (UID=1001, GID=1001) and the jekyll user (UID=1000, GID=1000) inside the Docker image. If their ids match, this error should not be observed.


Working

👷 Deploy Preview for vargas-work-portfolio processing.

Name
Link

🔨 Latest commit
a06e2f1d3d5dd1d8cbed8c542931051ac6dd064a

🔍 Latest deploy log
https://app.netlify.com/sites/vargas-work-portfolio/deploys/64e3ddbb6e2df10007e14b1f


Meeting notes from August 9th

This is not an issue per se, but rather a summary of the feedback and idea we received yesterday from Niko, Jack, Joanna, Johannes and Xiang, so we can decide on the future directions.
Distances and tree summary statistics

MP3 seems to be too noisy for our purposes.
We need to decide on good distance to use. Perfectly, interpretable and which makes sense for downstream applications as:

Is the order of mutations $A$ and $B$ preserved? (Some variations on the A–D distance).
Are the pathways preserved? (Some variations on DL distance; with applications for TreeMHN in mind. Perhaps some solutions developed by string matching community would be applicable).
For developmental biology and cell clustering: how many clones exist? What are the lineages and how closely different cells are?

We considered also other summary statistic, as lengths of the paths (e.g., tree depth or median), node degrees.
Validate behavior of the distances by studying the distribution of it when the tree is modified. For example, let $k$ be some transition kernel (e.g., making some kind of move in the tree space with probability $1$). How does the distance distribution $d( \mathcal T, k^{(n)}(\mathcal T) )$ look like for different trees $\mathcal T$ and $n$, where $k^{(n)}(\mathcal T) = k(k(\dotsc k(\mathcal T)))$ is application of $k$ several times? How does it look like for "random" trees, where "random" is one of the several generative process we have considered?
Look for correlations/mutual information between the distances and the likelihood.

Evidence of multimodality or plateau

Seek for multimodality and plateau for smaller trees.
Check with C++ version whether the likelihood is calculated properly for the distinct trees with the same likelihood.
Loglikelihood just as a number does not usually make much sense (as any offset can be added), so we should report e.g., the loglikelihood of random trees as the reference (i.e., differences in loglikelihood make sense).
Consider looking at the acceptance probabilities of MCMC moves in the trace.
Implement method using multiple particles (SMC sampler or some parallel tempering), so understand multimodality issues.

Miscellaneous

False positive rate 0.1 is much too large. Reasonable "large" rates include $10^{-4}$, $10^{-5}$, or, for whole exome sequencing, $10^{-2}$.
Longer runs (than 100,000) may be required to achieve good convergence. Take a look at the SCITE paper to find the figure giving some intuition on it.
Show summaries over several different tree topologies, rather than one fixed tree, to understand the variation caused also by tree selection, rather than just cell sampling.
Consider better ways of generating the trees and cells:

We can perhaps use Robert Noble's tree topologies as examples.
We can enforce some clonal mutations.
We can generate deeper trees by preferential attachment of nodes to trajectories/Chinese restaurant process/Pitman-Yor process.
We can attach cells only to leaves.
Or we can have "attachability" which is a function of depth. (The deeper the more likely that a cell attached there would survive).

Additions:

Investigate the potential positive bias of HUNTRESS, with trees and mutation matrices in the same order, and consider scrambling the order of mutations in the mutation matrix w.r.t. the tree - concern voiced by Jack
Remove claim in repo README that PYggdrasil can be used for copy number inference

These are quite a lot of ideas on what to enhance and investigate. - With SMC this becomes quite the strategic choice what we want to do in the remaining time.

Also regarding the choice of Tree-Tree similarities - I see the following passage from the HUNTRESS paper in a new light now:

Although it does not necessarily always return an optimal output matrix
(that is, closest to the input matrix I in terms of the total number of 0 → 1 flips),
we show that, if some reasonable assumptions are satisfied, the tree implied by the
output matrix, with high probability, matches the ground truth with perfect DL
accuracy measure (that is, two mutations belonging to different lineages in the true
tree also belong to different lineages in the tree implied by the solution returned
from the algorithm) and any pair of mutations that have an AD relationship in
the ground-truth tree will be either in AD order in the inferred tree or clustered
together (that is, reported as present in the same set of cells).

They cite the same motivations for AD and DL that Niko stressed yesterday. - Perhaps their choice was more prudent than I thought.

I think these issues have been sufficiently addressed. Let's archive this issue as the writing up phase start now.


viewWillDisappear not being calling

viewWillDisappear is not being called when page changes.

@StefanLage  ViewWillAppear is also never called


Allow rippled to be compiled as C++17 on mac OS with Xcode

With these few changes I can compile rippled using C++17 on mac OS using Xcode 9.4.1 and Boost 1.67.0.  I selected C++17 by changing the cxx_std_14 in CMakeLists.txt to cxx_std_17.

The change in PaySteps.cpp was prompted by a build error that came from the boost range library.  Boost was looking for the std::random_shuffle algorithm which is no longer in the standard library as of C++17.  The simplest solution was to convert the three uses of boost::range::find(_if) to simply use std::find(_if).

The change in ripple/beast/cxx17/type_traits.h was to guard the, now now duplicated, implementations of void_t and bool_constant using their standard-provided feature macros.  Without the guards the compiler gave errors about duplicate definitions.

With these changes I was able to build with both C++14 and C++17, pass the unit tests, and sync the server to the network.
I make no claims about whether other environments will be able to build using C++17 :wink:

Compiles and passes test on linux with clang 7 and c++-17

We should change the commit message. These chagnes aren't just specific to mac.

Jenkins Build Summary
Built from this commit
Built at 20181012 - 18:51:24
Test Results

Build Type
Log
Result
Status

msvc.Debug
logfile
1068 cases, 0 failed, t: 536s
PASS :white_check_mark:

gcc.Release -Dassert=ON, MANUAL_TESTS=true
logfile
1101 cases, 0 failed, t: 6m8s
PASS :white_check_mark:

docs, TARGET=docs
logfile
1 cases, 0 failed, t: 0m1s
PASS :white_check_mark:

gcc.Debug -Dcoverage=ON, TARGET=coverage_report, SKIP_TESTS=true
logfile
1071 cases, 0 failed, t: 16m32s
PASS :white_check_mark:

msvc.Debug, NINJA_BUILD=true
logfile
1068 cases, 0 failed, t: 557s
PASS :white_check_mark:

clang.Debug
logfile
1071 cases, 0 failed, t: 3m10s
PASS :white_check_mark:

rpm
logfile
1071 cases, 0 failed, t: n/a
PASS :white_check_mark:

clang.Debug -Dunity=OFF
logfile
1071 cases, 0 failed, t: 6m46s
PASS :white_check_mark:

gcc.Debug
logfile
1071 cases, 0 failed, t: 3m26s
PASS :white_check_mark:

gcc.Debug -Dunity=OFF
logfile
1071 cases, 0 failed, t: 2m24s
PASS :white_check_mark:

clang.Release -Dassert=ON
logfile
1071 cases, 0 failed, t: 5m39s
PASS :white_check_mark:

gcc.Release -Dassert=ON
logfile
1071 cases, 0 failed, t: 6m5s
PASS :white_check_mark:

gcc.Debug -Dstatic=OFF
logfile
1071 cases, 0 failed, t: 3m27s
PASS :white_check_mark:

msvc.Debug -Dunity=OFF
logfile
1068 cases, 0 failed, t: 1189s
PASS :white_check_mark:

gcc.Debug -Dstatic=OFF -DBUILD_SHARED_LIBS=ON
logfile
1071 cases, 0 failed, t: 3m26s
PASS :white_check_mark:

gcc.Debug, NINJA_BUILD=true
logfile
1071 cases, 0 failed, t: 3m3s
PASS :white_check_mark:

msvc.Release
logfile
1068 cases, 0 failed, t: 391s
PASS :white_check_mark:

clang.Debug -Dunity=OFF -Dsan=address, PARALLEL_TESTS=false, DEBUGGER=false
logfile
1071 cases, 0 failed, t: 1m21s
PASS :white_check_mark:

clang.Debug -Dunity=OFF -Dsan=undefined, PARALLEL_TESTS=false
logfile
1071 cases, 0 failed, t: 3m50s
PASS :white_check_mark:

@scottschurr Which version of boost are you using? I just compiled with both boost 1.67 and 1.68 and c++-17 without problems.

Replaced nots with !.  Updated commit message to
Allow Clang 7 to compile rippled as C++17

Just for giggles, I tried building this branch in Visual Studio. It worked fine with cxx_std_14. When I changed it to cxx_std_17... not so much, but we're not changing that, so I don't have a problem.

Codecov Report

Merging #2718 into develop will increase coverage by 1.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2718      +/-   ##
===========================================
+ Coverage    69.44%   70.48%   +1.04%
===========================================
  Files          705      705
  Lines        60269    55476    -4793
===========================================
- Hits         41856    39105    -2751
+ Misses       18413    16371    -2042

Impacted Files
Coverage Δ

src/ripple/app/paths/impl/PaySteps.cpp
75.11% <100%> (ø)
:arrow_up:

src/ripple/protocol/SecretKey.h
77.77% <0%> (-11.88%)
:arrow_down:

src/ripple/core/impl/SociDB.cpp
63.79% <0%> (-8.58%)
:arrow_down:

src/ripple/crypto/impl/csprng.cpp
94% <0%> (-4.79%)
:arrow_down:

src/ripple/overlay/impl/OverlayImpl.cpp
29.21% <0%> (-4.73%)
:arrow_down:

src/ripple/app/misc/NetworkOPs.cpp
63.33% <0%> (-4.45%)
:arrow_down:

src/ripple/nodestore/backend/NuDBFactory.cpp
69.48% <0%> (-3.92%)
:arrow_down:

src/ripple/basics/StringUtilities.h
72.72% <0%> (-3.36%)
:arrow_down:

src/ripple/nodestore/backend/RocksDBFactory.cpp
56.02% <0%> (-3.06%)
:arrow_down:

src/ripple/overlay/Overlay.h
80% <0%> (-2.61%)
:arrow_down:

... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c3fc3...6aec293. Read the comment docs.

I'd re-write the commit message again. This now works on more than just clang. Still :+1: with the latest commit.

@scottschurr This patch should silence/resolve the warnings on windows: https://github.com/seelabs/rippled/commit/a20c0a16cf64e9c07425a1c8b7e442992e063a62
Two things to note:

We no longer define BOOST_NO_AUTO_PTR in the cmake file. I don't know the origional modivation for adding this, so it's a little risky to remove it. On the other hand, it's hard to see where removing it would cause problems. My guess is it was added to resolve past warnings.

Many of the warnings were not resolved, just silenced with _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS on windows. We should resolve them in a future PR

Still :+1: from me.

👍

Squashed and marked as passed.  Thanks for all the help everyone.

in 1.2.0-b4 as a999894da


Container param cleanup + remove qkv_merging

This PR cleans up some container items and removes an unused qkv_merging parameter:

Remove qkv_merging=True from BERT containers
Change containers config object to ds_model_config
Remove qkv_merging param

Let's also link the other PR that removes quantize_scales, quantize_groups, etc. since we deferred removing those in this PR.


Hoop (hoop.photo)

Backstory
Hoop is an app where you can find friends on Snapchat, sort of like Tinder.
You get diamonds for watching ads, inviting friends, …, and can spend them by swiping on people. A couple of my friends had it, so I tried it out as well, but decided to delete my account.
I noticed that when deleting your account, it says that the app will exit once the account is deleted. Their privacy policy says the data will be stored until the user prompts deletion. After doing some testing, I noticed that the app does exit… but your data isn't deleted. People you swiped on can still see you, your diamonds are kept, …
Thus, it's possible to delete your account, but they don't actually delete your data. Just your photos and birthdate. This is contrary to what their privacy policy states, so maybe worth noting below.
Their support team is also to no use and ignored my questions.
Data

name: Hoop
url:
url_CODE:
difficulty: impossible
notes: Account > gear icon > delete account > delete; this only removes some of your account data, not all. There is no way to remove the other data.
email:
email_subject:
email_body:
domains: hoop.photo

Thanks for reporting, I've opened #1046 to incorporate your suggestion :)


[Jenkins CI] Broken R unit test : test_img_seg

@thirdwing
One of the R unit tests is failing in the Jenkins CI.
Looks like the issue is due to the installation of package failing.
Master builds are failing. Can you please take a look at the issue?
Build Failure Log Link -
https://builds.apache.org/blue/organizations/jenkins/incubator-mxnet/detail/master/276/pipeline
Error Output:
Failed -------------------------------------------------------------------------

Error: UNET (@test_img_seg.R#93) --------------------------------------------
trying to use CRAN without setting a mirror
1: install.packages(new.packages) at R-package/tests/testthat/test_img_seg.R:93
2: grep("^file:", contriburl)
3: contrib.url(repos, type)
4: stop("trying to use CRAN without setting a mirror")

DONE ===========================================================================
Error: Test failures
Execution halted
make: *** [rpkgtest] Error 1
script returned exit code 2

CI passed now: https://builds.apache.org/blue/organizations/jenkins/incubator-mxnet/detail/PR-7674/1/pipeline


web3swift.Web3Error.processingError("Failed to fetch nonce")

When I try to transfer token to another account, why is it always this error
web3swift.Web3Error.processingError("Failed to fetch nonce")
let url = URL.init(string: nodeAddress)
            let web3 = Web3(url: url!)
            let walletAddress = EthereumAddress(fromAddress) // Your wallet address
            let toAddress = EthereumAddress(toAddress)
            let erc20ContractAddress = EthereumAddress(contractAddress)
            let amount = Web3.Utils.parseToBigUInt(amount, units: .eth)
            var options = Web3Options.defaultOptions()
            options.value = amount
            options.from = walletAddress
            options.to = toAddress
            options.gasLimit = try web3?.eth.getBlockNumber()
            options.gasPrice = try web3?.eth.getGasPrice()
            let method = "transfer"
            guard let tokenContract = try web3?.contract(Web3.Utils.erc20ABI, at: erc20ContractAddress) else {
                print("error no created token address")
                return
            }
            let parameters = [toAddress as AnyObject, amount as Any] as [AnyObject]
            let transactionContract = try tokenContract.method(method, parameters: parameters, options: options)
            transactionContract.transaction.nonce = try (web3?.eth.getTransactionCount(address: Address(fromAddress)))!
            let results = try transactionContract.send(password: pass, options: options, onBlock: "")

Hello. Looks like you didn't send transaction before fetching nonce. Try to switch last 2 strings in your example.

Feel free to reopen the issue, if you still need help. 👍

Hi there,
This seems like a great library - thanks so much for providing!
I am also facing this error: 'Fatal error: 'try!' expression unexpectedly raised an error: Web3swift.Web3Error.processingError(desc: "Failed to fetch nonce").'
I'm sure I'm just doing something silly - any assistance would be very much appreciated:
let web3 = Web3.InfuraMainnetWeb3()
let walletAddress = EthereumAddress(wallet!.address!)!
    let contractMethod = "approve"
    let DAIcontractAddress = EthereumAddress(daiAddressString)!
    let abiVersion = 2

    let approvalUnits = "1000"
    let approveAmount = Web3.Utils.parseToBigUInt(approvalUnits, units: .wei)!

    let approveAddress = EthereumAddress(erc20AddressString)!

    let parameters: [AnyObject] = [approveAddress as AnyObject, approveAmount as AnyObject] as [AnyObject]
    let extraData: Data = Data()
    let contract = web3.contract(Web3.Utils.erc20ABI, at: DAIcontractAddress, abiVersion: abiVersion)!
    var options = TransactionOptions.defaultOptions
    options.from = walletAddress
    options.gasPrice = .automatic
    options.gasLimit = .automatic
    let tx = contract.write(
        contractMethod,
        parameters: parameters,
        extraData: extraData,
        transactionOptions: options)!

    _ = try! tx.send(password: password)

@alexandermucalov, sometimes it happens with infura issues. Ping me in the telegram, we can debug it, and I can provide you more support with this!


Merge editor: TypeScript type errors do not appear

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.87.0
OS Version: macOS 14.2.1 (23C71)

Steps to Reproduce:
Install TypeScript and create main.ts with contents:
export const add1 = (n: number) => n + 1;

add1(2)

Copy and apply the following patch e.g. using pbpaste | git apply -3. This will result in a conflict.
diff --git a/main.ts b/main.ts
index 4885bfc..bfd86b9 100644
--- a/main.ts
+++ b/main.ts
@@ -1,3 +1,4 @@
 export const add1 = (n: number) => n + 1;

+// foo
 add1(1)

Open the conflict in VS Code's merge editor.
Resolve the conflict but purposefully create a type error.
Expected: the type error should appear.
Actual: the type error does not appear. The type error only appears if I open the file outside of the merge editor.
https://github.com/microsoft/vscode/assets/921609/2b6763b2-d725-4f1b-82d2-16c4355b9671

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.87.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Does not reproduce:


common test cases for emqttd application

hi, do you write example using mysql auth plugin yet?

yes. I tagged 0.7.0 last weekend, and will commit the plugin today.

add more test cases if issues found. close this issue.


Adding algorithm TD Learning with N-Tuple Networks for 2048

An algorithm that can win at 2048 without using tree search or hand crafted state evaluator functions.
Currently the code is somewhat coupled with 2048. It is possible to decouple it, if that is valuable for open_spiel. Will have to find a way to move n_tuples into game.
Have modified the game 2048 to consider a move that doesn't change the board as invalid
Implementation is similar to https://github.com/moporgic/TDL2048-Demo

Cool! We had quite a big refactor committed to the master branch yesterday. Could you pull changes from master and commit the merge (or rebase)?
We basically just moved all the games into subdirectories.
I cannot run the tests while there are conflicts.

Sure. Rebased now 👍🏻

@lanctot

Used pylint and formatted the code
Introduced a class NTupleNetwork and added a brief description about what N-Tuples are and a citation to a IEEE paper that this implementation is based on
The output of the code is very straightforward similar to breakthrough_dqn.py in that for every 1000 runs; the code prints what's the average score reached, max score and largest tile that was unlocked. Running the code you can see the average scores increasing indicating that learning is happening. Once the 2048 tile is unlocked, the agent is able to win the game

Hi @Jazeem,
Can you respond to the conversations above (or resolve them now if they are resolved)

@lanctot
Have resolved them


Flutter support

I noticed that the library supports Kotlin and Swift. I wanted to ask if it is possible to use it on a Flutter application? If not, are you thinking on supporting it in the future? In case that it is possible, could you elaborate on how one could do it?

hi @Filipe3xF!
Honestly saying, last time we have reviewed the idea of packaging for Flutter a year ago or so. At that moment, we haven't dive deep and decided to postpone Flutter.
Right now we are working (almost done!) on React Native wrapper.
Flutter might be the next one. But there are challenges that we haven't researched yet: as Themis depends on OpenSSL / BoringSSL, we don't know how Flutter packets handle dependencies-of-dependencies (you have app, you add Themis-Flutter, which adds OpenSSL). Do people use static or dynamic linking for adding dependencies-of-dependencies, etc.
It would help us A LOT if you know examples of good Flutter libraries that you like. Especially if those libraries were ported from native (i.e. native iOS and native Android lib ported as one Flutter package).

@vixentael
In essence, that's not about Flutter support but Dart support. Dart has boringssl_gen repo. However, I've never used it before. I'd be interested in helping you to add Dart support. Just let me know where to start.

@minikin Hello, I have a large deal of dart experience. I would like to collaborate to bring this library to Flutter/Dart, as I am working on a cross platform e2e messaging app. My largest problem is finding two separate libraries that operate on the same specifications. I currently have a Python Django server that uses Cryptography, which is based mainly on RFC 3447, whereas the library I am using with Flutter is PointyCastle, however their library is based on RFC 2437 making the two incompatible is some areas. It is quite the struggle to find a consistent, cross platform, and modern Cryptography library for Flutter/Dart. If someone would like to collaborate on this, please let me know.


Memory Leak

Dear all,
Here is a sample code that will raise a MemoryError after a few seconds :
import numba, numpy
def leak(x):
    @numba.jit
    def since(a):
        out = numpy.zeros(a.shape)
        last = numpy.zeros(a.shape[1])
        for i in range(a.shape[0]):
            for j in range(a.shape[1]):
                if a[i, j]: last[j] = i
                out[i, j] = i - last[j]
        return out
    y = since(x)
data = numpy.random.randn(1e7, 2)
while True: leak(data)

At least on my setup :
Windows 7 64bits, Python 3.3.4 64bits (Miniconda build), Numba 0.13.2
What will fix the leakage :

removing the jit decorator (plain python)
moving the decorator outside of the leak function
calling the decorated function without storing the result (remove 'y = ')

What will not :

gc.collect() at various stages.

Best regards,

Closing this issue as no new information has been provided. As of 0.44, the above marginally consumes more memory as time goes by, but that's probably expected given the use case.
It is assumed that the above resolved the reported issue, if this is not the case please reopen the issue with new information. Many thanks.


Replace is_array with Puppet 4 native comparision

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Thanks!


Update Architecture Overview

This page is our 4th-most-visited page overall, and it needed some attention.
Summary of changes:

Add more links to terms and things that have docs now.  Most didn't have docs yet when this page was added.

Move the giant glossaries to the bottom of the page so readers can get through the Overview section first (that section is kind of the whole point of this page's existence, and sticking a glossary in the middle was breaking the flow of the page).

TODO:

[ ] port to previous supported versions

Hi @taroface I know this is kinda unplanned work.  I think this PR is from when you were on vacation. Mind taking a look?


Enabling breakpoints with using path module to resolve paths correctly

Using process.env.CWD has buggy side effects because many applications might have to switch the current working directory to another directory to fetch or serve different files. I noticed this when I wanted to add breaking points to the project with VScode.
Now with using path module everything works as it should and I can use breakpoints in the Typescript files 😼
I can demo this if you are not familar with VScode debugging tool :)

Thanks!


Add methods to create Translations with different plural rules

gettext/gettext currently can extracts strings from source files, thus creating an dictionary of translations (in GNU-gettext terms it may be seen as a POT - Portable Object Template - file).
When creating translations for other languages, we may need to change the plural count of the translations. So, let's introduce this new setPluralCount method.
For instance, here's a whole process to create two translation (.po) files, one for Russian (3 plural rules) and one for Japanese (1 plural rule):
$pot = \Gettext\Translations::fromPhpCodeFile($file);
$ruPo = clone $pot;
$ruPo->setPluralCount(3);
$jaPo = clone $pot;
$jaPo->setPluralCount(1);

The number of plurals is defined on export to po format (for example: https://github.com/oscarotero/Gettext/blob/master/tests/files/po.po#L11) so I'm not sure about this change, because it's a gettext specific rule, and this library tries to be something more abstract that fits more formats. I think a better approach is generate this empty values on export to po, according with the plural form header. For example:
$pot = \Gettext\Translations::fromPhpCodeFile($file);

$pot->setHeader('Plural-Forms', 'nplurals=3; ...');
$pot->toPoFile('locales/ru/locales.po');

$pot->setHeader('Plural-Forms', 'nplurals=1; ...');
$pot->toPoFile('locales/ja/locales.po');

This avoid duplications and possible bugs, for example:
$pot = \Gettext\Translations::fromPhpCodeFile($file);

$pot->setHeader('Plural-Forms', 'nplurals=3; ...');
$pot->setPluralCount(2);  //this is wrong because does not match with the plural-forms header

IMHO it's quite wrong to fix the number of plural rules just when exporting. What if we'd need to translate Russian or Japaneese from strings that have been extracted with fromPhpCodeFile? We'd need to set the plural rule of the Translations instance, save it, reload it and allow translations to be modified... Not so smart.
Furthermore, we could integrate the plural rules into Gettext. I'm currently developing a helper class to accomplish that (see https://github.com/mlocati/concrete5-translation-library/blob/pot-are-different-from-po/src/Gettext.php ). But it'd be useful for others to have such a function. So, we may have something lime this:
$pot = \Gettext\Translations::fromPhpCodeFile($file);
$po = $pot->createLanguageTranslations('it');

That createLanguageTranslations could set the number of plurals as well as adding the Language and Plural-Forms headers... Really useful!

Ok, I understand your point. I think the language must be managed from the Translations class, affecting not only to each translation but also the header, to avoid inconsistencies. For example:
$po = \Gettext\Translations::fromPhpCodeFile($file);
$po->definePlural(2, 'plural=(n != 1)');

$po->getHeader('Plural-Forms'); // nplurals=2; plural=(n != 1)

Your helper class is great. If you don't mind, I'll include in my library because it's really usefull

:ok: Sure!
We could add two new methods to set plural number/stuff.
One automatic method that accepts a language code and uses the data taken from my library. It returns false if the language code is unknown.
The second method is the one that you suggested above...

Yes, that's what I was thinking. I merge your PR before add these functions.


App.html should be treated as entry component when loading from gist

i.e., it shouldn't be possible to delete it (only clear it)

Ha I just came here to report this bug. It looks like we can rely solely on the filename for this.
Relatedly, the REPL should probably disallow multiple files with the same name. If you create another App.html, it looks like that one overrides the first one in the REPL. And later ones are going to override earlier ones when saving to a gist.

Both excellent points. We should also sort the files deterministically (probably App.html first, then alphabetical) since I'm not sure the order is in any way guaranteed

ha I missed you'd already PR'd this. nice, thanks 👍


'watch' and 'unwatch' as event names crash socket.io on Firefox

You get the bug with :
socket.on('unwatch', function(...

Why Firefox ? Probably because the new Object.prototype.watch() and Object.prototype.unwatch() are only implemented on Firefox.
A call to  hasOwnProperty might be missing somewhere.

This seems the problem of component-emitter. It keeps event listeners in an object, but watch and unwatch are methods actually, so this error happens.
https://github.com/component/emitter/blob/master/index.js#L45
TypeError: undefined is not a function {stack: (...), message: "undefined is not a function"}

The same problem occurs on other browsers too when you use another reserved key like constructor.
socket.on('constructor', function() {});

Great find


Update this to Psych Engine 0.7.3

Describe your bug here.
I'm writing this because I want to use certain 0.7.3 mods on this but most of them aren't supported on 0.7.1.
Steps to reproduce this bug.
Idk just do the best you can.
Command Prompt/Terminal logs
No response
Have you modded the build?
Yes, using Mods
If you edited anything in this build, mention or summarize your changes.
No response
What is your platform?
Windows

open issue to upstream, not to here


Dynamic presets based on path-parameters.

When serving images on a website the width of the device screen could be used to determine the width needed for the image.
The only way that I'm aware of to transport the wanted width of the image to spacechop is via url parameters. This introduces a security risk as now anyone can request the same image, but with a different width-parameter and overload the service.
One solution to this is to set rules for these parameters in the configuration. Say, in the previous example, that we want pretty high cache hits and therefore (on the client) rounds the device width to something divisible by 100. This validation can, in addition to the client, be done in spacechop.
How this might look in the configuration:
paths:
  - "/:preset/:_width/:image(.*)

dynamic_parameters:
  _width:
    divisible_by: 100

presets:
  my_dynamic_preset:
    steps:
      - $crop:
          width:
            dynamic: _width

divisible_by could be one of several validators that can be used in combination to lower the amount of possible values a dynamic parameter can take.

Wouldn't this be open to url spamming anyway?
https://url/width=100
101..149 returns width 100 (~50 requests, altho cached)
150..199 returns width 200 (~50 requests, altho cached)
https://url/width=200
etc...
? dno :)

I mean that if you dont provide a width that is divisble by 100 (101..149 etc) the service should respond with 404 or something like that.
So in addition to doing the rounding on the client to obtain an url, the service can enforce those "roundings".

how about using path_to_regex (v2.0.0) pattern:
paths:
  - /:preset/:width(100|200|300|400)/:image(.*)

presets:
  my_dynamic_preset:
    steps:
      - $crop:
          width: width
`
``

@ericwenn ah, got it

"I love it, especially late in the summer" 💃

Another alternative, that @Frexuz talked about earlier, is using a hash as a token, to ensure that only authorized users can use custom parameters. This is how Thumbor does it. It could look like this: http://example.com/my-dynamic-preset/width=200?t=JuywQ78hj==
It means there is less config needed to be done, but also harder to implement on the client. And if anyone gets a hold of the secret needed for the hash they can still overload the service.

@ericwenn should we create another issue for security using tokens? I'm not sure

PR is ready for review now

@timbrandin I think we should put security via tokens on hold for now.


🐛 [cloud_firestore] A problem occurred evaluating root project 'cloud_firestore' (cannot build appbundle)

Bug report
Since upgrading to the most recent version of flutter stable, I cannot build an appbundle with cloud firestore.
* What went wrong:
A problem occurred evaluating root project 'cloud_firestore'.
> Could not find the firebase_core FlutterFire plugin, have you added it as a dependency in your pubspec?

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
A problem occurred configuring root project 'cloud_firestore'.
> compileSdkVersion is not specified.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================

* Get more help at https://help.gradle.org

BUILD FAILED in 1s

The plugin cloud_firestore could not be built due to the issue above.

C:\Users\miles\IdeaProjects\ironsight_mobile>

Steps to reproduce
flutter build appbundle on flutter version 2.0.1 (most recent stable release)

Flutter doctor
C:\Users\miles\IdeaProjects\ironsight_mobile>flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 2.0.1, on Microsoft Windows [Version 10.0.19041.804], locale en-CA)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[√] Chrome - develop for the web
[√] Android Studio (version 4.1.0)
[√] IntelliJ IDEA Community Edition (version 2019.1)
[√] VS Code (version 1.53.2)
[√] Connected device (3 available)

This is not an issue with any of the plugins
AAPT: error: unexpected element <queries> found in <manifest>

This error message means your grade plugin version is out of date.
See https://android-developers.googleblog.com/2020/07/preparing-your-build-for-package-visibility-in-android-11.html


Refactor tag filtering

Tag filtering was missing for private repositories. Break tag filtering
out into a function and use it for both docker-hub and private repos.

Whoops.  This introduces a bug.


Added Meshery design embed extension to Meshery-UI

Notes for Reviewers
This PR fixes #11864
Added Meshery-design-embed to Meshery-UI.

Signed commits

[x] Yes, I signed my commits.

Thank you @Aviral0702, let's discuss this PR during the Meshery dev meeting call, if you would. Adding it as an agenda item to the meeting minutes.
Timing: 7:30 PM IST / 9:00 AM CT (Wednesday)
Meeting minutes: Google Doc
Meeting link: meet.layer5.io/meshery


Prettier-eslint support

Would it be possible to integrate support prettier-eslint? Or at least have some pointers to know what it would take to make a PR to support it 😊

prettier-eslint has a lot of extra configurability that I don't think the minimal API that this module uses can support.  https://github.com/prettier/prettier-eslint#options
I'd be interested to hear a proposal for a way we could make it work with no extra config!

Ideally it would just invoke the format method of prettier-eslint with the default options, leaving the configuration up to the user's .eslintrc file. From what I can see in the doc of prettier-eslint, by default it will find the proper eslint/prettier configuration files for the given files so I feel like you would not have to pass a lot of options?
https://github.com/prettier/prettier-eslint#eslintpath-string
https://github.com/prettier/prettier-eslint#prettierpath-string

I guess no progress was made on this as of yet?

Lack of prettier-eslint support is currently my blocker for using pretty-quick. Just invoking with defaults and handling configuration externally, would be absolutely fine and shouldn't be too disruptive. Would you consider a PR if there were no other externally visible changes to pretty-quick aside from an option to use prettier-eslint instead of plain prettier?

You can achieve similar functionality using just prettier-eslint module. I use the following configuration:
"lint-staged": {
    "app/**/*.{js,jsx}": [
      "eslint --fix",
      "prettier-eslint --config .prettierrc.json --write",
      "git add"
    ]
  },
  "husky": {
    "hooks": {
      "pre-commit": "lint-staged"
    }
  }

I use the following yaml config with lint-staged in order to work with prettier-eslint:
"app/{src,cypress}/**/*.{js,tsx,ts,jsx}":
  - cd app && yarn prettier-eslint '$@' --write --prettier-last

In order for the above to work, I use the following command to run lint-staged:
npx lint-staged --shell /bin/sh

It will be done in https://github.com/prettier-eslint/prettier-plugin


Buttons wrapped in Swedish GUI

Strings should probably be shortened to prevent break. Will fix.

Thanks! Will work on the other issue today


Add fundrawtransaction

Adds fundrawtransaction RPC call. Includes the following from Bitcoin Core:
https://github.com/bitcoin/bitcoin/pull/6088 - fundrawtransaction
https://github.com/bitcoin/bitcoin/pull/6417 - [QA] fix possible reorg issue in (fund)rawtransaction(s).py RPC test
https://github.com/bitcoin/bitcoin/pull/6444 - Exempt unspendable transaction outputs from dust checks
https://github.com/bitcoin/bitcoin/pull/6415 - Implement watchonly support in fundrawtransaction
https://github.com/bitcoin/bitcoin/pull/6828 - [rpc-tests] fundrawtransaction: Update fee after minRelayTxFee increase
commit bebe58 from https://github.com/bitcoin/bitcoin/pull/7296
https://github.com/bitcoin/bitcoin/pull/7506 - Use CCoinControl selection in CWallet::FundTransaction
https://github.com/bitcoin/bitcoin/pull/7518 - Add multiple options to fundrawtransaction
https://github.com/bitcoin/bitcoin/pull/7967 - [RPC] add feerate option to fundrawtransaction
Includes the updates up until their test framework supported python3. There are more changes that should be ported over after this.

Awesome!  With this we can supporting atomic tools like atomic swaps https://github.com/decred/atomicswap/pull/37


Disable consistent-return

Causing too many errors on async callback functions that should not be
affected by inconsistent returns.

:+1:

:100:


Use depth pass mode with normals if required, even if Environment is null

If using normal buffer debugging or if the normal texture was used, we should use PASS_MODE_DEPTH_NORMAL_ROUGHNESS regardless of whether there is a valid Environment or not. Otherwise, shaders reading the normal texture will not work without a valid Environment (and possibly other problems), even though we don't actually need to use one.

Fixes #75794

Thanks!


update vm sample

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check for Azure.ResourceManager.Compute
API changes are not detected in this pull request for Azure.ResourceManager.Compute


UnboundLocalError: local variable "video_path" referenced before assigment

Hi, I am trying to replicate your experiments on ActivityNet using VideoLLaMA2-7B model on a single A100 GPU. Here is the command I run:
python videollama2/eval/inference_video_oqa_activitynet.py --model-path DAMO-NLP-SG/VideoLLaMA2-7B --video-folder eval/Activitynet_Zero_Shot_QA/all_test/ --question-file eval/Activitynet_Zero_Shot_QA/test_q.json --answer-file eval/Activitynet_Zero_Shot_QA/test_a.json --output-file eval_output/Activitynet_Zero_Shot_QA/answers/VideoLLaMA2-7B/pred.json --num-chunks 1 --chunk-idx 0 --num-workers 1

I got the following error when running the inference script:
Traceback (most recent call last):
  File "/mnt/ceph_rbd/VideoLLaMA2/videollama2/eval/inference_video_oqa_activitynet.py", line 148, in <module>
    run_inference(args)
  File "/mnt/ceph_rbd/VideoLLaMA2/videollama2/eval/inference_video_oqa_activitynet.py", line 105, in run_inference
    for i, (video_tensors, video_names, questions, question_ids, answers) in enumerate(tqdm(dataloader)):
  File "/mnt/ceph_rbd/miniconda3/envs/videollama2/lib/python3.10/site-packages/tqdm/std.py", line 1181, in __iter__
    for obj in iterable:
  File "/mnt/ceph_rbd/miniconda3/envs/videollama2/lib/python3.10/site-packages/torch/utils/data/dataloader.py", line 631, in __next__
    data = self._next_data()
  File "/mnt/ceph_rbd/miniconda3/envs/videollama2/lib/python3.10/site-packages/torch/utils/data/dataloader.py", line 1346, in _next_data
    return self._process_data(data)
  File "/mnt/ceph_rbd/miniconda3/envs/videollama2/lib/python3.10/site-packages/torch/utils/data/dataloader.py", line 1372, in _process_data
    data.reraise()
  File "/mnt/ceph_rbd/miniconda3/envs/videollama2/lib/python3.10/site-packages/torch/_utils.py", line 722, in reraise
    raise exception
UnboundLocalError: Caught UnboundLocalError in DataLoader worker process 0.
Original Traceback (most recent call last):
  File "/mnt/ceph_rbd/miniconda3/envs/videollama2/lib/python3.10/site-packages/torch/utils/data/_utils/worker.py", line 308, in _worker_loop
    data = fetcher.fetch(index)
  File "/mnt/ceph_rbd/miniconda3/envs/videollama2/lib/python3.10/site-packages/torch/utils/data/_utils/fetch.py", line 51, in fetch
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/mnt/ceph_rbd/miniconda3/envs/videollama2/lib/python3.10/site-packages/torch/utils/data/_utils/fetch.py", line 51, in <listcomp>
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/mnt/ceph_rbd/VideoLLaMA2/videollama2/eval/inference_video_oqa_activitynet.py", line 64, in __getitem__
    print("video path: ", video_path)
UnboundLocalError: local variable 'video_path' referenced before assignment

Could you help troubleshoot this issue?

Please check if the position of the video folder actually have the video file. If the video file is not existed, the video_path variable is not initialized, which causes this error.

Thanks for your reply! I have already put all the 500 test videos in the specified path but still have this issue.

Hi! Can you attempt the new inference script in the latest commit. It prints some debug string, which may help you solve this issue.

Thanks for your reply! I have already put all the 500 test videos in the specified path but still have this issue.

Hello,I'm a phD student from ZJU, I also use videollama2 to do my own research,we create a WeChat group to discuss some issues of videollama2 and help each other,could you join us? Please contact me: WeChat number == LiangMeng19357260600, phone number == +86<PHONE_NUMBER>0,e-mail ==<EMAIL_ADDRESS>


Update faq.yml

@mcleanbyron

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@jimmyca15 @drago-draganov, please let me know if this looks reasonable to you.

#sign-off

#sign-off


Highlight request/response bodies based on content type

A small change to the request/response Body sub-tab to highlight bodies based on the Content-Type header (e.g. use JSON syntax highlighting if the header indicates application/json).  Highlighting is done only for a set of well-known content types (easily added to as needed).

Associated with #131.

Small comment about the placement of some code. But no major blocker.


For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingAds/hint-message/create-hint-message.md
:white_check_mark:Succeeded

BingAds/hint-message/reference.md
:white_check_mark:Succeeded

BingAds/hotel-feed/create-hotel-feed.md
:white_check_mark:Succeeded

BingAds/hotel-feed/reference.md
:white_check_mark:Succeeded

BingAds/hotel-service/get-started.md
:white_check_mark:Succeeded

BingAds/hotel-service/hotel-api.md
:white_check_mark:Succeeded

BingAds/hotel-service/manage-hotel-campaigns.md
:white_check_mark:Succeeded

BingAds/hotel-service/reference.md
:white_check_mark:Succeeded

BingAds/hotel-service/reporting.md
:white_check_mark:Succeeded

BingAds/pos-feed/create-pos-feed.md
:white_check_mark:Succeeded

BingAds/pos-feed/reference.md
:white_check_mark:Succeeded

BingAds/query-control-message/create-query-control-message.md
:white_check_mark:Succeeded

BingAds/query-control-message/reference.md
:white_check_mark:Succeeded

BingAds/query-message/reference.md
:white_check_mark:Succeeded

BingAds/scripts/concepts/selectors.md
:white_check_mark:Succeeded

BingAds/scripts/guides/single-account-access.md
:white_check_mark:Succeeded

BingAds/scripts/reference/AdGroup.md
:white_check_mark:Succeeded

BingAds/scripts/reference/AdGroupBidding.md
:white_check_mark:Succeeded

BingAds/scripts/reference/AdGroupBuilder.md
:white_check_mark:Succeeded

BingAds/scripts/reference/AdGroupSelector.md
:white_check_mark:Succeeded

BingAds/scripts/reference/AdGroupUrls.md
:white_check_mark:Succeeded

BingAds/scripts/reference/AdParam.md
:white_check_mark:Succeeded

BingAds/scripts/reference/BingAdsDate.md
:white_check_mark:Succeeded

BingAds/scripts/reference/Budget.md
:white_check_mark:Succeeded

BingAds/scripts/reference/Campaign.md
:white_check_mark:Succeeded

BingAds/scripts/reference/CampaignSelector.md
:white_check_mark:Succeeded

BingAds/scripts/reference/CampaignUrls.md
:white_check_mark:Succeeded

BingAds/scripts/reference/Keyword.md
:white_check_mark:Succeeded

BingAds/scripts/reference/KeywordBidding.md
:white_check_mark:Succeeded

BingAds/scripts/reference/KeywordBuilder.md
:white_check_mark:Succeeded

BingAds/scripts/reference/KeywordSelector.md
:white_check_mark:Succeeded

BingAds/scripts/reference/KeywordUrls.md
:white_check_mark:Succeeded

BingAds/scripts/reference/Logger.md
:white_check_mark:Succeeded

BingAds/scripts/reference/NegativeKeywordList.md
:white_check_mark:Succeeded

BingAds/scripts/reference/NegativeKeywordListBuilder.md
:white_check_mark:Succeeded

BingAds/scripts/reference/NegativeKeywordListSelector.md
:white_check_mark:Succeeded

BingAds/transaction-message/get-started.md
:white_check_mark:Succeeded

BingAds/transaction-message/reference.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add commas in expect.objectContaining doc

Codecov Report

Merging #3787 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3787   +/-   ##
=======================================
  Coverage   57.58%   57.58%
=======================================
  Files         194      194
  Lines        6776     6776
  Branches        6        6
=======================================
  Hits         3902     3902
  Misses       2871     2871
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e170a...0f1f3b0. Read the comment docs.

Thanks!


Add tests for Hive Activate ClusterDeployment

Signed off by: @jnpacker

Add tests for package create, hive.go
Used to activate clusterdeployments
Modify err returns from this method
Fix one CodeSmells

/cc @hanqiuzh @leena-jawale @itdove

Reference: https://github.com/open-cluster-management/backlog/issues/9908

/approve
/lgtm


App publishers should be able to receive emails when people leave reviews of their app

And quite possibly this should be enabled by default, lest no one will ever discover it or learn that someone wrote back about their app.

There is a valid question of how someone should be able to respond or reply to a commenter, somehow, at some point. I saw one comment on an app I published that's, as far as I know, inaccurate. While I don't really expect to respond visibly on the store page, I'd at least like a handy way to send the commenter an answer or clarification that they'd get by email?


fix: add vocalization for each message

This should resolve #1152 though needs to be tested.

I think this is what @kevmo314 was referring to @SputNikPlop.
Can you take a look at the changes I just added to #1162 and let me know if it looks like this is going down the correct path?

@kevmo314 can you take a look at the latest changes and let me know how things are looking?


0.3.0 Incorrect Controller Detected

My "Retrolink SNES Controller" is being detected as "Retrolink Saturn Classic Controller".
When I run the SDL2 Gamepad Tool I can see that the correct mapping exists:
"Retrolink SNES Controller",<PHONE_NUMBER>0000001100000010010000 (mapping available)

I searched the gamecontrollerdb.txt just to make sure, and it does in fact exist.
line 533
Also, is there a gradle task for running the jamepad test app to debug locally?

The gamecontrollerdb.txt is from an older version of Jamepad.
I made a pull request to upgrade that version which should come with the updated controller mappings file.

Yeah it's correct, the db is from an older version. It's not needed to update Jamepad to change the db, the file is included in resources. However, I am not sure if the file format is still the same. Please try it.
By the way, if your controller is detected, it will have a working mapping. The name is probably just an older named used to market the hardware.

The mappings are unusable from the Saturn mappings.
I copy pasted the newest file into resources like you said and my own controller started working. I only have the one so I'm unsure if this would potentially break other mappings.

I found a way by just setting the newer txt file in my assets directory. So it now overrides the older one when I run local and when I deploy.
I guess this can be closed then since this solution is acceptable for my use case.

By building an own local fork of this repo with your own controllerdb:
https://github.com/MrStahlfelge/gdx-controllerutils#building-from-source
You can then submit a tested PR for the change, and I can test with my controllers.
However, even with the Jamepad DB you might have a user with a controller that has a wrong mapping. Consider using the core-mapping subproject to let the user make his own mapping. :)

I'll look into the core mapping sub project :D thanks for all the help! Since I found what the problem was, and a way to resolve, I'll close this issue as solved.


docs(form): specify component ref type

🔗 Linked issue
Resolves #2292
❓ Type of change

[x] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Add type to form component ref
📝 Checklist

[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

Thanks 😄