3062 list style audit

Closes #3062
Summary
Fixes and improves a lot of design issues for the List and the components using the List
Change List (commits, features, bugs, etc)
See #3062 for specification and conversation. The code is best view per major commit:
1 - 2. Header and Search: Fix spacing and have search fill full row https://github.com/carbon-design-system/carbon-addons-iot-react/pull/3141/commits/0d62347e3f9ed3b253e773501bc4ebc8d68fbc03
3. Overflow icon: Fix overflow icon button size to match single icon size and placement. A previous fix to the button had to be adjusted to allow small ghost icon buttons. Updated stories that weren't using real buttons. https://github.com/carbon-design-system/carbon-addons-iot-react/pull/3141/commits/66bd1b278e43b04ce73c04d6fc610cb77132f710
4. Empty state. Add empty state for empty list and empty search result https://github.com/carbon-design-system/carbon-addons-iot-react/pull/3141/commits/008a23b60430020ce56018f058d674b8d0d5eb96
5. Pagination footer: Fix height, border and text alignments. https://github.com/carbon-design-system/carbon-addons-iot-react/pull/3141/commits/0240d21786c3749e6ed70d9fae681422fbe9192a
6. Load more: Align with level content, change loader and label. https://github.com/carbon-design-system/carbon-addons-iot-react/pull/3141/commits/460855f4ad0e4e7f72b441d5be7f52068265e32d
7. Mixed hierarchies: Fix indentation so that every child is always indented. Removed isCategory from Story to match design. https://github.com/carbon-design-system/carbon-addons-iot-react/pull/3141/commits/e25b8acc188df63ecee7b7eaa089ee46d652ce64
8. Tall row: Make tall rows (using isLarge) shorter. This required a redesign of the ListItem layout. Instead of absolute positioned elements corrected by special padding that had become very brittle and difficult to modify (and also failed in a few scenarios e.g. when large/tall rows with actions and labels) we now have flexbox with column gap. https://github.com/carbon-design-system/carbon-addons-iot-react/pull/3141/commits/36c9a1048b10e959b5a5cdfa1db0a640ca530512 This also fixed #3136.
Acceptance Test (how to verify the PR)
Note! Stories using document.dir for tooltipPosition or flipped props are not picking up the changes from the RTL knob. To properly test change the RTL knob, leave the story and enter again to see it working.
1. Header
Verify that the headers matches the spec (aligned with content)

https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-list--basic-single-column
https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-table-☢-tablecolumncustomizationmodal--playground-with-knobs

2 Search
Verify that the search matches the spec (full width when selected and icon aligned with content)

https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-list--basic-single-column-with-search
https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-selectusersmodal--default-modal

3 Overflow icon
Verify that the actions using the menu overflow matches the spec, i.e. the the small buttons are used. Also check that the single row action buttons are aligned with the new spec.

Go to https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-listitem--with-single-row-action
Make sure the action button size is according to spec
Enable RTL and make sure the button has not grown wider than in LTR
Go to https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-listitem--with-single-row-action
Make sure the overflow action button size is according to spec and that the menu is correctly positioned
Go to https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-simplelist--list-with-multiple-actions and make sure action buttons look ok.
Go to https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-overflowmenu--basic and check out the new size knob to make sure the sm size is being rendered ok.

4 Empty state
Verify that the empty states matches the spec

Verify Empty list  https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-list--with-empty-state
Go to https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-list--basic-single-column.
Enable knob "use search"  and type xyz in the search field
Verify that the "No results found" with a magnifier is used
Verify that the knobs "Empty state text" (combine with knob "demo empty list") and "Empty search state text" can modify the messages
Verify that the "No results found" is shown when search returns empty in story https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-hierarchylist--stateful-list-with-nested-searching
Verify the custom empty state in https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-hierarchylist--with-empty-state
Verify empty list and empty search in https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-selectusersmodal--default-modal
Verify custom empty states in story https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-table-☢-tablecolumncustomizationmodal--with-many-columns-and-load-more
Verify empty search result state in https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-table-tablemanageviewsmodal--with-callbacks-implemented (this search is external to the list and therefore looks different)
Verify the empty search state in https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-simplelist--basic

5 Pagination footer
Verify that pagination is according to te spec. Verify that the text "Page x" is correctly aligned to the left and has the correct height and no border on the sides nor bottom.

Verify that it looks ok with knob "isFullHeight" true and false. Double scrolling is  https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-list--with-pagination
Repeat for story https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-hierarchylist--stateful-list-with-nested-searching. Also expand and collapse categories to verify the pagination.
Same for this story https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-simplelist--list-with-empty-row

6 Load more
Verify that the load more follows the spec. Aligns with content per level. Uses skeleton loader.

Go to story https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-list--with-load-more
Verify that the text is "View more" and that it is aligned on the first level
Expand "Site 3" and verify that the  "View more" is aligned with thet content on that level
Click on a "View more" and verify that we get the skeleton loader
Check it all again with isVirtualList knob active

7 Mixed hierarchies
Verify that the stories are up to date with the spec. Not explicitly stated in the spec text but shown in the images are that all children should have indentation in relation to their parent.

Check that there all List stories and HierarchyList stories with categories (bold texts) only have one level of nesting.
Verify that all children have indentation in relation to their parent in https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-list--with-hierarchy
Check indentation in https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-list--with-checkbox-multi-selection-and-hierarchy
Check indentation in https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-hierarchylist--with-nested-reorder
and here https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-hierarchylist--with-mixed-hierarchies
and here https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-table-☢-tablecolumncustomizationmodal--with-column-groups

8 Tall row
Verify that the tall row (enabled by prop isLargeRow) is always 64 px tall. It must work with and without secondary values, with extremely long values, with single and multiple row actions, with checkboxes, with icons, tags, hierarchies and categories, with isVirtual false and true . These things should all be properly aligned and spaced. They should look and work ok separately and combined.

Go to https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-list--with-checkbox-multi-selection-and-hierarchy Enable isLargeRow knob and test with the different knobs available.
Enable isLargeRow knob in https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-list--with-tags
Verify https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-list--with-is-large-row-and-icon
https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-listitem--with-is-large-row
https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-listitem--testing-is-large-row-overflow
Verify with the all knobs here https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-listitem--basic-w-knobs
Go to https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-table-☢-tablecolumncustomizationmodal--playground-with-knobs and enable knob "Column key used for secondary value (secondaryValue)"
Verify with all the knobs for that story
Most of the stories for the HierarchyList have an isLargeRow knob. Verify that they look ok
Verify https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-simplelist--list-with-large-row
https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-simplelist--large-row-list-with-multiple-actions
https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-simplelist--large-row-list-with-overflow-menu

Regression Test (how to make sure this PR doesn't break old functionality)
No changes other than the improvements described by this PR in

All List stories https://deploy-preview-XXXXX--carbon-addons-iot-react.netlify.app?path=/story/1-watson-iot-list--basic-single-column
All HierarchyList stories https://deploy-preview-XXXXX--carbon-addons-iot-react.netlify.app?path=/story/1-watson-iot-hierarchylist--stateful-list-with-nested-searching
All ListCard stories https://deploy-preview-XXXXX--carbon-addons-iot-react.netlify.app?path=/story/1-watson-iot-listcard--basic
All ListItem stories https://deploy-preview-XXXXX--carbon-addons-iot-react.netlify.app?path=/story/1-watson-iot-listitem--basic-w-knobs
All SimpleList stories https://deploy-preview-XXXXX--carbon-addons-iot-react.netlify.app?path=/story/1-watson-iot-simplelist--basic
All TableColumnCustomizationModal stories https://deploy-preview-XXXXX--carbon-addons-iot-react.netlify.app?path=/story/1-watson-iot-table-☢-tablecolumncustomizationmodal--playground-with-knobs
This TableManageViewsModal https://deploy-preview-XXXXX--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-table-tablemanageviewsmodal--with-callbacks-implemented
All ListBuilder stories https://deploy-preview-XXXXX--carbon-addons-iot-react.netlify.app?path=/story/2-watson-iot-experimental-☢-listbuilder--complex-nested-example
All SelectUsersModal stories https://deploy-preview-XXXXX--carbon-addons-iot-react.netlify.app?path=/story/1-watson-iot-selectusersmodal--default-modal
All Button stories look the same when testing different knob configurations (size, type, icon etc)

Things to look for during review

[ ] Make sure all references to iot or bx class prefix is using the prefix variable
[ ] (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
[ ] UI should be checked in RTL mode to ensure the proper handling of layout and text.
[ ] All strings should be translatable.
[ ] The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
[ ] Unit test should be written and should have a coverage of 90% or higher in all areas.
[ ] All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
[ ] Changes or new components should either write new or update existing documentation.
[ ] PR should link and close out an existing issue

I would like if @dianatran18 would do a review of this PR

I'm going to follow up with a small change on the list headers once I confirm something with a few teams, but one thing I noticed was that there's an inconsistency with the selected state of a parent row for the checkbox multi-selection and hierarchy use case.
To reproduce:

Go to List: with checkbox multi-selection and hierarchy
Expand one parent row and select a child to create indeterminate parent state
Next, select a different parent row, then expand the parent row, and deselect a child to create indeterminate parent state
The first parent row will not have a selected background and blue highlight, but the second parent row will

See row 2 and 3 as the example

I think we can have it follow the 3rd row in the example, and show the selected state of the row

...

Go to List: with checkbox multi-selection and hierarchy
Expand one parent row and select a child to create indeterminate parent state
Next, select a different parent row, then expand the parent row, and deselect a child to create indeterminate parent state
The first parent row will not have a selected background and blue highlight, but the second parent row will

I think we can have it follow the 3rd row in the example, and show the selected state of the row

I've created a new issue for this since it is not new for this PR and probably just an issue of List story and not the list itself. See more info in https://github.com/carbon-design-system/carbon-addons-iot-react/issues/3148

Getting a double scrollbar when isFullHeight is false.

5 Pagination footer
Verify that pagination is according to te spec. Verify that the text "Page x" is correctly aligned to the left and has the correct height and no border on the sides nor bottom.

Verify that it looks ok with knob "isFullHeight" true and false. Double scrolling is https://deploy-preview-3141--carbon-addons-iot-react.netlify.app/?path=/story/1-watson-iot-list--with-pagination

Getting a double scrollbar when isFullHeight is false.

This is an old bug with the list, but I'll add a fix to this PR

One additional thing to check on is the header styling. This is the current style we have defined in our list spec, which was adjusted to match the data table header styling more.
Current:

Design:

I'm trying to back track to see if/when we got the request for batch actions in a list from a team, but in general the main difference is the height is 48px vs 56px (current), and the primary button is full bleed.
Note: one thing we'll need to adjust in the design spec is that the header should be using $productive-heading-02 as it is in the current implementation.
———
Examples of how teams are using lists now, which looks like the 48px height should be okay.
Graphite:

ELM:

I'll move my last comment out to a separate issue to not block this PR!


Why Kinect Body Tracking API 1.1.0 does not have nuget package

The previous versions both have msi and nuget source updated simultaneously, is there any reason v1.1.0 does not have nuget package?
When will nuget v1.1.0 be available?
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: afef83cf-fabc-7ac5-49e0-0b3293483b8e
Version Independent ID: 9b4f5587-a003-e184-d80d-c1abc5dbc33e
Content: Azure Kinect Body Tracking SDK download
Content Source: articles/kinect-dk/body-sdk-download.md
Product: kinect-dk
GitHub Login: @qm13
Microsoft Alias: quentinm

Thank you for your detailed feedback.  We are looking into the issue, and we will respond when we have more information.

#please-close


Reduce CRD size

Closes https://github.com/mariadb-operator/mariadb-operator/issues/549

As described in https://github.com/mariadb-operator/mariadb-operator/issues/549, we have reduced a 18% the CRD size


Custom rules and multi-character pairs stop working after nvim-compe's documentation window pops up

Hey, I am using vim-vsnip for snippets and I noticed that my custom rules stop working after using a snippet for the first time. In addition to custom rules this also happens with multi-character pairs like """ in python for example.
Here is my config:
local npairs = require("nvim-autopairs")
local Rule = require("nvim-autopairs.rule")

npairs.setup()

require("nvim-autopairs.completion.compe").setup({
    map_cr = true, --  map <CR> on insert mode
    map_complete = true, -- it will auto insert `(` after select function or method item
    auto_select = true -- auto select first item
})

npairs.add_rule(Rule("|", "|", "rust"))

are you using a latest commit?  are you using nvimtree

Yeah I am using the latest commit and nvimtree. Although I just tried if the issue persists after I uninstall nvimtree and it does.

sorry, i can reproduce it you should check your config. the problem of nvimtree already fix before

Alright I did some experimenting and found out that snippets actually do not trigger the behavior. It is triggered by the little documentation window that pops up in nvim-compe on some of the items in the completion menu.
Once that window appeared once the custom rules and multi-character pairs stop working for me until I restart neovim. Not sure if that is a problem with my configuration or with one of the plugins...

Here is a minimal example which reproduces the behavior:
require('packer').startup(function()
  use 'wbthomason/packer.nvim'
  use 'neovim/nvim-lspconfig'
  use 'hrsh7th/nvim-compe'
  use 'windwp/nvim-autopairs'
end)

local capabilities = vim.lsp.protocol.make_client_capabilities()
capabilities.textDocument.completion.completionItem.snippetSupport = true
capabilities.textDocument.completion.completionItem.resolveSupport = {
  properties = {
    'documentation',
    'detail',
    'additionalTextEdits',
  }
}

require'lspconfig'.pyright.setup {
  capabilities = capabilities,
}

require'compe'.setup {
  enabled = true;
  autocomplete = true;

  source = {
    nvim_lsp = true;
  };
}

require('nvim-autopairs').setup{}

require("nvim-autopairs.completion.compe").setup({
  map_cr = true, --  map <CR> on insert mode
  map_complete = true, -- it will auto insert `(` after select function or method item
  auto_select = false,  -- auto select first item
})

Using this config """ stops working in Python files after nvim-compe's documentation window popped up once.

I switched from nvim-compe to nvim-cmp and the issue persists there as well.

Sorry i can't reproduce the issue so
if you have a step or video to how to reproduce that issue then i will take a look.

Here is a gif of the issue using my setup:

Note how the """ pair only stops working after the documentation window from nvim-cmp pops up when I select def~ from the completion menu. I hope this helps.

Thankyou i fix that


Feature Request: Issue warning when Expressions.path used with unknown property of known Q-type

Some of the static error-checking provided by QueryDSL can be bypassed when using Expressions.path(Class<?>,Path<?>,String) to build a column reference.  I know that part of the reason that is allowed is to support SQL generation without generated Q-types, but there is a difference between the situation where there is no available Q-type and a programmer error of passing an invalid column name to Expressions.path.  A warning in the latter case, whether at the time of the call to Expressions.path, or at SQL generation time, would aid in troubleshooting.
(see #1980 )

Could you for completeness also add a snippet here with what would not be allowed?
The Class, QClass and snippet.
Then we can think of what would be a good way to fix it.


/v2 and /v2/candidates endpoints not respecting broker partition pruning - range partition

This is to report unexpected behavior where the broker selects too many segments to query.  The identified scenario is when secondary partition information exists (eg, for range partitioning) but is not being used in conjunction with a query filter which corresponds to the secondary partitions.  The result of not completely pruning segments at the broker is a detrimental impact on system operations such as for performance and cost.
Affected Version
28
Description
The /druid/v2 and /druid/v2/candidates broker endpoints are returning segments which should be filtered out based on secondary partition metadata.  Returning unneeded segments for planning and executing queries will cause unnecessary I/O throughout the system, causing avoidable detriment to cost and performance.
Steps to reproduce:

create segments with range partitioning, mark as used, load onto historicals.  Testing will require multiple segments per combination of datasource and time chunk.
Identify the partition column value(s) corresponding to a single segment (within a datasource/time chunk)
submit /v2 and /v2/candidates requests to the broker for the datasource and time chunk identified.  Add a query filter using a partition value previously identified for the first partition column.

Expected/observed behavior summary

The expected behavior is that the response will return only the segment identified and no others for the loaded datasource/time chunk.
The observed behavior is that the response will include additional segments for the loaded datasource/time chunk.

Testing notes

Testing used a segment where the partition/filter column was not a setwise start or end (ie, not indicated with a negative or positive infinity value for the column).  Further, to reduce ambiguity, a partition filter value was chosen that was not the first or last for the column within the segment.
The test setup had multiple partition columns in the queried segments but only filtered on the first partition column
Testing both included and omitted the query context value "secondaryPartitionPruning"
Some testing included "bySegment" in the query context to assess broker logic for selecting segments
Testing only queried a single time chunk (aligning with segment granularity).  This shouldn't be strictly necessary, but reproductions of the test may need to at least ensure that all segments in the time chunk have the same partitioning.

Representation of the test setup
segments for "src1"

there are multiple segments for the tested time chunk

segment_id
src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z
src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_1
src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_2

server segments for datasource "src1"

2x replication - similar to a typical production setup, but not strictly required for testing

segment_id,server
src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z,host1:8283
src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z,host2:8283
src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_1,host1:8283
src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_1,host3:8283
src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_2,host2:8283
src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_2,host3:8283

segment metadata - range partition column values

for testing we can assume that partitionDimensions are the first columns in dimensions, but that should not be strictly necessary

src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z: partitionDimensions: ["col_1","col_2"], start: [-inf, -inf], end: ["value1ghi","value2tuv"]
src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_1: partitionDimensions: ["col_1","col_2"], start: ["value1ghi","value2jkl"], end: ["value1lmn", "value2mnop"]
src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_2: partitionDimensions: ["col_1","col_2"], start: ["value1lmn", "value2qrs"], end: [+inf, +inf]

test query

select the identified datasource/time chunk and filter on the first partition column using a value matching only one of the multiple segments

{
  "queryType": "scan",
  "dataSource": "src1",
  "intervals": "2025-02-16T01:00:00.000Z/2025-02-16T02:00:00.000Z",
  "columns": ["__time", "col_1", "col_15"],
  "filter": {
    "type": "selector",
    "dimension": "col_1",
    "value": "value1jkl"
  },
  "context": {"secondaryPartitionPruning": true}
}

Expected result example - /v2/candidates
[
  {
    "interval": "2025-02-16T01:00:00.000Z/2025-02-16T02:00:00.000Z",
    "version": "2024-04-01T23:59:59.999Z",
    "partitionNumber": 1,
    "size": 999999,
    "locations": [
      {
        "name": "host1:8283",
        "host": null,
        "hostAndTlsPort": "host1:8283",
        "maxSize":<PHONE_NUMBER>99,
        "type": "historical",
        "tier": "_default_tier",
        "priority": 0
      },
      {
        "name": "host3:8283",
        "host": null,
        "hostAndTlsPort": "host3:8283",
        "maxSize":<PHONE_NUMBER>99,
        "type": "historical",
        "tier": "tier2",
        "priority": 0
      }
    ]
  }
]

If partition pruning is reflected at the broker, it would be unexpected to receive back any of "the other two segments" (regardless of server/replication)
Unexpected result example 1: /druid/v2 endpoint - extra (but not all) segments are returned

expected only src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_1
(FYI) unexpected segments are loaded on different servers than the expected segments
the test adds "bySegment" to the query context

[
    {
        "timestamp": "2024-04-01T09:00:00.000Z",
        "result": {
            "results": [
                {
                    "segmentId": "src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_1",
                    "columns": ["__time", "col_1", "col_15"],
                    "events": [
                        {"__time":<PHONE_NUMBER>000, "col_1": "value1jkl", "col_15": "hello"},
                        {"__time":<PHONE_NUMBER>000, "col_1": "value1jkl", "col_15": "world"},
                        {"__time":<PHONE_NUMBER>000, "col_1": "value1jkl", "col_15": "hello"},
                        {"__time":<PHONE_NUMBER>000, "col_1": "value1jkl", "col_15": "world"}
                    ],
                    "rowSignature": [
                        {"name": "__time", "type": "LONG"},
                        {"name": "col_1", "type": "STRING"},
                        {"name": "col_15", "type": "STRING"}
                    ]
                }
            ],
            "segment": "src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_1",
            "interval": "2025-02-16T01:00:00.000Z/2025-02-16T02:00:00.000Z"
        }
    },
    {
        "timestamp": "2024-04-01T09:00:00.000Z",
        "result": {
            "results": [],
            "segment": "src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z",
            "interval": "2025-02-16T01:00:00.000Z/2025-02-16T02:00:00.000Z"
        }
    }
]

Unexpected result example 2: /druid/v2/candidates endpoint - all segments are returned

expected only src1_2025-02-16T01:00:00.000Z/2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_1

[
  {
    "interval": "2025-02-16T01:00:00.000Z/2025-02-16T02:00:00.000Z",
    "version": "2024-04-01T23:59:59.999Z",
    "partitionNumber": 0,
    "size": 999999,
    "locations": [
      {
        "name": "host1:8283",
        "host": null,
        "hostAndTlsPort": "host1:8283",
        "maxSize":<PHONE_NUMBER>99,
        "type": "historical",
        "tier": "_default_tier",
        "priority": 0
      },
      {
        "name": "host2:8283",
        "host": null,
        "hostAndTlsPort": "host2:8283",
        "maxSize":<PHONE_NUMBER>99,
        "type": "historical",
        "tier": "tier2",
        "priority": 0
      }
    ]
  },
  {
    "interval": "2025-02-16T01:00:00.000Z/2025-02-16T02:00:00.000Z",
    "version": "2024-04-01T23:59:59.999Z",
    "partitionNumber": 1,
    "size": 999999,
    "locations": [
      {
        "name": "host1:8283",
        "host": null,
        "hostAndTlsPort": "host1:8283",
        "maxSize":<PHONE_NUMBER>99,
        "type": "historical",
        "tier": "_default_tier",
        "priority": 0
      },
      {
        "name": "host3:8283",
        "host": null,
        "hostAndTlsPort": "host3:8283",
        "maxSize":<PHONE_NUMBER>99,
        "type": "historical",
        "tier": "tier2",
        "priority": 0
      }
    ]
  },
  {
    "interval": "2025-02-16T01:00:00.000Z/2025-02-16T02:00:00.000Z",
    "version": "2024-04-01T23:59:59.999Z",
    "partitionNumber": 2,
    "size": 999999,
    "locations": [
      {
        "name": "host2:8283",
        "host": null,
        "hostAndTlsPort": "host2:8283",
        "maxSize":<PHONE_NUMBER>99,
        "type": "historical",
        "tier": "_default_tier",
        "priority": 0
      },
      {
        "name": "host3:8283",
        "host": null,
        "hostAndTlsPort": "host3:8283",
        "maxSize":<PHONE_NUMBER>99,
        "type": "historical",
        "tier": "tier2",
        "priority": 0
      }
    ]
  }
]

Summary
The broker should only select and/or query the smallest number of segments matching on datasource/time chunk and partition dimensions when it has enough has enough partition information about the used/loaded segments to prune out segments that don't match on partition dimensions (in addition to those segments not matching on datasource or time chunk)
Related documentation

https://druid.apache.org/docs/latest/ingestion/partitioning/
https://imply.io/blog/real-time-analytics-database-uses-partitioning-and-pruning-to-achieve-its-legendary-performance/
https://imply.io/developer/articles/multi-dimensional-range-partioning-in-druid/

Hi @ColeAtCharter. The /druid/v2/candidates API does not currently take into account segment pruning, although /druid/v2/ and /druid/v2/sql/ (the actual query APIs) do. I tried to repro the issue on /druid/v2/ and was not able to. A single segment was queried, as expected.
Could you provide some more details that could be used to repro this issue?
Here's what I tried:
I loaded data with the following SQL and rowsPerSegment: 1500 (to ensure we get multiple segments):
REPLACE INTO "wikipedia" OVERWRITE ALL
WITH "ext" AS (
  SELECT *
  FROM TABLE(
    EXTERN(
      '{"type":"http","uris":["https://druid.apache.org/data/wikipedia.json.gz"]}',
      '{"type":"json"}'
    )
  ) EXTEND ("isRobot" VARCHAR, "channel" VARCHAR, "timestamp" VARCHAR, "flags" VARCHAR, "isUnpatrolled" VARCHAR, "page" VARCHAR, "diffUrl" VARCHAR, "added" BIGINT, "comment" VARCHAR, "commentLength" BIGINT, "isNew" VARCHAR, "isMinor" VARCHAR, "delta" BIGINT, "isAnonymous" VARCHAR, "user" VARCHAR, "deltaBucket" BIGINT, "deleted" BIGINT, "namespace" VARCHAR, "cityName" VARCHAR, "countryName" VARCHAR, "regionIsoCode" VARCHAR, "metroCode" BIGINT, "countryIsoCode" VARCHAR, "regionName" VARCHAR)
)
SELECT
  TIME_PARSE("timestamp") AS "__time",
  "isRobot",
  "channel",
  "flags",
  "isUnpatrolled",
  "page",
  "diffUrl",
  "added",
  "comment",
  "commentLength",
  "isNew",
  "isMinor",
  "delta",
  "isAnonymous",
  "user",
  "deltaBucket",
  "deleted",
  "namespace",
  "cityName",
  "countryName",
  "regionIsoCode",
  "metroCode",
  "countryIsoCode",
  "regionName"
FROM "ext"
PARTITIONED BY DAY
CLUSTERED BY "page", "user"

Then ran this query:
{
  "queryType": "timeseries",
  "dataSource": {
    "type": "table",
    "name": "wikipedia"
  },
  "intervals": {
    "type": "intervals",
    "intervals": [
      "-146136543-09-08T08:23:32.096Z/146140482-04-24T15:36:27.903Z"
    ]
  },
  "filter": {
    "type": "selector",
    "dimension": "page",
    "value": "Bailando 2015"
  },
  "granularity": {
    "type": "all"
  },
  "aggregations": [
    {
      "type": "count",
      "name": "a0"
    }
  ],
  "context": {
    "bySegment": true
  }
}

A single segment came back in the reply:
[
  {
    "timestamp": "2016-06-27T00:00:00.000Z",
    "result": {
      "results": [
        {
          "timestamp": "2016-06-27T00:00:34.959Z",
          "result": {
            "a0": 9
          }
        }
      ],
      "segment": "wikipedia_2016-06-27T00:00:00.000Z_2016-06-28T00:00:00.000Z_2024-06-04T17:02:47.206Z_1",
      "interval": "2016-06-27T00:00:00.000Z/2016-06-28T00:00:00.000Z"
    }
  }
]

I also confirmed using the metric query/segment/time that only a single segment was queried.

@ColeAtCharter I was working on something recently that reminded me of this report. I realized it's possible to see the "unexpected result example 1" if the filter is filtering on something that is on the border of two segments (i.e. the value is the end of one segment and also the start of the next). This particular behavior is intentional, because it's possible for a value on the border of two segments to appear in both segments.
In the wikipedia example I posted, when I filtered on page Bailando 2015 I only got a single segment in the reply. That particular page was not the border of two segments. When I filtered on another page that was on the border of two segments, I got two segments in the reply. One had a count of 1 and the other had a count of 0.
It is certainly possible this is what you're seeing. If so, I would expect it to be fairly uncommon, unless your partitioning key is low cardinality relative to the number of segments.

Thanks, @gianm!  Understood.  The test example specifically contemplates this scenario by applying an equality filter that is on the first partition dimension where the value is strictly in between the target segment's start and end value for that dimension:
query filter:
{
    "type": "selector",
    "dimension": "col_1",
    "value": "value1jkl"
  }

target segment metadata:
src1_2025-02-16T01:00:00.000Z_2025-02-16T02:00:00.000Z_2024-04-01T23:59:59.999Z_1: partitionDimensions: ["col_1","col_2"], start: ["value1ghi","value2jkl"], end: ["value1lmn", "value2mnop"]

So the segment's col_1 start (value1ghi ) should be strictly less than the query's col_1 equality filter value (value1jkl) and further, strictly less than the segment's col_1 end value (value1lmn).
We can look for additional examples of this behavior to get more information about reproducing the issue.


Detection of controller folder ?

Looks like the LSP is not finding my files, in this app they are in app/packs/controllers which is probably non-standard.

My controllers are .ts, that's probably why all of this is happening :)

Ah I see, that explains things then, let me update this then 👍🏼

This should be resolved with v1.0.0, please re-open this issue if you still see something unexpected! Thank you!


Downloading Movies

Unsure if this is an issue or just a problem with the actual site. Ive just tried to download every one piece movie, "fireworks" and "demon slayer recap movie 3" and instead of getting them ive downloaded "5 centimeters per second" every time. download history showing the exact same file size + thumbnails of each file looking idential attached as evidence.
it does seam to correctly find the movies on the database, also pic below. hoping its just an issue with the site and not the program.

Thank you for reporting this. Not to get too technical, but there's a category tag for movies and apparently there's more than one. I use the default: 46540 but some have different ones.
It uses wcostrean for the movies
Click on a movie, click on Watch On Playlist and you've bypassed the paywall.
I will work on this in a bit

This issue has been fixed in the new release: 1.0.1

can confirm this has been fixed !


Running dev tools produces 'absent-click' glitch in buttons and links

Running Versions:

OS:  Windows 10 Home; Version 10.0.14393
Browser: Google Chrome 58.0.3029.110 (Official Build) (64-bit)
-- Revision: 691bdb490962d4e6ae7f25c6ab1fdd0faaf19cd0-refs/branch-heads/3029@{#830}.
Meteor: <IP_ADDRESS>
Meteor Dev Tools: 1.6.0

Symptoms:
When the Chrome Dev Tools window is open, some kind of glitch occurs where the first click on any button or link doesn't execute it's corresponding action, on the page you are developing (using the dev tools). From the second click on forward, everything continues to work fine with any button or link (including the one pressed for the first time in the page).  If you refresh the page, the problem reappears, again, only on the first click on any button or link you pressed.  It results in having to click a button or link twice for it to perform it's action, the first time the page runs (either by navigating to it or by refreshing the page).
This only happens while the Chrome Dev Tools window is open.  Additionally, if you uninstall the Meteor DevTools, the problem disappears (even if the Chrome Dev Tools window is open), only to return when you reinstall the extension.

Confirm the same behaviour on MacOS using Chrome 75. Disabling Meteor DevTools fixes the glitch.


Monorepo

Hello @xtyxtyx
Could you make this project a monorepo?
That is, have studio or xterm contain all the packages and not include them via git submodules.
This makes it difficult to contribute changes that possibly involve all packages as they would require 5 separate pull requests.
cc @devmil

Thank you for your suggestion!
Since context_menu_macos and tabs is depended only by studio, I think it totally makes sense to move them inside studio and will do that shortly.
As to pty and xterm, which are published to pub.dev and depended by projects other than studio, I feel it better to keep them standalone so they can be developed and tagged individually.

I think it totally makes sense to move them inside studio and will do that shortly.

(just so that there's no misunderstanding, I am not suggesting you to merge all packages into one, just to have one repo with all of the packages inside of that single repo)
Thank you for the answer. I'll have to think about it.

One idea from my sie: I'm using git subrepo to get and sync the repositories into my terminal.
Might be something worth considering
https://github.com/ingydotnet/git-subrepo


[WIP]if fe rollback version, support unmerged catalog types

What type of PR is this：

[ ] bug
[x] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/common/Config.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/server/CatalogMgr.java
2
2
100.00%
[]

@gengjun-git PTAL

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/server/CatalogMgr.java
3
3
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio backport branch-2.4


When submitting for IOS review this error is now appearing - PrivacyInfo.xcprivacy

TMS-91056: Invalid privacy manifest - The PrivacyInfo.xcprivacy file from the following path is invalid: “Frameworks/MapboxCommon.framework/PrivacyInfo.xcprivacy”. Keys and values in any privacy manifest must be in a valid format. For more details about privacy manifest files, visit: ....
MapboxCore and MapBoxNavigation both released fixes to this in their 2.18 versions

yes we are getting same error this week and it is stopping us from uploading the app

Any update on this?


Google Font's @import statenent is breaking after compiling from SCSS to CSS

Laravel Mix Version: 5.0.4
Node Version: 12.16.3
NPM Version: 6.14.4
OS:

Description:
The generated CSS breaks when SCSS has @import statement with ; in url.
Steps To Reproduce:
I was importing google fonts in my SCSS file:
This statement below works
@import url('https://fonts.googleapis.com/css2?family=Lora&display=swap');

This statement below BREAKS
@import url('https://fonts.googleapis.com/css2?family=Lora:wght@400;700&display=swap');

The css generated with the above statement is like this.
@import url(https://fonts.googleapis.com/css2?family=Lora:wght@400;

700&display=swap);

Looks like ; (semicolon) in the URL is seen as an end of the statement by the compiler.

A workaround is to use "%3b" instead of ";" in your link

@Chopinsky Thanks for the workaround. It works perfectly.
I was stuck, seeing I did everything correctly, yet the font was not loading. I thought I misspelled or did wrong in my SCSS, but after spending some time I understood the issue was not with the font or my CSS but compiler.
That's why I was stuck because my focus was never if it was a compiler issue. I hope this should be fixed in the core because Google gives that URL & many others may fall into this trap as well.

Glad to hear the workaround works! Regardless, I think there might be CSS rules driving this sort of behavior we saw. I think if CSS are extracted to modules and then minified, the compiler shouldn't add a line break after the semi-colon; not sure what's the supposed behavior otherwise.

Workaround works but this shouldn't be closed. Bug is still there.

ping @JeffreyWay

I'm not sure if this is related, but what version of the sass-loader should I be using with Laravel 8.12+? I changed my Google font @import google-font-argument semicolon to %3b but still get:
ERROR in ./resources/sass/app.scss
Module build failed (from ./node_modules/css-loader/index.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
ValidationError: Invalid options object. Sass Loader has been initialized using an options object that does not match the API schema.
 - options has an unknown property '0'. These properties are valid:
   object { implementation?, sassOptions?, additionalData?, sourceMap?, webpackImporter? }
    at validate (/home/geoff/Projects/sites/tweetshotz-com/node_modules/schema-utils/dist/validate.js:98:11)


Refactor: compile features in the loader rather than in the browser

This change moves where the feature files are compiled from inside the browser to wherever the loader is being run (hopefully Cypress node!).
This came about as I was trying to integrate this plugin with rollup preprocessor instead of webpack or browserify, I noticed that the end test bundle was huge (40k lines!). I'm not certain of the performance improvement this brings but regardless, parsing the feature file for the name in the loader then discarding that is somewhat wasteful.
While all the tests pass, there is one part I am not so sure about, and that is my change to getEnvTags() I made this logic run in the loader too and used process.env.TAGS instead of Cypress.env(). I am yet to check if that is a valid change and would be grateful if in the meantime you could hint if thats outright unacceptable - if so I'll modify this to be something that happens at test run time.
Please feel free to ask any questions or just outright decline if I have made a bad call here and this was done like this for a reason.
Thanks,
Tom

Thanks!
I did some benchmarks earlier and noticed that this didn't make any dent in the performance and actually didn't even achieve what I set out to achieve which was to get rid of the huge bundle step. I made the mistake of thinking this was the only location that Cucumber/Gherkin is imported.
I'm going to work on this some more tomorrow but one thing I've noticed is that in both your fork @badeball (not fully tried it, just from reading the code) and in this preprocessor there are imports from gherkin/cucumber in various files that are run side the browser. I suspect that by removing all of the large imports from inside the browser based code that there should be some pretty nice performance gains (especially in my specific usecase).
So for now you can either close this and I'll reopen when ready or if you want to leave it around I'll can basically keep committing and trying things out. I'll come back with some stats and if you feel it's beneficial for other users of this plugin we can go from there.

I've previously used disc to analyze browserify-bundles. If you open devtools when running a test with the interactive runner, you can see that it'll request your feature-file. You may then download the resolved bundle and analyze it.
For my fork, I know that I'm at least including @cucumber/messages, @cucumber/tag-expressions and @cucumber/cucumber/lib/models/data_table, which in turn will require at least protobufjs and lodash, so it's not going to be insignificant.

Due to personal reasons, the previous maintainers of this package are stepping down and handing the reigns over to me, a long-time contributor to the project and a user of it myself. This is a responsibility I'm very excited about. Furthermore, I'd like to thank @lgandecki ++ for all the work that they've done so far.
Read more about the transfer of ownership here.
The repository has however moved and all outstanding issues are being closed. This is not a reflection of the perceived importance of your reported issue. However, if after upgrading to the new version, you still find there to be an issue, feel free to open up another ticket or comment below. Please make sure to read CONTRIBUTING.md before doing so.


Any plans to build a real Linux client that can be used without Wine?

You can install on kubuntu using docker easily. I just wrote up instructions to add to the readme with about 4-5 commands needed.  Running btcp electrum on lubuntu 18.04 right now.

Try this :
+For Ubuntu 18.04 including Docker install:
+----------------------
+
+Update apt package index and upgrade packages as needed
+

sudo apt-get update && apt-get upgrade

+Install Docker package from Ubuntu repository
+

sudo apt install docker.io

+Build the docker image::
+

sudo ./build-docker.sh

+Run the docker image::
+

./run-docker.sh

Thank you for your instructions.

BTW, there is no working docker for Ubuntu 18.04 LTS.
So, I have to keep wait :)

The docker.io seemed to work but the docket-ce package has not been
updated. I will check over this again tonight. I was trying to recreate how
I got it to work on my laptop running 18.04. But it was lubuntu... I will
follow my own instructions on another computer running 18.04 Ubuntu to
check your syntax correction and update if needed.
Thank you for the feedback, just getting started with github.
On Wed, Jun 6, 2018 at 5:02 AM JDJoe<EMAIL_ADDRESS>wrote:

BTW, there is no working docker for Ubuntu 18.04 LTS.
So, I have to keep wait :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BTCPrivate/electrum-btcp/issues/53#issuecomment-395015675,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Afe3s2CgW01c0eIphkH_HwcG4ftCxH1Mks5t56icgaJpZM4S-6Yu
.

I found several similar posts about 18.04 K(U)buntu and docker.io and they usually end with "you just have to wait, it's not available" :)
My point is, you probably have better things to do. I can wait few more days.

Well it worked for me so I thought I would post it because I saw some like
that and decided I wanted a better answer :)
On Thu, Jun 7, 2018 at 1:17 PM JDJoe<EMAIL_ADDRESS>wrote:

I found several similar posts about 18.04 K(U)buntu and docker.io and
they usually end with "you just have to wait, it's not available" :)
My point is, you probably have better things to do. I can wait few more
days.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BTCPrivate/electrum-btcp/issues/53#issuecomment-395516326,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Afe3swXyxUHkdzflliPMMKsJ3L6-yKflks5t6W5EgaJpZM4S-6Yu
.

The docker build / docker run scripts work great, however I also like having a tar.gz around with all the deps inside, using this https://github.com/javier-lopez/dockers/blob/master/electrum-btcp/build-linux-tar-from-docker.sh to generate such file.


Produce heatmap from convergence rates.

Probably use the same module file (class) for all related issues on convergence rates.

Produce heatmap for each of the possible outcomes.


Asking question which does not have a relevant snippet in the knowledge base leads to frontend error

Asking a question, unrelated to knowledge base content, causes frontend to fail with error.
Without knowledge base:

With knowledge base:

@OlegSudakov Thanks for pointing this bug out.
This should have been fixed with the latest v0.2.0 release.
Can you please verify the same with latest codebase and close this issue?


Python: Refactor environment variable naming for clarity and consistency

Summary of Changes

Updated environment variable names to use single underscores for better readability and to avoid potential confusion.
Modified service_configurator.py to align with the updated environment variable naming convention.
Updated .env.example to reflect the new environment variable names, ensuring consistency across the project.
Added error handling and improved error messages in service_configurator.py for better debugging and maintainability.

Motivation and Context
The motivation for these changes is to address a bug where the service_configurator.py script is unable to read the GLOBAL_LLM_SERVICE environment variable due to inconsistent naming conventions. Additionally, the Azure service configuration variables were not being utilized, which could potentially lead to misconfigurations in certain deployment scenarios.

Why is this change required? To fix existing bugs related to environment variable handling and improve code maintainability and readability.
What problem does it solve? Ensures reliable loading of environment variables and correct configuration of AI services, thereby preventing runtime errors.
What scenario does it contribute to? Enhances the stability and reliability of the AI service configuration process within the semantic-kernel project.

Description
This PR addresses the issue where the environment variable GLOBAL_LLM_SERVICE was not consistently read due to a mismatch in the expected naming convention. The problem was identified in the service_configurator.py script where the variable was referenced with two underscores instead of one. Additionally, Azure service deployment names were not being used, leading to potential misconfigurations.

Modified the naming convention from double to single underscores for all environment variables in service_configurator.py and .env.example.
Ensured that Azure service deployment names are correctly utilized in the service configuration logic.
Improved error handling in the script to provide clearer and more actionable feedback.

For more context, here's a link to the buggy code: Link to the code, Link to the code

Contribution Checklist

[x] The code builds clean without any errors or warnings.
[x] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations.
[x] All unit tests pass, and I have added new tests where possible.
[x] I didn't break anyone :smile:

unit test

Unit test indeed all runs, lint does not, please run the checks!

Python 3.8 Test Coverage Report • FileStmtsMissCoverMissingTOTAL5545102082% report-only-changed-files is enabled. No files were changed during this commit :)
Python 3.8 Unit Test Overview

Tests
Skipped
Failures
Errors
Time

1206
11 :zzz:
0 :x:
0 :fire:
25.276s :stopwatch:

HI, I've noticed that this PR hasn't been approved yet. Are there any issues, or is there anything else I should add? Please let me know :)

HI, I've noticed that this PR hasn't been approved yet. Are there any issues, or is there anything else I should add? Please let me know :)

Thanks for following up. Just need one more approval from @eavanvalkenburg or @juliomenendez.

Thank you for your contribution, @bx-h.


Login and Logout Routes

Controllers - Within home-routes.js, Post route Login created to using passport to authenticate User and if User successfully passes authentication, the User is redirected to the dashboard.  If the User fails authentication, the User is redirected back to the login page.
Logout - If a User logs out, the User's property is removed and their session is cleared.  The User is the redirected to the login page.

Refer to Issue#111


refactor: Fixed typescript warnings

Fixing following warnings from lgtm.com to gain back A+

The parameter 'ProtoSubscribeResponse' has type 'any', but its name coincides with the imported type ProtoSubscribeResponse.
The parameter 'TResp' has type 'any', but its name coincides with the type parameter TResp.

Codecov Report
Base: 92.87% // Head: 92.87% // No change to project coverage :thumbsup:

Coverage data is based on head (eb806a3) compared to base (b03ca8a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   92.87%   92.87%
=======================================
  Files           9        9
  Lines        2527     2527
  Branches      325      325
=======================================
  Hits         2347     2347
  Misses        178      178
  Partials        2        2

Impacted Files
Coverage Δ

src/topic.ts
95.79% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


smake -j8 install getting errors

Expected Result:
Actual Result:

ssync
rsync --verbose --checksum --recursive --links --inplace --executability --chown=onnc:onnc --exclude=.git --delete /onnc//onnc/ /onnc//onnc-umbrella/src/
sending incremental file list
rsync: change_dir "/onnc//onnc" failed: No such file or directory (2)

sent 20 bytes  received 12 bytes  64.00 bytes/sec
total size is 0  speedup is 0.00
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1196) [sender=3.1.2]
Steps to reproduce:
cd /onnc/onnc
./scripts/create-new-backend.sh Foo
cd /onnc/onnc-umbrella/build-normal/
smake -j8 install
Environment:

ONNC version: 1.2.0
OS (e.g. from python -c "import platform as p; print(p.platform());print(p.processor())"):
Others:

It was solved by changing the source path to /onnc/onnc


Update color tokens for theming support

General Support Request
In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.
Possible Solution
Work with designers to figure out what tokens need updated values or renamed.
Additional context
This work stems from theming work happening to all Auro components:

https://github.com/AlaskaAirlines/AuroDesignTokens/issues/147

Tokens to be changed:

transparent

Rules that need refinement:

All background-color and color rules. Do we need to use linear-gradient instead?
background-color: var(--ds-color-border-active-default, $ds-color-border-active-default);
All border rules. Do we want to use a token for the entire rule or a tokens for each part of the rule (e.g. a rule for px size, type of border line and color)

This ticket will be blocked until this work is completed:

https://github.com/AlaskaAirlines/auro-button/issues/252


Cocoapods Support

QMKit should support installation by Cocoapods as well as by Carthage

https://github.com/vsouza/awesome-ios/pull/1562


Bump version to trigger deploy to nom

There have been some updates applied over the last 4 months to patch out a vulnerable package.
Could you upgrade the package on npm so it can be used in dependent libraries: https://github.com/sphereio/sphere-stock-import/issues/95
Thanks,
Moredhel

Done, please see v2.0.1


Train on custom dataset

How can we train the algorithm on a custom dataset? Is there a generate_labels files or any steps to prepare the data for training purposes?

Hi~
In order to train on a custom dataset, you need to prepare the annotations as coco format, for example,
convert_mot_to_coco


constifying in an nighlty branch or feature gate it? (with #[const_trait])

Would a PR be welcome where most of the methods and trait-impls are constified which could either be hidden behind a feature gate, similar to how it is achieved in this or in a different (nightly?) branch?
I would happily contribute this modification, as I need to write this code for another project anyways.
(Sorry for my bad english, I am not a native speaker)

I suggest you just maintain such a branch in your own fork of the repo.


Encode the arithmetic properties of FP multiplication

This PR implements the following arithmetic properties.

fmul x, y == fmul y, x
fmul 1.0, x == x, fmul =1.0, x == -x
fmul NaN, x == NaN
fmul +-Inf, +-0.0 == NaN
fmul +Inf, -Inf == -Inf
fmul +Inf, x == ?Inf (x != NaN or +-0.0, ? is the sign of x)
fmul -Inf, x == ?Inf (x != NaN or +-0.0, ? is the sign of -x)

We encoded the commuted version of each item as well.
Litmus tests are added to test the behaviors of add w.r.t. NaN, +-Inf, and +-1.0.

I'll push a few commits that will make a lot of conflicts with this patch.
I will resolve the conflict and land this.


MINOR: Improve EOS example exception handling

The current EOS example is over-complicating the exception handling by mixing non fatal and fatal ones. This cleanup is trying to make the code readability better. Will rebase after #8051 is merged
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

retest this please

retest this please

ok to test

Cherry-picked to 2.5


bye bye todo

Description
Resolves #17969

removed todo

Type of change

[ ] Bug fix
[ ] New feature
[ ] Documentation update
[x] Other~~
code cleanup

How Has This Been Tested?

n/a
Reminders:

Please follow the style guidelines of this project.
Please perform a self-review of your code before submitting a PR and asking others to review it.
Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

[ ] I have commented my code where applicable.
[ ] I have updated the release notes.
[ ] I have made corresponding changes to the documentation.
[ ] I have added debugging support to my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have confirmed new and existing unit tests pass locally with my changes.
[ ] I have added new baselines for any new tests to the repo.
[x] I have NOT made any changes to protocol or public interfaces in an RC branch.~~

merge w/ develop in #19682


(PUP-5915) Stop Exec defaulting its cwd parameter

Without this patch, the base Exec provider defaults the cwd parameter to
Puppet's working directory.  As a result, in the event that no cwd is
explicitly specified, Puppet attempts to change to the directory that is
already its working directory when it runs the Exec's command.  In most
cases that's merely wasteful, but under some circumstances it causes the
Exec to fail needlessly.
With the defaulting removed, the provider's
Puppet::Util::Execution.execute() call just does the right thing.
That is, it avoids attempting a working-directory change in the event
that no value was specified for the cwd parameter.

Updated ticket ID

CLA signed by all contributors.

jenkins please test this on aix71-POWER,osx1013-64,redhat7-64,solaris11-64,debian9-64,windows2012r2-64 with servertests

The zone tests don't appear to work on solaris11-64 only solaris114-64.

jenkins please test this on solaris114-64 with servertests

Given there are 2 approvals, I'm going to merge this.


Tarball build of man-db fails because /usr/include/le/ndbm.h is outdated and dptr is void* rather than char*

We probably need to port https://github.com/LuaDist/libgdbm to progress forward.  The current issue is:
./db_lookup.c:303:30: error: invalid operands to binary expression ('void' and 'int')
        else if (*MYDBM_DPTR (cont) != '\t') {  /* Just one entry */

This is because dptr is void* rather than char*.

issue opened: https://github.com/ZOSOpenTools/gdbmport/issues/1 (looks like gdbm isn't building correctly)

fixed


Add joshbranham as a reviewer

What is being added?
Add myself as an official reviewer of this project
Checklist before requesting review

[ ] I have tested this locally
[ ] I have included unit tests
[ ] I have updated any corresponding documentation

Steps To Manually Test
Please provide us steps to reproduce the scenarios needed to test this.  If an integration test is provided, let us know how to run it. If not, enumerate the steps to validate this does what it's supposed to.

Start the operator
Run the thing
Observe X in the spec for the thing
Clean up the thing

Ref OSD-0000

/retest

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.04%. Comparing base (dfbd19e) to head (86c40f8).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   47.04%   47.04%
=======================================
  Files          45       45
  Lines        6723     6723
=======================================
  Hits         3163     3163
  Misses       3229     3229
  Partials      331      331

/test validate

/test validate

/test validate

/test validate

/test validate

/lgtm


Release v1.0.4

#331 fixes a fairly large bug but isn't included in the latest release which means most users are unaware of it. Releasing a new version would mean more people would get to use the update as it would show as an update in HACS.

Agreed - I've forked the repository as a test and done a quick and dirty merge of all the outstanding PRs.  Had to do a bit of cleanup.  I then dropped the custom integration folder over the top of my current HACS install.
So far so good I have entities for GAS and ELEC with Values but for some reason I am only seeing ELEC in the energy dashboard.

I installed main which has been working well, although I only recently discovered that the integration was fixed

This installs the latest commit on main:

Thanks.. I thought there was a way to do it via the UI, but couldn't remember, and then stumbled across it just before you posted this, so thanks!  Still hasn't sorted my gas readings though :(

@HandyHat could we get an update on this? I think a new release tag would really help users, especially since the merge of #331.

I don't think this is longer supported.. look at the dates...


Feature: Add Support for Devnet Mint and Mint Lite

The Shardlabs devnet allows for minting to an address using the local faucet -> https://github.com/Shard-Labs/starknet-devnet#mint-token---local-faucet
This is necessary when the deployed and funded accounts are not sufficient (e.g. wrong account contract).
It would be great to start adding support for devnet-specific functionality such as this.

Sorry, I did not see this issue. This is something we have this tests https://github.com/dontpanicdao/caigo/blob/5114a4722290c5f43dc1451942779fd21df40139/rpc/xsessions/plugin_test.go#L97 . I am not sure how to introduce that. Could we have a test hellper like httptest ?

Resolving this due to added functionality


update scripts

Thanks @Randy1Burrell  - just cleaned it up a bit more there and set it ready for review again

Thanks @Randy1Burrell  - the copyright is updated now, so just needs another approval before merging

@Randy1Burrell Oh not sure what that 'dismissed stale review' is about - when you get a chance to approve it again feel free to merge it yourself then.


2.x

complete rewrite of monk:

return real promises (#104)
update mongoskin and mongodb (#111)
auto binding of the methods
eslint
test coverage
Support $ne, $in, $nin for id casting
Make the sort option behave like fields

drop support for node < 0.12 (no promise)

@TooTallNate
Could it be possible to enable travis for monk?
https://travis-ci.org/Automattic/monk

Could it be possible to enable travis for monk?

Sure thing, enabled!

[Current coverage][cc-pull] is 91.36%

No coverage report found for master at 18ed543.

Powered by Codecov. Last updated by [18ed543...c7e6db2][cc-compare]
[cc-base-branch]: https://codecov.io/gh/Automattic/monk/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/Automattic/monk/compare/18ed543cc4c710c09af4b428c16ab70ea5d22f41...c7e6db2dbc1383b6501e81634ab19d5d71c99e2a
[cc-pull]: https://codecov.io/gh/Automattic/monk/pull/132?src=pr

Travis is looking nice.

yeah, I'm happy to merge now. I'll probably do another PR to increase a bit the coverage next week but it shouldn't need a npm publish

@TooTallNate do you know when you will have time to merge and publish to npm?

waiting for that too


Bad evaluation

Hi @lufficc, i've trained model on a subset of coco with only 4 classes instead of 80 and 1600 images. This is my configuration:
MODEL:
NUM_CLASSES: 5
BACKBONE:
OUT_CHANNELS: (512, 1024, 512, 256, 256, 256, 256)
PRIORS:
FEATURE_MAPS: [64, 32, 16, 8, 4, 2, 1]
STRIDES: [8, 16, 32, 64, 128, 256, 512]
MIN_SIZES: [20.48, 51.2, 133.12, 215.04, 296.96, 378.88, 460.8]
MAX_SIZES: [51.2, 133.12, 215.04, 296.96, 378.88, 460.8, 542.72]
ASPECT_RATIOS: [[2], [2, 3], [2, 3], [2, 3], [2, 3], [2], [2]]
BOXES_PER_LOCATION: [4, 6, 6, 6, 6, 4, 4]
INPUT:
IMAGE_SIZE: 512
DATASETS:
TRAIN: ("coco_2017_train", )
TEST: ("coco_2017_val", )
SOLVER:
MAX_ITER: 100000
LR_STEPS: [85000, 120000]
GAMMA: 0.1
BATCH_SIZE: 4
LR: 1e-4
OUTPUT_DIR: 'outputs/vgg_ssd512_coco_4class100000iter'
TEST:
BATCH_SIZE: 1
CONFIDENCE_THRESHOLD: 0.01
MAX_PER_CLASS: -1
MAX_PER_IMAGE: 100
NMS_THRESHOLD: 0.01
I've trained it with 100000 iterations and the evaluation results are:
AP        : 0.011
AP50      : 0.015
AP75      : 0.013
APs       : 0.006
APm       : 0.004
APl       : 0.014
I think there are problems on resizing boxes when evaluating, because in "bbox.json" i see a lot of boxes with negative coordinates. Someone can help me please?

how do you solve it? thanks !

I didn't solve


How to handle an expired token

Hello hello,
I was checking out the other example and comparing it with this one, and I noticed a couple of things:

Unlike the other example, in this grant flow there is no such thing as "Refresh Token"
Unlike the other, more complete example, here it is not handled the case when the token has expired. In the other one, before every call there was a smart function that would check beforehand if the token needed be refreshed.

Since I am just learning about Oauth -mainly from this use case- I was wondering how should one proceed in this case -- especially in a case where there is no such Refresh Token.

Hey, @linuxbandit. Sorry for the late response. The notification for this issue went under the radar.
The samples are fundamentally different. This sample demonstrates how to connect a basic service (no user interaction) to Microsoft Graph.
In this sample, there's no need to implement the refresh flow. An application can simply request another access token. Tenant administrators consent these applications, thus, there's no need for end-user interaction.
For more information, see Build service and daemon apps in Office 365.
Let me know if you have more questions.

Thank you,
yes I also forgot to reply to my own question for those who needed, but I have found the solution and I wrote this snippet:
function checkIfTokenExpired(token, callback) {
    if( new Date(TOKEN_EXPIRE_ON) - new Date() < 10000){ //100 seconds
      console.log("Requesting another token: less than 100s to expiration");
      return authenticate(callback);
    }
    return callback(token);
};

So, if token is about to expire, I ask for another one and then the callback is called, otherwise the callback is directly invoked


Remove old Python27 stuff from pyodbc.pyi

Looks like a couple of entities are no longer in the pyodbc interface - "ansi" and "UNICODE_SIZE".  This PR removes them.

And again, thanks for noticing stuff I didn't.  Is there any way to create a unit test to compare the pyi file against the binary?
Long term I'm thinking we might want to split pyodbc into Python classes and a _pyodbc C library, as long as it doesn't degrade performance.  A performance benchmark is necessary for determining if the stable ABI is a good idea too.  Hmmm...  Need to prioritize that.

The utility mypy has a facility for doing a certain amount of stub checking, but I suspect that might depend on a pure-Python underlying module.
I think creating a pure-Python top/level module for pyodbc and C underlying extension classes would be a great idea.  There's a lot of fairly straightforward non-ODBC stuff that could be done without invoking the power of C, e.g. parameter validation.  It would be handy to be able to do that in Python.


Update README with multiple scopes example

For users who are using OAuth for the first time, the process of adding multiple scopes isn't intuitive. For example, someone will probably try scope: ['email', 'identify']. This small update to the README explains what's going on and makes it clear how to use multiple scopes.
Also changed the example ENV variables to match the Discord API (:client_id, :client_secret)

Great contribution, we really appreciate that. Thanks.


Enhanced version of capture video frames

2 enhancements were made.
1.User can set his preferred destination folder name under query. User can also set the video name under query(the video must be in .mp4 format and must be in in this folder itself).
2.User can set how many frames he want from the video then waiting 30 minutes for all the frames to get converted to .jpg extension.
Description
A short summary of what is included in your Pull Request.
Fixes #(issue_no)
Replace issue_no in the above line, with the issue related to this PR.
Type of change
Choosing one or more options from the following as per the nature of your Pull request.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation Update

Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.

[ ] I have named my files and folder, according to this project's guidelines.
[ ] My code follows the style guidelines of this project.
[ ] My Pull Request has a descriptive title. (not a vague title like Update index.md)
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
[ ] I have included a requirements.txt file (if external libraries are required.)
[ ] My changes do not produce any warnings.
[ ] I have added a working sample/screenshot of the script.

This is my 2 enhancements for Capture_Video_Frame project

mismatch in code and PR closing


Built-in functions and global scope doc

I added descriptions for built-in functions (more verbose ones) and some global scope constants.

The joystick descriptions are correct, yes. But I would choose the wording a bit differently.
For JOY_AXIS_*, I'd say "stick" instead of "Pad".
For JOY_ANALOG_* I'd use the same as for JOY_AXIS_* and scrap the "Analog" part, as axes should always be analog. I guess the point of these constants is that the user can instantly see if it's X or Y.
JOY_L/R: "Joystick left/right shoulder button"
JOY_L2/R2: "Joystick left/right trigger"
JOY_L3/R3: "Joystick left/right stick click"

Also, JOY_AXIS_4/5: "Joystick left/right trigger axis" or maybe "analog" would be appropriate here since you can get the triggers both digitally as buttons and analog as axes.

Thanks, I'll rewrite those descriptions. And squash to one commit.

And done :smiley:

oops, seems like I wasn't thinking so straight :/
The triggers should be axes 6 and 7, sorry.
fixed by #3949


Add cloudevents endpoints to server

This adds CloudEvents support to the server.

I have no idea why dep reformatted the lock file...

A newer version of dep reformats the lock file this way - the original file was generated with an older version.

Once we validate the endpoint, we can start receiving events from Event Grid - here's how a blob deleted event looks like:
{
  "eventType": "Microsoft.Storage.BlobDeleted",
  "eventTypeVersion": "",
  "cloudEventsVersion": "0.1",
  "source": "/subscriptions/<subscription-id>/resourceGroups/eventgrid-cloudevents/providers/Microsoft.Storage/storageAccounts/evcloudeventsstorage#blobServices/default/containers/testing-container/blobs/README.md",
  "eventID": "a90602e3-201e-0051-261e-f4bd9106719c",
  "eventTime": "2018-05-25T11:50:39.0091025Z",
  "data": {
    "api": "DeleteBlob",
    "requestId": "<request-id>",
    "eTag": "<e-tag>",
    "contentType": "application/octet-stream",
    "contentLength": 141,
    "blobType": "BlockBlob",
    "url": "https://evcloudeventsstorage.blob.core.windows.net/testing-container/README.md",
    "sequencer": "000000000000000000000000000001B100000000028f3beb",
    "storageDiagnostics": {
      "batchId": "<batch-id>"
    }
  }
}


java.lang.IllegalArgumentException - nativePtr is null

Information

Haze version: 0.9.0-rc02
Platform: Android
Platform version: Android 14

Behavior
Just updated from 0.9.0-beta01 to 0.9.0-rc02 and have started seeing crashes in the wild once I published a new app release. Works fine on my Pixel 8 device but have seen crashes on a Galaxy A15 5G and IQOO Z7x 5G (plus others).
Note that I didn't have any issues at all with 0.9.0-beta01.
Didn't change any of my implementation after the update either, other than what was required for the breaking API changes – which was just updating the style param in my case.
Stack trace:
Fatal Exception: java.lang.IllegalArgumentException: nativePtr is null
       at libcore.util.NativeAllocationRegistry.registerNativeAllocation(NativeAllocationRegistry.java:264)
       at android.graphics.RenderEffect.<init>(RenderEffect.java:314)
       at android.graphics.RenderEffect.createBlurEffect(RenderEffect.java:117)
       at dev.chrisbanes.haze.RenderEffect_androidKt.createRenderEffect-nhveHWw(RenderEffect_android.kt:71)
       at dev.chrisbanes.haze.RenderEffect_androidKt.createRenderEffect-nhveHWw$default(RenderEffect_android.kt:36)
       at dev.chrisbanes.haze.HazeChildNode.updateRenderEffectIfDirty(HazeChildNode.kt:375)
       at dev.chrisbanes.haze.HazeChildNode.drawEffectWithGraphicsLayer(HazeChildNode.kt:333)
       at dev.chrisbanes.haze.HazeChildNode.draw(HazeChildNode.kt:273)
       at androidx.compose.ui.node.LayoutNodeDrawScope.drawDirect-eZhPAX0$ui_release(LayoutNodeDrawScope.kt:110)
       at androidx.compose.ui.node.LayoutNodeDrawScope.draw-eZhPAX0$ui_release(LayoutNodeDrawScope.kt:89)
       at androidx.compose.ui.node.NodeCoordinator.drawContainedDrawModifiers(NodeCoordinator.kt:450)
       at androidx.compose.ui.node.NodeCoordinator.draw(NodeCoordinator.kt:439)
       ...

You’re going to need to share some code. What style are you using? Etc

Doing this:
    val hazeState = remember { HazeState() }
    Surface(
        modifier = modifier.aspectRatio(1f),
        ...
    ) {
        displayData.backgroundImage?.let {
            RemoteImage(
                url = it.url,
                contentScale = ContentScale.Crop,
                modifier = Modifier
                    .fillMaxSize()
                    .haze(hazeState),
            )
        }
        Box(
            modifier = Modifier
                .clickable { displayData.link?.url?.let { onClick(it) } }
                .fillMaxSize()
                .hazeChild(
                    state = hazeState,
                    style = HazeDefaults.style(
                        backgroundColor = backgroundColor,
                        tint = tint(tint),
                        blurRadius = if (displayData.hasBackgroundImage) 2.dp else 0.dp,
                        noiseFactor = 0f,
                    ),
                ),
        ) {
        ...
        }


Format all HTTP related operation name in METHOD:URI

@wankai123 Due to #7130, we should adjust all Java related plugin, and make sure the format is correct. And we should update plugin dev doc about this.
All @apache/skywalking-committers, other language agents should take care of this too.

Should also only count response code 5xx as errors?
https://github.com/apache/skywalking/pull/7111

Should also only count response code 5xx as errors?
#7111

We should count that as an error at the client side, but that is a different context. This issue is relating to operation name because OpenAPI spec support.

@wankai123 After you finish the group dynamic configuration, you could take care of this. We should have several weeks before cut 8.8.0 release, because there will a long testing about our new Elastic client implementation.

@wankai123 I just moved the milestone, due to Java agent moved out of main repo.


[Event Request] COD 22 - SplitJnlLine - SkipError

Similar to the way Errors have been skipped in codeunit 80 Sales-Post (e.g. OnPostItemTrackingForShipmentOnBeforeShipmentInvoiceErr), we would like to skip the error below in "Item Jnl.-Post Line"(Codeunit 22), function SplitJnlLine
...
end else
      // Move code to separate function with OnBefore publisher
                if (ItemJnlLine2."Item Charge No." = '') and (ItemJnlLine2."Job No." = '') then
                    if not ItemJnlLine2.Correction then // Undo quantity posting.
                        Error(Text011);

Can you please provide an event publisher with Handled pattern and acces to ItemJnlLine2, so we can skip the error?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


TOSM3-Initial-Flask-Implementation-With-Signed-Commits

Description
Beginnings of very rough implementation in Python+Flask for Integrating with the NHS Notify API Integration environment. Pushing up so all devs can take a look into the start of this work for the proof of concept. Next steps include decoupling functionalities and testing options.

[x] New feature (non-breaking change which adds functionality)

Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

[x] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

/azp run


travis: add Windows support

Note publishing releases does not work yet because of:
https://travis-ci.community/t/rvm-command-not-found-when-deploy-to-github-release/367

Let's keep this open for now. Maybe the travis bug will be fixed soon.


Unexpected struct_time flag with Calendar.parse on HTML  string

I was expecting a 0 instead of a 2 for the struct_time flag.
import parsedatetime
cal = parsedatetime.Calendar
print cal.parse('<a data-navid="792" href="/departments/departments-n-z/probate/estates-trusts/transfer-by-affidavit-50-000-and-under">')

OUTPUT:
((2014, 12, 2, 0, 0, 0, 1, 336, -1), 2)

This was recently fixed and will be included in the next release. Units such as hours are only picked out as standalone words like 792 hours or attached to the number like 792h. "792 href" in your example will no longer parse as a date. Since the parsing is done with regular expressions, the word boundary \b is used to ensure that the keyword is not just a substring in a larger word.
There were a lot of cases like this, we should be in much better shape now!

Awesome!  Thanks @idpaterson and @bear


Add logger name to system log

Breaking change

Proposed change

Add the logger name to the system log entries. Example name is homeassistant.components.hue.bridge. This will allow us to figure out the integration in the frontend.
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[x] New feature (which adds functionality to an existing integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[ ] Local tests pass. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the development checklist
[ ] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

[ ] No score or internal
[ ] 🥈 Silver
[ ] 🥇 Gold
[ ] 🏆 Platinum

Nice! That will improve the experience when a user hits an error 👍


Leaking existence of private repositories by SSH git access

Gogs version (or commit ref): 491407ddf89fb4182c5401c47d2af38f0a30adca
Git version: 2.1.4
Operating system: Debian 3.16.7-ckt25-2+deb8u3 (2016-07-02) x86_64 GNU/Linux
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[x] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist:

Description
There is a different error behavior when a private repository does not exists versus when you just don't have access when using SSH. The web client in both cases shows a 404.
See the following 2 repositories, the first one is private and does exist, the second one does not exist.

https://try.gogs.io/verysecret/private

$ git clone git@try.gogs.io:verysecret/private.git
Cloning into 'private'...
Gogs: Repository does not exist or you do not have access
User *** does not have level read access to repository verysecret/private.git
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

https://try.gogs.io/verysecret/private-does-not-exists

$ git clone git@try.gogs.io:verysecret/private-does-not-exists.git
Cloning into 'private-does-not-exists'...
Gogs: Repository does not exist or you do not have access
Repository does not exist: verysecret/private-does-not-exists
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

In the first case the User *** does not have level read access to repository verysecret/private.git actually confirms that the repository exists.

Don't run Gogs in DevMode when it's used in production :smile: https://github.com/bkcsoft/gogs/blob/master/cmd/serve.go#L76-L77

I just (re)tested it on my own environment (shouldn't try.gogs.io run in production mode?), but RUN_MODE = prod is in custom/conf/app.ini (and there is only one RUN_MODE key) and just to be sure checked /admin/config which lists:

Run Mode Production

I also checked the config path in /home/git/.ssh/authorized_keys and the --config= links to the same custom/conf/app.ini.
I see I shouldn't see these messages [1, 2, 3] based on the !settings.ProdMode check in fail [4], but I do. Is it possible the gogs serv key-* --config= fails to load the config file without reporting? Or the custom/conf/app.ini production mode isn't correctly overwritten with the prod value?

That's odd, I'll have a look when I have time.

I can reproduce this. I'll look at a fix next week.

ProdMode isn't even being set from what I can see.

Can you try this PR and report back if it works or not? :)

@LefsFlarey interesting find, but for me it does not seem to change a thing.
BTW for direct cli testing you can try making a dummy user, upload a key for this user and get the id ($ grep dummy-user-key-name /home/git/.ssh/authorized_keys | awk '{print $3}').
Then you can directly run gogs serve with a SSH command like this which is run on a git clone:
$ SSH_ORIGINAL_COMMAND=$(echo "git-upload-pack 'path/repo'") gogs serv key-X --config=custom/conf/app.ini
#or via sudo:
$ sudo -u git bash -c "SSH_ORIGINAL_COMMAND=\$(echo \"git-upload-pack 'path/repo'\") gogs serv key-X --config=custom/conf/app.ini"

Depending on the path, this still produces:
Gogs: Repository does not exist or you do not have access
User *** does not have level read access to repository ***/***

Gogs: Repository owner does not exist
Unregistered owner: ***

Gogs: Repository does not exist or you do not have access
Repository does not exist: ***/***

@LefsFlarey I just looked better at the patch, and it uses Key("RUN_USER") instead of Key("RUN_MODE")
However, I just tried this instead, but that doesn't solve the problem either:
switch Cfg.Section("").Key("RUN_MODE").String() {
case "prod":
    ProdMode = true
}

Oh my god, I didn't even notice. Let me fix it.

$ head custom/conf/app.ini
; App name that shows on every page title
APP_NAME = *** ***
; Change it if you run locally
RUN_USER = git
RUN_MODE = prod

[repository]
ROOT               = /home/git
FORCE_PRIVATE      = true
; Name must match file name in conf/license or custom/conf/license

Hm, strange. I'm not sure why it wouldn't work. @bkcsoft I hereby give up. T.T

@LefsFlarey you're close enough that I could debug it thought :laughing:
setting.ProdMode is only set in this function
Which is never ever called from cmd/serve.go :confused:
I'd move routers.checkRunMode() to setting.CheckRunMode() and change routers.GlobalInit() accordingly, then add setting.CheckRunMode() after this line
@Unknwon what do you think?

@bkcsoft that's probably a better idea, did you test it with the gogs serve command I gave & did you already made a branch for this? Otherwise I will give it a try (and test it :), it would be better to create a full integration failing test first of course.. ;-)

@bkcsoft I find it weird that ProdMode is almost entirely exclusively never used. What's the difference between prod & live/dev? Just the SSH part? IMO, it feels weird, hardly used and in my opinion, removed entirely.

@bwbroersma I haven't tried it, feel free to steal this one ^.^
@LefsFlarey the difference is verbosity. try.gogs.io is not is ProdMode since we want it do be verbose for testing purposes :smiley:

Also SSH git shouldn't leak stuff (e.g. that verysecret/private exist) that the web hides.

things that should be kept privatly should run in ProdMode, try.gogs.io is not one of these :wink:

@bkcsoft From what I can see from the code, the only part of verbosity in the entire repository is cmd/serve.go.

@LefsFlarey yeah, I found that as well and was sort-of confounded by that. Seems like there's more things that could/should use ProdMode as well (e.g. the exec-time in footer.tmpl).

I was thinking of remove the entire thing and ensure logging to local file is the only debugging....

Fixed in master.


Allow the user to choose rather than typing in yes/no for git installation

Currently gitRepo.js validates whether git is installed within the user's machine and prompts to type in (Y/N) such that if it should continue with the installation or not.

It should be replaced with a confirm dialog as supported by inquirer

I would like to work on this feature. Please assign me

Assigned!! All the best :+1:

@amitsin6h How's the progress

@ajomadlabs I working today itself. While working I found something strange.
When I did mevn init
after that I got the below list of commands
but what I found is mevn-cli does not works only mevn works.
I just want to know is it changed from mevn-cli to mevn or something is wrong with my setup

@anto-christo @ajomadlabs  to test the git installation I removed the git from my system. After that I run mevn init <appname>
below are the results

➜  mevn init testapp

  __  __                             _ _
 |  \/  | _____   ___ __         ___| (_)
 | |\/| |/ _ \ \ / / '_ \ _____ / __| | |
 | |  | |  __/\ V /| | | |_____| (__| | |
 |_|  |_|\___| \_/ |_| |_|      \___|_|_|

Tool for mevn stack.
? Please select one basic
exec: /bin/sh: 1: git: not found

mv: cannot stat 'mevn-boilerplate': No such file or directory
exec: mv: cannot stat 'mevn-boilerplate': No such file or directory

Fetching the boilerplate ⠦

Do I have to check if the user does not have git installed in his system then ask user to install git with yes /  no option ?
Please let me know .

@jamesgeorge007 @ajomadlabs  sorry for the trouble. I solved it after latest code merger from upstream branch.

@anto-christo @ajomadlabs I am working the latest code now.
I removed the git from my system using 'sudo apt-get remove git'
Then I tried to create the project using 'mevn init '
But below is the error that came

Second time I installed the git in my system using 'sudo apt-get install git'
Then I tried to create the project using 'mevn init '
It created the project
I guess now I have to handle the exception and then ask the user for the installation of git. So that it does not create any problem while creating the project.
My OS details
'Linux juno 4.15.0-39-generic #42-Ubuntu SMP Tue Oct 23 15:48:01 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux'

@amitsin6h Yeah, just handle that exception and let us know


[Tree] [NestedSet] fixes and enhancements

Added and fixed some wrong comments
Verify and recover wrong levels in nested set
childrenQueryBuilder() to allow specifying sort order separately for each field
Added option to reorder only direct children in reorder() method
Added 'includeNode' option in getPathQueryBuilder() to specify whether you want the starting node included or not
Added 'base' property for tree level annotation
Added 'treeRootNode' options in verify() in case you want to verify a single tree in a forest
Added options to recover() for sibling order, tree root in a forest, verification skip and auto-flushing
Added recoverFast() method for where speed is more important than safety and entity manager state
Added getPathAsString() method to entity repository

@pmishev Really grateful for the work you've put in here. It'll take me a bit to digest everything.
I'm concerned about changing the method APIs by adding new parameters. One intention with a 3.0 release was to limit the number of breaking changes. And on a more personal opinion, I dislike the use of an associative $options array that changes based on the method you're calling. It's repetitive, hard to document, and requires extra code if you want type safety / validation on the values.
What do you think of splitting up this PR into non-breaking improvements (including anything you'd consider a bug fix), and then the API-changing stuff? Should make it easier to digest and get some things merged sooner, instead of as a whole.

@AkenRoberts Thanks for having a look at it. All of these are changes I've been maintaining in my fork for a few years now, as we use them for our project. This time it took me a while as a hard push into master has overwritten the commit tree, so I had to reapply them line-by-line.
Seeing that a new major release is planned, I took the opportunity to divide everythin in as many separate commits as possible, so they can be individually reviewed.
These are the fixes:
https://github.com/Atlantic18/DoctrineExtensions/pull/2116/commits/7eb2fea9297ba28e6aac2b560d98d894c8b6dad1
https://github.com/Atlantic18/DoctrineExtensions/pull/2116/commits/dc355e10082eef6acffa1ed539844edcc62955df?w=1
This I consider a fix as well, or rather finishing the currently half-baked implementation:
https://github.com/Atlantic18/DoctrineExtensions/pull/2116/commits/b296c582dd79e69b6eb4f3254e9176c15b49cd43
This one is adding an additional param to the reorder() method - it's not a breaking change:
https://github.com/Atlantic18/DoctrineExtensions/pull/2116/commits/3184f6a6ddb5fad52c256b832a354a28070996d6
And then the big one:
https://github.com/Atlantic18/DoctrineExtensions/pull/2116/commits/7ae9cb160b76a75ee0a4a2425016d1fd8761ba2b
I couldn't really separate it as all of the changes are somehow connected.
There are no breaking changes here either, everything is backward-compatible.
About the associative $options array. I get where you're coming from, but in my experience, I've found that this approach has its benefits:
If your method has a dozen of parameters and you only want to specify the last one, you have no choice but filling in 11 other default values, trying hard not to mess up the order or the default values, just so you can pass the one you need. This way, it's much cleaner to specify only the parameters you actually need to change.
If you decide to remove an option in a newer version of the API, it gives you more flexibility.
It does require extra code for type safety/validation and that's why I normally use this approach with Symfony's OptionsResolver component, where this can be done with minimal code. I just didn't want to introduce another dependency in the project in this case, but I'd be happy to do so, if it would be an acceptable solution.
I don't really understand the point of being harder to document - I have documented the options in their respective docblocks.
In the end, whatever you decide to accept would save me time next time I have to upgrade, so I'll be happy.

a hard push into master has overwritten the commit tree

Yeah, sorry about that. The old master was an in-progress but very messy attempt at a new major release, and it was just all over the place while no longer being maintained. I made the executive decision to ice it, and focus on a more reduced and non-breaking 3.0 while the overall state and direction could be reevaluated.

I took the opportunity to divide everythin in as many separate commits as possible, so they can be individually reviewed

Awesome, that'll help me review more individually. Thank you!

There are no breaking changes here either, everything is backward-compatible.

True, I suppose an optional parameter is only breaking if someone has overloaded the method with their own parameter. I do want to be careful about adding parameters, though, because once they're in the public API we need to maintain them and introduce future BC concerns.
And I appreciate the additional thoughts for the array options. Regarding documentation, I'm thinking more about outside of docblocks, and then just the intuitiveness of these methods in general. There may be an opportunity to create a better API instead of jamming options into existing methods. Just something I want to fully evaluate before committing to it.
Thank you again, looking forward to pouring into this more closely.

Hi! This was auto-closed because I renamed/removed master. I've marked this as Still Relevant so I know there is some validity to this addition still.


Fix @routes Blade not working on some env (issue #115)

I made a pull request for issue #115

If any other service provider that's loaded before ziggy resolves the blade.compiler during boot, then the afterResolving hook won't fire. This is a very common pattern, and is even in the Laravel docs. This PR is a good fix for that.

@inxilpro Thanks for sharing information :)
I actually didn't understand why my fix is working.. haha

I'm going to merge this so people can pull down dev if they want, but I'm going to wait until I figure this and a few other things out before tagging a new release.

Thanks for finding a fix for this @darron1217


Reject TJAP3, embrace OpenTaiko.

Ohh boy this is gonna be a cool one. I screwed around while making the TJAPlayer3.cs and now people can't build anything anymore so I fixed it :3

mb komi

Changed some stuff in Program.cs to remove TJAPlayer3-f references.
Changed "enumerating" to "loading" in CActSelect曲リスト.cs. It saves up on a bit of coding space and people still know what it means.
Changed Input Calibration artist metadata from TJAPlayer3 Developers to OpenTaiko developers instead in CStage曲読み込み.cs.

i feel like most devs here don't trust me after what i did

Might as well remove Readme.txt under the root folder if you're removing them.

Might as well remove Readme.txt under the root folder if you're removing them.

Yeah, Takkkom had this readme.txt for no reason, even if there is already a README.md. That's why I decided to remove it. Useless clutter. Still waiting for the merge though.

I meant there was two empty Readme.txt  files.

./Readme.txt
./OpenTaiko/Readme.txt (the one you removed)

Might as well remove the one in the root folder as well.

Hello,
Changed Input Calibration artist metadata from TJAPlayer3 Developers to OpenTaiko developers instead in CStage曲読み込み.cs.
-> Since it refers directly to the TJAPlayer3 calibration chart (which is an external tja), it would no longer be handled as it by changing the metadata on CStage曲読み込み.cs, this should be reverted to "TJAPlayer3 Developers" imo
Did you build the program this time? Removing the Readme.txt file on the folders without dereferencing it on the VS project mights cause a build error


Mekanism and Ender IO

My game has Crashed with the gas conduct
http://pastebin.com/H5Rv0PNa

Please use the search bar before posting, this is a duplicate of #2257.

Also #2110