Consider using colors.json instead

I notice that this imports ~/.cache/wal/colors
However this file does not include the "special" section found in colors.json which includes background and foreground.
It would be nice if this theme would import the json and used those properties if they exist to better match the actual background and foreground of the system when applied with wal.
Thank you!

I see your point, and I might change this one day, but in the near future probably I won't. If you want, you can send me a PR.
That said, I don't understand what do you mean with 'match the actual background and foreground', could you explain it to me?

If you want, you can send me a PR.

It seems like it might be a straightforward change, I'll look into it

That said, I don't understand what do you mean with 'match the actual background and foreground', could you explain it to me?

Sure!
As mentioned, the extension looks for ~/.cache/wal/colors. By default these only include colors 1-16
https://github.com/dlasagno/vscode-wal-theme/blob/ccc84e4944aa7b7512bc7f3c8ffb7cb98c906e78/src/extension.ts#L8
Here is an example of my wal colors file
› cat .cache/wal/colors
#1B2B34
#E15A60
#99C794
#FAC863
#6699CC
#C594C5
#5FB3B3
#C0C5CE
#65737E
#E15A60
#99C794
#FAC863
#6699CC
#C594C5
#5FB3B3
#D8DEE9

However, pywal supports a theme to have base-16 colors defined, like background, foreground and cursor. These values are typically used for the background and foreground of the terminal, and other tools like polybar which can use pywal themes. Here is a predefined pywal theme that has these properties
Below is an example of my colors.json which references these properties
› cat .cache/wal/colors.json
{
    "wallpaper": "None",
    "alpha": "80",

    "special": {
        "background": "#242B2E",
        "foreground": "#D4D4D4",
        "cursor": "#C0C5CE"
    },
    "colors": {
        "color0": "#1B2B34",
        "color1": "#E15A60",
        "color2": "#99C794",
        "color3": "#FAC863",
        "color4": "#6699CC",
        "color5": "#C594C5",
        "color6": "#5FB3B3",
        "color7": "#C0C5CE",
        "color8": "#65737E",
        "color9": "#E15A60",
        "color10": "#99C794",
        "color11": "#FAC863",
        "color12": "#6699CC",
        "color13": "#C594C5",
        "color14": "#5FB3B3",
        "color15": "#D8DEE9"
    }
}

Note that #242B2E (along with the other "special" colors) are not present in ~/.cache/wal/colors
Now in template.ts it uses color0 and color1 for the background/foreground.
https://github.com/dlasagno/vscode-wal-theme/blob/ccc84e4944aa7b7512bc7f3c8ffb7cb98c906e78/src/template.ts#L104-L105
To be more true to a pywal theme one might expect the VSCode theme to use the defined backround and foreground colors
To summarize, the background for VSCode with this theme would be based on #1B2B34 and not #242B2E making VSCode not match the rest of the system that uses #242B2E as a background color.
Hopefully I provided enough context! Please let me know if there are further clarifications I can make :slightly_smiling_face:

I know that 6 months passed since the issue was opened, but I'm finally looking back into this since I'm planning an update for the extension anyway.
Before implementing this I was wondering what colors 0 and 7 would be used for after being replaced by background and foreground. @chrishoage, could you explain to me how they're used in a setup like yours?

They're generally not in my setup. I would imagine colors.json would be used to see if background and foreground are set, and otherwise fall back to the colors pulled from the colors object in colors.json
Looking at some image-generated themes from pywal background and foreground are set to color0 and color7 respectively.
However, pywal still allows these to be set independently from the normal base16 colors, where "black" (color0) can be a different color in the theme for background.
Please let me know if there are further clarifications I can help with!

At the moment to generate the theme I pass an array of 16 colors to a template. Do you think that setting colors 0 and 7 to the ones specified for background and foreground(if present) would achieve the desired outcome?

That's a good question, I'm uncertain with out seeing it. I think the desired outcome would be things that are "background" colors (e.g. the main editor background, perhaps the sidebar background, statusbar background) would all get the background color. Foreground things (like text, selection, etc) would get the foreground color.
Another thing that might be worth considering is to pull the alpha value from the colors.json and use it for the alpha value for the background colors.

Version 1.1.0 is now available and uses the custom background and foreground entries of colors.json.
In the end, I simply changed colors 0 and 7 with background and foreground respectively.


Add main tests

Closes: #1
Signed-off-by: Michael Gasch<EMAIL_ADDRESS>

Codecov Report

Merging #7 (7fbe9ef) into main (54b3671) will increase coverage by 31.25%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main       #7       +/-   ##
===========================================
+ Coverage   14.90%   46.15%   +31.25%
===========================================
  Files           4        4
  Lines         208      208
===========================================
+ Hits           31       96       +65
+ Misses        177       99       -78
- Partials        0       13       +13

Impacted Files
Coverage Δ

cache.go
100.00% <0.00%> (+16.66%)
:arrow_up:

server.go
30.58% <0.00%> (+17.64%)
:arrow_up:

main.go
46.00% <0.00%> (+46.00%)
:arrow_up:

vsphere.go
46.93% <0.00%> (+46.93%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b3671...7fbe9ef. Read the comment docs.


Code of Conduct

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

### Tasks
- [ ] https://github.com/microsoft/vscode/issues/201576

### Tasks
- [ ] https://github.com/microsoft/vscode/issues/201260
- [ ] https://github.com/microsoft/vscode/issues/201576
- [ ] https://github.com/microsoft/vscode/issues/201533
- [ ] https://github.com/microsoft/vscode/issues/201644
- [ ] https://github.com/microsoft/vscode/issues/201643
- [ ] https://github.com/microsoft/vscode/issues/201345
- [ ] https://github.com/microsoft/vscode/issues/201687
- [ ] https://github.com/microsoft/vscode/issues/201689
- [ ] https://github.com/microsoft/vscode/issues/200777
- [ ] https://github.com/microsoft/vscode/issues/201686

Me


error : embedding models do not support chat

i'm trying  to run :  ollama run nomic-embed-text
and the response to the command is :  error : embedding models do not support chat
ollama version is 0.1.27 on linux ubuntu
what to do?

vous utilisez bien l'endpoint "embeddings" ?

but what's the problem with anythingLLM? your first message is normal you can't run an embeddings model with ollama's cli

ok, i've understand what to do
I was misled by the command given on the ollama site: ollama run nomic-embed-text

Ah, yeah, the library isn't aware of embedding-only models.

@nicho2 getting the same error, also want to use with Anything.
How did you fix it ?

@wallartup embedding-specific models can't be used for chat.

It's not necessary to run (just pull the model and :

Hi, sorry this was misleading on ollama.com – it should show ollama pull <embedding model> now! To use the embeddings models you'll need to call the /api/embeddings endpoint: https://github.com/ollama/ollama/blob/main/docs/api.md#generate-embeddings

Getting this error:

Getting this error:

not sure if ollama is the problem here, the message from your vector database

That’s what I thought but when I swap it to not use ollama for embedding it works

Getting this error:

Hi, I also met the problem. Do you know how to solve it?


the summarise function could use some more love

multiple issues

ret is assigned but then implicitly returned (either return(ret) or don't assign ret and return implicitly
unnecessary brackets normal and curled
pipe is unnecessarily broken
fixed objects is not used?

Lets reavulate


context.go(); Rebuilds the statefull widget.

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
I am developing an application with bloc and go_router. I manage api calls and bloc events via routes. I just discovered it because my stafull widgets are creating unnecessary requests.
A context.go() called from a statefull widget; regenerates the redirected page.
Expected results
The redirected page is not regenerated.
Actual results
Unnecessary rebuild
Code sample
Code sample
class MyTestWidget extends StatefulWidget {
  const MyTestWidget({super.key});
  final viewPage = AppPage.serviceList;
  @override
  State<MyTestWidget> createState() => _MyTestWidgetState();
}

class _MyTestWidgetState extends State<MyTestWidget> {
  var _viewPage;

  @override
  void initState() {
    // TODO: implement initState
    _viewPage = widget.viewPage;
    super.initState();
  }

  @override
  Widget build(BuildContext context) {
    return Column(
      children: [
        (() {
          switch (_viewPage) {
            case AppPage.serviceList:
              print('do trigger bloc event');
              return Placeholder();
            default:
              return Placeholder();
          }
        })(),
        ElevatedButton(
          onPressed: () {
            // AppRouter.router.go(RouteNames.config);
            context.go(RouteNames.config);
          },
          child: const Text('ClickToMe'),
        ),
      ],
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
I/flutter (25140): do trigger bloc event
I/flutter (25140): go config page
I/flutter (25140): do trigger bloc event

Flutter Doctor output
I don't think it's necessary.

I noticed that using Navigator on the instance Navigator.push(             //   context, ...)  or accessing the go router through a static AppRouter.router.go(RouteNames.config);  does not trigger the rebuild. I still have the problem when I use static instance in my real application. I want to continue using go_router as I plan to deeplink the route I am trying to access.
Why might the statefull widget have such a behavior?

Hi @UnreALi
Which go_router version are you using currently? There is a release version (9.0.0) that solved issue related to rebuild issue. If you are using a lower version, please try upgrading to that version or latest one and check if issue still persists or not.
Otherwise, if you are on the latest version but still seeing this issue, please provide a completed and minimal reproducible code sample that doesn’t include 3rd party plugins or complex production code, along with Steps by steps to reproduce the issue so that we may verify this properly. Thank you!

Hi. I am also seeing this issue. I am using go_router: ^9.0.0. The stateful Scaffold I'm using gets recreated only the first time a user navigates, but then it's being reused.


Checkbox doesn't include hidden input

Describe the bug
The checkbox component only shows the indicator button and doesn't render the hidden input which means the checkbox doesn't show up in form submissions unless you manually bind the value and render it in another hidden checkbox
Reproduction
https://stackblitz.com/edit/github-ofar7n?file=src%2Froutes%2F%2Bpage.svelte,src%2Froutes%2F%2Bpage.server.ts
Logs
No response
System Info
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @sveltejs/kit: ^2.0.0 => 2.5.2
    bits-ui: ^0.18.2 => 0.18.2
    cmdk-sv: ^0.0.13 => 0.0.13
    formsnap: ^0.5.0 => 0.5.0
    lucide-svelte: ^0.303.0 => 0.303.0
    mode-watcher: ^0.2.1 => 0.2.1
    svelte: ^4.2.9 => 4.2.9
    svelte-sonner: ^0.3.18 => 0.3.18
    sveltekit-superforms: ^2.5.0 => 2.5.0
    vaul-svelte: ^0.2.4 => 0.2.4

Severity
annoyance

I'd like to contribute a fix for this. Should I make a PR for this repo or bits-ui?

Fixed in @next


Fix the samples and system tests

Currently broken on master:
https://circleci.com/gh/googleapis/nodejs-asset/20

passing for circleci


Error at the end of fishing competition

[00:10:10] [Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PURPUR - THIS IS NOT A BUG OR A CRASH  - git-Purpur-1958 (MC: 1.19.4) ---
[00:10:10] [Watchdog Thread/ERROR]: The server has not responded for 10 seconds! Creating thread dump
[00:10:10] [Watchdog Thread/ERROR]: ------------------------------
[00:10:10] [Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Purpur!):
[00:10:10] [Watchdog Thread/ERROR]: ------------------------------
[00:10:10] [Watchdog Thread/ERROR]: Current Thread: Server thread
[00:10:10] [Watchdog Thread/ERROR]: 	PID: 41 | Suspended: false | Native: false | State: RUNNABLE
[00:10:10] [Watchdog Thread/ERROR]: 	Stack:
[00:10:10] [Watchdog Thread/ERROR]: 		java.base@<IP_ADDRESS>/java.lang.StringBuilder.(StringBuilder.java:106)
[00:10:10] [Watchdog Thread/ERROR]: 		org.bukkit.configuration.MemorySection.createPath(MemorySection.java:951)
[00:10:10] [Watchdog Thread/ERROR]: 		org.bukkit.configuration.MemorySection.createPath(MemorySection.java:927)
[00:10:10] [Watchdog Thread/ERROR]: 		org.bukkit.configuration.MemorySection.getDefault(MemorySection.java:863)
[00:10:10] [Watchdog Thread/ERROR]: 		org.bukkit.configuration.MemorySection.getBoolean(MemorySection.java:370)
[00:10:10] [Watchdog Thread/ERROR]: 		even-more-fish-1.6.10.jar//com.oheers.fish.config.MainConfig.databaseEnabled(MainConfig.java:41)
[00:10:10] [Watchdog Thread/ERROR]: 		even-more-fish-1.6.10.jar//com.oheers.fish.competition.Competition.handleRewards(Competition.java:706)
[00:10:10] [Watchdog Thread/ERROR]: 		even-more-fish-1.6.10.jar//com.oheers.fish.competition.Competition.end(Competition.java:112)
[00:10:10] [Watchdog Thread/ERROR]: 		even-more-fish-1.6.10.jar//com.oheers.fish.competition.Competition.processCompetitionSecond(Competition.java:162)
[00:10:10] [Watchdog Thread/ERROR]: 		even-more-fish-1.6.10.jar//com.oheers.fish.competition.Competition.decreaseTime(Competition.java:216)
[00:10:10] [Watchdog Thread/ERROR]: 		even-more-fish-1.6.10.jar//com.oheers.fish.competition.Competition.access$000(Competition.java:29)
[00:10:10] [Watchdog Thread/ERROR]: 		even-more-fish-1.6.10.jar//com.oheers.fish.competition.Competition$2.run(Competition.java:143)
[00:10:10] [Watchdog Thread/ERROR]: 		org.bukkit.craftbukkit.v1_19_R3.scheduler.CraftTask.run(CraftTask.java:101)
[00:10:10] [Watchdog Thread/ERROR]: 		org.bukkit.craftbukkit.v1_19_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483)
[00:10:10] [Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1510)
[00:10:10] [Watchdog Thread/ERROR]: 		net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:487)
[00:10:10] [Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1424)
[00:10:10] [Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1195)
[00:10:10] [Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:325)
[00:10:10] [Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer$$Lambda$4633/0x000000080164e980.run(Unknown Source)
[00:10:10] [Watchdog Thread/ERROR]: 		java.base@<IP_ADDRESS>/java.lang.Thread.run(Thread.java:833)
[00:10:10] [Watchdog Thread/ERROR]: ------------------------------
[00:10:10] [Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PURPUR - THIS IS NOT A BUG OR A CRASH ---
[00:10:10] [Watchdog Thread/ERROR]: ------------------------------

This seems to be an error with purpur servers but I'm not fully sure what causes it and nor have I been able to reproduce it. I'll push a Spigot release when this is fixed.


[BUG] Minor UI inconsistency

Describe the bug
When the a task fails but the sidebar is open, the node status doesn't update

Expected behavior
A clear and concise description of what you expected to happen.
Flyte component

[ ] Overall
[ ] Flyte Setup and Installation scripts
[ ] Flyte Documentation
[ ] Flyte communication (slack/email etc)
[ ] FlytePropeller
[ ] FlyteIDL (Flyte specification language)
[ ] Flytekit (Python SDK)
[ ] FlyteAdmin (Control Plane service)
[ ] FlytePlugins
[ ] DataCatalog
[ ] FlyteStdlib (common libraries)
[x] FlyteConsole (UI)
[ ] Other

To Reproduce
Look at a running task as it transitions to failing
Screenshots
See above
Environment
Flyte component

[ ] Sandbox (local or on one machine)
[ ] Cloud hosted

[ ] AWS
[ ] GCP
[ ] Azure

[ ] Baremetal
[ ] Other

Additional context
Add any other context about the problem here.

cc @schottra

fixed by lyft/flyteconsole#115
available in flyteconsole v0.17.2


Applied similar fix for get all episodes i.e. -A

Fixed so that -A also works
Could you update your pullrequest to spams repo?
Br

Thanks, not the first time I forget about that...


Implement PrivateKeyfile authentication method for SSH and SFTP connections

This issue relates to Connect-SFTP.ps1 and Connect-SSH.ps1.
Currently, you can only use Credential or cleartext for connecting to an SFTP server. The SftpClient ctor contains two methods for creating a new connection with key files. The one I think you will like the most is this:
Renci.SshNet.SftpClient new(string host, string username, Params Renci.SshNet.PrivateKeyFile[] keyFiles)

PrivateKeyFile can be created directly from a string and errors nicely if the path is not found or if the file listed in the path is not a valid keyfile (no contents, damaged keyfile, putty ppk, etc.)
The SFTP client can be constructed via this method:
[Renci.SshNet.SftpClient]::new($Server,$Username,[Renci.SshNet.PrivateKeyFile]".\private.key")

Note that we can also add support for (multiple keys) or (password AND private key) via multiple authentication methods as outlined here:
Renci.SshNet.SftpClient new(Renci.SshNet.ConnectionInfo connectionInfo)
Renci.SshNet.ConnectionInfo new(string host, string username, Params Renci.SshNet.AuthenticationMethod[] authenticationMethods)

As usual, the ps module thingy with  [Environment]::CurrentDirectory vs working directory always applies.

Ok, I've added a little PR that MIGHT work. I have no tested in any fashion. I will not be in a position to test it until tomorrow, so i've labeled the PR as draft for now. Feel free to edit as desired (I removed all the mandatory parameters from the SFTP params just for consistency sake). If you test and have it working, feel free to merge.

Thank you. I just woke up to this. I can't really test this as I don't have a server that supports keys, but from the code, it looks ok.
I think it's possible to use login, password, and private key right? So we need to address that possibility.

I will test the pr today when I get a minute

PR has been accepted and closed. Awesome.
As for try/catch for errors, I would expect that letting the Renci object handle that would be sufficient. But if you want to add more try/catch to it, I'm sure that it'll make things a little clearer.
My plan for this module is to try it out on my next FTP automation project, but I dunno when that will be. Once I start doing that, I'll be able to open more issues/PRs to flesh out some of the functionality that I expect from SFTP that may not be present currently.

Great - I've mostly focused on testing ftps as this is what I use. The question is how sftpclient reacts if the wrong value is provided. If nothing happens here no need for try/catch.
https://github.com/EvotecIT/Transferetto/blob/eb1630b509d8a12df76316d586485048848fb62b/Public/Connect-SFTP.ps1#L28-L37

ya, it doesn't give you a broken SFTP object. It throws. I'd say leave it
alone.
On Tue, Sep 14, 2021 at 12:30 PM Przemysław Kłys @.***>
wrote:

Great - I've mostly focused on testing ftps as this is what I use. The
question is how sftpclient reacts if the wrong value is provided. If
nothing happens here no need for try/catch.
https://github.com/EvotecIT/Transferetto/blob/eb1630b509d8a12df76316d586485048848fb62b/Public/Connect-SFTP.ps1#L28-L37
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/EvotecIT/Transferetto/issues/2#issuecomment-919410691,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPUBTZAAKYR6HLNAEFSVUTUB6IEZANCNFSM5DAVNFDQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Well if it throws - it's going to be red. I prefer to have Warning by default, and if someone provides ErrorAction Stop - then throw an error and stop.
https://github.com/EvotecIT/Transferetto/blob/eb1630b509d8a12df76316d586485048848fb62b/Public/Connect-SFTP.ps1#L42-L53


Create disable_tracking_specific_link

Hello @iritch42,Thank you for the PR! We will be reviewing this PR soon, in the mean                                              time, please be sure to                                                                                sign our CLA so that we can merge your changes. Thanks again!                                             Team DX

Hey Ian - thanks for adding this! This page should be in with the other click tracking pages. If you want to add it in with the the other click tracking stuff go ahead and open another pull request.


Setting dynamic width to Row Header

Tried applying the same logic in cell in the RowViewHolder
public void setRowHeader(RowHeader rowHeader) {
        row_header_textview.setText(String.valueOf(rowHeader.getData()));
        // If your TableView should have auto resize for cells & columns.
        // Then you should consider the below lines. Otherwise, you can remove them.

        // It is necessary to remeasure itself.
        root.getLayoutParams().width = RelativeLayout.LayoutParams.WRAP_CONTENT;
        row_header_textview.requestLayout();
    }

But the row header cells are not expanding horizontally.Its taking the default width .
Any one having the solution?

Hi @raviyadav4875
The reason is row header width value should be constant.  I mean, calculating width value feature works for columns and their cells not for row headers.

Is there any way to make them dynamic? will this be a feature added in the future?

@evrencoskun any fix for this?

@evrencoskun any fix for this?

@raviyadav4875 did u find the fix for this? I need it in my project.

@sairam1501 I haven't found any fix for this.


FactoryGirl not available as is from Cucumber

features/support/env.rb does not have following line :
World(FactoryGirl::Syntax::Methods)

Shall it be left at one's customization willingness ?

Done. And faker too.
Thanks ;-)


From header must be equal to ...

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App version
6.603
Where did you get the app from?
Google Play
Android version
6.603
Device model
poco X3  NFC
Steps to reproduce
1: settings , account settings
2: sending mail -> Manage Identities
3: manage identities ... create a new identity<EMAIL_ADDRESS>(where I own mydomain.com)
3: send an email selecting the new identity as the sender
4: Mail appears to send, but later the notification appears:
Failed to send some messages
From header must be equal to ....
Where the ... is e.g<EMAIL_ADDRESS>(the initial identity)
Expected behavior
I use Thunderbird on Linux to send main email. This is entirely because I can set the from header (the only other way is the use sendmail directly on the command line). So my outgoing email is always from:
<EMAIL_ADDRESS>... never<EMAIL_ADDRESS>Then, as usually happens they sell my e-mail address and I start to get SPAM,  I block that address.
Currently I can't send email while away from the house (and a desktop Linux system) . The move of K9 to be Thunderbird for mobile meant I was finally able to send email "on the move"
The UI seems a little different. I expected to just be able to type in the from line in each mail message. It seems I had to go through the steps to create an new identity of each and every company I deal with (so this list is going to grow to hundreds)  ...Thunderbird does have this concept of create a new identity , I also use this for example to use encryption with certain people, but I one need one or two of these.
I see there are feature requests to allow the direct edit of the from header and I'd add my voice to those, but in the meanwhile I would expect the message to send.
FYI: I did a wireshark trace and I did not see any traffic from K9 to the SMTP server, so it looks like the bug is "local" ... I know my MTA will accept the graeme.name format as this is what I do on every email via Thunderbird
Actual behavior
Failed to send some messages
From header must be equal to ....
(AFYI I tried the graeme+name@  style and this failed in t he same fashion.
Logs
none

You are correct. The MTA supported different logins ... each imposed different rules. I switched to the "wildcard" version and it worked fine. Thanks for the help.
As an aside:
1: This would have been easier if the error message had made it clear it was a message from the remote sever vs K9 itself (a prefix on messages?)
2: The mechanism for setting the from header is much harder to use than the thunderbird version
(it could be just like reply-to header setting?)


Minimize the scope of KUBEVIRT_POSTINBOUND chain

What this PR does / why we need it:
Currently, in case the vm has a list of supported ports, the source
address of the incoming traffic to the vm is substituted by the address of
k6t-eth0 bridge (relevant for both ipv4 and ipv6).
The only reason for this behaviour I could find is for connecting to the vm
using localhost address as the destination (from an app inside the
virt-launcher pod).
In this case the source address would probably be also localhost.
The vm will try to reply to local host but of course won't succeed since the reply will stay
inside the vm and won't reach the default route.
So in this specific case, the substitution of the source address (localhost) to the bridge address is indeed needed.
However, couldn't find any other use case for this substitution.
More over, the behaviour may be harmful since the vm thinks all its
clients have the same ip address.
The PR minimizes the rules to do the substitution only in case the source address is localhost.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/retest

Based on http://linux-ip.net/html/routing-saddr-selection.html , for host generated traffic, it is enough to dnat the packets, the source will be determined by the exgress interface IP. So no snat is needed.

Based on http://linux-ip.net/html/routing-saddr-selection.html , for host generated traffic, it is enough to dnat the packets, the source will be determined by the eggress interface IP. So no snat is needed.

I was wrong, the egress is determined before the OUTPUT chain, after which it needs to be overwritten using SNAT. Sorry for the noise.

https://travis-ci.org/github/kubevirt/kubevirt/builds/691442496#L2158

/retest

The only reason for this behaviour I could find is for connecting to the vm
using localhost address as the destination (from an app inside the
virt-launcher pod).
In this case the source address would probably be also localhost.
The vm will try to reply to local host but of course won't succeed since the reply will stay
inside the vm and won't reach the default route.
So in this specific case, the substitution of the source address (localhost) to the bridge address is indeed needed.

This may be related to istio. @phoracek @SchSeba do you remember the details here?

/retest

The only reason for this behaviour I could find is for connecting to the vm
using localhost address as the destination (from an app inside the
virt-launcher pod).
In this case the source address would probably be also localhost.
The vm will try to reply to local host but of course won't succeed since the reply will stay
inside the vm and won't reach the default route.
So in this specific case, the substitution of the source address (localhost) to the bridge address is indeed needed.

This may be related to istio. @phoracek @SchSeba do you remember the details here?

Yes, indeed for istio (or any other side car/virt-launcher internal proccess communicating with the vm) this rule may be relevant.
The 'minimized rule' is enough for those cases.
Couldn't find any reason for having the rule for traffic with source address other than the localhost.

/retest

/retest

The only reason for this behaviour I could find is for connecting to the vm
using localhost address as the destination (from an app inside the
virt-launcher pod).
In this case the source address would probably be also localhost.
The vm will try to reply to local host but of course won't succeed since the reply will stay
inside the vm and won't reach the default route.
So in this specific case, the substitution of the source address (localhost) to the bridge address is indeed needed.

This may be related to istio. @phoracek @SchSeba do you remember the details here?

Only that istio has some expectations. I don't know what those are and we don't have tests for istio, so it would be only blind assumption anyway.
I'm ok with this change. Once we start integrating (testing) istio, we can revisit this.

/approve


A reference should be added for linking with cimfs.lib

The documentation should include this as a requirement for linking.

@TimMangan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Excellent point, thank you!


Please provide your stack

Hello ! as part of the pre-hackfest checklist, we asked you to describe the stack of software that you will be using in your project.
We want you to do this with StackShare. Please create a new stack and let us know the url of your stack. Only one per project.

Dear Bruce,
URL of my stackshare is: http://stackshare.io/icuzochukwu
On 11/23/16, Bruce Becker<EMAIL_ADDRESS>wrote:

Hello ! as part of the pre-hackfest
checklist, we
asked you to describe the stack of software that you will be using in your
project.
We want you to do this with StackShare. Please
create a new stack and let us know the url of your stack. Only one per
project.
--
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub:
https://github.com/sci-gaia/LagosHackfest/issues/20

--
Uzochukwu, Ikemefuna C. Ph.D
Department of Pharmaceutical and Medicinal Chemistry,
Faculty of Pharmaceutical Sciences,
Nnamdi Azikiwe University,
PMB 5025 Awka 420281,
Anambra State, Nigeria.
+234<PHONE_NUMBER>
**
*``Whatever is believed can be done´´ *

Ok, thanks


feat: Token Exchange (RFC 8693)

This PR implements OAuth2 Token Exchange in OP according to RFC 8693 (and client code)
Some implementation details:

OP parses and verifies subject/actor tokens natively if they were issued by OP
Third-party tokens verification is also possible by implementing additional storage interface
Token exchange can issue only OP's native tokens (id_token, access_token and refresh_token) with static issuer

👋 Hi There
Thank you for this PR, this looks awesome.
Please give us some time to schedule the review of this. Since the holiday season comes up our resources are a little tight 😁
Question: @livio-a would this be something where also @stebenz could assist?

Hey @lefelys
First of all, thank you very much for this PR. Unfortunately, i did not have time to have a close look at it.
I'll try later this week of at least the beginning of next.

I've updated the comments, after going though them with my colleague. Irrelevant ones are put on resolved. For the ones that remain, a kind request to solve them.
I took the liberty to merge next into your branch and resolve the merge conflicts, as there were a lot of changes on our side in the last weeks.

awesome, thanks! :pray:


maxCount

maxCount doesn't working to limit the images uploads. Can you give an example how to write the script.?

Hi there!
Hmm, I see that you're setting the option correctly - have you made sure that your version is updated to the latest release? That'll be version 4.0.8.
I made a quick codepen to show that the maxFileCount is working correctly on the latest version.
Try that and let me know, thanks!

Thank you so much. It works with the updated version. :)
On Nov 21 2019, at 4:09 am, John Datserakis<EMAIL_ADDRESS>wrote:

Hi there!
Hmm, I see that you're setting the option correctly - have you made sure that your version is updated to the latest release? That'll be version 4.0.8.
I made a quick codepen (https://link.getmailspring.com/link/4B1B1F46-EDAE-4E3F-9E89-F4A8DEE75169@getmailspring.com/0?redirect=https%3A%2F%2Fcodepen.io%2Fjohndatserakis%2Fpen%2FpooYwJQ%3Feditors%3D1010&recipient=cmVwbHkrQUhGM0RYSExNRjRFNEJONjVKWFNTUEYzNExXREZFVkJOSEhCNktOVVQ0QHJlcGx5LmdpdGh1Yi5jb20%3D) to show that the maxFileCount is working correctly on the latest version.
Try that and let me know, thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/4B1B1F46-EDAE-4E3F-9E89-F4A8DEE75169@getmailspring.com/1?redirect=https%3A%2F%2Fgithub.com%2Fpromosis%2Ffile-upload-with-preview%2Fissues%2F26%3Femail_source%3Dnotifications%26email_token%3DAHF3DXGMTGKXMR4WP5BA7ELQUWYTFA5CNFSM4JNKYUNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEVP7TQ%23issuecomment-556466126&recipient=cmVwbHkrQUhGM0RYSExNRjRFNEJONjVKWFNTUEYzNExXREZFVkJOSEhCNktOVVQ0QHJlcGx5LmdpdGh1Yi5jb20%3D), or unsubscribe (https://link.getmailspring.com/link/4B1B1F46-EDAE-4E3F-9E89-F4A8DEE75169@getmailspring.com/2?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHF3DXDS2GM5ZSIGAXB7MYLQUWYTFANCNFSM4JNKYUNA&recipient=cmVwbHkrQUhGM0RYSExNRjRFNEJONjVKWFNTUEYzNExXREZFVkJOSEhCNktOVVQ0QHJlcGx5LmdpdGh1Yi5jb20%3D).


Blank screen when switching back to Chrome OS from Trusty

I was able to log what was happening after I start xfce. When I go back into chrome OS, it's a black screen but the buttons still work so it's clearly running (I can raise or lower my volume on the black screen).
I can easily switch back into xfce and I can also restart the machine to get back to chrome OS, but I effectively can't switch screens without restarting.
chronos@localhost / $ sudo startxfce4
Password:
Entering /mnt/stateful_partition/crouton/chroots/trusty...
/usr/bin/startxfce4: Starting X server
_XSERVTransmkdir: ERROR: euid != 0,directory /tmp/.X11-unix will not be created.
X.Org X Server 1.15.1
Release Date: 2014-04-13
X Protocol Version 11, Revision 0
Build Operating System: Linux 3.2.0-76-generic x86_64 Ubuntu
Current Operating System: Linux localhost 3.14.0 #1 SMP Fri Mar 20 15:41:09 PDT 2015 x86_64
Kernel command line: cros_secure console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 2506752 verity payload=PARTUUID=cdff06a0-ad87-f246-8505-4b0b37336cdf/PARTNROFF=1 hashtree=PARTUUID=cdff06a0-ad87-f246-8505-4b0b37336cdf/PARTNROFF=1 hashstart=2506752 alg=sha1 root_hexdigest=5d5557b5b04108e7ce8162c9f15eb3149ec4163a salt=a9343ded2666b5870d2398f860f7ef9c75986bb11576ba379b0941335289303f" noinitrd vt.global_cursor_default=0 kern_guid=cdff06a0-ad87-f246-8505-4b0b37336cdf add_efi_memmap boot=local noresume noswap i915.modeset=1 tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic i915.enable_psr=1
Build Date: 12 February 2015  02:49:29PM
xorg-server 2:1.15.1-0ubuntu2.7 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.30.2
Before reporting problems, check http://wiki.x.org
to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
(++) from command line, (!!) notice, (II) informational,
(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Sun Apr 12 23:04:46 2015
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
Initializing built-in extension Generic Event Extension
Initializing built-in extension SHAPE
Initializing built-in extension MIT-SHM
Initializing built-in extension XInputExtension
Initializing built-in extension XTEST
Initializing built-in extension BIG-REQUESTS
Initializing built-in extension SYNC
Initializing built-in extension XKEYBOARD
Initializing built-in extension XC-MISC
Initializing built-in extension SECURITY
Initializing built-in extension XINERAMA
Initializing built-in extension XFIXES
Initializing built-in extension RENDER
Initializing built-in extension RANDR
Initializing built-in extension COMPOSITE
Initializing built-in extension DAMAGE
Initializing built-in extension MIT-SCREEN-SAVER
Initializing built-in extension DOUBLE-BUFFER
Initializing built-in extension RECORD
Initializing built-in extension DPMS
Initializing built-in extension Present
Initializing built-in extension DRI3
Initializing built-in extension X-Resource
Initializing built-in extension XVideo
Initializing built-in extension XVideo-MotionCompensation
Initializing built-in extension SELinux
Initializing built-in extension XFree86-VidModeExtension
Initializing built-in extension XFree86-DGA
Initializing built-in extension XFree86-DRI
Initializing built-in extension DRI2
Loading extension GLX
xf86EnableIOPorts: failed to set IOPL for I/O (Operation not permitted)
crouton: version 1-20150411190710~master:7adac7a1
release: trusty
architecture: amd64
xmethod: xorg
targets: xfce
host: version 6680.78.0 (Official Build) stable-channel samus
kernel: Linux localhost 3.14.0 #1 SMP Fri Mar 20 15:41:09 PDT 2015 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
No Chromium OS X server is available.
_IceTransmkdir: ERROR: euid != 0,directory /tmp/.ICE-unix will not be created.
xfce4-session: No gpg or ssh authentication agent found
/usr/bin/xbindkeys_autostart: line 24: CONF: unbound variable
(polkit-gnome-authentication-agent-1:16033): GLib-CRITICAL **: g_variant_new_string: assertion 'string != NULL' failed
(polkit-gnome-authentication-agent-1:16033): polkit-gnome-1-WARNING **: Failed to register client:

I think I got the same issue with utopic (trusty works fine), see: https://github.com/dnschneid/crouton/issues/1519

I should mention, I was having problems with a video game crashing in Trusty (Civilization 5). After a lot of searching for fixes, I was able to solve it by doing this:
add-apt-repository ppa:ubuntu-x-swat/x-updates
add-apt-repository ppa:oibaf/graphics-drivers
apt-get update && apt-get dist-upgrade
After this, Civilization 5 worked well, but then the next time I switched over to Chrome OS, it was just a black screen.

 If it does, it's probably related to overheating and something at the backend crashes. I had used the exact same PPA to test some games like Half-Life 2 and Hotline Miami and the frame-rate was decent with less jitters than drivers from other PPAs . After about 10 minutes, fan starts spinning like helicopter. If I continue playing, system becomes unstable after another 5-10 minutes. One time I also got the black screen when switching back to ChromeOS. Another time system just froze and rebooted.
Playing WebGL-based game in ChomeOS like "Save the Day" also causes fan to spin really fast, but no reboot so far. In my case, I think ASUS Chromebox's cooling is just not good enough for such graphics-intensive job, or maybe ChromeOS is really sensitive to overheating. Just my guess.

@chrisjamesberg I have also had the same problem. Running Trusty with Gnome, CIV5 would crash. I updated intel video drivers and civ5 worked but switching back to chromeos resulted in black screen. @haojiezhu I don't believe it has to do with overheating. I've updated the video drivers on many chroots with pixel 2, sometimes playing civ 5 and sometimes never installing steam in the first place — always screen goes black. This is a bug in chromeos. If you bring your linux chroot's video driver up to date, chromeos display fails (goes black).  dnschneid is aware of bug and it is being addressed: https://github.com/dnschneid/crouton/issues/1519

Same issue, also get blank screen after logging off of trusty.
No games or high intensive apps ran in my trusty session, tried logging in and immediately swapping back to chromeos, and it is a blank screen.
Only way to fix blank screen for me so far is to hard reset the device.

Make sure Chrome OS is in Stable channel.

Did you install  drivers to make Civ 5 not crash on startup? I too had the same problem with the crashing, and it seems that a side affect of installing the drivers breaks switching back to chrome os.
Instead, uninstall these


update vulkan packages to 1.2.198

Updated:

vulkan-headers to sdk 1.2.198
vulkan-hpp to sdk 1.2.198
vulkan-loader to sdk 1.2.198
vulkan-tools to sdk 1.2.198
vulkan-validationlayers to sdk 1.2.198

windows ci fails. Maybe we need also update SPIRV-Headers to sdk-<IP_ADDRESS>? https://github.com/KhronosGroup/SPIRV-Headers/releases/tag/sdk-<IP_ADDRESS>
https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/3553
Or you can split this pr and update Vulkan-ValidationLayers separately so that the patch can be merged quickly

How can I fix this error ? :thinking:
error: @programdir\core\main.lua:280: @programdir\modules\private\action\require\impl\package.lua:868: package(spirv-headers/1.2.198+0-sdk:{"vs_runtime=MT"}): conflict dependences with package(spirv-headers/latest:{"vs_runtime=MT"})!

I understand that versions aren't the sames between those provided and the one I'm currently adding but nothing more.

How can I fix this error ? 🤔
error: @programdir\core\main.lua:280: @programdir\modules\private\action\require\impl\package.lua:868: package(spirv-headers/1.2.198+0-sdk:{"vs_runtime=MT"}): conflict dependences with package(spirv-headers/latest:{"vs_runtime=MT"})!

I understand that versions aren't the sames between those provided and the one I'm currently adding but nothing more.

There is no good way yet. The version rules of spirv-headers have changed. Its latest version number is lower than 1.5.4, and vulkan-validationlayers 1.2.198 must depend on spirv-headers 1.2.198
And spirv-tools also depends on spirv-headers, vulkan-validationlayers also depends on them, so spirv-tools must also depend on spirv-headers 1.2.198


feat(analytics): add analytics iframe on admin view

What?

add analytics iframe on admin view

@Mahaveer1141 - can we add a sample screenshot of how this looks please?

@mikevic


refactor: move modules to their usage (WIP)

This is just a demo, didn't fix any imports.

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   98.68%   98.68%
=======================================
  Files         152      152
  Lines        2213     2213
=======================================
  Hits         2184     2184
  Misses         29       29

Impacted Files
Coverage Δ

client/app/components/_joinGroup/joinGroup.js
100% <ø> (ø)
:white_check_mark:

...bar/_languageChooser/languageChooser.controller.js
100% <ø> (ø)

...nents/group/_createStore/createStore.controller.js
100% <ø> (ø)

...oup/_pickupList/_createPickup/createPickup.spec.js
100% <ø> (ø)

client/app/services/store/store.spec.js
100% <ø> (ø)

...app/services/authentication/authentication.spec.js
100% <ø> (ø)

...pbar/_languageChooser/languageChooser.component.js
100% <ø> (ø)

...pp/components/group/_pickupList/pickupList.spec.js
100% <ø> (ø)

client/app/services/group/group.js
100% <ø> (ø)

client/app/services/group/currentGroup.spec.js
100% <ø> (ø)

... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730ebf4...ab0feff. Read the comment docs.


unimported fct

thanks for this repo,
This fct is non imported, thus undefined.
https://github.com/marcoaversa/diffinfinite/blob/4d2309606e5ce6190828b96f436cfa962ec5d1ec/dm.py#L592
I guess one could import it from
dm_masks.py:75

Thanks for the feedback. We forgot to remove the normalise_to_neg_one_to_one function. In our case we manually normalise the latent by a factor instead of mapping the data into [-1,1]. This is because the data clipped in the VQVAE latent space were introducing biases in the colour of the synthetic images, we will fix it soon.

Thanks for the reply,
I also noticed that my generated images are significantly brighter than the ground truth, maybe this could be the cause,
Looking forward for the fix :) !

actually it looks like the fix is actually already present:

Yep! The factor 50 should be adapted to your own dataset. In our case 50 was a good value to limit the noise to go over [-1,1] on each step. Unfortunately I don't have an ETA at the moment due to several project ongoing. I would expect that I can fix and polish it properly in 3 weeks.

okay thanks


Module 1.1 Assignment

Given what you have learned about Git, why would you want to use Git in your classroom?

Students should work in teams for most of the courses and more than been a simple tool, Git is a content they should master.


Topics to Edit and Apply Template

This is a...

[ x] Feature Request
[ ] Bug Report

For each of the topics below:

If the topic is not already in one of the templates, apply the Task, Tutorial, or Concept template.
Edit the topic to comply with the style guide.
Check for accuracy.

Pod Overview
Make sure the terminology is accurate and consistent. For example, this statement is misleading: "A Pod represents a running process on your cluster". The word process means a certain thing in Linux. And a Pod can have more than one process.
Tools for Monitoring Compute, Storage, and Network Resources
Master-Node Communication
Auditing
If possible, change the title to imperative form. If this topic seems like it covers too much, split it into two or more Task topics.
Nodes
Pods
Replication Controller
Put a note at the beginning of this topic: Replication Controller. In the note, explain that Deployment, along with a ReplicaSet, is the preferred way to do replication.
Labels and Selectors
Consider consolidating with Annotations.
Perform Rolling Update Using a Replication Controller
Logging with Stackdriver
Logging Using Elasticsearch and Kibana

PR #4537 addresses only the ReplicationController item in the original list. The PR also performs some cleanup on Deployments and ReplicaSets, although the latter two could use some more attention.

/assign

/remove-lifecycle rotten

/priority backlog

@sftim is this still relevant in our post-template Docsy world?

Good point. I'm going to close it; @steveperry-53 if that was unwise of me, please feel free to reopen it.

/close


Colored man pages don't work

Using antidote with
ohmyzsh/ohmyzsh path:plugins/colored-man-pages  # load OMZ plugins
doesn't result in colored man pages. Other plugins from OMZ seem to work.

Sorry, forgot to use
getantidote/use-omz        # handle OMZ dependencies
ohmyzsh/ohmyzsh path:lib   # load OMZ's library

before


[CH-120] Support memory manager

对接spark的内存管理

Can one of the admins verify this patch?

test please with 454

test this please with 454

test this please with 454

test this please with 454

test this please with 454


Aggregate with std::optional compile error

The following code does not compile. Is this intentional?
#include <optional>

#include "zpp_bits.h"

struct Foo {
    float a;
};
struct Bar {
    std::optional<Foo> foo;
};

int main() {
    static_assert(std::is_aggregate_v<Bar>);

    auto [data, out] = zpp::bits::data_out();
    zpp::bits::success(out(Bar{}));

    return 0;
}

where this does compile:
#include <optional>

#include "zpp_bits.h"

struct Foo {
    float a;
};
struct Bar {
    constexpr static auto serialize(auto & archive, auto & self)
    {
        return archive(self.foo);
    }

    std::optional<Foo> foo;
};

int main() {
    static_assert(std::is_aggregate_v<Bar>);

    auto [data, out] = zpp::bits::data_out();
    zpp::bits::success(out(Bar{}));

    return 0;
}

Try to specify the number of members explicitly as documented in the readme -
the number of members detection is not 100% due to relying on aggregate initialization to count members

Closing for inactivity


Report Fixed Asset - Projected Value (5607) - sum is not correct

Hello!
If I use report Fixed Asset - Projected Value (5607) as you can see on first image, is the sum correct? Always is shown the last amount from 12/31/2023.

Sorry, we cannot investigate or fix bugs reported in this forum. You should report hotfix requests via technical support, this way they will be fixed for reported version.


Dapp store/ Personal user's main page

https://www.figma.com/file/iu2QNG0VK2MpSLn0aokFjZ/DApp-Store-v2?node-id=150%3A926

My Dapps - clickable - goes to the main page My Papp store
Beam Dapps - hide, will be in the latest release
Link to the Publishers List (separate task) #903
Become a publisher - Link to pop-up with form for publisher. (separate task) #905
Beam's app card (separate task) #911
Users app card.  (separate task) #911
present form to upload dapp from the file.

Checked


[#109] Pulsar binary protocol documentation

Motivation
Added documentation for binary protocol specification

CLA is valid!

CLA is valid!

@saandrews updated

@saandrews Updated again

👍


COCIRS_5905 Illegal SPACECRAFT_CLOCK_STOP_COUNT

From pds-webserver created by rfrenchseti: SETI/pds-webserver#33
2019-06-11 02:36:01 | pds.opus_import.main |--| WARNING | [COCIRS_5905 index row 1] Badly formatted SPACECRAFT_CLOCK_STOP_COUNT "0/ 50.000"
2019-06-11 02:36:02 | pds.opus_import.main |--| WARNING | [COCIRS_5905 index row 2] Badly formatted SPACECRAFT_CLOCK_STOP_COUNT "1/ 50.000"

We are not going to mess with the COCIRS_5/6xxx again until after the team's final delivery (November 2020 if we're lucky). At that time, we will go through the errata files in the pds-webserver repo and address any matters like this. This error is already logged in an errata file, so that's good enough.


Visibility changes are not propagated to Elements

Works only. Grants are fine.

I think this is the same as the issue here.


⚠ PrivateHD has degraded performance

In 114bfc6, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 25404 ms

Resolved: PrivateHD performance has improved in bafc1ca.


unable to configure Onlyoffice documentserver default.json file

Describe the bug
I am unable to edit the /run/onlyoffice/config/default.json file to configure onlyoffice documentserver through nix parameters.
And if I edit it manually, it is overwritten on each reboot.
Steps To Reproduce
Steps to reproduce the behavior:

enable onlyoffice document server services.onlyoffice = {enable = true; hostname = "localhost";};
echo  /run/onlyoffice/config/default.json
reboot
the modification in default.json disappear

Expected behavior
Being able to configure the default.json file directly in the service config.
It is a json file, so maybe it is possible to just set any parameters from the nix config to the json file with a simple conversion from nix to json.
Additional context
In my case, I need to modify these values :
      "request-filtering-agent": {
        "allowPrivateIPAddress": true,
        "allowMetaIPAddress": false
      },

Notify maintainers
@SuperSandro2000
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.32, NixOS, 24.05 (Uakari), 24.05.20240531.805a384`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `not found`

Add a :+1: reaction to issues you find important.

I tried to add this which according to this line
  environment.sessionVariables = {
    ALLOW_META_IP_ADDRESS = "true";
    ALLOW_PRIVATE_IP_ADDRESS = "true";
  };

But this does not seem to have any effect.

We are doing some hacky stuff at https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/web-apps/onlyoffice.nix#L220-L259
we probably need to add a new option, to generally patch that file.

Each time the onlyoffice systemd service is started, the default.json file is copied over from the store and modified based on your service settings. This is the hacky stuff @SuperSandro2000 mentioned and the reason your modification to /run/onlyoffice/config/default.json are reset on each reboot.
However, onlyoffice also looks for a local.json file in the same folder as default.json. This local.json file should only contain the settings that actually are different from the default settings. The onlyoffice documentation actually seems to suggests to use the local.json file, see: https://helpcenter.onlyoffice.com/installation/docs-developer-configuring.aspx
For me, adding the following to my config worked nicely:
systemd.services.onlyoffice-docservice =
  let
    createLocalDotJson = pkgs.writeShellScript "onlyoffice-prestart2" ''
      umask 077
      mkdir -p /run/onlyoffice/config/

      cat >/run/onlyoffice/config/local.json <<EOL
      {
        "wopi": {
          "enable": true
        }
      }
      EOL
    '';
  in
  {
    serviceConfig.ExecStartPre = [ createLocalDotJson ];
  };

This approach just adds a second pre-start script that creates the local.json. Since this script and the one form the service definition both execute mkdir -p /run/onlyoffice/config/, it should not even matter which script is run first.


SQLFileChange broken relative path resolving

Search first

[X] I searched and no similar issues were found

Description
After upgrading from 4.15.0 to 4.21.1 we found exception, when execute our scripts.
We are often using relative pathes to our changes. So it works correctly until we updates to last release.
Steps To Reproduce
We have changeset into another changeset with relative path to parent
<changeSet author="nufefelov" id="Create_tables" runOrder="first">
        <comment>Создание таблиц</comment>
        <sqlFile relativeToChangelogFile="true"
                 path="../../oracle/crtable.sql"
                 encoding="Cp1251"
                 dbms="oracle"/>
        <sqlFile relativeToChangelogFile="true"
                 path="../../postgresql/crtable.sql"
                 encoding="UTF-8"
                 dbms="postgresql"/>
    </changeSet>

Since update we got error
liquibase.exception.LiquibaseException: liquibase.exception.UnexpectedLiquibaseException: java.io.FileNotFoundException: JAR entry com/asuproject/usoi/db/manage/scripts/liquibase/scheme/../../oracle/crtable.sql not found in D:\usoi5\master\core\build\libs\exploded\core.war\WEB-INF\lib\com.asuproject-usoi-db-scripts-5.x.jar
Expected/Desired Behavior
I found, that there are changes in SQLFileChange.java
There is method, that calculates relative path correctly (4.15.0)
@Override
    public InputStream openSqlStream() throws IOException {
        if (path == null) {
            return null;
        }

        InputStream inputStream;
        try {
            String relativeTo = null;
            if (ObjectUtil.defaultIfNull(isRelativeToChangelogFile(), false)) {
                relativeTo = getChangeSet().getChangeLog().getPhysicalFilePath();
            }
            inputStream = Scope.getCurrentScope().getResourceAccessor().openStream(relativeTo, path);
        } catch (IOException e) {
            throw new IOException("Unable to read file '" + path + "'", e);
        }

        if (inputStream != null) {
            return inputStream;
        }
        throw new IOException(FileUtil.getFileNotFoundMessage(path));
    }

And there is new version of this code, that does’not work from 4.21.1
@Override
    public InputStream openSqlStream() throws IOException {
        if (path == null) {
            return null;
        }

        ResourceAccessor resourceAccessor = Scope.getCurrentScope().getResourceAccessor();
        if (ObjectUtil.defaultIfNull(isRelativeToChangelogFile(), false)) {
            return resourceAccessor.get(getChangeSet().getChangeLog().getPhysicalFilePath()).resolveSibling(path).openInputStream();
        } else {
            return resourceAccessor.getExisting(path).openInputStream();
        }
    }

The method resolveSiblings() does’nt resolve it.
Liquibase Version
4.21.1
Database Vendor & Version
No response
Liquibase Integration
No response
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
Windows 10
Additional Context
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR (Thank you!)

The changeset is located in com/asuproject/usoi/db/manage/scripts/liquibase/scheme/ and the scripts in something similar to com/asuproject/usoi/db/manage/scripts/oracle/crtable.sql, is it correct?

Yes. It is correct

Thank you very much @bostandyksoft, and sorry for the late reply.
I tested your directory structure with different tests cases and all of them worked properly.
Anyway, I will try to perform further tests try finding the error.

Hi.
Yes. It is inside another (common) changelog.xml and includes by following way
<include relativeToChangelogFile="true" file="scheme/CreateScheme.xml" context="install"/>

Thank you very much for the feedback @bostandyksoft.
I think the issue closely resembles #3200, it may be caused by the same problem.

@filipelautert - even though this ticket is not marked as "willing to submit a PR", I'd like to request development guidance on fixing this newly introduced change to behavior.

Hello @jccampanero ! Were you able to reproduce this issue?

Sorry for the late reply @filipelautert.
No, I did some initial testing, that's the reason I identified that this issue might be related to #3200, but I'm sorry, I've been very busy at work with limited sparse time and couldn't continue working on the issue.
I'm still busy, although now I have more free time: I could work on it if you wish.

@jccampanero I see, no problems! We had some path fixes that were added to 4.23.0 , maybe it's already fixed there?
@bostandyksoft do you think you can try it with 4.23.0 ?

Sorry for the late reply @filipelautert.
Thank you very much for the feedback, I will try reviewing it in version 4.23.0.
Thank you very much again!!

Hi @jccampanero,
Have you had a chance to reproduce this issue using 4.23.0?
Thanks,
Daniel.

No @MalloD12 Daniel, sorry, I haven't tried it yet. I'm so sorry, I've had very little free time. I will try to do my best to test it asap. Sorry again.

Hi @jccampanero,
No worries, I was just checking as I was going through some of the tickets on our list.
Thanks,
Daniel.

Hi @MalloD12,
Sorry for the late reply.
I perform some simple tests with the latest Liquibase version as of writing, 4.23.1, and I was unable to reproduce the issue.
The same is true for the issue #3200, the provided failing test case now success.
Please, be aware that, in contrast, I experienced some strange behavior when testing the YAML example proposed for the #3200 issue. It is the following.
The YAML provided in the issue doesn't define an author field:
databaseChangeLog:
  - changeSet:
      id: create-schema
      changes:
        - sqlFile:
            path: sql/sql-file.sql
            relativeToChangelogFile: true
            splitStatements: false

If you try to perform liquibase update then it will cause the following error:
Unexpected error running Liquibase: La columna "AUTHOR" no permite valores nulos (NULL)
NULL not allowed for column "AUTHOR"; SQL statement:
INSERT INTO PUBLIC.DATABASECHANGELOG (ID, AUTHOR, FILENAME, DATEEXECUTED, ORDEREXECUTED, MD5SUM, DESCRIPTION, COMMENTS, EXECTYPE, CONTEXTS, LABELS, LIQUIBASE, DEPLOYMENT_ID) VALUES (...)

Please, note that it causes that the corresponding migration record will not be inserted in DATABASECHANGELOG but the migration script is executed, the test table referenced in sql-file.sql is created.
If you try updating again, after including author in the YAML file, then Liquibase will fail because as stated, the test table defined in the migration script already exists.
Perhaps the existence of the field author could be validated before executing the changeSet to avoid this type of problems.

Thanks so much @jccampanero for taking the time to perform this testing effort. We highly appreciate it. I have created #4837 for the SQL file issue you found.
I'm closing this issue as it wasn't reproduced in 4.23.1. Please feel free to reopen if anyone can still see this issue happening.
Thanks,
Daniel.


Fix handling of custom service properties

This PR will:

Enable the use of custom service properties such as enc and sig in the examples below:
{
  id              : 'did:dht:5cahcfh3zh8bqd5cn3y6inoea1b3d6kh85rjksne9e5dcyrc1ery#dwn',
  type            : 'DecentralizedWebNode',
  serviceEndpoint : 'https://example.com/dwn',
  enc             : '#enc',
  sig             : '#sig',
}

{
  id              : 'did:dht:5cahcfh3zh8bqd5cn3y6inoea1b3d6kh85rjksne9e5dcyrc1ery#dwn',
  type            : 'DecentralizedWebNode',
  serviceEndpoint : 'https://example.com/dwn',
  sig             : ['#auth', '#assert'],
}

Add test coverage for handling string and array custom service properties.

This PR will:

Enable the use of custom service properties such as enc and sig in the examples below:
{
  id              : 'did:dht:5cahcfh3zh8bqd5cn3y6inoea1b3d6kh85rjksne9e5dcyrc1ery#dwn',
  type            : 'DecentralizedWebNode',
  serviceEndpoint : 'https://example.com/dwn',
  enc             : '#enc',
  sig             : '#sig',
}

{
  id              : 'did:dht:5cahcfh3zh8bqd5cn3y6inoea1b3d6kh85rjksne9e5dcyrc1ery#dwn',
  type            : 'DecentralizedWebNode',
  serviceEndpoint : 'https://example.com/dwn',
  sig             : ['#auth', '#assert'],
}

Add test coverage for handling string and array custom service properties.

I believe it should look like
   {
     id              : 'did:dht:5cahcfh3zh8bqd5cn3y6inoea1b3d6kh85rjksne9e5dcyrc1ery#dwn',
     type            : 'DecentralizedWebNode',
     serviceEndpoint : 'https://example.com/dwn',
     enc             : 'enc',
     sig             : 'sig',
   }

   {
     id              : 'did:dht:5cahcfh3zh8bqd5cn3y6inoea1b3d6kh85rjksne9e5dcyrc1ery#dwn',
     type            : 'DecentralizedWebNode',
     serviceEndpoint : 'https://example.com/dwn',
     sig             : ['auth', 'assert'],
   }

since the identifiers are enc or sig not #enc or #sig

I believe it should look like
   {
     id              : 'did:dht:5cahcfh3zh8bqd5cn3y6inoea1b3d6kh85rjksne9e5dcyrc1ery#dwn',
     type            : 'DecentralizedWebNode',
     serviceEndpoint : 'https://example.com/dwn',
     enc             : 'enc',
     sig             : 'sig',
   }

   {
     id              : 'did:dht:5cahcfh3zh8bqd5cn3y6inoea1b3d6kh85rjksne9e5dcyrc1ery#dwn',
     type            : 'DecentralizedWebNode',
     serviceEndpoint : 'https://example.com/dwn',
     sig             : ['auth', 'assert'],
   }

since the identifiers are enc or sig not #enc or #sig

With custom properties it doesn't seem like we should have special handling for the values.  At least that's how I've been thinking about it.
In other words, there's nothing to say that the values of custom properties are referring to an id of a verification method.  They could refer to almost anything.

@frankhinek agree if they do not reference values in the doc itself then no issue

@frankhinek agree if they do not reference values in the doc itself then no issue

Are you thinking there should be logic to check the DID document to try and figure out whether the values are referring to other document properties?

the guidance is currently only present around keys, but I'd like to update this to recommend fully qualified identifiers for all properties https://did-dht.com/#representing-keys, I'll open an issue for this.
generally I think we should avoid fragments with # since - at least to me - they only make sense in the context of a full identifier


Improve the name and documentation of RPC AddComponentBounds

What's needed?
This RPC, for a given component and metric,

receives a vector of bounds from a client,
adds it to the existing set of bounds,
intersects all the bounds in the set,
sets the resulting pair of bounds as a the final bounds of the component's given metric,
and finally removes the received pair of bounds from the set (after a user-provided duration), recomputes the final bounds again, and updates it in the component.

The verb Add might not accurately represent this action, and could be misleading.
Proposed solution
Perhaps Augment is a better verb?
Also, it looks like the documentation needs to be improved to be more accurate.
Use cases
No response
Alternatives and workarounds
No response
Additional context
No response

Input from ChatGPT:

"Augment" is better than "Add" but still may not fully capture the idea of both adding and then later removing or recomputing after a duration. Here are a few alternatives to consider:

ApplyBounds: This verb emphasizes that bounds are not just being added; they’re being applied to the metric, intersected, and will later be removed.

ImposeBounds: This choice suggests enforcing bounds temporarily, implying that they may change over time.

ExtendBounds: "Extend" implies enhancement or adjustment, with potential to reconfigure the bounds as new inputs are applied.

EnvelopBounds: "Envelop" could work, suggesting that bounds are temporarily wrapping or containing the metric’s state.

OverlayBounds: If the bounds are temporary and layered, "Overlay" reflects that they are supplementary and will be removed after the specified duration.

Each option has a subtly different implication, but ApplyBounds and OverlayBounds seem most aligned with the behavior you described.

I do not see how Apply is a better choice than Augment. Augment suggests that it is extending the bounds, which Apply does not.
I also do not see any advantage of Apply over Add.
Let's maybe sleep over it for a day or two. We can close the issue if needed.


@NonNull on local variable root type? (yes/no/checker-dependent) [working decision: no]

BACKGROUND
This assumes our current approach toward local variables: because a checker can and should track the changing nullness of a local variable flow-sensitively, <insert explanation 1 or 2 here>
(1) the local variable's root type, being a mere static type, has to be the more general one: nullable. What the flow analysis does is explained as "type sharpening" (like "smart casts") which is general to more than just local vars.
OR
(2) the local variable's root type, being a mere static type, is unchangeable while the variable itself may go through different nullness states, so the type doesn't benefit from declarative nullness and so doesn't participate in it.
That being established,
FEATURE REQUEST
It is reasonable to want to apply @NonNull to a local variable root type, so that you can get a warning right away any time a nullable expression is assigned to it.
Without this, a checker will just infer the type to be nullable, and you'll still get a warning if and only if you try to use its value for some non-nullable purpose. That is, this FR isn't about preventing a bug, just reporting it closer to where it happened based on extra "hints/assertions" from the developer.
[EDIT: msridhar discusses a possible second use case below.]
THE QUESTION
Will our specification require, permit, or prohibit a checker to support this usage?
REQUIRE?
I don't see a strong case for this. Making sure that impl code is portable when moving from one checker to another has always been an explicit non-priority compared to the importance of nailing down APIs. Tenatively assuming we're not going with this option then I'll contrast the other two.
PROHIBIT?
One reason to prohibit would be if we thought different checkers might actually assign different meanings to this same usage, but I can't really see that happening here.
My bigger concern is that even just permitting this usage somewhat forces us into explanation (1) above and forces us to say "nullable by default but you can override it", and the massive problem with that is it's completely backwards to how things work for API types. So, prohibiting this might help us maintain conceptual simplicity of the overall model. (That said, Chris prefers (1) anyway?)
The impact on e.g. eisop users would be that when they want to use this pattern they will have to revert to a tool-specific @NonNull annotation. That's... not pretty but maybe livable. (Hopefully theirs would at least @Implies ours so that a file never strictly needs to mix both.)
PERMIT?
I don't love this option, but we could do it especially if >= 2 tools want to support this.
A problem I have with it is: what does the @NonNull javadoc say, then? It really wants to say definitive things like "means X in Y situation, has no meaning in Z situation", but it's awkward to say "it might have meaning or it might not". Particularly because I doubt we could get away with categorically saying that about all implementation-code concerns.
Also, as mentioned, even just permitting it somewhat undercuts our ability to lean on explanation (2) at top.
Also, now there'd be a decision users have to make, and have to debate with reviewers: when exactly is it worth using this? Some users might want to always use it; some maybe only if the var is non-final, or only if it's assigned at least 3.4 times, etc. etc. All over what seems like a very slight benefit. I'd kind of rather spare people from this.

Soliciting thoughts from tool owners @artempyanykh @msridhar @lazaroclapp @wmdietl @akozlova; seems pretty related to the other issue #252 .

Coincidentally I opened https://github.com/uber/NullAway/issues/561 a few months ago.  Interestingly, the motivation there was different (allowing for a more localized warning suppression in some cases).  Choosing "permit" does raise some questions, but I would like to keep the option open to support @NonNull on locals in NullAway in the future.

Thanks, @msridhar, that's interesting.
In Guava, I've used the approach of extracting a method that returns null as a member of any type. That lets me suppress the warning at the level of that one-statement method, after which code can write something like "unsafeNull()" without further ceremony:

https://github.com/google/guava/blob/e06a8cec65815599e510d7f9c1ea9d2a8eaa438a/guava/src/com/google/common/util/concurrent/AbstractFuture.java#L593
https://github.com/google/guava/blob/e06a8cec65815599e510d7f9c1ea9d2a8eaa438a/guava/src/com/google/common/collect/CompactHashMap.java#L949

One thing that I don't love about my approach is that the null has to cross method boundaries: In my dreams, I still want to make it possible for at least some users to use a bytecode rewriter that checks at runtime that methods never return null when they shouldn't—and of course unsafeNull could run afoul of that. But if such a tool were ever to exist, it would surely need to make a zillion exceptions, anyway. In fact, it would need to make an exception in an example similar to yours, in which a caller wants to pass null to a method that is declared not to accept it. And that exception needs to exist regardless of whether the caller uses unsafeNull or @NonNull Foo foo = ....
One thing that I do like about the approach of a separate method is that it can be used to "cast" type-variable usages from @Nullable E to plain E. In that case, it's not quite right to write @NonNull E e = ... because the value might not actually be non-null. Then again, @NonNull E e = ... is likely to be harmless, especially since the hack doesn't cross method boundaries like mine does.
(Besides the @NonNull Foo foo = ... approach and the unsafeNull() approach, there's also the (@NonNull Foo) cast approach that @kevinb9n mentioned above.)

@cpovirk that's a nice trick!  Is there a reason you used unsafeNull as the name for the method in one place and uncheckedNull in the other?  In any case, I'm open to the argument that the unsafeNull() method is a better way to do the targeted suppression (this comment nails it), so maybe that's not such a great motivator for @NonNull on locals.

I think the idea was that the usage of uncheckedNull was always actually "correct": getDoneValue would return null only for an AbstractFuture<@Nullable Something>. However, the usage of unsafeNull (oops, I should have linked a different usage above—now fixed) could actually return null from an Entry<K, @NonNull Foo> (albeit only in case of "undefined behavior"). It is a picky distinction that is unlikely to matter to anyone ever :)
I should note that I don't have a strong opinion about @NonNull on local-variable root types, or if I do, I can't remember what that opinion is :)

We don't support root nullness annotations on locals in Nullsafe. For localized suppressions we use:

methods a-la checkNotNull(...) that assert nullness,
methods a-la assumeNotNull(...) iow. an unchecked type-cast,
magic comments of the form // NULLSAFE_FIXME[<issue_types>]: <explanation> which work in situations where the required suppression isn't on an expression level.

A more localized error detection is nice but allowing @NotNull on locals opens a new can of worms and I'm not sure it's worth the hassle. So, far we have only a handful of @NotNull in the codebase and will likely keep it this way.

Good; I'd like to rule out "REQUIRE" and focus on the decision between "PERMIT" and "PROHIBIT".
And I'll propose we resolve for "PROHIBIT":
First a reminder that "PROHIBIT" really means that if you want to support it then the user has to drop down to a checker-specific annotation (which should have @Implies(org.jspecify.nullness.NonNull.class)). And I do recognize some downsides to this:

To the user who values this use case highly, this arrangement would feel quite unfortunate.
If a tool ends up preserving their own custom @NonNull annotation in perpetuity for this reason alone, that also feels quite unfortunate.

However, I think it buys us a lot:

A user can learn JSpecify fully without having to deal with this particular feature. It lets JSpecify be both simpler and more precise.
When encountering a usage of this particular feature, the user can view the annotation's javadoc and actually expect to find an explanation. This is the kind of firm bond between annotation and semantics we are trying to achieve in this project.
It would be much easier to switch to PERMIT later than the other way around.
It's cleaner to have a single list of all the circumstances where both jspecify @Nullable and jspecify @NonNull are "inapplicable" / "have no defined meaning".

In fact, the current docs I've written do have that single shared list, and I'm proposing to keep them that way by resolving this for "PROHIBIT".
Being merely a "working decision" I'll close this if I don't hear from anyone soon.

I think that's fine but would highlight one thing for the record: To get the full benefits here, what we need is not just for JSpecify to prohibit annotations on local-variable root types but for tools to implement that prohibition. Otherwise, we end up with a scenario in which, from the perspective of users, @NonNull does (to some tools!) apparently have semantics, which are undocumented. That's a lot like "permit" but in some ways worse.
Really, my point is just the usual one that "prohibit" means only so much when tool authors are the ones implementing the prohibiting or permitting. And some tools already permit annotations on local-variable root types, and they're not necessarily going to go to the effort of making an exception for JSpecify annotations. We can of course encourage them to! And it's a big help that at least a couple tools don't currently permit annotations on local-variable root types (or at least don't do anything with them if they see them?). Plus, another tool, Kotlin, doesn't look at the nullness of Java local variables to begin with.
If we found ourselves in a position in which many tools already supported JSpecify nullness annotations in a location where we'd prefer they not support them, then we'd have a more interesting decision. For example, I might want to prioritize pushing tool authors to stop recognizing class Foo<@Nullable T> before pushing them to stop recognizing @Nullable on local variables. But given that there aren't a huge number of tools that support annotations on local-variable root types already, and given that we're talking about local variables (not APIs), and given that annotations on local-variable root types are relatively rare in existing code anyway, I don't think we need to be too worried here.

I'm hoping the test suites help. We should apply ongoing gentle pressure toward passing them. And to do so a tool will have to have some code path that correctly demonstrates that Foo<@Nullable T> has no apparent effect except for a finding about the annotation being out of place. Then for the tool to keep respecting that anyway, at least it should have to do something fairly hacky to get there. That's a start. To the extent we find out such hacks exist, we can continue with the ongoing pressure thing.
It's worth noting that we'll have much more motivation to push on such issues for Foo<@Nullable T> than for anything API-invisible like this issue describes. The API cases go against the stated objective we've had since the beginning (API owners have one tool-neutral way to annotate their code). This... well, I feel like as long as our specs can provide a clear unambiguous "yeah they're not supposed to do that", then we've done our job, and I won't lose too much sleep over those that are doing it anyway.

"PROHIBIT" might be the wrong word, compared to, like "DENIGRATE"...

I think it's fair to make a working-decision that JSpecify declare @NonNull to have no meaning in these locations just like @Nullable. It can always be reopened by a motivated party.

(I started to claim to someone today that an explicit @Nullable could be useful to tell a checker "While I'm initializing this variable to a value with unspecified nullness, I want you to treat it as nullable." But in fact, I would expect the sort of "type sharpening" discussed above to kick in and treat the variable as if it still has unspecified nullness. So that is actually of no help. To get help, you'd want a method that converts the value to a nullable type (another thing that a JSpecify runtime jar could theoretically supply if we wanted to go that direction, which probably we don't)—or, you know, to annotate the API that you got the value from :))

Current decision: Local variable root types are very much "implementation code", and tools will be able to derive (and refine) the nullability of the root type component without annotations. For consistency, JSpecify does not allow @Nullable or @NonNull in those locations.
Argument for changing: It might be nice to allow some tools to interpret these annotations in those locations for their own non-portable purposes.
Timing: This must be decided before version 1.0 of the spec.
Proposal for 1.0: Finalize the current decision. If you agree, please add a thumbs-up emoji (👍) to this comment. If you disagree, please add a thumbs-down emoji (👎) to this comment and briefly explain your disagreement. Please only add a thumbs-down if you feel you can make a strong case why this decision will be materially worse for users or tool providers than an alternative.

Decision: JSpecify does not allow @Nullable or @NonNull on local variable root types. They are allowed on other type components (including wildcard bounds and non-wildcard type arguments).


Split Screen Markdown edit

Hi! I'm wondering if you guys have considered to offer a split screen markdown edit?
Right now the "preview" seems fine...but a split screen simultaneous edit seems more useful!
I'm just wondering if this is a technical difficulty or a design choice...

This would be cool but I'm not sure there's any bandwidth for this sort of undertaking right now. Right now maintenance is the priority, so unfortunately I have to mark this closed - although not from lack of interest, just time!
PS. http://socrates.io/ does this pretty well already and I use it a ton for collaborative editing.


Scroll Top Feature added to ToDo-Application

Hi Avinash,
I have added the scrollTop feature in the Todo App. This feature is much needed for every webpage/application. As our Todo application grows vertically, we need this feature. view it on the right corner of the page.
Added screenshot for reference.
Kindly approve my PR.

good work , can you please resolve conflicts


Reference link not working - viva connections app create

Reference link with title "Add Viva Connections for Microsoft Teams desktop" under More information section on documentation page of viva connections app create command is broken.
Direct link: viva connections app create - More information
Can I change it to Add the Viva Connections app in the Teams Admin Center and raise a PR or this is not a relevant documentation link for original broken link currently available on cmdlet documentation page?
If not, maybe this one is: Set up and launch Viva Connections?

Nice catch @ganesh-sanap! Let's get this fixed. I suggest that we use the Add the Viva Connections app in the Teams Admin Center link because this seems most closely related to the original.


Blog updates: changing columns and adding sharing on socials

Added:
a button for blog sharing on X

different archive pagination to have the dates rather than just the year

removed the date from the URL of the blog post
plugins:
  - search
  - blog:
      authors: true
      blog_toc: true
      blog_dir: blog
      archive_date_format: MM/dd/yyyy
      archive_url_date_format: MM/dd/yyyy
      post_url_format: "{slug}"

Putting this in a PR to see what the board thinks of the changes as URLs will be different

Used: https://www.youtube.com/watch?v=pPEUhfTZswc  as a reference for my code changes

Tested with MkDocs serve and I think it looks good.
As I understand it, each blog post has a specific url, like: http://<IP_ADDRESS>:8000/blog/hydrology-is-flat-and-its-buckets-all-the-way-down/, then it can be accessed via the archive with a url that has the date: http://<IP_ADDRESS>:8000/blog/archive/12/22/2024/.
Seems reasonable to me. My only issue might be the MM/DD/YYY format of the date. But it is okay with me if you like it.

Tested with MkDocs serve and I think it looks good. As I understand it, each blog post has a specific url, like: http://<IP_ADDRESS>:8000/blog/hydrology-is-flat-and-its-buckets-all-the-way-down/, then it can be accessed via the archive with a url that has the date: http://<IP_ADDRESS>:8000/blog/archive/12/22/2024/.
Seems reasonable to me. My only issue might be the MM/DD/YYY format of the date. But it is okay with me if you like it.

Yup. This was how it was done before, but it was just the year (2024) and not the date created. Also, there was a year in the blog post URL:
http://<IP_ADDRESS>:8000/blog/2024/hydrology-is-flat-and-its-buckets-all-the-way-down/ which seemed irrelevant.
I believe there is only date options, and MM/DD/YYYY seems the best for now. We should be able to change it in the future without breaking past URL references by sticking with a slug format like so: http://<IP_ADDRESS>:8000/blog/hydrology-is-flat-and-its-buckets-all-the-way-down/
I can merge this if no one else has any other comments 👍


python3Packages.lizard: init at 1.17.10

Description of changes
I would like to be able to use the lizard (link here) code metrics tool inside of nixpkgs!

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

@fabaff Thanks for the review here too! 😄

@ofborg build python310Packages.lizard


index_select_xpu not implemented for 'Float8_e4m3fn'

🐛 Describe the bug
index_select_xpu cause an IPEX UT fail.  In IPEX2.5, we override this Ops with IPEX implementation to make this UT pass.
ipex/tests/gpu/example/test_fp8_index_select.py::TestTorchMethod::test_index_select
'index_select_xpu' not implemented for 'Float8_e4m3fn'
Versions
..

created a PR for index_select, https://github.com/intel/torch-xpu-ops/pull/1081/files

merged.


Working copy of index.php

Do you have a working copy of index.php from https://youtube-dl-php.pxgamer.xyz/ available?
I'm no php developer and can't work out how to create the form correctly.
It just keeps giving me the submitted page at the first.

Hi, I was actually planning on redoing this as it's not as efficient as it can be.
The index.php I used is available here.
https://gist.github.com/PXgamer/e05f4890526820666c4960f0e633ec86

Thanks!
I'm a network admin for a few Australian (Vic) government schools and my staff are downloading all of various "youtube downloader' apps and browser extension - all with added spyware and browser hijackers of course.
Rather than block it, I just want to mitigate the risk of them doing it at home and host our own internal helper.
I look forward to your updates!
Craig

Ok, I updated this in commit bfcdd9264c77f9af436b0461f45c989d25663725 which contains quite a few changes.
You can now point a web server to the public/ directory. 😄


table of contents, doc needed

The README documentation provides the toc-own-page variable to be set at the beginning of the markdown document:

toc-own-page (defaults to false)
begin new page after table of contents, when true

But doing this:
---
title: "my title"
author: "myself"
titlepage: true

toc-own-page: true
---

will NOT work. I had to dive into eisvogel.tex to find out about toc and toc-title. Doing this:
---
title: "my title"
author: "myself"
titlepage: true

toc: true
toc-title: "Sommaire"
toc-own-page: true
---

DOES work.
toc and toc-title should be added in the official documentation.

The variables toc and toc-title are already part of the pandoc manual. I only document options that are added to the default template.
By default, pandoc does not generate a table of contents. The following code
---
title: "my title"
author: "myself"
titlepage: true

toc-own-page: true
---

does not produce a new page after the toc because there is no toc. If you want your documents with a table of contents, you can use --toc on the command line or add toc: true to your YAML front matter. In this case, the option toc-own-page should work as expected. I agree that this can be mentioned in the documentation. Perhaps an example is useful.


Bump bwc version to 2.19

Description
Bump bwc version to 2.19
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[ ] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I think this can be closed, didn't notice this open PR but included this change in my recently merged PR here: https://github.com/opensearch-project/anomaly-detection/pull/1366