We found a memory leak during AVS AQT testing

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:
When the device is on device playback, there will be a memory leak after about 3 hours.
Through observation, it is found that only during TTS playback will memory leak occur.
What is the expected behavior?
cat /proc/pid_xxx/status
VmRSS:     60572 kB
VmRss will not increase after 3 hours of continuous test.
What behavior are you observing?
During AQT device playback  testing, memory changes.
Provide the steps to reproduce the issue, if applicable:

Start AQT device playback  testing
cat /proc/pid_xxx/status
After about 3 hours of testing, compare the memory changes

Tell us about your environment:

What version of the AVS Device SDK are you using?
  Version 1.19.0 alexa-client-sdk

Tell us what hardware you're using:

[ ] Desktop / Laptop
[ ] Raspberry Pi
[* ] Other - tell us more: aarch64 rk3308

Tell us about your OS (Type & version):

[* ] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Hi @PerSpc ,
Thank you for contributing to the AVS Device SDK.
I have created an internal tracking ticket to get this issue investigated and fixed.

Hi samcoult,
Thank you for your help，Let me synchronize the test results on my side.
This is the result of two and a half hours of testing：
cat /proc/3318/status
VmHWM:     33124 kB   ----->   VmHWM:     71980 kB
VmRSS:        33124 kB   ----->    VmRSS:     70924 kB
cat /proc/meminfo
MemAvailable:      72392 kB    ---->    MemAvailable:      31952 kB
Version of gstreamer:  gstreamer1-1.10.4
Version of avs-sdk:  Version 1.19.0

Hi @PerSpc could you give us some more details on the platform you are using?
Also, it would help if you run a heap tracer such as valgrind or heaptrack to get an idea of the heap memory usage.
We ran similar tests with the SDK and concluded that looking at RSS by itself is not a good measure to find out actual memory used by the application. The reason is the heap allocator tries to optimize for speed by minimizing locking and allocates more memory from the OS and also it does not always free memory back to the OS.

Hi @PerSpc could you give us some more details on the platform you are using?
Also, it would help if you run a heap tracer such as valgrind or heaptrack to get an idea of the heap memory usage.
We ran similar tests with the SDK and concluded that looking at RSS by itself is not a good measure to find out actual memory used by the application. The reason is the heap allocator tries to optimize for speed by minimizing locking and allocates more memory from the OS and also it does not always free memory back to the OS.

I am closing this issue due to inactivity.  If you have further questions, please open a new ticket and refer to this closed one.


Typings for 2.1.0. are off

When trying
await this.apifyClient!
    .tasks()
    .create({
        actorId,
        name: taskName,
        options: { build: buildNumber, timeout: TASK_TIMEOUT_SECONDS },
    });

I run into the following issues

actorId is not present in typings and it seems that the client actually expects actId
timeout is present in typings but the runtime complains. it seems the legacy timeoutSecs works

Looking at the code, seems like the only properties that cannot be changed are userId, stats and the *At fields. If that's correct I'll update the types accordingly.
For the timeout vs timeoutSecs, from what I see TaskOptions has only timeoutSecs defined. 👀 Is timeoutSecs deprecated? If so, I can update it 👍

Hm...looking at the API probably not and it should e still timeoutSecs. But I believe the type hints in IDE were showing me timeout instead.

But I believe the type hints in IDE were showing me timeout instead

What version of the client are you on? It looks fine on 2.1.0 too 👀

Ok, this is probably my bad. Checking it now and it does show timeoutSecs.

I'm gonna close this for cleanup sake, please re-open or followup if this is still an issue 🙏


Fix #3616: Do not force all JSEnv inputs to be of the same type

I have updated this to use Seq.

If we're going to use Seq, let's use scala.collection.immutable.Seq explicitly.

I'm not so convinced about this. This would be inconsistent with other sbt keys and with how we do thinks in Linker. Is there a reason JSEnv should be different?

I'm not so convinced about this. This would be inconsistent with other sbt keys and with how we do thinks in Linker. Is there a reason JSEnv should be different?

It was to have the same API across Scala 2.12 and 2.13, but perhaps consistency with other APIs is more important indeed.

@sjrd Do you have any idea what happens to the CI where it can't find the linked files? (The failures where it can't find Promise are due to ForcePolyfills, I know how to fix these).

Of the java.io.FileNotFoundExceptions on the CI are just because the logs have been deleted since. It's a Jenkins exception. We have to delete logs after some time because we fill the disks quite quickly otherwise.
So basically, those errors are safe to ignore.

So basically, those errors are safe to ignore.

Ah, no. There is an error where Node.js fails to load the fast-opt-ed JS file. We'll see it once I fix the Promise usage.

Incorporated gzm0/scala-js#1. Let's see what the CI says.


New script sample - SharePoint List Item Version History Retrieval

New script sample "SharePoint List Item Version History Retrieval"

Hey @mromiszewski Really nice sample, thank you for contributing 😍 - this will be live shortly. 🎉

Hi. Great script. I really want to be able to retrieve the check-in comment that goes with the version.  Could you add that in or show how it can be done? I haven't found anyone that seems to be able to achieve this :)


Use linse as requirement for tests instead of clts

Linse is on pypi and offers a command to convert a sound to its clts name. Since we don't have complex sounds to be tested, so we make sure we can put this easily up with tests, etc. on pypi and integrated tests in github.

Since we don't have complex sounds to be tested

What would you consider a complex sound?
Otherwise, I don't see a problem doing the tests with linse instead of pyclts.

Sounds that are super generated and not in the 8000 that CLTS accepts, or alias cases, like "th" which is also nto resolved well by linse.clts.

Hm, I am not sure - as stated earlier in the PR discussion, I think the most common use case would be using CLTS, so I think it would be useful testing with that system as well. What would be the benefits of testing with linse instead of pyclts?

Tests on github run automatically if you set this up properly. To run automatically, you must make sure all can be installed without user intervention and data loading. This is not the case of clts.

But it is the case for linse, which also has 100% test coverage and is maintained and keeps the most recent version of CLTS, but with a lookup of all generated sounds rather than actively generated sounds.

Ahh, I see! Sure, then it makes a lot of sense - I'll adjust the tests accordingly :)

The only issue would then be, that we can not test whether Sound objects (generated by CLTS) can be processed correctly... (a function that we currently support, and I think would be reasonable maintaining)


When is the release date for Version 0.31.0?

Hello,
I'm eagerly anticipating the release of version 0.31.0 of Anchor and was wondering if there is any estimated timeline for its release?  As solana  has its stable  v2, when does anchor support it in the next anchor stabe version?

It has been ready for over 3 months now (https://github.com/coral-xyz/anchor/pull/3259), but I guess we're still waiting for an audit to publish it.

As solana has its stable v2, when does anchor support it in the next anchor stabe version?

Next version will support Solana v2 (https://github.com/coral-xyz/anchor/pull/3219). This is also mentioned in the Recommended Solana version section of the (unpublished) release notes. We'll probably change the recommended Solana version to v2.1.0 (https://github.com/coral-xyz/anchor/pull/3339) because v2.0's Rust version is quite outdated at this point.

To be honest, the speed of this release is really frustrating.

Before the audit passes, maybe we can have a 0.31.rc


Add aliases for deprecated hyphenated datasets

Can do this manually, will clear up current R CMD check warning.

Done in release with 583ce5b. For devel, I would say it's not really necessary and could wait until the end of the development cycle.

Deprecation process is complete, can you close @cmirzayi ?


[bug] Error: w3m-account-view: No account provided

Link to minimal reproducible example
https://github.com/WalletConnect/web3modal/tree/V3/examples/react-ethers5
Summary
When using @web3modal/ethers5: ^3.2.0, switching between different chains throws Error: w3m-account-view: No account provided.
I also tried with examples repository and the issue persisted.
Attaching a screenshot of examples-repo running on my local.

List of related npm package versions
  "dependencies": {
    "@web3modal/ethers5": "3.2.1"
  },
  "devDependencies": {
    "@vitejs/plugin-react": "4.1.0"
  }

You can test this in labs https://lab.web3modal.com/library/ethers/
Could you share the steps to reproduce the issue?

You can test this in labs https://lab.web3modal.com/library/ethers/
Could you share the steps to reproduce the issue?

After connecting the wallet (I tried with Metamask), try switching between different networks. The connect wallet button switches to a spinner which keeps buffering.

I was able to reproduce it, could you take a look @svenvoskamp ?

This issue has been resolved, so closing this one.

This issue has been resolved, so closing this one.

I am using the latest version @3.5.1, but this same bug still persists

This issue has been resolved, so closing this one.

I am using the latest version @3.5.1 in react, but this same bug still persists

me too
3.5.7 same

latest is 4.1.0


Shooting ( SpaceInvaders - Python )

Describe the bug
The game does not shoot when you hold the space button
To Reproduce
Steps to reproduce the behavior:

Go to '.pygames/spaceinvaders'
Run 'main.py'
Try holding space button
See error

Expected behavior
The spaceship should shoot even on holding the space bar.

Please assign this to me

This issue has been resolved.


Suggestion:for old project

The latest version supports androidx, but for some old projects, the cost of migrating to androidx is too great, so I hope the author can indicate, otherwise androidx will conflict with the support package.

You can use Jetifier to resolve these problems, read more here:
https://developer.android.com/jetpack/androidx/migrate


Localization improvements - Issue 340

First pull request? Read our guide to contributing
Checklist:

[x] Test your work and double check you didn't break anything

Description:

Use locale codes instead of language names identify languages
Support both Traditional and Simplified Chinese
Use locale-code NPM module which relies on official language names and locale codes instead of our own JSON file to track language names/codes (one less thing to maintain)
Update the script that turns Crowdin output into react-intl consumable translations

@wanderingstan this appears to "work". I'll defer to you on whether or not it resolves your requests.

Few notes:
• @micahalcorn For future we should think about how to do QA on things like this. Maybe something like testing.demo.originprotocol.com where we first deploy versions of the dapp before replacing demo.originprotocol.com, and then we can point translators and testing volunteers there?
• Looks like we have at least 3 arabic variations on there, but we're not supporting RTL languages. We should remove those. Is that something we on on crowdin?
• Pedantic Nitpic: I'm not a fan of using "Abbrev" for what really are language codes, e.g. in variables like langAbbrev. It's not really an abbreviation to have zh-Hant mean "Simplified Chinese". Could we s/Abbrev/Code/g those?
• The capitalization of the names is inconsistent. Had the same problem on the website, which we fixed with python's .capitalize() method. Is there a similar node method?

Also: Just realizing that many of the languages on Crowdin have <20% completion (many 0%).
How best do we remove languages? On crowdin side, or is there a master list somewhere of what gets shown on the dapp?
(I'll start going through code myself now too...)

@wanderingstan - the languages in the footer menu are now capitalized and the ...Abberv variables are renamed.
I think I removed all of the right to left languages from the DApp. We can talk to @coleman415 about removing them from Crowdin until we want to support them.
As for the languages with a low percentage translated, I think @joshfraser wanted those included with machine translations for now in hopes that it would prompt translators to provide better translations.
I think Crowdin has a way to run machine translations for all of the untranslated strings, and so we can talk to Coleman about that too. If they can be done by tomorrow, I can probably merge them into the app in time for the release tomorrow.


Would you consider making cbindgen dependency optional?

I have a pure rust project which has no need for the generated bindings.
I'm not familiar enough with cbindgen to know what the conventions are, but I was thinking it might make sense to simply make cbindgen an optional build dependency, and only generate the bindings when the feature is enabled.
Are you amenable to a PR?
For context, what brought me here was I noticed that your (up-to-date!) cbindgen resulted in my project duplicating the dependency. Now, I know I should go hound all the other crates to update their cbindgen, but the only thing better than an up-to-date dependency is no dependency at all!

Ah, actually looking at the code I bit, it seems like you've already started down this road with the headers feature.
I realize the crux is I don't know how (or if it's possible) to actually use something like "optional" build-dependencies... 🤔
e.g. just doing this
[target.build-dependencies]
cbindgen = { version = "0.22.0", optional = true }

produces output:

error: Package polylabel v2.4.0 (/Users/mkirk/src/georust/polylabel-rs) does not have the feature cbindgen

Presumably because features are only inferred from dependencies not dev-dependencies?

Sheesh, please disregard my previous comment - I had a typo in my Cargo.toml that lead me astray. 🤷
To prove to myself that this was possible, see: https://github.com/urschrei/polylabel-rs/pull/21

WHAT HAPPENED IN HERE

🙈


Update version of owl-to-rules to avoid 'indirect rules' for reflexive subclasses.

This should fix a problem in returning explanations for owl:Nothing inferences in Noctua. go-plus currently contains the axiom owl:Nothing SubClassOf owl:Nothing. That also needs to be figured out.

Thanks @balhoff!


How to fix the boundaries of water?

Today I am going to close the boundaries of water of this terrain erosion gpu project.
At first, it seems possible to make the WATER_HEIGHT(boundary points) = 0f to implement it but it didn't. Is there anyone who have the solution of it?

Hello,
setting WATER_HEIGHT to 0 at boundaries would affect simulation significantly - water will start disappear at the edges.
I'd rather do it this way:

Create a new vertical plane for each side of the terrain matching resolution of the water plane such that uv coordinates can distinguish between upper vertices (that match water) and lower vertices (that touch terrain)
Copy/paste water rendering code and set height of lower vertices to TERRAIN_HEIGHT, and upper to WATER_HEIGHT

Can you provide me the solution?
I feel thanks if you upload the files.
Greetings. Ivan.

I used this code to get the water height.
Code : (CustomTerrain.cs)
RenderTexture.active = _stateTexture;
tex.ReadPixels(new Rect(0,0,Width,Height), 0,0); //tex : Texture2D
tex.Apply();
But I noticed you set the water height limit to infinitive.
So most of color pixels's green values are 1f (256).
I am going to solve my issue with your first option.
"Create a new vertical plane for each side of the terrain matching resolution of the water plane such that uv coordinates can distinguish between upper vertices (that match water) and lower vertices (that touch terrain)"
Thanks. Ivan.

I tried myself, but as you can see the quality is really bad.
I think we should solve this problem by using shader. isn't it?
Thanks.

You did a dynamic texture on a static mesh, what I meant was a dynamic mesh)
I will be able to look at this issue on this weekend.

Please see the linked pull-request #3

Hi, bshishov. Really thank you for your great support.
I just have one little problem. That is when I try to scale down/up the water boundary gameobjects, then it crops down like this. What I have to change in code?

Currently it looks like this image in unity editor.

When I scale one of the 4 boundaries to it's original size then it looks fine.

In one word, the shape is absolute.
Thanks Ivan.

Oh, I found the solution. It's simply fixed by changing like the following code.
Material.SetVector("_WorldScale", Size / 4f);
I am going to close this issue when I fix this problem.

How do you think about the solution?

Regarding scale - set the correct scale in the WaterBoundary component in the inspector, no need to change the code.
on the screenshot it looks like that the boundary is ofsetted, make sure u didn't move the boundary object

Yes. You are right.
Thanks again for your great support.
Ivan.


Could it handle bot's token ?

Hi,
Someone successfully made binaries to handle a bot token and then make it play audio in a voice channel. But there is no source code of this project. It uses something called krust-voice 0.1. It also seems to use ffmpeg since it requires an ffmpeg path. Any idea how it could work ? It could be nicer than trying to login to my account to play audio as me and not as bot.

Sorry I have no idea about krust-voice. Also I guess ffmpeg is used to handle music, and do things such as decoding and playing music. I use mpg123 and pactl in this prject for the same purpose.

By the way, if your requirement is to

It could be nicer than trying to login to my account to play audio as me and not as bot.

Then you just need to learn to use pactl (for Linux) or virtual cable (for Windows) to redirect the music on your own PC. My project aims to play music as a bot (or a userbot, before official support came out). A centralized bot suits better when everyone uses the voice channel equally, while your idea, if I guess correctly, fits into the scenario when one streamer uses the voice channel for the most of the time.

There is not offical way that came pour nowadays, we still need to wait.


doc custom images

Also adds an option to override the image file when doing eden run, as discussed with @giggsoff
cc @rvs @eriknordmark who had mentioned this

This raises a larger question. Why is the Jenkins test run manually kicked off? Can we get it as part of the PR process? I am going to open a new issue on that.


Some searches involving “flash” on the Flask website throws a 500 error

If I try to search for “flash”, I get a 500 error:
http://flask.pocoo.org/search/?q=flash
I’ve found a few other searches related to flash that seem to fail; they may or may not be related:

Leading/trailing whitespace, e.g. “___flash” or “flash___”
Leading/trailing words with one or three characters – “a flash”, “big flash”, “flash a” and “flash big” all fail.
“flashe” and “flashes” both fail – appending other characters seems okay.

And some searches that work:

Prepending characters to “flash” – so “aflash”, “abflash”, “abcflash”, and so on seem to work.
Leading/trailing words with other numbers of characters – “hi flash”, “flash ab”, “flash abcd”, “high flash”, “highest flash” all work.

Repro’d in Safari and Chrome on OS X. I’m coming from a UK-based ISP, if that’s significant.
I was trying to search for the pages on message flashing. I couldn’t find a pattern to rejected searches, except that they all involve the word “flash”.

Just realised that the website code has its own repo; migrating there as https://github.com/mitsuhiko/flask-website/issues/26


Guidance on using Flow and ESLint

I want to create a Flow declaration file for Express
I created a file declarations/express.js.flow:
declare class Request {
  statusCode: number;
}

And referenced it from .flowconfig:
[libs]
declarations/express.js.flow

Now I can reference Request and Flow works:

But ESLint complains that Request isn't found:

I'm using babel-plugin-transform-flow-strip-types with the babel-eslint parser.
This obviously isn't a problem with Flow -- Flow is working fine. It's something to do with ESLint. I'm writing here because I would love some guidance on using ESLint and Flow together. They're definitely not mutually exclusive. It would be great to see something in the docs.

Hi, have you tried using https://github.com/zertosh/eslint-plugin-flow-vars?

@blaiprat I hadn't heard of eslint-plugin-flow-vars before. Works great :+1:
Another workaround is to specify global via ESLint:
/*global Request*/

You won't be happy if you define global variables for eslint :-) .... eslint-plugin-flow-vars is definitely the way to go here!

Agreed :smile:
As an aside, I just stumbled upon flow-guide (via your profile actually, @ryyppy :smile:)

@alexbooker cool! hope it actually helps in one way or another 😄

Is it possible to write a eslint plugin for flow where errors in flow are reported as eslint errors? This would make for an amazing workflow.

^^ Turns out it is possible. Here it is:

Now documented here: https://flow.org/en/docs/tools/eslint/


add script to invoke the promoter against multiple manifests

This also rearranges the layout of the binary and scripts in the docker
image to be more intuitive to use (everything under "/cip" directory).

This fixes #21

/lgtm


[bugfix] Handling null value for kafka client id suffix

label:
bugfix
A small follow-up fix to #13168. I recently deployed this patch to one of our clusters and found null getting appending to client id. This patch fixes that issue.
String clientIdSuffix =
        instanceDataManagerConfig != null ? instanceDataManagerConfig.getConsumerClientIdSuffix() : "";
    if (StringUtils.isNotBlank(clientIdSuffix)) {
      clientIdSuffix = "-" + clientIdSuffix;
    }
    _clientId = _tableNameWithType + "-" + streamTopic + "-" + _partitionGroupId + clientIdSuffix;

Above if ciientIdSuffix is null, we were not substituting it with "".
cc @Jackie-Jiang

Codecov Report
Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (d35cde3).
Report is 522 commits behind head on master.

Files
Patch %
Lines

.../starter/helix/HelixInstanceDataManagerConfig.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13279       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2461       +25
  Lines        133233   135739     +2506
  Branches      20636    20994      +358
=============================================
- Hits          82274        0    -82274
- Misses        44911   135739    +90828
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
?

java-21
0.00% <0.00%> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <0.00%> (-61.75%)
:arrow_down:

skip-bytebuffers-true
0.00% <0.00%> (-27.73%)
:arrow_down:

temurin
0.00% <0.00%> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks for catching this @tibrewalpratik17  .
TIL : null in string concatenation is converted to "null"  in java . Ref


Document the existing matchers that are available

Document the existing set of matchers that are available
based on the current unit tests.

Hi,
This is a nice addition to the doc but It would be nicer if you put the examples in code blocks to be more readable.
expect(actual).toBe(object)
expect(actual).toBeTheSameAs(object)
expect(actual).toNotBeTheSameAs(object)
.....

Yeah I can do that.

Updated. Any idea when this could be merged?
If it doesn't get some love soon, I may end up forking it.
I'd rather not though...

Closing due to inactivity.


Format /near/ links nicely

We should:

Add a pretty format for /near/ message links within Zulip, similarly to channel and topic links: #channel>topic@message-id (e.g., #design>handy notation for near links@1934657). These should automatically get parsed as /near/ links to the appropriate message.
Automatically convert pasted /near/ links to this format, just like we do with channel and conversation links (same undo functionality, etc.).

(2) can be a follow-up PR to (1). https://zulip.com/help/link-to-a-message-or-conversation will need to be updated as part of / a follow-up to this issue.

CZO thread

@zulipbot claim

@oscarStolpe Thanks for your interest, but I'm assigning this issue to @kuv2707 , who has implemented very similar features previously, and has some availability. Please go ahead and select a different issue to pick up.


Biographies

THomas will write two biographies
a) one about himself.
b) the other one for https://engineering.virginia.edu/news/2021/08/world-renowned-computational-scientist-geoffrey-fox-joins-uva-faculty
please add to overleaf
make sure length is similar to the once already there.

Completed both Biographies.


Support out-of-bounds behaviour in RectBivariateSpline

I'll look into this. It would make the special out-of-bounds handling in interpnd obsolete.

Are you referring to giving RectBivariateSpline the bounds_error = True/False option? If yes, :+1:, I was tripped up by the lack of this option in RectBivariateSpline when switching from interp2d.

Clipping out-of-bounds values seems to be a remnant from the original Dierckx 'package'. For 1D case it was expanded around 2001-ish, likely when wrapping it for later-to-become-scipy; 2D splines are left out for some reason.
The core logic responsible for clipping the out-of-bounds values is here: https://github.com/scipy/scipy/blob/main/scipy/interpolate/fitpack/fpbisp.f#L26 and https://github.com/scipy/scipy/blob/main/scipy/interpolate/fitpack/fpbisp.f#L46
Compare to the univariate case: https://github.com/scipy/scipy/blob/main/scipy/interpolate/fitpack/splev.f#L96, where it is controlled by the e argument.
So to implement this, fpbisp.f needs to grow a e argument (and receive it through the bispev.f, possibly also bispeu.f) and process each x and y argument in a way similar to the 1D case. Fortran code receives the extrapolation parameter e as an interger, and python wrappers should expose string aliases in addition to integers. For consistency with 1D UnivariateSpline, the minimum set of e values is 0 for extrapolation and 3 for clipping (and it should be the default to preserve backwards compat).


Moving to trpc-v10

Currently, trpc-playground won't work if you are using a trpc-v10 server. I created this issue to discuss on how/when we should convert to using trpc-v10.
I think it would be better if we moved to a structure for writing queries like this:
await trpc.users.byId.query({ userId })

Instead of
await query("user.byId", { userId })

What do you think about this? Should we wait until v10 is released?
I am happy to work on this.

We can definitely do this now. Feel free to do a PR on the next branch! I'll release it on the next npm tag.

available at trpc-playground@next


runtime: index out of range in scavenger page lookup

Example failure: https://build.golang.org/log/c367b3a210d28381bd2aa0bc2741b1492a6e4a7f
The candidate chunk discovered from the new scavenger index doesn't refer to a region of memory the page allocator thinks is mapped. No reproducer yet, but working on it.

This failure occurred a second time in a row on linux-amd64-goamd64v3. Looks like that's what's necessary to reproduce.

https://build.golang.org/log/40c03ce87d00a750855c376d71e74cc6615229ab

Confirmed. I can reproduce locally by just doing:
GOAMD64=v3 ./make.bash

I can also reproduce the issue in the scavenger tests. If I build the toolchain without GOAMD64=v3, and then run:
GOAMD64=v3 ~go test -run="Scavenge" -count=1 runtime
``

it fails.

Looking at the amd64 v3 rules, I think I found a bug. Does the scavenger use math/bits.Len16 or math/bits.Len8?

Ah yes, looks like it uses sys.LeadingZeros8 which probably uses the same builtin as Len8. The bug is the rule in cmd/compile/internal/ssa/gen/AMD64.rules:108, it's not right for 16/8 bits.

I have the same problem, I have bisect it to 91f863013e6b5ba870f6bfbfda0b735cf54fb3ca.

@cherrymui came to the same conclusion, that the codegen rules aren't right, specifically if the high bits of the register that's being used are not zero.


[py2py3] Migration at level scr/python/A/B/C - slice 9

Fixes #10133
Status
Ready
Related PRs

Previous migration PR: #10289 (slice8, issue #10132)
Next migration PR: #10295 (slice10, issue #10134 )

Description
Run futurize and some manual changes on the first batch of src/python/A/B/C.
No changes to test/python.
No notable changes that seem risky.
Is it backward compatible (if not, which system it affects?)
It should be.
External dependencies / deployment changes
Requires python-future in both py2 and py3 environments.

You are definitely correct! I just started running the unit tests in my oracle setup. I do not consider those tests to be conclusive, but I hope not to find anything terribly wrong. I will let you know


Add how-to page for openzeppelin lib and a example project

Signed-off-by: Alexandre Ferreira<EMAIL_ADDRESS>

@alexjorgef can you add steps for verifying the contract?  I think there may be a step regarding flattening the contract that needs to be added so that a user will be able to follow along.

@alexjorgef can you add steps for verifying the contract? I think there may be a step regarding flattening the contract that needs to be added so that a user will be able to follow along.

Of course, just add it. Let me know If anything should be changed :smiley: I think about extending this example with a chargeable ERC20 token, maybe should be added on a separate page.


Support for LuaSnip as snippets engine

The request is to add support for LuaSnip engine to provide snippets. It seems to me that only friendly-snippets is supported but I don't see how to integrate with LuaSnip.

LuaSnip seems out of scope for the built-in snippets provider, which supports vim.snippet and vscode-style snippet definitions. I'll leave this to the community to implement as an external provider

Any documentation on how to build different providers available? Or is that a future feature?

Not yet but it'll be done before 1.0

The problem is that having only a provider will make it so lsp snippets will use the internal engine, therefore mappings won't work the same.

Using this issue to track support for an accept.expand_snippet function

Closed by #286


Refactor principal_investigator slot on Study

Currently the principal_investigator slot is single valued, but some consortia have multiple principal investigators like WHONDRS and EMS. They have multiple people listed as a single value string (with a comma). Studies only have one investigator, but consortia might have multiple.
One way to fix this is to make the principal_investigator slot mulit-valued, but create a rule that says if research_category is a study, then the max_cardinality is 1.
This solution would require a migration.

Related to / duplicated with https://github.com/microbiomedata/nmdc-schema/issues/301 and https://github.com/microbiomedata/nmdc-schema/issues/458.

Good issue.
The preferred deign pattern here is to globally make principal_investigator multi-valued, and then to set it's maximum cardinality to 1 in any case where you want a singe principal_investigator
Making a slot multi-valued in some usages and single-valued in others is a violation of the montonicity guideline: slot_usages should refine slots, not switch them between incompatible states.
There's some discussions about this but no format documentation yet
@brynnz22 I think you already did that kind of thing for homepage_website

curl -X 'GET' \
  'https://api.microbiomedata.org/nmdcschema/study_set?filter=%7B%22id%22%3A%22nmdc%3Asty-11-547rwq94%22%7D&max_page_size=20&projection=principal_investigator' \
  -H 'accept: application/json'

{
  "resources": [
    {
      "id": "nmdc:sty-11-547rwq94",
      "principal_investigator": {
        "has_raw_value": "Jack A. Gilbert, Janet K. Jansson, Rob Knight",
        "email"<EMAIL_ADDRESS>        "name": "Jack A. Gilbert, Janet K. Jansson, Rob Knight",
        "orcid": "orcid:0000-0002-5487-4315",
        "type": "nmdc:PersonValue"
      }
    }
  ]
}


Azure Log Analytics REST API - Query limits  documentation mismatch

[Enter feedback here]
Dear,
The documentation  regarding the Query API maximum size on this page  references a value which is different from the value that can be seen when clicking on the 'Rate Limit'  URL in the 'Maximum request rate' row in the same section.
Which value is applicable?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1ca0191e-5d1b-44a1-afb3-71463164b53e
Version Independent ID: 53952dc6-d596-389c-e1d2-2f845bb59b86
Content: Azure Monitor service limits - Azure Monitor
Content Source: articles/azure-monitor/service-limits.md
Service: azure-monitor
Sub-service: general
GitHub Login: @bwren
Microsoft Alias: bwren

Thanks for the feedback! We are currently investigating and will update you shortly.

Assigning to content author @bwren for doc-enhancement

#reassign: @guywi-ms

#assign: @shemers
@shemers , Can you clarify this contradiction please? Do we need to make a change in the documentation?
Thanks,
Abby

Users shemers are already assigned.

#assign: @AbbyMSFT

Dear,
I think the URL were the discrepancy was found is now getting redirected.
URL with the discrepancy  :https://dev.loganalytics.io/documentation/Using-the-API/Limits
gets redirected to: https://docs.microsoft.com/en-gb/azure/azure-monitor/logs/api/overview
Kr,
Ernesto

@ErnieBot, You are correct. Thank you. I am closing the issue.
#please-close


Apt repository panic

Uploading non-deb file to gorjun's apt repository causes daemon panic:

Need to add initial check before trying to unpack and parse uploaded file

Fix merged


document lower casing of headers field

It would be nice to see the lower casing of header keys be documented here:
https://docs.stdlib.com/main/#/creating-services/the-context-object

We can certainly do this. 👍
cc @jacoblee93 who handles most of our website docs

@jacoblee93 is this documented yet?

Will do this now!

Ok, I've added an example to https://docs.stdlib.com/main/#/creating-services/the-context-object. Let us know if there's anything else we can make clearer!

Awesome, thank you very much!


Takes about 5 seconds to publish agent url.

Steps to reproduce the problem:

Create an agent.
Use Publish option to publish the agent.

Notice that it takes about 5 seconds to get the published url.
https://www.loom.com/share/722e2d3d8d334afd923258dcc63d8fc7?sid=976e2f1a-1aa5-493b-8bad-d45110347ee8

Can't repro


YAML.safe_load in schema:load fails for Symbol keys

Since switching from YAML.load to YAML.safe_load here, it is not possible to run schema:load.
That's because the schema.yml file generated by by schema:dump uses symbol keys, which are forbidden by safe_load (see YAML docs).
This can be easily remedied adding Symbol to the whitelisted classes, like so:
schema_data = YAML.safe_load(File.read(SCHEMA_YAML_PATH), [Symbol])

Thanks!  Fixed and released as 8.3.3 and 9.0.4


Documentation error

There appears to be a redundancy in example 2 for the cmdlet:
----------Begin Example 2----------
Example 2: Remove replication groups using a wildcard
PS C:\> Remove-DfsReplicationGroup -GroupName "RG*" -RemoveReplicatedFolders -Domain corp.contoso.com -RemoveReplicatedFolders
Performing this operation will remove the replication group "RG01" and the subscriptions members have to this replication group. Are you sure you want to continue to remove this replication group? [Y] Yes  [N] No  [S] Suspend  [?] Help (default is "Y"):

Performing this operation will remove the replication group "RG02" and the subscriptions members have to this replication group. Are you sure you want to continue to remove this replication group? [Y] Yes  [N] No  [S] Suspend  [?] Help (default is "Y"):

Performing this operation will remove the replication group "RG03" and the subscriptions members have to this replication group. Are you sure you want to continue to remove this replication group? [Y] Yes  [N] No  [S] Suspend  [?] Help (default is "Y"):

This command removes all replication groups that include the pattern RG* in domain corp.contoso.com, even if the groups include replicated folders.

----------End Example 2----------
Notice the parameter -RemoveReplicatedFolders being used twice? This seems to be redundant
Kurt

@KurtBuff Thanks for catching this!  I've updated it and the change should be published shortly.


Added example with multiple indicators in CommandResults

Status
Ready
Description
Added an example of CommandResults outputs with multiple IPs

@anara123 @ShahafBenYakir can you confirm the markdown output is like this? Or it's 2 different tables since you have 2 items in CommandResults?
thanks!

@anara123 @ShahafBenYakir can you confirm the markdown output is like this? Or it's 2 different tables since you have 2 items in CommandResults?
thanks!


Usage of _ (underscore) in _*.scss filenames

Is there any reason to prefix src/*/_*.scss with _? While src/*/*.js are written without it.
It causes problems to use standard BEM tools to work with files.
Is it possible to make consistent file names for all block techs (scss, js)?
cc @tadatuta

_ is a pretty standard way with Sass to denote that the file is not a whole structure but instead a partial of a larger whole.
What are the tools you are trying to use?

It’s not just a convention but a feature by SASS called partials. Files beginning with an underscore won’t be compiled stand-alone and therefore don’t generate any file in dist.

@Garbee @surma https://en.bem.info/tools/ and a lot more in npm actually.

So, we use CSSO and used to use SVGO ourselves, but on the final CSS file. If you are using these tools on the SASS files, it will most likely not work. Got more details? I feel like this is not related to MDL or its usage of underscores.

We were talking about bem-tools and ENB in the first place — tools to build entire BEM projects.
They utilize idea of https://en.bem.info/method/filesystem/ to introspect filesystem and collect bundles of just needed blocks instead of dists with everything.

As you can tell by our folder structure, we didn’t use bem-tools.
The original question was about the underscores in the filenames, which I hope I answered to your satisfaction. We will probably not adjust MDL for a tool we didn’t use in the first place. I’m closing this issue for now.

@surma but as I can see in gulpfile.js SASS feature for skip underscored partials are not used (if I rename _*.scss to *.scss everything works the same)
are there any strong reasons to intentionally break compatibility with wide spread (in BEM ecosystem) file structure? even if you personally don't use bem-tools or enb there are people who do — I personally try and stuck in monkey patching file structure after checkout of MDL sources

(I’m not sure where you see _*.scss in the gulpfile. )
This is not intentionally breaking something, because it never worked in the first place (as we didn’t know about bem-tools – at least I didn’t). We don’t even adhere to the folder structure. This is somewhat comparable to all the CSS preprocessors (SASS/LESS/Stylus). We chose our tooling to fit our workflow and can’t cater to every personal preference. This is not a great answer, I know.
In any case, changing the folder structure/filenames now is somewhat of a breaking change (some people might be pulling in the SASS code and compiling their own MDL). So your suggested change can only happen for v2 or later.
I’ll assure you that we will keep bem-tools in mind once we start working on v2. It actually might make our plans for modularization easier.
Out of curiosity: Why are underscores causing problems with bem-tools? It’s a perfectly valid filename, isn’t it?

@surma Thanks for going considering of using our existing tools for BEM ecosystem for v2. When you start to code something feel free to ask me or @tadatuta for any help with configurations. Also we have a lot of experience with blocks library development (i.e. bem-components and bem-core). Not just blocks code but also infrastructure such as autotests (JS unit tests, CSS tests with screenshots and HTML templates diff tests), automatically generated library website, documentations with live examples and so on. And we will be happy to share it with you!
Speaking about underscores: it's not fatal problem for current tools to customise naming scheme (maybe a little bit hacky). But existing configs, existing code of blocks and people habits are stuck to scheme described here https://en.bem.info/method/filesystem/.
BTW I'm working on a talk for Odessa.js conference where I gonna show how to use MDL with BEMHTML templates and BEM-aware building tools.


RGBW lighting fixture control with DALI DT8 and air conditioning unit control with air conditioning gateway

Hi Philip!
My current smart home customer is very happy with your plugin for Homebridge since he gets an opportunity to enjoy a complete and transparent integration of the most free@home devices to Home Kit. He is lacking several features which include:
Split unit gateway to control air conditioning units. This features is very similar to the fancoil thermostat.
https://www.busch-jaeger.de/en/online-catalogue/product-overview?tx_nlbjproducts_catalog[action]=show&tx_nlbjproducts_catalog[catBjeProdukt]=27303&tx_nlbjproducts_catalog[controller]=CatStdArtikel&cHash=7cf67980bfc5bca0532e73c0d4ae0d59
DALI gateway with DT8 feature to control RGBW lighting fixtures.
https://www.busch-jaeger.de/en/online-catalogue/product-overview?tx_nlbjproducts_catalog[action]=show&tx_nlbjproducts_catalog[catBjeProdukt]=27304&tx_nlbjproducts_catalog[controller]=CatStdArtikel&cHash=dfc92ef545afaf748cb42fb2f843eba4
I am wondering what's the approach to implement listed above features and how long would it take to do that?
Thank you in advance!

Hi Vadim,
I'm happy to hear that your customer is satistifed. Unfortunately, I have neither a split unit nor a DALI gateway available for testing. As the interaction with the SysAP is largely reverse-engineered, I don't see a viable way how to proceed with the integration. I would be happy to accept a PR for that topic though. Sorry to disappoint and thanks for your interest in the plugin!

Dear Philip,
I've been thinking if there is a way to implement the requested features. I
can extract a json configuration file from the existing @.*** system
with DALI DT8 feature and air conditioning gateway and make the log files
in Wireshark or whatever tool is applicable for you. Along with that I
can do all the testing on site. There is also an option to support you
financially in order to do the job. I just have to negotiate that with the
customer since he is interested as an end user. If this approach is
suitable for you, please, let me know how much would you charge to add the
two features to the plugin. An upfront payment is possible in the amount of
50-60% through PayPal or by other means, which is discussable.
Looking forward to hearing from you!

Dear Vadim, I'm flattered by your offer and your interest in the plugin, but I'm not convinced that this is the right way forward. Even with logs and traces, I cannot guarantee the success of the project. In my efforts to extend the plugin I've already hit an unexpected roadblock on several occasions. I'm not sure your customer would appreciate that outcome, especially if money has changed hands, right? There is also the question of a proposed timeline and the other typical project management questions. If we do this, we should do it right and be clear on everybody's expectations. Let me think about it, I'll get back to you.


feat: update golang-github-networkplumbing-go-nft to 0.2.0

Go bindings for nft utility (library)
Issue: https://github.com/linuxdeepin/developer-center/issues/3965
Log: update repo

/test

/test all


chore(CODEOWNERS): rm stephen from codeowners file

Overview

removes stephen from codeowners file

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: [ABC-123]
[x] I have run this code to verify it works
[ ] This PR includes unit tests for the code change
[ ] This PR includes testing instructions tests for the code change
[ ] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Gamut team should still be auto-added to this PR

🚀 Styleguide deploy preview ready!https://632b5a4e55450212363f73b7--gamut-preview.netlify.appDeploy Logs


Fix multiple Git processes error

When multiple targets are to be processed with ade_clang_format_git_targets(), the following error shows up because multiple Git processes are running on the same repo:
Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again.

AdeClangFormat should run these commands one at a time (e.g. by using a DEPENDS between each corresponding command and the next).

Also see this: https://discourse.cmake.org/t/good-way-of-running-custom-commands-serially/8412


keyboard: keychore K2 fn key not change

https://www.reddit.com/r/MechanicalKeyboards/comments/d5io49/comment/i1xyzog/?utm_source=share&utm_medium=web2x&context=3
https://mikeshade.com/posts/keychron-linux-function-keys/

run
echo "options hid_apple fnmode=0" | sudo tee -a /etc/modprobe.d/hid_apple.conf
sudo mkinitcpio -P


1.19.0 版本,当一文件关闭后再打开不能维持之前的折叠状态,1.18.0版本是可以的

版本信息: 1.19.0 x64

Summoning @50Wliu for at least a rough translation before closing (you didn't fill in the issue template @codecools :)

Google Translate says:

Version 1.19.0, when a file is closed and then open can not maintain the previous folding state, 1.18.0 version is possible
Version information: 1.19.0 x64

Thanks for taking the time to contribute!
We noticed that this is a duplicate of #13258. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


[BIP44-239] Extend newTx to EO wallets

https://github.com/input-output-hk/cardano-wallet/issues/239
#
Overview

[x] I have extended NewTx (used in NewPending/NewForeign) to apply EO prefiltering when adding a transaction to an EO Account

Comments

These changes add a new capability (new Tx for EO wallets) and does not test it yet.
Existing tests for "newTx for HdRnd wallets" are still satisfied so we can be sure that this does not break any existing functionality.
Since both @piotr-iohk and I want to test this new functionality next  (on API and Kernel level respectively) I suggest we review/merge this without tests to allow concurrent work between us.
NOTE: Adding tests for this on kernel level requires generalising the NewPayment Tests to EO wallets. These tests are also used by Tx and TxMeta tests, which also need to be generalised to EO wallets.

LGTM, however I'm not deeply in context..


Binding problem

Hi,
I'm new to Android Studio and I'm having some trouble with the data binding. I did all the steps on the ReadMe file and still can't make it work.
Corretc me if I'm wrong, but I need to add this to my layout right?
<layout xmlns:android="http://schemas.android.com/apk/res/android"> <data> <variable name="androidvalidation" type="com.github.Ilhasoft:data-binding-validator:0.6.1"/> </data> </layout>
So then I can use the app:validateMinLength="@{4}".
Thank you!

Hey @IndiceDev, you need to add compile 'com.github.Ilhasoft:data-binding-validator:0.6.1' into your build.gradle file, in this case, you are adding to your XML layout.
In order to use inside your XML layout, see this example: https://github.com/Ilhasoft/data-binding-validator/blob/master/sample/src/main/res/layout/activity_main.xml
I'm closing this issue because it's more a doubt about data binding usage and dependency configuration and not a library issue.


Slack retrying messages when bot is using CMS and the conversation is long

Hey!
I've recently tried to move my bot from 0.7 to v4.5 and noticed that what worked great before stopped working in 4.5, namely botkit failed to reply within 3 seconds time which in turn triggers Slack to send message retries.
The source of it is that new version stopped sending immediate ACKs to POST requests issued by slack. I found somewhat similar issue discussed here earlier https://github.com/howdyai/botkit/issues/1684
My question is, i'm not doing anything myself, i'm just using default generated code

    /* catch-all that uses the CMS to trigger dialogs */
    if (controller.plugins.cms) {
        controller.on('direct_message,direct_mention,mention', async (bot, message) => {
            let results = false;
            try{
                results = await controller.plugins.cms.testTrigger(bot, message);
            } catch (err){
                console.log(err)
            }

            if (results !== false) {
                // do not continue middleware!
                return false;
            }
        });
    }

If slack message contains a trigger for conversation defined in CMS and that conversation has, say, 10 messages to send, the 200 OK ack message won't be sent back before all 10 messages are pushed out...
Context:

Botkit version: 4.5
Messaging Platform: Slack

It should send the 200 after the first message in the dialog is sent back to Slack.
Is the call out to the CMS taking a long time?
One way around this is to return a promise from the handler, and do the work inside that promise. This will resolve the handler promise and send the 200 while your bot continues to wait for the CMS.
This requires you to call await bot.changeContext(message.reference) inside the promise.

Hi Ben, thanks for looking into it.

The call to CMS happens really fast, but the 200 OK is not being sent back until after all messages in the dialog are pushed out.

Hm, not sure I understand what the workaround is...
The handler is already defined as async, so it returns the Promise already..
controller.on('direct_message,direct_mention,mention', async (bot, message) => {

UPDATE: I was wrong regarding

call to CMS happens really fast

actually call to await controller.plugins.cms.testTrigger(bot, message); does not return until all messages are pushed out.
I have tried to trace it and diged deeper. Found a bunch of nested await calls going all the way to beginDialog and runStep -> onStep -> sendActivity() and then step.next() -> resumeDialog() -> runStep()
so basically the Promise returned by cms.testTrigger() never resolves before all messages are pushed out... and that triggers slack Timeout.

@amaralex that is not the expected behavior of dialogs.  Once the dialog begins, should resolve after sending its first message (or first N messages until a prompt is encountered).
I will have to do some experiments and research to see if this is a bug or something else weird!

or first N messages until a prompt is encountered

@benbrown in my test the conversation looked like 10 messages with no prompt at all. So may be it is an "expected" behaviour after all but it still triggers slack timeout

thank you for the info, I'll dig in asap.


Installation fails on ARM64

When installing on ARM64 (raspberry pi 4 with raspian 64 bit) the script "scripts/install.sh" fails when downloading and installing the node libraries:
if ! command -v node -v >/dev/null 2>&1
then
status_msg "Download Node 16.13.1"
wget https://nodejs.org/download/release/v16.13.1/node-v16.13.1-linux-armv7l.tar.gz
Here a check is needed if we are on ARM64 and the download needs to be
wget https://nodejs.org/download/release/v16.13.1/node-v16.13.1-linux-arm64.tar.gz

i am thinking about implementing this:
curl -sL https://deb.nodesource.com/setup_16.x | sudo -E bash -
sudo apt-get install -y nodejs (auto corrected depending on the plattform)```

implemented with 3c071b2c36cdc1dc1b57ca0b6f4a70bc62fa61fa and e9419d581c2fb02c349706a7d8fbe631db96a708


Claim error message shows up in chat for everyone to see

When a player tries to claim an area that is smaller than 16x16 blocks, an error message pops up in chat for everyone to see.
See the screenshot below.

Hi there!
I'm currently going through older tickets, and upon testing this issue, I can see that since we recently decreased the minimum size a claim can be, you can no longer proc this issue! Yay!
Thanks!


Matrix sign-in doesn't work with epcon auth if the user names contain space or non-ascii characters

The localpart of the user ID on matrix has strict rules: https://matrix.org/docs/spec/appendices#user-identifiers
At the moment, if the user's first name or last names contain spaces, or possibly non-ASCII characters, they cannot sign in via the epcon-auth. And the error message is very helpful: This homeserver does not support login using email address.  homeserver.log provides more debugging info.

I believe changing the way the Matrix user name is built will fix this implicitly: #1425

Fixed by using the epcon username


feat!: bring back the cliff vesting command (#111)

What is the purpose of the change
Bring back cliff vesting command from PR #111 , this was a very useful UX flow for folks doing cliff vesting on-chain.
Brief Changelog

Restore the CliffVesting CLI command

Testing and Verifying
This change is identical to what we had before.
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? yes
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
How is the feature or change documented? Code comment

It got removed due to branch mismanagement, not intentional


Improve overall code documentation

Self descriptive, low priority, we should have better documentation at main functions that we use.

This needs to be worked on constantly, no need to have separate issue for it


Upgrade Node Version

Requirements

Filling out the template is required.

All new code requires tests to ensure against regressions.

However, if your PR contains zero code changes, feel free to select the checkmark below to indicate so.

[X] Have you ran tests against this code?

[ ] This PR contains zero code changes.

Description of the Change
In this PR I've upgraded to the latest version of Node Supported by Google App Engine (Which is the service we run the backend on).
After upgrading my local Node to Node v18.13.0 I went ahead and ran all test suites of the code, and amazingly all tests pass without any modification.
Where we saw updates:

GitHub Actions have all added 18.x as a Node Version to run tests on. The other versions are still listed out of curiosity if we can support any other versions. But may be removed in the future if needed. Where we can officially say that version is no longer supported.
The app.yaml is now set to using Node 18. As well as the app.example.yaml
I've updated the engines field in the package.json
Lastly I've added .nvmrc so there no longer needs to be any confusion as to what version of Node the backend runs. The version will always be available in this file, and will be kept up to date as needed.

@Digitalone1 take a look and see if we can merge this into #65 or #66

Alright, as you can see I played around with seeing the difficulty of supporting multiple versions of NodeJS.
So with this the engines field in our package.json is 100% accurate into the exact versions of NodeJS we support. And can be used for future reference.
I know you originally wanted this to work with the newest features, so if you need to on your PR feel free to remove support for NodeJS 16 if needed. Since we control the environment this runs in, it's not the biggest deal if we only support a single version, just thought it'd be cool to support more.

@confused-Techie sorry for the late reply, we use structuredClone which was introduced in Node v17, so the minimum version should be 17.

@confused-Techie you can add v17 and v19. I tested on 19 locally, all passed.

@confused-Techie you can add v17 and v19. I tested on 19 locally, all passed.

Noted, I'll fix that. Although will have to check if GitHub Actions supports those other Node versions. If it doesn't I'd rather only support what we are able to test on each PR just to make sure our engines is accurate.
But will do some additional testing.

@Digitalone1 Alright, I've gone ahead and updated this one. You can pull it into your PR if you'd like, but otherwise this ones good to go.


Allow CreditCard Validator to be extended

In Brazil we have 2 other major credit card brands: Hipercard and Elo.
This change allow to extend the validator to add new Brands, this way: https://gist.github.com/stephandesouza/26b898e4df2d163ed3eeac183daa8e0b

Thanks, @stephandesouza!


duplicate accesses detected

In the tag integration tests, there is a duplicate accesses detected bug, and occasionally a log index out of bounds error -- these are presumably related.

With the following configuration:
debug:      true
testing:    false

simulation:

    # Simulation Environment Parameters
    random_seed:  42
    max_sim_time: 4320000

    # Network Parameters
    count_messages: true
    aggregate_heartbeats: true
    default_latency: 800
    default_replica: storage
    default_consistency: strong

    # Workload Parameters
    users: 3                  # number of simulated users creating traces
    max_objects_accessed: 10  # maximum number of objects that can be accessed
    synchronous_access: false # each access has to wait on the previous access to be triggered
    valid_locations:          # locations to allow user to move to.
        - home
        - work
        - mobile
        - cloud

    invalid_types:        # replica types that shouldn't have accesses.
        # - storage
        - backup

    move_prob: 0.2        # probability of moving locations
    switch_prob: 0.6      # probability of switching devices
    object_prob: 0.3      # probability of switching the currently accessed object
    access_mean: 1600     # mean delay (milliseconds) between accesses
    access_stddev: 512    # standard deviation of delay (milliseconds) between accesses
    read_prob: 0.58       # probability of read access; write probability is 1 - read_prob

    # Eventual Parameters
    anti_entropy_delay: 10000         # delay in milliseconds (20x per minute)
    do_gossip: true                 # perform gossip protocol
    do_rumoring: false              # perform rumor mongering

    # Raft Parameters
    election_timeout: [300, 600]  # Range to randomly select the election timeout
    heartbeat_interval: 150        # Usually half the minimum election timeout
    aggregate_writes: true          # Don't send writes until heartbeat.

    # Tag Parameters
    session_timeout: 40960          # Related to the mean delay between accesses

We instead get missing results fields as follows:
======================================================================
FAIL: Run the raft consensus simulation without errors
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/benjamin/Repos/umd/cloudscope/tests/test_simulation/test_main.py", line 150, in test_raft_simulation
    self.assertReliableResults(results)
  File "/Users/benjamin/Repos/umd/cloudscope/tests/test_simulation/test_main.py", line 107, in assertReliableResults
    self.assertIn(metric, results['results'], "Missing '{}' metric from results".format(metric))
AssertionError: Missing 'visibility latency' metric from results

======================================================================
FAIL: Run the tag consensus simulation without errors
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/benjamin/Repos/umd/cloudscope/tests/test_simulation/test_main.py", line 171, in test_tag_simulation
    self.assertReliableResults(results, metrics=tag_metrics)
  File "/Users/benjamin/Repos/umd/cloudscope/tests/test_simulation/test_main.py", line 107, in assertReliableResults
    self.assertIn(metric, results['results'], "Missing '{}' metric from results".format(metric))
AssertionError: Missing 'session length' metric from results

----------------------------------------------------------------------

With the default configuration we're getting the following errors:
======================================================================
ERROR: Run the tag consensus simulation without errors
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/benjamin/Repos/umd/cloudscope/tests/test_simulation/test_main.py", line 159, in test_tag_simulation
    sim.run()
  File "/Users/benjamin/Repos/umd/cloudscope/cloudscope/simulation/base.py", line 147, in run
    self.env.run(until=self.max_sim_time)
  File "/Users/benjamin/.virtualenvs/cloudscope/lib/python2.7/site-packages/simpy/core.py", line 137, in run
    self.step()
  File "/Users/benjamin/.virtualenvs/cloudscope/lib/python2.7/site-packages/simpy/core.py", line 221, in step
    callback(event)
  File "/Users/benjamin/Repos/umd/cloudscope/cloudscope/replica/base.py", line 220, in recv
    return self.dispatch(message)
  File "/Users/benjamin/Repos/umd/cloudscope/cloudscope/replica/base.py", line 313, in dispatch
    return handler(message)
  File "/Users/benjamin/Repos/umd/cloudscope/cloudscope/replica/consensus/tag.py", line 652, in on_append_entries_rpc
    "{} is possibly receiving duplicate append entries".format(self)
TagRPCException: Home Desktop (r0) is possibly receiving duplicate append entries

======================================================================
FAIL: Run the raft consensus simulation without errors
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/benjamin/Repos/umd/cloudscope/tests/test_simulation/test_main.py", line 150, in test_raft_simulation
    self.assertReliableResults(results)
  File "/Users/benjamin/Repos/umd/cloudscope/tests/test_simulation/test_main.py", line 107, in assertReliableResults
    self.assertIn(metric, results['results'], "Missing '{}' metric from results".format(metric))
AssertionError: Missing 'visibility latency' metric from results

----------------------------------------------------------------------

Duplicate AppendEntries occurs when a heartbeat message arrives out of order from the previous heartbeat message - kind of a problem.

Fixed - ended up being related to the raft append entries thing.


realsense_camera: 1.8.0-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository realsense_camera to 1.8.0-0:

upstream repository: https://github.com/intel-ros/realsense.git
release repository: https://github.com/intel-ros/realsense-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.24
previous version for package: 1.7.2-0

realsense_camera
* Enable configuration of the TF publication rate when using tf_dynamic
* Enable roslint when CATKIN_ENABLE_TESTING is True
* Add option to link against non-catkin librealsense
* Fixed LR auto exposure (#131)
* Dynamic reconfig autoexposure/exposure control SR300/F200/R200 (#213)
* Added check for depth_enable dynamic change
* Update Debug Tool
* Added SyncNodelet class as new base for F200/SR300/R200 (#207, #210)
* Contributors: Amanda Brindle, Dmitry Rozhkov, James Sergeant, Mark Horn, Matthew Hansen, Reagan Lopez, Séverin Lemaignan

Will wait with the merge until we have synced...


step 3 is not running successfully.

I am cloning the project and running flutter pub get and then running flutter packages pub run build_runner watch but it is failing.
[INFO] Generating build script...
[INFO] Generating build script completed, took 220ms

[INFO] Creating build script snapshot......
[WARNING] stderr: Info: Compiling without sound null safety!
[WARNING] stderr: Dart 3 will only support sound null safety, see https://dart.dev/null-safety
[INFO] Creating build script snapshot... completed, took 7.0s

[INFO] Setting up file watchers...
[INFO] Setting up file watchers completed, took 10ms

[INFO] Waiting for all file watchers to be ready...
[INFO] Waiting for all file watchers to be ready completed, took 200ms

You have hit a bug in build_runner
Please file an issue with reproduction steps at https://github.com/dart-lang/build/issues

AssetNotFoundException: boilerplate|.packages
package:build_runner_core/src/asset/file_based.dart 135:18  _fileForOrThrow.<fn>
dart:async                                                  _CustomZone.runUnary
package:build_runner/src/generate/watch_impl.dart 329:20    WatchImpl._run.<fn>

I have tried flutter clean, deleting .dart_tools folder but they did not change anything. I have also tried flutter upgrade and flutter packages upgrade.

same problem

`name: boilerplate
description: A flutter boilerplate project created using MobX and Provider.
The following defines the version and build number for your application.
A version number is three numbers separated by dots, like 1.2.43
followed by an optional build number separated by a +.
Both the version and the builder number may be overridden in flutter
build by specifying --build-name and --build-number, respectively.
Read more about versioning at semver.org.
version: 1.0.0+1
environment:
sdk: ">=2.15.0 <3.7.7"
dependencies:
flutter:
sdk: flutter
flutter_localizations:
sdk: flutter
flutter_cupertino_localizations: ^1.0.1
The following adds the Cupertino Icons font to your application.
Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^1.0.3
The following adds the shared pref as a dependency in your application
shared_preferences: ^2.0.6
A composable, Future-based library for making HTTP requests.
http: ^0.13.3
Flogs, a powerful logging framework
f_logs: ^1.2.2
MobX is a library for reactively managing the state of your applications. Use the power of
observables, actions, and reactions to supercharge your Dart and Flutter apps.
mobx: ^2.0.1
flutter_mobx: ^2.0.0
An helper to easily exposes a value using InheritedWidget without having to write one.
provider: ^5.0.0
String validation and sanitization for Dart. Dart 2-compatible version of validator
validators: ^3.0.0
A powerful Http client for Dart
dio: ^4.0.0
A flexible widget for user notification. Customize your text, button, duration, animations
and much more. For Android devs, it is made to replace Snackbars and Toasts.
another_flushbar: ^1.10.23
Material Dialog
material_dialog: ^1.0.0-nullsafety.1
This package provides internationalization and localization facilities, including message
translation, plurals and genders, date/number formatting and parsing, and bidirectional text.
intl: any
XXTEA is a fast and secure encryption algorithm. This is a XXTEA library for Dart.
xxtea: ^2.1.0
An helper to easily exposes a value using InheritedWidget without having to write one.
sembast: ^3.1.0+2
path_provider: ^2.0.2
for dependency injection
get_it: ^7.1.3
google_fonts: ^2.3.2
dev_dependencies:
flutter_test:
sdk: flutter
The following adds the launcher icon support to your application.
run below mentioned commands to generate launcher icons
flutter packages get
flutter packages pub run flutter_launcher_icons:main
flutter_launcher_icons: ^0.12.0
mobx_codegen: ^2.1.1
build_runner: ^2.3.3
analyzer: ^5.10.0
flutter_icons:
image_path: "assets/icons/ic_launcher.png"
android: true
ios: true
For information on the generic Dart art of this file, see the
following page: https://www.dartlang.org/tools/pub/pubspec
The following section is specific to Flutter.
flutter:
The following line ensures that the Material Icons font is
included with your application, so that you can use the icons in
the material Icons class.
uses-material-design: true
To add assets to your application, add an assets section, like this:
assets:

assets/images/
assets/icons/
assets/lang/

An image asset can refer to one or more resolution-specific "variants", see
https://flutter.io/assets-and-images/#resolution-aware.
For details regarding adding assets from package dependencies, see
https://flutter.io/assets-and-images/#from-packages
To add custom fonts to your application, add a fonts section here,
in this "flutter" section. Each entry in this list should have a
"family" key with the font family name, and a "fonts" key with a
list giving the asset and other descriptors for the font. For
example:
fonts:

family: ProductSans
fonts:

asset: assets/fonts/Product-Sans-Regular.ttf
asset: assets/fonts/Product-Sans-Italic.ttf
style: italic
asset: assets/fonts/Product-Sans-Bold.ttf
weight: 700

For details regarding fonts from package dependencies,
see https://flutter.io/custom-fonts/#from-packages
`

to solve your problem your pubspec.yml should be like below.
name: boilerplate
description: A flutter boilerplate project created using MobX and Provider.
The following defines the version and build number for your application.
A version number is three numbers separated by dots, like 1.2.43
followed by an optional build number separated by a +.
Both the version and the builder number may be overridden in flutter
build by specifying --build-name and --build-number, respectively.
Read more about versioning at semver.org.
version: 1.0.0+1
environment:
sdk: ">=2.15.0 <3.7.7"
dependencies:
flutter:
sdk: flutter
flutter_localizations:
sdk: flutter
flutter_cupertino_localizations: ^1.0.1
The following adds the Cupertino Icons font to your application.
Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^1.0.3
The following adds the shared pref as a dependency in your application
shared_preferences: ^2.0.6
A composable, Future-based library for making HTTP requests.
http: ^0.13.3
Flogs, a powerful logging framework
f_logs: ^1.2.2
MobX is a library for reactively managing the state of your applications. Use the power of
observables, actions, and reactions to supercharge your Dart and Flutter apps.
mobx: ^2.0.1
flutter_mobx: ^2.0.0
An helper to easily exposes a value using InheritedWidget without having to write one.
provider: ^5.0.0
String validation and sanitization for Dart. Dart 2-compatible version of validator
validators: ^3.0.0
A powerful Http client for Dart
dio: ^4.0.0
A flexible widget for user notification. Customize your text, button, duration, animations
and much more. For Android devs, it is made to replace Snackbars and Toasts.
another_flushbar: ^1.10.23
Material Dialog
material_dialog: ^1.0.0-nullsafety.1
This package provides internationalization and localization facilities, including message
translation, plurals and genders, date/number formatting and parsing, and bidirectional text.
intl: any
XXTEA is a fast and secure encryption algorithm. This is a XXTEA library for Dart.
xxtea: ^2.1.0
An helper to easily exposes a value using InheritedWidget without having to write one.
sembast: ^3.1.0+2
path_provider: ^2.0.2
for dependency injection
get_it: ^7.1.3
google_fonts: ^2.3.2
dev_dependencies:
flutter_test:
sdk: flutter
The following adds the launcher icon support to your application.
run below mentioned commands to generate launcher icons
flutter packages get
flutter packages pub run flutter_launcher_icons:main
flutter_launcher_icons: ^0.12.0
mobx_codegen: ^2.1.1
build_runner: ^2.3.3
analyzer: ^5.10.0
flutter_icons:
image_path: "assets/icons/ic_launcher.png"
android: true
ios: true
For information on the generic Dart art of this file, see the
following page: https://www.dartlang.org/tools/pub/pubspec
The following section is specific to Flutter.
flutter:
The following line ensures that the Material Icons font is
included with your application, so that you can use the icons in
the material Icons class.
uses-material-design: true
To add assets to your application, add an assets section, like this:
assets:

assets/images/
assets/icons/
assets/lang/

An image asset can refer to one or more resolution-specific "variants", see
https://flutter.io/assets-and-images/#resolution-aware.
For details regarding adding assets from package dependencies, see
https://flutter.io/assets-and-images/#from-packages
To add custom fonts to your application, add a fonts section here,
in this "flutter" section. Each entry in this list should have a
"family" key with the font family name, and a "fonts" key with a
list giving the asset and other descriptors for the font. For
example:
fonts:

family: ProductSans
fonts:

asset: assets/fonts/Product-Sans-Regular.ttf
asset: assets/fonts/Product-Sans-Italic.ttf
style: italic
asset: assets/fonts/Product-Sans-Bold.ttf
weight: 700

For details regarding fonts from package dependencies,
see https://flutter.io/custom-fonts/#from-packages

name: boilerplate
description: A flutter boilerplate project created using MobX and Provider.
version: 1.0.0+1
environment:
sdk: ">=2.15.0 <3.7.7"
dependencies:
flutter:
sdk: flutter
flutter_localizations:
sdk: flutter
flutter_cupertino_localizations: ^1.0.1
cupertino_icons: ^1.0.3
shared_preferences: ^2.0.6
http: ^0.13.3
mobx: ^2.0.1
flutter_mobx: ^2.0.0
provider: ^5.0.0
validators: ^3.0.0
dio: ^4.0.0
another_flushbar: ^1.10.23
material_dialog: ^1.0.0-nullsafety.1
intl: any
xxtea: ^2.1.0
sembast: ^3.1.0+2
path_provider: ^2.0.2
get_it: ^7.1.3
google_fonts: ^2.3.2
dev_dependencies:
flutter_test:
sdk: flutter
flutter_launcher_icons: ^0.12.0
mobx_codegen: ^2.1.1
build_runner: ^2.3.3
analyzer: ^5.10.0
flutter_icons:
image_path: "assets/icons/ic_launcher.png"
android: true
ios: true
flutter:
uses-material-design: true
assets:

assets/images/
assets/icons/
assets/lang/

fonts:

family: ProductSans
fonts:

asset: assets/fonts/Product-Sans-Regular.ttf
asset: assets/fonts/Product-Sans-Italic.ttf
style: italic
asset: assets/fonts/Product-Sans-Bold.ttf
weight: 700

changing to the next pubspec.yml worked for me:

name: boilerplate
description: A flutter boilerplate project created using MobX and Provider.

# The following defines the version and build number for your application.
# A version number is three numbers separated by dots, like 1.2.43
# followed by an optional build number separated by a +.
# Both the version and the builder number may be overridden in flutter
# build by specifying --build-name and --build-number, respectively.
# Read more about versioning at semver.org.
version: 1.0.0+1

environment:
  sdk: ">=2.15.0 <3.7.7"

dependencies:
  flutter:
    sdk: flutter

  flutter_localizations:
    sdk: flutter
  flutter_cupertino_localizations: ^1.0.1

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^1.0.3

  # The following adds the shared pref as a dependency in your application
  shared_preferences: ^2.0.6

  # A composable, Future-based library for making HTTP requests.
  http: ^0.13.3

  # Flogs, a powerful logging framework
#  f_logs: ^1.2.2

  # MobX is a library for reactively managing the state of your applications. Use the power of
  # observables, actions, and reactions to supercharge your Dart and Flutter apps.
  mobx: ^2.0.1
  flutter_mobx: ^2.0.0

  # An helper to easily exposes a value using InheritedWidget without having to write one.
  provider: ^5.0.0

  # String validation and sanitization for Dart. Dart 2-compatible version of validator
  validators: ^3.0.0

  # A powerful Http client for Dart
  dio: ^4.0.0

  # A flexible widget for user notification. Customize your text, button, duration, animations
  # and much more. For Android devs, it is made to replace Snackbars and Toasts.
  another_flushbar: ^1.10.23

  # Material Dialog
  material_dialog: ^1.0.0-nullsafety.1

  # This package provides internationalization and localization facilities, including message
  # translation, plurals and genders, date/number formatting and parsing, and bidirectional text.
  intl: ^0.17.0

  # XXTEA is a fast and secure encryption algorithm. This is a XXTEA library for Dart.
  xxtea: ^2.1.0

  # An helper to easily exposes a value using InheritedWidget without having to write one.
  sembast: ^3.1.0+2
  path_provider: ^2.0.2

  # for dependency injection
  get_it: ^7.1.3

  google_fonts: ^2.3.2

dev_dependencies:
  flutter_test:
    sdk: flutter

  # The following adds the launcher icon support to your application.
  # run below mentioned commands to generate launcher icons
  # flutter packages get
  # flutter packages pub run flutter_launcher_icons:main
  flutter_launcher_icons: ^0.12.0
  mobx_codegen: ^2.1.1
  build_runner: ^2.3.3
  analyzer: ^5.10.0

flutter_icons:
  image_path: "assets/icons/ic_launcher.png"
  android: true
  ios: true

# For information on the generic Dart art of this file, see the
# following page: https://www.dartlang.org/tools/pub/pubspec

# The following section is specific to Flutter.
flutter:

  # The following line ensures that the Material Icons font is
  # included with your application, so that you can use the icons in
  # the material Icons class.
  uses-material-design: true

  # To add assets to your application, add an assets section, like this:
  assets:
  - assets/images/
  - assets/icons/
  - assets/lang/

  # An image asset can refer to one or more resolution-specific "variants", see
  # https://flutter.io/assets-and-images/#resolution-aware.

  # For details regarding adding assets from package dependencies, see
  # https://flutter.io/assets-and-images/#from-packages

  # To add custom fonts to your application, add a fonts section here,
  # in this "flutter" section. Each entry in this list should have a
  # "family" key with the font family name, and a "fonts" key with a
  # list giving the asset and other descriptors for the font. For
  # example:
  fonts:
  - family: ProductSans
    fonts:
    - asset: assets/fonts/Product-Sans-Regular.ttf
    - asset: assets/fonts/Product-Sans-Italic.ttf
      style: italic
    - asset: assets/fonts/Product-Sans-Bold.ttf
      weight: 700

  # For details regarding fonts from package dependencies,
  # see https://flutter.io/custom-fonts/#from-packages

Apologies for the delay. The latest changes have been merged into the main branch, and the issue should now be resolved. Please pull the latest changes and let us know if you encounter any further issues.


2.1.4-beta Area2D error on KinematicBody2D.queue_free()

Operating system or device - Godot version:
Debian 9 - Godot 2.1.4-beta
Issue description:
I have a scene which have an Area2D node as root node, doing .queue_free() inside the "body_enter" signal logs this eror

"Condition '!node' is true. Continuing..."

The error says is on "scene/2d/area2d.cpp:332" in "_clear_monitoring" function.
I also have a VisibilityNotifier2D node with an "exit_screen" signal, and I do .queue_free() there too, but it doesn't trigger the error.
EDIT
------
Seems it has nothing to do the bullet, it's the target that is throwing the error. Here is a demo project.
Demo.zip

What node does the .queue_free? (tried with the same area but does not throw any error)
Can you make a small project with that error to see it better?

@eon-s I updated the issue and upload a demo project.

Tested with a recent build too.
If you do call_deferred("queue_free") on the KinematicBody2D it does not throw any error.
@RandomShaper may know better if this is a bug or the deferred call cannot be avoided.
This may be related or duplicate of #1247 too.

Ty, will use call_deferred()... Will leave this open then.

Added to my backlog.

The error is printed at area_2d.cpp because of
Node *node = obj ? obj->cast_to<Node>() : NULL;
ERR_CONTINUE(!node);

but if you look a few lines below, in similar code, you have:
Node *node = obj ? obj->cast_to<Node>() : NULL;

if (!node) //node may have been deleted in previous frame, this should not be an error
    continue;
//ERR_CONTINUE(!node);

In this case, when that happened wouldn't be exactly the "previous frame", but I belive the situation in the first loop is as benign as in the second one.
So this is expected to work, but the warning may be misleading.

Manually closing via  #9591.


make meteor-desktop-toaster plugin

Wrap electron-toaster into a plugin so it could be used directly on the desktop side instead of calling it from the renderer process.
Add an example - showing notification about HCP update being applied.

hi, trying to do the same with icon badges, but I am very very new at all this so please excuse any noob stuff.
so far got them working as a module for os x, but for windows i m kind of hitting a brick wall as it seems i need to get access to the window and draw an icon and so on.
This pretty much made me realise I don t understand clearly how your skeleton is structured from the point of view of main process and renderer process.
I assume that whatever s in meteor is the implicit renderer and that modules run in the main process, but couldn't really find any clear distinction in the docs (and being very new at this, it might have been there, but not clear enough for me to understand).
Also I couldn t find a way to get a reference to the main window from a module.
Could you ping me in the right direction to understand more on how all this is supposed to work together?
The plan for now is to make it work as  a module then to try and turn it into a plugin, so if you are ok with it, i might open more issues related to guidance on this.
P.S. my current thrain of thought is that since the module runs in the main process, i need to use some plugin to render an image (maybe some npm lib) with the badge and just use that instated of document canvas functions I don t have access to on the main process side. a confirmation if i m on the right track would be marvelous :D
thanks again

Task moved to Taiga.

in essence meteor-desktop-system-notifications does notifications and dock badges until this is ready
is taiga public?

@tzapu to be honest I will probably not make it as I like your plugin more than https://github.com/s-a/electron-toaster ;)
Now I am considering adding an example of using your plugin  or even including it in the default scaffold.
Yes, Taiga is public, the project should be accessible without login -> https://tree.taiga.io/project/wojtkowiak-meteor-desktop/us/6?no-milestone=1

thanks
taiga works ;) never worked with it before
if you are ok with it, i would like to add you as a contributor to the notifications plugin, maybe you need to change apis or something and can t wait on me (especially if it gets recommended)
let me know
alex

if you are ok with it, i would like to add you as a contributor to the notifications plugin, maybe you need to change apis or something and can t wait on me (especially if it gets recommended)

Sure, I'd be honored 👍


Make resync interval in controllers configurable

The resync interval in the controllers should be configurable. Right now, its hardcoded to 10 + (0-5) seconds in the address controller. I'm thinking we should expose 2 envs in the address controller, standard controller and agent:
RESYNC_INTERVAL_MIN_MS
RESYNC_INTERVAL_VARIANCE_MS
@grs wdyt? I'm not sure if the agent has the variable part, but I assume the first variable makes sense?

Resync what?

The address configmaps. In the java controllers, the configmaps are periodically refreshed and watches reset.

@lulf, the agent issues a standard GET then watches the list until the watch is ended, then it reissues the GET and watches again etc. There are no times hardcoded around this.

@grs After giving it some more thought, I'm not sure having a MIN and MAX gives us much, since its such a long period, and its only used once in each controller, and since they will start up at different times there is no gain in randomizing.


Unable to open the same VNC session with multiple users

Trying to open the same session from multiple computers does not work.

Fixed in https://github.com/aerokube/moon2/pull/116.


Fix ServiceCatalogWebTest#testConsoleErrorOnDeleteAddressSpace

Type of change

Bugfix

Description
Test was still looked for the behaviour from the old console.  I needed to add an id to the NoDataFound tsx to be able to detect the content from the test.
Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@enmasse-ci run tests testcase=ServiceCatalogWebTest#testConsoleErrorOnDeleteAddressSpace

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: ServiceCatalogWebTest#testConsoleErrorOnDeleteAddressSpace
TOTAL: 1
PASS: 1
FAIL: 0
SKIP: 0
BUILD_NUMBER: 451


Get status code from Esp OTA HTTP (IDFGH-13394)

Is your feature request related to a problem?
Running HTTP OTA for Esp, the "esp_https_ota_perform()" function does not return the status code. If you make a firmware image available on a host server and remove it, the function will show the log "File not found" but will continue to try to download the image. In fact, it is possible to notice that even when faced with this error, if you call the "esp_https_ota_get_image_len_read()" function after the "esp_https_ota_perform()" function you will notice that it will continue to return a value greater than 0; this doesn't make any sense, since there is no more image available on the server.
Describe the solution you'd like.
The solution is simple: create the public funtion esp_https_ota_get_status_code(esp_https_ota_handle_t * http_ota_handle) to allow get the last status code logged. This will allow the developer to make precise interventions in their code.
Describe alternatives you've considered.
No response
Additional context.
No response

focus on this issue, wating for the reslut

@LouisMaiaDev
Thank you for reporting this issue.
I attempted to reproduce the behavior on my setup by hosting a local Python-based server using python based server but I was unable to replicate the problem.
Could you please share more details about your setup or any specific steps you followed that might help in reproducing the issue? This information will be crucial for us to investigate further.

Yes, I can!
It's quite simple. Host the Esp firmware image on Google Drive or AWS (which is the way I'm using it) and launch Esp FOTA. If you still cannot reproduce the error, post here and I will publish the image that proves the existence of this error. As a solution, I had to implement the solution mentioned above in Espressif's HAL and this way I was able to intervene and handle this error appropriately.

Hello @LouisMaiaDev ,
Could you please share the respective OTA image? I could not reproduce the issue using the image uploaded to Google Drive, which is approximately 960KB in size.
Additionally, it would be greatly appreciated if you could share the patch detailing the changes you made to the file, as mentioned above.

Hi @LouisMaiaDev
I have created a patch to address the issue. Please review it and let me know if this meets your requirements or if any additional changes are needed.
api_to_get_last_status_logged.txt
Thanks.

Show, good! Very good @nileshkale123 !


FB Audience Network for iOS version 4.26.0

Now the source is fetched from cocoapods to keep supporting iOS 7

Needs license review.


Fix non-conforming accounts and single-account vanguard profiles.

In this PR, I am patching two bugs: one for non-confirming accounts (with no account number) by skipping the order for them. The other is that for single-account Vanguard logins, no "Select Account" option is available; the solution is to skip it if no header is found by letting the selector timeout gracefully.

Thanks for your contribution. Tested and it looks great.


Fixed a race condition and added a performance optimization for macos

With F_FULLSYNC macos is about 20x slower on the stress test.  With fsync performance is about the same as linux. F_FULLSYNC used to be much faster  in MacOS Catalina, but I think in recent OS versions they have something broken in the kernel that affects performance here. I did some extensive testing and was unable to cause data corruption with fsync. This may not be the case for external drives or older HDDs, but for internal SSDs it should be fine.

I did some extensive testing and was unable to cause data corruption with fsync. This may not be the case for external drives or older HDDs, but for internal SSDs it should be fine.

I think you only get the corruption on power loss (when the drive cache is dropped). You won't be able to test that easily on a device with a battery, right?

My tests involved cutting the power by long pressing the power button on a macbook.  I think this is wired in hardware to cut the power to the system regardless of the battery. Not sure what kind of power loss protection the internal SSD is using. It may be relying on system battery still or have additional capacitors. Or have none at all. Would be good to test in on a Mac mini though. I suspect that regular flush works for ParityDb because it still flushes everything to the NVMe controller, which creates an ordering. ParityDb can handle failed flush as long as write ordering is preserved. I.e. after a successful flush it should not be possible for writes occurred before flush to be lost, while writes after flush to be persisted.
In any case, I don't consider this to be much of an issue for substrate. Pretty much all of the validators use linux and also run in power loss protected data centres.


Android Basics: Fragments Navigation component

URL of codelab
In which task and step of the codelab can this issue be found?
In the codelab Fragments and the Navigation Component in the
4. Create Fragment and layout Files
Describe the problem
In the final part when viewing it in Spanish, an error is presented in the code for fragment_letter_list.xml since the part of the code of tools: context = ". WordListFragment" must be tools: context = ". LetterListFragment">, but only It is presented when it is read in Spanish
Steps to reproduce?

Go to...   codelab Fragments and the Navigation Component
Click on...  in the Create Fragment and layout Files and change lenguage to Spanish
See error...  in the code for fragment_letter_list.xml

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Duplicate of #155, #191


License style cleanup

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew tests with your changes locally?

This PR does a few things:

License arrays are now converted to hashes in the license method rather than on-demand when needed by e.g. audit. This means that calling formula.license will always return either a string, symbol, or hash.
Deprecate license arrays. This will display a deprecation message whenever license [...] is called. This message would show up when running brew audit, brew install, etc.
brew style forbids using license arrays. brew style --fix will automatically correct license arrays to an :any_of hash.
brew style requires using multiple lines for license expressions if there are nested hashed. This means that license any_of: ["MIT", "0BSD"] is allowed but license any_of: ["MIT", "0BSD" => { with: "LLVM-exception" }] is not.

If license arrays are no longer allowed, then I think bump-revision needs an update to revert 1ac470fe7a939c628f8e532e313ae06a11aeca4a from #8139, though I'm not sure if that will be sufficient to support symbols or hashes. I'll investigate further...

@scpeters I've got a fix in #8708


Add realsense in the copilot application

This PR adds the command to start the realsense camera in the copilot application.
CC @nicktrem

Thank you! Merging!


patch failed: config.yaml:17

Hi @tdjames1
I tried following the instructions, got to applying the patch and received the following message:
error: CITATION.cff: already exists in index
error: patch failed: config.yaml:17
error: config.yaml: patch does not apply

I'm on windows and I started with the Rmd template from the carpentries if that makes any difference.
Thanks,
Dan

Thanks for noting this error, it's because the carpentries template has been adjusted to include a CITATION.cff file which it didn't at the time of developing the patch file (see #23). A quick fix would be to remove lines 1-30 inclusive of the patch file, then edit the CITATION.cff with the info indicated in that section of the patch file.

Got it, will give that a go and report back. Thanks!

Had a go and that fixes the first part of the error:
error: CITATION.cff: already exists in index

The second part remained:
error: patch failed: config.yaml:17
error: config.yaml: patch does not apply

I had a bit of a tinker with it and it's because there's been a change to config.yaml that means that patch doesn't match up any more. Once I added the additional text it worked okay.
Would it be worth me regenerating the patch given I'm going to have to make these changes to my repo anyway?

If you'd be happy to do it that would be great!
I create the patch by creating a repo from the workbench template, making the various changes then running:
git diff daa55ad6609e.. > fair4rs_config.patch

where the daa55ad commit was the initial commit i.e. the unmodified workbench template.


Distinct feature params for different script/langsys entries?

@khaledhosny Is the support for writing feature params for ssXX and cvXX features via the YAML config file for GSUB from VOLT .input.ttf files currently able to support distinct feature params for different script and/or langsys entries? Use case would be Brill, in which e.g. Latin an Greek have different implementations for ss01 and ss02, and other ssXX features currently have only Greek implementations.
Peter C and Behdad have confirmed that this is possible within the GSUB table structure. See:
https://github.com/MicrosoftDocs/typography-issues/issues/1015#issuecomment-1763695680
I’ve not got to the build test stage of Brill updates yet, but wanted to check whether you anticipate any limitations in this area?

No, not currently.
Currently the feature params are added to all features that match the given feature tag. We can possibly extend the syntax to allow for script and language tag, something like ss01.latn.ENG with both the script and language parts being optional.

It would be a issue, though, if the same feature is referenced from different language systems but are requested to have different feature params. It would be rather complicated to try to handle this at the binary font level, so I think I’ll make it an error instead and the GSUB/GPOS table would have to be fixed before hand.

Will review and test this in next few days.
It would be a issue, though, if the same feature is referenced from different language systems but are requested to have different feature params.
To clarify, is this an issue in the new implementation, or were you able to work around it?

Will review and test this in next few days.
It would be a issue, though, if the same feature is referenced from different language systems but are requested to have different feature params.
To clarify, is this an issue in the new implementation, or were you able to work around it?

The code will error for now. It feels unlikely that these two conditions are met (same feature record referenced from different language systems and two different feature params are used for it), but if we catch an actual real case of this, we can figure out a fix then (it probably not that hard to split the feature record).

Note that it is normal, even common, to have multiple feature records for the same feature tag (e.g. I can count 11 ss01 feature records in a font I’m testing), usually each record is referenced from a different language system.

I am testing this functionality for the update Brill fonts, and running into an issue this this config:
    featureparams:
      ss01.latn: Round capital Eng
      ss01.grek: Prosgegrammeni to ypogegrammeni
      ss02.latn: Round descending capital Eng
      ss02.grek: Variant capital Iota dialytika
      ss03.latn: Monoline grave and acute modifiers
      ss03.grek: Acraphonic forms
      ss04.latn: Insular forms
      ss04.grek: Three-bar acrophonic stater variant
      ss05: Narrow angle brackets
      ss20: Latin phonetic forms of Greek letters
      cv01:
        label: Capital Eng
        tooltip: Round and round descending capital Eng forms
        characters: [0x014A]
      cv02:
        label: Koronis editorial sign
        tooltip: Sigmoid and horizontal koronis sign forms
        characters: [0x2E0E]
      cv03:
        label: Chinnantec tone signs
        tooltip: Monoline grave and acute modifiers
        characters: [0x02CB, 0x02CA]

I get this error message:
RuntimeError: Feature “ss01.latn” already has “featureparams”
Perhaps I need to always specify a langsys as well as a script?

It was breaking on the statics because the featureparams were already added to the VF before instancing them.


chore: disable cdn plugin when environment variable is not set

:tada: This PR is included in version 3.1.141 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Metrics reporting search query's should not be case sensitive

investigate if we can lowercase all search queries prior to executing them so that our metrics don't report users searching on both "MAp" "map" and/or "MAP" as different queries.

On hold for testing until communication between Latest to Metrics server is established.

I as unable to access metrics.  Not sure why yet but Soe was able to verify for me that results were returning with UPPERCASE, lowercase and Both in IE10, CHROME and FF.