Custom serializer output is html entity encoded

I have code roughly as:
const renderCtaButtonToMarkdown = ({ node: { linkUrl, text } }: any): string =>
  `[${text}](${linkUrl})`

const bodyText = blocksToMarkdown(bodyBlocks, {
  serializers: {
    types: {
      ctaButton: renderCtaButtonToMarkdown
    }
  }
})

Which gives the output
[My text](http://localhost:3000/foo/bar)

There seems to be some kind of undocumented behavior that "dangerous" characters are getting html entity encoded. How do I disable this? My values come from the CMS so I can assume them to be safe, especially in this context.

Thanks for reporting! I must admit I haven't seen this behaviour from this package before. I can't reproduce it either. Could you give us some more details of what environment you are it etc?

Looks like I spoke to soon thinking this was related to https://github.com/sanity-io/block-content-to-html/issues/3 somehow, where I had actual problem. In this case I didn't realize it was actually mustache.js escaping the link because of double curly braces. 🤦♂
Apologies for the noise.

That’s ok :) let us know if you hit any problems!


Add November system events

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Messaging.EventGrid


download artifacts improvements

We lost some nice features in our hurry to get new artifacts from dev branches.

We switched from Buildkite to GitHub Actions. GitHub Actions requires an authentication token to get the artifacts. It would be more convenient if we didn't have to provide one. Actually Buildkite builds the oasis-node and oasis-net-runner etc. for development branches too, so I think it would be nice to switch back. But comment here if there are other reasons to prefer GitHub Actions.
We stopped labeling the downloaded artifacts with their version. This is fine on CI where we start with nothing each time, but it's a worse experience for local development. The script doesn't update your software when it's out of date. We should restore this functionality.

fixed in #193


feat: [LW-9189] fetch and validate metadata

This PR fetches the off-chain metadata from the metadata url and removes the need for a local copy of the off-chain metadata.
This also improved the formatting of the codes to make them more consistent.

I tested this and it works as expected.
Steps I used to test this:
Used previous version from current main and submitted a dApp - LINK TO TRANSACTION
Used new version with same offchain metadata uploaded - LINK TO TRANSACTION
As can be seen, on-chain metadata is the same in both versions, which is expected.


Crossed IPs handling

Sometimes IPs from different cassandra nodes of the same cluster can be exchanged and in that case Cassandra refuses to start. CassKop introduced a fix to this issue described here.
What it does is store the host/ID map and when it sees that the map changed with an exchange of IPs from the previous time it collected it, it kills those pods and let k8s restart them.
The current code is available at https://github.com/Orange-OpenSource/casskop/blob/v1.0.0-release/pkg/controller/cassandracluster/reconcile.go#L708-L721 and https://github.com/Orange-OpenSource/casskop/blob/v1.0.0-release/pkg/controller/cassandracluster/reconcile.go#L751-L794).
The goal of this ticket is have it handled in cass-operator.

Migrated over to https://github.com/k8ssandra/cass-operator/issues/130


@AmirMz1 Radar will detect obstacles infront of it and this code shown will show the detected points with its velocity, azimuth, altitude and longitudinal distance from radar.

          @AmirMz1 Radar will detect obstacles infront of it and this code shown will show the detected points with its velocity, azimuth, altitude and longitudinal distance from radar.

You will need to do trial and error for mostly to know which points to take into consideration.
I think it is not possible to get the distance particularly from cars only. but my knowledge is limited.
You can see the images below for radar detection and its values

Originally posted by @sbv198 in https://github.com/carla-simulator/carla/issues/5395#issuecomment-1221949743
Can anyone post the whole code. I am getting black list of points instead of values.
I want to use radar to measure the distance between moving cars.

Radar sensor is not working in Imported map from RoadRunner.
Can anyone help with this please?

It is better to use some algorithms to avoid unnecessary points detected by radar.
Like in the image above with detected points it white points have the same velocity as ego while red and blue points have different  velocities so you can create some algorithms based on this  so it will eliminate all the points that have same velocities as ego

But the problem is I am getting blank list of points. It is working for other town map but when I run the same program it shows blank list although two cars are moving opposite to each other. How to resolve this?


KAFKA-5893: ResetIntegrationTest fails

improve stderr output for better debugging

This is WIP. I hope the build fails. We got quite some failing build but the output only says:
Standard Error
ERROR: null
ERROR: null

Ie, the exception we catch has no error message. Printing the whole stack trace should shed some light on this.
\cc @guozhangwang @dguy @bbejeck

@mjsax, Did you want me to merge this? You said it is a WIP in your comment, so i'm unsure?

Well. This does not fix the issue that's why it's WIP -- we can merge to figure out the root cause (the change makes sense anyway). But we should not close the JIRA as resolved (-> WIP).

Is this failure easily reproducible locally, or only on Jenkins? I'd prefer to merge a PR that fixes the issue altogether with logging improvements. We can use jenkins bots to continuously trigger builds until it fails.

@guozhangwang Updated this PR. I could not reproduce it locally, so I guess we need to merge this to get more insight why it's failing.

retest this please

retest this please.

Merged to trunk


expand qemu overhead

I cannot start Windows 10 inside EVE with 500MB overhead limit. Can we expand it a little?
Signed-off-by: Petr Fedchenkov<EMAIL_ADDRESS>

in for a penny, in for a pound -- I suppose :-(
However, 600Mb of pure overhead is obviously madness -- so as we've agreed with @temerkhanov -- lets get a good understanding of where this memory goes and whether there's something simple we can do to reduce it.
In the meantime -- I'll merge this to unblock your work


Improve statistical indicators

Motivation
"Improved message write statistics for topics" is  a program of "Summer 2021 of Open Source Promotion Plan" :  Restores the number of writes to the topic when the broker restarts or the topic changes.

Modifications

I add the getLastEntry() method  in ManagedLedgerImpl.java to  get the last written data for a topic.
I add some code in BrokerService.java to restore the number of writes when broker load the topic.
I add four test function in BrokerServiceTest.java to test the function I add

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change added tests and can be verified as follows:

Restore the number of writes without batch  when broker restarts.
Restore the number of writes without batch  when broker restarts and sending messages  asynchronously
Restore the number of writes with batch  when broker restarts and sending messages  asynchronously
Restore the number of writes with batch  when topic is unloaded  and sending messages  asynchronously

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: ( no)
The schema: (no )
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant.


segfaults on failures

any cedar syntax errors in the input of evaluate/validate with this library result in a segfault
this is very dangerous to use in production as we don't have a way of catching and handling such errors
ideally should return the root Cedar error message, or just a generic Go error

Hi @yuana97,
Apologies for the poor error handling, CGO is a fickle beast.
I'd accept a PR for the fix, however I personally found much more success with the WASM-based execution engine over at https://github.com/Joffref/cedar
Maybe give that a try?

We'll definitely look into getting a fix in for this post re:invent.
Interestingly, that WASM library doesn't work well for us due to ~500ms initialization time, which would kill our lambda performance (serverless)


[Exam] Enhance nav bar status

Checklist

[ ] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[ ] Server: I added multiple integration tests (Spring) related to the features (with a high test coverage)
[ ] Server: I added @PreAuthorize and check the course groups for all new REST Calls (security)
[ ] Server: I implemented the changes with a good performance and prevented too many database calls
[ ] Server: I documented the Java code using JavaDoc style.
[ ] Client: I added multiple integration tests (Jest) related to the features (with a high test coverage)
[ ] Client: I added authorities to all new routes and check the course groups for displaying navigation elements (links, buttons)
[ ] Client: I documented the TypeScript code using JSDoc style.
[ ] Client: I added multiple screenshots/screencasts of my UI changes
[ ] Client: I translated all the newly inserted strings into German and English

Motivation and Context

Description

Steps for Testing

Log in to Artemis
Navigate to Course Administration
...

Test Coverage

ExerciseService.java: 85%
programming-exercise.component.ts 95%

Screenshots

Bundled with https://github.com/ls1intum/Artemis/pull/2096


feat: Make "hint" and "predictive" the color of comments

Hi!
Big fan of Zed and this wonderful Tokyo Night theme!
There is just one thing I changed immediately after switching over to this theme:
I made the "hint" add "predictive" colours the colour of the comments.
The "cream" colour was just too distracting to me.
In this PR, I change the occurrences #cfc9c2 to #51597d (Tokyo Night) and #5f6996 (Tokyo Night Storm).
If you do not feel the same, feel free to ignore this PR.

I think this looks much better, thanks for the contribution!


Updates to work with new version of GamsStructure

@JuliaRegistrator register()

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.


ENH: Fix random seed in registration test

Fix random seed in registration test for the sake of reproducibility.

Not sure whether this would fix #155.


Separate minify-css, minify-js, and minify-html tasks from minify task.

Make sub tasks separate tasks for the minify task then let the minify task import the pipes from the other tasks to use within it.

Actually not even going to implement this untill there is more benefit to the user other than clearer configuration (only benefit currently is clearer configuration and ability to extend task more coherently from within bundle config).


Split coverage and coveralls scripts for local coverage use

Coverage remained the same when pulling cb96495c1625b5646c4f592cb0ec5d3b04e342a7 on hardikj:coverall into 2ad81946eeab16f99743ead5ff837df1b14e4d30 on wikimedia:master.


How can I install hoverfly as windows service or install to iis

Hi I am new at hoverfly and I am looking for some information
I download hoverfly windows setup.But I am little bit confused
when I use to hoverctl  start and this time hoverfly start to work on the fly but when I close command line it goes down
Is it possible to install hoverfly like windows service or install to iis.So when machine is shutdown or closed it can be automatically start.
Thank

@BilgehanYildiz This may just be down to how Windows works. This forum discussion might give you some ideas on how to fix the problem: https://serverfault.com/questions/39451/there-is-any-way-to-run-processes-in-the-background-in-windows-nohup-equivalent

When command prompt is closed all gone?What I want to ask is there any out of the box solution about that to install hoverfly windows server

No there isn't


Change S3 URLs to virtual-hosted style

Cf. https://aws.amazon.com/de/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/

Use fix in dvelop-apptemplate-go. Cf. https://github.com/d-velop/dvelop-app-template-go/issues/7


Use id attribute for scrolling in case page

Note: for support questions, please use stackoverflow. This repository's issues are reserved for feature requests and bug reports.

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] support request => Please do not submit support request here, see note at the top of this template.

Do you want to request a feature or report a bug?
Add attribute in WarsCaseCard component

What is the current behavior?
Use a function to scroll when loading element the first time

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

What is the motivation / use case for changing the behavior?
It doesn't need a library and it works on most of the browser (except IE on XP)

@nandiheath I need your comment before implement and send out PR

i think we better create a separate page for each of the WarCase
so it is more beneficial for 1) sharing 2) no more stupid scrolling..

let me spend some time to do this on weekend


fix 404s and redirects

Storage account - changes 404 path
Storage account - adds firewall rules allowing only Azure services
Redirects - change from IIS specific file to Gatsby's createRedirect

redirects are html pages with meta refresh tags (since there is no server to redirect)
redirects are static hosting friendly
redirects are not listed in sitemap (google will use sitemap to reindex)

Relates to #1326

Figure: Screenshot of build artifact - Gatsby is now configured to generate redirects that are static hosted friendly

deployed to staging for testing - https://github.com/SSWConsulting/SSW.Rules/actions/runs/8917869996


Add support for the Raspberry Pi Pico

added a new HAL for the Pico (uses the Pico-SDK)
added an example

Coverage remained the same at 95.522% when pulling e43f426db8ad08dd252108d4245cbea19857e32e on add_raspi_pico_support into 64b268a50e72fd7fb5a24dd13b625f2d1b7e3dc7 on master.


Comprehensive list of changes for this to work?

I previously had an install working but I lost access to the server/data and I'm trying to set it up again.
Is there a list somewhere of all of the things we need to change to fix the issues that arise after following the installation instructions....
Things I'm aware of being broken:

LAC and JAX team settings.  I believe you need to insert them into the database, and possibly also modify teams.py somewhere
Weird errors with some names that have a comma in them?
Other things I can't remember :)

If anyone has a list or a fork I can copy/compare from, that would be great.
Thanks!

I just got setup with everything. I think I should be good. I had to do the insert trick with the LAC and JAX teams.
Problem I am having now is I cant see anything when using q.game(season_year=2018, ...

Problem I am having now is I cant see anything when using q.game(season_year=2018, ...

This is an upstream uproblem.  See https://github.com/derek-adair/nflgame/issues/3 and https://github.com/BurntSushi/nflgame/issues/363.
If you feel like using my redux repository the 2018 data is packaged up in nflgame-redux==1.2.22-rc1
There are a number of options for you to get nflgame up and running (and thus nfldb) for the 2018 season.

Also until derek-adair/nflgame#3 is addressed the current week will not be functioning for the 2018 season.


Synchronous ResponseHandler used in AsyncHttpClient.

When I use AsyncHttpClient, it cause the following issues."Synchronous ResponseHandler used in AsyncHttpClient. You should create your response handler in a looper thread or use SyncHttpClient instead."
is that means I need use the SyncHttpClient ?

Closing as duplicate of #828


Set up base UI constructs in Storybook for easier development processes

No longer valid. Closing this one.


Update documentation and add vignettes skeleton

I updated the documentation to avoid CaMeLCasing issues. I am merging before any real progress was made on vignettes because of an incoming demonstration.

Fixed pull request.


This PR is a part of ongoing hi localization

Opening a fresh PR and closed  #29540

/retitle [hi] Add content/hi/docs/setup/production-environment/container-runtimes.md

/remove-area blog release-eng
/remove-kind support
/remove-language de en es fr id it ja ko pl pt ru uk vi zh
/remove-sig release


Can't find file because of extension omitted

Hi!
I'm trying to make a bundle with Angular 2 on Windows and get this error:
Could not load /node_modules/rxjs/symbol/observable (imported by \node_modules\@angular\core\src\util\lang.js): ENOENT: no such file or directory, open '\node_modules\rxjs\symbol\observable'
Angular imports like this:
import { $$observable as symbolObservable } from 'rxjs/symbol/observable';
Is there any option to force adding .js to the import?

If I recall, to solve this you need the following line:
https://github.com/OasisDigital/angular-aot-es2015-rollup/blob/master/rollup.config.js#L38
    commonjs({
      // make it possible to find these individual intra-package files
      include: [
        'node_modules/rxjs/**'
      ]
    }),

That doesn't help me. I can see in your config that you are not using the resolve plugin that causes the error.
I have tried the same config on Linux and it works.
My rollup config file:
`import alias from 'rollup-plugin-alias';
import typescript from 'rollup-plugin-typescript';
import resolve from 'rollup-plugin-node-resolve';
import commonjs from 'rollup-plugin-commonjs';
export default {
entry: 'public/vendor.ts',
dest: 'public/dist/vendor.es2015.js',
format: 'iife',
moduleName: 'vendor',
plugins: [
alias({ rxjs: __dirname + '/node_modules/rxjs' }),
resolve({ module: true,
main: true,
preferBuiltins: true,
extensions: [ '.js' ] }),
commonjs({
include: [
'node_modules/rxjs/**'
]
})
]
}`

This is odd, it normally works fine — can you provide a repro please?

I can't reproduce now after completely removing and reinstalling node_modules. Closing the issue.


Skip Topic Cleanup After Docker Restart

A standard benchmark restarts docker in between every test run.  During the nightly build this can happen over 500 times for the full benchmark run.  The Benchmark framework cleans up any Kafka topics before producing the topics needed for the test.
In between the tests, the benchmark framework does docker compose down followed by docker compose up.  This essentially resets both DH and Redpanda, excepting any mounted directories like "/data" that are outside each image's layered file system.  For Redpanda, this means that any persistent data (e.g. topic) is removed.  So there is no need to cleanup topics before each test when docker restart is enabled.
Changes:

Add configurable flag to Generators to skip Kafka topic cleanup if docker restart is enabled
Update benchmark framework to detect docker restart enabled and configure Generator to skip topic cleanup

Benefits:

Over the course of hundreds of benchmarks, a time improvement is expected
This may help with https://github.com/deephaven/benchmark/issues/140

After more investigation, this is unlikely to provide and real benefit, since the situation does not happen on every restart, but rather when parquet files are generated.  Since generated files are reused, it doesn't happen on every restart.


moving etheruem calls to its own namespace

in all cards, all references to ethereum events and calls are reällocated to the ethereum namespace
detail: http://tokenscript.org/2020/06/tokenscript#ethereum-namespace
This needs to be merged in at the same time as https://github.com/AlphaWallet/TokenScript-Examples/pull/73

Withhold merging until the apps and tokenscripts are ready


Migrate blocks, elements, pages, layouts, sections to named exports and clean imports

Description

Migrates all components to named exports
Cleans up all imports across components and routes
Add displayName to all components for easier React dev tools debugging.
Changed non .jsx to .js
Tightens some of the code

Note
Imports were reorganized to follow this pattern:
// top of the file
node_module import #1
node_module import #2
...
// single space
aliased import #1
aliased import #2
...
// single space
relative/local import #1
...
//double space
//double space
export function App(){
...
}

Just got to get the checks to pass

I've fixed most of the errors, but need to rewrite the product swimlane as it's got issues.

I've fixed most of the errors, but need to rewrite the product swimlane as it's got issues.

Just popping in for one code comment and to also say:
I'm not sure that using displayName is actually useful in a lot of cases here, to be honest. If you're using a named function for your component (e.g. function MyImage()) then it automatically picks up the name of the function (e.g. MyImage). If you're using an anonymous function (e.g. export default () => {}) or a HOC then displayName is useful in those situations, but I'm pretty sure that otherwise the name is already being picked up.
See also https://reactjs.org/docs/react-component.html#displayname

They were indeed. Thanks for the comment @frehner 🙏


Upload file without form data

Add possibility to upload a file in request body without using FormData object.
The file will be uploaded as a binary data instead of multipart/form-data request.
It will require to change the UI and when the file as binary data will be send the other payload fields must not be available.

This will be available with next release.


Migrate all old tests to new test framework

(message created by the CI based on PR content)

Codecov Report

Merging #2550 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2550   +/-   ##
=======================================
  Coverage   55.25%   55.25%
=======================================
  Files        6490     6490
  Lines      142522   142522
=======================================
  Hits        78756    78756
  Misses      63766    63766

Impacted Files
Coverage Δ

...-sdk-testutils/devtools_testutils/mgmt_testcase.py
93.75% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35d291...c24df41. Read the comment docs.


Task/damage controller

Includes #167 and #168 - attaches a dummy damage controller if one isn't present (note that there is not currently a damage controller proxy)

Since the resource containers all use the same proxy fields, is it possible to replace the several different proxy scripts with a single one with a resource type drop down? And then have the proxy replacer choose the correct concrete implementation based on that field?

Since the resource containers all use the same proxy fields, is it possible to replace the several different proxy scripts with a single one with a resource type drop down? And then have the proxy replacer choose the correct concrete implementation based on that field?

This is certainly possible but has a couple of drawbacks because of losing 1:1 to vanilla.

Users inspecting vanilla prefabs can add "Proxy" and get matching behavior with 1:1 - with this they'll have to go to our docs or use intuition to figure out what to add
The approach used here to map proxies gets more boilerplate.  Right now for 1:1 to vanilla, adding a proxy mapping is a two line affair which doesn't repeat itself and uses generic functions to just "magically" do its thing.  I can definitely work on refining this.

What that would look like:
using AutoMapper;
using CCL.Types.Proxies.Resources;
using LocoSim.Definitions;
using System.ComponentModel.Composition;
using UnityEngine;

namespace CCL.Importer.Proxies.Resources
{
    [Export(typeof(IProxyReplacer))]
    public class ResourceContainerProxyAutoMapper : Profile, IProxyReplacer
    {
        public ResourceContainerProxyAutoMapper()
        {
            CreateMap<ResourceContainerProxy, CoalContainerDefinition>();
            CreateMap<ResourceContainerProxy, FuelContainerDefinition>();
            CreateMap<ResourceContainerProxy, OilContainerDefinition>();
            CreateMap<ResourceContainerProxy, SandContainerDefinition>();
            CreateMap<ResourceContainerProxy, WaterContainerDefinition>();
        }

        public void ReplaceProxies(GameObject prefab)
        {
            foreach (var resourceContainerProxy in prefab.GetComponentsInChildren<ResourceContainerProxy>())
            {
                switch (resourceContainerProxy.type)
                {
                    case ResourceContainerType.Coal:
                        resourceContainerProxy.MapComponent<ResourceContainerProxy, CoalContainerDefinition>();
                        break;
                    case ResourceContainerType.Fuel:
                        resourceContainerProxy.MapComponent<ResourceContainerProxy, FuelContainerDefinition> ();
                        break;
                    case ResourceContainerType.Oil:
                        resourceContainerProxy.MapComponent<ResourceContainerProxy, OilContainerDefinition>();
                        break;
                    case ResourceContainerType.Sand:
                        resourceContainerProxy.MapComponent<ResourceContainerProxy, SandContainerDefinition>();
                        break;
                    case ResourceContainerType.Water:
                        resourceContainerProxy.MapComponent<ResourceContainerProxy, WaterContainerDefinition>();
                        break;
                    default:
                        CCLPlugin.Warning("Attempted to map a Resource Container Proxy of an unknown resource type, doing nothing");
                        break;
                }
            }
        }
    }
}

There's probably a way to structure things so that it's a bit less boilerplate to do this based on the type, some kind of abstract method I have some ideas, so let me know if you'd like me to pursue this approach.

Well, I did some consideration and figured out how I can reduce the boilerplate down to just
using CCL.Types.Proxies.Resources;
using LocoSim.Definitions;
using System.ComponentModel.Composition;

namespace CCL.Importer.Proxies.Resources
{
    [Export(typeof(IProxyReplacer))]
    public class CoalContainerProxyReplacer : ProxyReplacer<ResourceContainerProxy, CoalContainerDefinition> {
        protected override bool CanReplace(ResourceContainerProxy sourceComponent)
        {
            return sourceComponent.type == ResourceContainerType.Coal;
        }
    }
    [Export(typeof(IProxyReplacer))]
    public class FuelContainerProxyReplacer : ProxyReplacer<ResourceContainerProxy, FuelContainerDefinition> {
        protected override bool CanReplace(ResourceContainerProxy sourceComponent)
        {
            return sourceComponent.type == ResourceContainerType.Fuel;
        }
    }
    [Export(typeof(IProxyReplacer))]
    public class OilContainerProxyReplacer : ProxyReplacer<ResourceContainerProxy, OilContainerDefinition>
    {
        protected override bool CanReplace(ResourceContainerProxy sourceComponent)
        {
            return sourceComponent.type == ResourceContainerType.Oil;
        }
    }
    [Export(typeof(IProxyReplacer))]
    public class SandContainerProxyReplacer : ProxyReplacer<ResourceContainerProxy, SandContainerDefinition> {
        protected override bool CanReplace(ResourceContainerProxy sourceComponent)
        {
            return sourceComponent.type == ResourceContainerType.Sand;
        }
    }
    [Export(typeof(IProxyReplacer))]
    public class WaterContainerProxyReplacer : ProxyReplacer<ResourceContainerProxy, WaterContainerDefinition> {
        protected override bool CanReplace(ResourceContainerProxy sourceComponent)
        {
            return sourceComponent.type == ResourceContainerType.Water;
        }
    }
}

Including it at this point definitely opens the door a bit wider for how proxies get designed, so I'd say it's worth considering, let me know.

Works for me, if you're happy with it you can go ahead and merge.

Alright, I committed that version that enables multiple destinations from one proxy - it's added a bit more robustness to the proxy replacer so that it's still possible to do quite a bit without fully customizing the replacer.
Readme has been updated.
Also I don't have write access so I can't merge - but wanted you to take a look at the latest differences anyways.


Fix for merge-with-parent Set Git identity step

Checklist

[X] All new jobs, commands, executors, parameters have descriptions
[X] Examples have been added for any significant new features
[X] README has been updated, if necessary

Motivation, issues
Step Set Git Identity fails when there's no preconfigured Git identity
Description
Bugfix for Issue #33 - prevent non-zero error code returned by  git config --get command from failing the step.

mind taking a look @gmemstr @iynere ?


[ENH] simpler encode_categorical

PR Description
Please describe the changes proposed in the pull request:

remove tuple use in kwargs
use either a string(sort/appearance) or a 1D array.
update tests, and add examples(shamelessly copied from @thatlittleboy )

This PR resolves #1021 .

PR Checklist

Please ensure that you have done the following:

[ ] PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.

[ ] If you're not on the contributors list, add yourself to AUTHORS.rst.

[ ] Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.

Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks
There will be automatic checks run on the PR. These include:

Building a preview of the docs on Netlify
Automatically linting the code
Making sure the code is documented
Making sure that all tests are passed
Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl

🚀 Deployed on https://deploy-preview-1029--pyjanitor.netlify.app

Merged, thank you @samukweku!


Fresh pull request for sorting algorithms

Description
Add insertion sort, selection sort and merge sort.
Issue #5
Type of change
Please delete options that are not relevant.

[x] Added Algorithm
[x] Folder Structure

Added to SUMMARY.md (delete section if not needed)?
Have you added the page to SUMMARY.md if this is a new page and not a fix?

[x] Yes
[ ] No

@Ahel2000 do we need the .java files? You already added code in the markdown files. @arnabsen1729 opinion?

I have made the changes @arnabsen1729

@allcontributors add @Ahel2000 for contributing to documentation


08PC5X

 Th,Contributor_License_Agreement📥contribution.:📤:%FW4248%commentCLA_status is_AURE9_Let_us_review it.
****https://github.com/microsoft/25-days-of-serverless/pull/406#issuecomment-1154707819
_Originally posted by @FW4248 in https://github.com/microsoft/25-days-of-serverless/pull/406#pullrequestreview-1005223134_https://github.com/microsoft/25-days-of-serverless/pull/406#issuecomment-1154707819

 Th,Contributor_License_Agreement📥contribution.:📤:%FW4248%commentCLA_status is_AURE9_Let_us_review it. ****#406 (comment)
_Originally posted by @FW4248 in [#406  #407 !08PC5X](https://github.com/microsoft/25-days-of-serverless/pull/406#pullrequestreview-1005223134_https)


python3Packages.pyftdi: 0.53.3 -> 0.54.0

Description of changes

Things done
Update to latest upstream release 0.54.0

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 164113 run on x86_64-linux 1

12 packages built:

expliot
home-assistant-component-tests.alarmdecoder
python310Packages.adext
python310Packages.alarmdecoder
python310Packages.pyftdi
python310Packages.pyi2cflash
python310Packages.pyspiflash
python39Packages.adext
python39Packages.alarmdecoder
python39Packages.pyftdi
python39Packages.pyi2cflash
python39Packages.pyspiflash


Package apache

Project description
This project basically contains the apache http server (httpd), and the useful programs that come with it, including but not limited to [ ab (Apache benchmark) - apachectl - apxs, ... ]
Metadata

homepage URL: https://httpd.apache.org/docs/2.4/programs/
source URL: https://github.com/apache/httpd
license: Apache-2.0 license
platforms: MS-DOS(Windows), unix, linux, darwin, netBSD

Sorry about this, i found the apacheHttpd package right now, closing this issue.


PHp 8.4 testcases are failing with SSL wrong version error

testcases working with PHP 8.3 failing with PHP 8.4 with wrong version number error.
Fatal error: Uncaught GuzzleHttp\Exception\ConnectException: cURL error 35: OpenSSL/3.0.2: error:0A00010B:SSL routines::wrong version number (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for https://gcpubsub:8538/v1/projects/project-gcps-beb18c354408c9820e2a1636000c9f60/topics/topic-gcpsa-beb18c354408c9820e2a1636000c9f60?%24alt=json%3Benum-encoding%3Dint in tests/google-pubsub/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php:275
002+ Stack trace:
003+ #0 tests/google-pubsub/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php(205): GuzzleHttp\Handler\CurlFactory::createRejection(Object(GuzzleHttp\Handler\EasyHandle), Array)
004+ #1 tests/google-pubsub/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php(157): GuzzleHttp\Handler\CurlFactory::finishError(Object(GuzzleHttp\Handler\CurlMultiHandler), Object(GuzzleHttp\Handler\EasyHandle), Object(GuzzleHttp\Handler\CurlFactory))
005+ #2 tests/google-pubsub/vendor/guzzlehttp/guzzle/src/Handler/CurlMultiHandler.php(267): GuzzleHttp\Handler\CurlFactory::finish(Object(GuzzleHttp\Handler\CurlMultiHandler), Object(GuzzleHttp\Handler\EasyHandle), Object(GuzzleHttp\Handler\CurlFactory))
006+ #3 tests/google-pubsub/vendor/guzzlehttp/guzzle/src/Handler/CurlMultiHandler.php(180): GuzzleHttp\Handler\CurlMultiHandler->processMessages()
007+ #4 tests/google-pubsub/vendor/guzzlehttp/guzzle/src/Handler/CurlMultiHandler.php(206): GuzzleHttp\Handler\CurlMultiHandler->tick()
008+ #5 tests/google-pubsub/vendor/guzzlehttp/promises/src/Promise.php(251): GuzzleHttp\Handler\CurlMultiHandler->execute(true)
009+ #6 tests/google-pubsub/vendor/guzzlehttp/promises/src/Promise.php(227): GuzzleHttp\Promise\Promise->invokeWaitFn()
010+ #7 tests/google-pubsub/vendor/guzzlehttp/promises/src/Promise.php(272): GuzzleHttp\Promise\Promise->waitIfPending()
011+ #8 tests/google-pubsub/vendor/guzzlehttp/promises/src/Promise.php(229): GuzzleHttp\Promise\Promise->invokeWaitList()
012+ #9 tests/google-pubsub/vendor/guzzlehttp/promises/src/Promise.php(69): GuzzleHttp\Promise\Promise->waitIfPending()
013+ #10 tests/google-pubsub/vendor/google/cloud-pubsub/src/V1/Client/PublisherClient.php(346): GuzzleHttp\Promise\Promise->wait()
014+ #11 [internal function]: Google\Cloud\PubSub\V1\Client\PublisherClient->createTopic(Object(Google\Cloud\PubSub\V1\Topic), Array)
015+ #12 tests/google-pubsub/vendor/google/cloud-core/src/RequestHandler.php(118): call_user_func_array(Array, Array)
016+ #13 tests/google-pubsub/vendor/google/cloud-pubsub/src/Topic.php(252): Google\Cloud\Core\RequestHandler->sendRequest('Google\\Cloud\\Pu...', 'createTopic', Object(Google\Cloud\PubSub\V1\Topic), Array)
017+ #14 tests/google-pubsub/vendor/google/cloud-pubsub/src/PubSubClient.php(256): Google\Cloud\PubSub\Topic->create(Array)
018+ #15 tests/google-pubsub/pubsub-administrative.php(20): Google\Cloud\PubSub\PubSubClient->createTopic('topic-gcpsa-beb...')
019+ #16 tests/include/common.inc(11)
020+ #17 tests/google-pubsub/pubsub-administrative.php(14):
021+ #18 {main}
022+   thrown in tests/google-pubsub/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php on line 275

PHP version : 8.4.0beta5.
I'll provide the testcase to reproduce issue shortly.

testcase to reproduce the issue:
use Google\Cloud\PubSub\PubSubClient;
use Google\Cloud\PubSub\Topic;

$projectId = 'project-pubsub-‘ . md5(time());
$topicName = 'topic-pubsub-‘ . md5(time());
$subscriptionName = 'sub-pubsub-‘ . md5(time());
$snapshotName = 'snap-pubsub-‘ . md5(time());
$credentials = __DIR__ . '/dummy_app_credentials.json';

 use ($projectId, $credentials, $topicName, $subscriptionName, $snapshotName)
    $pubsub = new PubSubClient([
        'projectId'   => $projectId,
        'credentials' => $credentials,
    ]);
    $topic = $pubsub->createTopic($topicName);
    $subscription = $topic->subscribe($subscriptionName);
    $snapshot = $pubsub->createSnapshot($snapshotName, $subscription);
    try {
        $topic->update([]);
    } catch (Exception $ex) {
        // fails - it's not implemented by the emulator
    }
    try {
        $subscription->update([]);
    } catch (Exception $ex) {
        // fails - it's not implemented by the emulator
    }
    $snapshot->delete();
    $subscription->delete();
    $topic->delete();

composer lock file.txt
Composer lock file attached.

similar issue reported here https://github.com/googleapis/google-cloud-php/issues/7679

Hello @HeenaBansal20 ! Thanks for logging this.
I will look into this, but just a few things that stood out to me looking at the error message
Fatal error: Uncaught GuzzleHttp\Exception\ConnectException: cURL error 35: OpenSSL/3.0.2: error:0A00010B:SSL routines::wrong version number (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)

Error 35 cURL error is usually an environmental error. See the curl docs for more info:
CURLE_SSL_CONNECT_ERROR (35)

A problem occurred somewhere in the SSL/TLS handshake. You really want the error buffer and read the message there as it pinpoints the problem slightly more. Could be certificates (file formats, paths, permissions), passwords, and others.

Additionally. here:
for https://gcpubsub:8538/v1/projects/project-gcps-beb18c354408c9820e2a1636000c9f60/topics/topic-gcpsa-beb18c354408c9820e2a1636000c9f60?%24alt=json%3Benum-encoding%3Dint in tests/google-pubsub/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php:275

...where is this URL coming from? Why is the error being thrown in a guzzle test (CurlFactory.php)?


Fix: Default region is not working for the image import command

Fixes: https://github.com/ppc64le-cloud/pvsadm/issues/27

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bkhadars
To complete the pull request process, please assign mkumatag after the PR has been reviewed.
You can assign the PR to them by writing /assign @mkumatag in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @mkumatag

minor rewording

updated the changes

/assign @bkhadars
/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bkhadars, mkumatag
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


I had been leaving as much as possible as is in there in order to be able to test that we could still reproduce UCERF3 (e.g., org.opensha.sha.earthquake.faultSysSolution.RupSetBuilderTests compares a rupture set built with IFSRS and the new methods). But that reproducibility has been well demonstrated, so I'm ok merging this in and removing the duplicated code.


Keep end-to-end tests up to date

Codecov Report

Merging #939 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
- Coverage   95.48%   95.31%   -0.18%
==========================================
  Files          39       39
  Lines        3457     3630     +173
  Branches      295      528     +233
==========================================
+ Hits         3301     3460     +159
- Misses        156      160       +4
- Partials        0       10      +10

Impacted Files
Coverage Δ

browser/services/credentialManager.js
96.87% <0%> (-3.13%)
:arrow_down:

browser/pages/location/controller.js
92.3% <0%> (-2.86%)
:arrow_down:

browser/pages/install/controller.js
78.84% <0%> (-2.75%)
:arrow_down:

browser/main.js
98.48% <0%> (-1.52%)
:arrow_down:

browser/model/devstudio.js
96.8% <0%> (-0.97%)
:arrow_down:

browser/model/cdk.js
99.2% <0%> (-0.8%)
:arrow_down:

browser/model/helpers/downloader.js
95.27% <0%> (-0.63%)
:arrow_down:

browser/services/data.js
97.06% <0%> (-0.59%)
:arrow_down:

browser/model/jdk-install.js
96.04% <0%> (-0.39%)
:arrow_down:

browser/pages/welcome/controller.js
100% <0%> (ø)
:arrow_up:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d406e0...eac9336. Read the comment docs.


Can't use require in Node, only import?

So the std way of including things in a Node app is to use require - is there any way to do that instead of having to use import?

Node is moving toward using ES6 Modules, the JavaScript standard which the Node docs point out "are the official standard format to package JavaScript code for reuse": https://nodejs.org/api/esm.html
But indeed Node has, and no doubt will continue for some time, to support the require syntax.
You can use that form as of version 0.6.0 (just published!) by using:
const Pop3Command = require('node-pop3');

For your future reference if finding other such packages, while Node continues to support main in package.json to indicate the entry file for require statements (with the CJS exports or module.exports format allowing you to know how to require it), if present, exports will override main. You can see at https://github.com/node-pop3/node-pop3/blob/master/package.json#L7-L10 in our package, for require statements, ./lib/Command.js is the main entry file. Since it uses module.exports now, you can just require it as above.
Note that before the version I just published, 0.6.0, you had to use require('node-pop3).default. (See https://github.com/59naga/babel-plugin-add-module-exports if you want to know why.)
Closing, as that should resolve, but feel free to comment further as needed.

@brettz9 awesome - can you just push that new tagged version so I can give it a try?

Already done.

Oh, sorry, hadn't pushed upstream. Now pushed.


Add toggle chat plugin - needs 1.8.25

Allows the user to set a hotkey to open/close the chatbox. Also disables the flashing notification on the chat tabs.

You should use Client#setVarcIntValue https://github.com/MoreBuchus/buchus-plugins/blob/11309f10a29a2db335574195c1d4e1918f14e656/src/main/java/com/togglechat/ToggleChatPlugin.java#L87
You should look into HotkeyListener built specifically for this purpose, or just KeyEvent#consume to prevent the chat box receiving the key press https://github.com/MoreBuchus/buchus-plugins/blob/11309f10a29a2db335574195c1d4e1918f14e656/src/main/java/com/togglechat/ToggleChatPlugin.java#L119


Added minimal .npmignore to avoid publishing build folders

<EMAIL_ADDRESS>npm package weights 30.2MB when zipped, and 105MB when deflated.
This is mostly due to the fact that /android/build folder was published as a part of the package.
A package with no build folder weights 6.9KB, just for comparison.
I would very much appreciate if this could be merged, and a new, more lightweight version published. To save us time and bits.
Thanks!

Thanks for merging


Replace the code editor with Monaco (or Codemirror?)

VS Code uses Monaco, which might or might not help us
this blog post recommends CodeMirror: https://blog.replit.com/code-editors

Should we then probably use CodeMirror?
Article says it's the only thing that has good mobile support, and I recon that might come useful.

I think @OAGr was more in favor of using Monaco because of VS Code.
My guess that the decision depends on how much common APIs are there between VS Code and Monaco. If there are common APIs then it makes more sense to use Monaco; but if most VS Code APIs (classes such as TextDocument, TextLine, Range and so on) are abstractions on top of Monaco then it shouldn't matter. I haven't evaluated this myself.
I don't think that mobile support is very important, playground won't be very usable on mobile anyway. But this depends on what exactly "not supported" means; if it's the lack of usability features then it probably doesn't matter much; if it doesn't work at all in some mobile browsers then it might be a deal breaker.

It doesn't work on mobile with such ferocity, that it's even stated on it's search result.
And yes, it really doesn't work.

However, in this issue several people state that it actually works, and it's getting better?
https://github.com/Microsoft/monaco-editor/issues/246

I think @OAGr was more in favor of using Monaco because of VS Code.

Correct. If the APIs are really similar, this seems like it would be a major advantage to me.
I also heard that other smart people making similar decisions have generally been favoring Monaco. It sounded like it had much more support behind it, long term.

I also heard that other smart people making similar decisions have generally been favoring Monaco. It sounded like it had much more support behind it, long term.

Interesting. CodeMirror powers developer tools in all major browsers (Chrome, Firefox and Safari), and also replit and IPython, so I don't see it going away any time soon. Replit migrating to it from Monaco is a pretty strong signal too.
Oh the other hand, it seems that CodeMirror is the work of a single independent author, while Monaco gets commits from two Microsoft employees, so its bus factor is higher.

I still think we should go with Codemirror.
I compared the shape of Range objects in Monaco vs VS Code, and they're different, so I'd assume that other stuff is different too and VS Code APIs are not an extension of Monaco APIs.

#1448 fixes this.


Publish reference-viewlet as a public package

It would be very great if the reference-viewlet extension could be published to npm. It brings the extension developers who want to use the reference-viewlet API a lot of convenience in case the API version changes.

It would be very great if the reference-viewlet extension could be published to npm.

I don't understand... It is an extension that ships (and needs) VS Code. How can it be on npm?

You should be using extensionDependencies for that

You should be using extensionDependencies for that

Thanks for the suggestion but actually I have done that :smile:. My concern is about the API shape. Currently I put the references-view.d.ts into my extension's source folder so that I can get the API shape. Since extensionDependencies doesn't support restricting version, is there any efficient way to keep consistent between my API definition file and the API get from ms-vscode.references-view in case the version changes?

My concern is about the API shape.

We will not break that API


Implement a my^ macro

Briefly, allow this:
for [1, 2, 3] -> n {
    my^ total = 0;
    total = total + n;
}
say(total);

to mean this:
my total = 0;
for [1, 2, 3] -> n {
    total = total + n;
}
say(total);

That is, my^ is a variable declaration in the scope immediately surrounding the current scope. (Which must exist, or it's a compile-time error.)
A couple of quick points:

As usual — do it first as a feature flag in Perl 6, then (ASAP) as a pragma/macro in pure 007.
I realize that the macro itself is not promoting especially good coding practices. It's better to be explicit and declare it in the right place. The idea is that it'd allow stream-of-consciousness style programming, where going back, possibly several paragraphs, and putting a declaration outside of the macro, feels like a break in concentration.

You can sort of have the best of both worlds by having the IDE quickly fix up the my^ by moving it to the appropriate scope.
It's not clear whether my^ should accept or reject redeclarations in the outer scope. It can sort of be argued both ways.

It's interesting to ponder the relationship between a macro such as this, and the linter. I don't necessarily have any answers, I'm just wondering what a best-of-worlds situation looks like here.

Closing this as it feels like a fringe idea in the pale light of hindsight. We have so many more worthy macro ideas to pursue now.


Extending with new message types

Is it possible to extend citrus with new message types?  I don't think so from looking around the docs.  What I'm trying to do is define some higher level constructs for a message format called "foo" (for example).
At their core, foo message types are json.  But they follow a certain format, etc, that I'd like to standardize so boilerplate isn't present in the tests.  And it also provides value to me that I can have a message action that says <message type="foo" /> instead of <message type="json" />.
One route is for me to define my own module, which I could do with some effort.  I'd define my own dsl or xml structure (e.g. <foo .. />).  But I'd like to piggyback on all of the underlying hard work already present in the core module.
Any ideas?

You can write custom message validator implementations that support your very special message type. Just set the message type to 'foo' and write a custom message validator supporting this type.
You just need to add the custom message validator to the message validator registry then as described in customize-message-validators
The custom message validator should extend https://github.com/christophd/citrus/blob/master/modules/citrus-core/src/main/java/com/consol/citrus/validation/DefaultMessageValidator.java and overwrite supportsMessageType()

The validator will be called in a response, right?  Can I also validate before it is sent in a request?

You could add a custom message construction interceptor (com.consol.citrus.validation.interceptor.MessageConstructionInterceptor) that is called with the constructed message before that is sent out. You can add this interceptor globally as Spring bean to the Citrus Spring application context. All send and receive actions should automatically use this interceptor while processing.
The custom interceptor can also use Spring autowire mechanism in order to inject the Citrus XML message validators for schema validation.

About to close that issue, Ok for you?

Sorry about that, yes.  These past couple of weeks have been busy and I never got back here to thank you.  Thanks for the info.  I'll be trying this out.

Sorry to pile on to this issue but we're considering something similar. We have, at present, internal legacy mainframe services that exchange messages over MQ. The payload is [ugh!] a fixed width string defined by a COBOL copybook record. I want to be able to handle this as something more robust than plaintext. Basically be able to define message payloads (in Cucumber) with variable interpolation and response validation using the Hamcrest matchers. I think I understand how to write/register the MessageValidator -- doc looks pretty good on that. But I'm unclear on the MessageConstructionInterceptor. You say "add as a Spring bean to the Citrus Spring application context". Am I missing something or does Citrus use ApplicationContext.getBeansOfType to discover all known implementations of the interface? Also, is it possible using the named message feature in the Cucumber glue to specify the message type of the payload?

Citrus is using autowiring of Spring beans. So all implementations of message construction interceptors will be loaded to the framework by adding a new bean to the application context. Please open a new issue on that Cucumber question as it is misplaced in this issue. Thanks!


[eas-cli] [ENG-7591] Detect not provisioned devices

Why
https://linear.app/expo/issue/ENG-7591/detect-processing-devices-on-apple-developer-portal-and-dont-allow-the
How
After selecting devices to be provisioned and making a call to App Store Connect API the result is compared with the list of chosen devices. If any are missing, a message is displayed to the user
Test Plan
Added automated tests
TODO: manual testing

/changelog-entry new-feature Detect devices that fail to be provisioned, list them to the user and show the explanation message with the link to the devices page to check actual status


[CARBONDATA-2958] Compaction with CarbonProperty 'carbon.enable.page.level.reader.in.compaction' enabled fails as Compressor is null

Problem:
When CarbonProperty 'carbon.enable.page.level.reader.in.compaction' is enabled, compaction fails throwing Null Pointer Exception as compressor is Null
Solution:
Set compressor from pageMetaData

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[x] Testing done
Test case added

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/388/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/566/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8636/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/398/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/576/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8646/

Retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/400/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8648/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/578/

LGTM


Feat/vtk ascii output

:tada: This PR is included in version 5.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


CTextfilter - doFilter()

Expects $filters param to be string currently. I added support for array, which I think was the original idea.
$filter = (is_array($filters)) ? $filters : preg_replace('/\s/', '', explode(',', $filters));

It seems like a good approach to support both. I added it to the repo where I do further development on CTextFilter.
https://github.com/mosbth/ctextfilter/issues/4


Add redis database as local cache for API structure

This could greatly help with speed, especially in conditions with slower internet speeds, because it would no longer be necessary to constantly request information from the API. However, I am not sure how this would be implemented, or if there are even any real benefits.

Closed for now. No real reason to user afaik.


Prevented direct DOM manipulation in EditorContent component

Fixes #337
Description

Removed: highlight.js package from peer dependencies.

Checklist

[x] I have performed a self-review of my code.
[x] I have made corresponding changes to the documentation.
[x] I have added the necessary label (patch/minor/major - If package publish
is required).
[x] I have followed the suggested description format and styling.

Reviewers
@AbhayVAshokan _a

@labeebklatif _a can you please review this PR on priority?
https://vimeo.com/747149143/cce00eb1fc


Issue with server-side fetch since version 1.0.0-next.253

Describe the bug
I've been having issues with server-side fetch from version 1.0.0-next.253 onwards. It seems that the headers get re-written by Svelte Kit in a way that can corrupt certain requests.
This is the specific change that seems to have caused the issue for me.
The same requests still seem to work fine on the client side.
Reproduction
The options for my fetch requests look something like this. Unfortunately the GraphQL endpoint isn't a public one, so I can't share a "working" demo.
{
	body: REQUEST_STRING,
	headers: new Headers({
		"Content-Type": "application/json",
		"Authorization": "Basic " + CREDENTIALS
	}),
	method: "POST",
	mode: "cors"
}

Judging by the error log and my inspection of the response, it seems that the API is getting the request, but is returning an GUI console containing the query and result rather than a JSON response. This is causing the "unexpected token" error.
Logs
Unexpected token < in JSON at position 2

SyntaxError: Unexpected token < in JSON at position 2
    at JSON.parse (<anonymous>)
    at Proxy.<anonymous> (APP_PATH/.svelte-kit/runtime/server/index.js:1835:21)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Module.getData (/src/lib/utils.js:84:14)
    at async load (index.svelte:14:21)
    at async load_node (APP_PATH/.svelte-kit/runtime/server/index.js:1864:12)
    at async respond$1 (APP_PATH/.svelte-kit/runtime/server/index.js:2242:15)
    at async resolve (APP_PATH/.svelte-kit/runtime/server/index.js:2744:11)
    at async respond (APP_PATH/.svelte-kit/runtime/server/index.js:2688:20)
    at async APP_PATH/node_modules/@sveltejs/kit/dist/chunks/index.js:299:24

System Info
System:
    OS: macOS 11.6.1
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
    Memory: 1.14 GB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.10.0 - ~/.nvm/versions/node/v16.10.0/bin/node
    npm: 7.18.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 99.0.4844.83
    Firefox: 97.0.1
    Safari: 14.1.2
  npmPackages:
    @sveltejs/adapter-node: ^1.0.0-next.0 => 1.0.0-next.0
    @sveltejs/adapter-static: ^1.0.0-next.17 => 1.0.0-next.26
    @sveltejs/kit: ^1.0.0-next.252 => 1.0.0-next.302
    svelte: ^3.34.0 => 3.46.4

Severity
blocking an upgrade
Additional Information
No response

Do you know what header is resulting in you getting HTML back from your API instead of your expected content? Is it accept? Can you override and manually pass a different value for that header to make this work in your app?
It might make sense for SvelteKit to also exclude that header when copying others over from the original request.

I'm not sure which header is causing that behaviour, and am not sure how to intercept/log the headers that are actually getting sent in a server-side request.
On the client side, besides Host, Origin, Referred and authorisation, these are the headers on a successful fetch request to the GraphQL API.
POST /graphql HTTP/1.
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:97.0) Gecko/20100101 Firefox/97.0
Accept: */*
Accept-Language: en-GB,en;q=0.5
Accept-Encoding: gzip, deflate, br
content-type: application/json
Content-Length: 733
Connection: keep-alive
Sec-Fetch-Dest: empty
Sec-Fetch-Mode: cors
Sec-Fetch-Site: cross-site
DNT: 1
Sec-GPC: 1

The most likely culprit is accept, since now that we forward the navigation's headers it probably defaults to some text/html,application/xml,... variation. I also wouldn't be surprised if some API server tried to be helpful by interpreting sec-fetch-dest: document as an accept: text/html alternative.
However, do we really want to automagically forward headers? We can't guarantee it-just-works both client- and server-side as it's technically impossible to proxy all requests transparently, so maybe it'd help to make these differences intentionally apparent?

We probably have the same problem on our project. When requests go through the test domain "test.properDomain.com", it will not fetch data from our external api. While requesting the server ip directly, it will fetch data.
This error started happening after we upgraded svelte kit from 229 -> 298.
In the headers from requests through the test domain, X-FORWARDED-HOST contains two urls both the "test.properDomain.com" and the url to the api. X-FORWARDED-HOST: "test.properDomain.com", "www.api-server.com" .  And I suspect fetch from load is doing something magically there.

@mrkishi Thanks for the suggestion. It seems that explicitly setting both the Accept and Content-Type headers to "application/json" returns the right JSON response in the current version of Svelte Kit. So, my fetch request options now look something like this:
{
	body: REQUEST_STRING,
	headers: new Headers({
		"Accept": "application/json",
		"Content-Type": "application/json",
		"Authorization": "Basic " + CREDENTIALS
	}),
	method: "POST",
	mode: "cors"
}

This solves the immediate issue for me, but I'll leave it to others to decide if this still qualifies as a bug or if the discrepancies/pitfalls between server-side and client-side fetch just need to be documented somewhere.


test AWS V4 signer

AWS is migrating from V2 to V4 signer, for example, the Frankfurt region only supports the latter.  Other S3 implementations should support both vesions and s3-tests could exercise this in tests.  Implementation notes:
http://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-authenticating-requests.html

Would you mind creating an issue on the tracker so we can add a fix for this and track it there?
http://tracker.ceph.com/projects/rgw/issues/new

set of aws4 tests were added


Setting local value of global-local window option sets local value for other buffers in window

Steps to reproduce
setlocal scrolloff=2
setglobal scrolloff=3
setl modified " Force fresh buffer with enew
hide enew
echo &l:scrolloff &g:scrolloff

The script above prints "2 3". I don't understand why the local value of the new buffer is set to 2. If this is expected, is there documentation that explains this behavior?
Expected behaviour
The script should print -1 3
Version of Vim
9.0.1664
Environment
Linux
Logs and stack traces
No response

'scrolloff'  is global-local to a window. What happens when you edit a new buffer in the same window, is that the local value of the existing window option is kept.
It's also explained in much detail at :h local-options

Oh, I fundamentally misunderstood "Global or local to window" options. I had thought that these were scoped like window-local options, meaning that global scope was local to a window and local scope was local to a buffer in a window, but with the global-local mechanics of a default global value. Now I see that actually global is meant to be proper global scope, and local is meant to apply to the whole window. So only window-local options are per-(buffer,window). Please confirm my new understanding is correct; if it is, feel free to close this issue.

Perhaps tellingly, scrolloff and sidescrolloff are missing from https://github.com/vim/vim/blob/590aae35575cbd74d80c41d87fc647f2812aad70/src/structs.h#L177C1-L326C12

those are again global-local to window, while the options in winopt_T seem to be local to window. So 'sidescrolloff' and 'scrolloff' are part of the wind_T type:
https://github.com/vim/vim/blob/bf5f189e449d6517239b79804d7a422a46946838/src/structs.h#L3980-L3981
See also:
https://github.com/vim/vim/blob/bf5f189e449d6517239b79804d7a422a46946838/src/structs.h#L3956-L3964
Hm, except that this does not seem to be entirely true anymore, there are several global-local window options now also in winopt_T

'listchars', which now is also global-local to window which was changed back in eed9d46293f0842aad0d50
'fillchars' which was also changed to global-local to window  in 96ba25ac01279f73c0ecb5
'virtualedit' changed in 53ba05b09075f1422 and then later in 51ad850f5fbafa7aa3f60af
'showbreak' changed in ee85702c10495041791f728e97
'statusline'

Perhaps 'sidescrolloff' and 'scrolloff' should indeed also be there. Not sure, seems like techical debt 🤷♂

are we fine to close?

I don't think so. I think that either there needs to be a change in behavior for scrolloff and sidescrolloff to make them behave like the other global-local window options, or they need to be called something different since there are semantics of global-local window options laid out in the manual that these options violate.
And I agree with your second note in your post above - membership in winopt_T does not seem to imply anything about local v. global-local status.

I don't think so. I think that either there needs to be a change in behavior for scrolloff and sidescrolloff to make them behave like the other global-local window options, or they need to be called something different since there are semantics of global-local window options laid out in the manual that these options violate.

Sorry, I don't follow. Did you mention what behaviour was different with those two options in comparison to other global-local window options?

Yes - sorry if that was unclear.
" 1. Confirm local values are unset (scrolloff is -1 when unset):
:setl listchars?
:setl scrolloff?
" 2. Set the local values.
:setl listchars=tab:>>
:setl scrolloff=2
" 3. Change the buffer in the window.
:setl modified
:hide enew
" 4. Check local options again
:setl listchars? " empty; tracking global option
:setl scrolloff? " 2; local value is set

A more complete accounting of behavior differences I found is here - https://github.com/neovim/neovim/issues/24156#issuecomment-1607563115 (I did that testing in Neovim so it's possible there are some differences).

okay, I see. Indeed, I didn't know that global-local window options are also local to a buffer.
I have created #12643 to fix this which also includes a small addition to the documentation to make that clear.

What do you want to do about the other discrepancies mentioned in the issue I linked? Tests demonstrating the differences in the semantics:
This departure from buffer-local behavior affects syntax, filetype, readonly, bufhidden, buftype, modified (also channel in Neovim):
:setg syntax=ocaml
:setg commentstring=(*%s*)
:new
:set syntax? " Empty
:set commentstring? " (*%s*)

This departure from window-local behavior affects previewwindow, scroll, winfixheight, winfixwidth:
" Test 1: Global value
:setg cursorcolumn
:setg winfixwidth
:setl modified
:hide enew
:set cursorcolumn? " Set
:set winfixwidth? " Not set

" Test 2: Local value
:setl cursorcolumn
:setl winfixwidth
:setl modified
:hide enew
:set cursorcolumn? " Not set
:set winfixwidth? " Set

For these options I'm not convinced that their difference in behavior is a bug. It kind of makes sense when you think about what these options actually mean -- e.g., setting a syntax for new buffers is probably not something the user actually means to do. But calling them "local to buffer" and "local to window" options like the others is misleading. If we think the current behavior is desired, they deserve their own category of option.

Updated documentation with those options.
If you have any specific documentation recommendation, please show.

The updated docs look good to me for these special options. I noticed that you also removed the note about global-local window options being per-buffer. Why was that removed?

because it is already mentioned a few lines above at :h local-options

I think the text above describes the behavior of the global value for "local to window" options, but it doesn't say anything about the semantics of "global or local to window" options.

exactly, because it applies to both types of options: global-local options and local options.

It isn't obvious that that text applies to global-local options though. In particular, this bit:

Vim keeps a global value of the local window options, which is used when editing another buffer.  Each window has its own copy of these values.  Thus these are local to the window, but
global to all buffers in the window.

as well as the fact that the section is titled "Handling of local options" and all of its examples are "local to buffer" or "local to window" options suggest to the reader that nothing in that section is applicable to global-local options. The reader is unlikely to understand that the bits discussing the behavior of the local values of options are applicable, but the bits discussing the behavior of the global values of options are not.

Does that https://github.com/vim/vim/pull/12643/commits/9b47438c2e51184b1c5b6d9814dd2210792fa3a2 make it more clear?

No, because the parts of that section that discuss the semantics of global values of local options do not match the semantics of the global values of global-local options.

I don't follow. Afaik, the difference of |global-local| to regular local options is simply that they special in the sense, that usually only use the global value, but may have single local options. But that does not mean, that those |global-local| options do not themselves have (buffer- and window-) local values.

Yes, but this section of the manual does not discuss local values - it discusses both the global and the local values of regular local options. So saying that the whole section also applies for global-local options is misleading because there is text in there about how global values work and it does not apply to how global values work for global-local options.

For me, I understand it differently: It does not say at all, whether or not it applies to regular local-options only or not (meaning global-local). It's a high-level summary, of what happens with local options. And since both global-local and buffer/window-local options can have local options, it applies to both.
In any case, I am open to suggestiosn

The changes you are making in https://github.com/vim/vim/pull/12643 are good and I don't think we should block on it. Let's maybe unwind the note and just close out this issue with your changes as-is. Separately, I'm happy to work together to draft something in a different forum - e.g., a google doc - that tries to make the language clearer, and we (and others interested in helping) can iterate on it freely until we are happy with the text. How does that sound to you?

fixed by https://github.com/vim/vim/commit/4a8eb6e7a9df10f79bf95301ced012f0d6a13088


[SUBMARINE-174] Create the submarine-server module

What is this PR for?
Add the submarine-server module
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-174
How should this be tested?
https://travis-ci.org/jiwq/hadoop-submarine/builds/595195447
Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

I think you need added submarine-server design doc in docs\submarine-server path.
The PR What is this PR for? description of this paragraph is too simple. you need to tell others what the PR is going to do.
You need to add design doc link in this PR.
I think what modules are created by what module you need. Don't create many empty modules at once.

Thanks @liuxunorg help review. I will close this PR and create a new PR for the design doc first.

Due to it related to #48 and we can reuse the JIRA, so I close the PR and rename the JIRA summary.


question

what is sporkaddress?

strSporkAddress = "Xgtyuk76vhuFW2iT7UAiHgNdWXCf3J34wh";

and how can I generate sporkaddresses to use with -sporkaddr= ?

The sporkaddress is currently held by core. A message signed by the spork address can change a spork, sporks control a few non-critical things designed to prevent unintentional network forks. You can look at the current sporks here. If you have any questions about what each spork does I can try and clarify.
There are plans in the future to decentralize the control of sporks, however that has not been implemented yet.

Sporks are described in the docs:

https://docs.dash.org/en/latest/introduction/features.html#sporks
https://docs.dash.org/en/latest/developers/index.html#understanding-sporks

Hi, I'll go ahead and close this since I believe it's been answered adequately.


asciidoctor stem s_t_e_m problem

AsciidocFX parse stem as s_t_e_m as shown in attached picture..
This is only a windows operating system problem.

Sorry, reinstalling the latest version https://github.com/asciidocfx/AsciidocFX/releases/tag/v1.7.1 resolve that issue.

confirm that problem solved when i reinstall..
thanks.


minor error causing tragic loss of rare emoji

Do you ever think about this PR and wonder what to do with it?  cuz I know I do...

eh, ok.  closing this.  I still think you should fix the bug though lol.


sampled_backplane_capacity_counters_test - Added 90s sleep for Linecards to be properly up post power disable/enable in TestOnChangeBackplaneCapacityCounters and a check to skip validation on unused FAPs

Added a 90s sleep after power disable/enable to wait for Linuecards to be properly up before validating the BackplaneFacingCapacity parameters
Added a check to skip validation of AvailablePct when value is 0 indicating that no up interface is present in that particular FAPs

Pull Request Functional Test Report for #2875 / ec14511b1c298977789ed6e830e3b946891ceb0a
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters

Cisco 8000E

gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters

Cisco XRd

gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters

Juniper ncPTX

gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters

Nokia SR Linux

gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters

Openconfig Lemming

gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters

Cisco 8808

gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters

Juniper PTX10008

gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters

Nokia 7250 IXR-10e

gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.448%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1949

Relevant Lines:
3515

💛  - Coveralls


Move repo to personal GitHub account

@seisatsu: You should consider moving this repo to your account, off of @pariahsoft.

Done.


Update Microsoft.Azure.KeyVault version

Address #640 The new stable version 2.3.1 was published today, so we can use this for our RTM release after testing. Will also update BuildTools and Identity.

@JunTaoLuo tested, works, changed sample to cross-compile.

Thanks for the quick test!


Deployments missing files

If I deploy from the command line with a zip file, it works 100%. So I know everything is configured correctly there.
If I deploy with the VS Code extension, not all the files make it, and of course it doesn't run. The first deployment DID work, but all subsequent deployments (even for other apps) fail to include all necessary files, and can't run.

Hi @q00u
What type of project are you deploying?  Could you check your project settings?  There is an setting called appService.ignoreZipPattern that specifies which folders not to zip.  This is typically used to prevent archiving the node_modules with your zip file since it can be a really large folder.
If you have a .deployment file with the setting SCM_DO_BUILD_DURING_DEPLOYMENT=true the server should run a build and reconstruct your dependencies.

Two different projects with the same problem. A bot service bot, and a web app.
"appService.zipIgnorePattern": [] But, like I said, zip is the only thing that DOES work, at least for the bot service bot. The web app doesn't have zip as a possible deployment method.
SCM_DO_BUILD_DURING_DEPLOYMENT = false
node_modules is missing files. Tried turning SCM_DO_BUILD_DURING_DEPLOYMENT to true, and it still didn't work. Some of the folders were there, but with contents missing. When the apps try to run, they of course crash because the dependencies aren't there.

What method are you using to deploy the web app?
Can you SSH into your web app and confirm that the node_modules are missing?  There has been an issue recently where node_modules contents aren't showing up in the Files node, but are actually being constructed.
Would it be possible to provide a link to your repo so that we can help debug the issue?

Deployed from VS Code in the Azure extension (Right-click on target, "Deploy to Web App...")
Parts of node_modules were definitely missing, as that's how I found it (Log showed that it crashed on launch, and blamed missing import files; upon inspection, indeed some files did not exist on the server)
Have currently deployed via zip for one and ftp for the other, so the apps are working, and zip deployment is working, and ftp deployment is working.
It's just the VS Code extension deployment that's broken.
The only way for me to debug further on my end would be to break the deployment of one of my apps, which I'd rather not do at this time. If I have time, I'll set up a new app that I don't need, for temporary debugging.
Are you saying that you can deploy node.js apps from the extension with no problems? (Not just the first deployment, because that also worked for me, but subsequent deployments)

Sorry, when I say method, I meant what is your current deployment source type?  You can check that by right-clicking the target and clicking this context menu item:

Yeah, certainly don't break your app in order to help debug.  But you mentioned that you're deploying your service bot via zip deploy.  Does that mean your web app is being deployed via FTP?
The extension doesn't support FTP deployments at this time, so if you're trying to deploy via the extension, it will default to a zip-deploy which might be what's breaking your web app.
And I can confirm that I have been able to deploy node.js apps, edit their contents, and redeploy to the same app via the extension.
Is your project open-source by chance?  If it's hosted somewhere, it'd be great to be able to take a look at it and see if we can help resolve this issue.

Zip deploy via terminal for bot, ftp deploy via ftp program for web app. Nothing is being deployed via the extension anymore.
Sadly not open source (I'm not the boss).
I potentially have another bot project coming up this week, so at that time I will try to deploy via the extension again.

Closing due to lack of activity and since it seems like the user has moved on to other deployment methods at this point. That being said, could be related to https://github.com/microsoft/vscode-azureappservice/issues/1299


Feature request: Adding notes to saved stories.

Hi,
I'm not sure how feasible or how much work this would be, but would it be possible to add the ability to add notes to saved stories? Sometimes I save stories that have a specific thing(s) that I would like to remember about it when I come back to it later. Right now I kind of hack this feature using the tags, but it can get unwieldy if the note is long. If the notes could also be searchable that would be amazing.
Again, not sure how feasible or how much work this would be, but it would be really handy for some use cases I think.
Thanks.
-rattasak

Hi Rattasak, you'll want to submit feature ideas as an 'Idea' on http://getsatisfaction.com/newsblur. This bug tracker is more for tracking bugs in the code.

That being said, I think this is a great idea and I'd love it if you posted it on get satisfaction!

Hi Samuel, I posted it to the GetSatisfaction site as you suggested, though
it doesn't seem to
have gained much traction as an idea with other Newsblur users so far (:
On Thu, Jul 23, 2015 at 5:56 PM, Samuel Clay<EMAIL_ADDRESS>wrote:

That being said, I think this is a great idea and I'd love it if you
posted it on get satisfaction!
—
Reply to this email directly or view it on GitHub
https://github.com/samuelclay/NewsBlur/issues/705#issuecomment-124260884
.

What's the URL? I'll respond on there.

https://getsatisfaction.com/newsblur/topics/adding-notes-to-saved-stories
Thanks for asking!
-sak
On Mon, Jul 27, 2015 at 2:20 PM, Samuel Clay<EMAIL_ADDRESS>wrote:

What's the URL? I'll respond on there.
—
Reply to this email directly or view it on GitHub
https://github.com/samuelclay/NewsBlur/issues/705#issuecomment-125313840
.


Worker type definitions?

I'm trying denoflare for cf worker development and having issues with the type definitions. The official type definition file does not play with deno as it contains many conflicting definitions.
I have found this file in the repo but it seems to be different from the official definitions. For example, the get method of KVNamespace can be used with only 1 argument but raises type error when using the definition from this file.
I wonder what's the recommended / common practice here. Thanks.

So using the "official" Cloudflare types is blocked on https://github.com/cloudflare/workers-types/issues/199
until they fix how they present things, we're stuck with our own bespoke types. I've been working on some new well-documented types for the module worker syntax for my own use, which is a lot easier to encapsulate things than with the "globals" syntax, but yeah right now it's a bit painful.

Yea I've been maintaining my own types (in that cloudflare_workers_types.d.ts) from back before the official types file even existed.
Still find it useful as the the official one lags behind (esp for new cf alpha/beta services) and doesn't play nice with Deno.
I would like to have cloudflare_workers_types.d.ts reflect the current cloudflare production runtime as much as possible, so if you know of any specific differences that you are relying on in production, please raise them as issues/PRs on that file.  Only thing to keep in mind is that denoflare's fakes/stubs/proxies may need to change along with any core type changes.

For anyone following, the @cloudflare/workers-types was updated so that it is now partially importable to avoid the conflicts that used to occur. I haven't tested it with denoflare but it may be easier to use at least a subset of the types now since they dont have to be global and things like "blob" should no longer conflict.

To follow up, I tested and this works great using unpkg:
import { Request, ExecutionContext } from "https://unpkg.com/<EMAIL_ADDRESS>import * as semVer from<EMAIL_ADDRESS>
export default {
	async fetch() {
		const res = `Hello World! ${semVer.increment("1.2.3", "patch")}`
		console.log(res)
		return new Response(res);
	},
};

Nice, I could see migrating over to these piecemeal (re-exporting) in our types file where duplicative, and just keeping our file for the bleeding edge services that are not in workers-types yet.
I gave them some feedback about better jsdocs, and they are working on it.  That's another advantage our types still have in some cases.


Storages: Refine SegmentReadTaskPool and SegmentReadTaskScheduler

What problem does this PR solve?
Issue Number: ref #6834
What is changed and how it works?

This PR mainly refines SegmentReadTaskPool and SegmentReadTaskScheduler  preparing for supporting read-thread and data-sharing in disaggregated-mode. The logic of the reading path is still not changed after this PR.

Main changes:

Remove DMContext and physical_table_id from SegmentReadTaskPool.
Add DMContext to SegmentReadTask.

In disaggregated-mode, EstablishDisaggTask can return SegmentReadTasks of different physical tables. So SegmentReadTaskPool needs to support SegmentReadTasks of different physical tables.
Move information of physical tables in DMContext into SegmentReadTask .

Use GlobalSegmentID to identify a segment in SegmentReadTaskScheduler.

In op-mode, physical_table_id + segment_id + segment_epoch can identify a segment. In disaggregated-mode, it also needs to add store_id and keyspace_id.
Wrap this information into struct GlobalSegmentID.

Enhance the formatter of SegmentReadTaskPtr and remove SegmentReadTask::info.
Remove cluster member from RNWorkerFetchPages.
Remove RNReadTask since it is redundant.

Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-unit-test


Add thread id into the fields logged

This can be pretty handy for multi threaded program to follow the flow of log per thread.
It would have been better to have the u64 instead of its debug format but the api for that is not stable
https://doc.rust-lang.org/1.70.0/std/thread/struct.ThreadId.html#method.as_u64

Please tell me if you find this accurate.
I personally need it not so long ago for debugging nasty dead lock in multi threaded progra.
Maybe, this additional field should be optional (feature flag and or with constructor parameter), tell my what do you think about that ?

Thanks, but I think I'll pass over this one.  I understand that it's handy, but I think it's beyond the scope of this crate, on two different levels even.
For one thing, it's neither a standard field of journald nor a field of a log record. If I added this one where would I draw the line on other custom fields?
And then, conceptually I believe that adequate logging in complex multithreaded programs is well beyond the scope of the whole log crate and thus also of this crate.
If that's your use case I think you should rather use tracing and make good use of spans which are much better than manually aligning thread IDs of log messages.

PS: If you'd like to stick to log, even though I believe it's not really up to the task, and need to add the thread ID to log records, I'd rather prefer to see some development towards an API which enables you to write a custom log wrapper around a journald logger where you can then attach arbitrary custom fields to every specific log record.
That would support your use case without hard-coding specific non-standard fields.

Ok , I totally understand your point , thanks for the reply.

PS: If you'd like to stick to log, even though I believe it's not really up to the task, and need to add the thread ID to log records, I'd rather prefer to see some development towards an API which enables you to write a custom log wrapper around a journald logger where you can then attach arbitrary custom fields to every specific log record.

That would support your use case without hard-coding specific non-standard fields.

I started with this approach but didn't manage to come up with an elegant solution. I may have times in the coming weeks to try to do such a dev.
Thanks again for your useful crate.


Minimal example not running in test

Hi there,
I'm trying to run webrtc-rs in a test. As it didn't work at all, I started from the example/offer-answer/offer.rs and created a minimal example that just starts an offer and displays the first discovered ice-candidates.
What I don't understand: when I run the example as a binary, it prints out the ice-candidates. However, if I run the same code in a test, it doesn't create any ice-candidates. I made a small example here:
https://github.com/ineiti/webrtc-test/runs/5168072092?check_suite_focus=true
The first actions-rs/cargo runs the main and has the on_ice_candidates. The second actions-rs/cargo runs the test (including the -- --nocapture), but it only outputs the println!("Sleeping") that I put in there to make sure I can see the stdout...
Is there something obvious I'm doing wrong here? I hope that assuming it should run in a test is a correct assumption...
Thanks a lot,
Ineiti

So these are the log with trace level from running it with main:
[2022-02-12T16:28:12Z INFO  webrtc_ice::mdns] mDNS is using <IP_ADDRESS>:5353 as dest_addr
[2022-02-12T16:28:12Z TRACE webrtc_mdns::conn] Connected to interface address <IP_ADDRESS>:0
[2022-02-12T16:28:12Z TRACE webrtc_mdns::conn] Error connecting multicast, error: Os { code: 48, kind: AddrInUse, message: "Address already in use" }
[2022-02-12T16:28:12Z TRACE webrtc_mdns::conn] Connected to interface address <IP_ADDRESS>:0
[2022-02-12T16:28:12Z TRACE mio::poll] registering event source with poller: token=Token(1), interests=READABLE | WRITABLE
[2022-02-12T16:28:12Z INFO  webrtc_mdns::conn] Looping and listening Ok(<IP_ADDRESS>:5353)
[2022-02-12T16:28:12Z TRACE webrtc_ice::agent::agent_internal] [controlled]: Set selected candidate pair: None
[2022-02-12T16:28:12Z INFO  webrtc::peer_connection] signaling state changed to have-local-offer
Sleeping
[2022-02-12T16:28:12Z TRACE mio::poll] registering event source with poller: token=Token(2), interests=READABLE | WRITABLE
[2022-02-12T16:28:12Z TRACE mio::poll] registering event source with poller: token=Token(3), interests=READABLE | WRITABLE
on_ice_candidate Some(RTCIceCandidate { stats_id: "candidate:Iv6pGAi3THVEZV406rBfUO2LuH/mCHB7", foundation: "621537334", priority:<PHONE_NUMBER>, address: "<IP_ADDRESS>", protocol: Udp, port: 54970, typ:

And this when running in the test:
[2022-02-12T16:28:48Z INFO  webrtc_ice::mdns] mDNS is using <IP_ADDRESS>:5353 as dest_addr
[2022-02-12T16:28:48Z TRACE webrtc_mdns::conn] Connected to interface address <IP_ADDRESS>:0
[2022-02-12T16:28:48Z TRACE webrtc_mdns::conn] Error connecting multicast, error: Os { code: 48, kind: AddrInUse, message: "Address already in use" }
[2022-02-12T16:28:48Z TRACE webrtc_mdns::conn] Connected to interface address <IP_ADDRESS>:0
[2022-02-12T16:28:48Z TRACE mio::poll] registering event source with poller: token=Token(1), interests=READABLE | WRITABLE
[2022-02-12T16:28:48Z TRACE webrtc_ice::agent::agent_internal] [controlled]: Set selected candidate pair: None
[2022-02-12T16:28:48Z INFO  webrtc::peer_connection] signaling state changed to have-local-offer
Sleeping
[2022-02-12T16:28:49Z TRACE mio::poll] deregistering event source from poller

So the first different line is the missing
[2022-02-12T16:28:12Z INFO  webrtc_mdns::conn] Looping and listening Ok(<IP_ADDRESS>:5353)

Any idea why the mdns is not starting the loop?

OK - took me some time, but I finally found it.
#[tokio::test]

Only starts a single-threaded scheduler, so the mdns will not run. So the tests need to be marked with
#[tokio::test(flavor = "multi_thread")]

And everything is all right... Not sure where this information would be helpful or if you can check it in the code somewhere. Closing the issue.


Fix cash payment and double requirement

When a user is trying to install the software, there is a double requirement for gunicorn in the requirements.txt file which causes docker-compose to fail, and I fixed that.
Also when a user is trying to pay with cash the submit button would be disabled unless the person pays more money and needs change, so if they pay in exact change it wouldn't work but I fixed that.

Looks good, thanks a bunch!


refactor: remove refresh and replace refresh with render

r:rrarrwr...

Here are the changes we discussed a little bit ago.

This looks good to me! Did you decide not to implement different subclasses for now? (I'm fine with that. This looks similar to how the R code currently looks; I'm just curious!)

Yes, I decided not to for now. I implemented it and realized it wasn't worth the additional maintenance complexity. For what it's worth, I'm comfortable making a breaking change here in the future if we decide to do the abstraction.  At least until we get to a v1.0.0 release.


There is no way to see the GitHub Issue for SDK Reviews on the app

A GitHub issue is being created every time a new SDK Review is scheduled, but the link to this issue is nowhere to be found on the app, only in the email.

What about informational?

The Azure Devops work item has a field for the SDK review.  I would like that field updated to track the SDK review.  We could update the product dataverse table and then when the dataverse table syncs to the Azure Devops work item, the field would be updated.  We can also add a field similar to the Info Meeting State which is used to identify if a product has completed informational meeting (for specific scenarios they are required to do this before they create a release plan).

This issue is specific to the Scheduler tool. Currently only API Reviews is showing a link.
i.e.

Informational doesn't have a GH issue, but aybe we can put the ADO item link here?
SDK needs the link too.
@ladonnaq  as for updating the ADO item with the status of the meetings, I totally agree. Issue https://github.com/Azure/azure-sdk-tools/issues/4681 is a great example for that for Informational.
Could you open issues for API Review and SDK Review where we can see the specific name of the fields, the properties, and the desired behavior?

Link included in the list but it is missing adding the GH logo.

Also included on the Edit view (same as API Review meeting):

GH logo added


Enabling possibility of adding tags to RDS resources.

It might be also needed for a kill script. Done like in the tf_aws_alb module or tf_aws_sg (https_only)

@kwach merged!  thanks for your contribution 😁


[WFARQ-140] Follow up on the application client support. Changed to r…

…equire injection via @ArquillianResource annotation and minor clean up.
https://issues.redhat.com/browse/WFARQ-140

@starksm64 does this look okay? There are a few configuration name changes and to inject the AppClientWrapper you need to use an @ArquillianResource annotation. That feels more standard IMO.
The property name change is:  appClientSh -> appClientCommand
Also in the AppClientWrapper I removed the quit() method in favor of implementing AutoCloseable.


Update Item add if-match etag under the same etag, get 412 Precondition Failed .

Like https://github.com/OneDrive/onedrive-api-docs/issues/514 issue the same, I create a folder , and would like to update it , whether add "if-match" or "if-none-match" , always get 412 Precondition Failed even etag are same.
log like this,
1156 [main] TRACE OneDriveProvider - server's etag aQ0JGNTk1MTAxRkE2OTNGNSE2NjQuMQ
1156 [main] TRACE OneDriveProvider - local's  etag aQ0JGNTk1MTAxRkE2OTNGNSE2NjQuMQ
1433 [main] ERROR OneDriveProvider - HTTP PRECON FAILED
Could you please comfirm this ? thank.

Hmm, I'm unable to reproduce this one - here's what I tried.
Created a folder

PATCH https://api.onedrive.com/v1.0/drive/root:/tempfolder-1 HTTP/1.1
Content-Type: application/json
Host: api.onedrive.com
Content-Length: 21
{
"folder": { }
}
HTTP/1.1 201 Created
{
...
"eTag": "aQTkwNUFFOTJGMkUzRTc2RCE5NjM4MTYuMA",
"id": "XXXXXX!963816",
"name": "tempfolder-1",
...
}

Updated with correct ETag

PATCH https://api.onedrive.com/v1.0/drive/items/XXXXXX!963816 HTTP/1.1
Content-Type: application/json
Host: api.onedrive.com
Content-Length: 30
If-Match: aQTkwNUFFOTJGMkUzRTc2RCE5NjM4MTYuMA
{
"name": "tempfolder-2"
}
HTTP/1.1 200 OK
{
...
"eTag": "aQTkwNUFFOTJGMkUzRTc2RCE5NjM4MTYuMQ",
"id": "XXXXXX!963816",
"name": "tempfolder-2",
...
}

Updated with incorrect ETag

PATCH https://api.onedrive.com/v1.0/drive/items/XXXXXX!963816 HTTP/1.1
Content-Type: application/json
Host: api.onedrive.com
Content-Length: 30
If-Match: aQTkwNUFFOTJGMkUzRTc2RCE5NjM4MTYuMA
{
"name": "tempfolder-3"
}
HTTP/1.1 412 Precondition Failed
{
"error": {
"code": "notAllowed",
"message": "ETag does not match current item's value",
}
}

Did I do something different what you did to get the repro?

Please test with parentReference ,I want to rename and move to other folder(A folder)
PATCH https://api.onedrive.com/v1.0/drive/items/XXXXXX!XXXX HTTP/1.1
Content-Type: application/json
If-Match: etag
{
"name": "SubFolderB",
"parentReference" : {"path": "/drive/root:/A"}
}
{
"error": {
"code": "notAllowed",
"message": "ETag does not match current item's value",
"innererror": {
"code": "preconditionFailed"
}
}
}

Confirmed that's the trick, thanks @shinjikao it's definitely a bug that we'll get fixed.

Hi @shinjikao, this should now be resolved.