question on permissions used

My scanner got some additional checks implemented last week, and today, receiving your first update since, reported:
! repo/com.broscr.iptvplayer_4.apk declares flag(s): usesCleartextTraffic
! repo/com.broscr.iptvplayer_4.apk declares risky permission(s): android.permission.READ_EXTERNAL_STORAGE android.permission.READ_MEDIA_AUDIO

Could you please clarify those?

usesCleartextTraffic: are there any stations out there still using unencrypted HTTP?
READ_EXTERNAL_STORAGE: the minimum Android version needed to use your app is Android 5, which introduced SAF (Storage Access Framework). Is this permission still needed then?
READ_MEDIA_AUDIO: any locally hosted TV stations there? :see_no_evil:

Thanks in advance!

usesCleartextTraffic: are there any stations out there still using unencrypted HTTP?
Yes, there may be stations that use it, I have no definitive information about it, I added it because I saw http requests while testing.

READ_EXTERNAL_STORAGE: the minimum Android version needed to use your app is Android 5, which introduced SAF (Storage Access Framework). Is this permission still needed then?
Up to Android version 32, it is possible to read files with this permission. The user gets this permission to choose among all his files.

READ_MEDIA_AUDIO: any locally hosted TV stations there?
Note: Starting in API level 33, this permission has no effect. If your app accesses other apps' media files, request one or more of these permissions instead: READ_MEDIA_IMAGES, READ_MEDIA_VIDEO, READ_MEDIA_AUDIO. Learn more about the storage permissions that are associated with media files.
READ_EXTERNAL_STORAGE

usesCleartextTraffic: Thought so, thanks for confirming! Added to the allow-list of your app.
READ_EXTERNAL_STORAGE: I just learned this is still needed up to Android 9 if you want to access other apps' media files (for later Android versions one should use READ_MEDIA_AUDIO  etc; updating my notes here I noticed I've seen that earlier but it somehow escaped my memory, apologies for that). So I assume you refer to those? Then this point can be skipped and "merged" with the next one:
READ_MEDIA_AUDIO: yes, see above. But according to the app description (or according to how it can be read) and the app's name, it's intended for IPTV. Does it allow to play local media, too – and are you referring to local M3U playlists for local media then?

READ_MEDIA_AUDIO: yes, see above. But according to the app description (or according to how it can be read) and the app's name, it's intended for IPTV. Does it allow to play local media, too – and are you referring to local M3U playlists for local media then?.
In fact, this application is a player and all it does is to let the user select m3u and m3u8 files, read their content, save it in localdb and play it as a list.

    FlagIgnore:
      usesCleartextTraffic: Needed for some TV stations which only provide their streams over unencrypted HTTP.
    PermIgnore:
      android.permission.READ_EXTERNAL_STORAGE: Needed to access media saved/stored by other apps.
      android.permission.READ_MEDIA_AUDIO: Needed to play your local audio files.

Thanks!


Pass req.locals to immediate function.

The server.resume functionality allows for additional information to be passed to the immediate callback by exposing the res.locals parameter. This PR allows the same to be done for the initial authorization processing via req.locals.

Coverage increased (+0.0002%) to 99.778% when pulling e5c4a7597e9e0161a340d03969e69f871c96d6a7 on sjudson:pass-locals-authz into fe4b4c6123ee4da2f1588c17fe41caa8a13669d9 on jaredhanson:master.


[JoyUI] Add support for having user defined html tags for custom Typography system

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
While defining custom typography, we could also provide what tag to render.
const customTheme = extendTheme({
  typography: {
    // @ts-ignore
    display1: undefined,
    display2: undefined,
    h1: undefined,
    h2: undefined,
    h3: undefined,
    h4: undefined,
    h5: undefined,
    h6: undefined,
    body1: undefined,
    body2: undefined,
    body3: undefined,
    body4: undefined,
    body5: undefined,
    xlNumericsLimited: {
      fontSize: "68px",
      lineHeight: "76px",
      component: 'h1', // 👈 something like this
    },
    heroTitle: {
      fontSize: "42px",
      lineHeight: "52px"
    },
    greetingTitle: {
      fontSize: "32px",
      lineHeight: "40px",
      component: 'h2' // 👈 something like this
    },
    pageTitle: {
      fontSize: "28px",
      lineHeight: "36px"
    },
    paneHeader: {
      fontSize: "20px",
      lineHeight: "28px"
    },
    header: {
      fontSize: "18px",
      lineHeight: "24px"
    },
    subjectTitle: {
      fontSize: "16px",
      lineHeight: "22px"
    },
    bodyText: {
      fontSize: "14px",
      lineHeight: "20px",
      component: "p" // 👈 something like this
    },
    metadata: {
      fontSize: "12px",
      lineHeight: "16px"
    },
    metadataLimited: {
      fontSize: "10px",
      lineHeight: "12px"
    }
  }
});

Examples 🌈
No response
Motivation 🔦
Hi team,
While creating a custom Typography system, I noticed that all custom types were rendered with the <span> tag.  sandbox

I was thinking if the API could expose a way for us to choose what tag to render for our custom typography system too.
Thanks

@badalsaibo You can use provide levelMapping to the theme's default props of Typography.
const theme = extendTheme({
  components: {
    JoyTypography: {
      defaultProps: {
        levelMapping: {
          xlNumericsLimited: 'h1',
          // ...other levels
        }
      }
    }
  }
});

https://codesandbox.io/s/loving-paper-7ql3ex?file=/index.tsx

Nice.
We could consider adding a level mapping to the custom typography examples too!
https://mui.com/joy-ui/customization/theme-typography/#common-examples

Nice. We could consider adding a level mapping to the custom typography examples too! https://mui.com/joy-ui/customization/theme-typography/#common-examples

Done!


convert_from_abi helper has unnecessary cast

windows-uwp/windows-apps-src/cpp-and-winrt-apis/interop-winrt-abi.md
this helper can be written without the cast like this, please update the 2 occurrences on the page above.
template <typename T>
T convert_from_abi(::IUnknown* from)
{
    T to{ nullptr }; // this is a winrt projection type
    winrt::check_hresult(from->QueryInterface(winrt::guid_of<T>(), winrt::put_abi(to)));
    return to;
}

https://github.com/MicrosoftDocs/windows-uwp-pr/pull/444 is currently building...

I'll go ahead and close. Thanks, Chris!
-Steve


language mapping not found by Atom's Hydrogen package

Hydrogen is a jupyter front-end plugin for Atom.
It fails to execute elm code because the language field in the kernel json is text instead of elm.
We should change that in install.py to say "language":"elm".
In the meantime, I found a  workaround:
We can create a language mapping in Hydrogen's package settings from text to elm so that it can find the correct kernel for the language. (Language Mappings: {"text":"elm"})

Thanks for catching that! A fix is in master. If you agree that it's fixed, please close this.

Looks great! thank you!


remove double inheritance with NamedTuple error

remove double inheritance with NamedTuple to avoid TypeError, as per python 3.9:
https://github.com/python/cpython/pull/19363

closing because of https://github.com/AmpX-AI/fsql/pull/24


Disable "text message" notification radio control and add explanatory text

Since we are not capable yet of sending notifications, we should disable the option for notification rules and add a message explaining that this will be possible in the future.

Notifications are possible, but need some more work to get them fully working.
Current status:

Geographic notifications (point + radius), filtered by organisation and issue type work with sms and email.
Mention notifications work with email only and are not yet configurable

Email notifications on development is done by printing the mail to the terminal window where the dev server is running.

So for some notifications we support text messages and for some we don't? Should we disable the text message options for those notifications that don't and add an explanatory text that says that this will be possible once an SMS gateway is configured? We just wanted to make sure that as much as possible within the application is self-explanatory without the need of a handbook before they start testing.

So for some notifications we support text messages and for some we don't?

Yes, the 2 notification systems (one for issue creation and geograpic range, the other for user/org mentions in comments) are implemented differently at the moment. I'll try to work on it during the weekend and hope to get a proper implementation by Monday that works for both cases.
I have implemented the corresponding settings in 8bbb7714d62f12a57b11a16b955a03bbcf9b603c

I have implemented a very straightforward approach to this issue in 6cd2d285d643e32ed462737f4fd595b1c153161e
This will suffice for now, but I am thinking about refactoring the whole notification approach to accomodate  multiple backends, including web/mobile notifications with acknowledgement support.
Currently all notifications are sent immediately. We will need some kind of throttling in the future.


[DatabaseGenerated(DatabaseGeneratedOption.Identity)] for Guid

May be I have overseen something.
I want to use a Guid as the primary key. Pls no discussion upon it is better not to use. We have to replicate the database with others, so an integer key cannot guranty not to be duplicated.
I have to decorate the key with
[DatabaseGenerated(DatabaseGeneratedOption.Identity)]
as I read, if I want SQLite to return the newly generated key. But therefor the key column must have the attribute NOT NULL, otherwise I'm getting an exception. How can I acheave this? In the code I have seen, that in "AddNullConstraintIfNecessary" a "NotNullConstraint" will not be generated, if the property is an identity property. But here I need it.

Does SQLite support the auto creation of new GUID primary keys?
Please provide the DDL SQL which results in the behavior you would like to get.

Closed due to inactivity. Feel free to reopen.


dynamically reload highlightjs

Hello,
is it possible to reload highlight js somehow dynamically?
comparable to:
hljs.initHighlighting.called = false;
hljs.initHighlighting();

or
$(document).ready(function() {
   $('#myDiv').each(function(i, e) {hljs.highlightBlock(e)});
});

You can use code property to bind to your dynamic code content.

thank you. But i am using it in a contentEditable="true" container and want to re render the highlightjs once changes are made

Can you give me some example?


"Izvoru Ampoiului" is listed in the drop-down menu

Description:
"Izvoru Ampoiului" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Izvoru Ampoiului" in the search bar.

Expected results
The location is listed in the drop-down menu as "Izvoru Ampoiului, Alba (Zlatna)".


Implement pure Terraform version of k8s-tiller

[ ] Contribute to https://github.com/terraform-providers/terraform-provider-helm/issues/134
[ ] Implement TLS functionality using the TLS provider
[ ] Implement secrets management using Kubernetes provider

This was introduced in https://github.com/gruntwork-io/terraform-kubernetes-helm/releases/tag/v0.4.0


Fixes bookmark names not being preserved between views

Fixes #933

Looks good. Please give me a head's up before/when you start working on something next time, though, so there isn't a risk of duplicated effort or an issue having insufficient information to solve the problem.

sure thing!


Remove set guards from PathFollow3D

This PR removes set guards (which returned early if the same value is set again) to make sure that if you call set, it updates the transform.
From my early testing, it doesn't seem to impact performance (i.e. the setters aren't called every frame).
Fixes #98602
Alternative to #98618 (where a boolean is set to force the update, but doesn't fix the issue at the core)

How can I test these changes?

@Steinbeuge You can download the artifacts generated

@Steinbeuge The use of artifacts idea from @matheusmdx is great.
But I highly encourage you to start building Godot on your own. It's easier than we usually think it is.
Especially for testing PRs, with the GitHub CLI.
gh pr checkout 98642 # just before starting the build

I haven't looked into the bug much, but set guards like this is a common pattern in Godot and should work fine.
If the default state of the class is wrong, we shouldn't rely on re-setting its properties to the same default value to get stuff to update.
It might just be missing running an update once in NOTIFICATION_ENTER_TREE or similar, no?

I haven't looked into the bug much, but set guards like this is a common pattern in Godot and should work fine. If the default state of the class is wrong, we shouldn't rely on re-setting its properties to the same default value to get stuff to update.
It might just be missing running an update once in NOTIFICATION_ENTER_TREE or similar, no?

No, its still broken in 4.4 d5, setting it to zero hits a guard. These guards are nonsense, there are a lot of people who got hit by this same bug off the back of one fix for one person. Just give us a flag or a force_update function yikes..


Added information about the Microsoft Open Source Code of Conduct

Hi @Ricalo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Ricardo Loo). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Update index.sass

fixes this message:
DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

closes #7


Very bad quality in some cases

Overall this is a great project and even makes some new things possible but sadly I've run into some exceptionally bad cases where the quality loss is so bad I'm asked to disable compression.
None of the settings I tried seem to help.
Example image:

DXT1 (compressed using ddsview):
test_dxt1.zip

basis (1.12, -q 255, transcoded to BC7):
test-basis-output.zip

all together for a better comparison as a gif (4x zoom):

the selectors seem OK but the endpoints are way off, sometimes they even look as if they are swapped
any idea on what could be the issue or if there are any temporary workarounds/settings to try?

Sorry, I seem to have rushed with my issue.
I've just noticed that there's a new mode available (UASTC) and it looks great!
Added to comparison gif:

Thanks for all the work!


I checked the gruntfile and it seems to be just stale stuff.

LGTM


merge @register_condition and @condition into a single decorator ?

Could we replace this with a single @condition decorator that does the job of both?
@register_condition
@condition

It's possible, but it also hides a lot of the actual action. I'm not sure yet.
Also, we'd need to make sure that the arguments for the two tasks don't clash, which may become a bit fiddly in the long run. Now,  @register_condition has an optional name as a keyword argument (default is condition.name) and FontBakeryCondition also has an optional name argument (default is func.__name__). The name argument of @register_condition exists so that one can reuse conditions in other specs with a way to avoid name clashes with the rest of the namespace. Similarly FontBakeryCondition is so that we can use existing function that do the right thing but have a bad name (It's also used to print the condition via __repr__). I'm not sure what's best in this case, there's a (small) semantic gap between the two name args, we may have to rename the @register_condition argument if we want to unify.
The other thing is, that I find it quite tiring to wrap my head around the two styles of python decorators (with and without arguments) and put it together in one function. But that could be overcome.


Package dependency issue

I can't add the package to my Android project, because it needs to different versions of the same Xamarin.Android.Support.V4 package. (See the log below)
"Adding Xamarin.FFImageLoading.Forms...
Attempting to resolve dependency 'Xamarin.FFImageLoading (≥ 2.1.6-pre-126)'.
Downloading Xamarin.FFImageLoading 2.1.6-pre-126...
Downloading Xamarin.FFImageLoading.Forms 2.1.6-pre-126...
Attempting to resolve dependency 'Xamarin.Forms (≥ <IP_ADDRESS>92)'.
Attempting to resolve dependency 'Xamarin.Android.Support.v4 (= <IP_ADDRESS>)'.
Attempting to resolve dependency 'Xamarin.Android.Support.Design (= <IP_ADDRESS>)'.
Attempting to resolve dependency 'Xamarin.Android.Support.v7.AppCompat (≥ <IP_ADDRESS>)'.
Attempting to resolve dependency 'Xamarin.Android.Support.v4 (= 23.3.0)'.
Attempting to resolve dependency 'Xamarin.Android.Support.Design (= 23.3.0)'.
Updating 'Xamarin.Android.Support.v4 <IP_ADDRESS>' to 'Xamarin.Android.Support.v4 23.3.0' failed. Unable to find a version of 'Xamarin.Forms' that is compatible with 'Xamarin.Android.Support.v4 23.3.0'."

@tamasszadvari

FFImageLoading doesn't rely on any specific Xamarin.Forms / Xamarin.Android.Support packages versions.
Do you use Xamarin Studio or Visual Studio?
Did you try to uninstall and then reinstall all packages? (including Xamarin.Forms)

@daniel-luberda
I've noticed that, that's why I don't understand the error.
I use Xamarin Studio.
No, I haven't tried, but thanks for the suggestion, I'll try. Do you have any idea what can be the source of the problem?

I noticed that Xamarin Studio has sometimes problems with package updates. Uninstalling and installing all packages again usually resolves it.

I've deleted all of my references, and uninstalled all of my packages, and after that, I've tried to install the FFImageLoading.Forms package, and the issue is still there:
"Adding Xamarin.FFImageLoading.Forms...
Attempting to resolve dependency 'Xamarin.FFImageLoading (≥ 2.1.6)'.
Attempting to resolve dependency 'Xamarin.Forms (≥ <IP_ADDRESS>92)'.
Attempting to resolve dependency 'Xamarin.Android.Support.v4 (= <IP_ADDRESS>)'.
Attempting to resolve dependency 'Xamarin.Android.Support.Design (= <IP_ADDRESS>)'.
Attempting to resolve dependency 'Xamarin.Android.Support.v7.AppCompat (≥ <IP_ADDRESS>)'.
Attempting to resolve dependency 'Xamarin.Android.Support.v4 (= 23.4.0)'.
Updating 'Xamarin.Android.Support.v4 <IP_ADDRESS>' to 'Xamarin.Android.Support.v4 23.4.0' failed. Unable to find a version of 'Xamarin.Forms' that is compatible with 'Xamarin.Android.Support.v4 23.4.0'."
I use the latest stable version of the Xamarin Studio and Xamarin.Android too.

Did you have Xamarin.Forms package installed before adding Xamarin.FFImageLoading.Forms? What version?

Oh, I've managed to solve this problem. The problem was that in the packages folder I had two different versions of the Xamarin.Forms package, and one of them was an early (I think around version 2.0) version. After I've deleted the early version, I successfully installed the FFImageLoading package.
Maybe this will be a useful information in the future for others too. :)

Great. Thanks for the info.

Your welcome. This problem gave me a lot of headache. Maybe it would be useful to mention this in the readme file, but this is just an advice (because now I have to reinstall every other package, and I had a lot :) ). Package version conflicts are always a pain in the... :)


Add .gitattributes with Cargo.nix as generated

Overview
This PR will mark Cargo.nix file as generated in order to fix a little bit skewed language statistics of lorri's GitHub repository.

LGTM, thanks!


Simplify and generalize ssh key generation

Improve ssh key generation algorithm ahead. The ssh key generator was being used by the vSphere provider only and the vSphere provider created it inline to generate a key. This change converts key generation to a much simpler function while maintaining backward compatibility with the file writer. Additionally, it removes the vSphere specific logging from the key generator into the vSphere provider so the key generation function can be re-used.
This change shed light on how inflexible the filewriter.FileWriter interface is. It defines a path context for the application's io operations but doesn't compliment the stdlib's io package making it difficult to isolate io. Watch this space for a design proposal.

/cc @gwesterfieldjr @panktishah26 @ptrivedi @abhinavmpandey08

FileWriter refactoring discussions have been brought up in the past as well. I don't see the changes for the Tinkerbell provider in here. Assuming that's coming in a different PR?

Also, IIRC, the previous key generator was not specific to vSphere, except for a recent log message that had been added. This looks fine too.

/lgtm


Reranker API implemention

The docs has the rerank module but this is not available on the library
Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.
This PR inplements the rerank API into the pinecone library

Hi @Stosan, thanks very much for opening this PR to support the Rerank API in the Go SDK. I have some feedback that would be helpful for getting this code ready to merge into the library.
All of the code in the codebase under /internal/gen/* is generated from OpenAPI and proto specification files. You can see at the top of the Go files the tag about not editing: https://github.com/pinecone-io/go-pinecone/blob/64f1d686e9c7748d227d1ea4e2980eaba7d7130c/internal/gen/control/control_plane.oas.go#L1
In order to properly support Rerank in the Go SDK, we need to regenerate the code under /internal/gen/ to align with upcoming API changes. I've done that here: https://github.com/pinecone-io/go-pinecone/pull/76. Would you be able to rebase and refactor the changes in this PR on top of the release-candidate/2024-10 branch? This branch should include all of the necessary changes to the generated code under /internal/gen/.
The generated types, functions, and methods should be exposed in the inference package under /internal/gen/inference/inference_2024-10.oas.go: https://github.com/pinecone-io/go-pinecone/blob/release-candidate/2024-10/internal/gen/inference/inference_2024-10.oas.go
For the code you've added in this PR the changes in client.go and client_test.go look great, really appreciate the attention to detail around doc comments and testing coverage. If you're able to rebase your changes onto the upcoming release-candidate/2024-10 branch that would be very appreciated. Please let me know if you have any questions, and thanks!

All Austin,
Will do this weekend.


Plugin Removing itself fails

👋

What's going on?
Ignite plugins seems to fail removing themselves (when using yarn, anyway).
$ ignite remove code-push --debug
🔎    Verifying Plugin
    ✔ uninstalling react-native-code-push
    ✔ removing
Removing dev module
  TypeError: Cannot read property 'exec' of undefined

  - remove.js:65 removeDependency
    [global]/[ignite-cli]/build/commands/remove.js:65:27

  - remove.js:144 Command.<anonymous>
    [global]/[ignite-cli]/build/commands/remove.js:144:25

  - remove.js:32 step
    [global]/[ignite-cli]/build/commands/remove.js:32:23

  - remove.js:13 Object.next
    [global]/[ignite-cli]/build/commands/remove.js:13:53

  - remove.js:4 fulfilled
    [global]/[ignite-cli]/build/commands/remove.js:4:58

/Users/osedea/.config/yarn/global/node_modules/gluegun/build/index.js:13
    throw up;
    ^

TypeError: Cannot read property 'exec' of undefined
    at removeDependency (/Users/osedea/.config/yarn/global/node_modules/ignite-cli/build/commands/remove.js:65:27)
    at Command.<anonymous> (/Users/osedea/.config/yarn/global/node_modules/ignite-cli/build/commands/remove.js:144:25)
    at step (/Users/osedea/.config/yarn/global/node_modules/ignite-cli/build/commands/remove.js:32:23)
    at Object.next (/Users/osedea/.config/yarn/global/node_modules/ignite-cli/build/commands/remove.js:13:53)
    at fulfilled (/Users/osedea/.config/yarn/global/node_modules/ignite-cli/build/commands/remove.js:4:58)

remove.js relevant part:
38 var shelljs_1 = require("shelljs");
...
59 var removeDependency = function (moduleName) {
 60     console.warn('Removing dev module');
 61     if (useYarn) {
 62         shelljs_1.default.exec("yarn remove " + moduleName, { silent: true });
 63     }
 64     else {
              // shelljs_1.default does not seem to exist?
 65         shelljs_1.default.exec("npm rm " + moduleName + " --save-dev", { silent: true });
 66     }
 67 };

This is very strange because shelljs_1 is defined with all the methods on. Just shelljs1.default is missing.

Steps to reproduce
// Create a new project from `react-native init`
react-native init MyTest
ignite attach
ignite add intl
ignite remove intl

ignite doctor results:
System
  platform           darwin
  arch               x64
  cpu                4 cores      Intel(R) Core(TM) i5-6360U CPU @ 2.00GHz
  directory          MyTest       /Users/osedea/Projects/OSEDEA/Test/MyTest

JavaScript
  node               12.13.0      /Users/osedea/.nvm/versions/node/v12.13.0/bin/node
  npm                6.12.0       /Users/osedea/.nvm/versions/node/v12.13.0/bin/npm
  yarn               1.19.2       /usr/local/bin/yarn

Ignite
  ignite-cli           3.3.1        /usr/local/bin/ignite
  ignite src           build        /Users/osedea/.config/yarn/global/node_modules/ignite-cli/build
  createdWith          3.3.1
  boilerplate          empty
  boilerplateVersion   -
  generators           {}

Android
  java               1.8.0_222    /usr/bin/java
  android home       -            /Users/osedea/Library/Android/sdk

iOS
  xcode              11.2.1
  cocoapods          1.7.5        /Users/osedea/.rbenv/shims/pod

Submitted PR @adrienthiery.

:tada: This issue has been resolved in version 3.3.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


docs: move projects from README.md to docs/userguides/projects.md

What I did
updated README.md to move projects to projects.md
fixes: APE-403
How I did it
followed the ticket as best I could
How to verify it
review documentation
Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

ape-init is already covered in projects guide.

In addition to above comments, may need reordering to move projects section of README.md out of plugins section of README.md


Throttling requestQueue for rate limiting

Some of the target APIs or websites got rate limiting restrictions to prevent bots and scrapers. Right now the best way that I can overcome this is adding random sleeps on request functions. Is there a better way to do it? Or do you plan to add any kind of throttling to requestQueue for rate limits?

The SDK (SessionPool) considers 429 errors as a sign of a blocked proxy and discards the session. So this is your best bet. The sites sometimes send code 200, but tell you that you're rate limited somewhere in the HTML. Then you need to retire the session manually by calling session.retire().
Otherwise, you can use maxConcurrency and various custom delays to slow the crawler down. Or a combination of all of those.
Does this help?

Yes, that makes sense. Currently that's my approach when I encounter with rate limiting. However I think adding sleeps dynamically with multi-concurrency is not a decent approach since you can't really manage over it without burning up the proxies. That's why I asked if you have plans to implement some kind of throttling on requestQueue.


About inlines field's style

I inline a field, how to add a style to it?

https://github.com/sshwsfc/xadmin/blob/master/xadmin/plugins/inline.py
Inline models are managed by plugin. Use the style (def. stacked) attribute in your admin model object.
Notice that in the link above, style_manager is who registers styles (you could even register your own styles).


Network: Adds ability route external IPs to OVN NICs

Introduces the ability to route external IPs to OVN NICs by way of proxy ARP (for IPv4) or proxy NDP (for IPv6).
This is achieved using the following process:

Define a physical network with ipv4.routes and/or ipv6.routes set - this indicates which subnets the upstream router has already routed into the physical network (but importantly, not to the LXD host's IP).
Optionally you can set restricted.networks.subnets on a project to allocate a subset of the routes set on the uplink network as allowed for use with OVN networks inside this project.
Next, create an ovn network and set the ipv4.routes.external and/or ipv6.routes.external to a list of subnets that are within both the uplink's routes and (if set) the project's restricted.networks.subnets setting.
Finally, add an ovn NIC device to an instance, and specify ipv4.routes.external and/or ipv6.routes.external as a list of subnets that should be routed to the NIC device and published to the uplink network using proxy ARP or proxy NDP.

@stgraber I'm going to follow this PR up with another one to add more usage conflict validation (when another instance/network is using overlapping subnets)  and support for ipv4.routes and ipv6.routes for OVN NICs to add local non-external static routes as we discussed. But to keep the size down this is ready for review.

Testsuite passed

Testsuite passed

Testsuite passed


Hive Image Bump Fixing GHSA-6wvf-f2vw-3425

Which issue this PR addresses:
ARO-5064

What this PR does / why we need it:
Updates the hive image used to https://quay.io/repository/app-sre/hive/tag/bf2d689231
This is needed to resolve the vulnerability GHSA-6wvf-f2vw-3425, addressed in OCPBUGS-35282. Which was merged into the hive master branch via PR #2393 and PR #2339.

Test plan for issue:
Deploy this hive image to shared aks cluster.
Deploy this hive image to a shared aks cluster, ensuring the deployment is updated without error.
Create a cluster by installing via hive and a locally running RP.

Is there any documentation that needs to be updated for this PR?

How do you know this will function as expected in production?
steven@rh-thinkpad-p1:~/go/src/github.com/Azure/ARO-RP$ ./hack/hive-generate-config.sh
main: Using hive commit: bf2d689231
install_kustomize: starting
hive_repo_clone: starting
hive_repo_clone: Cloning https://github.com/openshift/hive.git into /tmp/tmp.ci6AhBxUpM for config generation
Cloning into '/tmp/tmp.ci6AhBxUpM'...
remote: Enumerating objects: 153644, done.
remote: Counting objects: 100% (276/276), done.
remote: Compressing objects: 100% (157/157), done.
remote: Total 153644 (delta 137), reused 211 (delta 114), pack-reused 153368
Receiving objects: 100% (153644/153644), 133.25 MiB | 22.84 MiB/s, done.
Resolving deltas: 100% (93978/93978), done.
Updating files: 100% (25882/25882), done.
hive_repo_hash_checkout: starting
hive_repo_hash_checkout: Attempting to use commit: bf2d689231
HEAD is now at bf2d68923 Merge pull request #2394 from 2uasimojo/build-faster/pip
generate_hive_config: starting
main: Hive config generated.

Connected to westeurope aks vpn.
sudo openvpn secrets/vpn-aks-westeurope.ovpn

Deploying hive:
steven@rh-thinkpad-p1:~/go/src/github.com/Azure/ARO-RP$ ./hack/hive-dev-install.sh
hive is already installed in the namespace
would you like to reapply the configs? (y/N): y
customresourcedefinition.apiextensions.k8s.io/checkpoints.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterclaims.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterdeploymentcustomizations.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterdeployments.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterdeprovisions.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterimagesets.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterpools.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterprovisions.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterrelocates.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterstates.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/dnszones.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/hiveconfigs.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/machinepoolnameleases.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/machinepools.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/selectorsyncidentityproviders.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/selectorsyncsets.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/syncidentityproviders.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/syncsets.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clustersyncleases.hiveinternal.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clustersyncs.hiveinternal.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/fakeclusterinstalls.hiveinternal.openshift.io configured
secret/hive-global-pull-secret configured
hiveconfig.hive.openshift.io/hive configured
configmap/additional-install-log-regexes created
serviceaccount/hive-operator unchanged
clusterrole.rbac.authorization.k8s.io/hive-operator-role configured
clusterrolebinding.rbac.authorization.k8s.io/hive-operator-rolebinding configured
deployment.apps/hive-operator configured
deployment.apps/hive-operator condition met
deployment.apps/hive-controllers condition met
pod/hive-clustersync-0 condition met

Hive is installed.

Closing to open a new pull request with the latest hive tag.


[7.x] Simplify hidden attributes on models

This PR is aimed to make the method behaviour more predicatable, consistent and to slightly simplify the codebase.
The state before this PR is the following:

Methods makeHidden and makeVisible are featured on documentation and tested, addHidden and addVisible are not. And each of add* only has a single use in the codebase.
Method makeHidden may produce surprising results on an edge case:

Calling makeHidden['col1'] on a model that has $visible = ['col1'] would clear (and thus disable) the whitelist, making everything visible (except col1).

Method addVisible may produce unexpected results on two cases

If the model's $visible was empty, addVisible('col1') will make everything but col1 invisible;
If col1 is hidden, addVisible('col1') would not make it visible.

Other than the three quirks above, the differences between makeHidden/makeVisible and addHidden/addVisible are just these:

make* returns model, add* returns void.
add* accepts unwrapped lists of arguments ('col1', 'col2') in addition to single string ('col1') and arrays (['col1', 'col2']) which are accepted by both.

To solve the inconsistencies and surprises, simplify the work with the methods and reduce amount of similar methods, I propose here to:

Make makeHidden and makeVisible accept unwrapped lists of arguments ('col1', 'col2') in addition to current ('col1') and (['col1', 'col2']). That's for convenience and consistency with methods like with().
Remove addHidden and addVisible.
Move previous addVisible logic into makeVisible (it's still one line).
Simplify makeHidden to only add entries to $hidden, but not remove the from $visible.

Explanation on the final point: adding to blacklist $hidden is enough as the blacklist is applied last. The only case where removing from $visible would affect behaviour is the aforementioned quirk that makes everything else visible and such behaviour just shouldn't be here.

But how can one make a hidden attribute visible again?


API doc links broken

The following links:

https://teaclave.apache.org/api-docs/trustzone-sdk/optee-teec/
https://teaclave.apache.org/api-docs/trustzone-sdk/optee-utee/

referenced by both the "Docs" dropdown on the main Teaclave site and by this project's README go to a 404 page. The Internet Archive's last record of them working was on March 21st.

@mssun Could you provide some guidance for me to fix this? I noticed the docs of other projects are also broken, such as https://teaclave.apache.org/api-docs/client-sdk-rust/. Thanks!

I have uploaded the documents to the website in https://github.com/apache/incubator-teaclave-website just now. Please check the links out.

@henrysun007 Great. Thanks!


Add asset manager token into share sale environment

To be merged after deployment#907

Looks right to me :+1:


Handle Cloudfront forwarded headers

Is your feature request related to a problem? Please describe.
I have a website that renders components in a different manner if it's a phone or not by checking the user-agent header. This was perfectly fine with AWS API Gateway, but Cloudfront caches everything, so that approach is currently broken for me.
Describe the solution you'd like
Reading through the docs I found some ways that Cloudgront allows to forward certain headers so it can cache different objects depending on the header sent:

https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/header-caching.html#header-caching-web-device
https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/lambda-examples.html#lambda-examples-redirecting-examples

However, the lambda doesn't take into consideration this. I'm fairly new to AWS, Serverless and Next.js and I'm not sure if this feature request should be here or in Next.js
Describe alternatives you've considered
Just use previous version with API Gateway
Additional context

This should be possible to do now. Check https://github.com/danielcondemarin/serverless-next.js/blob/master/README.md#custom-cloudfront-configuration for more info.

Fantastic!!


Pipelined connection rise exception

Seems if we are using pipelined request server do not handle it properly. Even it do not support pipelined requests it must not throw exception.
Server configuration:
<?php

const AERYS_OPTIONS = [
    // help avoid connection errors during benchmark
    'connectionsPerIP' => 100,
    // to emulate NodeJS behavior
    'keepAliveTimeout' => 10000,
    'maxKeepAliveRequests' => 10000,
];

(new \Aerys\Host)
    ->name("localhost")
    ->expose("<IP_ADDRESS>", 8080)
    ->use(function(Aerys\Request $req, Aerys\Response $resp) {
        $data = 'Hello world!';
        $status = 200;
        $resp->addHeader('Content-Type', 'text/plain; charset=utf-8');
        $resp->addHeader('X-Powered-By', 'AerysServer');
        $resp->setStatus($status);
        $resp->end($data);
    });

Lua pipelined script:
init = function(args)
    local r = {}
    for i = 1, 20 do
        r[i] = wrk.format(nil, "/?" .. i)
    end

    req = table.concat(r)
end

request = function()
    return req
end

wrk -t1 -c100 -d1s --latency -s pipeline.lua http://<IP_ADDRESS>:8080/

Get following exception after benchmark is finished:
[2017-05-13 00:32:51] critical LogicException: Promise already resolved in /app/aerys/vendor/amphp/amp/lib/Placeholder.php:70
Stack trace:
#0 /app/aerys/vendor/amphp/amp/lib/PublicPromisor.php(63): Amp\Deferred->resolve(Object(Aerys\ClientException), NULL)
#1 /app/aerys/vendor/amphp/aerys/lib/Server.php(913): Amp\Deferred->fail(Object(Aerys\ClientException))
#2 /app/aerys/vendor/amphp/aerys/lib/Server.php(506): Aerys\Server->close(Object(Aerys\Client))
#3 /app/aerys/vendor/amphp/amp/lib/NativeReactor.php(265): Aerys\Server->onReadable('00000000369e395...', Resource id #183, Object(Aerys\Client))
#4 /app/aerys/vendor/amphp/amp/lib/NativeReactor.php(249): Amp\NativeReactor->doIoCallback('00000000369e395...', Object(stdClass), Resource id #183)
#5 /app/aerys/vendor/amphp/amp/lib/NativeReactor.php(214): Amp\NativeReactor->selectActionableStreams(0.0975)
#6 /app/aerys/vendor/amphp/amp/lib/NativeReactor.php(71): Amp\NativeReactor->doTick(false)
#7 /app/aerys/vendor/amphp/amp/lib/functions.php(46): Amp\NativeReactor->run(Object(Closure))
#8 /app/aerys/vendor/amphp/aerys/bin/aerys-worker(56): Amp\run(Object(Closure))
#9 {main}

I'm not able to reproduce this with current master given your instructions.
Your lua script definitely works according to the debug log, but I get no such exception...

@bwoebi, thanks you! Hmm... I will check with latest master

I'm also didn't succeed on my Mac. It is only reproducible using my Docker image. It is reproducible under different PHP versions. I guess it might be related that I'm running everything inside docker under root user. I will check.
To reproduce run in console:
Get docker image:
docker pull dmitrybalabka/aerys-benchmark:php70

Run server:
docker run dmitrybalabka/aerys-benchmark:php70 php -n -c ./php/default-opcache.ini ./aerys/vendor/bin/aerys -w 1 -c ./aerys/server-wo-timeout.php --worker-args="-n"

In other console:
Get image id that is currently running:
docker ps

Run benchmark:
docker exec -it <image id>   ./bin/wrk -t1 -c100 -d1s --latency -s ./report/pipeline.lua http://<IP_ADDRESS>:8080/

After benchmark was finished you will see in first console exception.

Yay for system dependent bugs … I'll investigate, thanks.

Could reproduce it too in my Debian VM, thanks; looking now.


Dependency major version upgrades

Bumps a number of dependencies that were out-of-date due to them dropping Node 8 support.
I ran Prettier over the repo as we've updated Prettier's major.

If we update chalk, we'd need to update its usage here as well.
-new chalk.constructor({level: 1});
+new chalk.Instance({level: 1})

And wouldn't chalk >= 3 break IE11 again? See https://github.com/facebook/create-react-app/issues/8405

@ianschmitz ianschmitz
Why were you able to update chalk?
What about 5b80f55


Create proposal/pitch deck

[x] Create a document containing the pitch text (or longer proposal text)
[ ] Create a pitch deck

(this is blocked by #1, #2)

proposal is in the planning doc "Ask your Climate - Planning doc" in drive. We aren't creating the pitch deck yet.


Fix final problem for Issue: https://github.com/bcgov/identity-kit-poc/issues/62

This fix is intended to resolve the "flow" problem of issuing a credential. The app would not always wait for a credential to be accepted.
Adjusted status to wait for request_received for the issue_credential webhook controller in order for the app to display the correct status.
Adjusted app so that when a new credential is requested by the same user they will have status reset to consumed rather than issued.

I love that this is the "final" problem.  Bold!  :-)


iina: 1.2.0 -> 1.3.0

Description of changes
https://github.com/iina/iina/releases/tag/v1.3.0
IINA v1.3.0 has HDR support for 14"/16" Apple Silicon Macbook Pros, and fixes a wide variety of crashes and bugs.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@arkvim


Landscape Auth Picker

Is it possible to lock the FUI Auth Picker to a orientation.
Any chance to redesign the landscape layout, now with TOS & PP, doesn't look good, see attached
Thank You

Yup, the fix is already targeted for 4.1. A snapshot build might be available tomorrow depending on how things go.


fix: fix youtube embed

Pull Request Test Coverage Report for Build 463094119

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 74.1%

Totals

Change from base Build 461264981:
0.007%

Covered Lines:
1661

Relevant Lines:
2045

💛  - Coveralls

Pull Request Test Coverage Report for Build 463094119

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 74.1%

Totals

Change from base Build 461264981:
0.007%

Covered Lines:
1661

Relevant Lines:
2045

💛  - Coveralls


Errors when importing rsgislib.segmentation on NCI

We're getting the following error when trying to load rsgislib on the NCI (for both module load dea/20191127 and module load dea .
This package is used in the Image_segmentation.ipynb notebook, which worked correctly in December 2019 but now breaks when run on the VDI.
from rsgislib.segmentation import segutils
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-65266bf9980b> in <module>
     10 from datacube.helpers import write_geotiff
     11 from skimage.segmentation import quickshift
---> 12 from rsgislib.segmentation import segutils
     13
     14 sys.path.append('../Scripts')
/g/data/v10/public/modules/dea-env/20191127/lib/python3.6/site-packages/rsgislib/segmentation/__init__.py in <module>
     26
     27 # import the C++ extension into this level
---> 28 from ._segmentation import *
     29 #import warnings
     30 #
ImportError: libCGAL.so.13: cannot open shared object file: No such file or directory

This worked as of

Notebook has been updated to no longer be compatible with the NCI environment (see #583). If rsglislib gets fixed in the future, we can update its documentation


chore(main): release 0.13.0

:robot: I have created a release beep boop
0.13.0 (2023-09-26)
Features

e 1-9 opens editor in group (#153) (caa9510)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/MarcoIeni/glimpse/releases/tag/v0.13.0 :sunflower:


📉  PowerBI in AP: Implement requirements for PowerBI Gateway

User Story
As a user of Analytical Platform, I would like to be able to publish visualisations of my AP data using PowerBI Gateway
Value / Purpose
PowerBi is the preferred tool for this purpose across MOJ and has a high rate of adoption across the org, so being able to use it would improve AP customers' experience.
Useful Contacts
@julialawrence
User Types
Analytical Platform Users
Proposal
This story captures the implementations of the authoring workflow drawn here: https://mojdt.slack.com/archives/C062MEEF5SQ/p1699457775225609?thread_ts=1699456879.652999&cid=C062MEEF5SQ

Components to create are as follows:

IAM Policy mirroring that of the alpha role of the master author.
Github Team in the ministryofjustice org.
Permission Set mapping the team to the iam permissions defined in the policy
Document to provide instructions to the users about configuring Athena connectivity in PowerBI Desktop using AWS ODBC driver

There are complicated factors about how the iam policy is to be managed since we can't simply use the same IAM policy object as that is defined as an inline policy. Meaning, as part of the work, we need to consider how to keep the iam policy used by the permission set aligned to the alpha role permissions.
Additional Information
The workflow mentions a critical assumption that all readers/authors of the report have the same set of permissions. This assumption isn't correct, however, the requestor will appoint a master author of the report who will have access to the full data and then will utilise capability native to PowerBI to partition the report with smaller subsets of data. As members of the DPAT team, we are not implementing that portion of the solution: that will sit with the customer.
Definition of Done

[ ] IAM Policy complications resolved
[ ] IAM Policy defined
[ ] Permission set defined
[ ] Github Team defined
[ ] Document authored
[ ] Tested with Customer (build a Windows EC2 if needed)

Need more clarity on who the point of contact and master owner is.

Hey @julialawrence  - sorry about the delay - we have four github usernames from Finance in order to copy permissions.  Hope i'm putting this in the right issue for you.
Their names and associated usernames are:
Winnie Sibanda: clr65o
Mark Bettis: MBETTIS
Daniel Ukponmwan: sov67j
Hasaam Khan: gzm57i
I told Winnie that they will (likely, though i'm not sure) have to make requests for Power BI desktop (if they don't have already) and the ODBC drivers.  Please advise as and when it's necessary.

Hi @julialawrence - Anis asked me to additionally add usernames from Data and Analytics engineering teams:
myself andrewc-moj
Gwion Aprhobat gwionap
Ben Waterfield benwaterfield
Phil Hall phil-hall-moj
Chris  Sheldon Csheldon155

me and @Gary-H9 have picked up this ticket
we've so far in analytical-platform-development:

created an IAM role (arn:aws:iam::525294151996:role/powerbi-desktop)
created an EC2 keypair (key-05900ca440f153e4b)
created a Windows Server 2022 instance (i-0af7f05db86af254a)
connected via SSM
installed PowerBI Desktop
installed Amazon Athena ODBC

Note: We need to destroy the click'opsed Windows EC2 instance in data-platform-apps-and-tools called powerbi-desktop. Added to Definition of Done.

Moving back to blocked as unclear how to proceed, work has been done but can't find any documentation

Initial work done on team configuration in terraform was in this branch.

Awaiting details from Gwion as per this thread. When these are provided they need to be added to this branch - add-powerbi-author.

If we don't get ublocked by end of sprint, these go to the backlog and another story raised to test with DMET. Testing is 1 meeting for 2 hours.


keypad back button doesn't remove

this lib is very good effort and work fine but I can't remove. back button on keypad don't make anything
and this method doesn't work
editCodeView.clearCode();

Same problem here

Please will you make any update to close this issue ?

@MohamedHamada12 @iurysza Hi. You could now test a new version 1.0.4 with this fix. Thank you for pointing out this issue.


Update the message used to detect the invalid MP/EE versions.

Need to insert the version number as a result of recent change.

Fixes #1579


Extend the legend based on styles/tags

In order to avoid high textual pollution, I use different styles for technologies or special component "styles".
For example, a blue dashed arrow means https. It would be useful to add such custom notation to the legend (based on tags), for example by adding a property to the styles:
    styles {
        relationship "https" {
               c4plantuml.legend "HTTPS Connection"
         }
    }

Support for dashed arrows was missing, so I've added it, and they will now show up in the legend as expected. Here's an example:
workspace {

    model {
        a = softwareSystem "A"
        b = softwareSystem "B"

        a -> b "Makes APIs calls using" {
            tags "HTTPS Connection"
        }
    }

    views {
        systemLandscape {
            include *
            autoLayout
        }

        properties {
            c4plantuml.tags true
        }

        styles {
            relationship "HTTPS Connection" {
                color #0000ff
                style dashed
            }
        }
    }

}

Dotted lines also work now too.

Awesome!


Authentification for stashes from remote url (Feature request)

in this function for remote url
pub async fn try_fetch_stashes_from_remote_url(
) -> Result<Option<Vec<String>>, CrunchError> {
    let config = CONFIG.clone();
    if config.stashes_url.len() == 0 {
        return Ok(None);
    }
    let response = reqwest::get(&config.stashes_url).await?.text().await?;
    let v: Vec<String> = response.split('\n').map(|s| s.to_string()).collect();
    if v.is_empty() {
        return Ok(None);
    }
    info!("{} stashes loaded from {}", v.len(), config.stashes_url);
    Ok(Some(v))
}

I would like to use some kind of authorization with this feature
e.g.
    [...]
    let client = Client::new();

    let user: Option<String> = &config.stashes_url_user;
    let password: Option<String> = &config.stashes_url_password;

    let response = client
        .get(&config.stashes_url)
        .basic_auth(user, password)
        .send();
   [...]

nevermind, remembered that you can include basic auth inside URL


Add Automatic conversion Support (POJO to/from String) for FIFO SQS Queues

Solves gh-372 .
Would like to thank @eddumelendez  for giving me his opinion on first draft and suggesting some changes.

The main issue is that we do not support properly FIFO queues even if the conversion is fixed. SQS integration works in a way that it fetches the batch of messages and puts them to handlers where each works in different thread, and messages are processed in parallel. If we have more than one message belonging to the same group id, we do not guarantee the order.
This is why I wouldn't really focus on this at all at this stage. We just don't support FIFO queues. For 3.0 we will need to rewrite everything to AWS SDK v2, and this will be a great opportunity to start supporting FIFO queues.

I agree. We are losing main point of SQS FIFO which is ordering. I suggest we close this PR then since changes will be introduced in 3.0. and this code will be dropped then. Not sure if it is correct way to mb deprecate current impl in 2.3.x and force switch to new impl in 3.0, just suggestion? Wdyt @maciejwalkowiak ?

We can't deprecate current implementation without having a new one. I agree. Closing this one, we will revisit the topic in 3.0


go_1_18: init at go1.18beta1

The go 1.18 beta1 is out. It appears to be building fully (and
suprisingly quickly too - :) ).
I trimmed a couple patches which referenced golang issues which had been
closed.

Motivation for this change
One of the important things to do for go betas, is to actually use them to find bugs. By landing this early, this allows nixos users (like myself), to easily update their packages to use go1.18beta1. It also means that when go1.18 is released, we can just do a version bump.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

--- pkgs/development/compilers/go/1.17.nix
+++ pkgs/development/compilers/go/1.18.nix
@@ -54,11 +54,11 @@

 stdenv.mkDerivation rec {
   pname = "go";
-  version = "1.17.6";
+  version = "1.18beta1";

   src = fetchurl {
-    url = "https://dl.google.com/go/go${version}.src.tar.gz";
-    sha256 = "sha256-TcG78/9h8MH/Kxk1Xm2IFRpwEmJopHx2FHdobvlHSMg=";
+    url = "https://go.dev/dl/go${version}.src.tar.gz";
+    sha256 = "sha256-QYwCjbFGmctbLUkHrTpBnXn3ibMZFu+HZIZ+SnjmU6E=";
   };

   # perl is used for testing go vet
@@ -166,17 +166,10 @@
     ./ssl-cert-file-1.16.patch
     ./remove-test-pie-1.15.patch
     ./creds-test.patch
-    ./go-1.9-skip-flaky-19608.patch
-    ./go-1.9-skip-flaky-20072.patch
     ./skip-external-network-tests-1.16.patch
     ./skip-nohup-tests.patch
     ./skip-cgo-tests-1.15.patch
     ./go_no_vendor_checks-1.16.patch
-  ] ++ [
-    # breaks under load: https://github.com/golang/go/issues/25628
-    (if stdenv.isAarch32
-    then ./skip-test-extra-files-on-aarch32-1.14.patch
-    else ./skip-test-extra-files-on-386-1.14.patch)
   ];

   postPatch = ''

@zowoq  - Sorry don't quite know what you mean by that comment - are you saying we should delete the go1.17 file? Or are you just summarizing the 1.17 to 1.18 delta?

Yes, just summarizing the delta.


Model based cart squashed

Re #468

Current coverage is 58.85% (diff: 84.87%)

Merging #562 into master will increase coverage by 9.10%

@@             master       #562   diff @@
==========================================
  Files            91         94     +3
  Lines          4129       4263   +134
  Methods           0          0
  Messages          0          0
  Branches        430        444    +14
==========================================
+ Hits           2054       2509   +455
+ Misses         2017       1658   -359
- Partials         58         96    +38

Powered by Codecov. Last update 971e6aa...7a24b8a


Added dynamic Github repository cards

Card demo:
https://github.com/saicaca/fuwari/assets/65259076/65e65227-057a-4946-a68c-7e0f27f52526

The part were the card is pressed and the color changes and is maintained like that for a second, is because I maintained the click so the animation can be seen in the video, the timing/transitions corresponds to the click action

Markdown syntax:
[!GITHUB user/repo]
[!GITHUB saicaca/fuwari]

Smaller screens:
https://github.com/saicaca/fuwari/assets/65259076/c66b5775-dfaa-4fa3-ba62-826cdf0c0843
Waiting for github
https://github.com/saicaca/fuwari/assets/65259076/eff3db11-2ed3-4d8d-8c8c-eaf72ab5e389

Thanks for your contribution! This is a very useful feature.
But I would prefer to use the remark-directive to do this, following the generic directive syntax. The syntax will look like:
::github{repo="user/repo"}

I would appreciate your help in implementing this, or you can leave it to me, and I will implement it when I have time.

Thanks for your contribution! This is a very useful feature.
But I would prefer to use the remark-directive to do this, following the generic directive syntax. The syntax will look like:
::github{repo="user/repo"}

I would appreciate your help in implementing this, or you can leave it to me, and I will implement it when I have time.

I will look at that, now that I read about it, using directives make more sense. I never used astro/# remark/rehype, a little new to me. I will look at this when I get some time as I really need to study for some exams

For the GFM admomitions should that also be converted to the generic directive syntax?

For the GFM admomitions should that also be converted to the generic directive syntax?

Yes! I just left a comment there too.

@saicaca Hey do you have any comment on the styling of the card?:
https://github.com/saicaca/fuwari/assets/65259076/12f83a30-a3cb-495c-9d1d-7ef318209662

@saicaca Hey do you have any comment on the styling of the card?:

This style looks good! You don’t need to worry too much about the styling; I will make further adjustments if necessary.😀


Nested Yara matching doesn't work - yr_scanner seems to be not reentrant (Segmentation fault)

New scanner API in libyara (>=3.8.0) generates "segmentation fault" when additional scanning is executed from the callback.
Bug can be reproduced using yara-python:
import yara

with open('sample', 'r') as f:
    sample = f.read()

def yara_cb(*args):
    patt = 'rule ann { strings: $a={%s} condition: $a }' % 'fe fa fe fa'
    y = yara.compile(source=patt)

    for m in y.match(data=sample):
        pass

    return yara.CALLBACK_CONTINUE

y = yara.compile(source="""
rule sth1 { strings: $a = { 00 } condition: all of them }
rule sth2 { strings: $b = { B3 04 8D 7D FC [1094795585-1094795585] BA 03 00 00 00 [1-2] 47 FE CB } condition: all of them }
""")
y.match(data=sample, callback=yara_cb)

Stacktrace (3.8.1, commit 3098948):
#0  yara_callback (message=2, message_data=0x555555be1e98, user_data=<optimized out>) at yara-python.c:730
#1  0x00007ffff67cac65 in yr_scanner_scan_mem_blocks (scanner=0x555555b6ee10, iterator=iterator@entry=0x7fffffffd820) at yara/libyara/scanner.c:460
#2  0x00007ffff67b28ee in yr_rules_scan_mem_blocks (rules=<optimized out>, iterator=iterator@entry=0x7fffffffd820, flags=flags@entry=0, callback=callback@entry=0x7ffff67ae0a0 <yara_callback>, user_data=user_data@entry=0x7fffffffd8c0,
    timeout=timeout@entry=0) at yara/libyara/rules.c:205
#3  0x00007ffff67b299c in yr_rules_scan_mem (rules=<optimized out>, buffer=<optimized out>, buffer_size=<optimized out>, flags=flags@entry=0, callback=callback@entry=0x7ffff67ae0a0 <yara_callback>,
    user_data=user_data@entry=0x7fffffffd8c0, timeout=0) at yara/libyara/rules.c:255
#4  0x00007ffff67afb29 in Rules_match (self=<yara.Rules at remote 0x7ffff7e84620>, args=<optimized out>, keywords=<optimized out>) at yara-python.c:1470
#5  0x000055555564fd57 in do_call (nk=<optimized out>, na=<optimized out>, pp_stack=0x7fffffffd9b0, func=<optimized out>) at ../Python/ceval.c:4586
#6  call_function (oparg=<optimized out>, pp_stack=0x7fffffffd9b0) at ../Python/ceval.c:4394
#7  PyEval_EvalFrameEx () at ../Python/ceval.c:3009
#8  0x00005555556468ca in PyEval_EvalCodeEx () at ../Python/ceval.c:3604
#9  0x00005555556461e9 in PyEval_EvalCode (co=<optimized out>, globals=<optimized out>, locals=<optimized out>) at ../Python/ceval.c:669
#10 0x0000555555676bdf in run_mod.lto_priv () at ../Python/pythonrun.c:1385
#11 0x0000555555671952 in PyRun_FileExFlags () at ../Python/pythonrun.c:1371
#12 0x0000555555670dcd in PyRun_SimpleFileExFlags () at ../Python/pythonrun.c:957
#13 0x000055555562058b in Py_Main () at ../Modules/main.c:645
#14 0x00007ffff7a05b97 in __libc_start_main (main=0x55555561fef0 <main>, argc=2, argv=0x7fffffffddd8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffddc8) at ../csu/libc-start.c:310
#15 0x000055555561fe0a in _start ()

Program received signal SIGSEGV, Segmentation fault.
yara_callback (message=2, message_data=0x555555be1e98, user_data=<optimized out>) at yara-python.c:730
730	      object = PyBytes_FromStringAndSize((char*) m->data, m->data_length);
(gdb) p m
$1 = (YR_MATCH *) 0x4141414141414141
(gdb) call yr_get_tidx()
$2 = -1
(gdb) l
725
726	  yr_rule_strings_foreach(rule, string)
727	  {
728	    yr_string_matches_foreach(string, m)
729	    {
730	      object = PyBytes_FromStringAndSize((char*) m->data, m->data_length);
731
732	      tuple = Py_BuildValue(
733	          "(L,s,O)",
734	          m->base + m->offset,

Access violation is caused by read from 0x4141414141414141. Address was determined by gap boundaries [1094795585-1094795585] in $b.
yr_scanner_scan_mem_blocks initializes thread index in TLS
https://github.com/VirusTotal/yara/blob/309894830a5f9ff8cc22155d7719ea608de7bc9d/libyara/scanner.c#L374
and sets it back to -1 after finished scanning
https://github.com/VirusTotal/yara/blob/309894830a5f9ff8cc22155d7719ea608de7bc9d/libyara/scanner.c#L497
So if we try to perform nested scanning:

Matching is performed for sth1 using outer scanner (tidx=0)
Callback is fired which creates inner scanner for ann (tidx=0)
Inner scanner is destroyed (tidx=-1)
Callback is fired for sth2 with tidx=-1. yr_string_matches_foreach gets first YR_MATCH from string->matches[-1], so match address is read from YR_STRING.chain_gap_* fields

https://github.com/VirusTotal/yara/blob/e748df2139d2fb80dafddd2f4da199e172d73218/libyara/include/yara/types.h#L269-L274
Thanks to @icedevml and @sasza8 who have found this bug and provided minimal test-case which causes crash.

You are correct, YARA scanner is not re-entrant. This is not specific to version 3.8.0, previous versions work in the same way. I'm afraid that the only solution for that is getting rid of the TLS, which would involve a major redesign for very little gain.

We haven't experienced this bug with yara version ~3.7, although we are using nested calls pretty heavily in our setup. Maybe recent refactor of scanner.c caused it not being re-entrant?

Our work-around PoC for now:
import yara

with open('sample', 'r') as f:
    sample = f.read()

deferred_cb = []

def yara_cb(*args):
    global deferred_cb
    # simply don't do any significant job here
    deferred_cb.append(args)

    return yara.CALLBACK_CONTINUE

def actual_cb(*args):
    patt = 'rule ann { strings: $a={%s} condition: $a }' % 'fe fa fe fa'
    y = yara.compile(source=patt)

    for m in y.match(data=sample):
        pass

y = yara.compile(source="""
rule sth1 { strings: $a = { 00 } condition: all of them }
rule sth2 { strings: $b = { B3 04 8D 7D FC [1094795585-1094795585] BA 03 00 00 00 [1-2] 47 FE CB } condition: all of them }
""")
y.match(data=sample, callback=yara_cb)

for args in deferred_cb:
    actual_cb(*args)

This way one could untangle nested calls and thus avoid bug.
If the bug is not easy to fix, then it would be satisfactory to at least have it docummented that scanner is not re-entrant (or maybe even some runtime check?) so others won't run into the same trouble.

Agreed, this should be added to the documentation.

Note added to documentation in 93643141f46dbab8e10055a1f859c29c53a0003a.


Is it compatible with bouncycastle?

I am searching an ECIES algorithm which can work fine both in client and server. My server is using Java, and the algorithm provider is bouncycastle. Is there any sample  encrypting by javascript and decrypting by java?

If it supports ECIES it should be compatible.


new version 5 is weird

youtube detects it

https://github.com/TheRealJoelmatic/RemoveAdblockThing/issues/439


stack_file_name: No such file or directory

How this path is taken? Ive tried:
absolute path within my repo (/docker-compose/{filename}-compose.yml )
Ive tried just the {filename}-compose.yml  when it`s in the root of my repo
ive tried renaming it to docker-compose.yaml and using the default path
ive tried using my full repo link path
Every single one of them ends with No Such File or Directory.
How do i point it to a docker-compose.yaml in my repo to be copied to the host?

How this path is taken? Ive tried: absolute path within my repo (/docker-compose/{filename}-compose.yml ) Ive tried just the {filename}-compose.yml when it`s in the root of my repo ive tried renaming it to docker-compose.yaml and using the default path ive tried using my full repo link path
Every single one of them ends with No Such File or Directory. How do i point it to a docker-compose.yaml in my repo to be copied to the host?

I am not sure about your case, but I had the same problem: No such file or dir.
Then I tried to test it without copy - took an example from here https://shihadeh.dev/actions/Docker-Deployment/ - Compose tab (without copy) and got the following:
Registering SSH keys... Agent pid 9 Identity added: /github/home/.ssh/id_rsa (/github/home/.ssh/id_rsa) Add known hosts Connecting to user@<IP_ADDRESS>[12]()... /docker-entrypoint.sh: line 104: docker-compose: not found
Ip and user are not real here.
My guess it that it cannot establish ssh connection (just the line with "connecting" word and not success output) but continue to execute docker-compose command on the DockerHub machine (where docker-compose is not installed). Maybe the same situation can be in inability to find docker-compose file.
I rechecked all SSH credentials, keys according to docs and did not find any mistake in my config. Difficult to understand the reason without more detailed logs. I think the only way is dive into debugging (using another github action in marketplace).
Maybe I will come back to debug it but now it is quite sad that I was not able to make it work - it seemed to be a trivial action with a little effort to configure. =(

I am able to establish a connection, with this one weird line in the logs
load pubkey "/github/home/.ssh/id_rsa": invalid format

If I specify any value for deploy_path other than the home directory of the ssh user it does not work. If I specify something like /root/ it will put the file in /root/docker-compose.yml and work fine. Looks like it copies the file but doesn't have any logic to run against it if it.


Plan project structure

Decide how to organize the code and what tools/libraries we are going to use for this project. A skeleton can be created once we agree on a plan.
Issues to think about:

how to organize the code
what framework to use
how are we going to test the code
will there be a ci?
what about logging?
what is the plan for input validation and error handling. What are the possible error scenarios?

how to organize the code

I think for organizing, it would be helpful to recognize the components that we have talked about.

Protocol - the API interface that should be implemented by servers that have a feather runtime running on them
Feather API - the API implementation, its responsibility being to invoke the underlying runtimes and adhere to the protocol.
Runtime - The runtime environment that runs some code, maybe has some presets (dependencies, env vars, etc...)

We could split code like this:
feather-python-runtime/
|-- feather_python/
|-- |-- api.py
|-- |-- feather.py
|-- |-- runtime.py
|-- requirements.txt
|-- README.md
|-- Makefile  # or a run.sh ?

feather.py or runtime.py can be directories too, if that may be needed.
I'm still not sure whether we need a separate api.py (only for routing) and a separate feather.py (for invoking runtimes and adhering to protocol), and whether we should have classes for Request/Response/Runtime.
I'm leaning towards having a Runtime class that should implement run and run_tests methods, and always return the stdout and stderr in a standard format (as a tuple or namedtuple, maybe?).
There can be Request, Response objects that we create while parsing request, or before returning a response. We should be able to work using them internally with ease. These would standardize our ways across different input parsing / runtime invocation methods.

I gave it some thought and I am feeling more confident about having everything as classes/objects.
I have this idea:

Runtime will be a class and will expose certain methods for the Feather invoker to use. The invoker (Feather API) is then responsible for converting it to a format that is compatible with the protocol.

class RuntimeExecution(NamedTuple):
    status_code: int
    stdout: str
    stderr: str
    # more relevant fields

runtime.run(code: str) -> RuntimeExecution
runtime.run_files(files: list[File]) -> RuntimeExecution

File can be the same class that is used by Flask.

what framework to use

Let's use Flask. We won't have too many endpoints, we don't need too much magic.

how are we going to test the code

We should have functional tests that test the runtime against the protocol implementation and for python-correctness.
Flask has this: https://flask.palletsprojects.com/en/1.1.x/testing/

will there be a ci?

I don't think there's a need for it immediately, while just starting out. For now, we can get by with running tests manually. I think if we get more contributors, we would need CI.

what about logging?

I doubt how much we'll be needing a dedicated logger (traceback logs should be good enough). But if we do face a need, I think a simple logging.Logger should be good enough. A good pattern would be logger.exception(e) when we need to
not stop an exception from being raised and handle it some other way.

what is the plan for input validation and error handling. What are the possible error scenarios?

We should have middlewares for input validation. We could use one of the tools that we were considering for YAML validation for the problem repository feature (like cerberus).
For error handling we should have subclasses of Exception, with an extra "status_code" that will tell the responding middleware to respond with that HTTP status code. I'm not sure if that is too verbose though.

feather-python-runtime/
|-- feather_python/
|-- |-- app.py
|-- |-- feather.py
|-- |-- runtime.py
|-- requirements.txt
|-- README.md
|-- Makefile  # or a run.sh ?

I think we may not need a seperate feather.py. I suggest having a schema.py or models.py with the classes to model request and response classes for run and test.

runtime.run(code: str) -> RuntimeExecution
runtime.run_files(files: list[File]) -> RuntimeExecution

I think there should be just a single function run and another for run_tests.
runtime.run(req: RunRequest) -> RunResponse
runtime.run_tests(req: TestRequest) -> TestResponse

We should have functional tests that test the runtime against the protocol implementation and for python-correctness.
Flask has this: https://flask.palletsprojects.com/en/1.1.x/testing/

We may need tests to validate the protocol, but we also need unit tests to verify the functionality of the runtime, without involving the Flask component.
For input validation, I recommended going with Pydantic.

I doubt how much we'll be needing a dedicated logger (traceback logs should be good enough). But if we do face a need, I think a simple logging.Logger should be good enough. A good pattern would be logger.exception(e) when we need to handle an exception in some other way.

The point I was trying to make it not so much about logging, but making you think about how would you find when something goes wrong.

I think we may not need a seperate feather.py. I suggest having a schema.py or models.py with the classes to model request and response classes for run and test.

That makes sense. Let's call it models.py to not give the idea of a database schema.

runtime.run(req: RunRequest) -> RunResponse
runtime.run_tests(req: TestRequest) -> TestResponse

I think this is much better! I, too, was having doubts about having two methods to run in the same way.

We may need tests to validate the protocol, but we also need unit tests to verify the functionality of the runtime, without involving the Flask component.

Okay, I was trying not to test details, but I think this would help us better identify where things are going wrong, and it would also be something I can do while building the runtime.

The point I was trying to make it not so much about logging, but making you think about how would you find when something goes wrong.

Ah okay, then I quite liked how Nginx has access.log and error.log. Having all errors logged in one place, separate from rest of the logs would be very good.
We can have a logging.Handler for errors to save that information to a file. (like so: https://flask.palletsprojects.com/en/2.2.0/logging/#email-errors-to-admins)

We would also need an errors.py in the project structure.
errors.py
FeatherException
|-- InputValidationError
|-- |-- ...

Another question to think about: Whether or not we should use typing.
For now, I am going with adding type annotations wherever it will help, and not at other times, only for humans to understand.


Dev to main, watchlist -display as movie cards.

Reinitiate full pull request

Please reinitiate full pull request


Unable to find source repository

I found closed bugs for this issue, but I am still puzzled by it.
I fully understand being able to configure the repository the PRs are made against. But for choosing the source of a PR, surely the only things that matter are that the source repository is on GitHub. And querying the source repository for PRs is wasteful - theres no point doing that at all.

Extension version: Last updated 22/12/2021, 10:09:20
VSCode Version: 1.63.2
OS: Windows

Steps to Reproduce:

Have 2 remotes, one called 'origin' and one called 'myname'
Create a new branch 'foo' and push to github/myname using the vscode sync button
click on create a PR and watch it fail.

@rbtcollins I'm trying to follow your repro steps, but I still see PR creating succeed. Can you share screen shots of how you see it fail to create a PR?

Before syncing

Select my repo to sync to

My repo isn't visible in the create PR dialog 'From' box

old remotes setting:

then

add my source repo (which will never have pull requests on it ...)
cancel the PR creation
Initiate PR creation again
now the from box lists my repo

Thanks @rbtcollins, I see the confusion now.

Works well when the two origins have different owners, ran into #3278 when they're both the same owner.


MIT Lecture on gaussian splatting

It would be great if this course could be included in the tutorials/blogs: https://www.scenerepresentations.org/courses/inverse-graphics-23
The last lecture of module 2 contains an overview of Gaussian Splatting.

That's really great. I will add this. Thanks for this link!

Added. Thanks again!


Internal Server Error with sample script

I have verified that I am using the correct parameters to upload a sample CSV, but I receive an Internal Server Error using sample_script.ps1. Does anyone still use this to upload a CSV?
Failure with StatusCode [InternalServerError] and ReasonPhrase [Internal Server Error]

Bug addressed by Microsoft


[bn] Localize content/bn/docs/tasks/tools/included/_index.md

Signed-off-by: Arindam Majumder<EMAIL_ADDRESS>Localizes content/bn/docs/tasks/tools/included/_index.md to Bengali
This is an initial PR as may need some improvements!
Tracking issue: https://github.com/kubernetes/website/issues/31677

Hey @Arindam200  , Our approvers for Bengali localization are @rajibmitra  and @mitul3737  & @Imtiaz1234  . After creating a PR, feel free to knock us on Slack or mention us.

tide/merge-method-squash

/label tide/merge-method-squash

/language bn

Ok sir I will do that!