TCC keep crashing

As in title,its 100% crash if  i invite more than one person to party. I have everything updatet do newest verson, pls help .
error.txt

You probably have no GroupAbnormals in tcc-config.xml (or you don't have the class="Common" one). Close TCC and delete everything from <GroupAbnormals> to </GroupAbnormals> in tcc-config.xml. Then restart TCC and it should create default values.

ughh my tcc config looks wierd, i dont even have , i can see only

i can't attach my config, because format is not suported

Delete <GroupAbnormals/> and restart TCC then

usually i deleting my whole config,with launching TCC  because of black square's on desktop, they are always ther when i close and open tcc with no delete config file.

Black squares means that you disabled transparency on some windows. You have to enable it and restart TCC.

it help witch party crashing, thank you. So its mean im forced to use transparency, right ?

Transparency setting was added for some people who wanted to stream with some software which didn't see transparent windows. It should be kept always on.

Oh, thank you very much for fast response and help, its working good now,


Add option to select record language

Since implementing https://github.com/dini-ag-kim/lrmi-profile/issues/18 the JSON Schema for the default LRMI profile expects a default language in the context, e.g. {"@language": "de"}.
In the editor, this could be added with a dropdown right over the web form, where you can choose a language. In the JSON, this would then set the default language with the respective language code in the @context.

The relevant part of the JSON schema is https://github.com/dini-ag-kim/lrmi-profile/blob/898c01232dcc39db2d56dea8f3f9e18770c399e8/draft/schemas/schema.json#L12-L35

Duplicate of #32. Closing.


Setup CI

.

Just a simple e2e test for the todo example is enough

Running on Travis now. :tada:


ipfs-desktop on Windows always errors, never starts ipfs on login

OS: Windows 10
Version of IPFS Deskop: 0.22

Describe the bug
I have had the IPFS Desktop installed for a while, and was wondering how I could make it start IPFS on login. Turns out that this is supposed to be an actual feature. Well, it never worked unless I manually started the daemon. Meaning, that IPFS Desktop on my Windows maschine has thus far never brought up IPFS itself ever.
To Reproduce
I honestly wish I knew what led to this bug. All I did was to install it via Chocolatey and whilst installing an update, I selected "Only for myself".
Expected behavior
I expected to have an IPFS node running whenever I log into my Windows.
Screenshots
None, except the "IPFS has errored" message.
Additional context
None that comes to mind.
error.log

@IngwiePhoenix Thanks for bringing this to our attention. Could you also attach the combined.log file?
It looks like you're on the latest version of IPFS desktop, so that's great. However, it sounds like you're saying that when you start IPFS Desktop, you have to start the ipfs daemon manually, or is it that you need to start the IPFS Desktop application manually?
IPFS Desktop is supposed to enable launch on startup automatically, as you can see at https://github.com/ipfs/ipfs-desktop/blob/e16b1e7374b0d614c4bd2416b7b75cd58f45d85e/src/auto-launch.js#L86. We should be able to see what's happening once we get your combined.log file.
Is IPFS Desktop listed as a startup app? Could you share a screenshot showing as much? Or you could provide the full terminal output of running either of the below commands:
Windows cmd/batch
wmic startup get caption,command

Powershell
Get-CimInstance Win32_StartupCommand | Select-Object Name, command, Location, User | Format-List

If IPFS Desktop is not listed there, you may need to add it to your list of startup applications manually for now.

Thanks for providing the combined.log. It looks like this code is being called multiple times, which means the configuration isn't being saved properly. We will need to investigate this further.
Steps to troubleshoot:

Try to restart desktop

Is IPFS-desktop failing to run the daemon only during startup, or all the time?

Start binary for daemon that is bundled with IPFS-Desktop manually using CLI

C:/Windows/Users/$user/AppData/Local/Programs/IPFS Desktop/ should contain the binaries (file locations are called out here: https://github.com/ipfs/ipfs-desktop/issues/1656#issuecomment-704979096)
Can you manually start the exact binary that IPFS-Desktop uses and cannot start?

@IngwiePhoenix we don't have the bandwidth to investigate this further at this moment but if you can provide further information so it can be looked into when someone has time that would be very helpful.


Need to add the configuration details of changing the username and the password in analytics documents

Description:
We need to add the configuration details of changing the username and the password in analytics documents. We are able to find those details in the SP documentation [1]. But we have missed them in the analytics documentation [2].
[1] https://docs.wso2.com/display/SP430/User+Management+via+the+IdP+Client+Interface
[2] https://docs.wso2.com/display/AM260/Working+with+Analytics
Thanks,
Rizmeer

We will not be fixing this as this issue is based on an older version of the product.


Database Provisioning in Flyway

We explored ideas around database provisioning in flywaydb.org/blog/flyway-provisioning . Would this be a useful feature for you? How would you like to see it working? Please feel free to submit ideas, comments or just give us a thumbs-up.

Simplifying integration testing scenarios with Flyway out of the box would be very good. I like to able to have various of types of data stets in different dirs and then run tests and have fly apply the data sets as part of the execution of the tests but not have the test data be part of the migration scripts that get shipped.

Simplifying integration testing scenarios with Flyway out of the box would be very good. I like to able to have various of types of data stets in different dirs and then run tests and have fly apply the data sets as part of the execution of the tests but not have the test data be part of the migration scripts that get shipped.

@asaikali This should already be possible by specifying multiple entries in flyway.locations. It's a similar concept to the "database-specific sql" FAQ answer. This use case is also describe in this blog post and also in this GitHub question


Possible alternative to grab bag

This is gonna seem like a non-sequitur at first...
In the logger example here, all traps trigger a log, but not all invocations of internal methods of the target which have corresponding traps will be logged. Reflect.set may end up calling target[[DefineOwnProperty]], but will do so without also triggering the defineProperty Proxy trap.
The reason I point that out is cause I think it implies that there’s no requirement that a given trap represents the “end of the line.” The relationship between set and defineProperty could be instructive for this problem because it suggests an avenue where the contract for preventExtensions doesn’t change at all.
Could [[PreventExtensions]] be redefined as calling two other internal methods, [[FreezePrototypeOf]] and [[PreventPropertyExtensions]]? These would each obtain distinct new Proxy traps. Existing code using the preventExtensions trap would not be impacted — plus it would continue to be the more useful trap to use for most cases, and people would only implement the more “granular” traps when they are specifically needed.
This seems cleaner and less error-prone to me than an options grab bag, but I haven’t investigated it deeply and maybe have missed something that makes this approach not viable.

I wrote a spec draft in https://github.com/tc39/proposal-freeze-prototype/pull/4, which instead uses the [[GetExtensibility]] and [[SetExtensibility]] internal methods, which uses the new getExtensibility and setExtensibility proxy traps and Reflect methods, with a backwards‑compatible fallback to the existing isExtensible and preventExtensions proxy traps, which are only used if getExtensibility and setExtensibility don’t exist.


Modify the release candidate container to work for both daffodil and vscode

When running the release candidate script, prompt the user for either
"daffodil" or "daffodil-vscode" to determine which repository to
release. This changes which repo is checked out, how the repo is
built, and which files are copied to the dist directory. All other
automated build steps are common and are unchanged.
Daffodil release files are still installed to dist.apache.org/repos/dist/dev/daffodil/
VS Code release files are installed to dist.apache.org/repos/dist/dev/daffodil/daffodil-vscode

Also did some cleanup to the container script:

Move wix files and Docker setup/entrypoint scripts out of /root and
into /opt and /usr/bin, respectively. With this change, the only files
in /root are build files, making it easier to verify release artifacts
Add the --rm option to podman run. This container is short lived and
does not need to exist once it finishes

DAFFODIL-2655

Once this change is committed, this container will not really be specific to daffodil anymore. I wonder if it makes sense to move the container directory to its own repository (e.g. apache/daffodil-release-candidate)? That way, if we ever need to make changes to the container for the vscode repo we don't have to make changes to this somewhat unrelated repo?

I don't think a separate repo makes sense (apache/daffodil-release-candidate).  I have 3 reasons: 1) we're talking about moving only 5 files which hardly justifies a separate repo at the Apache organization level; 2) the path daffodil/containers/release-candidate is much easier to understand than the repo name daffodil-release-candidate; 3) newcomers will feel more confused and waste more time trying to understand 3 daffodil-* repos than only 1 to 2 daffodil repos.

Fair points. I don't feel strong about this and am fine with keeping it in here.
Here's some additional thoughts in the back of my head, but which I don't think are all that strong of arguments since they're very future stuff and probably doesn't really apply right now:

This is almost generic enough that it could be used for other apache projects. I sort of envision this repo growing to be a possible starting point for other projects to create their own release candidates. I know it was a pain to come up with all this stuff in the past, and it would be a shame for other new ASF projects to have to do something similar. That said, I doubt I'll want to do the work to make this truely generic. But if it were in a separate repo, others might.

I could imagine a case where the daffodil repo is on some sort of code freeze but we want to make changes to the release candidate stuff for vscode (or maybe some other future project). By decoupling this release candidate container from any particular repo, it's easier to make those changes. That's not an issue now because we don't really code freeze, except maybe unofficially near releases, which aren't common.

And maybe a potential argument against:

It now requires a bit more effort to keep a third repo in sync. When building a release, we must ensure that the release manager uses the latest daffodil-relase-candidate repository or there might be subtle build issues. Theoretically either the build would fail, or it would be detected as part of the VOTE, so maybe not too big of a deal. But is another point of failure. That said, it's maybe not too different from our current method, where you should build from the latest Daffodil commit. For example, people that primarily do daffodil-vscode development have to clone the daffodil repo to do a release. Not a big deal, but might be a repo they don't always keep up to date.

I am ok with leaving it in Daffodil's source tree for now. That works because these release scripts/containers aren't actually part of a release. They're not distributed.

This still needs another +1


Install error on debian 10

Without this, it can be installed on a newly installed version of debian 10. One line is enough to fix it.

Did you have a KVM ?

yes

The script currently works fine on Debian 10


kha.graphics4 support in java backend

It would be really nice to have a GL/3D capable graphics4 backend for java (i think it's nicer to write and debug in java for android, and also have the same code work for desktop).

We already have that for Android-Java.


[system] theme styleOverrides overwrites component api prop "color"

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
assume I set
MuiLink: {
    styleOverrides: {
      root: {
       color: '#0068a9', // blue
    },
  },

in the MUI theme components section
and later in my code I want to set some custom colors through Link's color prop
<Link color='#a8adb3'>grey</Link>

I get a the blue from the theme instead.
I would expect the component prop color to take precedence over the  MUILink setting. But it is actually the opposite.
When looking at the css in the <style> tag, the colors are set, but apparently the MUI theme settings get appended.
screens from my local example - links should be grey but are blue

BTW this is another interesting bug - styles get appended instead of merged.
Expected behavior 🤔
properties should have precedence over MUI theme settings in order to be able to be able to easily customize
Steps to reproduce 🕹
Steps:

Context 🔦
I've implemented the design tokens for the Link component - this would be the default for white background. But our design has also a dark background, where the links are in another color. So the idea was to set either "color" or sx prop, but I wasn't expecting this
Your environment 🌎

`npx @mui/envinfo`
System:
    OS: macOS 12.2.1
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.0/bin/yarn
    npm: 8.1.0 - ~/.nvm/versions/node/v16.13.0/bin/npm
  Browsers:
    Chrome: 99.0.4844.51
    Edge: Not Found
    Firefox: 97.0.1
    Safari: 15.3
  npmPackages:
    @emotion/react:  11.7.1
    @emotion/styled:  11.6.0
    @mui/base:  5.0.0-alpha.72
    @mui/icons-material: ^5.4.2 => 5.4.2
    @mui/lab: ^5.0.0-alpha.73 => 5.0.0-alpha.73
    @mui/material: ^5.5.1 => 5.5.1
    @mui/private-theming:  5.4.4
    @mui/styled-engine:  5.4.4
    @mui/styles: ^5.5.1 => 5.5.1
    @mui/system: ^5.5.1 => 5.5.1
    @mui/types:  7.1.3
    @mui/utils:  5.4.4
    @types/react: ^17.0.16 => 17.0.16
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    styled-components: ^5.3.3 => 5.3.3
    typescript: ^4.3.5 => 4.3.5

Hi.
If you try <Link sx={{color:'#a8adb3'}}>grey</Link> instead of <Link color='#a8adb3'>grey</Link>, the color you passed to sx will override.
Here is a working solution: https://codesandbox.io/s/brave-paper-umxiko

@hbjORbj  hi - yes I was using sx props in the end - but I still consider this a bug because setting a prop should have priority over a theme. Thats a really confusing behavior.

Hi.
If you use styleOverrides, we expect that you won't use individual style props like color very often. For the rare cares that you need to tweak, you can use sx prop. If you use individual style props like color a lot, that's a sign that you didn't need styleOverrides in the first place.

I see - thanks for the explanation.
Is this documented ?

I guess we could improve our approach here. I would also expect prop customization to be able to override the theme, just as the sx prop can. Both seem like a viable option to do one-off, local, customizations. Why would one prefer the sx prop in favor of using color in a component that has it? Also, why does the sx prop work but using the prop doesn't? That's not clear to me too. It seems we're lacking this reasoning in the How to customize article.

If you use individual style props like color a lot, that's a sign that you didn't need styleOverrides in the first place.

Or a sign that you didn't know you should use styleOverride in favor of always locally editing a given prop. The reason to that lack of knowledge could also be a sign to improve documentation.

I thought that styleOverrides overriding individual props is quite obvious, but actually we could question that.
@mnajdova Was there some reasoning behind why individual style props doesn't override styleOverrides but sx does?

Or a sign that you didn't know you should use styleOverride in favor of always locally editing a given prop. The reason to that lack of knowledge could also be a sign to improve documentation.

I agree with this.

Theme overrides are global overrides applied on top of the component's styles, it is basically a replacement for invoking styled(SomeComponent). On the other hand sx prop is instance override, meaning it adds override on one specific component's usage, which is more specific then a global override. This is why they behave differently. Basically we have this order of overrides being applied:

Component's styles
Theme styles
sx props styles

which is more specific then a global override

I think I'm still missing why the component's own styling props aren't as specific as the sx prop. If I have customization on a theme level, either sx={{ color: red }} and color="red" should work to customize it. Or not? If so, why?

How would you define in the style overrides then styles that would override when color="red" is applied as prop? Note that we plan in v6, to no longer support the style overrides per props, so you would only have:
styleOverrides: {
  root: ({ color }) => ({
    ...(color === 'red' && { /* some overrides */ }),
  })
}

Developers can define the styles however they want here, and they will be applied on top of the styles coming from the component. It is the same as using the styled() utility.
// The custom button will always have a pink background
const CustomButton = styled(Button)({
  background: 'pink'
});

cc @siriwatknp mentioned on some issue that we may want to increase the specificity for styles applied based on props, but in my opinion that would make the DX for customizing much harder.

Basically we have this order of overrides being applied:

Component's styles
Theme styles
sx props styles

I think there should be "default theme styles" at the beginning of the list 🤔
It would be great to have this list in the docs customization pages

Yup, agree! 👆
What I'm trying to uncover here is the reasoning behind the facts, not necessarily asking for anything to be changed (from a feature perspective). Why component props doesn't have the same specificity to override styles as the sx prop? I feel like that's not clear and we should explain it in the docs — the point of this issue. (@aaarichter as a contributor/user was not aware why as well).
My mental model is that customizing styles via component props is a one-off customization, just like the sx prop, since these styles won't be perpetuated to any other instance of that component. Maybe we should include something in the One-off customization section of the How to customize page, explaining if that is right or wrong and the whys.

@mnajdova @danilo-leal I think this is about the naming confusion. The Link component requires color prop to be the key of the palette (primary | secondary | ...), so the output styles can be more than CSS color property (it could be background, border, shadow, etc). However the color in sx prop targets specifically to CSS color.
<Link color="primary">...</Link> // the output can affect color, :hover state, etc.
<Link sx={{ color: '#ff5252' }}>...</Link> // you want to force only the CSS color to be #ff5252

So both are different depending on the result you want.
But the more confusing part is that Typography can accept any color which is different from the Link.
<Typography color="primary">...</Typography> // works
<Typography color="#ff5252">...</Typography> // works

In my opinion, we should be very clear about the color prop and sx={{ color: '...' }}, then add the docs somewhere. (Typography should not combine them)

@siriwatknp That's very important information to disambiguate! I have reopened the issue and will open a PR adding this info to the How-to-customize page in order to close it again.

@danilo-leal I think misunderstood the Link component (just found out that it inherits Typography) 😢. Let me dig deeper and find what causes the issue.

Updated the issue title and label since this is a bug on the Link component (not related to system)

Why aren't we allowed to do this, and is there an alternative?
is sx the alternative - the way to use custom colors outside the palette?
const theme = createTheme({
  link: {
    signout: "#fd6342",
  },
  palette: {
    primary: {
      main: "#fff",
    },
    secondary: {
      main: "#000",
    },
  },
});


Hi, Would you like to submit the code?

We are planning to submit our code before the conference begins. Please wait for our update!
After the update, We'll mention our update here and close the issue.

@pengzhangzhi We have updated our code.

Thanks for sharing.


Removed peerDependency since this package does not use it

This package does not use mongoose or require it anywhere.  We should definitely remove it as a peer dependency.  The README should be read by end-user to ensure they are using proper version.  We should not enforce users, especially power users, to go an extra step to include mongoose as a dep in their main package.json file if it is not necessary.  With the current peer dependency this extra step is needed.

Hello @niftylettuce! Thanks for your suggestion and your contribution. However, unless I am mistaken, mongoose is being required here: https://github.com/matteodelabre/mongoose-beautiful-unique-validation/blob/master/index.js#L3.


Event for player/group meta changes

I'd find such events extremely good for my scoreboard-based nametag prefix plugin. Polling isn't that good option for it in my opinion
Imagine this scenario:

/lp user mikroskeem meta addprefix 0 "&c&lOP" or ... meta set shortranks_prefix "&c&lOP&4 "
Event gets fired and plugin listens for given event
Scoreboard plugin updates scoreboard prefix(es)

// enhancement

Actually I can fetch meta changes using permission node set/unset events, since metadata is stored as permissions.
Now question is that is it worth to add separate event for meta changes

Yeah, I'm trying to plan out a restructure of the event API to make that clearer.
The current system was a bit rushed, and isn't very expandable.

Question is though, is it finally time for a breaking API change (removing and replacing the current event package) or should I try to keep the old one?

I think you can go for breaking API change, I don't mind

Should be resolved by 6798fb21b2e73782d086239d3d4eb25740fb6c45
I'll update the documentation soon, for now, here's the class you need to register your listeners.
https://github.com/lucko/LuckPerms/blob/master/api/src/main/java/me/lucko/luckperms/api/event/EventBus.java


TypeError: Cannot read properties of undefined (reading 'removeEventListener')

I'm getting this issue while changing the page, kindly provide the solution for this one..

#64 Duplicate


Fix filtersToSQL output when IN filter has numeric values

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 70.326%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
1142

Relevant Lines:
1529

💛  - Coveralls


Re-Adding Dawn Wallet

Woops on the previous commit. Here's Dawn Wallet!

@jaymeh13 - thanks for this, I reverted the commit after merging it initially because it looks like some data is inaccurate (e.g. the type being Safe, availability in browser, etc.) - have added Dawn to the list of wallets to check and add soon though :)


fixes Cannot read property 'onAction' of undefined

Hey there,
props will be undefined if useGesture() is called without arguments, which will cause any code inside handlers to choke on accessing any property on props
codesandbox repro here

Thanks, released it under 2.0.4


Create new API command: ConnectBankAccountManually

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/226849
Tests

Log into your account in NewDot. If you don't have a workspace, create one.
Go to Settings>Workspace>Connect Bank Account:

Select "Connect Manually"
Enter a valid routing/account number
You should be taken to the next step.
Repeat Up to step 4, but enter the same number in both fields. An error should show up:

Repeat 1-3 and go offline. The button should get disabled:

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps
Same as tests. It'd be nice to ping someone with a Chase account that can test the following:

Log into your account in NewDot. If you don't have a workspace, create one.
Go to Settings>Workspace>Connect Bank Account
Select Connect with Plaid and follow the steps to connect your Chase bank account via Plaid.
After the process is completed, you'll be taken back to the Connect Manually flow (Chase is a special case).
Enter the WRONG bank account number. You should see an error
Enter the right one. You should move forwards to the next step.

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

OFF WIP and ready for review!

Comments addressed!

Comments readdressed!

https://github.com/Expensify/App/pull/11162 has been merged on main - please merge main on your branch

OFF HOLD! Ready for review!

LGTM! Could you also add test steps for connecting a Chase bank account with Plaid and verifying that we ask the user to enter the bank account numbers manually

I Added them to the QA section! I don't have a Chase account to test them 🤷

I don't have a Chase account to test them

These are the test credentials for any Plaid banks:
username: user_good
password: pass_good

Merged without contributor+ checklist passing but all other tests succeeded.

I don't have a Chase account to test them

These are the test credentials for any Plaid banks: username: user_good password: pass_good

Chase takes me to an SMS confirmation screen 😬

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

write 1234 :)
On Tue, Sep 27, 2022 at 12:20 PM OSBotify @.***> wrote:

✋ This PR was not deployed to staging yet because QA is ongoing. It will
be automatically deployed to staging after the next production release.
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/pull/10987#issuecomment-1259294234, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AASZRZ4AHHVVTIYJXJBAMTDWALC5NANCNFSM6AAAAAAQMKUON4
.
You are receiving this because you commented.Message ID:
@.***>

🚀 Deployed to staging by @MariaHCD in version: 1.2.8-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.2.8-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Support for webm captures, to be used from devtools console (no UI).

Hi doxas,
Do you want this? It just exposes the capture (formerly captureGif) function to the global namespace and passes format, framerate and quality args to CCapture.
It defaults to the old values so it shouldn't change existing behavior and there's no UI, so if you want to merge we should probably add a few lines to the readme and/or help text.
To capture 20 seconds at 960x540 and 50 FPS as a webm file open devtools' console and enter
TWIGL.capture(1000,960,540,'webm',50,100);

(In Chrome. In Firefox it crashes the site with Uncaught Couldn't decode WebP frame, does the browser support WebP?)
It's useful for me, but it's a quick and very dirty hack so if you don't feel like merging it as-is I won't be offended in any way :)

@yonatan
Hi yonatan.
Thanks for Pull request.
This is so good idea.
If you're willing to wait, I'll look into integrating it into the UI.

@yonatan
After merging the pull request, I made a few changes and deployed it.
Thanks for the great suggestion!


guided-tour / traduction

hello team,
This PR brings traductions to the guided-tour
Paul

this in template should be remove imo

:tada: This PR is included in version 1.4.0-rc.8 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Clean bb-main a little

There's now a lot going on in bb-main. It could stand to be separated a little, I think.

Marking as closed; this is going to be dealt with in the future under tabs, I think.


Support for facebook and linkedin usernames

I'm making modification the a few themes too to support it (if a value exists)

Low risk. Isolated. Only concern is that it's confusing to see options that aren't used by existing themes. Will create a new issue to reference these for next release.

facepalm ...
Just noticed that this was a PR against jb-development rather than master. Merge was unnecessary. Copying more text to #273 for context without having to come to this (closed) PR.


notifier.rb:72-73: Fix git class. Here we got a problem...

The puzzle 13-e3667bac from #13 has to be resolved:
https://github.com/l3r8yJ/gitnotifier/blob/70242ebb4bad34695d16656c37a5d322471c955b/lib/gitnotifier/notifier.rb#L72-L73
The puzzle was created by @l3r8yJ on 09-Dec-22.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd 3 puzzles #24, #25, #26 are still not solved.

@0pdd 3 puzzles #25, #26, #28 are still not solved; solved: #24.

@0pdd 2 puzzles #26, #28 are still not solved; solved: #24, #25.

@0pdd the puzzle #28 is still not solved; solved: #24, #25, #26.

@0pdd 2 puzzles #32, #33 are still not solved; solved: #24, #25, #26, #28.

@0pdd all 6 puzzles are solved here: #24, #25, #26, #28, #32, #33.


[WIP] document endpointslice 'serving' and 'terminating' conditions

Signed-off-by: Andrew Sy Kim<EMAIL_ADDRESS>Placeholder docs for KEP https://github.com/kubernetes/enhancements/issues/1672 and https://github.com/kubernetes/enhancements/issues/1669
EPSlice updates:

add a Conditions section to the EndpointSlices doc
add sections for all conditions Ready, Serving and Terminating.

External Load Balancer updates:

adds a section "Handling of Terminating Endpoints"

/milestone 1.20
/assign @kcmartin
/hold no k/k prs?
/sig network

PR for KEP 1672: https://github.com/kubernetes/kubernetes/pull/92968
Working on the PR for KEP-1669.

Hey @andrewsykim please change the base to dev-1.20 branch

Hi @andrewsykim
Friendly reminder that the deadline for having docs ready for review is coming up on Nov 23rd, right after Kubecon NA. We would appreciate it if you could provide some/all docs content for this feature early so that it can be reviewed by Sig Docs before Kubecon and other events in November.

k/k pr merged
keeping /hold until the base is changed to dev-1.20

Hi @andrewsykim
This doc was for both KEP 1672 and KEP-1669
Even though KEP 1672 k/k pr was merged, KEP-1669 k/k was not merged https://github.com/kubernetes/kubernetes/pull/96371 in time.
KEP 1669 was removed from the 1.20 release, see https://github.com/kubernetes/enhancements/issues/1669#issuecomment-726530900 for details
/hold
Please change the title and description of the pr to only reflect KEP 1672. Thank you!

Hi @andrewsykim
A friendly reminder that Docs "Ready for Review" Deadline is this Monday, Nov. 23rd for the 1.20 release.
Please reach out if you have any questions.

@andrewsykim I'm working on a PR that will likely conflict with this (https://github.com/kubernetes/website/pull/24935). I think everything you have already is safe, but the enabling EndpointSlices page seems like it could get messy. For that reason, I think it might be simplest if I cover both new feature gates in my PR (EndpointSliceNodeName and EndpointSliceTerminating). Let me know if that makes sense to you. If not, I'm happy to pull that part out of mine.

@andrewsykim -- What do you think about Rob's comment above? Do you want him to cover both features gates in his PR and do a review?
Also, please let us know if this PR is no longer necessary, we can close it out. Thanks!

I think what's scoped here is still necessary, I just documented the feature gates that correspond with what's being documented here. Now that my PR is merged in, feel free to change any part of the feature gate docs as well.

Exception requested/granted. PR will be ready for review by EOD Wednesday the 25th

I think what's scoped here is still necessary, I just documented the feature gates that correspond with what's being documented here. Now that my PR is merged in, feel free to change any part of the feature gate docs as well.

Makes sense, I'll leave out anything with feature gates and only focus on documenting the new conditions. Thanks @robscott!

Closing in favor of https://github.com/kubernetes/website/pull/25229

/close


Drivenadapter client ktor 2

Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing
Description

Add new driven adapter KTOR http clien for kotlin
update spring boot version to 2.6.2
update lombok version to 1.18.22
update plugin dependencies

Category

[x] Feature
[ ] Fix

Checklist

[x] The pull request is complete according to the guide of contributing
[x] Automated tests are written
[x] The documentation is up-to-date
[ x The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog

fix error


Use alternate context var for Jinja support

Jinja does not support using self as a template variable, as self is reserved for its own internal use. To add support for Jinja templates, an alternative name has been added where 'self' has been used.  Templat authors are free to use which ever template variable works in their template language.
I have not changed all the internal Wagtail templates, as these are not using Jinja. I have changed the wagtailuserbar templatetag to use the new page variable so  that it can theoretically be used in Jinja as well, although the template tag would need to be added to Jinja first.
This needs to be documented somehow, although I am unsure how exactly to do this. The docs could be converted completely to use the page template variable, as this would work on all templating engines, but this is a big change. Alternately, a note could be added regarding the self/page duplication and which to use when, but this note may need to be added to multiple places in the docs so people do not miss it. Which approach would you prefer?

Should the name for the TEMPLATE_VAR and the PAGE_TEMPLATE_VAR first be retrieved from django's settings and then fall back on these names?

@kurtw: I considered this, but I couldn't see a large enough benefit to make it worth it, but I am happy to be convinced otherwise. How would changing the name of the page template variable site wide help you?

@kaedroho please review. @timheap are you using Jinja in a Wagtail project?

@tomdyson We wanted to use it in a recent project, but couldn't because of this and https://code.djangoproject.com/ticket/24538. Now that the barriers are out of the way, we would be very keen on using Jinja in our next Wagtail project.

@timheap interesting - what would you do about template tags (e.g. image, static)?

@tomdyson I would imagine you include them in the jinja environment.
@timheap Now that I'm thinking about it, I'm leaning towards keeping it as is. It would be great to see some documentation included for clarity and direction on it's implementation with respect possible confusion e.g. including template tags.

@tomdyson I have not investigated implementing the Wagtail template tags in Jinja yet, as Wagtail and Jinja can not be used together until this current issue is merged :) . I think a separate set of template tags will have to be created for Jinja use, but both sets of tags should be able to use the same code to do the heavy lifting - the template tag will just be a template-language-specific wrapper around the actual logic. I intend to investigate this further in another PR in the future.
@kurtw I agree it needs some documentation, I am just unsure how to go ahead with it. As far as I can see, the most reasonable options are:

Rewrite all the documentation to use the new page variable, so the documentation works for both template languages,
Put a note in a conspicuous place saying "Use self in Django templates, but use page in Jinja",
Put a note next to every template example, saying the same as above, or
Provide both Jinja and Django template examples, side by side.

None of the options stand out as a clear winner to me.

Put a note in a conspicuous place saying "Use self in Django templates, but use page in Jinja"

I think this makes most sense, as a first pass at least. Hopefully we'll be in a position to offer full support for Jinja as an alternative to Django templates in the not-too-distant future, but until then, its use will be confined to 'early adopters' specifically seeking it out, and it's reasonable to expect that they'll search the docs for 'jinja' and find the note. Longer term, if Jinja use takes off, then I'd be in favour of slowly phasing out use of 'self' in Wagtail templates.

FWIW I prefer page over self generally.

My 2c: On the one hand self is a var I associate with internal stuff which I wouldn't expect to see exposed in a django template's context. And on the other, my models often contain fields called 'page' (usually a ForeignKey) which would result in page.page often, so self can be a useful other option.

@davecranwell You wouldn't typically have page as a direct field of a page model though, surely? I can see things like related_link.page coming up, but for a foreign key field on the page itself, you'd want to give it a more descriptive name like index_page.

@gasman true, fields called page wouldn't be best practice. Either way I'm not precious about self, I wouldn't mind it changed for better compatibility with jinja.

I'm happy with the logic here. A couple of additional thoughts:

It's not clear to me whether you intend for end-users to be able to override your chosen variable names (page, block and field_panel) on a per-subclass basis. If that's the plan, then the {% wagtailuserbar %} tag needs more attention, as that's tied to the PAGE_TEMPLATE_VAR definition from wagtail.wagtailcore.models. If that's not the plan, then: 1) I'm mildly in favour of ditching the TEMPLATE_VAR constants and simply hard-coding the names in the context dictionaries instead, as that makes the code more readable (and avoids the misleading impression that they're overrideable); and 2) the changes to wagtailform can presumably be dropped in favour of #1429 / #1541.
Is there a risk that existing Wagtail sites might be setting their own page variable in middleware or context processors, which we'd be clobbering with this change? Would that be a case for implementing @kurtw's suggestion of making the variable configurable in settings? Or am I just being overly paranoid here? :-)
On the question of documentation - since Jinja isn't going to be particularly usable until we've ported the template tags over, would it perhaps make sense to merge this in as an internal, undocumented change for now, so that you can get on with that task - and then deal with documentation once that's ready?

I was not intending on allowing users to override the page, block and field_panel names. I thought that this was unnecessary configuration that would cause unnecessary complications in the template tags and documentation. self is already hard coded, so hardcoding the alternatives is no different. Multiple people have asked after customising the name though, so if there is enough demand for it I am happy to look in to it. I put the names into a constant simply to adhere to DRY principals, but it would also make it easy to change it using a setting. I can not see what overriding it on a per-page-model basis would achieve here. If it is really desired by users, they can always just add another template variable:
class Event(Page):
    def get_context(self, request):
        context = super().get_context()
        context['event'] = self
        return context

There is a risk here, but I think it is small. The only conflicting name I can think of would be for pagination pages, which I often call page in the template. On a similar note though, I just realised using block for self in stream blocks means you can not use {{ block.super }} in the template. The block probably shouldn't conflict with core Django template functionality. I'll try to think of a better name.

I agree, template tags need to come before anything is usable. As far as I can see, the template tags that need to be ported are {% wagtailuserbar %}, {% image %}, and |richtext. All the rest are for the admin, so they don't need to be ported.

To @gasman's second bullet, from what I've seen in the wild projects that are changing the Page object's reference key in the context dict are overriding the get_context method so I think it shouldn't affect them so I don't think forcing the name page will hurt many people, if at all. Personally, I think the benefits of setting the variable to page outweigh the alternatives.
Since this abstraction could help people use alternative templating engines by itself, I'm in favor of merging this now even though Jinja2 extensions need to be made for wagtail's template tag library for full support.

@timheap I didn't read your comment before posting. To your last bullet, the tags wagtailuserbar and image are in need of converting but I think |richtext only needs to be included in the environment by simply adding it to the filters dictionary so no additional work should be needed.

Happy for this to be merged once we've settled on a better name for block, and the wagtailforms changes are backed out (as I believe they're unnecessary now that #1541 has been merged).

I've rebased the commit on to master, removed the wagtailform changes in favour of #1541, and renamed block to value.

https://twitter.com/lincolnloop/status/634802587452047360


Use std::vector for fields grouping indices

We always push back, so std::vector is enough and faster than std::list.

👍


Reduce duplicate code

Is your feature request related to a problem? Please describe.
Currently OpenTimeSeries and OpenFrame have a lot of duplicate code. And although tests are in place to ensure consistency the pylint package raises many R0801 duplicate-code warnings. Ideally this should be reduced. This is what this issue suggests to fix.
Describe the solution you'd like
A new file, common.py is added and in it I will place functions representing the code that is shared between the classes. They will output a float or pandas.Series based on whether or not the resulting pandas.DataFrame has one or more columns.
Describe alternatives you've considered
I am sure there are more advanced and/or performant alternatives but this is simple and within my own know-how

WIP entails 3 common files to group different types of functions. Also a new CommonProps class is added. OpenTimeSeries and OpenFrame will be subclasses of this and the Pydantic.BaseModel. They then inherit common properties.

The new class is now named CommonModel and contains much more than I originally anticipated would be possible. The coming PR will leave the below as the only duplicate code warning remaining. This will be left as is and silenced once more.
As part of the process I have been able to reduce the number of tests to 149. It may be possible to reduce further now when both classes share the same calculating functions and numeric properties.
A colleage suggested dropping one class altogether and have one class always output an array of one or more results, and thereby having one class for all situations. It is feasible but this would be a change that would break a lot of work done downstream within our fund business, and I will not invest time in this now.


remove tons of debug prints everywhere.

eg. in VulkanTracer, and all object constructions.

VulkanTracer : done in VMA_Branch
The rest: deleted (changed some to only RAYX_D_LOG)


chore: ad eslint-plugin-react-hooks

rules are already there in eslint.rc but the dep was handled by CRA before, so just adding it manually now


Login skin object links to the default language instead of the current one

Description of bug
Login skin object links to the default language instead of the current one
Steps to reproduce
Create a site with two languages.
Use a skin with login skin object.
Switch to the secondary language.
The login link will point to the default lang.
Expected result
The current language should be kept.
Screenshots

Affected version

[X ] 9.3.2

This was a but on my end caused probably by cache or app pool.


Log in local timezone

I can see that the logs are coming out in UTC, can we use the system local time instead, or maybe add a flag to enable this?

I just came across this issue looking for the same thing.  I'm glad I'm not crazy, but it's a little disheartening that this issue has been open for more than two years.


Create a Spring project.

The project must have the dependency Spring Web (build web, including RESTful, applications using Spring MVC).

The basic structure is committed in link.


Docs CI test is broken with latest nightly

Describe the bug
The docs CI test is failing on master
To Reproduce
https://github.com/apache/arrow-rs/actions/runs/3062071013/jobs/4942618618
error: internal compiler error: no errors encountered even though `delay_span_bug` issued

error: internal compiler error: broken MIR in DefId(
...

Expected behavior
Tests should pass
Additional context
@tustvold  notes in https://github.com/apache/arrow-rs/pull/2693#issuecomment-1248120845 that this is due to https://github.com/rust-lang/rust/issues/101844

Could we close this issue? The patch has been merged
remziy@remziy-mlt:Arrow-rs$ rustup default nightly
info: using existing install for 'nightly-aarch64-apple-darwin'
info: default toolchain set to 'nightly-aarch64-apple-darwin'

  nightly-aarch64-apple-darwin unchanged - rustc 1.65.0-nightly (95a992a68 2022-09-16)

It does appear to no longer be failing - https://github.com/apache/arrow-rs/actions/runs/3072636649/jobs/4964248404


Update translation for spanish

CC: @jasperhuangg @iwiznia
Details
Updating the spanish translations to be more accurate (Didn't make it to the original PR). Also changing the notification preference we show users to be "Immediately" instead of "Always" (we don't have to change the code) because it's more grammatically correct.
Fixed Issues
related to Expensify/Expensify#176851
Follow up from https://expensify.slack.com/archives/C21FRDWCV/p1641490225006000
Tests/QA Steps

[ ] Verify that no errors appear in the JS console

Make sure you have spanish as your set language to test this
Click the green plus on the bottom left, create a new Room. If you already have a room, you can use that
Click on the icon in the Header of the room chat and then click on Settings
Verify that the Notifications section now match the screenshot below.

Tested On

[x] Web
[x] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Gonals in version: 1.1.29-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Popover in tabulator issue

May I get help with an issue I am experiencing. I created a link icon component in the tabulator where when you click the link, it goes to another page. I want a user to see a description of what the link does when you click by showing the description when they hover over the link icon. That works perfectly, but the issue is when you click on the icon link, the popover does not dissapear, it remains showing even in the new page. Here is my tabulator code:
def config_tabulator_columns(self):
        def view_link_formatter(cell):
            icon_setter = Link(icon="fa:search", foreground="black", font_size=15, spacing_above="none", spacing_below="None", align="center")
            popover(icon_setter, content='View and Update Progress', placement='left', trigger='hover')
            return icon_setter

        self.tabulator_show_client_tasks.columns =  [
            {"title":"", "field": "full_view", "formatter":view_link_formatter, "headerSort":False, "width":50}
        ]

Thank you so much. Works perfectly!


Support for Ajazz ak33

What are you experiencing an issue with?

[ ] Aurora
[ ] Aurora supported game, (Fill in the game)
[x ] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[ ] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[ ] Performance problems
[ ] Visual bug
[ ] Localization issue
[x ] Enhancement suggestion
[ ] Device issue
[ ] Other, (Fill in another type of issue here)

Expected behavior:
You should support the Ajazz k33
Actual behavior:
You dont support the ajazz ak33
How often does this problem occur?
All the time until you support the ajazz ak33
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

Buy an ajazz ak33
Plug it in
Open Aurora
Cry

What is the version of Aurora you are experiencing this issue with?
Latest
Does the previous version of Aurora have this issue?
Probably
Please include any logs, screenshots, or files that are related to this issue:
If it's possible, please do.

There doesn't appear to be any SDK available for that keyboard, without which makes it basically impossible to add support for it without having direct access to the keyboard. If they release an SDK for the keyboard or an unofficial one appears then I'll be sure to try and make support for it, but until then there isn't much I can do.

I have an A-jazz AK 52, if I reverse engineer the way the supplied app by the manufacturer sets individual keys RGB values would you accept a patch?


Bug: Search items not always returned to original order after searching

I've noticed the Command.Item components will be render in a seemingly random order sometimes when searching and resetting the filter.
Reproduction:

Use the Raycast menu on cmdk-sv.com
Type a random letter (e.g. "I") and press backspace repeatedly in quick succession until the order changes.
The "unfiltered" results result is sorted by some seemingly random order

If it helps, my current workaround for solving this is doing:
{#key inputValue === ''}
	<CommandMenu />
{/key}

so the component is created and destroyed, but that definitely feels like a hack.

This only occurs when you do that in rapid succession, correct? If so, we likely have some sort of race condition which is messing with the DOM sorting, almost as if it's still in the process of sorting, interrupted, and then sorts based on the interruption.
I will look into this when I get the chance, thanks for posting your workaround. It definitely makes sense that it works, and if we aren't able to identify an alternative fix, we can implement that within the library so you aren't stuck doing it in your codebase.

@huntabyte Nope, I incorrectly assumed that was the case at first but it's actually reliably unordered when items are filtered out by a letter and re-added.
What I did figure out is what is happening with the "random" order, is actually the included results from the previous input value are moved to the top, and the filtered results are moved to the bottom.

My hunch is using the DOM .appendChild() method to reorder elements when sorting breaks Svelte's ability to keep track of the original DOM order/where the node should be inserted back, but I haven't investigated too much further.

I'll put up a PR up now for the {#key} fix, feel free to close if you can think of a better solution :)


Add Ruby 2.6

@tarebyte thanks for your contribution. As far as I understood, there was at least one significant security flaw in ruby 2.6.0. Could you update the PR to use 2.6.1 instead?
When that is done and when CI works, we are glad to merge.

Gah sorry @scepticulous for some reason I thought I opened this on my fork 🤦♂ so apologies for the lack of description or follow up.
I can update to the latest ruby 2.6 since I'm already here 😅

Bundler latest version requires Ruby >= 2.3.
https://rubygems.org/gems/bundler/versions/2.0.1
Maybe we can update bundler to the latest version conditionally.
Also this error.

https://travis-ci.org/rack-test/rack-test/jobs/478857681
TypeError:
can't dup NilClass

The reason is maybe below code is okay except Ruby 2.3.
But on Ruby 2.3, below code becomes the TypeError.
irb(main):001:0> nil.dup
=> nil

@junaruga I wonder if we should fix the fact that we are using env with a value of nil. Maybe by replacing it with a stubbed value. This would als make the tests more realistic.
What do you think?

@scepticulous let me think it.
By the way, I think we can run Travis CI as daily cron mode too.
Seeing the history of the build, the last build is 5 month ago.
That's not good :<

@junaruga I fully agree on the cron mode. Can you take care of that?
Regarding the test adjustments. let me know if you opt for it. In that case I could update the PR to add the adjustment in order to fix the nil.dup issue.

@scepticulous for the cron mode, adding the notification to freenode server #rack-test channel might be better at least than current situation.
Though I am not sure I can care, I am going to join the irc channel if the channel is created.
https://github.com/socketry/nio4r/blob/master/.travis.yml

notifications:
  irc: "irc.freenode.org#celluloid"

@scepticulous

Regarding the test adjustments. let me know if you opt for it. In that case I could update the PR to add the adjustment in order to fix the nil.dup issue.

I found the reason of the issue. This is because of sinatra latest version 2.0.5. This issue does not happen on sinatra 2.0.4. I think we can wait next version of the sinatra or just pin sinatra adding gem 'sinatra', '2.0.4' to Gemfile.
I opened the ticket.
https://github.com/rack-test/rack-test/issues/243

@tarebyte yes, please push the change to 2.6.1 instead of 2.6.0 and we can merge it.
The build failures are already addressed in other issues and PRs, so we would be glad to merge your PR as soon as its 2.6.1

@scepticulous yeah, I am okay.

@junaruga can you merge this dispite the failing jenkins check?
I guess we should just merge the fixes that make CI pass again asap so that we are able to activate travis as a requirement again. otherwise we are not able to accept contributions.

@scepticulous

guess we should just merge the fixes that make CI pass again asap so that we are able to activate travis as a requirement again.

Yeah I agree to make CI pass again asap.
Let's merge another PR too.

@tarebyte Thanks Mark!


v1 Deployment

Hi,
I wanted to know where can I access the previous version website as I had created my Resume doing it and some features like Markdown and custom Title name are missing in this version.
If the deployment is not available, can you point out the last commit of v1 and steps to build/deploy on GH Page ?

Hi,
We have the source code for the same in releases for version 1
https://github.com/sadanandpai/resume-builder/releases

Thanks alot for the help.
I have deployed it: https://resume-v1-lovat.vercel.app/
Repo: https://github.com/RuthlessRuler/resume-v1


bump db_connection version

There is no need to bump. Projects using myxql can still use 2.3 if they want to as ~> 2.0 allows it. :) in any case, thanks!


PR: Use Python 3.9.14 for x86_64 macOS application build

Description of Changes
Spyder 5.5.1rc0 macOS x86_64 exhibits
RuntimeError: tk.h version (8.5) doesn't match libtk.a version (8.6)

This exhibited previously for local arm64 builds and seemed to be the result of incorrect tcl-tk Python build flags. However, this did not exhibit for Python 3.9.14 x86_64. I suspect that there is a change in the setup-python build flags between 3.9, 3.10, x86_64, and arm64. Nevertheless, the easiest fix right now is to revert to 3.9.14 for x86_64. 🤞🏼

@ccordoba12, the x86_64 artifact works properly on my local machine. I think we're good to go.


Write a JavaScript program to print ascii value of a string

Description
Write a JavaScript program to print ascii value of a string
ASCII value is the numeric representation of a character. For example, the ASCII value of the character 'A' is 65. The ASCII value of the character 'a' is 97. The ASCII value of the character '0' is 48. The ASCII value of the character ' ' is 32.
Input  : ABC
Output : 65 66 67

How to contribute

Save the solution in PrintAsciiValueOfAString.js file
Add PrintAsciiValueOfAString.js file in print-ascii-value-of-a-string folder

!assign


"Ibănești" and "Dumbrăvița" are listed in the drop-down menu

Description:
"Ibănești" and "Dumbrăvița" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Ibănești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Ibănești, Botoșani (Ibănești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Dumbrăvița" in the search bar.

Expected results
The location is listed in the drop-down menu as "Dumbrăvița, Botoșani (Ibănești)".


moving the blocking 3rd party <script src=https://unpkg.com/htmx.org@…

…1.9.11> from  to just before  for performance reasons.

Just a friendly suggestion: You probably shouldn't mix reformatting changes in this PR, or at least they should be stored in a separate commit; otherwise it's very hard to identify what exactly is changing.

Thank you for the suggestion. I will check that tomorrow.

fixed with https://github.com/wintermute-cell/magick.css/commit/66b6ab183032fd5fc8125fe26122096f0b6b884f
please do not include any formatting changes in a PR where formatting is not the main concern.


Binder seems to create new consumer and add to the group when an existing consumer is being paused.

Hi @garyrussell, this is the issue that I was chatting with you about in the gitter channel.
Problem
After upgrading spring-cloud-stream from 3.0.7.RELEASE to 3.0.11.RELEASE I started to realizing some noise from the integration test log about consumer not able to connect to the broker after the embedded broker is shutdown.
Originally I thought this was probably something minor but after a close look I realized that this might be something more serious.
Code logic
Basically I have developed a kafka streams application with retry mechanism. Some message will be produced to the retry topic with a timestamp making the next retry time. The consumer for the retry topic is configured to not commit offset automatically. Whenever the consumer polls a message it will check if the message is ready for retry or not. If it's ready then the consumer will commit the offset, otherwise the I will call the nack() method from the Acknowledgement.class and have the same message pushed to the front of the message queue. This same message will be consumed again and again until it is ready for retry.
The following is the example code I have:
spring.cloud.stream:
  function:
    definition: foo;bar
  kafka.binder:
    brokers: ${spring.embedded.kafka.brokers}
    auto-create-topics: false
  kafka.bindings:
    bar-in-0.consumer:
      auto-commit-offset: false
      idle-event-interval: 1000
  bindings:
    foo-in-0:
      destination: input_topic
    foo-out-0:
      destination: retry_topic
    bar-in-0:
      group: retry_group
      destination: retry_topic
      consumer:
        max-attempts: 1
    bar-out-0:
      destination: success_topic
    bar-out-1:
      destination: failure_topic

spring.cloud.stream.kafka.streams:
  binder:
    brokers: ${spring.embedded.kafka.brokers}
    auto-create-topics: false
    configuration:
      default.key.serde: org.apache.kafka.common.serialization.Serdes$StringSerde
      default.value.serde: org.apache.kafka.common.serialization.Serdes$StringSerde
  bindings:
    foo-in-0:
      consumer:
        application-id: foo-application

package com.example.simpledemo;

import org.apache.kafka.clients.consumer.Consumer;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.streams.kstream.KStream;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.cloud.stream.binding.BinderAwareChannelResolver;
import org.springframework.context.ApplicationListener;
import org.springframework.context.annotation.Bean;
import org.springframework.kafka.event.ListenerContainerIdleEvent;
import org.springframework.kafka.support.Acknowledgment;
import org.springframework.kafka.support.KafkaHeaders;
import org.springframework.messaging.Message;
import org.springframework.messaging.MessageHeaders;
import org.springframework.messaging.support.MessageBuilder;

import java.time.Duration;
import java.util.Collections;
import java.util.function.Function;

@SpringBootApplication
public class SimpleDemoApplication {

	private static final Logger log = LogManager.getLogger(SimpleDemoApplication.class);

	public static void main(String[] args) {
		SpringApplication.run(SimpleDemoApplication.class, args);
	}

	@Autowired
	private BinderAwareChannelResolver resolver;

	@Bean
	public ApplicationListener<ListenerContainerIdleEvent> idleListener() {
		return event -> {
			try {
				log.info("Pausing consumer for 5 seconds");
				// constantly polling to stay alive -> in real world the pause is longer than max.poll.interval.ms
				for (int delay = 0; delay < 5000; delay += 1000) {
					Thread.sleep(1000);
					event.getConsumer().poll(Duration.ZERO);
				}
			} catch (InterruptedException e) {
				throw new RuntimeException(e);
			}
			event.getConsumer().resume(event.getConsumer().paused());
		};
	}

	@Bean
	public Function<KStream<String, String>, KStream<String, String>> foo() {
		return inputStream -> inputStream
			.mapValues(message -> message + ":" + (System.currentTimeMillis() + 5000))
			.peek((k, v) -> log.info("Producing message with key {} and value {}", k, v));
	}

	@Bean
	public java.util.function.Consumer<Message<String>> bar() {
		return message -> {
			MessageHeaders headers = message.getHeaders();
			String payload = message.getPayload();
			Consumer<?, ?> consumer = headers.get(KafkaHeaders.CONSUMER, Consumer.class);
			String topic = headers.get(KafkaHeaders.RECEIVED_TOPIC, String.class);
			Integer partitionId = headers.get(KafkaHeaders.RECEIVED_PARTITION_ID, Integer.class);
			Acknowledgment acknowledgment = headers.get(KafkaHeaders.ACKNOWLEDGMENT, Acknowledgment.class);

			String status = payload.substring(0, payload.indexOf(":"));
			long retryTime = Long.parseLong(payload.substring(payload.lastIndexOf(":") + 1));

			if (retryTime > System.currentTimeMillis()) {
				acknowledgment.nack(Duration.ZERO.toMillis());
				consumer.pause(Collections.singleton(new TopicPartition(topic, partitionId)));
			} else {
				acknowledgment.acknowledge();
				if ("SUCCESS".equals(status)) {
					resolver.resolveDestination("bar-out-0").send(
						MessageBuilder.withPayload("RETRIED_" + payload)
							.copyHeadersIfAbsent(headers)
							.setHeader(KafkaHeaders.MESSAGE_KEY, headers.get(KafkaHeaders.RECEIVED_MESSAGE_KEY))
							.setHeader(KafkaHeaders.TIMESTAMP, headers.get(KafkaHeaders.RECEIVED_TIMESTAMP))
							.build()
					);
				} else if ("FAILURE".equals(status)) {
					resolver.resolveDestination("bar-out-1").send(
						MessageBuilder.withPayload("RETRIED_" + payload)
							.copyHeadersIfAbsent(headers)
							.setHeader(KafkaHeaders.MESSAGE_KEY, headers.get(KafkaHeaders.RECEIVED_MESSAGE_KEY))
							.setHeader(KafkaHeaders.TIMESTAMP, headers.get(KafkaHeaders.RECEIVED_TIMESTAMP))
							.build()
					);
				}
			}
		};
	}
}

This code example was created as per our discussion, I was trying to reproduce the very same problem with this code however it's not showing up. I only see this problem on the real code for some reason. But basically this simple code snippet shows the basic structure of the retry mechanism.
The log
The following log is retrieved from the real code test run, from the log you can see that between the consumer pause and resume there is a new consumer created and added to the consumer group. I only see this when upgrading to version 3.0.9.RELEASE and so on. It does not happen with 3.0.8.RELEASE.
From the log you can see that consumer with clientId consumer-retry-group-2 is being paused on partition retry-topic-0 for 5 seconds.
Then a new consumer is created with clientId consumer-retry-group-3 and added to the group retry-group in between the pause and the resume log.
This newly created consumer consumer-retry-group-3 also doesn't seem to obey to the config I set for disabling the auto.commit.offset, it somehow has the value set to true instead.
2021-04-22 18:08:43 - [Consumer clientId=consumer-retry-group-2, groupId=retry-group] Seeking to offset 0 for partition retry-topic-0
2021-04-22 18:08:48 - Pausing consumer for 5 seconds on partition [retry-topic-0]
2021-04-22 18:08:51 - ConsumerConfig values:
	allow.auto.create.topics = true
	auto.commit.interval.ms = 5000
	auto.offset.reset = latest
	bootstrap.servers = [<IP_ADDRESS>:53287]
	check.crcs = true
	client.dns.lookup = default
	client.id =
	client.rack =
	connections.max.idle.ms = 540000
	default.api.timeout.ms = 60000
	**enable.auto.commit = true**
	exclude.internal.topics = true
	fetch.max.bytes = 52428800
	fetch.max.wait.ms = 500
	fetch.min.bytes = 1
	group.id = retry-group
	group.instance.id = null
	heartbeat.interval.ms = 3000
	interceptor.classes = []
	internal.leave.group.on.close = true
	isolation.level = read_uncommitted
	key.deserializer = class org.apache.kafka.common.serialization.ByteArrayDeserializer
	max.partition.fetch.bytes = 1048576
	max.poll.interval.ms = 300000
	max.poll.records = 500
	metadata.max.age.ms = 300000
	metric.reporters = []
	metrics.num.samples = 2
	metrics.recording.level = INFO
	metrics.sample.window.ms = 30000
	partition.assignment.strategy = [class org.apache.kafka.clients.consumer.RangeAssignor]
	receive.buffer.bytes = 65536
	reconnect.backoff.max.ms = 1000
	reconnect.backoff.ms = 50
	request.timeout.ms = 30000
	retry.backoff.ms = 100
	sasl.client.callback.handler.class = null
	sasl.jaas.config = null
	sasl.kerberos.kinit.cmd = /usr/bin/kinit
	sasl.kerberos.min.time.before.relogin = 60000
	sasl.kerberos.service.name = null
	sasl.kerberos.ticket.renew.jitter = 0.05
	sasl.kerberos.ticket.renew.window.factor = 0.8
	sasl.login.callback.handler.class = null
	sasl.login.class = null
	sasl.login.refresh.buffer.seconds = 300
	sasl.login.refresh.min.period.seconds = 60
	sasl.login.refresh.window.factor = 0.8
	sasl.login.refresh.window.jitter = 0.05
	sasl.mechanism = GSSAPI
	security.protocol = PLAINTEXT
	security.providers = null
	send.buffer.bytes = 131072
	session.timeout.ms = 10000
	ssl.cipher.suites = null
	ssl.enabled.protocols = [TLSv1.2]
	ssl.endpoint.identification.algorithm = https
	ssl.key.password = null
	ssl.keymanager.algorithm = SunX509
	ssl.keystore.location = null
	ssl.keystore.password = null
	ssl.keystore.type = JKS
	ssl.protocol = TLSv1.2
	ssl.provider = null
	ssl.secure.random.implementation = null
	ssl.trustmanager.algorithm = PKIX
	ssl.truststore.location = null
	ssl.truststore.password = null
	ssl.truststore.type = JKS
	value.deserializer = class org.apache.kafka.common.serialization.ByteArrayDeserializer

2021-04-22 18:08:51 - Kafka version: 2.5.1
2021-04-22 18:08:51 - Kafka commitId: 0efa8fb0f4c73d92
2021-04-22 18:08:51 - Kafka startTimeMs:<PHONE_NUMBER>611
2021-04-22 18:08:51 - [Consumer clientId=consumer-retry-group-3, groupId=retry-group] Cluster ID: xTl517dtRkarLy9Nb8iz8w
2021-04-22 18:08:51 - [Consumer clientId=consumer-retry-group-3, groupId=retry-group] Discovered group coordinator localhost:53287 (id:<PHONE_NUMBER> rack: null)
2021-04-22 18:08:51 - [Consumer clientId=consumer-retry-group-3, groupId=retry-group] Found no committed offset for partition retry-topic-0
2021-04-22 18:08:53 - Resuming consumer on partition [retry-topic-0]

I was trying to provide you with a simple and complete project that can reproduce this problem but unfortunately I cannot get it reproduced. I am still puzzled at this moment why a new consumer is created after the existing consumer in the group is being paused.
Any help would be greatly appreciated.

See https://stackoverflow.com/questions/67084583/why-is-my-spring-cloud-stream-config-creating-multiple-kafka-consumers/67094493#67094493
You will see 3 consumers if you have the actuator on the class path - only one actually consumes anything.

@garyrussell thanks for the info. Just wondering is this a feature introduced after 3.0.8.RELEASE for spring-cloud-stream? As I mentioned earlier as I do not see the 3rd consumer when using 3.0.7.RELEASE and yes I DO have actuator in my class path.

@garyrussell Also you are right, after adding actuator and micrometer in the classpath I started seeing the 3rd consumer from my example code above which I failed to reproduce the issue originally.

I am assuming this has been resolved based on SO link and the last two responses. Feel free to reopen it if it is not the case


Crash on Wine

Cannot run on wine-stagins 7.22 due this error
thread 'main' panicked at 'index out of bounds: the len is 1 but the index is 1', src\ui\edit_bbs.rs:23:16
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Should be fixed by
https://github.com/mkrueger/icy_term/commit/2ea1dedacf1d1b14625abbe1422579e9ce09a12d
and https://github.com/mkrueger/icy_term/commit/d2efda96439a8ac66543df956f82436be4e49ef8


better debugging messages

feedback from user:
I'm getting this error / response from https://socket.analytics.mashape.com/1.0.0/single [{"field":"data.har.log.entries.0.request.url","message":"must be uri format"}]

Not sure how this is an issue with the agent, looks more like an issue with the API, what is the URI format?

Not sure how this is an issue with the agent, looks more like an issue with the API, such as what is the URI format?

the invalid URI format is the problem, but in order for us to debug remotely from users, be good to have debugging flags, or info in the console?

Hmm, yeah I couldn't decipher that from your initial comment.
If it's something like a console error, that's easy enough. Though the API should return something a little better.

yeah the validator currently just reports the invalid field(s) but not the values


Docs are down

Can't get to https://www.jgeppert.com/
Thanks.

This to me highlights that the documentation should be stored in the same repository as the code.

what docs you are refering. the showcase app can be downloaded and run by everyone.


MID2STD pq

hi all I have a MIB2STD PQ " single sd slot" and no navigation in my tiguan need to know how and which toolbox to download and how to install if possible

https://github.com/olli991/mib-std2-pq-zr-toolbox/blob/master/README.md


static port for node application

hi,
i have been trying to use specific port for my application 3000 for an instance
found this plugins:
dokku-bind-port
docker options
when i am using the -p flag , my application actually deployed and exposed on the correct port -> 3000 and not the default 5000
i understood that the port issue is because the old app is still running , while the new one gets deployed
i saw this PR to docker , but dokku still seems to have this problem
docker-fixed-port
also found this on digital ocean
subdomain-digitalOcean
but i have no need for subdomain, and my server uses a specific pot
what am i missing? , there is a solution?
i may be new to dokku but i couldn't find clean solution, and hope the is one :+1:  , it is really handy one

Hi @oriandabud, I don't think the docker issue is related. That was a docker 1.0 specific bug that wasn't releasing ports used by stopped containers, good news is that what your trying to do has been a feature of Dokku's for some time now!
If you want to bind your application to a different port, you can set the var DOKKU_NGINX_PORT and/or DOKKU_NGINX_SSL_PORT. Note: Even for non default ports or no vhosts, nginx is still used to enable zero downtime deployments (ie you can't start a new container if another is already using the same port, instead nginx proxys the preferred port to the random backend port).  http://progrium.viewdocs.io/dokku/nginx/
Let me know if that helps. :smiley:

@oriandabud bump

ok great this ENV solved my problem
thanks :+1:

i seems to be happening again
tried to unset DOKKU_NO_NGINX
but still, i can access to :5000 , to localhost:
but i cant access localhost:5000
why is that?
-----> Running post-deploy
-----> VHOST support disabled. Skipping domains setup
-----> Setting config vars
       NO_VHOST: 1
-----> Creating http nginx.conf
-----> Running nginx-pre-reload
       Reloading nginx
-----> Shutting down old containers in 60 seconds
=====> b98753d0751c86bdb6595f660d0074a2316c315cfcf32161b3161ae4660e223f
=====> Application deployed:
       http://<IP_ADDRESS>:32772 32773 (container)
       http://<IP_ADDRESS>:5000 (nginx)
       https://<IP_ADDRESS>:5000 (nginx-ssl)

I'm not sure I understand your question. You want to know why you can access your app at :5000 but not localhost:5000?

I was able to make that work (on master)...Can you clarify what you're attempting to do and what's not working for you?
-----> Running post-deploy
=====> unsupported vhost config found. disabling vhost support
-----> Setting config vars
       NO_VHOST: 1
-----> Setting config vars
       NO_VHOST: 1
-----> Creating http nginx.conf
-----> Running nginx-pre-reload
       Reloading nginx
-----> Setting config vars
       DOKKU_APP_RESTORE: 1
=====> Application deployed:
       http://<IP_ADDRESS>:32790 (container)
       http://<IP_ADDRESS>:5000 (nginx)

root@dokku:~/dokku# dokku config node-js-app
=====> node-js-app config vars
DOKKU_APP_RESTORE:     1
DOKKU_DOCKERFILE_PORT: 8000
DOKKU_NGINX_PORT:      5000
NO_VHOST:              1
PORT:                  5000
root@dokku:~/dokku# curl http://<IP_ADDRESS>:5000
Hello World!
root@dokku:~/dokku# curl http://localhost:5000
Hello World!

oh sorry , the markdown removed my inline comments
working for me:
curl http://<IP_ADDRESS>:5000 (aka <IP_ADDRESS> is the container ip)
curl http://localhost:3728 (aka 3728 is dokku deployed port)
not working for me:
curl http://localhost:5000 (although i have DOKKU_NGINX_PORT:  5000)

To be clear <IP_ADDRESS> is not the container ip in my example. It is the standard network interface.
Check out how port 5000 is bound with netstat -plant; look for port 5000. Assuming the port binding looks right, check out how you're resolving the name localhost. ping localhost is a pretty quick method of doing this. You might also grep localhost /etc/hosts and compare the two.

Also make sure not to set DOKKU_NO_NGINX

no DOKKU_NO_NGINX
also ping localhost works
and grep localhost /etc/hosts outputs
::1	localhost	ip6-localhost ip6-loopback

Maybe add <IP_ADDRESS> as an alias to localhost in /etc/hosts?

This is what I have in my vagrant env
root@dokku:~# grep localhost /etc/hosts
<IP_ADDRESS>  dokku.me *.dokku.me www.test.app.dokku.me www.test.dokku.me localhost
::1     localhost ip6-localhost ip6-loopback

@oriandabud Do you have any update for us?

Closing. Feel free to comment with more info and we can re-open.


Updates popups and tooltips - Re-Pull

This re-introduces the changes from #219 and addresses the comments in that PR. The revert, #227, does not actually remove the reverted commits from the git history, so the only commit listed in this PR is the one addressing comments, even though it reintroduces all the code from 219.

think just need to update snapshot tests then can merge :)


ctx.throw with 449 is transformed in error 500

Hi !
When i want to use the http code 449 "Retry With", koa transform it to 500. How can i allow this status please ?
I know this is not a standard http code, introduced by Microsoft. But currently, i need it...
So, can you help me please ?
Thanks in advance !

Non standard status codes are not supported by jshttp/statuses (which Koa depends on).
See ongoing discussion.


docs: fix response payload for v2 endpoints

Endpoints

[x] /v2/pox
[x] /v2/info
[x] /v2/contracts/interface

closing for now as we are directing users to use https://docs.stacks.co/reference/api#stacks-node-rpc-api-endpoints for rpc endpoints.
heres a new ticket for adding in a new RPC section.


Update new-site-checklist.md

Category

[x] Content fix

Contents of the Pull Request
Content fixes & improved formatting

Docs Build status updates of commit d304a93:
:white_check_mark: Validation status: partially passed

File
Status
Preview URL
Details

:x:Error

Details

Community/new-site-checklist.md
:bulb:Suggestion
View
Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://SiteHelp and include the error report for our team to troubleshoot

Community/new-site-checklist.md

Line 2, Column 1: [Suggestion-audience-missing] Missing required attribute: 'audience'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Thanks, @ganesh-sanap!


Bump lotus-model dependency

+1
http://lucaguidi.com

On 23/giu/2015, at 07:18, Trung Lê<EMAIL_ADDRESS>wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/lotus/lotus/pull/266
Commit Summary
Bump lotus-model dependency
File Changes
M Gemfile (2)
Patch Links:
https://github.com/lotus/lotus/pull/266.patch
https://github.com/lotus/lotus/pull/266.diff
—
Reply to this email directly or view it on GitHub.


ci(windows): resolve ci issues

Summary
MSBuild GH Action lib was deprecated.
This change updates invocation to match pattern in C++ Client.
Checklist

[x] Ready to be merged

platformio build failures: resolved in #233

platformio build failures: resolved in #233


Incorrect range Headers and missing partial content implementation

206 Partial Content is incorrectly implemented causing some video files (MP4) to fail. This is caused by the introduction of range headers in https://github.com/karma-runner/karma/commit/a567b6f in issue #2140
Expected behavior
According to RFC 2616, the byte-range-resp-spec should be (first-byte-pos "-" last-byte-pos).
For example, if the resource is of length 1234 and the range request is for bytes 500-, the range should be 500-1233/1234
If my resource is 229,255 bytes and I request it with:
Range: bytes=0-

I expect:
HTTP/1.1 206 Partial Content
Accept-Ranges: bytes
Content-Range: bytes 0-229254/229255
Content-Length: 229255

Actual behavior
Currently, when my resource is 229,255 bytes and I request it with karma v1.2.0:
Range: bytes=0-

I am receiving:
HTTP/1.1 206 Partial Content
Content-Range: bytes 0-229255/229255

Few things are wrong here:

Content-Range should be bytes 0-229254/229255 instead of 0-229255/229255
Should return Accept-Ranges
We should return Content-Length since it's recommended for application to implement according to RFC 2616.

Also I recommend we use range-parser for this.
Environment Details
Introduced in Karma v1.2.0. In v1.1.2, this is fine.
Fails in Chrome 52 and Chrome 53, in Mac OS X, Windows and Ubuntu.
Steps to reproduce the behaviour

Use files to serve a small MP4 asset in Chrome 52 or Chrome 53.
Asset will not load as range headers are wrong, this causes video not to play

@dignifiedquire I'll take this.


diffenator: use blackrenderer

@simoncozens I see we've got our own cool draw_text function, https://github.com/googlefonts/gftools/blob/diff2-fuzz/Lib/gftools/diffenator/ft_hb_shape.py#L9-L18. Perhaps it's better if we use blackrenderer so it'll allow us to also gen colr v1 bitmaps?
I've just quickly modified our function so it uses blackrender and there's a few differences we need to consider:

left: blackrenderer, right: ft_hb_shape.draw_text

for non-color fonts, colors are inverted
draw_text includes the left side bearing but not the right (did you mean intentionally want this?). Blackrenderer includes both sidebearings
blackrenders output array is for RGBA pixels. Ours is just for greyscale

If none of the above are issues to you, I shall proceed and integrate blackrenderer.

Looks good. We will probably have to fix the diff function but I think go for it.

Cool, I'll proceed. Since the diff function uses numpy arrays, it works from the get go
>>> a = np.array([
        [[255, 255, 0],[255, 0, 0]],
    ])
>>> b = np.array([
        [[255, 255, 0], [255, 0, 0]]
    ])
>>> print(img_diff(a,b))
0.0

>>> a = np.array([
        [[255, 255, 0],[255, 0, 0]],
    ])
>>> b = np.array([
        [[255, 255, 0], [125, 0, 0]]
    ])
>>> print(img_diff(a,b))
0.28

This issue is obsolete with the new diffenator2.


[ja] Ensure seccomp starts with small letter

en PR https://github.com/kubernetes/website/pull/43209/files
/assign @t-inu
/assign @nasa9084

/lgtm
@dipesh-rawat
Thank you for creating the link of the page, it's so useful for reviewing quickly.

/approve


[Fuel backend] Setup CI Tests

Original report (archived issue) by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).

it's been tested primarily on ubuntu trusty and xenial
We should set up CI so we can test on osx and windows

I think this can be closed, as @scpeters said we already have CI running for all platforms.


Drag & drop: moving an item downwards results in the item getting placed one position too far down

Steps to reproduce
see #214
Expected behaviour
Drag-drop should place items at the right position.
Actual behaviour
Dragging an item within the tree upwards works as expected but moving an item downwards results in the item getting placed one position too far down.
Putting #1 behind item #2 to become the new #2 results in it becoming #3 (see Screenshot).

Server configuration
Operating system:
Web server:
Database:
PHP version:
Lumen Version:
Spacialist version:
List of activated modules:

Module List

Are you using external storage, if yes which one: local/ftp/aws/...

I added this to delphi instead of backlog. Due to this bug the rank property of the tree elements is messed up.

Not part of the first 0.4 release, but definitely for 0.4.x.


How to debug server side component?

Best wish. Thanks.

Hey! We now have much better docs on RSC: https://beta.nextjs.org/docs
Please check these out and let us know if they help 😄


Feature/#21969

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Automated cherry pick of #1467: fix create disk scheduler failed

Cherry pick of #1467 on release/2.11.0.
#1467: fix create disk scheduler failed

/lgtm
/approve


Rebuild packages fails in Beta

Similar to https://github.com/atom/atom/issues/8837, however this only happens with the Atom Beta build, no Incompatible Package issues in stable build.
Upon opening Atom, even in safe mode, a red bug icon appears. The screen it leads to reveals that

Some installed packages could not be loaded because they contain native modules that were compiled for earlier version of Atom.

Clicking the button to Rebuild Packages fails giving the errors shown below.
Note the target path for the Make command is odd and seems to point to the non-beta version.
../../../../../../../../../../../../Applications/Atom

If i navigate to the package folder and run the rebuild command, it succeeds with apm but fails with ape-beta giving same output as above.

This is on OS X 10.11.1, running NVM if it makes a difference.

cc @maxbrunsfeld @nathansobo

I wonder if this has something to do with the app naming in beta?

Also note the use of node 0.10.40 which is not expected.

Don't know where 0.10.40 is coming from, the output of nvm ls and respective paths are below.
~|⇒ nvm ls
        v0.12.7
->       v4.1.1
default -> stable (-> v4.1.1)
node -> stable (-> v4.1.1) (default)
stable -> 4.1 (-> v4.1.1) (default)
iojs -> N/A (default)

~|⇒ which node
/Users/Ketch/.nvm/versions/node/v4.1.1/bin/node

~|⇒ which npm
/Users/Ketch/.nvm/versions/node/v4.1.1/bin/npm

I've also stumbled upon this bug while using atom-beta 1.12 on OSX 10.12.1. I also ran into this bug on OSX 10.11.6, so I don't think it depends on a specific version of OSX. I'm guessing the bug has to do with the app's name in beta.
gyp WARN download NVM_IOJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use IOJS_ORG_MIRROR
gyp WARN download NVM_IOJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use IOJS_ORG_MIRROR
gyp WARN download NVM_IOJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use IOJS_ORG_MIRROR
make: *** No rule to make target `../../../../../../../../Applications/Atom', needed by `Makefile'.   System Darwin 16.1.0
gyp ERR! command "/Applications/Atom Beta.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom Beta.app/Contents/Resources/app/apm/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /Users/costan/.atom/packages/git-blame/node_modules/pathwatcher
gyp ERR! node -v v4.4.5
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok

npm ERR! Darwin 16.1.0
npm ERR! argv "/Applications/Atom Beta.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom Beta.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/costan/.atom/.apm/.apmrc" "--userconfig" "/Users/costan/.atom/.apmrc" "rebuild" "--runtime=electron" "--target=1.3.6" "--arch=x64"
npm ERR! node v4.4.5
npm ERR! npm  v3.10.5
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the pathwatcher package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs pathwatcher
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls pathwatcher
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/costan/.atom/packages/git-blame/npm-debug.log

This should be fixed once atom/apm#673 is fixed. :sparkles: