arch-x86: Add XCR0 register and add to X86KvmCPU

The extended control registers were not being updated in the KVM thread context nor updated in the KVM state. This was causing issues when checkpointing since the XCR0 value was reverting to the default value rather than what it was previously before the checkpoint. THis was causing multiple applications to crash due to executing instructions which are now illegal instructions due to XCR0 being incorrect.
This commit adds the XCR0 as a misc register similar to the exiting x86 control registers and adds all of the helper functions to access and set the register value. It also adds support for updating the KVM CPU's state with the register value and updating the thread context's misc reg value so that it is checkpointed along with the other misc regs.
Note that this does not add support for XSAVE of the AVX state (i.e., the upper 128 bits of YMM registers). It does however fix the immediate problem in issue #958 .
Change-Id: I97456c8b57cbc7b381bd4be94944ce6567a43c76

@v-ramadas I stumbled upon a solution to this kernel panic while working on something slightly related, so created a PR for it.  We should be able to test checkpointing GPU ML apps now

Thanks! This is great. I will test it out when I get some time.

@BobbyRBruce @Harshil2107  The failing tests are checkpoint restore checks.  The checkpoint appears to be part of a resource, how does that get updated?  This change implicitly adds another element to an array param

.... Do I need to write a checkpoint upgrader?

If the checkpoint upgrader needs to be updated, then I can run the updated checkpoint upgrader on the existing checkpoints and push a new version. If the checkpoint upgrader doesnt need to be update I can just retake the checkpoints and update the version.
Can you tell me if you need to update the checkpoint upgrader?

Well if you take new checkpoint with this change applied then that would also fix the failing tests.
I suppose writing an upgrader is more correct as other might need to use it.  Is the upgrader run as part of the tests?

If the checkpoint upgrader needs to be updated, then I can run the updated checkpoint upgrader on the existing checkpoints and push a new version. If the checkpoint upgrader doesnt need to be update I can just retake the checkpoints and update the version.
Can you tell me if you need to update the checkpoint upgrader?

Added a checkpoint upgrader.  I guess this would have to be applied to the resources?

I will run and update the failing checkpoints.

I will run and update the failing checkpoints.

Thank you!

I just reran the tests with updated checkpoints.

To get the tests to pass you would need to update the resource version to 3.0.0 in the x86-fs-restore-checkpoint.py, x86-hello-restore-checkpoint.py. I can also push a commit with this changes if you want me to.

To get the tests to pass you would need to update the resource version to 3.0.0 in the x86-fs-restore-checkpoint.py, x86-hello-restore-checkpoint.py. I can also push a commit with this changes if you want me to.

Sure... I don't know where those files are.

The checkpoint upgrader doesnt seem to fix the checkpoints, should I take new checkpoints or do we need to update the updater again?

It looks like the testlib tests have a different name for the ini config section, so I will have to rewrite the upgrader

Updated the checkpoint upgrader.  You might need to manually edit the m5.cpt file to remove the x86-add-xcr0 tag from the file before running the upgrader again.  Or simply use the 2.0.0 files

If I could make a suggestion.  Is it possible to have testlib run the checkpoint upgrader before running a test? Then you could "officially" recreate during the release freeze? That way it wouldn't require someone with access to the checkpoint files to post a PR requiring checkpoint upgrades.  Although that might be rare enough it doesn't make sense.

The updated simpoint is causing other PRs to fail, I will create create a version specific resource for this PR and so that the tests in other PRs dont fail.

If I could make a suggestion. Is it possible to have testlib run the checkpoint upgrader before running a test? Then you could "officially" recreate during the release freeze? That way it wouldn't require someone with access to the checkpoint files to post a PR requiring checkpoint upgrades. Although that might be rare enough it doesn't make sense.

The reason for not doing that is, that the checkpoints on gem5 resources become outdated and need to be updated all at once. As we have to keep the checkpoints in sync with gem5 resources, I feel it is better to keep on updating them as the changes are made.
I will push a change that defines the resource versions explicitly instead of grabbing the latest version in another PR. In this way the tests for other PRs with older code will not fail, when we update the checkpoints.

I have created a new resource for this change, now the tests in other PRs should not be affected. I will sync the resources when I push the PR I mentioned above (this should not affect tests for other PRs).

If I could make a suggestion. Is it possible to have testlib run the checkpoint upgrader before running a test? Then you could "officially" recreate during the release freeze? That way it wouldn't require someone with access to the checkpoint files to post a PR requiring checkpoint upgrades. Although that might be rare enough it doesn't make sense.

The reason for not doing that is, that the checkpoints on gem5 resources become outdated and need to be updated all at once. As we have to keep the checkpoints in sync with gem5 resources, I feel it is better to keep on updating them as the changes are made.
I will push a change that defines the resource versions explicitly instead of grabbing the latest version in another PR. In this way the tests for other PRs with older code will not fail, when we update the checkpoints.

I see. I was attempting to find a solution that didn't require a single entity (UC Davis) to have to be involved.

I see. I was attempting to find a solution that didn't require a single entity (UC Davis) to have to be involved.

Thanks! I agree that would be great. The main problem here is that checkpoints are deeply tied to the code of gem5 (which is a problem). Really, checkpoints should be more of an API that can't be changed willy-nilly, but that's not how it's architected right now.
There's a tradeoff in the work to do per-commit and per-release. When possible, I'd like to do the work per-commit to make release time easier. Updating checkpoints should be rare enough (a few times every release) that it's better to do it per-commit than waiting until the release.
You're not the first to suggest auto-running the checkpoint upgrader (or removing checkpointing from testing). But, one of the main arguments against this is that it would mask when checkpoints need to be updated for the next release (putting more onus on us at release time).

@abmerop it doesn't look like you need me for anything here at this point, since you are still working with @Harshil2107 on the checkpoint changes.  Let me know if I'm missing something though.  I added Harshil as a review to hopefully help with this.

@abmerop it doesn't look like you need me for anything here at this point, since you are still working with @Harshil2107 on the checkpoint changes. Let me know if I'm missing something though. I added Harshil as a review to hopefully help with this.

The checks has passed now, so I just need a reviewer to approve


Video not saving

some times video save at android/data/com.trimmer.videotrimmer/files/Picture/(video saved here)
but some times it did not save at that place
and where can i find this location
/data/user/0/com.trimmer.videotrimmer/app_flutter/Trimmer/image_picker6447870776611015947_trimmed:Aug14,2020-08:25:17.mp4
i did not get it any where in my phone

Did you use the default storage option of the package or anything other like StorageDir.externalStorageDirectory?

Thanks for replying I figure out the problem what is going on here . Actually in build.gridle file I target to sdk 29 but when I target to sdk 28 everything works fine.

@sbis04 I used default storage option , also target sdk is 28. Still getting the same issue as above. Kindly guide me..


There're some problems with my taskbar 🔪🩸

I've to enable taskbar size as small:

After restarting the PC my taskbar gives me the bouquet of pain in my eyes. Look at this:

So... There are three problems at all:

My left doc panel beseeches to kill its:

The space between icons looks like really space 👾🪐🛰:

In my second monitor the taskbar surface wasn't changed, but the icons were:

It makes me sad cuz I love some small panels. It'll be fantastic if the taskbar will be 24 pixels.

Unfortunately, problem 1 and 2 are known issues with no known resolution. If a solution becomes available I’ll mention so here and I’ll address the issue in a future update of Windows 11 Fixer.


feat: support for doctype retrieval

Provides support for DOCTYPE retrieval in PullParser.

@kornelski thanks so much for the suggestions!

The tests are failing

Please test your work

Of course!

Hi @kornelski I think this pr was merged accidentally?


added C++ guards in wren.h

I think the idea is that when you use Wren in C++, you'd also compile Wren itself as C++, so the extern "C" is not necessary. At least the README.md says that Wren compiles as C++98 as well. I'm not exactly sure if there is a particular reason to support this, though.

I compile Wren separately as a static library.  In my build pipeline, it is built in parallel with all my other 3rd party libraries.  The external C only libraries I use (zlib, libpng, freetype2, glew, etc), all have C++ guards.
I do not have to provide any special build settings and allow the compiler to build based on extensions.
Without the guards, C++ will assume the public functions are mangled names and cause link errors.
As a workaround, I'd have to wrap extern "C" every time I include  a Wren header:
extern "C" { #include "wren.h" }

Compiling Wren as a C++ static library will create the proper names though.

The other C libs you mentioned do actually only build as C though, where as wren compiles as CPP.

Like others note, you shouldn't need to extern "C" Wren's header if you want to use it from C++. You can just compile it as C++ instead and the names will be consistently mangled. Because Wren uses .c as a file extension, you may have to tell your build system that you explicitly want to compile it as C++, but that should be fairly straightforward.
We wouldn't want to always use extern "C" when compiling wren while __cplusplus is defined because that would break users who do intend to compile it as C++.
For what it's worth, Lua is set up the same way.
Are you running into problems getting your build system to compile it as C++?

You could do (or even wren could  provide it, like lua) "wren.hpp" where its content is:
#pragma once
extern "C" {
#include "wren.h"
}

You could do (or even wren could provide it, like lua) "wren.hpp" where its content is:

Oh, that's clever. :) I'd be happy to do that for Wren. Would that work for you, @foobit?

For what it's worth, Lua is set up the same way.

I'm left wondering though, what is the advantage of doing this?

The wren.hpp is a perfect solution which keeps Wren open to both options.

I'm left wondering though, what is the advantage of doing this?

It's not too hard to get the code to compile as either C or C++ and supporting the latter lets users integrate it into their C++ apps without having to deal with two sets of build flags, extern "C", etc. It just gives you a simpler, more homogenous build.

OK, "wren.hpp" is in now: https://github.com/munificent/wren/commit/417ed7aeede528a2f646741a0c4d75beb6d52d64


subscriber_email email changes

change email subscriber_email as footer field assign to this field. @jitendra-webkul #660

Thanks @jay-thanki


Lists in json source cause HTML problems with
 wrapping

Where to find the issue
Pages on https://www.coronawarn.app/ generated from json source containing lists
 or
.
Describe the issue
When a
 (unordered list) or an
 (ordered list) is included in a json source file for the cwa-website, the default conversion to html wraps the list in paragraph
 ...
 tags which makes it invalid HTML.
See for instance https://stackoverflow.com/questions/7168723/unordered-list-in-a-paragraph-element. A paragraph
 is allowed to contain phrasing content.
 and
 do not belong to the category of phrasing content.
Steps to reproduce
Run https://validator.w3.org on https://www.coronawarn.app/en/ and note error:

"No p element in scope but a p end tag seen"

This is due to the following source. I have added new lines for readability:

Download the current version of the app (iOS: 2.28.0 or Android: 2.28.3)

Keep operating systems up-to-date (at least iOS 12.5 or iOS 13.5 depending on your iPhone model or at least Android 6 with current Google Play services)

Keep background updates switched on and check them regularly

To be on the safe side, open the app once a day

This is a simple example from the main page. More importantly it is also a problem in the FAQs on https://www.coronawarn.app/en/faq/results/.
Analysis
In the example, the source link is from:
https://github.com/corona-warn-app/cwa-website/blob/4157d4b0b2cd1b4780ae3eeb9982f5eec6939e62/src/data/index.json#L46-L48
which is processed by the following and this wraps the list incorrectly in
 ...

https://github.com/corona-warn-app/cwa-website/blob/4157d4b0b2cd1b4780ae3eeb9982f5eec6939e62/src/partials/text-component.html#L12-L14
Suggestion
Some way needs to be found to prevent lists in the middle of textblocks being wrapped in
 ...
 so that the generated HTML is correct.
A special case (linkList) was already implemented for lists of internal URLs in FAQs. See https://github.com/corona-warn-app/cwa-website/blob/4157d4b0b2cd1b4780ae3eeb9982f5eec6939e62/src/partials/page-faq-results.html#L95-L106
Perhaps this could be made more generic?

@brianebeling
The list of remaining HTML issues is getting shorter! Thanks for the latest merges today!
The remaining problems are more difficult to solve and unfortunately I don't have a solution for this issue I'm describing here. I will be submitting a few more issues that don't know the answer to.

Wrapping in a  feels a bit like it could introduce behaviour. This surely seems like a more difficult one. We will discuss this internally, thank you!

Is there actually a for the user visible problem with this?

@Ein-Tim

Is there actually a for the user visible problem with this?

You would need to check all browsers on the market to find out how they handle the incorrect code to answer this question.
It is better to aim for correct HTML code which adheres to the HTML5 standards so you can be sure about the presentation. There is no guarantee otherwise about what happens.

@MikeMcC399
Okay, I guess "Don't fix it if it ain't broken" isn't the right way to go here then (-;

@Ein-Tim
Best practice is to be HTML compliant. This is in the interest of best user experience. You are welcome to google the topic if you would like to learn more about why it is a worthwhile goal.

@brianebeling
You could also move this issue to a discussion. Questions:

Is it necessary to address this issue?
How could it be addressed?

I don't have the option myself to move it.

I think this is actually an issue. We should try to keep the relevant information here, so you don't have to search for it. Something more generic like "Which HTML issues should we prioritize" would be a good topic for a discussion. In this case we have something specific that is actionable though, so relevant information should also go here.

After a review of this issue it seems unlikely that it causes unwanted behaviour, considering there are other places where there is no visible change, but with the structure we want and also a small test showed no difference in Chrome. That was not on the full scale of this issue though.
This might turn out to be a bit time consuming, we will keep it on the backlog till the priorities are a bit clearer as its not breaking any functionality. Pull Requests are welcome of course.


Documentation on prior art

We did this research already, it would help others if we documented this in the README for others going through the same process.

so I started on this, but it looks like the landscape has changed so much that it's too long and would take too much effort to maintain a section in the README. So I'm going to make this a wiki page and have the README link to it.


networkStats always at -1

Hey, me again!
If naming scheme differs from _darwin ? 'en0' : 'eth0'. For instance, with systemd’s predictable network device names

Hi again, I do not really understand your question. Is it about different naming of network interfaces in OS X or is there a bug that states network is always up (as stated in the title)? Can you be more precise on the issue that you discovered? Then it would me much easier to fix that ;-)

I have a (Linux) server on which the interface is not eth0 but enp1s0f0, and with that name, it doesn't return any stats.

very clear! I need to make a small function that determines the first physical network address (which is anyway used only as a default value). You anyway can call networkStat with your interface name
networkStat(‚enp1s0f0‘, function(data) {
	…
});

Thank you for the provided link.

Am 10.06.2016 um 20:51 schrieb Buzut<EMAIL_ADDRESS>I have a (Linux) server on which the interface is not eth0 but enp1s0f0, and with that name, it doesn't return any stats.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/sebhildebrandt/systeminformation/issues/10#issuecomment-225265608, or mute the thread https://github.com/notifications/unsubscribe/AEf9iD8govOJBqkfFhsHclIaKffz47DXks5qKbIvgaJpZM4IzMVq.

Thanks!
Calling the function directly with the interface name is not as good as letting it determine the interface all alone for automation, but that'll do till you fix it.

already have an idea how to do that ;-)
will try to do it next week …

Am 10.06.2016 um 21:03 schrieb Buzut<EMAIL_ADDRESS>Thanks!
Calling the function directly with the interface name is not as good as letting it determine the interface all alone for automation, but that'll do till you fix it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/sebhildebrandt/systeminformation/issues/10#issuecomment-225268627, or mute the thread https://github.com/notifications/unsubscribe/AEf9iGj0fmSECIkv8f0jP5OUW-jGtnj5ks5qKbUGgaJpZM4IzMVq.

Finalizing V 3.0 of systeminformation where I implemented a solution for that.

Done in V3.0. Better detection of first external network interface (as a default value)


Requests go through as long as an API-KEY header is present, regardless of whether the API-KEY is valid or not

E.g, if "undefined" is passed as the API-KEY, the request still goes through. Add validation for the API-KEY.

Apologies, this was an issue in a different library.


Ability to set the classpath when running java

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

I'm playing with pulumi with some pre-baked java code, which I can invoke in the usual fashion:
runtime:
  name: java
  options:
    binary: ./build/libs/scripting-host.jar

Unfortunately, my code then fails because there is a dependency that doesn't live in that jarfile. I've tried building a fat-jar instead, but this fails for other reasons (as the code inside itself does some classpath manipulation and obviously gets the wrong answer).
It would be really nice to be able to specify the classpath when invoking, something like
runtime:
  name: java
  options:
    binary: ./build/libs/scripting-host.jar
    classpath: ./build/distributions/scripting-host/lib/guava-31.1-jre.jar:etc:etc:etc

Affected area/feature

Pulumi-java-executor

Thanks for the suggestion, @magnayn-mns.


getNextAddress is blocking

When doing
await window.marina.getNextAddress();

the entire page freezes for a couple of seconds. I would expect the page to remain usable whilst an address is being loaded.

Thanks for opening this!
Is the wallet with lot of history by any chance?

Depends on what you consider a lot.
I have generated about 1000 addresses using this wallet.

@ErikDeSmedt, is it possible to share the app code using the marina provider ?

This is the code we are using to generate the address.
let marina = await getProvider();
let address  = (await marina.getNextAddress())?.confidentialAddress;

PS:
On my current set-up the getNextAddress() resolves immediately and I cannot replicate the issue

On my current set-up

But with the same mnemonic ie. 1000+ addresses generated or a new one?

It  has the same mnemonic.
However, not all these addresses have received funds.
If I do window.marina.getAddresses() the list is considerably shorter and only contains 50 addresses.
It seems my current wallet is not aware of the generated addresses.

I managed to reproduce the behavior.
I generated 1000 address by pasting the snippet below in the chrome console. The script took approximately 40 minutes.
// Generate 1000 addresses and capture the timing
for (let iii=0;iii<1000;iii++) {
  await (async () => {
    let start = performance.now();
    await window.marina.getNextAddress();
    let end = performance.now();
    console.log({"index" : iii, "timing" : end-start});
  })();
}

It seems that genNextAddress() becomes slower if you generate more addresses.

Once the script is executed you can go into your browser console and do.
window.marina.getNextAddress();

You'll notice the tab does not respond for a couple of seconds.


bump bundler minimum version to 1.7 due to CVE-2013-0334

The resque-job-stats.gemspec file uses a pessimistic version constraint to lock the bundler version as  ~> 1.1.0. Due to the recently-announced CVE-2013-0334, it is best if all gemspecs update to 1.7.0 at a minimum.
This was caught by Gemnasium.

Thanks @ktdreyer this should be fixed as of 48717ea.


Print contract when exception happens

Coverage decreased (-0.01%) to 30.995% when pulling 2a78e06e7190171140d615669afafc165d0ec1b8 on qingweibinary:qingwei/fix_bug into 413a54e191f9dedfbd6b0f67d6570c2b87f4a39f on binary-com:master.


Client(s) should handle oversized payloads gracefully

See https://github.com/cloudflare/cloudflare-rs/issues/32
TL;DR - especially in places where large payloads are expected, Wrangler should check that the total request payload is <100MB, and/or handle the 413 response from the API, by notifying the user that they are trying to upload a too-large payload.

The worker can be fairly big and we warn about it arround ~1Mb. I don't see a case where the payload would exceed 100Mb.

this is specifically in reference to static asset uploads to KV.
On Wed, Aug 28, 2019 at 5:57 AM Sven Sauleau<EMAIL_ADDRESS>wrote:

The worker can be fairly big and we warn about it arround ~1Mb. I don't
see a case where the payload would exceed 100Mb.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/wrangler/issues/476?email_source=notifications&email_token=ABZA4PY7JFM6LCALMEU5AZLQGZKZLA5CNFSM4IQGWFLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5KXBRA#issuecomment-525693124,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZA4P5HQTBKFIJ53JJHPTDQGZKZLANCNFSM4IQGWFLA
.

--
Ashley Lewis
<EMAIL_ADDRESS>https://www.cloudflare.com/
1 888 99 FLARE  |  www.cloudflare.com

We already have 413 error support in the feat-kv-commands branch. I started a PoC of a payload size check, but I'm not sure if we want to mirror API functionality by adding this check to cloudflare-rs; after all, the API Gateway returns a 413 very quickly (it checks payload size even before the request is forwarded to the KV API Service behind the Gateway).
I think that for now, we can potentially close this issue. I'm weary of implementing duplicate logic on top of the KV API and API Gateway--this is something that could cause technical debt down the line whenever the API or the API Gateway change.

it might still be wise to do in Wrangler if only for the bucket commands (see #499 )

Got it now, it's specific for single or batch of KV object upload.

going to move to the kv additions milestone

I think #499 has superseded this ticket; shall we close this? @ashleymichal

yes, we can close this. thanks @gabbifish


OBS only lists outdated fedora releases

I tried installing sfizz on fedora 36, and OBS only offers releases for fedora 34 33 32.
(Also using the 34 release crashes reaper (native) on loading it, but idk if that's to be expected)

I added the Fedoras, you may try!


Unable to Fix issue with WillPopScope for Android

Hi there. I was trying to implement nested navigation using the Package and am unable to pop out from application in the case of BottomNavigationBar. Here is my code:
class InitialPage extends StatefulWidget {
  @override
  _InitialPageState createState() => _InitialPageState();
}

class _InitialPageState extends State<InitialPage> {
  int _selectedIndex = 0;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      bottomNavigationBar: BottomNavigationBar(
        currentIndex: _selectedIndex,
        onTap: (index) => setState(() => _selectedIndex = index),
        items: [
          BottomNavigationBarItem(
            icon: Icon(Icons.home),
            title: Text('HOME'),
          ),
          BottomNavigationBarItem(
            icon: Icon(Icons.settings),
            title: Text('SETTINGS'),
          ),
        ],
      ),
      body: CommonBottomNavigationBar(
        selectedIndex: _selectedIndex,
        childrens: <Widget>[
          NavigatorPage(),
          SettingsPage(),
        ],
      ),
    );
  }
}

Similarly the Page Handling Code:
class CommonBottomNavigationBar extends StatefulWidget {
  final int selectedIndex;
  final List<Widget> childrens;

  CommonBottomNavigationBar({
    @required this.selectedIndex,
    @required this.childrens,
  });

  @override
  _CommonBottomNavigationBarState createState() =>
      _CommonBottomNavigationBarState();
}

class _CommonBottomNavigationBarState extends State<CommonBottomNavigationBar> {
  @override
  Widget build(BuildContext context) {
    return Stack(
      children: List.generate(
        widget.childrens.length,
        (index) {
          return _buildOffstageNavigator(index);
        },
      ),
    );
  }

  Widget _buildOffstageNavigator(int index) {
    return WillPopScope(
      onWillPop: () async { <----- FROM HERE
        final isFirstRouteInCurrentTab =
            await Get.nestedKey(index).currentState.maybePop();

        // let system handle back button if we're on the first route
        return isFirstRouteInCurrentTab;     <------ TO HERE
      },
      child: Offstage(
        offstage: widget.selectedIndex != index,
        child: widget.childrens[index],
      ),
    );
  }
}

and the NavigatorPage for Nested Navigation is
class NavigatorPage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Navigator(
      key: Get.nestedKey(0),
      initialRoute: '/',
      onGenerateRoute: (settings) {
        if (settings.name == '/') {
          return GetRouteBase(
            page: HomePage(),
          );
        } else if (settings.name == '/detail') {
          return GetRouteBase(
            page: DetailPage(),
          );
        } else {
          return GetRouteBase(
            page: Scaffold(
              body: Container(),
            ),
          );
        }
      },
    );
  }
}

My Issue is in WillPopScope Call inside. I would be grateful if you could help with this.

WillPopScope must use root navigation, not the one with ID.
WillPopScope must wrapper the root widget.
Using it that way should work.

Can you provide a working code for the problem?

 Widget _buildOffstageNavigator(int index) {
    return WillPopScope(
      onWillPop: () async

and use root navigator:
final isFirstRouteInCurrentTab =
            await Get.key.currentState.maybePop();

Hi there, I did what you had suggested doing. But the output is different than what was before.
This time it gave
( 6674): [ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: Stack Overflow

would it be helpful for solving if I share the repo? I would really like to get this correct so that I can use Navigation, StateManagement, and others just using Get Package.

For Reference to the Code. Here is the Link to the Repo with the required Implementation.
Link: https://github.com/spike04/Get_Navigation

@spike04 hey!
I was wondering if you had any progress? I'm now facing the same thing and I'm trying to just use Get instead of mixing concepts.

Some contributors commented on the open issues saying that you should return false, and treat the closing event with the key, basically this way:
    onWillPop: () async {
      Get.key.currentState.maybePop();
      return false;
    },

I hope this helps you in some way, since it goes beyond the competence of this library (I would, at the very least, have to rewrite WillPopScope to have a definitive solution for this, which is not in the plans)

hey @spike04 I took a look at your code and its as @jonataslaw says, you just have to do this...
Future isFirstRouteInCurrentTab() async {
bool isFirstRouteInCurrentTab = !await Get.nestedKey(
availableChoices[currentIndex].nestedKeyValue(),
).currentState.maybePop();
return isFirstRouteInCurrentTab;
}
Where avialableChoices is a list of navigationBarItems and the nestedKeyValue is set by you per each tab.

Since the suggested solutions were posted a week ago with no response, I suppose the problem has been resolved.
Closing.

Use Flutter Navigator insted of getx route


Improving the loading skeleton bug example

In the example here https://nextjs.org/learn/dashboard-app/streaming#fixing-the-loading-skeleton-bug-with-route-groups it's claimed that

Right now, your loading skeleton will apply to the invoices and customers pages too. This is because in Next.js, files nest inside each other. Since loading.tsx is a level higher than /invoices/page.tsx and /customers/page.tsx, it's also applied to those pages.

However, given that there's no rendering or data fetching logic wired up with customers and invoices pages, it's difficult to demonstrate what this bug actually means.
I propose the following improvements to be considered:

Include a console.log inside the loading.tsx component
Instruct the user to refresh the page while visiting the other parts of the application, to confirm that the loading component does in fact gets called
Instruct the user do the same thing again after the route group creation, and notice that the console.log message doesn't appear because the loading component doesn't load

@thanosngplus thanks for the feedback, this is a good suggestion! We have a PR adding this :)


std.barrel loops on 5.3

$ LUA_INIT_5_3= lua5.3
Lua 5.3.0  Copyright (C) 1994-2015 Lua.org, PUC-Rio
> =std
nil
> require "luarocks.loader"
table: 0x1d7db00
> std= require"std".barrel()

At this point (using stdlib 41.1.0), the Lua process is consuming 100% CPU, and Ctrl+C doesn't work.

D'oh!  Thanks for the report.


/opt/arkime/bin/Configure not compatible with Arch Linux

Describe the bug
I downloaded Arkime Arch Linux package by the official website.
After the install by pacman, when I run /opt/arkime/bin/Configure, and it needs to install ElasticSearch, it will download .deb file that is not compatible with Arch Linux environment, instead of retrieving ElasticSearch package from AUR.
Furthermore, when it asks for downloading GEO files, I get the following error:
Download GEO files? You'll need a MaxMind account https://arkime.com/faq#maxmind (yes or no) [yes]
Arkime - Downloading GEO files
2023-04-22 23:06:15 URL:https://www.iana.org/assignments/ipv4-address-space/ipv4-address-space.csv [23331/23331] -> "/tmp/tmp.SP67DOUqWu" [1]
2023-04-22 23:06:15 URL:https://raw.githubusercontent.com/wireshark/wireshark/master/manuf [2120911/2120911] -> "/tmp/tmp.oePQ93VrMS" [1]
error loading configuration file /etc/GeoIP.conf: invalid account ID format: strconv.Atoi: parsing "YOUR_ACCOUNT_ID_HERE": invalid syntax
chmod: cannot access '/usr/share/GeoIP/*.mmdb': No such file or directory
chmod: cannot access '/var/lib/GeoIP/*.mmdb': No such file or directory

but I guess that here I need to register an account.
I would like also to ask if the PKGBUILD file used for creating the .zst package is available to be read.
Thank you

Describe the bug I downloaded Arkime Arch Linux package by the official website.
After the install by pacman, when I run /opt/arkime/bin/Configure, and it needs to install ElasticSearch, it will download .deb file that is not compatible with Arch Linux environment, instead of retrieving ElasticSearch package from AUR.

You'll need to just install yourself, I'll change Configure to not ask on arch

Furthermore, when it asks for downloading GEO files, I get the following error:
Download GEO files? You'll need a MaxMind account https://arkime.com/faq#maxmind (yes or no) [yes]
Arkime - Downloading GEO files
2023-04-22 23:06:15 URL:https://www.iana.org/assignments/ipv4-address-space/ipv4-address-space.csv [23331/23331] -> "/tmp/tmp.SP67DOUqWu" [1]
2023-04-22 23:06:15 URL:https://raw.githubusercontent.com/wireshark/wireshark/master/manuf [2120911/2120911] -> "/tmp/tmp.oePQ93VrMS" [1]
error loading configuration file /etc/GeoIP.conf: invalid account ID format: strconv.Atoi: parsing "YOUR_ACCOUNT_ID_HERE": invalid syntax
chmod: cannot access '/usr/share/GeoIP/*.mmdb': No such file or directory
chmod: cannot access '/var/lib/GeoIP/*.mmdb': No such file or directory

but I guess that here I need to register an account.

Yep see the message it prints out.

I would like also to ask if the PKGBUILD file used for creating the .zst package is available to be read.

Not sure what you are asking for, you can see the build in screwdriver.yaml file and the build container in release/buildArch/Dockerfile

Not sure what you are asking for, you can see the build in screwdriver.yaml file and the build container in release/buildArch/Dockerfile

Usually Arch Linux packages are created by using PKGBUILD but I see that screwdriver.yaml has the following content that seems to generate the Arch package for Arkine:
 export ARKIME_VERSION=`sed 's/.*"\(.*\)\".*$/\1/' /opt/arkime/common/version.js | head -n 1`
 /root/.local/share/gem/ruby/3.0.0/bin/fpm -s dir -t pacman -n arkime -x opt/arkime/logs -x opt/arkime/raw -v $ARKIME_VERSION --iteration $SD_BUILD_ID --template-scripts --after-install "release/afterinstall.sh" --url "https://arkime.com" --description "Arkime Full Packet System" -d libmaxminddb -d libpcap -d yara -d perl-http-message -d perl-lwp-protocol-https -d perl-json -d libnet -d lua -d zstd -d openssl-1.1 -d pcre /opt/arkime

You'll need to just install yourself, I'll change Configure to not ask on arch

Why "to not ask on arch"? Could not be better that Configure detects the OS and based on that run the correct command for installing ElasticSearch? If not, a message during the configuration could be good too.

Why "to not ask on arch"? Could not be better that Configure detects the OS and based on that run the correct command for installing ElasticSearch? If not, a message during the configuration could be good too.

No because in general we don't want folks to run elastic on the same machine, plus the Configure script is probably going away, there isn't much reason to use it anymore.


Fixes #1964 - docs for invite user without email

Coverage: 94.263%. Remained the same when pulling 3c4e3283993e6d07477e4a8a3b8f2f88af3a6236 on cody-updated-invite-docs into b14bbe1f62543ac5a7ce0bc2c6d3a4ba9b1dc82c on main.


Support Angular 16

Please add support for Angular 16

Hello @AhsanAyazAhsanAyaz,
I will take a look at this like I did for Angular 15, probably this week-end if I get time.
Have a good day.

Hello @AhsanAyazAhsanAyaz,
I will make a PR for Angular 16 (like I did for Angular 15), probably this week-end if I get time.
Have a good day.

We will wait for that @Yberion thanks for your work! :)


add Content-Length header when returning xmls

(I copy the text from https://github.com/nextcloud/server/issues/3724, since they tell me to place it here)
Steps to reproduce

make a request like https://nextcloud.example.com/remote.php/dav/addressbooks/users/juza/contacts/
take a look at response headers
"content-type:application/xml; charset=utf-8" presents, but there is no header about the content length :)

Expected behaviour
Content-Length should present, so nginx could compress the response with gzip
Actual behaviour
No headers make nginx ignore compressing. My nextcloud server is run at home, where I have only 5 Mbps of upload speed, so the list of contacts is being downloaded for 3 annoying sec
Server configuration
Nextcloud version: (see Nextcloud admin page) 11.0.2
Contacts version: (see Nextcloud apps page) 1.5.3

Hi,
This is not happening, because it will prevent us from streaming the response to the client. We're moving towards a streaming model, and we can't predict how big the xml responses will be when we start sending headers.


How to generate the file 'oas_paired_10k_single_direction_4search_v2.fa'?

Thanks for the amazing work!
When I'm following the data-pipeline/README.md to process files, I cannot find the step about how to generate the file oas_paired_10k_single_direction_4search_v2.
Do  the file oas_paired_10k_single_direction_4search_v2 and oas_paired_10k_bothdirections_v2.fa have the same content in the step to generate the OAS filter validation set.
# Write the validation sequences in single direction format for MMseqs2 search
with open('oas_paired_10k_single_direction_4search_v2.fa', 'w') as f:
    for index, row in df_clustered_full_10k.iterrows():
        f.write(">")
        f.write(row['uuid'] + "_lc" + "\n")
        f.write(row['sequence_alignment_aa_light'] + "\n")
        f.write(">")
        f.write(row['uuid'] + "_hc" + "\n")
        f.write(row['sequence_alignment_aa_heavy'] + "\n")

Sorry, I made a mistake. The code is correct.


[v2.9] Use the userClient instead of userCache when cleaning up auth provider users

Issue:

Problem

Solution

Testing

Engineering Testing
Manual Testing

Automated Testing

Test types added/modified:

Unit
Integration (Go Framework)
Integration (v2prov Framework)
Validation (Go Framework)
Other - Explain: EXPLAIN
None
REMOVE NOT APPLICABLE BULLET POINTS ABOVE

If "None" - Reason: EXPLAIN THE REASON

If "None" - GH Issue/PR: LINK TO GH ISSUE/PR TO ADD TESTS

Summary: TODO
QA Testing Considerations

Regressions Considerations

TODO
Existing / newly added automated tests that provide evidence there are no regressions:

TODO

https://github.com/rancherlabs/embargoed-security/issues/558


"No Client Identifier Found"

I have setup IdentityServer4 and it works fine as long as I use Postman to obtain access tokens (using resource owner grant), however, when I send the exact same request within a javascript application, I get a 400 bad request on the browser console and the following error in the IdentityServer console:

"No client identifier found". Here is the request sent in Typescript, using exact same parameters and values as I use in my Postman:
`let head = new Headers({
'content-type': 'application/x-www-form-urlencoded'
});
let options = new RequestOptions({
headers: head
});
let body = JSON.stringify({
"grant_type":"password",
"username": "behrooz66",
"client_id": "resourceOwner",
"client_secret": "secret",
"password": "bbcliqa",
"scope": "api offline_access"
});
  let x = this._http.post("http://localhost:5000/connect/token", body, options)
        .map(res => res.json());
  return(x);`

Any ideas?

hmm, 5m from open to close. so what was it?

Sorry, I realized the format of the body is not right. My bad :(

why dont you say your fix then

https://stackoverflow.com/questions/43912622/identity-server-4-getting-invaid-client-error


Molecular Weight Calculator

Enter calculator name -
Molecular Weight Calculator
Describe calculator functionality -
Known the atomic weights of the elements of the compound, the Molecular Weight Calculator as the name suggests calculates the weight of the chemical compound provided, it is valid.
Under which category you wish to place it -

[ ] Computer Science
[ ] Mathematics
[ ] Physics
[x] Chemistry
[ ] Biology
[ ] Art
[ ] Finance
[ ] Scientific
[ ] Health
[ ] Sports
[x] Let project owner decide
[ ] Suggest a new category - (Answer here)

Kindly assign it to me

This issue has already been covered.


Puma Restarts End in Framework Load Error

Description
When deploying a Rails application with Capistrano and Puma we will get the error NameError: uninitialized constant NewRelic::Control::Frameworks::RailsNotifications. A redeploy will fix it. Basically, we are forced to deploy the app twice to resolve the issue. We have several other applications on the same stack that do not have this problem.
Expected Behavior
Puma should restart without any NewRelic errors
Troubleshooting or NR Diag results
NameError: uninitialized constant NewRelic::Control::Frameworks::RailsNotifications
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/newrelic_rpm-6.13.1/lib/new_relic/control/class_methods.rb:52:in `const_get'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/newrelic_rpm-6.13.1/lib/new_relic/control/class_methods.rb:52:in `load_framework_class'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/newrelic_rpm-6.13.1/lib/new_relic/control/class_methods.rb:32:in `new_instance'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/newrelic_rpm-6.13.1/lib/new_relic/control/class_methods.rb:13:in `instance'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/newrelic_rpm-6.13.1/lib/newrelic_rpm.rb:41:in `block in <class:Railtie>'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:32:in `instance_exec'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:32:in `run'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:61:in `block in run_initializers'
  /home/capuser/.rbenv/versions/2.5.1/lib/ruby/2.5.0/tsort.rb:228:in `block in tsort_each'
  /home/capuser/.rbenv/versions/2.5.1/lib/ruby/2.5.0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
  /home/capuser/.rbenv/versions/2.5.1/lib/ruby/2.5.0/tsort.rb:431:in `each_strongly_connected_component_from'
  /home/capuser/.rbenv/versions/2.5.1/lib/ruby/2.5.0/tsort.rb:349:in `block in each_strongly_connected_component'
  /home/capuser/.rbenv/versions/2.5.1/lib/ruby/2.5.0/tsort.rb:347:in `each'
  /home/capuser/.rbenv/versions/2.5.1/lib/ruby/2.5.0/tsort.rb:347:in `call'
  /home/capuser/.rbenv/versions/2.5.1/lib/ruby/2.5.0/tsort.rb:347:in `each_strongly_connected_component'
  /home/capuser/.rbenv/versions/2.5.1/lib/ruby/2.5.0/tsort.rb:226:in `tsort_each'
  /home/capuser/.rbenv/versions/2.5.1/lib/ruby/2.5.0/tsort.rb:205:in `tsort_each'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:60:in `run_initializers'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/railties-<IP_ADDRESS>/lib/rails/application.rb:361:in `initialize!'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/railties-<IP_ADDRESS>/lib/rails/railtie.rb:190:in `public_send'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/railties-<IP_ADDRESS>/lib/rails/railtie.rb:190:in `method_missing'
  /var/www/onlineu/current/config/environment.rb:5:in `<top (required)>'
  /var/www/onlineu/current/config.ru:3:in `require'
  /var/www/onlineu/current/config.ru:3:in `block in <main>'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/rack-2.2.2/lib/rack/builder.rb:116:in `eval'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/rack-2.2.2/lib/rack/builder.rb:116:in `new_from_string'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/rack-2.2.2/lib/rack/builder.rb:105:in `load_file'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/rack-2.2.2/lib/rack/builder.rb:66:in `parse_file'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/puma-3.12.0/lib/puma/configuration.rb:318:in `load_rackup'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/puma-3.12.0/lib/puma/configuration.rb:243:in `app'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/puma-3.12.0/lib/puma/runner.rb:145:in `load_and_bind'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/puma-3.12.0/lib/puma/single.rb:96:in `run'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/puma-3.12.0/lib/puma/launcher.rb:184:in `run'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/puma-3.12.0/lib/puma/cli.rb:78:in `run'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/gems/puma-3.12.0/bin/puma:10:in `<top (required)>'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/bin/puma:23:in `load'
  /var/www/onlineu/shared/bundle/ruby/2.5.0/bin/puma:23:in `<top (required)>'
=== puma startup: 2020-10-02 16:44:38 +0000 ===

Steps to Reproduce

Deploy the application via Capistrano
One of the Puma instances will fail to restart
Redeploy the application
Puma instances will start fine from a new daemonized process

Your Environment

newrelic_rpm (<IP_ADDRESS>7) and newrelic_rpm (6.13.1) (bumping the version did not help resolve the problem)
Ruby 2.5.1
Rails <IP_ADDRESS>

Additional context
Add any other context about the problem here. For example, relevant community posts or support tickets.

Hi, @ggennrich. Thanks for reaching out to us. I'm sorry to hear you're having this issue - we appreciate you letting us know so we can dig into it with you.
The error you’re seeing is happening very early on when the agent is installing. I’ve narrowed the problem down to this line. On that first deploy, the agent is not able to properly require the file it needs to set up Rails instrumentation. My suspicion is that for some reason, the $LOAD_PATH is different between the first and second deploys.
Some questions for you:

Has anything recently changed in your deploy scripts that may not be fully establishing the environment or is changing the $LOAD_PATH during deploys?
Are you changing paths or symlinking where gem libraries are involved in one of your deploy steps?
Finally, are you using phased puma restarts?

Hi, @rachelleahklein. Thanks for the reply! Here are the answers:

No. The same deploy script is used to deploy to 4 instances but only 2 of the instances are having this issue and only one app (we have several others that deploy fine on all 4 instances)
Not that I can tell
Yes

Appreciate the help!

@ggennrich, thanks for answering those questions.  Your answers lead us to some more targeted line of questions:

Has this been an ongoing issue for some time or did it start with a recent upgrade of the agent?

If it started recently with an agent upgrade, can you elaborate on what the prior version of the Agent was?

Are you deploying with Capistrano?  If so, what version?
Lastly, we asked about phased puma deploys, because there are a number of issues raised (and resolved) with phased Puma deploys, so some research there may help your case.
Although I didn't see anything in Rails changes for your series that would point to a load issue, it may still be worthwhile upgrade to <IP_ADDRESS> as other gems Rails depends on were also updated along the way: https://github.com/rails/rails/compare/v<IP_ADDRESS>...v<IP_ADDRESS>

We are closing this issue since we did not receive a response.  If this situation continues to be an issue, please open a new ticket.


Add global constants to classify tags by type

Per the (lengthy) discussion in #157 , implements the proposed global constants to classify tags by type, making the code and tests slightly simpler and more robust, and enabling external tools consuming them to differentiate between tag types without resorting to hardcoding.
Also adds a test that all tags from each group are included in the list of all tags, and expands the existing basic tags test to at least one tag from each group.
I'm happy to change the names chosen for the constants if the currently selected ones are problematic, just let me know, thanks!
Resolves #157

@asottile I assume you dropped the FORMAT_TAGS constant due to the (extremely small but non-zero) runtime cost of generating it, given that consuming code can derive it from the existing constants (under assumptions regarding the other tag types that are likely to be invariant over the foreseeable future)?

@asottile I assume you dropped the FORMAT_TAGS constant due to the (extremely small but non-zero) runtime cost of generating it, given that consuming code can derive it from the existing constants (under assumptions regarding the other tag types that are likely to be invariant over the foreseeable future)?

I dropped it because it's unnecessary

Right, for the reason mentioned above?

Also, where's my cat? You know the only reason I do these PRs is for the adorable cat GIFs, right? :laughing:


frame not work when using bit framework

hi,
i use bit framework for using datepicker but when install bit framework from nuget then frame in design not worked please see the attach images.
first image its befor install bit framework and second image its after that.
img1

img2

Could you please submit a simple app which reproduces this?

i create new project and now its worked very well
but why in other project i have this problem?

You've to make two projects identical step by step!


Support port filter when -net=host

We need explicit port filter when -net=host
Probably
$ docker -e constraint:port=80 would be override this.

Need to run $ docker --net=host to check if the post binding info knows about native port or not.


onMetaData: videocodecid not defined for HEVC, VP9 and AV1

Hi,
I am really glad a new version of RTMP is coming 🙏
In the FLV spec, there is a field in onMetaData called videocodecid where the codec was specified:
videocodecid: Number: Video codec ID used in the file (see E.4.3.1 for available CodecID values)

with CodecID:
Codec Identifier. The following values are defined: 2 = Sorenson H.263
3 = Screen video
4 = On2 VP6
5 = On2 VP6 with alpha channel 6 = Screen video version 2
7 = AVC

Unfortunately, in the current version of enhancements of RTMP spec, there is no mention of onMetaData's videocodecid field.
Is it something missing or is it because onMetaData is not really useful?
Best regards,
Thibault

Heya Thibault,
That is an interesting topic. The onMetaData marker is not always guaranteed to be there. That said it does not mean that we should not enhance onMetaData in conjunction with the latest rtmp updates. I will take a closer look. Out of curiosity how do you use the callback and do you use all the properties that the callback delivers?

Hi,
Sorry to say that I won't answer your question because I am focusing on the emitter part. I just noticed that videocodecid was missing when I tried to implement enhanced RTMP in my emitter library.
But one day, someone asks to add info in the onMetaData, so at least few people requires this marker.

clarification of the above: the Enhanced RTMP spec defines the Video FourCC as a UI32 (rather than, say, UI8[4]), and FourCCs are usually interpreted as unsigned 32-bit integers out in the world anyway. since an onMetaData's videocodecid is already a Number, which has the precision to represent any UI32, and any codec ID that was a fourCC would be unambiguous with the existing codec ID space <= 15, it seems the most natural to just use the fourCC integer value as the videocodecid. any program that cares about the videocodecid in an onMetaData and knew about Enhanced RTMP would probably just have numeric definitions for the new enhanced codec IDs, maybe with a comment saying where those numbers came from.

We probably will not overload the meaning of videocodecid and instead provide a new property which will identify fourCC via a string (i.e. same style as in fourCcList property, see NetConnection connect command)

We probably will not overload the meaning of videocodecid and instead provide a new property which will identify fourCC via a string (i.e. same style as in fourCcList property, see NetConnection connect command)

Hi,  I'm sad to tell you that, at this moment,  we can not guess whether the video codec is  H264 or H265 from obs.
Obs send metadata with videocodecid of 7 when push a H265 rtmp stream:

And obs did not set fourCcList in  NetConnection connect command:

So when i am implementing enhanced-RTMP, i am very confused whether the stream is H264 or H265.
Rtmp metadata will becoming dispensable, it can even lead to ambiguity.
So I strongly recommend adding a field in metadata that indicates the correct codecid.

We probably will not overload the meaning of videocodecid and instead provide a new property which will identify fourCC via a string (i.e. same style as in fourCcList property, see NetConnection connect command)

Hi, I'm sad to tell you that, at this moment, we can not guess whether the video codec is H264 or H265 from obs. Obs send metadata with videocodecid of 7 when push a H265 rtmp stream:
And obs did not set fourCcList in  NetConnection connect command:
So when i am implementing enhanced-RTMP, i am very confused whether the stream is H264 or H265. Rtmp metadata will becoming dispensable, it can even lead to ambiguity.
Also, what videocodeid should be used for vp9 and av1?
So I strongly recommend adding a field in metadata that indicates the correct codecid.
Thanks, Best regards.

Yes, this is a known issue in the onMetadata callback and there is a plan to address it in the future. When parsing the bitstream are you able to look at the FourCC value which signals the current codec (see ExVideoTagHeader Description)?

i'd like to draw attention to Discussion #19 "Enhanced RTMP & FLV test/sample media, clients, and servers for validation and interop". this is a case where attempting interoperation with different tools and media would surface issues like this earlier.
no matter what, the onMetaData videocodecid shouldn't be 7 if the codec is actually HEVC. i think the right thing to do for this specific case is to file a bug report for OBS.

Yes, this is a known issue in the onMetadata callback and there is a plan to address it in the future. When parsing the bitstream are you able to look at the FourCC value which signals the current codec (see ExVideoTagHeader Description)?

Yes, we can discriminate H264 or H265 from VideoTagHeader by FourCC value.
But skip the metadata will caused some issues, such as delay increasement.
By the way, if metadata declare an incorrect vidoecodecid, this is not rigorous.
How about set videocodecid to zero and add a FourCC string value in metadata?

How about set videocodecid to zero and add a FourCC string value in metadata?

Yes what is what we are thinking as well. Note: it is legal to not have videocodecid property in the onMetadata SCRIPTDATA Tag.  Which means we can to return a string representing the FourCC codec and not have videocodecid property present.

@xia-chu let us know if you have some flv content which would be ok to share to test this issue. thanks!

Yes what is what we are thinking as well. Note: it is legal to not have videocodecid property in the onMetadata SCRIPTDATA Tag. Which means we can to return a string representing the FourCC codec and not have videocodecid property present.

If have no videocodecid in metadata, it may be mistaken for not having a video, i don't think this is appropriate.
An unsupported videocodecid is better than the absence of a videocodeid.

let us know if you have some flv content which would be ok to share to test this issue. thanks!

I can generate a flv file withmetadata which videocodecid id is 0 and videoFourCC is hvc1 if you want.

I can generate a flv file withmetadata which videocodecid id is 0 and videoFourCC is hvc1 if you want.

i strongly recommend against having a videocodecid property that's 0, since traditional codec ID 0 is "None". instead i reiterate my suggestion above: since Enhanced RTMP fourCC codec IDs are already numbers by definition (they're defined to be UI32 in the spec), that for purposes of the videocodecid, saying "video codec<PHONE_NUMBER> is HEVC" is the same effort as saying "video codec 7 is AVC".
in other words, the new fourCCs are already compatible with and a natural fit for the current way videocodecid works and is used.

let us know if you have some flv content which would be ok to share to test this issue. thanks!

I can generate a flv file withmetadata which videocodecid id is 0 and videoFourCC is hvc1 if you want.
Hi,

having a codec id of zero is problematic. In pre 2023 flv file spec audio/video codec ids are defined via 4 bit values. So zero either has a meaning or is reserved. For instance audiocodecid of zero (yes, we working on enhancing audio codecs as well...) stands for linear pcm, platform endian).
Given all the comments in this thread, as already suggested earlier we are now leaning towards encoding a FoucCC value in videocodecid property when dealing with enhanced-RTMP codecs. This should work since we only need 32 bits for a FourCC value and an AMF0 Numbers have more than 32 bits to encode an integer value. Further out we will mimic the same behavior on the audio side. Stay tuned for a description in the spec to formally align.

we are now leaning towards encoding a FoucCC value in videocodecid property when dealing with enhanced-RTMP codecs

This is also acceptable， thanks for your work.

Closing the issue. We added new onMetaData section in the spec. videocodecid property MUST now be set to a FOURCC value (per enhanced-RTMP spec) when video codec is signaled via FourCC.


Make cs setup install scala-cli

It would be really nice if cs setup also installed scala-cli
See https://github.com/VirtusLab/scala-cli/issues/904
Including scala-cli in cs setup can be done prior to the potential/eventual promotion of scala-cli to scala. With both the traditional scala runner and scala-cli on path more people can start to play with scala-cli as soon as they have installed the currently official scala via the Coursier installers, without having to go to the scala-cli install page.

@alexarchambault What is the process that defines which applications are installed? In the documentation it says that it installs a number of applications, but there is no link to the exhaustive list. It would be useful to know which applications are installed, and several stakeholders should be consulted to update that list of apps.

Probably, this is covered by #2415 ?

Fixed by https://github.com/coursier/coursier/pull/2415, yep.

:tada: :rocket: :heart:


ios-deploy 1.9.2 is installed but required

Steps to Reproduce
When running flutter doctor command, I got some warnings, especially one about my ios-deploy version that is not updated.
[!] iOS toolchain - develop for iOS devices (Xcode 9.3)
    ✗ ios-deploy out of date (1.9.2 is required). To upgrade:
        brew upgrade ios-deploy

But when running the upgrade: Error: ios-deploy 1.9.2 already installed.
Logs
No need.
Flutter Doctor
[✓] Flutter (Channel beta, v0.1.5, on Mac OS X 10.13.4 17E160e, locale fr-FR)
    • Flutter version 0.1.5 at /Users/Hugo/flutter
    • Framework revision 3ea4d06340 (8 days ago), 2018-02-22 11:12:39 -0800
    • Engine revision ead227f118
    • Dart version 2.0.0-dev.28.0.flutter-0b4f01f759

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.io/setup/#android-setup for detailed instructions).
      If Android SDK has been installed to a custom location, set $ANDROID_HOME to that location.

[!] iOS toolchain - develop for iOS devices (Xcode 9.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.3, Build version 9Q117m
    • ios-deploy 1.9.1
    ✗ ios-deploy out of date (1.9.2 is required). To upgrade:
        brew upgrade ios-deploy
    • CocoaPods version 1.4.0

[✗] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.io/setup/#android-setup for detailed instructions).

[✓] VS Code (version 1.20.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Dart Code extension version 2.9.2

[!] Connected devices
    ! No devices available

! Doctor found issues in 4 categories.

Paste the output of running flutter doctor -v here.
I'm using Xcode 9.3 on macOS 10.13.4.

cc @xster @cbracken

@TorzuoliH Thanks for reporting this.
Based on the doctor output (• ios-deploy 1.9.1), It looks like you have version 1.9.1 installed. It sounds like running brew upgrade ios-deploy isn't working.
To resolve this, can you run the following commands and log the output here?

brew --version
brew info ios-deploy
brew update (older versions of homebrew require this)
brew upgrade ios-deploy (I assume this may give the same error as before)
brew info ios-deploy (again, just so we can see if it's now 1.9.2)
brew upgrade (if the above upgrade didn't get ios-deploy up to date, hopefully this did)

If you're still seeing the doctor error after the above, can you try this and paste the output?
brew reinstall ios-deploy

I'm using Xcode 9.2 on macOS 10.13.3.
I was getting the same error. I ran brew reinstall ios-deploy which displayed the following:
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/ios-deploy
Target /usr/local/bin/ios-deploy
already exists. You may want to remove it:
  rm '/usr/local/bin/ios-deploy'

To force the link and overwrite all conflicting files:
  brew link --overwrite ios-deploy

To list all files that would be deleted:
  brew link --overwrite --dry-run ios-deploy

Then, once I ran brew link --overwrite ios-deploy the error disappeared when running flutter doctor

Hello guys, sorry, haven't time to test with your instructions.
Thanks @UltimoTG, I will do the same on my side and confirm that it's well working :)

@cbracken

Homebrew 1.5.7

ios-deploy: stable 1.9.2 (bottled), HEAD

Done

Same error

ios-deploy: stable 1.9.2 (bottled), HEAD

Still got the error when flutter doctor

By doing brew reinstall ios-deploy I got error too, so I tried brew link --overwrite ios-deploy and it worked!
Output: Linking /usr/local/Cellar/ios-deploy/1.9.2... 3 symlinks created
Thanks to @UltimoTG 😄

@UltimoTG  I followed all the mentioned steps but i found that some of the developer might not given allowed for the developer mode so below is the command which i used to resolve the issue.
       sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer

Abhisheks-MBP:~ minduses$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v0.2.8, on Mac OS X 10.13.4 17E199, locale en-IN)
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 9.3)
[✓] Android Studio (version 3.1)
[✓] Connected devices (1 available)

Hope it might help . others.

Thanks @androidheight . At last, your stuff worked.

I face the same problem to , but my problem is i forgot i'm already install ios-deploy before through nodejs npm, so ,,,, I'm very confuse get the error below
 • ios-deploy 1.8.6
    ✗ ios-deploy out of date (1.9.4 is required). To upgrade with Brew:
        brew upgrade ios-deploy

solution is just uninstall it by
npm uninstall -g ios-deploy
hope it helps ...

解决方案：
npm uninstall -g  ios-deploy
忘记自己之前安装过，所以执行这条命令即可，取消全局安装

I've tried all the above with no success. not the greatest of onboarding experiences for Flutter so far.. :-(
i know my iOS and Android native environments are fine as I develop in them all the time.
➜ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.14.1 18B75, locale en-AU)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
[!] iOS toolchain - develop for iOS devices (Xcode 10.1)
✗ ios-deploy out of date (1.9.4 is required). To upgrade with Brew:
brew upgrade ios-deploy
[✓] Android Studio (version 3.2)
[!] VS Code (version 1.30.1)
[✓] Connected device (1 available)
➜ brew upgrade ios-deploy
Error: ios-deploy 1.9.4 already installed

@ajonno did you try https://github.com/flutter/flutter/issues/15082#issuecomment-370883723 ?

run:
npm uninstall -g ios-deploy
display:
dyld: Library not loaded: /usr/local/opt/icu4c/lib/libicui18n.58.dylib
Referenced from: /usr/local/bin/node
Reason: image not found
Abort trap: 6
how to solve it ?

In my case I couldn't remove the package using npm uninstall for whatever reason, so I located the package:
$: identify ios-deploy
And then forcefully removed it
$: rm -rf ~/.npm-packages/lib/node_modules/ios-deploy/
It was finally gone by then, I re-installed it using homebrew and it worked like a charm.
Using Mojave


Another Race Condition

If you send an message(emqttd:publish(Msg) or emqttd_client:publish(Msg)) in hook 'client.subscribe.after' makes an race with
emqttd_server:pubsub_subscribe_ which calls emqttd_pubsub: async_subscribe(Topic, SubPid) and
this calls emqttd_trie:insert, trie is needed by publish to route!
Solution i guess:

call emqttd_pubsub: subscribe(Topic, SubPid) which is sync instead of
emqttd_pubsub: async_subscribe(Topic, SubPid) or
we hook a new one called subscribed in emqttd_router add_route!

Hints?

@obi458, it's not race condition. The SUBSCRIBE is asynchronous.

Ok, what i need is to send(from a plugin) a message to a client, the plugin! makes the subscription like
the  {"$Q/username/$u", 1} subscription, but there is no way to notify the subscription is done(sync)!

Use the 'client.subscribe.after' hook:
on_client_subscribe_after(ClientId, TopicTable, _Env) ->
    io:format("client ~s subscribed ~p~n", [ClientId, TopicTable]),
    self() ! {dispatch, Topic, Msg},
    {ok, TopicTable}.

Template code:
https://github.com/emqtt/emqttd_plugin_template/blob/master/src/emqttd_plugin_template.erl

Ok, this solve how to send a message, if sessions the calling process.
Nice would be if there is a notify if the subscription is completed at the end of add_subscriber_.

@obi458 The design of async subscribe is a bit confusing, I think. Any suggestions?

I will think about it, now 2 weeks holiday :-)


Supervised ml bk

Finished Peakidentify
increased accuracy of supervised ML with all calibration files
made formic acid specific supervised ML
made regression of supervised ML
still having trouble with one test on test_interpolate.py

This was merged by user, but review happened in person with team.


[DOCS] Improve README.md

There are a bunch of grammar issues, and I feel like it doesn't state exactly what this project is so I would like if someone would help me improve the README.md but adding sections, improving grammar, etc.

can I work on this?

can I work on this?

sure!

Are there any contributing guidelines that need to be included?

Are there any contributing guidelines that need to be included?

No, I will do it myself once #3 is done.

ok

Hi! There are minor grammatical errors that can be fixed and the ReadMe can become a bit more interesting!
Also, it would be awesome if you can post screenshots or maybe some pictures that could describe the game if that is possible :)

Hi, can you work on the grammar errors.
Yeah, I will add a screen recording and a few snaps in a bit of the game,
thanks for your suggestion.
On Sat, 20 Aug 2022 at 12:16, Krupali Trivedi @.***>
wrote:

Hi! There are minor grammatical errors that can be fixed and the ReadMe
can become a bit more interesting!
Also, it would be awesome if you can post screenshots or maybe some
pictures that could describe the game if that is possible :)
—
Reply to this email directly, view it on GitHub
https://github.com/KendallDoesCoding/Choose-Your-Own-Adventure-Game/issues/1#issuecomment-1221245211,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGJUTNTANQD4JXHXFVLE4TV2B5M5ANCNFSM56H5HH5Q
.
You are receiving this because you authored the thread.Message ID:
<KendallDoesCoding/Choose-Your-Own-Adventure-Game/issues/1/1221245211@
github.com>

Hi, can you work on the grammar errors. Yeah, I will add a screen recording and a few snaps in a bit of the game, thanks for your suggestion.
…
On Sat, 20 Aug 2022 at 12:16, Krupali Trivedi @.***> wrote: Hi! There are minor grammatical errors that can be fixed and the ReadMe can become a bit more interesting! Also, it would be awesome if you can post screenshots or maybe some pictures that could describe the game if that is possible :) — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTNTANQD4JXHXFVLE4TV2B5M5ANCNFSM56H5HH5Q . You are receiving this because you authored the thread.Message ID: <KendallDoesCoding/Choose-Your-Own-Adventure-Game/issues/1/1221245211@ github.com>

Hi! I would love to work on the editing :) thank you!

Will close this issue after I add the screenshots.

@krupalitrivedi I tried to include a example video but it's not showing like I see in other repos
Commits:
1- fdaa09b962dbc7c475035078a1a776a92269670c
2 - 07ba35c557d8221698814b84c9e5fe1a4e30e03d

@KendallDoesCoding When i tried putting the video through 'drag and drop' method, I was able to see it, but when I tried putting it through internal linking, it isn't working. Working on the same rn and will let you know as soon as possible!

I think I've made a issue in the README embedding it or the file format is wrong, mkv is surely wrong, so I made it mov, maybe it needs to be mp4?

@KendallDoesCoding When i tried putting the video through 'drag and drop' method, I was able to see it, but when I tried putting it through internal linking, it isn't working. Working on the same rn and will let you know as soon as possible!

I think I've made a issue in the README embedding it or the file format is wrong, mkv is surely wrong, so I made it mov, maybe it needs to be mp4?

@KendallDoesCoding no no mov is fine, i was able to embed it into your readme! I'm trying to figure out the problem with internal problem

oh wow! this is exactly what I wanted, can you make a PR please?
On Fri, 26 Aug 2022 at 21:31, Krupali Trivedi @.***>
wrote:

@KendallDoesCoding https://github.com/KendallDoesCoding When i tried
putting the video through 'drag and drop' method, I was able to see it, but
when I tried putting it through internal linking, it isn't working. Working
on the same rn and will let you know as soon as possible!
I think I've made a issue in the README embedding it or the file format is
wrong, mkv is surely wrong, so I made it mov, maybe it needs to be mp4?
@KendallDoesCoding https://github.com/KendallDoesCoding no no mov is
fine, i was able to embed it into your readme! I'm trying to figure out the
problem with internal problem
[image: unknown.png]
https://user-images.githubusercontent.com/99717469/186945680-e224e70a-3837-4bd8-b17b-446816379720.png
[image: unknown (1).png]
https://user-images.githubusercontent.com/99717469/186945914-2e864d17-8d35-4c0b-83b7-0a75cb313bc1.png
—
Reply to this email directly, view it on GitHub
https://github.com/KendallDoesCoding/Choose-Your-Own-Adventure-Game/issues/1#issuecomment-1228672102,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGJUTOSO6UNZ47W4YN2RGLV3DS7BANCNFSM56H5HH5Q
.
You are receiving this because you were mentioned.Message ID:
<KendallDoesCoding/Choose-Your-Own-Adventure-Game/issues/1/1228672102@
github.com>

May need to trim the video down a little bit, but for now it's fine.. Thanks @krupalitrivedi and @athulmekkoth for helping improve the README :)))


Add mark/unmark as downloaded commands.

Wrap choosing a list of entries ina  helper function.
ZFill numbers in sub selector list for convenience.
Clean up some code and code style.
Remove option of not overwriting file on download.
Rely upon feed_state_dict = if something is in there, don't download.
Mark+Unmark allow messing with feed_state_dict on user side.
Fix off-by-one in enqueing.
Pull min/max filter out into sub class level.
Mark, unarmk, and enqueue all use that logic.
Bump to 1.0.0, ahead of actual tag release hopefully by end of year.

Changes Unknown when pulling 4e89fdfcc7628d6e11faf0d486011cf56fc895a2 on feature/12-mark-unmark into ** on master**.


Issue with polygon merging

Hi,
I am having issue with polygons merging.
If a create a bunch of polygons as:
# Make a bunch of rectangles
tot = []
tot.append(np.array([[  -5., -100.],
                     [   5., -100.],
                     [   5.,  100.],
                     [  -5.,  100.]]))

tot.append(np.array([[  45., -100.],
                     [  55., -100.],
                     [  55.,  100.],
                     [  45.,  100.]]))

tot.append(np.array([[-100.,   -5.],
                     [ 100.,   -5.],
                     [ 100.,    5.],
                     [-100.,    5.]]))

tot.append(np.array([[-100.,   45.],
                     [ 100.,   45.],
                     [ 100.,   55.],
                     [-100.,   55.]]))

I obtain this:

If I "merge" the polygons to have only one left as:
# Execute the  merge
pc = pyclipr.Clipper()
pc.scaleFactor = int(1000)

pc.addPaths(tot, pyclipr.Subject)

tot = pc.execute(pyclipr.Union,
                pyclipr.FillRule.EvenOdd)

I get this:

You can remark the holes at the intersections of the polygons.
I was expected something like this:

Which is something I get by using Klayout and click on: edit -> selection -> merge

If you can help me to get the same result as with Klayout that would be really helpful.

You probably want FillRule.NonZero
See the docs here:
https://www.angusj.com/clipper2/Docs/Units/Clipper/Types/FillRule.htm

Unfortunately no.
When I use FillRule.NonZero, I got:

Is is, in fact, a known issue, see this discussion: https://github.com/AngusJohnson/Clipper2/discussions/820.


Ability to specify backup directory

Original absolute path is "appended" to the destination backup folder. Column is replaced with "_drive". Not distinguishing between Windows and the rest. So Linux path or file name containing column might be renamed unnecessarily but seems like a reasonable tradeoff for simplicity.

@arykov Backup now use single .zip files, and support restoration. Sorry, I will close this PR.


Rename max.retries setting

Description
Simply rename a global setting name to a more descriptive one:
max.retries to vm.ha.migration.max.retries
Also, as it is used in global context, have changed the scope from Cluster to Global.
This setting has been introduced before 4.14, so no need to update DB on upgrade
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

LGTM
the setting did not exist previously, so nothing to handle in the upgrade path SQL files...

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1041

@blueorangutan test

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1236)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38758 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3960-t1236-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_05_deploy_and_upgrade_kubernetes_ha_cluster
Failure
1059.84
test_kubernetes_clusters.py

just checking if the kubernetes error is persistent.
@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Will probably wait for tests to complete before the code freeze, unless you are 100% sure @shwstppr that we can proceed?

Tests are complete from the previous run where shwstppr (author of the failing test) has confirmed it's not realted to this PR.
Nevertheless, new tests.
This PR is allowed to be merged after the currently running tests complete (in sense of the code freeze fof 4.14)

Trillian test result (tid-1240)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35656 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3960-t1240-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

2 x LGTMS, test results passing,
merging.


Expose DataFusion Extensible Optimizer

We're considering the adoption of DataFusion as a replacement for our custom query planner and plan optimizer. However this would require the ability to extend the Optimizer with custom optimization rules given some domain specific operations.
From perusing this repo I could not establish whether this ability is exposed in the java bindings. If this capability does in fact exist, a quick pointer to the relevant class would be much appreciated.

We're considering the adoption of DataFusion as a replacement for our custom query planner and plan optimizer. However this would require the ability to extend the Optimizer with custom optimization rules given some domain specific operations.
From perusing this repo I could not establish whether this ability is exposed in the java bindings. If this capability does in fact exist, a quick pointer to the relevant class would be much appreciated.

can you demo some pseudo code if you were able to do that?

Are you trying to understand the interface that I am envisaging, or are you interested in the internals of a custom optimizer that we'd wish to implement?


TODO/FIXME Count 15

[ ] TODO: test w/custom logger that writes to string, not file
Commit: (ccfc29d) Setup test suite with bedrock-test@4.
File:  tests/mocha/test.js:642
Matthew Collier commented 8 months ago

[ ] TODO: add test that adds logger early
Commit: (ccfc29d) Setup test suite with bedrock-test@4.
File:  tests/mocha/test.js:636
Matthew Collier commented 8 months ago

[ ] FIXME: rework this error handling and callers
Commit: (257fcd7) Use wrapper for loggers.
File:  lib/loggers.js:270
Dave Longley commented 5 years ago

[ ] TODO: run in parallel
Commit: (749029d) Convert remaining async lib use to promises.
File:  lib/loggers.js:202
David I. Lehn commented 8 months ago

[ ] TODO: simplify with cluster.on('online')?
Commit: (37cb19c) Add bedrock-cli feature.
File:  lib/bedrock.js:509
Dave Longley commented 5 years ago

[ ] FIXME: use child logger
Commit: (c2f318c) Use workaround for master/worker child logger.
File:  lib/bedrock.js:452
David I. Lehn commented 7 months ago

[ ] TODO: does this need adjusting after fixing the worker cwd issue?
Commit: (3fba9c5) Reorganize code into functions; fix bug with runOnce notifications.
File:  lib/bedrock.js:377
Dave Longley commented 5 years ago

[ ] FIXME: use child logger
Commit: (c2f318c) Use workaround for master/worker child logger.
File:  lib/bedrock.js:371
David I. Lehn commented 7 months ago

[ ] FIXME: v2.0.0: remove warning and default and throw exception .
Commit: (5f2efcb) Deprecated config.paths defaults.
File:  lib/bedrock.js:56
David I. Lehn commented 3 years ago

[ ] FIXME: v2.0.0: remove warning and default and throw exception .
Commit: (5f2efcb) Deprecated config.paths defaults.
File:  lib/bedrock.js:43
David I. Lehn commented 3 years ago

[ ] FIXME: v2.0.0: remove when removing warnings below.
Commit: (5f2efcb) Deprecated config.paths defaults.
File:  lib/bedrock.js:36
David I. Lehn commented 3 years ago

[x]
Commit: (8e0950c) Comment out TODO.
File:  README.md:715
Dave Longley commented 5 years ago

[ ] FIXME also check if a validation type?
Commit: (7d9c451) Initial commit of bedrock.
File:  lib/bedrock/tools.js:110
Dave Longley commented 6 years ago

[ ] * TODO: look into better stack parsing libraries.
Commit: (4d3fafd) Parse stack errors.
File:  lib/bedrock/tools.js:76
David I. Lehn commented 6 years ago

[ ] FIXME: add parse error handling
Commit: (4d3fafd) Parse stack errors.
File:  lib/bedrock/tools.js:98
David I. Lehn commented 6 years ago

Closing -- all TODOs/FIXMEs have been assigned specific issues and those issues are linked to in source.


Fix #1905 #1833

ping @snoyberg, persistent has restrictive bounds in tests

It seems that for some reason, revision 1 hasn't been picked up yet.
https://hackage.haskell.org/package/persistent-2.6/revisions/

@dan that revision edits only library component, not tests.

it should be ok now

@phadej thanks for staying on top of that.


Add my first file

I have created my first branch,created a file, and made a commit!

Finish

Ok

Finish read

Finish my-first-branch

Finish README.md


[Event Request] page 6034 "Service Credit Memo Statistics" - OnAfterGetRecordOnAfterCalculateAdjProfitLCY

We would like to add a new event OnAfterGetRecordOnAfterCalculateAdjProfitLCY in the following trigger:
trigger OnAfterGetRecord()
var
    CostCalcMgt: Codeunit "Cost Calculation Management";
    IsHandled: Boolean;
begin
    ClearAll;

    if "Currency Code" = '' then
        Currency.InitRoundingPrecision
    else
        Currency.Get("Currency Code");
    //A108F0080.Event.ns
    IsHandled := false;
    OnBeforeCalculateTotals(
        Rec, CustAmount, AmountInclVAT, InvDiscAmount, CostLCY, TotalAdjCostLCY,
        LineQty, TotalNetWeight, TotalGrossWeight, TotalVolume, TotalParcels, IsHandled);
    if IsHandled then
        exit;
    //A108F0080.Event.ne

    ServCrMemoLine.SetRange("Document No.", "No.");

    if ServCrMemoLine.Find('-') then
        repeat
            CustAmount := CustAmount + ServCrMemoLine.Amount;
            AmountInclVAT := AmountInclVAT + ServCrMemoLine."Amount Including VAT";
            if "Prices Including VAT" then
                InvDiscAmount := InvDiscAmount + ServCrMemoLine."Inv. Discount Amount" / (1 + ServCrMemoLine."VAT %" / 100)
            else
                InvDiscAmount := InvDiscAmount + ServCrMemoLine."Inv. Discount Amount";
            CostLCY := CostLCY + (ServCrMemoLine.Quantity * ServCrMemoLine."Unit Cost (LCY)");
            LineQty := LineQty + ServCrMemoLine.Quantity;
            TotalNetWeight := TotalNetWeight + (ServCrMemoLine.Quantity * ServCrMemoLine."Net Weight");
            TotalGrossWeight := TotalGrossWeight + (ServCrMemoLine.Quantity * ServCrMemoLine."Gross Weight");
            TotalVolume := TotalVolume + (ServCrMemoLine.Quantity * ServCrMemoLine."Unit Volume");
            if ServCrMemoLine."Units per Parcel" > 0 then
                TotalParcels := TotalParcels + Round(ServCrMemoLine.Quantity / ServCrMemoLine."Units per Parcel", 1, '>');
            if ServCrMemoLine."VAT %" <> VATpercentage then
                if VATpercentage = 0 then
                    VATpercentage := ServCrMemoLine."VAT %"
                else
                    VATpercentage := -1;
            TotalAdjCostLCY := TotalAdjCostLCY + CostCalcMgt.CalcServCrMemoLineCostLCY(ServCrMemoLine);
            //A108F0080.Event.ns
            OnCalculateTotalsOnAfterAddLineTotals(
                Rec, ServCrMemoLine, CustAmount, AmountInclVAT, InvDiscAmount, CostLCY, TotalAdjCostLCY,
                LineQty, TotalNetWeight, TotalGrossWeight, TotalVolume, TotalParcels);
        //A108F0080.Event.ne
        until ServCrMemoLine.Next() = 0;
    VATAmount := AmountInclVAT - CustAmount;
    InvDiscAmount := Round(InvDiscAmount, Currency."Amount Rounding Precision");

    if VATpercentage <= 0 then
        VATAmountText := Text000
    else
        VATAmountText := StrSubstNo(Text001, VATpercentage);

    if "Currency Code" = '' then
        AmountLCY := CustAmount
    else
        AmountLCY :=
          CurrExchRate.ExchangeAmtFCYToLCY(
            WorkDate, "Currency Code", CustAmount, "Currency Factor");

    ProfitLCY := AmountLCY - CostLCY;
    if AmountLCY <> 0 then
        ProfitPct := Round(100 * ProfitLCY / AmountLCY, 0.1);

    AdjProfitLCY := AmountLCY - TotalAdjCostLCY;
    OnAfterGetRecordOnAfterCalculateAdjProfitLCY(Rec, AdjProfitLCY); //A108F0080.Event
    if AmountLCY <> 0 then
        AdjProfitPct := Round(100 * AdjProfitLCY / AmountLCY, 0.1);

    if Cust.Get("Bill-to Customer No.") then
        Cust.CalcFields("Balance (LCY)")
    else
        Clear(Cust);

    case true of
        Cust."Credit Limit (LCY)" = 0:
            CreditLimitLCYExpendedPct := 0;
        Cust."Balance (LCY)" / Cust."Credit Limit (LCY)" < 0:
            CreditLimitLCYExpendedPct := 0;
        Cust."Balance (LCY)" / Cust."Credit Limit (LCY)" > 1:
            CreditLimitLCYExpendedPct := 10000;
        else
            CreditLimitLCYExpendedPct := Round(Cust."Balance (LCY)" / Cust."Credit Limit (LCY)" * 10000, 1);
    end;

    ServCrMemoLine.CalcVATAmountLines(Rec, TempVATAmountLine);
    CurrPage.Subform.PAGE.SetTempVATAmountLine(TempVATAmountLine);
    CurrPage.Subform.PAGE.InitGlobals("Currency Code", false, false, false, false, "VAT Base Discount %");
end;

Event Signature:
[IntegrationEvent(false, false)]
local procedure OnAfterGetRecordOnAfterCalculateAdjProfitLCY(ServiceCrMemoHeader: Record "Service Cr.Memo Header"; var AdjProfitLCY: Decimal)
begin
    //A108F0080.Event
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


fix(servicescontainer): change to getderivedstatefromprops

This changes the lifeCycleMethod on the ServicesContainer from
componentWillRecieveProps to getDerivedStateFromProps which is more fitting.
Testing
Select a very high refresh rate from the ui configurations, and visit the services page.
Trade-offs
N/A
Dependencies
N/A

:tada: This PR is included in version 2.83.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Telegraf and Azure Monitor on ARC VM

[Enter feedback here]
Hi,
A couple of questions.

Have you been able to set configure this on an ARC VM? I have attempted and have been unsuccessful. I had to use this iptables command to make it use the correct metadata endpoint.
sudo iptables -t nat -A OUTPUT -p tcp --dport 80 -d <IP_ADDRESS> -j DNAT --to-destination <IP_ADDRESS>:40342

There is an open issue against the plugin in regards to it using an unsupported SDK.  https://github.com/influxdata/telegraf/issues/12535
"error_description":"The api-version '2018-02-01' could not be found. Supported are 2021-02-01 2020-06-01 2019-11-01 2019-08-15"

In step four of Plot your Telegraf metrics in the Azure Portal I do not see the "Metrics", is this because its an ARC VM or am I missing something else

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 90b9aacb-357c-90fc-1804-756d3d6f5124
Version Independent ID: a44c6284-a0cb-92e7-f251-748c47f7f587
Content: Collect custom metrics for Linux VM with the InfluxData Telegraf agent - Azure Monitor
Content Source: articles/azure-monitor/essentials/collect-custom-metrics-linux-telegraf.md
Service: azure-monitor
Sub-service: essentials
GitHub Login: @EdB-MSFT
Microsoft Alias: edbaynash

@brhoug
Thanks for your feedback! We will investigate and update as appropriate.

Hi @brhoug
1. Have you been able to set configure this on an ARC VM?
When updating the article, I used a simple ubuntu VM to make sure it worked as documented. I don't believe that it is supported for ARC VMs although I don't see why not if you can get the networking and authentication happening. Please open a support ticket for more help with this.  As noted in the documentation: "InfluxData Telegraf is an open source agent and not officially supported by Azure Monitor"
2 There is an open issue against the plugin in regards to it using an unsupported SDK
Please note that this is a 3rd party open source agent and we are not involved in it's maintenance.
3 "In step four of Plot your Telegraf metrics in the Azure Portal I do not see the "Metrics", is this because its an ARC VM or am I missing something else"
If you are getting an error and your metrics are not making it out of your VM to Azure monitor, then it stands to reason that you wont see them in the metrics explorer.
I hope this clarifies the issues.

#please-close


Convert (and cache) remote keys in replication GET response for timed out standby replicas in leader-based replication

During replication, as of part of legacy GDPR requirements, remote keys are converted (and cached) to local keys using StoreKeyConverter during metadata exchange. These converted/cached keys are used for validation and transformation after the missing blobs are fetched for them. In case of leader-based replication, when we are fetching missing blobs for standby replicas (timed out waiting for their keys to arrive from leaders), StoreKeyConverter would have cleared these keys from its cache as it is replicating with other replicas before time out happened. This fix is to re-convert remote keys and fill the cache when we fetch missing blobs for timed out standby replicas.

Codecov Report

Merging #1593 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #1593      +/-   ##
============================================
- Coverage     73.70%   73.68%   -0.02%
- Complexity     8440     8443       +3
============================================
  Files           589      589
  Lines         46014    46028      +14
  Branches       5841     5846       +5
============================================
+ Hits          33914    33916       +2
- Misses        10352    10362      +10
- Partials       1748     1750       +2

Impacted Files
Coverage Δ
Complexity Δ

...va/com/github/ambry/replication/ReplicaThread.java
85.16% <66.66%> (-0.26%)
152.00 <3.00> (+3.00)
:arrow_down:

.../com/github/ambry/network/BlockingChannelInfo.java
80.95% <0.00%> (-3.18%)
16.00% <0.00%> (ø%)

...github/ambry/rest/AsyncRequestResponseHandler.java
87.87% <0.00%> (-2.36%)
22.00% <0.00%> (ø%)

...in/java/com/github/ambry/store/BlobStoreStats.java
66.51% <0.00%> (-1.37%)
90.00% <0.00%> (-2.00%)

...m/github/ambry/replication/ReplicationMetrics.java
91.39% <0.00%> (-1.03%)
54.00% <0.00%> (-1.00%)

...c/main/java/com/github/ambry/network/Selector.java
78.38% <0.00%> (-0.79%)
78.00% <0.00%> (-1.00%)

...a/com/github/ambry/clustermap/ClusterMapUtils.java
91.78% <0.00%> (-0.46%)
58.00% <0.00%> (ø%)

...ain/java/com/github/ambry/router/PutOperation.java
92.64% <0.00%> (-0.17%)
123.00% <0.00%> (-1.00%)

...n/java/com/github/ambry/store/PersistentIndex.java
91.82% <0.00%> (+0.11%)
256.00% <0.00%> (+1.00%)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2dde01...8b69b7a. Read the comment docs.


Officially maintained OWASP ZAP Node API

This API has been unmaintained for several years, I'm the new owner and keeping it maintained now

The API code
Now official
Official announcement
Main issue
Main PR
What's changed

Interested in a PR?

send pr please.


H/channelcombine gpu

Fixed channelcombine node - gpu flow
This should also fix the issue #338 in the master branch.

@hansely is this ready to be merged?

@kiritigowda Yes


Volume Tier Change across subscriptions

Can we get a consideration added that explains if volume tier change requires being in the same account and subscription or can it be in a different account or a different account in a different subscription?
thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d0269a82-164f-c86b-05f5-831381455059
Version Independent ID: 02280290-efb4-fb61-4d1a-20125f64c067
Content: Dynamically change the service level of a volume for Azure NetApp Files
Content Source: articles/azure-netapp-files/dynamic-change-volume-service-level.md
Service: azure-netapp-files
GitHub Login: @b-hchen
Microsoft Alias: anfdocs

@elfcounsel
Thanks for your feedback! We will investigate and update as appropriate.

@elfcounsel - Thank you, Win!  Great to hear from you.  I'll take this comment/suggestion to the technical team.

@elfcounsel - Thanks again, Win.  Per discussion with the team, we will only document that this feature (dynamic volume move) is supported only within the same NetApp account.
This change is implemented in PR 191922, posting ETA 3/22/22 PST.

#please-close


Can't Receive message

I tried implementing FCM reception using this library.
My implementation: https://github.com/choiman1559/electron-push-receiver
Generating & Getting token via registerToFCM is totally ok,
And login, iq, heartbeat event appears normally after connect FcmClient,
However, when I send an FCM message I don't get to read the message with the following log:
FcmClient -> onSocketDataBytes -> Failed to read current message, ready for the next one.

And my FCM message is:
{
   "message" : {
           "token": "/*Device's token*/".
           "android": {"priority": "high"},
           "data": {}
   }
}

I am seeing a similar problem.  Some of my message types are arriving okay, some are exhibiting the same error as above.
I'm getting the same problem with both registerToFCM and subscribeToFCM.
push-receiver does not suffer from this problem.
Please let me know what other info I can provide to help diagnose the issue. Thanks!

I have not been able to receive any messages at all using this library. This is what I'm doing.
const ecdh = createFcmECDH();

registerToFCM({
  appID: '1:750231271280:web:14f5b6b9be8e2d04ccc1b5',
  ece: {
    authSecret: authSecret,
    publicKey: ecdh.getPublicKey()
  },
  firebase: {
    apiKey: 'AIzaSyA7WcnPAWRJrugA3si_UbsluizOKG1KRhI',
    appID: '1:750231271280:web:14f5b6b9be8e2d04ccc1b5',
    projectID: 'testprojectforelectron2'
  },
  vapidKey: 'BI_pyAda2dUIk1sY5iixqx7UAH1d2Siiv-6Mdr9SkuJcyEOG2EXuspv5XI3ey98RNWYHF_UpZnCNPvOzKaglV4U'
})
  .catch(() => { })
  .then((registration) => {
      const client = new FcmClient({
        acg: {
          id: BigInt(registration.acg.id),
          securityToken: BigInt(registration.acg.securityToken)
        }
      });

      client.on("heartbeat", () => {
        console.log("Heart)
      })
      client.on('message', (message) => {
        console.log(message);
      });
      client.on('message-data', (data) => {
        console.log(data);
      });
      client.on('close', () => {
        console.log("Closed");
      });
      client.on('login', () => {
        console.log("Logged in");
      });
      client.connect();
  });```

I only get 1 heartbeat and 1 login event after which I don't get anything.

Solved. The problem appears to occur when re-importing and registering credentials that were previously registered and stored in storage.
This was resolved by changing to issue a new credential each time the FCM service is run.
https://github.com/choiman1559/electron-push-receiver/blob/master/src/index.js

I was already using a new credential each time so this doesn't resolve my issue. I'll create a new ticket for that.

Solved. The problem appears to occur when re-importing and registering credentials that were previously registered and stored in storage.
This was resolved by changing to issue a new credential each time the FCM service is run. https://github.com/choiman1559/electron-push-receiver/blob/master/src/index.js

This doesn't seem to be a problem. I have got it to work with the same credentials each time. I simply had to re-type the credentials to their original format to get it to work.
privateKey = new Uint8Array(dataFromStorage); authSecret = new Uint8Array(dataFromStorage); id = BigInt(dataFromStorage); securityToken = BigInt(dataFromStorage);


clarify that 1.0 will eventually be deprecated, it is not yet deprecated

Addressing comments from @bboreham on https://github.com/prometheus/prometheus/pull/14395 re: status of RW1.0

Should we do this on release-2.54 branch?

Should we do this on release-2.54 branch?

which is easier for you, PRing this into the release branch or into main? I can't remember if we have automation for backporting at all

I'm not aware of any automation; if you change the base to release-2.54 it will get merged back with everything else when the release is done.
Or you can open a second PR to cherry-pick this to that branch.

@bboreham changed base to 2.54 :+1: seems like the easiest option for now


Upload_mission vs Update_mission

What is the difference between these two services? Is it necessary that we keep them separate?
If so, add the update_mission endpoint to operator.py

I think update_mission changes the waypoints while upload_mission sends it to drone.

Deleted update_mission


Migration issue: provider not fetching data with 1.3.4

When updating from 0.8.2 to 1.3.4 (and RiverPod 1.0.4), our transactionProvider no longer returns any data.
Previous:
HookBuilder(builder: (context) {
   final state = useProvider(watchTransactions());
   final transactions = state.model;

   if (state.hasException) {
      return Text(state.exception.toString());
   }
   if (transactions.length == 0) {
      return const Spacer();
   }
   return Expanded( ....);
}

Now:
HookConsumer(builder: (context, ref, child) {
   final transactions = ref.watch(transactionsProvider);

   transactions.when(
      loading: () => Spacer(),
      error: (error, stack) => Text('Oops, something unexpected happened'),
      data: (value) {
         if (value.length == 0) {
            return const Spacer();
         }
         return Expanded(...)
      }
}

But the data state is never invoked.
A breakpoint added to the _adapter function feeding the provider is never hit.
What should I be doing differently @frank06?

Hey Daniel, were you able to solve this?

Hi Frank, not yet.
I will give the migration another go in about two weeks after wrapping up some other work.
Would love to be in touch then. Please email the best contact details (your previous email bounced).