Create SECURITY.md

https://MineIn.Cloud/bonus?r=72255
On Mon, 12 Aug 2024 at 14:05, Newel-86 @.***> wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/pi-apps/pi-explorer/pull/140
Commit Summary

fba423e
https://github.com/pi-apps/pi-explorer/pull/140/commits/fba423e99b9f6802c8ad3d346abc9cc3f3bf4e9a
Create SECURITY.md

File Changes
(1 file https://github.com/pi-apps/pi-explorer/pull/140/files)

A SECURITY.md
https://github.com/pi-apps/pi-explorer/pull/140/files#diff-f6ed156e4bf5c791680662464b94ea5d753f219ee816b385f67870e2c0d7d4c7
(21)

Patch Links:

https://github.com/pi-apps/pi-explorer/pull/140.patch
https://github.com/pi-apps/pi-explorer/pull/140.diff

—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140, or unsubscribe
https://github.com/notifications/unsubscribe-auth/BD3OMLFGJ42K55M5ANHUBPTZRCQJLAVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DAOBRGAZDMNA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

😮😮

😊😊😊😊

https://noones.com/user/ManlyHagfish54
On Fri, 16 Aug 2024 at 17:31, سیروس چاوشی @.***> wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140#pullrequestreview-2242981127,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BD3OMLH5NWCB2MQUHNLB3ZLZRYLLFAVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBSHE4DCMJSG4
.
You are receiving this because you commented.Message ID:
@.***>

https://noones.com/user/ManlyHagfish54
On Mon, 19 Aug 2024 at 21:25, EVANDRO FRANCISCO GARCIA <
@.***> wrote:

Thank my friend!👍
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140#issuecomment-2297284011,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BD3OMLAAHGZTSJCRIWJZ3STZSJBD7AVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGI4DIMBRGE
.
You are receiving this because you commented.Message ID:
@.***>

Thanks too, what are you dealing with
On Sat, Aug 24, 2024, 8:11 PM florim1213 @.***> wrote:

https://noones.com/user/ManlyHagfish54
On Mon, 19 Aug 2024 at 21:25, EVANDRO FRANCISCO GARCIA <
@.***> wrote:

Thank my friend!👍
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140#issuecomment-2297284011,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/BD3OMLAAHGZTSJCRIWJZ3STZSJBD7AVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGI4DIMBRGE>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140#issuecomment-2308459847,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BH5AVJE764ABSFVULBQCK5DZTC5DPAVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYGQ2TSOBUG4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Why
On Sun, Aug 25, 2024, 4:01 AM kalumunafaustine @.***>
wrote:

Thanks too, what are you dealing with
On Sat, Aug 24, 2024, 8:11 PM florim1213 @.***> wrote:

https://noones.com/user/ManlyHagfish54
On Mon, 19 Aug 2024 at 21:25, EVANDRO FRANCISCO GARCIA <
@.***> wrote:

Thank my friend!👍
—
Reply to this email directly, view it on GitHub
<
https://github.com/pi-apps/pi-explorer/pull/140#issuecomment-2297284011>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/BD3OMLAAHGZTSJCRIWJZ3STZSJBD7AVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGI4DIMBRGE>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140#issuecomment-2308459847,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/BH5AVJE764ABSFVULBQCK5DZTC5DPAVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYGQ2TSOBUG4>

.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140#issuecomment-2308565802,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJDWCYV3LDDGL774FKNVAY3ZTEGFDAVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYGU3DKOBQGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I would like to know what you will be offering with your company after Pi
open minet sir
On Sun, Aug 25, 2024, 4:28 AM EVANDRO FRANCISCO GARCIA <
@.***> wrote:

Very good
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140#issuecomment-2308610477,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BH5AVJDJMVB3M5HWBY32A7LZTEXMJAVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYGYYTANBXG4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

stake.com/?c=BJVPQFu4
On Sun, 25 Aug 2024 at 00:59, kalumunafaustine @.***>
wrote:

Thanks too, what are you dealing with
On Sat, Aug 24, 2024, 8:11 PM florim1213 @.***> wrote:

https://noones.com/user/ManlyHagfish54
On Mon, 19 Aug 2024 at 21:25, EVANDRO FRANCISCO GARCIA <
@.***> wrote:

Thank my friend!👍
—
Reply to this email directly, view it on GitHub
<
https://github.com/pi-apps/pi-explorer/pull/140#issuecomment-2297284011>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/BD3OMLAAHGZTSJCRIWJZ3STZSJBD7AVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGI4DIMBRGE>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140#issuecomment-2308459847,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/BH5AVJE764ABSFVULBQCK5DZTC5DPAVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYGQ2TSOBUG4>

.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140#issuecomment-2308565802,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BD3OMLB7I2Y5GL4BF52MTL3ZTEF5ZAVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYGU3DKOBQGI
.
You are receiving this because you commented.Message ID:
@.***>

Hoffe es geht noch was im diesem Jahr 😜

@.***
On Wed, 28 Aug 2024, 11:08 am Newel-86, @.***> wrote:

Closed #140 https://github.com/pi-apps/pi-explorer/pull/140.
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140#event-14040764432, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BCEFRICXJHK326DQFG22MMDZTVSNHAVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGA2DANZWGQ2DGMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

https://TONFree.win/?r=99933
On Fri, 30 Aug 2024 at 09:01, S9393 @.***> wrote:

@.***
On Wed, 28 Aug 2024, 11:08 am Newel-86, @.***> wrote:

Closed #140 https://github.com/pi-apps/pi-explorer/pull/140.
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140#event-14040764432, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/BCEFRICXJHK326DQFG22MMDZTVSNHAVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGA2DANZWGQ2DGMQ>

.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/140#issuecomment-2320274352,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BD3OMLAGRXT7GKHGNTSQ6B3ZUAKGJAVCNFSM6AAAAABMMA2IQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQGI3TIMZVGI
.
You are receiving this because you commented.Message ID:
@.***>


Time wrong after last update

After the last update, the time is incorrect (one hour ahead). I'm on CET and it seems as it doesn't detect winter time anymore.

The website currently doesn't pay any attention to your timezone, it was just a happy coincidence that you were in the time zone the server was on.
Razviar has said he is working on getting the website to use your timezone, but it's not there yet.


Some problems about set position on play and play effect sound on Web in iOS

First question about set position on play.
This's what I do.
OutlinedButton(
  onPressed:(){
     myPlayer.play(AssetSource('Music.mp3'),position:Duration(minutes: 1));
  },
),

On Web everytime I click the button It's will play from start, you need to call "stop()" once and it will play from specified position, but if you play other music file the issue will begin.
But on iOS and Android devices it will happen only at first time, no need to call stop().
Second question is about Flutter Web
For some reason I need to run Flutter Web on iOS browser, need to play a button effect sound when click the button, first time click it's work good, but after that it's sound like been cut half, if change other sound file the issue come again. Same whatever using Chrome or Safari. (Latest version), but seens work good for a long music file.
And this issue only happen on Flutter Web on iOS, another platform are work fine.
My iPad : iPad Air 4 (macOS 15.6)
AudioPlayer soundPlayer = AudioPlayer();

@override
void initState() {
  super.initState();
  soundPlayer.setReleaseMode(ReleaseMode.stop);
}

soundPlayer.play(AssetSource('Button.mp3'));

Flutter : 3.0.4
Dart : 2.17.5
AudioPlayer : 1.0.1

Want to know did I just miss something to do for these 2 question? thank you very much.

Can you check again with audioplayers: ^1.1.0 ? Also please don't mix two issues in one. Then create two separate issues, with its own issue template. Thx :)


[Bug]: 2024-11-24 11:02:13.754948083 [E:onnxruntime:Default, provider_bridge_ort.cc:1992 TryGetProviderInfo_CUDA] /onnxruntime_src/onnxruntime/core/session/provider_bridge_ort.cc:1637 onnxruntime::Provider& onnxruntime::ProviderLibrary::Get() [ONNXRuntimeError] : 1 : FAIL : Failed to load library libonnxruntime_providers_cuda.so with error: libcublasLt.so.11: cannot open shared object file: No such file or directory

What happened?
when i run this code
embedding_model = LateInteractionTextEmbedding("jinaai/jina-colbert-v2",cuda=True)
I get
2024-11-24 11:02:13.754948083 [E:onnxruntime:Default, provider_bridge_ort.cc:1992 TryGetProviderInfo_CUDA] /onnxruntime_src/onnxruntime/core/session/provider_bridge_ort.cc:1637 onnxruntime::Provider& onnxruntime::ProviderLibrary::Get() [ONNXRuntimeError] : 1 : FAIL : Failed to load library libonnxruntime_providers_cuda.so with error: libcublasLt.so.11: cannot open shared object file: No such file or directory
2024-11-24 11:02:13.754961467 [W:onnxruntime:Default, onnxruntime_pybind_state.cc:965 CreateExecutionProviderInstance] Failed to create CUDAExecutionProvider. Require cuDNN 8.* and CUDA 11.*. Please install all dependencies as mentioned in the GPU requirements page (https://onnxruntime.ai/docs/execution-providers/CUDA-ExecutionProvider.html#requirements), make sure they're in the PATH, and that your GPU is supported.
/home/kareem/mambaforge/envs/IR/lib/python3.11/site-packages/fastembed/common/onnx_model.py:89: RuntimeWarning: Attempt to set CUDAExecutionProvider failed. Current providers: ['CPUExecutionProvider'].If you are using CUDA 12.x, install onnxruntime-gpu via pip install onnxruntime-gpu --extra-index-url [https://aiinfra.pkgs.visualstudio.com/PublicPackages/_packaging/onnxruntime-cuda-12/pypi/simple/](https://aiinfra.pkgs.visualstudio.com/PublicPackages/_packaging/onnxruntime-cuda-12/pypi/simple/`)
warnings.warn(
What is the expected behaviour?
the model work with cuda version
A minimal reproducible example
No response
What Python version are you on? e.g. python --version
python3.11
on Pop!_OS ❯ nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2022 NVIDIA Corporation
Built on Wed_Sep_21_10:33:58_PDT_2022
Cuda compilation tools, release 11.8, V11.8.89
Build cuda_11.8.r11.8/compiler.31833905_0
FastEmbed version
v0.4.2
What os are you seeing the problem on?
Linux
Relevant stack traces and/or logs
No response

@hh-space-invader Thanks man, I didn't notice that there was  fastembed version for GPU, i was reading the qdrant documenation about fastembed.
keep doing this amazing work.
Nice to see you here :love_you_gesture:


Material version mismatch. Expected 12 but received 0.

platform : Android
I add implementation 'com.google.android.filament:filament-android:1.12.6' in my testProject,
and copy filament-main/android/samples/sample-hello-triangle  to my testProject,
after running , it encounter this error：
E/Filament: Panic
    in filament::MaterialParser *filament::createParser(filament::backend::Backend, const void *, size_t):69
    reason: Material version mismatch. Expected 12 but received 0.
A/libc: Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 16297 (ai.filamenttest), pid 16297 (ai.filamenttest)

I also test 'com.google.android.filament:filament-android:1.12.5'`  it still have this problem ?
Anything wrong ?
after add
  implementation 'com.google.android.filament:gltfio-android:1.12.6'
    implementation 'com.google.android.filament:filament-utils-android:1.12.6'
    implementation 'com.google.android.filament:filamat-android:1.12.6'

still get this error,  and i checked Material.java , there are no method to set version.

Did you use a previous version of Filament? If so, make sure your materials get compiled/recompiled. How do you compile your materials?

@romainguy   The baked_color.mat is copied from filament-main/android/samples/sample-hello-triangle/src/main/materials/ ,

in kotlin code, i just change the .filamat to .mat ,   is this problem ?

Yes it is. .mat files are source files, you need to compile them to .filamat using the tool called matc.

Thanks for your help .   @romainguy


We <3 You

Follow-up article over at X-Team: https://x-team.com/blog/compare-cxs-jss-performance/

This benchmark is over a year old. See here for recent results.


ENH: Add overview figure

Thanks for that. Just one nitpick - can we crop all the white bits around the images?

Done!


[Bug]: 0.5.4 breaks static type checks for Collection.query with include

What happened?
TL;DR Type checking Collection.query with include set breaks with chromadb>=0.5.4 or more specifically after #2416 (cc @jeffchuber).
I took the example from the README, stripped all comments and added an include to the Collection.query call:
import chromadb

client = chromadb.Client()

collection = client.create_collection("all-my-documents")

collection.add(
    documents=[
        "This is document1",
        "This is document2",
    ],
    metadatas=[{"source": "notion"}, {"source": "google-docs"}],
    ids=["doc1", "doc2"],
)

results = collection.query(
    query_texts=["This is a query document"],
    n_results=2,
    include=["distances", "metadatas", "documents"],
)

This type checks fine for chromadb<=0.5.3, but results in errors (see below) for chromadb>=0.5.4.
Versions
Chroma 0.5.3 / 0.5.4, Python 3.9.19, mypy 1.11.0
Relevant log output
chromadb<=0.5.3
Success: no issues found in 1 source file

chromadb>=0.5.4
main.py:20: error: List item 0 has incompatible type "str"; expected "IncludeEnum"  [list-item]
        include=["distances", "metadatas", "documents"],
                 ^~~~~~~~~~~
main.py:20: error: List item 1 has incompatible type "str"; expected "IncludeEnum"  [list-item]
        include=["distances", "metadatas", "documents"],
                              ^~~~~~~~~~~
main.py:20: error: List item 2 has incompatible type "str"; expected "IncludeEnum"  [list-item]
        include=["distances", "metadatas", "documents"],
                                           ^~~~~~~~~~~
Found 3 errors in 1 file (checked 1 source file)

Thats no good! Sorry. @tazarov can you take a look?

@pmeier, You are correct that mypy complains about the newly added types
https://github.com/chroma-core/chroma/blob/4f68c60ec58a1355bc6c7797738e07bba85e5159/chromadb/api/types.py#L129-L140
This also affects get().
That said we do validate the the values of enum (and we even treat them as str. Strings are ok approach and we can make this still work with existing code by making Include a union type like so - Include = List[Union[IncludeEnum, str]]. Though I feel that in the future Enums might be a better approach.


Advanced Example: Cannot import multiples coordinates

Hello everyone,
Nice job with the well-documented repository!
I am a rookie, and I have been struggling to import my data (around 200 coordinates (latitude, longitude)) to the advance example you have in the repository.
I copied and pasted the HTML code of the advanced example, but cannot figure out how to import all my coordinates to the code.
I tried putting everything in the following format: "var marker = new google.maps.Marker({position: new google.maps.LatLng(-6.369028, 34.888822)});"
but the map wouldn't get uploaded correnctly.
So basically I wish to have a map with the following effect

, but couldn't figure out how to import coordinates.
Thanks in advance!

Hi @ChiXuUnited,
thank you for your question.
The trick is, to add all locations (markers) to an markers array.
var markers = []; // Create a markers array to collect all markers

var marker = new google.maps.Marker({ // Create a new marker with it's lat/lng
  position: new google.maps.LatLng(51.5074, 0.1278)
});
markers.push(marker); // Push each marker to the markers array

var options = {
  imagePath: 'images/m'
};

var markerCluster = new MarkerClusterer(map, markers, options); // Create a new Marker Clusterer Object

Hello Sebastian @XmlmXmlmX,
I am still getting nothing here: I added the code to the array as you described,
here is the code I came up with:
    var markers = [];

////// I kept the original code of advanced exemple.html in between
var latLng = new google.maps.LatLng(data.photos[i].latitude,
data.photos[i].longitude)
var marker = new google.maps.Marker({
new google.maps.LatLng(12.238333, -1.561593);
new google.maps.LatLng(11.825138, 42.590275)
});
markers.push(marker);
}
/////// original code here again, until:
markerClusterer = new MarkerClusterer(map, markers, {
maxZoom: zoom,
gridSize: size,
styles: styles[style],
imagePath: '../images/m'
});
}
//////// then some more original code
Then I saved the code in a html file, but the whenever I open the html file, I've got:

Should I send you my entier code so that you can have a closer look?

Hello again Sebastian @XmlmXmlmX
I managed to solve (partly) the previous issue, now I succeed in loading the map! (feeling very proud now)
Now the issue is that I still don't see any marker on the map.
Will continue debugging the code, but will certainly appreciate it greatly if you can give me any advise

here is what it look like now

Have a look here: https://jsfiddle.net/Mescaline/yazt8j34/3/

Hello again Sebastien @XmlmXmlmX
The problem I am encountering is to have the beautiful layout of your advanced example, while importing my database to the map.
I still couldn't succeed, because I cannot figure out how and where to put my coordinates in the code of "advanced example.html".
Is there any advise you can give me on this, Sebastien?


added scons ccache tool

small port from mongodb tools, very useful.
I saw some mention of ccache on certain platforms detect, but it didn't look like it was used for the scons general build, and for sure not linuxbsd.

Also want to mention that this is more important with ninja generation tool. It is less useful with pure scons because scons has scons cache, and the ninja tool has not yet been updated to use the scons cache, so this ccache tool can work with ninja to provide build caching for the compilation at least, which is generally the bulk of build time.

I have noticed large increase in performance on Linux systems. Can be salvaged independently from the Ninja pr.

I have noticed large increase in performance on Linux systems. Can be salvaged independently from the Ninja pr.

This should work fine without ninja, but why not just use scons-cache if no ninja?

I guess #60698 is the most recent take on this if someone wants to salvage it, so we can close this one indeed.


[$1000] iOS - Copy and Download buttons overlap with Next button when app is in Spanish

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Sign in and enter the app
Change language to Spanish
Go to Seguridad -> Autenticación de dos factores

Expected Result:
Button should not overlap between each other
Actual Result:
Copy and Download buttons overlap with Next button when app is in Spanish
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/46521de4-048a-49e3-95aa-8c5e689ed23c
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bb40af209228ca22
Upwork Job ID:<PHONE_NUMBER>044396032
Last Price Increase: 2023-06-06

hello

<EMAIL_ADDRESS>        upwork Profile Link :  https://www.upwork.com/freelancers/faizans50

Weird. Yes, I can repro.

@Expensify/design Do we need to fix anything here?

Hmm I don't understand why the buttons/background card area overlap the button like that, but it's definitely a bug. @MonilBhavsar can you take a look at this one since I think you worked on this feature?

It happened on IPhone 7 and 8

@shawnborton We have a proposal above should I wait for @MonilBhavsar here?

Well I'm not sure if we should accept proposals or make the original PR author go back and fix all of this, because it seems like we didn't implement this feature properly.

Looks like this is a case for small screen devices we missed while introducing scroll view here.
@BeeMargarida or @thiagobrez could you please us with this issue.

@MonilBhavsar I'll take a look at this 👌🏻

Proposal
Please re-state the problem that we are trying to solve in this issue.
In Two-Factor authentication CodesPage, when the app is in Spanish and in small screens, the Copy and Download buttons (from page body) overlap with the Next button in the footer
What is the root cause of that problem?
Footer is included in the page ScrollView, which causes the page to have to contract to fill everything
What changes do you think we should make in order to solve the problem?

Move FixedFooter outside the ScrollView
Remove flex1 from the ScrollView contentContainerStyle
Add a little paddingTop to the FixedFooter, so when the page scrolls there is a gap between content and footer, so the UI doesn't feel too cluttered
In the Copy and Download buttons wrapper, render a column instead of row when screen is extra small (Galaxy Fold). This is a different issue that wasn't seen before - these buttons were overflowing horizontally in this screen size

iPhone 7

iPhone 8

iPhone 14

Pixel 5

Galaxy Fold

@arosiclair @MonilBhavsar
Looks good to me. cc @shawnborton

Just to make sure I understand, are we paying this out as a new bug with a new fix? Why wouldn't we treat this as a regression and ask the original PR author to fix this?

@shawnborton There is an open issue https://github.com/Expensify/App/issues/19187 it's within the we can handle it there as regression.

Hey @shawnborton, I'm the original PR author :)
Wasn't sure how the process should go in this case, so I decided to post a proposal anyway

Ah apologies. Okay, I say we treat this like a regression. @MonilBhavsar what's the process for that?

PR is ready for review here: https://github.com/Expensify/App/pull/20575

Okay, we should handle this in the original issue apparently: https://stackoverflowteams.com/c/expensify/questions/8513.
However, that is an overall issue for many bugs, so I prefer keeping it isolated in here, but we'll account for the regression in the payment. I will assign you to this @thiagobrez.

Issue not reproducible during KI retests. (First week)

Is this resolved without the PR then?

PR is being reviewed here: https://github.com/Expensify/App/pull/20575

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x]  [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/19260
[x]  [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/19260#discussion_r1245186159
[x]  [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This should have been caught in this review based on the checklist
[x]  [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A
[x]  [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[x]  [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

We don't need a separate regression test here, this minor Ui polish. Existing cases should be enough. @arosiclair Let me know if you differ on any of the above.
Thanks!
Cc: @twisterdotcom

No problem @twisterdotcom - I'll take care of payment once we reach the payment date tomorrow :)

Wait actually I'm coming into this a bit late as I didn't managed this issue from the start - are we paying full price for this (but just to C+ for review)? There was some kind of regression here but I'm not certain @arosiclair @Santhosh-Sellavel

@greg-schroeder Better this discussion can happen on Slack or new dot. We can wait for @twisterdotcom, I'm in no rush to collect payments here.

Good call, I will open a discussion

I sent you an offer @Santhosh-Sellavel for this one... given you're a different reviewer than the initial PR let's just go with the standard payment.

awaiting payment acceptance and we can close this out

Not overdue

Closing for now as everything else is complete. :)

Paid Santhosh on new Dot.


API: Option for "additional" read-only user

It would be great if the API could support multiple users such that we could provide our development team with read-only access to query the API

👍

@rodriguesalex, @sureshsubramaniam: this is an upcoming feature in the Sensu Enterprise Console API (i.e. the Sensu Enterprise Dashboard backend). Which will not only provide token-based RBAC against the Sensu API, it will also provide a single API endpoint for multiple Sensu installations. This feature is scheduled for the next release, to become available later this month (July 2016).
There are no plans to implement these features in the Sensu Core API at this time, so I'm going to close this issue. Please feel free to visit the Sensu website to learn more about Sensu Enterprise, here: https://sensuapp.org/enterprise


Add current_diagnoses to the episode

Add field "current_diagnoses" in MongoDB Data model
Fill this field on encounter package creation Confluence (postprocessing, p.4 )
Handle diagnoses roleback Confluence (p.6)
Show "current_diagnoses" on gets Apiary

[ ] Bug: Two records in history for each encounter


[feature request] select text when dragging horizontally

hi
so im using in a list system with editable input text box's
and it keeps bugging me that when i go to select text it drags instead of selecting text
would b great if it there was an option that could allow it so when u drag vertically it moves and horizontally it selects text
http://jsbin.com/horatecuti/2/edit?output

I had the same issue on Firefox. Please add selectors "input, textarea" in the ignore options of the constructor. Beware that the defaults are "a, img".

i tried adding input to ignored but it appeared to do nothing
http://jsbin.com/tusiwoxaga/1/edit?js,output
i also tried filters and that disabled the dragging but hasnt allowed selection
http://jsbin.com/xacuboderi/2/edit?js,output
but i was hoping there would b a way to allow both text selection and dragging based on mouse direction

Any updates on this one?

Try master and use filter: 'input' + preventOnFilter: false
http://jsbin.com/tediyivoko/edit?html,css,js,output

thx @RubaXa
works perfectly
any idea when a stable release might come out?

19


Proposal: Wiki Restructure

Good morning
the WIKI could in my opinion use a little spring cleaning. All pages are on the same level without any structure.
In a first step I grouped them in three categories: Develop / Installation / Modules.
Then I created a custom sidebar with https://github.com/adriantanasa/github-wiki-sidebar/wiki so that those groups are in a tree structure.
I wouldnt and couldnt push such a change idrectly to the wiki git sicne only @MichMich has the rights for that so I created a repo where one can see these changes: https://github.com/rejas/MagicMirrorWiki
If you have more ideas on how to freshen up the wiki please tell so.
In my opinion it is THE place to look for modules and some tips & tricks that dont fit anywhere else. Or are there any other ideas on where to collect infos about modules?

I think most of the content of the Wiki can be moved to the docs website. The 3rd Party Modules list is probably the only one that needs to remain in the Wiki and Mirror Vendor List, since this is a community driven list.
For all other aspects (installation, faq, etc) it makes more sense to put that all in one spot: the documentation page.
Whats your thought about that?

Yes, only the modules list (and the hw vendors) is something that has a real place here since they need to (and will) be updated often. So for the moduels maybe just seperate the one big page into subpages like finance etc, just like the voice modules already have a page?
Module development is a prime candidate for the docs indeed.
I wasnt very sure about the tips / tricks for installation, Some might already be outdated now, some might need more updates than on release day...

how about managing the modules in a json file in the repo and then include them into the docs with a very good customizable search which uses the json from the repo?

That sounds nice but would require
a) someone to build something like this (could you?)
b) that MichMich would have to approve and merge an PR for every change.  Not sure if he would like that (or would delegate that work).

I once built a search engine for modules. The idea was that the community would help maintaining it. But in the end it was just yet one other thing for me to maintain and service. For now I prefer to just manage it in the Wiki.

If only it would be easy to build a pipeline like https://tiny-helpers.dev/ has... Not that I wouldnt find that a tempting task but I surely dont have the time for that :-D

I like the idea to have everything in the documentation page.
But I see no automated build process for the doc. We could leave the 3rd Party and Vendor List in a public repo and use an automated build (e.g. run weekly) for the doc stuff, where the 2 files are fetched and integrated in the doc.

The docs have an automated build process. As soon as I merge a change, the site will be updated.

I'd rlike to e-open this since I might want to slowly cleanup the wiki. First target:
Deletion of https://github.com/MichMich/MagicMirror/wiki/Running-Magic-Mi
rror-on-OSX-(and-potentially-windows)
Doesn thave any real value here, what you think @MichMich ? It would be easy to just push the delete button but I want to check back with you.

Yup. Go ahead. Everything that is in the documentation can be removed.

First PR opened for some pages: https://github.com/MichMich/MagicMirror-Documentation/pull/87/files
When that gets merged following pages can be deleted in the wiki:

https://github.com/MichMich/MagicMirror/wiki/Apple-Google-Microsoft-Calendar-Support
https://github.com/MichMich/MagicMirror/wiki/Module-Debugging
https://github.com/MichMich/MagicMirror/wiki/Notifications
https://github.com/MichMich/MagicMirror/wiki/Auto-Starting-MagicMirror

THe other wiki pages about on how to configure MM on linux/pi will be cleaned up later. I propose to just add a how-to for the latest raspi-os version and remove all old OS tips, sicne most users would download the latest version anyway. Any comments about that @MichMich ?

I deleted the pages mentioned above since the PR putting them in the official documentation site is now merged.
As for the installation pages I was planning to do that during the xmas holidays but alas I dont find the time right now. Hopefully in january :-)

No rush! Same here. Life gets in the way. 🤷🏻♂ Enjoy your holidays. 👍🏻

Please reopen @MichMich I am not yet finished ;-)

Could you also assing this issue to me @MichMich ?

Of course. 😬


fix(readme): Install good version of tweepy

The last version of Tweepy is not working with the bot.

Hello,
Thank you for this PR. This is the short term solution. In the long term it will be better to use https://docs.tweepy.org/en/stable/api.html#tweepy.API.verify_credentials.
we just have to replace api.me() with api.verify_credentials().

You should also fix the version in requirements.txt


[FEATURE] Highlighting Queries Improvements

Description
Hi! I read/write a lot of Hack code in my day-to-day. My primary editor is Neovim and I've been hoping to leverage tree-sitter to power syntax highlighting. However, the highlighting queries for Hack are pretty bare-bones: https://github.com/slackhq/tree-sitter-hack/blob/main/queries/highlights.scm
I was curious if you all would accept contributions to at the very least the highlight queries to be more in line with other tree-sitter grammars (here's PHP  for comparison).
I'd be potentially interested in augmenting the grammar or the parser as well to allow for more fine-tuned highlight queries, but I'd of course defer to you all for anything backwards incompatible.
Thank you!
Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

treesitter highlighting for Hack in neovim works pretty great. It uses a different highlight query than this project provides: https://github.com/nvim-treesitter/nvim-treesitter/blob/master/queries/hack/highlights.scm
we really just need to sync that file with the highlights provided in this repository.
Another good thing to add would be a locals.scm, since Hack has odd scoping rules.
IMO this is the last thing stopping tree-sitter-hack from being a "maintained" language for nvim-treesitter, it's just been on my backlog for a long time.


Graceful Exiting

Is there anyway to make the jpegio return a exception if it breaks in the libjpeg library? Currently if you try to read a jpeg that it can not parse properly or is not actually a jpeg file it will kill the entire program without being able to recover.

@asrabon
Could you demonstrate examples or cases in which an exception needs to be raised?
It will be helpful for me to refine the codes if I know the cases.

I can give you some more examples if you need them but these should give you a general idea of what I am talking about:

In libjpeg/src/jchuff.c: If the huffman table that is referenced is negative or larger than the maximum number of huffman tables then it runs ERREXIT1 which kills the entire program without being able to recover it.
if (tblno < 0 || tblno >= NUM_HUFF_TBLS)
ERREXIT1(cinfo, JERR_NO_HUFF_TABLE, tblno);
In libjpeg/src/jdmarker.c: If there is no SOI(Start of Image) marker then it runs ERREXIT2 which kills the entire program.
if (c != 0xFF || c2 != (int) M_SOI)
ERREXIT2(cinfo, JERR_NO_SOI, c, c2);

It would be nice everywhere libjpeg throws an ERREXIT of any kind it returned a python exception or error code rather than terminating the entire program by calling the exit function in C. If you wanted a trivial script you could run to see one example of the unrecoverable program termination.
from jpegio import read
jpeg = read("/path/to/some/file.gif")
print("Will never reach this print statement.")

@asrabon
Thanks for your explanation.
I am gonna try dealing with it .


[flaky-test] TestInstallChartWithAutomaticTolerationOnTaintedCPNode

Flaky Test
Running go integration tests
=== RUN   TestChartsTestSuite
=== RUN   TestChartsTestSuite/TestInstallChartWithAutomaticTolerationOnTaintedCPNode
    charts_test.go:108:
        	Error Trace:	/home/runner/_work/rancher/rancher/tests/v2/integration/catalogv2/charts_test.go:108
        	Error:      	Received unexpected error:
        	            	an error on the server ("unknown") has prevented the request from succeeding
        	Test:       	TestChartsTestSuite/TestInstallChartWithAutomaticTolerationOnTaintedCPNode
--- FAIL: TestChartsTestSuite (4.33s)
    --- FAIL: TestChartsTestSuite/TestInstallChartWithAutomaticTolerationOnTaintedCPNode (0.04s)

Release Branch
source branch of PR: main

Drone Build (if applicable)
pipeline stage URL:  https://github.com/rancher/rancher/actions/runs/10602494548/job/29392291780?pr=46874

The test case TestInstallChartWithAutomaticTolerationOnTaintedCPNode  comes from this PR https://github.com/rancher/rancher/pull/46347
cc @diogoasouza

Another occurrence of the failure: https://github.com/rancher/rancher/actions/runs/10840272499/job/30084149425?pr=47034#step:32:94


Compile/release for sbt 1.0 beta

sbt 1.0.0-M6 has been released: http://www.scala-sbt.org/1.0/docs/sbt-1.0-Release-Notes.html
Would be great if a compatible version could be published.
In the ideal case it would be a simple cross-compilation but maybe there are incompatibilities that need to be resolved.

Should have checked the readme first. I am not smart.

@leonardehrenfried Thanks for the notice. We still need to create binaries for sbt-1.0.0-M5. I'll upload a new version.

Released sbt-sonatype-2.0, which works with sbt-0.13.x, 1.0.0-M5 and M6.


feat!: Remove solve from PWG trait & introduce separate solvers for each blackbox

Related issue(s)
Works towards a resolution of the conversation at https://github.com/noir-lang/acvm/pull/247/files#r1180617953 and puts ACVM in a better position for self-implementing all of the opcodes (one by one).
Description
Summary of changes
This removes the solve function on the PartialWitnessGenerator trait and moves it into the pwg module as a standalone function that takes a backend. It also replaces solve_black_box_function_call with individual functions for each black box function being solved. This will allow us to systematically implement the blackbox function calls in ACVM and then remove them from the PWG interface for backends. Until (eventually) they are all gone and the backend doesn't need to implement anything for PWG; instead, just conforming to the ACVM implementation.
I've split these out into separate functions because leaking the BlackBoxFunc enum to a backend is misleading after #247 lands and keccak is handled by ACVM. However, it seems like we'll need pedersen for quite some time (probably as the only one?).
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt with default settings.
[x] I have linked this PR to the issue(s) that it resolves.
[x] I have reviewed the changes on GitHub, line by line.
[x] I have ensured all changes are covered in the description.

Additional context
(If applicable.)

@guipublic reviewed via DM while github was broken, I've pushed his suggested changes, so should be good for another review.

Much prefer this compared to original implementation as we can enforce removal of dead code in backends by removing bb functions from the trait.


SMT spending a day with Prototype team

SMT spending a day with Prototype team on Tuesday 11 October
What
SMT spending a day with Prototype team
Why
It's a great opportunity to spend some time in person with our SMT colleagues and tell them everything they need to know about the Kit.
Who needs to work on this
Team
Who needs to review this
Team
Done when

[x] Agenda confirmed
[ ] Presentations completed

AGENDA
10:00 - 16:00

Intro to the team - 10:00 - 10:10
History of how we got there - Joe 10:10 - 10:20
Q&A 10:20 - 10:30
What we know about our users and who our users are - Amelia (talk about personas) 10min
Demo old version of the kit - Joe - 10min
Pain points and known issues - Amelia - 10min
v13 & beta - Amelia - 5-10min (approach rather than findings)
Demo of the product (v13) - Joe - 10min
Q&A 10min
BREAK 15min
Check-ins 12:00 - 12:30
LUNCH 12:30 - 13:30
Technical architecture - Natalie 45 min
Q&A
Q3 and beyond - Ruth - 20min
Q&A

General awareness
What we want from SMT
Understanding and alignment of the product
Is there a strategy for DSP (Ruth to share and team to link it up with any points in the demo/talks)
Ben
Ruth
Izabela
Amelia
Laurence tbc
Natalie tbc
Nora tbc
Final agenda to be shared with SMT on Friday
Team to confirm and finalised on Thu

Final agenda shared with SMT.


Update solution-overview.md

Added the following statement about certification: It is also certified for ECC/Netweaver.

@batamig
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

I'll have to take this back to the team to confirm before I can approve. @dvir-ms @yohasson can you confirm?


I am not able to switch to new window from parent window. Switch page is not working

Can anyone help me

I am trying to switch on new browser window from parent window. I need to close new window switching on it. I have tried to use switch page() method,but it is not working for me.My code:
Driver ( original URL)
//Login using credentials
Search the document in desktop
wait for('give value ').click() // it will open document in viewer mode.
switch page('titel/URL/index)

Script is not switching to new page. Can some share code to figure out this issue


Add @pragma('vm:entry-point') to RestorableRouteBuilder arguments

Fixes https://github.com/flutter/flutter/issues/118565.
Behind the scenes, the restoration API for routes uses PluginUtilities.getCallbackHandle. For that to work correctly, the callback passed into these restoration methods must be marked with @pragma('vm:entry-point') as @mraleph explains in https://github.com/flutter/flutter/issues/118608. Ideally, we find a better solution for this in the future that doesn't leak this ugly implementation detail to consumers of the restoration API for routes. Until then, this ensures the feature works as advertised.

Is there any way to test this? (I can't think of one)

I can't think of a good way either. Ultimately, I think PluginUtilities.getCallbackHandle should just fail for callbacks that are not marked correctly, https://github.com/flutter/flutter/issues/118608#issuecomment-1396110151.


Support wasm files

wasm files produced by llvm will have DWARF in custom sections soon: https://reviews.llvm.org/D45118
I can implement this, but just filing this for posterity.

See also https://github.com/yurydelendik/wasm-dwarf/


nuxtCtx.tryUse is not a function

Describe the bug
 FATAL  nuxtCtx.tryUse is not a function                               08:56:01

  at tryUseNuxt (node_modules/@nuxt/kit/dist/index.mjs:54:18)
  at ModuleContainer.normalizedModule (node_modules/@nuxt/kit/dist/index.mjs:601:14)
  at node_modules/nuxt-delay-hydration/dist/module.cjs:2:53
  at async ModuleContainer.addModule (node_modules/@nuxt/core/dist/core.js:239:20)
  at async ModuleContainer.ready (node_modules/@nuxt/core/dist/core.js:51:7)
  at async Nuxt._init (node_modules/@nuxt/core/dist/core.js:478:5)

   ╭─────────────────────────────────────────────────╮
   │                                                 │
   │   ✖ Nuxt Fatal Error                            │
   │                                                 │
   │   TypeError: nuxtCtx.tryUse is not a function   │
   │                                                 │
   ╰─────────────────────────────────────────────────╯

To Reproduce
Steps to reproduce the behavior:
I am trying to use this on an exsisting project running in full static, Nuxt 2.
I have gotten this error before on other projects while using Nuxt 3.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Dont really know how to describe it futher, when i have time I will make a minimal reproduction.
Edit:
❯ npm why @nuxt/kit
<EMAIL_ADDRESS>node_modules/@nuxt/kit
<EMAIL_ADDRESS>from the root project
<EMAIL_ADDRESS>from<EMAIL_ADDRESS>  node_modules/nuxt-delay-hydration
<EMAIL_ADDRESS>from the root project

<EMAIL_ADDRESS>node_modules/@nuxtjs/sanity/node_modules/@nuxt/kit
<EMAIL_ADDRESS>from<EMAIL_ADDRESS>  node_modules/@nuxtjs/sanity
<EMAIL_ADDRESS>from the root project

But if anyone know would be of great help! Thanks!
And love the concept of the module! Would be great to show off awesome lighthouse stats to clients!

Hey @procrates
This issue is related to different @nuxt/kit's using different versions of unctx.
Couple of ways to fix this:

update the sanity module if possible
update your package manager to use<EMAIL_ADDRESS>(see https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/ or https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides)

Hey @harlan-zw
I'm having pretty much the same issue as OP.
Could you elaborate more on what the right setup should look like?
"resolutions": {
    "unctx"<EMAIL_ADDRESS>},

Thanks!

Hey @harlan-zw
I'm having pretty much the same issue as OP. Could you elaborate more on what the right setup should look like?
"resolutions": {
    "unctx"<EMAIL_ADDRESS>},

Thanks!

I think like this
"resolutions": {
    "unctx": "2.0.1"
},

Try upgrading nuxt / all modules if you're still having this though, they should have resolved it by now

Thank you @harlan-zw !
Unfortunately upgrading modules is not an easy option. But I'll test which changes can help without breaking anything crucial


Added new option showIdProperty to Shopware.grid.Panel

1. Why is this change necessary?
It should be possible to show the id of the record without overriding the entire function
2. What does this change do, exactly?
Adds a new config option showIdProperty to Shopware.grid.Panel
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-21083
Please use this issue to track the state of your pull request.

Hey @shyim,
thank you for your contribution! 🖤
Your changes will be merged soon!


Predictions using the Cox time varying fitter.

Hello @CamDavidsonPilon,
First of all, thanks a lot for providing us with the library!
My question is regarding making predictions using the Cox Time varying fitter. There is very little documentation about the issue.
My problem is that in CoxPH, we do not need to specify the time at which the covariates were measured as they are assumed to be constant over the whole observation period, for each individual. However, for the time varying method, it does make a difference to know at which point in time our covariates were measured.
Do we thus have to provide the start and stop time in our dataset in the .predict() method?
Thanks a lot,
Tom

Hey @pinouche, so prediction with time varying covariates has an internal paradox: if I know the covariates of a subject at each, surely I know if they are alive or not! See more here: https://cran.r-project.org/web/packages/survival/vignettes/timedep.pdf

Can we pre-assume covariates for each subject for a period of future time and check their survival probability for that time range? Different covariates will surely lead to different survival probability at different future times.  I don't need to know if they are alive or not. I need to get each individual's survival decay curve. Thanks.

Hi @CamDavidsonPilon, really appreciate the effort in bringing the lifelines library to life.
As discussed in https://github.com/CamDavidsonPilon/lifelines/issues/530, this can be legitimate use case in running future what-if scenarios -- not necessarily hitting the internal paradox you mentioned above. So, wanted to check if this can be included as a future enhancement, as it seems like the underlying components are available and we need to expose the survival function on top of the same.


feature: Expressions modernization

Is your feature request related to a problem? Please describe.
Code that is stuck with Python 3.8 and cannot use future annotations and has to use List, Optional, Union, etc.
Describe the solution you'd like
It would be nice if it was possible to "modernize" Griffe expressions on-the-fly, transforming  Optional[...] into ... | None, Union[A, B] into A | B, etc.
Describe alternatives you've considered
/
Additional context
Originally asked by @tiangolo in https://github.com/tiangolo/fastapi/pull/10392#issuecomment-1759487903

Implemented in Insiders v1.2.0 :slightly_smiling_face:


"Static Sprite" sample

This puts a © character on the screen at 40,40.
Something isn't quite right, as the background color is wrong.

It should look like:

LOL?


Exceptions in Bioagents child class should be raised instead of in parent

See the problem in: https://github.com/sorgerlab/bioagents/blob/master/bioagents/init.py#L54-L68
A specific example is InvalidModelDescriptionError being raised in MRA_Module but handled as generic Exception in parent class.

Fixed in #46


Find and replace "ipython" in sample notebooks

Example:
In "BigQuery - Extracting Data"
gcs_bucket = gcp.Context.default().project_id + '-ipython'
Bucket names etc should also avoid "ipython". Primarily because the name should not be used per license and secondarily because we don't want to create confusion between IPython & Datalab.

Given we have very few references and should rarely need them, and that lawyers have OKed them anyway so they are not a ship stopper, I'm closing this.


improve type inference for mapFormulas()

I got annoyed by VsCode constantly complaining that n could be a StrNode in the following example.
// nodes is NumNode[]
mapFormulas(nodes, n => n, n => {
  // stuff with n
})

This is still force-casting albeit on a mapFormula level. If we're improving on this front, it might be better to add parametric type for the "permissible leaf", e.g., Base<Leaf>, Threshold<ConditionLeaf, ValueLeaf>. Such change could go directly into master.
If the type-checker proves inadequate to do that, we may need to do something like this, though I'm not 100% sure if that is advisable just yet.
Meanwhile, one can still do
mapFormula(..., _f => {
  const f = _f as NumNode
})

which is not the best, but still keep the casting explicit.

Let's explore a bit the parametric "permissible leaf nodes" I mentioned. If it's a dead end, we'll merge this.

We ended up using the alternate approach (#698) instead, which should also give a robust type inference.


Android - Notification not always fired

Hi,
I have an issue with OnNotification javascript events which are not always working/fired on Android.
Below is how I initialize notifications:
    push = PushNotification.init({
        android: {
            senderID: "xxxxxxxxx",
            forceShow: true
        }
    });

On the server side, I send notifications with:
var message = new gcm.Message({
    collapseKey: 'TopNews',
    priority: 'high',
    contentAvailable: true,
    delayWhileIdle: true,
    data: {
        key1: 'message1'
    },
    notification: {
        title: "Hello Title",
        icon: "ic_launcher",
        body: "My body"        }
});

In the case the App is in foreground:
when I tap on a notification,  OnNotification javascript event is always fired.
In the case the App is the background:
when I tap on a notification, OnNotification is sometimes fired.
In the case the App coldstarts:
when I tap on a notification, OnNotification is sometimes fired.
When OnNotification is not fired, below is the adb logcat:
I/GCM     (  744): GCM message app.xxxxxx.xxxxxxxxx 0:1453723285525624%9170c9aa9170c9aa
D/dalvikvm( 4719): Late-enabling CheckJNI
I/ActivityManager(  460): Start proc app.xxxxxx.xxxxxxxxx for broadcast app.xxxxxx.xxxxxxxxx/com.googl
e.android.gms.gcm.GcmReceiver: pid=4719 uid=10076 gids={50076, 3003, 1028, 1015}
I/dalvikvm( 4719): Could not find method android.content.pm.PackageManager.getPackageInstaller, referenced from method c
om.google.android.gms.common.zze.zzi
W/dalvikvm( 4719): VFY: unable to resolve virtual method 462: Landroid/content/pm/PackageManager;.getPackageInstaller ()
Landroid/content/pm/PackageInstaller;
D/dalvikvm( 4719): VFY: replacing opcode 0x6e at 0x000b
I/GMPM    ( 4719): App measurement is starting up, version: 8487
I/GMPM    ( 4719): To enable debug logging run: adb shell setprop log.tag.GMPM VERBOSE
E/GMPM    ( 4719): GoogleService failed to initialize, status: 10, Missing an expected resource: 'R.string.google_app_id
' for initializing Google services.  Possible causes are missing google-services.json or com.google.gms.google-services
gradle plugin.
E/GMPM    ( 4719): Scheduler not set. Not logging error/warn.
I have no idea what is wrong but if any of you had a clue of what I can do to solve my issue, I would be very greatful. Thanks in advance for your answer,

Move all of your fields from the notification object to the data object. GCM will not delegate handling of push notifications to listeners (this plugin uses listeners) if a notification object is present, and that's why the plugin can't run anything (including your .on('notification')). It should look something like this:
var message = new gcm.Message({
    collapseKey: 'TopNews',
    priority: 'high',
    contentAvailable: true,
    delayWhileIdle: true,
    data: {
        key1: 'message1',
        title: "Hello Title",
        icon: "ic_launcher",
        body: "My body"
    }
});

Thank a lot!
A clarification for those who encounter the same problem. Remove Property "contentAvailable" when moving all fields to data. Otherwise the android notification appears without the title and defined body. And the javascript event is not triggered. A priori, this property has no more relevance in this context.
Thanks again fredgalvao!
(I was going crazy!)


net/mail: TestDateParsingCFWS failing on linux-mips64le-mengzhuo

net/mail TestDateParsingCFWS is failing consistently on linux-mips64le-mengzhuo since https://go-review.googlesource.com/c/go/+/152877 was checked in. Seems like it could be related.
--- FAIL: TestDateParsingCFWS (0.00s)
    message_test.go:256: Header(Date: Fri, 21 Nov 1997 09:55:06           CST).Date() = 1997-11-21 09:55:06 +0800 CST, want 1997-11-21 09:55:06 +0000 CST
    message_test.go:267: ParseDate(Fri, 21 Nov 1997 09:55:06           CST) = 1997-11-21 09:55:06 +0800 CST, want 1997-11-21 09:55:06 +0000 CST
    message_test.go:256: Header(Date: Fri, 21 Nov 1997 09:55:06           CST (no leading FWS and a trailing CRLF)
        ).Date() = 1997-11-21 09:55:06 +0800 CST, want 1997-11-21 09:55:06 +0000 CST
    message_test.go:267: ParseDate(Fri, 21 Nov 1997 09:55:06           CST (no leading FWS and a trailing CRLF)
        ) = 1997-11-21 09:55:06 +0800 CST, want 1997-11-21 09:55:06 +0000 CST
FAIL
FAIL	net/mail	0.032s

/cc @bradfitz @ianlancetaylor @buchanae

CC @iWdGo


Add option to remove only local stale branches

It would be nice to be able to remove stale branches, but only the local ones. My use case is I'm working in a large team, and there are a bunch of branches that while stale upstream, are not necessarily ones we want to remove without a discussion.

good idea, will add that asap

This has been implemented as the -l flag - let me know if there are any issues using it.

Thanks so much!


Fix resampling issue in regions of overlap between orders and certain end artifacts

After deblazing each order of an APF stellar spectrum, two more steps must be taken before the spectrum can be input into SpecMatch-Emp: combining the spectral orders, and resampling onto the reference/library wavelength scale. In the original method of resampling a deblazed APF spectrum onto the SpecMatch-Emp library wavelength scale, these are done simultaneously by looping over each library wavelength value, finding all elements of the spectrum that are within +/- 0.17 A of that value, and averaging those values. Because the orders overlap, this often means averaging not only adjacent values within one order but also between orders.  This is done by calling the script called resample.py.
However, this method results in a much 'noisier' spectrum in the region of overlap between orders.
In addition, there are some issues at the ends of each order: 1) an 8 pixel wide dip in flux which comes from the blaze functions containing 8 zero-valued pixels at the end of each order, and 2) a 100 pixel wide section at each end of each order where the deblazed order is gradually set equal to the undeblazed order. These issues could both be fixed in the deblazing step or in the resampling step.
All three of these issues are evident in the example segment of HIP111169 (note that the step-like offsets between orders is a different issue from the deblazing which must be resolved separately).

Solution
The second two parts of this issue are easiest to resolve: I simply truncate each order by 100 pixels on each end (actually, by 101 pixels on the right-hand end in order to keep the same number of pixels as the APF wavelength solution).
To fix the first issue, I changed the method for resampling and combining orders: I now resample each order individually onto the section of the reference wavelength scale corresponding to that order, then combine orders by averaging exactly two values in the regions of overlap.
Why does this work better?
The old method of resampling often ends up averaging more than two values for each pixel in the overlapping region, because when the two orders are combined, the effective spacing between pixels is decreased by, on average, a factor of two (and now, half come from one order and half from the other).  When there is an offset between the orders (as there currently is due to an issue with the deblazing), if there are more pixels in the average from one order than the other that will pull the average towards one order or the other. Since the number of pixels used from each order is different for each reference wavelength value, with there sometimes being more from the first order and sometimes more from the second, this would cause the apparent 'noisiness' in the averaged region. In contrast, in the new resampling method we only ever average one or two pixels and this issue is avoided. Of course, this issue will also be much less apparent once the deblazing is modified so that no offset occurs.
Code modifications
In practice, this means first creating a new method called resample_order (which resamples just one order) and importing it (currently it is located in rescale2.py), and then replacing the following lines of code which appear in the run_smemp_apf.py script.
Old version:
# Get a wavelength solution rescaled onto the scale of the library
lib_wl_soln = get_rescaled_wave_soln()

# Resample the spectrum onto the new wavelength scale
data_new = resample(wave_soln_ref, wave_soln, data)

New version:
# resample each order individually
lib_wl_soln = get_rescaled_wave_soln()
resampled_orders = np.empty(shape=(0))
resampled_wl = np.empty(shape=(0)) # contains resampled wl for each order concatenated (so there are repeats)
for order in np.arange(30,52,1):
    order_values = data[order][100:-101] # truncate the ends because the deblazing doesn't work well here --> unless in future iteration do this in deblazing
    apf_wl_values = wave_soln[order][100:-100]
    first = apf_wl_values[0]
    last = apf_wl_values[-1]
    new_first = first - 0.017
    new_last = last + 0.17
    new_wl_section = np.array(lib_wl_soln)[(new_first <= lib_wl_soln) * (new_last >= lib_wl_soln)]
    resampled_order = resample_order(new_wl_section, apf_wl_values, order_values)
    resampled_orders = np.hstack([resampled_orders, resampled_order])
    resampled_wl = np.hstack([resampled_wl, new_wl_section])

# average duplicate flux values
resampled_spectrum = np.zeros(len(lib_wl_soln))
i=0
for wl in lib_wl_soln:
    values = resampled_orders[resampled_wl == wl]
    avg = np.nanmean(values)
    resampled_spectrum[i] = avg
    i += 1

This produces the following result:

IMPORTANT NOTE: this has NOT yet been implemented in the actual run_smemp_apf.py script.


fix: error commit #253

Codecov Report

Merging #278 (7e0af75) into main (a974c86) will decrease coverage by 0.09%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   62.55%   62.45%   -0.10%
==========================================
  Files          41       41
  Lines        7055     7061       +6
==========================================
- Hits         4413     4410       -3
- Misses       2263     2271       +8
- Partials      379      380       +1

Impacted Files
Coverage Δ

pkg/monitor/agent.go
69.70% <83.33%> (+0.16%)
:arrow_up:

pkg/controller/policy/cache/rule.go
89.40% <0.00%> (-8.61%)
:arrow_down:

plugin/tower/pkg/controller/policy/controller.go
83.28% <0.00%> (-0.46%)
:arrow_down:

plugin/tower/pkg/controller/global/controller.go
84.80% <0.00%> (+1.47%)
:arrow_up:

plugin/tower/pkg/controller/endpoint/controller.go
80.76% <0.00%> (+1.92%)
:arrow_up:


how to specify AnkiConnect server address ?

Hi @rampaa, integration with Anki requires setting up AnkiConnect server address. how could I do this ? I do not find such entries in Anki Desktop Preferences ...

Preferences->Anki

@rampaa, I got Communication error ! Is Anki open? though I turn on the Anki Desktop App ... Do you think the server address is different (e.g. not <IP_ADDRESS>:8765) ?

You need to be in mining mode in order to mine words. "Left click/Touch" and "Text select" lookup modes will automatically activate the mining mode. If you are using the "Mouse move" lookup mode, you can activate the mining mode with a middle mouse click or with the mining mode hotkey. When you enable the mining mode, you should see a message showing you how to mine a word like:

In this case you need to press the orange-colored 妹 character.
You can also use your keyboard to mine words, if you prefer that, see the following hotkeys:


Android release build error on v1.1.14  RNMixpanel.sharedInstanceWithToken got 3 arguments, expected 4

When I try and create a release build using react-native run-android --variant=release, the app builds successfully, but then when I open it on the simulator I get:
E/AndroidRuntime: FATAL EXCEPTION: mqt_native_modules
    Process: com.finimize.myapp, PID: 23809
    com.facebook.react.bridge.NativeArgumentsParseException: RNMixpanel.sharedInstanceWithToken got 3 arguments, expected 4
        at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:348)
        at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:150)
        at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:26)
        at android.os.Looper.loop(Looper.java:193)
        at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:225)
        at java.lang.Thread.run(Thread.java:764)

Library version 1.1.14, RN version 0.61.5
The Android gradle dependency tells me I'm using this version com.mixpanel.android:mixpanel-android:5.6.8@aar
I've tested this on someone else's machine too and the same issue.

I have same problem.

Its ok in removing metro cache file

@matt-dalton  how did you fix it ? if you have

you have a metro-cache directory under the tmp directory of your operating system.
Remove this metro-cache file and rebuid.

TypeError: Mixpanel.sharedInstanceWithToken is not a function

Same here upgrading from 1.1.1 to 1.2.0, going to downgrade, since I've have checked followed these are far as I can tell

https://github.com/davodesign84/react-native-mixpanel#additional-info-for-android-version--112
https://github.com/mixpanel/mixpanel-android/releases
https://github.com/mixpanel/mixpanel-android/releases/tag/v5.5.1
https://github.com/davodesign84/react-native-mixpanel/releases (nothing here)

@matt-dalton how did you fix it ? if you have

Sorry @enigmablue - didn't see this. I'm still having problems with it. It just only seems to affect release builds on my simulator, so have just been building on device until now.

you have a metro-cache directory under the tmp directory of your operating system.
Remove this metro-cache file and rebuid.

I tried this:
rm -rf $TMPDIR/metro-*
And rebuilt and it didn't seem to fix anything.
Has anyone else managed to work this out?

@matt-dalton how did you fix it ? if you have

Sorry @enigmablue - didn't see this. I'm still having problems with it. It just only seems to affect release builds on my simulator, so have just been building on device until now.

you have a metro-cache directory under the tmp directory of your operating system.
Remove this metro-cache file and rebuid.

I tried this:
rm -rf $TMPDIR/metro-*
And rebuilt and it didn't seem to fix anything.
Has anyone else managed to work this out?


Reorganization & ADB

On the surface, no changes other than text mostly.
Underneath....
Completely reformatted and reorganized all code into indvidiudual files based on purpose.
Converted screenshot method to android debug bridge screenshot grabbing. This proves to be substantially slower, but the purpose of this project is not for speed but stability and learning.

closes #12 #11 #10 #6


Sparse array approach

Move from scipy sparse matrices to sparse arrays using the sparse library. This simplifies the index gymnastics a bit, avoid the special numpy matrix interface (cf the note at the top of here), and should allow us to work with dask a bit more easily.
Draft PR for now since it is built on #22 and should be seen as proof of concept.

@bjlittle the greetings task of the ci seems to fail and I have no idea why. Have you seen this problem before?

This looks interesting, I'll have to have a play around with sparse to see what it can do here.
My first concern is that I think I'll probably want to re-integrate and test against some level of back-end unstructured mesh support before changing too much about the regridding mechanics. Part of my thinking when creating the _flatten_array and _unflatten_array method was to have the dimensions of the grid be solely the concern of the GridInfo class (or MeshInfo for unstructured meshes). I would want to be confident that this approach would also work if we tried it with meshes where the data was a 1d array.
Secondly, I'm curious what advantages sparse gives us with respect to dask. I have seen some work in Iris to give our regridders more dask support (https://github.com/SciTools/iris/pull/3701) and the iris regridders are using scipy.sparse arrays. Is there anything sparse would give us that would go beyond this? Perhaps it would be worth comparing performance eventually.

Play away :smile:
To your first concern, I did have that use case in mind, and I think it shouldn't matter.
I look at it like this: the source data comes in as a tensor with a bunch of indices, say S_{ij} where i refers to latitudes and j to longitudes. Similarly, we want a target output T_{kl}. From ESMF we get weights w_{klij} and we can write our regridding as T_{kl} = w_{klij} S_{ij} using Einstein sum convention or, more explicitly T_{kl} = \sum_{i,j} w_{klij} S_{ij}.
Now suppose the source data comes in as a 1d vector, but we still want a 2d output. Then the weights we get back from ESMF will have three indices w_{kli}, and the equation becomes T_{kl} = \sum_{i} w_{kli} S_{i}. Or maybe we want to regrid regular data to a mesh? T_{k} = \sum_{ij} w_{kij} S{ij}. Mesh to mesh? T_{k} = \sum_{i} w_{ki} S_{i}.
What about 3D timeseries? T_{mnkl} = \sum_{ij} w_{klij} S_{mnij}. Perhaps with full 3d regridding in the future? T_{mnkl} = \sum_{ijp} w_{nklpij} S_{npij}. I'll stop short of time dependent regridding.
The point is that all those right-hand sides amount to one tensordot(weights, source, axes=axes) call each with appropriate axes arguments, which only depend on the shapes of S and T. The result of that operation always has the right shape.
To your second point, first a point of terminology: As far as I understand, scipy.sparse only offers matrices, ie exactly two dimensional objects. When speaking of arrays, we generally think of arbitrary dimensional objects. That is precisely what sparse offers us in a, well, sparse way. That's also why it interacts nicely with dask: It's straightforward to have a dask array where the chunks are sparse arrays instead of numpy arrays. This doesn't work so nicely with (sparse) matrices because neither slicing nor stacking are clear when the dimensionality changes. Moreover, the semantics of matrices differ from those of ndarrays (see, e.g. multiplication *). How would that carry through to a hypothetical dask sparse matrix?
If we put the weights into a dask sparse array using sparse, we simply call dask.array.tensordot instead of numpy.tensordot and dask will take care of any necessary rechunking to bring the requisite bits of weights to the right input data.
This also seems to be the recommended approach to sparse arrays in dask, see here.

I've done a bit of experimenting with sparse/dask to see how well to see how well tensordot would work with chunked arrays. I tried the following code with the latest version of dask:
import sparse
import scipy.sparse
import numpy as np
import dask.array as da
from datetime import datetime

x = da.random.random((4, 4), chunks=(2, 2))
x[x < 0.65] = 0
chunked_sparse_data = x.map_blocks(sparse.COO)

print("random matrix:")
print(chunked_sparse_data.compute().todense())

lazy_chunked_result = da.dot(chunked_sparse_data, chunked_sparse_data)

t = datetime.now()
chunked_result = lazy_chunked_result.compute()
print(f"Time taken for dask/sparse product: {datetime.now() - t}")

scipy_sparse_data = scipy.sparse.csr_matrix(chunked_sparse_data.compute().todense())

t = datetime.now()
scipy_result = scipy_sparse_data * scipy_sparse_data
print(f"Time taken for scipy.sparse product: {datetime.now() - t}")

t = datetime.now()
numpy_result = np.dot(x.compute(), x.compute())
print(f"Time taken for numpy product: {datetime.now() - t}")

print("numpy result = scipy.sparse result")
print(np.allclose(scipy_result.todense(), numpy_result))

print("dask/sparse result = scipy.sparse result")
print(np.allclose(scipy_result.todense(), chunked_result.todense()))

Which gave the following results:
random matrix:
[[0.         0.         0.95641988 0.        ]
 [0.95865256 0.89930353 0.84667644 0.        ]
 [0.         0.         0.         0.        ]
 [0.82999434 0.         0.         0.        ]]
Time taken for dask/sparse product: 0:00:02.275874
Time taken for scipy.sparse product: 0:00:00.000224
Time taken for numpy product: 0:00:00.010662
numpy result = scipy.sparse result
True
dask/sparse result = scipy.sparse result
False

It looks as though there is a bug, probably with dask.array.tensordot (it looks like this bug happens specifically when the data is chunked). It's also concerning that the sparse calculation is considerably longer than the scipy.sparse calculation. It may well be that much of this is a one time overhead and there is a tipping point at which using dask/sparse becomes more efficient, but at the moment it looks as though it is likely that we might want to keep working with scipy.sparse until dask/sparse improves. I feel like it might still be possible, though perhaps slightly more difficult, to incorporate scipy.sparse into some kind of dask framework so long as chunking is done on dimensions other than latitude/longitude.

I've raised an issue with dask about the above problem https://github.com/dask/dask/issues/6907.

Thanks for the testing!
The apparent bug does concern me, though my own testing suggests that this has nothing to do with sparse and is a rather strange problem. Notably, replacing the line
chunked_sparse_data = x.map_blocks(sparse.COO)

with
chunked_sparse_data = x.map_blocks(sparse.COO).persist()

(i.e. adding .persist(), thereby calculating the preceding graph, ending up with really only the four constituent blocks) makes all calculations equivalent.
Tracing the calls, it seems dask passes wrong submatrices to sparse. Of course, this must be addressed in dask.
The timings do not concern me. The numbers as presented here suffer from at least four problems:

We don't compare like with like. Only the scipy.sparse calculation gets the benefit of localizing all data before performing the calculations. That's just not saying anything about scipy.sparse vs sparse, or indeed a matrix interface with specialized multiplication vs an array interface with explicit (tensor)dot.
This is multiplying two sparse matrices. That's not the case we are interested in. Rather, we are looking at the application of one sparse, matrix-like thing to a large, full array.
The size and chunking are completely unrepresentative of our use case.
Timing is not a trivial task and just doing it with a call to datetime.now before and after has to be taken with a huge grain of salt; doubly so if the times are in the milli- and microsecond range. I suspect that you at least ran the code a couple of times and got similar results, but when we want to look at timing more seriously, we should probably have a look at timeit and perhaps the corresponding ipython/jupyter magics %time and %timeit. Some more information can be found in Jake VanderPlas' Python Data Science Handbook.

I agree that the timings are by no means rigorous, but I still think it's something we should figure out before commiting to either package. With that said, it is somewhat tricky knowing what type of calculations to measure before having a complete design. My concern with sparse is that it may be using a fundamentally slower algorithm for the necessary calculations. The fundamental object in sparse is a COO array, scipy.sparse also has COO matrices, but recomends CSR/CSC matrices for certain calculations because they are inherently faster (https://docs.scipy.org/doc/scipy/reference/generated/scipy.sparse.coo_matrix.html). The sparse documentation suggests that for some operations it first translates to an appropriate scipy.sparse matrix, though this is not necessarily the case for tensordot (the documentation suggests this calculation had to be reimplemented, though the language is not entirely clear to me - https://sparse.pydata.org/en/stable/#design). My suspicion is that while it may be slightly trickier to work with, there may well be a viable design involving scipy.sparse with some level of dask support (using map_blocks perhaps) which gives better performance.
I think it would be good to have a discussion at some point about how we plan to design sparse/dask integration and how best to compare the performance of those designs.

Interestingly, the same PR in dask (https://github.com/dask/dask/pull/6846) which seems to fix the above bug also looks like it will offer some level of dask integration for scipy.sparse.


IOS popping up a bottom sheet above a webview will penetrate through the underlying webview.

[x] I have read the Getting Started section
[x] I have already searched for the same problem

Environment

Technology
Version

Flutter version
3.3.2

Plugin version
5.4.4+3

Android version

iOS version

macOS version

Xcode version

Device information:
Description
Expected behavior:
Current behavior:
Steps to reproduce

This
Than that
Then

Images
Stacktrace/Logcat

Stack(children: [
Opacity(
opacity: 0.01,
child: WebViewWidget(controller: WebViewController())
),
const CircularProgressIndicator(),
]);

wrap your flutter_inappwebview with another webview could temporary fix it
or subscribe to this issues for more info
https://github.com/flutter/flutter/issues/30143


Fix for issue #143

Fixed crash when running ch.exe -Dump:Encoder ..\..\..\..\test\benchmarks\Octane\pdfjs.js
Fixes Microsoft/ChakraCore#143

Hi @darth10, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Thanks @darth10 for contributing. Can you please add details of the cause of the bug?

Question: Who deletes branchJumpTableWrapper now?

Deleting the branchJumpTableWrapper objects in the Map method was causing the error.
Of course, I could be wrong.
Perhaps, we should just do a null check instead?

Hi guys, the IR.cpp also needs to be changed, otherwise wrong instructions will be dumped. I believe keeping branchJumpTableWrapper instead of deleting it without destructing the MultiBrInstr would help prevent dangling pointers.
--- a/lib/Backend/IR.cpp
+++ b/lib/Backend/IR.cpp
@@ -4143,6 +4143,8 @@ Instr::Dump(IRDumpFlags flags)
     {
         BranchInstr * branchInstr = this->AsBranchInstr();
         LabelInstr * targetInstr = branchInstr->GetTarget();
+        bool labelPrinted = false;
+
         if (targetInstr == NULL)
         {
             // Checking the 'm_isMultiBranch' field here directly as well to bypass asserting when tracing IR builder
@@ -4150,21 +4152,29 @@ Instr::Dump(IRDumpFlags flags)
             {
                 IR::MultiBranchInstr * multiBranchInstr = branchInstr->AsMultiBrInstr();

-                multiBranchInstr->MapMultiBrLabels([](IR::LabelInstr * labelInstr) -> void
+                // A MultiBranchInstr may have been lowered to a JMP instruction, so if that
+                // is the case, we don't need to print the labels.
+                if (this->m_opcode == Js::OpCode::MultiBr)
                 {
-                    Output::Print(L"$L%d ", labelInstr->m_id);
-                });
+                    multiBranchInstr->MapMultiBrLabels([](IR::LabelInstr * labelInstr) -> void
+                    {
+                        Output::Print(L"$L%d ", labelInstr->m_id);
+                    });
+                    labelPrinted = true;
+                }
             }
             else
             {
                 Output::Print(L"??");
+                labelPrinted = true;
             }
         }
         else
         {
             Output::Print(L"$L%d", targetInstr->m_id);
+            labelPrinted = true;
         }
-        if (this->GetSrc1())
+        if (this->GetSrc1() && labelPrinted)
         {
             Output::Print(L", ");
         }

Closing for now.

@darth10 I talked to @satheeshravi about this. It is ok to not delete branchJumpTableWrapper. The branchJumpTableWrapper is allocated from jit arena allocator. Arena allocator have a short life time and will be collected any way.

That's great!
Also, I see Microsoft/ChakraCore#162 is also fixed by @mcfi in PR #163.
So, I think we're all set.
Reopening.

Hi @darth10, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Should we remove the method as well now that it is unused?
https://github.com/Microsoft/ChakraCore/blob/9229c3387b695b2e2fb247681b26d6e6514bc6d1/lib/Backend/IR.h#L57


Remove pluggable components CRD from charts

Signed-off-by: Marcos Candeia<EMAIL_ADDRESS>Description
Removing pluggable components CRD from charts.
Issue reference

n/a
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test

Quick suggestion just for reference link the discussion regarding removal of this crd?

Quick suggestion just for reference link the discussion regarding removal of this crd?

Here @mukundansundar
https://github.com/dapr/dapr/issues/5210#issuecomment-1258479834