[WIP] nydus-image: fix unpack from specify blob dir

Fix the panic when user specify --blob-dir on unpack:
$ nydus-image unpack --bootstrap /path/to/bootstrap \
    --blob-dir /path/to/blobs \
    --output /path/to/oci.tar

Error: fail to unpack

Caused by:
    both blob path or blob backend config are not specified

Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Go over all the following points, and put an x in all the boxes that apply.

[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

Really helpful fix, I thought it was a problem with my usage, so I could only use the --blob parameter instead of --blob-dir.
Thanks a lot!

Otherwise LGTM!

Fixed in master.


Add JUnit 5 support test coverage and documentation

Summary
The code should work for JUnit 5, but it has not been tested yet. It would be nice to have a few tests and an example in the documentation
References
No response

What is the suggested approach to manage junit4 and junit5 tests?
Option 1
Keep junit4 and junit5 classes close to each other by copying existing tests and  adjust for Junit5. So we will have structure like that:
src
├── main
│   └── ...
├── test
│   ├── java
│   │   └── org.wiremock.integrations.testcontainers
│   │       ├── WireMockContainerExtensionJunit4Test
│   │       ├── WireMockContainerExtensionJunit5Test
│   │       ├── WireMockContainerJunit4Test
│   │       └── WireMockContainerJunit5Test
│   └── resources
│       ├── logback-test.xml
│       └── org.wiremock.integrations.testcontainers
│           ├── WireMockContainerExtensionJunit4Test
│           ├── WireMockContainerExtensionJunit5Test
│           ├── WireMockContainerJunit4Test
│           └── WireMockContainerJunit5Test
└── ...

Option 2
Add separate test source folder using build-helper-maven-plugin so we will have following structure
src
├── main
│   └── ...
├── test-junit4
│   ├── java
│   │   └── org.wiremock.integrations.testcontainers
│   │       ├── WireMockContainerExtensionJunit4Test
│   │       └──  WireMockContainerJunit4Test
│   └── resources
│       ├── logback-test.xml
│       └── org.wiremock.integrations.testcontainers
│           ├── WireMockContainerExtensionJunit4Test
│           └── WireMockContainerJunit4Test
├── test-junit5
│   ├── java
│   │   └── org.wiremock.integrations.testcontainers
│   │       ├── WireMockContainerExtensionJunit45Test
│   │       └──  WireMockContainerJunit5Test
│   └── resources
│       ├── logback-test.xml
│       └── org.wiremock.integrations.testcontainers
│           ├── WireMockContainerExtensionJunit5Test
│           └── WireMockContainerJunit5Test
└── ...

@bitxon I would keep the first approach for now. If we have too many tests in the future, which would be a good problem to have,  we could refactor it. I doubt there will be too many test files, and not all tests will require JUnit 4 and 5 coverage
FTR there is a patch from @kapishmalik in https://github.com/wiremock/wiremock-testcontainers-java/pull/16


Jobs with R0 (timesToRepeat: 0) get re-run upon server restart

Hello,
What I'm seeing is something that doesn't quite square with my understanding of how things should be (and my understanding may be off here). If a job is submitted with R0--that is only to execute a single time and not scheduled to repeat--and then I restart the kala process, it reads the jobs back in from the job cache with a start time in the past and then executes the job.
I ran a test case with a job that curls a locally running web server, and when restarting kala I see an entry in the web servers log indicating it was hit. Furthermore, the stats for the job when inspected by GET on /job/{job_id} indicates the job executing a few times (see attached job JSON) even though it is meant to only execute once.
Is this expected behavior? I'm a misconfiguring somehing, or is it a bug?
Thanks much.
Here's the JSON for the job. This was supposed to execute once, but I restarted the server twice after it executed once, resulting in multiple executions:
{
    "job": {
        "command": "curl http://localhost:8080",
        "dependent_jobs": null,
        "disabled": false,
        "epsilon": "",
        "id": "89e33016-9240-43b2-6516-89b26f96bac6",
        "metadata": {
            "error_count": 0,
            "last_attempted_run": "2016-03-01T00:17:19.920306138Z",
            "last_error": "0001-01-01T00:00:00Z",
            "last_success": "2016-03-01T00:17:19.933363004Z",
            "success_count": 3
        },
        "name": "scheduled job",
        "next_run_at": "2016-03-01T00:08:13.10126407Z",
        "owner": "",
        "parent_jobs": null,
        "retries": 0,
        "schedule": "R0/2016-02-29T16:07:58-08:00/PT",
        "stats": [
            {
                "execution_duration": 18041450,
                "job_id": "89e33016-9240-43b2-6516-89b26f96bac6",
                "number_of_retries": 0,
                "ran_at": "2016-03-01T00:07:58.001177058Z",
                "success": true
            },
            {
                "execution_duration": 15145524,
                "job_id": "89e33016-9240-43b2-6516-89b26f96bac6",
                "number_of_retries": 0,
                "ran_at": "2016-03-01T00:08:13.101358483Z",
                "success": true
            },
            {
                "execution_duration": 12510431,
                "job_id": "89e33016-9240-43b2-6516-89b26f96bac6",
                "number_of_retries": 0,
                "ran_at": "2016-03-01T00:17:19.920854808Z",
                "success": true
            }
        ]
    }

Hey @james-m, sorry for the delayed response.
So that is absolutely not expected behavior. I have a quick fix in testing at the moment, and will merge it into master shortly.


Main handlebars charlotte

Main.handlebars:

Added in HTML for navbar/header
Added in links to Bootstrap, Google Fonts and separate CSS
Added in script at bottom for signout.js

Public CSS:

Added in styling for elements, classes, ids in both the main.handlebars and signin.handlebars

approved


symengine.py does not correctly link to libpython

Placing a symlink to libpython in the cwd works around the problem.
~$ python -c "import symengine"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "~/anaconda3/lib/python3.4/site-packages/symengine/__init__.py", line 1, in <module>
    from .lib.symengine_wrapper import (Symbol, Integer, sympify, SympifyError,
ImportError: dlopen(~/anaconda3/lib/python3.4/site-packages/symengine/lib/symengine_wrapper.cpython-34m.so, 2): Library not loaded: libpython3.4m.dylib
  Referenced from: ~/anaconda3/lib/python3.4/site-packages/symengine/lib/symengine_wrapper.cpython-34m.so
  Reason: image not found

Per comments here: http://stackoverflow.com/questions/26815537/opencv-3-0-0-alpha-with-python-3-failed-to-import-cv2
~$ otool -L ~/anaconda3/lib/python3.4/site-packages/symengine/lib/symengine_wrapper.cpython-34m.so
~/anaconda3/lib/python3.4/site-packages/symengine/lib/symengine_wrapper.cpython-34m.so:
	libpython3.4m.dylib (compatibility version 3.4.0, current version 3.4.0)
	~/opt/gmp/lib/libgmpxx.4.dylib (compatibility version 9.0.0, current version 9.0.0)
	~/opt/gmp/lib/libgmp.10.dylib (compatibility version 13.0.0, current version 13.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 120.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1213.0.0)

Thanks for the bug report. Can you try the following patch?
diff --git a/cmake/FindPython.cmake b/cmake/FindPython.cmake
index 5513ff7..ab0307b 100644
--- a/cmake/FindPython.cmake
+++ b/cmake/FindPython.cmake
@@ -47,6 +47,9 @@ FIND_LIBRARY(PYTHON_LIBRARY NAMES
     NO_SYSTEM_ENVIRONMENT_PATH
     )

+add_library(python UNKNOWN IMPORTED)
+set_property(TARGET python PROPERTY IMPORTED_LOCATION ${PYTHON_LIBRARY})
+
 execute_process(
        COMMAND ${PYTHON_BIN} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
        OUTPUT_VARIABLE PYTHON_INSTALL_PATH_tmp
@@ -119,7 +122,7 @@ macro(ADD_PYTHON_LIBRARY name)
     ENDIF(${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
     set_target_properties(${name} PROPERTIES PREFIX "")
     set_target_properties(${name} PROPERTIES OUTPUT_NAME "${name}${PYTHON_EXTENSION_SOABI}")
-    target_link_libraries(${name} ${PYTHON_LIBRARY})
+    target_link_libraries(${name} python)
     IF(${CMAKE_SYSTEM_NAME} STREQUAL "Windows")
         set_target_properties(${name} PROPERTIES SUFFIX ".pyd")
     ENDIF()

Results in the error:
~/git-repos/symengine.py$ python setup.py install build --symengine-dir=~
~/anaconda3/lib/python3.4/site-packages/setuptools-18.4-py3.4.egg/setuptools/dist.py:285: UserWarning: Normalizing '0.1.0.dev' to '0.1.0.dev0'
running install
running build
SymEngine_DIR : ~/lib/cmake/symengine
CMake Error: Error in cmake code at
~/git-repos/symengine.py/cmake/FindPython.cmake:47:
Parse error.  Expected a command name, got unquoted argument with text "+add_library".
CMake Error at CMakeLists.txt:14 (find_package):
  find_package Error reading CMake code from
  "~/git-repos/symengine.py/cmake/FindPython.cmake".

-- Found CYTHON: cython
CMAKE_BUILD_TYPE : Release
CMAKE_CXX_FLAGS_RELEASE : -std=c++11 -Wall -Wextra -fPIC -O3 -march=native -ffast-math -funroll-loops -Wno-unused-parameter -D__extern_always_inline=inline
CMAKE_CXX_FLAGS_DEBUG : -std=c++11 -Wall -Wextra -fPIC -g -Wno-unused-parameter -ggdb
HAVE_SYMENGINE_MPFR : False
HAVE_SYMENGINE_MPC : False
Copying source of python wrappers into: ~/git-repos/symengine.py
CMake Error at symengine/lib/CMakeLists.txt:10 (add_python_library):
  Unknown CMake command "add_python_library".

-- Configuring incomplete, errors occurred!
See also "~/git-repos/symengine.py/CMakeFiles/CMakeOutput.log".
error: error calling cmake

Nevermind, turns out I'd accidentally copied the "+" from your patch. This does not fix the original problem, however.

Thanks @woodscn for the bug report. How is it possible that our tests pass on a Mac, e.g. here: https://travis-ci.org/symengine/symengine.py/jobs/90321358? We need to improve our testing to test for the bug that you found.

The whole process ends up being a bit hackish; it's entirely possible that I'm messing something up on my end. I'm also working with an Anaconda installation, in my user directory, and I'm running python 3.4 rather than 2.7. Lots of possibilities there.
Here's my process, FWIW, running cmake version 3.3.2 and python 3.4.
git clone both symengine and symengine.py
git checkout specific commit in symegine
cmake -D<set install path to be ~, which has bin, lib, and include directories available> .
This throws errors, but running cmake again finishes cleanly. No idea why.
make install
cd to symengine.py
python setup.py install build --symengine-dir=<~>
Again, cmake throws errors the first time, but the second time finishes.
Testing results in the error:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/woodscn/anaconda3/lib/python3.4/site-packages/symengine/__init__.py", line 1, in <module>
    from .lib.symengine_wrapper import (Symbol, Integer, sympify, SympifyError,
ImportError: dlopen(/home/woodscn/anaconda3/lib/python3.4/site-packages/symengine/lib/symengine_wrapper.cpython-34m.so, 2): Library not loaded: libpython3.4m.dylib
  Referenced from: /home/woodscn/anaconda3/lib/python3.4/site-packages/symengine/lib/symengine_wrapper.cpython-34m.so
  Reason: image not found

This can be fixed following the procedure I linked to, or by symlinking libpython, but those are just temporary workarounds, and will break things if/when you change conda environments.

Can you post your cmake log where it throws the error? You can use gist.github.com to post it. It should not throw any errors and it should just work with your cmake and Python 3.4 versions.

Sure thing. While I figure out how to do that, here's a sample piece of output.
CMake Error: Error in cmake code at
/home/woodscn/Downloads/cmake-3.3.2-Darwin-x86_64/CMake.app/Contents/share/cmake-3.3/Modules/Compiler/._Borland-DetermineCompiler.cmake:1:
Parse error.  Expected a command name, got unquoted argument with text "".
CMake Error at /home/woodscn/Downloads/cmake-3.3.2-Darwin-x86_64/CMake.app/Contents/share/cmake-3.3/Modules/CMakeCompilerIdDetection.cmake:16 (include):
  include could not find load file:

    /home/woodscn/Downloads/cmake-3.3.2-Darwin-x86_64/CMake.app/Contents/share/cmake-3.3/Modules/Compiler/._Borland-DetermineCompiler.cmake
Call Stack (most recent call first):
  /home/woodscn/Downloads/cmake-3.3.2-Darwin-x86_64/CMake.app/Contents/share/cmake-3.3/Modules/CMakeCompilerIdDetection.cmake:44 (_readFile)
  /home/woodscn/Downloads/cmake-3.3.2-Darwin-x86_64/CMake.app/Contents/share/cmake-3.3/Modules/CMakeDetermineCompilerId.cmake:108 (compiler_id_detection)
  /home/woodscn/Downloads/cmake-3.3.2-Darwin-x86_64/CMake.app/Contents/share/cmake-3.3/Modules/CMakeDetermineCompilerId.cmake:126 (CMAKE_DETERMINE_COMPILER_ID_WRITE)
  /home/woodscn/Downloads/cmake-3.3.2-Darwin-x86_64/CMake.app/Contents/share/cmake-3.3/Modules/CMakeDetermineCompilerId.cmake:39 (CMAKE_DETERMINE_COMPILER_ID_BUILD)
  /home/woodscn/Downloads/cmake-3.3.2-Darwin-x86_64/CMake.app/Contents/share/cmake-3.3/Modules/CMakeDetermineCXXCompiler.cmake:104 (CMAKE_DETERMINE_COMPILER_ID)
  CMakeLists.txt:2 (project)

gist here: https://gist.github.com/woodscn/386a66d2faf75dbbd41f

CMake error seems to be a bug in CMake.
Can you post ~/git-repos/symengine.py/symengine/lib/CMakeFiles/symengine_wrapper.dir/link.txt and ~/git-repos/symengine.py/symengine/lib/CMakeFiles/symengine_wrapper.dir/flags.make ?
Also what does your environment variables CC and CXX point to?

link.txt:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -std=c++11 -Wall -Wextra -fPIC -O3 -march=native -ffast-math -funroll-loops -Wno-unused-parameter -D__extern_always_inline=inline -bundle -Wl,-headerpad_max_install_names -flat_namespace -undefined suppress -o symengine_wrapper.cpython-34m.so CMakeFiles/symengine_wrapper.dir/symengine_wrapper.cpp.o /home/woodscn/anaconda3/lib/libpython3.4m.dylib /home/woodscn/lib/libsymengine.a /home/woodscn/lib/libteuchos.a /home/woodscn/lib/libgmpxx.dylib /home/woodscn/lib/libgmp.dylib

flags.make:
# CMAKE generated file: DO NOT EDIT!
# Generated by "Unix Makefiles" Generator, CMake Version 3.3

# compile CXX with /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
CXX_FLAGS = -std=c++11 -Wall -Wextra -fPIC -O3 -march=native -ffast-math -funroll-loops -Wno-unused-parameter -D__extern_always_inline=inline -fPIC -I/home/woodscn/git-repos/symengine.py/symengine/lib -I/home/woodscn/lib/cmake/symengine/../../../include -I/home/woodscn/include -I/home/woodscn/anaconda3/include/python3.4m

CXX_DEFINES = -Dsymengine_wrapper_EXPORTS

# Custom flags: symengine/lib/CMakeFiles/symengine_wrapper.dir/symengine_wrapper.cpp.o_FLAGS = -fno-strict-aliasing -Wno-unused-function -Wno-constant-logical-operand

CC and CXX aren't set to anything in particular. I think that means they're using the defaults:
cc --version
Apple LLVM version 7.0.0 (clang-700.1.76)
Target: x86_64-apple-darwin14.5.0
Thread model: posix

Thanks for the info.
The following mail thread describes the problem, https://groups.google.com/a/continuum.io/forum/#!topic/anaconda/fUpqjkK5jEI
We should either,

Provide conda build script in the repo itself.
Use rpath for symengine.py as we want the relative path between symengine_wrapper.so and libpython3.4m.dylib to be fixed.

Or both.
@certik, regarding the test issue, we didn't see this because although we used Miniconda for python, there must have been a system python that was linked to symengine_wrapper.so at runtime.

I thought that we already used 2., since cmake uses rpath. We should start with 2., how do we fix it?
We should also finish https://github.com/conda/conda-recipes/pull/145, but that's a separate issue.
Ondrej

CMake does use rpath, but only absolute rpaths I think. So we should use for example, $ORIGIN based (for Linux) rpath or @loader_path based (for OS X) for the linked python library.

Doing relative rpath with cmake like that is tricky I think. It's better to be left to the package manager.
Why do absolute rpaths not work?

My understanding is that it's ambiguous to link to a specific Python, since conda environments may change which one is being called regularly. However, linking directly with whichever Python was used to build the package would be okay.

That's exactly right. I thought we already link to the Python version with absolute paths. Either way, that should work and that's what we need to support.
In order to get better integration with Conda, one needs to finnish the https://github.com/conda/conda-recipes/pull/145 PR, which is a separate/orthogonal issue.


feat: Cloudflare Workers AI EF

Refs: #61

#63  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on  Graphite


Not working on HA 2024.10.1

Hello.
Since i updated to HA 2024.10.1 (currently on 2024.10.3)  this integration does not work anymore. I get this when i do "Check configuration":

Platform error 'binary_sensor' from integration 'rpi_gpio' - No module named 'RPi._GPIO'

Is there a fix for this?
What information is needed to help resolve the issue?
Thanks in advance.

It's the same for me... Is there any solution?

You probably updated the OS together, see https://github.com/thecode/ha-rpi_gpio/issues/255
The library is not supported anymore by newer kernels, there is WIP to switch to a newer library, I don't have a timeline.

Yes, I have upgraded to BookWorm... Prior to that, simply updating HA (without updating to BookWorm) did not lead to such results...
It remains to wait for you to figure it out.: https://github.com/thecode/ha-rpi_gpio/discussions/285 ?

You probably updated the OS together, see #255 The library is not supported anymore by newer kernels, there is WIP to switch to a newer library, I don't have a timeline.

In my case, I'm using Home Assistant on docker container, so i don't think it is OS related... The issue appeared after upgrading the HA container to 2024.10.1.
On different device I have HA container still on 2024.9.3 and the integration works fine...

In my case, I'm using Home Assistant on docker container, so i don't think it is OS related... The issue appeared after upgrading the HA container to 2024.10.1.

In my case, I use HA Supervised. As far as I understand, it is also installed in a container... I upgraded to BookWorm after the supervisor started "swearing" at the outdated version... And after that, the integration stopped working...
In addition, there is such information: https://github.com/thecode/ha-rpi_gpio/discussions/284#discussioncomment-11010333

Fixed in https://github.com/thecode/ha-rpi_gpio/releases/tag/2024.10.0


Launching PyPy interpreter crashes Visual Studio

I am using Visual Studio 2015 CTP with PTVS 2.2 Beta, PyPy3 2.4.
Going to Python Environments and calling the pypy interpreter crashes VS.

The debugger doesn't work with pypy as well, but I think it's connected to this issue.

When you say "calling the PyPy interpreter" what are you clicking on to do that? Can you walk me through step by step what you're doing so I can try it on my own machine?

I'm clicking this: http://i.imgur.com/djrXRdo.png and instantly getting this: http://i.imgur.com/Ser50di.png
I will be happy to provide any additional information and send you the logs if you tell me what information you need and where I can find the logs.

My setup:

Windows 10 TP 10061
VS 2015 CTP
PTVS 2.2 Beta
PyPy3 2.4.0 (32 bit)
The projects involved are (probably unnecessary, but I'll list them just in case):

https://bitbucket.org/moigagoo/sloth-ci
https://bitbucket.org/moigagoo/sloth-ci-extensions
https://bitbucket.org/moigagoo/sloth-ci-validators

I think that may be fixed in a later version of PTVS, as I'm not seeing that issue now. We have a newer release back at CodePlex that probably fixes this.
The debugger not working is more of a concern, though we have also made some improvements to that in the release I linked, so it may already be fixed. Can you try that dev build and let us know?

I've installed the new version. The issue persists.
The debugger doesn't close instantly now though, but rather an error is shown: http://i.imgur.com/Fcfeghr.png Which is progress, I think :-)

Just noticed that calling a regular Python interpreter crashes VS as well, at least with the new PTVS version.

Ah, okay, that's the stackless issue. We've got details about how to fix it (they've changed their API at some point), but haven't gotten there yet. The original support was contributed - we don't actually have anyone on the team who's familiar enough with stackless to just get it right.
As for the crash, can you put the text from Tools - Python Tools - Diagnostic Info into a gist or email it to<EMAIL_ADDRESS>There should be details about the crash in there.

Here you go https://gist.github.com/moigagoo/f50c230459d8fcff45d1
I've reported the stackless issue as a separate .

Thanks for the separate issue. Unfortunately, there isn't enough information in the log to figure out what the problem is - a Win32Exception basically means that the cause is not obvious and probably means you have some sort of local corruption (as opposed to a coding error).
If you add a custom environment and set the interpreter path to Notepad, does the problem still occur? There may be some sort of policy restriction configured on launching programs.


Safety Manual Page

As a precautionary measure, the home page can have regular pop ups of random safety tips for women to be followed on road, public places, homes etc. and a separate page for safety tips as well as a self-defense manual for emergencies could make this website more useful and handy. I would like to work on this issue if it is approved.

As a precautionary measure, the home page can have regular pop ups of random safety tips for women to be followed on road, public places, homes etc. and a separate page for safety tips as well as a self-defense manual for emergencies could make this website more useful and handy. I would like to work on this issue if it is approved.

Work on safety manual page only.

@anushka1309paul Any updates ?

Sir,
I had been unable to complete the same due to my ongoing examinations, but
I will finish the same at the earliest.
Thanks and Regards,
Anushka Paul
On Thu, Apr 8, 2021 at 11:53 PM Swapnil Srivastava @.***>
wrote:

@anushka1309paul https://github.com/anushka1309paul Any updates ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/swapnilsparsh/Rescue/issues/230#issuecomment-816040391,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANPN7TTYL2Q4Z3KAGSX3BNDTHXYDPANCNFSM42IM4LAA
.


Add Model docs release version change to README

Documents changes from #1346 in the Docs repo README

Rendered on https://github.com/hflynn/ome-documentation/tree/readme-release-number for review


Change of model

Hi, is it possible to change the structure of model instead of using the model provided in the library

Yes, one way is instead of using "pip install", clone the repository and make desired changes.


maintainers: update euank email

Per the title.

LGTM. This also made me realize that list is horribly outdated, I'll run a cleanup on it.


Idea: Addable, Editable, Deletable

You're on a roll, so I thought I throw this out there.
For Addable, I am envisioning a button in the bar that would show when protected bool $addable = true;. This button would show a modal that contains fields for all the Columns and would have Add and Cancel buttons.
For Editable, I'm thinking having protected bool $editable = true; show an edit icon in an actions column that would make each of the columns change into fields and the edit icon would change into a save button. Alternatively, it could show a modal like Addable.
For Deletable, it'd simply have protected bool $deleteable = true; show a trash icon in the actions column that would have a confirmation before deleting the row.
I am thinking about working on this myself, but you've been so quick and elegant with the updates, I'd hate to waste time building it differently than you'd do it. :-)

Hi @KenKodz,
Thanks for sharing your thoughts!
Although I like your idea, I'm afraid it's a bit outside of the scope of this package. I'm mainly focused on the table itself and making it as easy as possible to interact with. Actions can be implemented to alter data by the user, but updating or deleting records directly within the package is something I'm currently not planning to add. Having a "crud" on top of the table would introduce quite some complexity. Of course, feel free to implement these functionalities by yourself. Any custom settings you may need in your columns can be passed via metadata.
Hope you understand!


Add Ctrl-C handling to the REPL

I noticed that you can't stop execution with a SIGINT when working interactively at the REPL (it does seem to work for loaded files) so I went ahead and tried adding it. Would be glad to know if there is a less invasive way of doing this!

I believe this would also need some Windows-specific code as SIGINT isn't supported on Windows.

I went ahead and reimplemented the functionality using the interrupt handler scheme as suggested by @zeux. Let me know how this looks 😃 I had to add a couple things to lapi due to a circular import problem I didn't quite understand...not sure if that was the correct approach.
Haven't yet had a chance to look into reproducing this for Windows; maybe tomorrow evening!

This still has core changes that are not necessary:

Interrupt handler should raise an error if SIGINT was raised; the error will be caught at the top level. The global sigint flag needs to be reset at the top level to correctly break out of pcall.

The most recent commit raises an error with luaL_error. I didn't understand the latter concern about resetting the sigint flag to break out of pcall, but it seems like it may not be relevant with the switch to lazy interrupt setting that I also rolled into the most recent commit.

LUA_SIGINT status is not necessary, and neither is lua_setstatus (the latter is dangerous as it can put the thread into an inconsistent state depending on how it's used).

I've addressed both of these concerns.

Setting interrupt handler can be done via lua_callbacks

I removed my custom interrupt handler setter and use lua_callbacks in the most recent commit.

Additionally, the preferred mode of operation for interrupt handlers is to set them lazily (this can be done on any thread / signal), in this case instead of the flag what should probably happen is that the signal handler should set the interrupt callback that errors unconditionally, and the top-level should clear the interrupt handler after handling the error.

This is also addressed in the most recent commit, although I had to keep track of a global lua_State for the repl because I'm not able to pass any context beyond the signal value to the signal handler. I'm not certain this is the best way to do this.

Sorry this got stuck a little bit, I think this looks good now modulo some style issues, I'll clean this up a little and merge it next week.

Sounds good, @zeux. Thanks! :)


rewrite

form changes

use smart formspecs mod? ( https://forum.minetest.net/viewtopic.php?id=7553 )
change the codes to use 2/23 format not binstring internally (form could still have a converter for the NKS code system, and the form should actually have a series of fields for each rule)
destructive toggle (grow into other nodes, dirt, water, plants, stone?)
use textlists for plane, growth, etc
option for unlimited ttl (-1 or 0?)
icons for node types (trail, final)
select box with library of Game of Life entities that can be loaded to current position? (orientation, options form)
noise?
growth rate (globalstep timer interval?)

triggering of multiple nodes,

move formspec out of the metadata (probably at least need a table of settings with hash -- maybe the hash could just be the serialized settings table?), handle forms with player_on_receive_fields instead and somehow pass them multiple nodes in question (possibly to all inactive automata blocks -- would solve multiple triggering too) punching with the programmable node block could open the form like the compassgps mod does. then all inactive nodes will be activated with the form settings!

changes to abm, nodelist, voxelmanip

option 1: use abm to generate a list of each C.A. block and derive an extent for VoxelArea? (still uses only loaded nodes)
option 2: use an exhaustive list of nodes kept in-mod? (stop using abm?) could use technic.get_or_load_node() to force-load non-loaded nodes, or possibly do a check with plants_lib.is_node_loaded, to eliminate the growths that include ONLY non-loaded nodes. could have a field in the form to force the activation to ignore loadedness... apparently these are just wrappers for minetest.get_node_or_nil(pos)

--from technic
-- if the node is loaded, returns it. If it isn't loaded, load it and return nil.
function technic.get_or_load_node(pos)
	local node_or_nil = minetest.get_node_or_nil(pos)
	if node_or_nil then return node_or_nil end
	local vm = VoxelManip()
	local MinEdge, MaxEdge = vm:read_from_map(pos, pos)
	return nil
end

can voxelmanip be used to count neighbors faster? might need to start counting processing times for various operations to compare strategies

new features

1D automata
3D automata
moore vs von neumann neighborhoods (in 3D as well)
neighborhood depths (in 1D and 3D as well)
specific neighbor rules  (in 1D and 3D as well)
an anti-cell for 0 neighbor inactive rules
loading and saving of Game of Life entities (without worldedit?) see Form updates above

the idea here is that only people interested in cellular automata will care about this mod, so those people will want a mod that handles the deterministic nature of C.A. and will not want the patterns disfigured by the player's movement, so will not mind the "bad design" implementation of having non-loaded nodes grow. This may cause lag, but the gain from moving away from a) heavy use of metadata, b) not using AdvancedBlockModifiers at all or hardly, and c) using VoxelManipulator should offset these concerns anyway.
Further approaches to limit lag will be: the TTL setting to limit growth, not growing patterns that are entirely made up of non-loaded nodes, identifying patterns that are in a steady state (such as "still life" entities in Game of Life that are their own "parent" -- when other cells come near these have to come back to life for interaction though), possibly dividing the growth rate (the globalstep timer interval) by the total cell count for each pattern, etc

considering adding a "chance" into the globalstep that is proportional to the number of cells in the pattern.
also considering to set a limit to the number of cells...
also considering setting a limit to the profile for certain patterns' growth cycle. if the processing time takes longer than X then the pattern must terminate.


Getting Started Page: Trailhead Link is Broken

The "Learn with Trailhead" Tile includes a link to an NPSP Trailmix:
https://trailhead.salesforce.com/users/00550000006yYDZAA2/trailmixes/npsp?
Internal request to change to :
https://trailhead.salesforce.com/en/content/learn/modules/nonprofit-cloud-basics
More details on Work Item.

**lurch: add

Tracking W-032418

Included in beta release 3.154 (Beta 4)

Included in production release 3.154


can not call store procedure in mysql

error message is: Not found table
this bug was introduced by the code change of last 2-3 days

Could you paste your example code here?

In my side, all query using a store procedure met the issue, below is an example (it is fine under tag v0.5.4, but encounter the issue with latest code)
GetDatabase().Sql("call p_template_heat(?, ?)", buf.String(), arg.Count).Find(&result)


Immediate effect max notifications

With regards of #40 , I played around a bit with the source code and found a possible solution for the problem.
Basically I made sure that state.notifications can't hold more notification than the value of props.maxNotifications.
Let me know if this is good enough for merge, or if there is anything else left to be added here.

Hey! thank you for the PR, I tested it and it works great. Can you fix the conflicts before merging it?

Hi! Thanks! It should be good to go now.


Latest release CSS files are blank

If you go to the readme of this repo an download the latest release the css files, foundation.css and foundation.min.css are empty. If you download the .zip from the website the files are fine. Thanks!

We updated the readme link https://github.com/zurb/foundation/commit/453e120daa5f7a3da5961717283ee788a893d386


Use the exact same package version in package.json and package-lock.json

For CI build (npm ci), versions define in package-lock.json must match those in package.json. Currently @types/node doesn't. This PR fixes that.

Wrong repo.


Material UI is incompatible with Gatsby v3 incremental builds due to browserlist using fs

Referenced in this gatsby-plugin-material-ui issue, SSR in Gatsby v3 is disabled when using Material UI for some people due to browserlist accessing the file system via fs.
I know this isn't technically a bug, but an alternate method of prefixing could solve the problem.  The only option to make it work is by disabling prefixing.

It doesn't look like this bug report has enough info for one of us to reproduce it.
Please provide a CodeSandbox (https://material-ui.com/r/issue-template-next), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

Hey @eps1lon ,
I think I've narrowed down where the issue is coming from, but I don't know the exact reason.
It seems to be coming from Mui's accordion component (Finally got the error to disappear after removing the only accordion component in the full site).  Here's a minimal reproduction.
Directions
yarn build
Error
You should see the error:
warn Unsafe builtin method was used, future builds will need to rebuild all pages
warn WebpackError: Unsafe builtin usage fs.existsSync:
    at material-ui-gatsby-ssr-problem/node_modules/browserslist/node.js:38:1
    at material-ui-gatsby-ssr-problem/node_modules/browserslist/node.js:202:1
    at material-ui-gatsby-ssr-problem/node_modules/browserslist/node.js:49:1
    at material-ui-gatsby-ssr-problem/node_modules/browserslist/node.js:200:1
    at material-ui-gatsby-ssr-problem/node_modules/browserslist/index.js:433:1
    at material-ui-gatsby-ssr-problem/node_modules/autoprefixer/lib/browsers.js:54:1
    at material-ui-gatsby-ssr-problem/node_modules/autoprefixer/lib/browsers.js:42:1
    at material-ui-gatsby-ssr-problem/node_modules/autoprefixer/lib/supports.js:41:1
    at material-ui-gatsby-ssr-problem/node_modules/autoprefixer/lib/supports.js:86:1
    at material-ui-gatsby-ssr-problem/node_modules/autoprefixer/lib/supports.js:247:1
    at material-ui-gatsby-ssr-problem/node_modules/autoprefixer/lib/supports.js:245:1
    at material-ui-gatsby-ssr-problem/node_modules/autoprefixer/lib/supports.js:270:1
    at material-ui-gatsby-ssr-problem/node_modules/autoprefixer/lib/processor.js:67:1
    at material-ui-gatsby-ssr-problem/node_modules/postcss/lib/container.js:119:1
    at material-ui-gatsby-ssr-problem/node_modules/postcss/lib/container.js:55:1

  36 |     return filenessCache[file]
  37 |   }
> 38 |   var result = fs.existsSync(file) && fs.statSync(file).isFile()
     | ^
  39 |   if (!process.env.BROWSERSLIST_DISABLE_CACHE) {
  40 |     filenessCache[file] = result
  41 |   }

It seems to be coming from Mui's accordion component

The error is pointing to postcss and autoprefixer. These are not packages we're responsible for.


Remove universal jquery reference

GTM tags and variables used across the site have had jquery references removed, so this removes it from the base template.
Removals

Remove universal jquery references.

Testing

./frontend.sh and check the site over. Outside apps (OAH, KBYO) should handle jquery themselves, if I understand correctly.

cc @kelleyholden

I have a task to add sortable tables to Wagtail, but the installed version of Capital Framework requires jQuery. Does the Platform team have a recommendation how to move forward now that jQuery is being removed from the project?

@jimmynotjim ooh, we were making this change with the understand that there were no cfgov-refresh dependencies on jQuery. This is still the case, right - what you're talking about is adding a feature from  Capital Framework to cfgov-refresh that is dependent on jQuery, correct?
I would recommend it be refactored to use vanilla JS and we make sure that future Capital Framework features are not dependent on jQuery, as a it's a major priority for us to remove jQuery from the cfgov-refresh pages. It's a pretty big performance hit right now and removing it will save us ~90kb in page weight on Wagtail pages.

There are some references that I added when doing OAH pop stuff. I'll push to this branch and remove them.

what you're talking about is adding a feature from Capital Framework to cfgov-refresh that is dependent on jQuery, correct?

Not exactly. Sortable Tables have been in Capital Framework for a while, similar to Expandables, and I thought they were in use, just not within the Wagtail interface. Removing jQuery entirely may break them where they are used (unless it's one of the places we're leaving it, I'm not even sure where they are in use).

I would recommend it be refactored to use vanilla JS and we make sure that future Capital Framework features are not dependent on jQuery

The latest version of Capital Framework did remove the jQuery requirement, and both JS dependent components use @sebworks Atomic Component code. I know we're in the middle of making that move, but I don't know what to do about Sortable Tables in the mean time. Guess I'm looking for some guidance here from the team before moving forward.

FOLLOW UP:
Looks like Sortable Tables have been in CF since late 2015, maybe @mistergone knows where they are currently used.

@jimmynotjim, so the best solution for now is just to use the sortable table shell and modify it where appropriate to fit into cfgov-refresh.  I think we are already poly-filling for class list so you would just need to setup the events.

@jimmynotjim or deliver jquery with sortable tables. We just want to remove the universal jquery install, but individual dependencies could install jquery themselves, if they need it.

i don't mind that for external modules but we shouldn't encourage CFPB modules to create backdoor ways for using jQuery. Otherwise, what is the point of removing it from our repo?

True 👍

Sounds like back-porting the latest cf-tables code into this repo is the way to go for my task.
As far as existing uses, I can't find any references to Sortable Tables in this repo. Unless someone speaks up 👍  from me on 🔥  jQuery.

I'm getting jQuery errors from the GTM code on pages with a youtube player.

Should be gone now. Updated tags are now published according to @kelleyholden.


Connect wallet modal + copy changes on modal

[ ] Connect wallet modal + copy changes on modal

I think this is redundant with #265 -- can we delete this?

yep


Replace auth endpoints with new graphql endpoint and mutations

We decided to move our only non-gql endpoints to gql as well and prepared structure for it on API already. (url if you want to test API in Altair: https://stage.devvapi.com/candidates/v1/auth/graphql)
Now we will replace them on the frontend. I will not remove old components and services right away, leaving them for around a month.
After implementation we plan to test it for a few days on the development version before propagating to the production.

Deployed to https://devv.jobs.


problem with redirect

Hi,
when trying to run the "stupid" example, I encounter the following problem. It was working before. Is it related with a change on the ietf.org website? Does it have to be reflected somewhere in the code of kramdown-rfc2629?
ruby -I ../lib/ ../bin/kramdown-rfc2629 stupid.mkd stupid.xml
.refcache/reference.RFC.2119.xml: fetching
/usr/lib/ruby/2.3.0/open-uri.rb:225:in `open_loop': redirection forbidden: http://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.2119.xml -> https://xml2rfc.tools.ietf.org/public/rfc/bibxml/reference.RFC.2119.xml (RuntimeError)
        from /usr/lib/ruby/2.3.0/open-uri.rb:151:in `open_uri'
        from /usr/lib/ruby/2.3.0/open-uri.rb:717:in `open'
        from /usr/lib/ruby/2.3.0/open-uri.rb:35:in `open'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:436:in `block in get_and_cache_resource'
        from /usr/lib/ruby/2.3.0/timeout.rb:91:in `block in timeout'
        from /usr/lib/ruby/2.3.0/timeout.rb:33:in `block in catch'
        from /usr/lib/ruby/2.3.0/timeout.rb:33:in `catch'
        from /usr/lib/ruby/2.3.0/timeout.rb:33:in `catch'
        from /usr/lib/ruby/2.3.0/timeout.rb:106:in `timeout'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:435:in `get_and_cache_resource'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:487:in `block in convert_img'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:482:in `scan'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:482:in `convert_img'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:125:in `block in inner_a'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:123:in `map'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:123:in `inner_a'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:130:in `inner'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:143:in `convert_p'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:125:in `block in inner_a'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:123:in `map'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:123:in `inner_a'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:130:in `inner'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:615:in `convert_root'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:118:in `convert1'
        from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:113:in `convert'
        from /usr/lib/ruby/vendor_ruby/kramdown/converter/base.rb:105:in `convert'
        from /usr/lib/ruby/vendor_ruby/kramdown/document.rb:120:in `method_missing'
        from ../bin/kramdown-rfc2629:341:in `<main>'

It may be related to the following mail on the xml2rfc mailing list about a browser problem similar to the error message:
https://mailarchive.ietf.org/arch/msg/xml2rfc/PEL8ZkS6uYaTG0ZhoSMYqV6cbIU

Hi Cédric,
Indeed, there is discussion today on the tools mailing list about a redirection problem, exacerbated by a certificate problem. I have to think about ways of making kramdown-rfc more robust to this kind of situation.
Grüße, Carsten

This appears to be a bug in the open-uri library, though.
Workaround at the moment:
XML_RESOURCE_ORG_PREFIX=https://xml2rfc.tools.ietf.org/public/rfc
kramdown-rfc2629
(i.e., set the environment variable XML_RESOURCE_ORG_PREFIX to the value
https://xml2rfc.tools.ietf.org/public/rfc before calling kramdown-rfc2629)
Grüße, Carsten
Carsten Bormann wrote:

Hi Cédric,
Indeed, there is discussion today on the tools mailing list about a
redirection problem, exacerbated by a certificate problem. I have to
think about ways of making kramdown-rfc more robust to this kind of
situation.
Grüße, Carsten
On 28 Aug 2016 12:10, Cédric Boutillier wrote:

Hi,
when trying to run the "stupid" example, I encounter the following
problem. It was working before. Is it related with a change on the
ietf.org website? Does it have to be reflected somewhere in the code
of kramdown-rfc2629?
|ruby -I ../lib/ ../bin/kramdown-rfc2629 stupid.mkd stupid.xml
.refcache/reference.RFC.2119.xml: fetching
/usr/lib/ruby/2.3.0/open-uri.rb:225:in open_loop': redirection forbidden: http://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.2119.xml -> https://xml2rfc.tools.ietf.org/public/rfc/bibxml/reference.RFC.2119.xml (RuntimeError)         from /usr/lib/ruby/2.3.0/open-uri.rb:151:in open_uri'
from /usr/lib/ruby/2.3.0/open-uri.rb:717:in open'         from /usr/lib/ruby/2.3.0/open-uri.rb:35:in open'
from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:436:in block in get_and_cache_resource'         from /usr/lib/ruby/2.3.0/timeout.rb:91:in block in timeout'
from /usr/lib/ruby/2.3.0/timeout.rb:33:in block in catch'         from /usr/lib/ruby/2.3.0/timeout.rb:33:in catch'
from /usr/lib/ruby/2.3.0/timeout.rb:33:in catch'         from /usr/lib/ruby/2.3.0/timeout.rb:106:in timeout'
from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:435:in get_and_cache_resource'         from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:487:in block in convert_img'
from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:482:in scan'         from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:482:in convert_img'
from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:125:in block in inner_a'         from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:123:in map'
from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:123:in inner_a'         from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:130:in inner'
from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:143:in convert_p'         from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:125:in block in inner_a'
from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:123:in map'         from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:123:in inner_a'
from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:130:in inner'         from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:615:in convert_root'
from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:118:in convert1'         from /home/boutil/src/ruby/kramdown-rfc2629/lib/kramdown-rfc2629.rb:113:in convert'
from /usr/lib/ruby/vendor_ruby/kramdown/converter/base.rb:105:in convert'         from /usr/lib/ruby/vendor_ruby/kramdown/document.rb:120:in method_missing'
from ../bin/kramdown-rfc2629:341:in `'
|
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cabo/kramdown-rfc2629/issues/27, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AABaTms-WhnR8o-4KS1JlzN0PJsoUdT-ks5qkV6ZgaJpZM4Ju5Bk.

I pushed a 1.0.34 with a workaround installed.  Please update:
gem update

Leaving this open, as the workaround still needs to be moved to the proper stable base URI.

I can confirm that gem update to kramdown-rfc2629-1.0.34.gem fixes the bug for me.

I tried 1.0.36, and the problem is fixed for me too. Thanks!

Heya, after updating to a newer kramdown-rfc2629 I get a message "Occasionally run certified-update" but I had to hunt around to figure out that was the executable provided by the following gem: https://github.com/stevegraham/certified
Would be good to make that a bit easier to figure out.


Cannot connect to redshift

What language are you using?
Python
What version are you using?
3.9
What database are you using?
Redshift
What dataframe are you using?
Pandas
Can you describe your bug?
Cannot connect to redshift
What are the steps to reproduce the behavior?
#%%
import connectorx as cx
db = ""postgresql://username:password@server:port/database""
query = "SELECT * FROM order_details LIMIT 10"
try:
result = cx.read_sql(db, query)
print(result)
except Exception as e:
print(f"Error: {e}")
Database setup if the error only happens on specific data or data type
Table schema and example data
Example query / code
your
code
goes
here

What is the error?
Error: db error: ERROR: syntax error at or near "("

Hi @kar-man , please replace postgresql:// with redshift:// in your url

Thank you. It works


Future plans after Noise Update

You have said that your interest in Pizza Tower has dropped recently, and that you don't have as much free time as you used to. Considering that, do you plan on dropping the port after this, passing it on to someone else, or anything else? I'm just curious to know if you have any ideas for what lies in the future for this port. Thank you in advance for your answer.

After I'll release the update I think I'll only do any bugfix updates whenever any bugs come up here.
As for passing the port's source code to someone else: The biggest obstacle to creating a port is FMOD, and I have already open sourced my GML replacement of it, and will open source my rewrite as well once the update is out. If anyone wants to do a port for later versions of the game this would help them immensely. But my port specifically will remain on life support for the foreseeable future, after the update.


Travis cannot run integration tests

According to https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions, Pull requests sent from forked repositories do not have access to encrypted variables or data.That makes running the integration tests fail during a PR from a forked repository.

Using semaphore CI meanwhile. Closing


Implement Liquid::Drop.

This still a draft.
All public methods with no arguments from a Drop is exported. I implemented a small stack machine to be able to process the expressions given to the Context, but it still missing some things:

The ! and - prefixes aren't implemented yet
I'm not 100% sure of the .blank? and .missing? semantics.
I need to review the code too, since I believe it can be even simpler.

Besides two tests about ! and - prefix, these are the tests that still failing.
  1) Liquid Liquid::Context returns nil for missing key in strict mode with ?
     Failure/Error: ctx.get("missing?").should be_nil

       Expected: false to be nil

     # spec/liquid_spec.cr:55

  2) Liquid::Template should support array access via literal
     Failure/Error: tpl.render(ctx).should eq "second, first, third, third"

       Expected: "second, first, third, third"
            got: "second, first, , third"

     # spec/template_spec.cr:238

  3) Liquid::Template should support #blank?
     Failure/Error: tpl.render(ctx).should eq "blank"

       Expected: "blank"
            got: ""

     # spec/template_spec.cr:290

  4) Liquid::Template should support combinations of array/hash access and property access
     Failure/Error: tpl.render(ctx).should eq "3 2 second-b val val val"

       Expected: "3 2 second-b val val val"
            got: "3 2 second-b  val val"

     # spec/template_spec.cr:332

Most, if not all, are about how the built in methods .size, '.blank, present` must behave.
Any early feedback are appreciated.
Fix #36

Now there's just 2 tests failing:
  1) Liquid Liquid::Context returns nil for missing key in strict mode with ?
     Failure/Error: ctx.get("missing?").should be_nil

       Expected: nil to be nil

     # spec/liquid_spec.cr:55

  2) Liquid::Template should support #blank?
     Failure/Error: tpl.render(ctx).should eq "blank"

       Expected: "blank"
            got: ""

     # spec/template_spec.cr:290

To pass on other tests, the current code is evaluating the variables not found to nil when they have a ? suffix instead or raise an error. IMO they should raise an error or evaluate to nil depending on strict mode.
Second tests tests if {% if var.blank? %}blank{% endif %} renders blank when there's no variable set in the context
According to https://jumpseller.com/support/liquid-sandbox/ both tests are about invalid expressions that uses variables that not exist in the context and must raise an error on strict mode or evaluate to nil in non-strict mode.

oops, removed the branch by mistake.
BTW I noticed that these .blank? and .present? are liquid.cr extensions to liquid language, they do not exist in any liquid implementation I saw so far.
I have no idea about how many people are using this project and how it would deal with breaking changes... probably not much.
So, I'll update the PR to match behavior of https://shopify.github.io/liquid/, since my needs are for ruby compatibility at first, then the community decides what to do with the code.

Closing this in favor of https://github.com/amberframework/liquid.cr/pull/69


Turshi instruction logic

This PR provides a functioning version of the Cairo instruction logics gate constraints. It still doesn't have the wiring between I/O registers and public input, but it should be easily addable. This PR does not contain the memory logics, which has been moved to a different PR for readability and ease of review. In particular, some parts of the memory logics are subject to changes for lookup tables, so that part is less stable. It needs about 4 rows per Cairo instruction in a 15-wire kimchi. The delta between this PR and the one for the Cairo runner are the following:

Added one field to CairoProgram that gives the list of instructions of the execution.
turshi.rs: includes

4 Cairo gates definitions;
a witness generator from an execution of the runner;
a gadget generation from a witness,
constraints for the operands, operations, registers, instruction checks, registers updates
a checking function that replicates the constraints expressions in field format
a verification function that evaluates the constraints directly
one simple check using the same program as the runner's tests

some changes needed to be added to prover, expr, verifier, gate, wires,  index, for it to work. But further modifications will have to be carried out

These are the following types of gates (more or less, in gadget order).

CairoClaim: takes care of the initial and final registers claim
CairoInstruction: takes care of the logics of the Cairo instruction.
CairoFlags: performs registers update checks using the values of the flags
CairoTransition: performs the check of a correct transition between consecutive instructions
Zero: does nothing, it's just a row that holds 3 values. It would be great to merge this one somewhere else, but it doesn't seem to fit. So it is a Zero gate for now (used to be CairoAuxiliary, but I think it can be Zero like in ChaCha).

Some remarks/TODOs for future versions:

I have to write the wiring of the Cairo rows. In the comments I wrote some sort of table of the current layout and it explains what columns should be copied and from where. But this is still pending.
I want to create full tests that involve both the prover and the verifier, not only these "gates checks"
(Issue 282)Think about a different number of columns and how much it would benefit Cairo and other complex gates. In this approach, if n is the number of instructions, the full gadget for the program takes 4n-1 rows.
(Issue 294)The runner still needs to address the hints independently: meaning, run the program backwards and figure out the intermediate 2 or 3 values of the memory that need to be set for this nondeterministic feature of the memory

Awesome work-- Looks great!

Update: I have addressed @mimoo 's comments regarding the optional feature of the cairo gates, so I wrapped these fields in optional types. This way, powers of alpha are not altered if the circuit has no cairo gates. For this, I followed the same strategy as chacha, equipping the constraints_expr and expr_linearization with a boolean type cairo. OCaml types are updated to be optional as well, and the alphas have been updated on the specs.
This way, cairo gates have no effect on the rest of the proof system, but if you still think it is worth moving these things to another PR, that can be done.

if you still think it is worth moving these things to another PR, that can be done.

yeah sorry can you do it ^^? I'd really like to be able to review the parts that affect kimchi in isolation so we make sure that it won't affect the hardfork

yeah sorry can you do it ^^? I'd really like to be able to review the parts that affect kimchi in isolation so we make sure that it won't affect the hardfork

sgtm, I'll do that then :)

Merging Cairo instruction-related gates after addressing your comments (upcoming PRs about the proof system and the memory model)


Master process on 100% CPU

During production mode, aerys (master process) uses currently constantly 100% CPU. Currently using the NativeReactor. Everything is fine in debug mode.

No repro currently, when that occurs again, please reopen with reproduce steps.


Coalesce track events into stream allocator.

In a large room, when a participant joins, that participant could
subscribe to a significant number of tracks in a burst upon join.
This could generate a bunch of events into stream allocator.
Coalesce events of a track so that only one allocate event per track
is posted to channel, i. e. prevent posting more allocate events
till the previous one is processed. As allocate will take view
of current state of track when processing the event, there is no
need to post multiple events.

Great work to continuous improve this! still not understand this completely..


Turbine condensation return

It would be nice to have not have to keep pumping absurd amounts of water. Already 12,000mB/t is quite the task, but it would be nice if we could recover the water and pump it back into the reactor. Run the turbine and reactor "closed loop".
Might save quite a few ticks server side.

I'll consider allowing for water to be reprocessed in the future, maybe a "Condensation Port."  Closing for now, however, to focus on more prevalent issues.


All headerfiles of React has been moved React/*** in 0.40

This needs to be upgraded in order to let users continue to use the plugin when the release is out at 1 of January according to release schedule.
A release candidate is already available.

Thanks for the heads up, @ptomasroos.

Here is PR for that https://github.com/bugsnag/bugsnag-react-native/pull/60

Fixed via #60. Thanks @henrikra!


Failed: Update autorest version to prerelease 3.0.0-alpha.20240726.6

Generated by Autorest Regen Preview build 20240726.6Triggered from pull request: https://github.com/Azure/autorest.csharp/pull/4932

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Analytics.Purview.DataMap


Add @g.eulji.ac.kr

Eulji university
@g.eulji.ac.kr

@dduniverse Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Add Golang/other lambda backend language support

Is your feature request related to a problem? Please describe.
I would like to be able to automagically deploy non-javascript based lambda functions (eg. golang)
Describe the solution you'd like
Add support for using any supported lambda languages, particularly Golang
Describe alternatives you've considered
Manually adding the required CloudFormation/etc to my repo.
Using pre-deployed lambda's (from AWS SAM or similar)
Additional context
N/A

Is there any recommendation on how best to deal with this issue at the moment?

Generally it would be really helpful to have some integration between sam and amplify. Sam supports different Lambda runtimes, whereas Amplify only supports Node.  If there was a way an Amplify api could be created that leveraged SAM scripts it would really help

Yeah,  this is a big deal for me too!

I commented on another ticket about implementing a python lambda. I'm something similar can be done for golang. Luckily after initial setup, there's no more work to do. just add code: https://github.com/aws-amplify/amplify-cli/issues/1505

+1 for go lambda.

Also +1 for go lambda, go lambda local dev would be killer also!

+1 as this is preventing me from using Amplify :( . (for lambda functions anyway)

Any updates on this ticket?

We're actively working on getting Python, Java, Go, .NET support for Lambda runtimes support out soon.

@kaustavghosh06 Great news, I hate to have to ask this, but do you have an approximate time for this release? I'm working on my university final year project at the minute and would like to use python lambda functions with amplify, I cannot afford to if they are not released in the next 2-3 weeks. If I had an idea I could plan accordingly. Thanks.

Great to hear support for more languages is coming! Does anyone happen to have a link to a guide on how to work around that for the time being? I'm attempting to integrate in python lambda functions.

Great to hear support for more languages is coming! Does anyone happen to have a link to a guide on how to work around that for the time being? I'm attempting to integrate in python lambda functions.

I found this bug when looking to work through that same situation, @SolveForTech. In the end I used Serverless Framework and the aws-amplify-serverless-framework plugin to connect the AWS config details between Serverless and the Amplify library on the client side.
I wrote up how I did it at https://medium.com/@jrheling/using-serverless-framework-with-the-amplify-client-library-9f3a1e2ee24f, in case that's of help to you.

Thank you Josh!!!
On Mon, Mar 9, 2020, 11:07 AM Josh Heling<EMAIL_ADDRESS>wrote:

Great to hear support for more languages is coming! Does anyone happen to
have a link to a guide on how to work around that for the time being? I'm
attempting to integrate in python lambda functions.
I found this bug when looking to work through that same situation,
@SolveForTech https://github.com/SolveForTech. In the end I used
Serverless Framework and the aws-amplify-serverless-framework plugin to
connect the AWS config details between Serverless and the Amplify library
on the client side.
I wrote up how I did it at
https://medium.com/@jrheling/using-serverless-framework-with-the-amplify-client-library-9f3a1e2ee24f,
in case that's of help to you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-cli/issues/156?email_source=notifications&email_token=ABYJAIXG7HEDW3FYMHYSXR3RGUO3JA5CNFSM4FUTH6Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOH3VRI#issuecomment-596622021,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYJAIXLSL46YL6JFHXMZSDRGUO3JANCNFSM4FUTH6ZQ
.

genius workaround @stefangomez, thanks. I followed the same pattern for a golang lambda and it worked without a hitch. The only additional step I added was a "preinstall": "go clean" in the package.json.

Hey guys, yesterday with Amplify CLI v4.18.0 we officially support Go, Java, Python and .NET runtimes along with local testing for these functions. Docs for the feature - https://docs.amplify.aws/cli/function#supported-lambda-runtimes

Yeeeess!! Thank you @kaustavghosh06 !

In case of python function, it does not seems to build through Amplify due to the lack of python 3.8 on the Amazon Linux:2 image (only 3.7 is on it) ... will have to install it in prebuild phase or custom image ...


Do not import from IPython.core.display and warn users.

Codecov Report

Merging #1 into refactor_display will decrease coverage by 0.02%.
The diff coverage is 83.33%.

@@                 Coverage Diff                  @@
##           refactor_display       #1      +/-   ##
====================================================
- Coverage             72.12%   72.10%   -0.03%
====================================================
  Files                   255      255
  Lines                 26877    26888      +11
====================================================
+ Hits                  19385    19387       +2
- Misses                 7492     7501       +9

Impacted Files
Coverage Δ

IPython/core/display.py
78.41% <75.00%> (-0.19%)
:arrow_down:

IPython/core/displaypub.py
58.33% <100.00%> (ø)

IPython/core/magics/display.py
65.51% <100.00%> (ø)

IPython/core/page.py
20.11% <100.00%> (ø)

IPython/core/pylabtools.py
54.65% <100.00%> (ø)

IPython/core/tests/test_display.py
99.21% <100.00%> (ø)

IPython/testing/iptest.py
67.53% <100.00%> (+0.14%)
:arrow_up:

IPython/core/async_helpers.py
89.70% <0.00%> (-2.95%)
:arrow_down:

IPython/core/interactiveshell.py
79.89% <0.00%> (-0.21%)
:arrow_down:

IPython/core/tests/test_magic.py
98.36% <0.00%> (-0.14%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ca535...43a01a2. Read the comment docs.


Added Etch Sketch Game

It solves issue #1532
Its working video,
https://user-images.githubusercontent.com/75881393/119194347-8db64b00-baa0-11eb-8a6f-31b07b58d94a.mp4

Please @ridsuteri @991rajat @urvashi-code1255 review this PR.


Async execution of Page Bottom, DOM Ready, Window Loaded

Hi,
For async deployments, can you please document (diagrams would help) the order in which Launch will fire rules triggered on the UI Events "Library Loaded", "Page Bottom", "DOM Ready", and "Window Loaded" when the Library Loaded event occurs before or after the underlying actual underlying events (or in the absence of _satellite.pageBottom()).
Example 1:

Async Launch library loads instantly (and underlying Library Loaded event is fired)
End of  is reached but there is no _satellite.pageBottom() event to fire
DOMContentLoaded() fires
window.load() fires
Expected order of rules: Library Loaded, Page Bottom, DOM Ready, Window Loaded

Example 2:

End of  is reached but there is no _satellite.pageBottom() event to fire
Async Launch library loads instantly (and underlying Library Loaded event is fired)
DOMContentLoaded() fires
window.load() fires
In what order do the rules fire?

Example 3:

End of  is reached but there is no _satellite.pageBottom() event to fire
DOMContentLoaded() fires
Async Launch library loads instantly (and underlying Library Loaded event is fired)
window.load() fires
In what order do the rules fire?

Example 4:

End of  is reached but there is no _satellite.pageBottom() event to fire
DOMContentLoaded() fires
window.load() fires
Async Launch library loads instantly (and underlying Library Loaded event is fired)
In what order do the rules fire?
Is this scenario even possible? or is window.load() dependent on the Launch Library loading?

It seems like the order of the Library Load event in relation to the other page load events is unpredictable, but I hope the order of rule firing is and is the same as in Example 1. Regardless of how it works, i think this needs to be documented. One specific use case we are trying to decide is when should we fire our Analytics page view beacon if some of our data layer is not defined until the bottom of the page? Would the preferred event be Library Loaded, DOM Ready, or Window Loaded?
The information should go here:
https://docs.adobelaunch.com/client-side-information/asynchronous-deployment
@Aaronius

Hi @dwright-adobe. I plan on writing up something more formalized to go in the docs, but just to give you the answer beforehand: Every time the Launch library loads, no matter when or how it is loaded, all of the following events will trigger their respective rules in this order: Library Loaded, Page Bottom, DOM Ready, Window Loaded. If any phase has already occurred on the page, they'll fire their respective rules "immediately", while still respecting the order.

Also, in response to this:

One specific use case we are trying to decide is when should we fire our Analytics page view beacon if some of our data layer is not defined until the bottom of the page? Would the preferred event be Library Loaded, DOM Ready, or Window Loaded?

I would use DOM Ready. DOM Ready will occur after the document has been loaded and parsed, which would be after "the bottom of the page". Library Loaded could be too early and Window Loaded is unnecessarily late.

Thanks! We decided on using DOM Ready for the Tutorial, but it's great to have this confirmation. I think it will be helpful to have the order stated in the documentation when you have time.

New documentation has been published here: https://docs.adobelaunch.com/launch-reference/client-side-information/asynchronous-deployment
Thanks for the request @dwright-adobe.


Update cos-setup-network.service to look like the other services

Currently the network service is not kept as alive like the other and has some other configs in there which dont make much sense.
This patch just makes it equal to the rest of the other oneshot services

closing in favour of https://github.com/kairos-io/packages/pull/303 which is more complete


How to deploy with hidden dot folder (/.files) or create dot folder on production

I'm trying to create hidden dot folder on the same level as public to serve static files I generate every day.
var fs = Npm.require('fs');

Meteor.startup(function() {
  var dir = './../../../../../.files';
  if (!fs.existsSync(dir)){
      fs.mkdirSync(dir);
  }
  routePath = fs.realpathSync(dir);
})

Everything works on production but I got error during deploy : Invoking deployment process: FAILED
Logs showed I can't create this folder:
Error: EACCES, permission denied './../../../../../.files'
    at Object.fs.mkdirSync (fs.js:654:18)
    at Router.map.route.where (server/server_router.js:7:10)
    at /opt/appname/app/programs/server/boot.js:249:5
error: Forever detected script exited with code: 7
error: Script restart attempt #14

Did you get a solution for this?


Reolink Doorbell "Exit Status 1" and EOF Errors

I have a Reolink doorbell, but the stream is regularly going offline and I'm not sure why.  I am running Go2RTC through Frigate.
I am getting errors like
2023-10-01 15:57:39.597489210  15:57:39.597 WRN [rtsp] error="streams: exec: exit status 1" stream=side_door
2023-10-01 15:57:44.712305404  15:57:44.712 WRN [rtsp] error="streams: exec: exit status 1" stream=side_door
2023-10-01 19:25:42.094011955  19:25:42.093 WRN github.com/AlexxIT/go2rtc/internal/streams/producer.go:171 > error=EOF url=ffmpeg:rtsp://admin:password@<IP_ADDRESS>:554/h264Preview_01_main

And my config for frigate/go2rtc is as follows.
go2rtc:
  webrtc:
    candidates:
      - <IP_ADDRESS>:8555
      - stun:8555 # if you have dynamic public IP-address

  streams:
    side_door:
      - ffmpeg:rtsp://admin:password@<IP_ADDRESS>:554/h264Preview_01_main
      - ffmpeg:rtsp://admin:password@<IP_ADDRESS>:554/h264Preview_01_main#audio=pcm#audio=volume#audio=async
      - "ffmpeg:side_door#audio=opus"

    side_door_substream:
      - ffmpeg:rtsp://admin:password@<IP_ADDRESS>:554/h264Preview_01_sub
      - ffmpeg:rtsp://admin:password@<IP_ADDRESS>:554/h264Preview_01_sub#audio=pcm#audio=volume#audio=async
      - "ffmpeg:side_door_substream#audio=opus"

cameras:
  side_door:
    ffmpeg:
      inputs:
        - path: rtsp://<IP_ADDRESS>:8554/side_door
          input_args: preset-rtsp-restream
          roles:
            - record
            - detect
            - rtmp

Any help appreciated

https://github.com/AlexxIT/go2rtc#source-rtsp

Reolink users may want NOT to use RTSP protocol at all, some camera models have a very awful unusable stream implementation

You should use HTTP-FLV


Remove Experience Config Delivery Mechanism [#3322]

Closes #3322
❗ Contains migration; check downrev before merging
❗ Blocked by frontend ticket https://github.com/ethyca/fides/issues/3320
Vocabulary
Privacy Notice:   The entity that a user accepts or rejects in terms of consent.  A notice encapsulates a name, consent mechanism, data uses, and potentially many regions.  It is not linked to Privacy Experiences via FK.  Privacy Experiences are potentially created behind the scenes when Privacy Notices are created/updated to make sure we always have experiences to present the given notices.
Privacy Experience:  Governs how privacy notices are presented to the end user for a given region. Represents the Experience for a single region and component (overlay or privacy center).  Has a FK to Experience Config.  At runtime, determines what Privacy Notices are relevant for a particular experience and returns.  Components like the privacy center, banners, and overlays should call the Privacy Experience API.
Experience Config:  Holds the copy for an experience, such as the overlay's title or button labels.  This ExperienceConfig can be shared between multiple Experiences.  The Admin UI queries the Experience Configs so the customer can set these up.  Experiences are updated behind the scenes when Experience Config updates are made.
Description Of Changes
Building on the previous data model changes to keep Privacy Notices in sync with Privacy Experiences, this PR simplifies the constraints.
Follows what @NevilleS proposes here, primarily by removing ExperienceConfig.delivery_mechanism and all associated validation.  Previously, PrivacyNotices that had opt_in or notice_only consent mechanisms had to be presented in an overlay that was delivered by a banner (field stored on the PrivacyExperienceConfig).  There was a lot of behind the scenes activity to ensure that we always kept our PrivacyExperiences in the correct state, when both PrivacyNotices and PrivacyExperienceConfigs were updated. We remove this here and instead surface a property calculated at runtime for the frontend to determine if they need to show a banner.
Similarly makes the related changes to update the ExperienceConfig with the new fields per updated requirements
Code Changes

[ ] In the GET Privacy Experience List endpoint, surface a new field PrivacyExperience.show_banner which is calculated at runtime as to whether or not the given experience needs to be triggered via a banner
[ ] Remove checking associated privacy notice consent mechanisms when updating or creating ExperienceConfigs to make sure there's not a delivery mechanism mismatch.  Reduces the links between the two.

[ ] Remove automatically updating Experiences behind the scenes when PrivacyNotices were adjusted in a way that forced the delivery_mechanism to change

[ ] Add/rename many fields on the ExperienceConfig table to reflect the new mockups.
[ ] Allow ExperienceConfigs to be updated without passing in a regions key, to support the first release, where the copy can be updated, but the regions can't.  If no regions key supplied, Experiences that are linked to the ExperienceConfig won't be touched.

[ ] Add new validation that prevents ExperienceConfig.component from being updated once it's created to avoid a bunch of extra backend messiness.

[ ] Bug fix that changes when we validate PrivacyNotice component and displayed_in_* fields - there were edge cases where we would be validating too early.  We really need the existing PrivacyNotice object to already be loaded before we validate.

Steps to Confirm

[ ] POST {{host}}/privacy-notice to create some notices
[ ] GET  {{host}}/privacy-experience/ to verify Privacy Experiences still created behind the scenes when the Privacy Experiences were created.  For now experience_config should be null.  Verify that show_banner is True if there is a notice under privacy_notices that has a consent_mechanism of opt_in or notice_only.  privacy_center notices however, always have show_banner = False
[ ] POST {{host}}/experience-config where your request body has component=overlay, and use a region that matches one of your regions in experiences
[ ] GET {{host}}/privacy-experience/ and verify that experience_config is no longer null for the matching overlay type and region.
[ ] Do a PATCH {{host}}/experience-config/{{experience-config-id}} to an experience config that was associated with an experience whose "show_banner" was True.  In the request body, set banner_enabled: always_disabled.  Verify that this should flip show_banner to False, for Experiences it is attached to (GET {{host}}/privacy-experience/ to verify

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[x] Update CHANGELOG.md
[x] For API changes, the Postman collection has been updated

thanks very much for taking the time to review @adamsachs ⭐

Thanks again for getting up to speed to get this reviewed Adam! Especially appreciate the comments about keeping an eye on what fields are stored in which model and will keep a watch on this one.


the first sync() call erase my config value

Hi @RonaldinhoL. Can you share the code you are using that caused the issue? I need to be able to reproduce the problem in order to fix it.
sync() will first read config values from the file that you provide. If any values have been set on the Config object, they will not be overwritten by the value from the file. sync() will then write the values from the Config object to the file.

i init by None，dose it matter?

my sence dose need a default value，for example: username and password and token

@RonaldinhoL Based on your comments, I understand that you are trying to do something like this:
import profig

c = profig.Config('test.cfg')
c.init('username', None)
c.sync()

And what happens is that the value from the config file is being overwritten. Is that correct?
If that is the case, yes this should be considered a bug, or at least unexpected behavior. What is happening is that profig is not able to determine the type of the value you are expecting to read. It is using type() on your default value, which in this case is NoneType. So, when it tries to read the value from the config file, it is converting it to None. That is then written back to the config file.
I will fix this, but I can't say when. In the meantime, everything should work if you set the type that you expect to read from the config file. In you case, something like this should work:
c.init('username', None, str)
# or
c.init('username', '')

Thanks for the report.


Process hangs due to race condition in file pusher?

Describe the bug
Our team has been using the wandb logger in pytorch-lightning to monitor trial progress and log artifacts for over a year now and fairly recently (perhaps due to recent upgrades of our wandb version?) we've been encountering a bug where upon the completion of a trial, the process hangs, seemingly due to a race condition in file uploading. Our debug-internal.log file ends with the following 3 lines:
2022-10-16 08:04:19,712 INFO    SenderThread:615 [sender.py:finish():1315] shutting down sender
2022-10-16 08:04:19,712 INFO    SenderThread:615 [file_pusher.py:finish():168] shutting down file pusher
2022-10-16 08:04:19,713 INFO    SenderThread:615 [file_pusher.py:join():173] waiting for file pusher

At face value, this would appear to be a race condition of some kind. Worth noting perhaps is the fact that we are using a tempfile.TemporaryDirectory as our save_dir. Also worth mentioning is the potential relatedness of #269.
Please let me know if I can provide any more details regarding the nature of the issue. We're currently in the process of decrementing our wandb version in the hopes that this will help but currently, this issue is blocking our ability to use wandb!
Additional Files
No response
Environment
WandB version: 0.13.3
OS: ubuntu 18.04
Python version: 3.8.10
Additional Context
No response

Hi @OrEisenberg , happy to help here. Can you please provide the following:

Complete debug.log and debug-internal.log files for the runs that are hanging
wandb version you were using prior to upgrading
Brief description of your experiment and count/size of files you are uploading to your project.
For the files logged, are you logging them as artifacts?
Thank you

I'm facing similar issue as well with similar setup as @OrEisenberg: using the logger in python_lightning and running in a Bitnami pytorch container (Debian 11, Python 3.8.14, wandb 0.13.4). I suspect I was being rate-limited, as I was running the container as one of the 12 agents of my sweep.
I have notice something strange however. The wandb dashboard showed the run crashed initially (although the run was actually running fine on my local machine), but after coming back from my dinner break it shows the run was finished and everything was uploaded to the dashboard. And this happens not just once, but on almost all the runs in my sweep.

Brief description of your experiment and count/size of files you are uploading to your project.
An variational inference algorithm with 5000 iterations, logging 4 scalers in every 10 iterations. The 'run' file with a .wandb extension was 4.4MB.

For the files logged, are you logging them as artifacts?
No

Complete debug.log and debug-internal.log files for the runs that are hanging
debug-internal.log
debug.log

@weiyaw Would you happen to be calling wandb.finish() before starting your training by chance (this is recommended by pytorch_lightning if I recall correctly)?

I didn't call wandb.finish() in my script, as I'm not using a notebook. Are you referring to this article, under the section 'Let's Train our Model'? https://wandb.ai/manan-goel/MNIST/reports/How-to-Integrate-PyTorch-Lightning-with-Weights-Biases--VmlldzoxNjg1ODQ1
I wasn't using ray either. I was running my containers on Kubernetes.

Here's another run that was stuck in an infinite loop without uploading anything to wandb server after around the 2000th iteration.
I was running 28 sweep agents across 4 VMs (7 each) simultaneously. Each agent was wrapped in a container, and I was using docker run repeatedly to run the containers.
debug.log
debug-internal.log

We've resolved this issue on our end. It turn out it was just an interaction between ray and pytorch-lightning. See this iss.

Hi @OrEisenberg , we appreciate you writing in with an update and informing us it's been addressed.


MapView fully loaded callback / MapView Screenshot Functionality

Please note: issues related to or caused by osmbonuspack will be closed with a
suggestion to open an issue at https://github.com/MKergall/osmbonuspack
(feel free to delete whatever doesn't apply)
Issue Type
[ ] Question
[ ] Bug
[ X] Improvement
[ ] Build system related
[ ] Performance
[ ] Documentation
Description
Currently there is no option to know when a Mapview is fully loaded with all the tiles. This could be helpful to create a static screenshot of MapView instead of relying on a server-side Static Map API.
A functionality similar to snapshot  method in Google's MapView would also be useful.

Hi @abinpaul1!
Actually there's something similar, but maybe not deeply embedded in MapView.
It's called MapSnapshot.
I think you'll find a couple of demos in the sample app: one that creates bitmaps with up-to-date tiles for USA States, and the other that displays on top of the MapView the number of up-to-date and approximated tiles.
Tell me if you do find something close to your needs.

Yes. That was exactly what was required. Thanks a lot.
I wasnt able to find this functionality easily. I would be happy to add documentation or wiki for this option , if you could point me to where I should.
Just adding the snippet to take snapshot of a Mapview hear incase anyone wants a quick sample
final MapSnapshot mapSnapshot = new MapSnapshot(new MapSnapshot.MapSnapshotable() {
            @Override
            public void callback(final MapSnapshot pMapSnapshot) {
                if (pMapSnapshot.getStatus() != MapSnapshot.Status.CANVAS_OK) {
                    return;
                }
                final Bitmap bitmap = Bitmap.createBitmap(pMapSnapshot.getBitmap());
                // Do something with the bitmap like save to file
            }
        }, MapSnapshot.INCLUDE_FLAG_UPTODATE, pMapView);
new Thread(mapSnapshot).start();

@abinpaul1 Cool! Feel free to create a new page in the wiki.

I have added it here : https://github.com/osmdroid/osmdroid/wiki/Taking-Snapshot-of-Maps

@abinpaul1 Well done!
There's another demo that could be interesting for you called "Tile States", based on TileStates. Each time the map is refreshed, the number of up-to-date/expired/scaled/not-found tiles is computed. Less "callback-style" than MapSnapshot, but can be useful too.
Feel free to close this issue.


I would like to join this organization to add DS and Algorithms

Actually it's the other way around.
in order to join this organisation, one must add DS and Algorithms to the repository.

Hi @JayantGoel001,
You were invited as a member of this organization.

The invitation link

Hi @JayantGoel001,
You were invited as a member of this organization.

The invitation link

Thanks 🙂


Input Text name

It's possible to add a input text for indicate the name to file for export? thanks. Your plugin is amazing!

Thank you.
The name of the artboard is used for the name of the file that is exported. Does that work for you?

Closing due to inactivity


support template versioning (copied from Profile Editor repo)

Add a version property field to the resource template and profiles section.

Closing in favor of https://github.com/LD4P/sinopia_editor/issues/2844


mini.files doesn't follow symlinks

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.files
Description
When a file is a symlink, mini.files doesn't open it
Neovim version
Nightly v0.11.0-dev+599-g8df6736ca
Steps to reproduce

Create a symlink
Try to open it with mini.files

Expected behavior
The target file of the symlink opens
Actual behavior
Nothing happens

Thanks for the issue!
Wow, indeed I can reproduce. It is rather strange because it works with symlinked directories (which I mostly have to deal with). I'll take a look.

On a second note, I'd like to ask for some clarifications.
I did indeed manage to reproduce it with the following setup (on Linux in zsh):

echo "File original" > file-orig
mkdir dir
ln -s file-orig dir/file-linked

Then after navigating to 'dir' directory, there is both no preview of 'file-linked' (although it is present) and it is not opened. The reason for that is that the file path is resolved as '/dir/file-orig', which is indeed not present on file system. You can verify it with :=vim.fn.resolve('dir/file-linked') (should print 'dir/file-orig') and :=vim.uv.fs_stat('dir/file-linked') (which should print nil and an error that file does not exist).
On the other hand, if symbolic link is created to the full path, everything works as expected. That is, after ln -s $(pwd)'/file-orig' dir/file-linked2, everything works as expected for 'dir/file-linked2' file.
So I'd like to ask how exactly did you create symlinks? If via linking to relative path, then it seems to be not a good way. Another confirmation of this is that Neovim's built-in :edit doesn't recognize 'dir/file-linked' but recognized 'dir/file-linked2'.

@echasnovski Yes, I created the symlinks using a relative file path. Could that perhaps be an upstream bug if the :edit command doesn't work with it either?
Also, in case it matters, I got this issue while managing files on a mounted ssh server (I guess it uses sshfs but I'm not sure how Gnome does stuff). Though I don't think this is relevant to the issue since you're able to reproduce in on a local filesystem.

Could that perhaps be an upstream bug if the :edit command doesn't work with it either?

It is certainly possible, however it is not only :edit that behaves this way but also vim.uv.fs_stat() doesn't recognize these "relative symlinks" as paths that actually exist on disk. As both of these come from different parts of software with long history of widespread use and tests, I'd say this is intentional.
On latest main this case at least results into a notification which shows information about why there is nothing happening. I think this is the best 'mini.files' can do here.


Server Error Log #6

https://gist.github.com/Vohras2/0601a89bedabdf98d0431f4ae86380b3

Sponge tracking error, won't be able to forward this one unless it keeps happening on latest. Closing.


Add panel pointing to docs for ml benchmarks

This will render like this at the top of the page.

I also removed the link which was not very visible.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @AnandInguva


'Unpublish' button missing from top of Opp detail pages

this only happens when the user does not have the ability to publish, which includes when the parent program or project is also unpublished


Fix ddf.groupby with scalar group_keys and falsy column slicing

When working with some ddfs recently containing integer columns, I noticed a couple issues when slicing column 0, which is "falsy" - depending on the operation, sometimes I would get the wrong column output (eg: .groupby(...)[0].agg(...) would return a different column, if 0 wasn't the first) or get a dataframe back instead of a series. These were mostly caused by if self._slice checks which should be if self._slice is None checks.
While looking into this, I also discovered issues with ddf.groupby(scalar_value).cov() ('int' object is not iterable). I think this is mostly isolated to .cov, but there's a lot of other logic checking or converting self.by to a list elsewhere, so harder to say.
The added tests fail when run without the changes, but aren't particularly clear/tidy - any suggestions on a better way (or an existing test)?

[ ] Closes #xxxx
[x] Tests added / passed
[x] Passes pre-commit run --all-files

Can one of the admins verify this patch?

Tests are broken due to https://github.com/dask/dask/pull/9020#discussion_r867429175 - I think that's a separate .cov incompatibility w/ the pandas version. I haven't had time to look in to see if that'd be a quick thing to fix or worth a separate issue (and removing from these tests for now).

Looks like there's a difference in 3.8 where pandas returns an int64 dtype while dask returns a float64 (tests also failed on 3.9/macos, but I think that was just a flake). I rebased and will see if I can debug, but seems like it might not be directly related to these changes (aside from new tests).

Ok, I think this is because pandas==1.2.5 is installed for 3.8 (pandas==1.3.5 is used for 3.9), which doesn't use the int64 type.
For now, I changed my tests to explicitly say float64.

I think the two failing tests in the latest commit are flakes, or at least unrelated:

dask/array/tests/test_reductions.py::test_reductions_2D[f4]
dask/tests/test_distributed.py::test_blockwise_dataframe_io[True-None-hdf]

I think all of my commits have had flakes (ignoring the true failures) so I won't commit again just for a rerun. Could someone "rerun failed jobs"? 🙏


Member port creation handling - stable/newton

Details: We need to decide how to handle port creation error for a specific member in stable/newton.

OpenStack Release
stable/newton
Bug Severity
For bugs enter the bug severity level. Do not set any labels.
Severity: <Fill in level: 1 through 5>
Severity level definitions:

Severity 1 (Critical) : Defect is causing systems to be offline and/or nonfunctional. immediate attention is required.
Severity 2 (High) : Defect is causing major obstruction of system operations.
Severity 3 (Medium) : Defect is causing intermittent errors in system operations.
Severity 4 (Low) : Defect is causing infrequent interuptions in system operations.
Severity 5 (Trival) : Defect is not causing any interuptions to system operations, but none-the-less is a bug.

@szakeri and @dflanigan: I think this issue has been addressed completely. We likely did not reference it directly in a PR.


FilterChooser component has unappealing artifact on right side in Chrome 96+

This appears to be a css issue in Chrome 96+.  Does not happen in Chrome 95.
This does not happen in our select component.

Reported by @haynesjm42 today - I've seen this also and have been meaning to file this ticket. Colin / John - if either of you have a few cycles to look this week please comment or chat so we don't dupe up the work - hopefully a quick style fix, but with React Select you never know...

This issue exists on Safari 15.1 too.  So, it is not strictly a Chrome version bug, as I previously thought.
The artifact is the vertical scrollbar.
Definitely, if these lines are tweaked:
hoist-react/desktop/cmp/input/Select.scss
// Ensure multi-value selects don't overflow vertically in the toolbar
.xh-toolbar {
  .xh-select {
    &__value-container--is-multi {
      height: 28px;
      overflow-y: auto !important;
    }
  }
}

The scrollbars go away.  But those lines are needed for their specified purpose.
It's the lineheight of the element inside that is making the element too big.

and by just a smidge over 28.
Lineheight is coming from blueprint.css:

Will look into whether that changed recently.


Add ClusterTask to webhook (for validation)

Changes
We are not validating nor mutating ClusterTask as we do for
other objects. This fixes that by adding it to what the webhook watches.
Will be cherry-picked in v0.5.2 :angel:
/cc @bobcatfish
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task and TaskRun to build and release this image

Release Notes
Make sure ClusterTask are validated by the webhook (as are other resources)

I am a bit hesitant to put this in the 0.5 release - it feels kinda like a new feature and since that release has been a bit unstable I feel like it's good to minimize what we're adding (e.g. what if there was a bug in our validation and suddenly we started panicking on clustertask validation)

Fair :wink: Let's add that to the 0.6.x milestone then :wink:


yielded components on a hash are linted as not defined when yielded on named blocks

Not sure which addon is doing the linting, this one or https://github.com/ember-template-lint/ember-template-lint. Starting here
When a component is yielded on a named block, then used, the linter states that the component is undefined. This is in a test. Have not yet converted the actual use to a gjs.
await render(<template>
      <Stargate
        @onCancel={{(noop)}}
        @onContinue={{(noop)}}
        @noButtons={{false}}
      >
        <:default>
            {{blockText}}
          </:default>
        <:buttons as |buttons|>

          <buttons.cancel /><buttons.continue /></:buttons>
        <:title>
{{title}}
 </:title>
      </Stargate>
    </template>);

Linting message
 Error in template: 'buttons' is not defined  no-undef

While the named block happens to be the same name as the yielded hash, I did try changing the names and the issue persisted.
I have used yielded components elsewhere with no linting issue, assuming this is specific to named blocks

what ember-source are you using? this is fixed in projects with sufficiently new ember-source, due to a fix landing in @glimmer/syntax's parser

4.12.3.   Used to be I kept ember data and ember source in sync. Working through ED deprecations, so cant update to 5 for ED. Is it ok to update to 5 for source and keep ED at 4?

K, good to know, ember-code coverage looks like its bringing in 0.42 and and ember font awesome is bring in 0.27

Should be resolved in v4. Thanks for reporting!
If this is still an issue, lemme know and we can reopen.

Can you try the main branch of eslint-plugin-ember?

sadly that did not fix it: https://github.com/c0rydoras/gjs-linting-no-undef-reproduction/actions/runs/6799482927/job/18485892842

Interesting. Thanks for the reproduction! Can you open an issue on eslint plugin ember? Thanks!

done: https://github.com/ember-cli/eslint-plugin-ember/issues/1991


autoapi subtitle looks wrong

I'm not sure what I'm doing wrong with sphinx-autoapi but the subtitle looks weird and needs to be fixed.

I suppose the "Create a 404.html page" should be at the same level that the paragraph and maybe in bold. Also, "404.html" should be rendered as code.
The page affected by this is https://sphinx-notfound-page.readthedocs.io/en/latest/autoapi/notfound/extension/index.html

I looked at the code that generates this docstring. I don't see anything obvious wrong with it, but I see that line 19 is being exported in the same style as the heading. It's weird. I tried adding an extra blank line between the """ and line 19, but that didn't fix this issue.
If you know of other projects that are using autoapi, post links. I can look at some examples next week and maybe the fix will be obvious.

This is an example of a project using autoapi: https://modelbase.readthedocs.io/en/latest/autoapi/modelbase/index.html
It may be a problem of the theme or the autoapi itself, but it needs further research to understand the reason.

Closing because it's an upstream bug: https://github.com/rtfd/sphinx-autoapi/pull/165