Aggregate possible have memory leak in global aggregation and non-global aggregation

Bug description
According to https://facebookincubator.github.io/velox/develop/aggregate-functions.html#accumulator

Memory allocated from the HashStringAllocator needs to be released in the destroy() method.

AggregateWindow will invoke Aggregate::destroy in its destructor.
https://github.com/facebookincubator/velox/blob/acaeb1f8705cf92cb5eddc3299b7ee24d32ab95e/velox/exec/AggregateWindow.cpp#L94-L101
But GroupingSet only invoke Aggregate::destroy when isGlobal_= true and Aggregate::accumulatorUsesExternalMemory return true.
https://github.com/facebookincubator/velox/blob/acaeb1f8705cf92cb5eddc3299b7ee24d32ab95e/velox/exec/GroupingSet.cpp#L93-L97
https://github.com/facebookincubator/velox/blob/acaeb1f8705cf92cb5eddc3299b7ee24d32ab95e/velox/exec/GroupingSet.cpp#L379-L381
For most Aggregates, their accumulatorUsesExternalMemory default return false, thus will not be invoked destroy in global aggregation. For non-global aggregation, seems no one will invoke destroy method to release memory.
Why we use these conditions to decide whether invoke destroy? Is anywhere will shared aggregates with grouping set?
CC @mbasmanova @xiaoxmeng
System information
Velox System Info v0.0.2
Commit: Not in a git repo.
CMake Version: 3.20.2
System: Linux-5.10.134-13.1.al8.x86_64
Arch: x86_64
C++ Compiler: /usr/lib64/ccache/c++
C++ Compiler Version: 10.2.1
C Compiler: /usr/lib64/ccache/cc
C Compiler Version: 10.2.1
CMake Prefix Path: /usr/local;/usr;/;/usr;/usr/local;/usr/X11R6;/usr/pkg;/opt
Relevant logs
No response

For grouped aggregation, the aggregates are destroyed in hash table -> row container: https://github.com/facebookincubator/velox/blob/acaeb1f8705cf92cb5eddc3299b7ee24d32ab95e/velox/exec/RowContainer.cpp#L298

Thanks for reply @Yuhta .
I add log and debug MinMaxTest.maxVarchar, both global aggregation and grouped aggregation's destroy were not invoked.
RowContainer::freeAggregates only invoked in spilling aggregation when running testAggregates.

min/max is not using external memory so destroy is not called.  Can you check some other aggregate that has accumulatorUsesExternalMemory() return true?

min/max is not using external memory so destroy is not called. Can you check some other aggregate that has accumulatorUsesExternalMemory() return true?

Only SumNonPODAggregate's accumulatorUsesExternalMemory return true.
Most aggregate use SingleValueAccumulator, did you mean SingleValueAccumulator will auto release memory without explicitly invoke SingleValueAccumulator::destroy?
@Yuhta

Yes memory allocated from HashStringAllocator is not considered "external memory" and does not need to released in the aggregate itself.

Thanks for the explanation!


fix(forms): hide input control text under valid icon

Fixes #1305
This PR is a proposal to fix #1305 by:

adding the same padding-right rule than in Bootstrap
avoiding to display the valid icon for Quantity Selector (not enough space)

Dear reviewer please check all possible cases in forms when inputs are valid.
Live previews

Forms > Validation > Custom styles
Forms > Validation > Supported elements

@MewenLeHo or @louismaximepiton Please check this new version including https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/pull/1306/commits/87892ff3da92ffb5231512fb4632c2870db7e11a which should fix .form-control-color and .form-check-input use cases 🤞

@MewenLeHo or @louismaximepiton Please check this new version including 87892ff which should fix .form-control-color and .form-check-input use cases 🤞

LGTM 👌


Way to switch intents?

Is there a way to trigger/switch an intent manually?
My use case:
An intent is triggered.
Logic is performed that decides if a user has access to this particular intent.
If not, then pass the user to another intent on the alexa service and continue the interaction.

Not ATM, but this is a reasonable feature request, intents are really just functions, so we should have a documented way of calling another intent by name. Please contribute!

Still interested in this feature? It's exactly what the "this.emitWithState('Intent');" from the official node.js sdk does (https://github.com/alexa/alexa-skills-kit-sdk-for-nodejs#tips)
I will dive into the issue and hopefully send a pull requests the next days/weeks.

Yeah, this still seems totally reasonable to me. I've ended up hand-rolling something like this in most Alexa skills I've built, seems logical to somehow expose the internal list of handlers by name.

Any progress on this?

@lazerwalker what did you do to accomplish this? can you show some example code?

@sof123 I'm not exactly sure what sort of issues you're running into, but since handlers are just functions, you can just store a reference to them and call them as appropriate.
Here's a trivial example of what I was talking about:
var intents = {};

intents.intentA = function(req, res) {
    res.say("Hello");
    return intents.intentB(req, res);
}

intents.intentB = function(req, res) {
    res.say("World");
}

app.intent("intentA", {
    "utterances": ["say 'hello world'"]
  },
 intents.intentA
});

app.intent("intentB", {
    "utterances": ["just say 'world'"]
  },
 intents.intentB
});


Vue.js app TypeError only in Apple Safari

Posted on SO
I've made myself a Vue app only to find out it doesn't work on Safari. It works on Firefox, on MacOS, so it's definitely Safari - not MacOS.
App built with:

OS: Windows 10 Pro
VUE CLI: @vue/cli 4.4.1
VUE: v2.6.11
NODE: v12.16.1
NPM: 6.13.4

Errors: Object.values is not a function Error
Error message in console
Source: Source
Source file of error
I have a quick look and found the script was licensed to Google, and mentioned a provider. I use Firebase authentication, which also includes auth providers such as Google, Twitter, etc... I made a mock-up app with firebase auth providers with no problem.
If you use safari, website is hosted at https://herbievine.com
Thanks for any help.

Turns out it was a firebase function
firebase.analytics()


Problems with wmi-checks

Hi Sven,
first of all: this is a really great and awesome project and i am thankful for your effort to have an alternative now for nsclient++!
I have tested in the last days with snclient 0.13 a little bit and recognized two problems: perfdata are not available in every case (already mentioned here) and check-wmi with performance counters are not the same as used in the old days.
Can you pls take a look at it?
Expected Behavior
snClient returns pdh data done by check-wmi equivalent to checks on NSClient++
Current Behavior
snClient does return OK instead
Context (Environment)
snClient Version: 0.13 Windows 11 Pro
Detailed Description
wmi:
select PercentIdleTime from Win32_PerfFormattedData_HvStats_HyperVHypervisorLogicalProcessor where Name="_Total"
-> e.g. results in "94" which gives us the idle time
nsclient:
check_pdh -a 'counter=\Hyper-V Hypervisor Logical Processor(_Total)\% PercentIdleTime' 'warn=value>25' 'crit=value>15' 'perf-config=*' show-all
-> e.g. results in "94" which gives us the idle time
snclient:
check_wmi -a perf-config="*(unit:%)" "query=select PercentIdleTime from Win32_PerfFormattedData_HvStats_HyperVHypervisorLogicalProcessor where Name='Total'" "warn=value<25" "crit=value<15" show-all
-> results in "OK:_"
Thank you very much,
Joachim

Have you tried using PercentIdleTime instead of value in the thresholds? You also might want to adjust the top-syntax template. There are no good defaults for that in check_wmi, because the check is so generic.

I run into similar issues. We are using nsclient check_pdh to collect some special performance metrics on Windows systems. These metrics are not available in the integrated windows_exporter of snclient.
As a replacement check_wmi would do the job for us but currently it does not provide performance data in the check results.
Do you think check_pdh will find its way in to snclient? Or will it be an option to add performance output to check_wmi?
Here is an example of a query where I would like to have performance data. But in general it would be great to have the option for all check_wmi queries.
curl  -X GET \ 'https://hostname:8443/query/check_wmi?warn=AvgDiskQueueLength >&query=SELECT AvgDiskQueueLength FROM Win32_PerfRawData_PerfDisk_LogicalDisk WHERE Name&detail-syntax=%24(status) - AvgDiskQueueLength is %24(AvgDiskQueueLength)&crit=AvgDiskQueueLength >'
--header 'password: GeheimesPasswort'

btw thresholds are working for me in this example with snclient 0.18
Thank you for your great work...
Marc

It also looks like that empty-state and empty-syntax are not implemented for check_wmi in v0.18.
Any chance to get it implemented?

Thank you.. Marc

@sni Thank you for adding the perfdata and warn/crit support in 6bc26e21df1edb3bd668bc6a451e3fd618b26930.
The idea of having a macro to remove unwanted characters from the perflabel sounds great.
We are currently using check_pdh in nsclient to query windows performance counters. The metrics of check_pdh have :/ and all other sort of characters in it and we are struggling over them when trying to create queries in Grafana. We end in a quoting/escaping hell.

@mlueckert:

added perf-syntax in a7367baf06d1c0858ff6302fcabcaf4ce016986b
added generic macro regex replacement in 45c5256f07b3f9ed9d7c4d2405bea07d2e1cb855
added none-ascii replacer in de0470ade133232e1014d9012dd4fcb0b56925a6

With that you should be able to do something like check_wmi ...perf-syntax='%(key:ascii)' which removes anything except a-zA-Z0-9.
Let me know if that works for you.

@mlueckert btw, empty-syntax/state has been added with 6bc26e21df1edb3bd668bc6a451e3fd618b26930


About MIoU result

Hi, I want to compare with your BlitzNet512_COCO_VOC07+12, but I can not find the MIoU result on PASCAL VOC 2012 in your published ICCV2017. So, is it convenient for you to tell me the MIoU result. Thx.

Hi,
Here are the results for BlitzNet512 and BlitzNet300 from the Pascal VOC 2012 evaluation server.
Best,
Nikita


[REMOVAL]  Site Bleacher

Title
Site Bleacher
Removal Reason

Probably doesn't work with Firefox anymore due to (dynamic) first party isolation
Hasn't been updated in 5 years

Removal Data
No response
Association Disclosure
None
Would you like to submit a PR?
No.
Please tick the boxes

[X] You have filled out this form accurately, and to the best of your knowledge
[X] You have indicated whether or not you are associated with this project or a competitor
[X] A similar submission has not already been opened for this software/ service
[X] You have read our Contributing Guide and software requirements
[X] You agree to the Code of Conduct

Done in https://github.com/Lissy93/awesome-privacy/pull/290. Thank you!


Can't get wildcards to work

I have 2 payloads both with wildcard prompts
cargo prompts are just left as " "
n_iter: 1
batch_size: 1
steps: 20
cfg_scale: 8
width: 544
height: 960
sampler_name: DPM++ 2M Karras v2
sampler_index: DPM++ 2M Karras v2

seed: -1
subseed: -1
subseed_strength: 0
seed_resize_from_h: -1
seed_resize_from_w: -1

config
batch_size: 5
init_points: 1
n_iters: 1

I keep getting the same 1 prompt every time I start the process regardless of config batch size, as if my seed wasn't set to -1
What do I do sadge

Ok I tried like 500 different types of prompter.py setup for the last 10 hours and nothing works. Am I actually retarded?
class CardDealer:
    def __init__(self, wildcards_dir: str):
        self.wildcards_dir = Path(wildcards_dir)
        self.wildcards = {}
        self.load_wildcards()

    def load_wildcards(self):
        wildcard_files = list(self.wildcards_dir.rglob("*.txt"))
        for file in wildcard_files:
            wildcard_name = file.stem
            with open(file, "r", encoding="utf-8") as f:
                lines = f.readlines()
                self.wildcards[wildcard_name] = [line.strip() for line in lines]

    def sample_wildcard(self, wildcard_name: str) -> str:
        if wildcard_name in self.wildcards:
            content = self.wildcards[wildcard_name]
            if content[0].startswith("__") and content[0].endswith("__"):
                # If the content itself is a wildcard, recursively process it
                return self.sample_wildcard(content[0][2:-2])
            return random.choice(content)
        return wildcard_name

    def replace_wildcards(self, prompt: str) -> str:
        while "__" in prompt:
            start_index = prompt.index("__")
            end_index = prompt.index("__", start_index + 2) + 2
            wildcard_name = prompt[start_index:end_index]
            replacement = self.sample_wildcard(wildcard_name[2:-2])
            print(f"Replacing {wildcard_name} with {replacement}")  # Add this line for debugging
            prompt = prompt.replace(wildcard_name, replacement, 1)
        return prompt

Like this.
Is the problem elsewhere? I don't get it

Ok I think it works, but I can't get the tags that are used to show either during the process or in the metadata, but whatever, the images I get seem to be using wildcards. Used this
import os
import random
import re
from dataclasses import dataclass
from pathlib import Path
from typing import Dict, List, Tuple
from omegaconf import DictConfig, ListConfig, OmegaConf

PathT = os.PathLike

class CardDealer:
    def __init__(self, wildcards_dir: str):
        self.wildcards_dir = Path(wildcards_dir)
        self.wildcards = {}
        self.load_wildcards()

    def load_wildcards(self):
        wildcard_files = list(self.wildcards_dir.rglob("*.txt"))
        for file in wildcard_files:
            # Use relative path from wildcards directory
            relative_path = file.relative_to(self.wildcards_dir)
            # Replace slashes with underscores
            wildcard_name = str(relative_path).replace("/", "_").replace(".txt", "")
            with open(file, "r", encoding="utf-8") as f:
                 lines = f.readlines()
                 self.wildcards[wildcard_name] = [line.strip() for line in lines]

    def sample_wildcard(self, wildcard_name: str) -> str:
        if wildcard_name in self.wildcards:
            content = self.wildcards[wildcard_name]
            if content:
                # Randomly choose a line from the content
                return random.choice(content)
        return f"__{wildcard_name}__"  # Return the original wildcard if not found

    def replace_wildcards(self, prompt: str) -> str:
        chunks = re.split("(__\w+__)", prompt)
        replacements = []
        for chunk in chunks:
            if chunk.startswith("__") and chunk.endswith("__"):
                # This is a wildcard
                replacement = self.sample_wildcard(chunk[2:-2])
                replacements.append(replacement)
            else:
                # This is not a wildcard
                replacements.append(chunk)
        return "".join(replacements)

def assemble_payload(defaults: Dict, payload: Dict) -> Dict:
    for k, v in defaults.items():
        if k not in payload.keys():
            payload[k] = v
    return payload

def unpack_cargo(cargo: DictConfig) -> Tuple[Dict, Dict]:
    defaults = {}
    payloads = {}
    for k, v in cargo.items():
        if k == "cargo":
            for p_name, p in v.items():
                payloads[p_name] = OmegaConf.to_container(p)
        elif isinstance(v, (DictConfig, ListConfig)):
            defaults[k] = OmegaConf.to_container(v)
        else:
            defaults[k] = v
    return defaults, payloads

@dataclass
class Prompter:
    cfg: DictConfig

    def __post_init__(self):
        self.load_payloads()
        self.dealer = CardDealer(self.cfg.wildcards_dir)

    def load_payloads(self) -> None:
        self.raw_payloads = {}
        defaults, payloads = unpack_cargo(self.cfg.payloads)
        for payload_name, payload in payloads.items():
            self.raw_payloads[payload_name] = assemble_payload(defaults, payload)

    def render_payloads(self, batch_size: int = 0) -> Tuple[List[Dict], List[str]]:
        payloads = []
        paths = []
        for p_name, p in self.raw_payloads.items():
            for _ in range(batch_size):
                rendered_payload = p.copy()
                processed_prompt = self.dealer.replace_wildcards(p["prompt"])
                rendered_payload["prompt"] = processed_prompt
                paths.append(p_name)
                payloads.append(rendered_payload)
        return payloads, paths


Upcoming updates to this package

Upcoming updates to this package
Hello everybody!
Thanks to @ascoders I've become a maintainer for this repo and related repo react-native-image-viewer
I have some free time now to go through issues and provide some fixes/features. I will spend around 2 hours each day working on this project, hopefully bringing it to a better shape by June.
Rough idea for the current major version of this package is:

[X] Update tooling (e.g. adopt ESLint since TSLint is deprecated, as well as other devX improvements)
[ ] Go through PRs
[ ] Go through Issues looking which ones make sense to implement, address questions, fix bugs, etc.
[ ] Incorporate changelog
[ ] Update documentation
[ ] Maybe make better demo project to test things out + some automated tests

All backwards-compatible changes will be released under 2.2.x version.
After that work is done I'd like to go away from class-based component to functional component + hooks since it is the modern (and the future) way to write React and it is also easier to read and reason about code. Especially for "small" components like this one.
But I'd suggest to leave it for future major release 3.x.x since even though it probably gonna be backwards-compatible it would be a nice way to mark the point in time for this kind of major refactoring step (we might also plug in some non-backwards-compatible stuff at this point too).
Let's use this issue as a discussion topic.
I will also update this top comment with the progress status:
13.05.2020
Made a cleanup branch for basic cleanup (ESLint, dependency updates, etc.)
15.05.2020

Improved demo app to test things out (+repaired it, it was broken due to old expo version).
Refactored deprecated methods
Merged/adopted some PRs

P.S. I know it sounds like a big update and you want to run npm update react-native-image-pan-zoom already, but please be patient, since I can't work all day on this some updates can take a bit of time before they reach npm.

Sounds great!
I'd love to see Prettier 2.0 thrown in as part of basic tooling cleanup/update.
As for the road map it looks ok. Maybe it would be worth to consider if rewrite to react-native-reanimated + react-native-gesture-handler makes sense for a major future release.

@ascoders I've made a cleanup PR #130 with some non-breaking changes and small improvements (no big new features). Feel free to review if you have time.
But most importantly, I can't publish new versions on npm, so what should we do about that? I can ping you here when I think there are enough fixes to publish a new version, but I'm not sure how often you check this repo. If you could give me, this is my npmjs user profile - https://www.npmjs.com/~artemkolichenkov
Have no idea how to share permissions though. But I'm fine with you publishing it if you can check here once in a while.
Also it would be nice to install allcontributors bot to this repo to put people's names on Readme. I don't think I can do it for this repo, would be nice if you could do that :)

@ArtemKolichenkov thanks for your work! You have been given npm collaborator for these two packages. And allcontributors has been installed to this repo.

UPDATE: Released version 2.1.12 to npm Read release notes here

Small "update" - haven't been able to work for the last couple of days on this repo, will continue now, sorry for the lack of action.

Hi again!
I was quite busy since my last comment, had to move and change job this summer. Today is my last day at current job btw so I will have some time and energy to come back to this repo 🙂
Again sorry for delay.


Move IPFS adder/getter to separate node

Problem
Currently IPFS add/get service exported by ipfs_channel node:
https://github.com/airalab/robonomics_comm/blob/master/ipfs_common/src/ipfs_common/ipfs_channel.py#L75
Proposal
It wold be better to run IPFS adder/getter as separate ROS node.

Closed in #109


Feature documentation

Fix AB#308

Azure is pulling a shallow clone which will not work.  Adjust the Azure pipeline to do a full history clone.


🔧 Ensure components implement interfaces at compilation

Closing this one in favour of https://github.com/EinStack/glide/pull/279 because to close this one I would need to improve the structure of the project to avoid circular dependencies. This is going to be done in the referenced PR.


[Feature]: Web Resources smart match

Contact Details
@effEyeEll
Is your feature request related to a problem?
Yes
Describe the problem?
Hi @Power-Maverick,
Just kicking the typres of Web Resources smart match.  Looks really interesting. I noticed the following things that I thought might interesting to consider improving (sorry I don't have time to contribute right now!)
The smart match config file is a single XML line, if it was pretty printed then it would make it easier to understand, and would be easier to (git) merge if multiple people are working with it in git.

Provide a solution or an idea you would like to see in the tool?
No response
Relevant log output
No response

Good idea 👍
Will check the feasibility

Couldn't find any method to invoke the default formatter when the file is created. Have asked the question here. Let's see if I get any good response.
In the meantime, you can right-click and select format before checking-in the file.

I had a quick view of the code.  Is a JSON object being converted to XML using jsonToXML ?
https://github.com/Power-Maverick/DataverseDevTools-VSCode/blob/f60b211f3351e30b0d6b1c37ce4780d60a736669/src/utils/Parsers.ts#L18
if so then setting format: true might do the trick.
https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/docs/v4/3.XMLBuilder.md#format

You are a lifesaver. I totally forgot about that method

This should be released in v2.0.8


⚠ SceneTime has degraded performance

In a7153c8, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 2060 ms

Resolved: SceneTime performance has improved in f8c0415 after 6 minutes.


Access function args in @Span decorator

First of all ,thanks for the great library! Its been a joy to work with so far
One pattern that I have noticed myself duplicating almost everywhere is this
  @Span('DocumentsService.create')
  async create(userId: string, orgId: string, dto: CreateDocumentDto) {
    this.traceService.getSpan().setAttributes({
      orgId,
      userId,
      dto: JSON.stringify(dto),
    });
// --- snip

Where I annotate a function with Span, and then immediately set the function args into the span attributes.
Question
Is it possible with reflect-metadata to roll that code into @Span , maybe something like this
@Span('DocumentsService.create', ['userId', 'orgId', 'dto'])

Where users have to explicitly set the fields they want to attach to attributes
I am used to this in rust, but I'm not sure if the TS compiler is capable of something like that

Hey! this is a reasonable ask, PRs are welcome.


Prevent animated custom emoji from continuously animating in the right sidebar

This is similar to https://github.com/zulip/zulip/pull/18623, but with a key distinction: Because we already process animated custom emoji in resize_gif in zerver/lib/upload.py, we have more flexibility about how to manage these than we do with linked GIFs.  Here's a specific proposal:

We modify resize_emoji to return a tuple, including an is_animated boolean and if true, a still_image version of the animated emoji (with just the first frame) that thus does not animate, which would be uploaded by the image processing code path.
We potentially extend the realm_emoji upload code path to return
upload_emoji_image should return is_animated to its caller
We store that in a new boolean is_animated field in the RealmEmoji database table.
We extend the API to include a still_url field for RealmEmoji objects if is_animated is True. I'd expect that to just call get_emoji_url passing a new still=True parameter that returns the still image URL rather than the default URL.
We then do the webapp frontend change to make clients that see an emoji with a still_url property can render the still URL for the image with an on-hover behavior to instead display the animated GIF URL.

Tagging as high priority and a release goal for 5.0, since the addition of emoji in statuses makes this important.

Note that animated PNGs are also a thing.

And “static” is confusing; the opposite of “animated” is “still”.

Yeah, "still" sounds much better.

@zulipbot claim

The PR for this (#19563) is awaiting a review!


STORY: Validate multiple values for ORIS code

Definition of Ready

[x] Does this meet the INVEST criteria?
[x] Does this have a clearly defined user?
[x] Does this have an estimate?
[x] Does this have acceptance criteria?
[x] Does this have sufficient context (wireframes, business rules, etc.)?
[x] Is this traceable to a feature, epic, or PI?

User Story
As a CAMPD user I want to enter valid filter criteria for multiple ORIS codes so that I can see results for multiple ORIS codes in one query
Acceptance Criteria
Given a user has entered an invalid parameter for ORIS code
When the error message is displayed
Then the error messages contain a url to the end point to find the correct data
One or more ORIS codes are not valid. Refer to the list of available ORIS codes for valid values [placeholder for link to Facilities endpoint] fv-9
Context
Send valid and invalid values
Validate the values
If ANY invalid value, give error message for each invalid value and query stops
If ALL values are valid, return results
NOTE: Need confirmation from Travis L and EPA on error message format
Data Elements
Query results will include:
STATE | FACILITY_NAME | ORISPL_CODE | UNITID | OP_DATE | OP_HOUR | OP_TIME | GLOAD (MW) | SLOAD (1000lb/hr) | SO2_MASS (lbs) | SO2_MASS_MEASURE_FLG | SO2_RATE (lbs/mmBtu) | SO2_RATE_MEASURE_FLG | NOX_RATE (lbs/mmBtu) | NOX_RATE_MEASURE_FLG | NOX_MASS (lbs) | NOX_MASS_MEASURE_FLG | CO2_MASS (tons) | CO2_MASS_MEASURE_FLG | CO2_RATE (tons/mmBtu) | CO2_RATE_MEASURE_FLG | HEAT_INPUT (mmBtu) | PRIMARY_FUEL_INFO | SECONDARY_FUEL_INFO | UNIT_TYPE_INFO | SO2_CONTROL_INFO | PART_CONTROL_INFO | NOX_CONTROL_INFO | HG_CONTROL_INFO| PRG_CODE_INFO| ASSOC_STACKS
Testing
Test Case:  TC103
Tester:  @davidkwartler
Definition of Done

[x] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[x] Has the code been unit tested and peer reviewed?
[x] Have the functional tests been executed?
[x] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Has the user story been accepted by the Product Owner?
[x] Is the user story ready to be deployed to the staging/integration environment?

Pull Request

Updated paramsDTO to validate multiple orisCodes
Updated IsOrisCode
Added getFacApi() to ApiConfigService
Removed unused imports

TC103 passed @tlageman-epa


Add wildcard selector method to dbt docs

Contributions

[X] I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates
https://docs.getdbt.com/reference/node-selection/methods
What part(s) of the page would you like to see updated?
The "wildcard" method
The wildcard method can be used to select a model using unix-style wildcard expressions evaluated against the fqn.
See fnmatch reference for syntax.
# These are equivalent
dbt run --select 'wildcard:*_model_?'
dbt run --select some_model_a some_model_b some_model_1

# So are these
dbt run --select 'wildcard:*_feature_model_[1-3]'
dbt run --select test_feature_model_1 new_feature_model_2 ml_feature_model_3

Additional information
I have a PR I am opening in dbt-core now. I will post its link for reference.
This PR is not relevant until the attached PR is merged.
https://www.notion.so/dbtlabs/dbt-Core-v1-5-docs-a2ae11be77bf47629f85faf7a3f27991

This becomes relevant after this is merged, tagging it for tracking purposes:
https://github.com/dbt-labs/dbt-core/pull/6599

Thanks so much for opening this issue, @z3z1ma! I labeled this for 1.5 but let us know if it's available sooner.

@runleonarun the PR connected to this documentation change was merged 🎉
Some small changes. The wildcard: is no longer needed as a prefix as the functionality is baked into the default selector. Furthermore all string based (ie. non status based) selectors have the functionality enabled. The list can be seen below.
FQN
Tag
Source
Exposure
Metric
File
Package
TestName

Here is a markdown table to include describing the syntax. My recommendation is a note in all the above selectors that points to a specific section in the documentation containing this table.

Wildcard
Description

*
matches any number of any characters (including none)

?
matches any single character

[abc]
matches one character given in the bracket

[a-z]
matches one character from the range given in the bracket

cc @jtcohen6 @dbeatty10 for visibility/input (if nothing else) since they both grokked the issue through its lifecycle.

Thanks so much for lettign us know, we have this in the queue to be documented! cc @matthewshaver


Creating MySQL configuration using URLParser

Hi,
It seems that there is no way of creating a mysql configuration for 'AsyncMySQLStorage' using URLParser. Looking at the code, you use 'ParserURL.parse' which only matches on postgresql connection urls. There should either be a way of creating a new configuration by supplying it a connection string directly or by creating a configuration by parsing a connection string via URLParser just like with postgresql.

There is a pull request that adds this: #178 - I'm also interested in getting this into develop. :)

This issue can be closed, #178 has been merged.


Fixed the logging property in config.yaml.example

When uncomenting and using logging,
the level of handlers, file, logger, logger.handlers is not correct.
So, configuration error occur.
Fixed the level of problematic settings.

Merged into elastalert2.


同步公有云资源创建时间

这个 PR 实现什么功能/修复什么问题:
同步公有云资源创建时间
是否需要 backport 到之前的 release 分支:

release/2.8.0

/cc @swordqiu @Zexi @tb365 @wanyaoqi @yousong

/cherrypick release/2.8.0

Codecov Report

Merging #535 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #535      +/-   ##
=========================================
- Coverage    7.42%    7.4%   -0.03%
=========================================
  Files         345     345
  Lines       54279   54301      +22
=========================================
- Hits         4031    4020      -11
- Misses      49872   49904      +32
- Partials      376     377       +1

Flag
Coverage Δ

#aFlag
7.4% <0%> (-0.03%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/compute/models/guests.go
0.67% <ø> (ø)
:arrow_up:

pkg/util/ucloud/eip.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/disks.go
0.78% <0%> (-0.01%)
:arrow_down:

pkg/util/esxi/vdisk.go
0% <0%> (ø)
:arrow_up:

pkg/util/esxi/virtualmachine.go
0% <0%> (ø)
:arrow_up:

pkg/util/ucloud/disk.go
0% <0%> (ø)
:arrow_up:

pkg/util/aws/instance.go
0% <0%> (ø)
:arrow_up:

pkg/util/aws/eip.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/elasticips.go
1.55% <0%> (-0.01%)
:arrow_down:

pkg/util/aws/disk.go
0% <0%> (ø)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409e8cf...924181b. Read the comment docs.

/cherrypick release/2.9.0

/approve
/lgtm


train.py:44-49: Train model on target columns instead...

The puzzle 45-34bf1ac1 from #45 has to be resolved:
https://github.com/h1alexbel/samples-filter/blob/7d238e9db3b17a4e9dc4af256e1eeeab09e7adb2/model/train.py#L44-L49
The puzzle was created by @rultor on 24-Apr-24.
Estimate: 60 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Let's try these strategies:

build single text input from all column values and feed it to the model: input=repo is  $full_name, description: $description, topics:  $topics;
train model on multiple columns: full_name, description, topics and probably readme

The puzzle 45-34bf1ac1 has disappeared from the source code, that's why I closed this issue.


GooglePlayGames not signed using an Apple submission certificate

Since the itunesconnect interface changed I can't submit any update of my app. Here is the error I am getting:
ERROR ITMS-9000: "Missing or invalid signature. The bundle 'com.google.GooglePlayGames' at bundle path 'Payload/IOSLauncher.app/GooglePlayGames.bundle' is not signed using an Apple submission certificate."
I've tried to update RoboVM, revoke and create new certificates/Provisioning profiles but nothing changes.
Any idea on why is this happening?

Nice and addictive game !
Do you know if this workaround still works with le latest versions of libgdx, robovm, robovm-bindings and GPGS ?
My problem is that if I delete the binary "GooglePlayGames.bundle/GooglePlayGames", the Robovm exportation fails with this error message : [ERROR] ld: framework not found GooglePlayGames.
Thanks in advance for advice.

It was still working for me some month ago.


Can't run kadenze-dl (ERROR)

Hi!
I can't run kadenze-dl.py, as I get the following error:
Traceback (most recent call last):
  File "kadenze-dl.py", line 1, in <module>
    from kadenzeclient import KadenzeClient
  File "/Users/mactobe/Downloads/kadenze-dl-master/kadenze-dl/kadenzeclient.py", line 4, in <module>
    from robobrowser import RoboBrowser
  File "/Users/mactobe/anaconda3/envs/kadenze/lib/python3.6/site-packages/robobrowser/__init__.py", line 3, in <module>
    from .browser import RoboBrowser
  File "/Users/mactobe/anaconda3/envs/kadenze/lib/python3.6/site-packages/robobrowser/browser.py", line 8, in <module>
    from werkzeug import cached_property
ImportError: cannot import name 'cached_property'

Any idea what might be and how can I solve this??

Hi, sorry for the delay, it seems that I missed the issue notification :(
Thanks for reporting the issue, it seems that a transitive dependency (Werkzeug)broke a library I use.
I pinned the version in requirements.txt, so you just have to update by running pip install -r requirements.txt

Thank you!


activation

currently the activation is split up into 2 steps, first DDIC, then code, what happens if DDIC refers to eg a class?

not supported, dont have any ideas on how to fix
workaround is to add the ddic objects as types in a class


configurations using the same pid are not updated properly

Fixed an issue whereby re-using a configuration pid did not cause the configuration to be sent to the ManagedService/ManagedServiceFactory correctly.

Codecov Report

Merging #754 (b9a0611) into development (c141557) will decrease coverage by 11.04%.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff                @@
##           development     #754       +/-   ##
================================================
- Coverage        89.90%   78.85%   -11.05%
================================================
  Files              231      107      -124
  Lines            13863     4682     -9181
================================================
- Hits             12463     3692     -8771
+ Misses            1400      990      -410

Impacted Files
Coverage Δ

framework/src/util/SharedLibraryException.cpp
0.00% <0.00%> (-100.00%)
:arrow_down:

framework/include/cppmicroservices/Framework.h
0.00% <0.00%> (-100.00%)
:arrow_down:

util/include/cppmicroservices/util/DataContainer.h
0.00% <0.00%> (-100.00%)
:arrow_down:

...ramework/include/cppmicroservices/FrameworkEvent.h
0.00% <0.00%> (-100.00%)
:arrow_down:

...mework/include/cppmicroservices/GetBundleContext.h
0.00% <0.00%> (-100.00%)
:arrow_down:

...mework/include/cppmicroservices/ServiceReference.h
0.00% <0.00%> (-100.00%)
:arrow_down:

.../include/cppmicroservices/SharedLibraryException.h
0.00% <0.00%> (-100.00%)
:arrow_down:

framework/include/cppmicroservices/Any.h
0.00% <0.00%> (-93.00%)
:arrow_down:

...ork/include/cppmicroservices/detail/CounterLatch.h
5.88% <0.00%> (-87.67%)
:arrow_down:

util/include/cppmicroservices/util/MappedFile.h
0.00% <0.00%> (-83.34%)
:arrow_down:

... and 209 more


feat(prettier): trim spaces when printing hardline

Current dependencies on/for this PR:

main

PR #1531   👈

PR #1532

This stack of pull requests is managed by Graphite.

Merge activity

Nov 24, 4:05 AM: @Boshen started a stack merge that includes this pull request via Graphite.


How to edit components?

E.g. I want to change navbar / footer / link colors. I am not aware on how I could do such a thing?

Yeh - we should be able to override the classnames of components - i'm stuck because the Carousel has a fixed height..

Right now you can customize it only using the theme support. We are planning to give access to the className property again, but still, need to decide how it is going to work along with the theme support.
I'm closing this one, since it is already a "in progress" discussion that will lead for a implementation task in the future.

@rluders I have one last question about this.
The docs say that the theme is an experimental feature that might potentially change.
Is that notice up to date or is theming still a WIP?


URGENT: Broken link on download page

The page
https://libcloud.apache.org/downloads.html
contains the link:
sha256
This does not work; it should be
sha256
Please fix this urgently

This should now be fixed.
Thanks for reporting and sorry for the delay.


Fail when badge is not created

The action was not failing when the authorization was not set.  As well when used in a matrix causes concurrent updates of the gist, causing a 500 response code.
The action should fail when the badge info was not success full updated

Thank you very much for this fix!


ci: microk8s version bump 1.21->1.22

Change to be able to test training-operator 1.5.0 in microk8s 1.22
Merge after #30

Change to be able to test training-operator 1.5.0 in microk8s 1.22

I know you like training-operator, but I think we are in the wrong repo here :)


json output

hi,
it would be great if gb would support json output. if you have a IDE and want to call gb build you have to parse the output with regex's or something to get structured feedback.
the oracle tool supports a -format flag for it's output. It would be great for gb to have something similair so it would be much easiear to call gb from other tools.

What kind of output would you like to see ? Under normal operation gb
outputs the name of the package being compiled to standard out and
everything else to stderr.
On Tue, Jun 9, 2015 at 3:17 PM, Ulrich Schreiner<EMAIL_ADDRESS>wrote:

hi,
it would be great if gb would support json output. if you have a IDE and
want to call gb build you have to parse the output with regex's or
something to get structured feedback.
the oracle tool supports a -format flag for it's output. It would be
great for gb to have something similair so it would be much easiear to
call gb from other tools.
—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/196.

it would be great to have a struct of severity, package, file, linenumber and message. I think you are simply calling go build. but as i read in your posting (http://dave.cheney.net/2015/06/09/gb-a-project-based-build-tool-for-the-go-programming-language) you want to address the compiler message to hide the $GOPATH and $GOROOT outputs.
in an IDE you always need this information to jump to exact the location where the error occured. so if you will parse the output of go build it would be great to have the option to print it out in a structured way.

@ulrichSchreiner thanks for logging this issue.
The compiler currently generates this output on a per line basis, this isn't something gb is involved in.
lucky(~/example-gsftp) % gb build
cmd/gsftp
FATAL command "build" failed: # /home/dfc/go/pkg/tool/linux_amd64/compile -p cmd/gsftp -pack -o /tmp/gb276539104/cmd/gsftp/main.a -I /tmp/gb276539104 -I /home/dfc/example-gsftp/pkg/linux/amd64 -complete src/cmd/gsftp/main.go: exit status 2
src/cmd/gsftp/main.go:157: no new variables on left side of :=
src/cmd/gsftp/main.go:157: cannot assign os.FileInfo to f (type *sftp.File) in multiple assignment
src/cmd/gsftp/main.go:161: undefined: fi in fi.Name
src/cmd/gsftp/main.go:161: undefined: fi in fi.Size
src/cmd/gsftp/main.go:161: undefined: fi in fi.Mode

It would be possible to process the output from the compiler, but a IDE could equally do the same job.
I have to be honest with you that this isn't something that I can prioritise at the moment, but if you were prepared to commit to maintaining this feature, I would accept patches for it.


Add LLM App to Readme.md

Add LLM App to Readme.md.

@gaocegege I hope this looks fine:) Thanks!

Should be alphabetical!

Thanks @strickvl! Now I fixed it. Ah, I see there is a conflict.

@strickvl I guess your commits were also mixed with mine now. I moved to clean PR my change now:
https://github.com/tensorchord/Awesome-LLMOps/pull/87


chore: bump version

Proposed changes

This PR bumps version to 0.3.0 and will match incoming 0.3.0-arduino tag.
see #65  for more info.
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (improve a current implementation without adding a new feature or fixing a bug)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Build (changes that affect the build system)
[ ] Docs (documentation only changes)
[ ] Test (adding missing tests or fixing existing tests)
[x] Other... Please describe:

Checklist

[x] I have read the CONTRIBUTING documentation
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.
If no reviewer appears after a week, a reminder will be sent out.

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   87.82%   87.82%
=======================================
  Files          29       29
  Lines         805      805
=======================================
  Hits          707      707
  Misses         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a5798...5aa74f6. Read the comment docs.

@sleepdefic1t The ci/circleci: build-linux-clang-5 job is failing as of 3c09e61ca41fd6fe2c7ac03b1d4db4b24e352b74. Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!


FEAT: styling design system.

Add SASS Boilerplate
Include SASS compile command in make file.

It seems like the templ's inbuilt CSS still needs a bit of work for us to use, so I've opted for using SASS over just writing regular CSS. This will help keep our design system and styles organized.
The build step is only used locally, and we can generate a nice, performant, minified stylesheet on our machine.
Since we already have to locally generate the templ files, I don't think it's the end of the world to add just one more command when running the project locally—and we get all the benefits of SASS 😄.

Just an extra comment- I've my personal boilerplate of SASS partials. I always find this a good starting point for projects, but once we have a solid design in place I will reorganise.


Question: Custom messages per rule and field

Versions:

VueJs: 2.5.16
Vee-Validate: 2.0.9

Assumptions

Vue SSR
I have an input component
Scoped form

Question:
How would I do the following?
I'm trying to make the required message for firstName be:
Please enter your first name.

and for city:
Please enter the city.

Steps To Reproduce:
So far I have:
const dictionary = {
  en: {
    messages: {
      required: (field) => {
        if (field === 'firstName') {
          return `Please enter your ${field}.`
        } else if (field === 'city') {
          return `Please enter the ${field}.`
        }
        return `Please enter a ${field}.`
      },
    },
  },
}

Object.keys(veeRules).forEach(k => Validator.extend(k, veeRules[k]))
Validator.localize('en', veeEn)
Vue.use(VeeValidate, { inject: false, dictionary })

But this doesn't seem correct.

You could assign specific error messages to specific fields:
const dictionary = {
  en: {
    custom: {
      firstName: {
         required: 'Please enter your first name.'
      },
      city: {
        required: 'Please enter the city.'
      }
    }
  }
}

Object.keys(veeRules).forEach(k => Validator.extend(k, veeRules[k]))
Validator.localize('en', veeEn)
Vue.use(VeeValidate, { inject: false, dictionary })

Hi @logaretm I'm trying this out but I keep getting: "Can't find variable: veeRules". I'm obviously doing something wrong. Please can you give me pointers?

@elujoba I know that you fixed it, but more info is here: https://github.com/baianat/vee-validate/issues/1329

@logaretm Thanks a million!


Add analysis groundwork for capabilities

this includes the majority of the work necessary for capability support in analysis
as far as concrete syntax goes, currently only with-capability is supported, but require-capability and compose-capability should follow pretty quickly
this uses a stack for tracking capabilities (unlike the current concrete implementation), which allows calling with-capability inside of a defcap with correct semantics

/cc @slpopejoy

FYI I added a few more docstrings to Pact.Analyze.Types.Capability.


Could I use GPUimage to export movie from image sequence?

Could I use GPUimage to export movie from image sequence?

There's nothing built into the framework for this, but you might be able to add custom capabilities to do so. I'd gladly accept that as a pull request.


Moved model free designs to core.initial_designs package

Issue #, if available: #219
Description of changes: As agreed upon in the issue, moved model_free designs to core.initial_designs package
Documentation update is coming in a separate PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks @mmahsereci , good fixes indeed. all done

Codecov Report

Merging #259 into master will increase coverage by 0.01%.
The diff coverage is 92.1%.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   90.02%   90.03%   +0.01%
==========================================
  Files         114      114
  Lines        3628     3634       +6
  Branches      403      403
==========================================
+ Hits         3266     3272       +6
  Misses        282      282
  Partials       80       80

Impacted Files
Coverage Δ

...mukit/experimental_design/acquisitions/__init__.py
100% <ø> (ø)

...ukit/benchmarking/loop_benchmarking/benchmarker.py
0% <0%> (ø)
:arrow_up:

...experimental_design/acquisitions/model_variance.py
100% <100%> (ø)

emukit/experimental_design/__init__.py
100% <100%> (ø)
:arrow_up:

...it/experimental_design/experimental_design_loop.py
95.83% <100%> (ø)

emukit/core/initial_designs/latin_design.py
90% <100%> (ø)

...imization/acquisitions/max_value_entropy_search.py
87.27% <100%> (ø)
:arrow_up:

...imental_design/acquisitions/integrated_variance.py
88% <100%> (ø)

emukit/core/initial_designs/__init__.py
100% <100%> (ø)

emukit/core/initial_designs/random_design.py
100% <100%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b026e88...9a1b375. Read the comment docs.


The Challenges of Migrating 150+ Microservices to Kubernetes below it  [watch video] button

This is a Feature Request
On clicking the the middle button of mouse on watch video , the video should open on another tab.
Why is this needed
because any individual can go through the web page and listen the video

/triage needs-information

Page related to issue: https://kubernetes.io/ (Homepage)
/language en

it is good to open in a modal popup window, Even though if it is opening in separate tab you can't read content and watch video at the same time

but they can listen and take a overview at the same time!!!

/retitle Add ability to open video in new tab for enhanced multitasking browsing experience

IMO opening links in new tabs can cause confusion for users who are used to links opening in the same tab, disrupting their browsing flow and making it difficult to track their navigation history. Moreover, it can negatively impact the performance of devices with limited system resources, as each new tab consumes additional memory and processing power. Also, we should keep in mind the user experience on mobile devices.

/remove-triage needs-information
/area web-development

hey dipesh its ankush myself as a beginner can you guide me in this project
i wanna contribute
On Wed, Jun 14, 2023 at 4:30 PM Dipesh Rawat @.***>
wrote:

/remove-triage needs-information
/area web-development
—
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/issues/41633#issuecomment-1590971553,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5ZZTMVLZPR3JPIIIRIQAXDXLGKTHANCNFSM6AAAAAAZF6MKZY
.
You are receiving this because you authored the thread.Message ID:
@.***>

/priority awaiting-more-evidence

because any individual can go through the web page and listen the video

this is already possible


🐛 Bug Report — Runtime APIs Error: "In-Reply-To does not match original Message-ID" for MS Outlook emails

Send an email to a CF worker from a MS outlook client and try to reply using the email's Message-ID. This happens with the exact same code from the docs, and then you'll find the following error:

Error: In-Reply-To does not match original Message-ID

I can confirm that prepending a line break to ms outlook message_id's fixes the issue, but it's still a bug.
reply_msg.setHeader('In-Reply-To', `\n ${msg.headers.get('Message-ID')}\n`) // notice the \n

Here is an example message-id that fails
Message-ID:
<EMAIL_ADDRESS>
This  comes from the actual source of an email sent by ms outlook. It looks like there's some line folding that is happening. I'm guessing that on the cloudflare end of things, the string is being compared to the original message exactly. However, the header.get method returns the header value without the folding.
I think the email specs allow folding but that the unfolded text should be treated as one line.

@edevil where should this be directed?

To me. :) I'll create an internal ticket to track this.

Hey @asimpletune, mind testing it again, please?

Hey @edevil , just tested. message-id works, thanks, but there's a new problem now.
The new issue is headers that are folded now are similarly rejected.
Two problems with this:
1.) it doesn't conform to spec, as folding whitespace is supposed to be disregarded.
2.) anyone who has folded headers now has a broken email worker.
I checked and that's now the case for one of my services.
Here's a link to the rfc5322 spec.
I also have a simple email parser that I wrote. While the code of that project is probably not helpful for this, what may be helpful is the grammar written in EBNF notation.
Probably the simplest way to fix it is just remove any folding whitespace from both emails's headers (the original and the reply) and then do the check.


Django-messages messages_inbox_count template tag not working as expected

1.pip install django-messages
2.added 'messages', to INSTALLED_APPS
3.added django-messages 'messages.context_processors.inbox', context processor to
TEMPLATES = [
{
'BACKEND': 'django.template.backends.django.DjangoTemplates',
'DIRS': [os.path.join(BASE_DIR, 'templates')]
,
'APP_DIRS': True,
'OPTIONS': {
'context_processors': [
'django.template.context_processors.debug',
'django.template.context_processors.request',
'django.contrib.auth.context_processors.auth',
'django.contrib.messages.context_processors.messages',
'django_messages.context_processors.inbox',
],
},
},
]
Finally i am trying to use messages_inbox_count tag inside one of my template as follows:
Inbox ({{ messages_inbox_count }})
However, as expected this doesn't show up any inbox count on the page.

try:
{% load inbox %}
{% inbox_count %}

It's not called messages_inbox_count, just inbox_count.
If it still does not work, please try installing from the git repo instead if pypi (a new release will be uploaded in the next weeks).


Controlled Miner not working

Minecraft version & Mod Version:
Minecraft version 1.12, Mod version 1.12-1.8.4 jar and tried on 1.12-1.8.3jar
Single player or Server: Single player and multi player through Lan
Describe problem (what you were doing / what happened): We set up 2 controlled miners, one at bedrock level and one is at 65. Neither one will break blocks, they attempt to but it switches to another block before the one is working on breaks. We have tried obsidian aiot, the mattoxk, diamond pickaxe, gold and stone shovels. It seems to work the best with no tool but still doesn't break the block. With a tool it only hits the block for a second then switches, with no tool it hits until right before the block breaks then stops.
We have tried it with different size areas, different heights, white listing items and nothing changes it.  We only play on single player or multiplayer lan with the 2 of us.
Crash log (if any):
(If this is a suggestion and not a bug report, delete all this and just write your suggestion!)

Looking into this now :)

So it happens the same way in single player and lan?  The way you describe it sounds like lag which is weird. I am running it in single player right now and its fine, i will try LAN mode later.
When it 'almost' breaks the block do you get any block drops from it?

I tried it in multiplayer and had no issues.  This means it must be

Something about block protection (server settings, spawn chunks protected, something like that, maybe another mod protecting blocks)

a conflict with another mod

Do you have a full mod list along with their version numbers? The easiest way so take your entire "latest.log" file from the logs folder

After playing around with it yesterday we found the issue. We have the minecolonies mod and in the area we built our town it will not use the controlled miner above or below ground. It is working around at 130 blocks away from the town hall.

Aha yes that makes sense.  Many mods or blocks that use permissions, such as saying "other players cannot mine here" also affects blocks, so it was treating controlled miner as a player and blocking it.
Thanks for reporting this anyway! It was still a good thing to do, im glad I know!


[swift-3.1-branch] Fix for the Intents overlay on watchOS

Explanation: The deprecated initializer has never existed in watchOS, but has on iOS. Adding the static check to work around.
Scope of Issue: Fixes intents overlay compilation.
Origination: Existing issue with the overlay code.
Risk: Minimal
Reviewed By: Jordan Rose @jrose-apple
Testing: Test suite
Directions for QA: N/A

rdar://problem/30535987

@swift-ci Please smoke test

@swift-ci test


Constructing a Request for a relative URL fails

Describe the bug
I'm using vitest with happy-dom. In my application code I want to instanciate a Request from a relative URL like new Request('/api/foo'). From my perspective this should work and in my browser all works fine as expected. But creating the instance im my tests fails with:
TypeError: Invalid URL
 ❯ new URL node_modules/happy-dom/src/url/URL.ts:8:15
 ❯ Module.get src/data/api/common.ts:59:21
 ❯ src/data/api/common.test.ts:35:30

I digged a bit into the problem but can't really figure out whats going wrong. Something I noticed is that there is the Request constructor from node:internal instead of happy-dom when I print a stack trace from the URL constructor:
at new URL (file:///*******/node_modules/happy-dom/lib/url/URL.js:9:22)
at new _Request (node:internal/deps/undici/undici:5055:25)
at Module.get (/*******/src/data/api/common.ts:59:21)
at /*******/src/data/api/common.test.ts:35:30
at file:///*******/node_modules/@vitest/runner/dist/index.js:135:14
at file:///*******/node_modules/@vitest/runner/dist/index.js:58:26
at runTest (file:///*******/node_modules/@vitest/runner/dist/index.js:663:17)
at runSuite (file:///*******/node_modules/@vitest/runner/dist/index.js:782:15)
at runSuite (file:///*******/node_modules/@vitest/runner/dist/index.js:782:15)
at runSuite (file:///*******/node_modules/@vitest/runner/dist/index.js:782:15)

Switching to jsdom does not solve the issue. As well as creating a standalone script which uses happy-dom to create a Request works fine. So I think the problem lies in the integration into vitest.
Reproduction
https://stackblitz.com/edit/vitest-dev-vitest-8gdvjz?file=test%2Frequest.test.ts
System Info
System:
    OS: macOS 13.6.1
    CPU: (12) arm64 Apple M2 Max
    Memory: 14.14 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.9.0 - /opt/homebrew/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 10.1.0 - /opt/homebrew/bin/npm
    pnpm: 8.10.0 - /opt/homebrew/bin/pnpm
    bun: 1.0.7 - /opt/homebrew/bin/bun
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 116.0.5845.179
    Edge: 116.0.1938.69
    Safari: 17.1
  npmPackages:
    @vitejs/plugin-react-swc: 3.4.0 => 3.4.0
    vite: 4.5.0 => 4.5.0
    vitest: 0.34.6 => 0.34.6

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This is just how node works:
> node
new Request('/api/foo')
// TypeError: Invalid URL

Sure. But using a browser-like environment in my tests should behave as a browser, not like node?!

You don't use any environment in your reproduction. If you are using any environment, then Vitest doesn't control what variables are exposed and how they work.

My bad. I updated the reproduction to represent more my setup. And btw using the following solves my current issue:
import { Request as HappyRequest } from 'happy-dom';

// @ts-expect-error This is only a temporary fix
global.Request = HappyRequest;


Live reload with Expo / React Native

Hey, thanks for the great work!
I'm currently developing a React Native app but it feels quite painful having to clear the cache everytime I make a change (with "R" command in Expo console).
It would be awesome to have a livereload feature for development purpose. I tried with the runtime: true option in .babelrc but it does not seem to change the behavior.

I wish I could help but as I mentioned in #39 it's outside the scope of a plugin to offer that functionality. It's something babel would need to implement. Thanks for using my plugin!


Add support for add-on configuration

Currently, there is no way to provide configuration information for the add-ons. For example, if you want to change the email address from which the management console sends emails, you have to write a custom recipe that either creates the chef_ingredient resource with the right content in config or creates an ingredient_config resource with the same. This complicates the provisioning process. Ideally, the configuration for each add-on could be specified in the attributes, much like how the list of add-ons to install can be specified.

I apparently just hit this now that chef-manage is enforcing the 'accept license' thing. This just made spinning up chef-server more complicated than it needs to be.


Namespace deletion

Issue: AAH-714

AddedDeleteCollectionModal that could be used for deleting collections, namespaces and containers

With working backend for deleting namespace, I added logic for deleting namespace on UI

Namespace can be deleted only if no collections in the namespace

Delete namespace modal

Error alert if something went wrong

Success alert

Success alert is shown on the namespace list page, the flow goes like that:

DELETE namespace
If success -> redirect to namespacelist
show success alert

I have a arista namespace with a published collection. When a go to arita detail page and change a repository from pusblished to community I can try to delete it but it fails with {"errors":[{"status":"400","code":"invalid","title":"Invalid input.","detail":"Namespace arista cannot be deleted because there are still collections associated with it."}]}

Created a new component DeleteModalWithConfirm which uses DeleleModal, but already includes confirmation UI part and logic for that, this could be nice for reusing later, since all content deletion modals are same and could be reused like that :)
Fixed mentioned error by getting all namespace's repositories and checking if it has collections.
 The logic should stay in a container if possible.

Good suggestion, thanks, It really made no sense mixing collection and namespace into one delete modal, also when there's container deletion and might others in future :grin: :+1:

I will investigate that test fail more, my Chrome crashes on this local test, but in Firefox it passes normally.


Create open_redirect_onelink.yml

Description
Match messages with observed open redirect from onelink
Associated samples

Sample 1

Associated hunts

Hunt 1

/update-test-rules

created https://github.com/sublime-security/static-files/pull/222 based on test-rules results

https://github.com/sublime-security/static-files/pull/222 has been merged, should be good to start looking at test-rule results after this point

onelink.me has a much larger issue than I though.  I'm going to close this for now, it's too difficult to detect malicious use from benign.  I think a decoder will  work better, but I've also attempted to contact some security people at AppsFlyer regarding the issue as well.


EfLoW installation: Failed to acquire IP address for virtual machine

Describe the Problem
I had no issue installing several version of EFLOW on a test system but when I try it at a customer, in a plant, on a test device but in a production environment (OT network), I receive this error: Failed to acquire IP address for virtual machine
I had the issue on the GUI install (through Windows Admin Center and using the PowerShell commands.
To Reproduce
Steps to reproduce the behaviour:

Install EFLOW on a edge device in the OT network
Select External or ICS networking, doesn't matter
After a while, you receive the error message. A retry is possible when using the PowerShell method, but doesn't change the result

Expected behaviour
EFLOW installs successfully without error.
Screenshots

Windows Host OS (please complete the following information):

Edition: Windows 10 IoT Enterprise LTSC
Version: 17763
Virtual Machine: no

PowerShell output
`
[03/15/2021 12:16:51] Successfully created virtual machine
[03/15/2021 12:16:52] Querying IP and MAC addresses from virtual machine (BEMOED002-EFLOW)

Virtual machine MAC: 00:00:00:00:00:00
Failed to acquire IP address for virtual machine

[03/15/2021 12:17:46] Done.
[03/15/2021 12:17:46] Virtual machine hostname: BEMOED002-EFLOW-b283610e
[03/15/2021 12:17:46] ERROR: Could not retrieve MAC or IP address for virtual machine
[03/15/2021 12:17:46] Virtual machine may have failed to acquire an IP address.
Confirmation Required
Do you want to try a fallback to the internal default switch?
Note: This will not destroy the external switch. You can get to back to using the external switch with the command 'Connect-VMNetworkAdapter -SwitchName External -VMname BEMOED002-EFLOW' at any time
later
[Y] Yes  [N] No  [?] Help (default is "Y"):
[03/15/2021 12:21:03] Trying to associate virtual machine with the internal default switch
[03/15/2021 12:21:04] Waiting 5 seconds to allow virtual machine to acquire an IP address
[03/15/2021 12:21:09] Querying IP and MAC addresses from virtual machine (BEMOED002-EFLOW)

Virtual machine MAC: 00:15:5d:6a:42:03
Failed to acquire IP address for virtual machine

[03/15/2021 12:22:03] Done.
[03/15/2021 12:22:03] ERROR: Retry could not retrieve MAC or IP address for virtual machine (headless)
`

@FMauroy,
Could you open the Hyper-V Manager and check if the EFLOW VM has an assigned IP in the networking tab?
If no IP is assigned, could you try restarting the VM?

@FMauroy
Have a look at this issue  https://github.com/Azure/iotedge-eflow/issues/9
Sounds very similar to some of the issues we were having. The link includes a workaround for the IP issue, but you might encounter others further down the line.

@FMauroy,
It appears that the VMSwitch which the VM was attempting to use is not able to get an IP address.  On physical hardware this can be caused by a misconfigured VMSwitch that is attempting to use an inactive network connection.  I do not know the specifics of your particular hardware, but I had this occur on my Intel NUC which has two wired connections in addition to a wireless connection.  Once I configured my VMSwitch to use the port that I had connected to the network it resolved this issue for me.
Please run the following commands in an elevated PowerShell session.

Description
Command

Get Virtual Network Switches
Get-VMSwitch

Get Network Switch Details
Get-VM | Where-Object {$_.Name -like '*EFLOW'} | Get-VMNetworkAdapter

This will tell you which VMSwitch your EFLOW VM is using as well as how it is configured.  You can modify the configuration of the VMSwitch using Hyper-V Manager using Virtual Switch Manager.  If you are not familiar with Virtual Switch Manager, this is a pretty decent tutorial .
Please let us know how it goes.
Terry Warwick
Microsoft

Thanks everyone for you quick replies :-)
I double checked all connections, and didn't find anything wrong. It should have worked. So in the end, I rebooted the host, and it worked right away... Maybe Hyper-V was a bit lost and the reboot set everything straight. I should have rebooted before posting.
Regards
fred


refactor(anoncreds): master secret to link secret

Updates AnonCredsRsHolderService according to the recent changes in @hyperledger/anoncreds API and applies transformations to credential request metadata (including migration script).
There is a test that is not passing, because anoncreds-rs expects the credential definition to have a link_secret field instead of the former/legacy master_secret field (this is according to this test added recently by @blu3beri).
From my understanding, we should still be tied to master_secret in this case but AnonCreds spec is not consistent about this: in section 7.2.2., it first shows an example where link_secret is used (supposed to be based in an example in Sovrin MainNet which actually uses master_secret). And then, when describing all the fields within a Credential Definition, it states:

master_secret (also known as link secret, but kept as master_secret for backwards compatibility)

Yeah the credential definition should still use master_secret and we should fix that in AnonCreds RS and the specification

@genaris made https://github.com/hyperledger/anoncreds-rs/pull/173

@genaris https://github.com/hyperledger/anoncreds-rs/releases/tag/v0.1.0-dev.13 is cooking, after which we can merge this PR I think?

Yes, I think we'll need to update some package.json files first so yarn.lock takes this new version.


[WFLY-13635] Upgrade Apache CXF to 3.3.7

Issue: https://issues.redhat.com/browse/WFLY-13635

@jimma could you review please?

@ronsigal Please review as well as a resteasy module depends on the commons-codec and commons-lang. Thanks.

Ok, sure.
On 7/20/20 3:27 PM, Brian Stansberry wrote:

@ronsigal https://github.com/ronsigal Please review as well as a
resteasy module depends on the commons-codec and commons-lang. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wildfly/wildfly/pull/13413#issuecomment-661287728,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEDP46S6DWM2LYZ7LR4VTTR4SLB5ANCNFSM4O6WQ7YQ.

@spyrkob  Looks xmlshema is updated in cxf  : https://github.com/apache/cxf/blob/cxf-3.3.7/parent/pom.xml#L223 . We include this upgrade too ?

@jimma thanks, I missed it. Updated the PR to include it now.

I ran the RESTEasy testsuite from branch 3.14, which should go into WF 21, with commons-codec upgraded. I don't see where RESTEasy depends on commons-lang. In any case, the testsuite passed.

Thanks, @ronsigal. Sorry, my mistake re commons-lang; I thought there was a module.xml dependency but there is not.

@bstansberry, +1.

@jimma ok now?

@bstansberry  Looks good to me now.


Fix bug with datetime causing errors

Datetime appears to be causing issues for various samples/components. This seems to be related to when the milliseconds are 0

Fixed in 2.1.9


FALCON-1860 ADFProviderService should be optional as default setting

+1 Ying, will commit shortly

+1
LGTM

+1. Thanks for updating the documentation.


Add windows and mac tests on CI, add py3.9

trying out tests on windows and mac.  Will likely need some iteration on windows

just took adding a few encoding="utf-8" lines to the ome_autgen.py script to get the code generation working on windows... but it looks like everything's working now and tests are passing all around!


try/catch does not restore prior set -e value

...but rather forces -e to be unset when leaving a try block, regardless of its prior value.

Indeed, I thought about it. I left it like that on purpose, because you're not supposed to use the framework with -e set anyway (since that defeats the point of using error handling or try & catch). It's an easy fix though as it would only require capturing the flag first and setting it to the previous setting.
Feel free to file a pull request.

Solved with v2.0