dotnet process won't be kill after close nvim.

When I Open an .cs file, after Project initialization complete, 3 dotnet prcess run on background.(like below.)

After i use :qa! close nvim, it only close one dotnet process.(like below.)

Lsp Log:
[START][2024-10-23 12:33:59] LSP logging initiated
[WARN][2024-10-23 12:33:59] ...lsp/handlers.lua:625	"[Microsoft.CodeAnalysis.LanguageServer.HostWorkspace.FileWatching.DelegatingFileChangeWatcher] We are unable to use LSP file watching; falling back to our in-process watcher."

Can you try to set filewatching to false to see if that helps in this case?
Anyways, this is something I have thought about that could potentially happen, but haven't really been looking after if is happening myself yet

Hmm okay, I will try to get some time to look into this a bit more. I just wish roslyn was able to be started normally as per the lsp spec...

I can't seem to reproduce it on a windows machine. After looking through the code, isn't it related to this?
server.lua
detach = not vim.uv.os_uname().version:find("Windows"),

Setting it to true on windows keeps the dotnet alive even after exiting neovim (while also spawning a shell each time neovim is opened). I don't have a linux machine available right now to test what happens while it's kept with detach false there.

This is the documentation from detached for lsp in neovim
--- Daemonize the server process so that it runs in a separate process group from Nvim.
--- Nvim will shutdown the process on exit, but if Nvim fails to exit cleanly this could leave
--- behind orphaned server processes.
--- (default: true)
--- @field detached? boolean

I think I remember that setting it to false will block forever, but I can verify this soon. However, I don't remember why detach can not be used for windows. I think I got a PR for it explaining the reasons behind it.
I don't use windows though. I have a VM with windows I can test with, but I never really use neovim in the VM

I don't think I will do much about this for now, as I plan to switch over to using stdio as communication once roslyn supports it. There is a PR ready over at the server, which I hope will be merged some time early after the holidays.
I will keep this up until then


study the timed A := nat -> A monad

@jadephilipoom pointed me to the files TimedMonad.v and SequentialTimed.v, which simulate circuits using timed A instead of list A, where timed A is defined as nat -> A. SequentialTimed.v contains a loop definition loopSeqF with a builtin delay.
If I understood @satnam6502 correctly, he would like to define loop without a builtin delay, and put explicit delay elements inside the "body" of the loop, so I was curious to see if the approach in these two files would allow this, and made some stand-alone experimentation file based on them.
I managed to write some code that seems to create a loop without builtin delay: You can write a loop body like
Definition sample_loop_body_with_delay(inp_signal: timed (combType Nat)):
  timed (combType Nat) -> timed (combType Nat) :=
  fun sum_signal =>
    inp <- inp_signal;;
    sum <- delay sum_signal;;
    res <- add inp sum;;
    res' <- incr res;;
    res'' <- decr res';;
    ret res''.

which explicitly calls delay on sum_signal inside its body, and then you can make a definition like
Definition sum_countUp: timed (combType Nat) :=
  loop (sample_loop_body_with_delay countUp).

This looks too good to be true, so here are the (severe) limitations:

I don't actually define the loop combinator as a Definition, but as a Notation, in order to delay the termination checking to the actual usage. This also means that it can only be applied to concrete expressions for which Coq's termination checker succeeds, and it won't be possible to prove general theorems about the loop combinator.
I changed the signature of the loop body: It doesn't take an input signal any more (that seemed to have become unnecessary, but I could add it back), and instead of taking just the current state as an argument, it takes a timed State, ie the whole time series of state values.
I rely on the termination checker unfolding the loop body and (potentially) also nested definitions inside it, as well as the definition of delay, until it is convinced that the recursive calls are on structurally smaller nats. When it works, it happens all automatically, but it will be hard to debug when it doesn't, and will not scale well with bigger expressions where unfolding everything could lead to huge terms and thus huge slowdown in the termination checking.

Given these limitations, I don't think we should use such an approach, but just wanted to share this file in case someone else is about to redo similar experiments.

At first sight this looks very interesting. Let me take a closer look and see what I can do with it...

Interesting idea!
This is a special case of your disadvantage (1) but unfortunately it won't be able to be used in higher order circuits definitions that put their arguments in a loop either (as at notation time the argument will be unresolved).

Update: I managed to lift restrictions (1) and (3).
The trick is that if the loop body delays its output by at least one time step, then a fuel amount of t+1 is sufficient to simulate the loop, so the fact that we use fuel can be hidden as an implementation detail in the definition of the loop combinator.
That is, we can define loop f simply as applying f to itself t+1 times:
Definition loop{B: SignalType}(f: timed (combType B) -> timed (combType B)): timed (combType B) :=
  fun t => power_fun f (S t) (fun _ => defaultCombValue B) t.

And as an example, I made a circuit fib with two delays computing Fibonacci numbers:
      -------      -------   ---
      |delay|      |delay|   | |
  +-->|with |--+-->|with |-->|a|
  |   |init |  |   |init |   |d|
  |   |  1  |  |   |  0  |   |d|--+----->
  |   -------  |   -------   |e|  |
  |            |             |r|  |
  |            +------------>| |  |
  |                          ---  |
  |                               |
  +-------------------------------+

and proved that it behaves like the Gallina specification fib_spec.

Awesome! I'm going to take a deeper look in a minute but this sounds very promising.
Currently I think this would not work for a circuit such as loop ( swap >=> fsT delay ) (using your definition of loop), here each path has a guaranteed after two unrolls. Increasing the assumed gas would work right? Is there a way to make this work for a loop that needs an arbitrary 'n' unrolls?

FWIW I'll also push some experiments on indexed monads soon, but I think your approach is more promising if we can cover all cases.

Yeah, loop (swap >> fsT delay) would not work with this approach, and doubling the fuel in the definition of loop would fix this particular example, but I don't quite know how to best generalize it and how to adapt the loop_fix theorem...

Very cool! I think it would be okay to not deal with loops that delay different state values different amounts; those could be represented with nested loops. However, it would be good to handle loops with different amounts of delay on the state values and on the output values. The current loop signature doesn't distinguish feedback and output, if I understand correctly, which is suitably general (you can always not use all your state). However, if we add back the distinction, perhaps it would be possible to reason about a loop with different amounts of delay on the values that are and are not fed back.
One note here that might or might not help with proofs is that, if the state value is first and the output value is second, loop (x >> snD delay) is equivalent to loop x >> delay.

@jadephilipoom, are you suggesting a solution to the loop (swap >> fsT delay) example that involves nested loops and/or separating the loop body output into a "state" and "output" part? Or is your comment unrelated to that example?

@jadephilipoom, are you suggesting a solution to the loop (swap >> fsT delay) example that involves nested loops and/or separating the loop body output into a "state" and "output" part? Or is your comment unrelated to that example?

My comment is related to that example -- if I understand correctly, the problem is that the loop delays only one part of its state, so things get out of sync. But if we separate loop "state" (which is fed back to the beginning of the loop block) and loop "output" (which is not), then we can represent different amounts of delay on the state parts with nested loops and different amounts of delay on the output parts won't be a problem because we don't need to loop them back. It would also allow loops with no delay at all on the output.

if I understand correctly, the problem is that the loop delays only one part of its state, so things get out of sync.

I see another problem: In the body of this loop, there is one path that does not get delayed at all. Just to make sure we're discussing the same circuit (I used different signatures than standard Cava), here's a pic of the circuit I'm considering:

The upper input doesn't get delayed at all! Yet, this is a valid circuit, but in order to prove it, you have to put your finger one of the input wires, and follow the wire until you get back to where you started, and note that no matter where you started, by the time you get back to your starting point, you have traversed at least one delay, but this journey went through the loop body twice, and the delaysAtLeast judgment I used in this PR can't be used to prove this kind of "advanced loop body validity".

Ah, I see now! Thanks for the detailed clarification :slightly_smiling_face:
I think that this circuit can be expressed as a loop that would pass the validity check: loop (swap >> fsT delay) is equivalent to loop delay >> fork2, no? I'm not sure if it's the case that every circuit can be transformed this way, though. At any rate, this validity check, even if it would fail some valid circuits, is certainly an improvement over the delay automatically being fused to the loop.

Ah, I see now! Thanks for the detailed clarification 🙂
I think that this circuit can be expressed as a loop that would pass the validity check: loop (swap >> fsT delay) is equivalent to loop delay >> fork2, no? I'm not sure if it's the case that every circuit can be transformed this way, though. At any rate, this validity check, even if it would fail some valid circuits, is certainly an improvement over the delay automatically being fused to the loop.

I'm not suggesting we put too much effort into it, but it would be great if we could crack this case as otherwise loopy combinators will be more restrictive (and if the combinator is providing the loop it will be less clear how to do the circuit transform to a valid representation)

A simple hack might be to pass an additional nat argument to loop, with loop n body standing for "a loop whose proof that all paths contain at least one delay requires n unfoldings of the loop body", or, equivalently, "a loop whose output at time t can be correctly simulated by using a fuel amount of n*(t+1)". In the case of loop (swap >> fsT delay), for example, n would be 2. But I don't know if unfolding a loop body n times will always allow to prove validity, I think the reason why a circuit is valid can be arbitrarily complex if you have loops whose body contains a multiplexer whose selector signal represents a complicated expression?

Currently, Cava2 does not provide any loop-like combinator that does not also introduce delays and state on its own, but it seems that for the applications we're interested in right now, this feature is not needed. I still believe that if this feature is desired, the approach in this PR would be a good one to try out, but in that case it would have to be applied to the Cava2 code, so in the meantime, I'm closing this PR.


Smooth card hovering

Related Issue
Closes #749
Description

This PR makes sure that when the user hovers over the card, hovering is smooth and the content doesn't get overflow and hidden and is displayed properly.

Checklist

[x] My code adheres to the established style guidelines of the project.
[x] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

@rohansx  I have created the PR for #749

Resolve the conflicts and also mention the details about the issue you've resolved in the previous issue

@rohansx have a look now

Lgtm

Thanks, it was great contributing to this project. Looking forward for more contributions :)

@anamika7153 looking forward for ur contributions


'fixed_param_names' and 'lr_mult' behave differently

I was using the python version of MXNet on a 64-bit Ubuntu 16.04 OS.
I changed the fully connected layers in the VGG-16 network and I wanted to fine-tune it.
At first I used the 'fixed_param_names' in mx.mod.Module class and it seemed to be working very well. The accuracy was getting better and better, with a 75% accuracy at 10th epoch.
Then I saved a checkpoint at the 10th epoch, changed the module by removing the 'fixed_param_names' parameters, set the 'lr_mult' to 0 by calling 'opt.set_lr_mult()', and finally loaded the checkpoint file to continue the training process. However, the accuracy rapidly dropped to about 50% (2 classes were included in the training set.)
Here's the code segment for using 'fixed_param_names':
net, arg_params, aux_params = mx.model.load_checkpoint('../model/vgg16', 0)
name_list = [k for k in arg_params if not 'fc' in k]
mod = mx.module.Module(net, context=ctx, work_load_list=wl, fixed_param_names=name_list)
Here's the codes for 'set_lr_mult' method:
opt = mx.optimizer.Adam(learning_rate=0.001)
mult_dict = {k:0.0 for k in arg_params if not 'fc' in k}
opt.set_lr_mult(mult_dict)
mod.init_optimizer(optimizer=opt)
I understand that the 'fixed_param_names' parameter is related to 'grad_req' when calling the executor, and no memory is allocated for gradients in this way. For 'lr_mult' case, the gradients are calculated, but  are not added to the weights as the learning rate was 0.
But I guess this should only make difference in memory occupation and computation speed. The result should have been the same, as the weights are the same in both cases. Why were they different??
Maybe I was wrong in understanding the matters. Could someone help me with that?
By the way, I cannot understand the difference between 'fixed_param_names' and the 'BlockGrad' operator. I guess both of them save the memory cosuming, only that 'BlockGrad' cut off the backpropagation completely. I guess this could be implemented with 'fixed_param_names' by specifying all layers before the blocking node, right? Furthermore, if I wanted to freeze the middle part of a network while keep the rest parts trainable: {trainable parts} <-- {frozen parts} <-- {trainable parts} <--{deviation}, I guess that 'BlockGrad' would not help, but 'fixed_param_names' would function.
As the results of my training was not correct, I guess there must have been something wrong in my understanding. Would someone please help me? THX.

This seemed to be a BUG.
I placed a breakpoint in the set_lr_mult method. However, the breakpoint was never reached.
Besides, the method was implemented by setting each parameter's 'lr_mult' of self.sym.
But the 'self.sym' of the optimizer was None.

BlockGrad sets the gradient to 0, but you are still learning weight decay.
I suggest a "HowTo" label to this issue and change the subject to "How to freeze certain layers in finetune".

@precedenceguo Thanks for reply.
I found out that I did not understand the mechanism of opt.set_lr_mult() method.
The program would lookup the attributes in the whole network recursively when the 'set_lr_mult()' method was called.
If the variables did not have such attributes, nothing would be done. The weights would be updated with the original learning rate. In other words, the set_lr_mult() method took no effects.
I added the 'lr_mult' attributes to the variables in advance, and then installed the optimizer. Everything was OK then.

@back2yes I met the same issue. How can I add the 'lr_mult' attributes to the variables in advance ? In symbol, how can I implement this ? Please tell me more detailed information, thanks!

@bruinxiong Check out this comment: https://github.com/apache/incubator-mxnet/issues/8584#issuecomment-343150185.


PV production Sensor showing values at nighttime

Lately my Solarman production sensor shows values at nighttime.
Inverter: Deye 8K Hybrid
Inverter Firmware: 2005-1124-1807
HA Solarman version: v1.4.3
Logger Module Version: LSW_15_FFFF_1.092R
Logger Extended Version: v<IP_ADDRESS>F

Is there any chance to avoid this behavior?
Any suggestions are highly appreciated!

This is because it is disconnecting with the integration or something this started happening on version v1.4.3 I'm sitting with the same issue I downgraded to version 1.4.1 it resolved the issue but 1.4.1 does not work on the latest version of home assistant I also have an issue open regarding this.

It never happened with Solarman 1.4.1. as well.
Today my “Total Load Power” went nuts showing me some 65.000 Watts. 😳
Please fix this issue.

I dont know much about hassio plugins, but there should be a way to smooth data and ignore temporary spikes?

I have the same problem with Deye 12K Hybrid 3-phase inverter...

Mismo problema con microinversor
deye_4mppt 2000. No puedo utilizar para medir la produccion solar diaria, ya que me suma los datos del día anterior.


Tutorial 2a (DPM II)

Tutorial/Bug description

Checklist

[ ] All packages are in the conda environment dl2021
[ ] Pretrained models are automatically downloaded and stored at https://github.com/phlippe/saved_models / a pull request has been setup for this
[x] Notebook has badges for:

[ ] Filled notebook on github
[ ] Filled notebook on Colab
[ ] Saved models on github
[ ] YouTube recording

[x] The author names have been filled in
[x] The notebook has been added to the doc tree (docs/index.rst)
[x] All images of the notebook are included in the pull request
[x] The website was build locally once (do not commit the html files)

How Has This Been Tested?

[ ] Conda environment dl2021
[x] Local computer - CPU
[ ] Local computer - GPU
[ ] Google Colab - CPU
[ ] Google Colab - GPU
[ ] Lisa - GPU

Thanks for the pull request! In the notebook, I see that you are training the models for <3 epochs, which keeps the runtime on Colab reasonable. In other notebooks, we often provide pretrained models to keep the runtime reasonable while having fully trained models. If you want, we can also do it here, but I am also ok with sticking to the current format for your notebook.

Thanks for the suggestion. The tutorial is today and tomorrow already, so we'll stick with these, but for the next tutorial we'll consider adding pre-trained models.


Has the project been totally abandoned?

Nope, it's serves its role as a base for voice + magento integrations .If you feel like there's anything missing - feel free to contribute :)
In terms of plans for future development: we're currently working on a highly-conceptual level. While working with clients we've noticed some common patterns, especially around Google Assistant. We just need to confirm that they're generic enough to implement them in here.


Support HTML in ui_update.label for UI Text node

Description
https://discourse.nodered.org/t/non-breaking-space-is-not-treated-in-ui-update-label/92071
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

It's our intention @Subnum12, just have a big list of priorities atm, but it is on the list. Community contributions are also welcome.

@joepavitt
I will have a look at this in a couple of days from now.  First I need to finalize a tutorial that is already a long time on my todo list.

@joepavitt,
As promised, here is the pull request


Caching

Is there currently no way to add caching?

Not at the moment. What are you looking for?

Something like this https://github.com/wshirey/kong-plugin-response-cache

How do you identify responses that can be cached and for how long?

You can configure caching by headers, query string, and uri. I guess the duration would have to be set for all responses.


Error in Documentation Code

I think there some bugs in http://wagtail.readthedocs.org/en/v1.0b1/pages/streamfield.html?highlight=blocks#streamblock
At the first code example:

('carousel', blocks.StreamBlock(
    [
        ('image', ImageChooserBlock()),
        ('quotation', blocks.StructBlock([
            ('text', blocks.TextBlock()),
            ('author', blocks.CharBlock),
        ])),
        ('video', blocks.EmbedBlock()),
    ],
    icon='cogs'
))

the blocks.CharBlock need some paranthesis at the end blocks.CharBlock() and also the blocks.EmbedBlock() can't be referenced like that since wagtail.wagtailcore.blocks doesn't contain it. Since you are doing the same thing with ImageChooserBlock() and you reference it right it away, I would suggest to do the same thing with EmbedBlock().
Something like:

('carousel', blocks.StreamBlock(
    [
        ('image', ImageChooserBlock()),
        ('quotation', blocks.StructBlock([
            ('text', blocks.TextBlock()),
            ('author', blocks.CharBlock()),
        ])),
        ('video', EmbedBlock()),
    ],
    icon='cogs'
))

The same errors occure at the next code example in the documentation, in which you are demonstrating the same code in class based form. Note: Missing parenthesis at the EmbedBlock

Thanks for spotting! Do you have time to make those fixes and send us a pull request?

Sure thing :)


Add custom distro logos

Now most of the distro logos on the robbb bot are bad, some even have desktop screenshots , not logos. For example red hat.

🤔 so what's your proposed solution? if you have concrete issues with specific logos, PR a fix that sets a better one :D


feat: payload util methods

This PR intends to payload util methods and unit tests for easy interop between java maps. Supports nested maps and arrays.
Example usage:
Map<String, Object> map = new HashMap<>();
map.put("name", "John Doe");
map.put("age", 42);
map.put("married", true);

Map<String, Value> payload = PayloadUtil.toPayload(map);

Reciprocal
Map<String, Object> mapAgain = PayloadUtil.toMap(payload);

I'm a little weary of adding utility methods that don't control invariants in public packages. For example,
toPayload(Map<String, Object> inputMap) { ... }

Allows any Object entry value. Consequently,

It silently ignores types that aren't supported by Value (it could throw instead)
It throws for Maps that have entry keys other than String

With the methods in ValueFactory, it's a little more convenient to build payloads e.g.
Map<String, Value> map = Map.of(
  "foo", value("bar"),
  "baz", value(1),
  "quux", list(List.of(value(true), value(false)))
);

Do you feel strongly about supporting conversion to/from Map<String,Object> in addition? If you do, what do you think about a specialized PayloadMap type with overloaded methods for the supported types?

Great points. I too now don't see any clear benefit of using this utility with exceptions over the Map.of() usage you presented.

Closing with reference to https://github.com/qdrant/java-client/pull/11#issuecomment-1855780646.


Add array.slice() docs to Chunky Monkey description

I think it would be helpful to include a link to the Array.slice() docs here, since it's important to the solution and it's the first time it appears in a Bonfire.

It's possible to solve without slice, but I do think it's the most straightforward way to solve it and should be introduced in this sidebar. Thanks! :+1:


/live/song/get/track_names	doesn't return anything

/live/song/get/num_tracks works flawlessly, but I can't seem to get the similar /live/song/get/track_names working

``def osc_handler(*args):
n = args[-2]

if args[0] == '/live/song/get/num_tracks':

    print('Number of tracks - '+str(args[1]))
    global number_of_tracks
    number_of_tracks =  int(args[1])

elif args[0] == '/live/song/get/track_names':

    print('track_names - '+str(args))

elif args[0] == '/live/track/get/output_meter_level':
    with open("Track_"+str(n)+"_status.txt", "w") as file:
        file.write(str(args[-1]))
        file.close()

else:
    print(args[0])

used with
server_thread = threading.Thread(target=server.serve_forever).start()
disp.map("/live/track/get/output_meter_level", osc_handler)

client.send_message("/live/song/get/num_tracks", 99)
disp.map("/live/song/get/num_tracks", osc_handler)

disp.map("/live/song/get/track_data", osc_handler)
```


Fix the script path issue

Fix the path issue when generating pre-commit.sh
Using formatSourceAndFixImports

Could you please make another PR for formatSourceAndFixImports ?

😉, The plugin's been really helpful. Thank you too!


test: update k8s test versions to 1.16.13, 1.17.9 and 1.18.6

Signed-off-by: André Martins<EMAIL_ADDRESS>

test-me-please

Coverage decreased (-0.004%) to 37.234% when pulling 1ce6dfdc868d8c48bcc2a1026bf973d11ab43446 on aanm:pr/update-k8s-versions-master into f18fcd9b3d4c2d9a26f952b24f4bdae710da88ca on cilium:master.

retest-runtime

test-missed-k8s

test-me-please

Backports to v1.7 and v1.8 merged via #12668 and #12669.

And backport to v1.6 merged via https://github.com/cilium/cilium/pull/12667.


Example description position fix

Before fix example description was placed after code block in subsequent section. After fix its placed before example like in webapplication7.md

#sign-off


2018: javascript-algorithms

Thanks for your PR. The link you recommended isn't a talk on the topic of JavaScript, so it doesn't fit this project.


PHP 8.0 support

Syntax changes that require new tests to make sure the tool is compatible with PHP 8.0:

Named Arguments

[x] update existing code => integration test in #5399
[ ] new feature

Nullsafe operator

[x] update existing code => integration test in #5399
[ ] new feature

Attributes (Attributes v2, Attribute Amendments, Shorter Attribute Syntax and Shorter Attribute Syntax Change)

[x] update existing code (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5284)
[ ] new feature

Union Types 2.0

[x] update existing code => integration test in #5399
[ ] new feature

Allow ::class on objects

[x] update existing code (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5166)
[ ] new feature

Static return type

[x] update existing code (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5177, https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5184)
[x] new feature (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5177, https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5184)

Variable Syntax Tweaks

[x] update existing code
[ ] new feature

Allow trailing comma in parameter list

[x] ~update existing code~ (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5240 https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5239)
[x] new feature

Allow trailing comma in closure use lists

[x] update existing code
[ ] new feature

Mixed Type v2

[x] update existing code (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5254)
[ ] new feature

throw expression

[x] update existing code (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5232)
[ ] new feature

non-capturing catches

[x] update existing code
[ ] new feature (WIP https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5175)

Constructor Property Promotion

[x] update existing code (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5277)
[ ] new feature

Match expression v2

[x] update existing code (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5251)
[ ] new feature

Add str_starts_with() and str_ends_with() functions

[x] update existing code
[x] new feature

Add str_contains() function

[x] new feature

Deprecate curly brace syntax for accessing array elements and string offsets

[x] update existing code
[x] new feature (already implemented)

Change the precedence of the concatenation operator

[x] update existing code
[ ] new feature

Remove inappropriate inheritance signature checks on private methods

[x] update existing code
[x] new feature (already implemented)

Deprecate left-associative ternary operator

[x] update existing code
[ ] new feature

Add Stringable interface

[x] update existing code (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5166)
[ ] new feature

Date: mktime() and gmmktime() now require at least one argument. time() can be used to get the current timestamp.

[x] update existing code
[x] new feature (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5166)

Exif: Removed read_exif_data(). exif_read_data() should be used instead.

[x] update existing code
[x] new feature (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5166)

The imap_header() function which is an alias of imap_headerinfo() has been removed.

[x] update existing code
[x] new feature (already implemented)

parse_str() can no longer be used without specifying a result array.

[x] update existing code
[x] new feature (not we can do)

Calling implode() with parameters in a reverse order ($pieces, $glue) is no longer supported.

[x] update existing code
[x] new feature (already implemented)

Mbstring A number of deprecated mbregex aliases have been removed.

[x] update existing code
[x] new feature (already implemented)

Namespaced names can no longer contain whitespace (nor comments)

[x] update existing code
[x] new feature (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5264)

[x] PHP 8.0 migration rule set (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5166)
[x] PHP 8.0 integration test (tests/Fixtures/Integration/misc/PHP8_0.test) ensuring all new syntaxes are passing complex ruleset like @Symfony or @PhpCsFixer:risky) (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5399)
[x] Update ~Travis~ GitHub Actions with dedicated PHP8 job

- GMP:
  . gmp_random() has been removed. One of gmp_random_range() or
    gmp_random_bits() should be used instead.

- OCI8:
  . The OCI-Lob class is now called OCILob, and the OCI-Collection class is now
    called OCICollection for name compliance enforced by PHP 8 arginfo
    type annotation tooling.
  . Several alias functions have been marked as deprecated.

- Reflection:
  . The method signatures
        ReflectionClass::newInstance($args)
        ReflectionFunction::invoke($args)
        ReflectionMethod::invoke($object, $args)

    have been changed to:
        ReflectionClass::newInstance(...$args)
        ReflectionFunction::invoke(...$args)
        ReflectionMethod::invoke($object, ...$args)

    Code that must be compatible with both PHP 7 and PHP 8 can use the following
    signatures to be compatible with both versions:
        ReflectionClass::newInstance($arg = null, ...$args)
        ReflectionFunction::invoke($arg = null, ...$args)
        ReflectionMethod::invoke($object, $arg = null, ...$args)

Other changes that might require fixing existing tests and/or adding new ones:

[x] Object-based token_get_all() alternative
[x] Treat namespaced names as single token (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5166)
[x] Don't include trailing newline in comment token
[x] SPL: SplFixedArray is now an IteratorAggregate and not an Iterator. (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5166)

Additional source: https://github.com/php/php-src/blob/php-8.0.0rc1/UPGRADING
Note

From now we only accept PR's that are compatible with PHP8
Updating composer.json of the project will be done after all current functionality has been made compatible (new feature support can wait)
We will keep the build step nightly as allowed to fail. When there is a dedicated Travis target for PHP8 we will add it to the steps

Union Types rule should definitely support sorting to prevent !n possible orders.

Note that this issue is not about implementing new rules but making sure that existing rules do not break with new PHP 8.0 syntax changes. Nice suggestion though :+1:

these will be in PHP8 and effect us (I think)
https://wiki.php.net/rfc/class_name_literal_on_object
https://wiki.php.net/rfc/static_return_type
https://wiki.php.net/rfc/variable_syntax_tweaks

More changes to the lexer: https://github.com/sebastianbergmann/php-token-stream/issues/95.

added alias in PHP8
https://wiki.php.net/rfc/rename-double-colon-token

@SpacePossum that RFC has been rejected. Voting closed yesterday, and they failed to get a 2/3 majority (only managed 58.9%).

@GrahamCampbell can you link the RFC?  php/php-src#5182 appears to be accepted and merged (despite the closed PR status).

Would a dedicated Travis CI job for PHP 8.0 be a part of the definition of done for this issue? I know there is a "nightly builds" job, but that is different than pointing to a release of PHP 8.0 (even if it is beta).

Would a dedicated Travis CI job for PHP 8.0 be a part of the definition of done for this issue?

If Travis CI supports dedicated PHP 8.0 jobs, I would say yes.

https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5114 gets us started with some stuff. If anyone could work out why that\s not working, that'd be a help.

PHP 8.0 Wiki Page and Timetable - GA Release 11/26/2020
PHP 8.0.0RC1 Upgrade Notes

I took some time to review all the core changes in the upgrade notes and their respective RFCs. I picked out the ones that had syntax changes, or I otherwise felt might break a rule.
I created a Google Sheet to track these potentially rule-breaking changes.  Anyone can comment on this sheet. Please request edit permissions if desired:
https://docs.google.com/spreadsheets/d/1URgmC3lM34AKQmllDJlh3dmXU95EaixqowATSKFTX90/edit?usp=sharing
This is just a quick-and-dirty organization technique for myself that I thought would be useful; if there is a better place to organize this (GitHub issue?) let me know.

@hamdrew To be honest I prefer tracking PHP changes here, I updated the description. Hopefully I didn't forget anything important.

@julienfalque I agree! I removed the link to avoid confusion.
Last night I set up a PHP 8 docker environment to develop from. I share it here if anyone finds it useful: https://github.com/hamdrew/PHP-CS-Fixer-Docker
I didn't want to contribute a docker development environment directly to this project because that is a large discussion that doesn't need to happen right now.

I addressed the SplFixedArray issue first in #5167, since it was prohibiting a lot of tests from running.
@SpacePossum To what branch would you like php8-related PRs to be targeted?  I chose master for now.

Thanks @hamdrew for the work in the PR!
Currently I'm working in PHP8 support as well in https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5166 , for now I picked 2.15 to see what we can do for as many as branches we support.

@SpacePossum Cool, I'll target the same branch in my PRs to be consistent.

Related: https://github.com/PHP-CS-Fixer/diff/issues/19.

Would it be possible to bump this package from "php": "^5.6 || ^7.0", to "php": "^5.6 || ^7.0 || ^8.0", in order not to block other package. Atm php-webdriver/php-webdriver is blocked among others.
I understand that this issue tackle a larger overhaul, but would be great to get out of the blocking situation.

From the description:
Note
Updating composer.json of the project will be done after all current functionality has been made compatible (new feature support can wait)

We are not going to break the code of our users, so "no" for now

@SpacePossum absolutely. I was not proposing to break anything.
Will it be possible to view a list of the current functionality that is not compatible with 8?

@viezel Please read the original post of this thread.
The best fix for your issue is to not depend directly on PHP CS Fixer at all, not even in require-dev. Install it separately instead, e.g.:
$ mkdir -p tools/php-cs-fixer
$ composer require --working-dir=tools/php-cs-fixer friendsofphp/php-cs-fixer

Unless you develop some extension for it, PHP CS Fixer is not a dependency of your code but a tool.

There is also a nice vendor-bin plugin for composer which does this too.

See, for example: https://github.com/vlucas/phpdotenv.

For GitHub Actions, php-cs-fixer can be easily installed thanks to shivammathur/setup-php even on PHP 8

folks, be aware that PHP CS Fixer does not let itself to be installed on PHP 8 not because we are willing to add some extra feature that will improve PHP 8 syntax, but because if you run PHP CS Fixer and feed it with code written in PHP 8, tool itself can crash, or worse - it will not crash and write back to your PHP file with invalid syntax, as PHP CS Fixer is not yet fully aware about syntax changes brought bu PHP 8

NB Executing php-cs-fixer on PHP 8.0 is not officially supported yet, so use with care!

@viezel Please read the original post of this thread.
The best fix for your issue is to not depend directly on PHP CS Fixer at all, not even in require-dev. Install it separately instead, e.g.:
$ mkdir -p tools/php-cs-fixer
$ composer require --working-dir=tools/php-cs-fixer friendsofphp/php-cs-fixer

Unless you develop some extension for it, PHP CS Fixer is not a dependency of your code but a tool.

I totally agree. But I do not control the https://github.com/php-webdriver/php-webdriver repo.

It's on a dev-dep, so doesn't block you installing it. It blocks them testing on PHP 8 however. They should remove it from their require-dev, as per the suggestions in the above comments here.

For GitHub Actions, php-cs-fixer can be easily installed thanks to shivammathur/setup-php even on PHP 8

@vincentchalamon This does not seem to be the case, at least not any more. I'm getting the following error when trying to include 8.0 in my build matrix, and pinning php-cs-fixer to 2.16.7 with the shivammathur/setup-php action:

PHP needs to be a minimum version of PHP 7.1.0 and maximum version of PHP 7.4.*.

@christeredvartsen If you want to disable that check you can use PHP_CS_FIXER_IGNORE_ENV=1 I don't know the consequences of this, so use with caution, but it will work with PHP 8 :smile:

@canvural Thanks, works in my case. Guess I'll keep an extra set of eyes on this build step until php-cs-fixer officially supports PHP 8.0. Thanks for the tip!

Named Arguments

WDYT of an OptionalArgumentsFixer which would remove arguments whose value is their default’s?
<?php chunk_split('This should be changed', 76);

would become
<?php chunk_split('This should be changed');

An additional boolean name_arguments option could determine whether
<?php chunk_split('This may be changed', 76, "\n");

would stay unchanged or become
<?php chunk_split('This should be changed', end: "\n");

due to changes in PHP parser and syntax, running PHP CS Fixer under PHP 8 can change meaning of your code (While tool itself will not crash, as code syntax is still valid after the change, yet it's meaning is different). Be warned when using PHP_CS_FIXER_IGNORE_ENV=1.

@MatTheCat for new feature requests, please raise dedicated issue or send a PR

Hi, is there a beta or development version/branch where I can install PHP CS Fixer with PHP 8?

This issue is 1 year old, and seems to be far from complete. Is there any ETA on availability of a release compatible with PHP 8?
PHP CS Fixer is currently preventing us from upgrading to PHP 8, and I'd hate to have to remove it :/

Welcome to open source @BenMorel, if you are that dependent on the project maybe consider supporting the developer financially, e.g. via GitHub sponsorship. It is also worth noting that PHP 8 has only been fully released for a bit over a week ago, so maybe have some patience?

@BenMorel If I understood this thread correctly you can use PHP_CS_FIXER_IGNORE_ENV=1 to bypass the version constraint. Use at your own risk.

Sorry, I didn't mean to be rude, I also maintain a couple open source projects myself, and I do understand that it's a lot of time investment. Let me simply rephrase my question as:

When can we expect a PHP 8 -compatible release?

The effort needed to have basic support of new syntax (so to only understand it and don't break the code, not talking about effort to write new rules to adjust new syntax) is insane, for that, there is now ETA for PHP 8 support release.
I understand that this is not best situation, but amount of folks investing their private, free time is very limited.
If you want to speed up PHP 8 support, please take a look at TODO in opening message and help with one of it.

composer install on PHP8 is now possible with the release of 2.17:
https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5326

For people complaining that PHP 8 doesn't work, remember this is an OSS project. It is much your job to make it work as it is anyone elses'. If you need a feature, consider implementing it yourself or asking for a quote for someone else to do it for you.

Based on the reasoning to not allow usage of the tool in #5341

The result running PHP CS Fixer on code with it is not known, currently.
We already had a case when PHP 8 code was parsed, changed by fixer and produced valid PHP syntax, but with different meaning. We don't want to offer that to users of the tool. In our opinion it's better to not offer the tool than offer the tool and break the code logic.

Would it be an idea to give the user a warning when someone uses php-cs-fixer with PHP 8.0

or at least the info how to use PHP_IGNORE_ENV.
would you mind to add that note, @SanderSander ?

@keradus Ah sorry guess I'm getting tired that would be way better 😅

2.18 with PHP8 enabled was released. If you would spot any issues with it, raise a net ticket.
I'm leaving this meta-ticket open, as it still contains plenty of ideas for new rules.

2.18 with PHP8 enabled was released. If you would spot any issues with it, raise a net ticket.
I'm leaving this meta-ticket open, as it still contains plenty of ideas for new rules.

I'm going to close here as a lot of work has been done and having new dedicated issues for each item will be much easier to track going forward. Thanks all for sharing information, thoughts and options, great work :+1:  : )


Problem with arrays in buses

Reported by HansOlsson on 4 Mar 2009 15:13 UTC
The problem is to introduce array elements in expandable connectors(buses) in a convenient way, such that each component only generates the signal for one array element. Applications are wheels in vehicles, cylinders in engines etc.
See more in attachment (including proposals).

Migrated-From: https://trac.modelica.org/Modelica/ticket/148

Comment by HansOlsson on 17 Mar 2009 12:24 UTC
Merged proposal accepted.

Modified by otter on 9 Jan 2017 12:26 UTC

Changelog removed by otter on 9 Jan 2017 12:26 UTC


Feature: Add --http-disabled flag

Context:
By default, Wiremock has always an HTTP listener started on 8080 if the flag port is not set even if you are setting an HTTPS listener.
Goal:
Adding a flag --http-disabled allowing the Wiremock server to be reached only from HTTPS.

Looking good!
Please could you add an acceptance test, then I'll merge.

Cool, I added a few tests!

Could you add an acceptance test (that starts WireMock for real and tests via an HTTP client)?
This is probably the right place to put it (and see examples of this kind of test):
https://github.com/tomakehurst/wiremock/blob/master/src/test/java/com/github/tomakehurst/wiremock/HttpsAcceptanceTest.java

Hi @tomakehurst,
Before your last comment, I had 3 tests:

one checking the HTTP connector is null
one checking the command --http-disabled is mapped to the object WiremockConfig
one acceptance test checking HTTPS is still behaving as expected when HTTP is disabled in HttpsAcceptanceTest

On the last one, if I'm testing the HTTP port, I would have to expose the private method httpPort and this one would throw an exception saying the server can't start with the option --http-disabled.
I could test this exception IllegalStateException but it would be more a unit test.

Urgh, sorry. Don't know how I glossed over that. Guess I shouldn't review PRs on a Monday morning before my 1st coffee! I'll take another look on the train home, and probably merge.

One more small thing - I'm not keen on changing the behaviour of WireMock.port() depending on the whether HTTP is enabled or not. Can you revert that so that it's always explicitly WireMock.httpsPort() that needs to be called?

Would also be good to have an assertion in the acceptance test confirming that there is nothing listening on the HTTP port.

Hey @tomakehurst,
I reverted the part around port() returning HTTPS or HTTP port based on the options set.
The HTTP connector being null, I'm asserting the IllegalStateException and message thrown when we are calling port().
If we recap, we have:

one test validating the command option is well applied to the Wiremock configuration
one test validating the HTTP connector is null when this option is passed
one test validating HTTPS returns a stub and throws an exception when we are calling port()

@tomakehurst 🙂


Bump astw

https://github.com/substack/astw/pull/7 warrants a major version bump. lexical-scope should be updated accordingly.

Done in https://github.com/substack/lexical-scope/commit/ba50173762674ae5b859d47aab5f0d3ca12135a2


Update LMDB to 0.9.19

The GitHub mirror of the project is out-of-date and a new version of LMDB has been released. It is available on the mdb.RE/0.9 branch of the OpenLDAP repository (commit 27f6160).

The mentioned commit is actually not a release. When the release is made a tag with name LMDB_0.9.19 should be created.


Hammer.Manager undefined in Meteor 1.3

Getting the following error:
TypeError: Cannot read property 'Manager' of undefined
Hammer is installed and I try to instantiate it in the following example:
Template.mobileSwipe.rendered = function() {
        var height = $('#my-content').height();
        console.log('Height: ' + height);

        var stage = document.getElementById('swipe');
        console.log(stage)
        var mc = new Hammer.Manager(stage);
        var Rotate = new Hammer.Rotate();
        mc.add(Rotate);
        mc.on('rotate', function(e) {
            var rotation = Math.round(e.rotation);

            stage.style.transform = 'rotate('+rotation+'deg)';
        });

    }

It keeps failing on the var mc = new Hammer.Manager(stage);

You have not loaded Hammer Hammer is the undefined` variable there. You need to make sure you have loaded hammer and have a valid reference to it. Im going to close this since it does not appear to be a problem with hammer but that you have not loaded it properly.

You need add npm package :
npm install hammerjs
and if you want use velocity in Hammer you need this package :
meteor add velocityjs:velocityjs
It's resolve my Hammer problems.


Updated spelling

Updated spelling of contributors

Great catch! Can you add yourself to the Contributor List if you haven't already?


How can I use input by python in Visual Studio Code?

VSCode Version: Code 1.3.1 (e6b4afa53e9c0f54edef1673de9001e9f0f547ae, 2016-07-12T13:31:10.994Z)
OS Version: Darwin x64 16.0.0

I am pretty sure that I didn't make mistakes in my codes. But the vs code doesn't seem to be able to use 'input', because after I run the program, I can't type anything into the vs code or see anything when the program codes have 'input' in it. It won't show me anything either.

@Eric2i , you can find the solution here DonJayamanne/pythonVSCode/issues/196 with sample instructions here.
If you are still experiencing issues with the Python extension, please raise a issue in the Python git repo, thanks.
Similar to Microsoft/vscode#8765


kfctl not using correct url

I am trying to setup Kubeflow on my K3S server listening on port 6443. For some reason, the setup tries to install on port 8080, which is not used. Is there a way to change this url?
I downloaded the kfctl_k8s_istio.v1.0.2.yaml config file. When I run the kfctl apply command, I get the following error:
failed to apply:  (kubeflow.error): Code 500 with message: kfApp Apply failed for kustomize:  (kubeflow.error): Code 400 with message: couldn't create namespace kubeflow Error: Post "http://localhost:8080/api/v1/namespaces": dial tcp <IP_ADDRESS>:8080: connect: connection refused

Cluster infos:
>kubectl config current-context
default

>kubectl config get-contexts
CURRENT   NAME      CLUSTER   AUTHINFO   NAMESPACE
*         default   default   default

>kubectl config view
apiVersion: v1
clusters:
- cluster:
    certificate-authority-data: DATA+OMITTED
    server: https://<IP_ADDRESS>:6443
  name: default
contexts:
- context:
    cluster: default
    user: default
  name: default
current-context: default
kind: Config
preferences: {}
users:
- name: default
  user:
    password: ***
    username: admin

>kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.4+k3s1", GitCommit:"97b7a0e9df2883f08028fb7171c1e62fc1899a0c", GitTreeState:"clean", BuildDate:"2020-06-18T01:30:45Z", GoVersion:"go1.13.11", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.4+k3s1", GitCommit:"97b7a0e9df2883f08028fb7171c1e62fc1899a0c", GitTreeState:"clean", BuildDate:"2020-06-18T01:30:45Z", GoVersion:"go1.13.11", Compiler:"gc", Platform:"linux/amd64"}

>kfctl version
kfctl v1.0.2-0-ga476281

I figured out my KUBECONFIG was not set. This solved the issue.


Deployment on OpenStack Fails

I have been attempting to deploy OKD4 on my OpenStack Stein cluster. The cluster has all of the required services, compute, block, object, network, etc.
When attempting to deploy OKD4 on OpenStack, Terraform fails due to the following error:
ERROR
ERROR Error: Unsupported argument
ERROR
ERROR   on ../../tmp/openshift-install-867057577/bootstrap/main.tf line 75, in data "ignition_file" "dhcp_conf":
ERROR   75:   filesystem = "root"
ERROR
ERROR An argument named "filesystem" is not expected here.
ERROR
ERROR
ERROR Error: Unsupported argument
ERROR
ERROR   on ../../tmp/openshift-install-867057577/bootstrap/main.tf line 88, in data "ignition_file" "dns_conf":
ERROR   88:   filesystem = "root"
ERROR
ERROR An argument named "filesystem" is not expected here.
ERROR
ERROR
ERROR Error: Unsupported argument
ERROR
ERROR   on ../../tmp/openshift-install-867057577/bootstrap/main.tf line 101, in data "ignition_file" "hostname":
ERROR  101:   filesystem = "root"
ERROR
ERROR An argument named "filesystem" is not expected here.
ERROR
ERROR
ERROR Error: Unsupported argument
ERROR
ERROR   on ../../tmp/openshift-install-867057577/masters/main.tf line 7, in data "ignition_file" "hostname":
ERROR    7:   filesystem = "root"
ERROR
ERROR An argument named "filesystem" is not expected here.
ERROR
ERROR Failed to read tfstate: open /tmp/openshift-install-867057577/terraform.tfstate: no such file or directory
FATAL failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply using Terraform

The same install-config.yaml file works fine on ocp4.
Install-config.yaml:
apiVersion: v1
baseDomain: example.com
compute:
- hyperthreading: Enabled
  name: worker
  platform:
    openstack:
      type: ocp.master
  replicas: 3
controlPlane:
  hyperthreading: Enabled
  name: master
  platform:
    openstack:
      type: ocp.master
  replicas: 3
metadata:
  creationTimestamp: null
  name: ec
networking:
  clusterNetwork:
  - cidr: <IP_ADDRESS>/14
    hostPrefix: 23
  machineCIDR: <IP_ADDRESS>/16
  networkType: OpenShiftSDN
  serviceNetwork:
  - <IP_ADDRESS>/16
platform:
  openstack:
    cloud: openstack
    computeFlavor: ocp.master
    externalNetwork: ext-net
    lbFloatingIP: <IP_ADDRESS>
    octaviaSupport: "0"
    region: "ca-east"
    trunkSupport: "0"
publish: External
pullSecret: '{"auths":{"fake":{"auth": "bar"}}}'
sshKey: ssh-rsa AAAAB3...

Also, it seems that the OpenStack terraform vars are still specifying the rhcos image:
{
  "openstack_base_image_name": "ec-zp8b5-rhcos",
  "openstack_base_image_url": "https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.3/43.80.20191002.1/x86_64/rhcos-43.80.20191002.1-openstack.x86_64.qcow2",
  "openstack_external_network": "ext-net",
  "openstack_credentials_cloud": "openstack",
  "openstack_master_flavor_name": "ocp.master",
  "openstack_lb_floating_ip": "<IP_ADDRESS>",
  "openstack_api_int_ip": "<IP_ADDRESS>",
  "openstack_node_dns_ip": "<IP_ADDRESS>",
  "openstack_ingress_ip": "<IP_ADDRESS>",
  "openstack_trunk_support": "0",
  "openstack_octavia_support": "0"

I attempted to change the image name to fedora-coreos with no luck:
{
  "openstack_base_image_name": "fedora-coreos-30.20191014.0",
...
}

thanks for repoting back and for testing it @jdhirst1
Not sure exactly on the state but we'll ask in the next WG meeting and report back unless you will join and can ask/ hear yourself.
Please keep raising issues, we appreciate and welcome more folks like you to provider feedback

Related to https://github.com/openshift/okd/issues/16 provider

@DanyC97 Since this is related to fcos installer, should this be raised on the installer/fcos repository?

@jdhirst1 no, let's track this here for the time being.

Closing in favor of #16


Fails to compile in XCode Version 7.0 beta 6 (7A192o)

  1 Soundcloud Group
  2 Pods/Soundcloud/sources/SoundcloudSDK/extension/DictionaryExtension.swift:38:21: Cannot invoke 'map' with an argument list of type '(Dictionary<Key, Value>, (_, _) -> String)'
  3 Pods/Soundcloud/sources/SoundcloudSDK/model/ImageURLs.swift:47:48: Cannot use optional chaining on non-optional value of type 'String'
  4 Pods/Soundcloud/sources/SoundcloudSDK/extension/NSURLExtension.swift:21:51: Cannot force unwrap value of non-optional type 'String'
  5 Pods/Soundcloud/sources/SoundcloudSDK/request/Request.swift:33:16: 'GeneratorOf' has been renamed to 'AnyGenerator'
  6 Pods/Soundcloud/sources/SoundcloudSDK/request/Request.swift:222:77: Extra argument 'error' in call
  7 Pods/Soundcloud/sources/SoundcloudSDK/request/Request.swift:230:29: Type of expression is ambiguous without more context
  8 Pods/Soundcloud/sources/SoundcloudSDK/soundcloud/Soundcloud.swift:149:54: Missing argument labels 'retry:completion:result:' in call
  9 Pods/Soundcloud/sources/SoundcloudSDK/request/TrackRequest.swift:45:24: 'join' is unavailable: call the 'joinWithSeparator()' method on the sequence of elements
 10 Pods/Soundcloud/sources/SoundcloudSDK/request/TrackRequest.swift:105:50: Missing argument labels 'retry:completion:result:' in call
 11 Pods/Soundcloud/sources/SoundcloudSDK/request/TrackRequest.swift:163:54: Missing argument labels 'retry:completion:result:' in call
 12 Pods/Soundcloud/sources/SoundcloudSDK/request/UserRequest.swift:182:54: Missing argument labels 'retry:completion:result:' in call

This is using the pod version... 0.1.8 I think?

Hi @roaet
The framework isn't available for Swift 2.0 yet. It'll come this week, probably tomorrow or the day after. I'll let you know as soon as it's available.

Cool! I was just making an issue so my PR could refer to it, but if you're going to do it so soon then I'll just wait.

I didn't start it yet so both ways work for me :)

I was just about to start soundcloud dev on iOS using this pod, so I don't have a decent example program to test if I fixed it or not.
I can make the PR but it'd be untested.

Done is 0.2.0 76fbf4fc74327663cfaf31028a6e36c101122e5a

Let me know if you face any issues. Next step for this project is to support pagination and include Playlists in Readme since they're now supported 🎉🎉🎉
I'll be glad to have any feedback at all :)

I actually had it working with my fixes but didn't make a PR! This is a great project and I look forward to contributing if you don't mind!
I will test this asap.

@roaet can I close this?

Yes Thank you!


FastAPI Parametric Dependency Injection

Hello, is there a way to define a parametric dependency injection based on some of the query/mutation variables?
Eg. something like
def custom_context_dependency(name: str) -> str:
    return name

async def get_context(
    custom_value=Depends(custom_context_dependency),
):
    return {
        "custom_value": custom_value,
    }

@strawberry.type
class Query:
    @strawberry.mutation
    def example(self, name: str, info: Info) -> str:
        return f"Hello {info.context['custom_value']}"

You want to inject stuff into info.context?

Yes, I want to inject an http client as a dependency in the info.context, but some client parameters depends on the request parameter (eg. the login user)

You can:

write an extension and inject what you want there though extensions are not working for subscriptions currently.
pass context_value to Schema.execute

maybe @Kludex has some ideas about this. In the django integration we have defined get_context on the class and it receives the info param, I think we should have the same for fastapi

Why not having the HTTP client globally? 🤔

This is a great idea. I would suggest writing an extension that injects the fastapi dependency into the resolvers.


ValueError: If mode is 'interp', window_length must be less than or equal to the size of x.

My code is this: modbamtools plot -r NC_007793.1:607408-609562 95_0_0.bam -o modbamtools/
And my version is this: modbamtools --version : modbamtools, version 0.4.8
But I still have the issue with these followings:
Traceback (most recent call last):
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/bin/modbamtools", line 8, in
sys.exit(cli())
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/lib/python3.8/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/lib/python3.8/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/lib/python3.8/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/lib/python3.8/site-packages/modbamtools/cli.py", line 334, in plot
fig = Plotter(
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/lib/python3.8/site-packages/modbamtools/modbamviz.py", line 47, in init
self.tracks, self.num_tracks = get_tracks_gl(
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/lib/python3.8/site-packages/modbamtools/tracks_webgl.py", line 276, in get_tracks_gl
freq_traces, single_read_traces, het_traces = make_modbam_trace_gl(
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/lib/python3.8/site-packages/modbamtools/tracks_webgl.py", line 178, in make_modbam_trace_gl
freq = plot_frequencies_gl(sample_dict, start, end, color=colors[i])
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/lib/python3.8/site-packages/modbamtools/tracks_webgl.py", line 71, in plot_frequencies_gl
freq, freq_smooth = calc_freq(dict_per_read_mod, start, end)
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/lib/python3.8/site-packages/modbamtools/utils.py", line 78, in calc_freq
freq_smooth["y"] = savgol_filter(freq["y"], window, poly)
File "/gpfs/data/pirontilab/Students/RenqiuguoLi/miniconda/envs/modbamtools/lib/python3.8/site-packages/scipy/signal/_savitzky_golay.py", line 345, in savgol_filter
raise ValueError("If mode is 'interp', window_length must be less "
ValueError: If mode is 'interp', window_length must be less than or equal to the size of x.
Please! Thank you very much!

Hello, I'm also getting this error now, having used the dorado basecaller from Oxford Nanopore. the modbamtools version I have is 0.4.8
Previously I had this error on data from the guppy basecaller, but with version 0.2.2 of modbamtools, and upgrading modbamtools to 0.4.8 fixed the error that time. Could this error be due to the dorado basecaller?

my code and error are:
modbamtools plot -r chr8:127729510-127749672 control_dorado_0-3-0_dna_r10.4.1_e8.2_400bps_hac_v4.1.0_mod_bases_aligned.bam  -o modbamtools/
Traceback (most recent call last):
  File "/usr/local/bin/modbamtools", line 8, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/modbamtools/cli.py", line 334, in plot
    fig = Plotter(
  File "/usr/local/lib/python3.8/dist-packages/modbamtools/modbamviz.py", line 47, in __init__
    self.tracks, self.num_tracks = get_tracks_gl(
  File "/usr/local/lib/python3.8/dist-packages/modbamtools/tracks_webgl.py", line 276, in get_tracks_gl
    freq_traces, single_read_traces, het_traces = make_modbam_trace_gl(
  File "/usr/local/lib/python3.8/dist-packages/modbamtools/tracks_webgl.py", line 178, in make_modbam_trace_gl
    freq = plot_frequencies_gl(sample_dict, start, end, color=colors[i])
  File "/usr/local/lib/python3.8/dist-packages/modbamtools/tracks_webgl.py", line 71, in plot_frequencies_gl
    freq, freq_smooth = calc_freq(dict_per_read_mod, start, end)
  File "/usr/local/lib/python3.8/dist-packages/modbamtools/utils.py", line 78, in calc_freq
    freq_smooth["y"] = savgol_filter(freq["y"], window, poly)
  File "/usr/local/lib/python3.8/dist-packages/scipy/signal/_savitzky_golay.py", line 345, in savgol_filter
    raise ValueError("If mode is 'interp', window_length must be less "
ValueError: If mode is 'interp', window_length must be less than or equal to the size of x.


Duplicate slashes if set param 'suffix' of the component UrlManager to '/'

What steps will reproduce the problem?
#13522
[
    'suffix'     => '/',
    ['pattern' => '<page:\d+>', 'route' => 'site/index', 'defaults' => ['page' => 1]],
]

Then create a URL like that
Url::to(['site/index', 'page' => 1])
What is the expected result?
The generated URL should be
Home

What do you get instead?
Home

Additional info

Q
A

Yii version
<IP_ADDRESS>

PHP version
7.0.15

Operating system
Centos 6

Issue is not reproducible on Yii 2.0.10

Probably will be fixed by https://github.com/yiisoft/yii2/pull/13624

Is there a typo in the issue description? The URL rule has a site/brand route and the URL creation example - site/index.

Sorry, for my typo in the description. I corrected it.

Confirmed via #13660.

https://github.com/yiisoft/yii2/pull/13624/commits/7206b2ba8a9e2a7648fa5507ce338fc851bc0a6e


Replace code coverage tool

Resolves: MWPW-129597
Test URLs:

https://bye-codecov--milo--hparra.hlx.page/?martech=off

Description
In the past 7 days, there have been at least 7 times when the codecov report for a PR was not uploaded. 5 of these PRs have already been merged without their codecov being uploaded. This breaks coverage reporting for all subsequent PRs. In each of those 5 cases, there were check failures and in some cases the UT coverage was skipped.
The codecov tool and workflow is creating more noise than signal. Developers are paying cost of poor or broken coverage in unrelated parts of the code, and are being conditioned to ignore errors.
See snapshot of https://app.codecov.io/gh/adobecom/milo/pulls below.

Challenges
It is only possible for this workflow to comment on the PR when the PR comes from an adobecom/milo branch. This is because workflow requires write permission from its automatically created secrets.GITHUB_TOKEN and for security reasons the permission is always read-only when request comes from a public PR. For this reason this change will fail tests when coverage drops. It is the responsibility of the developer to check for failure.

This works in my own fork: https://github.com/hparra/milo/pull/1
It does not work here because the scope of secrets.GITHUB_TOKEN is always read for PRs from public forks, regardless of permissions settings in workflow. The only way to make this work is for people to always make PR from a adobecom/milo branch, which will have correct permissions. See https://github.blog/changelog/2021-04-20-github-actions-control-permissions-for-github_token/

It is only possible for this workflow to comment on the PR when the PR comes from an adobecom/milo branch. This is because workflow requires write permission from its automatically created secrets.GITHUB_TOKEN and for security reasons the permission is always read-only when request comes from a public PR.

I think this is a blocker for accepting the change of this PR. We actually want folks to fork the milo repo and raise PRs from their forks, especially newly onboarded Milo Contributors won't have any write permissions to the milo repo.

I think this is a blocker for accepting the change of this PR. We actually want folks to fork the milo repo and raise PRs from their forks, especially newly onboarded Milo Contributors won't have any write permissions to the milo repo.

They can still do that. The problem is under this configuration we won't get the update comment on the PR, instead if coverage fails then the Unit Tests will fail.

@chrischrischris @auniverseaway Ironically, codecov seems to be causing less problems lately. I'm on the fence with this one. 🤷♀

I'm not in love this this, but I get it.

Me neither. Maybe we should hold on this.

Only works for PRs coming from adobecom/milo branches
Am I understanding it correctly that PRs from forks will break on this?

I confused a few ppl with that sentence. What "breaks" is the comment on PR to show coverage report -- I have disabled that so PRs from forks don't error out. The check still runs and UT check will fail if coverage fails.
Unrelated to PR, seems this test is erring consistently:
❌ marquee > supports media credits > has a media credit with element content
AssertionError: expected null to exist
at o. (test/blocks/marquee/marquee.test.js:48:29)

If we continue improving UTs (flapping, coverage) and ensure green checked PRs are landing on main then codecov will continue to behave. I can reopen this if it starts acting up again.


Remove 3DES ciphers from default TLS config

This is a TODO. We should probably remove ECDHE-RSA-3DES-EDE-CBC-SHA and RSA-3DES-EDE-CBC-SHA from the default TLS config. They'd still be available if users want the extra compatibility but they're not preferred (they're already at the bottom of the list).

 It should just be a few simple changes in tls.go.

I picked up this

Should Caddy not match what mozilla states on this?
https://wiki.mozilla.org/Security/Server_Side_TLS

Does it not?

Closed by PR #412 ?


[DONT MERGE] record form upgrade

that last commit passed wizard builder tests but not callisto-core tests, so I made https://github.com/SexualHealthInnovations/django-wizard-builder/issues/131


NoSuchMethodError Encoder#init(..) in AbstractLogstashTcpSocketAppender

With logback-core 1.2.x the Encoder has changed and the init(..) method is gone. This breaking API changes requires a major release but has been introduced in a minor version update. Anyway ch.qos.logback.core.encoder.Encoder#init(OutputStream) is gone.
Using logstash-logback-encoder in 4.9 with logback 1.2.x leads to the following exception on startup:
in net.logstash.logback.appender.LogstashTcpSocketAppender[BOOT] - Unable start disruptor java.lang.NoSuchMethodError: ch.qos.logback.core.encoder.Encoder.init(Ljava/io/OutputStream;)V
	at java.lang.NoSuchMethodError: ch.qos.logback.core.encoder.Encoder.init(Ljava/io/OutputStream;)V
	at 	at net.logstash.logback.appender.AbstractLogstashTcpSocketAppender$TcpSendingEventHandler.openSocket(AbstractLogstashTcpSocketAppender.java:539)
	at 	at net.logstash.logback.appender.AbstractLogstashTcpSocketAppender$TcpSendingEventHandler.onStart(AbstractLogstashTcpSocketAppender.java:488)
	at 	at net.logstash.logback.appender.AsyncDisruptorAppender$EventClearingEventHandler.onStart(AsyncDisruptorAppender.java:332)
	at 	at net.logstash.logback.encoder.com.lmax.disruptor.BatchEventProcessor.notifyStart(BatchEventProcessor.java:184)
	at 	at net.logstash.logback.encoder.com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:113)
	at 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
	at 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
	at 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at 	at java.lang.Thread.run(Thread.java:745)

see logback commit log:
https://github.com/qos-ch/logback/commit/e2a9429c293ddc55b2a0f771c376b1bf3b00c8ba#diff-6016b292fde98b9e7ed5c04a79bd96f2

Closed. Looks like I had a dependency clash and somehow version 4.6 was used. Can't reproduce with clean classpath 4.9 and LB 1.2.1


Fix layout issues with widgets

iOS 17 made some widgets API changes and we need to adopt those in order to fix layout issues.

Fixed in build 6138.


Rotation in Physijs

When I apply physijs to model , the rotation range changes to -PI / 2 to PI / 2,How could I get the correct range -PI to PI?

Uhhhh... multiply angle by 2 (cancels division)...


Improve most common memory footprint

No need neither to create a list in items() nor to sort the whole
sequence. We need only the max one, right?
If we have two values with the same frequence than we still have
undefined result as before as dict.items() & dict.iteritems()
return values in an undefined order.
Yeah, I just read random code in luigi and see if I can improve
it.

Coverage increased (+0.0%) to 75.82% when pulling 53e87a19891ce9ed989d7cea02f8ac5374d9addb on themalkolm:improve_most_common_memory_footprint into 0f866fa624b1c363b2fa2031df9195114489d77e on spotify:master.

LGTM

LGTM, any opinion @ulzha  ?


"Undefined variable" with list unpacking

Environment
Visual Studio CodeVersion: 1.33.1
Python Extension Version: 2019.3.6558
OS: Windows 10
Python version: 2.7/3.6
Language Server Version: <IP_ADDRESS>
Actual Behavior
Given the Python script
def foo():
    [a, b] = (1, 2)
    x1 = a

    (c, d) = (1, 2)
    x2 = c

    e, f = (1, 2)
    x3 = e

    return (b, a)

if __name__ == "__main__":
    print(foo())

The line x1 = a reports the problem "Undefined variable: 'a' Python(undefiend-variable) [3, 10]".
Expected Behavior
No problem.
Interestingly, the other lines do not trigger warnings and even return (b, a) is accepted.

Can you try out the beta build? This should be already fixed there.
"python.analysis.downloadChannel": "beta"

you are right, no problem with <IP_ADDRESS>


Add new target mockgen

Some times, the codes we changed just requires mock code re-generation
but we can only run make codegen at this moment to run all auto-gen tools
which is a little time-consuming, so move mockgen related codes out of codegen
with standalone Makefile target, developer can use make mockgen to
update mock codes separately.
Signed-off-by: Lan Luo<EMAIL_ADDRESS>

Codecov Report

Merging #3530 (b54456c) into main (f0c3cbe) will decrease coverage by 22.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #3530       +/-   ##
===========================================
- Coverage   65.57%   43.37%   -22.20%
===========================================
  Files         278      210       -68
  Lines       27770    25223     -2547
===========================================
- Hits        18210    10941     -7269
- Misses       7642    13193     +5551
+ Partials     1918     1089      -829

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
43.37% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/ovs/openflow/default.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/util/runtime/runtime.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/openflow/groups.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/apis/controlplane/types.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/apis/controlplane/helper.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/nodeportlocal/k8s/annotations.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ovs/openflow/ofctrl_pipeline.go
0.00% <0.00%> (-93.34%)
:arrow_down:

pkg/ovs/openflow/logs.go
9.52% <0.00%> (-90.48%)
:arrow_down:

pkg/apis/controlplane/register.go
0.00% <0.00%> (-90.48%)
:arrow_down:

pkg/agent/controller/networkpolicy/reject.go
0.00% <0.00%> (-87.91%)
:arrow_down:

... and 198 more

Hi @antoninbas  Could you help to review this PR? thanks!

Hi @antoninbas  Could you help to review this PR again, code generation checker failed, so I refined the code and now they are all in one file hack/update-codegen-dockerized.sh, thanks.

/skip-all

/skip-all


xtensa/asm2: Save shift/loop registers on exception entry

This was a little embarassing.  The swap code got this right, and the
interrupt exit path got it right, but on entry we weren't ever saving
the shift and loop registers for the interrupted context.
This almost always worked anyway as the loop registers aren't ever
used in any Zephyr code (gcc won't generate this style of loop AFAICT)
and the SAR shift amount register is generally used only in two pairs
of adjacent instructions making the chance of hitting that exact cycle
quite low in general.
But of course we have shift-happy crypto code in our tests, so this
got caught, thankfully.
See https://github.com/zephyrproject-rtos/zephyr/issues/6470
Signed-off-by: Andy Ross<EMAIL_ADDRESS>

Codecov Report

Merging #6492 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6492   +/-   ##
======================================
  Coverage    53.2%   53.2%
======================================
  Files         436     436
  Lines       41353   41353
  Branches     7937    7937
======================================
  Hits        22001   22001
  Misses      16128   16128
  Partials     3224    3224

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cd0fd2...da634c7. Read the comment docs.


Perhaps sealer needs to provide an application image market

Issue Description
Perhaps sealer needs to provide an application image market to provide users with enough high-quality application images. For example, it provides directly available middleware capabilities such as database, message queue and configuration management. Further shielding the underlying complexity.
Type: feature request

@lllwan Good idea! While sealer is open source project under CNCF. But I think that sealer applications marketplace seems to be a commercial product or at least operated by a commercial organization.
If it is a commercial one, I am afraid that maybe sealer open source team is not the suitable organization to do this. Actually I have little experience on this. Could you input some from the CNCF? @caniszczyk


Non-SRIOV IB Diagnostics

The tool does not currently support collecting Infiniband diagnostics on any non-SRIOV enabled SKUs.

See azurehpc scripts


Add support for "undefined"

I would like to see a test case which ensures that we don't step into this issue again if we start refactoring.

Which issue are you referring to? The bugfix in the separate commit is tested by the undef tests in the next commit.

I would like to see a test case which ensures that we don't step into this issue again if we start refactoring.

Which issue are you referring to? The bugfix in the separate commit is tested by the undef tests in the next commit.

I understand, I missed that.


megacheck is automagic

This is not expected behavior when I set e.g.
{
    "Enable": ["vet", "golint", "staticcheck", "unused", "gosimple"]
}

If I want megacheck, then I will add megacheck to that list instead of staticcheck, gosimple and unused. Megacheck also has the disadvantage that I don't really see what linter found what issue.

The other linters are deprecated and will be removed completely at some point. This is the intermediate stage.


[BUG] DP Codegen not generating credential methods on client builders

Describe the bug
A clear and concise description of what the bug is.
Autorest generation for Dataplane is not generating credential methods on client builders, even when security and security-scopes are specified.
To Reproduce
Steps to reproduce the behavior:
Follow guide here for DP codegen for Java with Autorest, using below README (linking to valid input files available here in official spec repo). Observe that no credential methods are added to the client builders.
Code Snippet
Add the code snippet that causes the issue.
input-file:
  - C:/Users/chrismiller/source/repos/azure-devtest-center/src/sdk/specification/devcenter/data-plane/Microsoft.DevCenter/preview/2022-03-01-preview/devcenter.json
  - C:/Users/chrismiller/source/repos/azure-devtest-center/src/sdk/specification/devcenter/data-plane/Microsoft.DevCenter/preview/2022-03-01-preview/devbox.json
  - C:/Users/chrismiller/source/repos/azure-devtest-center/src/sdk/specification/devcenter/data-plane/Microsoft.DevCenter/preview/2022-03-01-preview/environments.json
payload-flattening-threshold: 2
public-clients: true
security: AADToken
security-scopes: https://devcenter.azure.com/.default

Expected behavior
A clear and concise description of what you expected to happen.
Credential methods are available on client builders for authentication
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: [e.g. iOS] Win 11 Enterprise
IDE: [e.g. IntelliJ] VS 2022 Preview
Library/Libraries: [e.g. com.azure:azure-core:1.16.0 (groupId:artifactId:version)] N/A (new library)
Java version: [e.g. 8] openjdk 17.0.4 2022-07-19 LTS
@autorest\java version: 4.1.3

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

Closing as this was resolved in Autorest.java: https://github.com/Azure/autorest.java/issues/1730


Highscore fix

tweaked some of the naming and comments (may have missed some so if I did just please point them out). All commented out code from me should be removed. Keeping in some test code to aid with debugging for now, but nothing is test code in the model, only in the CLI (which I'm not actually pushing yet) and the Highscores.py file

changing the controllerRunAutoGame and Base functions in controller was necessary since you didn't want me to use a getter method in the model. The only difference is that it stores and returns the game_id from the method in the model code, which is carried over into the CLI (which is where I have been setting it up so far) from the controllerRunAutoGame and Base functions. The NewPuzzleHelper method simply updates the lines where those are called like this: self.game_id = self.controller.controllerRunAutoGame() (and for the other one). This allows me to access the game_id while in the CLI file. It does not change any functionality and everything still works the same way, it was simply my workaround for not using a getter method. As for the comments, I will fix those and update this.

My bad, it is actually okay to have the getter in the model like the rest of them! Just was thinking about test coverage but I'm sure Devon's got that covered. You can revert it back to how you had it


Support JSON defined rules import

Basically this feature is to allow the importing of a JSON defined rules structure (similar to regent < 3.x.x
{
  isHot: { greaterThan: ['@temperature', 55]  },
  isRaining: { equals: ['@precipitation', 'raining'] },
  windyAndCold: {
    or: [
      { greaterThan: ['@windSpeed', 10] },
      { lessThan: ['@temp', 65] }
    ]
  }
}

We could call regent.import on this rules object and the method would return an object of rules, with the value of each being a regent function. I propose that the first iteration of this not try to handle custom predicates. I can't think of a sane way to do that.

Here is a PR with code the handle JSON imports.
https://github.com/northwesternmutual/regent/pull/40
No docs written yet, but if anyone has any feedback on the API let me know.

What about just regent.import(json, predicates)

Also, is this useful without a way to export as well?

@jesselee34 I think it's super useful without export. You could define a rules server that served rules to multiple applications.

I don't like regent import because import is a reserved keyword, so you couldn't do
import { import } from 'regent'

And I don't want to have to do this every time
import { import as importFn} from 'regent'

Plus, the parse function doesn't really import anything, it returns an object of regent functions


[decompiler] replace "peek" system for method decompilation

This didn't work reliably in texture.gc.  The FormStack could probably be improved to make this easier to figure out.

(method 0 fact-info-enemy) is failing to get the method call in the head of the form.
    (let ((t9-3 (method-of-type res-lump dummy-12)))
     (set!
      (-> gp-0 notice-top)
      (t9-3
       s5-0
       'notice-top
       'interp
       -1000000000.0
       4096000.0
       #f
       *res-static-buf*
       )
      )
     )

Also happens a ton in transformq and level.

This issue is actually two issues.
The original issue (peek failures) in texture, transformq, and level is addressed with https://github.com/water111/jak-project/pull/488
The fact-info-enemy thing is still happening, but these are non-virtual method calls and the peek system is not involved in any way.

Similar issues happening in res.gc.

The conclusion is that res-lump has a few methods that are often (but not always!) called by some macro that internally does (method-of-type res-lump <blah> ...).  We should probably special case these so they don't "split" like this, but keep the (method-of-type thing because it won't actually grab the method from the most specific type at compile time, it always uses res-lump (different from a normal method call).

See also process-drawable deactivate for more non-virtual weirdness.

We believe that there are macros for accessing res-lumps that bypass doing virtual method calls.  These are now recognized in the decompiler and after https://github.com/water111/jak-project/pull/796 it will look like this:
(set! (-> obj notice-top) (res-lump-float entity 'notice-top :default 4096000.0))


Address comments in #5

Thanks for merging #5! Here are the remaining changes to address your comments.

lgtm!


how to log in fiddler

hi was following the update guide but along the way my brain just gave in and farted. wanted to inquire on how do you log on fiddler as i understand the rest of the updating tutorial but the log thing still confuses me.
P.S do you run the client console in the ygomaster client right not the steam version?

another note is the ygomasterupdate is not showing up on fiddlers folder

Hi! Did you solve this problem? Because I also encounter the same issue. YgoMasterFiddler  isn't showing on anywhere also. Thanks!


UI is buggy on a specific resoltution.

Describe the bug
When we visit the website. UI does not stack properly. But on hover it stacks but looks bad.
Check attached screenshots.
To Reproduce

Visit Website
Tested at 1366px X 768px

Expected behavior
Stack when not hovering on sidebar and to not stack on hover on sidebar.
Screen real estate is being wasted on blank space.
Screenshots
Without Hover

With Hover

Desktop (please complete the following information):

OS: Windows
Browser chrome, edge, firefox
Version latest of each browser

@jeremyphilemon  @JunaidBabu

It's working now.


Error in list-of-plugins.html docs (NormalModuleReplacementPlugin section)

EDIT:
I found that my newResource function is called twice - on before-resolve and after-resolve events. At first time this function should modify request, but at second one resource attribute.
Docs says only about request:

If newResource is a function, it is expected to overwrite the ‘request’ attribute of the supplied object.

I changed title of this issue from
NormalModuleReplacementPlugin not working in 2.2.0-rc.0
to
Error in list-of-plugins.html docs (NormalModuleReplacementPlugin section)

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Webpack still use original module instead of replacement one.
If the current behavior is a bug, please provide the steps to reproduce.
Add any valid instance of webpack.NormalModuleReplacementPlugin to plugins inside your webpack config file and check if your replacement module is used.
Example: instead of any-module package from node_modules we want to use replacement from our app directory. Let's write our config file:
// ...
plugins: [
  new webpack.NormalModuleReplacementPlugin(
    new RegExp(`^${PATHS.vendor}/any-module/lib/index.js`), // PATHS.vendor is absolute path to package node_modules directory
    function(result) {
      const appModulePath = path.join(PATHS.app, './any-module/lib/index.js');
      if(fs.existsSync(appModulePath)) {
        result.request = appModulePath;
      }
    }
  )
]
// ...

And then use it somewhere in our code:
const anyModule = require('any-module');

What is the expected behavior?
Webpack should resolve module from newResource specified to NormalModuleReplacementPlugin constructor.

I have additional question about NormalModuleReplacementPlugin. When I change request and resource attributes of result object should loaders from webpack config module.rules array be aplied to replacement module?
{
  test: /\.jsx$/,
  loaders: ['babel-loader?cacheDirectory', 'preprocess-loader'],
  include: PATHS.app
}

Now I have this error (source is not passed through Babel and Webpack can't understand JSX syntax):

Is it expected behaviour?

To ensure we can fix this, could I twist your 💪 into creating a minimal reproducible example repo that we can test against? It will considerably expedite the troubleshooting process 🙏 🙏 .

@TheLarkInn
git clone https://github.com/mateuszmazurek/NormalModuleReplacementPlugin-test.git
cd NormalModuleReplacementPlugin-test
npm install
npm test

How about my question in comment? When i use NormalModuleReplacementPlugin correctly should loaders be applied to replacement module? I don't know if I should open dedicated issue.


Bug Fix for Issue #1147: Kinect body tracking device not created

This pr addresses issue https://github.com/microsoft/Azure-Kinect-Sensor-SDK/issues/1147
Tracker create failed.
The onnxruntime.dll is now needed in the Assets/plugins folder.
Updated the  README.md file for release 1.0.1 and updated the MoveLibraryFiles.bat to make sure the libraries are now correctly distributed.

Hi,
Tracker create is still failing for me and it's printing this exception catching exception for background thread result = K4A_RESULT_FAILED.


Allow listing and selecting probe

This provides options similar to cargo-flash to list all connected probes
and to specify which one to use:
probe-run --list-probes
probe-run --probe '1366:0101' --chip nrf52 bin
probe-run --probe '1366:0101:123456' --chip nrf52 bin
This also alows specifying the probe as en env-var:
PROBE_RUN_PROBE='1366:0101:123456' cargo run
It fixes #14.

Additional question: does the selector accept just the serial number (e.g. --probe 123456)? I think that the serial number is usually unique enough to select a probe.

Additional question: does the selector accept just the serial number (e.g. --probe 123456)? I think that the serial number is usually unique enough to select a probe.

No, in DebugProbeSelector, the vendor_id and product_id are not optional.


Please support Python 3.11

Would it be possible to easily update this to support Python 3.11?

Thank you!


Make auto require disabled by default

Would it be possible to make auto require disabled by default?
Over the past few days I wondered multiple times why I had a require at the top of a file but guessed it was there because I copy & pasted the file header form existing files. But right now I noticed the same require added to a 3rd party library (rxi/flux) after I've just done a very minor code modification to the file. The auto require is completely useless as nothing of the required file is ever used in the library.
IMO it's really not a good idea to have content/code modifying features enabled by default.

Only when your input is neither a defined global variable nor a visible local variable, Auto Require will work, which should eliminate most of the ambiguity.
How do you trigger Auto Require ?

I didn't trigger it, well at least not as far as I know (is there a predefined shortcut?). I didn't even know the features exists before I noticed that it inserted a require in some of my files. I only really noticed that something went wrong when it added the line
local tutorial_01 = require "source.tutorial_01"
at the top of the flux.lua file (https://github.com/rxi/flux) which, is a self contained single file library not relying on any external code/data (besides some math functions) and even less so a tutorial script from my game :)
The only change I did to flux.lua was to add a single line after line 170 with the following content
t.done = true
I have no idea why the auto require happened or, in case I did trigger it, how I did it :)
Anyway - found the toggle to disable features so no real problem on my side but I'd prefer such features to be disabled by default in a language as dynamic as Lua.

Auto require is a pretty common feature afaik, it even exists and is enabled by default in VSCode's built-in intellisense for a similarly "dynamic" language, Javascript. If this feature were to be disabled by default, I wouldn't have known that it existed and requiring files in a huge project would continue to be a dreadful task.
It's good to provide context of your environment/setup as it gets hard to find out if it's an issue on your end or with the plugin. I think any specific examples like you just did to reproduce your issue will be more helpful to improve the feature rather than "disable this x feature so it is never known to humankind because it doesn't work well enough"
Anyway, I think this is an issue indeed with some edge case involving # and tables. Could reproduce by having this in a workspace:
testlib.lua

--- Testlib
local testlib = {}
return testlib

reproduce.lua

local has_function = { f = function () end }

local no_function = { f = true }

-- Doesn't work
do
    local t = has_function[#has_function]
    -- type "t." here
end

-- Works
do
    local t = no_function[#no_function]
    -- type "t." here
end


Special characters in note/folder names break the application

Including a / character in a note/folder name results in spurious errors:

For folders: Workspace not found
For notes: ENOENT: no such file or directory

In both cases, it's because the / character is interpreted as a directory separator. Because of this, in the first case, we fail to find the parent directory of the new directory.  The second case is more confusing, because I'd expect to get a Folder '...' not found error, for similar reasons.

Note, on MacOS at least, it is possible to have file names containing / characters.


Accessibility issue: Adding text description on tray icon

Hi,
I would like to know if it's possible to add some text (description?) on the tray icon.
Context:
My dad is blind, so it must a screen reader software,named JAWS or NVDA, to use a computer. When he try to list all applications on tray icon area, he is not able to see your app (see attached file).

Potential solution:
Add appIcon.setTitle('Chromecast Audio Stream'); on line 54, between })); and appIcon.setContextMenu(contextMenu);

Is there any significant progress?

Hi Acid!
I don't found text description on tray icon in last release. Do you implement it?

Sorry, no. I just did a mass close of issues.

What do you think about my suggestion?

Is someone could try my suggestion? I don't know how to compile after modification application.

You just need to execute, "grunt dev"

After http://electron.atom.io/docs/v0.27.0/api/tray/ relecture, I assume that my solution works only on MacOS. Is someone could confirm?

Hi @acidhax,
Is there any significant progress? Sorry to ask again, but I clearly don't have necessary skill to do it by my own.


[TwitchAlert] Add timeout to API requests

Describe the bug
Occasionally GH actions will not successfully run tests (likely something to do with API restrictions, an issues itself). However in this case TwitchAlert tests will continually try to get a response from the API an not stop.
To Reproduce
Numbered steps to reproduce the behavior:

Run GitHub Actions tests
Get lucky (idk how to reproduce)
Watch the tests continue forever

Expected behaviour
Whenever requesting from the Twitch API fails, timeout for random time.
If timed out 5 times, throw an error.
Additional context

Version e.g. 0.4.2

Believe when 2 applications running on the same key, they fight over the account, creating lots of OAUTH keys and invalidating the one the other has


LF-19645 allow delegateOpts as combination of engageOpts and profileOpts

#review

Why?

If we don't, every customer using LFEP will have to put the same settings into two objects--profileOpts and engageOpts. It seemed repetitive.

After talking with Trey in person, closing this for now. I recommend pursuing an integration path for LFEPv2 that doesn't require this lib, e.g. https://github.com/Livefyre/lfpackages/pull/16#issuecomment-153883965


Calculate Cert test coverage and notify discord monitoring channel

Description
This change introduces certification test line coverage and its notification to Dapr Monitoring discord channel.
After review, Before Merging, someone with appropriate privileges, need to add "DISCORD_MONITORING_WEBHOOK_URL" to the secrets for Actions in Settings.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

This is the format in which it will be notifying. As the last message, it also posts a "Total Coverage" overall.

After review, Before Merging, someone with appropriate privileges, need to add "DISCORD_MONITORING_WEBHOOK_URL" to the secrets for Actions in Settings.

Example run on my local fork: https://github.com/DeepanshuA/components-contrib/actions/runs/2627567493

After review, Before Merging, someone with appropriate privileges, need to add "DISCORD_MONITORING_WEBHOOK_URL" to the secrets for Actions in Settings.

Hello @DeepanshuA, can you also please add a documentation on maintaining this new secret and how to generate it? Similar to https://github.com/dapr/dapr/blob/master/docs/development/setup-ci.md

Cert test coverage isn't meaningful. We should not optimize for this. Only the Union of unit tests and cert tests matters, but cert tests do not need necessarily high coverage by themselves. For example we should not test things again already covered by conformance tests.
Also any way you can make the discord step not fail, even if the notification fails? The test run shouldn't show up as a failure because of discord!


Alzheimer's Tutorial

I'm very interested to employ your elegant approach and started wth the tutorial.  Everything works except for these lines:
top_genes_per_cell_type[cell_type] = results_tmp.index[:num_top_genes]
    de_results[cell_type] = set(results_tmp.index)

I get these types of errors:

NameError: name 'top_genes_per_cell_type' is not defined

Any suggestions?

Hey @JBreunig,
I just took a quick look at the notebook, and it looks like that variable top_genes_per_cell_type isn't actually used anywhere so you should be able to remove it/comment it out. Let me know if that fixes the issue.


Moved the HTTP API docs from Apiary to /docs

I moved the documentation of the client-server HTTP API from Apiary to our source tree (in /docs, i.e. our documentation using Sphinx). I used the sphinxcontrib-httpdomain extension.
The HTTP API seems a bit broken right now, so the example GET request is made up and I wasn't able to figure out a working new-transaction POST. Those are left as TODO items. When someone fixes/improves the current HTTP API, they can fix and augment these docs accordingly.

[Current coverage][cc-pull] is 89.87%

Merging [#442][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #442   diff @@
==========================================
  Files            18         18
  Lines          1274       1274
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1145       1145
  Misses          129        129
  Partials          0          0

[][cc-pull]

Powered by Codecov. Last updated by [7de9b17...ac4912b][cc-compare]
[cc-base-branch]: https://codecov.io/gh/bigchaindb/bigchaindb/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/bigchaindb/bigchaindb/compare/7de9b1711f4a63e6613e3a9d57bb05593ecd1b41...ac4912b40937fca98e6e604dfdedc0bb9ea41be8?src=pr
[cc-pull]: https://codecov.io/gh/bigchaindb/bigchaindb/pull/442?src=pr

It renders nicely :+1: