bug(MatDatePicker): Datepicker label overflows over Icon

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
14.2.7
Description
Currently updating from v. 14.2.7 to 16.2.7 (16.2.8 on stackblitz), and I noticed that the date picker isn't handling long labels correctly. Instead of showing an ellipsis, it's overflowing to behind the calendar icon. See examples below:
Version 16.2.8 (bad): https://stackblitz.com/edit/8enoqa?file=src%2Fexample%2Fdatepicker-overview-example.html

Version 14.2.7 (good): https://stackblitz.com/edit/c2yh3u?file=src%2Fapp%2Fdatepicker-overview-example.html

Note: Version 15.2.9 is also showing an incorrect label.
Reproduction
StackBlitz link: https://stackblitz.com/edit/8enoqa?file=src%2Fexample%2Fdatepicker-overview-example.html
Steps to reproduce:

Wrap a datepicker in a div with a set width.
Set mat-form-field width to 100% of the parent width.
Set label to be longer than available space.
Observe label filling entire input, including icon space, instead of overflowing with ellipsis

Expected Behavior
The label should fit in the allotted space and not show behind the calendar icon.

Actual Behavior
The datepicker label is filling the entire input, behind the calendar icon.

Environment

Angular: 16.2.7 / 16.2.8 (stackblitz)
CDK/Material: 16.2.7
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows

I found a workaround for this issue, adding this scss rule:
label.mat-mdc-floating-label {

    &:not(mdc-floating-label--float-above) {
        width: 100%
    }

    mat-label {
        text-overflow: ellipsis;
        overflow: hidden;
    }
}


[python] Refine pyenv based virtualenv management

Proposed Changes
Now that pyenv plugins availability is detected by directly probing
'pyenv', we need to rely on the same mechanism consistently.
Further, we perform available plugin scan with zsh native techniques
instead of relying on external commands.
Followup to #1433

/cc @zachwhaley, @gpanders, @diraol, @belak

Quality as always. Looks good to me at a glance @indajitr.

Thanks for the review guys!


[docs][bug] Each accordion panel with content expanded on page load on {Element} > Code pages

Description
If you visit a Code page of any element and scroll down to any of the <rh-accordion>'s on those pages, each accordion panel is expanded on page load.
Screenshots

Steps to reproduce

Visit any Element on uxdot.
Once you're on the Overview page, click on "Code" in the subnav. Eg: Alert > Code.
Scoll down to view the accordion containing docs for slots, attributes, methods, events...
Observe how any accordion panel that has content is expanded.

Expected behaviour
Accordion panels should be collapsed on the Code page on initial load.
Operating System (OS)
macOS
Browser
Safari, Microsoft Edge
Additional browser or assistive technology info
Interestingly, <uxdot-copy-permalink> is not working on Code pages either.

the idea here was to expand only those panels which have API content, in order that ctrl-f works. This aids discoverability, so that users won't be confused about which APIs are available on elements.


CLI should check for minikube cluster status before getting gateway address

If the minkube cluster is stopped we should not get the http-gateway address from minikube, we should use kubectl to locate the service or maybe assume localhost.
$ minikube status
minikube: Stopped
cluster:
kubectl:

Also see #547

This issue has gone stale, we're on Knative now! Please reopen if still relevant.


Do not print row count on failures

Fixes #3015

@electrum printRows(ImmutableList.<List<?>>of(), true); is passing an empty list and hence effectively calling writer.flush() which we already call in flush(), then why do we still need to call it? Or I missing something here.

also added writer.close() calls.


Factor humidity into weather prediction

On the few devices with humidity sensors, it would be useful if the humidity factored into the algorithm for weather prediction to better determine when a storm is incoming.

Not going to implement.

Frequency of use (ex. edge case) vs effort to implement


fixed a small bug with googleplus color not showing

Let me ask the original repo owner if his repo is still maintained. If not, I can probably maintain and keep this repo up-to-date.

I noticed that he merged your pull request afterwards. Would've made a pull
directly to joshowens had I realised
On 26 Jul 2015 11:32 pm, "lovetostrike"<EMAIL_ADDRESS>wrote:

Let me ask the original repo owner if his repo is still maintained. If
not, I can probably maintain and keep this repo up-to-date.
—
Reply to this email directly or view it on GitHub
https://github.com/lovetostrike/shareit/pull/1#issuecomment-125036428.

Yea, I think the new version isn't released yet though.


Quest issue: Life and Destruction

After capturing Xerneus and returning to the weird forest I'm told to search for clues. It says look for the suspicious grass (indicated earlier in the quest with black clocks). The clocks used to indicate that are invisible. I hit them and they showed up, but I don't know if they will persist that way through a reset.
It makes this portion of this quest very difficult.

Clocks were replaced with cool grass, nice!


Register audio and image models consistently in admin panel

Fixes

Fixes #919 by @krysal
Description

This PR

ensures that images and audio have all reporting models registered in the admin panel
adds checks to ensure non-existent identifiers cannot be reported
distributes concerns from the central _Report models to the Deleted_ and Mature_ models
ensures that the changes to mature status are synced to Elasticsearch
surface mature field in the details endpoint for WordPress/openverse-frontend#1822
limits admin functionality to encourage correct usage of reporting flows
adds documentation where it was lacking
implements general refactors and makes code quality improvements

Testing Instructions

Check out the PR and run all services.
Visit the Django admin panel.
See new models present.

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Hmmm, I'm not able to get my local API to spin up. It hangs waiting for the image index to be ready. I'll debug this a bit more later today so I can finish this review.

Hmmm, I'm not able to get my local API to spin up. It hangs waiting for the image index to be ready. I'll debug this a bit more later today so I can finish this review.

FWIW a just recreate worked for me! This might be an issue with the ingestion server, RE #417

FWIW a just recreate worked for me! This might be an issue with the ingestion server, RE https://github.com/WordPress/openverse-api/issues/417

Nah, for me it's because my disk is too full and ES won't let you add or modify indexes if your disk is above 95% full :sweat_smile: Working on moving some things around to fix this issue. I have been successfully ignoring it for a long time.
Should be able to finish reviewing this soon.

@sarayourfriend if you do just down -v that will delete the ES volume and free up space.

@sarayourfriend if you do just down -v that will delete the ES volume and free up space.

Yeah, that didn't work. Based on the logs I was seeing ES was measuring the available disk space on the host device, somehow. My main drive is filled to 97% so I'm moving some things off to external drives now to see if it'll fix the situation.
This is entirely a problem of my own creation and nothing to do with this project specifically. Sorry, just gotta bear with me a moment on this one.

Fixed in 1f5aee8. I had not initially done it because Django requires a migration when you change the plural name so the tradeoff didn't seem worth it.
Rearranging is possible but it is significantly complicated and will increase the scope of the PR by a lot. Will create a separate issue and PR to address this.
Deleted images are not reindexed because during the data refresh we exclude all identifiers for which we have a DeletedImage or DeletedAudio model instance.
Since the identifier UUID is a primary field changing it from the admin makes Django think you're working with a new instance and doesn't affect the old one. Fixed in 41a5339.


Video Canvas Should be optional for player

If you want to use the player to play sound, you probably don't want to draw to the screen, and don't need a video-canvas. As such, it should really be optional. And also should be able to be set as a parameter  when constructing the video-player-server% object.

Commit c11010d77102f5e6697e9c5ce340cf3bfd491ca5 fixes this.


Select New Task for Mentors/Mentor Manager-Admin-App - Sprint 2

Description:

Build the Screen using the style guide.
Integrate Screen with the Backend

Hello @Honeyloveet, I'll like to work on this. Kindly assign it to me. Thank you


Null check on data row

Should resolve #16
I added a test for this to ensure appropriate fix.
Thanks @mtimofiiv

:shipit:


How to use require instead of import?

Hi,
I'm trying to access this from Node-Red which is based on Node.js
The system allows me to simulate require whereby I can import the entire module as a variable instance.
However, the example wants to import two variables from the module, so I don't know where to go from here.
I tried assigning parseDomain as the variable representing "parse-domain" , but it didn't like that, saying it wasn't a function
I then tried assigning parse-domain to pd and accessing pd.parseDomain  but that gave me "TypeError: Cannot read properties of undefined (reading 'parseDomain')".
As you can see, I am not much of a Javascript programmer!
Any advice would be much appreciated!
B.

After further research, it turns out that I can't do what I want because currently Node Red does not support anything but Common JS modules.
Is there any hope that you could somehow provide that as an alternative?
B.

I'm sorry, we switched to ECMAScript modules only with v6.0.0 (https://github.com/peerigon/parse-domain/releases/tag/v6.0.0). You can try a version below v6.0.0 but the list of domains will be outdated.
You should also be able to import ECMAScript modules asynchronously into CommonJS:
import("parse-domain").then(({parseDomain}) => {
  // This gets executed once the module is loaded
  // You can call parseDomain() now
}):

I know you closed this, but I have to ask:  What do you mean by V6.0.0 ? (I told you I was inexperienced!)

I'm going to write this off, since on past performance I won't get a reply until 2024.
Your unexplained solution returned
TypeError [ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING]: A dynamic import callback was not specified.
So bugger it.

@bwims there was a colon instead of a semicolon, but besides that this code snippet works. You can try it out here: https://stackblitz.com/edit/stackblitz-starters-cmcjne?file=index.js (run node index.js)

Your error suggests that your code is running inside a Node VM. There's more going on in your setup which makes it hard to debug.

So grateful for your quick reply!   I am using Node Red, which is a low
code development system based on message flow through nodes.  It's based on
Node-JS and it allows you to introduce your own javascript via a function
node and that allows use of imported routines.  Unfortunately, I have no
knowledge of the internals, so I guess if you aren't familiar with NR I am
out of luck!
Thanks
B.
On Mon, 30 Oct 2023 at 08:44, Johannes Ewald @.***>
wrote:

Your error suggests that your code is running inside a Node VM
https://nodejs.org/dist/latest-v20.x/docs/api/vm.html. There's more
going on in your setup which makes it hard to debug.
—
Reply to this email directly, view it on GitHub
https://github.com/peerigon/parse-domain/issues/151#issuecomment-1784728284,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AENIQ2LOFYF7RG3YV5TM6OTYB5SF3AVCNFSM6AAAAAAWWRMHA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUG4ZDQMRYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


How to run downstream tasks automatically when rerun the upstream task?

A -> B
task B depends on task A.
when we rerun A, how to run the downstream tasks?

clear A with the "including downstream" option, then either let the scheduler pick up the tasks. You can do it from the UI or CLI.

What if C depend A using ExternalTaskSensor in another dag?
Can CLI deal with this situation?


Update Cargo.toml with latest versions

tested the app with signoz with the latest versions, works fine

@prashant-shahi @pranay01 @srikanthccv for review


add the ability to toggle break-on-all exceptions

Add the ability to toggle break-on-all exceptions.

probably as a dropdown expanding menu in the debugger view
the setting should persist between sessions

Is there any workaround currently to disable this behavior somehow?

You can toggle it in the settings for the dartlang plugin.

Should've looked there in the first place. Thanks so much!
P.S: Also found experimental "type information tooltip", which is amazing!


Switch from segmentation_models_pytorch to torchseg

It appears that segmentation_models_pytorch is no longer maintained. minerva uses it for providing a library of segmentation models for testing and experiments. However, it is pinned to a now quite old timm==0.9.2 which is now causing conflicts with other dependencies.
The solution it seems is to switched to an actively maintained fork of segmentation_models_pytorch called torchseg

segmentation_models_pytorch is now maintained again and has updated its dependencies. There is thus no need to move to torchseg.


Feature request: Support G-Suite/LDAP/SSO for login

I would like to roll out Bashhub server for my entire company. We use Google/G-suite for SSO. It would be incredible to be able to authenticate using LDAP or G-Suite SSO.
Thanks again for writing this!

So I have been doing a bit of thinking on this and I haven't been able to come up with a good way to implement it. It would be different if bashhub-server handled the sign-in process but other than providing endpoints and creating tokens it doesn't, the bashhub-client does.  If you or anyone else have any thoughts on a good implementation I'd love to hear it because this would be pretty cool/convenient
to have.
Thanks again for using it!


test(autoware_testing): fix smoke_test

Related Issue(required)

Related #389
Description(required)

Fixed a problem that caused the tested node to terminate with an error while running a smoke test.
In the code before the change, this affected the issue where code coverage could not be obtained.
(Code coverage is not measured unless the process under test terminates without error.)
Obtaining code coverage is an aid in test design because it allows us to see which paths in the code have been tested.
There is another aspect to this issue. Currently, the test is passed by adding an acceptable return code, but this means that the return code will be different for normal Node startup and testing. The test specification is supposed to be "sending SIGINT returns return code 0 (normal completion)," but this means that the test allows different behavior from the specification.
Review Procedure(required)

Related PR(optional)

Please check the test on CI. If this PR is okay, it should exit without error.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Read commit-guidelines
[x] Assign PR to reviewer

If you are adding new package following items are required:

[ ] Documentation with description of the package is available
[ ] A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Some Nodes need to support multiple parameter files to execute without errors. Therefore, I modified smoke_test: ae9ce3100

@KeisukeShima Could you resolve conflicts if you are still working on this PR?

@wep21 I have resolved the conflicts. And it is ready for review.
Could you review this PR?

I've changed the title from fix to test.


Add converting batches to NetCDF and saving them out

Pull Request
Description
This PR adds support for converting multiple input dataarrays/datasets into a single Dataset to save it out as NetCDF. This is to help with #231 and make batches more interpretable on disk .
Fixes #237
How Has This Been Tested?
Unit tests

[x] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

This has the start of windnet forecasting, but mostly is just adding how to combine and uncombine the output from PVNet datapipe to save to NetCDF, and load it from that.


feat: speed up rollback command

Update

I did a cleaner version: https://github.com/cosmos/iavl/pull/636


[folding] Increase number of foldable regions

Please increase the maximum number of foldable regions.
Pull request #140480 implements a configurable number of foldable regions which is great, but it's limited to 65000 which is too small - I regularly open large lua table dumps and huge log files and get the "The number of foldable regions is limited to a maximum of 65000" message several times a day.
I appreciate performance may be affected, but I want to turn the knob until it hurts... I am not noticing any issues at 65000 on even modestly specced PCs.

@aeschli The underlying issue causing this limit is of course the storage of parent indexes in the FoldingRegions class. They're stored as 16 bits in two parts of 8 bits each. We could increase that but doing so would require at minimum changing the startIndexes array to Uint64Array. Better would be to just add a separate array to store parent indexes at the same memory cost. Which seems cheap enough. Would you like me to do that?


Purpose of optional fields

The position and chromosome are not required, what are the consequences of including or excluding these for the scoring?

Sorry for the late reply. These are just used for keeping track of things, they do not affect scoring.


Platypus Finance - Platypus Venom Contract -- is this all thats required for a contribution?

I would love to contribute to this collection!
Not sure if this is all thats required, I just took a look at some of the other contracts submitted.
Honestly I have no idea what userdoc and devdoc are?
Can we use a nice name for the record, or should it always match the smart contract?
See below, the contract is called OptimizedTransparentUpgradeableProxy but it is listed as Platypus Finance: Platypus Venom as the public name. A layman user is probably going to want to see the Platypus Finance label, not the OptimizedTransparentUpgradableProxy one.

Contract

https://snowtrace.io/address/0x5857019c749147eee22b1fe63500f237f3c1b692#code

0x5857019c749147EEE22b1Fe63500F237F3c1B692.json
{
  "name": "OptimizedTransparentUpgradeableProxy",
  "chainId": 43114,
  "address": "0x5857019c749147EEE22b1Fe63500F237F3c1B692",
  "metadata": {
    "output": {
      "abi": [{"inputs":[{"internalType":"address","name":"initialLogic","type":"address"},{"internalType":"address","name":"initialAdmin","type":"address"},{"internalType":"bytes","name":"_data","type":"bytes"}],"stateMutability":"payable","type":"constructor"},{"anonymous":false,"inputs":[{"indexed":true,"internalType":"address","name":"implementation","type":"address"}],"name":"Upgraded","type":"event"},{"stateMutability":"payable","type":"fallback"},{"inputs":[],"name":"admin","outputs":[{"internalType":"address","name":"","type":"address"}],"stateMutability":"nonpayable","type":"function"},{"inputs":[],"name":"implementation","outputs":[{"internalType":"address","name":"","type":"address"}],"stateMutability":"nonpayable","type":"function"},{"inputs":[{"internalType":"address","name":"newImplementation","type":"address"}],"name":"upgradeTo","outputs":[],"stateMutability":"nonpayable","type":"function"},{"inputs":[{"internalType":"address","name":"newImplementation","type":"address"},{"internalType":"bytes","name":"data","type":"bytes"}],"name":"upgradeToAndCall","outputs":[],"stateMutability":"payable","type":"function"},{"stateMutability":"payable","type":"receive"}]
    }
  },
  "version": 1,
  "checkPoints": []
}

Thanks, please open an PR for this :)

No worries, will do, but did you see my question - Can we use a nice name for the record, or should it always match the smart contract?

No worries, will do, but did you see my question - Can we use a nice name for the record, or should it always match the smart contract?

sure, please pick the name you like.

Sorry I will open a PR for a few of these when I get a chance. Cheers


Welcome page opens while I am starting to type in a python file

Issue Type: Bug
Repro

Install python extension
Open python file and start typing

Bug
While I'm typing, the welcome page pops up and interupts me. This seems to happen around 2-5 seconds after I first open a python file.
Extension version: 2020.9.114305
VS Code version: Code - Insiders 1.51.0-insider (7a3bdf4ee9588755d447aa1c3b5db4a123fc11a9, 2020-10-23T07:32:22.213Z)
OS version: Darwin x64 19.6.0

Thanks for bringing it up 😊 we're working on a new design proposal for the start page, and part of it involves the start page being open to the side and not steal focus.

https://github.com/microsoft/vscode-python/pull/16834

Start page has been removed, see https://github.com/microsoft/vscode-python/issues/16678, https://github.com/microsoft/vscode-python/pull/16791 and https://github.com/microsoft/vscode-python/pull/16834.


#111 Cross compile to Scala 3

Codecov Report

Merging #112 (a19f2e3) into master (08cbfa2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #112   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           41        41
=========================================
  Hits            41        41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08cbfa2...a19f2e3. Read the comment docs.


Box variant for pallet calls

This way the size of the pallet calls are not "shared", some pallet can have very big calls while some other keep small ones, they don't all inherit the size of the biggest pallet call.

the consequence are a slight similar to https://github.com/paritytech/substrate/pull/9339

Damn but that requires lot of change every time we match on the pallet call variant :-/

for me best solution was still https://github.com/paritytech/substrate/pull/9339


Added argument passing to invalidate method

I saw, that the authenticate method passes the arguments into the authenticator. But the invalidate method does not do that. So I simply added the arguments into the method call to enable the same behaviour as seen in the authenticate method.

What's your use case for this? This would also need a test ;)

I have certain cases in which I know the backend will revoke the session (Platform-Update, etc..) and need to invalidate it on client side without doing a server call. Also you can send additional data on the logout (leaving message) or build advanced logic into the invalidate call.
I'll write tests for this in the next days :+1:

@leuprechtroman i just did a pull request to your fork with a test case for this feature.

@hajjem-ayoub  Thank you so much!
I updated my repo, included the tests and made everything pass the tests.

Thanks for your feedback, I've adapted everything according to it!


Timeout when download file

Cannot download file from http://deoss-pub-gateway.cess.cloud/ these days, it was good before, please help to check
    const res = await axios.get('http://deoss-pub-gateway.cess.cloud/75a3d8fad3d5d2d26b4530c4aefeca8dc7f871ed61175834da285b581d44307f', {
        headers: {
            Operation: "download",
            Account: "cXhwBytXqrZLr1qM5NHJhCzEMckSTzNKw17ci2aHft6ETSQm9",
        },
        responseType: "stream",
        onDownloadProgress: (progressEvent) => {
            if (progressEvent === undefined || progressEvent.total === undefined) return
            const percentCompleted = Math.round((progressEvent.loaded * 100) / progressEvent.total);
            console.log(`progress: ${percentCompleted}%`);
        },
    })
    const outS = fs.createWriteStream('./temp.mp4')
    res.data.pipe(outS)
    console.log(res.data)

Response:
esponse: {
    status: 504,
    statusText: 'Gateway Time-out',
    headers: Object [AxiosHeaders] {
      server: 'nginx/1.22.1',
      date: 'Wed, 15 May 2024 09:30:46 GMT',
      'content-type': 'text/html',
      'content-length': '4020',
      connection: 'close',
      etag: '"639e5807-fb4"'
    },
...

@EF09FE Our public gateway bandwidth has been exhausted. We suggest trying again later, or you can start a gateway service yourself.


Updated: mark-text <IP_ADDRESS>

Newer version of mark-text (<IP_ADDRESS>4) is now available in master.


ICANN verification of contact information

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 840fd195-aec1-bb94-7d7e-12b80345701b
Version Independent ID: 875f23b9-b3e4-c1a2-5f78-de963d6f0ce9
Content: ICANN verification of contact information - Microsoft 365 admin
Content Source: microsoft-365/admin/misc/icann-verification-of-contact-information.md
Service: microsoft-365-business
GitHub Login: @nataliekagole
Microsoft Alias: nkagole

The office 365 support link isn't working. The link doesn't seem to be active

@msbemba

@samsonmobisa  This looks like a technical issue/bug, you will need to report it to the support team via the need help section on the admin center. So that a technical support engineer can fix this.
Hope this helps!
Thanks
Sri

Tried to use a link in a certain article but didn't seem to work. Can you
please share with me a link to support team
On Thu, Jun 22, 2023, 5:53 PM Sriraman M S @.***> wrote:

@samsonmobisa https://github.com/samsonmobisa This looks like a
technical issue/bug, you will need to report it to the support team via the
need help section on the admin center. So that a technical support engineer
can fix this.
Hope this helps!
Thanks
Sri
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/microsoft-365-docs/issues/12274#issuecomment-1602782592,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWBEA73BSBQUR6E5HIL4FL3XMRL5DANCNFSM6AAAAAAZMMR7P4
.
You are receiving this because you were mentioned.Message ID:
@.***>

@samsonmobisa  https://support.microsoft.com/en-us/topic/contact-microsoft-office-support-fd6bb40e-75b7-6f43-d6f9-c13d10850e77#:~:text=Sign in to Microsoft 365,-free%2C US only).
This is the link to contact support
Hope this helps!
Thanks
Sri


How to create pull request

actually all up to date → one step is missing @bmen :
Between 6 an 7 → Step: perform Review → this can also be a separate Guide but is the most used step for LEAD e.g. (we'll be using this a lot for each new Profile as the quality check is very relevant here and done by not so technical people as well)


Twitter Clone

This is a twitter clone supporting twitter like CRUD operations

I'm merging your project please create another pull request after listing your project in the index.html files of the repo


remove negative connotation

Description

The README makes reference to steroids, which could be misconstrued as a negative connotation. It doesn't add a lot of value to the tool either, so I'm thinking we could probably do without.
Related Issues

Motivation and Context

I think it does more harm than good. Removing those words makes the README much more amicable.
How Has This Been Tested?

No test required. Docs only.
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (improves code quality but has no user-facing effect)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Documentation

Readiness Checklist

[ ] My code follows the code style of this project
[x] My change requires a change to the documentation
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

@nrichers What do you think?

@karencfv @nrichers Thanks! I've updated the straggler and squashed into a single commit.


DirectShow support?

Hi @jakky1 many thanks for your package.
I am looking for a simple package to play HAP video files on Windows.
I understand your package only supports Media Foundation codecs. I'm no expert in video but I learned that HAP requires DirectShow, even with K-Like codecs installed.
Would it be possible to add support for DirectShow?
Thank you

No.
Directshow is deprecated since Vista (even though it still works on Windows 11 ...),
so this package will not support Directshow.
But, I think (not sure) Media foundation can use Directshow codec.
Maybe you can try it.


Refactor truststore logic into own package (1/2)

This PR creates a new package duplicating the truststore logic into its own package.
My intent is for a subsequent PR to refactor main() to use the truststore package, and remove truststore logic from the main package.

Following. Is this much different from https://github.com/smallstep/truststore ?


Header search

Solves: https://github.com/franksparks/BookJourney/issues/10
WIP

Closing in favor of: https://github.com/franksparks/BookJourney/pull/19


Ability to deploy Meshery on Istio

Current Behavior
Meshery does have deployment artifacts to deploy Meshery and its ecosystem on Kubernetes. There is also a Istio yaml which contains virtual service and gateway definition.
Expected Behaviour
We need to ensure the deployment succeeds and works the expected way on Istio.

We were able to test Meshery and its adapters on Istio. The change that came out of this session was the Gateway port change from 8080 to 80 to avoid adding more ports to the ingress gateway service.

@girishranganathan this was closed as a duplicate of #442, right?


Goal Codes flow for credential and proof still has the contact screen display

When using Goal Codes in QR Code invites for either cred issuance or proofs, as in the BC Wallet Demo Showcase, still has the contact screen flicker onto the screen for a fraction of a second. It almost feel like a glitch rather than part of the flow. Maybe we should not go to the Contact screen?
However, what if the request or proof never comes, even if it was the goal? In that case it should go to the Contact screen.
See attached video for how it now behaves.
https://github.com/bcgov/bc-wallet-mobile/assets/44370861/6c62db2f-9c1e-4acb-b92d-e57e18cd2fd7
Severity
Low

I'm taking a look at the code right now, so it looks like the flicker is on the connection screen rather than the contact screen. The loading screen is a part of the Connection screen. I definitely agree it looks clunky but I don't think the issue has to do with the navigation. I think the waiting screen is a modal or something that gets animated after the connection screen is mounted. I'll remove the header from the connection screen and fixup the modal and that should get rid of the issue

I can't seem to reproduce this anymore, are you still able to @nodlesh ?


Mention how to install tree-sitter-cli in README

When I run ./bin/ensure-lang python, it returns an error
Running 'tree-sitter test' for python
./bin/ensure-lang: line 35: tree-sitter: command not found

And I went out to search how to install tree-sitter's cli.
It would be nice if you mention that tree-sitter-cli is required and how to install it.

I updated README in https://github.com/ubolonton/emacs-tree-sitter/commit/21100b9e90ebf1ca585cbf334c14d6b51999ffd1


mac osx interface

hello again.
now that i got multiple teensy s running with your flexcan code i am thinking about how to get my computers host software to talk to the devices.
i guess the simplest would be to communicate over serial usb to the teensy and have the teensy then communicate with the can network.
but there are these usb-can devices out there like this one http://canusb.com.
what is your recommendation? do you know of a library that i could tap in to?
thanks again.

I believe the FlexCAN library thread on the PJRC forum will be much better place to ask this kind questions
https://forum.pjrc.com/threads/25101-CAN-Bus-Library-for-Teensy-3-1


Unable to login with mongodb config

Bug report
Hello @bahdcoder  I just made complete backend in Tensei, I was amazing... But now i have changed the db to MongoDb. How ever, I am unable to login now. What could be the reason and what I can do in this matter?
This is my package.json
{
  "name": "tensei-awesome-app",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "dependencies": {
    "@mikro-orm/mongodb": "^4.5.6",
    "@tensei/auth": "^0.8.4",
    "@tensei/cms": "^0.8.4",
    "@tensei/core": "^0.8.4",
    "@tensei/graphql": "^0.8.4",
    "@tensei/media": "^0.8.4"
  },
  "scripts": {
    "dev": "nodemon src/index",
    "start": "node index.js"
  },
  "devDependencies": {
    "@mikro-orm/sqlite": "^4.4.0",
    "nodemon": "^2.0.7"
  }
}

Index.js
const { cms } = require("@tensei/cms");
const { auth } = require("@tensei/auth");
const { media, files, file } = require("@tensei/media");
const { graphql } = require("@tensei/graphql");
const {
  tensei,
  welcome,
  resource,
  text,
  integer,
  hasOne,
  textarea,
  belongsTo,
  belongsToMany,
  hasMany,
  date,
} = require("@tensei/core");

tensei()
  .root(__dirname)
  .plugins([
    welcome(),
    cms().plugin(),
    media().plugin(),
    auth()
      .rolesAndPermissions()
      .plugin(),
    graphql().plugin(),
  ])
  .databaseConfig({
    type: "mongo",
    dbName: "khelo_ka_raja",
    clientUrl:
      "mongodb+srv://mystring",
  })
  .start()

  .catch(console.error);

Everything works just perfectly removing the db config. This also dosent show any error. Can you please help me in this? It would be great as I am in a hurry.
Regards,
@Manjit2003

Did anyone else manage to solve this issue? Actually its quite urgent as of now...

Hello. I actually worked and resolved this. Can you upgrade to the latest versions ? Let me know if it works out. It should.
So sorry for the long break. I'm back now and a team will be joining 🙏

@bahdcoder Isn't 0.8.4 the latest version? If not so can you please guide me a little 🤏🏻.. It would be great
Thanks for reply

Yes that's the latest. Still getting an error ? Please share it 🙏

Also you'd have to delete that admin user and create a new one again.

Steps to reproduce :

Create a tensei app with following code:

const { cms } = require("@tensei/cms");
const { auth } = require("@tensei/auth");
const { media, files, file } = require("@tensei/media");
const { graphql } = require("@tensei/graphql");
const {
  tensei,
  welcome,
  resource,
  text,
  integer,
  hasOne,
  textarea,
  belongsTo,
  belongsToMany,
  hasMany,
  date,
} = require("@tensei/core");

tensei()
  .root(__dirname)
  .plugins([
    welcome(),
    cms().plugin(),
    media().plugin(),
    auth()
      .rolesAndPermissions()
      .plugin(),
    graphql().plugin(),
  ])
  .databaseConfig({
    type: "mongo",
    dbName: "khelo_ka_raja",
    clientUrl:
      "mongodb+srv://mystring",
  })
  .start()

  .catch(console.error);

Goto http://localhost:8810/cms it will ask you to create a new admin.
Enter your email and click the link it sent you.
Upon clicking the link, It will redirect you to http://localhost:8810/cms/auth/login.
Then if you enter your email there, then it will again send you a magic link.
Then upon clicking the magic link, you will be again redirected to http://localhost:8810/cms/auth/login.
This keeps recurring...

Still unable to login even after flushing the whole DB also tried by deleting admin user

Thank you for sharing. I'll have a look again as soon as I can.

Thanks, will be eagerly waiting...

@bahdcoder were you able to reproduce the issue??
Thanks

Yes I was. Still trying to find a solution. Working on it today 🙏

@bahdcoder Thanks for ultra fast reply ⚡.... Will be eagerly waiting

@bahdcoder any update brother? Actually, this was quite urgent...
Thanks

@Manjit2003 so sorry this is taking long. I found the bug, but its a crazy one and I can't seem to figure out how to fix. Its only affecting mongodb and its really weird. sorry its delayed you and your goals.
I'll keep working on fixing it.

@Manjit2003 finally found the bug and fixed it. Was a problem with one of our internal packages. Error should be fixed now. Thank you very much for your patience 🎉

Thank you very much brother for your help 🙏... You have done an excellent job and it means a lot to us... Keep it up and all the best for future


CARDS-1868: As an admin, I can configure the clinician dashboard

Contains subtasks:

CARDS-1840: As an administrator, I can disable the dashboard boxes' time grouping tabs
CARDS-1838: Make the wording on the clinic dashboard configurable

Do we want the settings to be per clinic?

Maybe later, let's see if the usecase comes up.


In period picker

Is your feature request related to a problem? Please describe.
I need to disable dates, that are out of given period, for example i picked june 2024, so i cant pick any month that is out of 2024
Describe the solution you'd like
Disable any pickable dates that are out of given period (year/month) on range start
Describe alternatives you've considered
Disabling button on range start and enabling on range end

@nick-shaydayuk You can use min-date and max-date props to handle this behavior. You can listen on selected date from internal-model-change event


docs: add instructions on how to contribute to documentation in readme

Description
In this pull request, I have made the following changes:

Added instructions on how to contribute to AsyncAPI Docs in README.
Checked the links and included a reference to detailed documentation. No issues or errors were identified during testing.

Related issue(s)
Resolves #2561

closing because this is being handled via the TW Onboarding Guide


Enable Pagination for Result Sending

Although the front end table has a pagination feature, the back end will send all results at once to the front end.
The task is to modify the back end's behavior and make it send only one page at once. It should only send the next page when the user clicks the next page button on the front end.

The server will currently send the first page of the result, the total count, and the total page count to the front end.

Looks like nz-table has built-in server-side pagination feature.
https://ng.ant.design/components/table/zh#components-table-demo-ajax

Basic functionality is implemented.

Some known issues:

The event for PaginatedResult is not put in TexeraWebsocketEventTypeMap. Tried adding PaginatedResult into TexeraWebsocketEventTypeMap but for some reasons the type won't match. Current workaround is casting the event into unknown and then casting into PaginatedResult (which is a bad practice).
const paginatedResult = websocketEvent as unknown as {
  paginatedResults: Array<{
    operatorID: string,
    table: Array<object>,
    totalRowCount: number
  }>
};

If the result panel is closed or the view result operator is deselected (which causes the result panel to clear all its data), the pagination status is cleared (i.e. when opening the panel next time, it will start from the first page regardless what page it previous is on).

Now the page will be preserved.

Close this issue because the corresponding pull request #903 is merged.

Close this issue because the corresponding pull request #903 is merged.


Integrate Dev Wallet

Description
This PR integrates the dev-wallet server into the CLI. This is the beginning of the tools section in the CLI and more will follow. Integration is straightforward since the dev-wallet itself is a module according to the PR https://github.com/onflow/fcl-dev-wallet/pull/100
WIP because I'm waiting for dev-wallet to be fixed so it can be built as a static bundle.

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[ ] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

This is blocked until fcl-dev-wallet is refactored in a way it can be statically exported into a bundle.

Codecov Report

Merging #467 (0ac4456) into master (a622a4f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   54.99%   54.99%
=======================================
  Files          37       37
  Lines        2002     2002
=======================================
  Hits         1101     1101
  Misses        757      757
  Partials      144      144

Flag
Coverage Δ

unittests
54.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/flowkit/arguments.go
25.97% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a622a4f...0ac4456. Read the comment docs.


Update 'About' page with Science Advances publication instead of ArXiv link

https://advances.sciencemag.org/content/7/29/eabe6534

Please also update the EPJ paper:
https://epjdatascience.springeropen.com/articles/10.1140/epjds/s13688-021-00271-0

And the COVID ngrams paper:
https://journals.plos.org/plosone/article?id=10.1371/journal.pone.0244476


Exclude scssc from manifest

Fix #4244

Coverage increased (+0.009%) to 87.737% when pulling d045d66f3a373a266dcd199e23c2f4611ac730b9 on yakky:feature/remove_scssc into 27045ad2ab1b37e2b4b26cb073e3a4d11f522dd2 on divio:support/3.0.x.


BUFR master table version udpate

Addresses https://github.com/wmo-im/csv2bufr/issues/123

Now included in another PR.


Error at objects.txt

Sir, i got the datasets, but i am getting error at this point , how to rectify
file_path = '/media/aalok/Zone_B/ashish/PS_Datasets/DiLiGenT102/objects.txt'

pls reply sir


Firefox doesn't submit correct value

Similar to #21, on Firefox 49.0.2, the value 09/19/2016 is submitted instead of 2016-09-19. I'm not sure if I got what you meant by the browser submitting the input text instead of the underlying value, but if I inspect the element on Firefox, the underlying value is on the format 09/19/2016 as well (differently than on Chrome without the polyfill, where it's the expected 2016-09-19).
You can see where it's breaking by going on https://fda.opentrials.net with Firefox and adding the start date/end date filters.

Did you reference the usage notes to ensure that the value is being used in the way that the polyfill can support?
In my tests on Firefox 52, accessing the value property of the input element produces the expected YYYY-MM-DD string.  Same with the link that you sent (although that may have been modified since).
If you can still reproduce this with an unmodified version of the polyfill, please comment.  Closing for now.


readme: fix TOC for Privacy & license info section

Signed-off-by: Luís Ferreira<EMAIL_ADDRESS>

Thanks! :heart:


[6.x] Fix assertEquals misordered arguments

This PR fixes assertEquals arguments order in tests. First argument is expected value. In case of error it will produce incorrect error message. It looks like assertSame doesn't have this issues.
This changes could be automatically merged to 6.x, 7.x and 8.x as well.
Replaces PR against 8.x: #34663

tests/Events/EventsSubscriberTest.php has 2 more issues, but it was added in 7.x so I will push it as separate PR after this one will be merged.

Is this easily mergable -> 7.x -> 8.x?

Yes, I've tried to change branches to 7.x and 8.x and GitHub said that it could be automatically merged.

Just send to current branch please.

@taylorotwell master or 8.x? Because it is already was in 8.x at the start.

@antonkomarev he means 8.x :)

Thanks @driesvints will do it today evening.


subject is hardcoded somewhere?

I always see "subject of the conversations" when I look up the messages later.  Even thought I'm 9x% confident I changed in the source code...

@arechnitzer and I also tested this, cannot reproduce as stated.
I made a mistake and used this exactly subject on my first message of the term.  I think what is happening here is that Canvas presents the conversation in a vaguely threaded way, even when I started a new conversation...
So all my personal messages for the term are labelled as "Whatever the first subject was"...  If anytthing this is a Canvas UI bug.


[Bug]: Wrong endpoint used for Atlassian token exchange

Package
@lucia-auth/oauth
Describe the bug
Hello, as per the Atlassian's documentation, the endpoint that should be used for the access token exchange is /oauth/token, however, in the OAuth implementation for Lucia, /token is used, which results in a 404 error as soon as the exchange request is sent.

I'm reading through the contribution docs and will create a PR to fix this


Remove backticks from transpiled output.

Overview
This PR removes backticks from transpiled output. Some customers assign our snippet to a variable for insertion in a specific place in their app, and to avoid conflicts with single and double quotes, they enclose the script in backticks (`). However, since we started transpiling for newer browser versions, we have template literals in our output, which conflict with backticks. We also recently added an error message containing backticks.
This change results in a very slight increase in loader size. The SPA loader, for example, is 168 bytes larger.
Related Issue(s)
N/A
Testing
Standard automated tests apply.

Has there been an actual issue ticket by a customer because they cannot do raw insertion for some reason?


Tag tool/workflow versions with additional status

Feature Request
Ability to clearly mark tool/version as 'pre-release' or some similar indicator to make clear that tool is still undergoing wider testing.
Desired behaviour
Should allow for:

pre-release
pre-release + release
release

e.g.
0.0.1 - pre-release
or
1.0.0 - release
1.0.1 - pre-release

or
1.0.0 - release
Why?

Primarily useful for first releases to dockstore, to indicate that something may not quite be ready for general use.

Sounds like a good idea. We could even harvest and pass through if a tag is marked as a pre-release on the GitHub side.
Additionally, we like to (and can encourage in our documentation) version some of our software using semantic versioning and its pre-release identifiers  http://semver.org/#spec-item-9
e.g. Examples: 1.0.0-alpha, 1.0.0-alpha.1


Restructuring branch

Ok so maybe there is something I don't know then. What is the Restructuring branch for?

Technically it's not NEEDED, but it's attached to this pr for upstream. Don't see the harm in leaving it there in case upstream ever decides to resume their fork of the project.

Just an update, that this banch is now deleted, since i got around to merging the PR upstream.


Console.log in multiselect.component.ts

Hi
In the file multiselect.component.ts, in ngDoCheck() there is a console.log left.
Can it be removed?
Because it is populating the dev tools consoles with these messages.
Thanks!!

it is removed and no more exists in the latest version. please update to latest version.


refactor: replace initialScrollIndex with onContentSizeChange in RulerPicker

This PR addresses an issue with the RulerPicker component where the initialScrollIndex prop was not setting the scroll position as expected. The root cause seemed to be that the scroll index was calculated before the content dimensions were fully known.
Changes made:

Removed the initialScrollIndex prop from the RulerPicker component.
Added an onContentSizeChange prop to the RulerPicker component.
Inside the onContentSizeChange callback, calculated the initial scroll position based on the initialValue, stepWidth and gapBetweenSteps props, and then programmatically scroll to that position.

This change ensures that the RulerPicker correctly displays the initial value passed to it. It was tested with a variety of initial values and found to work as expected.
https://github.com/rnheroes/react-native-ruler-picker/assets/68515357/82fca3aa-3c20-4476-8f05-d767b14ef2c8

Thank you for your contribution to react-native-ruler-picker and addressing the bug. We really appreciate your effort in making the component better. @Skipperlla


Add new chain qa_with_references, inspired by qa_with_sources.

Description:
This chain returns the selected documents used for the response. Then, it's possible to extract all meta-data
for these documents, to generate a markdown link or other stuff.
It's not easy to manage the links of sources. Langchain proposed a qa_with_source, but this chain returns only a
list of URL. It's not possible to extract other informations about the metadata, like the filename or others stuff.
I propose a solution to this problem: return the Documents, and let development do what it wants with it.
This pull-request proposes a new implementation of the original chain qa_with_source.
Now, the implementation qa_with_reference returns the list of documents used for the response.
Then, it's possible to use all meta-data for these documents, to generate a Markdown link (with filename/title and URL) or what you want.
To do that, I inject a UUID in the meta-data, and ask to return a list of UUID in the response. Then, it's easy to find the corresponding document.
In another branch,
I have reimplemented the origin qa_with_source to extend the qa_with_reference.
Tag maintainer:

@baskaryan

Dependencies:

no

Twitter handle:

@pprados

This returns citations:
from langchain.chains import RetrievalQAWithSourcesChain
qa_chain = RetrievalQAWithSourcesChain.from_chain_type(llm,retriever=vectorstore.as_retriever())
result = qa_chain({"question": question})

This returns source documents:
from langchain.chains import RetrievalQA
qa_chain = RetrievalQA.from_chain_type(llm,retriever=vectorstore.as_retriever(),
                                       return_source_documents=True)
result = qa_chain({"query": question})
print(len(result['source_documents']))
result['source_documents'][0]

Do those cover the use-case you need here?

No. The RetrievalQA or RetrievalQAWithSourceChain return only the url of all documents used.
But,

some documents have no URL
not all documents are used
Others metadata can be important to manipulate the response.

With my proposition (next version soon), return only the documents used to answer, and, if it's possible, the verbatim used to answer.
And, it's possible to manipulate all the information about these documents (Google file id, records id from DB, etc.)

Dear @rlancemartin,
I have made several changes to the code for this new release.
Before explaining the changes, let me provide some context. With RetrievalQAWithSourcesChain or RetrievalQA, it was not possible to identify only the documents used, as the parameter return_source_documents=True would return all documents, even those not used for the response. Additionally, with RetrievalQAWithSourcesChain, only the metadata["source"] was returned, making it difficult to calculate the link between the URL and the corresponding document, especially when multiple documents shared the same URL. And, it's possible ONLY if the metadata has source.
That's why I'm proposing this new version (which fixes a bug in RetrievalQAWithSourcesChain when the recursive process is necessary).
New release:

To optimize token usage, I have stopped using UUIDs (UUIDs consume tokens).
Instead, I now use an index from the list of documents, which is shorter.
The code is now compatible with asynchronous operations.
I have also updated the documentation in docs/extras/use_cases/question_answering/index.mdx.
When using chain_type='stuff', all documents are merged into the same prompt, and only the documents used are returned.
For chain_type='map_reduce', the verbatim is extracted from the document to answer and added to the metadata. This allows searching for the portion of text used for the response. If the list of documents is large, the recursive approach is used, and the verbatim may not be extracted.
chain_type='refine' cannot extract the verbatim, but it only returns the documents used.
Lastly, chain_type='map_rerank' returns only the best document.
I fixed a bug in llm.py related to empty document lists.
Now, it's possible to create a link, with the source and the text fragment to highlight the portion of page (url with #:~:text=...).

I hope you find these changes beneficial.
Later, if you accept my code, it will be possible to revise RetrievalQAWithSourcesChain to inherit RetrievalQAWithReferencesChain.

Note that another difference with qa_with_source is the consumption of tokens. When you add a URL for each document or aggregate a list of URLs, especially if you have many documents, it can consume a significant number of tokens. In my proposition, only an integer is used to identify the corresponding document. This approach can be more efficient when dealing with a big list of documents, allowing for better performance.

Hello @rlancemartin,
I have a "1 change requested", but i can not change something. Is the process blocked?

Hello @rlancemartin, I have a "1 change requested", but i can not change something. Is the process blocked?

@pprados thanks for the detailed explanation.
Also adding @baskaryan and @eyurtsev who may have a point of view.
AFAICT, the problem you want to solve:

return the exact source documents used for answer generation in RAG.

Limitations today:

return_source_documents=True returns all source docs retrieved
RetrievalQAWithSourcesChain returns citations [1]

Question 1:

what is the precise problem with RetrievalQAWithSourcesChain?
can we put up a PR that addresses it narrowly? this should resolve your use case, IIUC.

Approach:

You use map_reduce or refine chains w/ intermediate_steps=True
"verbatim" of the docs is retrieved from the answers["intermediate_steps"]

Question 2:

This seems to be wrapping MR or Refine chains intermediate_steps values?
Why do these guarantee the source documents that used used in the final answer?

In short, the premise is good: higher quality citations for RAG generations. The problem w/ RetrievalQAWithSourcesChain is not fully obvious to me, but I also have not worked with it extensively. A crisp overview of that problem and PR to address it narrowly seems reasonable. Finally, use of MR or Refine intermediate_steps is also not entirely obvious to me as a solution to the problem: as you show in the notebook, you will get an answer per document for the question (logged to 'verbatim') but it's still not fully obvious how each answer maps to the final answer without some additional work (e.g., semantic similarity, etc) that will add further overhead.

Question 1:
What is the precise problem with RetrievalQAWithSourcesChain?

It's impossible to return the exact source documents used for answer generation in RAG.
RetrievalQAWithSourcesChain return only the URL (the document must have a URL) and nothing else
It's structured by the implementation. The implementation manipulates a list of URL, not a list of referenced documents.
My implementation maintains a real relation between the reference and the associated document.

Can we put up a PR that addresses it narrowly?

Yes, but after the pull request will be accepted.
It's possible to reimplement RetrievalQAWithSourcesChain to be a derived implementation of my code. It's simple. Use RetrievalQAWithRefernce to receive the list of original document, and extract only the URL. This implementation is better because the consumption of tokens is lower (replace each URL in the list to a simple number).

Approach:
You use map_reduce or refine chains w/ intermediate_steps=True

Yes. It's because, with the map-reduce mode, it's possible to extract only the portion of the document used. But, this information is accessible, only with intermediate_steps=True. I reuse the code from RetrievalQAWithSourcesChain. The map process, apply a LLM to extract a focus of each document, with the verbatim to answer. Sometime, the verbatim is "nothing", sometime is something. The reduce phase, use only the verbatim of each portion, to answer. But, it's not necessery to inject the verbatim used, in the body of the response, because it's accessible with intermediate_steps=True.

"verbatim" of the docs is retrieved from the answers["intermediate_steps"]

Yes. It's the same implementation of RetrievalQAWithSourcesChain

Question 2:
This seems to be wrapping MR or Refine chains intermediate_steps, which is the question answer per doc.
That is logged to verbatim.
But additional work is needed to compare each to the final answer to see which docs are most related.

No. The reduce phase select the corresponding document (exactly, the corresponding document, where the verbatim was extracted - Normally, it's possible to find the verbatim in the original document, with a simple text search). It's the job of LLM to answer of this question: which is the question answer per doc. It's just the same with RetrievalQAWithSourcesChain, but use an id, and not an URL.

It seems you found a bug there?

Yes, the actual implementation of RetrievalQAWithSourcesChain can not manage a list of URL for each document. But, when we use the map reduce, a first reduce can by apply. This step use multiple document, and return a partial response with a list of document. Then this response is use like a new document, to continue the analyse. So, if you have a big list of document, if a partial reduce is used, you lost the list of all URL. (But the major problem is the number of tokens used in this scenario).

I think hallucinations are a big problem. Allowing simple reference to what allowed the answer is necessary. Just having a list of documents, some of which have been used, some of which have not, is not a good approach.
Question 1:
What is the precise problem with RetrievalQAWithSourcesChain?

The challenge lies in returning the precise source documents employed for generating answers in RAG.
RetrievalQAWithSourcesChain solely provides URLs (requiring documents to possess URLs) without additional information.
Its structure is defined by the implementation, manipulating a list of URLs rather than a list of referenced documents.
My implementation establishes a direct correlation between references and associated documents.

Can we put up a PR that addresses it narrowly?

Yes, although the PR can only be submitted after acceptance.
A potential solution involves reconfiguring RetrievalQAWithSourcesChain as a derivative of my code. This simplified approach involves using RetrievalQAWithReference to acquire the list of original documents and extracting solely the URLs. This implementation proves advantageous as it reduces token consumption (replacing each URL in the list with a numerical value).

Approach:
You use map_reduce or refine chains w/ intermediate_steps=True

Indeed, this choice is driven by the capability of map-reduce mode to extract the relevant document portions. However, accessing this information requires setting intermediate_steps=True. My implementation repurposes the code from RetrievalQAWithSourcesChain. The mapping process employs a Language Model (LLM) to extract a focused section from each document, along with the verbatim answer. This verbatim answer, at times "nothing" and at others more substantive, is then employed in the reduction phase to formulate the final answer. However, it is unnecessary to incorporate the verbatim into the response body, as its retrieval is possible with intermediate_steps=True.

"verbatim" of the docs is retrieved from the answers["intermediate_steps"]

Yes, this corresponds to the same approach employed in RetrievalQAWithSourcesChain.

Question 2:
This seems to be wrapping MR or Refine chains intermediate_steps, which is the question answer per doc.
That is logged to verbatim.
But additional work is needed to compare each to the final answer to see which docs are most related.

Not exactly. The reduction phase selects the corresponding document (the exact document from which the verbatim was extracted - usually, a simple text search can locate this verbatim in the original document). It is the role of the Language Model to answer the question of which document corresponds to the question-answer pair per document. This is analogous to RetrievalQAWithSourcesChain, albeit using an ID instead of a URL.

It seems you found a bug there?

Yes, the current implementation of RetrievalQAWithSourcesChain struggles to handle a list of URLs for each document. Yet, when utilizing map-reduce, an initial reduction step can be applied. This step employs multiple documents and yields a partial response containing a list of documents. This response then becomes a new document for further analysis, and another reduce phase. Consequently, with a substantial list of documents, using a partial reduction can result in the loss of the complete URL list (the templace accept only one url by document). However, the primary issue here pertains to the number of tokens consumed in this scenario (an URL like from GoogleDoc, are not LLM friendly).

I believe hallucinations pose a significant issue. Enabling straightforward referencing of what led to the answer's derivation is imperative. Relying solely on a list of documents, some utilized and some not, is an inadequate approach.

Question 1:
What is the precise problem with RetrievalQAWithSourcesChain?

The challenge lies in returning the precise source documents employed for generating answers in RAG.
RetrievalQAWithSourcesChain solely provides URLs (requiring documents to possess URLs) without additional information.
Its structure is defined by the implementation, manipulating a list of URLs rather than a list of referenced documents.
My implementation establishes a direct correlation between references and associated documents.

Can we put up a PR that addresses it narrowly?

Yes, although the PR can only be submitted after acceptance.
A potential solution involves reconfiguring RetrievalQAWithSourcesChain as a derivative of my code. This simplified approach involves using RetrievalQAWithReference to acquire the list of original documents and extracting solely the URLs. This implementation proves advantageous as it reduces token consumption (replacing each URL in the list with a numerical value).

Approach:
You use map_reduce or refine chains w/ intermediate_steps=True

Indeed, this choice is driven by the capability of map-reduce mode to extract the relevant document portions. However, accessing this information requires setting intermediate_steps=True. My implementation repurposes the code from RetrievalQAWithSourcesChain. The mapping process employs a Language Model (LLM) to extract a focused section from each document, along with the verbatim answer. This verbatim answer, at times "nothing" and at others more substantive, is then employed in the reduction phase to formulate the final answer. However, it is unnecessary to incorporate the verbatim into the response body, as its retrieval is possible with intermediate_steps=True.

"verbatim" of the docs is retrieved from the answers["intermediate_steps"]

Yes, this corresponds to the same approach employed in RetrievalQAWithSourcesChain.

Question 2:
This seems to be wrapping MR or Refine chains intermediate_steps, which is the question answer per doc. That is logged to verbatim. But additional work is needed to compare each to the final answer to see which docs are most related.

Not exactly. The reduction phase selects the corresponding document (the exact document from which the verbatim was extracted - usually, a simple text search can locate this verbatim in the original document). It is the role of the Language Model to answer the question of which document corresponds to the question-answer pair per document. This is analogous to RetrievalQAWithSourcesChain, albeit using an ID instead of a URL.

It seems you found a bug there?

Yes, the current implementation of RetrievalQAWithSourcesChain struggles to handle a list of URLs for each document. Yet, when utilizing map-reduce, an initial reduction step can be applied. This step employs multiple documents and yields a partial response containing a list of documents. This response then becomes a new document for further analysis, and another reduce phase. Consequently, with a substantial list of documents, using a partial reduction can result in the loss of the complete URL list (the templace accept only one url by document). However, the primary issue here pertains to the number of tokens consumed in this scenario (an URL like from GoogleDoc, are not LLM friendly).

I believe hallucinations pose a significant issue. Enabling straightforward referencing of what led to the answer's derivation is imperative. Relying solely on a list of documents, some utilized and some not, is an inadequate approach.

Thanks for the detailed explanation. Let's merge this in langchain_experimental, so please move files here. There are some interesting ideas here that it would be great to allow folks to experiment further with them.

@rlancemartin
It's done. Now the code is in langchain_experimental for the moment.
I hope it can migrate to the standard branch later. Then it will be possible to optimize and fix qa_with_source.

I add a TU to validate the code in experimental branch.

Hello @rlancemartin, @hwchase17,
I have just published an update to better identify verbatim of the original document, and I had some documentations.
Code migrated to experimental, with unit-test.
Can you take the time to validate this pull-request ?
I hope it will take less time than the pull-request on Google Drive ;-)

Hello @rlancemartin,
I updated the code to extract all verbatim from the original document.
You can see a clear sample here.
I hope to be integrated into the experimental branch soon.

@rlancemartin,
The lint fail with other experimental components. See this declared bug 10088.
They are incompatible with the latest version of langchain.

@baskaryan, @rlancemartin,
(I changed the description for this new version)
Question answering with references and verbatim over documents.
We believe that hallucinations pose a major problem in the adoption of LLMs (Language Model Models).
It is imperative to provide a simple and quick solution that allows the user to verify the coherence of the answers to the questions they are asked.
This chain extracts the information from the documents that was used to answer the
question. The output source_documents contains only the documents that were used,
and for each one, only the text fragments that were used to answer are included.
If possible, the list of text fragments that justify the answer is added to
metadata['verbatims'] for each document.
Then it is possible to find the page of a PDF, or the chapter of a markdown.
A sample result of usage with Wikipedia, may be:
For the question "what can you say about ukraine?",
to answer "Ukraine has an illegal and unprovoked invasion inside its territory,
and its citizens show courage and are fighting against it. It is believed that
the capital city of Kyiv, which is home to 2.8 million people, is a target.",
the LLM use:
Source https://www.defense.gov/News/Transcripts/...
-  "when it comes to conducting their illegal and unprovoked invasion inside
Ukraine."
Source https://www.whitehouse.gov/briefing-room/...
- "to the fearless and skilled Ukrainian fighters who are standing in the
breach"
- "You got to admit, you have -- must be amazed at the courage of this country"
Source https://www.whitehouse.gov/briefing-room/...
-  "believe that they will target Ukraine's capital, Kyiv, a city of 2.8 million
innocent people."
Source https://www.whitehouse.gov/briefing-room/...
-  "believe that they will target Ukraine's capital, Kyiv, a city of 2.8 million
innocent people."

@pprados Hi , could you, please, resolve the merging issues? After that ping me and I push this PR for the review. Thanks!

Hello @leo-gan
Thank you for considering my proposal.
For the moment, it is on the experimental branch, but I am hopeful of a deeper integration into langchain. Then, it will be possible to add 2 methods to VectorStoreIndexWrapper: query_with_references() and query_with_references_and_verbatims()
Some remarks to understand the code.

It is a fork of qa_with_source. I resynchronized my code with the latest version.
It is not very clear whether it is possible/advisable to use parsers from templates. The current implementations of ReduceDocumentsChain and MapReduceDocumentsChain do not use prompt parsers, and that's a shame.
MapRerankDocumentsChain use apply_and_parse() but it's deprecated. I would adjust the code in sync with qa_with_sources.
An evolution of these 3 classes will be welcome and would simplify my code. I can do it, but i would be sure it's what you want: use the associated parser for eachs prompts.

For qa_with_reference, I propose 2 implementations, one based on Pydantic objects, the other without in order to save token consumption. This is the version that is activated.
For qa_with_reference_and_verbatims, I use a Pydantic objects and the corresponding parser.
Integration tests require openai and wikipedia (pip install openai tiktoken wikipedia). You can see the different results with qa_with_sources, qa_with_references and qa_with_sources_and_verbatims.
Sometime, qa_with_sources in mode  map_rerank crash. Because the regex pattern is '(.?)\nScore: (\d)' but sometime, the LLM returns the score, without the `\n'. It may be fixed, but I don't want to create confusion.
After validation, it will be possible to review qa_with_sources for a compatible implementation, but more economical in tokens, without bugs in the case of a large list of documents (bug because it's impossible to manage a long list of URL, and recursive map-reduce is not prepared to use multiple URLs for the same document).
In addition, the new version will only be able to find the list of documents used for the response (and not the list of documents returned by the vectorstore. It is not the same thing - some documents are not really used).

@baskaryan PR is ready for review

@rlancemartin Please, review this PR again. TNX!

@rlancemartin Please, review this PR again. TNX!

I'm on paternity leave currently (new baby). Thanks for looking into this. I can have a look when I'm back in October unless others have a chance. This has been moved to experimental IIRC, so we can probably get it merged without major concern.

@baskaryan Regarding to @rlancemartin this PR can be merged. :gift:

I just resynchronize the code. @baskaryan, can you merge this PR ?

@baskaryan Could you, please, review it?

@baskaryan, @leo-gan, @baskaryan
Someone, can you review this code, please?
I hope I don't have the same problem as with the Google drive integration ;-)

@hwchase17  Could you, please, review it?

@baskaryan, may be, you can review the code?

any update on this PR?

Hello @rlancemartin, @hwchase17, @timxieICN,
Yes. I rebase the code.
All checks have passed. I waiting the review.

Thanks @pprados - I took a quick look at your codes - looks great. However, I did notice your implementation on QAWithReferencesAndVerbatimsChain deviates quite a bit from the rest of LangChain's qa_chain or ConversationalRetrievalChain. For example, there's no argument/concept of retriever anymore.

@pprados - also, what's the technical reason why verbatim only works for chain_type='map_reduce'?

@pprados  - I tried to run your code by refactoring it into our existing workflow, as follows:
query_executor = RetrievalQAWithReferencesAndVerbatimsChain.from_llm(
                llm=AzureChatOpenAI(temperature=0),
                retriever=OpenSearchVectorStore,
                memory=...,
                chain_type="map_reduce"
)

I noticed:

The code is quite slow. For QA on a 8-page long pdf, the query can easily take up to 30 sec.
The response is not always optimal. The response is not as accurate as what the ConversationalRetrievalChain provides.

Is this what you've seen as well?

btw, @pprados - are you aware of this https://api.python.langchain.com/en/latest/_modules/langchain/chains/openai_functions/citation_fuzzy_match.html?
I tested it a bit and it seems more generalized than your approach.

@timxieICN

also, what's the technical reason why verbatim only works for chain_type='map_reduce'?

No. It's works with all chain_type. It's an all comment. I will fix it.
I will try the other implementations.

btw, @pprados - are you aware of this https://api.python.langchain.com/en/latest/_modules/langchain/chains/openai_functions/citation_fuzzy_match.html?

@timxieICN, this solution works only with openai_functions, and with ChatModel, but can indeed be a source of inspiration for evolution.

@pprados - It's just defining pydantic model and calling OpenAI's Function Calling behind the scenes. Not totally sure if it only works with ChatModel

Look the code here

@pprados - I believe you can tweak the code to make it work for other models and use cases as well. It's pretty much just doing this: https://openai.com/blog/function-calling-and-other-api-updates


Example for a deep learning model

Summary
Can you please provide an example of logging inference predictions for a deep learning model (e.g. image/audio classification).
Desired Behavior
NOTE: # Would like to see example of how non-tabular, high-dimensional inputs (e.g. image, audio, text) would be logged to NR
Possible Solution
NOTE: # If high-dimensional inputs are not supported, provide a way to send just predictions (e.g. just y_pred, without X)
Additional context
Currently, at least one feature is required to log with the library, when the inputs are high-dimensional (e.g. images, audio), sending them to NR would not be useful. Would like a way to sent just predictions without inputs.

Thanks for the feedback @JustasB.
You are correct. We thought about sending the characteristics of the data instead of the data itself as X. We will also check the option of not sending X at all and will update you soon.
Thanks!


Support for ECS

Some helper functions for integration with unity's ECS would be helpful. Here are some possible cases:
Container.Bind<System>().FromEcs()
Container.Bind<System>().FromNewInEcs("World Name")
Container.Bind<System>().FromEcs("World Name")
Container.Bind<System>().FromNewInEcs()
maybe some  helpers for creating archetypes.
Container.BindArchetype<Class,Class2>()

I don't think it would work nicely right now with unity still fiddling with constant updates of their ecs code. When it is more mature, maybe it would be more feasible without getting break when they finalized.


Feedback and new test data

Hi @khundman and @chrismattmann, I'm currently working with @kermitt2 to the GROBID quantity model.
I was wondering if you had time to have a look at the demo, if you spot any bug or you have any remarks feel free to open new issues. ;-)
On the other hand, we still have to introduce more training data. If you have some relevant document we could use (perhaps not necessarely on the scientific domain) would be great :) You can push them on the dataset or a subdirectory of it.
Cheers

I close this since it has passed quite some time ;-)
Trying to maintain and perhaps extend little by little


Page previews failing for pages that begin with included content

For Bug Reports

BookStack Version: v0.17.1
PHP Version: 7.0.15
MySQL Version: 5.7.17

Expected Behavior
The chapter page which lists pages with their previews should properly render the preview for pages that have included content in the beginning of them.
Actual Behavior
On the main page of a chapter that lists all of a chapter's pages, if a page's preview contains an include tag for another page or bookmark, there is a javascript TypeError exception logged to the console and the page list does not render.

@XtremeBain Thanks for reporting, Will be in the next bugfix release.
I've updated it so included content is parsed into the text view for list previews and searching. This is only on save though (For performance reasons) so it is possible that this text content may become outdated if the included content is changed.


feat: apply console to moduleLogger codemod

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

Testing

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #2448

PR #2453   👈

This comment was auto-generated by Graphite.


docs: push event tracking

Adds docs for push event tracking & auto tracking

:tada: This PR is included in version 1.0.0-alpha.15 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore: export extra types from @jest/reporters

Summary
I'm trying to write a reporter outside of this repo, and these types are really needed in order to avoid the extra dependencies

Test plan
Green CI (it's just extra type exports 🤷♂)

Codecov Report

Merging #9160 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9160   +/-   ##
=======================================
  Coverage   64.83%   64.83%
=======================================
  Files         278      278
  Lines       11732    11732
  Branches     2883     2883
=======================================
  Hits         7607     7607
  Misses       3508     3508
  Partials      617      617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe6ebba...06d51cd. Read the comment docs.


Add extension method overloads that take a specific config section to bind to

By default the authentication components have a default config schema, but you should be able to specify a specific config section to bind to.

Why do we need this?  Call services.Configure<XyzOptions>(config.GetSection("<yourpath>")

That works as long as the component uses the default config binder, but not all components do. Ex. I believe the kestrel config is custom. We want a consistent pattern.

Sure but was there something specific in the security repo you were asking about, because all the options for auth work reasonably well with the binder.
If you want a general pattern, I'd recommend something like this:
  public class MyOptions {
     public void Bind(IConfiguration config) {
       // Do yo binding.
     }
  }

  var config = GetYoConfig();
  services.Configure<MyOptions>(o => o.Bind(config));

No plans to do this.


Neural Renderer

Hello !
I want to understand the Neural renderer (DL network) part. How did you train this neural renderer?
If there is a dataset, please provide a link for it.
Have you used a traditional rendering algorithm in this case? (If so how ?)
Thank you

Hello! In renderer training, we used baseline/Renderer/stroke_gen.py for generating training data online. You can see baseline/train_renderer.py for details.

Another small query, while running stroke_gen.py file, with f = np.random.uniform(0,1,10) , I am basically getting an empty black image with no stroke . I seem to have double checked it , is there any issue with f value that I'm providing ? Also, why is the center (y,x) , any specific reason ?
Thank You

Hello, I think you should convert float32 to unint8 before visualizing. You can use cv2.imshow((gen * 255).astype('uint8')). The problem of coordinate order comes from the difference between numpy and cv2. When drawing with cv2, the order of coordinates is different.


Labeling 230.000 images

I have image file that contains about 230.000 images for graduate project, so what do you suggest to label whole images because i can't label these images by one by

What do you mean by labeling whole images? Do you mean open all images under that folder?

I mean annotate to yolo format


Formatter: Target version support

Adjust the formatting based on the syntax supported by the targeted python versions.

Black uses this option to decide what grammar to use to parse your code. In addition, it may use it to decide what style to use. For example, support for a trailing comma after *args in a function call was added in Python 3.5, so Black will add this comma only if the target versions are all Python 3.5 or higher.

Source

[ ] Decide on minimal supported python version
[ ] Trailing args and kwargs comments (depending on the above decision)
[ ] Parenthesized with items

Relevant features:

3.10: Parenthesized with items
3.12: f-string grammar

Do we have a list of syntax that would change formatter behaviour that is not in 3.7/3.8? I can only think of nested f-string quotes in 3.12

Do we have a list of syntax that would change formatter behaviour that is not in 3.7/3.8? I can only think of nested f-string quotes in 3.12

f-strings will be fun because they now can contain comments too, yeah.
I don't have more than what's outlined in the issue above and is derived from Black's documentation. We could do a quick search on Black's repository to identify other version-specific formatting (or look at their version-specific tests)

Parenthesized with items (mentioned above) -- need to make sure we don't introduce parentheses there if unsupported. I don't know if this needs changes or not, but it was new in Python 3.10. (They have crates/ruff_python_formatter/resources/test/fixtures/black/py_39/remove_with_brackets.py for this, I think?)
See also crates/ruff_python_formatter/resources/test/fixtures/black/py_39/pep_572_py39.py -- walrus operators can be unparenthesized in some cases starting in Python 3.9, so we need to make sure we don't remove parentheses in such cases on older versions.

For my projects, the quote normalization would be OK, as this should be already fixed by the Q rules in the linter. However, the prefix normalization would be very problematic, as it breaks backwards compatibility with some older versions of Pythons that we still need to support for a couple of our projects. Specifically, the issue is the change from br"..." to rb"..." for binary regular expressions, which causes a SyntaxError. Without some type of replacement for this --skip-string-normalization option, we would not be able to switch to Ruff for formatting.

Originally answer by @tdulcet

I've confirmed that the unparenthesized walruses is handled correctly (we never remove those parentheses, so we're fine).

We also get the remove_with_brackets.py test case right. I've confirmed that we only add parentheses in a with if there were already parentheses to start. (Can see should_parenthesize in stmt_with.rs; the other case is that in which there's a parenthesized dangling comment, which again implies parentheses.)

As far as I can tell, there's nothing that we need to do here, assuming...

We only want to support Python 3.7 and later.
We don't care about downgrading code (e.g., if code was written for Python 3.10, and uses a parenthesized with, then when run under --target-version py37, we consider it validate to retain the parenthesized with).

Some notes on Black's behavior:

I believe that Black adheres to (2) -- so if you run over a file with a match statement using --target-version py37, Black will fail. Black uses the target version to determine which parser to use.
Black has a VERSION_TO_FEATURES concept whereby it detects features that are used in a given file, and uses that to infer the target version, if it's not set (see: detect_target_versions).
After inferring the target versions, the only version-specific features that affect formatting are Feature.TRAILING_COMMA_IN_CALL and Feature.TRAILING_COMMA_IN_DEF (which apply for Python 3.5 and later, i.e., the versions we support), and Feature.PARENTHESIZED_CONTEXT_MANAGERS.

This last piece (Feature.PARENTHESIZED_CONTEXT_MANAGERS) is interesting, but is only relevant for preview style: https://black.readthedocs.io/en/stable/the_black_code_style/future_style.html#using-backslashes-for-with-statements. In short, Black is going to wrap multiple with statements using backslashes on older versions or parentheses on newer versions. Right now, it seems like the parenthesized version is implemented in preview mode. So, once we do preview style, we'll need to support that and gate it on target version.
For example, given:
with a as b, c as d, e(1,) as f:
    pass

Black stable formats as:
with a as b, c as d, e(
    1,
) as f:
    pass

But preview gives you:
with (
    a as b,
    c as d,
    e(
        1,
    ) as f,
):
    pass

(Can see should_parenthesize in stmt_with.rs; the other case is that in which there's a parenthesized dangling comment, which again implies parentheses.)

This may no longer be true if we implement https://github.com/astral-sh/ruff/issues/7243

We don't care about downgrading code (e.g., if code was written for Python 3.10, and uses a parenthesized with, then when run under --target-version py37, we consider it validate to retain the parenthesized with).

I'm unsure whether I would expect my formatter to downgrade the syntax. I guess mainly because I'm just not used to having this setting in a formatter. Removing parentheses raises interesting question when it comes to comments, especially leading and trailing commnts

What's the status on this? Do we plan to support this for the Beta?

My assessment is that there's nothing to do here until we support preview style.


Security extension acs beta0

This is a set of patches for the security-extension beta0 release based on the v21.05_0.8_BETA-0 tag of the arm-systemready ACS.
The intent is for this pull request to be applied to a branch called "security-extension-acs-beta0".  Do not apply or merge this with "main".

A separate security-extension-acs-beta0 branch created with these changes.


Way to compile benchmarks without running them?

I would prefer not to run benchmarks in CI, both because it slows down the CI process considerably and the CI environment I'm using is not well-suited for accurate benchmarking. However, if I don't at least compile the benchmarks in CI, they have a tendency to break, e.g.
https://github.com/tendermint/signatory/pull/30
Is there any way to ensure the benchmarks compile without actually running them?

Hey, thanks for trying Criterion.rs. I think you're looking for cargo build --benches --all.

Thanks for the prompt reply! That did the trick


gtags: not working

vim or neovim?

[ ] vim
[x] neovim

Output of vim --version or nvim --version:

NVIM v0.3.4
Build type: Release
LuaJIT 2.0.5

Output of :echo has("python"):
0
Output of :echo has("python3"):
1
Output of :echo &pythondll(only vim, not neovim):
Output of :echo &pythonthreedll(only vim, not neovim):
Output of :py print(sys.version):
Output of :py3 print(sys.version):

3.7.3 (default, Mar 27 2019, 09:23:15)
[Clang 10.0.1 (clang-1<IP_ADDRESS>)]

Output of :echo g:Lf_Debug_Cmd:
Output of :echo g:Lf_FilesFromCache:
Operating system:

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Configurations related to LeaderF in vimrc:

Describe your question, feature request, or bug.
Request from non-main thread.
Requests from different threads should be wrapped with nvim.async_call(cb, ...)
  File "/Users/sapphire/.nvim/LeaderF/autoload/leaderf/python/leaderf/gtagsExpl.py", line 763, in _executeCmd
    print("gtags generated successfully!")
  File "/usr/local/lib/python3.7/site-packages/pynvim/plugin/script_host.py", line 182, in write
    self.redirect_handler(data)
  File "/usr/local/lib/python3.7/site-packages/pynvim/plugin/script_host.py", line 75, in <lambda>
    sys.stdout = RedirectStream(lambda data: nvim.out_write(data))
  File "/usr/local/lib/python3.7/site-packages/pynvim/api/nvim.py", line 393, in out_write
    return self.request('nvim_out_write', msg, **kwargs)

Steps to reproduce
type :Leaderf gtags --update under the project root.
Actual behaviour
Expected behaviour

Did not test on neovim.

only vim works?

NO, also will add neovim support. Didn't realize that neovim is not compatible with vim here.

okay, thx

Fixed.


[firebase_auth] Web authentication status not persistent across site reload

Bug report
Describe the bug
While Developing for Flutter Web, contradicting to what is stated in the FlutterFire Docs, the authentication state is not persisted for the user.

Hi @kushalgoel786
When opening an issue, please try to provide all of the information indicated in the template.
Closing this issue, since no information has been provided.
Thank you.

Hi @kushalgoel786
When opening an issue, please try to provide all of the information indicated in the template.
Closing this issue, since no information has been provided.
Thank you.


0.0.6

[FIX] Missing library dependency fix.
[IMP] Added optional --local flag. Lemmy won't run in non-PR builds by default.

Version
:tada: Package version has been updated properly.
Changelog
:tada: Changelog has been updated properly.
Lint
:tada: No lint warnings were reported!

Summary
Value

:octocat: Commit
a9ad0628d7b45a60035011d4582e040f7b9d9548

Comparing against
master branch

Build number
45

Job number
45.1

System
linux


RuntimeError: unreachable

I'm getting the error RuntimeError: unreachable on a few images.
For example - https://cdn.statically.io/img/openbenches.org/w=600,f=auto,q=80/image/e663fa6d446ffff38ceda1fe78c2a16ea6c76cfa.jpg returns an error.
The underlying image is fine https://openbenches.org/image/e663fa6d446ffff38ceda1fe78c2a16ea6c76cfa.jpg
Even if I change the width or quality on the CDN URl, it still gives the same error.
Any idea how I can fix it?  Thanks!

same here :/


Flink 6602 -- bug fix

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[ ] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[ ] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[ ] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

thanks for the update @lmalds. I'll add two tests and will merge this

On more thing. It would be good if you build the flink-table module locally before submitting or updating a PR. The PR fails because some lines exceed the line length limit. Thank you.

Yes, I will. Thank you.


US 1974660: Previous versions cleanup - part 40

Project to clean up the previous versions for "Driver Reference" articles. Moving a couple of files for "usbcon" technology.

Hi @mhopkins-msft  - Please review and let me know if this is OK to merge. Thanks much!

Thanks, @mhopkins-msft for your feedback. I actually had the following instruction from Lori on this and we've done all of them like I did in this PR. This was the instruction I received:
"Meriwether will complain if SAL is on the ### -param line. Change all of these to be formatted as follows:
-param Context
[in] A pointer to ..."
@lorihollasch  - can you please confirm? Thanks much!

@craigcaseyMSFT , go ahead and make the change that @mhopkins-msft  has requested. I just checked Meriwether and it does not seem to be consistent in its complaining, sorry!

Everything reviewed and approved.
#sign-off

Thanks @craigcaseyMSFT!