Fix NotFound page for categories and tags

Details

In a scope of this PR:

Improving a handling for showing edit categories and tags pages. The app should show "It is not here", when no categories and tags for a money request.
A small fix of markup for FullPageNotFoundView of EditRequestPage, a back button is pressable now on native platforms.
A minor fix propTypes error of EditRequestTagPage and EditRequestDistancePage, testID was missed for ScreenWrapper.

Fixed Issues

$ https://github.com/Expensify/App/issues/28079
PROPOSAL: N/A
Tests

"Not here" message shows up

Create a money request with a regular user (not a workspace).
Dive to edit money request page.
Verify that there are not "Category" or "Tag" buttons.
Add to url an endpoint for:

categories - "/edit/category".
tags - "/edit/tag".
amount - "/edit/amount".

Verify that for the first 2 cases "Not here" message shows up (an empty page is expected for now).
Verify that for the 3rd case there is an input to modify amount (an empty page is expected for now).

Content shows up

Create a money request with a workspace with categories/tags.
Dive to edit money request page.
Verify that there is "Category"/"Tag" buttons with a selected value.
Add to url an endpoint for:

categories - "/edit/category".
tags - "/edit/tag".
amount - "/edit/amount".

Verify that for a value that exists you have content, otherwise "Not here" message shows up (an empty page is expected for now).
Verify that for the 3rd case there is an input to modify amount (an empty page is expected for now).

[x] Verify that no errors appear in the JS console

Offline tests

Same as "Tests".
QA Steps

Same as "Tests".

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/57314631/31bdeb45-cd38-4759-a79d-072a9382a9c7
https://github.com/Expensify/App/assets/57314631/f04bc340-b360-4a4d-86c9-df0d08d2bd2c

Mobile Web - Chrome

https://github.com/Expensify/App/assets/57314631/b8100b07-6988-4c4f-8833-ccbcc00b84a9

Mobile Web - Safari

https://github.com/Expensify/App/assets/57314631/1b06dcf5-0734-49fc-bdff-e9709a38a036

Desktop

https://github.com/Expensify/App/assets/57314631/8f6929d0-2895-4482-926f-1f0fa2b767c4

iOS

https://github.com/Expensify/App/assets/57314631/b6a07f7b-ef7a-4a3b-b589-3d0f48735830

Android

https://github.com/Expensify/App/assets/57314631/4c707745-b706-4ed1-878f-77541c78651a

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/108292595/cffe5e57-f4f4-4dd5-a2d4-0591872368d0

Mobile Web - Chrome
https://github.com/Expensify/App/assets/108292595/041db2c8-6e11-4ee2-a3fc-c6404e3f33db

Mobile Web - Safari
https://github.com/Expensify/App/assets/108292595/9d4e3a67-5bae-4dc0-b697-0da1fca4c92d

Desktop
https://github.com/Expensify/App/assets/108292595/13387a63-bafe-4e13-bf00-9ab7885cc19f

iOS
https://github.com/Expensify/App/assets/108292595/c2e1f326-8222-48c4-8ef9-27a106e6d215

Android
https://github.com/Expensify/App/assets/108292595/768e7133-bd12-466f-adc8-0421ad9788bb

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.76-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@rezkiy37 QA mentioned this is failing this old bug https://github.com/Expensify/App/issues/28069, can you have a look into it?

Ah it just means they have seen it during testing this PR, does not mean it have re-intorduced it.  I am just reporting, there is many of such Prs to link :D
Seems like this is not related, I agree

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.77-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Doc update for opensuse

This is a followup to a request for CONTRIBUTING.md and REVIEW_GUIDELINES.md updates for openSUSE.
https://github.com/ros/rosdistro/pull/28385#pullrequestreview-596691495
I've also reworked the rosdep/{base,python},yaml patches to be less release specific unless necessary. I'll open separate PRs for those in smaller bunches if this one gets accepted.

Thanks @neotinker !


Crafting - Allow to craft torches with charcoals

Ignore the damage value from coal and this will allow to create torches with charcoals.

Nice catch. I knew there would be more of these left when I "strictified" the crafting recipe matcher.


chore: pre deploy checks

Issue #, if available: GALI-1353
Description of changes: added a new pre deployment check to:

Verify resources that have been terminated: Workspaces owned by internal auth users
Pre deployment step must check if SSH keys linked to internal users are deactivated
Pre deployment step must check if all Internal Users (including root; root will need to be deactivated from DDB table) are deactivated
Verify internal users are not linked to the following resources: Projects, Org Studies, DS Accounts
This should be the first pre-deployment step that runs, and installation should stop if any of the conditions are not met.

Unit tests to come. Documentation that advises admins how to prepare their environments to pass this check to come.
Checklist:

[x] Have you successfully deployed to an AWS account with your changes?
[ ] Have you written new tests for your core changes, as applicable?
[x] Have you successfully tested with your changes locally?

AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Could you paste a sample error message that could be encountered by an end user on the terminal when some of these pre-deployment checks fail?


Adding note about WEBSITE_TIME_ZONE not supported on Linux consumption

@brettsam : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@brettsam Is it only for Consumption plan? I see user reported it for Linux Premium or App Service plan also. https://stackoverflow.com/questions/64316818/time-zone-issue-python-function-app-on-azure

Good question. Maybe @balag0 knows?

I suspect it does not may be since it runs in isolation within container?

The app setting is supported in Linux App service plan. But the way the setting is configured is different from Windows.
On windows the supported values are
https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-vista/cc749073(v=ws.10)?redirectedfrom=MSDN
On Linux the supported values are
https://en.wikipedia.org/wiki/List_of_tz_database_time_zones


Give proper credit where due

There are people to be credited for certain concepts, ideas and solutions.
Below are names that I must partially credit for the making of Trebol

@amigoscode for fluently describing a working example on his youtube channel about how to implement Spring Security auth using JWTs and a DB. I did write the implementation code on Trébol myself, but it's sooo very similar to his codebase, I feel I have to reference it https://github.com/amigoscode/spring-boot-security-course/tree/8-JTW

Most of the code I've written in this project is really a mixed bag of my own ideas and some approaches suggested all around Stack Overflow, Baeldung and other sites. I really could not come with any other particular responsibles for most of the codebase.


Loose request version

Will be good to loose the dependency so that customer don't need to download multiple version of the same package and reduce the overall app package size. (request itself is quite large)
Major package version with breaking change should be manually update.

@irace @maddalab how do yo think?

I'll defer to @ceykooo and team on this (I haven’t worked on tumblr.js in years)

Sounds good. Tested with latest<EMAIL_ADDRESS>to confirm and :+1:

Thanks!
would be good if we can have a patch version update for this change? @ceykooo

@KevinTCoughlin and team, do you think we can have have any patch release in the near future?

+1 for a patch release

@roderickhsiao @nicolashenry Done. v0.0.7 should have it.

Thanks a lot :)


Search failure for pimâtisiwina

There's an issue with some searches like pimâtisiwina.
Currently locally detected a list index out of range error, which should be checked on.

Issue relates to preverbs.  Failure currently at https://github.com/UAlbertaALTLab/morphodict/blob/5440fda28627dbe87ca69a4d32e90eff32b63ea2/src/CreeDictionary/API/search/presentation.py#L509
when tag='PV/mahti+'.
This can be solved in two ways:

Default to unfound result when entries[0] fails, would provide some results whenever this code fails, deploying that as a temporary fix.
@aarppe Main problem is that there is no entry in importjson for mahti that has inflectional_category="IPV", as expected by https://github.com/UAlbertaALTLab/morphodict/blob/5440fda28627dbe87ca69a4d32e90eff32b63ea2/src/CreeDictionary/API/search/presentation.py#L501 . Currently there are entries with IPC, IPJ, IPH, and V.  Should these all be accepted instead of IPV (or just V?)

Immediate issue has been fixed in production with the hotfix, but decision on handling Preverbs that are not an IPV remains a concern that needs to be addressed before closing the issue.


Github Copilot Chat wrong log in account

Type: Bug
After updating to v1.86, my VSCode setup with two GitHub accounts encounters an issue. Despite being logged in with my 1st GitHub account, Copilot chat keeps switching to my 2nd account. The problem resolves temporarily when I log out of the 2nd account completely, but returns upon logging back in with my 2nd account for other extensions.
Extension version: 0.12.1
VS Code version: Code 1.86.1 (31c37ee8f63491495ac49e43b8544550fbae4533, 2024-02-07T09:07:19.849Z)
OS version: Linux x64 5.15.0-89-generic
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz (8 x 3300)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
3, 7, 9

Memory (System)
31.15GB (15.10GB free)

Process Argv
--unity-launch --crash-reporter-id 19908b30-4c38-4c7c-afcd-8697f0e6b324

Screen Reader
yes

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
bf62j303:30959262
b1063948:30958189
3ef8e399:30962115
bg6jg535:30958357
ccp1r6:30958156

This issue is caused by VS Code not properly supporting multiple auth sessions. Not much can be done on the extension side until VS Code fixes this. It was a bug that this worked before
Ref:
https://github.com/microsoft/vscode/issues/203850
https://github.com/microsoft/vscode/issues/127967


Set Content-Type to "application/json" where applicable in API

Closes concourse/concourse#1111.

Sorry it took me some time, but I finally got around to adding the tests. I hope I caught all the places that needed an additional test.

@SHyx0rmZ Thanks for adding the tests! Looks good.


[BUG] Dashboard not giving an option to select a tenant and defaultRoute does not seem to be in sync with default tenant (last selected tenant)

Describe the bug
We have multiple problems with dashboard access related to multi tenancy:

Dashboard doesn't not give an option to select a tenant every single time, instead it keeps default tenant (or last selected tenant) in user cookie.
When we login to dashboard, it starts with defaultRoute but this defaultRoute is not the one specific to the default tenant (or last selected tenant). For example, we have three tenants: A, B (default tenant) and C, and when we login it lands on the defaultRoute of tenant A, while expectation is to land at defaultRoute of tenant B.

To Reproduce
Pre-requisites:

We have two custom tenants "cadm" and "e911", and e911 is the default tenant (or last selected tenant)
We have disabled "Global" and "Private" tenants

Steps to reproduce the behavior:

Go to Dashboard

Click on Single Sign-on

See defaultRoute belonging to "cadm" tenant

See error "could not locate that dashboard" which is understood as it belongs to a different tenant "cadm" other than the default/selected tenant "e911":

Expected behavior

Dashboard should give an option to select a tenant every single time.
When we login to dashboard, the defaultRoute should be in sync with the default tenant (or last selected tenant).

OpenSearch Version
2.4.0
Dashboards Version
2.4.0
Plugins
No custom plugin enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):

OS: [e.g. iOS]
Browser and version [e.g. 22]

Additional context
Add any other context about the problem here.

[Triage] @deepak-rsystems Thank you for filing this issue.

Dashboard should give an option to select a tenant every single time.

This is expected behavior by design. Users have still have an option to switch tenants by clicking on your avatar and choose the tenant they want to switch to.

When we login to dashboard, the defaultRoute should be in sync with the default tenant (or last selected tenant).

@opensearch-project/security Can someone please look into this behavior?

Hi @opensearch-project/security-dashboards-plugin team,
Could you please let us know, what is the plan for this ticket?
Any fix planned? If yes, in which release?

Hi @opensearch-project/security-dashboards-plugin team,
Could you please let us know, what is the plan for this ticket?
Any fix planned? If yes, in which release?

I will pick this up @davidlago, please assign me.

Update: on 2.11.0 we're unable to disable global tenant, so I couldn't reproduce that error.
Gonna try to reproduce that on 2.4.0

Tested on 2.10.0 with:

disabled global tenant
disabled private tenant
I've created two tenants: cadm and e911

results:

user with e911 tenant was by default on e911_tenant
user with cadm tenant at first login had to choose tenant but his cadm_tenant was selected by default

As said previously I'll compare with 2.4.0.

@kajetan-nobel I think you were able to reproduce the bug, but couldn't acknowledge it.
As per your last comments:
Tested on 2.4.1 (Dashboard and OpenSearch) with the same results. Dashboards are taking the first available tenant for this case by showing up set up defaultRoute (which is set per tenant on Stack Management > Advanced Settings).
Let me provide the problem description in simple words:

We have two custom tenants "cadm" and "e911", where "e911" is the default tenant (or the last selected tenant). Also we have disabled "Global" and "Private" tenants.
There is an inconsistency in Dashboards that for a user login having access to both the tenants:

tenant is displayed as the last selected tenant i.e. "e911", which is fine.
but, the default route is displayed as per the first available tenant i.e. "cadm" tenant default route (sorted in ascending order by tenant name).

Expectation is to see the default route as per tenant "e911" which is the default tenant in this case.
Another example, now take three tenants, "cadm", "e911" and "bmc" where "e911" is the default tenant (the last selected tenant). So when user logins now, it will see default route for tenant "bmc" but selected tenant is "e911"
Let me know if its still not clear.

@deepak-rsystems thank you for your quick reply!
I've got a few questions:

what do you mean by default route? Do you mean clicking on Dashboards menu item?

So an example to reproduce would be:

Sign in and select a tenant
Go to a some dashboard of a tenant
Switch tenant (while being on a dashboard) to a different one
See the error and redirect to the list of dashboards

Second one:

Sign in and select a tenant
Go to a some dashboard of a tenant
Go to home and switch a tenant
Click on menu "Dashboard" item
See the error and redirect to the list of dashboards

Those are reproduction steps then. Am I correct @deepak-rsystems?

@kajetan-nobel Kindly check the definition of defaultRoute in the attached screenshot:

So, default route is the landing page when you open OpenSearch Dashboards.

@deepak-rsystems thank you for your response, I'm glad that we're on the same page, just wanted to be sure :). It looks like the amount of tenants also has an impact on the default route.
Cases
Tested on version: 2.4.1
Side note: Expected behaviors are my proposal as solutions for unexpected behaviors.
User contains only one available tenant after login

It doesn't show a user's homepage, instead, it uses a default route ✅

User contains more than one available tenant after login

It shows a homepage always (ignores completely default route for every case) ❌
expected behavior: uses the default route if the current user has access to the last selected tenant, if he doesn't - should show up a tenant selection (even with Global and Private tenants available)
it shows a selection of tenants only when the site is visited for the first time, after re-login it uses the last selected tenant (expected) ✅
but after logging out and logging in as a different user who doesn't have access to the last selected tenant (from the previous user), it uses the first available tenant alphabetically. ❌
expected behavior: shows up a tenant selection but with selected default tenant. After changing tenant it should go to the default route.

The user changed the tenant

it ignores the default route of the selected tenant ❌
expected behavior: goes to the default route of selected tenant after switching
co-related GUI issues to the last selected tenant (repro steps are in https://github.com/opensearch-project/security-dashboards-plugin/issues/1261#issuecomment-1829750611)

clicking in the menu Dashboard after switching a tenant throws an error that Could not locate the dashboard
switching a tenant while being in the dashboard of a different one throws the same error
expected behavior for both: after switching a tenant it should go to the default route. For such a solution, it'll never try to access an unavailable dashboard.

Summary: Default route is only used when an available tenant is only one. So it'll never be used when Global and Private are also enabled because they're treated as tenants which was said in issue #1245. As those two issues are co-related and I've tried to cover impacted cases I propose to merge #1245 to this one. Also when the last selected tenant is not found we should rather show a menu of selection tenants with preselected default tenant and use the default route after switching.
As I was debugging, and looking into that I found additional cases that are related, so decisions here will be needed
@DarshitChanpura @davidlago @peternied


Add network_ee_stable_2.11 jobs

given this depends-on the ansible-runner images, we should add depends-on (in your first comment). then zuul knows the merge order.

given this depends-on the ansible-runner images, we should add depends-on (in your first comment). then zuul knows the merge order.

done

recheck

recheck

recheck

Recheck


However, there are cases that two optimizers are used optimized different parts of the network, for example, a CNN+LSTM. one would want CNN to be updated SGD and LSTM to be updated Adam.

+1, would also be useful for certain types of adversarial cases where the steps are not alternating (e.g. Concrete DropBlock from https://arxiv.org/abs/2004.04725)


improve Acces denied

I did some additional testing with explicitly supplying wrong password and username.
This now actually catches the wrong password/usernames

@Squachen sorry, I did not expect to have it merged so soon, was not yet fully done with testing.
I schould have waited before making the PR.

@starkillerOG Nah sorry, that's on me. Wanted to get a new version pushed asap since I'm at the right computer atm but don't know if I will be for the next couple of days. Is it ready for merge/version update now?


Issue #88 Disable filtering when destroying

The code internally could not distinguish between setting -P or not setting any -p
option at all. The net result was that -P really only unsets all prefixes passed
on the command line with -p 'prefix' before the -P is encountered.
This commit changes that: -P now is treated independently and will skip
prefix filtering if set.

Tests are broken with this change :(
The problem is that PREFIX_FILTER='true' should be defined in core since you modify core logic.

Thanks for the feedback. I will have a look.

I have slightly rewritten the logic. First I have reverted the logic - there's no SKIP_PREFIX_FILTER instead of PREFIX_FILTER. This made the conditionals slightly easier to construct. Next I have added a local default in core. So if SKIP_PREFIX_FILTER is unset, core acts as if it's 'false'. And finally I have added unit tests to verify it all still works.


xenia: Add version 1.0.276

There is no active release.
No reason to have it in Extras. Extras addition could be considered as soon as the release process will be stable with tags and real version instead of this junk "release process".
What could be done in Extras is to have it using nightly, but I would rather avoid it and wait for some real release.
{
    "version": "nightly",
    "description": "Xbox 360 Research Emulator",
    "homepage": "https://xenia.jp",
    "license": "BSD-3-Clause",
    "suggest": {
        "vcredist": "vcredist2019"
    },
    "architecture": {
        "64bit": {
            "url": "https://ci.appveyor.com/api/projects/benvanik/xenia/artifacts/xenia_master.zip?branch=master&job=Configuration%3A%20Release&pr=false"
        }
    },
    "bin": "xenia.exe",
    "shortcuts": [
        [
            "xenia.exe",
            "xenia Xbox 360 Research Emulator"
        ]
    ]
}


Add support for Perl built with C++

For Perl XS modules, particularly those in the core, you need your module to support being build with a Perl binary created with a C++ compiler.
I'm just updating   Compress-Raw-Zlib with a C- related change that gets stung with this use-case more often that I'd like.  The typical workflow  goes like tis

I update the module, forgetting to test the C++ use case
code gets uploaded to CPAN
the smokes run but they fail with the C++ builds
I scramble to fix the issue & upload a to CPAN

I have all of the use-cases I need cooked into my GitHub actions, but this one is missing. Any chance of adding C++ support?

I have never built Perl with C++.
How do I do that?

At the configure stage just use Dcc to use a C++ compiler rather that the default C compiler.
configure -Dcc=g++ ...

or this for clang
configure -Dcc=clang++ ...

@pmqs you should be able to test C++ builds sufficient for updating your modules in core by replacing:
perl Makefile.PL

line in your workflow file with:
perl Makefile.PL CC=g++

@pmqs you should be able to test C++ builds sufficient for updating your modules in core by replacing:
perl Makefile.PL

line in your workflow file with:
perl Makefile.PL CC=g++

Thanks @tonycoz
Part of the reason for wanting the C++ mode is to trap compiler errors & warnings in a build that I always forget to do when I'm getting a release together. The CC=g++ change works fine with the Linux gcc workflow, but the Mac workflow triggers a clang built Perl, so the CC=clang++ build that also include -Werror triggers this
clang: error: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Werror,-Wdeprecated]

That feels like a wider issue with building Perl with C++ in general that is going to cause problems when clang drop building C code with their C++ compiler.

For your purposes you can probably do:
perl Makefile.PL CC="clang++ -xc++"

unfortunately that doesn't work when building perl itself (which I tried to fix in Perl/perl5@07e3b5cdb6f7260446b791acf0623e01a37e4739 but had to revert in Perl/perl5@0c77b7235984453280b85b181aecb8e757ee8480)

For your purposes you can probably do:
perl Makefile.PL CC="clang++ -xc++"

unfortunately that doesn't work when building perl itself (which I tried to fix in Perl/perl5@07e3b5c but had to revert in Perl/perl5@0c77b72)

That's a good option. Didn't see that one in the clang docs. Another option I investigated was -Wno-error=deprecated but that doesn't silence the warning, plus it hides other possible deprecations.
Another option I use with C builds is -Wc++-compat


Professionalize Test Suite

What feature should we add?
It's unclear where to add tests, so this issue will involve moving them around in a way that makes sense and provides a baseline for new tests to be added. We'd also like to add the ability to test against different backends. Testing against different backends may make sense to split out into its own issue.

I think you addressed this but just to clarify at least part of it. We should try to see if there is a way to run the same tests against different backends in order to DRY the code and avoid missing some tests for some backends. I think it may make sense to have some backend-specific tests but we should see what we can combine along the way.


ImportError: cannot import name DEFAULT_CIPHERS

python -m elastalert.elastalert --verbose --rule nginx_access.yaml
Traceback (most recent call last):
File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib64/python2.7/runpy.py", line 72, in run_code
exec code in run_globals
File "/usr/lib/python2.7/site-packages/elastalert-0.1.39-py2.7.egg/elastalert/elastalert.py", line 19, in
import kibana
File "/usr/lib/python2.7/site-packages/elastalert-0.1.39-py2.7.egg/elastalert/kibana.py", line 5, in
from util import EAException
File "/usr/lib/python2.7/site-packages/elastalert-0.1.39-py2.7.egg/elastalert/util.py", line 10, in
from auth import Auth
File "/usr/lib/python2.7/site-packages/elastalert-0.1.39-py2.7.egg/elastalert/auth.py", line 3, in
import boto3
File "/usr/lib/python2.7/site-packages/boto3-1.9.172-py2.7.egg/boto3/init.py", line 16, in
from boto3.session import Session
File "/usr/lib/python2.7/site-packages/boto3-1.9.172-py2.7.egg/boto3/session.py", line 17, in
import botocore.session
File "/usr/lib/python2.7/site-packages/botocore-1.12.172-py2.7.egg/botocore/session.py", line 30, in
import botocore.credentials
File "/usr/lib/python2.7/site-packages/botocore-1.12.172-py2.7.egg/botocore/credentials.py", line 42, in
from botocore.utils import InstanceMetadataFetcher, parse_key_val_file
File "/usr/lib/python2.7/site-packages/botocore-1.12.172-py2.7.egg/botocore/utils.py", line 31, in
import botocore.httpsession
File "/usr/lib/python2.7/site-packages/botocore-1.12.172-py2.7.egg/botocore/httpsession.py", line 7, in
from urllib3.util.ssl import (
ImportError: cannot import name DEFAULT_CIPHERS

If anyone every comes across this again, you basically need to update urllib3:
pip install --upgrade urllib3 --user
or if you have different versions of Python:
python -m pip install --upgrade urllib3 --user

DEFAULT_CIPHERS is removed from urllib3 2.0.0
If you encounter this in 2023, you might want want to pin to a version < 2
pip install 'urllib3<2'

I tried it and it's still not working :/

@CliveCorbishleyTAL Where did you get DEFAULT_CIPHERS is removed from urllib3 2.0.0 information from?+

@saharudra -- looks like it's in the urllib changelog: https://github.com/urllib3/urllib3/blob/b234aaf7ccbcb64012d8b33d21eb8bc9f768935d/CHANGES.rst#L43


Average operator

Average operator implementation

Already implemented in https://github.com/ReactiveX/RxGo/pull/117


Make an option to ignore "a 'return' statement can only be used within a function body" problem

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: February 2022
OS Version: Irrelevant

Steps to Reproduce:

onkeydown="return NotNeg(event)" onpaste="return NotNeg(event)" ondrop="return NotNeg(event)"
Make Sure You Have The Latest Updated Version Of VS Code

The 'Problems' pane will give the problem: "a 'return' statement can only be used within a function body". These functions work perfectly with the 'return' written in and do not work well without it. I uninstalled this version and reinstalled the January 2022 version, as I used it until yesterday, and it worked perfectly without showing this issue.
What I want: I just want an option to right-click on this issue and have the option to ignore it so it doesn't show up, as well as be able to see and edit all ignored issues in some settings.

duplicate of #143220
I don't think we need a setting, we just have to fix the issue and not issue a error.


fixed typo

I know, sorry for such a lame PR 😁
And to increase the usefulness of this PR a tiny bit: your amazon wishlist link in THANK_YOU.md does not work

There are no lame PRs :wink:
Thanks for noticing and fixing!

Coverage remained the same at 96.482% when pulling 97fe2e6791e95944efbfeae4fdacd12d0e67719b on kevinpapst:patch-1 into 74f93435160c19e0f5b2f64a6dbdc0519fe6684c on heiglandreas:main.


Revert AliasTuple back to AliasSeq

See<EMAIL_ADDRESS>

LGTM. Seems @andralex approves in the forum thread, so I'm tempted to toggle automerge, but I'll let a few more reviewers chime in first.

I'm really done with this debate, but I'll at least chime in and say I still have no objection to AliasSeq.

The leadearship has spoken. I wouldn't merge simpy because that's be me merging the same thing twice.

-1 from, for reasons already explained several times. It's the worst of all suggestions so far.

People argued against pack b/c AliasSeq auto-expands.
In that sense it's very different from http://en.cppreference.com/w/cpp/language/parameter_pack.

Why do you use TypeList/TList throughout the documentation?

I'm fine with this. If no strong new objection please merge but only after minding @MartinNowak's review.

@MartinNowak Thanks for the thorough review.  I fixed the typos, but I'm not the person to fix the irregularities in the naming conventions here as I think there are quite a few more than the ones you pointed out.
For the record, I'm simply reverting https://github.com/D-Programming-Language/phobos/pull/3488 (which was merged prematurely) back to https://github.com/D-Programming-Language/phobos/pull/3463.
I politely ask that you merge this PR as is, putting master back into a previously merged state, and that @deadalnix (originator of https://github.com/D-Programming-Language/phobos/pull/3463) please volunteer to clean up the naming conventions.

Auto-merge toggled on

thx all!

It's ironic that AliasSeq was selected, whereas setExt was vilified for using an abbreviation.

@WalterBright keeping in mind that there already was setExtension adding setExt met expected resistance.

@klickverbot so what do you think of Seq?

@WalterBright very few are happy with this name.  It was selected by decree and out of frustration because the conversation devolved into sarcasm and belittlement of cooperation as "bikeshedding"


Minor spelling mistake:

Will fix it today. I plan to revamp the whole README.md. And maybe create some docs page. It should be fixed today.


Poetry -> Flit

Codecov Report

Merging #13 (8f61556) into main (42253fb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   85.94%   85.94%
=======================================
  Files           7        7
  Lines        1010     1010
=======================================
  Hits          868      868
  Misses        142      142

Impacted Files
Coverage Δ

pyabc2/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42253fb...8f61556. Read the comment docs.


How to keep the bot online?

Hi guys!
I'm trying to set up this kit to remove https://github.com/mvaragnat/botkit-express-demo from my bot.
Once I cloned, installed dependencies and added my Slack app details, the bot sends me the I am a bot that has just joined your team message when the Oauth was successfully, but it never changes it states to on so I can't send any command. Also, it doesn't run if I don't remove the .data/db folder before running it.
Not sure if I'm doing something wrong or there is any configuration that I'm missing.
Thanks in advance!

This is the last debug message I get
debug: Got response null {"ok":true,"channel":"D52343234","ts":"1234323432343","message":{"type":"message","user":"U23423434","text":"You must now \/invite me to a channel so that I can be of use!","bot_id":"B5ACE7CH1","ts":"1234323432343"}}

Hi @benbrown,
Yeah the app config in Slack looks good, it works fine if I use the same app with a different project, I guess could be something in the code...
But I'll try this first
npm install -g botkit
botkit new --platform slack

Thank you!


removed duplicate with tags and groups

Resolved duplicates mention in #868

Before merging this we should discuss with mg-nestleder as it might not be an issue or solved the wrong way-

Both changes needs discussing before adding
Showing all tags also needs some styling


Change data visualisation from Vega to Plotly for Umeå and Örebro page.

Modify historic_orebro_umea.md to use plotly data visualisation instead of Vega.

Don't worry about the last force push, I (might) have forgotten to deal with the Swedish version of the page, so I just extended the previous commit :)

Add explanation for '***' in the graph legend by either:

separating * and ** in the x axis data
adding a third line to the legend

Figure out exactly what the * refer to

Checking visualisation responsiveness

Sorry Liane, I squashed some related commits together to keep things consistent and tidy but I realised too late that they are under my name now... I'll be the one targeted by git blames though ^^

To summarise:

[x] pages content updated according to your commits
[x] visualisation  CSS style to 600px so it stops shrinking and becomes scroll-able on smaller view-ports


unsupported tag format

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.

Description
the current tags (0.9.13, 0.9.12, ...) don't work with the go modules system.
could you add tags v0.9.13, v0.9.12, ... ?
Steps to Reproduce
go get<EMAIL_ADDRESS>
Expected behavior: [What you expect to happen]
require (
	github.com/vinyldns/go-vinyldns v0.9.13
)

Actual behavior: [What actually happens]
require (
	github.com/vinyldns/go-vinyldns v0.0.0-20200917153823-148a5f6b8f14
)

Reproduces how often: [What percentage of the time does it reproduce?]
100%
Versions
All current versions.
Additional Information
none.

Fixed in #82 and Release v0.9.15


lung dataset status is wrong

Lung dataset status has events showing up as 1 and 2 instead of 0 and 1. Leads to no censoring in cph fitting.
from lifelines.datasets import load_lung
lung = load_lung()
lung['status'].hist()

ah, this should be changed to the more standard coding :+1: thanks!


added reconnectNow to allow reconnecting immediately

The current reconnect method is just closing the socket and waiting for the reconnect timeout to happen.
I've added a new reconnectNow method that reconnects 'immediately'.
It also can be used to connect if the connection is currently closed.
Both could also happen within the reconnect method instead but I wasn't sure whether the existing behaviour was intentional.

@de-git  Thank you for the PR.
Please pay attention to the contribution guideline and be branched by and targeted towards `canary´ always. As well as a proper commit message (for the changelog)

@de-git  Ehm.. are you still wanting to pull request this here? I'm a little bit confused, i.e.  7e90835 ?!

Yes, sorry. Didn't receive a notification email. I will review the contribution guideline and make the necessary changes.

This pull request has now been superseded and can be closed.


Mobile navigation does not close when going form mobile to desktop sized viewport

When resizing the browser from a mobile sized width to desktop with the mobile navigation open, the navigation should close. Right now, it doesn't. The class global-nav-expanded on <body> is not removed when resizing. It works correctly when clicking to close though.
Steps to Reproduce

Resize your browser down to 900px or less
Open the navigation
Resize to more than 900px
See error in the console and broken layout

Technical details:

Ghost Version: 43f2be4d798d57d0e9170f142cd15e4d2799ec1c (also present in 0.5.8)
Client OS: Mac OS X 10.10.1
Browser: Chrome 40

Nice find :+1:
Coincidentally, I was working on an "ember cleanup" PR this morning and this bug is fixed in it.

@jaswilli has that PR landed, or is it still to come?

@ErisDS I have it in a big "ember clean-up" branch which I've been holding back in consideration of the ember-cli work.  I'll separate out just the fix for this issue and push it up.

which I've been holding back in consideration of the ember-cli work

<3


Polymorphic relations

Is there any solutions to have polymorphic relations in the model?
For example:
class Photo
belongs_to :article
belongs_to :event
end
/articles/:id/photos/:id
/event/:id/photos/:id
And have such methods for querying photos:
Photo.where(article_id: 1).find(2)
Photo.where(event_id: 2).find(3)
Now, two 'belongs_to' relations in the model leads to such method:
Photo.where(article_id: 1, event_id: 2).find(2)
/articles/:id/event/:id/photos/:id
And if I mention only one relation in the query, it leads to ArgumentError

I don't have the ability to do polymorphic relations at this time. I will think about it, but if you have suggestions, I'd love to hear them.


Strip login hint from redirect URL when present

This is following up on #217 by removing the login hint query parameter from the redirect URL if it is there.

@lennartschoch , overall LGTM. One comment please rewrite your test to use testcases. See https://github.com/greenpau/caddy-authorize/blob/main/pkg/shared/idp/config_test.go for example.

Oh, right! :) Thanks for the hint, done!


DUT response to touch is very slow

https://buganizer.corp.google.com/issues/150860723
cc @dkwingsmt and @iskakaushik. Conversation on the Google bug.

@dkwingsmt The internal issue was assigned to you, so I also assigned this mirror issue to you.

@dkwingsmt Can you please assign a conservative milestone to this bus? Thanks.

@goderbauer I would like to, but I'm waiting for the response for the question I asked in the thread. For now I don't have any way to reproduce it.

I did find a bug during investigation, which will be fixed by https://github.com/flutter/flutter/pull/52450. I'm unsure if it's the cause for this issue, and I'll update the internal ticket for confirmation once the fix is rolled in.

We believe this is closed.


Update formatDuration

Switched formatDuration's math to determine hours & minutes using .toFixed(0) instead of Math.trunc(), which appears to do a better job of gracefully rounding the calculations so that you don't get results like "1h 60m 60s"

Addresses issue #117

Sorry, but you've got it backwards - this will only make the problem worse. See the following:

Yeah, I saw that it wasn't working as I was running a few other test cases. Will probably poke just a little more at it on my own branch.


bboxarea.cxx calculation is incorrect for orthographic cameras

I am looking at a bug where the eye position is directly beneath a bounding box. So, the classifier in bboxarea.cxx uses the bottom of the bounding box to calculate the area. But the orthographic view direction is parallel to the bottom of the bounding box, so the area is calculated as 0.
I think for orthographic cameras, the view direction needs to be used for classifying the silhouette, not the eye position. I think the using the max/min based on the sign of the direction would work. Maybe something like this:
int pos = ((dir[0] > 0) ?  1 : 0)   // 1 = left
        + ((dir[0] < 0) ?  2 : 0)   // 2 = right
        + ((dir[1] > 0) ?  4 : 0)   // 4 = bottom
        + ((dir[1] < 0) ?  8 : 0)   // 8 = top
        + ((dir[2] > 0) ? 16 : 0)   // 16 = front
        + ((dir[2] < 0) ? 32 : 0);  // 32 = back

Hi, Cleve! Thanks, I know what you mean, and yes, the direction is what you can use in this case. I've made a note in the code itself.
 You really need a table of just 27 entries, not 64, and Eric Lengyel's implementation uses this; otherwise the idea's the same. See "Game Math Case Studies," http://www.terathon.com/gdc15_lengyel.pdf

I was actually looking at the implementation you did for LMV and it uses the 27 entry table. It took me a  some time to track this one down.

Sorry, I should have added a comment! Now you know my sources.


XLIFF import compatibility with WPML

Motivation
We already support importing XLIFF files that were exported by WPML/WP. However, we will change at least some page slugs during migration. These slugs are used by WPML to match the exported pages. We need a mechanism that can match old WP slugs with the new Integreat CMS pages.
We want to be able to transition from WP to our new CMS at any time. Stopping XLIFF exports for several weeks is currently not an option. As the migration itself is postponed anyways due to limitations of the service team, we can implement this feature to enable a migration at any time.
Proposed Solution
Options:

We can create a mapping file when updating the slugs after migration (see https://issues.tuerantuer.org/browse/INFRA-161). This mapping file can be used for searching and replacing the slugs in the XLIFF file before importing.
Add an additional (temporary) field to the page translation model that stores the WP slugs w/o changes.

Alternatives
More ideas are welcome.

We decided to solve it by creating a mapping file during translation: https://issues.tuerantuer.org/browse/INFRA-196


Closing client leads to server error

Start a polling session
Open a polling client, (optionally submit a vote
Stop the polling
Close the client (after the session has been closed)

This throws an error, since session.ui.onFinished() is called (poll.js, line 132) but the session.ui has been set to null before (in step 3 above).
Closing a client for a closed session should probably not trigger anything.

This is not happening here.

Still happening...
https://github.com/decker-edu/quizzer/assets/31275467/1bb575e4-0107-48ac-a12a-ac1066ea76a2


Add Maven Central as a fallback for dependency download

To reduce flaky CI builds when JCenter is experiencing a blip
Example failure from Travis:
> Task :rabbitmq:compileTestJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Could not resolve all files for configuration ':rabbitmq:testCompileClasspath'.
> Could not resolve org.assertj:assertj-core:3.12.2.
  Required by:
      project :rabbitmq
   > Could not resolve org.assertj:assertj-core:3.12.2.
      > Could not parse POM https://jcenter.bintray.com/org/assertj/assertj-core/3.12.2/assertj-core-3.12.2.pom
         > Could not resolve org.junit:junit-bom:5.4.0.
            > Could not resolve org.junit:junit-bom:5.4.0.
               > Could not get resource 'https://jcenter.bintray.com/org/junit/junit-bom/5.4.0/junit-bom-5.4.0.pom'.
                  > Could not GET 'https://jcenter.bintray.com/org/junit/junit-bom/5.4.0/junit-bom-5.4.0.pom'.
                     > Read timed out

I'd estimate this kind of failure accounts for ~20% of the CI jobs that I have to re-run, and it's a waste to have to do so.
If we use Maven Central as a fallback, I believe that our builds should be more stable.

@rnorth seems to be failing, but due to the plugin resolution :D


Delete be-maptime.json

Maptime project seems dead.
We have decided to disable our Maptime chapter.
Our events are not displayed directly on our website : https://openstreetmap.be/calendar.html

ok, thanks @jbelien


StepDefinition.sourceReference should be StepDefinition.source_reference

Summary
This follows-up #816, one of the field is still in camelCase.
Details
Change StepDefinition.sourceReference to StepDefinition.source_reference
How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[ ] The change has been ported to Java.
[ ] The change has been ported to Ruby.
[ ] The change has been ported to JavaScript.
[ ] The change has been ported to Go.
[ ] The change has been ported to .NET.
[ ] I've added tests for my code.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Note: locally when running make, I get loads of changes in the file java/src/main/java/io/cucumber/messages/Messages.javawhich don't really look related to the changes in the .proto file.
I haven't committed them.


Create proper docker compose file

current one is not maintained and incorrectly designed as it builds binaries with every container start

fixes #210


improvements to user/getTest

Move all components of "getTest" header section to the center of the page
-Provide a light background as in the register page on https://gitanjali.org/register
Create a line separator between "create test" and teacher's list of tests as seen in https://gitanjali.org/school
use text type and color to match gitanjali.org/school
the text length of the fields in the table is changing. fix the max length of characters in the fields to (say) 5 for index, 500 for question text(but it should wordwrap within a specified length), 5 for score and fixed length for delete button

partially done!!

extra field on right most side of table
table needs padding on left and right
all fields should have word wrapping


Properly applied xrdb patch

I properly applied a working version of xrdb patch, allowing for modifying dwm's colors directly in xresources with:
dwm.normbordercolor: #....
also, the xrdb function found in config.h binded to mod+f5 now properly works and applies colors to dwm without needing to restart dwm and reset all window positions and tagging.

The whole reason the xrdb patch was removed is that the more complete xresources patch is used now which loads other non-color variables as well. While I'm fine with you adding the binding with the other patch, there's no reason to have to redundant (and contradictory) patches at the same time.

I am aware that the other patch was used, but I couldn't manage to make it work for any other variable besides automatically reading *color# values from xresources, so basically dwm.normbgcolor or any other wouldn't load

Okay, I completely overlooked how actually existing patch in your repo works, thank you for your time, closing this


Broken Liquid / Markdown in Lua, enterprise docs

See this docs build, for instance.

Moving to the backlog until we know more context


Cloud Firestore orderBy doesn't return null values

The docs say that null values should come first in any ordering.
However, the following stream excludes any documents where the createdAt field is null:
Firestore.instance.collection('someCollection').orderBy('createdAt', descending: true).snapshots()
How do I get all the documents, orders, including null values (first)?
Thanks!

@Vluf
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/1204. Any further collaboration will be done there.


Zap event is not published on specific condition

I have encountered rather interesting and not obvious bug - zaps event are not published if nostrudel didn't make any writes to relays (like reaction, boost, follow etc). For me seems to be reproducible - just refresh page with nostrudel, you can even double check that you've authenticated on relays, however it does not help, it is necessary to do some write to relays first.

Thanks for clarifying this. I haven't encountered it again for other zaps, so I will close this issue.


Form not found, shadowroot problem?

Version of the custom_component
6.7.3
Configuration
multiscrape:
  - resource: "https://app.usertesting.com/my_dashboard/available_tests_v3"
    scan_interval: 20
    timeout: 30
    log_response: true
    form_submit:
      submit_once: true
      resubmit_on_error: true
      resource: "https://app.usertesting.com/participants/sign_in"
      select: ".ng-untouched .ng-pristine .ng-invalid"
      input:
        email: x
        password: x

    sensor:
      - unique_id: ut_tests
        name: Number of tests
        select: "head > title"
        value_template: "{{ (value) }}"

Describe the bug
Im trying to setup a script to see how many usertesting.com tests are available for me, but Im getting an error when trying to submit the form in order to login to my dashboard.
Maybe its because the form on the login site is in the shadowroot?
Debug log
This error originated from a custom integration.

Logger: custom_components.multiscrape.coordinator
Source: custom_components/multiscrape/coordinator.py:75
Integration: Multiscrape scraping component (documentation, issues)
First occurred: 11:57:10 AM (9 occurrences)
Last logged: 12:00:00 PM

Scraper_noname_0 # Exception in form-submit feature. Will continue trying to scrape target page. Could not find form

Or maybe its because the form on this example didn't load yet, since the page looks like its loading parts of it asynchronously ?


be careful which checkout command is used

if the branch was just created, then don't use -b

I merged with master.

woo-hoo!  finally worked: https://travis-ci.org/gforsyth/travis_docs_builder/builds/146477229


Version 4.13.4 introduces major breaking changes

Describe the bug
Specifically, the upgrade of some dependencies here: https://github.com/distubejs/ytdl-core/commit/efa92e91bdc18fd50897d0cb35ed96f4c86cc858
One upgrade that caused uncompilable code for me was undici 5->6, as detailed by somebody else here: https://github.com/nodejs/undici/discussions/3010
In general, as this commit upgrades major versions of the dependencies, it should cause a major version bump in the next release.
Debug File

N/A
Environment

@distube/ytdl-core version: 4.13.4
Node.js version: 20
Operating system: All

This is a fork so I don't care about semver, it is why there are many breaking changes while the version is still 4.x.
Anyway, you can use overrides to downgrade your undici version.
I will replace this with a brand new project soon.

I would but...  apparently overrides doesn't work with a monorepo if you're using npm workspaces. That's why I've been unsuccessfully trying to move to yarn or pnpm for the past few days.

For anyone reading this in the future, I simply copied the code from this repo directly into my project (with the license and its notice), and installed the dependencies manually. I had to adapt the code a little bit but it works.


feat: add support to extension .res, .resi, .rei

It will enable reason-mode to .res to ReScript

There are no resi files in rescript?
I'm not sure it is a good idea to have this merged. The syntax of rescript is different from the syntax of rescript. And the rescript people want to have full control of the pipeline which I guess mean they will have their own emacs mode.

https://rescript-lang.org/docs/manual/latest/module#every-resi-file-is-a-signature
if we want to merge this, it must be enabled on resi files too.

https://rescript-lang.org/docs/manual/latest/module#every-resi-file-is-a-signature
if we want to merge this, it must be enabled on resi files too.

Updated to accept .resi, can u check?

Hey @Khady, what do you think?

My problem with merging this is that rescript syntax is the not the same reason syntax. So the syntax provided by this mode is not fully relevant. Also if people are using merlin/ocaml-lsp based on this mode it will also not work given the different syntax. Maybe it is better to have a different mode for rescript?
I am not against merging this, I guess it can help at least temporarily. Just not sure that it is the right thing to do.

I agree with you about rescript make more sense.
But, liked you said it's temporary, what do you think about we create a rescript mode? And just to start use the same code as reason-mode.

I don't have the rights to add you to the organization. You should probably discuss the rescript mode on the rescript forum and they will guide you on where to host it. It can totally be a fork of the reason-mode to start.
In the meantime I'll merge this PR as it is better than nothing. Thanks for submitting it. Please let me know if/when it is no longer necessary.


starrating: half stars don't display in Safari

Bug
Expected behavior
All stars display, like in Chrome
Actual behavior

It took me way too long to remember how to debug in Safari.
My research thus far isn't giving me anything. Will continue to look around.


Locate cells within data grid

can you help me to locate control which i have circled below,

I am unable to locate individual cell in data grid. Please find application links below,
DemoForm1.exe
GridsDemo.exe
Also i need your help to locate COM/ActiveX control. I will come up with some sample application with such controls.
Thanks,
Maqdoom

You currently can't locate a specific cell using WinAppDriver because the table doesn't expose the cells to UI Automation.  What you can automate depends on what the control provides to UI Automation.

The individual cell within the DataGrid control you have in the application is not accessible. In general, Windows Application Driver can only see elements and properties that is shown in inspect.exe.
As you can see in the inspect.exe tool, some of the most useful information you can get from the DataGrid above are simply:

Attribute
Value

Name
"AutomationStringGrid1"

ControlType
UIA_DataGridControlTypeId (0xC36C)

LocalizedControlType
"data grid"

ClassName
"TAutomationStringGrid"

Grid.ColumnCount
5

Grid.RowCount
5

Selection.Selection
"Row 3, Col 2"

Value.Value
"Row 3, Col 2"

Table.ColumnHeaders
"Title 1"

"Title 2"

"Title 3"

"Title 4"

"Title 5"

Table.RowHeaders

Table.RowOrColumnMajor
0

Hi,
Is there any way to identify  a row in datagrid?
In my scenario, I intend to click on a datagrid row and trying to read row details that are populated in different controls on the same form.
But I could not find a way to identify different rows. Is this possible?


unfs3: mark as broken

Motivation for this change
ZHF: #122042
https://github.com/unfs3/unfs3/issues/13
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

#182309 may be of interest.


feature/snapshot-save

ability to save snapshots
ability to disable snapshot tracking
refactoring of magic numbers
introduced atoms
refactoring of components - mainly made them smarter

First of all thank you so much for an amazing PR 🎉 This would help a lot.
I noticed that once you save a snapshot and then when you switch between other stores or observables, the snapshot you saved from another store or observable still shows up.
I expect it to only show up on the recorded store and not in other stores.
Is this an intended behavior or a potential bug?

you're right - we should filter the saved snapshots by tracker. will add that.

Thank you!

Thank you @robinfehr for this PR. Hoping to push a release within a couple of days.

#1 can be closed I guess - for the persisted version we could open a new issue.


Need target element label in imagemap

The HTML image map construct allows for a label to be provided when hovering over a target in an image map.
This was originally put into an alt attribute in IE.  Later browsers put it into a title element instead.
When we generate an image map, we should retrieve the alt text, and use it as the contents of the <xref> element.
The example here includes a "Section 1" label: https://docs.oasis-open.org/dita/v1.0/langspec/imagemap.html

Fixed in #474.


Delay the initiation of exit-messages.

This should avoid the error where the config-file function is run at compilation time and thus shows the incorrect path in the help text.
This solves issue #10.

I've verified that the path in the error message expands to the full path of the current user when running the built binary on Arch Linux.


Fix IPv4 address validation

The regex had an en-dash instead of a hyphen in the character range

Can one of the admins verify this patch with one of the following commands:

"jenkins test please" for a one time test run
"ok to test" to accept latest and future commits on this pull request for testing
"add to whitelist" to add the author to the whitelist

ok to test


Sidebar links include a locale not used by the site after 0.28.5

What version of starlight are you using?
0.28.5
What version of astro are you using?
4.16.8
What package manager are you using?
pnpm
What operating system are you using?
mac
What browser are you using?
Chrome
Describe the Bug
We hit an issue related to this https://github.com/withastro/starlight/pull/2548 - our docs don't use the /en/ prefix (we have defaultLocale: en), and after updating, sidebar links include the /en/ prefix and thus lead to 404s: staging deploy that replicates the issue here: https://d30789a7.val-town-docs.pages.dev/
Link to Minimal Reproducible Example
https://d30789a7.val-town-docs.pages.dev/
Participation

[ ] I am willing to submit a pull request for this issue.

Thanks for the issue @tmcw! It looks like you actually have a misconfiguration that happened to work as you expected previously, but wasn’t intended to. Sorry nonetheless for the disruption!
The locales config in your astro.config.mjs should either look like this:
      locales: {
        root: {
          label: 'English',
          lang: 'en',
        },
      },

(as documented in the Starlight i18n guide)
OR can be omitted entirely as an English root locale is also Starlight’s default.

Thanks again for the issue @tmcw — going to close this as I believe it has been resolved, but let me know if you have any questions or still think there’s a bug here.


[FEATURE REQUEST] Add a black linter workflow

Description
Is your feature request related to a problem? Please describe.
As a project with multiple users contributing to it, it is essential to maintain a proper linting style to ensure better code readability by users. An excellent way to do this is by automatic linting checks using the prettier linter in GitHub actions.
Describe the solution you'd like
Add the prettier linter to ensure proper and uniform linting of the codebase.
I would like to work on this as a part of GSSoC 23.

Not needed.


How to set a custom MaxRetry for minioClient?

because the dafault MaxRetry is too large for me.Thanks!

import "github.com/minio/minio-go/v7"

func init() {
   minio.MaxRetry = 1
}


feat: use AdbServerCommand variants for usb commands when applicable

Changes

Added a convenience method into_bytes for AdbServerCommand which returns a Vec<u8> of the stringified command
Replaced hardcoded strings like shell, sync and reboot directives with variants of AdbServerCommand for the usb implementation

Hi !
I'm not so confident using ADBServer code in USB features. We may use a feature flag later on to split between these two parts of the project, and mixing code goes quite against it.
I would recommend either using a common structure that could go in these two components, or just leave as it is (this is just an enum field, there is not a big difference)
I was planning to have a look at global code architecture as we introduced a new trait and directory structure may be improved

Would you like me to close this then?
-------- Original Message --------
On 10/29/24 13:33, cocool97  wrote:

Hi !
I'm not so confident using ADBServer code in USB features. We may use a feature flag later on to split between these two parts of the project, and mixing code goes quite against it.
I would recommend either using a common structure that could go in these two components, or just leave as it is (this is just an enum field, there is not a big difference)
I was planning to have a look at global code architecture as we introduced a new trait and directory structure may be improved
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Yes I think we can close it for now, I'll do the architecture changes soon


V1.4 update UGDG

DG implementation details updates

addalloc
addscore
show

Note: I made some cosmetic changes hence it doesn't look standardised currently.
Will update others' part accordingly once everyone is done with their update.

Codecov Report

Merging #278 (64a48d0) into master (5fd50b1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #278   +/-   ##
=========================================
  Coverage     74.31%   74.31%
  Complexity      925      925
=========================================
  Files           105      105
  Lines          2920     2920
  Branches        396      396
=========================================
  Hits           2170     2170
  Misses          647      647
  Partials        103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd50b1...64a48d0. Read the comment docs.

Looks fine in general, just some minor tweaks should be done in order to stay consistent with the other sections.
I'm generally of the opinion that the sequence diagrams add absolutely no value (especially since they're tiny). Though you can leave those on for now, we can discuss this along with the table of contents later in the meeting

Hm I changed the table of contents to be auto-generated alr (since I also find it inconvenient to have to update it every time something change), but somehow the deployed website doesn't show up as expected

Looks fine in general, just some minor tweaks should be done in order to stay consistent with the other sections.
I'm generally of the opinion that the sequence diagrams add absolutely no value (especially since they're tiny). Though you can leave those on for now, we can discuss this along with the table of contents later in the meeting

Hm I changed the table of contents to be auto-generated alr (since I also find it inconvenient to have to update it every time something change), but somehow the deployed website doesn't show up as expected

i prefer it to be manually written though, the auto generated one looks a bit messy. we just have to make one adjustment at the end after everything else is completed.