Adds load info to DrmSessionEventListeneronDrmKeysLoaded()

This is a first pass at what we talked about in issue https://github.com/androidx/media/issues/1001

added the wrapper class KeyLoadInfo to embody the requests required  to fetch the key
added KeyLoadInfo to the DrmSessionEventListener.drmKeysLoaded() method
Deprecated DrmSessionEventListener.onDrmKeysLoaded(int, MediaPeriodId)
added new onDrmKeysLoaded() with the KeyLoadInfo, setup so both method are called

Next steps are to add it to AnalyticsListener and update any broken test cases possibly add some new ones

Unless we want to go for renaming KeyLoadInfo to KeyRequestInfo and moving forward with the drmKeysRemoved() update too... I would squash the commits and run the code beautifier on what we have.
I'm good either way.

I'm on vacation next week @icbaker so it will take a bit to get to these changes.  Only one I need your input on is best path for the taskId

This latest force-push was to rebase to latest main branch, dropped changes to HttpMediaDrmCallback to "resolve" the conflicts.  Will add code back that was moved from  HttpMediaDrmCallback to DrmUtil.executePost() in the next commit / push.


Allow a second ssh to running container

expose something like pide ssh to connect a second shell to the same docker container

Save off the "temp" name to the .pide file?

Note: killing the main screen will terminate the container.

Implemented as pide ssh.


Code to partially handle unbound DNS

Hi Mika,
I'm not a Splunk expert yet but I added a few lines to more or less handle unbound DNS logs and make them more or less CIM compliant.
Regards,
Simon
---eventtypes.conf --
...
[pfsense_unbound]
search = sourcetype=pfsense:unbound
-- props.conf --
...
[pfsense:unbound]
EXTRACT-queries = info: resolving (?P\S{2,})\s(?P<query_type>\S+)
EXTRACT-response = info: response for (?P\S+)\s(?P<record_type>\S+)
EXTRACT-reply = info: reply from\s(\S+)\s(?P(\d|.)+)#(?P<src_port>(\d+))
-- tags.conf --
...
[eventtype=pfsense_unbound]
network = enabled
resolution = enabled
dns = enabled

@simongillet i've made some adjustments to your code and created a Pull request for this - confirmed working on PFsense 2.3.4

Thanks.
By the way, I don't know if DHCP stopped for you as well but after upgrade my DHCP logs were not correctly processed anymore.
I made this dirty line to get it working again.
[pfsense:dhcpd]
EXTRACT-ipv4_dhcp = (?<vendor_action>DHCPACK|DHCPREQUEST|DHCPRELEASE|DHCPOFFER|DHCPDISCOVER|DHCPACK|DHCPINFORM) ((?:on|for|of) (?<dest_ip>\S+) ((\S+) )?)?(((?:from|to) (?<src_mac>\S+) ((\S+) )?))?via (?<src_interface>\S+)

mine seems OK

Thanks for the updates. Creating a new release, let me know if you find any bugs.


🧹 Clean-up the old dormant user process

User Need
As a Ops Eng Team
I want to clean up code we no longer use
so that we simplify what we have to support and reduce work for the team.
Value
Less work for the team.
Simplify our portfolio.
Functional Requirements (What):

Remove all code and infrastructure relating to the old dormant users process

Non-Functional Requirements (How):

[x] Remove old code and GH actions workflows relating to old process
[x] Remove old S3 contents from MoJDSD

Acceptance Criteria:

[x] Old dormant users is gone

🔥🔥🔥🔥🔥     🔥🔥🔥🔥🔥     🔥🔥🔥🔥       🔥🔥🔥🔥🔥
🔥                           🔥            🔥            🔥   🔥
🔥🔥🔥                    🔥            🔥🔥🔥🔥        🔥🔥🔥
🔥                           🔥            🔥           🔥     🔥
🔥                    🔥🔥🔥🔥🔥    🔥            🔥    🔥🔥🔥🔥🔥


Undoing several times in TextEdit can lead to text being scrambled

Godot version:
3.2 and master.
Issue description:
Found this a couple of times while undoing in the script editor. It happens randomly, and this error generally pops up:
scene/gui/text_edit.cpp:3981 - Index p_to_column = 57 is out of bounds (text[p_to_line].length() + 1 = 57).

CC @Paulb23

Script editor generally does weird things when undoing autocompletion, especially with braces.
This one looks like duplicate of #34253 (same error)


chore: bdd-spring-1574287899 to 0.0.1

chore: Promote bdd-spring-1574287899 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


publish<EMAIL_ADDRESS>

Requested by: @bitsandfoxes
Merge target: (default)
Quick links:

View changes
View check runs

Assign the accepted label to this issue to approve the release.
Leave the #retract comment under this issue to retract the release (original issuer only).
Targets

[x] symbol-collector
[ ] upm
[ ] github
[ ] registry

Targets marked with a checkbox have already been executed.  Administrators can manually tick a checkbox to force craft to skip it.

[info] =================================
[info] === Publishing to target: upm ===
[info] =================================
[info] [[target/upm]] Fetching artifact...
[debug] [[target/upm]] Getting artifact list for revision "dc8f0d5093c7ba13b9c6191f5411801d9cf99963", filtering options: ***includeNames: undefined, excludeNames:undefined***
[debug] [[artifact-provider/github]] Fetching artifact list for revision `dc8f0d5093c7ba13b9c6191f5411801d9cf99963`.
[debug] [[artifact-provider/github]] Found list in cache.
[debug] [[artifact-provider/github]] Found 9 artifacts.
[info] [[target/upm]] Found artifact: "package-release.zip", downloading...
[debug] [[artifact-provider/github]] Downloading `package-release.zip` to `/tmp/craft-OTLZWh`
[debug] [[artifact-provider/github]] rename /tmp/craft-MqmZrh/package-release.zip to /tmp/craft-OTLZWh/package-release.zip
[debug] GET /user - 200 in 87ms
[debug] [[target/upm]] Target release repository: https://github.com/getsentry/unity/
[info] [[target/upm]] Cloning https://github.com/getsentry/unity/ to /tmp/_craft-release-upm-IOtMYh...
[info] [[target/upm]] Clearing the repository.
[info] [[target/upm]] Extracting "package-release.zip".
[info] [[target/upm]] Adding files to repository.
Error:  Done
Pushing to https://github.com/getsentry/unity/
POST git-receive-pack (chunked)
error: RPC failed; curl 56 GnuTLS recv error (-54): Error in the pull function.
send-pack: unexpected disconnect while reading sideband packet
fatal: the remote end hung up unexpectedly

  Pushing to https://github.com/getsentry/unity/
  POST git-receive-pack (chunked)
  error: RPC failed; curl 56 GnuTLS recv error (-54): Error in the pull function.
  send-pack: unexpected disconnect while reading sideband packet
  fatal: the remote end hung up unexpectedly

  at Object.action (/usr/local/bin/craft:127:6006)
  at OW.exec (/usr/local/bin/craft:127:6426)
  at /usr/local/bin/craft:127:11842
  at new Promise (<anonymous>)
  at fA.handleTaskData (/usr/local/bin/craft:127:11731)
  at fA.<anonymous> (/usr/local/bin/craft:127:11357)
  at Generator.next (<anonymous>)
  at a (/usr/local/bin/craft:124:1[363](https://github.com/getsentry/publish/actions/runs/5360301580/jobs/9724996724#step:10:364)13)
  at runMicrotasks (<anonymous>)
  at processTicksAndRejections (internal/process/task_queues.js:95:5)

Files were pushed but the GH release wasn't done: https://github.com/getsentry/unity/commit/f3892db016ab2c663ed921ad5255af8eeeaea52e


Updates to AllJoyn assets - sync to latest.

Updates to AllJoyn assets: latest versions of ZWaveAdapter, MockAdapter, and Templates.
Removing unused documentation which is no longer up to date

Hi @zhuridartem, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 10:12:29 on 2023.08.09
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 5, errors out: 0
Original problem ID: 35192
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=35192

Problem has been resolved in 12m 0s at 10:24:29 on 2023.08.09
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 35192


[BUG]  The collect function in FragmentQueue fails to sort frames correctly.

Describe the bug
The sort_by function in the collect method of FragmentQueue is using id for comparison during sorting (it should actually be index), causing the Frame to be sorted incorrectly. As a result, in some instances, the output Vec<u8> may be incorrect.
To Reproduce
Steps to reproduce the behavior:
This issue may probabilistically occur when receiving a Fragment because the sorting is not done correctly, primarily due to the improper use of id instead of index in the sorting process.
Expected behavior
Correcting the usage of the sort_by function, here is the suggested modified code:
frames.sort_by(|a, b| {
                    a.fragment_meta
                        .as_ref()
                        .unwrap()
                        .index
                        .cmp(&b.fragment_meta.as_ref().unwrap().index)
                });

Server versions (please complete the following information):

commit: [2af4c5a]
Version: 0.3.1

Additional context
Here is the debug output of my code, and the buffer concatenation is not correct:
code:
for frame in frames.iter() {
                    let fm = frame.fragment_meta.clone().unwrap();
                    println!("index: {}, len: {}", fm.index, frame.body.len());
                    buffer.extend_from_slice(&frame.body);
                }

output:
index: 0, len: 1463
index: 1, len: 1463
index: 5, len: 637
index: 2, len: 1463
index: 3, len: 1463
index: 4, len: 1463

Do you have a input buffer source or no? If not, judging the frame length and indices im assuming this is a MC buffer source.

This issue should be fixed! Please let me know if you're still having this issue after updating to 0.3.2!


Access to global variable $wp_filter

As per this article: https://make.wordpress.org/core/2016/09/08/wp_hook-next-generation-actions-and-filters/ , the next WP version (4.7) will introduce changes to the $wp_filter global variable.
W3TC accesses this variable in 2 places in inc/functions/plugin.php:
$wp_filter[$hook] = array();

These seem to be (by default) only used in Genesis.php, but could be used by other developers.
I have never made use of this feature in W3TC, so I am not quite familiar with it, but we could either replace the above line with something like:
if(is_object( $wp_filter[$hook]))
 $wp_filter[$hook]->callbacks = array();
else
$wp_filter[$hook] = array();

or stick to WP standard functions and use remove_all_filters
I would prefer sticking to standard WP functions, even if there's a small execution overhead in doing so, but at least there's less chance of breaking things.

i vote for standard remove_all_filters

Bonus points for using remove_all_filters().  Fix looks correct.


Azure AKS cluster can't be created but no clear messages why

What kind of request is this (question/bug/enhancement/feature request):
Possible bug on Azure
Steps to reproduce (least amount of steps as possible):

Ubuntu VM on Azure
Docker run rancher latest following the docs quick start examples
Create Azure service principal with all required permissions (in my case I tried full access role, "Contributor", while debugging, it didn't help)
Try to add AKS cluster in Rancher
All steps pass, it seems good, but then UI error in red appears

Result:
AKS cluster is not being created despite proper credentials provided in Rancher UI

Other details that may be helpful:
logs from rancher docker container:
2020-01-13 07:23:09.210460 I | mvcc: store.index: compact 227783
2020-01-13 07:23:09.212526 I | mvcc: finished scheduled compaction at 227783 (took 1.190803ms)
2020/01/13 07:23:54 [INFO] kontainerdriver azurekubernetesservice listening on address <IP_ADDRESS>:34223
2020/01/13 07:23:54 [INFO] kontainerdriver azurekubernetesservice stopped
2020/01/13 07:23:54 [INFO] Provisioning cluster [c-6nm8r]
2020/01/13 07:23:54 [INFO] Creating cluster [c-6nm8r]
2020/01/13 07:23:59 [INFO] kontainerdriver azurekubernetesservice listening on address <IP_ADDRESS>:33175
2020/01/13 07:23:59 [ERROR] Cluster c-6nm8r previously failed to create
2020/01/13 07:23:59 [INFO] kontainerdriver azurekubernetesservice stopped
2020/01/13 07:23:59 [ERROR] ClusterController c-6nm8r [cluster-provisioner-controller] failed with : error getting Resource Group 'evisort-development': resources.GroupsClient#CheckExistence: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: error response cannot be parsed: "" error: EOF
2020/01/13 07:24:00 http: TLS handshake error from <IP_ADDRESS>:60990: EOF
2020/01/13 07:24:04 [INFO] kontainerdriver azurekubernetesservice listening on address <IP_ADDRESS>:33299
2020/01/13 07:24:04 [INFO] kontainerdriver azurekubernetesservice stopped
2020/01/13 07:24:09 [INFO] kontainerdriver azurekubernetesservice listening on address <IP_ADDRESS>:43601
2020/01/13 07:24:09 [INFO] kontainerdriver azurekubernetesservice stopped
root@rancher-ubuntu:~#

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
v2.3.3
Installation option (single install/HA):
single docker container on ubuntu

This error has been seen in the past, regarding not enough permissions. I just the steps mentioned on https://rancher.com/docs/rancher/v2.x/en/cluster-provisioning/hosted-kubernetes-clusters/aks/ (using the Azure CLI) and I was able to provision successfully. Please provide more info on how the credentials were created (and the commands used when using the CLI). If using the Portal, permissions need to be granted explicitly after configuring to apply.

@superseb thanks, I was able to pass that step after recreating the credentials again, probably missed something. But now it is stuck on a step of creating a cluster - but nothing gets created in Azure actually:

It just hangs like that ... maybe I have not enough permissions in the node template credentials?
`
2020/01/13 09:38:12 [INFO] [node-controller-docker-machine] Creating client certificate: /management-state/node/nodes/application2/certs/cert.pem
2020/01/13 09:38:13 [INFO] [node-controller-docker-machine] Running pre-create checks...
2020/01/13 09:38:13 [INFO] [node-controller-docker-machine] Running pre-create checks...
2020/01/13 09:38:15 [INFO] [node-controller-docker-machine] The default lines below are for a sh/bash shell, you can specify the shell you're using, with the --shell flag.
2020/01/13 09:38:15 [INFO] [node-controller-docker-machine]
2020/01/13 09:38:15 [INFO] Generating and uploading node config application3
2020/01/13 09:38:15 [INFO] [node-controller-docker-machine] The default lines below are for a sh/bash shell, you can specify the shell you're using, with the --shell flag.
2020/01/13 09:38:15 [INFO] [node-controller-docker-machine]
2020/01/13 09:38:15 [INFO] Generating and uploading node config application2
2020/01/13 09:38:16 [ERROR] NodeController c-scwb4/m-rxfkq [node-controller] failed with : Error with pre-create check: "autorest#WithErrorUnlessStatusCode: POST https://login.microsoftonline.com/1e9275f7-b4f8-4724-9687-8f1e037e2d6a/oauth2/token?api-version=1.0 failed with 401 Unauthorized: StatusCode=401"
2020/01/13 09:38:16 [INFO] Creating jail for c-scwb4
2020/01/13 09:38:16 [INFO] Generating and uploading node config
2020/01/13 09:38:16 [ERROR] NodeController c-scwb4/m-cf4w7 [node-controller] failed with : Error with pre-create check: "autorest#WithErrorUnlessStatusCode: POST https://login.microsoftonline.com/1e9275f7-b4f8-4724-9687-8f1e037e2d6a/oauth2/token?api-version=1.0 failed with 401 Unauthorized: StatusCode=401"
2020/01/13 09:38:16 [INFO] Creating jail for c-scwb4
2020/01/13 09:38:16 [INFO] Generating and uploading node config
2020/01/13 09:38:17 [ERROR] NodeController c-scwb4/m-lmlww [node-controller] failed with : Error with pre-create check: "autorest#WithErrorUnlessStatusCode: POST https://login.microsoftonline.com/1e9275f7-b4f8-4724-9687-8f1e037e2d6a/oauth2/token?api-version=1.0 failed with 401 Unauthorized: StatusCode=401"
2020/01/13 09:38:26 [ERROR] NodeController c-scwb4/m-sqnhm [node-controller] failed with : Error with pre-create check: "autorest#WithErrorUnlessStatusCode: POST https://login.microsoftonline.com/1e9275f7-b4f8-4724-9687-8f1e037e2d6a/oauth2/token?api-version=1.0 failed with 401 Unauthorized: StatusCode=401"
2020/01/13 09:38:30 [ERROR] NodeController c-scwb4/m-s7n5t [node-controller] failed with : Error with pre-create check: "autorest#WithErrorUnlessStatusCode: POST https://login.microsoftonline.com/1e9275f7-b4f8-4724-9687-8f1e037e2d6a/oauth2/token?api-version=1.0 failed with 401 Unauthorized: StatusCode=401"
2020/01/13 09:38:30 [INFO] Creating jail for c-scwb4
2020/01/13 09:38:30 [INFO] Generating and uploading node config
2020/01/13 09:38:30 [ERROR] NodeController c-scwb4/m-lsm64 [node-controller] failed with : Error with pre-create check: "autorest#WithErrorUnlessStatusCode: POST https://login.microsoftonline.com/1e9275f7-b4f8-4724-9687-8f1e037e2d6a/oauth2/token?api-version=1.0 failed with 401 Unauthorized: StatusCode=401"
2020/01/13 09:38:30 [INFO] Creating jail for c-scwb4
2020/01/13 09:38:30 [INFO] Generating and uploading node config
`
btw I have a feature suggestion: pre-defined node templates :) because it's such a hassle to fill these details... and most people would probably just select a few params like "minimum nodes X, maximum Y, machine size: Z" and that's it.

This needs different permissions, as you are not creating AKS now but creating a cluster with Azure nodes. But based on the error, it doesn't allow you to use these credentials at all, as it just returns a 401. What fields did you use? The same error was seen in https://github.com/rancher/rancher/issues/22248 when some fields were not filled in.


Сan i use carret , seekNext,  seekPrevious method in onKeyDown event?

It is necessary to specify the behavior of the following keys:
DELETE or Backspace - delete left or right symbol
HOME or END - move to very left or very right through HH or MM
UP or DOWN - increase or decrease value
LEFT or RIGHT - move left or right through HH and MM

@setdream ,
No you do not have access to it.
Is the above functionality not already present? (except the increase/decrease)


[Crash] NullPointerException: Ticking block entity

forge{<IP_ADDRESS>9}
xnet{1.3.2}
Just got this crash for the first time and now it continues to happen over and over again. This is on a Sponge server but because it's an NPE I was hoping it wasn't sponge related.
https://hastebin.com/itemurepay.php
https://hastebin.com/yucesuruyi.pl
https://hastebin.com/ugokeluhob.pl

I will check it out but I recommend filing a ticket with sponge too

Removing the effected controller stopped the crash. If details on its connections would be helpful, I should be able to better details.


Test Syntax Error in Swift 4

Somewhere along the line, NSRegularExpressonOptions became NSRegularExpression.Options, which is a struct instead of a class. This means that a few of VerbalExpressionss methods are mutating now that .options has value semantics instead of reference semantics. This, in turn, causes a syntax error in the testSearchOneLine() test (on line 197) because it declares tester as a let, but the searchOneLine() method is one of the newly-mutating methods.
I see three ways around this:

Make tester a var instead of a let, and just deal with having mutating functions.
Make VerbalExpressions a class instead of a struct.
Make .options a wrapper class for the "real" options.

(Personally, I'm torn between 2 & 3)
Anyway, I can submit a PR with everything updated to Swift 3/4 syntax (it compiles & tests under both language settings). Just let me know how you want this fixed.

Thanks for bringing this to our attention!
I fixed this in master.
Actually none of the workaround you proposed were necessary. The error was caused by bug in the removeModifier function.
By mistake, the mutation function options.subtract() was called instead of the non-mutating version options.subtracting(). The whole VerbalExpressions struct is immutable, functions only return new instances instead of mutating the struct value itself.


Limtation for only one CLASS ?

HI! Is it possible to use only one class? For example I have "normal" situations, and I want to detect only one type of event (Fall detection).
Best regards

I think what you mean is two classes: "normal" and "fall".
Two classes is possible.


[BUG] Security Integ tests are failing on 2.x due to setup issues

What is the bug?
Security Integ tests are failing on 2.x due to setup issues
How can one reproduce the bug?

Check the workflow errors: https://github.com/opensearch-project/cross-cluster-replication/actions/runs/5087351696/jobs/9142646007?pr=657

org.opensearch.replication.integ.rest.SecurityCustomRolesIT > classMethod FAILED
Suite: Test class org.opensearch.replication.integ.rest.SecurityCustomRolesIT
    org.opensearch.client.ResponseException: method [PUT], host [https://[::1]:43247], URI [_plugins/_security/api/internalusers/testUser1], status line [HTTP/1.1 400 Bad Request]
  2> org.opensearch.client.ResponseException: method [PUT], host [https://[::1]:43247], URI [_plugins/_security/api/internalusers/testUser1], status line [HTTP/1.1 400 Bad Request]
    {"status":"error","reason":"Weak password"}
    {"status":"error","reason":"Weak password"}
        at __randomizedtesting.SeedInfo.seed([272BE71E3127C24D]:0)
        at __randomizedtesting.SeedInfo.seed([272BE71E3127C24D]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:375)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:375)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:345)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)

Hi @saikaranam-amazon, I see that these integ test failure are a blocking SQL build for 2.8 release. Is this still to be worked in 2.9? Also,  2.8 infra autocuts  https://github.com/opensearch-project/cross-cluster-replication/issues/825 https://github.com/opensearch-project/cross-cluster-replication/issues/824 https://github.com/opensearch-project/cross-cluster-replication/issues/843 seem to be related to this.


kpt UI for non-GKE clusters

Hi All,
It will be very helpful if you can provide the web UI for non GKE cluster as well. Since most of the peoples runs workload using on-prem cluster or any public cloud cluster but not all using the GKE  cluster.
We are using on-prem cluster and we really want to access the kpt web UI.
So if you guys can build the web ui for non GKE cluster , it will be helpful.
Thank you in advance
Regards,
Vishal Varvate

Hi Vishal, thanks for raising the issue here. For context for others, Vishal was following the Nephio PoC scenario and ran into this issue.
Vishal, I believe the only dependency on GKE is because of the Google OAuth integration. The UI then uses that identity to login to the cluster. In your onprem environment, how do you authenticate to the cluster?
cc @ChristopherFry

(Assume the title here is supposed to read "non-GKE clusters")

HI John,
We use access key tokens  for authenticating clusters.

We use access key tokens for authenticating clusters.

I'm not entirely sure what that means at the kubernetes level.  Is kubernetes configured with OIDC, for example?  Are you using something like dex.
As I understand it (and @ChristopherFry can correct me here), the web UI needs to authenticate to the kubernetes cluster running kpt/porch.  The UI itself is mostly/purely client-side, so we just need to (1) trigger authentication so we get credentials and (2) pass-through the credentials to the cluster.


Persist sort

Would be nice if hitting save would actually persist the sort I have on the table.

Hi @gampleman, sorry for the late reply, I saw your issue but was caught by some fixes required on the minimap.
When you say persisting the sort on save, do you mean saving the file on disk with the current sort applied or just storing the current sort so that tablr can reuses the same setting when opening the file again?
I ask this because I thought deeply about that when implementing the sort feature and was somehow reticent to make the sort modifies the file on disk without the user intending to do so. I was thinking of adding a command to apply the sort on a table so that the rows get saved in the current order.

I mean saving the file. I feel that changing the sort should make the file dirty and should have and undo support. So the actual saving should happen when the user hits the save command.

Hi, I'll have some time to implement something for this, what do ou think of having a button next to the column edit action to apply the current sort on the table? This button would only be available if a sort is applied.

Sounds ok to me.


COVID-19 changes across Apply and Manage

Email sent by UCAS
Changes to Apply for teacher training
Changes to Manage teacher training applications

Looks brill thanks @paulrobertlloyd - these changes aren't super urgent:

for consistency with other areas of gov.uk, use coronavirus in lower case (remove 'disease') followed by (COVID-19) on first mention - see https://www.gov.uk/coronavirus for how it has been used on gov.uk
write numbers in numerals except 1 -  'UCAS and the department agreed to extend all decline by default (DBD) and reject by default (RBD) decision dates for a period of four weeks'
use lower case at the beginning of bullets - full stops not needed
'Pausing DBD and RBD deadlines in response to Coronavirus (COVID-19)' - would make more plain english i.e. 'Giving teacher training providers longer to make decisions on applications because of coronavirus (COVID-19)'
'Adding a banner informing users of these changes with a link to the guidance' - specify where


[NTR] tumor-associated endothelial cell

Hello Cell Ontology Team,
I had a discussion with Alex about the term-request 'tumor-associated endothelial cell' into Disease Ontology, please see here:
https://github.com/DiseaseOntology/HumanDiseaseOntology/issues/1016
Preferred term label: tumor-associated endothelial cell
Synonyms:  tumor endothelial cell  /    TEC
WP definition:
https://en.wikipedia.org/wiki/Tumor-associated_endothelial_cell
Definition (derived from PMID:32588325, PMID:29695087)
draft definition:  Cells that line tumor blood vessels and are part of the tumor microenvironment (TME) that plays a central role in cancer development and progression. While the tumor blood vessels show clear morphological and functional abnormalities,  the cellular origin of vessel network in tumors is less known.
Parent cell type term: CL:0001061 abnormal cell
Cell part_of UBERON:0001986 endothelium (or part_of the anatomical cluster UBERON:0002049 vasculature)
nano-attribution (ORCID): https://orcid.org/0000-0003-3308-6245
Many thanks in advance for your help
Anne
Anne Niknejad
Senior biocurator
https://bgee.org/
SIB | Swiss Institute of Bioinformatics
Unil, Department of Ecology and Evolution - Quartier Sorge, bâtiment Biophore - 1015 Lausanne
t: +41 21 692 42 21 - f: +41 21 692 41 65
<EMAIL_ADDRESS>- https://www.sib.swiss

For quick reference, @addiehl 's favourable comment to having 'tumor-associated endothelial cell' in CL is here

Hello, @ANiknejad, thank you for the new term request and accompanying information.
I propose the following definition:
An endothelial cell that lines a tumor blood vessel and is part of the tumor microenvironment that plays a central role in cancer development and progression.
and setting the following as a comment:
While tumor blood vessels show clear morphological and functional abnormalities, the cellular origin of a vessel network in tumors is less known.
Does the above seem reasonable to you?
Also, I am unable to access the full text for PMID:32588325. Could you confirm that paper supports the comment statement above?

Hi, @ANiknejad, checking in to see if you had thoughts on the comment above.

@dosumis - I'm uncomfortable about this because:
1.  Potentially out of scope
2. Classification - right now under abnormal cell.   But potentially wrong to classify pathological/disease associated cells under normal CL branches.
3. Need to automated classification but patterns we should use are unclear.

From slack:
@matentzn  Basic approach should be as usual - new involved parties should not be rejected outright, but the “tumor-associated” has a very bad smell attached; basically anything that could copy the whole CL hierarchy with “X cell type” should be avoided. On the other side, you can show them how to use post composition to say “endothelial cell” and “associated with pathological entity” some “tumor”.  If there is just 20 such cell types, you can also precompose them
@cmungall:
agreed, massive ragged lattice red flags here. But it is worth looking at the NCIT abnormal cell hierarchy here

@dosumis, @ANiknejad, given the comments above, would closing this ticket for now be appropriate?

Closing this ticket due to comments above and no recent follow-up comments.


2.x Write Server Initial Sync

When a write server boots up, it should not be marked as UP until after it has synced up with all of it's peers. A corollary of this is that the replication protocol need to support metadata exchanges to indicate to receiver servers that it has received all the information the sender has for the initial sync.

Proposed implementation
Eureka server bootstrapping may happen from different sources, depending on Eureka cluster lifecycle:

for initial startup, there is no prior data available, so servers should start with empty registries
for existing cluster, when a new write server is brought up, it should ideally take full registry content from one of its peers
when full cluster is restarted, or there is other reason why a new server cannot bootstrap itself from a peer, it should load last known registry content from an external source/backup storage. Multiple backup storages may be implemented here.

In the original design, we envisaged that peer bootstrapping would be implemented within replication protocol itself:

a new node chooses one of its peers, and initiates full registry bootstrap
the chosen peer sends all its registry content, including local and any other registrations
one bootstrapping is done, a regular replication mode is enabled

This implementation has a few drawbacks:

complicates replication protocol, with additional mode of operation
has complex failover scenario - if bootstrapping from first node fails, we have to restart it from another peer, with which we may have already established replication channel.
it does not cover bootstrapping from external sources, and how the two would interact

In general, we need an API and some pluggability mechanism where multiple bootstrap sources may be provided. They should be also prioritized, so for example peer bootstrap is always first choice. The proposed API consists of two interfaces:
public class RegistryBootstrapCoordinator {

    @Inject
    public RegistryBootstrapCoordinator(RegistryBootstrapService primaryRegistryBootstrapService,
                                        Set<RegistryBootstrapService> additionalRegistryBootstrapServices,
                                        SourcedEurekaRegistry registry) {
        // Setup bootstrap sources
    }

    @PostConstruct
    public void bootstrap() {
        // Initiate registry upload from the configured bootstrap source
    }
}

public interface RegistryBootstrapService {

     Observable<Void> loadIntoRegistry(SourcedEurekaRegistry<InstanceInfo> registry, Source source);
}

Each registry entry provided by bootstrap source is associated with Source.BOOTSTRAP, and is put immediately on eviction queue. If bootstrapping fails, the server is enabled anyway, as eventually the up to date state will be reconstructed from the registering clients. The bootstrap process is guarded by a timeout, which if crossed stops it and enables the normal operation mode of the server.
Peer bootstrapping instead of replication protocol, uses regular interest subscription with full registry fetch, with failover mechanism switching to another available service.
Server availability status
Within Eureka write cluster we cannot depend on instance registered status, when deciding if a server is up or down. Instead this information has to be provided somehow when connecting to the server. A few options may be envisaged here:

Embed server availability in a framing protocol itself, discarding all requests until server is up. A remote endpoint would receive a special frame asking it to disconnect.
Implement application level hello message exchange, and embedded server availability status within it.
Implement negative acknowledgment replies (NACK), carrying over detailed error status similarly to HTTP protocol. If NACK.SERVER_UNAVAILABLE reply is received, a connection to the given server should be dropped.

What will be the downside of only considering option 3:

When full cluster is restarted, or there is other reason why a new server cannot bootstrap itself from a peer, it should load last known registry content from an external source/backup storage. Multiple backup storages may be implemented here.

as a "bootstrap" scenario and any other scenario as a usual replication scenario? In other words, what is the usecase of getting the entire registry contents from a source (peer or backup) when other peers are available in the cluster?
AFAIU, the entire registry would be required to assert if it is safe to serve registry contents to clients or not. That assertion will be based on the number of instances in a peer's registry. If this is the only reason for the bootstrap, I propose the following:

Modify replication protocol to also send;

total instances in the peer registry

Number of peers

Modify replication change notification stream to include a marker when the local registry (owned by that node) is streamed completely.

For a node starting up, it should do the following:

Attempt to connect to all peers.
Get the number of peers and registry information from all peers.
If all other peers are reachable then connect to all of them and wait till all of them have streamed all their local registry content.
If any of the peer is unreachable or not ready to serve traffic, connect to the backup store to fetch the last known registry information.

A node would start serving registry information to clients, if it has received the registry contents. We may also choose to have some heuristics around how much of the registry information we should wait for in case nodes are not able to stream all their data before disconnect.
The positive of this approach is that you would not get into the hierarchy of bootstrap sources and would also eliminate the need of full registry fetch from a peer in spite of all peers being available.

Instead this information has to be provided somehow when connecting to the server. A few options may be envisaged here

I did not quiet understand the difference between the options here. All the options look like sending a message "Not available for registry fetch" and closing the connection. Since, the protocol is framed, so you would have to send the message as a different frame, isn't?

Some key points from our offline discussion:

bootstrapping from replication channel as a first step is a good thing, but slightly complex to implement. We will not do this now, but possibly some time in the future
doing full registry fetch from a peer or backup cluster should be fast enough, to not impact server bootstrapping time too much
we will have single external bootstrap source, so the hierarchy proposed above is not needed

What we will provide now for write server bootstrap is a bootstrapping mechanism from either peer write cluster node or external backup cluster (configuration choice).

Implemented by PR #500


No schema is listed after adding schemas to artifacts folder

Describe the Bug with repro steps
Expected Behavior:
Clicking on "Select a Source/destination schema" should show list of available schemas to be picked.
Actual Behavior:
No schema is listed to be picked.
Repo steps:
Click on "Create new data map" - opens up map designer
Added 8 schemas into Artifacts\Schemas folder
Try to select source/destination schema to start mapping.
There is no schema listed.
Screenshots or Videos
No response
Version
2.15.15
Additional context
More info available in internal OneNote
AB#25473654

Unable to reproduce. This was probably fixed.


Estimated reading time && fix #41

Add "Estimated reading time" to .other-wrapper in post layout.
Didn't touch CSS though.

Need to figure out a way to exclude <pre> tag though

Great Job! but I still have a question.
the reading time seems too large. for example, I don't think TeXt - Mermaid really need  14 mins to read.

That’s what I mean to find a way for excluding tags like <pre>

No, I mean this:
{% assign count = post.content | strip_html | strip_newlines | size %}
{% if count < 400 %}
  1 min to read
  {% else %}
  {{ count | divided_by:200 }} mins to read
{% endif %}

the count is the  number of characters in the content. and then you divided count by 200, witch means the reading speed is 200 characters per minute.

I tested mine is 279 😂
My blog has some posts that take 50+ mins to read, due to pre tags.

It 's number of words, but count is the number of characters. eg:

I believe I can fly.
5 words, 20 characters

查了一下午的确没有很好的解决办法，尤其是多语言混合，jekyll 比 WordPress 还心累啊！
可能可以用 https://github.com/jpatokal/script_detector 或者自己造个轮子。。。
相关：
http://taoalpha.github.io/blog/2015/05/21/tech-jekyll-count-of-chinese-characters/
https://github.com/jekyll/jekyll/issues/1921
https://github.com/Shopify/liquid/issues/984

在我看来，统计的结果可以不准确。但也应该在偏小的合理范围内，这样才能吸引访问者点击链接去看文章。（太长不看我是深有感触的）


fix: pacing column values don't display (#2432)

GitHub Issue (if applicable): #2432
Explanation of Bugfix/Feature/Modification:
The pacing columns feature was failing as the getEntityType method no longer existed on the category object. I have updated it to getDisplayEntityType which seems to return equivalent values.

Oops - I missed the other pull request (#2430) fixing the same problem as there are duplicate bug reports. (#2428, #2432)
If we want to keep the check, the getDisplayEntityType method seems to return the same value as getEntityType, otherwise I can close this request.


Not functional with new V5 Websocket built into OBS 28+

Connects then disconnects over and over. Apparently alot has changed with V5 of the websocket. There is a Websocket 4.X Compat plugin to still be able to use older V4 tools while running OBS V28+.

Hello. Just wondering if anyone has had a look at the effort involved in upgrading to the v5 Websocket? I'm running on 4.9 currently, but conscious this may not be supported forever in OBS.

Hello. Just wondering if anyone has had a look at the effort involved in upgrading to the v5 Websocket? I'm running on 4.9 currently, but conscious this may not be supported forever in OBS.

I've had other priorities seeing as this isn't urgent with the compatibility plugin being available, but I'm aiming to do some work on it this month as things are a bit quieter.

Of course, makes sense. Let me know if you'd like me to help with any testing.


Feature: disable/enable LoginItems

We currently still need to support to enable/disable login items in Ventura.
This would work by:

Adding it in /var/db/com.apple.xpc.launchd/disabled.*.plist with <key>NAME</key>\n<true/> to disable.
Adding it in /var/db/com.apple.xpc.launchd/disabled.*.plist with <key>NAME</key>\n<false/> to disable.

I think this is the issue I'm running into when trying to disable a startup item:
$ maclaunch disable com.wiheads.paste-setapp-LaunchAtLoginHelper
/opt/homebrew/bin/maclaunch: line 608: disableLoginItems: command not found

Just wanted to add it for context.  Thanks!

I noticed that disableLoginItems was added in the following commit, but there hasn't been an accompanying function for it. I searched google for the command/function and nothing shows up.
https://github.com/hazcod/maclaunch/commit/eb91b579651f419652430db159fabcbe9476ab19
The function left unimplemented so that it would throw an error until this is implemented thus fixing it?

Yes, indeed. This issue is specifically about implementing that function.


Support custom OneToOneFields with additional parameters.

Problem Statement
Coercing OneToOneFields to be ForeignKeys on historical models causes issues when the OneToOneField is a custom subclass that includes additional arguments that do not exist on ForeignKey.__init__.
Describe the solution you'd like
In my particular case, ignoring the value would work well. My proposed solution is to supply a dictionary to HistoricalRecords that maps fields to the list of kwargs that should be excluded.
Describe alternatives you've considered
I did not consider alternatives.
Additional context
Currently when trying to use a custom OneToOneField, a TypeError is raised:
  File "python3.9/site-packages/simple_history/models.py", line 159, in finalize
    history_model = self.create_history_model(sender, inherited)
  File "python3.9/site-packages/simple_history/models.py", line 221, in create_history_model
    fields = self.copy_fields(model)
  File "python3.9/site-packages/simple_history/models.py", line 302, in copy_fields
    field = FieldType(*args, **field_args)
  File "python3.9/site-packages/django/db/models/fields/related.py", line 825, in __init__
    super().__init__(
  File "python3.9/site-packages/django/db/models/fields/related.py", line 474, in __init__
    super().__init__(rel=rel, **kwargs)
TypeError: __init__() got an unexpected keyword argument 'custom_field'

This is caused by #167 and somewhat related to #462.

c


testutil: connect/disconnect make 1 result on event channel

There's an event result write to the events channel in both the
EventNotify() and in the ConnectNotify()/DisconnectNotify() code paths,
but there will only be one read.  These writers will block and leak
goroutines.
Signed-off-by: Tim Pepper<EMAIL_ADDRESS>

Coverage decreased (-0.02%) to 65.64% when pulling f5d27562151b136bc4e4840f1abb70f00e62b7b0 on tpepper:master into 098caffdeace8125093de108dacc18e6d290ae59 on 01org:master.


Update meshery-ui doc contribution flow

Notes for Reviewers
This PR fixes #7339
Here's how it looks:

Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit bfe4e9fb54a9996a831ca07ad6dda523199ccad6 at: https://640f28f1da84f4022fb4a8de--meshery-docs-preview.netlify.app

🚀 Preview for commit 2cae75cfdf778feb2d3fd6fc0191e3df759ebd32 at: https://640fe1e2c9f3fe1ec9b914ce--meshery-docs-preview.netlify.app

Good stuff, @senali-d 👏

yay, @senali-d! 🎈


Does it work? Dont you want to add to repo?

I'm not finished... haven't got the time to work on that project right now.
Will deploy 0.1 probably between Christmas and New Year. I'll let you now

Thank you.
8 дек. 2017 г. 11:39 пользователь "lob"<EMAIL_ADDRESS>написал:

I'm not finished... haven't got the time to work on that project right now.
Will deploy 0.1 probably between Christmas and New Year. I'll let you now
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/oberstel/iobroker.pjlink/issues/1#issuecomment-350231760,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEXqgI5uCIzCJsWYYwkVaV_vz20sqQYYks5s-RHggaJpZM4Q65vy
.

It's released now and I created a proper thread on ioBroker forum: http://forum.iobroker.net/viewtopic.php?f=20&t=10201

Perfect :)


Detach the existing views instead of removing them

in the onLayoutChildren for better performance.
When a view holder is retrieved from the detached state (scrap), it doesn't go
through the Adapter, thus it should be more optimized than re-creating fro the
Adapter.

@yaraki  could you take a look?


No records for Firebase Analytics: values.xml is note generated

Hi there! Many thanks for this plugin.
I wonder to know if I must use this plugin with cordova-plugin-google-services or other.
I set the google-services.json in the root path. When I add the plugin it copied into /platform/android... but when I check the records in Firebase Analytics (Android) there is no information (iOS works fine).
It seems that the plugin is not generating the /platforms/android/build/generated/res/google-services/debug/values.xml that should contained the keys for tracking.
I use this command: ionic cordova platform build android --prod
Is there any plugin or command line missing?
Thanks in advance
Federico

Hi @blakek! Perhaps you can iluminate me! Thanks in advance

@BluebambooSRL please test with version 1.0

closing as resolved, please reopen if this is still an issue with the latest version


How to add distributed load in UEL

Sorry to bother you, your project is great! I would like to ask, do you know how to implement distributed load in UEL? Many thanks.

Easy way to do that is by creating a set of elements in the input file and defining the load.
The next way is to define the load inside the UEL, in the force and stiffness matrix. This would be efficient to implement any load distribution (such as force or pressure as a function). But this will require examining the elements and particular nodes beforehand. It would be easier to examine the nodes in matlab or something similar then load those in to the UEL.

Thanks for your responses. I have created a set of elements and defined the load in the .inp file. And I updated the RHS matrix. But after these operations, the model no longer converges.......
I think my changes to the UEL file are wrong, but I don't know how to modify it correctly. If possible, could you give me an example of how to implement a distributed load in UEL (how to redefine the force and stiffness matrix)?  Thanks a million!

Thanks! Maybe I should promise you some rewards, like citing your articles?

but, how to visualize the odb file?
Best,
Libo Yan


unable to get few references

Sentence:
"Now keep in mind that Alexander's Force depending on what time we're looking at. It numbers between forty and fifty thousand troops a good number of them infantry  some Cavalry and most of the battles that will see him fight, especially the next two against the Persian forces"
resolved output: "Now keep in mind that Alexander's Force depending on what time we're looking at. It numbers between forty and fifty thousand troops a good number of them infantry some Cavalry and most of the battles that will see Alexander fight, especially the next two against the Persian forces"
I wanted that  "It numbers between" , here the "it" should get replaced by " Alexander's Force"
There is a reference between them as we can observe in the demo website, but I am unable to get it using the example.py in the repository.

one more example
for the sentence " Alexander 's really Angry that bestest his killed Darius . He's also likely angry that bestest is claiming that he is the Shan cha and so he kills Rebecca's in Fairly brutal form and there's different accounts of how the killing happened."
response by example.py
"resolved": "Alexander 's really Angry that bestest his killed Darius . his's also likely angry that bestest is claiming that his is the Shan cha and so his kills Rebecca's in Fairly brutal form and there's different accounts of how the killing happened."
In the case:
"He's also likely angry" , here 'he' should get mapped to Alexander but it is getting mapped to his

Thanks for the report - merging with Issue #215 !

Hi @samhardyhey ,
was just curious to know if the reference is getting created in demo website, then why ain't we getting same result by using example.py (for the above mentioned examples)

I would assume because the two results are being produced by different models?

Hi @svlandeg and all, the demo website is running a previous release of neuralcoref – I should clarify that on the webpage as there are have been a few questions in the past

Oh, maybe then I should try the previous version on my project

@julien-c can u tell me which version specficially the demo website is running on , so that I can try that out. Thanks


Creating our Kanban board

Link to Kanban board:
https://github.com/MarcoDiaz2000/catalog-of-my-things/projects/1
Our team is integrated by three people and assigned as follows:
@ab-noori will do the tasks of team member # 1
@MarcoDiaz2000 will do the tasks of team member # 2
@tamoorsaeed22 will do the tasks of team member # 3

Hi @ab-noori , @MarcoDiaz2000 and @tamoorsaeed22 ,
Status : APPROVED 🥳 🥳
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

All requirements are covered ✔
Tasks assigned fairly 👍
All members have been assigned tasks
Implemented all requirements 👏

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @shella12 👋,
Thank you so much 🙏  for reviewing and approving our project.
Your nice feedback is really appreciated 🙏.


feat(listviews): SIP-34 filters for charts, dashboards, datasets

SUMMARY

api endpoint /api/v1/database/schemas for fetching list of schemas.
adds SIP-34 filters to datasets list view
removes LIST_VIEWS_SIP34_FILTER_UI feature flag
enabled SIP-34 filters for datasts, charts, dashboards, listview
moves src/views/* -> src/views/CRUD/* (eg, src/views/datasetList/DatasetList.tsx -> src/views/CRUD/dataset/DatasetList.tsx ) -- idea being that src/views/CRUD namespace can share code, ie, data fetching logic, state hooks, edit modals, delete modals, etc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

unit tests pass
can filter on charts, dashboards, datasets list views

ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Changes UI: Behind ENABLE_REACT_CRUD_VIEWS flag
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #10335 into master will decrease coverage by 6.42%.
The diff coverage is 37.86%.

@@            Coverage Diff             @@
##           master   #10335      +/-   ##
==========================================
- Coverage   65.67%   59.24%   -6.43%
==========================================
  Files         601      405     -196
  Lines       32268    13247   -19021
  Branches     3275     3253      -22
==========================================
- Hits        21191     7848   -13343
+ Misses      10893     5215    -5678
  Partials      184      184

Flag
Coverage Δ

#javascript
59.24% <37.86%> (-0.36%)
:arrow_down:

#python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset-frontend/src/components/ListView/utils.ts
75.00% <ø> (-8.15%)
:arrow_down:

superset-frontend/src/featureFlags.ts
84.61% <ø> (-1.10%)
:arrow_down:

...uperset-frontend/src/views/CRUD/dataset/Button.tsx
100.00% <ø> (ø)

superset-frontend/src/welcome/App.tsx
0.00% <0.00%> (ø)

superset-frontend/src/views/CRUD/utils.tsx
25.00% <25.00%> (ø)

...perset-frontend/src/views/CRUD/chart/ChartList.tsx
57.03% <33.33%> (ø)

...et-frontend/src/views/CRUD/dataset/DatasetList.tsx
62.17% <39.34%> (ø)

...rontend/src/views/CRUD/dashboard/DashboardList.tsx
63.77% <60.00%> (ø)

...rset-frontend/src/components/ListView/ListView.tsx
98.14% <100.00%> (-0.16%)
:arrow_down:

superset-frontend/src/components/Modal.tsx
94.44% <100.00%> (ø)

... and 197 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eee678...b44cf7e. Read the comment docs.

can't wait to see it live!

This looks amazing, let's get it through! Looks like you're one cypress test away :)

Impacts #8976


Data Model/API - Patient Data - Address Fields/Nationality

check whether Nationality is correctly captured through API and stored (or if that's a Frontend issue - i.e. not passed) if mising in API and/or DB model please add
make 'houseNumber' optional so that we can include the house number within the street attribute - background: increase data entry speed and alolow complex adresses with Street + HouseNumber + Appartment/Block...
make 'stayHouseNumber' optional so that we can include the house number within the street attribute - background: same as above

PR ist offen

in dev


SFTTrainer can add  and  to the text?

bellow is my preudocode.
my data format is like data="[INST] <<SYS>>\nYou are a helpful, respectful and honest assistant.Help as much as you can.\n<</SYS>>\n\n{input} [/INST] {response}"
the question is that SFTTrainer can add <s>  to the start of data or </s> to the end of data by default?
if SFTTrainer does't add it, I need to add <s> and </s> to my data
`
tokenizer = LlamaTokenizer.from_pretrained("meta-llama/Llama-2-7b-chat-hf")
Set training parameters
training_arguments = TrainingArguments(
    output_dir=output_dir,
    num_train_epochs=num_epochs,
    per_device_train_batch_size=micro_batch_size,
    gradient_accumulation_steps=4,
    optim="paged_adamw_32bit",
    sharded_ddp=True,
    save_steps=200,
    logging_steps=200,
    learning_rate=learning_rate,
    weight_decay=0.001,
    save_strategy="steps",
    fp16=False,
    bf16=False,
    max_steps = -1,
    evaluation_strategy="steps" if val_set_size > 0 else "no",
    eval_steps=200 if val_set_size > 0 else None,
    max_grad_norm=0.3,
    warmup_ratio=0.03,
    ddp_timeout=3600,
    group_by_length=group_by_length,
    lr_scheduler_type="constant",
    report_to="tensorboard",
    ddp_find_unused_parameters=False,
)
formatting_func1 = partial(formatting_prompts_func,prompt="llama2")
callbacks = [SavePeftModelCallback()]
# Set supervised fine-tuning parameters
trainer = SFTTrainer(
    model=model,
    train_dataset=train_data,
    eval_dataset=val_data,
    peft_config=peft_config,
    formatting_func=formatting_func1,
    max_seq_length=cutoff_len,
    tokenizer=tokenizer,
    args=training_arguments,
    packing=packing,
    callbacks=callbacks,
)
`

The dataset is tokenized with:
outputs = tokenizer(
                element[dataset_text_field] if not use_formatting_func else formatting_func(element),
                truncation=True,
                padding=False,
                max_length=max_seq_len,
                return_overflowing_tokens=False,
                return_length=False,
            )

You could check if that adds the special tokens for you and otherwise add them in the formatting_func. Hope this helps!

thanks


Wallet auth

Features added:

The user can head on to '/login' page to connect his wallet with our dapp.
After connecting the wallet, the app checks for the member status of the user by calling a read-only function from Miami Vice's smart contract. Note: The Miami vice's contract is not deployed yet so the read-only function cannot be tested.
The user is then redirected to the registration page or Miami vice's dashboard.
Added the '/logout' page which signs the user out from his wallet and then redirects to the login page (will need to be changed to landing page once we have one)

Minor Changes:

Added stacks connect package for authenticating the user through the wallet web extension
Added "DOM" in tsconfig to avoid errors related to dom functions such as fetch and window.

Changes left:

I haven't worked on the HTML/CSS side of things so the login page will appear very basic with just a text and a button. I hope someone more skilled in the design aspect of the frontend can code this :D

Build is failing on CF for some reason. Check the logs.
Other than that, this is an AWESOME PR!! thank you! gonna test it out and give it an approval or not later. cc @314159265359879 for his review too. assigning reviews now...


Orchestrator is not reading the ingestion steps from appsettings

The orchestrator is not reading the ingestion steps from app settings: https://github.com/microsoft/semantic-memory/blob/main/dotnet/CoreLib/Pipeline/BaseOrchestrator.cs#L40. It always consumes the default steps.

Fixed :-)

Creating a note here for using arrays in .NET configuration:
If you have multiple sources for a configuration that is an array, the value of the configuration does NOT get overridden by each source. Instead, the values in the sources will get "merged". See example below.
appsettings.json => settings.foo = [ 1, 2, 3, 4, 5, A, B, C ]
appsettings.development.json => settings.foo = [ X, Y, Z ]

The way .NET handles that, results in
settings.foo = [ X, Y, Z, 4, 5, A, B, C ]

To avoid unintended behavior in your application if you have arrays in your config, please make sure to keep only config source that has the values and all the other ones should remain empty.


[pulsar-package-management] Support to access a separated bookkeeper cluster

Motivation
Currently, the bookkeeper client used by can not be initialized correctly when using a separated bookkeeper cluster via bookkeeperMetadataServiceUri whose zookkeeper connection may be different with pulsar zookkeeper servers.  e.g.
17:08:07.661 [ForkJoinPool.commonPool-worker-43] WARN  org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl - Failed to find 1 bookies : excludeBookies [], allBookies [].
17:08:07.662 [ForkJoinPool.commonPool-worker-43] ERROR org.apache.bookkeeper.client.LedgerCreateOp - Not enough bookies to create ledger with ensembleSize=1, writeQuorumSize=1 and ackQuorumSize=1
17:08:07.662 [ForkJoinPool.commonPool-worker-43] ERROR org.apache.distributedlog.bk.SimpleLedgerAllocator - Error creating ledger for allocating /kobe/pulsar/packages/function/public/default/redis/v1.0/meta/<default>/allocation :
org.apache.bookkeeper.client.BKException$BKNotEnoughBookiesException: Not enough non-faulty bookies available
        at org.apache.bookkeeper.client.BKException.create(BKException.java:72) ~[org.apache.bookkeeper-bookkeeper-server-4.14.3.jar:4.14.3]
        at org.apache.distributedlog.BookKeeperClient$1.createComplete(BookKeeperClient.java:223) ~[org.apache.distributedlog-distributedlog-core-4.14.3.jar:4.14.3]
        at org.apache.bookkeeper.client.LedgerCreateOp.createComplete(LedgerCreateOp.java:272) ~[org.apache.bookkeeper-bookkeeper-server-4.14.3.jar:4.14.3]
        at org.apache.bookkeeper.client.LedgerCreateOp.initiate(LedgerCreateOp.java:166) ~[org.apache.bookkeeper-bookkeeper-server-4.14.3.jar:4.14.3]

Modifications
Use the correct BKDLConfig from property bookkeeperMetadataServiceUri.
Documentation

[x] no-need-doc

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@codelipenghui Please help to take a look, thanks.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@codelipenghui PTAL, thanks!


Fix: Allow setting build dir when running a task from cli.

This is useful to allow usage in Nuxt.

🔗 Linked issue

Related to: https://github.com/unjs/nitro/issues/1974
❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Allow to set the build directory - this allows usage within Nuxt for example.

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

I am not sure if i forgot anything for this to be appreciated, also i am not sure about the naming convention.
Feedback would be appreciated.

Thanks for this PR. yes, we need to specify build-dir but I'm afraid 1) it is too early to expand experiment and 2) we might need to use programmatic API exports of Nitro for Nuxi CLI instead of depending on nitro. (I'm have it on plan ~> https://github.com/nuxt/cli/issues/353)
Nitro CLI itself can load nitro.config to respect the buildDir (PR welcome for this) but it is not going to help for Nuxt. Nitro will never involve in reading downstream configs (https://github.com/unjs/nitro/issues/2196#issuecomment-1971024371)
For clarity I'm closing this PR for now.

@pi0, thanks for your reply!

Thanks for this PR. yes, we need to specify build-dir but I'm afraid 1) it is too early to expand experiment and 2) we might need to use programmatic API exports of Nitro for Nuxi CLI instead of depending on nitro CLI. (I'm have it on plan ~> nuxt/cli#353)

I see, and get that.

Nitro CLI itself can load nitro.config to respect the buildDir (PR welcome for this) but it won't be useful for Nuxt. Nitro will never involve in reading downstream configs (#2196 (comment))

Could you please point me in the right direction as to how i can read the nitro config from the cli?
Also, how is nitro reading config from when you set it upstream then...? When you define a preset from nuxt.config.ts for example, it is propagated, but how does this happen, and would this not be a good place to set it by default in nuxt?
Thank sin advance!

When nitro used in other meta frameworks (Nuxt), it won't read config itself and Nuxt provides the config after reading nitro key in nuxt.config.ts that why we cannot have this logic in Nitro but should be in Nuxt.
Options loading mechanism is here btw: https://github.com/unjs/nitro/blob/main/src/options.ts#L144


Can't pass queries which accept non %s format arguments

If I write a SQL query with a format string that accepts anything other than %s the query will fail due to PyMySQL's internal argument processing mechanics, by which everything is converted to a string and escaped prior to execution of the query. This will raise a format error exception at run--time.

This is by design.


When update to windows 10 anniversary update, vs code terminal display looks like width not enough

VSCode Version: 1.12.2
OS Version: 15063.296

Steps to Reproduce:

When i update my pc to windows 10 anniversary version, my vs code built in terminal display something wrong, when a output is long ,it will not auto wrapping, the result is as follow picture shows, it makes me confuse

Duplicate https://github.com/Microsoft/vscode/issues/19665


update redirect

In the redirects.htcaccess file, update https://sendgrid.com/docs/Classroom/Deliver/enabling_custom_dkim.html
to redirect here: https://sendgrid.com/docs/Classroom/Deliver/Sender_Authentication/internet_standards_spf_and_dkim_and_deliverability.html

grab this one

thanks @dearkathie!

Kindly review my pr please #3137


Added oamlGodotModule::ReadDefsFile function

This pull requests allows ReadDefsFile to be called from the oamlGodotModule class, necessary for loading multiple OAML definitions (as I do in Wyrmsun for instance; and I am currently adapting Wyrmsun's engine Wyrmgus to become a Godot module).

Nice to see you're adapting Wyrmgus as a Godot module!

@marcelofg55 Thank you for making the OAML Godot module (and OAML of course!), the existence of the module made it substantially simpler to to modify Wyrmgus to make it become a Godot module as well.


Build for windows

Is your feature request related to a problem? Please describe.
A Windows 10 user can't download / use Hugy
Describe the solution you'd like
We propose an .exe app

Any progress ?


[C Team] Simple autonomous

Summary
Make a simple autonomous that drives backwards and leaves the community

This is complete


What happens to the server when 20 users submit at once?

Need to test for same expression/different expressions, or alternatives calls. Mimic real use in a seminar/classroom.

I think it makes sense to wait until async endpoints are working (at least for Herbie) to test this

We basically tested this and Zane disabled async again so I think we're fine


[bug]: switching template when connectivity browser is open leads to unstable behaviour

as of 79a37fe
steps to reproduce:
0/ go to /, select human multilevel, select mni152 template space
1/ select any region (hoc1, eg), open connectivity browser
2/ switch template to colin 27
3/ select any region (fp1, eg)
expected behaviour:
pmap shown
actual behaviour:
max pmap shown
4/ toggle connectivity accordion
expected beahviour:
connectivity widget shown, colour map applied
actual behaviour:
only white color map shown, connectivity widget not shown.
possibilty related to #605

resolved as of a673bc2
still needs e2e to prevent regression

Fixed


Update Gitea to the latest version

Gitea in this PR fixed the issue that prevented it from being used as an OCI registry when path-based routing was enabled.
We should update Gitea to the latest version and enable it so it could be used as the OCI registry for idpBuilder and make the necessary changes for PR #166 to work.

nvm looks like #236 already got this right.


Instructions on how to get ESP-IDF should be on top of release info (IDFGH-4494)

The instructions on how to get ESP-IDF for a given release from GitHub is currently the bottom of the release info, underneath the (very long) changelog. It would be better to have it on top, as the first thing you see when opening a release.

Thanks for raising this feature request.

Hi @rogerdahl,
Yes, agree this seems reasonable. The steps have been at the end for a long time now, since back when the changelogs were shorter.
We won't edit the existing releases, as editing a release sends a new round of emails to everyone who is subscribed. But we can change this starting from the next release.

Thanks for your suggestion, we have used this approach in our recent releases. Will close the issue.


manualData, manualData submission, config changes

Pull Request Test Coverage Report for Build 342257780

0 of 47 (0.0%)  changed or added relevant lines in 2 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.3%) to 36.952%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/pow/miningTasker.go
0
18
0.0%

pkg/pow/solutionHandler.go
0
29
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/pow/solutionHandler.go
1
0%

pkg/tracker/psrs.go
4
91.97%

Totals

Change from base Build 341952039:
-0.3%

Covered Lines:
1610

Relevant Lines:
4357

💛  - Coveralls


Fix TokenLayerPF2e#cycleStack

Also fixes a small error in the status effects HUD. token.actor.isDead always returns true for creatures at 0 hp so we need to check for the status.

I recall isDead and the status effect should be 1-1, but I'd have to double check. But even if it was 1-1, checking the (foundry) status effects in the status effects section is the correct way to go about it anyways.


fix crds for 0.24.0 release

Signed-off-by: haarchri<EMAIL_ADDRESS>
What this PR does / why we need it:
upgrade CRDS for 0.24.0 release
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

followup for https://github.com/fluxcd-community/helm-charts/pull/29

Special notes for your reviewer:
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] helm-docs are updated
[x] Helm chart is tested

can we only extract the CRDs from flux via cli ? then it is easy with check-diff and run a generate step

You can build this overlay https://github.com/fluxcd/flux2/blob/main/manifests/crds/kustomization.yaml, it will give you all CRDs.

thanks - i will comeback with a automatic solution - thanks


Typo in QBtnGroup

There is a typo in quasarcomponents.py file. Slots value of QBtnGroup must be default_slot (not defualt_slot).

Thank you for catching this.


why is generated iconfont so big?

I have many svg files, but a few of them are very large after they are generated.

This is true in both Mac and Linux systems
node version: 8.4.0
zip package: iconfont.zip
svg file source code:

<svg viewBox="0 0 14 2" xmlns="http://www.w3.org/2000/svg"><rect width="14" height="2" rx="1" fill="#666" fill-rule="evenodd"/></svg>

Your viewbox should be normalized to 512x512px


Summarize this page does not work normally

Describe the bug
问题描述
No conversation box popped up for the summarize this page option.
To Reproduce
如何复现
Steps to reproduce the behavior:

Go to any page
Click on summarize this page
No conversation box popped up.

Expected behavior
期望行为
A conversation box should be popped up.
Screenshots
截图说明
This is the error info provided in the service worker console.

Please complete the following information):
请补全以下内容

OS: Windows
Browser: Chrome Version 121.0.6167.140 (Official Build) (64-bit)
Extension Version: v2.4.9

Additional context
其他
This error happened frequently before, but simply reloading the web page can fix this error and the conversation box would appear normally. However, reloading the page no longer fixes this error starting from this week.

fixed in https://github.com/josStorer/chatGPTBox/commit/1fc3cd8ee072d420fc54e4ce01a6853c71c82927
After conducting some investigation, I found that OpenAI seems to have adopted different strategies for different accounts. Since my account still adheres to the traditional SSE strategy, I mistakenly assumed that everything was still normal. I have now adapted to the new WebSocket strategy and automatically adopted the appropriate strategy according to OpenAI's response.

Hey
Every now and then it works and very often there is no analysis! Unfortunately it's not stable at the moment! Without error message. Even without a VPN, things don't always work properly!


VFIO still not working

look, i tried everything, im in the latest update, i reinstalled everything, i tried the "fix" and nothing... please someone help me.
SystemLog.txt

Is this version 0.9.2f?

that file? no but i also tried it and gave me the same result

Please try 0.9.2g, and, if it fails, send a new log.
https://github.com/ra1nstorm/ra1nstorm-helper/releases/tag/0.9.2

SystemLog.txt

it failed...

im also getting the same issue that is #20 but when i force it to be one, it just shows me the script

Please try 0.9.2g, and, if it fails, send a new log.
https://github.com/ra1nstorm/ra1nstorm-helper/releases/tag/0.9.2

It appears that it attempts to forward the entire PCIe bridge, rather than just the USB controller.
Thank you. I will investigate a possible solution.

damm, that sounds bad, i hpoe you can do it, i believe in you

I have the same issue
SystemLog.txt

Should be fixed in 0.9.3 after a VFIO repair.


drivers: modem: bg9x: Kconfig values compiled into autoconf.h even if it isn't being used

Describe the bug
The bg9x modem's Kconfig is lacking the if MODEM_QUECTEL_BG9X endif guard to prevent its default values from being compiled into the autoconf.h
To Reproduce

Build anything
Check the autoconf.h for bg9x related configs

Expected behavior
Kconfig default values should be compiled only when its source is being used.
Impact
autoconf.h pollution.

Thanks!!


text-properties return wrong information

Describe the bug
I am writing a plugin using text-properties (very helpful to impove my plugin)
And when I am testing or, in other words, learning how it works, I got some wrong cases.
To Reproduce
1. A simple vim script:
let g:extend = []
func Listener(bufnr, start, end, added, changes)
 for item in a:changes
   call add(g:extend, item)
 endfor
endfunc
call listener_add('Listener')

2. A sample buffer:
1
2

3
4

we run the above vim script here now.
And after i pressed u (undo), i got the following in my buffer which is my expectation to delete 3th line, a blank line:
1
2
3
4

3. But i got wrong text-properties callback.
:echo g:extend  ===> [{'lnum': **2**, 'col': 1, 'added': -1, 'end': 4}]
In vim's doc, saying:
		When lines are deleted the values are:
	 ???      lnum	the first deleted line
		    end		the line below the first deleted line, before
				the deletion was done
		    added	negative, number of lines deleted
		    col		1

Expected behavior
:echo g:extend  ===> [{'lnum': **3**, 'col': 1, 'added': -1, 'end': 4}]
4. By contrast,
i press dd (delete one line) on the 3th line in the following buffer.
1
2

3
4

I got:
:echo g:extend  ===> [{'lnum': 3, 'col': 1, 'added': -1, 'end': 4}]
it matched.
Environment (please complete the following information):

Vim 8.2.0439
OS: Windows 10
GUI

谢谢 means to thank you for reply and your great work.

Another case
vim script same as the above.
asuming we have current buffer and cursor is at 1th line:
1
2
3
4

To press VGd, we delete all text.
To press u, undo.
I got the following:
:echo g:extend ===> [{'lnum': 1, 'col': 1, 'added': -4, 'end': 5}, {'lnum': 1, 'col': 1,** 'added': 3 **, 'end': 2}]
In fact, we did added 3 line, but the first line had changed, and vim did not notify to user.

Another case
vim script same as the above.
asuming we have current buffer and cursor is at 1th line:
1
2
3
4

To press VGd, we delete all text.
To press u, undo.
I got the following:
:echo g:extend ===> [{'lnum': 1, 'col': 1, 'added': -4, 'end': 5}, {'lnum': 1, 'col': 1,** 'added': 3 **, 'end': 2}]
In fact, we did added 3 line, but the first line had changed, and vim did not notify to user.

Jimmy Huang wrote:

Another case
vim script same as the above.
asuming we have current buffer and cursor is at 1th line:
1
2
3
4

To press VGd, we delete all text.
To press u, undo.
I got the following:
:echo g:extend ===> [{'lnum': 1, 'col': 1, 'added': -4, 'end': 5}, {'lnum': 1, 'col': 1,** 'added': 3 **, 'end': 2}]
In fact, we did added 3 line, but the first line had changed, and vim
did not notify to user.

It did, since the first line is 1, thus the first line is changed.  It
reports both the changed first line and adding three lines at once.
The "lnum" item is the first affected line, "end" is the first line
below the affected lines, before the change.
--
Witches prefer brooms: vacuum-cleaners need extension cords!
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Jimmy Huang wrote:

Describe the bug
I am writing a plugin using text-properties (very helpful to impove my plugin)
And when I am testing or, in other words, learning how it works, I got some wrong cases.
To Reproduce
1. A simple vim script:
let g:extend = []
func Listener(bufnr, start, end, added, changes)
 for item in a:changes
   call add(g:extend, item)
 endfor
endfunc
call listener_add('Listener')

2. A sample buffer:
1
2

3
4

How did you create this?  Since you use undo this matters.

we run the above vim script here now.
And after i pressed u (undo), i got the following in my buffer which is my expectation to delete 3th line, a blank line:
1
2
3
4

3. But i got wrong text-properties callback.
:echo g:extend  ===> [{'lnum': **2**, 'col': 1, 'added': -1, 'end': 4}]
In vim's doc, saying:
		When lines are deleted the values are:
	 ???      lnum	the first deleted line
		    end		the line below the first deleted line, before
				the deletion was done
		    added	negative, number of lines deleted
		    col		1

Expected behavior
:echo g:extend  ===> [{'lnum': **3**, 'col': 1, 'added': -1, 'end': 4}]
4. By contrast,
i press dd (delete one line) on the 3th line in the following buffer.
1
2

3
4

I got:
:echo g:extend  ===> [{'lnum': 3, 'col': 1, 'added': -1, 'end': 4}]
it matched.

If I add the line with "o" on the second or "O" on the third line and
then undo, I get the same.
--
The question is:  What do you do with your life?
The wrong answer is: Become the richest guy in the graveyard.
(billionaire and Oracle founder Larry Ellison)
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

How did you create this?  Since you use undo this matters.
If I add the line with "o" on the second or "O" on the third line and then undo, I get the same.

Just same as you do. It seems to work well when i  p a new line then undo it.

It did, since the first line is 1, thus the first line is changed.  It
reports both the changed first line and adding three lines at once.
The "lnum" item is the first affected line, "end" is the first line
below the affected lines, before the change.

I think i get it now.  At the first time, i thought it's "one operation one report", and it is very nice for users.

But i got wrong text-properties callback.

:echo g:extend ===> [{'lnum': 2, 'col': 1, 'added': -1, 'end': 4}]
In vim's doc, saying:
  When lines are deleted the values are:

???      lnum	the first deleted line
end		the line below the first deleted line, before
the deletion was done
added	negative, number of lines deleted
col		1
Expected behavior
:echo g:extend ===> [{'lnum': 3, 'col': 1, 'added': -1, 'end': 4}]

That's not what I get:
vim -Nu NONE -S <(cat <<'EOF'
    vim9
    range(1, 4)->setline(1)
    feedkeys('2Go', 'nxt')
    g:extend = []
    def Listener(bufnr: number, start: number, end: number, added: number, changes: any)
        for item in changes
            add(g:extend, item)
        endfor
        echom g:extend
    enddef
    listener_add(Listener)
    feedkeys('u', 'nxt')
    redraw
    mess
EOF
)

This outputs:
[{'lnum': 3, 'col': 1, 'added': -1, 'end': 4}]
          ^

I think i get it now.

So, is there still an issue?

I think this is either fixed or working as intended.  I'll tentatively close this issue.  If you do see a problem, please re-open and give a full reproduction.


feat: move Hasura actions to be a module

Description
This PR makes the Hasura actions work just like any other module. The configuration of the module allows to specify another node to get the data from. It also changes how the migrate v3 command works by adding the configuration for the new actions module.
Closes: #375

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[x] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[x] targeted the correct branch
[ ] provided a link to the relevant issue or specification
[x] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[x] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

I think we should also add actions to config file on init command and add node section for rpc/grpc address in default config file, what do you think?

I think we should also add actions to config file on init command and add node section for rpc/grpc address in default config file, what do you think?

Added, thanks!

I am testing it on my local and I can't get the hasura actions to work properly. I am getting internal server error inside hasura console and in docker logs this error pops up Spock Error while handling ["v1","graphql"]: InvalidUrlException "host.docker.internal:3000/account_balance" "Invalid scheme" 🤔

I am testing it on my local and I can't get the hasura actions to work properly. I am getting internal server error inside hasura console and in docker logs this error pops up Spock Error while handling ["v1","graphql"]: InvalidUrlException "host.docker.internal:3000/account_balance" "Invalid scheme" thinking

Does anything else work if you don't use Hasura actions? What's the config?

Yes bdjuno works, I migrated to v3 config file and just set port to 3000 inside actions section like so:
actions:
    port: 3000

After investigating with @RiccardoM we've found out that this error was caused by missing http:// prefix inside docker' ACTION_BASE_URL flag


Question: abusing click to parse other apps command lines

I am wondering if anyone has been able to abuse click to parse command lines of other programs. Imagine I want to create a git command line parser gitp but instead of receiving a command line like git, it receives a file with several git calls and for each it parses its command line and stores somewhere in a database.
How would I be able to abuse click like this? Any suggestions?

Please use StackOverflow for questions.


Blue icon can't be seen in title bar when blue accent color is being used in Windows

The new blue icon, introduced in 1.18, can't be seen in the title bar when the Windows 10 accent color is set to blue (which I bet lots of people are using). See the screenshot below.
I suggest using 2 colors (blue + black), just like the icon in the Start Menu which doesn't have this problem.

Old one with white outline worked fine.
Orange one worked fine.
On mostly dark environment I'd prefer white outline.
Personally, I'm fine with orange and would've prefer if you insisted on keeping orange color despite initial kickback.

Here's a bit of extra information. You probably don't encounter this problem unless you've got this specific Windows color setting turned on:

When VS Code is unfocused, it's OK:

But when VS has the focus, you can't see it:

If I remember correctly, the original blue icon had a small white outline around the logo, and was also filled with white. I'm not sure you could really fill the new one (there's only one closed section), but it should be possible to add a small white outline to it to make it stand out more.
Here it is on the taskbar (next to VS 2017):

I think it looks OK as-is on the taskbar (and matches VS 2017 nicely), so I don't think it needs a white outline there.

Worst case for taskbar:

Normally I'm using Navy Blue and transparency on. So it looks like this for me:

Still it was notable change for worse compared to previous icons.
Any mono-colored icon can have it's own worst case, VS too, it's just happen that blue is kind of default background color. Some ways to increase contrast better be considered for all the icons across product family.
Title bar icon I can barely see:

But thankfully I don't need to look for it as often as for taskbar icon.

@KillyMXI Ah, I see what you mean about the taskbar now.

I liked the orange one A LOT. In a task bar filled with blue or blue~ish icons it stands out and that was such a nice change. Then they changed it back to blue because people didn't like it.
Now, you know people who don't like it, but how about people who actually like it?

There is currently no plans to change the icons, but thanks for your interest. See also https://code.visualstudio.com/blogs/2017/10/24/theicon

@bpasero So you don't care that the icon is invisible in the title bar on what's basically a default Windows installation?

The shape of the logo is irrelevant for this discussion. This issue is about the fact that you can't see the logo on a blue title bar. That is all.

Great! Now the Code icon is practically indistinguishable from VS2017! 👎 😞

Seconded. The original icon was perfect. without the white outline around the icon, it is very difficult to see the logo against many colors on the desktop (in windows)
This is a screenshot of my desktop. the new logo is barely visible against my wallpaper:

This also affects Windows 7's taskbar when the icon overlays a correctly coloured bit of desktop background. It happens for me with the default win 7 background, the icon is before VS2015's:

A white border like it used to have, or anything to give it some contrast against whatever colour background, would be extremely useful.

@bpasero This is a problem for people still on Windows. Even discounting the status bar thing, it's very difficult to see on the task bar in Windows 7. How can you say this is fine?


Update SOP links on ASCT+B Table page

Update SOP links on ASCT+B Table page
SOP links need to be updated to the following URLs:

[ ] SOP: Authoring Anatomical Structures, Cell Types and Biomarkers (ASCT+B) Tables
[ ] SOP: ASCT+B Table Communications

External links should always open in new tabs.
Tagging @emquardokus so she can track this issue and comments can be resolved in the ASCT+B Table doc. Thank you!

Fixed this in #173


'save' button on homebridge-config-ui-x settings does not work

Clicking the 'Save' button on homebridge-config-ui-x settings form does not save the changes. The spinner runs forever and config.json is not updated. I don't mean the config.json file edtior (this one works as expected) what I mean is the one that is available in the 'Plugins' tab. Nothing unusual is shown in the logs, btw.

I cannot replicate this. What does your setup look like? Both your issues are probably caused by something unique to your environment.

I am running homebridge-config-ui-x as a plugin in a docker container. It suddenly started working as expected and can't reproduce it right now.
The other issue was likely caused by a failed update attempt though I don't think npm would remove  the existing package in that case.
Feel free to close both issues if you think they are not helpful, I will open again if have more info. Thanks!


NAS-130771 / 24.10-RC.1 / Add RedactedFileMetric and use to redact iSCSI CHAP secrets (by bmeagherix)

Add RedactedFileMetric and use redact_chap_passwords callback to redact iSCSI CHAP secrets.
This will replace the secrets in the copy of /etc/scst.conf.
Original PR: https://github.com/truenas/ixdiagnose/pull/211
Jira URL: https://ixsystems.atlassian.net/browse/NAS-130771

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.


Feature/correct cell names

Description
Clearly documents the reason for the pull request and what has changed.

[ ] This is a bugfix.
[ ] This is a new feature.
[x] This is part of a feature.

Organization

[x] Have you linked this pull request to a Trello card?

Review

[ ] Have you added two reviewers to this pull request?
[x] Is this a work in process?
[ ] Is this ready to be reviewed?

Some sector and cell names can not be unmatched  between datasets. I corrected  some names  which codes can not solve.

 Merging "site_assessment" and "names_codes" datasets


Improve the text at the top of the home page

Received the latest home page text from the product team.

Test


TkPrevious and RsPrevious

Let's make it possible to redirect on logout

@rultor release, tag is 1.10

@rultor release, tag is 1.10

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 1.10

@yegor256 Done! FYI, the full log is here (took me 14min)

The job is not in WBS, won't close the order


Show the help message when no action is specified

Right now when one runs the wemo command without arguments it throws an error.
Traceback (most recent call last):
  File "/home/epoulin/.local/share/pyenv/versions/shell/bin/wemo", line 10, in <module>
    sys.exit(wemo())
  File "/home/epoulin/.local/share/pyenv/versions/3.7.2/envs/shell/lib/python3.7/site-packages/ouimeaux/cli.py", line 375, in wemo
    args.func(args)
AttributeError: 'Namespace' object has no attribute 'func'

This PR changes it so that the usage message is printed instead.

LGTM, thanks.