loglevel is ignored for alertmanager

What did you do?
added the loglevel: debug to alertmanager-main
spec:
  ExternalURL: https://foo.bar.tld/alertmanager-main/
  logLevel: debug
  replicas: 3
  version: v0.15.0-rc.1

What did you expect to see?
debug log in the logs and --log.level=debug as arg for the alertmanager
What did you see instead? Under which circumstances?
 kubectl -n monitoring describe pod alertmanager-main-1
Name:           alertmanager-main-1
Namespace:      monitoring
Node:           ip-172-25-33-187.us-east-2.compute.internal/<IP_ADDRESS>
Start Time:     Tue, 17 Apr 2018 09:28:31 +0200
Labels:         alertmanager=main
                app=alertmanager
                controller-revision-hash=alertmanager-main-7f64f658c5
Annotations:    kubernetes.io/created-by={"kind":"SerializedReference","apiVersion":"v1","reference":{"kind":"StatefulSet","namespace":"monitoring","name":"alertmanager-main","uid":"20e7e01c-420f-11e8-b874-069d260f2e...
Status:         Running
IP:             <IP_ADDRESS>
Controlled By:  StatefulSet/alertmanager-main
Containers:
  alertmanager:
    Container ID:  docker://5418c244fce1eb26cc7e0d795a6ec97631d9669a51107428f33f673b5cf6150b
    Image:         quay.io/prometheus/alertmanager:v0.15.0-rc.1
    Image ID:      docker-pullable://quay.io/prometheus/alertmanager@sha256:d7bf6d0943f8a83c55aa50a7c6e6331a1be63f624f88176f110ee41ad720a12f
    Ports:         9093/TCP, 6783/TCP
    Args:
      --config.file=/etc/alertmanager/config/alertmanager.yaml
      --cluster.listen-address=$(POD_IP):6783
      --storage.path=/alertmanager
      --web.listen-address=:9093
      --web.external-url=https://foo.bar.tld/alertmanager-main/
      --web.route-prefix=/
      --cluster.peer=alertmanager-main-0.alertmanager-operated.monitoring.svc:6783
      --cluster.peer=alertmanager-main-1.alertmanager-operated.monitoring.svc:6783
      --cluster.peer=alertmanager-main-2.alertmanager-operated.monitoring.svc:6783
    State:          Running
      Started:      Tue, 17 Apr 2018 09:28:34 +0200
    Ready:          True
    Restart Count:  0
    Requests:
      memory:   200Mi
    Liveness:   http-get http://:web/api/v1/status delay=0s timeout=3s period=10s #success=1 #failure=10
    Readiness:  http-get http://:web/api/v1/status delay=3s timeout=3s period=5s #success=1 #failure=10
    Environment:
      POD_IP:   (v1:status.podIP)
    Mounts:
      /alertmanager from alertmanager-main-db (rw)
      /etc/alertmanager/config from config-volume (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-28zcn (ro)
  config-reloader:
    Container ID:  docker://8f75517bfdec6f7a1500fe406cbec6f5af3808e6a3f0d16de73695ca938b56f4
    Image:         quay.io/coreos/configmap-reload:v0.0.1
    Image ID:      docker-pullable://quay.io/coreos/configmap-reload@sha256:e2fd60ff0ae4500a75b80ebaa30e0e7deba9ad107833e8ca53f0047c42c5a057
    Port:          <none>
    Args:
      -webhook-url=http://localhost:9093/-/reload
      -volume-dir=/etc/alertmanager/config
    State:          Running
      Started:      Tue, 17 Apr 2018 09:28:42 +0200
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:     5m
      memory:  10Mi
    Requests:
      cpu:        5m
      memory:     10Mi
    Environment:  <none>
    Mounts:
      /etc/alertmanager/config from config-volume (ro)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-28zcn (ro)
Conditions:
  Type           Status
  Initialized    True
  Ready          True
  PodScheduled   True
Volumes:
  config-volume:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  alertmanager-main
    Optional:    false
  alertmanager-main-db:
    Type:    EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:
  default-token-28zcn:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-28zcn
    Optional:    false
QoS Class:       Burstable
Node-Selectors:  <none>
Tolerations:     node.alpha.kubernetes.io/notReady:NoExecute for 300s
                 node.alpha.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type    Reason                 Age   From                                                  Message
  ----    ------                 ----  ----                                                  -------
  Normal  Scheduled              9m    default-scheduler                                     Successfully assigned alertmanager-main-1 to ip-172-25-33-187.us-east-2.compute.internal
  Normal  SuccessfulMountVolume  9m    kubelet, ip-172-25-33-187.us-east-2.compute.internal  MountVolume.SetUp succeeded for volume "alertmanager-main-db"
  Normal  SuccessfulMountVolume  9m    kubelet, ip-172-25-33-187.us-east-2.compute.internal  MountVolume.SetUp succeeded for volume "config-volume"
  Normal  SuccessfulMountVolume  9m    kubelet, ip-172-25-33-187.us-east-2.compute.internal  MountVolume.SetUp succeeded for volume "default-token-28zcn"
  Normal  Pulling                9m    kubelet, ip-172-25-33-187.us-east-2.compute.internal  pulling image "quay.io/prometheus/alertmanager:v0.15.0-rc.1"
  Normal  Pulled                 9m    kubelet, ip-172-25-33-187.us-east-2.compute.internal  Successfully pulled image "quay.io/prometheus/alertmanager:v0.15.0-rc.1"
  Normal  Created                9m    kubelet, ip-172-25-33-187.us-east-2.compute.internal  Created container
  Normal  Started                9m    kubelet, ip-172-25-33-187.us-east-2.compute.internal  Started container
  Normal  Pulling                9m    kubelet, ip-172-25-33-187.us-east-2.compute.internal  pulling image "quay.io/coreos/configmap-reload:v0.0.1"
  Normal  Pulled                 9m    kubelet, ip-172-25-33-187.us-east-2.compute.internal  Successfully pulled image "quay.io/coreos/configmap-reload:v0.0.1"
  Normal  Created                9m    kubelet, ip-172-25-33-187.us-east-2.compute.internal  Created container
  Normal  Started                9m    kubelet, ip-172-25-33-187.us-east-2.compute.internal  Started container

Environment

Kubernetes version information:

kubectl version
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.3", GitCommit:"d2835416544f298c919e2ead3be3d0864b52323b", GitTreeState:"clean", BuildDate:"2018-02-07T12:22:21Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.11", GitCommit:"1df6a8381669a6c753f79cb31ca2e3d57ee7c8a3", GitTreeState:"clean", BuildDate:"2018-04-05T17:16:46Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:

kops

Prometheus Operator Logs:

ts=2018-04-17T07:39:04.135750535Z caller=operator.go:338 component=alertmanageroperator msg="Alertmanager updated" key=monitoring/main
ts=2018-04-17T07:39:04.135838797Z caller=operator.go:394 component=alertmanageroperator msg="sync alertmanager" key=monitoring/main

@Deshke which version of the Prometheus Operator are you using?

@mxinden quay.io/coreos/prometheus-operator:v0.18.1

did not work with 0.15 to 0.17 either

@Deshke The AM-LOG-Level feature is not yet released. It is only present on current master.
In order to use it, you would need to build a Prometheus operator Docker image from master (make crossbuild contianer) and deploy it on your cluster.
I am closing here. Let me know if you have any further questions.


transpileModules config

This will allow transpiled modules just like https://www.npmjs.com/package/next-transpile-modules you can now just add transpileModules to your remix.config.js.
/**
 * @type {import('@remix-run/dev/config').AppConfig}
 */
module.exports = {
  appDirectory: 'app',
  browserBuildDirectory: './public/build',
  publicPath: '/build/',
  serverBuildDirectory: './server/build',
  devServerPort: 8002,
  transpileModules: ['ui', 'lib', 'env'],
}

@ryanflorence this was not intended for node_modules, but if you are using a monorepo (workspaces, lerna, turbo etc...) and needed to include your other packages with your deployment i.e. your UI components.  It looks like someone else opened up a pull request with the same approach but better documentation https://github.com/remix-run/remix/pull/1839 😄

Thanks for taking the time to improve Remix!
Unfortunately we'd rather not transpile modules from node_modules. The module ecosystem has gotten incredibly dependent on webpack-isms (like automatically polyfilling node built-ins like "http", which is 250kb of code that sneaks into your bundle!) and folks expecting a bundler to figure out how to import a css file.
We don't want to enable the same incompatibility issues by enabling people to ship "remix-isms" or "esbuild-isms" in their node_modules.
Thanks again though :)

Please merge this pr to allow people have the option to choose to transpile the modules


Template validation

PR Details
Namespace changes within the namespace validation window weren't being carried over to generated project source files, this PR fixes that.
Description
See above.
Related Issue
#547
Motivation and Context
Fix a bug.
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

This PR supersedes #753 , see my comment over there for more info.
Do note that the generated *App.cs class name is based on the project name and gets auto-corrected through BuildValidClassName(), it is not based on the namespace, they won't match if users change the namespace, it works fine but I'm not sure that that's expected behavior for you @xen2, I'll leave that to you.

I have also noticed when checking #753 PR that namespace wasn't passed through, and as you guessed it's the proper fix to do.
Thanks for getting ahead of me and making a new PR to fix that!


select does not seem to limit columns pulled from tap

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/603
Originally created by @robmoore1 on 2019-04-21 19:17:30

What is the current bug behavior?
Using the select command, users can indicate a specific column for the table they are selecting. This is captured correctly in meltano.yml. However, when running the elt process, all of the columns are selected rather than just the ones specified.
What is the expected correct behavior?
Only the indicated columns should be used when pulling data via the tap.
Steps to reproduce
How one can reproduce the issue?
Using select indicate a table and a particular column rather than '*'.
Run elt and view the query executed in the output.
Refer to the table created and note it contains all columns from the original table.
Relevant logs and/or screenshots
I ran meltano select tap-postgres "flyway_schema_history" "installed_rank" and then meltano elt tap-postgres target-postgres and saw the following in the output:
INFO Loading 44 rows into 'flyway_schema_history'
INFO COPY flyway_schema_history_temp ("checksum", "description", "execution_time", "installed_by", "installed_on", "installed_rank", "script", "success", "type", "version") FROM STDIN WITH (FORMAT CSV, ESCAPE '\')
INFO UPDATE 0
INFO INSERT 0 44

I also confirmed that all the columns were pulled from the source.
Possible fixes
If you can, link to the line of code that might be responsible for the problem or suggest a fix
Further regression test
Ensure we automatically catch similar issues in the future

[ ] Write additional adequate test cases and submit test results
[ ] Test results should be reviewed by a person from the team

View 17 previous comments from the original issue on GitLab


Make GuildChannel.toString work properly for voice channels

This isn't necessary, as Discord still displays the channel name.


adding after Signed-off-by Matt Germonprez

@LawrenceHecht these changes have been captured in a separate doc and will be resurfaced when we do our periodic review of the Burnout metric. This should be happening in the next month or so. :+1: I'm closing this for now.


simpletest from ladyada

will be back for the pylintening

I took a shot at resolving the pylint issues.
The biggest factor was this file seemed to contain two examples one after the other. I split them into separate files ov5640_pico_simpletest.py and ov5640_pico_st7789.py and the majority of the pylint issues went away. The few remaining were some unused imports.
I also renamed the files to use ov5640_ as the first part of the name. I forget exactly what it is, but I think there is something that assumes example file names will have the library name at their beginning.


Fix one of the transitions and remove the app and status bar from the top of RegisterActivity.

When the application is opened, the RegisterActivity is displayed after the SplashScreen, you have to make it so that after opening the application and SplashScreen being displayed for 3s, LoginActivity should be displayed instead of the RegisterActivity.
Also, there are still app and status bar present on the top of the RegisterActivity, you have to remove them so it looks similar to the login Activity
LoginActivity:

RegisterActivity

Attach a .gif of opening the application, LoginActivity being displayed after SplashScreen, going to the RegisterActivity and showing the changes while submitting a PR.

Claim

claim

@IEC2021103Abhinav  you have been assigned this issue.


TextEdit ignores expand_margin

Godot version
3.4.4
System information
Windows 10
Issue description
Setting a border on the TextEdit with an expand_margin results in no border at all.
Steps to reproduce

Make a new Theme
Give TextEdit a focus StyleBoxFlat with a border of 4px on all sides
Clicking the preview TextEdit shows a border
Change the StyleBoxFlat to use an expand_margin of 4px on all sides
Click the preview TextEdit: no border visible

Setting a similar StyleBoxFlat for LineEdit works as expected.
Minimal reproduction project
No response

Related to https://github.com/godotengine/godot/issues/32867.


vp9 ref_frame_sign_bias flag set error.

in some vp9 clips,  ref_frame_sign_bias_flag set error.
clip: Stress_VP9_3840x2160_150_inter_stress_1.1.vp9

Find out that libyami should set ref_frame_sing_bias to zero when Reset the segment feature data to the default stats but libyami forget that.

see #275 , this bug is fixed.

Hi Cong:
can we close this?

yes, it can be closed now.


Stored properties cannot be marked potentially unavailable with '@available'.

After adding the Location Picker am getting the error "Xcode build done.
Failed to build iOS app
Swift Compiler Error (Xcode): Stored properties cannot be marked potentially unavailable with '@available'.
......ios/Pods/LocationPicker/LocationPicker/LocationPickerViewController.swift:59:5

After adding the Location Picker am getting the error "Xcode build done. Failed to build iOS app Swift Compiler Error (Xcode): Stored properties cannot be marked potentially unavailable with '@available'. ......ios/Pods/LocationPicker/LocationPicker/LocationPickerViewController.swift:59:5


add custom buttons option

link to https://github.com/jpilfold/ngx-image-viewer/issues/4
Can you please review the var names and see if they make since to you.  Or would like me to change anything.

Do you mind if i add this change in with my request:
to change the cursor on disabled buttons.
.img-container button {
    z-index: 99;
    position: absolute;
    right: 15px;
    cursor: pointer;
}

To
.img-container button {
    z-index: 99;
    position: absolute;
    right: 15px;

    &:not(:disabled) {
      cursor: pointer;
    }
}

@tmburnell How's this coming along?

@jpilfold Updated lint, function, naming.  Can you please review again.

Do you want a type definition for the event format?

Yes please, that would be good.

Have added the event ts type.


rsync installation fails in 1.7

Here are the versions from the welcome message:
Boot2Docker version 1.7.0, build master : 7960f90 - Thu Jun 18 18:31:45 UTC 2015
Docker version 1.7.0, build 0baf609

This is the output when I try to install rsync:
tce-load -iw rsync
Downloading: rsync.tcz
Connecting to repo.tinycorelinux.net (<IP_ADDRESS>:80)
wget: server returned error: HTTP/1.1 404 Not Found
md5sum: rsync.tcz.md5.txt: No such file or directory
Error on rsync.tcz

I could install the package with version 1.6

same problem

We had this same problem today. I filed #950 as a response.
We compiled a 64 bit copy on an Ubuntu box and it seems to be running fine. You can either do the same for yourself or download ours here if you'd like: https://64bit-rsync.s3.amazonaws.com/rsync

As another workaround, compiling rsync on a boot2docker instance is trivial.  I was able to build a rsync 3.1.1 tcz without any problems by installing the TCL build environment packages and following their instructions http://wiki.tinycorelinux.net/wiki:creating_extensions.
I have my files and a build here if you are interested:
cameronbrunner/tinycorelinux-extensions/releases/tag/rsync-0.0.1

FYI - They took my rsync contribution and uploaded it today.  Expect to see it in all of the mirrors shortly.
http://www.tinycorelinux.net/6.x/x86_64/tcz/updates/updatelist.txt
Once replicated to all mirrors this issue should go away.

It appears this now can be installed via the package manager thanks to @cameronbrunner's work on this. So, this issue seems to be resolved.

@jakirkham Good catch :)  They just published the new rsync.tcz.dep 21 hours ago.


Adopting Package Namespaces for NuGetGallery

Closes https://github.com/NuGet/Engineering/issues/3992
Made changes to the NuGet.config files to make use of the Package Namespaces feature (spec)  in the NuGet Gallery repo.
NOTE: Package Namespaces is still in preview and may see further changes, so these changes cannot be merged as of now (even though they wouldn't break anything at the moment).
FURTHER RESOURCES: Introducing Package Namespaces (DRAFT)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: advay26 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

FYI @nkolev92 , @erdembayar

Please don't merge this PR now. We are changing XML element names in settings and should be a minor change.

@advay26 - The XML attribute name change is done. Example can be found here https://devblogs.microsoft.com/nuget/introducing-package-source-mapping/#package-source-mapping-example-configuration and https://github.com/NuGet/Samples/blob/main/PackageSourceMappingExample/nuget.config#L19.

@advay26 - The XML attribute name change is done. Example can be found here https://devblogs.microsoft.com/nuget/introducing-package-source-mapping/#package-source-mapping-example-configuration and https://github.com/NuGet/Samples/blob/main/PackageSourceMappingExample/nuget.config#L19.

I'm trying to create tool that generates this part so please hold on until end of next week.

After approving the PR, I realized that globalPackagesFolder is not configured in the NuGet.Config file. This means that if the package is available locally on the %userprofile%\.nuget\packages then no online sources will be checked. For e.g. https://github.com/NuGet/Samples/blob/main/PackageSourceMappingExample/nuget.config#L6

But in general trust packages already on local, for example fallback folder.

I agree with @erdembayar.
You already trust whatever is available on your local machine.


remove hovers for mobile devices

Will fix #321, but don't want to close that issue until it's tested. I'm not sure the best way to test this other than to get it out on prod so that someone with an iPhone can verify the behavior is fixed. Problem was that we kept mouseover events active even on mobile devices and thought it wouldn't matter, but iOS apparently registers hovers. Decided to remove those and I think that will fix the weird behavior.

OK @aappling-usgs, I think I've got it now :)


odo allows creating mutliple URLs with same name in experimental mode

/kind bug

What versions of software are you using?
Operating System: all
Output of odo version: master
How did you run odo exactly?
$ odo create nodejs
Experimental mode is enabled, use at your own risk

Validation
 ✓  Checking devfile compatibility [114792ns]
 ✓  Validating devfile component [201390ns]

Please use `odo push` command to create the component with source deployed

$ odo url create --host apps-crc.testing nodejs-300
 ✓  URL created for component: nodejs, cluster host: apps-crc.testing

To create the URL on the cluster, please use `odo push`

$ odo url create --host apps-crc.testing
 ✓  URL created for component: nodejs, cluster host: apps-crc.testing

To create the URL on the cluster, please use `odo push`

$ cat .odo/env/env.yaml
ComponentSettings:
  Name: nodejs
  Namespace: myproject
  Url:
  - Name: nodejs-300
    Port: 3000
    host: apps-crc.testing
  - Name: nodejs-3000
    Port: 3000
    host: apps-crc.testing

Actual behavior
odo url create allows creation of multiple URLs with same name
Expected behavior
It shouldn't allow creation of multiple URLs with same name. Or at least it doesn't when I execute any of the above two odo url create commands again.
Any logs, error output, etc?

The component was not pushed to the cluster when I faced the bug.
Backend cluster was OpenShift

I think there is a similar issue https://github.com/openshift/odo/issues/2980. Can you please check?

Yep. Closing since this is dupe as mentioned above.


[entropy_src/rtl] intial version of RTL

Signed-off-by: Mark Branstad<EMAIL_ADDRESS>

@vogelpi could you review these changes for the RTL? They are fairly small. If they look ok and approved, could you also integrate? Thanks much.

@vogelpi @sriyerg @eunchan
It seem the wierdness with the check pulling an old commit has been fixed. can this be merged?

Hi @mwbranstad,
sorry for my very late response. I was busy with other stuff and at some point noted that the PR already got approved. I think @msfschaffner is basically out of office this week.
I commented on your issue for the styleguide here: lowRISC/style-guides#21
Independent of the outcome of this discussion (I fear it could take more time to resolve the discussion, to prepare and to get the actual PR merged in the styleguide), I would recommend to change the "questionable" statements to the syntax recommend by @msfschaffner and the styleguide for reasons of consistency. Once the style guide is changed, we can alter the RTL again, no one will disagree. I did the same also with AES.
Other than that, the RTL looks very clean but also not yet complete. I would ask you to describe in the commit message (and also in the PR), what this commit implements and what not. As an example, I did the following in my first AES RTL commit:
    [aes] Add AES module

    This is the first commit for the AES module. It contains the register
    interface, as well as top-level and core RTL files.

    Apart from the register interface, the module is not yet functional.
    The functional blocks will be added with future commits.

Best regards,
Pirmin

@vogelpi thanks for the review. As you have outlined, I have reverted the operators to the bitwise version until the issue is resolved. Also, update the PR comment to say that the RTL is in fact complete relative to the current specification. Of course there is on-going architectural discussions to change that, but it is so in flux that is cannot be include in this PR yet.

Thanks @mwbranstad for changing and sorry for my comment regarding the incompleteness (I had in mind that the spec describes much more).
Regarding the bitwise and logical operators: there are still a couple assignments in the code that use the logical operators. Could you please also change those to bitwise?

@vogelpi Apparently did not scan the file properly before. All operations should be converted that are not in conditional context.

LGTM, will leave the final approval to the designers.


Peer to peer code review

Hello @DammyShittu, Your repo looks professional👏🏼

Your code is clean and it follows the best practices. Great work 👍🏼

The suggestion made was to change your module functions to pure functions for easy testing.

Happy Coding 😄 💻

✌