Handle exceptions thrown by filter chain

Before I added this starter to my app I had my own @ControllerAdvice error handler. By default, this doesn't handle exceptions thrown by filters, so I added a filter to ensure that an ExpiredJwtException thrown within the filter chain would also be handled
@Component
public class FilterChainExceptionHandler extends OncePerRequestFilter {

    private final HandlerExceptionResolver resolver;

    public FilterChainExceptionHandler(@Qualifier("handlerExceptionResolver") HandlerExceptionResolver resolver) {
        this.resolver = resolver;
    }

    @Override
    protected void doFilterInternal(HttpServletRequest request, HttpServletResponse response, FilterChain filterChain)
        throws ServletException, IOException {

        try {
            filterChain.doFilter(request, response);

        } catch (ExpiredJwtException e) {
            // forward the exception to the @ControllerAdvice error handler
            resolver.resolveException(request, response, null, e);
        }
    }
}

After deleting my @ControllerAdvice and using this starter instead, this no longer works. I suspect this is because the error handler in this starter is annotated @ControllerAdvice(annotations = RestController.class), so it will only handle exceptions propagated by REST controllers.
Is there a way to allow exceptions thrown by filters to be handled as well?

Can you try if https://wimdeblauwe.github.io/error-handling-spring-boot-starter/current/#handle-non-rest-controller-exceptions would help ?

@wimdeblauwe thanks for your response, unfortunately that didn't work. I defined the class like this (the example in the docs is missing the responseCustomizers argument) and set a breakpoint in handleException, but it wasn't called
@ControllerAdvice
@ConditionalOnWebApplication(type = ConditionalOnWebApplication.Type.SERVLET)
public class FallbackExceptionHandler extends ErrorHandlingControllerAdvice {

    public FallbackExceptionHandler(List<ApiExceptionHandler> handlers,
                                    FallbackApiExceptionHandler fallbackHandler,
                                    LoggingService loggingService,
                                    List<ApiErrorResponseCustomizer> responseCustomizers) {

        super(handlers, fallbackHandler, loggingService, responseCustomizers);
    }

    @ExceptionHandler
    @Override
    public ResponseEntity<?> handleException(Throwable exception, WebRequest webRequest, Locale locale) {
        return super.handleException(exception, webRequest, locale);
    }
}

My current workaround is to redefine my custom filter like so. Obviously this isn't ideal, because the goal of the starter is to have a consistent/declarative approach to error handling
@Component
public class FilterChainExceptionHandler extends OncePerRequestFilter {

    private final FallbackApiExceptionHandler fallbackHandler;
    private final ObjectMapper objectMapper;

    public FilterChainExceptionHandler(FallbackApiExceptionHandler fallbackHandler, ObjectMapper objectMapper) {
        this.fallbackHandler = fallbackHandler;
        this.objectMapper = objectMapper;
    }

    @Override
    protected void doFilterInternal(HttpServletRequest request, HttpServletResponse response, FilterChain filterChain)
        throws ServletException, IOException {

        try {
            filterChain.doFilter(request, response);

        } catch (ExpiredJwtException e) {
            /*
            The global exception handler does not handle exceptions thrown in the filter chain, so call the relevant
            functionality in this library ourselves to emit the same response (as the exceptions it does handle)
            https://github.com/wimdeblauwe/error-handling-spring-boot-starter/issues/87
             */
            var responseBody = fallbackHandler.handle(e);
            var jsonResponseBody = objectMapper.writeValueAsString(responseBody);
            response.sendError(UNAUTHORIZED.value(), jsonResponseBody);
        }
    }
}

Do you have a small project with a test that triggers the exception so I could take a closer look if we could do something automatically in the library?

Solution Proposal
Add a filter to the starter that does much the same as FilterChainExceptionHandler (see above). In other words, it runs as early as possible in the filter chain, catches exceptions thrown by other filters, and handles them in the same way as ErrorHandlingControllerAdvice.
Either of the following approaches could be adopted to avoid making the introduction of this feature a breaking change

handling exceptions thrown by filters is controlled by a configuration property that is disabled by default
the configuration has a list of exception types that should be handled, which is empty by default

In order to avoid duplicating the same logic in this filter and ErrorHandlingControllerAdvice, you could define a new bean that encapsulates this logic and delegate to it in both places. e.g.
@Component
public class ErrorHandlingFacade {
    private static final Logger LOGGER = LoggerFactory.getLogger(ErrorHandlingControllerAdvice.class);

    private final List<ApiExceptionHandler> handlers;
    private final FallbackApiExceptionHandler fallbackHandler;
    private final LoggingService loggingService;
    private final List<ApiErrorResponseCustomizer> responseCustomizers;

    public ErrorHandlingFacade(List<ApiExceptionHandler> handlers,
                               FallbackApiExceptionHandler fallbackHandler,
                               LoggingService loggingService,
                               List<ApiErrorResponseCustomizer> responseCustomizers) {
        this.handlers = handlers;
        this.fallbackHandler = fallbackHandler;
        this.loggingService = loggingService;
        this.responseCustomizers = responseCustomizers;
        this.handlers.sort(AnnotationAwareOrderComparator.INSTANCE);

        LOGGER.info("Error Handling Spring Boot Starter active with {} handlers", this.handlers.size());
        LOGGER.debug("Handlers: {}", this.handlers);
    }

    public ResponseEntity<ApiErrorResponse> handleException(Throwable exception) {
        ApiErrorResponse errorResponse = null;
        for (ApiExceptionHandler handler : handlers) {
            if (handler.canHandle(exception)) {
                errorResponse = handler.handle(exception);
                break;
            }
        }

        if (errorResponse == null) {
            errorResponse = fallbackHandler.handle(exception);
        }

        for (ApiErrorResponseCustomizer responseCustomizer : responseCustomizers) {
            responseCustomizer.customize(errorResponse);
        }

        loggingService.logException(errorResponse, exception);

        return ResponseEntity.status(errorResponse.getHttpStatus())
                             .body(errorResponse);
    }
}

Delegating to the facade bean from the filter would look something like this
@Component
public class FilterChainExceptionHandler extends OncePerRequestFilter {

    private final ErrorHandlingFacade errorHandlingFacade;
    private final ObjectMapper objectMapper;

    public FilterChainExceptionHandler(ErrorHandlingFacade errorHandlingFacade, ObjectMapper objectMapper) {
        this.errorHandlingFacade = errorHandlingFacade;
        this.objectMapper = objectMapper;
    }

    @Override
    protected void doFilterInternal(HttpServletRequest request, HttpServletResponse response, FilterChain filterChain)
        throws ServletException, IOException {

        try {
            filterChain.doFilter(request, response);

        } catch (Exception ex) {
            // TODO: replace the line below with logic that figures out from the configuration whether we should handle ex
            boolean isHandledException = true;

            if (isHandledException) {
                var responseEntity = errorHandlingFacade.handleException(ex);
                response.setStatus(responseEntity.getStatusCode().value());
                var jsonResponseBody = objectMapper.writeValueAsString(responseEntity.getBody());
                response.getWriter().write(jsonResponseBody);

            } else {
                throw ex;
            }
        }
    }
}

Delegating from the @ControllerAdvice to the facade bean would be as simple as:
@ControllerAdvice(annotations = RestController.class)
@ConditionalOnWebApplication(type = ConditionalOnWebApplication.Type.SERVLET)
public class ErrorHandlingControllerAdvice {
    private final ErrorHandlingFacade errorHandlingFacade;

    public ErrorHandlingControllerAdvice(ErrorHandlingFacade errorHandlingFacade) {
        this.errorHandlingFacade = errorHandlingFacade;
    }

    @ExceptionHandler
    public ResponseEntity<ApiErrorResponse> handleException(Throwable exception, WebRequest webRequest, Locale locale) {
        return errorHandlingFacade.handleException(exception);
    }
}

Thank you for this. I have now created a branch with a commit that implements this. Can you take a look and tell me your thoughts? If ok, I will add some documentation on it and merge it into the library. See https://github.com/wimdeblauwe/error-handling-spring-boot-starter/commit/f717389172199103fa363e95337ab59ba35eba90

@wimdeblauwe Looks good, but I think you might have missed something (or maybe I did)

4.3.0 is now released: https://github.com/wimdeblauwe/error-handling-spring-boot-starter/releases/tag/4.3.0

@wimdeblauwe I upgraded to the new version, and it works like a charm. Thanks very much!


fix: prevent duplicating template with same name

Make a quick fix before releasing 2.0 to prevent users from accidentally creating thousands of templates.

coverage: 96.403% (-0.003%) from 96.406%
when pulling c1cb8b4a218d4320dfeaf41f8fa1d442ec7afce5 on Tomas2D:0-fix-template-load
into 6c9a4886d38e8bb9defb9dc7f7616c7b9916eede on IBM:main.


Build failure ../go/src/github.com/kubernetes-incubator/bootkube/pkg/asset/tls.go:216: etcdServers[i].Hostname undefined (type *url.URL has no field or method Hostname)

I got this failure with 0.5 and master
../go/src/github.com/kubernetes-incubator/bootkube/pkg/asset/tls.go:216: etcdServers[i].Hostname undefined (type *url.URL has no field or method Hostname)

@f0 what version of go are you using? We are only testing against go v1.8.x.

@aaronlevy   works with 1.8, thx


Worona phyton not found

hello I am newbie here , I got some error from compiling the project in cmd it said "phyton not found" somebody here can solve it?

Hello @neroshin where are you getting that error?

I run in powershell , should it need a phyton?

Hello again @neroshin, are you following our documentation?  https://docs.worona.org/dashboard/publish/do-it-yourself.html
You don't need to compile anything on your computer. You have to use Phonegap build instead.

I'm getting cofused @Poliuk ,how can I use the worona dashboard open source , It should be run in phonegap?

@neroshin you don't need to install it on your servers, you can just use our online dashboard. It's free :)
If you have more doubts about his please send us an email to<EMAIL_ADDRESS>


Warning: Failed prop type: The prop options is marked as required in Picker, but its value is undefined.

Hi!
I'm trying to reproduce your examples (here), but I always found the same problem
Warning: Failed prop type: Invalid prop `value` supplied to `Picker`.
Warning: Failed prop type: The prop `options` is marked as required in `Picker`, but its value is `undefined`.

Here is my code. I've tried to encapsulate your demo in a component, but no success
export class YearMonthPicker extends React.Component {

    constructor(props) {
        super(props);
        this.handleRangeChange = this.handleRangeChange.bind(this);
        this.handleRangeDismiss = this.handleRangeDismiss.bind(this);
        this.handleAMonthChange = this.handleAMonthChange.bind(this);
        this.handleAMonthDismiss = this.handleAMonthDismiss.bind(this);
        this.handleClickMonthBox = this.handleClickMonthBox.bind(this);
        this.handleClickRangeBox = this.handleClickRangeBox.bind(this);
        this.state = {
            mvalue: {year: 2013, month: 11}
        };
    }

    handleRangeChange () {
    }
    handleRangeDismiss () {
    }
    handleAMonthChange () {
    }
    handleAMonthDismiss () {
    }
    handleClickMonthBox () {
    }
    handleClickRangeBox () {
    }

    render() {

        let pickerLang = {
                months: ['Jan', 'Feb', 'Mar', 'Spr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec']
                , from: 'From', to: 'To'
            };

        let makeText = m => {
            if (m && m.year && m.month) return (pickerLang.months[m.month - 1] + '. ' + m.year);
            return '?';
        };

        return (

                    Pick A Month

                        <Picker
                            ref="pickAMonth"
                            years={[2008, 2011, 2012, 2014, 2016]}
                            value={this.state.mvalue}
                            lang={pickerLang.months}
                            onChange={this.handleAMonthChange()}
                            onDismiss={this.handleAMonthDismiss()}
                        >
                            <MonthBox value={makeText(mvalue)} onClick={this.handleClickMonthBox()} />
                        </Picker>

                    Pick A Span of Months

        )
    }
}

Can somebody please point me to the rigth direction? What's wrong? I'm supplying a value (or not?)
I've tried also passing a moment() value or something like that. Still invalid... :(
Thanks in advance

Without your complete sourcecodes, it's hard to tell what's the problem.
I made an independent test pack for you.
https://raw.githubusercontent.com/nickeljew/react-month-picker/master/examples/test-pack.zip
You can download and try it by yourself.
Please:

run 'yarn' or 'npm install' under the test-pack folder
run 'grunt' to build the demo.js and demo.css files
open demo.html in browser to try the demo
remove or change codes in demo.jsx and rebuild and retry it, I believe you will find out.

I had the same issue. @dtodo1paco had probably installed a wrong package, since in the README it is written to install react-picker instead of react-month-picker.

Jesus! It's my bad.... Sorry.
Already updated a new version to correct the typo.


Move origin validiation to validate function

Related with https://github.com/safe-global/safe-transaction-service/pull/1177#discussion_r1035941612

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.88%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6337

Relevant Lines:
7211

💛  - Coveralls

I would prefer a separate validate_origin function
I didn't in a separated function because is going to be called only in one place. I mean, is not being reusable.

I didn't in a separated function because is going to be called only in one place. I mean, is not being reusable.

I'm not taking about clean code 😉 , I'm talking about how Django REST serializers work: https://www.django-rest-framework.org/api-guide/serializers/#field-level-validation . We should only add validations in validate when they depend on another fields, else they should go in their own functions so validation is more clear

I didn't in a separated function because is going to be called only in one place. I mean, is not being reusable.

I'm not taking about clean code wink , I'm talking about how Django REST serializers work: https://www.django-rest-framework.org/api-guide/serializers/#field-level-validation . We should only add validations in validate (object level validation) when they depend on another fields, else they should go in their own functions so validation is more clear (field level validation)

Done here


DSP48E1 multiply functionality being optimized out by Yosys passes

This issue is related to PR #427.
In the simulation model of DSP48E1, there is a segment of code that deals with multiplier functionality
...
    assign mult_o = ((USE_MULT == NONE_ENUM_VAL) || (USE_SIMD != ONE48_ENUM_VAL)) ? 43'b0 :
                    (carryinsel_in == 3'b010) ? 43'b0 :
                    {{18{ad_mult[24]}}, ad_mult[24:0]} * {{25{b_mult[17]}}, b_mult};
...

Here, we can see that mult_o, the output of the multiplier is set depending on the values of certain ports on the DSP, namely USE_MULT and USE_SIMD. This makes sense, as DSP48E1 does not provide functionality when using two or four line simd, and the multiplier is directly turned off when USE_MULT is set to "NONE".
However, the series of Yosys passes we perform to obtain bitvector semantics are simplifying the top-level ternary to being always true. This means that mult_o is being set to 0 always, and the multiplier semantics are left out of the DSP's final racket semantics.
The Yosys pass that is doing this optimization is during the prep pass, specifically the proc subpass within. During this pass,
Yosys performs the opt_expr optimization, which causes our issue.
An exact replication of the issue can be performed with the following minimum command to replicate behavior
yosys -p "read_verilog -sv lakeroad-private/DSP48E1/DSP48E1.v; hierarchy -simcheck -top DSP48E1; debug opt_expr; write_verilog output/tmpoutput.sv" > output.log.
The tmpoutput.sv verilog file shows that mult_o is assigned to 0, rather than a ternary between 0 and a multiplier as it should be.
The output.log file gives a log of the actions performed by the opt_expr pass, with debug messages unsuppressed.
I think the relevant logging info in output.log is the following, but I have yet to fully figure out the root cause.
...
Replacing $eq cell `$eq$lakeroad-private/DSP48E1/DSP48E1.v:1171$102' (isneq) in module `\DSP48E1' with constant driver `$eq$lakeroad-private/DSP48E1/DSP48E1.v:1171$102_Y = 1'0'.
Replacing $ne cell `$ne$lakeroad-private/DSP48E1/DSP48E1.v:1171$103' (isneq) in module `\DSP48E1' with constant driver `$ne$lakeroad-private/DSP48E1/DSP48E1.v:1171$103_Y = 1'1'.
Replacing $logic_or cell `$logic_or$lakeroad-private/DSP48E1/DSP48E1.v:1171$104' (const_or) in module `\DSP48E1' with constant driver `$logic_or$lakeroad-private/DSP48E1/DSP48E1.v:1171$104_Y = 1'1'.
Replacing $mux cell `$ternary$lakeroad-private/DSP48E1/DSP48E1.v:1171$106' (1) in module `\DSP48E1' with constant driver `$ternary$lakeroad-private/DSP48E1/DSP48E1.v:1171$106_Y = 43'0000000000000000000000000000000000000000000'.
...

Fixed, the issue I was running into was that I had not changed the bitwidth of USE_SIMD or USE_MULT. This meant that the only vlaues of the enum that worked were 1 bit values, like NONE_ENUM_VAL, which expectedly meant that USE_SIMD could never be ONE48 and thus was simplified to just true. Thank you to Yosys team for help on this.


Update markdown documents

LLM-Assisted Editing Enhancement
To make the most of your modifications or further developments, it's advisable to use the specific branch from which this Pull Request (PR) originates. This will ensure you have a solid and up-to-date foundation for your tweaks and enhancements.
Using Markdown LLM Corrector.

/run pipeline

:tada: This PR is included in version 1.6.1 :tada:
The release is available on:

GitHub release
v1.6.1

Your semantic-release bot :package::rocket:


Update README.MD

Added link to Turbo-C source site and mention of errata.txt

Merge PR by FredJScipione


servicemonitor for multiple hosts?

Hey guys, does anyone know what the servicemonitor for use with prometheus operator would look like, i've tried the following but with no success:
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  annotations:
    td/managed-by: flux
  labels:
    prometheus: k8s
  name: thdks-prometheus-vmware-exporter-svcmon1
  namespace: vmware-exporter
spec:
  endpoints:
  - honorLabels: true
    interval: 30s
    path: /metrics
    port: http
    scrapeTimeout: 30s
    params:
      target:
       - default
       - host2
    metricRelabelings:
      - sourceLabels: [__address__]
        targetLabel: __param_target
      - sourceLabels: [__param_target]
        targetLabel: instance
  jobLabel: thdks-vmware-exporter
  selector:
    matchLabels:
      app: vmware-exporter
      release: vmware-exporter

This isn't working at all, i'm assuming because it's not utilizing section when calling the exporter itself.

i cannot add multiple section, just only receive default section

i cannot add multiple section, just only receive default section

Hey guys, does anyone know what the servicemonitor for use with prometheus operator would look like, i've tried the following but with no success:
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  annotations:
    td/managed-by: flux
  labels:
    prometheus: k8s
  name: thdks-prometheus-vmware-exporter-svcmon1
  namespace: vmware-exporter
spec:
  endpoints:
  - honorLabels: true
    interval: 30s
    path: /metrics
    port: http
    scrapeTimeout: 30s
    params:
      target:
       - default
       - host2
    metricRelabelings:
      - sourceLabels: [__address__]
        targetLabel: __param_target
      - sourceLabels: [__param_target]
        targetLabel: instance
  jobLabel: thdks-vmware-exporter
  selector:
    matchLabels:
      app: vmware-exporter
      release: vmware-exporter

This isn't working at all, i'm assuming because it's not utilizing section when calling the exporter itself.

use /metrics?section=xxx
and
- source_labels: [__address__]
      target_label: __param_section
      replacement: <IP_ADDRESS>


Apply Wallace's patches

See original PRs for history:

https://github.com/digital-asset/daml/pull/16127
https://github.com/digital-asset/daml/pull/16146
https://github.com/digital-asset/daml/pull/16236

cc @wallacekelly-da

@digital-asset/daml-docs Can I get a stamp on this? All changes have been approved on the daml side already.


Auto-create cert-manager namespace as part of bootstrap install

Details
Recent changes to /cluster/core and moving cert-manager to /cluster/apps have made it necessary to manually create the cert-manager namespace. Ideally the configure script would do this automatically.
Anything else you would like to add:
task: [cluster:kustomizations] kubectl get kustomizations -A
Output (selected):

NAMESPACE
NAME
AGE
READY
STATUS

flux-system
apps
55m
False
dependency 'flux-system/core' is not ready

flux-system
charts
55m
True
Applied revision: main/...

flux-system
config
55m
True
Applied revision: main/...

flux-system
core
55m
False
Secret/cert-manager/cloudflare-api-key namespacenot specified, error: namespace "cert-manager" not found

flux-system
crds
55m
True
Applied revision: main/...

flux-system
flux-cluster
55m
True
Applied revision: main/...

flux-system
flux-installation
55m
True
Applied revision: v0.31.1/...

flux-system
traefik-crds
55m
True
Applied revision: v10.21.1/...

Additional Information:
None.

Issue resolved in upstream project by moving cert-manager to kube-system namespace. I have taken the same approach.


Implement GitHub Actions Workflow to create GitHub Releases and scaffold Release Notes

https://goreleaser.com/customization/templates/?h=go+template

query {
  search(type: ISSUE, first: 100, query: "is:pr is:closed milestone:v3.13.0 repo:aquaproj/aqua-registry") {
    issueCount
    nodes {
      ... on PullRequest {
        number
      }
    }
  }
}


[TextField] cannot customize outlined input label font size

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When increasing the font size of the Outlined Input Form labels, the notched outline that renders by default for all TextFields doesn't accommodate for the increased label width.

Expected Behavior 🤔

I would expected the notched outline to not strike through any part of the label (i.e. the input border should give enough left and right padding to the label).
Steps to Reproduce 🕹

Use <TextField /> defaults and increase the font-size of the label with CSS
Steps:

Code Sandbox - https://codesandbox.io/s/formattedinputs-material-demo-forked-sozwt

Context 🔦

I am trying to customize the font size of all labels as part of the MUI theme for my react app.
Your Environment 🌎

`npx @material-ui/envinfo`
System:
    OS: macOS Mojave 10.14.6
  Binaries:
    Node: 10.23.0 - ~/.nvm/versions/node/v10.23.0/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v10.23.0/bin/npm
  Browsers:
    Chrome: 89.0.4389.114
  npmPackages:
    @emotion/react: ^11.1.5 => 11.1.5
    @emotion/styled: ^11.1.5 => 11.1.5
    @material-ui/core: ^5.0.0-alpha.29 => 5.0.0-alpha.29
    @material-ui/styled-engine:  5.0.0-alpha.25
    @material-ui/styles:  5.0.0-alpha.29
    @material-ui/system:  5.0.0-alpha.29
    @material-ui/types:  5.1.7
    @material-ui/unstyled:  5.0.0-alpha.29
    @material-ui/utils:  5.0.0-alpha.29
    @types/react: ^17.0.2 => 17.0.2
    react: ^17.0.1 => 17.0.1
    react-dom: ^17.0.1 => 17.0.1
    typescript: ^4.1.5 => 4.1.5

You need to use the same font-size for the input too. See https://codesandbox.io/s/formattedinputs-material-demo-forked-87984?file=/demo.tsx


Set content-disposition for video download and transcript files

Currently clicking the Download Video button causes the video to open in a new tab in Firefox (but not Chrome). This should be fixed by setting the Content-Disposition for course video files on AWS.
Similarly transcript files should also download instead of opening in a tab

@abeglova what's that status of this?


doc: Fix documentation about n-gram overlap

This commit fixes the documentation about n-gram overlap that unrelated variables are declared.
Replace this entire comment with:

Description: Fix the documentation in https://python.langchain.com/docs/modules/model_io/prompts/example_selectors/ngram_overlap. It's currently declaring unrelated variables, for example, examples local variable is declared twice and the first one is overwritten immediately.
Issue: N/A
Dependencies: N/A
Tag maintainer: for a quicker response, tag the relevant maintainer (see below),
Twitter handle: @dosuken123

Please make sure your PR is passing linting and testing before submitting. Run make format, make lint and make test to check this locally.
See contribution guidelines for more information on how to write/run tests, lint, etc:
https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md
If you're adding a new integration, please include:

a test for the integration, preferably unit tests that do not rely on network access,
an example notebook showing its use. It lives in docs/extras directory.

If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17.

@baskaryan Hi 👋 Would you mind reviewing this change, please? TIA!

thanks @dosuken123!


[release/1.3] Catch up vndr with state of vendor/ dir

Due to a temporarily broken containerd/project script the vendor dir
was slightly out of state with what it should have been after the
last runc vendor update.
Signed-off-by: Phil Estes<EMAIL_ADDRESS>

Codecov Report

Merging #3772 into release/1.3 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/1.3    #3772   +/-   ##
============================================
  Coverage        45.59%   45.59%
============================================
  Files              116      116
  Lines            11463    11463
============================================
  Hits              5227     5227
  Misses            5336     5336
  Partials           900      900

Flag
Coverage Δ

#linux
45.59% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa98dc6...0336121. Read the comment docs.


Improve the output message when no config/flags/env variables specified

Currently if I don't use a profile or export env variables, we get a generic error:
"PROPERTYVALUE
error	Error creating ProviderClient: You must supply a Username in your AuthOptions."
I think at a minimum the error should be more friendly. In the bigger picture, this ties into whether a "default' profile (and/or the only defined profile if there is one) should be consumed by default when a profile isn't specified. It feels a little weird to use configure to make a config file, but then have to specify it all of the time with the --profile flag if it's the only one you're using. We could either hint in the configure process about using Default, or make it dummy proof by automatically consuming the profile if there is only a single profile saved. Actually both are probably good ideas. (Says the guy who suggested them.)

The error could be improved, but this isn't a bug. A username is required, whether it comes from the command-line, the config file, or the environment variable. Not specifying a profile will use the default profile if it exists. If creating a config file with rack configure, leaving the profile name blank will correctly create the default profile. I think using a named profile that isn't explicitly defined with the profile flag is counterintuitive.

I agree at the very least it's just an ask to improve the error, thus
enhancement not bug. The rest is merely opinionated speculation on my part
:)
On Thursday, June 18, 2015, jrperritt<EMAIL_ADDRESS>wrote:

The error could be improved, but this isn't a bug. A username is required,
whether it comes from the command-line, the config file, or the environment
variable. Not specifying a profile will use the default profile if it
exists. If creating a config file with rack configure, leaving the
profile name blank will correctly create the default profile. I think using
a named profile that isn't explicitly defined with the profile flag is
counterintuitive.
—
Reply to this email directly or view it on GitHub
https://github.com/jrperritt/rack/issues/84#issuecomment-113267074.

I think you're right though that the rack configure introduction should better explain how profiles work.

I think we should re-title this issue, or create a different issue to track pretty formatting of expected errors.
Thoughts?

Here's my rough suggestion on improving this output:
"Error: Rackspace Cloud credentials are required, and you haven’t created a config file,  exported any environment variables, or specified them on the command line. You can fix this by

running 'rack config' to create a configuration file
specify the credentials in the command using --user, --apikey and --region
export the required environment variables:
VAR1
VAR2
etc.

"

I like @rtgoodwin's suggested message. Bonus would be if we let them know which they're missing if we have some of the environment variables (or some of the config).

Actually, Gophercloud already let's us know:
"PROPERTYVALUE
error Error creating ProviderClient: You must supply a Username in your AuthOptions."

The only question is whether we create a hack to grep for the parts we want (like "Username") or do it correctly and implement error types in and return error types from in Gophercloud.

Can the client not check for presence of flags/file/bars on its own? It
doesn't seem that gopher cloud would want to absorb these changes that are
specific to the CLI?
On Tuesday, June 23, 2015, jrperritt<EMAIL_ADDRESS>wrote:

Actually, Gophercloud already let's us know:
"PROPERTYVALUE
error Error creating ProviderClient: You must supply a Username in your AuthOptions."
The only question is whether we create a hack to grep for the parts we
want (like "Username") or do it correctly and implement error types in and
return error types from in Gophercloud.
—
Reply to this email directly or view it on GitHub
https://github.com/jrperritt/rack/issues/84#issuecomment-114595393.


Extended stake pool operator resources overview.md

I recently uploaded my personal cheatsheet on my staking pool's GitHub repository to help other staking pool operators to quickly setup a Cardano node using CNTools. This guide includes useful commands to enhance security and stability with 2FA, SSH, Firewall rules, backups with snapshots, synchronization, IP banning, etc. I also configured simple navigation links to improve the user experience when going through the guide. This might be specially interesting for SPOs who seek to reduce operation costs or to improve their decentralization by migrating their Cardano nodes to private servers or to smaller and more local data centers. We know that this process normally requires to setup the nodes from scratch and most guides aren't quite summarized. I hope the community considers this resource to be included in the staking pool section of the developer portal.
👋👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.

Select one of the templates below that fits your contribution
Remove this text as well as the other templates
Fill in all sections of the template
Summon a reviewr using @mentions (optional)
Click "Create pull request"

Showcase addition

Name: Project name
Description: Describe your project (See Showcase guidelines)
Link:   <link_to_project>
Source: <link_to_source_code>
Tags:

analytics
explorer
educational
game
gateway
opensource
pooltool
metadata
nativetoken
nft
wallet

Updating documentation
Issue
Fixes #issueId

Description of the change

Bugfix
Fixes #issueId

Description

Quickfix

Thanks for your PR.
IMO - pointing to a md file with steps is better served by contributing/integrating to Operate a Stake Pool  section of the portal. The underlying tools and steps are to an extent already covered by points above the section

we could really use a helping hand in the stake pool operator category right now :))

@rdlrt @katomm Thank you for your reply! I thought this Cheatsheet would be a good adition to the resources, specially because the "Choose security over comfort" section just links the readers to the Cardano Forum and to a page where the Cardano keys pairs are explained. My original cheatsheet (in PDF format) was well received by other SPOs in the Cardano Forum because it summarizes quite a lot of important commands and makes the whole setting up process more convenient and easier. Therefore, I decided to create a md version on GitHuB to improve the copy-paste experience of commands as well. I'd also love to colaborate if you currently need some support with this category!

I'm closing this as we are now in contact in Discord.


ovn: improve OVN tutorial.

Improve the tutorial of the basic OVN features. Update the contents of
the "Locally attached networks" and "Locally attached networks with VLANs"
in detail. The logical ports of type "l2gateway" is described.
Signed-off-by: nickcooper-zhangtonghao<EMAIL_ADDRESS>

Thanks for the patch.
The patch introduces some trailing whitespace in OVN-Tutorial.md.  Can you remove that?
env8/setup.sh includes:
ovn-nbctl lsp-set-options sw0-port3 l2gateway-chassis=56b18105-5706-46ef-80c4-ff20979ab068 network_name=physnet1
That UUID will be different each time the sandbox is used.  It should dynamically figure out the chassis UUID, instead.
The updates to the localnet sections are good.  A further improvement would be to simplify these, because a separate lswitch per port connected to the network is no logner required.  A single lswitch with a localnet port and N other regular ports is fine.
Finally, I would update the new section clarifying the major difference between localnet and l2gateway ports.

Thanks.
Some trailing whitespace has been removed in OVN-Tutorial.
env8/setup.sh includes:
ovn-nbctl lsp-set-options sw0-port3 l2gateway-chassis=56b18105-5706-46ef-80c4-ff20979ab068 network_name=physnet1
That UUID will be always the same, because the sandbox assigns the same UUID to this chassis via
"ovs-vsctl set open . external-ids:system-id=56b18105-5706-46ef-80c4-ff20979ab068".

I would squash the 2 commits into 1, but I can do that locally before pushing.

I made the following tweaks and applied this to master.  Thanks!
`diff --git a/tutorial/OVN-Tutorial.md b/tutorial/OVN-Tutorial.md
index 5c67b2e..a1fff0b 100644
--- a/tutorial/OVN-Tutorial.md
+++ b/tutorial/OVN-Tutorial.md
@@ -957,7 +957,10 @@ hypervisors. Please see the tutorial 3 above.
L2Gateway provides a way to connect logical switch ports of type l2gateway to
-a physical network.
+a physical network.  The difference between l2gateway ports and localnet ports
+is that an l2gateway port is bound to a specific chassis.  A single chassis
+serves as the L2 gateway to the physical network and all traffic between
+chassis continues to go over geneve tunnels.
Start with a simple logical switch with 3 logical ports.
diff --git a/tutorial/ovn/env8/setup.sh b/tutorial/ovn/env8/setup.sh
index d2b406c..2bb05ff 100755
--- a/tutorial/ovn/env8/setup.sh
+++ b/tutorial/ovn/env8/setup.sh
@@ -40,6 +40,7 @@ ovs-vsctl add-port br-int lport2 -- set Interface lport2 external_ids:iface-id=s
ovn-nbctl lsp-add sw0 sw0-port3
ovn-nbctl lsp-set-addresses sw0-port3 unknown
ovn-nbctl lsp-set-type sw0-port3 l2gateway
+# The chassis UUID is hard-coded in tutorial/ovs-sandbox.
ovn-nbctl lsp-set-options sw0-port3 l2gateway-chassis=56b18105-5706-46ef-80c4-ff20979ab068 network_name=physnet1
ovs-vsctl --may-exist add-br br-eth1
`


melengedanges

melengedanges created by<EMAIL_ADDRESS>on 2017-04-20 16:08:39

<EMAIL_ADDRESS>replied, Adidil eng kebesengei, me te mocha doraib ar bek el chad e ngak a sabisii el melengedanges a mlai e diak a ngosukak.
Is this some variation on "meleng" (borrow)? Â Whatever it means, this dude is seriously left out of the fun! Â Everybody's cruisin' the town except him.

<EMAIL_ADDRESS>replied, Melngedanges a mlai: melngedanges a buuch: melngedanges a lius. Dmanges: looking upward.

<EMAIL_ADDRESS>replied, checking for a ride, checking for a buuch.

<EMAIL_ADDRESS>replied, To my understanding, with respect to betel nut, melngedanges is while
you're walking around and looking up to see if there are nuts. Then the
other form is when you're just sitting (or doing whatever) but you keep
looking, literally or figuratively,  to see if a ride (or someone) will
show up. There's some hope or expectation involved.
For example, I told an Aunt of mine once that I would stop by, then I was
running late. When I showed up later in the afternoon she said, "Ngak tia
rak dengchokl el kora di melngedanges le kikedel ra om call." And she just
meant she had been sitting just waiting because it had been a while since I
called.
Thanks! And good morning! :)

<EMAIL_ADDRESS>replied, Great discussion. Â I've fixed my rather hopeful but misguided translation for the word in the song translation.
So how are melengedanges and melanges different? Â
On Monday, April 24, 2017 6:41 AM, Jelga Emiwo (Debugle<EMAIL_ADDRESS>wrote:

Emails/html
|
|  --- Write ABOVE THIS LINE to reply ---
Jelga Emiwo posted a new comment on melengedanges :
To my understanding, with respect to betel nut, melngedanges is whileyou're walking around and looking up to see if there are nuts. Then theother form is when you're just sitting (or doing whatever) but you keeplooking, literally or figuratively, to see if a ride (or someone) willshow up. There's some hope or expectation involved.For example, I told an Aunt of mine once that I would stop by, then I wasrunning late. When I showed up later in the afternoon she said, "Ngak tiarak dengchokl el kora di melngedanges le kikedel ra om call." And she justmeant she had been sitting just waiting because it had been a while since Icalled.Thanks! And good morning! :) View this on DebugleStop receiving email notifications about this item.  |
|

<EMAIL_ADDRESS>replied, Generally I'd say they are different in the normal way that standard verb
forms are different from their reduplicated forms which is that the
reduplicated forms suggest that the person keeps doing the action
repeatedly.  But I'm curious to hear what our Palauan friends say.
Joseph talks a lot about reduplication in Chapter 11:
http://tekinged.com/books/handbook1.php

<EMAIL_ADDRESS>replied, I think it's a variation of time spent doing it and how it's done.
Melanges-to look up to check betel nut or look up to see a person's face
because he's taller than you. Melengelanges - walking around the yard
looking up at all the betel nut trees; it's continuous.
The same is seen in several words such as melim (drink) and melmelim which
could be nursing a drink, drinking slowly, sipping.
Or, merdekekl (jump) and merdedekekl which is jump around or continue to
jump.
J

<EMAIL_ADDRESS>replied, I guess my question has to do with the component of waiting or expectation in the definition. Â Melengedanges a buuch or melengedanges a lius incorporates both looking up and waiting/checking (until/to see if the fruit is ready for picking). Â Maybe that's where the reduplication comes in -- keep looking up, over and over, until you see it is ready. Â Is the "waiting" component a part of melanges? Â Or just simplying looking up?
On Monday, April 24, 2017 10:06 AM, Jelga Emiwo (Debugle<EMAIL_ADDRESS>wrote:

Emails/html
|
|  --- Write ABOVE THIS LINE to reply ---
Jelga Emiwo posted a new comment on melengedanges :
I think it's a variation of time spent doing it and how it's done.Melanges-to look up to check betel nut or look up to see a person's facebecause he's taller than you. Melengelanges - walking around the yardlooking up at all the betel nut trees; it's continuous.The same is seen in several words such as melim (drink) and melmelim whichcould be nursing a drink, drinking slowly, sipping.Or, merdekekl (jump) and merdedekekl which is jump around or continue tojump.J View this on DebugleStop receiving email notifications about this item.  |
|

<EMAIL_ADDRESS>replied, The waiting component is present only for "melngelanges a mlai" (or when
expecting someone like in the example with my Aunt) but not for betel nut
(or a tall person). For the latter, it simply means to look up.
Hope that helped.
J

<EMAIL_ADDRESS>replied, Thanks!
On Monday, April 24, 2017 10:24 AM, Jelga Emiwo (Debugle<EMAIL_ADDRESS>wrote:

Emails/html
|
|  --- Write ABOVE THIS LINE to reply ---
Jelga Emiwo posted a new comment on melengedanges :
The waiting component is present only for "melngelanges a mlai" (or whenexpecting someone like in the example with my Aunt) but not for betel nut(or a tall person). For the latter, it simply means to look up.Hope that helped.J View this on DebugleStop receiving email notifications about this item.  |
|


Add support for zsh and Ubuntu

@pose I took your PR and ran with it a bit. I made a few more tweaks to get everything working on Ubuntu. Plus you can also run everything in a Vagrant VM (via the provided Vagrantfile and provisioning scripts) that has all the necessary tools.
Please review merge if everything works on your end.

@twistedstream reviewed and tested. Thanks!


Can we set a consumer timeout?

Hello, I read that the default ack timeout for rabbitmq is 30 minutes.
So I want to adjust this. Is go-rabbitmq able to set a consumer ack timeout?

It works since 0.7.2


ECID fixed on 13.3 iPhone XR

As of version 4.3.1 ECID has been fixed
Describe the bug
A clear and concise description of what the bug is and what you expected to happen.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots
If applicable, add screenshots to help explain your problem.
Device (please complete the following information):

iOS Version: 13.3
iOS Device: xr
unc0ver Version: 4.3.1

Place an "x" between the brackets if true:

[ ] this is a bug others will be able to reproduce
[ x] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ x] this issue is present after a rootfs restore
[ ] this issue is present on the latest version of unc0ver

Logs
If applicable, add logs or error messages here.

I know it doesn’t seem like a big deal but if it’s showing 0x0 it does cause problems


Update readme - non-installed packages.

The latest version does not install the following packages:

ocamlrun
ocamlc/ocamlopt
ocamlfind

I decided to keep them there and rather add a note, since maybe the intension is to add them back at some point in future versions? Let me know, I can remove them from the list too.

Thank you. The intent is not to add them back because they step over other peoples' brew installs of them etc and it's hard for them to repair. Can you remove them completely?

@jordwalke Done. No problem :)

Hi there, can we close this issue out?

Yes, this isn't relevant anymore :+1:


Can i be able to differentiate between .xlsm and .xlsx files using mmmagic ?

i am trying to upload files and as the magic numbers of both .xlsm and .xlsx is same when i try to use this code
  let magic = new Magic(MAGIC_MIME_TYPE);
 magic.detectFile(fileLocation, (err, mimeType) => {
 if (err) throw err;
 console.log(mimeType);

 })

here if i upload a .xlsm file i get mime type as  application/vnd.openxmlformats-officedocument.spreadsheetml.sheet which is same as for .xlsx file-type where as it should be application/vnd.ms-excel.sheet.macroEnabled.12.
same is the case with .ppsm (getting mime type of .ppsx) and .docm (getting mime type of .docx)
is there a way to identify macro enabled files using this package in any way ?

That's entirely dependent upon whatever magic database you're using.


error plotting band structure

Hi. I am trying to plot band structure on SUMO. I have a kpoints file and a vasprun.xml which worked fine for plotting dos yet when I go to plot band structure I get this error. Could anyone explain it to me please?
Traceback (most recent call last):
File "/home/cmtg/.local/bin/sumo-bandplot", line 8, in
sys.exit(main())
File "/home/cmtg/.local/lib/python3.8/site-packages/sumo/cli/bandplot.py", line 886, in main
bandplot(
File "/home/cmtg/.local/lib/python3.8/site-packages/sumo/cli/bandplot.py", line 298, in bandplot
bs = vr.get_band_structure(line_mode=True)
File "/home/cmtg/.local/lib/python3.8/site-packages/pymatgen/io/vasp/outputs.py", line 958, in get_band_structure
if "" in kpoint_file.labels:
TypeError: argument of type 'NoneType' is not iterable

Was the KPOINTS file created using sumo-kgen? Does it include the symmetry labels?

I just created a KPOINTS file myself. It looks like this:
Regular mesh centered at Gamma (better forces)
0
Gamma
12 12 5
that's all I have. That and a vasprun.xml file

That's not a suitable KPOINTS for a band structure diagram, it's a regular sampling mesh for a DOS.
You need to use sumo-kgen to create an appropriate KPOINTS file and run a non-self-consistent calculation using the density from the DOS calculation.

Hi @oisin67 did you manage to do a full band structure calculation and plot it?


When Invoke-Expression wrapped in function then Import-Module leads to weird variable scope leaking

Hello!
During debugging legacy code I faced with weird behaviour.
I have a module without Export-ModuleMember statements. And two nested invoked scripts. And it occurs that variables defined in imported module are not available in script imported the module - this is ok, because no Export-ModuleMember . But! but these variables become visible in next nested script! And even after I imported one more module there with redefining variables with same name. And again, imported module variables become visible in one more nested invoked script 🤔
But the main point that this is a case only when I wrapped Invoke-Expression command into function, which resides in that imported module.
Steps to reproduce
How to reproduce - download enclosed files into folder and run
& {.\MainScript.ps1}. This will results in what shown in Actual behavior part - unexported (leaked) variable $WAT1 is visible from nested scripts scope (btw it does not have (Get-Variable WAT1).Module property value!). But it should not be visible, since it is not exported from the module.
ImportModuleScopeLeakExample.zip
MainScript.ps1

Import-Module -Name ${PSScriptRoot}\ModuleTEST_wo_Export_1.psm1 -Force

try {
    Get-Variable WAT1 -ErrorAction Stop
    Write-Host "I don't want to read that line, must be alredy catched due to error in previous line." -ForegroundColor Red
}
catch [System.Management.Automation.ItemNotFoundException] {
    Write-Host "I awaits this catch, cause WAT1 is not exported."
}

Write-Host "Here WAT1 should not be visible here $WAT1 ***"

invoke-exp -scriptfile  "${PSScriptRoot}\Level1ChildScript.ps1"
# Invoke-Expression '.\Level1ChildScript.ps1'

try {
    $(Get-Variable WAT1 -ErrorAction Stop | select Value )
    Write-Host "I don't want to read that line, must be alredy catched due to error in previous line." -ForegroundColor Red
}
catch [System.Management.Automation.ItemNotFoundException] {
    Write-Host "I awaits this catch, cause WAT1 is not exported."
    Write-Host "Still no WAT1 variable awaited here."
}

Level1ChildScript.ps1
Import-Module -Name ${PSScriptRoot}\ModuleTEST_wo_Export_2.psm1 -Force

try {
    Get-Variable WAT1 -ErrorAction Stop
    Write-Host "    I don't want to read that line, must be alredy catched due to error in previous line." -ForegroundColor Red
}
catch [System.Management.Automation.ItemNotFoundException] {
    Write-Host "    I awaits this catch cause WAT1 is not exported."
}
Write-Host "    Here WAT1 should not be visible here - $WAT1 ***"

# Invoke-Expression  ${PSScriptRoot}\Level2ChildScript.ps1
# . ${PSScriptRoot}\Level2ChildScript.ps1

invoke-exp -scriptfile  ${PSScriptRoot}\Level2ChildScript.ps1

try {
    $(Get-Variable WAT1 -ErrorAction Stop | select Value )
    Write-Host "    I don't want to read that line, must be alredy catched due to error in previous line." -ForegroundColor Red
}
catch [System.Management.Automation.ItemNotFoundException] {
    Write-Host "    I awaits this catch, cause WAT1 is not exported."
    Write-Host "    Still no WAT1 variable awaited here."
}

Level2ChildScript.ps1

try {
    Get-Variable WAT1 -ErrorAction Stop
    Write-Host "        I don't want to read that line, must be alredy catched due to error in previous line." -ForegroundColor Red
}
catch [ItemNotFoundException] {
    Write-Host "        I awaits this catch cause WAT1 is not exported."
}
Write-Host "        Here WAT1 should not be visible here - $WAT1 ***"

ModuleTEST_wo_Export_1.psm1
$WAT1 = 'SUPER PUPER ONE FROM MODULE 1!'

function send-message_wait_color(){
	param([string] $functionName)
	write-host "Start processing function:$functionName.."
Here WAT1 should not be visible here  ***
    I awaits this catch cause WAT1 is not exported.
    Here WAT1 should not be visible here -  ***
        I awaits this catch cause WAT1 is not exported.
        Here WAT1 should not be visible here -  ***
    I awaits this catch, cause WAT1 is not exported.
    Still no WAT1 variable awaited here.
I awaits this catch, cause WAT1 is not exported.
Still no WAT1 variable awaited here.

Actual behavior
PS C:\dev\PowerShell\BUG> & {.\MainScript.ps1 }
I awaits this catch, cause WAT1 is not exported.
Here WAT1 should not be visible here  ***
Start processing function:deployment of: C:\dev\PowerShell\BUG\Level1ChildScript.ps1..

Name                           Value
----                           -----
WAT1                           SUPER PUPER ONE FROM MODULE 1!
    I don't want to read that line, must be alredy catched due to error in previous line.
    Here WAT1 should not be visible here - SUPER PUPER ONE FROM MODULE 1! ***
Start processing function:deployment of: C:\dev\PowerShell\BUG\Level2ChildScript.ps1..
WAT1                           SUPER PUPER ONE FROM MODULE 2!
        I don't want to read that line, must be alredy catched due to error in previous line.
        Here WAT1 should not be visible here - SUPER PUPER ONE FROM MODULE 2! ***
deployment of: C:\dev\PowerShell\BUG\Level2ChildScript.ps1 is Done

Value : SUPER PUPER ONE FROM MODULE 1!

    I don't want to read that line, must be alredy catched due to error in previous line.
deployment of: C:\dev\PowerShell\BUG\Level1ChildScript.ps1 is Done
I awaits this catch, cause WAT1 is not exported.
Still no WAT1 variable awaited here.

Environment data

Name                           Value

PSVersion                      7.2.0-preview.1
PSEdition                      Core
GitCommitId                    7.2.0-preview.1
OS                             Microsoft Windows 10.0.17763
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Good! I did my best to reduce it as much as possible :) As for me, it looks a bit cleaner now, what do you think?

Can you confirm if this also demonstrates the issue?
$module1 = New-Module {
    $Internal = 'Module 1'

    function Invoke-Exp {
        param([string] $ScriptFile)
        Invoke-Expression $ScriptFile
    }
}

$module2 = New-Module {
    $Internal = 'Module 2'

    function Invoke-Exp {
        param([string] $ScriptFile)
        Invoke-Expression $ScriptFile
    }
}

Import-Module -ModuleInfo $module1 -Force
"Value is: $Internal"
Invoke-Exp '
    Import-Module -ModuleInfo $module2
    "Value is: $Internal"
    Invoke-Exp ''"Value is: $Internal"''
    "Value is: $Internal"
'

"Value is: $Internal"

Returning:
Value is:
Value is: Module 1
Value is: Module 2
Value is: Module 1
Value is:

Can you confirm if this also demonstrates the issue?

Yes, I confirm this. Looks pretty similar to my case. I thought that to have it in separate files is important.

@daxian-dbw Hi! Could you please remove "Waiting on Author" tag?

Sorry I got caught up with something else.
So this behavior is expected, the Invoke-Expression is running in the scope of the module.  Nothing is actually leaking here, just the expression is being invoked in a scope where the variable is visible.

Wow! Thank you! Now I can see that. Please close the ticket!
I must be careful with all that scope. Seems better not to use module variables in functions at all. All other functions from module will behave similar 🤔 like this
$module1 = New-Module {
    $Internal = 'Module 1'

    function Get-Var {
        param ($name)
        Get-Variable -Name $name -Scope script
    }

    function Invoke-Exp {
        param([string] $ScriptFile)
        Invoke-Expression $ScriptFile
    }
}

$module2 = New-Module {
    $Internal = 'Module 2'
    function Get-Var {
        param ($name)
        Get-Variable -Name $name -Scope script
    }

    function Invoke-Exp {
        param([string] $ScriptFile)
        Invoke-Expression $ScriptFile
    }
}

Import-Module -ModuleInfo $module1 -Force
$Internal = 'Script'
"Var value is: $((Get-Var -name Internal).Value)"
Invoke-Exp '
    Import-Module -ModuleInfo $module2
    "Var value is: $((Get-Var -name Internal).Value)"
    "Var value is: $((Get-Var -name Internal).Value)"
'

"Var value is: $((Get-Var -name Internal).Value)"

Returning:
Var value is: Module 1
Var value is: Module 2
Var value is: Module 2
Var value is: Module 1

Seems better not to use module variables in functions at all.

I'd more recommend avoiding Invoke-Expression tbh.  The scriptblock method of managing callbacks described in this comment avoids all those issues as scriptblocks are bound to the module they're created in.
Invoke-Expression has a lot of other issues as well.  Potential security issues if used with user input, no error/verbose/etc streams, limited $MyInvocation info, no begin or process blocks, and poor performance to name a few.


Per-client forced command

https://github.com/oxy-secure/oxy/commit/bfaef0b569f734187bac602d43920a6b0e18f3a0


fix(async): fix invalid control character

Deploy preview for js-primer ready!
Built with commit 681592a30c186d8fa5f4dd7b4cc4c20dc584c3ee
https://deploy-preview-533--js-primer.netlify.com


Connection pool with multiple hosts

I'm looking for feedback on the connection pool with multiple hosts.
Context:
Having a connection pool connecting to multiple hosts is something pretty nice to have:

It's easier to think with a concrete example. Suppose you have a cluster of 3 machines M1, M2 and M3. Your client C is connected to M1.
Suppose that the connection M1-C goes down, but not the connection M<x>-M<y>
In this case, you could connect C to M2 and everything will work.
RethinkDB is implementing raft, and auto failover will be shipped in the next few months (not sure exactly when). At that time a machine could just disappear, and the cluster will still work fine. It would be bad if the point of failure becomes the driver.

So having the pool connected to multiple server should help a lot.
Implementation:
The implementation I'm working on has the following features:

There is basically a "pool master", and n pools (if you connect to n different servers)/
You can connect to as many hosts as you want with whatever options you want (buffer/size)
If a server goes down, or if the connection client-server is down, its pool will become empty (all the connections will be closed). At that time, the pool is considered not healthy, and all the quotas of connections it has, is spread across the other servers.
So if you have these settings:

M1: buffer=200, max=1000
M2: buffer=80, max=300
M3: buffer=150, max=900

And if M1 goes down, then the settings become:
M2: buffer=`80, max=800
M3: buffer=250, max=1400

The idea behind this behavior is that the driver should keep the same number of connections available/max connections across all the servers to be able to sustain the same workload.

If a server comes back (the pool will try to recreate connection with an exponential back off like it does now), the pool will take back its quotas and things come back to normal.

Queries are still executed with run(). You do not have an explicit access to the pool and you can't specify on which server the query should be sent.

Queries are sent to different servers in a robin hood fashion. Before sending a query to a server, we check that the pool has an available connection. If it doesn't, we'll try to check another server. If no connection is available, we wait for a connection to be freed except if all the pools have errors, in which case we'll reject the query.

Limitations:

You cannot explicitly select a pool - one reasonable use case is to route query directly to the appropriate master but that seems stretched.
You cannot update the servers to which the driver is connecting to on the fly. Should we pull the servers from r.db('rethinkdb').table('server_status')? And let the driver create the pools?

Any thoughts on that?
Site note: As part of this work, I've also fixed #50 by adding reqlite in the tests.

I couldn't understand something:
Considering there is a master pool, so M1, M2 and M3 are under one master pool localized in other server? Or one of them is the master pool (How they know about each other)?
Let me know if this question make senses.

Sorry for the confusion.
What I've called master pool is a class in the driver. It's just the code responsible to decide which connection pool to use.
I also forgot the syntax. It would look like this for now:
var r = require('rethinkdbdash')({
    hosts: [
        {host: "server1_ip", port: 28015},
        {host: "server2_ip", port: 28015},
        {host: "server3_ip", port: 28015},
    ]
})

Maybe servers is better than hosts?

Thanks for the explanation @neumino,
BTW, servers looks good to me, considering that host is a prop. Like hapijs.

So there's a discovery mode (by default true) where the pool will pull data from rethinkdb_status and connect to all hosts in the cluster.
There's a bit of work left:

Properly handle localhost as any machine could be localhost
Handle proxys and similar things (admin?)

Fixed in 2.0.0


Unexpected Behavior when overriding default workspace and source

Description
Attempting to override the default workspace and source in the monosi_project.yml is not successful. When monosi profile is run the overides are removed from the monosi_project.yml file and the default workspace an source are used.
Expected behavior
When monosi profile is run on a project with overrides for workspace and source the specified workspace and source should be used. The monosi_project.yml file should still have the specified workspace and source in it after running monosi profile
Please provide clear and concise description of what you expected to happen.
Steps to reproduce

Add an additional workspace to /.monosi/workspaces.yml as shown below

default:
    sources:
        default:
            type: snowflake
            user: <snowflake_username>
            password: <snowflake_password>
            account: <snowflake_acct>
            warehouse: COMPUTE_WH
            database: SNOWFLAKE_SAMPLE_DATA
testworkspace:
  sources:
        testsource:
            type: postgres
            user: <postgres_username>
            host: <postgres_host>
            port: 5432
            database: <postgres_database_name>
            password: <postgres_password>

Navigate to your monosi project directory and open monosi_project.yml
Add override configurations to the file as shown below

name: monosi-repo
version: 0.0.3
monitor-paths:
- ./monitors
- ./bootstrapped-monitors
workspace: testworkspace
source: testsource

run monosi profile
when it completes navigate to the bootstrapped-monitors directory and run ls you will see that the default snowflake data was used
navigate back to the root directory and open the monosi-project.yml file and you will see the workspace and source overrides are no longer there

Additional context
before running monosi profile

after running monosi profile

Looks like these items were there, but commented, for the most part. This entire section needs to be refactored to common and the parsing specific logic kept in CLI moving forward, but enabling this feature should resolve this bug per PR.
Thanks for the issue contribution!

Closing unless issue persists.


fix(trpc): support running with Zoneless change detection

PR Checklist

pnpm test ran successfully
Tested the trpc-app to work in zoneless change detection including this patch
Closes #1295

What is the new behavior?
Now also the trpc package works, when running in zoneless change detection.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Thanks! @allcontributors add @tobiasegli for code


Discovery response & Collection Information Response needs a fully qualified URL in  element

Currently a discovery response returns just a path without the hostname in the <Address> element.
After discussing on the TAXII mailing list [1], consensus is that the <Address> element should be a fully qualified URL.
@MarkDavidson suggested there could be a django-solo config instance in django-taxii-services which holds a server hostname to use (if specified), or if the value is not specified, the code could attempt to auto-detect the correct value.
Sounds fair to me.

http://making-security-measurable.1364806.n2.nabble.com/TAXII-Discovery-Response-Question-SEC-UNCLASSIFIED-td7586075.html

@ScottyAU
Thank you for opening this issue. This is a bit mucky, but there is some work on using Solo in the logging branch. It has a get_url_base() function [1] that could be leveraged for your purposes. Probably a little more logic would have to be added (in order to be prepared for the site not being configured yet, or having a bad configuration), but this may be a decent starting point.
If that code is wonky and doesn't work right, please don't hesitate to break from it.
Thank you.
-Mark
[1] https://github.com/TAXIIProject/django-taxii-services/blob/logging/taxii_services/models.py#L1753

Thanks @MarkDavidson
I started looking on the weekend.  What I did note was that after making a change to fix the discovery response to return a fully qualifed value for the / element - I then got the same path only type element in a Collection Information Response - so I've added fixing that to this issue too.
Both of these are blocking intergration with Soltra Edge.

Thanks so much for this @jasenj1
This only addresses the discovery response though - not the collection management response...
Would you prefer a seperate issue for that?
Cheers.

The fix should be for all service addresses. I'll have to look into where the CIR is getting the URL. Sorry, I thought the change would fix all the address problems.

Jasen.

From: Scotty Brown <notifications<EMAIL_ADDRESS>Reply-To: TAXIIProject/django-taxii-services <reply<EMAIL_ADDRESS>Date: Monday, March 30, 2015 at 9:29 PM
To: TAXIIProject/django-taxii-services <django-taxii-services<EMAIL_ADDRESS>Cc: Jasen Jacobsen <jasenj1<EMAIL_ADDRESS>Subject: Re: [django-taxii-services] Discovery response & Collection Information Response needs a fully qualified URL in  element (#40)
Thanks so much for this @jasenj1https://github.com/jasenj1
This only addresses the discovery response though - not the collection management response...
Would you prefer a seperate issue for that?
Cheers.
—
Reply to this email directly or view it on GitHubhttps://github.com/TAXIIProject/django-taxii-services/issues/40#issuecomment-87894056.

I believe I have it fixed now. Found some other places where .path was used and needed to be changed to using the full address.

Jasen.

From: Scotty Brown <notifications<EMAIL_ADDRESS>Reply-To: TAXIIProject/django-taxii-services <reply<EMAIL_ADDRESS>Date: Monday, March 30, 2015 at 9:29 PM
To: TAXIIProject/django-taxii-services <django-taxii-services<EMAIL_ADDRESS>Cc: Jasen Jacobsen <jasenj1<EMAIL_ADDRESS>Subject: Re: [django-taxii-services] Discovery response & Collection Information Response needs a fully qualified URL in  element (#40)
Thanks so much for this @jasenj1https://github.com/jasenj1
This only addresses the discovery response though - not the collection management response...
Would you prefer a seperate issue for that?
Cheers.
—
Reply to this email directly or view it on GitHubhttps://github.com/TAXIIProject/django-taxii-services/issues/40#issuecomment-87894056.

Thanks @jasenj1
I updated django-taxii services on the host, but am now getting a 500 back form Yeti when trying to do a discovery response:

(u'Error importing handler: taxii_services.DiscoveryRequestHandler', <type 'exceptions.AttributeError'>, AttributeError("'module' object has no attribute 'DiscoveryRequestHandler'",))

And similar when i try a collection management response:
AttributeError at /services/collection-management/
(u'Error importing handler: taxii_services.CollectionInformationRequestHandler', <type 'exceptions.AttributeError'>, AttributeError("'module' object has no attribute 'CollectionInformationRequestHandler'",))
I'll try and do a bit of digging today.  The only change was a pull on django-taxii-services.
Cheers.

Looks like you don't have the new version of YETI. We changed some of the object names.
"taxii_services.XXX" has been removed. It's now "taxii_services.message_handlers.XXX". If you grab the latest version of YETI the database has been updated with the new names. It has to do with managing imports.
Sorry about that.

Jasen.

From: Scotty Brown <notifications<EMAIL_ADDRESS>Reply-To: TAXIIProject/django-taxii-services <reply<EMAIL_ADDRESS>Date: Tuesday, March 31, 2015 at 4:59 PM
To: TAXIIProject/django-taxii-services <django-taxii-services<EMAIL_ADDRESS>Cc: Jasen Jacobsen <jasenj1<EMAIL_ADDRESS>Subject: Re: [django-taxii-services] Discovery response & Collection Information Response needs a fully qualified URL in  element (#40)
Thanks @jasenj1https://github.com/jasenj1
I updated django-taxii services on the host, but am now getting a 500 back form Yeti when trying to do a discovery response:
(u';Error importing handler: taxii_services.DiscoveryRequestHandler';, <type ';exceptions.AttributeError';>, AttributeError("';module'; object has no attribute ';DiscoveryRequestHandler';",))
And similar when i try a collection management response:
AttributeError at /services/collection-management/
(u'Error importing handler: taxii_services.CollectionInformationRequestHandler', <type 'exceptions.AttributeError'>, AttributeError("'module' object has no attribute 'CollectionInformationRequestHandler'",))
I'll try and do a bit of digging today. The only change was a pull on django-taxii-services.
Cheers.
—
Reply to this email directly or view it on GitHubhttps://github.com/TAXIIProject/django-taxii-services/issues/40#issuecomment-88243421.

Ah - thanks @jasenj1
I had the latest Yeti - just needed a '''python manage.py syncdb'''
Cheers for both of these fixes!
Scotty


Update dependencies and workflows

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b83133d) to head (07e7d44).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #594   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           70        70
  Lines         1845      1845
  Branches       217       217
=========================================
  Hits          1845      1845

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Final height of the chain not visible

Bug Description
There is no one value that is pointing to the final height of the chain.
One could filter for how many blocks were produced in the last period with max of 1 year.
Steps to Reproduce
Open CCDScan on Home page.
Expected Result
Total length of the chain should be shown.
Actual Result
Total length is not show.
Note:
I think this is useful to know if ones node is up to a final height by comparing its own node height with the total length. I think that it is also good to just show for how long (how many blocks) the chain exists.
Versions

Software Version: version 0.1.2/1.0.2

I think you should put this in the CCDScan repo, not documentation.

@mh-concordium aligned and can close


CloudFormation output template getting UTF-8 BOM added

Description:
For some reason my Input SAM template YAML had a UTF-8 BOM in it.  When the sam package command is executed, the UTF-8 BOM is duplicated in the output cloud formation template file which causes the sam deploy command to fail.
Steps to reproduce the issue:

Open any SAM template file and ensure encoding is set to UTF-8 BOM

$ od -x filename.yaml
0000000 bbef 41bf 5357 6554 706d 616c 6574 6f46
<...>

Execute sam package:

$ sam package ---template-file sam-template.yaml --output-template-file output.yaml --s3-bucket deployments

Deploy processed sam template:

$ sam deploy --template-file output.yaml --stack-name myStack --capabilities CAPABILITY_IAM

Waiting for changeset to be created..
Failed to create the changeset: Waiter ChangeSetCreateComplete failed: Waiter encountered a terminal failure state Status: FAILED. Reason: Invalid template property or properties [???AWSTemplateFormatVersion]

A file without these codes at the beginning of the file work fine.
eg:
0000000 5741 5453 6d65 6c70 7461 4665 726f 616d

Observed result:
output.yaml has this at the end of the file and a sam deploy fails:
Transform: AWS::Serverless-2016-10-31
"\xEF\xBB\xBFAWSTemplateFormatVersion": '2010-09-09'

Expected result:
That last line in output.yaml should not be there and the UTF-8 BOM should have been stripped.
Not a huge deal as I changed the file type :-)  But would be nice to just strip it during processing? I did lose some time trying to figure out what happened!

It will be great if SAM can read all UTF8 encoding .yaml files and package with it properly, pretty annoying have to remember changing encoding to UTF8

I think maybe the IDE default file encoding is UTF8-BOM?
I was using Visual Studio 2017 (we are using .NET Core 2.1 Lambda) to create an empty text file and rename it to _______.yaml
We now just use powershell script to change it to UTF8 before running sam package
Not sure what  @mattgillard was using to generate the .yaml file

Sorry for late reply...yeah it was vscode

As part of a solution, I use Notepad++ to convert it to non-BOM UTF-8.
Go to Encoding > UTF-8  and save the file [ src ]


test(cmd-api-server): randomize port in config service test

If you don't specify port zero for the API and the cockpit then they
will default to 3000 and 4000 instead which is bad for
parallel test execution where we need guarantees not to
use potentially conflicting port numbers.
Signed-off-by: Peter Somogyvari<EMAIL_ADDRESS>

Codecov Report

Merging #1205 (bf4a9af) into main (0e4c7c5) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
+ Coverage   71.76%   71.93%   +0.17%
==========================================
  Files         270      270
  Lines        9420     9431      +11
  Branches     1113     1113
==========================================
+ Hits         6760     6784      +24
+ Misses       2087     2074      -13
  Partials      573      573

Impacted Files
Coverage Δ

...src/main/typescript/prometheus-exporter/metrics.ts
100.00% <ø> (ø)

...src/main/typescript/prometheus-exporter/metrics.ts
100.00% <ø> (ø)

...src/main/typescript/prometheus-exporter/metrics.ts
100.00% <ø> (ø)

...src/main/typescript/prometheus-exporter/metrics.ts
100.00% <ø> (ø)

...src/main/typescript/prometheus-exporter/metrics.ts
100.00% <ø> (ø)

...src/main/typescript/prometheus-exporter/metrics.ts
100.00% <ø> (ø)

...src/main/typescript/prometheus-exporter/metrics.ts
100.00% <ø> (ø)

...src/main/typescript/prometheus-exporter/metrics.ts
100.00% <ø> (ø)

...s-cmd-api-server/src/main/typescript/api-server.ts
85.52% <100.00%> (+0.04%)
:arrow_up:

...escript/prometheus-exporter/prometheus-exporter.ts
93.75% <100.00%> (+20.41%)
:arrow_up:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce076d7...bf4a9af. Read the comment docs.


Ownership of "glossarist" gem at rubygems.org

As per request by sonalkr132 at Rubygems.org, this issue serves as notice to Rubygems.org that:

the owner of this repository and the "glossarist" is rubygems.org user "ribose (https://rubygems.org/profiles/ribose); and
to request the transfer of gem ownership to the user "ribose"

Thanks.

Done.
$ gem owner glossarist
Owners for gem: glossarist
- ribose
- skalee


Docker Monitoring Docker

I have developed a tool which can monitor another container and provide the memory/cpu/disk statistics of a running container.
I need to pass the dockerID of a container as input to my program. But the issue is how do I know if the container being monitor is restated. in this case the dockerID has changed.
How do I know if a container is restarted and fetch the dockerID every time the container is starts/restart.

Hey @satyabratabharati, i hope you can understand that this repository is not ment to provide support for specific implementation-problems for Docker and also should not be used for that.
Nevertheless you may use a mount to the Docker socket for adding an event listener to changes of containers you listen to (e.g. like in the nginx reverse proxy) when a container is started/stopped with a specific env var value.
All the best for the implementation!


Spoke Subnets are created as Public subnet

The spoke VCNs are created as Public subnet although the name indicates that Private subnet e.g. : spoke01_subnet_priv01

And according to reference architecture the spoke VCNs should not be accessible from the internet as well:
https://docs.oracle.com/en/solutions/hub-spoke-network/index.html#GUID-8295B649-5AF9-4CBD-A85E-153AB4916532

Thanks for pointing that. I'll  fix that.

Thank you so much @oegentil  for looking into this, this will help us a lot!

Thanks for looking into this @oegentil. This will be super helpful

Yes, I second @nishanbrown in his finding and would like to see this issue fixed soon, please. It will help, of course


Python program to search occurrence of a number

🚀 Feature
(A clear and concise description of what the feature is.)
I want to add a python program which will take a sequence as input and two integers x and k.The program will return a boolean value depending upon the count of x.
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


How to get device id from hex?

Is there a function to get the id of an device from the hex code of a telegram?
I have this (comes from the parser):
55000707017af600002782032000ffffffff4a0050
And looking for the id (and other base information):
00278203

not all ESP3Packets come from devices and hence not all of them have IDs. You can get the id (senderId) of the device from the RadioERP1 interface though, so from whatever the transformer returns.
transformer.on('data', async data => {
  console.log(data.senderId)
})

Thats exact what i am looking for. Thank you.


crashes in 1.19.3

Cannot load with 1.19.3 (fabric):
java.lang.RuntimeException: Could not execute entrypoint stage 'client' due to errors, provided by 'cheatutils'!
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
	at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
	at net.fabricmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:53)
	at net.minecraft.class_310.<init>(class_310.java:465)
	at net.minecraft.client.main.Main.method_44604(Main.java:205)
	at net.minecraft.client.main.Main.main(Main.java:51)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:214)
	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:249)
	at org.multimc.EntryPoint.listen(EntryPoint.java:143)
	at org.multimc.EntryPoint.main(EntryPoint.java:34)
Caused by: java.lang.NoSuchFieldError: field_11146
	at com.zergatul.cheatutils.wrappers.ModApiWrapper.<clinit>(ModApiWrapper.java:13)
	at com.zergatul.cheatutils.ModMain.onInitializeClient(ModMain.java:21)
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47)
	... 16 more

I see Mojang made a lot of refactoring of geometry related code, matrices, vectors and similar stuff. This will take some time to fix.

That was fast!  Looks like the fabric version only offers ESP and Freecam, and the ESP doesn't appear to be working.  I was actually specifically looking for kill aura in fabric - is that going to be available?  FWIW, there's a separate freecam mod, so that feature is a little redundant other than the convenience of having it all in one place.

Fabric version has Kill Aura (under Hacks column). ESP should work. There is rare bug (it happens more often for some users) with Blocks ESP. But Entity ESP is stable. You can use other FreeCam mod, but it is better to use embedded freecam, since some modules have integration with native freecam, and it will not work with another freecams.

Ok, I see it now.  Is there any way to be more granular on what can be targeted?  It appears to ignore passive mobs.

I added this to forge version about week ago. I can add this to fabric, but I have a lot of other requests, so it will not be very soon

ok, cool.  Yeah, it would be super helpful to just be able to specify a list of things to target.  Specifically, I'm looking to be able to hit bats (which doesn't seem to be a target of "flying mobs").

Moved forge Kill Aura changes to fabric version. Check 0.11.0 fabric. It may take some time before curseforge approve file.

Works in 1.19.3


Reporting an Issue or Missing Feature
Using Grant-PnPAzureADAppSitePermission to grant write access to sites.selected errors out while using 2.1.1 stating it is an invalid request. When doing the exact same command with 1.11 it works (I have a vm with the new version and one with the old).
Expected behavior
A new azureAd app site permission should be created.
Actual behavior
No new AzAD appsite permission is created and a generic invalid request error is returned.
Steps to reproduce behavior
#replaced my actual domain/host/site with contoso
$siteUrl = 'https://contoso.sharepoint.com/sites/contososite'
connect-pnponline -interactive -url $siteUrl -tenant contoso.onmicrosoft.com
Grant-PnPAzureADAppSitePermission -Permissions "Write" -Site $siteUrl -AppId $appId -DisplayName "SitesResourceSpecific"

What is the version of the Cmdlet module you are running?
2.1.1 is the one that is failing. It works for me on 1.11 exact same cmdlets.
(you can retrieve this by executing Get-Module -Name "PnP.PowerShell" -ListAvailable)
Which operating system/environment are you running PnP PowerShell on?

[x ] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

Same issue.

Have fixed this issue, it will be available in tomorrow's nightly builds.
Please let us know if the issue still persists.

Hi @gautamdsheth Do you have an ETA on when this fix will be released? Thanks!

Had the same issue, Prerelease fixed it! Thanks @gautamdsheth!

After upgrading to the today's nightly, the internal error is gone - however I now get:

Forbidden (403): Access denied

Since I also get this when calling Get-PnPAzureADAppSitePermission, I assume that this points to a different issue than the one reported by OP: While the documentation states that Sites.FullControl.All is the required permission (which is granted), this does not seem to be the case - at least when using an own Azure AD app and connecting with Client ID and PFX.

This can happen if you are not site admin. Replying in case someone does Internet Search for 403 error with Get-PnPAzureADAppSitePermission this and lands here. I faced same issue as I had FullControl over site but was not site admin. Menu Settings --> Site Permissions --> Advanced Permissions Settings --> Site Collection Administrators

I just made a new app with full rights.  I can login and see all my sites as admin.
Grant-PnPAzureADAppSitePermission -AppId "$($appid)" -Site $siteUrl -DisplayName "test" -Permissions "write"
Fails
Grant-PnPAzureADAppSitePermission: {"error":{"code":"accessDenied","message":"Access denied","innerError":{"date":"2024-09-27T18:38:10","request-id":"xxxx112fb5f","client-request-id":"xxxxx3112fb5f"}}}

@ComputerHabit2 that is unrelated to the original issue that I submitted here. That error MOST likely refers to that the user you are running as needs to be an Owner of the sharepoint site. This is true regardless of if you run it as a Global Admin.

@ComputerHabit2 that is unrelated to the original issue that I submitted here. That error MOST likely refers to that the user you are running as needs to be an Owner of the sharepoint site. This is true regardless of if you run it as a Global Admin.

I agree.  This was me getting stuck with switches being disabled and having to scramble for understanding of the changes.


can we use this library with stripe.js?

Does this library support integration with react-stripe-js ?

I believe not. I'm not a react-stripe-js specialist, but I think we don't have access to the card values at the moment the user is filling in. If you have access to card infos, maybe the main idea of react-stripe-js is wrong. 😅


[BUG]: Demo app does not correspond to current source

Description of the bug
Viewing the source code and the current demo, there are missing routes / pages / components.

pages/about
pages/services
pages/projects

Steps To Reproduce

Download and run the source from this repository
Notice the routes and some pages are missing

Additional Information
No response

It's a starter. You can find the demo code in jaco branch, https://github.com/shinokada/flowbite-svelte-starter/tree/jaco


WARNING: unable to extract channel id

[x ] I'm reporting a broken site support
[x ] I've verified that I'm running youtube-dl version 2019.07.02
[x ] I've checked that all provided URLs are alive and playable in a browser
[x ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x ] I've searched the bugtracker for similar issues including closed ones
Verbose log
[download] Downloading video 109 of 777
[youtube] KFLOT_BmINI: Downloading webpage
[youtube] KFLOT_BmINI: Downloading video info webpage
WARNING: unable to extract channel id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
WARNING: video doesn't have subtitles
[youtube] KFLOT_BmINI: Downloading thumbnail ...
[youtube] KFLOT_BmINI: Writing thumbnail to: HACKADAY/HACKADAY - Uploads from HACKADAY/Uploads from HACKADAY - S01E109 - Hackaday Live - Dr. Rajib Shubert - Virus stamping for targeted single cell infection.jpg
[debug] Invoking downloader on 'https://r5---sn-vgqskned.googlevideo.com/videoplayback?expire=1562804119&ei=NismXa-YMcjN8wShp6KYCw&ip=<IP_ADDRESS>&id=o-AH_vYWarYLqMWAPSWMS9U2_7qq_lTKiIdVSS1JCEprbN&itag=302&aitags=133%2C134%2C135%2C136%2C160%2C242%2C243%2C244%2C247%2C278%2C298%2C302&source=youtube&requiressl=yes&mm=31%2C26&mn=sn-vgqskned%2Csn-p5qs7nel&ms=au%2Conr&mv=m&mvi=4&pl=20&initcwndbps=1820000&mime=video%2Fwebm&gir=yes&clen=86022036&dur=1089.237&lmt=1530418535796904&mt=1562782368&fvip=6&keepalive=yes&c=WEB&sparams=expire%2Cei%2Cip%2Cid%2Caitags%2Csource%2Crequiressl%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=ALgxI2wwRQIhAJ8xir1hNbP4vBnUZFOJqLwLUzsdQgcASbgAlFGpUDNZAiB1UrbHo5hcsxBQs0TBbjbrumkGc_UEmdnJcvldIoBIiA%3D%3D&lsparams=mm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AHylml4wRAIgG3brqX9R1Hf5wStm2R4P_PuYCnorotxSQfvgMV9twjsCIDXrUoCKPGIYfAfzpWcawexLak-gcnYNji_qxXuHKw2d&ratebypass=yes'
[download] Destination: HACKADAY/HACKADAY - Uploads from HACKADAY/Uploads from HACKADAY - S01E109 - Hackaday Live - Dr. Rajib Shubert - Virus stamping for targeted single cell infection.f302.webm
[download] 100% of 82.04MiB in 00:47
[debug] Invoking downloader on 'https://r5---sn-vgqskned.googlevideo.com/videoplayback?expire=1562804119&ei=NismXa-YMcjN8wShp6KYCw&ip=<IP_ADDRESS>&id=o-AH_vYWarYLqMWAPSWMS9U2_7qq_lTKiIdVSS1JCEprbN&itag=251&source=youtube&requiressl=yes&mm=31%2C26&mn=sn-vgqskned%2Csn-p5qs7nel&ms=au%2Conr&mv=m&mvi=4&pl=20&initcwndbps=1820000&mime=audio%2Fwebm&gir=yes&clen=16718447&dur=1089.261&lmt=1530419934027871&mt=1562782368&fvip=6&keepalive=yes&c=WEB&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=ALgxI2wwRQIhAP9HpJny-fsvqyCPCTTbxgK0wKF71NI2vdE4nWJ6R3tcAiBGLVE2GV6NAILLGsfD5d1mGaTuo93y0ONdyVumk2cXjA%3D%3D&lsparams=mm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AHylml4wRAIgG3brqX9R1Hf5wStm2R4P_PuYCnorotxSQfvgMV9twjsCIDXrUoCKPGIYfAfzpWcawexLak-gcnYNji_qxXuHKw2d&ratebypass=yes'
[download] Destination: HACKADAY/HACKADAY - Uploads from HACKADAY/Uploads from HACKADAY - S01E109 - Hackaday Live - Dr. Rajib Shubert - Virus stamping for targeted single cell infection.f251.webm
[download] 100% of 15.94MiB in 00:09
[ffmpeg] Merging formats into "HACKADAY/HACKADAY - Uploads from HACKADAY/Uploads from HACKADAY - S01E109 - Hackaday Live - Dr. Rajib Shubert - Virus stamping for targeted single cell infection.mkv"
[debug] ffmpeg command line: ffmpeg -y -i 'file:HACKADAY/HACKADAY - Uploads from HACKADAY/Uploads from HACKADAY - S01E109 - Hackaday Live - Dr. Rajib Shubert - Virus stamping for targeted single cell infection.f302.webm' -i 'file:HACKADAY/HACKADAY - Uploads from HACKADAY/Uploads from HACKADAY - S01E109 - Hackaday Live - Dr. Rajib Shubert - Virus stamping for targeted single cell infection.f251.webm' -c copy -map 0v0 -map 1a0 'file:HACKADAY/HACKADAY - Uploads from HACKADAY/Uploads from HACKADAY - S01E109 - Hackaday Live - Dr. Rajib Shubert - Virus stamping for targeted single cell infection.temp.mkv'
Deleting original file HACKADAY/HACKADAY - Uploads from HACKADAY/Uploads from HACKADAY - S01E109 - Hackaday Live - Dr. Rajib Shubert - Virus stamping for targeted single cell infection.f302.webm (pass -k to keep)
Deleting original file HACKADAY/HACKADAY - Uploads from HACKADAY/Uploads from HACKADAY - S01E109 - Hackaday Live - Dr. Rajib Shubert - Virus stamping for targeted single cell infection.f251.webm (pass -k to keep)
[ffmpeg] Adding metadata to 'HACKADAY/HACKADAY - Uploads from HACKADAY/Uploads from HACKADAY - S01E109 - Hackaday Live - Dr. Rajib Shubert - Virus stamping for targeted single cell infection.mkv'
[debug] ffmpeg command line: ffmpeg -y -i 'file:HACKADAY/HACKADAY - Uploads from HACKADAY/Uploads from HACKADAY - S01E109 - Hackaday Live - Dr. Rajib Shubert - Virus stamping for targeted single cell infection.mkv' -c copy -metadata 'title=Hackaday Live : Dr. Rajib Shubert - Virus stamping for targeted single cell infection' -metadata date=20180531 -metadata 'description=Dr. Rajib Shubert, (Caltech) Virus stamping for targeted single cell infection' -metadata 'comment=Dr. Rajib Shubert, (Caltech) Virus stamping for targeted single cell infection' -metadata 'purl=https://www.youtube.com/watch?v=KFLOT_BmINI' -metadata artist=HACKADAY 'file:HACKADAY/HACKADAY - Uploads from HACKADAY/Uploads from HACKADAY - S01E109 - Hackaday Live - Dr. Rajib Shubert - Virus stamping for targeted single cell infection.temp.mkv'
[ffmpeg] There aren't any subtitles to embed
Command used:
youtube-dl --verbose -i --match-filter "playlist_title !='Liked videos' & playlist_title != 'Favorites'" -f "(bestvideo[vcodec^=av01][height>=1080][fps>30]/bestvideo[vcodec=vp9.2]
[height>=1080][fps>30]/bestvideo[vcodec=vp9][height>=1080][fps>30]/bestvideo[vcodec^=av01]
[height>=1080]/bestvideo[vcodec=vp9.2][height>=1080]/bestvideo[vcodec=vp9]
[height>=1080]/bestvideo[height>=1080]/bestvideo[vcodec^=av01][height>=720]
[fps>30]/bestvideo[vcodec=vp9.2][height>=720][fps>30]/bestvideo[vcodec=vp9][height>=720]
[fps>30]/bestvideo[vcodec^=av01][height>=720]/bestvideo[vcodec=vp9.2]
[height>=720]/bestvideo[vcodec=vp9][height>=720]/bestvideo[height>=720]/bestvideo)+
(bestaudio[acodec=opus]/bestaudio)/best" --merge-output-format mkv -o "%(uploader)s/%(uploader)s - %(playlist)s/%(playlist)s - S01E%(playlist_index)s - %(title)s.%(ext)s" --download-archive youtube_hacking_tutorials_downloaded.txt --embed-subs --write-sub --sub-lang en --ignore-errors --no-continue --no-overwrites --no-post-overwrites --write-thumbnail --add-metadata "https://www.youtube.com/channel/UCnv0gfLQFNGPJ5MHSGuIAkw"

Could you please let me know how this incomplete? I've provided the output from the --verbose flag, and with the command that I used. I'm unsure what else to add...

@firstcoffeethencode your logs are missing the beginning of the log which has the important information. also, use surround your logs and commands with
```
```


Add support of metrics reporting

Closes: https://github.com/Mirantis/k8s-netchecker-server/issues/36

This change is

Reviewed 4 of 7 files at r1, 1 of 2 files at r2, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Here's a draft fix for rtcp-fb wildcard support fix #3418.

Here's a draft fix for rtcp-fb wildcard support fix #3418.
But I don't have an environment to build and test it.

I compiled it with WSL2 Ubuntu. It does fix the problem. I verified.

Replace asterisk with wildcard. It's a more accurate description.

https://chromiumdash.appspot.com/commit/55c51732205a789aaf2a08d555987a6770184681
The commit is reverted. Issue close.


Updating AS files we are fighting over

WHAT
Updating AS files we are fighting over
WHY
Some updates after dependency updates
HOW
Checklist :clipboard:

[ ] Add explicit visibility modifier and explicit return types for public declarations
[ ] Run spotless check
[ ] Run tests
[ ] Update metalava's signature text files

Landing as non-controversial.


Flake: lb_load_reporter_test

test/cpp/server/load_reporter/load_reporter_test.cc:175
Value of: static_cast(lb_feedback.calls_per_second())
Expected: is approximately<PHONE_NUMBER>0000002 (absolute error <= 15.205000000000002)
Actual: 248.783 (of type double), which is -55.3174 from 304.1
https://source.cloud.google.com/results/invocations/58ce2943-6b4a-4425-b57b-a2bb14a7a4f7/targets/%2F%2Ftest%2Fcpp%2Fserver%2Fload_reporter:lb_load_reporter_test@poller%3Depoll1/tests

Hmm, I think we should actually delete the load reporter files if we are not using them.


Update SA1614 (ElementParameterDocumentationMustHaveText) to handle included documentation

The issue described in #1603 applies to SA1614 as well.

Grabbing this


Add shortcuts to access patch/diff - fix #220

This is a fix for #220 that removes the patch/diff links on commit pages introduced in #66 and replaces them with keyboard shortcuts.
To use this PR, on a commit page you press theshift++/= to view the patch, or +/= to view the diff or shift+alt++/= to view the original.
This is a WIP because of failing ava tests.
These tests only fail locally I guess. If anyone else has failures please comment.

Can you also update the Adds links to patch and diff for each commit mention in the readme?

Do you really use it that often that it's worth having keyboard shortcuts for this? I maybe use it once a month and would never remember the shortcuts.

Can you also update the Adds links to patch and diff for each commit mention in the readme?

Can do.

Do you really use it that often that it's worth having keyboard shortcuts for this? I maybe use it once a month and would never remember the shortcuts.

Maybe I can add it to the shortcut helper? This is just a way to preserve the function and remove the troublesome UI components. I think links are better than keyboard shortcuts, but these links keep breaking the UI.

@paulmolluzzo Maybe we can put them somewhere different where they're not so easily prone to breakage?

@sindresorhus that could work just as well. I can't think of a good spot for these unless they're in a totally different area, we make a new row underneath, or we use icons instead to reduce the width of the added links.

@sindresorhus added to README and rebased on master to be up to date.

@paulmolluzzo FYI Merge conflicts

@DrewML thanks, fixed.


Added Phase Change Material constitutive class and heat conduction model

Other than that, It looks good on my end. Thanks for the addition @markleader!
Check out steps 4 and 5 here for how to fix the black/clang linting failures


country(rwanda): add rwanda page

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Submit a Cloud Definition ~ Virtual Network

Word: Virtual Network
Content: A virtual network is a private space in Azure where you can add certain resources to communicate with each other without the use of the internet. You can compare it to a VLAN.
Author Name: Athina (Artist) Thomas
Author Link: https://linktr.ee/artistyay?fbclid=PAAaYkcfWyjCkgqM-JdaL03_xhx3bZTl7wT5a2wQpgWAmAqmCPG6nqr8mk_70
Learn More URL: https://learn.microsoft.com/en-us/azure/virtual-network/virtual-networks-overview
Category: networking
Abbreviation [OPTIONAL]: VNET

Nice one, I've added it, thank you!


packages/jest-cli

I need to make sure all tests pass on CI

seems like i made it work!
@cpojer can you double check all the dependencies + lerna stuff?

@facebook-github-bot import

Thanks for importing. If you are an FB employee go to Phabricator to review.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


Ancestry proofs

Adds ancestry proofs to the beacon client.

[x] Downloads the beacon state using lodestar
[x] Send block roots, block root hash and block roots proof to beacon client
[x] Verify block root proof
[x] Store block roots
[x] Check block proofs in execution header imports
[x] Only check ancestry blocks for non-minimal spec until unmarshalling minimal beacon state object is possible
[ ] Add ancestry proof test data to test fixtures

The only thing still outstanding is to update the test and benchmark data fixtures. I would like to do so after merging https://github.com/Snowfork/snowbridge/pull/773.

Updated docs including a explanation of how the ancestry proofs work: https://www.notion.so/snowfork/Beacon-Client-074ca039288247bba2f96bd6cb8674bf#13645ee8badc4cf183547cb51151d15a


[ Feature Request ] Ability to bring pushables on collisionless statics

Is your feature request related to a problem? Please describe.
I'm making a level where there is a pushable that has to be pushed on a collisionless static, ut Lara can't,because the engine detects a minimal collision.
Describe the solution you'd like
I would like if pushables can be pushed/pulled on an object with collision=0.
Describe alternatives you've considered
No response
Additional context
No response

@LGG-PRODUCTION please provide a test project.

[collide_item.cpp]
GetCollidedObjects () (line 237)
auto box0 = bounds.ToBoundingOrientedBox(staticObj.pos.Position);
auto box1 = collidingBounds.ToBoundingOrientedBox(collidingItem.Pose);

// Override extents if specified.
if (customRadius > 0.0f)
    box1.Extents = Vector3(customRadius);

// Test accurate box intersection.
if (box0.Intersects(box1))
    collObjects.Statics.push_back(&staticObj);

Although box0 bounds extents are 0,0,0,0, it keeps sending to Intersect function, and this one just verify that the object is intersecting with box1 (that has the extent volume of the pushable) so returns a positive what push the static into the list of collided objects.

Added fix in commit 0a8eb65de
auto box0 = bounds.ToBoundingOrientedBox(staticObj.pos.Position);
auto box1 = collidingBounds.ToBoundingOrientedBox(collidingItem.Pose);

// Override extents if specified.
if (customRadius > 0.0f)
	box1.Extents = Vector3(customRadius);

// Skip if either bounding box has any zero extent (not a collidable volume).
if (box0.Extents.x > 0 || box0.Extents.y > 0 || box0.Extents.z > 0)
	continue;

if (box1.Extents.x > 0 || box1.Extents.y > 0 || box1.Extents.z > 0)
	continue;

// Test accurate box intersection.
if (box0.Intersects(box1))
	collObjects.Statics.push_back(&staticObj);

Because Extents is an XMFLOAT3, it doesn’t have an intrinsic .Length() function. Converting it to XMVECTOR to use the XMVector3Length function would add unnecessary complexity, so I kept this approach for simplicity and efficiency.

Updated approach in commit: 0faa11a882cf011f4483a8dd3e1fc430a7f58aa6

Is it still happening?

Fixed, according to author's report.