how is the transformation from map to base_link calculated ?

where is the transformation between map frame and base_link calculated ? Which process provides this transformation ?
When I perform localization based on AW tutorial (tierV) the lidar scans do not overlap the map generated earlier by ndt mapping.
Thanks.

dlounis , i have same problem, do you have solved?

@dlounis  can you contact me (my weixin number is<PHONE_NUMBER>5 )

@amc-nu,
You told that a tf between the GNSS coordinates and the exact point where you started to create the map is  needed. Would you tell me how to make this tf?


auto completing is up everywhere.

I just installed this package and set nothing yet.
I made new html file for test.
when I typed "<html ng-", it automatically pop up some word that start with 'ng-'.
it looks nice, but problem made after.

with ">", auto completing pop up is pop again, all syntax is well done tho.
not even here, this suggestion pop is up everywhere.
is this expected result? or do i have to set up something more?

I'm experiencing the same issue (AngularJS-sublime-package v1.2.1, SublimeText 3 Build 3083). I had to disable 'Built-in Element Completions', as entering '' followed by an [enter] led to the ng-include template being inserted.

thanks It works to me :)


[katana] Display missing default values in command line --help

Is your feature request related to a problem? Please describe.
The following default values are not displayed :
--validate-max-steps <VALIDATE_MAX_STEPS>
The maximum number of steps available for the account validation logic.

 --invoke-max-steps <INVOKE_MAX_STEPS>
The maximum number of steps available for the account execution logic.

--eth-gas-price <L1_ETH_GAS_PRICE>
The L1 ETH gas price.

--strk-gas-price <L1_STRK_GAS_PRICE>
The L1 STRK gas price.

Describe the solution you'd like
Display default values like other params
-p, --port <PORT>
Port number to listen on.

[default: 5050]

Can I work on this? @notV4l

@notV4l please can you help with resource where I can look up the default values?

I think you can find some values here:
https://docs.starknet.io/documentation/tools/limits_and_triggers/

@notV4l please can you help with resource where I can look up the default values?

well i started to look into it, and i did PR xd

No worries @notV4l . I'll just look out for another issue


Github pages deploy problem with path

In my project I put angular into subfolder and after github pages deploy
I have got wrong urls in the released application.
https://github.com/kodiua/ng-europe-hackaton
https://kodiua.github.io/ng-europe-hackaton/ng-app/

Same here

Heya, I think you can fix this with the --base-href flag. Can you try ng github-pages:deploy --base-href="ng-europe-hackaton/ng-app/"?

Closing as inactive.


proposal: time: new Init() and Start() methods for Timer

As suggested here #54861 by add these two new methods to time package, we achieve this goals:

Changes don't break any existing code and respect backward compatibility.
prevent two heap allocation (unnecessary) request, when a Timer can be part of other structs (embed or as a field).
Due to NewTimer can't inline and return the pointer of a Timer struct,
If devs want to add a Timer to other structs (embed or as a field) to allocate both structs in one request,
existing NewTimer() don't let us do this.
Init method can inline now and the Start() method sets the when field. In this way, functions respect the single responsibility principle.

/time> go build -gcflags="-m"
./sleep.go:64:6: can inline (*Timer).Init
./sleep.go:50:8: inlining call to (*Timer).Init

Improve code readability of NewTimer() function.

Proposed function signatures:
func (t *Timer) Init()
func (t *Timer) Start(d Duration)

func (t *Ticker) Init()
func (t *Ticker) Tick(d Duration)

Keep in mind that these new methods is not introduce new functionality, They just get some functionalities from NewTimer & NewTicker and made them be simple. Init() method as usuall initialize the new allocated object. Start() or Tick() method will start timer(runtime package) that will send signal (on the channel) once or on periods  base on its type.

Please write doc comments for these new methods.  Thanks.  In particular, what does the Init method do?  Why do we need it?

Although I wrote comments in #54861, you are right I must copy them here for better referencing.
// Init initialize the Timer.
// It must call before call Start() or Reset() methods
func (t *Timer) Init()
// Start start the timer that will send
// the current time on its channel after at least duration d.
func (t *Timer) Start(d Duration)

// Init initialize the Ticker.
// It must call before call Tick() or Reset() methods
func (t *Ticker) Init()
// Tick start the timer that will send
// the current time on its channel after each tick.
func (t *Ticker) Tick(d Duration)

As said in the first comment, Due to NewTimer or NewTicker returning a pointer of Timer or Ticker and they can't be inlined, So when we can embed Timer or Ticker we don't have a way to Init them without unnecessary heap allocation. When Init exist we can easily add Timer or Ticker to other structs with one heap allocation request.

type HeartBeatService struct {
	// other fields
	interval time.Duration
	ticker   time.Ticker
}

func (h *HeartBeatService) Init(interval time.Duration) {
	h.interval = interval
	h.ticker.Init()
}
func (h *HeartBeatService) Reinit() {
	h.ticker.Stop()
	// can flush h.ticker.C here too.
}
func (h *HeartBeatService) Deinit() {
	h.ticker.Stop()
}

func (h *HeartBeatService) Process() {
	h.ticker.Start(h.interval)

	for now := range h.ticker.C {
		// send signal
	}
}

In this way, each new methods have a single responsibility and complete the life cycle of Timer or Ticker, And prevents congested logic in NewTimer or NewTicker.

What does Init do that Start cannot do instead?

@rsc Init exist to show object(Timer) life cycle and respect functions single responsibility. (Personally I like a code that respect these principles).
But anyway you are the ruler, if you don't like Init exported method, just accept the Start exported method. But take in mind that we need init local method any way, because Timer let us call its Reset method in not started timer. So We need to check for not initialized timer in both Start and Reset or change the Reset documents.

It sounds like the goal is purely to avoid allocations. But each Timer is kept in a heap stored in the runtime, and we don't want the runtime's copy to be writable by user code, or else the heap invariants can be violated. So I don't think we want the runtime to allow the user to provide the memory for a Timer.
Is there a program or real-world benchmark you can point to that is suffering from these allocations?

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

It sounds like the goal is purely to avoid allocations. But each Timer is kept in a heap stored in the runtime, and we don't want the runtime's copy to be writable by user code, or else the heap invariants can be violated.

@rsc How runtime's copy can be writable by user code?
Can you explain when all fields of runtimeTimer are privates user can change them directly without any exported methods?

So I don't think we want the runtime to allow the user to provide the memory for a Timer.

When any developer decides to embed a structure into another one, It means that have enough knowledge about bad things that may happen like memory leaks and it is like many other features in Go such as string that can be a huge problem if we don't be careful.

Is there a program or real-world benchmark you can point to that is suffering from these allocations?

I know the usage of proposed APIs is rare (in comparison to other features) and usually used in low-level libraries such as /runtime/netpoll.go/pollDesc but it can be a helpful feature in some use-cases like implementing network protocols in user space (instead of kernel space) as QUIC.
I think writing many things in user space (as OS-library) is the future way to develop computer software.
P.S.: I try to rewrite the timer package and get all functionality away from the Go runtime and time packages, It is not ready to use yet but it is a possible way.
I think the Go runtime package needs many rewrite to be small and just a wrapper of functionalities not an implementor of them.
https://github.com/GeniusesGroup/libgo/tree/dev/timer

The fact that the fields are private doesn't prevent someone from writing
    var v HeartBeatService
    v.Init()
    v  = HeartBeatService{}

I try to rewrite the timer package and get all functionality away from the Go runtime and time packages, It is not ready to use yet but it is a possible way.
I think the Go runtime package needs many rewrite to be small and just a wrapper of functionalities not an implementor of them.

That is interesting.  The current timer implementation is closely tied to the scheduler, as I expect you know.  This has been guided by a desire for efficiency and timer accuracy, especially for programs with millions of timers.  That is, performance and accuracy are extremely important here.  If we can get comparable results by moving this out of the runtime, that would be great.  But it sounds hard.

The fact that the fields are private doesn't prevent someone from writing
    var v HeartBeatService
    v.Init()
    v  = HeartBeatService{}

/runtime/time.go/timerNoStatus  is the answer that if any developer tries to do in your way, in many logics in timing like this will drop its timer. I know it is a bug but the bug came from the developer's mistake not the timer package that try to reallocation without Init and Start the new Timer

I try to rewrite the timer package and get all functionality away from the Go runtime and time packages, It is not ready to use yet but it is a possible way.
I think the Go runtime package needs many rewrite to be small and just a wrapper of functionalities not an implementor of them.

That is interesting. The current timer implementation is closely tied to the scheduler, as I expect you know. This has been guided by a desire for efficiency and timer accuracy, especially for programs with millions of timers. That is, performance and accuracy are extremely important here. If we can get comparable results by moving this out of the runtime, that would be great. But it sounds hard.

Until now, I know we can't have the timer package without extracting some other functionality from runtime. we need some functionality of the scheduler, a user-space scheduler like Go or kernel level one.
In overall I know it is not so hard to split the Go runtime package, It is just about giving responsibility to some ones that have enough rights.
I suggest starting by taking away all unix time codes to small a package in time/unix. I can do it for the community like this one But it needs very long process decision that make many overheads due to conflicts from other developers.

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

No change in consensus, so declined.
— rsc for the proposal review group


Atom racer is not properly configured.

From @vrcod on December 8, 2015 12:48
[Enter steps to reproduce below:]

...
...

Atom Version: 1.2.4
System: Ubuntu 15.04
Thrown From: Atom Core
Stack Trace
Atom racer is not properly configured.
At undefined

undefined

Commands
     -7:21.9.0 application:add-project-folder (atom-text-editor.editor.is-focused)
  3x -6:50.9.0 core:move-down (atom-text-editor.editor.is-focused)
     -6:49.9.0 core:move-up (atom-text-editor.editor.is-focused)
  3x -6:49.1.0 core:move-down (atom-text-editor.editor.is-focused)
     -6:46.1.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
  2x -6:45.5.0 editor:newline (atom-text-editor.editor.is-focused)
     -6:45.1.0 core:move-up (atom-text-editor.editor.is-focused)
     -6:44.8.0 snippets:next-tab-stop (atom-text-editor.editor.is-focused)
     -6:44.8.0 snippets:expand (atom-text-editor.editor.is-focused)
     -6:44.8.0 editor:indent (atom-text-editor.editor.is-focused)
     -4:43.3.0 core:paste (atom-text-editor#racer.racerBinPath.editor.mini.is-focused)
 12x -1:31.3.0 core:backspace (atom-text-editor#racer.racerBinPath.editor.mini.is-focused)

Config
{}

Installed Packages
# User
language-rust, v0.4.5
linter-rust, v0.2.11
racer, v0.17.2

# Dev
No dev packages

Copied from original issue: atom/atom#9980

I'm getting the same errors whenever the racer package tries to call racer. (racer.racerBinPath not set, racer.rustSrcPath not set, racer is not properly configured)

Seems the problem were the default paths for the rust source and racer. (/usr/bin/racer instead of /usr/local/bin/racer and /usr/src/rust/src instead of /usr/local/src/rust/src)
So it's pretty much just an error message that could be more descriptive, and somewhat weird default paths.

I am receiving this error and I do have options properly configured. I have a custom path for racer which is set, yet this still shows.

Is racer actually configured properly (e.g. does path/to/racer complete std::io::B show completions or error) on your system? Also, does the racer path in the options point to the executable, not the directory it's in, and does the rust source path actually point to a directory with the rust sources in it?

Yes

$ racer complete std::io::B
MATCH BufReader,47,11,/home/chaos/repos/rustc-1.6.0/src/libstd/io/buffered.rs,Struct,pub struct BufReader<R> {
MATCH BufWriter,299,11,/home/chaos/repos/rustc-1.6.0/src/libstd/io/buffered.rs,Struct,pub struct BufWriter<W: Write> {
MATCH BufRead,1267,10,/home/chaos/repos/rustc-1.6.0/src/libstd/io/mod.rs,Trait,pub trait BufRead: Read {
MATCH Broadcast,1497,11,/home/chaos/repos/rustc-1.6.0/src/libstd/io/mod.rs,Struct,pub struct Broadcast<T, U> {
MATCH Bytes,1640,11,/home/chaos/repos/rustc-1.6.0/src/libstd/io/mod.rs,Struct,pub struct Bytes<R> {

Yes
Yes

I also receive tooltip info like mismatched types and red squiggles where I've done things incorrectly. So it behaves like it is configured properly, yet the error is still thrown.
The following is the Bug Report atom wants me to file:
Issue:
racer.rustSrcPath is not set in your config.
Body:
[Enter steps to reproduce below:]

...
...

Atom Version: 1.5.3
System: LMDE 2
Thrown From: Atom Core
Stack Trace
racer.rustSrcPath is not set in your config.
At undefined

undefined

Commands
     -6:01.9.0 vim-mode:reset-normal-mode (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -6:01.3.0 vim-mode:delete (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -6:01.2.0 vim-mode:move-to-end-of-word (atom-text-editor.editor.vim-mode.is-focused.operator-pending-mode)
     -6:00.6.0 vim-mode:activate-insert-mode (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -5:59.6.0 vim-mode:activate-normal-mode (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -5:59.1.0 ex-mode:open (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -5:59.1.0 blur (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -5:58.8.0 core:confirm (atom-text-editor.editor.mini.is-focused)
 10x -5:58.7.0 blur (atom-text-editor.editor.mini.is-focused)
     -0:39.9.0 vim-mode:move-down (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:39.2.0 vim-mode:move-up (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:38.9.0 vim-mode:insert-after-end-of-line (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:37.8.0 core:backspace (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
 11x -0:36.5.0 blur (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
  3x -0:05.7.0 core:backspace (atom-text-editor.editor.vim-mode.insert-mode.is-focused)
     -0:00.5.0 blur (atom-text-editor.editor.vim-mode.insert-mode.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "language-gfm",
      "language-gfm",
      "language-gfm",
      "language-gfm",
      "language-gfm",
      "language-gfm",
      "language-gfm"
    ],
    "themes": [
      "atom-material-ui",
      "atom-material-syntax"
    ]
  },
  "editor": {
    "fontSize": 16,
    "invisibles": {},
    "showIndentGuide": true
  }
}

Installed Packages
# User
atom-material-syntax, v0.4.3
atom-material-ui, v1.1.3
autocomplete-python, v1.6.1
build-cargo, v0.12.0
ex-mode, v0.8.0
language-idris, v0.4.1
language-latex, v0.6.1
language-markdown, v0.11.0
language-monte, v0.1.1
language-rust, v0.4.6
linter, v1.11.3
linter-csslint, v1.3.1
linter-flake8, v1.11.0
linter-jshint, v2.0.2
linter-markdown, v1.5.0
linter-python-pep257, v0.0.1
linter-rust, v0.4.0
markdown-preview-plus, v2.2.2
minimap, v4.19.0
minimap-git-diff, v4.1.8
racer, v0.18.0
rust-api-docs-helper, v0.5.1
vim-mode, v0.64.0
vim-mode-visual-block, v0.2.15

# Dev
No dev packages

And Atom racer settings:

Oh okay, you only get that one error? Well, I just did the basic troubleshooting of things I went through by myself, seems like this might actually be a bug which the creator (@edubkendo) should have a look at.

racer is working properly with the following setup:

Note that you need to specify the absolute path to the user's directory, rather than using the tilde if you're on linux

I can confirm that the issue is now resolved.

For me works too.
Atom: 1.7.4
Rust: 1.8.0

I had this problem and solved it by removing trailing whitespace in my path. I would suggest either trimming the contents of the path, or at the very providing a properly descriptive error message.

Same for me, the 'Detect Binaries' feature actually puts trailing whitespaces in the path, which will result in the above error messages (I am on Windows btw).

https://github.com/edubkendo/atom-racer/issues/64

I managed to fix today using this method https://github.com/edubkendo/atom-racer/issues/61#issuecomment-272695463

https://github.com/edubkendo/atom-racer/issues/61

I managed to fix this issue today via https://github.com/edubkendo/atom-racer/issues/61#issuecomment-272695463

This is still happening on Windows 10. The autocomplete works but throws an error with every character typed. Quite unusable

If you are having problems with permission issues with rust in general (some things will still work, but you get other errors outside of racer):
Step 1) Fix permissions:
cd /usr/local
sudo chown -R <your-username>:<your-group-name> *

don't know your group name?: id -g
Step2) Reinstall rust (it didn't properly get added to /usr/local:
curl https://sh.rustup.rs -sSf | sh
Step3) Reinstall cargo package racer:
// if already installed:
cargo uninstall racer
// then install:
cargo install racer

.
NOW configure it in atom:
Path to racer config:
/Users/{username}/.cargo/bin/racer
.
Step4) Get rust source code:
rustup component add rust-src
and the path will be:
/Users/{username}/.multirust/toolchains/stable-x86_64-apple-darwin/lib/rustlib/src/rust/src
The stable-x86_64-apple-darwin probably will look a bit different than yours. So check your path first.

I had this issue too, in my case I installed the racer package with atom package manager. Thing is, the package is installed as racer-v2, so when I set the path to the racer executable and rust sources, it kept throwing me this error because in file config.cson, those parameters where under "racer-v2" package section. I changed it to "racer" and it worked (config made within Atom's UI was erased).


Make Jax buildable with the latest Bazel

Without this change build script fails with the following message:
Encountered error while reading extension file 'tensorflow/workspace.bzl': no such package '@org_tensorflow//tensorflow': The native http_archive rule is deprecated. load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") for a drop-in replacement.

This PR simply implements the suggestion outlined in the error. I was able to successfully build against CUDA10 and latest cuDNN on Ubuntu 16.04, after applying this change.

FYI, I did sign the CLA. Not sure why it says it's not signed.


{{ config.companyAddress }} appearing twice on invoice and delivery note

This issue initially has been solved with NEXT-34382 in the past. However, in current versions the company address will be shown twice on invoices and delivery notes, again.
Removing the following block from the letter_header.html.twig and delivery_note.html.twig solves this issue - at least as a workaround:
{noformat}{% if config.displayCompanyAddress and config.companyAddress is not empty %}
{{ config.companyAddress }}
{% endif %}{noformat}

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-38834
[created from NEXT-38834, comment 502558]


support for setting/sending multiple cookies

This patch adds support for using multiple cookies set by the same server, when using stickycookies.
The original code only remembered the last cookie set.
Testcase through: mitmdump -t "."
visit https://httpbin.org/cookies/set?helloWWW=worldZZZ&xxx=yyy
then flush cookies from your browser
and finally visit https://httpbin.org/cookies

Thanks for the excellent PR! :smiley:
It'd be great if you could add a small test at test/mitmproxy/test_flow.py, but we can take that over if you are busy with other things.

I've switched to defaultdict, simplified the list comprehension with .values() and squashed the new commits into one. I'll have a look at the test as well later today

Awesome. Thanks so much for the great PR! :smiley: :cake: :tada:


Package and publish new Perspective view release

[x] update dev dependencies to latest
[x] create v1.6.0 change log
[x] update docs and pics
[x] package and publish tabular-data-viewer-v1.6.0.vsix

see release notes and v1.6.0 changelog for info: https://github.com/RandomFractals/tabular-data-viewer/releases/tag/v1.6.0


In Super Admin Exams Section... Where can i add Term Exam name

In Super Admin Exams Section... Where can i add Term Exam name... please give reply

Please clarify your question

In exams section Exams List -> Add Exam -> Showing First Term, Second Term .....Where can i edit those..
In exams section Marks ->Showing 1ST CA (20), 2ND CA(20), EXAM (60).. Where can i change these things..

Pins are used in result checking, if pins are enabled, students wouldn't be able to check their results without supplying a pin
Your first issue, this is unfortunately not possible. You can't change them
Your second issue, also not possible
I know of a package that would allow you to do that but I wouldn't mention it here for a few personal reasons
If you are interested hit me up via email
<EMAIL_ADDRESS>


_clearCache function missing trailing )

added trailing ) on "hasOwnProperty(setting))" on line 301

Good cache ;)


AV1 video support

Could Lagrange support AV1 video?
At the moment, the default behaviour is to open links to such content in a different browser.
https://av1.webmfiles.org/#
https://aomedia.org/av1/

At least for the time being, I feel that video playback is too complex to be an integrated part of the application (too many commonly used codecs, HW support, multiple new dependencies, platform-dependence, etc.). In these cases I think it's better to rely on separate specialized apps or the platform's video playback features. Currently there isn't even support for animated GIFs (#183).
What could be done instead is to recognize more video formats and do a tighter integration with specific external players like mpv.


feat: Wildfly log plugin

Proposed Change

Created Wildfly plugin

Checklist

[x] Changes are tested
[ ] CI has passed

Little disclaimer on this one, in the field attribute.log.filename I forgot to change the sample log file to wildfly so although the name of the file is solr it still contains wildfly logs.


Add a method to disable rotations on RigidBody.

The common way of doing this is to set its angular inertia to zero. However, users unfamiliar with inertia may not think of it. Thus we should add a method that does that.

This has been added to nphysics v0.10. See https://www.nphysics.org/rigid_body_simulations_with_contacts/#kinematic-degrees-of-freedom


Review request for Microsoft.ConfidentialLedger to add version preview/2024-01-26

Data Plane API - Pull Request
Confidential Ledger is adding a new API to list users. A new preview API (2024-01-26-preview) is added, and a new API to list users
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Link to API Spec engagement record issue:

Is this review for (select one):

[ ] a private preview
[X] a public preview
[ ] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

Design Document: Doc
Previous API Spec Doc:
Updated paths: /app/users

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Azure DevTools Wiki

Checks stuck in `queued` state?
If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`.
This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.

fix https://github.com/Azure/azure-rest-api-specs/issues/28064

The required check Breaking Change(Cross-Version) is failing due to changes that are not related to this new API version (see details).
Given that the https://github.com/Azure/azure-rest-api-specs/pull/21659 also had the same detected breaking changes and was eventually approved, I've added the BreakingChange-Approved-Previously label.

@DominikMe , @johanste , the changes have been approved by the API review board, and the current build check breaks are not caused by this change, see this comment.  Awaiting your reviews, thank you!

@DominikMe , @johanste , can we request for a review on this PR?  Is there anything we need to do to move this along? Thanks in advance!

/pr RequestMerge


Overloaded functions may not be detected

The lookup_function() function in symbol_table is not using argument_types in it's evaluation. As such, it may detect foo(x, y) and foo(x) as a call to the same method.

Does 4eba68c0774484acfa34d98ef1e152fef6a2c17b address this issue?

Yes. foo(x, y) should not be confused with foo(x) and vice-versa.

Sweet. Closing this then.


chore: POC progressive loading variant 2

Description
An alternative to https://github.com/cloudscape-design/components/pull/2108
Related links, issue #, if available: n/a
How has this been tested?

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closed in favour of https://github.com/cloudscape-design/components/pull/2274


Create a REST controller for the adminstration

In the Rest controller:

list workers
start / stop a worker

Done


Cast icon for prejoin

Feature Request
Need an icon for casting in pre-join screen
Problem description
A clear and concise description of what the problem is. Ex. I have an issue when [...]

https://github.com/stardust-ui/react/pull/585

#1278


Adjust paths order

Summary
Move $(pwd)/dist to the end of PATH as the last choice of devbox binary.
How was it tested?

Close https://github.com/jetpack-io/devbox/issues/781

PTAL @gcurtis @mikeland86

@mikeland86 I think you added this. Are you okay with putting dist/ at the end of the PATH?

This is part of my workflow but if it's messing with other people's I'm OK removing it (I think removing is a bit better than appending it is very likely that everyone developing devbox has devbox installed). I thought this would be helpful to others, but If others don't use it this way, I can just modify my own PATH.
My workflow is usually using devbox shell to develop devbox. So I'll start a shell and then run devbox run build and test it out.
@gcurtis can you share your GOBIN workflow? In some cases it can be important that the default devbox binary is the development one because in some cases devbox calls itself so if we don't change the default devbox we end up calling production one instead.

@mikeland86 it's just go install ./cmd/devbox; devbox. I have GOBIN set to ~/bin so that's where the built binary gets placed. But if I had run devbox build at some point earlier, then the build in dist always gets launched.
Sometimes I also test things out in a temp directory in a new terminal:
$ cd `mktemp -d`
$ devbox init
...

In that case I'm not in a devbox shell.

@gcurtis should we also change build to be go install ./cmd/devbox ? And just let individual developers set GOBIN?


Not share node in Rete Network

I fork your code and try to use it. When I create some Rules which have the same operator. But when I ran, I saw the repeat in the calculation
I used the examples/rulesapp
Here is my config for ruelsapp.json:
[   {     "name": "n1",     "properties": [       {         "name": "name",         "type": "string",         "pk-index": 0       },       {         "name": "age",         "type": "number",         "pk-index": 1       },       {         "name": "address",         "type": "string",         "pk-index": 2       }     ]   },   {     "name": "n2",     "properties": [       {         "name": "name",         "type": "string",         "pk-index": 0       },       {         "name": "wife_name",         "type": "string",         "pk-index": 1       },       {         "name": "child_name",         "type": "string",         "pk-index": 2       }     ]   } ]
Here is main function
https://github.com/DucVuMinh/rules/blob/chech_rete_work/examples/rulesapp/main.go

@DucVuMinh mentioned calculations are repeated because the same condition function checkForBob added to both rule & rule2.
Use below like code snippet to understand the behavior:
rule2.AddCondition("c1", []string{"n1"}, **checkForBob2**, nil) //update print statements of checkForBob2 to distinguish from checkForBob
rule2.AddCondition("c1.1", []string{"n1"}, **checkAge2**, nil)

@rameshpolishetti how i can use share node. Can you give me a example


Allow non-HTTPS connection to S3 storage

At present, the protocol used to connect to an S3 media backend is hardcoded to HTTPS:
https://github.com/jointakahe/takahe/blob/2f546dfa74e38fab5bf47a2f4da04e6008010fd7/takahe/settings.py#L445
I have deployed Takahe in k8s, with S3 storage provided by rook-ceph, so network traffic between Takahe and the S3 backend is over a private network. This is a legitimate use case for HTTP, but it is not currently possible to specify this in the Takahe settings.

Hmm, that is an interesting use case. I don't think normal S3 allows non-HTTPS access for most things, so it's probably safe to allow a protocol to be specified?

If there are no objections, shall I submit a PR?

Yes, go for it - I would suggest adding an option for s3-insecure:// as a protocol that Takahē understands for the media URL and then doing the setup based on that.

Implemented in #658.


Enable MD5 checksums when uploading a multi-block file to Azure Blob

Enable MD5 checksums when uploading a multi-block (a.k.a. multipart) file to Azure Blob Storage
What is the purpose of this change?
git git push  assuming that the API does not supports MD5 checksum in the PutBlockList call, but according to the doc it's supported (https://docs.microsoft.com/en-us/rest/api/storageservices/put-block-list) and actually it was already supported by the underlying API helpers:

The azureblob backend propagates the headers when committing the block list: https://github.com/ncw/rclone/blob/b353c730d8d248c55ab86d9efd889427457b4ab9/backend/azureblob/azureblob.go#L1362
Checksum is read from the headers in the CommitBlockList https://github.com/ncw/rclone/blob/b353c730d8d248c55ab86d9efd889427457b4ab9/vendor/github.com/Azure/azure-storage-blob-go/azblob/url_block_blob.go#L99
Then the MD5 checksum is sent using the x-ms-blob-content-md5 header  https://github.com/ncw/rclone/blob/b353c730d8d248c55ab86d9efd889427457b4ab9/vendor/github.com/Azure/azure-storage-blob-go/azblob/zz_generated_block_blob.go#L102

Was the change discussed in an issue or in the forum before?
Doesn't seems ... found the issue, fixed it :)
Checklist

[x] I have read the contribution guidelines.
[ ] I have added tests for all changes in this PR if appropriate.
[ ] I have added documentation for the changes if appropriate.

[x] I'm done, this Pull Request is ready for review :-)

A very nice change - thank you :-)
I'll merge it now


Refactor: call it option_name, instead of key_sym

This an internal name-change refactoring to ParserFile:

call each settings key an option_name, instead of key_sym
also, add an IRREGULAR_OPTIONS hash to explain why we translate option name to an option key
rename a method to #option_key_for to avoid mixing up with i18n ("translate" can be a loaded word)

@skywinder I felt this was a missing piece from the feature addition.


Cannot find latest version in Jetbrains Marketplace

The latest version in Jetbrains Marketplace is still 1.7.0

That's as expected since incremental compiler updates are not necessary to the IntelliJ plugin.

That's as expected since incremental compiler updates are not necessary to the IntelliJ plugin.

I will upload an update for 1.7.4 to reduce confusion. Thank you.

I will upload an update for 1.7.4 to reduce confusion. Thank you.

Thanks for your response.

Thanks for your response.


The last published release is 2.0.0, but bower.json is updated to 3.0.0

Currently, the latest published tag is v2.0.0 - see https://github.com/jacereda/purescript-arraybuffer/tags to verify.  However, the dependencies have been updated since then - see e.g. https://github.com/jacereda/purescript-arraybuffer/blob/61a273192b889784ddc1c18ad4ad9dd7403249e2/bower.json
Did you mean to publish a new release compatible with 0.10?  Since git tags aren't pushed by default, you might have accidentally forgotten to git push origin v3.0.0.

I was probably waiting for -uint to update its dependencies so I could get rid of the "resolutions" in bower.json, but somehow I forgot about it at some point.
Thanks!


Needs more info

The descriptions of tasks are great. It just doesn't state clearly what each task actually does.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 94ca5e7d-d25c-2b11-44fe-620946cf4577
Version Independent ID: 224fdc61-9afd-d790-3aea-d83ce567315f
Content: Customize Microsoft Security Code Analysis tasks - Azure
Content Source: articles/security/develop/security-code-analysis-customize.md
Service: security
GitHub Login: @vharindra
Microsoft Alias: terrylan

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.


NAVBAR FIX [ENHANCEMENT]

HI @codervivek5
I would like to fix the navbar for all media widths as it is not responsive at all and is bad for User Experience.
**Reference to issue **

I am also providing a reference image of the navbar from my previous projects which is 100% responsive for all media widths.

I will add a better navbar keeping the theme of the web page in mind. Please assign me this issue under GGSOC 23'
Regards Priyam Maini

make it for mobile resposive


Storage: local JSON file

This project seems like the only candidate so far to build a simple local IPAM (with "database" checked into git repository), but it was missing this type of storage, so I have implemented it as a local JSON file:

uses internal Memory backend for operating on the data

preserved it's internal data structure in the output

"refreshing" from file on reads and fully reloading on writes based on tracking of modification times
json.go for serialization and deserialization of Prefixes

It is pretty barebones and could be improved, but should be good enough for easy evaluation of the project/library with persistence enabled.
some improvements I thought of:

fix Dump()/Load() losing some informations (eg: Namespaces) and reuse this logic as a JSON data structure
could involve file system locking of files (didn't go with it at the start because it's pretty unix'y feature)
could be more performant:

split into multiple files for smaller edits
more efficient reload (eg: diff the data instead of clearing and loading whole file)

Linter complains:
  Error: G306: Expect WriteFile permissions to be 0600 or less (gosec)
  Error: type `testableFileStorage` is unused (unused)
  Error: type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors (errorlint)
  Error: comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)

  Error: issues found

I think there is nothing wrong with your approach, but have you considered using SQLite instead, this would also be a local storage solution but with all the downsides you mentioned fixed ?
I started such a support back then, but havent enough time to finish that.

Yeah my first thought was using SQLite, but this would not advance in any meaningful way my use case of checking state into the repository in a human readable format.

not sure what is this error ERROR: denied: installation not allowed to Write organization package

not sure what is this error ERROR: denied: installation not allowed to Write organization package

PRs from outside the metal-stack org are not allowed to push to our registry, this is nothing to worry about. We where not able to implement this in the CI that the push is not executed in such a case.

Codecov Report

Merging #123 (04f4405) into master (6f010ba) will decrease coverage by 0.73%.
The diff coverage is 57.57%.

:exclamation: Current head 04f4405 differs from pull request most recent head bb6d2bd. Consider uploading reports for the commit bb6d2bd to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   64.85%   64.13%   -0.73%
==========================================
  Files          10       11       +1
  Lines        1491     1656     +165
==========================================
+ Hits          967     1062      +95
- Misses        341      380      +39
- Partials      183      214      +31

Files Changed
Coverage Δ

file.go
57.57% <57.57%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Nice, its still quite fast:
BenchmarkNewPrefix/MongoDB-2    	     662	   1790806 ns/op	   34140 B/op	     397 allocs/op
BenchmarkAcquireIP/Memory-2     	  255164	      4491 ns/op	    2224 B/op	      43 allocs/op
BenchmarkAcquireIP/File-2       	    2041	    543635 ns/op	   20134 B/op	     210 allocs/op
BenchmarkAcquireIP/Postgres-2   	     310	   3839610 ns/op	   10969 B/op	     262 allocs/op
BenchmarkAcquireIP/Cockroach-2  	     135	   9741293 ns/op	   10964 B/op	     261 allocs/op
BenchmarkAcquireIP/Redis-2      	     921	   1340158 ns/op	   11822 B/op	     272 allocs/op
BenchmarkAcquireIP/Etcd-2       	     345	   3552269 ns/op	   63949 B/op	    1073 allocs/op
BenchmarkAcquireIP/KeyDB-2      	     872	   1487534 ns/op	   11820 B/op	     272 allocs/op
BenchmarkAcquireIP/MongoDB-2    	     651	   1842363 ns/op	   40701 B/op	     532 allocs/op

Can you add the filesytem backend into the Readme, skip the benchmark numbers for now.


Sum causing exception in some treemaps

Use the "whiskey" data with the following Brunel:
 treemap x(Category, Brand) color(Rating) size(Price) sort(#count) label(ABV) tooltip(#all, Name) sum(Price) mean(Rating) min(ABV) list(Name:50)
Getting exception:
[err] java.lang.NullPointerException [err] 	at org.brunel.data.summary.SummaryValues.get(SummaryValues.java:73) [err] 	at org.brunel.data.modify.Summarize.make(Summarize.java:173)

Issue was caused by a group containing nothing but null values;  added a fix to check for that


Cannot find module "mousetrap-global-bind"

I'm trying to use shortcuts from an Electron app, and I'm using webpack to bundle npm packages, it throws this error:
Cannot find module "mousetrap-global-bind"

This package is wrtten to work for browserify. I am assuming that's the reason you're getting that error.
Afaik webpack doesn't automatically process the browser field inpackage.json see this. But there is a solution here: https://github.com/webpack/webpack/issues/151

Thank you


Role-Based Adaptive Authentication do not work with a Service Provider of a SAML application in a SSO scenario

Suggested Labels:
Affected : 5.7.0
Severity: Blocker
Priority: Highest
Type: Bug
Steps to Reproduce the issue:

Setup SAML application and the service provider with SAML configuration as given in Configuring a Service Provider for Adaptive Authentication.
Set up role-based adaptive authentication for previously created Service Provider as given in Configuring Role-Based Adaptive Authentication.
Login to the WSO2 IS Dashboard (https://localhost:9443/dashboard) using admin credentials.
Then go the index page of the SAML application (http://localhost.com:8080/saml2-web-app-pickup-dispatch.com/) and click the login button.
This should redirect to Adaptive Authetication page but this will skipped the Adaptive Authentication.The admin role has been authenticated successfully only after going through the basic authentication.

This issue's cause is FLOW_STATUS parameter [1]
AuthenticatorFlowStatus flowStatus = (AuthenticatorFlowStatus) request
                .getAttribute(FrameworkConstants.RequestParams.FLOW_STATUS);`

When the request come from SAML component the FLOW_STATUS is set to null value. However, the OAuth components set this value to COMPLETED value when the request come. Therefore, this scenario is working for OAuth applications.
[1]. https://github.com/wso2/carbon-identity-framework/blob/master/components/authentication-framework/org.wso2.carbon.identity.application.authentication.framework/src/main/java/org/wso2/carbon/identity/application/authentication/framework/handler/sequence/impl/GraphBasedSequenceHandler.java#L415

This issue already identified with https://github.com/wso2/product-is/issues/3717 and fixed with https://github.com/wso2/carbon-identity-framework/pull/1900 in master


Add ZSH completion

I was able to use the bash completion script to work in my zsh (5.0.5, OS X) with the following:
autoload bashcompinit
bashcompinit
source /path/to/projectionist/completion.bash

That is an excellent work around! I still definitely want to do native zsh completion at some point, but this is really helpful in the meantime.


Basic auth creation with duplicate username for more than one consumer

Summary
i tested creating basic auth for a consumer. i then created basic auth for another consumer with the same username. it did not fail.
Steps To Reproduce

http://localhost:8001/consumers/{consumer_id}/basic-auth

{
"username": "shanelee007"
}
Get a 201 when i create the above request for two different consumers.
Additional Details & Logs

Kong version 0.9.8
Operating System OSX

Hi,
Thanks for the report. This was fixed in 23389d616831ebc21c155fbed34545025a98cc94 and will be part of 0.10.0.

thanks @thibaultcha  any chance you can update the plugin doc to explain the username is unique? And what error responses can return?
https://getkong.org/plugins/basic-authentication/
Also, i do not see an example request/response to verify the credentials work. can that be added in?

@shavo007 the docs are in https://github.com/Mashape/getkong.org/tree/master/app/plugins. Can you please send a PR?

If i may ask, what are the reasons for the consumer username to be uniq? I would like to have the same username but different password for 2 consumers and it's currently not possible (v0.11)


DealFieldsApi->getDealFields() fails with error 'Class 'FieldTypeAsString' not found'

Hi everyone,
I'm running pipedrive/pipedrive:5@beta and when using the getDealFields function on DealFieldsApi, it fails with 'Class 'FieldTypeAsString' not found'. My code is added below.
Other endpoints like POST deals is working perfectly.
Who has an idea what goes wrong?
        $apiKey = Environment::getEnv('PIPEDRIVE_API_KEY');
        $companyDomain = Environment::getEnv('PIPEDRIVE_COMPANY_DOMAIN');

        $host = str_replace('{{companyDomain}}', $companyDomain, 'https://{{companyDomain}}.pipedrive.com/v1');

        $this->configuration = (new Pipedrive\Configuration())
            ->setApiKey('api_token', $apiKey)
            ->setHost($host);

       $apiInstance = new Pipedrive\Api\DealFieldsApi(
            new GuzzleHttp\Client(),
            $this->configuration
        );

        try {
            $result = $apiInstance->getDealFields(0, 10);
            print_r($result);
        } catch (\Exception $e) {
            print_r('Exception when calling DealFieldsApi->getDealFields: ' . $e->getMessage());
        }

I get this problem too.

Hi,
Thank you for reporting the issue.
Version 6.1.0 has been just released with the fix.

Does this also fix that jsonserializer will return "mixed" when this is not supported in php 7.4?

@chrisTrung No, 6.1 doesn't include a fix for the issue.
We will try to look into the problem and get back with an update there in the issue. But FYI, since 7.4 version had the end of life already in November 2022, we're considering dropping its support.

Closing due to no recent activity.
If you are running into a similar problem, feel free to create a new GitHub issue.
Thank you.


Add a hover effect on know more button in the home page

Proposal
I want to add hover effect on know more button exactly like the login/signup button in the header tab ,  using css.
Please consider this under GSSOC'21.

Kindly consider assigning this issue to me under GSSOC '21.

Please find some valid issues, Adding hover property to one button is not an issue.


interface watchdog timeout / interface link state DOWN UP

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
I have OPNsense 22.1 installed on a mini pc MSI Cubi N 8GL-079DE and have connection issues. When doing a speed test or it is consistently "crashing" and also sometimes while browsing or using the web GUI. I can see the following on the monitor after boot:
*** SecondaryFw.localdomain: OPNsense 22.1.1_3 (amd64/OpenSSL) ***

 LAN (re0)      -> v4: <IP_ADDRESS>/24
 WAN (re0_vlan10)   -> v4/DHCP: [...IP...]
                      v6/DHCP: [...IP...]

 HTTPS: SHA256 [... hexadecimal numbers ...]
               [... hexadecimal numbers ...]

FreeBSD/amd64 (SecondaryFw.localdomain) (tttyv0)

login:

after "forcing" the problem with a speed test it adds following lines:
re0: watchdog timeout
re0: link state changed to DOWN
re0_vlan10: link state changed to DOWN
re0: link state changed to UP
re0_vlan10: link state changed to UP

After a few seconds (I guess 10-30s) the connection is back and the problem can happen again. That's why the monitor looks like this:
[...]

FreeBSD/amd64 (SecondaryFw.localdomain) (tttyv0)

login: re0: watchdog timeout
re0: link state changed to DOWN
re0_vlan10: link state changed to DOWN
re0: link state changed to UP
re0_vlan10: link state changed to UP
re0: watchdog timeout
re0: link state changed to DOWN
re0_vlan10: link state changed to DOWN
re0: link state changed to UP
re0_vlan10: link state changed to UP
re0: watchdog timeout
re0: link state changed to DOWN
re0_vlan10: link state changed to DOWN
re0: link state changed to UP
re0_vlan10: link state changed to UP
re0: watchdog timeout
re0: link state changed to DOWN
re0_vlan10: link state changed to DOWN
re0: link state changed to UP
re0_vlan10: link state changed to UP

To Reproduce

Installed 22.1 on my device
Created VLans and other settings
making a speed test (for example fast.com)
Network connection issue

Expected behavior
Continuous working internet connection
Relevant log files
Dashboard -> System -> Log Files -> General
system.log
Additional context
I tried updating from 21.7 to 22.1 the first time and fresh install two times after. I do not have this problem with 21.7 and before, I did also a fresh install of it and worked without a problem. I am currently running 22.1 with an Intel NIC 4x 1GB (pcie passthrough) on my home server in a VM. I am not using VLans there and was not able to test VLans yet due to needed uptime. I am guessing it has to do with the VLan, because i have no problem with the VM on my server without them.
Environment
OPNsense 22.1 and 22.1.1 testet not working
OPNsense 21.7 tested working
MSI Cubi N 8GL-079DE:

Intel Pentium N5000 1.1Ghz Quad Core
4GB RAM
LAN Realtek RTL8111H

duplicate of https://github.com/opnsense/src/issues/155


Refactor/Cleanup

This is a signification refactor that strips away lots of unneeded codes, and fixes a number of outstanding issues, like https://github.com/kubernetes-incubator/metrics-server/issues/56.

I tried now, but the deployment does not work.
It looks like something trivial
kubectl -n kube-system logs metrics-server-59d9ffd56-xg6zv
Error: unknown flag: --source

I tested the current version. Problem with IPv6 mentioned in #56 is fixed. I have now the following certificate problem:
ubuntu@k8s-master:~/metrics-server$ kubectl logs -n kube-system metrics-server-6bcfdcdd-f7xnr --follow
I0720 07:58:06.000527       1 serving.go:273] Generated self-signed cert (apiserver.local.config/certificates/apiserver.crt, apiserver.local.config/certificates/apiserver.key)
Scrape Timeout: 54s
[restful] 2018/07/20 07:58:06 log.go:33: [restful/swagger] listing is available at https://:443/swaggerapi
[restful] 2018/07/20 07:58:06 log.go:33: [restful/swagger] https://:443/swaggerui/ is mapped to folder /swagger-ui/
I0720 07:58:06.970052       1 serve.go:96] Serving securely on [::]:443
E0720 07:59:06.959471       1 manager.go:94] unable to fully collect metrics: [unable to fully scrape metrics from source kubelet_summary:k8s-master: unable to fetch metrics from Kubelet k8s-master (<IP_ADDRESS>): Get https://<IP_ADDRESS>:10250/stats/summary/: x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs, unable to fully scrape metrics from source kubelet_summary:k8s-3: unable to fetch metrics from Kubelet k8s-3 (<IP_ADDRESS>): Get https://<IP_ADDRESS>:10250/stats/summary/: x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs, unable to fully scrape metrics from source kubelet_summary:k8s-2: unable to fetch metrics from Kubelet k8s-2 (<IP_ADDRESS>): Get https://<IP_ADDRESS>:10250/stats/summary/: x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs, unable to fully scrape metrics from source kubelet_summary:k8s-1: unable to fetch metrics from Kubelet k8s-1 (<IP_ADDRESS>): Get https://<IP_ADDRESS>:10250/stats/summary/: x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs]
E0720 07:59:19.224069       1 reststorage.go:92] unable to fetch pod metrics for pod kube-system/openstack-cloud-controller-manager-k8s-master: no metrics known for pod "kube-system/openstack-cloud-controller-manager-k8s-master"

I was able to fix the TLS certificate problem passing to the metrics-server the option --kubelet-insecure-tls.
Now I have other permissions problem. I guess the deploy folder should be patched with a working setup.
E0720 08:13:56.389732       1 manager.go:94] unable to fully collect metrics: [unable to fully scrape metrics from source kubelet_summary:k8s-master: unable to fetch metrics from Kubelet k8s-master (<IP_ADDRESS>): request failed - "403 Forbidden", response: "Forbidden (user=system:anonymous, verb=get, resource=nodes, subresource=stats)", unable to fully scrape metrics from source kubelet_summary:k8s-2: unable to fetch metrics from Kubelet k8s-2 (<IP_ADDRESS>): request failed - "403 Forbidden", response: "Forbidden (user=system:anonymous, verb=get, resource=nodes, subresource=stats)", unable to fully scrape metrics from source kubelet_summary:k8s-3: unable to fetch metrics from Kubelet k8s-3 (<IP_ADDRESS>): request failed - "403 Forbidden", response: "Forbidden (user=system:anonymous, verb=get, resource=nodes, subresource=stats)", unable to fully scrape metrics from source kubelet_summary:k8s-1: unable to fetch metrics from Kubelet k8s-1 (<IP_ADDRESS>): request failed - "403 Forbidden", response: "Forbidden (user=system:anonymous, verb=get, resource=nodes, subresource=stats)"]

@DirectXMan12 not sure where the problem is. I logged into a shell in the pod
kubectl -n kube-system exec -ti metrics-server-566d6454f-swjwt /bin/sh
Then I tested the metric-server credentials like this:
wget -q -O - --header "Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" https://kubernetes.default.svc.cluster.local/api/v1/nodes

it seems to work. I have a HTTP 200 and I get data.

Adding --authentication-token-webhook to the kubelet command line arguments fixed all the authorization problems.

NB: my convention with TODOs is that if it's in the form TODO: xyz, I want to fix it pre-pr-merge.  If it's in the form TODO(<name>): xyz, I think we can evaluate it in another PR if need be.

/lgtm

we need to get the merge bot working on this repo.  In the mean time, I'll press the green button.

Great work - thank you!
How often are Docker images built as I would like to roll these updates out to our clusters? Are the images only built for full releases?

I'll have to take a look at how we get these set of images built.  I think at the moment, it requires some Googler intervention.  @piosz or @kawych can probably confirm.


Do not compile with -Werror

Revert the addition of -Wno-deprecated-copy and do not compile with -Werror.

merge for Vesko since he doesn't have permission to.


Stream the OpenAI Completion

Good Day, Sir!
How can I stream the OpenAI Completion?
I tried it on my end, but I can't make it.
Reference:
https://www.beskar.co/blog/streaming-openai-completions-vercel-edge

Just closing this project should help you stream the completion. What are you struggling with specifically?

Closing for now, feel free to re-open or DM me on twitter if you have questions.


Updating ParametersRef docs and examples to be cluster-scoped

This matches the scoping of the GatewayClass and matches the intention of parameters being configured with implementation specific custom resources.
Fixes https://github.com/kubernetes-sigs/service-apis/issues/144
/cc @jpeach @hbagdi

Question: If an implementation doesn't want to use a CustomResource for this purpose and wants to resort to a ConfigMap, that is not possible? If yes, why do we want to impose such a limitation?

@hbagdi, that's a great question. I did not add enough context here. I think I gave a better summary as I was closing my previous PR related to this (https://github.com/kubernetes-sigs/service-apis/pull/183#issuecomment-673109175)

https://github.com/kubernetes-sigs/service-apis/pull/183#issuecomment-673109175

I somehow missed that activity in my notifications.

Secrets are potentially interesting but I don't think I've seen any use cases for GatewayClass parameters that would benefit from Secrets.

You could have an operator running in the cluster that reconciles Gateways associated with a specific GatewayClass by spinning up infra inside and outside the k8s cluster. To do this, it requires a set of credentials, stored in Secrets. Now, one can argue that the secrets then should be part of the deployment of the operator and not the GatewayClass.
I think it is safer to start with cluster-scoped references and then re-evaluate this if the above hypothetical case becomes a reality.

You could have an operator running in the cluster that reconciles Gateways associated with a specific GatewayClass by spinning up infra inside and outside the k8s cluster. To do this, it requires a set of credentials, stored in Secrets. Now, one can argue that the secrets then should be part of the deployment of the operator and not the GatewayClass.

I think it is safer to start with cluster-scoped references and then re-evaluate this if the above hypothetical case becomes a reality.

I agree with all of that. If we want to support namespace-scoped params here in the future, I think the starting point is convincing the broader sig-network community that IngressClass params should be namespace-scoped. If we can build consensus there, I think it's a no brainer to add the same capability here.

@robscott thanks for addressing https://github.com/kubernetes-sigs/service-apis/pull/286#discussion_r486641898, LGTM.

@robscott Needs another rebase.
/lgtm

@hbagdi just rebased this PR, please take another look when you have time.

@robscott Needs more rebasing.

@hbagdi Rebased once more, don't think there are any more PRs open that will conflict with this.

LGTM

/lgtm


Enable PowerShell in argcomplete

Currently, argcomplete does not support PowerShell (https://github.com/kislyuk/argcomplete/issues/166).
However, it is possible to write PowerShell script to enable argcomplete:
https://github.com/tibortakacs/powershell-argcomplete
This solution works well in PowerShell, however, it requires minor modification of the application which uses argcomplete (create special output stream, see at https://github.com/tibortakacs/powershell-argcomplete/blob/82c79a752dd0ebdeca5e7aa4e929f04253999363/mat.py#L92).
This is necessary because PowerShell does not support file descriptor '8'.
This PR would take a step forward, and enable argcomplete in PowerShell without any modification of the applications:
https://github.com/tibortakacs/powershell-argcomplete/tree/poc_add_ostream_logic_to_argcomplete
This approach introduces a new environment variable to specify the output stream's file descriptor. The PowerShell script could just set the value to '2' (stdout) which stream is used to gather completion results.
Looking forward to your opinion.

Codecov Report

Merging #302 into master will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   82.72%   82.61%   -0.12%
==========================================
  Files           7        7
  Lines         741      742       +1
==========================================
  Hits          613      613
- Misses        128      129       +1

Impacted Files
Coverage Δ

argcomplete/__init__.py
91.06% <0.00%> (-0.26%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651e9fe...f51a8ef. Read the comment docs.

The issue with stdout/stderr is they require the script's cooperation in not printing anything to them during argcomplete invocations, which is fine for scripts you write and maintain, but isn't part of argcomplete's general contract and can't be guaranteed to work with arbitrary argcomplete-compatible scripts.
Options for Windows support (in the context of Git Bash support) have been discussed in the past on #267 and #142, where @kislyuk suggested using WSL or investigating other IPC mechanisms on Windows. I was unable to find any IPC mechanisms that could be conveniently accessed from the command line, though I did not investigate Powershell at all.
If you are not able to find a Powershell-specific IPC mechanism, then the ability to opt-in to using stdout - with the associated caveats - seems like the next best option as far as I can see. Ultimately it is up to @kislyuk whether this feature is acceptable.

@evanunderscore Thank you for your response. You are right, this solution is not perfect because applications can use stdout before calling autocomplete. However, I believe this is discouraged by the pattern how argcomplete should be used.
Due to this, we can consider to change the approach: instead of passing file descriptor, we can make stdout usage explicit (_ARGCOMPLETE_OSTREAM_USE_STDOUT). It is less flexible but more obvious for the developers of the effect of the settings.
In the mean time, I have been working on some better IPC mechanism using memory mapped files, I am sure though it will be successful or not. I would surely require using Win32 DLLs (e.g. kernel32) with ctypes (https://docs.python.org/2/library/ctypes.html). Would be this an accepted option if it works?
@evanunderscore @kislyuk Looking forward to your opinion.

Thanks for the thoughtful discussion.
I'm OK with parameterizing the fd in this way, as long as the default remains unchanged. I would not be OK using kernel32 via ctypes in argcomplete :)
With that said, in order for this PR to be merged, it would have to add appropriate documentation and specific instructions for how to use this functionality in PowerShell.

I've had another look into this, and managed to get a handle-based solution working. I've put up draft PR #305. Would something along these lines help you from PowerShell @tibortakacs?

@evanunderscore Thank you for the update. Not totally sure, I have to check whether the handle-based solution is supported by PowerShell or not. I am going to send feedback soon*.
(*It might take a few days, I am OoO now. Sorry for the delay.)

While it would be ideal if PowerShell is able to perform the handle manipulation natively, the point of the Python wrapper on my branch is that it does the work for you. At the cost of running the interpreter one additional time, you get a program that outputs only the completions on stdout and nothing else. Interested in your opinion on whether this trade off is worthwhile.

@evanunderscore Thank you for the head-up. What do you mean "running the interpreter one additional time"? Could you please give me a short explanation how your solution is expected to work?
I have player with PowerShell and stdout handles. I am almost there, however, I found a small discrepancy yet. When I use GetStdHandle (https://docs.microsoft.com/en-us/windows/console/getstdhandle) in PowerShell to get the stdout handle, I always get 88. When I pass it to the Python script, it works well, however, I cannot catch the stdout from the PowerShell script, it is always shown. The interesting point is that if I just run h = msvcrt.get_osfhandle(1) in Python, h handle value always changes, and its value is something like 3588, 3412 etc., but only for 1. For 2 it is stable 92. Going to contniue what is happening here, I just thought that you might have an idea here.

@evanunderscore The main issue can be demonstrated by using this example:
import os
import msvcrt

h = msvcrt.get_osfhandle(1)
print(h)
# Version 1 - Using h
# i = int(h)

# Version 2 - Using const value
i = int(84)
if i == h:
    print("Equal")

stdout_fd = msvcrt.open_osfhandle(i, os.O_RDONLY | os.O_TEXT)

output_stream = os.fdopen(stdout_fd, "wb")
output_stream.write("Hello World!".encode())
output_stream.flush()

In case of Version 1:
(venv) PS> python .\failure.py
84
Hello World!
(venv) PS> python .\failure.py 1>$null
(venv) PS >$out = python .\failure.py
(venv) PS > $out
Hello World!2780```

So, the output can be properly redirected or captured. And it looks like that the value of `h` is `84`, but in case of `$out = python .\failure.py` `2780` is written into the output. Stange.

In case of Version 2:

(venv) > python .\failure.py
84
Equal
Hello World!
(venv) > python .\failure.py 1>$null
Hello World!
(venv) > $out = python .\failure.py
Hello World!
(venv) > $out
1916

So, the `output_stream` output is not part of the redirection or capute, but it is always shown by the console.

Do you have any idea what is going on here? :) If we can solve this mystery, there is not any blockage to move into the handle-based direction. Otherwise, I might merge the handle and the fd based solutions.

What do you mean "running the interpreter one additional time"? Could you please give me a short explanation how your solution is expected to work?

You can see the edits I made to the shell functions on in my draft PR - rather than use the shell to run the command and redirect output ("$@" 8>&1 9>&2 1>&9 2>&1) the Python wrapper is called instead (__python_argcomplete_run_subprocess "$@"). The wrapper then handles these redirections internally.
Ordinarily, tab completion runs the shell function, which will run your application (via the Python interpreter) in order to get the completions. In this case, only one Python interpreter is launched.
With my proposed change, the shell function will run my Python wrapper (which requires you to run the interpreter) which then uses subprocess to run your application (via a completely separate Python interpreter). The "one additional time" I'm referring to is the step in the middle where we need to run my script. The performance impact is the time to start the interpreter and execute my script. Theoretically this need not be implemented in Python; we just need something to do the redirection.

Do you have any idea what is going on here?

Handles are per-process opaque identifiers for resources. You shouldn't have any expectation that PowerShell's handle to stdout should match Python's handle to stdout, or even that of another instance of PowerShell.
In version 1, you're effectively just duplicating your own stdout FD and writing to it. Whether this means you're writing to PowerShell's stdout or somewhere else depends on whether PowerShell performed any redirection. I'm not certain why 2780 is printed, but it could be related to creating the file descriptor with os.O_TEXT but then opening it in binary mode.
In version 2, you're writing directly to PowerShell's stdout. It appears that the handles were inheritable, so you've been able to open them in the child process and then write directly. This is effectively the same thing that I'm doing in my solution: I'm passing the handles for the wrapper script's stdout/stderr via environment variables that the child then uses to open the output and debug streams.
The difference is that the shell function is then capturing stdout from the wrapper Python process. The fact that this is happening in an intermediary script is what's making it work; if I were connected directly to Bash's stdout, capturing the output would not be possible.
In your case, you can use my script directly and I expect it should work for you. There may be a way in PowerShell to get a handle connected to some kind of pipe, then you could pass that handle and eliminate the need for the intermediate Python wrapper, though I don't know enough about PowerShell to suggest a starting point for that. If PowerShell scripts are run as separate processes, you might be able to get that to work, but it would only be worthwhile if PowerShell's startup cost is less than Python's.

Handles are per-process opaque identifiers for resources. You shouldn't have any expectation that PowerShell's handle to stdout should match Python's handle to stdout, or even that of another instance of PowerShell.

I should probably walk this comment back a little bit, since I'm not absolutely certain of the details myself. Obviously if the handles are inherited then they will be the same. If you're seeing the stdout handle change but stderr remain the same, I'm guessing it's because you're redirecting stdout so the handle is referring to something else, while stderr remains connected to PowerShell's stderr.

@evanunderscore  Thank you for your very detailed response. I am going to process it, and send reponse soon.
@kislyuk Thank you for your feedback. I understand your concerns of the usage of 'kernel32' or any other Windows DLL. Please let me ask, just for my education, which are your main concerns regarding this question?
@kislyuk @evanunderscore Before the answer about usage of "kernel32" I had figured out how to use memory mapped files as IPC between PowerShell (and actually any win32 process) and Python, just needed some time to clean it and make it work with argcomplete. I have pushed a new commit with a proof of concept solution to show how it could work, it might be useful now or later.
Please find the corresponding PowerShell changes here:
https://github.com/tibortakacs/powershell-argcomplete/commit/c0a12f4fc65e0e37c27f27ef7e20b475a3853dbe
Since the stdout based solution worked properly well with PowerShell, I would consider the memory mapped based solution as a backup plan for applications which uses stdout before calling argcomplete. Therefore I have introduced the "output stream mode" concept: the default is the file descriptor based one to preserve the original behavior, and I have added the "mmf_win" one for the memory mapped file IPC. It could be added @evanunderscore 's handle based solution as well.
Looking forward to your opinion.

Great work getting the memory-mapped files working! In this case though I don't think it's the most appropriate tool for the job. Having to specify the size in advance and having it backed by the page file is not ideal. Ideally we want something entirely in-memory.
In case I wasn't clear before, I was suggesting that at a minimum you would be able to use the __python_argcomplete_run_subprocess script on my branch from PowerShell, in which case the fact that it passes handles becomes an implementation detail that you need not be aware of. Have you managed to get that working? I think it's a reasonable starting point.
However I think you can get PowerShell to do that work itself and eliminate the need for my script entirely. I've pushed https://github.com/evanunderscore/argcomplete/commit/6e04eb55402a67c3d1b1e8a9d27c250918c6f707 which modifies my wrapper to use a pipe instead of shortcutting directly to its own stdout, which you can use as a model for how I would do this in PowerShell. If you're able to call CreatePipe and make the write handle inheritable, you should be able to specify that handle as an environment variable and use my branch without modification.
If you can get that working, you shouldn't need any changes beyond what's on my branch. I am inexperienced with PowerShell, but if you run into trouble, let me know and I'll do my best to help out.

Thank you, @evanunderscore . I agree, the memory mapped solution is not best approach. It might be useful in future somewhere else :). Just for education: this page describes the concept: https://docs.microsoft.com/en-us/dotnet/standard/io/memory-mapped-files It does write that it uses virtual memory, however, the "Non-persisted memory-mapped files" which I used "are suitable for creating shared memory for inter-process communications (IPC)." Do you have any more insight how it works behind the scene? My understanding was that it is purely memory-based solution as well. Just the put the last bricks to the right place in this topic :)
Thank you for your detailed description of the handles and file descriptors, and the solution you proposed. I have also done some research to understand the basics of them (this blog post is particulary useful: http://lackingrhoticity.blogspot.com/2015/05/passing-fds-handles-between-processes.html). And now I understand your PR which I believe is great, it really works out of box, I am happy to move into this direction in PowerShell.
Let me ask though how robust this solution is comparing the pure stdout based one? The pipe-based is just much better for sure because it solve the accidental (intentional?) stdout writing before argcomplete, however, it is also more complex with msvcrt call and handle inheritance. Just wondering whether there is any scenario which we can recall now where there is a potential risk that it would not work, and we could keep the file descriptor based as a backup?
Let me ask a small question regarding the final usage as well. You used py.exe which on my system is C:\WINDOWS\py.exe. I believe it would be better to call the interpreter which is used by calling __python_argcomplete_run_subprocess. Would it make sense to change it to sys.executable? (I know this is an implementation detail, however, for the project I have been working on would be an important point.)

I don't know for sure, but I'd suspect it uses CreateFileMapping under the hood, which says this:

If hFile is INVALID_HANDLE_VALUE, the calling process must also specify a size for the file mapping object in the dwMaximumSizeHigh and dwMaximumSizeLow parameters. In this scenario, CreateFileMapping creates a file mapping object of a specified size that is backed by the system paging file instead of by a file in the file system.

So my understanding is that it does create non-persisted shared memory, but that memory is actually backed by the system paging file.

Just wondering whether there is any scenario which we can recall now where there is a potential risk that it would not work

It will work as long as the handles are inherited by the Python process argcomplete runs in. For example, when the Windows launcher creates the process it sets the bInheritHandles parameter to TRUE. If this were to be changed to FALSE, the handle would not be inherited when our process is launched via py.exe. Similarly if some other step is introduced in the chain that does not allow handles to be inherited, this won't work. The same would be true on Linux if there were something in the chain that didn't allow the file descriptors to be inherited.

I believe it would be better to call the interpreter which is used by calling __python_argcomplete_run_subprocess

The fact that this script is written in Python is completely an implementation detail. It should not matter at all which interpreter is used to run it (though I haven't specifically tested against Python 2). There is absolutely no reason to assume that the interpreter used to run that script should be the same as the child (which could have a shebang line indicating it is to be run with a completely different interpreter). This is exactly the reason I'm using py.exe; because I want the target script to run with the interpreter it specifies, not the interpreter my script specifies.
The reason I have to do this is described in a comment above where I'm running py.exe, but in short: I don't actually know how the shell is going to run the script. I also can't guarantee that using py.exe will produce the same result, but it's the best method I could come up with. There may be a better alternative that involves launching another Bash shell to execute the command.
However none of this should matter to you if you implement what the script is doing directly in PowerShell. In that case, you are the shell; you can just run the command unmodified.

@evanunderscore Thank you for your detailed responses again.
Regarding the shared memory question, interesting point, .NET does use this method under the hood. I can imagine that the .NET documentation and the CreateMappedFile documentation can be aligned, but this is definitely out of scope of this PR.
Thank you for your analysis regarding the robustness of the pipe-based solution. I am convinced this is the right way to go to.
About my interpreter question: I see now how "nooby" my question was :), thank you for your detailed response. I learned now about py.exe in Windows, and this is the right solution.

However none of this should matter to you if you implement what the script is doing directly in PowerShell. In that case, you are the shell; you can just run the command unmodified.

I think the PowerShell script would just call py.exe __python_argcomplete_run_subprocess as you mentioned above. In the current state, I do not see too big penalty of running two Python interpreters, and using the __python_argcomplete_run_subprocess would align PowerShell to other shells.
Would you agree with this direction?

@evanunderscore @kislyuk Thanks to @evanunderscore 's change, the PowerShell support does not need any code change, it only needs the wrapper script. Therefore, the scope of this PR is mainly adocumentation change. Which way do you prefer?

Keeping the https://github.com/tibortakacs/powershell-argcomplete repository with the detailed documentation the PowerShell wrapper script, and adding reference with short summary here.

Moving the detailed documentation here.
a. Create a new POWERSHELL.rst page with a reference in README.rst.
b. Just extend README.rst.

Any combinations of the aboves.

Please let me know which way you prefer.

About my interpreter question: I see now how "nooby" my question was :), thank you for your detailed response. I learned now about py.exe in Windows, and this is the right solution.

No problem. It was a perfectly valid question, and one that has come up several times before in this project, since using sys.executable is usually the right way to do things. However in this case it is not, and I wanted to be very clear about why.
Your implementation looks good! I don't expect you should have any need to use the wrapper script at all; I would recommend only including the handle-based version unless someone can come up with a compelling reason otherwise.
One thing to mention - you shouldn't have to use py.exe at all in your code; when the user runs ./mat.py, Windows will use the file association for .py files to work out how to launch the script. In most cases this will be py.exe, but not always.

We do not officially support Powershell, but argcomplete contributors have since been able to achieve unofficial support using other approaches. I'm going to go ahead and close this PR - it has no chance of being merged in its current state, and we will not be using memory mapping or ctypes in argcomplete.


Bug on getDirections function

I've found out that the next code line (61):
args.unitSystem = _unitSystems[args.unitSystem] || googleMaps.UnitSystem.IMPERIAL;

always returned 1, no matter what. The reason is because is you pass 'metric' as a parameter, the returned value of the array is 0, so then it selects the right part of the condition. It can be solved by changing it to:
args.unitSystem = _unitSystems[args.unitSystem] || googleMaps.UnitSystem.METRIC;

Also I found out that if you use the same args object for multiple calls, unitSystem was modified ( to 0 or 1). That shouldn't happen, it should be copied. So to solve also this, the whole functions would be:
getDirections: function(args) {
    var _args = angular.copy(args);
    _args.travelMode = _travelModes[args.travelMode] || googleMaps.TravelMode.DRIVING;
    _args.unitSystem = _unitSystems[args.unitSystem] || googleMaps.UnitSystem.METRIC;
    return exec(_args);
}

Hope to help.
Best regards

hi @alexjoverm,
Thank you so much for reporting these issues. I will dig into them really soon.

Fixed via 8eaea51. Thanks for reporting.


Segmentation Fault reading uproot written tree

Hello,
I am trying to write and then read a tree with uproot. Writing the tree and reading it again with uproot is no problem but I encounter a segmentation fault, when trying to open Jagged-Array branches of the tree with other root-tools like a TBrowser or the python root_numpy module. I used the awkward-array documentation on how to write the tree.
A minimal Example of how I write and how it fails would be this:
import numpy as np
import awkward as ak
import uproot3 as ur
import root_numpy as rn

print("Version:\nuproot: {}\nawkward: {}\nroot_numpy: {}".format(ur.__version__, ak.__version__, rn.__version__))

f_path = "/tmp/test_uproot_writing.root"
keys = ["key_a", "key_b", "key_c"]

branch_dict = {}
branch_reg = {}

print("Creating New root-file with uproot")

with ur.recreate( f_path ) as out_file:
    for key in keys:

        arr = ak.to_awkward0( ak.Array( [np.zeros( (20))[:np.random.randint(4, 20)] for i in range(100)] ) )

        dtype = ur.newbranch( np.dtype("f8"), size="{}_counts".format(key) )
        branch_reg[key] = dtype
        branch_dict[key] = arr

        counts = arr.counts
        branch_dict["{}_counts".format(key)] = counts

    out_file["ttree"] = ur.newtree(branch_reg)
    out_file["ttree"].extend(branch_dict)

print("Trying to load the file with root_numpy")

nparr = rn.root2array( [f_path], treename="ttree", stop=None, branches=keys)

With the stack-trace:
Singularity> python3 scripts/debug_uproot_tree_writing.py
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
Version:
uproot: 3.14.1
awkward: 1.0.2
root_numpy: 4.8.0
Creating New root-file with uproot
Trying to load the file with root_numpy

 *** Break *** segmentation violation
 Generating stack trace...
 0x00007f3399a82b7a in TreeChain::GetEntry(long long) at /tmp/pip-install-zh223qts/root-numpy_eee9f47128724527985f005dc6ccceda/root_numpy/src/TreeChain.h:240 from /usr/local/lib/python3.6/dist-packages/root_numpy/_librootnumpy.cpython-36m-x86_64-linux-gnu.so
 0x00007f3399a71191 in <unknown> from /usr/local/lib/python3.6/dist-packages/root_numpy/_librootnumpy.cpython-36m-x86_64-linux-gnu.so
 0x00007f3399a76f98 in <unknown> from /usr/local/lib/python3.6/dist-packages/root_numpy/_librootnumpy.cpython-36m-x86_64-linux-gnu.so
 0x000000000050a4a5 in <unknown> from python3
 0x000000000050beb4 in _PyEval_EvalFrameDefault + 0x444 from python3
 0x0000000000507be4 in <unknown> from python3
 0x0000000000509900 in <unknown> from python3
 0x000000000050a2fd in <unknown> from python3
 0x000000000050cc96 in _PyEval_EvalFrameDefault + 0x1226 from python3
 0x0000000000507be4 in <unknown> from python3
 0x000000000050ad03 in PyEval_EvalCode + 0x23 from python3
 0x0000000000634e72 in <unknown> from python3
 0x0000000000634f27 in PyRun_FileExFlags + 0x97 from python3
 0x00000000006386df in PyRun_SimpleFileExFlags + 0x17f from python3
 0x0000000000639281 in Py_Main + 0x591 from python3
 0x00000000004b0dc0 in main + 0xe0 from python3
 0x00007f33c47e2b97 in __libc_start_main + 0xe7 from /lib/x86_64-linux-gnu/libc.so.6
 0x00000000005b259a in _start + 0x2a from python3

Further:
using root-version 6.18/04

added the root-version used

I encountered some interesting/weird behaviour while trying to even reduce the example:
The following script only SOMETIMES failes with a segmentation-fault. Thus far this looks like a stochastic behaviour to me, with the script failing in 50% of the cases and the rest running fine.
import numpy as np
import awkward as ak
import uproot3 as ur
import root_numpy as rn

f_path = "/tmp/test_uproot_writing.root"
keys = ["key-a"]

print("Creating New root-file with uproot")
with ur.recreate( f_path ) as out_file:

    arr = ak.to_awkward0( ak.Array( [np.zeros( (20) ) for i in range(100)] ) )
    out_file["ttree"] = ur.newtree( {"key-a": ur.newbranch(np.dtype("f8"), size="n")})
    out_file["ttree"].extend({"key-a": arr, "n": arr.counts})

print("Trying to load the file with root_numpy")

nparr = rn.root2array( [f_path], treename="ttree", stop=None, branches=keys)
print(nparr)

Letting both script-versions run 50 times:
The
with ur.recreate( f_path ) as out_file:
    arr = ak.to_awkward0( ak.Array( [np.zeros( (20))[:np.random.randint(4, 20)] for i in range(100)] ) )
    out_file["ttree"] = ur.newtree( {"key-a": ur.newbranch(np.dtype("f8"), size="n")})
    out_file["ttree"].extend({"key-a": arr, "n": arr.counts})

Version failed 26/50 times
and the
with ur.recreate( f_path ) as out_file:
   arr = ak.to_awkward0( ak.Array( [np.zeros( (20)) for i in range(100)] ) )
   out_file["ttree"] = ur.newtree( {"key-a": ur.newbranch(np.dtype("f8"), size="n")})
   out_file["ttree"].extend({"key-a": arr, "n": arr.counts})

failed 50/50 times

Same problem with the newest verrsion:
Version:
uproot: 3.14.4
awkward: 1.3.0
root_numpy: 4.8.0

When the script is succesful in loading the uproot-written tree with root, I encounter vastly random values in all ranges of magnitude, so I suspect that succes is still corrupted somehow internally.

I'm following this; thanks for submitting it! (Sorry for my silence so far.)
My action is going to be to ensure that this case is not broken in Uproot 4 (follow it on https://github.com/scikit-hep/uproot4/discussions/321), which is my highest programming priority right now, though non-programming priorities (summer conferences) have prevented me from updating it for the last few weeks. It will get done this summer, though.
What you're seeing with non-deterministic segfault vs wrong values is typical of ROOT file-writing: if one byte is out of place, reading it back might trip up in different ways. (It might depend on uninitialized values in some array somewhere.)
Your example is an indication that the file is not being written correctly, though I don't think it has ever been tested with root-numpy before. (I think the unit tests use PyROOT to test read-back, other than Uproot itself.) It could be that root-numpy is revealing an error that hadn't been revealed before by reading it in a different way. All of the information needed to read a jagged branch is contained in that branch—although it is usually linked to a "count leaf" in another branch (size in the Uproot 3 API), it is not necessary to read the counts to get the jagged array. It could be that the count leaf is incorrectly written, but only root-numpy attempts to read the count leaf. (Uproot definitely doesn't; I don't know about PyROOT.)

Thanks for the answer!
Is there already a version/branch of uproot4 that would allow writing trees?
As mentioned earlier, opening the broken branches in a TBrowser also results in a seg-fault

See https://github.com/scikit-hep/uproot4/discussions/321 — the Uproot 4 feature is in progress.
By testing the Uproot 3 feature in PyROOT, we also didn't see what it would do in the TBrowser, which might try to access more, like root-numpy.


CVE-2007-4559 Patch

Patching CVE-2007-4559
Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.
If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

I am unable to merge these suggested changes as they would break the code descriptions in the book. The code listed here, is sample code, and has to match the published code snippets in the book.


DOCUMENTATION: Icons

The development team has requested that all of the current icons listed in the visual design spec sheets be compiled into one sheet for ease of reference. This will help to deter the random use of icons for defined states, as well as mismatches between Font Awesome and PatternFly.
In Addition, some testing will be done with VISUALS (TESTING): Status Icons

So far, the following icons have been located:

Icons for Types and States
Warning Triangle
Add Work Item: Work Item Detail Panel

I met briefly with @jryhanyc and I'll set up a template with the icons I've used thus far, then post it to InVision. When she has created her icons, she'll add to the file.

sounds good. If there are new icons/fonts, we could possibly add those to the Platform/Planner first, and then create a PR for PatternFly. There has been talk about integrating pieces from this project to PatternFly, so that might be a good first piece.

I like that idea, thanks!

@bdellasc @jryhanyc I'll be updating the backend code with the correct icons (that is where the UI gets them from), so once they are ready to go, just let me know. If they are being done in parts, I can create multiple PRs for them to consume to match our Sprints :-)

@qodfathr, @michaelkleinhenz, @michaelvirgil, @maxandersen, @Mgranfie
For the Issue Tracking & Scrum Work Item types, we referred to this spreadsheet and pieced together from mockups @mindreeper2420 mentioned above. Two of the four templates (Agile? & Scenario-Driven?) are not yet listed here as they are still being sorted out.
I posted mockups of all the icons we're aware of across 3 InVision mockups.
For the "Work Item Types" (page 1), there are questions:

Is "Feature" part of the "Scenario-Driven" methodology?
If the red items are still needed, are they listed under the correct methodology?
Do we have any of the other missing Work Item Types nailed down yet?
Are there Work Item Types that belong to multiple methodologies?

Can someone please provide definitions for the Work Item Types currently without icons (and not included in the PDD Glossary ) I did some web searches and here was what I found:

Task: a piece of work that needs to be completed for a story?
Issue: something that has already happened and is entered into the system?
Any other Work Item Types that still need to be added to the list

Additional stories blocked by these open issues:

Map Statuses & Types to iconography + create iconography (Part 1 of 2)
VISUALS (SPECS): Map Statuses & Types to iconography + create iconography (Part 2 of 2)

Current (unconfirmed) types & states:
Issue Tracking
———————————————
Issue
New
Active (= In Progress)
Resolved (= Done)
Closed (verified and meets the Definition of Done)
Removed (= Deleted, for now)
Task
New
Active
Closed
Removed
Model: Scrum
———————————————
Bug, Product Backlog Item
New
Approved (approved by PM or Ready-Ready, and can planed or handed off the the team.)
Committed (team has planned to work on it)
In Progress
Done
Closed
Removed
Task
To Do
In Progress
Done
Removed
Epic & Feature
New
In Progress
Done
Removed

@jryhanyc - waiting on two definitions. I sent an e-mail.

@jryhanyc, I updated the top section with the latest definitions and additional work item types.

Closing this, since there is a visuals story for it currently.


[Azure Search] Define a ranking for the "empty search query" that doesn't over-value System.* packages

Today it comes from 2.x installs and restores. Just download count will look like this:
https://www.nuget.org/stats/packages
Which is not that interesting...

Two options here:

Take the existing rankings.json and use that. This gets weird after the end of the list.
Take the total download count list and introduce an exclude list (System.*, etc).

I am leaning towards option 2 since it will require less maintenance.
In short, we are not looking at this as a hugely important decision as long as the behavior delta between old and new search is not disruptive to our customers.

Maybe include this implemention inside the auxiliary2azuresearch job tracked by https://github.com/nuget/nugetgallery/issues/6447.

Exclude list idea:

Add new field
Exclude list in ng-search-data blob, downloaded by db2azuresearch for now. Required index rebuild
Do we need a new scoring profile? Only if results are weird

The only things this blocks are:

Service index pointing to Azure Search
Moving 100% of gallery search queries to Azure Search

In other words, we can make the randomized A/B test go to the legacy search all the time for empty search results.


move code to container-native terminology

Hello @ivotron! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file cli/popper/gha.py:

Line 967:80: E501 line too long (80 > 79 characters)


⚠ Processors has degraded performance

In 61606b0, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 74 ms

Resolved: Processors performance has improved in 9ca95ab.


Move all build steps into Docker

We can move all of the build steps into Docker to avoid having Node (NPM), PHP (Composer) on the host. However on my macOS it is extremely slow when the artifacts are extracted.
DOCKER_RUN=docker run --rm --interactive --tty
# TODO someone better w/ Makefiles add support for `${COMPOSER_HOME:-$HOME/.composer}`.
DOCKER_DRUPAL_RUN=${DOCKER_RUN} -v ${PWD}/drupal-src:/app -v ${HOME}/.composer:/tmp

drupal-update:
	${DOCKER_DRUPAL_RUN} composer update --ignore-platform-reqs

drupal-build:
	${DOCKER_DRUPAL_RUN} composer install --ignore-platform-reqs

drupal-archive:
	${DOCKER_DRUPAL_RUN} composer archive --format=zip
	mv drupal-src/drupal-wasm-1.0.zip .

The drupal-install target would require some special work.

I think we can consider this fixed by https://github.com/mglaman/wasm-drupal/pull/31, but we need to update the README


Add a deprecation warning to the final pre-unified fidesctl release

Is your feature request related to a specific problem?
Fidesctl users will have no clear way of knowing that fidesctl as a package is being deprecated
Describe the solution you'd like
Add a log message to the server and a warning in the CLI that the new package name is ethyca-fides and point them to the fides 2.0 migration guide in the docs

@NevilleS does it seem fine to add this in now? Or should we push one final release with this deprecation warning in it when we push the real thing?


Insecure openFirewall

With the current openFirewall configuration Port 6556 is opened for everyone. So you can call telnet <IP> 6556 from any other device to see all Monitoring information.
I used the following configuration (for nftables) instead:
{
  config,
  pkgs,
  check_mk_agent,
  ...
}:
let
  cfg = config.services.check_mk_agent;
  monitoringServerIp = "<IP_ADDRESS>";
in
{
  imports = [ check_mk_agent.nixosModules.check_mk_agent ];

  config = {
    services.check_mk_agent = {
      enable = true;
      bind = "<IP_ADDRESS>";
      openFirewall = false;
      package = pkgs.check_mk_agent.override { enablePluginSmart = true; };
    };

    networking.firewall.extraInputRules = ''
      ip saddr ${monitoringServerIp} tcp dport ${toString cfg.port} accept
    '';
  };
}

I thought this was the default for all "official" nixos configuration. I just picked some random examples from search.nixos.org

https://github.com/NixOS/nixpkgs/blob/nixos-unstable/nixos/modules/services/web-apps/silverbullet.nix  seems to have only a very basic configuration
https://github.com/NixOS/nixpkgs/blob/nixos-24.05/nixos/modules/services/monitoring/prometheus/exporters.nix  seems to have a advanced firewall configuration via firewallFilter and firewallRules options, but those seems to be only used by services.promethues.exporters.*
https://github.com/NixOS/nixpkgs/blob/nixos-unstable/nixos/modules/services/misc/mediatomb.nix  simple
https://github.com/NixOS/nixpkgs/blob/nixos-unstable/nixos/modules/services/web-apps/gotosocial.nix  simple
https://github.com/NixOS/nixpkgs/blob/nixos-unstable/nixos/modules/services/misc/bazarr.nix  simple
https://github.com/NixOS/nixpkgs/blob/nixos-unstable/nixos/modules/services/web-apps/suwayomi-server.nix simple

This seems to confirm my gut feeling: If you just want to open the firewall to everyone you can use that option, otherwise you have to configure your firewall on your own. I think this makes sense, because the flake author can not know whether the system uses iptables, nftables or other higher level firewall systems.
I too have special firewall configuration in my setup via networking.firewall.extraCommands.
Do you have an example of other modules or flakes that have a more advanced firewall configuration option?