Improve display of histone modifications

Histone alles and modifications are universally described using the processed (- initMet) for the histones.
For alleles we do this:
hht3-K56R(K57R aa)
The name follows the community usage, and the description matches the underlying protein sequence. We use the underlying protein sequence to check that the alleles and modifications conform with the sequence in our QC pipeline without adding a special case for histones.
At the moment we Display modifications using only the preprocessed form which will be very confusing for end users. We would like to change the display so that the universal nomenclature is presented with the processed form in parentheses
K14(K15) processed/preprocessed.
I will add a list of the histones that this applies to.

Applies to

Gene systematic ID
SPAC1834.03c
SPBC1105.12
SPBC8D2.03c
SPAC1834.04
SPBC8D2.04
SPBC1105.11c.1
SPAC513.01c
SPCP31B10.07
SPCC622.08c
SPAC19G12.06c
SPCC622.09

Applies to

Do these have a something like a GO term in common so we don't need to maintain a gene list in the configuration file?

extended the "applies to" list with Jo's additions

Do these have a something like a GO term in common so we don't need to maintain a gene list in the configuration file?

https://www.pombase.org/results/from/id/593d5a9e-c876-467e-a531-336791ef7e8b
Unfortunately not -these are described variously as adapters or structural molecules. There is not even a protein family that is specific for the group because this is only a subset of all histone faults.

Could we add some sort of /controlled_curation to annotate these genes?  That way the annotation will end up in Chado and the web code will be identify the genes.

Yes, I can add
/controlled_curation="histone"
or does it also need to have a "type"?

or does it also need to have a "type"?

It's been so long, I can't remember.  I'll refresh my memory and let you know.
But now I think about it, I wonder if /SO=SO:0000418 would be better?

this is for signa peptide, not modified histone?
but PRO might have a grouping, will check

nope PRO does not have a grouping (it would be a bit odd anyway)

this is for signa peptide, not modified histone?

Sorry!  Please ignore me.  :-)  I was think about this is at the same time: pombase/website#2115

I thought you were. They are both removal of N-terminal regions, but a bit different ;)

I could find, or request the PRO_ID for each one and add
controlled_curation=display(PRO:xxx)

Should I do it like this?

/controlled_curation="histone

I think something like this:
/controlled_curation="term=warning, histone"

K14(K15) processed/preprocessed.

Where does that need to be shown on the web site?  Sorry, I don't understand histones.

I could find, or request the PRO_ID for each one and add
controlled_curation=display(PRO:xxx)

I'm not sure about that but I don't really understand what's needed.

Don't worry, we can discuss in person, it's easier.

Action for kmr: make a Chado check that we always have 11 histones - 11 annotations to GO:0000786 nucleosome

How's this?:
https://desktop.kmr.nz/gene/SPAC1834.04

Good, but I think it needs to be visible in the full view as well as  show details.

Good, but I think it needs to be visible in the full view as well as show details.

It will be.  That's what the two images show.  The code isn't finished yet so my desktop version is a bit dodgy.  I took the screenshot while it was briefly doing the right thing for hht1.  :-)

Got it!

Hi Val.
On the documentation page for the modifications section (https://www.pombase.org/documentation/gene-page-modifications) it says:
Note: for histones, residue numbering assumes that the initiator methionine is removed.

Is that correct?  If so, I think I'm misunderstanding things.

I think that is because the documentation predates the manus script,and that previously  the instructions were to represent histone modifications using the histone code standard.
I'm not sure whether  everybody adhered to that guidline, because presumably they would need to manually edit their mass spec output to make the histones match (unless that mass spec processing does this automatically, this seems unlikely because even uniprot reports the modifications on the unprocessed version https://www.uniprot.org/uniprotkb/P09988/entry#ptm_processing).
It might be useful to know how many manus script  'fixed' to the non-modified form @manu do you know this?
But I think we  probably  just need to update the modification now to say that histones should be reported in the unprocessed form.
Basically, we changed the way we do this to make it the same for every protein, but weren't aware of the existing instructions for histones.

We will also need to correct
https://www.pombase.org/
The Residue column indicates the position modified. For protein modifications, use one-letter amino acid code. Multiple entries are allowed, but only for cases where two or more of the same modification are known to be present at the same time. Separate entries with commas (e.g. S72,T85). Position numbering should reflect the current sequence data in PomBase. Please refer to the Gene Coordinate Changes page to ensure that your residue position entries are up to date. Also note that histones are conventionally numbered assuming the initiator methionine is removed (i.e. every position in the mature protein is numbered, and is 1 less than the apparent numbering predicted by translating the ORF).

For protein modifications, use one-letter amino acid code. Multiple entries are allowed, but only for cases where two or more of the same modification are known to be present at the same time. Separate entries with commas (e.g. S72,T85)

this section isn't correct, we don't  conjoin because this wi make modifications impossible to collapse and it isn't sure informative since  it's biased for close residues which are like to be on the same peptide fragment.
Also we report the phase when known so we can get modifications that co-occur this way.
2.- we can tell people this isn't necessary, and why
Please refer to the Gene Coordinate Changes page to ensure that your residue position entries are up to date.
I can rewrite a shorter version tomorrow.

The residues are displayed correctly for histones now.  I had some bugs to fix when displaying on pages that have a mixture of histones and non-histones like:
https://www.pombase.org/term/MOD:00408

That's now fixed but let me know if you see any problems.
We talked about being more explicit in the detailed display (eg."K56(K57)` processed(preprocessed)").  Should we do that?  Here's how it looks in the test version on my desktop:

We talked about being more explicit in the detailed display (eg."K56(K57)` processed(preprocessed)"). Should we do that? Here's how it looks in the test version on my desktop:

It doesn't hurt, but I  think most biologists will understand without.  Put it in for now as  there is space...

OK, I'll added that.  The main site will have the change in a little while.

Add text at the top in the "Notes" section.
We have a QC pipeline in place to check that the modified residues match the current protein sequence coordinates. For most proteins where the protein sequence coordinates have changed, we will be abo to automatically "lift over" to the current sequence residue numbering.
Change text
Also note that histones are conventionally numbered assuming the initiator methionine is removed (i.e. every position in the mature protein is numbered, and is 1 less than the apparent numbering predicted by translating the ORF).
to
Histones should be represented using the unprocessed protein sequence coordinates, not the processed coordinates conventionally used to describe histones. Histone modifications will be  represented on the gene pages as
K4(K5) processed(preprocessed), but our checking pipeline will expect unmodified forms.

Edited text above.
@kimrutherford can you make this change and ten this ticket can close

can you make this change and ten this ticket can close

Excellent, thanks.  I've made that text change.


added custom color palette to use in Interface Builder

[Current coverage][cc-pull] is 100% (diff: 100%)

Merging [#2][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master    #2   diff @@
===================================
  Files           3     3
  Lines          75    75
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           75    75
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update [7deb703...a82c156][cc-compare]
[cc-base-branch]: https://codecov.io/gh/pelotoncycle/Peloton-UIColors/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/pelotoncycle/Peloton-UIColors/compare/7deb703e4caa5af5e91e837d618330ea2e0a10e7...a82c1561fcfe43495fc43d5399128e12640aaa28?src=pr
[cc-pull]: https://codecov.io/gh/pelotoncycle/Peloton-UIColors/pull/2?src=pr

I think we should move this palette under the Peloton-UIColors/Assets folder


Add hanami to rbenv_map_bins

This is necessary so that you can run the command hanami through method execute.
Hanami is a full-stack Ruby web framework.
Example:
namespace :deploy do
  task :hanami_help do
    on roles(:app) do
      within release_path do
        with hanami_env: fetch(:hanami_env) do
          execute :hanami, 'help'
        end
      end
    end
  end
end

Hello again! As I mentioned in https://github.com/capistrano/bundler/pull/88#issuecomment-269874054, I think this is better done in capistrano-hanami. See capistrano3-puma for an example:
https://github.com/seuros/capistrano-puma/blob/e18b30c18aceceed003e8007c268125317a17a9d/lib/capistrano/tasks/puma.rake#L21-L24


"Programming in Ada 2012" is not the language reference!

The textbook "Programming in Ada 2012" is definitely not the language reference.  It is possibly the most comprehensive Ada 2012 textbook, but it is still only a textbook.
Technically, I think you can get the official "Ada Language Reference" for Ada 2012 in print from Springer, but check it out.

Changed to Comprehensive reference. Is it ok?

Changing for : Comprehensive

I hope you well sparre, really. I am closing as I know you might not answer often.


substraTEE-ink-contracts

Grant Application
This application is (select one):

[x] Speculative (use this by default)
[ ] an RFP response

This application is (select one):

[ ] Public (fully)
[x] Public with private finances

Abstract
This application is a follow-up to our grant for developing substraTEE. substraTEE is an off-chain-worker system that interacts with a substrate chain and executes calls to a state-transition-function inside an Intel SGX enclave in order to provide integrity and confidentiality within the guarantees of Intel.
During the implementation of our wasm-stf-within-sgx-enclave feature we realized the potential to support ink contracts for our SGX off-chain worker. We consider this feature a suggested change request. It exceeds our budget for the current grant.
Checklist

[x] The grants document has been read and understood.
[x] The Google Form will be completed accurately. Note that the Google Form requires the pull request URL.
[x] Abstract (above) is succinct and complete.
[x] The application is being included into the correct directory: either 'targeted' or 'speculative'.
[x] The application includes a project description.
[x] The application includes all names of team members.
[x] The application includes a description of the team's experience.
[x] The application includes all necessary links (e.g. GitHub and LinkedIn)
[x] The "Development Roadmap" section in the application has a timeline of development ("milestones").
[ ] The "Development Roadmap" section in the application has an estimate of funds required.
[x] The "Development Roadmap" section gives an indication of the team's long term plans.
[x] The "Development Roadmap" section includes documentation as a deliverable for at least one milestone.

Let's revisit this in the future.


login error in production in android

i am currently facing the problem in login in fb in production but it's working fine in locally . my app is in production since year but from last week i am facing a error in login .

Pursue this with facebook support. The code is fine in this module, your project must have some issue in their system


How can we train LSTM PPO?

Hi,
I am trying to train LSTM PPO on Hopper-v3 but it did not learn well.
Although LSTM policy is hard to learn compared to FF policy, it seems there are several missing pieces to train them.
Could you give some advice to train LSTM PPO?
Thank you so much.

cf. my settings are as follows:
algo=dict(
        discount=0.99,
        learning_rate=3e-4,
        clip_grad_norm=1e6,
        entropy_loss_coeff=0.0,
        gae_lambda=0.95,
        minibatches=128,
        epochs=10,
        ratio_clip=0.2,
        normalize_advantage=True,
        linear_lr_schedule=True,
        bootstrap_timelimit=False,
    ),
    sampler=dict(
        batch_B=16,
        max_decorrelation_steps=400,
    ),

I tried batch_T as 2048, 256, 40, 32, 16
cf2. LSTM did not increase after finishing point.

@jd730  what is this nice vis tool you are using?

@tarungog  Hi, I am using wandb.

Hi!  Looking at your settings, I think minibatches in the algo might be too high relative to the sampler batch_B.   Try using batch_B as different multiples of minibatches, and let us know if that works?
minibatches=128 will try to chop the training batch into 128 minibatches.  But in PPO with recurrence, the shuffling/minibatching all happens along the B dimension only, so the agent receives full-length sequences in T.  I'm not sure what the behavior will be when minibatches > batch_B....should add a warning about this!  In feedforward mode, the shuffling/minibatching happens over individual data points (T and B).

@astooke  Thank you for your advice.
I tested various settings as follows:
set LSTM size as fc (64) - lstm(64) since FF default setting is fc(64)-fc(64).
(minibatch, batch_T, batch_B): (4, 20, 16), (4, 40, 16), (4, 40, 48), (16, 40, 48), (16, 256, 16), (16, 40, 16), (32, 40, 48).

The best setting (blue) was (32,40, 48) setting but decreased after 40M and much lower than FF setting (brown).
Furthermore, in LSTM, I am figuring out that sometimes entropy goes to infinity. it randomly happens. i.e. if I ran three jobs with the same settings, 0-1 job works like below.

Hi!  I'm not sure about the specifics of this learning problem, so I might not be able to help much.  But one other thing to try is to put a skip connection around the LSTM, and maybe keep 2 FF layers before it, so your network would like like fc1-->fc2-->lstm-->(+)fc2_output-->output.  So the network can learn as FF when that's OK, and just pick up recurrence where it's helpful later on in training.
Let us know what works!

@astooke, Thanks a lot. I will try following your advice and update it.

@jd730 off-topic, but would you mind sharing your wandb integration code?

Hi!  @jd730 any progress here?  Else I would like to close the issue, as it's about a specific RL problem rather than the code base.  Thanks! :)

Hi, @astooke. Unfortunately, due to other works, I did not try yet. I'll close it and if I have any updates, I will reopen and share the results.
Thank you for your help.
@MasterScrat, you may add some lines regarding wandb on dump_tabular on logger.py

TLDR: I think I found a solution: set value_loss_coeff=1e-3 and batch_B=minibatches.
This issue is now closed but it seems that no solution was found; I was recently training a MujocoLstmAgent on a custom robot environment and initially had the same problem of the agent not being able to learn. After a quick inspection, I saw that the actor and the critic are implemented in a single network; the following call print(agent.model) yields:
MujocoLstmModel(
  (mlp): MlpModel(
    (model): Sequential(
      (0): Linear(in_features=77, out_features=256, bias=True)
      (1): ReLU()
      (2): Linear(in_features=256, out_features=256, bias=True)
      (3): ReLU()
    )
  )
  (lstm): LSTM(275, 256)
  (head): Linear(in_features=256, out_features=37, bias=True)
)

According to a similar issue (ray-project/ray#5278), the problem comes from the fact that the value function loss is huge when compared to the policy loss. The solution is to set the value_loss_coeff parameter to a low value (I used 1e-3) to balance the two losses. Below is the full configuration I used (I normally set batch_B=minibatches):
  sampler = Sampler(
      ...
      EnvCls=gym_make,
      CollectorCls=CpuWaitResetCollector,
      batch_T=256,
      batch_B=8,
      max_decorrelation_steps=0,
  )
  algo = PPO(
      ...
      discount=0.99,
      learning_rate=3e-4,
      clip_grad_norm=1e6,
      entropy_loss_coeff=0.0,
      gae_lambda=0.95,
      minibatches=8,
      epochs=10,
      value_loss_coeff=1e-3,
      ratio_clip=0.2,
      normalize_advantage=True,
      linear_lr_schedule=False,
  )
  agent = MujocoLstmAgent(model_kwargs=dict(normalize_observation=False))

Hope this helps someone :smile:


‘struct tinyobj::attrib_t’ has no member named ‘positions’

src/App.cpp: In member function ‘void App::draw(float)’:
src/App.cpp:266:35: error: ‘struct tinyobj::attrib_t’ has no member named ‘positions’
float vx = attrib.positions[3*idx.vertex_index+0];

You are probably posting to wrong project.
There is no src/App.cpp file in this repo.  And attrib.vertices, not attrib.positions

In your example code you used "attrib.positions" (in the readme file)... I went through your source code and found out by myself that it should have been "attrib.vertices".
Note: this was on the develop branch!

In your example code you used "attrib.positions" (in the readme file)... I went through your source code and found out by myself that it should have been "attrib.vertices".
Note: this was on the develop branch!

You should describe these information when you post the issue. And inconsistency in README has been fixed already: https://github.com/syoyo/tinyobjloader/commit/b8c33156de96592903f06acc619ac921adc251c3


fix(tracer.js): catching json stringify errors

Further to https://github.com/epsagon/epsagon-node/issues/271

:tada: This PR is included in version 1.62.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


console player selection does not work anymore

1- What are the steps that lead to the bug occurring? Or, how frequently does the bug occur?
2- What would be the normally expected or desired result?
3- What is the actual result (the bug)?
4- What is the impact of this bug?
5- (Any additional context or information eg. in the form of error messages or screenshots.)
1- This bug did not exist before, but like 2 years ago it began appearing to me, the feature was working perfectly in the past, now it always works
2- The feature is expected to ran the command on the player I click their username in, however, when I click at their Username the console just closes.
3- The console closes when clicking on a player's username
4- It slows down the process of running commands, I have to type instead of clicking directly on the usernames.
5- I provided a video clip of the issue
https://user-images.githubusercontent.com/59706401/235512125-f869bafb-e014-41c8-a0d3-a9f3848a6946.mp4

You don't need to write the full username, you can write the first 3-4 letters of the username btw.

I don't think you were ever able to click on predicted usernames, it does look like your cursor is highlighting something meaning that it's probably a text button but due to a oversight that detects whether you click anywhere on the screen to exit out of the command-line. Ringing @ccuser44...

actually it used to work like 2 years ago, I'm pretty sure when I click in their username it inserts all the username, it was to make running command in multiple people easier

You don't need to write the full username, you can write the first 3-4 letters of the username btw.

true but trust me when there are like +10 players in the server it's easier to click than typing the first letters, also some people might have the same letters in the prefix of a word

Looking into this

Epix janitor

What

According to my research, this still works. Problem is that the console closes when it is "unfocused" and for some reason, clicking on the console is unfocusing it??


TOC for this page contains unrelated entries like Data protection overview

When navigating to this page, the TOC in the left shows "Data protection overview" which seems unrelated.
When I navigate to "Data protection overview", it changes to TOC entirely (and is not under the "Wikis" root).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 29f1e43f-a069-dd88-7fc7-9cc497fb94f0
Version Independent ID: c261afa7-6eb7-b3f0-9f92-6d2f3c5ac336
Content: Markdown syntax for wikis in Azure DevOps - Azure DevOps
Content Source: docs/project/wiki/wiki-markdown-guidance.md
Product: devops
Technology: devops-collab
GitHub Login: @chcomley
Microsoft Alias: chcomley

Hi @NenoLoje, Thanks for the heads up on this. I'll publish an update today, which will be live shortly afterward. The Data protection overview is related to Azure DevOps, but I do understand that it can be frustrating to be taken to a completely different TOC! Thanks again.


Remove direct string as ID argument to Fluent Read API

Photon currently supports being able to read data using the following syntax:
const user = await photon.user.find('bobs-id')

This assumes that User has a field tagged with @id and that it is a single field, i.e. not a compound index. If User has a compound index then the syntax would no longer be valid for User. I suggest that we remove the ability to pass the ID in directly if the model has a single ID field. This removes any chance of a developer using Photon having to remember what type of index is used in the model and enforces a consistency between the different models in terms of accessing the desired data.
Preferred syntax:
// Single ID field
const user = await photon.user.find({ id: 'bobs-id' })

// Compound index
const user = await.photon.user.find({
  customer: { name: 'Bob', email<EMAIL_ADDRESS>}
})

// Connecting
await photon.user.create({
  email<EMAIL_ADDRESS>  posts: {
    connect: {
      id: 'post-id'
    }
  }
})

This was removed a long time ago. We no longer have this shortcut.

This was removed a long time ago. We no longer have this shortcut.


Problems with Formula

Hi,
I am using Jexcel with 4 tables, each on 1 Tab.
For each of these 4 tables, I am using formula.
I noticed that the formula written in 1 table was rewriting the formulas of the 3 other tables.
Understand my problem ?

It has been fixed in the new release v1.5.2 (available in the master repo)


[BUG] UUID validator identifies uuid as invalid

Before you begin...

[X] I have searched the existing issues
[X] I am not using version 13.x of node  (if so, please upgrade)

Description of the problem
The validation function considers the following uuid being invalid: b46a70e0-dea8-11ed-0000-000000000000
About 5 popular online uuid validators say this is a valid uuid. Also the validator npm-package says this uuid is valid.
Recipe for reproducing
https://codesandbox.io/s/wizardly-margulis-l32syf?file=/src/App.js
Additional information
No response
Environment
No response

It doesn't look valid to me, the variant is set as 0 which seems wrong.
Look at the description about N here: https://en.wikipedia.org/wiki/Universally_unique_identifier#Format

Just had a quick look at the document. Isn't this the variant-0, which still is supported for backwards compatibility? Or am i getting it wrong?


[Task]: Fix failing LS testcases after replacing contextTypeResolver with expectedType API

Description
Since usages of ContextTypeResolver replaced by the expectedType API, failing LS cases need to be fixed.
Describe your task(s)
No response
Related area
-> Editor
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

As per the offline discussion, the following test cases will not be addressed in this PR. @DamithaSenevirathne will further look into those.
“Function_call_expression_ctx_config15.json”
“Function_call_expression_ctx_config19.json”
"mapping_constructor_expr_ctx_config3.json"
“New_expr_ctx_config15.json”
“New_expr_ctx_config11.json”
“New_expr_ctx_config16.json”
“New_expr_ctx_config26.json”
“New_expr_ctx_config14.json”
"mapping_expr_ctx_config38_negative.json",
“Anon_func_expr_ctx_config1a.json”

Due to parser changes for client declaration, the context is identified incorrectly invar_def_ctx_config16.json (https://github.com/ballerina-platform/ballerina-lang/issues/38711). Therefore, it will be fixed once https://github.com/ballerina-platform/ballerina-lang/pull/38800 is merged reverting the changes.

“Function_call_expression_ctx_config15.json”,
“Function_call_expression_ctx_config19.json”

will be fixed from the LS side.

PR: https://github.com/ballerina-platform/ballerina-lang/pull/38852 will address remaining cases

Due to the recent changes in https://github.com/ballerina-platform/ballerina-lang/pull/38852, the following LS tests mentioned on this document need to be fixed as well.

@mindula could you overtake this and see through the expected types API.

Closing this since the test cases have been fixed and the PR to master is ready: https://github.com/ballerina-platform/ballerina-lang/pull/39287


Remove Deprecated Check for UpdatedReplicas Field in Etcd Waiter Function

How to categorize this PR?
/area control-plane
/kind cleanup
What this PR does / why we need it:
This PR removes the check for the deprecated UpdatedReplicas field in the CheckEtcdObject function within etcd/waiter.go. The logic for checking replicas is now handled by etcd-druid here, making it sufficient to only check status.ready.
Release note:
NONE

/cherry-pick release-v1.81

/test pull-gardener-e2e-kind

/hold

/unhold


Re-exports do not work across crates

If I add std.rs with these contents
import option = hack::option;

export option;

mod hack {
    import option = option::t;
    export option;
}

I can't access the std::option type from outside the crate.

The problem is viem_items (view_item_export here) are not written to crate metadata. I'll try to fix that.

Closed by commits 9bb290c, bd30063 and 5e3ffb6


[Feature] Unnest supports multiple parameters of different types

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

starrocks_be_unittest succeeded.

starrocks_be_unittest succeeded.

[FE PR Coverage Check]
:heart_eyes: pass : 48 / 50 (96.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/transformer/RelationTransformer.java
3
4
75.00%
[667]

:large_blue_circle:
com/starrocks/catalog/FunctionSet.java
9
10
90.00%
[1260]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/QueryAnalyzer.java
19
19
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/TableFunction.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AST2SQL.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/TableFunctionRelation.java
3
3
100.00%
[]

starrocks_be_unittest succeeded.

[FE PR Coverage Check]
:heart_eyes: pass : 55 / 56 (98.21%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/transformer/RelationTransformer.java
3
4
75.00%
[667]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/FunctionSet.java
15
15
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/QueryAnalyzer.java
19
19
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/TableFunction.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AST2SQL.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/TableFunctionRelation.java
3
3
100.00%
[]

BE Build Success

[FE PR Coverage Check]
:heart_eyes: pass : 56 / 57 (98.25%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/transformer/RelationTransformer.java
3
4
75.00%
[667]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/FunctionSet.java
15
15
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/QueryAnalyzer.java
19
19
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/TableFunction.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AST2SQL.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/TableFunctionRelation.java
3
3
100.00%
[]

BE Build Success

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 55 / 56 (98.21%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/transformer/RelationTransformer.java
3
4
75.00%
[667]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/FunctionSet.java
15
15
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/QueryAnalyzer.java
19
19
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/TableFunction.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AST2SQL.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/TableFunctionRelation.java
3
3
100.00%
[]

run starrocks_admit_test


Browser back & forward button loses scroll position

When navigating between two pages using back/forward in the browser, the scroll position is always reset and the page is scrolled to the top.
I have an older application that is using Turbolinks where this does not happen.
Thank you!

Thank you for opening this. Does https://github.com/hotwired/turbo/pull/57 resolve this?

Thank you for your swift reply, unfortunately that doesn’t seem to fix it. I installed this dev build to try it out, I hope that was how I should test it out. Otherwise I’m open to more testing, of course.
I can’t seem to replicate this bug on the hotwire docs site btw, which as far as I can tell also uses Turbo: https://turbo.hotwire.dev/handbook/introduction
I have created a tiny demo page that replicates the bug: https://maxlielje.co/turbo-scroll-demo/ Scroll down, click the link to the sub page, and then navigate back. This resets the scroll position to the top.

Digging deeper, the way that the turbo docs site uses turbo is like this:
<script type="module">
  addEventListener("load", () => import("https://cdn.skypack.dev/@hotwired/turbo?min"))
</script>

Changing my demo to use that load event triggered import seems to fix it. I will investigate if that fixes it for my main application, too.

I have done some more testing with the load-based import and it seems that the scroll position is lost when navigating back quite quickly after navigating to a page. It is restored correctly when the visit on the target page lasts a second minimum, at least that’s what it feels like. The load-based import is an improvement over the "regular" (or bundled as I have in my main app) import as at least it sometimes works. It still doesn’t always, though, even after waiting.
On the demo page (https://maxlielje.co/turbo-scroll-demo/), when scrolling down and navigating to the sub page and immediately clicking back, which is easy to do on a trackpad for example with swipe gestures, the scroll position is lost.
When navigating to the sub page, waiting a second, and then navigating back, the scroll position is restored.
I also tested this with a turbolinks based app and there the it works correctly even when navigating back very quickly. I couldn’t get turbolinks to lose the scroll position at all.

Same problem here, I'm using:
<script type="module" src="https://cdn.skypack.dev/@hotwired/turbo"></script> in <head>.

I think the problem is the type="module".

It doesn't work for me the docs website too... Chrome 88, Windows 10. @mxlje can you confirm?

Docs website: It does work for me most of the time on macOS and Brave, so chromium. It never works with Safari.
It feels like a timing issue / race condition to me, like it has something to do with how fast the target page is loaded completely and if that is interrupted somehow. It’s very inconsistent.
@seanpdoyle does anything come to mind that might cause this?

@mxlje for me your demo page (https://maxlielje.co/turbo-scroll-demo/) was working correctly (regardless of how fast I'm going back), but at some point stopped.
I've spent a few minutes trying to reproduce what's caused a failure and I found that it's a "click".

Open demo page https://maxlielje.co/turbo-scroll-demo/
Scroll down to the link and click it.
Go back and see that everything is fine.
Click the link again.
Click on any part of the page (text, title, empty space).
Go back. The scroll position is lost.

Scroll position will not work too when clicking on the first page too:

Open demo page https://maxlielje.co/turbo-scroll-demo/
Click on text or empty space.
Scroll down to the link and click it.
Go back and see scroll position is lost.

@vovayatsyuk I can repro the same bug you describe on Chrome 89
but on Firefox 86 I can never repro it
and on Safari 14 it happens 100% of the time, even when I don't click anywhere on the page before going to the next page
(I'm on macOS Catalina 10.15.7)
🤔

There seem to be two issues in the demo above:

On Safari 14.0.3 every time when I navigate back, it first goes to the right location and after a second or 2 jumps up.
On Chrome 90 it breaks as described above: only after clicking on random places in the first page before clicking the link.

I reverted my project from Turbo back to Turbolinks until this issue is fixed. I managed to utilize Turbo Frames on the project in the meantime, so had to create some temp code to load <turbo-frame tags manually.

Just discovered this issue as well, and it'll be a big problem with the app I'm building. Only tested in Safari 14.0.2 and Chrome 89 on mac.
Managed to replicate on the turbo docs as well:
https://user-images.githubusercontent.com/7999019/116958844-06fd2200-acdb-11eb-9fa1-73607579746e.mp4

I hacked together a fix guys! I didn't make this a PR because this is truly a hack. I don't know enough of the rest of the code base and conventions. Perhaps this can be a starting point for someone to make a proper one?
diff --git a/src/core/drive/visit.ts b/src/core/drive/visit.ts
index 1187f55..02889a8 100644
--- a/src/core/drive/visit.ts
+++ b/src/core/drive/visit.ts
@@ -38,6 +38,7 @@ export type VisitOptions = {
   action: Action,
   historyChanged: boolean,
   referrer?: URL,
+  restorationIdentifier?: string,
   snapshotHTML?: string,
   response?: VisitResponse
 }
@@ -310,7 +311,7 @@ export class Visit implements FetchRequestDelegate {
   }

   scrollToAnchor() {
-    if (getAnchor(this.location) != null) {
+    if (getAnchor(this.location) != "") {
       this.view.scrollToAnchor(getAnchor(this.location))
       return true
     }
diff --git a/src/core/native/browser_adapter.ts b/src/core/native/browser_adapter.ts
index 44c2bee..4252359 100644
--- a/src/core/native/browser_adapter.ts
+++ b/src/core/native/browser_adapter.ts
@@ -15,7 +15,7 @@ export class BrowserAdapter implements Adapter {
   }

   visitProposedToLocation(location: URL, options?: Partial<VisitOptions>) {
-    this.navigator.startVisit(location, uuid(), options)
+    this.navigator.startVisit(location, options?.restorationIdentifier || uuid(), options)
   }

   visitStarted(visit: Visit) {
diff --git a/src/core/session.ts b/src/core/session.ts
index 92d8ccb..97189bb 100644
--- a/src/core/session.ts
+++ b/src/core/session.ts
@@ -105,9 +105,9 @@ export class Session implements FormSubmitObserverDelegate, HistoryDelegate, Lin

   // History delegate

-  historyPoppedToLocationWithRestorationIdentifier(location: URL) {
+  historyPoppedToLocationWithRestorationIdentifier(location: URL, restorationIdentifier: string) {
     if (this.enabled) {
-      this.navigator.proposeVisit(location, { action: "restore", historyChanged: true })
+      this.navigator.proposeVisit(location, { action: "restore", historyChanged: true, restorationIdentifier })
     } else {
       this.adapter.pageInvalidated()
     }

In debugging this, I can confirm that when restoring a page the URL is valid, but the restorationIdentifier is new every time. It appears some of the code used to behave this way, but was removed.
For example, see the following refactoring in Session

first:  https://github.com/hotwired/turbo/commit/ab6907fbaa378c05210e8e94284fc0edcb31fa74#diff-da4d3d3a97b9ed26e47b50d9a5d2f5795434467e001f8a6deba72c361a23baa7L102-L108

restorationIdentifier no longer passed along #historyPoppedToLocationWithRestorationIdentifier
#visit was renamed to #proposeVisit, but no longer supported the restorationIdentifier parameter

then:  https://github.com/hotwired/turbo/commit/843bf38f3c73ba0148d1897d2158cc0f4d6da2f9

restorationIdentifier removed from params

However,History still passes restorationIdentifier to historyPoppedToLocationWithRestorationIdentifier() even though the parameter has since been removed.
see: https://github.com/hotwired/turbo/blob/main/src/core/drive/history.ts#L96

Ah, looks like some of this was already discovered by the team in https://github.com/hotwired/turbo/pull/57, but the PR was just closed a few days ago.

As a temporary fix you could add something like the following:
class ScrollPosition {
  save() {
    document.body.dataset.scrollPosition = JSON.stringify([window.scrollX, window.scrollY]);
  }

  restore() {
    const scrollPosition = JSON.parse(document.body.dataset.scrollPosition || '[]');
    if (scrollPosition.length > 0) {
      window.scrollTo(...scrollPosition);
    }
    delete document.body.dataset.scrollPosition;
  }
}

const scrollPosition = new ScrollPosition();

document.addEventListener('turbo:before-cache', function (_event) {
  scrollPosition.save();
});

document.addEventListener('turbo:load', function (_event) {
  scrollPosition.restore();
});

Ah could've saved me some time debugging, if I knew about #57 - it's very similar to my hack! Wonder why it was closed without merging.
Nice solution @tleish

It's fixed in beta 8! 🥳

Sorry for my late reply here and thanks everyone for helping narrow it down and then of course fix it. It indeed does look like the problem is fixed in beta 8 🎉


[DO NOT MERGE] Fixes for fast-queueing

Avoid doing reloadData while there are perfomBatchUpdates animating: https://github.com/diegosanchezr/UICollectionViewStressing/tree/master/GhostCells
Relying on tracked visible cells and transforming then with CollectionChanges is not reliable. It's safe in terms of giving to the presenters a cell of a correct type, but it may end giving a presenter a cell that doesn't belong to it. Instead, now we take the cells from indexPathsForVisibleItems + cellForItemAtIndexPath and use the tracked cells just to detect inconsistencies. If this happens, we delay the update until the animations finish hoping the inconsistency will go away. If the consistency stays after all animations have finished we'll fall back to reloadData.

[Current coverage][cc-pull] is 65.68%

Merging [#157][cc-pull] into [dev][cc-base-branch] will increase coverage by 0.33%

@@                dev       #157   diff @@
==========================================
  Files            61         61
  Lines          3279       3308    +29
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           2143       2173    +30
+ Misses         1136       1135     -1
  Partials          0          0

Powered by Codecov. Last updated by [5c3c84e...adeae5d][cc-compare]
[cc-base-branch]: https://codecov.io/gh/badoo/Chatto/branch/dev?src=pr
[cc-compare]: https://codecov.io/gh/badoo/Chatto/compare/5c3c84e6a63abc650c2e269b3d19877ae6722221...adeae5d8b2ffb8ed9fa0850e86a59c5b9f8db641
[cc-pull]: https://codecov.io/gh/badoo/Chatto/pull/157?src=pr


error in LachesisNode_ConnectClient for large number of nodes

When running 25 nodes, get an error. This is an intermittent issue.

WARN[0035] recv from server err: try to reconnect
panic: interface conversion: interface is nil, not internal.LachesisNode_ConnectClient

Modify closeStream() in grpc_lachesis.go:
v := p.stream.Load()
if v != nil {
stream, _ := v.(internal.LachesisNode_ConnectClient)
if stream != nil {
stream.CloseSend()
}
}
@Maxime2 can you try the fix?

Fixed.


Deprecate szokodiakos/typegoose, use hasezoey/typegoose

as the title & branch says:
Add notes that the original repo (this one right here) got moved to a newer-version
@Ben305 merge this, when you are ready to "move" as by hasezoey#1
(this should be in the last published version of typegoose(npm))

Coverage increased (+0.05%) to 88.426% when pulling ad1125a340a33df64c6b286534e263f8d68d4af4 on hasezoey:deprecateoriginalrepo into ee37b68fa2713c31efa09e0e007279b51e5e9d54 on szokodiakos:master.


Font options in toolbar missing after font refactor

Godot version
v4.0.alpha12.official [2c11e6d9e]
System information
Windows 10
Issue description
After the font refactor for Alpha 12, the font options in the toolbar is no longer present. Having these options at a glance, automatically register font families, and in the toolbar made working with fonts substantially easier, rather than having to navigate to theme overrides every time.
Alpha 11

Alpha 12

Steps to reproduce

Create a new project
Add any control node that uses text (Label, RichTextLabel, LineEdit, etc)
Select node, notice options missing from toolbar

Minimal reproduction project
Two projects for ease of testing and not having to reimport between the two versions.
font-options-toolbar_a11.zip
font-options-toolbar_a12.zip

cc @bruvzg

It was removed in favor of https://github.com/godotengine/godot/pull/62139, toolbar was causing issues on a small screens and was inconsistent with the rest of editor UI.

Indeed, this is by design. Similar functionality will come back in a different form in future alphas :)


chore(main): release 1.7.2

:robot: I have created a release beep boop
1.7.2 (2024-08-29)
Bug Fixes

ollama: fetching models from remote repo (1863500)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.7.2
:sunflower:


DIfferent version in Chinese 1.41.1-E

UCP always show missing components while the game version is Chinese1.41.1E.

Is it only the Extreme version or also the normal one?
For reference, similar problems occur with the Russian version https://github.com/Sh0wdown/UnofficialCrusaderPatch/issues/518.

Both with the normal and the extreme versions


Logs of retrain.py break web browser when launched in Colab

When you play with retrain.py locally on your machine (I use Jupyter Notebook and Docker) it is fine to do 10k-20k training steps.
But when you try to launch it on Colab, it seems that the amount of logs is way too big, and usually it breaks Chrome, making it's card impossible to launch (tested on Macbook Pro 2017, 16GB Ram, i7).
Maybe it would be a good idea to define level of logs as a input argument in retrain.py script?
How to reproduce:
Launch my project in Colaboratory: https://github.com/frogermcs/GTSRB-TensorFlow-Lite. It's pretty likely Chrome will crash during the learning process (3/4 tries crash).

@frogermcs  Could you please confirm if you selected the "Hardware accelerator" from the Colab ? If so, which one you selected ?

Usually it's TPU. Do you think it can have something with it?

@frogermcs it might be useful what specific error message(s) is overly verbose. In general if the messages are printed through standard Python or standard TF Logger, they could be disabled by tweaking the logging level before running the function from retrain.py.
For standard TF logger you can do something like "tf.logging.set_verbosity(tf.logging.FATAL)" before running the function in question. For standard Python logging it would be "logging.root.setLevel(logging.FATAL)"
If the message are produced by print() you could just redirect all stdin into a file, e.g.
sys.stdout = open('file', 'w')
print("Blah")  # Will be written to file.

I think setting logging level is not possible with current retrain.py implementation because of that:
def main(_):
  # Needed to make sure the logging output is visible.
  # See https://github.com/tensorflow/tensorflow/issues/3047
  tf.logging.set_verbosity(tf.logging.INFO)

Maybe it would be good to differentiate logs a little bit? For example:
          tf.logging.info(
              str(how_many_bottlenecks) + ' bottleneck files created.')

should be logging.debug()? And just some final info about script outputs should be .info()? And then we could parametrize it via input args. What do you think 🤔?

And the issues I have? "Aww snap" from Chrome. Tab is either crashing or when I launch it, view isn't rendered. Usually when I'm in a half way of retrain.py - bottlenecks are probably already created, and training process is in progress.

What about as an immediate work-around, just redirecting stdout and stderr as I mentioned in my last post?
But in general I think it makes sense to add a flag to be able to set the logging level for the script. @arnoegw to see if there are any concerns with the approach.

@frogermcs, I think tf.logging.info every 100 files is ok, but logging for each file (e.g., at line retrain.py:354) should be logging.debug.
Would you like to send me a pull request that adds a --logging_verbosity flag and fixes the per-file logging?

Just created Pull Request (#252). I also tested it in my project and works fine in Chrome and Colab. Finally I could leave the Chrome tab open and come back to it after an hour. :)

I merged the pull request earlier today.
Folks who like to train an image classifier in a colab and enjoy living on the cutting edge of TF 2.0.0alpha0 (announced last week) might want to take a look at  examples/colab/tf2_image_retraining.ipynb which is considerably smaller, faster (if you use a GPU), and even supports fine-tuning the image module.


Threading and Avalonia properties

First thanks for such big effort! :)
TLDR: The code of at least AvaloniaProperty seems to be not thread safe, with hidden assumption that only main UI thread might interact with it.
When looking at the code of AvaloniaProperty, I get impression that this code is expected to be called ONLY from one thread at same time. No checks are done for concurrency.
At least _metadata* are not thread safe structures. If there would be at least 2 Dispatchers involved and on them 2 property registration would happen, this might lead to undefined behavior (works, infinite loops, NRE, mess up state).
When looking at Dispatcher code and comment "In Avalonia, there is usually only a single 'Dispatcher' in the application" with public ctor it might indicate more than one Dispatcher.
On other hand, CheckAccess/VerifyAccess are using one single well known UI thread.
That's perfectly fine that AvaloniaUI will be single threaded UI framework. The HTML/JS/DOM proven that single threaded UI just works.
Still I would like to made it clear and appropriate code is put in different places to avoid accidental cross thread calls for the following reasons:

as behavior is undefined for cross thread calls, the diagnostics of such issues is very hard
this would cut all the bizarre ideas like off loading some UI work to other threads as they are clearly ot supported
with await/async + Task it is very easy to land on not appropriate thread, hence ANY diagnostics are welcome.
if such checks are not necessary (it is obvious it is single threaded), then why there is dispatcher concept with CheckAccess?

Of course it AvaloniaUI would be multi-dispatcher, then probably rather big refactor is needed.
So, what's the team stance on this topic?

Dispatchers were initially designed against WPF's dispatchers, but it turned out that most platforms don't allow multithreaded access to UI-related APIs. So the framework now enforces everything to work on the UI thread. We could implement support for multiple dispatchers, but that will only work for Win32 and X11.

with public ctor it might indicate more than one Dispatcher.

I think at some point someone tried to reuse the displatcher code to run their own (non-UI) main loop on non-UI thread. It was quite a while ago though. We should probably remove it.

Hmm. Setting AvaloniaProperty always involves a call to VerifyAccess that throws if someone tries to get or set the property from a thread other than the ui thread.
You can always perform non ui related tasks on a different thread you just need to use the ui thread's dispatcher to marshall the result to the ui thread. That works the same with Wpf.

@kekekeks That's fair.
@Gillibald Does the registration of property also does this check? Non concurrent versions of structures (Dictionary<>, Queue<>) without sync primitives looks suspicious.
But from your answer it seems that this is an assumption that AvaloniaUI is single threaded…
… and you have it under full control. That's good!
Thanks!


Missing the features ..

It seems gallery , camera, even the options of settings page, nothing is working like the given screenshoot.

Same here, nothing works..

yes ,same here not working everything
they show just screenshot ???


[DO NOT MERGE] Porting ROCm blfoat16 support to master-rocm-enhanced

This PR is to port the ROCm blfoat16 support from the develop-upstream to the master-rocm-enhanced branch.
We need to have a few pre-reqs in place before we can take this PR

[ ] identify a commit on the upstream/master branch for which all ROCm CI jobs (rocm, rocm-cpp, rocm-xla)  are passing, aka the ROCm CI qualified commit
[ ] rebase the master-rocm-enhanced branch to the ROCm CI qualified commit
[ ] Setup ROCm CI jobs to run on PRs filed on the master-rocm-enhanced branch

The purpose of filing this PR now is to assist with filtering out the changes in this PR, from the set of diffs in develop-upstream that we need to triage before we abandon that branch

Can one of the admins verify this patch?


Build eos image for eos

Change Description
Buildkite was building the eos-dev image and pushing it to gcr as eos.
Instead, build eos and push it as eos.
Consensus Changes
None
API Changes
None
Documentation Additions
None

Grabbing this review from Eric, since I know about this change.  This should have no effect on anything currently running; it just basically makes sure we don't have unnecessarily bloated images when in the non-dev environment.


Web - Language is out of sync when logging in to another device

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login account A on device 1
Go Setting => Preference => Language
Change language to "Spanish"
Login account A on on device 2, observed that the language is not the same as device 1

Expected Result:
The language of the 2 devices must be the same
Actual Result:
The language is not the same as device 1
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/08bde6f0-9763-4249-93b9-512f38359fd5
https://github.com/Expensify/App/assets/93399543/29c46209-d781-4463-8367-9a0c2ef087e2
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688272791784679
View all open jobs on GitHub

@namhihi237 When you say two devices here - do you mean two web browsers? When I change the language on web Chrome on staging it updates my Android device is updating, so would be good to get clarity what the exact devices are. Thanks!

I cannot reproduce this on my end, it updates both ways when I have tested this, so closing


watchdog

A hang watchdog support or documentation for it?

[ ] remove reset-in from dashboard
[ ] fix in jacdac-c/devicescript
[ ] use resetin


Parsing book subtitles

Hi,
I'm having an issue with book subtitles. I'm not sure if the problem is in the way they are handled in the bibtex file I'm working in or with pandoc-citeproc itself.
Basically, when I export my bibtex file from Papers (the citation manager I use), the title of the book appears in the field 'title,' and the subtitle appears in 'series' (example below). The problem is that when I convert everything using pandoc, the subtitle doesn't get italicized as part of the book name. So for example the book Freud, Jews, and other Germans: Masters and Victims in Modernist Culture appears only as Freud, Jews, and other Germans: Masters and Victims in Modernist Culture.
Is there anything I can do to prevent this? or to fix it?
Thanks!
Example of bibtex entry:
@book{Gay:1978tq,
author = {Gay, Peter},
title = {{Freud, Jews, and other Germans}},
publisher = {New York : Oxford University Press},
year = {1978},
series = {Masters and Victims in Modernist Culture}
}

What csl are you using?  The default is chicago-author-date.csl,
so that's what you're getting if you don't specify one.
You could try customizing it, changing

to

both places where it occurs.
+++ Mendel Kranz [Dec 01 15 20:06 ]:

Hi,
I'm having an issue with book subtitles. I'm not sure if the problem is
in the way they are handled in the bibtex file I'm working in or with
pandoc-citeproc itself.
Basically, when I export my bibtex file from Papers (the citation
manager I use), the title of the book appears in the field 'title,' and
the subtitle appears in 'series' (example below). The problem is that
when I convert everything using pandoc, the subtitle doesn't get
italicized as part of the book name. So for example the book Freud,
Jews, and other Germans: Masters and Victims in Modernist Culture
appears only as Freud, Jews, and other Germans: Masters and Victims in
Modernist Culture.
Is there anything I can do to prevent this? or to fix it?
Thanks!
Example of bibtex entry:
@book{Gay:1978tq,
author = {Gay, Peter},
title = {{Freud, Jews, and other Germans}},
publisher = {New York : Oxford University Press},
year = {1978},
series = {Masters and Victims in Modernist Culture}
}
—
Reply to this email directly or [1]view it on GitHub.
References

https://github.com/jgm/pandoc-citeproc/issues/199

I'm actually using chicago-full-note-bibliography but that seems to do the trick. (As an aside, I'm not sure I actually know the difference between the two.)
Is this what everyone has to do to ensure subtitles of books are italicized? Or is my setup somehow different?
Also, I noticed I'm getting a dot (.) in between title and subtitle as well as right after the subtitle. Is there any reason for this?
For example, the above citation is rendered as:
Gay, Peter. Freud, Jews, and other Germans. Masters and Victims in Modernist Culture. New York: Oxford University Press, 1978.

+++ Mendel Kranz [Dec 01 15 20:38 ]:

I'm actually using chicago-full-note-bibliography but that seems to do
the trick. (As an aside, I'm not sure I actually know the difference
between the two.)
Is this what everyone has to do to ensure subtitles of books are
italicized? Or is my setup somehow different?

It seems to me that Papers is doing something pretty strange
in mapping subtitle to series.  Not all subtitles are series
titles (some are).  BibLaTeX has a 'subtitle' field, why
doesn't Papers use that?

Also, I noticed I'm getting a dot (.) in between title and subtitle as
well as right after the subtitle. Is there any reason for this?
For example, the above citation is rendered as:
Gay, Peter. Freud, Jews, and other Germans. Masters and Victims in
Modernist Culture. New York: Oxford University Press, 1978.

See above.  This is appropriate for series.
Not so much for subtitle.

It seems to me that Papers is doing something pretty strange
in mapping subtitle to series.  Not all subtitles are series
titles (some are).  BibLaTeX has a 'subtitle' field, why
doesn't Papers use that?

Weird. I've submitted a support request with them, hopefully they'll have an answer for me.
Thanks for the help.


Firestore convenience, camera button added back, pods removed, .gitignore implemented, other stuff

added a convenience class that will help new devs get this working with a new instance of Firestore (ATCRemoteData.swift), added .gitignore to prevent accidental commits with GoogleService-Info.plist, gitignore won't track or add pods or Podfile.lock, debugging statements added throughout-- not having them means a clean terminal, but it is damn hard to stack trace if we don't know what is working and how. Also, modified ID scheming, it is more logical to make the chat threads look like {userID}:{userID} instead of concatenating the two

Looks great. Thanks a lot!


Bro integration

Will squash and merge. more work to do, of course.

I am going to close the PR, but leave the branch.


Where is AnnoDesigner.exe. ?

I don't see it and so I have no way to launch it, I extract the documents and ... nothing! No icon or button to launch the app...

It is not in the source code. You should go to releases, there you will find built executable https://github.com/AnnoDesigner/anno-designer/releases/tag/AnnoDesignerv9.4

Keep in mind the Documents Folder is a Protected one by Microsoft, install this in C:\Program File\ folder
The program has a link, witch is seen as "Bad" by windows Defender....


⚠ Bofrost.at has degraded performance

In 2639aa1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1511 ms

Resolved: Bofrost.at performance has improved in 0ecc96f after 6 minutes.


Add test and README  + rebase

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 5 committers have signed the CLA.:x: nikicc:x: wI2L:x: bluemoon:x: hmajid2301:x: armandpicardYou have signed the CLA already but the status is still pending? Let us recheck it.


Access to Resource Manager's Organization Policies API (v1)

Problem
I'd like to use the v1 API that relates to Organization Policy management with the Python client, but:

Cloud Resource Manager v3 API does not provide access to the Organization Policy management
current version (1.1.0) of the python-resource-manager client does not provide wrappers around the v1 API which would expose the desired APIs [1]

Question
I'd like to have guidance on the matter:

would the v1 API be baked into the python-resource-manager client someday ?
might other APIs / Python client give access to similar API
are those APIs designed to only be accessed by other means (through discovery[2] for example)
should I use older version of the python-resource-manager

Thank you,
Alexis
[1] https://cloud.google.com/resource-manager/reference/rest/v1/projects/getOrgPolicy
[2] https://cloud.google.com/resource-manager/reference/rest/v1/projects/getOrgPolicy#python

Hi @aderuelle,
I believe resource manager v3 was intended to merge the features in v1 and v2. However, I see that the v3 doesn't seem to have org policy methods. I've opened a ticket with the internal teams that manage the Resource Manager and Organization Policy APIs and will update this issue once I get a response.

I found an existing feature request for the API team here to expand the V3 API to include features that were available in V1. Please visit this link to file additional feature requests. I'm going to close this issue as it is a feature request for the API rather than the client library.


Methodology edits

Minor README methodology edits. This replaces PR #8.

@dgendill
The math looked fine except for the annual number of hours being 10 short (8760 was correct in paragraph below the math).
I don't fully understand the "system output" relationship to the reduction numbers, so maybe we can clarify and reword at the next meeting.

Looks good, thanks!
Yeah that last part is sort of disconnected from the rest right now.  I think we were going to use that number to chart Fort Collin's total capacity to solar capacity over time, or to make a pie chart showing what types of energy contribute to the whole.  This is the math Ian did at the meeting...
On page 13 of the 2014 climate action plan it says we get 0.2% of energy from local Fort Collin's solar.  It also says the total solar capacity at the end of 2014 was 2,625kw.  So then we can infer the total capacity of Fort Collins (renewable and non-renewable) by dividing 2625 by .002 to get 1,312,500kw.


add a stub for TimeTileLayer

@Bobfrat this should get us back up and running w/ TimeTileLayers.  For now (forever) it treats them like TileLayers.

https://travis-ci.com/asascience-open/Leaflet/builds/89559871

What am I supposed to do w/ that travis info?

I didn't make a PR when I 1st made the oceansmap branch, so I guess that's why we didn't run into this earlier.

/home/travis/build/asascience-open/Leaflet/src/layer/tile/TimeTileLayer.js
20:1  error  Expected indentation of 1 tab but found 8 spaces  indent

Closing in favor of #3.


updated GitOps UI for dashboard and version history

What type of PR is this?
type::feature
What this PR does / why we need it:
Cleans up the UI and gets rid of confusion around deployed and new available versions when GitOps is enabled.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Demo showing changes: https://www.loom.com/share/1e19ac639f8f43168b136e5ef8698239
Does this PR introduce a user-facing change?

UI improvements to the Application Dashboard and Version History page when GitOps is enabled

Does this PR require documentation?
NONE (that I know of, potentially some new screenshots but thats TBD)

This looks great! 👍  Video was super helpful. I would like to have @rianfowler take a look as well.


[Fix] Make --rest optional to prevent auto-change of REST port with --dev

Motivation
Solves Issue #3220 wherein specified rest port was overwritten by the default when the --dev flag was being used.
Test Plan
This will only change a node's behavior when both --dev and --rest are used.
Tested locally.
Related PRs
(Link any related PRs here)

I'm not sure of the scope of this change, but no matter what, I want to make sure that anytime we require a port that we can set both host:port to a specific values.  There's a tendency for us to simply bind to <IP_ADDRESS>:port and this breaks multi-homed deployments in production environments.  Dev environments, I understand, are special, but for everything else, these values, at a minimum, should be configurable either via command line or in a config file.


Is it possible to create a similar extension for VS Code?

Implementing VS Code support is left as an exercise :)


Fixed #26277 -- Added support for null values in ChoicesFieldListFilter.

https://code.djangoproject.com/ticket/26277

Please uncheck "Patch needs improvement" on the ticket after updating the PR, thanks!

merged in 069319396f0e9fb10254e1bcf578336392c9cffb, thanks!


JS: use type inference to back up function-style classes

This makes ClassNode take advantage of type inference to recognize function-style classes in more cases.
Evaluation (internal link). Currently re-running on rhino.

ClassNode is not actually being computed by our standard suite at the moment, so I'm not sure why I ran the evaluation in the first place.

Heh, well, I suppose it's a useful check for how noisy dist-compare results are in practice...


Updated README.md to include Debian installation instructions

Hi, Linqigan. Thank you for all you have done to make C++ Workflow a part of Debian packages. It's very important for us and for our project. I hope we shall cooperate continuously. Thanks for this pull request too.


[QUESTION] Multi function gathered result / Aiohttp - use Client with event loop inside view to get result

First check

[x ] I used the GitHub search to find a similar issue and didn't find it.
[ x] I searched the FastAPI documentation, with the integrated search.
[ x] I already searched in Google "How to X in FastAPI" and didn't find any information.

Description
I want use code:
async def fetch(session: ClientSession, url: str) -> str:
    async with session.get(url) as resp:
        return await resp.text()

async def main(urls: List[str]):
    async with aiohttp.ClientSession() as session:
        tasks = [asyncio.ensure_future(fetch(session, url)) for url in urls]
        response_data = await asyncio.gather(*tasks)
        return response_data

def get_code(urls: list):
    data = asyncio.run(main(urls))
    return data

to create API call like this:
router = APIRouter()
@router.get("/sourcecode/from-url")
async def online_sources(link: AnyUrl):
    data = get_code(list(link))
      return {'data': data}

but this code create internal server error:
  File "/home/pi/.local/lib/python3.7/site-packages/nest_asyncio.py", line 11, in apply
    raise ValueError('Can\'t patch loop of type %s' % type(loop))
ValueError: Can't patch loop of type <class 'uvloop.Loop'>

Additional context
Targer platform is Raspberry PI 4 with Python 3.7.3 (Rasbian OS)
Perspective
My target is create NLP service where using API call is possible get response from bunch of urls and process them using NLP. My code outside Fast API to get source code and result of externatl calls working, but inside Fast API I have not idea how coded it to makes them working.
For single call I found intergration:
Single call aiohtpp
but I want inside Fast API parts when one function gathers multitime result (async gather result) and try find patter to achieve something similar to code provided above.  Provided code is with single URL, but I want modified design to use multi URL passed by this API point inside aiohttp Client. I have not idea how move forward and resolve this.
Best regards

Not at a computer to test right now but I think the issue is that FastAPI is already running asyncio for you. So instead of trying to run your coroutine with asyncio.run in get_data you should just be awaiting your coroutine.
So try this:
router = APIRouter()
@router.get("/sourcecode/from-url")
async def online_sources(link: AnyUrl):
    data = await main(list(link)) # this is the change
    return {'data': data}

I'm looking pattern to use async code with Fast API. Your suggestion is good when only website is process, because still I have asyncio.gather which is not compatible as you suggest me. Ma target is:

API call
fill from function data from call
run the same function multitimes with other data
get / put somewhere result of operation to use with other API calls.

I wrote this -> Single call aiohtpp
This is an example for multiple calls
@app.get('/endpoint')
async def endpoint():
    url = "http://localhost:8080/test"

    with aioresponses() as mock_server:  # mock answer , remove in real
        mock_server.post(url=url, status=200, body=json.dumps({"succes": 1}))
        mock_server.post(url=url, status=200, body=json.dumps({"succes": 2}))

        async_calls: List[Coroutine] = list()  # store all async operations

        async_calls.append(SingletonAiohttp.query_url(url))
        async_calls.append(SingletonAiohttp.query_url(url))

        all_results: List[Tuple] = await asyncio.gather(*async_calls)  # wait for all async operations

    return sum(all_results)

@js-compilatrum
can you close the issue

Ops! My mistake. Thank you for your help.

Thanks for the help here @dbanty and @raphaelauv ! 👏  🙇
Thanks for reporting back and closing the issue @js-compilatrum  👍

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.


All posts with @here/@everyone are ignored

What was the original intent for those checks in the code?  I just persisted them (albeit with a singular regex).

Merging the refactored code undid this fix, to fix: add a function which strips @here and @everyone.

Ah.  I get it.  We don't want the bot using those mention types just because a user did, but we still want to respond to those posts.

Also, they both contain e, so they shouldn't respond to the post of there's no e in the rest of the post.

It should also strip other mentions too, so it doesn't ping people a second time.

Should be fixed by #3.


minor improvements to wording

TBH, I'm not a fan of the space-wasting "you must scroll and scroll to see more content" style, which was super-hip around 2015 but looks a bit dated now. But I realize that changing the style is probably out of scope, so I just made some minor text improvements.
One thing that I addressed is that the features menu points to https://linkml.io/#features, but nothing happens -- it just shows the main page. I think it's meant to bring you back up to the top if you were further down the page -- but since the menu doesn't stay fixed at the top of the page, it's no longer visible to click on if you've scrolled down, so it seems pointless. I therefore am suggesting getting rid of that menu item, but if there's somewhere useful it could point, please lmk where that is!

I don't have permission to merge.

@sierra-moxon could you merge this so i can see how it looks before i try changing the templates as described in https://github.com/linkml/linkml/issues/759?
thanks!

@sujaypatil96 can you merge this PR? Chris approved it. Thanks!

Merging it in @nlharris.

Thanks Sujay... but uh oh, now https://linkml.io/ shows up empty!! I must have messed something up, maybe missed a close quote or something?

Oh wow, should we revert? Or we can figure out what the issue is, and make another PR immediately.

see PR #4 which i think should fix it


Invariant Violation: requireNativeComponent: "ContextMenu" was not found in the UIManager

I have same problem:
Invariant Violation: requireNativeComponent: "ContextMenu" was not found in the UIManager
Stacktrace:
This error is located at:
    in ContextMenu (created by ContextMenu)
    in ContextMenu (created by CellRenderer)
    in RCTView (created by View)
    in View (created by AnimatedComponent)
    in AnimatedComponent
    in AnimatedComponentWrapper (created by CellRenderer)
    in RCTView (created by View)
    in View (created by AnimatedComponent)
    in AnimatedComponent
    in AnimatedComponentWrapper (created by TouchableOpacity)
...

I am using:

ios: 14.5 (reproducible on newer versions too)
emulator iphone 12 (reproducible on other versions too)
"expo": "46.0.9"
"react-native": "0.69.4"

If I start with npx expo run:ios I have not problem, but if I use npx expo start I have this problem, when the contextMenu component tries to draw on the screen.

@mpiannucci this question has already been asked and is getting more and more likes https://github.com/mpiannucci/react-native-context-menu-view/issues/42 but it has been closed

I havent tested with expo, so thats why i have not addressed this yet

It's a native module, so it's not going to work with Expo. Think we can just close this

It's true, to use with expo you need to run the application via npx expo run:ios or npx expo run:ios --device


Consider making a builder gem for the gov-au-guide-template

Nfi how to do this… but would be cool once the generic templates are abstracted out and cleaned up.

Closing this - can open a new issue in govau/uikit?


Module 'lucid.misc' has no attribute 'io'

I used to use notebooks flawlessly. Recently, I get this error
module 'lucid.misc' has no attribute 'io'
when importing some modules from the lucid library. Does anyone know how to solve this annoying error?

Solved.. it was an tensorflow version issue (there's no support for TF 2).
It's enough to add this line before the importing phase:
!pip install --quiet lucid==0.2.3
#!pip install --quiet --upgrade-strategy=only-if-needed git+https://github.com/tensorflow/lucid.git
%tensorflow_version only works on colab
%tensorflow_version 1.x


Fix flaky Windows Autopep8 & Black formatting test

https://dev.azure.com/ms/vscode-python/_build/results?buildId=90315&view=logs&j=e456b71d-3d0a-5786-582e-34e11c3491a4&t=2c4243b3-1d63-596d-5bf6-6777b4bab47e&l=7115

Closing this as we are moving to separate extensions


[BUG] type mismatch in NzInputComponent

I'm submitting a...

[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Support request => Please do not submit support request here

Current behavior

ERROR in /ng-zorro-antd/src/components/input/nz-input.component.ts (149,7): Type 'string | boolean | AutoSizeType' is not assignable to type 'boolean | AutoSizeType'.
Type 'string' is not assignable to type 'boolean | AutoSizeType'.

ERROR in /ng-zorro-antd/src/components/input/nz-input.directive.component.ts (72,7): Type 'string | boolean | AutoSizeType' is not assignable to type 'boolean | AutoSizeType'.
Type 'string' is not assignable to type 'boolean | AutoSizeType'.

Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Angular version: 4.0.0

ng-zorro-antd version: 0.5.0

it is not a mismatch, it is just a hack, with this code nzAutosize could work like an attribute.
    <nz-input [(ngModel)]="inputValueOne" nzType="textarea" nzAutosize nzPlaceHolder="Autosize height based on content lines"></nz-input>

@vthinkxie Got it,thanks!


Update operations fields with omitempty when tx is failed

Some operation details data may not be be available if tx is failed. For example, LP meta will be empty for LiquidityPoolDeposit. In such case the operation details with information that is unavailable should be hidden.

Wouldn't it be more cohesive/consistent to show empty fields? We can document that the fields will be empty when the transactions fails
Although .... maybe it makes operations harder to parse.

I checked the API again and I think you are right we can do omitempty for some and zero values for others. The only fields that require meta are:

for deposit:

LP assets - which probably should be hidden,
reserves_deposited which can be 0 because it's 0 for failed txs.

for withdrawal:

LP assets - which probably should be also hidden,
reserves_received which can be 0 because it's 0 for failed txs.

I think that it would be ideal to set the amounts to 0 when the transaction fails. e.g.
{
  "id": "3697472920621057",
  "paging_token": "3697472920621057",
  "transaction_successful": false,
  "source_account": "GBB4JST32UWKOLGYYSCEYBHBCOFL2TGBHDVOMZP462ET4ZRD4ULA7S2L",
  "type": "liquidity_pool_deposit",
  "type_i": 22,
  "created_at": "2021-11-18T03:47:47Z",
  "transaction_hash": "43ed5ce19190822ec080b67c3ccbab36a56bc34102b1a21d3ee690ed3bc23378",
  "liquidity_pool_id": "abcdef",
  "reserves_max": [
    {
      "asset": "JPY:GBVAOIACNSB7OVUXJYC5UE2D4YK2F7A24T7EE5YOMN4CE6GCHUTOUQXM",
      "amount": "1000.0000005"
    },
    {
      "asset": "EURT:GAP5LETOV6YIE62YAM56STDANPRDO7ZFDBGSNHJQIYGGKSMOZAHOOS2S",
      "amount": "3000.0000005"
    }
  ],
  "min_price": "0.2680000",
  "min_price_r": {
    "n": 67,
    "d": 250
  },
  "max_price": "0.3680000",
  "max_price_r": {
    "n": 73,
    "d": 250
  },
  "reserves_deposited": [
    {
      "asset": "JPY:GBVAOIACNSB7OVUXJYC5UE2D4YK2F7A24T7EE5YOMN4CE6GCHUTOUQXM",
      "amount": "0"
    },
    {
      "asset": "EURT:GAP5LETOV6YIE62YAM56STDANPRDO7ZFDBGSNHJQIYGGKSMOZAHOOS2S",
      "amount": "0"
    }
  ],
  "shares_received": "0"
}

and
{
  "id": "3697472920621057",
  "paging_token": "3697472920621057",
  "transaction_successful": true,
  "source_account": "GBB4JST32UWKOLGYYSCEYBHBCOFL2TGBHDVOMZP462ET4ZRD4ULA7S2L",
  "type": "liquidity_pool_withdraw",
  "type_i": 23,
  "created_at": "2021-11-18T03:47:47Z",
  "transaction_hash": "43ed5ce19190822ec080b67c3ccbab36a56bc34102b1a21d3ee690ed3bc23378",
  "liquidity_pool_id": "abcdef",
  "reserves_min": [
    {
      "asset": "JPY:GBVAOIACNSB7OVUXJYC5UE2D4YK2F7A24T7EE5YOMN4CE6GCHUTOUQXM",
      "min_amount": "1000.0000005"
    },
    {
      "asset": "EURT:GAP5LETOV6YIE62YAM56STDANPRDO7ZFDBGSNHJQIYGGKSMOZAHOOS2S",
      "min_amount": "3000.0000005"
    }
  ],
  "shares": "200",
  "reserves_received": [
    {
      "asset": "JPY:GBVAOIACNSB7OVUXJYC5UE2D4YK2F7A24T7EE5YOMN4CE6GCHUTOUQXM",
      "amount": "0"
    },
    {
      "asset": "EURT:GAP5LETOV6YIE62YAM56STDANPRDO7ZFDBGSNHJQIYGGKSMOZAHOOS2S",
      "amount": "0"
    }
  ]
}

However, we would need to obtain the assets ... which may not even be available in our database if the transaction contains the liquidity pool creation (or if the liquidity_pool_id in the operation is wrong).
Thus, I think we should just add omitempty to every field which may not be obtainable when the transaction fails.

Another option is to leave the assets as an empty string (or omit them),  when they are unknown, that would be:
{
  "id": "3697472920621057",
  "paging_token": "3697472920621057",
  "transaction_successful": false,
  "source_account": "GBB4JST32UWKOLGYYSCEYBHBCOFL2TGBHDVOMZP462ET4ZRD4ULA7S2L",
  "type": "liquidity_pool_deposit",
  "type_i": 22,
  "created_at": "2021-11-18T03:47:47Z",
  "transaction_hash": "43ed5ce19190822ec080b67c3ccbab36a56bc34102b1a21d3ee690ed3bc23378",
  "liquidity_pool_id": "abcdef",
  "reserves_max": [
    {
      "asset": "",
      "amount": "1000.0000005"
    },
    {
      "asset": "",
      "amount": "3000.0000005"
    }
  ],
  "min_price": "0.2680000",
  "min_price_r": {
    "n": 67,
    "d": 250
  },
  "max_price": "0.3680000",
  "max_price_r": {
    "n": 73,
    "d": 250
  },
  "reserves_deposited": [
    {
      "asset": "",
      "amount": "0"
    },
    {
      "asset": "",
      "amount": "0"
    }
  ],
  "shares_received": "0"
}

{
  "id": "3697472920621057",
  "paging_token": "3697472920621057",
  "transaction_successful": true,
  "source_account": "GBB4JST32UWKOLGYYSCEYBHBCOFL2TGBHDVOMZP462ET4ZRD4ULA7S2L",
  "type": "liquidity_pool_withdraw",
  "type_i": 23,
  "created_at": "2021-11-18T03:47:47Z",
  "transaction_hash": "43ed5ce19190822ec080b67c3ccbab36a56bc34102b1a21d3ee690ed3bc23378",
  "liquidity_pool_id": "abcdef",
  "reserves_min": [
    {
      "asset": "",
      "amount": "1000.0000005"
    },
    {
      "asset": "",
      "amount": "3000.0000005"
    }
  ],
  "shares": "200",
  "reserves_received": [
    {
      "asset": "",
      "amount": "0"
    },
    {
      "asset": "",
      "amount": "0"
    }
  ]
}

This provides the highest amount of information, I think I would go for this.

Fixed in #3880.


[Merge] MONDO:0012461	bulimia nervosa, susceptibility to, 2

Mondo term (ID and Label)
MONDO:0012461	bulimia nervosa, susceptibility to, 2
Reason for deprecation
OMIM merged these
Term to be merged with
MONDO:0005452	bulimia nervosa

The course of action here conflicts with #1705
also this would not be a merge. MONDO:0012461 is susceptibility caused by a particular gene. MONDO:0005452 is the actual condition


Integrate spot markets and add fuzzing

if spot markets are added in the Colosseo engineering milestone we need to integrate spot into the market sin and carry out fuzzing tests

closing as a duplcate of

https://github.com/vegaprotocol/vega-market-sim/issues/445


Passing certain arguments after "npm test -- " skips all tests

Prerequisites

[x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
[x] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[x] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[x] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description

Steps to Reproduce

Create a simple test file, called index.js

Set the contents to something simple like:
  it(`a`,()=>{});

set the npm scripts block like this:
"scripts": {
   "test": "mocha index.js"
},

run npm test from the command line and confirm you see
✔ a

1 passing (3ms)

run npm test -- -f a from the command line and confirm you see the same output

run npm test -- -f aa from the command line

Expected behavior: I expect to see the same output as before
Actual behavior: I actually see
  0 passing (1ms)

Reproduces how often: Every time
Versions

The output of mocha --version and node_modules/.bin/mocha --version:
mocha --version
mocha : The term 'mocha' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ mocha --version
+ ~~~~~
    + CategoryInfo          : ObjectNotFound: (mocha:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

node_modules/.bin/mocha --version
10.2.0

The output of node --version: v16.14.2

Your operating system

name and version: Windows 11
architecture (32 or 64-bit): 64 bit

Your shell (e.g., bash, zsh, PowerShell, cmd): PowerShell and cmd

Your browser and version (if running browser tests): No

Any third-party Mocha-related modules (and their versions): No

Any code transpiler (e.g., TypeScript, CoffeeScript, Babel) being used (and its version): No

Additional Information

@jamietwells this is parsing by npm, not by Mocha. Using quotes, double-quotes or backtick quotes could evtl. help, PowerShell is sometimes behaving differentely than other shells.
I'm going to close this issue unless you have a pure Mocha sample with node_modules/.bin/mocha. Please also cross check you expectations against Mocha's / npm's docs.

Ah yes, I see, -f is already used by mocha internally to filter tests, so I need to pick something that doesn't clash. Ok, this can be closed. I'll use -z to pass my file name, it seem to be unused.


Allow missing documentation on the autogenerated constructor

Otherwise it triggers the missing_docs warning on dependent projects, which may turn into hard faults depending on project configuration.

Ugh. The contents of rustdoc are not tokenized like the others inside a proc-macro (AFAICS), so #ident from patch1 is left as-is. I've removed #ident from the line altogether in v2. It's all fairly inconsequential, and adding #[allow(missing_docs)] would work equally fine.

Any idea why I don't get this warning on my projects? I know modular_bitfield had a similar problem, but why does it only happen sometimes?
I would go for the allow rule.

thanks, yeah that makes sense!


autoSelect

Prerequisites

[x] I have read the documentation;
[x] In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description
There is already autoFocus, so that when a field appears the cursor is in it.  autoSelect would also be very helpful, so that when the field appears all the text in it is already selected for deletion.
Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Ideally, I'm providing a sample JSFiddle or a shared playground link demonstrating the issue.
Expected behavior
Setting a schema of { 'ui:autoSelect': true } highlights all the text in an input field when it renders.
Actual behavior
Nothing.
Version
You can usually get this information in your package.json or in the file URL if you're using the unpkg one.

@Y-Less are you interested in making a PR for this?


Reverse Light Again...

https://github.com/user-grinch/ModelExtras/issues/26
Continuation of this issue, another second car bug...
Reverse light shadow and corona too bright when you got second car. On first, it fixed, thanks.

Fixed


How to use abapGit with GitLab 2FA/MFA?

Hello,
I would like to use abapGit with an On-Premises GitLab instance where 2FA/MFA is enabled. When I enter my username and password in the login dialog, I get an HTTP 401 error. Accessing the Git repos from abapGit via username + personal access token does work. Logging in to the GitLab instance via a browser does work too: It asks for the 2FA/MFA information after the login via username and password. Does this have to be implemented on your own?
https://docs.abapgit.org/guide-authentication.html#two-factor-authentication doesn't help me.
Best Regards,

abapGit works much like raw command line git, I expect also only personal access tokens to work for raw command line

Makes sense @larshp. The documentation is a bit unprecise then, right? If a token is the only supported way, it's not a MFA I think? I mean, you just need the token; no second credentials.

yea, just the token
yea, the documentation might be unprecise, github recently disabled the 2FA hack, plus it was deleted from abapgit, https://github.com/abapGit/abapGit/pull/4039

And then there was the attempt to use OAuth2 https://github.com/abapGit/abapGit/issues/3766
Unit SAP supports storing user-specific credentials for 3rd party apps, we can forget about getting this topic resolved.

@GiantCrocodile any suggestions for how to improve the documentation?

closing

closing


Add 1.1 callout to Manage Long-running Queries page

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4cf27fa82985a8242fd2b51b7c87e2d33779361a/


brew should overwrite existing python links

Summary:
Builds are failing on CI because brew bails out when it tries installing Python 3.1. The image already has an existing version of Python 3, which we should overwrite.
Changelog:
[General][Changed] - Brew overwrites system Python 3.
Differential Revision: D43391941

Conflict was resolved and merged.


Wiki: Wrong example in "runtimeExecutable" property

Hello Josh,
Just a minor documentation issue in https://github.com/BowlerHatLLC/vscode-nextgenas/wiki/launch.json-fields-for-SWF-debugging#runtimeexecutable.
The "runtimeExecutable" property section shows the "program" example.
Best,
Aurélien

Thanks!


No bluetooth support in HA core-2022.2.9

Bluetooth works in the host machine, but the HA snap has no access to the controller:
$ bluetoothctl show
Controller XX:XX:XX:XX:XX:XX (public)
$ sudo snap run --shell home-assistant-snap
$ bluetoothctl show
No default controller available
The problem seems to be the missing library pybluez in python 3.9.8 that ships with snap Home Assistant 2022.2.9.
Any suggestions are appreciated.

I managed to get it to work by reinstalling the bluez and manually binding HA to the stack.
sudo snap remove bluez
sudo snap install bluez
sudo snap connect home-assistant-snap:bluez
Everything works now.


Record Constructors in the "checked" Data have p-Prefixes breaking Compilation

For example net.minecraft.world.level.levelgen.structure.pieces.PiecesContainer.
public record PiecesContainer(List<StructurePiece> pieces) {
[...]
   public PiecesContainer(List<StructurePiece> pPieces) {
        this.pieces = List.copyOf(pPieces);
    }
}

The generator for the sanitized export needs to be fixed to avoid modifying the canonical constructor of a record class.


[SUPPORT] Flink MOR only creates log files

Describe the problem you faced
When using Flink with an MOR table only log files are created. This is different from Spark, which only uses log files when changes to a file group occur. Log files are not optimized for large payloads which results in a costly performance hit when flushing the data. The end result is a pipeline which quickly buffers data, blocks while converting the data, and then flushes. For base files, the heavy lifting is passed to the parquet writer which automatically addresses these complications by incrementally processing data at the row group level. In that situation, the expectation is a relatively flat CPU usage, since serialization and compression is occurring in parallel with reads.
Over-provisioning helps to a degree, but is limited to the size of the batch size. Reducing the batch size helps significantly but results in too many small files. Compaction can be used to help with this, but this adds a large cost in the I/O to S3 and compaction job.
To Reproduce
See the attached file, Demo.java, from @kzdravkov. This is a self-contained Flink example illustrating the behavior.
Expected behavior
See the attached file hudi_spark_mor.py. This is a self-contained PySpark example that shows the behavior that is expected. In short - whenever inserts occur it's expected that a base file will be created. It's additionally expected that the file bin packing logic will occur as appropriate.
Environment Description

Hudi version: 0.13.1
Spark version: 3.1.1
Flink version: 1.13.1
Hive version: N/A
Hadoop version:
Storage (HDFS/S3/GCS..): Local, but S3 in prod
Running on Docker? (yes/no): No.

Flink is running in k8s. Data is in S3. Catalog uses Glue. For the purposes of this issue, local is sufficient for demonstration.
Additional context
@kzdravkov initially started this discussion in slack here with @danny0405 and others. The thread has some additional details about our use case, but I'll include some important notes below:
The data volume is modest at 50-100k rps with 100 mb/s uncompressed data. We are trying to migrate an existing Flink job that is a basic parquet table to Hudi. The job is insert heavy, but does have upserts and as such needs to be set to upsert. Our data model requires a global index to ensure we don't have duplicates (record --> partition mapping can change). This has been mitigated by using a pseudo-global index by setting the FLINK_STATE index to address most of the duplicates. All of the table services are done independently via Spark (currently Glue jobs).
Given that this is blocking a rollout, we are planning to test our job with COW to see if it's good enough, and then migrate to MOR once this is addressed.
For anyone curious about the log file overhead, please see the above slack thread. I believe this is also an issue, but assuming log blocks are kept small then it's minor and likely not worth the effort. I'd like to exclude that from this issue, since it's a separate and secondary issue.

@yihua Do you have intreast to join this discussion to investigate for more efficient log append wrtiers ? Currently the log file encoding is not that efficient if ther user switchs to the parquet bytes log blocks.


spread operator for enum

Search Terms

Enum
Spread operator

Suggestion

I would like to use the spread operator to spread the values (or maybe the keys) of an enum.
Use Cases

I want to use this to check or print available types of enum type.
Examples

enum TestStatus{
    PENDING,
    ACCEPTED,
    WRONG_ANSWER
}
console.log(...TestStatus); // prints: "PENDING"  "ACCEPTED"  "WRONG_ANSEWR"

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

This can be done right now with Object.values:
enum TestStatus {
    PENDING,
    ACCEPTED,
    WRONG_ANSWER
}
console.log(...Object.values(TestStatus).filter(k => typeof k === 'string'));

Thank you, @nickbclifford. Unfortunately, That didn't work for me.

However, I'm following a similar approach.
export function enumToArray(enumObject: any): string[] {
  const keys = Object.keys(enumObject).filter(key => typeof enumObject[key as any] === "number");
  return keys;
}
enum TestStatus {
    PENDING,
    ACCEPTED,
    WRONG_ANSWER
}
console.log(...enumToArray(TestStatus));

But imagine, what if the spread operator is natively supported for enums! I think that would provide a better and more concise way to write code.

Thank you, @nickbclifford.
However, I'm following a similar approach.
export function enumToArray(enumObject: any): string[] {
  const keys = Object.keys(enumObject).filter(key => typeof enumObject[key as any] === "number");
  return keys;
}
enum TestStatus {
    PENDING,
    ACCEPTED,
    WRONG_ANSWER
}
console.log(...enumToArray(TestStatus));

But imagine, what if the spread operator is natively supported for enums! I think that would provide a better and more concise way to write code.

[x]  This wouldn't change the runtime behavior of existing JavaScript code

Right now console.log(...MyEnum) will fail because MyEnum has no @@iterator, so this would change that runtime behavior of existing code.

[x]  This could be implemented without emitting different JS based on the types of the expressions

I don't see how that's possible.  Because MyEnum is not an array, array-like, or iterable, console.log(...MyEnum) has to behave differently than console.log(...MyArray).
Assuming the shape of enum objects isn't changing (if it did, that would be a disastrous break), you'd need to have a type-directed transpile where console.log(...MyArray) outputs console.log(...MyArray) and console.log(...MyEnum) outputs console.log(...Object.values(MyEnum).filter(something)

Also,

[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)

How is this not a runtime feature? The checklist should actually be checked, nit just copied.

This is technically feasible by including Symbol.isConcatSpreadable and a Symbol.iterator in our downlevel enum emit, however I doubt we're looking to increase the featurefulness of our nonstandard features, so I don't think this'll go anywhere for awhile.

Any update on this matter?

This would be cool, if added anytime soon. As of now the suggestion of @nickbclifford does the job console.log(...Object.values(Enum)).


Codegen is run as part of the build process

There's no reason that regular users of the crate should have to run the codegen and translate botocore definitions into code, pass that through serde, and then compile it.  It's slow, unnecessary, and provides several points for failure to unnecessarily occur.
We should generate the code for all services once (a la the current --features all) as part of packaging the rusoto crate proper, and publish the generated code to crates.io to save crate users the compile time and bother.
Whether or not that generated code should get committed to git is a matter for debate.  I tend to say that generated code has no place in version control, but I could see arguments in this case.

@jimmycuadra @indiv0 can you please weigh in on this?
A distinction @adimarco made clear is the difference between checking generated code in vs packaging it into the crate is something I hadn't thought about before.  I'm all for having the published crate have the generated code included.  This can help ease of use for crate users and reduce some issues we get in this area ( #302 , #274 , #256 , #205 , #156 show this is a continual problem for our users).

All the issues Matthew linked are related to syntex breakage (except for one which is about the old Python codegen.) Have there been problems for anyone since the revamp of serde_codegen that removes syntex as a public dependency? I don't think what Anthony is suggesting is needed to avoid that pain anymore. However, I don't really see a downside to it either. There's nothing platform-dependent about generating the Rust code, so there's no reason it has to happen on the user's machine. As for checking in generated code, generally that feels wrong to me, but the only reason it'd actually matter is when developing Rusoto itself and making sure the generated code stays in sync. Depending on how this issue is implemented, I could easily see it being a win all around.

Jimmy is correct about those issues appearing to be related to syntex breakage (which is less of an issue now), so this is less of a "fix" for anything and more of a general "improvement". I also don't really see a downside to including the generated code in the package (since it's meant to be a more-or-less complete representation of the project anyways). Though I'm also against checking-in the generated code.

Keep in mind that the full generated code is 78 MB (last I checked, in https://github.com/rusoto/rusoto/pull/326#issuecomment-236384172). I don't think it is reasonable to check in 78 MB of code or publish a 78 MB crate to crates.io. The entire repo currently including all git history is less than a third of that.

Another downside to having the codegen expansion happening outside of the compilation process on the end user's machine is that because Rusoto is a library, it's kind of the equivalent of including Cargo.lock in the repo, which you're not supposed to do for a library. That is, the quality of the code generation would be locked to whatever version of Rust and whatever version of things like Serde we used to generate it rather than a possibly more up-to-date version the user had installed (or even an older version they have installed, if there were some other compatibility issue.)

Sounds like the pros don't outweigh the cons on this one.  Objections to closing this issue?

No objections from me.

None from me either.


Mac database startup issue

When I start up the dev database (and I believe the non-dev one as well) it takes quite a while to start up and all the while I see:
connect test error:  Connection terminated unexpectedly
connect test error:  This socket has been ended by the other party
connection error:  Connection terminated unexpectedly

seems to be working now