JSC_JS_MODULE_LOAD_WARNING - Unable to debug React dependency failure

Background
I have spent the last 24 hours trying to get the compiler to compile a script that requires React (a totally insane use case I'm sure).  I browsed no less than 6 threads featuring a fellow named Chad Killingsworth who absolutely insists that ES6/CommonJS modules can be depended on with a variety of magic spells:

include --process_common_js_modules
include --module_resolution NODE
include --js node_modules/react/**/*.js and --js node_modules/react-dom/... (because why would the compiler do this for you if you have --module_resolution NODE set when you can manually include all your dependencies by hand, even if they're defined in a syntactically repetitive way that Closure Compiler is, you know, built to recognize and automate?)

And so on.  Not only do these not help in this case, but I can't even get the compiler to import the standalone React script as a sanity check.
I've avoided the Node ecosystem for a while, it always came off as a messy framework with a lot of conflicting standards, and judging by Chad's frustrated comments surrounding Node's integration of CommonJS modules and so on, it seems like I was pretty right.  Not to go on too much of a diatribe here, but it seems like it's very hard to get things to just work once modules are thrown in the mix.
I empathize with the package maintainer's frustrations regarding conflicting module standards, but this is the most trusted and efficient JS compiler on the planet, and it should be able to handle this use case without issue. Dare I say it: We should be able to compile a script that depends on one of the most popular Javascript frameworks in existence. Even switching the project from ES6 import/export to CommonJS require did not help. I've used the NPM google-closure-compiler package, but I switched back to the JAR just to rule that out as a variable.
Issue
First, some sanity checks. react-test.js is literally just a copy of node_modules/react/cjs/react.production.min.js (copied to make sure this wasn't CC's node module resolution logic breaking). Node can load it without issue:
$ node -e 'console.log(require("./react_test.js"))'
{
  Children: {
    map: [Function: map],
    forEach: [Function: forEach],
    count: [Function: count],
    toArray: [Function: toArray],
    only: [Function: only]
  },
  Component: [Function: F],
  Fragment: Symbol(react.fragment),
  ...
  version: '16.13.1'
}

Our test file test.js, which depends on the React library:
const React = require('./react_test.js');

class Test {
    test() {
        return React.Component;
    }
}

module.exports = Test;

Try to compile:
$ java -jar ~/closure.jar \
--compilation_level ADVANCED \
--process_common_js_modules \
--module_resolution NODE \
--js test.js

test.js:3: ERROR - [JSC_JS_MODULE_LOAD_WARNING] Failed to load module "./react_test.js"
const React = require('./react_test.js');
              ^

1 error(s), 0 warning(s)

"Failed to load module." Not the most descriptive error. Any ideas how to proceed?  If the Node runtime can load the module and work with it, and CC cannot, I can't really buy the "it's a feature, not a bug, just use the right flags" line.
Ultimately, there just seems to be few excuses for this failure - this is a Node module, and there is no good reason why CC cannot just import it off-rip with require('react') or import React from 'react' if we include --module_resolution NODE, and especially no good reason why it won't load the standalone script (no package.json logic required!) via require('./react_test.js') without providing a meaningful error message.
It seems like this is a relatively common issue with the compiler, and I have tried all of the remedies in most of these posts. Using CC for vanillaJS is a beautiful, seamless experience that cannot be beaten. We should try to keep that same energy for modern JS as well, especially when it comes to the React library.

Additional debugging info.  React's standalone does include require('object-assign'), so I tried to compile that, very much expecting an error (i.e., CC couldn't compile object-assign, so it couldn't compile react, and sure the error is still bland and useless, but at least there's a diagnosis) - but to my surprise, it compiles without issue.
$ java -jar ~/closure.jar --compilation_level ADVANCED --process_common_js_modules --module_resolution NODE --js node_modules/object-assign/index.js

var f="function"==typeof Object.defineProperties?Object.defineProperty:function(a,d,c){a!=Array.prototype&&a!=Object.prototype&&(a[d]=c.value)},g="undefined"!=typeof window&&window===this?this:"undefined"!=typeof global&&null!=global?global:this;function h(a,d){if(d){var c=g;a=a.split(".");for(var b=0;b<a.length-1;b++){var e=a[b];e in c||(c[e]={});c=c[e]}a=a[a.length-1];b=c[a];d=d(b);d!=b&&null!=d&&f(c,a,{configurable:!0,writable:!0,value:d})}}
var k="function"==typeof Object.assign?Object.assign:function(a,d){for(var c=1;c<arguments.length;c++){var b=arguments[c];if(b)for(var e in b)Object.prototype.hasOwnProperty.call(b,e)&&(a[e]=b[e])}return a};h("Object.assign",function(a){return a||k});
(function(){try{if(!Object.assign)return!1;var a=new String("abc");a[5]="de";if("5"===Object.getOwnPropertyNames(a)[0])return!1;var d={};for(a=0;10>a;a++)d["_"+String.fromCharCode(a)]=a;if("0123456789"!==Object.getOwnPropertyNames(d).map(function(b){return d[b]}).join(""))return!1;var c={};"abcdefghijklmnopqrst".split("").forEach(function(b){c[b]=b});return"abcdefghijklmnopqrst"!==Object.keys(Object.assign({},c)).join("")?!1:!0}catch(b){return!1}})();

Regarding:

Try to compile:

$ java -jar ~/closure.jar \
--compilation_level ADVANCED \
--process_common_js_modules \
--module_resolution NODE \
--js test.js

test.js:3: ERROR - [JSC_JS_MODULE_LOAD_WARNING] Failed to load module "./react_test.js"
const React = require('./react_test.js');
              ^

1 error(s), 0 warning(s)

Does it work if you add --js ./react_test.js to the command.
I know it seems stupid, but the compiler really is designed on purpose to require that every single input file be listed on its command line. It never searches through directories for anything.
The module resolution and module root are about matching the paths inside those files to the paths that the compiler received on its command line.

@brad4d Thanks for replying - no, I definitely tried that, it actually gets hung up on a package dependency called object-assign, it's just a polyfill for Object.assign - its index.js exports in the form:
module.exports = shouldUseNative() ? Object.assign : function (target, source) {
	...
};

And I dug through the compiled code, and the CC'd code returns the value of (renamed) shouldUseNative(), with the function (target, source) {...} value being compiled, but not used. If you run CC on react.production.js with --debug flag you can get a better idea of what's going on.
My first step was trying to get object-assign.js to compile in a way that works. It does not seem like the compiler felt obligated to do much about the module.exports by default, completely ignoring it as unused code. I was able to quickly work around this with  module.exports = window['__NODE__OBJECT_ASSIGN'] = ..., which would not only flag the modules object as an export for CC but also leave the value stored somewhere usable.
Now the second issue. If we compile a script with module.exports, the compiled script needs to be able to be require'd as expected in Node, while also taking the form of (function(){ ... return exportVal; })() so that it can be assigned to a variable when run in the browser. Basically, require('./compiled.js') === (function(){ /* compiled.js embedded directly */ })() needs to hold, completely platform agnostic - this should really be the case for all output, but I'll settle.
Another issue comes up with Node not having window defined and the browser not having module defined, but it can be worked around.  It takes two layers of anonymous embedding (the first layer so we can return an exported value by assigning it to window, and the second layer so we can actually return that in a browser instance). It's ugly but it's progress:
(function () {
    if (typeof window == "undefined") window = {};
    if (typeof module == "undefined") module = {};

    module.exports = window['__NODE_MODULES__OBJECT_ASSIGN'] = (function() {
        var k="function"==typeof Object.defineProperties?Object.defineProperty:function(a,d,c){a!=Array.prototype&&a!=Object.prototype&&(a[d]=c.value)},l="undefined"!=typeof window&&window===this?this:"undefined"!=typeof global&&null!=global?global:this;function m(a,d){if(d){var c=l;a=a.split(".");for(var b=0;b<a.length-1;b++){var e=a[b];e in c||(c[e]={});c=c[e]}a=a[a.length-1];b=c[a];d=d(b);d!=b&&null!=d&&k(c,a,{configurable:!0,writable:!0,value:d})}}
        m("Object.getOwnPropertySymbols",function(a){return a?a:function(){return[]}});var n="function"==typeof Object.assign?Object.assign:function(a,d){for(var c=1;c<arguments.length;c++){var b=arguments[c];if(b)for(var e in b)Object.prototype.hasOwnProperty.call(b,e)&&(a[e]=b[e])}return a};m("Object.assign",function(a){return a||n});var p=Object.getOwnPropertySymbols,q=Object.prototype.hasOwnProperty,r=Object.prototype.propertyIsEnumerable;
        window.__NODE_MODULES__OBJECT_ASSIGN=function(){try{if(!Object.assign)return!1;var a=new String("abc");a[5]="de";if("5"===Object.getOwnPropertyNames(a)[0])return!1;var d={};for(a=0;10>a;a++)d["_"+String.fromCharCode(a)]=a;if("0123456789"!==Object.getOwnPropertyNames(d).map(function(b){return d[b]}).join(""))return!1;var c={};"abcdefghijklmnopqrst".split("").forEach(function(b){c[b]=b});return"abcdefghijklmnopqrst"!==Object.keys(Object.assign({},c)).join("")?!1:!0}catch(b){return!1}}()?Object.assign:
        function(a,d){if(null===a||void 0===a)throw new TypeError("Object.assign cannot be called with null or undefined");var c=Object(a);for(var b,e=1;e<arguments.length;e++){var f=Object(arguments[e]);for(var h in f)q.call(f,h)&&(c[h]=f[h]);if(p){b=p(f);for(var g=0;g<b.length;g++)r.call(f,b[g])&&(c[b[g]]=f[b[g]])}}return c};

        return window['__NODE_MODULES__OBJECT_ASSIGN'];
    })();

    return window['__NODE_MODULES__OBJECT_ASSIGN'];
})()

In node:
$ node -e "console.log(require('./compiled/object-assign.js'))"
[Function: assign]

Run in the browser:
console.log((function () {
    if (typeof window == "undefined") window = {};
    if (typeof module == "undefined") module = {};

    module.exports = window['__NODE_MODULES__OBJECT_ASSIGN'] = (function() {
        var k="function"==typeof Object.defineProperties?Object.defineProperty:function(a,d,c){a!=Array.prototype&&a!=Object.prototype&&(a[d]=c.value)},l="undefined"!=typeof window&&window===this?this:"undefined"!=typeof global&&null!=global?global:this;function m(a,d){if(d){var c=l;a=a.split(".");for(var b=0;b<a.length-1;b++){var e=a[b];e in c||(c[e]={});c=c[e]}a=a[a.length-1];b=c[a];d=d(b);d!=b&&null!=d&&k(c,a,{configurable:!0,writable:!0,value:d})}}
        m("Object.getOwnPropertySymbols",function(a){return a?a:function(){return[]}});var n="function"==typeof Object.assign?Object.assign:function(a,d){for(var c=1;c<arguments.length;c++){var b=arguments[c];if(b)for(var e in b)Object.prototype.hasOwnProperty.call(b,e)&&(a[e]=b[e])}return a};m("Object.assign",function(a){return a||n});var p=Object.getOwnPropertySymbols,q=Object.prototype.hasOwnProperty,r=Object.prototype.propertyIsEnumerable;
        window.__NODE_MODULES__OBJECT_ASSIGN=function(){try{if(!Object.assign)return!1;var a=new String("abc");a[5]="de";if("5"===Object.getOwnPropertyNames(a)[0])return!1;var d={};for(a=0;10>a;a++)d["_"+String.fromCharCode(a)]=a;if("0123456789"!==Object.getOwnPropertyNames(d).map(function(b){return d[b]}).join(""))return!1;var c={};"abcdefghijklmnopqrst".split("").forEach(function(b){c[b]=b});return"abcdefghijklmnopqrst"!==Object.keys(Object.assign({},c)).join("")?!1:!0}catch(b){return!1}}()?Object.assign:
        function(a,d){if(null===a||void 0===a)throw new TypeError("Object.assign cannot be called with null or undefined");var c=Object(a);for(var b,e=1;e<arguments.length;e++){var f=Object(arguments[e]);for(var h in f)q.call(f,h)&&(c[h]=f[h]);if(p){b=p(f);for(var g=0;g<b.length;g++)r.call(f,b[g])&&(c[b[g]]=f[b[g]])}}return c};

        return window['__NODE_MODULES__OBJECT_ASSIGN'];
    })();

    return window['__NODE_MODULES__OBJECT_ASSIGN'];
})());
> ƒ assign() { [native code] }

You can see that both produce the same output at runtime, while also working as a Node import/require.
Ultimately the issue seems to be that package maintainers have just straight up decided not to do anything about module export logic, which I feel is a little depressing. I can try to help out, but I am way out of my depth here. This should be a proof-of-concept for basic CommonJS module exports, however - I'm working to get React to compile with compiled/object-assign.js embedded in place of require statement.

@christiantjl
This would be a good question to send to the closure-compiler-discuss mailing list.
To investigate further here we would need a specific repro case with full js files, etc.
Probably others who use the compiler in this mode on the mailing list can help without that.


Missing addition in reduction cell

I think line 646 in nasnet.py is missing the addition of x2 and x5.

Yup. That was a great catch! I will be uploading the fix + weights in some time


isAuthenticated flag is false after refresh

After refreshing the Page the isAuthenticated flag is false but in the cookie its set to true

When you refresh the page your browser will execute a "silent authentication request" and receive a new id_token and access_token from Auth0. During that step, you'll have a second that isAuthenticated is false.
However, as soon as the new tokens are received (if the user still has a valid session with Auth0), you'll see that the flag updates to true.
Let me know if this helps.

But silent authentication request will fail, auth0 log says Login required, this only happens when login through social connections like google, not happens to password login sessions

Hi -
It's not updating to true for me.
False -> Login -> True.
Refresh -> False again even though cookie is set.
I can see the call goes out to auth0 which returns 200 but I'm not able to capture that in the update when getting const { isAuthenticated, isLoading, login, logout } = useAuth();

This seems broken on the actual example site too. Login to profile, refresh and you are logged out and need to log back in.

Any way to fix this? I'm running into this error

All of the concepts of this library have been moved to the official Auth0 SDK for React (https://github.com/auth0/auth0-react), so I'll be archiving this repository shortly.


Errors when submitting summarization system outputs with custom dataset

Task: Summarization

Test data: https://github.com/neulab/ExplainaBoard/tree/main/integration_tests/artifacts/summarization

Error Info:

I'm guessing this is from the production environment because I saw several error messages in CloudWatch. I think I have fixed this bug but that change hasn't been deployed yet. We can close the issue once we deploy that change.

oh, sure, and thanks for fixing this!

This error has been fixed and new error has been recorded here: https://github.com/neulab/explainaboard_web/issues/311


support TRC721

TRC721 token is NTF token run on TomoChain.
Refer to:

http://erc721.org/
https://etherscan.io/tokens-nft

#687


Player armour

Description

Gives player armour, reduces enemy damage by x%.
Linked:

[x] #158
[x] #159

This issue was closed because the project was archived


Update README.md

Testing CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 0feb6372534d14eed1c799ef2e7fdbc9c5aba86a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Design and implement additional commands

[x] #4 teller list balances current --interval=monthly --timeframe=year
[x] teller list transactions current
[ ] teller list direct-debits current
[ ] teller list standing-orders current

[ ] teller list payment-mechanisms current
[ ] teller send <amount> [<currency>] --from=<from> --to=<to>

[ ] teller search transactions current --query=<query>

Worth looking at keen-cli for some ideas, although we are not planning on making generalised analysis tools. Some other features we may need to wait for Teller to support.
Note: <from> and <to> might be able to contain URIs.

Closing this because it contains too many things that will probably be finished at wildly different times...


Error installing on Raspberry Pi

I get an error running npm install spi on my Raspberry Pi (model B) running Raspbian.
Error output in pastebin: http://pastebin.com/DuGqZyrv
Am I possibly missing some system dependencies?

From the errors, I'm guessing there is some work to be done to get it to work with 0.12.0.  I haven't been actively developing or using the module in a while, so I haven't kept up to date on the latest versions of node.  I'll take a look this weekend to see if I can figure it out with the latest node version.
From my brief investigation, it looks like ObjectWrap doesn't exist anymore, and that's leading to other errors.

I also have this issue. Is there a possibility of an update for 0.12?

I tried a couple of different versions of node.
v0.11.9 - has the same issue
v0.10.2 - works

I've started using pi-spi
He claims to have updated it for 0.12.0, but I haven't tested it yet.

Hi, I have the same issue, would be lovely to benefit from your module on recent node version ;)

I'm not going to rev to a new version of node/io until the split has been resolved/addressed.

IO.js is joining the Node foundation.  I'd like to use some libraries that depend on this one - can it be rev'd to 0.12.0?  Thanks!

I'm working on it.  There are a ton of breaking changes on the native side in the 0.12 release, so it's not going to be a super quick fix to get it building again.
I will need some help with testing it because I don't have any SPI devices right now, so I have no way of testing the actual functionality.

This compiles, though I do not have a SPI device to test it with right now.  If someone wants to give this a shot while I wait for the SPI oled screen I ordered to come in: https://github.com/RussTheAerialist/node-spi/commit/a01fead772fcf71e1130b519700ff3dea9d9130d#diff-25d902c24283ab8cfbac54dfa101ad31
It cleans up the native code a bit also.

Thanks @RussTheAerialist!  I'll pull this down tomorrow and give it a try against my Mcp3008 ADC too.

It compiles/installs correctly on my RasPi (woo!), but I only get 0 readings off of a trimpot connected to an Mcp3008.  That said, I'm kinda new to hardware, so I might have something done something wrong.

Can you post your code?  I might have an mcp3008 (need to check my parts collection), so I can see what's going on.  I've had other reports of all zeros before, but I thought that was fixed, though in cleaning up the code, I might have done something stupid.

I cloned and modified the package.json for the Mcp3008 library to point the "node-spi" dependency to the master branch of this repo, then ran this (almost verbatim from the example code):
'use strict';

var Mcp3008 = require('mcp3008.js'),
    adc = new Mcp3008(),
    channel = 0;

adc.read(channel, function (value) {
    console.log(value);
});

ah yeah, I'm not so familiar with the mcp3008 library.  I'm reading up on the mcp3008 (I found one in my parts box).  I'm not sure I'll get to troubleshooting today or not, but let me see if I can duplicate what you have setup, and I'll post when I have the troubleshooting done.

Amazing, thanks @RussTheAerialist!

Hey, I was able to get a test bed setup with the mcp3008, and I was able to get it to work.  However, I did make a small mistake where it was having everything be zero.  There are two clock pins on the raspberry pi.  One is for I2C which is labeled SCL, and the other for SPI which is labeled SCLK.
Can you verify which pin off of the raspberry pi you are connecting pin 13 on the mcp3008 to?  Using my logic analyzer, I was able to see data coming across and it was being read by node without a problem.

This was just with a floating analog pin since I don't seem to have any free trim-pots right now.

I should mention a couple of things:

I modified the mcp3008 library to take spi options
I passed in the following for options:

{
  mode: 0,
  chipSelect: 0, /* Low */
  maxSpeed: 15000 /* 15Khz to slow things down */
}

That worked!  Thanks a bunch - I'm happy to put in a PR to the Mcp3008.js library to pass SPI options unless you'd prefer to do it.
Thanks again @RussTheAerialist.

I'll go ahead and put one in.  Thanks for verifying that it worked for you too!

Can I just register my interest in case you do end up updating thing?
Just trying to get my MCP3008 working with node and keep getting errors nstalling with node gyp.

@NiallNiall - which version of node?  I haven't had time to work on the documentation, but I'm going to push the Node 0.12.x compatible version to npm tonight.

0.2.0 has been pushed to npm.  It's compatible with 0.12.x.

Oh great! Thanks a lot!
I'm away from my Pi till Monday, but I'll check it out then.
It was on Node 0.12.1 (I think...)
Although I did nvm to 10.0.2 and while the installation appeared to work, I got a different error saying the module didn't register correctly when trying to require it in a script.
Hopefully latest update will solve it.
Thanks a bunch for pushing it either way though.


torch._C._LinAlgError: linalg.cholesky: The factorization could not be completed because the input is not positive-definite (the leading minor of order 1 is not positive-definite).[BUG]

Describe the bug
使用autogptq量化Qwen2-7b模型时出错
Hardware details
A6000GPU
Software version
torch 2.0.1 CUDA 11.7
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Additional context
AutoGPTQ的Qwen2量化出错

Not enough calibration data


Add support for Xpra idletimes

The /metrics endpoint only reports the idletime for Xrdp sessions. It should also work for Xpra sessions.

Implemented with https://github.com/DSD-DBS/capella-dockerimages/pull/256


The ability to provide custom render instructions.

I think it'd be a great idea to be able to pass custom instructions through to the service.
An example:
If I wanted to have an avatar with his fist in the air whilst jumping (jump for joy), I could pass in some instructions that would say, how to render the leg (think of how Cinema4D and  3DS Max rigs work).

Yeah, I've been intending to add a feature like this, but that'd require adding render sorting. Visage currently has a hard-coded render order that only works for the default pose.

This would be an amazing feature and definately one I'd use.

:thinking:

As of dfedfa20, this is very possible, now that there's rotation anchor support and the secondary layers don't clobber eachother or the base layers. Going to look into designing a JSON format for defining limb/head positions and deploying it next time I work on Visage.

Epic work man, really appreciate this!


[docs]Revise the description of @router

Describe the PR
Revise the README.md to correct the description of @router

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   88.59%   88.59%
=======================================
  Files           5        5
  Lines        1008     1008
=======================================
  Hits          893      893
  Misses         72       72
  Partials       43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384975c...5d64a31. Read the comment docs.

@Fullstop000 Thanks your contributions. 💯


PT-1725 | Fix routing & showing of selected CMS page by fixing getRoutedInternalHref & getIsItemActive functions

Description :sparkles:
fix: fix routing of CMS pages by fixing getRoutedInternalHref function
refs PT-1725
fix: fix showing selected menu item by fixing getIsItemActive function
refs PT-1725
Issues :bug:
Closes :no_good_woman:
Related :handshake:
PT-1725
Testing :alembic:
Automated tests :gear:
Manual testing :construction_worker_man:
Screenshots :camera_flash:
Routing

Showing selected menu item

Additional notes :spiral_notepad:

kultus-admin-ui branch is deployed to platta: https://kultus-admin-ui-pr329.dev.hel.ninja :rocket::rocket::rocket:


Add WaitGroup to ensure consumer has sent all before removing itself

WHAT is this pull request doing?
I'm not sure we've run into this potential bug, but this is a solution to make sure the consumer has written all to socket before it's removing itself from a queue. The bug may trigger if it's the last consumer because then the queue will unmap its segments, but the consumer may still have references to a mapped segment that it tries to write to socket, resulting in a crash.
HOW can this pull request be tested?
Uhm... yolo? Should try to add specs for this.

Does this impact performance?

Does this impact performance?

Can't say it's noticeable. I guess benchmarks are in margin of error. This fix is what's needed for the "flush fiber" I've been playing around with, and that gives a 10-15% increased throughput.

Can't say it's noticeable. I guess benchmarks are in margin of error. This fix is what's needed for the "flush fiber" I've been playing around with, and that gives a 10-15% increased throughput.

Okay, nice! 👍


Document how to use a CredentialAccessBoundary/DownscopedToken

There is currently no documentation or example anywhere obvious that describes how you are supposed to use a CredentialAccessBoundary or DownscopedClient with Storage either in this library or in google-auth-library. It would be very helpful to have this information for issuing onetime tokens for accessing specific resources within a bucket.
This seems like a relatively common need for projects that deal with file uploads/downloads and so would be worth explicitly documenting since it's not remotely close to obvious.

Hi @apjoseph ,
Thank you for reporting this issue. There is still some development work ongoing for DownscopedClient. Part of that work will include documentation and samples. I will update this issue when the documentation becomes available.


config: move all cli flags to options.Config

Similar to what was done here, it would be nice to have all cli flags be backed by values in options.Config.

I'll work on this

@willfindlay When you mentioned cli flags, did you mean this? https://github.com/cilium/tetragon/blob/main/cmd/tetragon/flags.go
I read the file and it seems like all option.Config fields have been backed there?

I'll work on this

Are you still doing the work? I can help.


Update da.json

Please send your pull requests the develop branch.
Don't forget to add the change to CHANGELOG.md.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.
Thanks!

Does the pull request solve a related issue?
If so, can you reference the issue?
What does the pull request accomplish? Use a list if needed.
If it includes major visual changes please add screenshots.

Warnings

:warning:

Please include an updated CHANGELOG.md file.This way we can keep track of all the contributions.

  Generated by :no_entry_sign: dangerJS

I pulled the wrong changelog. Have added another pull on the development fork. Sorry it's my first commit

Please send a new PR. thanks.


Code coverage service: CI integration

@mxlei01 Would you take this on once #344 is complete?

I can change the travis.yml file, however, this will require to setup secrets in the coveralls repo, and the travis as well. I would need access to coveralls and travis, which is not possible.
I can show you where to get the coveralls repo ID, and you can set them on travis.

Excellent. Your guidance would be helpful.

You can see on the top right this is your coveralls repo token.

Then in travis you would need to add the key as an environmental variable.
When travis executes this command:
nosetests --exe -c ../.noserc --with-coverage --cover-inclusive --cover-tests --cover-package=. unit_tests && COVERALLS_REPO_TOKEN=<COVERALLS_REPO_TOKEN> TRAVIS_BRANCH=master BRANCH=master coveralls --rcfile=../.coveragerc
It will update the code coverage on the coveralls website, and also the badge on the repo.


Error: ...non-existent package 'aws_common'

As you can see ros-kinetic-aws-common is already installed, but I still get an error saying
[rospack] Error: package 'lex_node' depends on non-existent package 'aws_common'
and rosdep claims that it is not a system dependency.
Check the ROS_PACKAGE_PATH or try calling 'rosdep update'

What am I doing wrong. Any help is appreciated.

Hi @ThunderRoid,
Thanks for submitting this issue. I don't think you're doing anything wrong. I think this is caused by how we're building the aws_common package. Besides rospack not being able to find the package are you having any trouble running the node?
You didn't specify what steps you're taking to get and build your lex_pkg2, but I was able to reproduce your issue with the following steps
source /opt/ros/kinetic/local_setup.bash
rosdep update

mkdir -p ~/lex_ws/src && cd ~/lex_ws/src
git clone https://github.com/aws-robotics/lex-ros1.git
cd ~/lex_ws
rosdep install --from-paths src --ignore-src -r -y
colcon build
source install/local_setup.bash
rospack depends1 lex_node

This resulted in a similar error to yours:
[rospack] Error: package 'lex_node' depends on non-existent package 'lex_common' and rosdep claims that it is not a system dependency. Check the ROS_PACKAGE_PATH or try calling 'rosdep update'

However I was able to run the node with no problem. I've included more details below on what's causing this issue. We'll look into resolving the issue with rospack, but I don't think this should prevent the node from functioning.
More Details
The lex_node package depends on both lex_common and aws_common. What these two packages have in common is that they both use cmake as a build tool instead of catkin.
ROS packages installed from apt are installed into /opt/ros/kinetic/share and the packages are there:
$ ls /opt/ros/kinetic/share | grep -E '(aws)|(lex)_common'
aws_common
aws_ros1_common
lex_common

rospack is looking there for packages (can confirm with echo $ROS_PACKAGE_PATH), however it only identifies projects with a package.xml as ROS packages (see this question).
$ ls /opt/ros/kinetic/share/aws_common
cmake
$ ls /opt/ros/kinetic/share/lex_common
cmake
$ ls /opt/ros/kinetic/share/aws_ros1_common
cmake package.xml

For some reason our pure cmake builds are not including the package.xml which prevents rospack from recognizing them but doesn't seem to impact functionality.

Thank you so much for the reply. I got it working.

To add some more information: having the package.xml installed is not enough - CMake packages are simply not supported by the rospack and ros2 pkg tools and this seems like the intended behavior to me.
This is because the ROS-specific hooks that modify the environment to add the package path are not installed (see install/lex_node/share/lex_node/hook/ros_package_path.sh).
If you have to use those tools for CMake packages, you can of course directly edit ROS_PACKAGE_PATH:
~/rospk$ rospack depends1 lex_node
[rospack] Error: package 'lex_node' depends on non-existent package 'lex_common' and rosdep claims that it is not a system dependency. Check the ROS_PACKAGE_PATH or try calling 'rosdep update'

~/rospk$ export ROS_PACKAGE_PATH=${ROS_PACKAGE_PATH}:/home/avishaya/rospk-fix/install/aws_common/share:/home/avishaya/rospk-fix/install/lex_common/share

~/rospk$ rospack depends1 lex_node
roscpp
std_msgs
lex_common
lex_common_msgs
aws_common
aws_ros1_common


refactored dockerfiles to reduce image sizes

Update Ruby to 3.2.2;
Add redis and helper services to docker-compose;
Refactored dockerfile for client  - use node:18-alpine and multi stage build to reduce image size
Refactored dockerfile for api - use ruby:3.2.2-slim-bullseye and update dependencies to reduce image size

Time to build ~ 122s
Image sizes: client reduced from 1.27GB to 309MB. rails api reduced from 1.07GB to 678MB

This addresses issue #172

Significantly reduced time to stop containers: from ~10+ seconds for client to 0.4s


Updates fiat api to disable csrf protection, fixes small SPeL error i…

…n pipelines controller.
@duftler @skim1420 - this should fix your deleting pipeline/403 forbidden issues.

Verified that I can now delete pipelines without getting the 403's.


[Copy Change] Edit Welcome message on Eligibility Questionnaire

Edit Welcome message on Eligibility Questionnaire

Safiya just came through with the new wording. The 'Welcome' header should stay as is, and the content below should be "Welcome to Detroit Home Connect! We know that finding housing can be difficult. We are here to help. To find you a home that best fits your needs, let's answer four simple questions first. Some affordable housing only accepts people of certain ages or certain incomes, so we want to make sure you are applying to properties that work for your household."


TextBox makes BEEP sound when typing on Mac

TextBox makes sound like if it was an error each time some key is pressed.

New mac backend based on winit doesnt do this, will close when we switch over

@danwalmsley can this be closed now?

New macOS backend doesn't produce beep sounds. Thanks!


android app not useful in forced landscape mode

So since you already took the app apart any chance on making it landscape friendly? basically the app cuts off the entire bottom of itself when on a device that is forced landscape i.e. my android head unit in my car. would be awesome to keep one of these in my car but the app is useless in landscape mode. need to find a way to make the app scroll-able while in landscape.

Interesting idea. That will be tough given how the code is obfuscated. We
have, however figured out how the server works, so we could potentially
make an aftermarket app. Maybe once we unlock the sdr functionality, we can
look into the idea.
On Thu, May 31, 2018 at 10:52 PM ImDroided<EMAIL_ADDRESS>wrote:

So since you already took the app apart any chance on making it landscape
friendly? basically the app cuts off the entire bottom of itself when on a
device that is forced landscape i.e. my android head unit in my car. would
be awesome to keep one of these in my car but the app is useless in
landscape mode. need to find a way to make the app scroll-able while in
landscape.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nickdaria/TzumiMagicTV-RTLSDR/issues/2, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AO--veZH8obbPn540wKYBCpIScLpkWJSks5t4LpwgaJpZM4UWD7z
.

This should just be a flag set in the manifest file
On Fri, Jun 1, 2018, 1:37 AM Nick Daria<EMAIL_ADDRESS>wrote:

Interesting idea. That will be tough given how the code is obfuscated. We
have, however figured out how the server works, so we could potentially
make an aftermarket app. Maybe once we unlock the sdr functionality, we can
look into the idea.
On Thu, May 31, 2018 at 10:52 PM ImDroided<EMAIL_ADDRESS>wrote:

So since you already took the app apart any chance on making it landscape
friendly? basically the app cuts off the entire bottom of itself when on
a
device that is forced landscape i.e. my android head unit in my car.
would
be awesome to keep one of these in my car but the app is useless in
landscape mode. need to find a way to make the app scroll-able while in
landscape.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nickdaria/TzumiMagicTV-RTLSDR/issues/2, or mute the
thread
<
https://github.com/notifications/unsubscribe-auth/AO--veZH8obbPn540wKYBCpIScLpkWJSks5t4LpwgaJpZM4UWD7z
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nickdaria/TzumiMagicTV-RTLSDR/issues/2#issuecomment-393776909,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANVzaXT5v3uNvkc8OG3GQ2OAxebdRtx-ks5t4OEggaJpZM4UWD7z
.

Something like this might work
https://stackoverflow.com/questions/21056625/android-relativelayout-wont-scroll-when-in-landscape-mode
On Fri, Jun 1, 2018, 5:06 AM<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:

This should just be a flag set in the manifest file
On Fri, Jun 1, 2018, 1:37 AM Nick Daria<EMAIL_ADDRESS>wrote:

Interesting idea. That will be tough given how the code is obfuscated. We
have, however figured out how the server works, so we could potentially
make an aftermarket app. Maybe once we unlock the sdr functionality, we
can
look into the idea.
On Thu, May 31, 2018 at 10:52 PM ImDroided<EMAIL_ADDRESS>wrote:

So since you already took the app apart any chance on making it
landscape
friendly? basically the app cuts off the entire bottom of itself when
on a
device that is forced landscape i.e. my android head unit in my car.
would
be awesome to keep one of these in my car but the app is useless in
landscape mode. need to find a way to make the app scroll-able while in
landscape.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nickdaria/TzumiMagicTV-RTLSDR/issues/2, or mute
the
thread
<
https://github.com/notifications/unsubscribe-auth/AO--veZH8obbPn540wKYBCpIScLpkWJSks5t4LpwgaJpZM4UWD7z
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nickdaria/TzumiMagicTV-RTLSDR/issues/2#issuecomment-393776909,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANVzaXT5v3uNvkc8OG3GQ2OAxebdRtx-ks5t4OEggaJpZM4UWD7z
.

Also if you send me the Android project folder I could take a peek at it

The APK should be available in the repo. Use JARX to decompile it.


V2 Verification Error With Authorization Header

Hi there,
I am trying to verify requests through Dialogflow, but I keep getting the following error:
{
    "error": "A verification header key was not found"
}

For my Google Action, I am using v2 of the API, v2.0.1 of this sdk, and I am trying to run this function on Lambda.
When I log the conv.headers object, I can see the Authorization header coming through the request, but I still get the error above. I believe the issue is tied to this line here: https://github.com/actions-on-google/actions-on-google-nodejs/blob/master/src/service/dialogflow/dialogflow.ts#L340
The check is changing the header value I pass to lower case, however the actual header value that is stored in the conv.headers object is not, so it is not finding the match. If I remove the .toLowerCase(), then the request goes through fine.
Here is the code I am running:
'use strict';

const { dialogflow } = require('actions-on-google');

const app = dialogflow({
  verification: {
    Authorization: 'Basic QWxsb3k6YXBwbGU='
  }
});

app.intent('Default Fallback Intent', conv => {
  console.log(conv.headers);
  conv.ask('default fallback intent');
});

app.intent('Default Welcome Intent', conv => {
  console.log(conv.headers);
  conv.ask('hi there');
});

module.exports.handler = app;

Also, here is the action I setup in Dialogflow:
Test2.zip
Is there anything else I need to pass verification object to get this request to work?

Thanks for reporting this!
Yeah, it looks like a bug. The reason why it does .toLowerCase() is because HTTP header keys are case insensitive so it expects the headers map keys to already be .toLowerCase() in order to match correctly which happens in Firebase Functions' express interface.
The fix would need to be either in the lambda framework handler code to convert to lowercase or in the verification code to convert the keys there.
For now, you can write your own custom framework handler for lambda and use that:
'use strict';

const { dialogflow } = require('actions-on-google');

class CustomLambda {
  handle(standard) {
    return async (event, context, callback) => {
      const headers = {}
      for (const key in event.headers) {
        headers[key.toLowerCase()] = event.headers[key]
      }
      const result = await standard(JSON.parse(event.body), headers).catch(e => {
        error(e.stack || e)
        callback(e)
      })
      if (!result) {
        return
      }
      const { status, body } = result
      callback(null, {
        statusCode: status,
        body: JSON.stringify(body),
      })
    }
  }

  isContext(second) {
    return typeof second.succeed === 'function'
  }

  isCallback(third) {
    return typeof third === 'function'
  }

  check(first, second, third) {
    return this.isContext(second) && this.isCallback(third)
  }
}

const app = dialogflow({
  verification: {
    Authorization: 'Basic QWxsb3k6YXBwbGU='
  }
});

app.frameworks.lambda = new CustomLambda()

app.intent('Default Fallback Intent', conv => {
  console.log(conv.headers);
  conv.ask('default fallback intent');
});

app.intent('Default Welcome Intent', conv => {
  console.log(conv.headers);
  conv.ask('hi there');
});

module.exports.handler = app;

Let me know if this works or if you have any issues.

@Canain Thanks for the quick response, detailed explanation, and quick solution. I implemented the the custom framework handler, and it worked perfectly.
Thanks again!


nodejs10.x is no longer supported

hey TJ, hope you can advise. Else do I need to migrate to AWS SAM ? :sweat:
Prerequisites

[X] I am running the latest version. (up upgrade)
[X] I searched to see if the issue already exists.
[X] I inspected the verbose debug output with the -v, --verbose flag.
[X] Are you an Up Pro subscriber?

Description
The runtime parameter of nodejs10.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs14.x) while creating or updating functions.
https://s.natalian.org/2022-02-12/up.log
Steps to Reproduce

https://github.com/kaihendry/goserverless.sg
up

I am getting this same this morning.   Apex pro user
Error: deploying: us-west-1: updating function config: InvalidParameterValueException: The runtime parameter of nodejs10.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs14.x) while creating or updating functions.

Long term pro user
Up is completely broken. Deploys do not work.
I am trying to deploy some updates to several projects I have running on UP and nothing can be updated. In one simple one, I completely destroyed the app then tried to redeploy and I am getting this.

     Error: deploying: us-west-1: creating function: InvalidParameterValueException: The runtime parameter of nodejs10.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs14.x) while creating or updating functions.
{
  RespMetadata: {
    StatusCode: 400,
    RequestID: "c35adcec-d8a9-4000-91dc-d1642ac5788b"
  },
  Message_: "The runtime parameter of nodejs10.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs14.x) while creating or updating functions.",
  Type: "User"
}

Add
"lambda": {
  "runtime": "nodejs14.x"
},

to up.json in the root of the project.


[PRP-181] Set up testing for staff portal (redo)

Ticket
https://wicmtdp.atlassian.net/browse/PRP-181
Changes

What was added, updated, or removed in this PR.

Configure Playwright for staff portal
Create initial e2e test with screenshots
Configure eslint
Add npm scripts to update prisma, run lowdefy, run e2e

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

This PR configures the staff portal to be able to run Playwright for e2e tests. When you run npm run e2e, it will call playwright.config.ts's webServer command, which looks like this:
  webServer: {
    command:
      "npm run prisma:update && \
       docker compose up --build && \
       docker compose exec remix_dev npx prisma migrate reset --force",
    port: 3033,

This is configured to:

Copy the prisma schema and migrations from the participant folder into the staff folder (I tried symlinks but symlinks outside the docker context break docker builds)
Build and run the docker containers
Force a prisma reset
Tell Playwright to wait for port 3033 (the lowdefy_dev container) to be ready

Testing

Screenshots, GIF demos, code examples or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

Run npm run e2e

@microwavenby This PR replaces #29 which I broke so completely that there was no recovering it. Sorry to have you re-review, but it should be largely the same.

Oh I just realized I need to rework this for the e2e changes I made for the participant app.


Fixed errant capitalization of Ruby on code block

Updated codeblock markers to change "Ruby" to "ruby" so that the syntax highlighting functions properly.

Thank you!


Update the build image to include the Go 1.17.5 update

What this PR does / why we need it:
Update the build image to include the Go 1.17.5 update.
Does this PR introduce a user-facing change?:
NONE

/assign @kron4eg

/retest

/retest


Wechat group-society

Hello students!
We would like to invite you to help us create a new way of socializing on wechat where individuals and groups can easily find like-minded people/groups by subscribing to our group-society official account.
Detailed description:
We will build up a centralized platform using our powerful wechaty official account puppet  to allow individual users as well as wechat groups to subscribe to. With group users' permission, we will use our wechaty bot to collect chat messages, and analyze the topics of interest for each group via topic modeling tools. The top topics of each group will be used as its 'tag' so that individual users can search for and join the groups of interest. Besides, our wechaty bot can break the boundaries between groups of similar interests by sharing messages across groups.
Link to  #30  wishlist
Skills required/preferred
Programming skills in typescript and/or python
Experience with git version control
Basic understanding of common design patterns and good software engineering habits
(Preferred) Experience with Pytorch/Tensorflow, and basic understanding of machine learning
Possible mentors
@MachengShen @huan ?

Thank you @MachengShen for inviting me to be the likely mentor.
This project is very valuable and useful,  I'd like to join as a co-mentor with you!


License page

I assume we need a page like https://www.openstreetmap.org/copyright that explicitly states the legal status of the data in the database. Wasn't there something like this before? @jessbeutler

Yes, great catch. I am not sure that we have this documented like this yet, but I can set up a page on the pd website.

This is more important now that people are adding data. All we really need is to assign a public-domain-equivalent license, probably CC0.

@jessbeutler I'm happy to take this on if you prefer.

Feel free to jump ahead on this!


Speed up build process

Hot on the heels of #3658, some low-hanging fruit that came out of that discussion

Run travis under node 4.3.x (gives a decent improvement over 0.12.)
Move cloc to the end of the build since it's the least important.
Take advantage of multiple cores for combine/minification
Improved build output to not spew as much garbage but still produce relevant information.

Number 3 reduced makeZipFile times on my machine from 5:40 to 2:30, performance increase has transferred to travis as well (looks like it's down to 5-6 minutes).  Since travis reports 32 cores and trying to use them all results in travis killing the build (I think because of memory limitations), I put in a hardcoded limit of 8 for now.
My approach is a little hacky (I exec a separate npm script passing a base64 encoded string on the command line), but I couldn't determine a better way to handle it with gulp because there's no programmatic way to spawn a task (I think this is being fixed in gulp 4, so we'll revisit when that comes out).

:+1: from me.  Anyone else want to look at this?


GitLab CI shared-runner compatibility

e6426a1b7f26db19e9b5c0da6d0fc8121e288315 ("Add a aspell as a default entrypoint") seems to break usage on GitLab CI (shared-runners). All past tags have been overwritten so I can't confirm with certainty that this is the cause.
Could you be persuaded to provide an alternative image with the default entrypoint?
The story of what works in GitLab CI is long and confused, mostly covered in gitlab-org/gitlab-runner#2692, and well summarised in this particular comment (emphasis mine):

Solution with entrypoint: ["/bin/sh"] (either it's sh or bash) doesn't work at all.

Solution with entrypoint: ["/bin/sh", "-c"] (either  it's sh or bash) works and depends on shell available inside of the image. We can see that packer supports both, terraform and curl support sh.

For some reason none of the shells is working for kcov image. I don't know why this is happening, because kcov image has both shells available. From what I found /bin/sh is a symlink to /bin/dash and that's what raises the sh: 1: set: Illegal option -o pipefail error. But why sh is used when bash is available and should be detected first? I don't know.

Solution with entrypoint: [""] works for all images, but not with Docker 1.12.X.

This image exhibits the problem in case 3, making it unusable in GitLab's shared runners for now. Historically, the solution to this problem was to not override ENTRYPOINT. Naturally you have no interest in removing the custom entrypoint in the primary image, which works entirely as intended and far more ergonomically than without the custom entrypoint.
Whether it were a separate image or just a tag wouldn't matter to me. It seems like the non-overriding Dockerfile could be the work-around and the overriding one could inherit from the work-around to preserve current functionality.

Immediately after spending 2 hours researching this problem and writing the ticket, I happened across rumours of a functioning work-around that delegates to /usr/bin/env and modifies $PATH. I've managed to confirm the following working as intended:
.gitlab-ci.yml:
spellcheck en-US:
  stage: test
  image:
    name: starefossen/aspell:0.60
    entrypoint:
    - "/usr/bin/env"
    - "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
  script:
  - ./spellcheck list

where spellcheck is basically
#!/bin/bash

aspell \
    --encoding 'UTF-8' \
    --mode html \
    --personal './.aspell.en.pws' \
    --lang en-US < README.md

exit 1

with quite a bit more sophistication (I can link the actual implementation once I get a stable commit).
Image id sha256:1d2a35ff9aa9af497e3a424b99b75a156a7234c1dc2a8db8e8d612e8c6941edd.
Given that, and the expectation that eventually GitLab's shared runners will adequately support entrypoint overriding, this ticket probably is not worth pursuing.

It sounds like it would still be quite helpful for you to have a sans ENTRYPOINT version. I'd be happy to make one for you. Although I guess it's up to @Starefossen want's it tied to this repo

I am very sorry for breaking people’s CI pipelines. That was not my intention when merging the change. I think we should revert the entrypoint and make a separate tag with the entrypoint set.
I am away from my workstation, if anyone can propose a PR to revert the entrypoint I can approve it from here.


[v3] Add tags

This issue is part of the migration to v3. You can read full details about the various changes here.
In Exercism v3, tracks can be annotated with tags. This allows searching for tracks with a certain tag combination, making it easy for students to find an interesting track to join.
Tags are specified in the top-level "tags" field in the track's config.json file and are defined as an array of strings, as specified in the spec.
Goal
The "tags" field in the config.json file should be updated to contain the tags that are relevant to this track. The list of tags that can be used is listed in the spec.
Example
{
  "tags": [
    "runtime/jvm",
    "platform/windows",
    "platform/linux",
    "paradigm/declarative",
    "paradigm/functional",
    "paradigm/object_oriented"
  ]
}

Tracking
https://github.com/exercism/v3-launch/issues/1

Adds tags in https://github.com/exercism/haxe/pull/126/commits/0efd32cd70f8b5a7dc997c6a625f19db39d28198

Adds tags in https://github.com/exercism/haxe/pull/126/commits/0efd32cd70f8b5a7dc997c6a625f19db39d28198


Fix leaking http connections

We faced problems with leaking http connections. We receive hooks by http, all connections are keep-alived. After few hours of our testing we noticed that we`ve got ~400 opened connections despite of hardcoded limit to 20. Also we had same number of goroutines both on server & client sides.
Default http client runs standalone goroutine for every connection so code in Expired doesn`t close these connections it just set client to nil. And new created client opens and runs new goroutines for new connection.

Wow. This looks much cleaner. Thanks.

It works on my side. Big thanks!


Add Kotlin Snippets to PFI/Required SDKs, PFI/Onboarding,  Wallet/Required SDKs pages

Include Kotlin Snippets on PFI docs

What type of PR is this? (check all applicable)

[ ] ♻ Refactor
[ ] ✨ New Feature
[ ] 🐛 Bug Fix
[ x] 📝 Documentation Update
[ ] 👷 Example Application
[ ] 🧑💻 Code Snippet
[ ] 🎨 Design
[ ] 📖 Content
[ ] 🧪 Tests
[ ] 🔖 Release
[ ] 🚩 Other

Description
Update PFI docs pages for Required SDKs and Onboarding to have Kotlin code snippets
Related Tickets & Documents

Resolves #
Mobile & Desktop Screenshots/Recordings

Added code snippets?

[ ] 👍 yes
[ x] 🙅 no, because they aren't needed

Added tests?

[ ] 👍 yes
[x ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

No tests? Add a note

Added to documentation?

[ ] 📜 readme
[ ] 📜 contributing.md
[ x] 📓 general documentation
[ ] 🙅 no documentation needed

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1206190035927197
https://app.asana.com/0/0/1206190035927215

Outstanding tasks:

Add <LanguageSwitcher> to the top of the guides. Right now, they won't work with the <Tabs> you're using in these guides
Add JS tests for PFI Onboarding guide
Verify test assertion for PFI Onboarding guide (Kotlin blocked by #1197)

Please open tickets to track this work


Bug found while close the tab on telecine.

Expected behavior
In this application the tab should be closed while I starting video as it closes like in the other apps during video.
Actual behavior
We are not able to close this tab during video as it shows some unknown error occurred.
How to reproduce
Download the app.
Open the app.
Click on red video bar right corner below option.
Click on start now.
See in the right top there is an x and red colour video bar.
Then I click on  'x' close bar, unknown error occurred.

App: Telecine- version 1.6.2
Operating system: mi A1 8.0 "Oreo"

Recording Of The Bug
https://youtu.be/urFORUKj5QA
Posted on Utopian.io -  Rewarding Open Source Contributors

Dupe of #149.


How can I add custom content?

How can I add custom content?
For example use the slide out for any other content without the menu?
I've just replaced the old mobile menu with hc-offcanvas. However on the other page side we have a content sidebar which until now simply used the old off-canvas menu - but instead of the menu items, we simply displayed other contents.

@nickbe did you found a solution?

Since it didn't seem to work out of the box and there's not documentation for this we dropped it. Regretably.

@nickbe I think you can use any content, but it has to be wrapped in
 tag.
Example:

My custom content

As long as you will not use  tag in your custom content it will work great.

Yeah that's the probem. I need  tags - that's one issue and having to use it inside an  tag also gave us trouble.
We've tried that out before, but I guess being able to use any content would be something that has to be implemented in the core routines first.

Duplicate of https://github.com/somewebmedia/hc-offcanvas-nav/issues/29
Please continue discussion there. Thanks.

@nickbe support for custom content has been added in the latest version.


Wanted: Server-side rendering

Hi! I work on OpenCollective - we help other open source projects (including react-boilerplate get funding.
We'd like to rebuild our frontend using React-boilerplate. But, Server-side rendering is a must for us - mostly for search crawlers and faster performance.
We are willing to pay someone to implement SSR in react-boilerplate and help the community out in the process. Would anyone be interested? You can reply on this issue.
Needless to say that whatever you build has to meet @mxstbr's approval and be merged into react-boilerplate to be considered complete.
Update: removed my email address. Prefer to discuss this publicly.

(NB just so that it is known, SSR seems to mix very well with GraphQL. Relay, Apollo and Relate all seem to support it. E.g. the in-development Relax CMS created and uses Relate which has SSR, seems pretty neat. And I write this in brackets, because GraphQL clients are still on the experimental side 😉 see https://github.com/mxstbr/react-boilerplate/issues/1041 for more GraphQL discussion.)

FYI other threads about SSR: https://github.com/mxstbr/react-boilerplate/pull/625, https://github.com/mxstbr/react-boilerplate/issues/174. The PR looks stale but could give inspiration I guess. Maybe @datapimp could comment?

I've implemented SSR on some React projects and I plan to do that on my boilerplate (https://github.com/diegohaz/arc). I'll see if I can do that in react-boilerplate and I send a PR. :)

if it helps, I have a project (much simpler than this, but still fully tested) which add SSR.
It shows how to add SSR using Koa or Express:
https://github.com/peter-mouland/react-lego

Looks like react-starter-kit provides SSR.

It also looks like hjs-webpack provides SSR. And anyway looks like a nice way to simplify the webpack configuration, automatically comes with dev server, transpiling, HMR, minifying and publishing.

I guess Koa is the preferred server technology as it is more active? or are there others we should be looking into?

That's how Este does server-side rendering with React Router 4.
https://github.com/este/este/blob/70409fe62e8b4fce48ec4d84eda155017069482a/src/server/frontend/render.js
It's not only about a server-side rendering but also server-side data fetching.
I think this 20 sloc component solves is universally for any data source.
https://github.com/este/este/blob/70409fe62e8b4fce48ec4d84eda155017069482a/src/server/frontend/ServerFetchProvider.js

I'm self promoting here, but I just made a solution for this exact scenario, React checksums included: https://www.prerender.cloud/

After receiving a few responses over email, I realized it's probably better to discuss it publicly.
So, if you are interested in helping, please respond here with:

how you plan to add ssr, any implementation details, snags, etc. Would rather resolve those ahead of time, then block PR from getting merged.
if you wish to be compensated, how much you expect to receive?

Fyi, @miksago.
Note that we plan to pay whoever builds this through react-boilerplate open collective. As in, we'd donate to opencollective.com/react-boilerplate (or help get the funds from others if it's beyond our budget). And then you can invoice that collective directly.

FYI a very interesting article on whether SSR is actually needed for SEO (do make sure to read the comments below as well).
So although not having SSR might have some impact on your rankings, it's at least inaccurate to say that it just isn't indexed at all. There's the "Fetch as Google" tool to check how your site is actually indexed. You could maybe give it a try?
As for the performance aspect, I wonder how impactful SSR is compared to the other benefits already in RBP (e.g code splitting)? @mxstbr do you have production-grade websites based on RBP to share, so that people can see with their own eyes how fast the rendering already is?

@asood123 I might be wrong, but I'm not sure if there is a "best" way to do SSR for any given React+Redux app.
I've worked on some apps that use redux-saga to perform data tasks, and resolves using saga mechanisms. For other apps I've checked out a few libraries like redux-async-connect, and I've also wrote my own (react-transact -- excuse the lack of docs, but there are examples).
The main problems for SSR are:

Mapping matched route components to data tasks.
Guaranteeing that data tasks are complete before rendering HTML.
Serializing application state atom into JSON + embed them on page.
Deserializing application state atom from embedded JSON.

Luckily 3 and 4 are dead simple with Redux. However, I'd be hesitant to push for a single solution to do 1 and 2.
Not sure what @mxstbr thinks of this? I don't mind sharing some ideas, just don't know if any solution is generic enough to be part of the boilerplate.

@jaysoo Sorry for spamming here, but this is already solved in the here:
Universal data fetching component
https://github.com/este/este/blob/master/src/server/frontend/ServerFetchProvider.js
Waiting for the final render
https://github.com/este/este/blob/master/src/server/frontend/render.js#L123
Example
https://github.com/este/este/blob/master/src/common/lib/redux-firebase/firebase.js#L35
Simple, elegant, battle tested, universal.

@steida No worries about spamming. I still don't quite see how this addresses the issue universally though.
Counter example
When using redux-saga, you may have data tasks defined using generator functions.
// using redux-saga
import { call, put, take } from 'redux-saga/effects'

function* requestThing() {
  yield take('REQUEST_THING')
  const data = call(fetch, ...)
  yield put({ type: 'RESOLVED_THING', payload: data })
}

This means components will only dispatch request actions, and the return type is void. The only way to access the promise is to get the task object and await on the task.done promise. But I'm unsure how to get access to these task objects from within components.
Note: It is possible to run a root saga only for the SSR case that will await all data tasks to complete before resolve its promise object. Just need a convention for what this looks like.

You don't believe me it works? It works for server side rendering and React Native both.

@steida Not arguing it doesn't work for those cases. I've built several React apps with SSR myself, so I know the solution of provider+decorator+queue/manager works.  I'm just bringing up another case that I don't think would work (without modification).
Say I have a component like this:
class MyPosts extends Component {
  static contextTypes = { store: React.PropTypes.object }

  componentWillMount() {
    this.context.store.dispatch({
      type: 'posts/REQUEST_POSTS'
    })
  }

  render () { ... }
}

Where the posts/REQUEST_POSTS action is picked up by a saga, which fetches the requested data, and then dispatches posts/LOADED_POSTS.
function* watchForRequestPosts() {
    while (true) {
      yield take('posts/REQUESTED_POSTS')
      const posts = yield call(fetch, '/posts')
      yield put({ type: 'posts/LOADED_POSTS', payload: posts })
    }
}

In this case, the MyPosts component, nor any HOC on top of it, can have access to know when posts are resolved.
Of course, there are many ways to get this to work with SSR, and I've done it before, it's just a matter of.

Is it worth generalizing this for RBP.
If so, which solution should be taken?

Since RPB recommends redux-saga, it is probably worth the consideration for SSR.

Actually, didn't notice that RPB adds store.runSaga method to the enhanced redux store. This could be used to run a task and push the task.done promise for SSR case. The assumption here would be that no long-running saga is fetching data required for SSR.

@jaysoo @steida I've just implemented this on this project using redux-saga: https://github.com/diegohaz/arc/tree/universal-redux
Actions:
export const postList = {
  request: (limit, resolve, reject) => ({ type: POST_LIST_REQUEST, limit, resolve, reject }),
  success: (list) => ({ type: POST_LIST_SUCCESS, list }),
  failure: (error) => ({ type: POST_LIST_FAILURE, error })
}

Saga:
export function* listPosts (limit, resolve = fn, reject = fn) {
  try {
    const params = { _limit: limit }
    const { data } = yield call(api.get, '/posts', { params })
    resolve(data)
    yield put(postList.success(data))
  } catch (e) {
    reject(e)
    yield put(postList.failure(e))
  }
}

export function* watchPostListRequest () {
  while (true) {
    const { limit, resolve, reject } = yield take(POST_LIST_REQUEST)
    yield call(listPosts, limit, resolve, reject)
  }
}

export default function* () {
  yield fork(watchPostListRequest)
}

Container component:
class SamplePageContainer extends Component {
  static post ({ req, store }) {
    return Promise.all([
      this.get({ store }),
      store.dispatch(submit(config, req.body))
    ])
  }

  static get ({ store }) {
    return new Promise((resolve, reject) => {
      store.dispatch(postList.request(15, resolve, reject))
    })
  }

  render () {
    return <SamplePage />
  }
}

Server:
app.use((req, res, next) => {
  // ...
  match({ history, routes, location: req.url }, (error, redirectLocation, renderProps) => {
    // ...
    const fetchData = () => new Promise((resolve, reject) => {
      const method = req.method.toLowerCase()
      const { params, location, components } = renderProps
      let promises = []

      components.forEach((component) => {
        if (component) {
          while (component && !component[method]) {
            component = component.WrappedComponent
          }
          // try to call Component.method where method is the HTTP method name
          component &&
          component[method] &&
          promises.push(component[method]({ req, res, params, location, store }))
        }
      })

      Promise.all(promises).then(resolve).catch(reject)
    })
    // ...
    fetchData().then(() => {
      render(configureStore(store.getState(), memoryHistory))
    }).catch((err) => {
      console.log(err)
      res.status(500).end()
    })
  })
})

@diegohaz That's pretty elegant, thanks for sharing! I guess generally if a request action is dispatched, there should be a resolve and reject handler that can be invoked by the corresponding saga.

@jaysoo @diegohaz @steida. Am enjoying the discussion. Would one of you want to take on the task of adding support for SSR? :) Let us know how much you'd charge and we'll figure something out.

@asood123 I'll take a look at the RBP code today to see how long I can do this and give you an answer. 😊

Hi, @asood123, It will cost me about 3 working days. I will ask $750 for it.

FYI there's prep, a side-project of the Graphcool team, looks like an easy way to pre-render at build time (zero server/bundler configuration needed). See their example or their Learn Relay source code for usage. Don't know how much effort would be needed to integrate with more dynamic content and of course it would pre-render "old" data as it's at build time, but it might be an easy win especially for the more static parts and if deployments are frequent enough.

I'll let @diegohaz take a stab at it. I will be on vacation soon for 3 weeks, and I have other work queued up at the moment. Happy to provide any support in terms of advice, etc.
@sedubois That could be interesting approach for static sites. I'd also look at https://zeit.co/blog/next for inspiration.

@diegohaz that sounds pretty reasonable. When will you be able to start?

@asood123 I'll start a PR this monday. 😊

when ssr is merged into master.

Not to interrupt your negotiations, but is this feature even wanted by the maintainers? I thought it was a conscious decision not to put ssr in the master branch?

yes, we have been talking to @mxstbr. He'd like to get SSR support as well.

Some other references, though a bit dated:

https://github.com/mxstbr/react-boilerplate/issues/92#issuecomment-172036437
https://github.com/mxstbr/react-boilerplate/issues/174

:+1:

I'm working on that.

FYI: https://medium.com/open-collective/asking-for-a-new-feature-on-an-open-source-project-3305deba1356#.6ehgqgzhc

airbnb has a different approach: https://github.com/airbnb/hypernova
In short, it's a separate process that renders the webpage (performing data requests and everything) then sends the html string back.

There is also Paypal's react-engine.

@diegohaz any updates? Have one other sponsor who has graciously offered to financially contribute towards SSR's completion.

@asood123 Yeah, sorry. I'm still working on this, but having hard time with #783

@haz let me know how I can help with #783; we can do a group schedule a
time to chat about it in the open collective slack if you like
On Tue, Nov 8, 2016 at 7:43 PM Haz<EMAIL_ADDRESS>wrote:

@asood123 https://github.com/asood123 Yeah, sorry. I'm still working on
this, but having hard time with #783
https://github.com/mxstbr/react-boilerplate/issues/783
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mxstbr/react-boilerplate/issues/1103#issuecomment-259313999,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACn0PXyplByy3kVStCnc7Oh1MCybOmPks5q8SUpgaJpZM4KWUJn
.

@datapimp -- I don't think @haz is who you think he is ;).

@diegohaz @asood123 let me know how I can help with #783; we can schedule time to do a group chat about it in the open collective slack if you like

@datapimp I've just read your article and will try to figure this out. I'll ask you for help if I have any doubts, thanks. 😊

Great @diegohaz.
I believe in its current state, the DLL Bundle for this project gets compiled for libraryTarget: web.
In order to make SSR work, you will need to create the DLL Bundle for the libraryTarget: umd so that it can be required in both a browser environment and the node environment.  I'm available if you need any help.
JS

I still have not managed to find the time to solve the problems I encountered and probably will not have time for this anytime soon.
@tomazy contacted me and It seems he has a working solution. Just posting here to ensure that there is no problem if he (or another person) takes this in my place.

That's too bad to hear, @diegohaz. Thanks for the update though. No problem from our end if @tomazy picks it up.

I've created a new PR for this feature (#1236). There are still a few small things to be solved but in general it works. I'd appreciate if you guys could spend a minute on reviewing it to check if I don't make any design mistakes.

@asood123 @tomazy Watching this closely and am very excited about the potential. Does anyone know if @mxstbr plans on merged this into master, or will it be a separate SSR branch? My preference would be the former, to ensure it's maintained properly.

Last I talked to @mxstbr, this was going to merged into master...

I better understood the need for server-side rendering with this article: http://rauchg.com/2014/7-principles-of-rich-web-applications/#server-rendered-pages-are-not-optional

@asood123 Have you had a chance to look at #1236 ? I think it's pretty much done.

@tomazy I looked over the PR. Looks fine to me - though I'm not that experienced. Better to have someone like @datapimp or @diegohaz look at it. I'll ping a couple other people who might be able to review as well.
Excited to see this go live soon!

Any estimate on when this will get merged in? @mxstbr  We wanted to start using react-boilerplate, but SSR is a must have for us.  Thanks!

@WhatIfWeDigDeeper If you look at #1236 you can see there was activity a few hours ago.

Thanks for the update.

@mxstbr We wanted to start using react-boilerplate, but SSR is a must have for us. Thanks!

Please use the PR branch and let us know where it breaks so we can fix it before releasing it!
The one reason I haven't merged the PR yet is that I don't know if it works for everything. The only way to find that out is by having people use it! So please use the PR branch by @tomazy and let us know how it goes!

@mxstbr Its been a while since any activity here. Are you going to merge it?

is the SSR effort abandoned?

@hadifarnoud unfortunately there is currently no plan to land SSR support in react-boilerplate :( please see #1236 and #1776 for more information. specifically, please follow #1236 as there may be a maintained SSR fork that you can use... i am leaving this issue open for visibility until next release

if there is a working pull request, why not merge it since a lot of people seem to want this feature?

@diegohaz Thanks for sharing the example. I have implemented something similar to that in React Universal. I am using static fetchData to call the server with the function at first through redux-saga
While I have everything working properly as I want, There seems to be a re-fetching in case of using the fetchData function inside componentDidMount or  componentWillMount I can see that the server-side function is called successfully but for some reason yield put does not add the value to my store which is funny considering the rest is working
All up till the console.log is working with axios. Just yield put does not put the data inside store but when I call the same function inside ComponentDidMount again, the store works properly with the update.
Let me know if anything can be done about it to prevent re-fetching!
Here is my saga.js
import { call, put, takeEvery, all, select } from 'redux-saga/effects';
import axios from 'axios';
import jwt from 'jsonwebtoken';
import { port, host } from '../appConfig';

export const getHomeState = state => state.home;

export function* fetchData() {
  const homeState = yield select(getHomeState);
  console.log(JSON.stringify(homeState));
  try {
    const token = jwt.sign({ exp: Math.floor(Date.now() / 1000) + (60 * 60) }, 'whatever');
    let response = null;
    if (port) {
      const reqURL = `http://${host}:${port}/api/data`;
      response = yield call(axios.get, reqURL, { headers: { authorization: token, 'Content-Type': 'application/json' } });
    } else {
      const reqURL = '/api/data';
      response = yield call(axios.get, reqURL, { headers: { authorization: token, 'Content-Type': 'application/json' } });
    }
    console.log(response.data.msg);
    yield put({ type: 'FETCHED_JWT', data: response.data.msg });
  } catch (err) {
    console.log(err);
    console.log('saga API data did not work. Retry fetching it');
  }
}

export function* watchFetchData() {
  yield takeEvery('FETCH_DATA', fetchData);
}
export default function* rootSaga() {
  yield all([
    watchFetchData(),
  ]);
}

Thanks

Is there any interest in taking another shot at this? I recently implemented SSR in my own fork of react-boilerplate (writeup of what had to change here). If the maintainers are interested, I'm happy to send my changes upstream in a pull request, but I don't want to do that if there is a pre-existing plan for this that I'd be stomping on.

@smspillaz
I don't think there is any SSR plan unfortunately. there is a pull request here #1236
It was decided not to include SSR. we had the same issue as @asood123 and used this fork (had problems along the way but it works). It would be fantastic if @mxstbr helps the effort and allow that fork or any other implementation to merge. This is very important to many.
btw, I'm interested to learn what is the difference between your fork and @tomazy.

remembering back to the original conversation - i think the decision was to keep this project as a client-side only boilerplate.  The hope being that it would help focus future changes and keep it simpler.  You might come up against the same push-back that happened last time.
I think if your PR enables client-side only and a SSR option, then you're on to a winner, especially if the changes to either are minimal.

I agree heavily with @peter-mouland, couldn't have said it better. Having an SSR option in addition to client side only would be ideal.
Adding in my two cents: I feel that SSR should be a decision based on project scopes and doesn't belong in a boilerplate. SSR can take a big toll on performance if you don't have a well thought-out project scope for both front and back end, and those alone open up large cans of worms that wouldn't be fair to put on the shoulders of a boilerplate.
If anyone wants to restart the ball rolling with adding an SSR option, please feel free, as long as it is truly an option. See #2129 for a short list of what I'm currently working on, it may have a place in there as well.

@smspillaz
Thanks for putting in the effort. I will try and use your branch in my project. Will let you know if i run into anything.


bugfix/ajax

fix a dom error on certain webkit versions when accessing a readonly prop of the xhr object

That's correct. Will most likely revert to
for (key in obj)
if(obj.hasOwnProperty(key))
for upstream acceptance. This likely won't go upstream anyway though, because of the magic keywords.


[BUG]: Can't download episodes from Crunchyroll

Program version
4.6.0
Operating System
Windows
Type
CLI
Service
Funimation
Command used
One Piece, Episode 741. all subs and dubs
Show ID
[WARN] decryption not enabled!, [WARN] No full streams found!, [ERROR] Download error
Episode
S7E535
Console Output
[WARN] Private key missing

=== Multi Downloader NX GUI 4.6.0 ===

GUI server started on port 3000
[WS] Connection to public ws from '::1'
[WS] Connection from '::1'
[WS] Connection from '::1'
USER: novaeclipse2012<EMAIL_ADDRESS>Your Country: AU

USER: novaeclipse2012<EMAIL_ADDRESS>Your Country: AU
USER: novaeclipse2012<EMAIL_ADDRESS>USER: novaeclipse2012<EMAIL_ADDRESS>[DEBUG] Got search options: {"search":"one piece","search-type":"series"}
Found series:
  [Z:GRMG8ZQZR|SRZ.257631] One Piece (Seasons: 25, EPs: 1324) [SIMULCAST, SUB, DUB]
    - Subtitles: en, es-419, es-ES, pt-BR
    [S:GYVNM8476] One Piece: East Blue (1-61) (Season: 1) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:GY3VWX3MR] One Piece Special Edition (HD, Subtitled): East Blue (1-61) (Season: 1) [SUB]
      - Versions: ja
      - Subtitles: en, es-419, pt-BR
    [S:G6P8PQ7M6] One Piece: Alabasta (62-135) (Season: 2) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:GY19QP57R] One Piece Special Edition (HD, Subtitled): Alabasta (62-135) (Season: 2) [SUB]
      - Versions: ja
      - Subtitles: en, es-419, pt-BR
    [S:GRVNM78ZY] One Piece: Sky Island (136-206) (Season: 3) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:GYWEM933Y] One Piece Special Edition (HD, Subtitled): Sky Island (136-206) (Season: 3) [SUB]
      - Versions: ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:GY5VJ4KQY] One Piece: Water 7 (207-325) (Season: 4) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:GYE5M421R] One Piece: Thriller Bark (326-384) (Season: 5) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:G6X0MWV7Y] One Piece: Summit War (385-516) (Season: 6) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:GRP8PE35R] One Piece: Fishman Island (517-574) (Season: 7) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:G69PXQ7EY] One Piece "3D2Y" (Season: 12) [SUB]
      - Versions: ja
      - Subtitles: en, es-419, pt-BR
    [S:G63VWN2WY] One Piece: Punk Hazard (575-629) (Season: 8) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:GYGGVE07Y] One Piece: Dressrosa (630-699) (Season: 9) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:GYJQKXG46] One Piece - Episode of Sabo (Season: 15) [SUB]
      - Versions: ja
      - Subtitles: en, es-419, pt-BR
    [S:GYMG8J7WY] One Piece - Adventure of Nebulandia (Season: 18) [SUB]
      - Versions: ja
      - Subtitles: en, es-419, pt-BR
    [S:GR5V1MVKR] One Piece: Dressrosa (700-746) (Season: 9) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:G6WE8NE26] One Piece: Silver Mine (747-750) (Season: 10) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:G63VWQWEY] One Piece - Heart of Gold (Season: 22) [SUB]
      - Versions: ja
      - Subtitles: en, es-419, pt-BR
    [S:G6GGZMGP6] One Piece: Zou (751-782) (Season: 10) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:GYG5EPK5Y] One Piece: Whole Cake Island (783-878) (Season: 11) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, pt-BR
    [S:GY75N3546] One Piece - Episode of East Blue (Season: 28) [SUB]
      - Versions: ja
      - Subtitles: en, es-419, pt-BR
    [S:G6NVVEP9Y] One Piece - Episode of Skypiea (Season: 30) [SUB]
      - Versions: ja
      - Subtitles: en, es-419, pt-BR
    [S:GR0X5QW7Y] One Piece: Reverie (879-891) (Season: 12) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en, es-419, pt-BR
    [S:GY8VCPXXM] One Piece: WANO KUNI (892-1088) (Season: 13) [DUB, SUB]
      - Versions: en, ja
      - Subtitles: en, es-419, es-ES, pt-BR
    [S:GYP8PM4KY] One Piece: Egghead Island (1089-Current) (Season: 14) [SIMULCAST, SUB]
      - Versions: ja
      - Subtitles: en, es-419, es-ES, pt-BR
      - Availability notes: Now available exclusively for Premium Members: One Piece Special Edition (HD).

The DBZ special is not available at this time. Toriko x One Piece episodes are available at: http://www.crunchyroll.com/toriko

Please note that HD and device support for One Piece will be available within a few hours after each simulcast release due to the production process. Thanks for your patience and enjoy the show!

  [Z:G5PHNMWX9|SRZ.283088] One Piece (Movies) (Seasons: 3, EPs: 3) [SUB, DUB]
    - Subtitles: en
    [S:GR49C7J15] One Piece Film: Gold (Season: 131) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en
    [S:G6WEC3WJW] One Piece: Stampede (Season: 141) [SUB, DUB]
      - Versions: en, ja
      - Subtitles: en
    [S:GY09CX1K7] One Piece Film: Red (English Dub) (Season: 151) [DUB, SUB]
      - Versions: en, ja
      - Subtitles: en

  [Z:G4PH0WEGW|SRZ.283298] Stand My Heroes: Piece of Truth (Seasons: 2, EPs: 13) [SUB, DUB]
    - Subtitles: en, es-419, es-ES, pt-BR, fr, de, it, ru, hi
    [S:GY19CPW4D] Stand My Heroes: Piece of Truth (Season: 1) [SUB, DUB]
      - Versions: en, es-419, pt-BR, ja
      - Subtitles: en, es-419, pt-BR, fr, de, hi
    [S:GYWEC3WNE] Stand My Heroes: Warmth of Memories (Season: 4) [SUB]
      - Versions: ja
      - Subtitles: en, es-419, es-ES, pt-BR, fr, de, it, ru

  [Z:GY8DP4JDY|SRZ.278619] ORESUKI Are you the only one who loves me? (Seasons: 1, EPs: 14) [SUB]
    - Subtitles: en, es-419, pt-BR
    [S:GRZJVEQ46] ORESUKI Are you the only one who loves me? (Season: 1) [SUB]
      - Versions: ja
      - Subtitles: en, es-419, pt-BR

  [Z:G5PHNM717|SRZ.283549] My One-Hit Kill Sister (Seasons: 1, EPs: 12) [SUB, DUB]
    - Subtitles: en, es-419, es-ES, pt-BR, fr, de, ar, it, ru, hi
    [S:G609CX5K8] My One-Hit Kill Sister (Season: 1) [SUB, DUB]
      - Versions: es-419, pt-BR, de, hi, ja
      - Subtitles: en, es-419, es-ES, pt-BR, fr, de, ar, it, ru, hi

  Total results: 797 (Page: 1/160)
USER: novaeclipse2012<EMAIL_ADDRESS>[DEBUG] Got resolve options: {"id":"GRMG8ZQZR","q":0,"e":"741","dubLang":["eng","spa","spa-419","spa-ES","por","fra","deu","ara-ME","ara","ita","rus","tur","hin","zho","chi","kor","cat","pol","tha","tam","may","vie","ind","tel","jpn"],"dlsubs":["all"],"fileName":"[${service}] ${showTitle} - S${season}E${episode} [${height}p]","dlVideoOnce":false,"all":false,"but":false,"noaudio":false,"novids":false,"simul":false

[S7E535] - Hordy's Onslaught! the Retaliatory Plan Set Into Motion! [✓ Japanese, ✓ English]
Requesting: [G6K5KQW8Y] One Piece: Fishman Island (517-574) - 535 - Hordy's Onslaught! the Retaliatory Plan Set Into Motion!
Chapter request successful
[WARN] Decryption not enabled!
[WARN] No full streams found!
[ERROR] Download error: Unable to download episode 741 from GRMG8ZQZR

Additional Information
I've looked at the issues forum, and had seen that mp4decryption might not have been installed properly, so I looked at a few tutorials, and I'm positive that it's installed properly, if you could help me out I out be really grateful, this downloader is great and have been using it for a while now, and still want to continue using it, also great job this is a great project :) P.S I had to remove a lot from the console output section, only the episode list for the title (there's a lot for one piece) and it exceeded the word limit

You need to place a CDM in your widevine folder

Sorry for asking but what's a CDM? and how would I place one?

I can't really go in depth but Google "L3 CDM dump" and you should find more info

search on videohelp forum to find your answer

Latest release adds a new Non-DRM stream. No telling how long it will last, but it is there for now

Going to close this since version >4.6.1 adds a newly discovered non-drm stream.
Side note: I appreciate you sticking around with the tool through all these difficulties :)


Overlapping pins look weird

When two markers overlap, the background shapes of the pins overlap and then the labels overlap separately on top of the background shape.  So, it looks a bit weird.  Any ideas how I could get around this?

You can see how the bus icon and the flag icon are overlapping.

I have the same issue. Did you figure out anything to get it to look cleaner?

No, I just let it be.
On Thu, Jul 2, 2015, 1:20 PM Jacob Holland<EMAIL_ADDRESS>wrote:

I have the same issue. Did you figure out anything to get it to look
cleaner?
—
Reply to this email directly or view it on GitHub
https://github.com/scottdejonge/Map-Icons/issues/22#issuecomment-118154702
.

I am having this issue, too. From the inspector, I can see that the pins are in a layer that is z-index: 1, and the labels are separate layer that is z-index: 4. I don't think these can be resolved since they are in completely different and overlapping containers. I like this icon set but unless the z-index issue can be fixed, I can't use it for my application.

+1

Any work around for this yet?  Everything works brilliantly except for this issue.  Have a map with a high density of markers and when zoomed out it looks terrible.

+!

Same issue here.. this is quite a deal breaker for an otherwise pretty cool library

any update for this issue?

https://github.com/scottdejonge/map-icons/issues/60

+1


Implement Gossip Ping/Pong Messages

I recently studied the gossip protocol codebase and have worked on ping/pong for a gossip-like protocol. I want to pick this up and know more about implementing this for Velos!


Need to add pgp to the Freedom interface definition

Currently, grunt build in uproxy-networking gives

/usr/local/google/home/bemasc/uproxy-networking/build/samples/copypaste-socks-chromeapp/freedom-module.ts(22,32): error TS2339: Property 'pgp' does not exist on type 'Freedom'.

This is a "non-emit-preventing type warning" but it's still worth fixing, by adding pgp to the interface, probably in uproxy-lib's freedom typings.

This will likely be resolved by the pull request from @iislucas, specifically: https://github.com/uProxy/uproxy-lib/pull/114/files#diff-91a31963653009892ad97046071a2c2eR134

Done here: https://github.com/uProxy/uproxy-lib/blob/dev/third_party/freedom-typings/pgp.d.ts


chore(release): v1.1.2 🎉

:robot: I have created a release *beep* *boop*
1.1.2 (2022-10-10)
Bug Fixes

errors: ensure error instantiation doesn't fail due to bigint stringification (0f72f90)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ehmpathy/google-ads-api-client/releases/tag/v1.1.2 :sunflower:


[#28] Move tests to separate directories

Codecov Report

Merging #34 (87b38b5) into master (84b2f48) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   97.77%   97.77%
=======================================
  Files          15       15
  Lines         135      135
  Branches       17       17
=======================================
  Hits          132      132
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b2f48...87b38b5. Read the comment docs.


Add !important to .select2-hidden-accessible.

.select2-hidden-accessible is the CSS class that is added to the original <select> element (that Select2 is initialized on) to hide it.
In cases where the original <select> has other style declarations assigned which conflict with those of .select2-hidden-accessible, the latter styles may be overridden, possibly resulting in the original <select> element not being properly hidden.
Similar to what https://github.com/select2/select2/pull/1549 did for Select2 v3's CSS, this adds the !important rule to all style declarations for .select2-hidden-accessible to make it exponentially harder to override them.

Thanks!


Make Manager SyncPeriod configurable via a flag

/kind feature
Describe the solution you'd like
It should be possible to configure the SyncPeriod (how often watched resources are re-queued to be reconciled) that’s used to configure the Manager (see CAPA for example).
This would be something that should be exposed as a flag (--sync-period?) with a reasonable default, perhaps maintaining the default of 10 hours.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

/priority longterm-important
/milestone Next


cannot use python3.6 in buildInputs

you can test on simple
mkShell {
    buildInputs = [ nixpkgs-python.packages.x86_64-linux."3.6" ];
};

then with nix develop - python will not start.
looks like the problem has something to do with this change since 3.8

What error do you get?

sorry that i haven't posted the error message - thought it's easier to reproduce and see, but here it is:
Failed to import the site module
Traceback (most recent call last):
  File "/nix/store/3ydi8l8whzrvfbmr29aiyiahb9d2kqgs-python3-3.6.15/lib/python3.6/site.py", line 553, in <module>
    main()
  File "/nix/store/3ydi8l8whzrvfbmr29aiyiahb9d2kqgs-python3-3.6.15/lib/python3.6/site.py", line 539, in main
    known_paths = addusersitepackages(known_paths)
  File "/nix/store/3ydi8l8whzrvfbmr29aiyiahb9d2kqgs-python3-3.6.15/lib/python3.6/site.py", line 282, in addusersitepackages
    user_site = getusersitepackages()
  File "/nix/store/3ydi8l8whzrvfbmr29aiyiahb9d2kqgs-python3-3.6.15/lib/python3.6/site.py", line 258, in getusersitepackages
    user_base = getuserbase() # this will also set USER_BASE
  File "/nix/store/3ydi8l8whzrvfbmr29aiyiahb9d2kqgs-python3-3.6.15/lib/python3.6/site.py", line 248, in getuserbase
    USER_BASE = get_config_var('userbase')
  File "/nix/store/3ydi8l8whzrvfbmr29aiyiahb9d2kqgs-python3-3.6.15/lib/python3.6/sysconfig.py", line 601, in get_config_var
    return get_config_vars().get(name)
  File "/nix/store/3ydi8l8whzrvfbmr29aiyiahb9d2kqgs-python3-3.6.15/lib/python3.6/sysconfig.py", line 550, in get_config_vars
    _init_posix(_CONFIG_VARS)
  File "/nix/store/3ydi8l8whzrvfbmr29aiyiahb9d2kqgs-python3-3.6.15/lib/python3.6/sysconfig.py", line 421, in _init_posix
    _temp = __import__(name, globals(), locals(), ['build_time_vars'], 0)
ModuleNotFoundError: No module named '_sysconfigdata__linux_x86_64-linux-gnu'

as you see, there is m missing in '_sysconfigdata__linux_x86_64-linux-gnu'
and that has something to do with this i bet

Someone should try to apply https://github.com/pypa/distutils/pull/111/files and see if it fixes it.


Freeing the UiDrawPath

Unlike most other drawing related classes, UiDrawPath has an explicit freePath() method, and the path handle is not freed automatically in the destructor.  Is this intentional?

Is this intentional?

I don't remember that it was. The other area classes were changed in this commit: https://github.com/parro-it/libui-node/pull/80/commits/3f993178c26a2915ffa7df32ec4cc6caa03bc371

I also don't remember it to be intentionally done...

@parro-it I commited the change to https://github.com/parro-it/libui-node/commits/path-destructor.
Should we keep the function as a noop for compatibility? It's missing in libui-napi.

I remember we already discuss the matter on libui-napi repo, and we decided to remove them...
so I suppose we can remove them here too.


Integrate bundle-analyzer

This PR integrates with https://www.bundle-analyzer.com/ to check that file sizes are within the specified limit. I put 200kb as a max size for JS bundle, and 100kb for CSS. We can adjust them later, but for now they look like a good starting point.

@koss-lebedev could you also pretty please change the base of PR into v3? 🙏

@dannytce Good question 🙂To be honest, I didn't consider other options because bundle-analyzer was referenced directly in the issue, but if you don't mind, I would like to take a look at other options

@koss-lebedev yeah originally I wasn't planning to do that. But even with pretty straightforward Lighthouse #114 I realized there are numerous implementations of the same thing. So I thought it might be worth to try them and document them :)


Conflicted file is not marked as modified

Prerequisites

[x] Can you reproduce the problem in safe mode?
[x] Are you running the latest version of Atom?
[x] Did you check the debugging guide?
[x] Did you check the FAQs on Discuss?
[ ] Are you reporting to the correct repository?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

Description
Files that have conflicts in them after a failed merge are not detected as modified in the Tree View or Status Bar, but Git Diff shows the changes correctly.
Steps to Reproduce

Find a branch that has conflicts with another branch
Attempt to merge the two
Open a file that has conflicts
Observe that the Tree View does not color the file as modified, and the Status Bar also reports no changes

Expected behavior: Tree View and Status Bar to detect changes
Actual behavior: No changes are detected other than Git Diff
Versions
You can get this information from executing atom --version and apm --version at the command line.
Atom    : 1.7.0-dev-8472f91
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1

/cc @joshaber here's another one for you!

I think #10757 is related to this / the same, i've also posted this issue comment describing the same behaviour when doing a multi-edit using find-and-replace.

@arcticicestudio It may be related but is not the same.  This scenario does not require other windows open, nor does it refresh upon switching focus.

Ah good catch. It looks like 1.5.4 behaves the same way.

Not stale.


Ability to visit the project links

I can help you to create feature where visitors can select the project.
This is for hacktoberfest 2023.
Also we can change the font theme to something terminal based font.

Hi @Y1a2s3h4,
Please proceed to work on the following feature under the current issue-

Create a feature where visitors can select the project & see/visit the link of the project

Feel free to create another issue if you wish to work on the following-

Also we can change the font theme to something terminal-based font.

I will label both PRs hacktober-accepted once they are ready to be merged.
I appreciate your interest in open source.
Regards
THT

Yes, Thank You.
I'll Just create another issue for font theme.

You can use dummy links.


fix: Change Eldritch Blast damage to match Magic Missile

What does this do?
Changes Eldritch Blast's damage to match the format of Magic Missile. I.e. Magic Missile lists damage rolls as per missile, even though you may cast multiple missiles. Eldritch Blast can also focus multiple targets or one like Magic Missile can, and the amount of blasts scale like Magic Missile does, so its damage should follow the same format. So, Eldritch Blast damage rolls are now per beam.
I'm not sure if there are more spells that operate similarly. Either way, I think they should all follow the same format.
I'd also like to informally suggest a new field for spells like this that defines how many times a spell is used per cast. So, for example, Eldritch Blast would have a field defining 1 beam at level 1, 2 beams at level 5, etc. I'm not sure if that's realistic, how many spells that impacts, or if it would be useful. I can open an actual issue for tracking that if it actually sounds useful to people.
How was it tested?
Built locally.
Is there a Github issue this is resolving?
No.
Did you update the docs in the API? Please link an associated PR if applicable.
N/A
Here's a fun image for your troubles

I opened issues for the new field suggested
Database issue: https://github.com/5e-bits/5e-database/issues/541
API issue: https://github.com/5e-bits/5e-srd-api/issues/361