[TRIVIAL] Add keys field option

This PR contains docs updates which were accidentally pushed to develop last time. The not-yet-reviewed changes are in this commit: https://github.com/pilosa/python-pilosa/commit/52530978106c4982cddaa5a77b36d70dbcb4602d

Coverage remained the same at 100.0% when pulling<PHONE_NUMBER>6c4982cddaa5a77b36d70dbcb4602d on yuce:add-keys-field-option into 1e2f73a20d5b2b54e0650ca45db4fb78385adcea on pilosa:master.


chore: update Python requirements

SUMMARY
Update Python dependencies to pick up bug fixes in newer package versions
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Run CI
Manual testing of core flows

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Might be good to get a bot to do this https://dependabot.com/, it can get overwhelming but it's nice to get one PR per lib, make it easy to see which upgrade is breaking CI.
Unclear if Apache Infra is cool with dependabot, but it's easy to ask.

@mistercrunch agreed. We do something similar at Airbnb for all our Python dependencies via a cron. We also update the pre-commit hooks.
Note not all Python packages adhere to the <major>.<minor>.<patch> versioning (there's actually been a deliberate move away from this for a number of packages) but as long as we bound versions I think semi-frequent (every week, fortnight, or month) updates should be fairly safe.

I opened a ticket with Apache INFRA to turn on dependabot here. Once that is set we'll be able to add a config file to the repo to specify how we want it to work.
https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/

Closing in favor of the coming Dependabot config


exercise 3 test case 5

Hello, can anyone give me a general run down as to how to solve level 5 of exercise 3? it seems my recycled loaders sequence is always wrong, and i cant figure out the issue from just reading the expected vs actual outputs. Here are some screenshots. Any help is deeply appreciated.

Thank you.

Something must be wrong with allocation of the loaders, look at your level3 and level5 .jsh files and debug.


Add Results for LightGBM Model of Higgs Dataset (10,500 Trees)

Hi Venkatesh. Can you also update model-inference/decisionTree/experiments/readme.md with your lightgbm updates?

Hi Venkatesh. Can you also update model-inference/decisionTree/experiments/readme.md with your lightgbm updates?

Hey, Hong. Sure, will do that.

Hi Venkatesh. Can you also update model-inference/decisionTree/experiments/readme.md with your lightgbm updates?

Hey, Hong. Sure, will do that.

Thanks!

Adding Logs for 500 Trees Models. Will merge once I get them.

Two files are really long. I don't think you need to share them if they are the prediction outputs.

@hguan6 @venkate5hgunda @mahidhar96 At this point, let's share the prediction outputs using git just for efficient communication. In the future, I will archive these prediction outputs in an S3 bucket. But now, let's just push our prediction output to github repo!!!

@hguan6 @venkate5hgunda @mahidhar96 I deleted my last comment. I meant that we need push the result.txt to git. We do not need the inference results like 0/1s.

Yes, that will be great! I will share it soon.
On Wed, Aug 31, 2022 at 2:08 PM Jia Zou @.***> wrote:

@hguan6
https://urldefense.com/v3/__https://github.com/hguan6__;!!IKRxdwAv5BmarQ!duOmGFRX9CT_djm00b9gqleIHTm-M_QsfEC18FWdxHSvyEnipNWeAD65DRnJD5zNyRXx-DmajE4rX9Ex3LYD3JI$
@venkate5hgunda
https://urldefense.com/v3/__https://github.com/venkate5hgunda__;!!IKRxdwAv5BmarQ!duOmGFRX9CT_djm00b9gqleIHTm-M_QsfEC18FWdxHSvyEnipNWeAD65DRnJD5zNyRXx-DmajE4rX9ExLMt8FGM$
@mahidhar96
https://urldefense.com/v3/__https://github.com/mahidhar96__;!!IKRxdwAv5BmarQ!duOmGFRX9CT_djm00b9gqleIHTm-M_QsfEC18FWdxHSvyEnipNWeAD65DRnJD5zNyRXx-DmajE4rX9ExLDYtAVk$
At this point, let's share the prediction outputs using git just for
efficient communication. In the future, I will archive these prediction
outputs in an S3 bucket. But now, let's just push our prediction output to
github repo!!!
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/asu-cactus/netsdb/pull/54*issuecomment-1233421465__;Iw!!IKRxdwAv5BmarQ!duOmGFRX9CT_djm00b9gqleIHTm-M_QsfEC18FWdxHSvyEnipNWeAD65DRnJD5zNyRXx-DmajE4rX9Exdh63eJk$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEX53CZHJVT5URL3A4BNN2LV37CNNANCNFSM6AAAAAAQBRAB7I__;!!IKRxdwAv5BmarQ!duOmGFRX9CT_djm00b9gqleIHTm-M_QsfEC18FWdxHSvyEnipNWeAD65DRnJD5zNyRXx-DmajE4rX9ExiT8PiYs$
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Hong Guan, MS
School of Computing and Augmented Intelligence
Arizona State University

I was thinking about the csv outputs. Shall we upload them to github?
On Wed, Aug 31, 2022 at 2:10 PM Jia Zou @.***> wrote:

@hguan6
https://urldefense.com/v3/__https://github.com/hguan6__;!!IKRxdwAv5BmarQ!ffNw4G5lJsZqbTy2V8bbttgF68UjlJa3_lCwYcchwigRbekWA9Mjk-xUxw5tDXv-fBcfZAgR0wURNKjsiICbsck$
@venkate5hgunda
https://urldefense.com/v3/__https://github.com/venkate5hgunda__;!!IKRxdwAv5BmarQ!ffNw4G5lJsZqbTy2V8bbttgF68UjlJa3_lCwYcchwigRbekWA9Mjk-xUxw5tDXv-fBcfZAgR0wURNKjsOaGSu0s$
@mahidhar96
https://urldefense.com/v3/__https://github.com/mahidhar96__;!!IKRxdwAv5BmarQ!ffNw4G5lJsZqbTy2V8bbttgF68UjlJa3_lCwYcchwigRbekWA9Mjk-xUxw5tDXv-fBcfZAgR0wURNKjsI_iVhi8$
I deleted my last comment. I meant that we need push the result.txt to git.
We do not need the inference results like 0/1s.
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/asu-cactus/netsdb/pull/54*issuecomment-1233424044__;Iw!!IKRxdwAv5BmarQ!ffNw4G5lJsZqbTy2V8bbttgF68UjlJa3_lCwYcchwigRbekWA9Mjk-xUxw5tDXv-fBcfZAgR0wURNKjsozN2Dwg$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEX53C4AV3EHEP22YXRK55TV37CZHANCNFSM6AAAAAAQBRAB7I__;!!IKRxdwAv5BmarQ!ffNw4G5lJsZqbTy2V8bbttgF68UjlJa3_lCwYcchwigRbekWA9Mjk-xUxw5tDXv-fBcfZAgR0wURNKjsUomoynE$
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Hong Guan, MS
School of Computing and Augmented Intelligence
Arizona State University

Yes the times measured for each experiment, eg. result.txt should be pushed
to git, so that we can analyze these together. This is super important!
On Wed, Aug 31, 2022 at 2:14 PM hguan6 @.***> wrote:

I was thinking about the csv outputs. Shall we upload them to github?
On Wed, Aug 31, 2022 at 2:10 PM Jia Zou @.***> wrote:

@hguan6
<
https://urldefense.com/v3/__https://github.com/hguan6__;!!IKRxdwAv5BmarQ!ffNw4G5lJsZqbTy2V8bbttgF68UjlJa3_lCwYcchwigRbekWA9Mjk-xUxw5tDXv-fBcfZAgR0wURNKjsiICbsck$
@venkate5hgunda
<
https://urldefense.com/v3/__https://github.com/venkate5hgunda__;!!IKRxdwAv5BmarQ!ffNw4G5lJsZqbTy2V8bbttgF68UjlJa3_lCwYcchwigRbekWA9Mjk-xUxw5tDXv-fBcfZAgR0wURNKjsOaGSu0s$
@mahidhar96
<
https://urldefense.com/v3/__https://github.com/mahidhar96__;!!IKRxdwAv5BmarQ!ffNw4G5lJsZqbTy2V8bbttgF68UjlJa3_lCwYcchwigRbekWA9Mjk-xUxw5tDXv-fBcfZAgR0wURNKjsI_iVhi8$
I deleted my last comment. I meant that we need push the result.txt to
git.
We do not need the inference results like 0/1s.
—
Reply to this email directly, view it on GitHub
<
https://urldefense.com/v3/__https://github.com/asu-cactus/netsdb/pull/54*issuecomment-1233424044__;Iw!!IKRxdwAv5BmarQ!ffNw4G5lJsZqbTy2V8bbttgF68UjlJa3_lCwYcchwigRbekWA9Mjk-xUxw5tDXv-fBcfZAgR0wURNKjsozN2Dwg$
,
or unsubscribe
<
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEX53C4AV3EHEP22YXRK55TV37CZHANCNFSM6AAAAAAQBRAB7I__;!!IKRxdwAv5BmarQ!ffNw4G5lJsZqbTy2V8bbttgF68UjlJa3_lCwYcchwigRbekWA9Mjk-xUxw5tDXv-fBcfZAgR0wURNKjsUomoynE$
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Hong Guan, MS
School of Computing and Augmented Intelligence
Arizona State University
—
Reply to this email directly, view it on GitHub
https://github.com/asu-cactus/netsdb/pull/54#issuecomment-1233427914,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACBLNBVDTS3MQYPY6EKJWQDV37DKTANCNFSM6AAAAAAQBRAB7I
.
You are receiving this because your review was requested.Message ID:
@.***>

--
Jia Zou
Research Scientist
Department of Computer Science
Rice University


[Youku] Crash when episode count is wrong

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.12.31. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.12.31

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Here is a test url: http://list.youku.com/show/id_z20eb4acaf5c211e3b2ad.html
youtube-dl http://list.youku.com/show/id_z20eb4acaf5c211e3b2ad.html\?spm\=a2h0j.8191423.module_basic_title.5\~A\!2 -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'http://list.youku.com/show/id_z20eb4acaf5c211e3b2ad.html?spm=a2h0j.8191423.module_basic_title.5~A!2', u'-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.12.23
[debug] Python version 2.7.13 - Darwin-17.2.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.3.2, ffprobe 3.3.2
[debug] Proxy map: {}
[youku:show] z20eb4acaf5c211e3b2ad: Downloading webpage
[youku:show] z20eb4acaf5c211e3b2ad: Downloading initial playlist data page
[youku:show] z20eb4acaf5c211e3b2ad: Downloading playlist data page 2
ERROR: An extractor error has occurred. (caused by KeyError(u'html',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 438, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youku.py", line 292, in _real_extract
    'stage': reload_id,
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youku.py", line 254, in _extract_entries
    transform_source=lambda s: js_to_json(strip_jsonp(s)))['html']
KeyError: u'html'
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 784, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 451, in extract
    raise ExtractorError('An extractor error has occurred.', cause=e)
ExtractorError: An extractor error has occurred. (caused by KeyError(u'html',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

The episode count is 16 however it has three modules 1-40 41-80 81-86.
Obviously it's youku's fault.

Carefully read new issue template and provide all requested information.

I have updated information.

https://github.com/CoXier/youtube-dl/commit/5936bc6ed7aa2579c3edeca54d29ce30f3ba8d68 solves this issue.

Do not close the issue when fix is not merged.


Unable to remove movement tag with --meta-remove-property

--meta-remove-property=movement does not remove movement property from tagged file(s)

Thx for reporting, i'll take a look.

I have the same issue with recording-date.
tone tag file.m4b --meta-remove-property recording-date Error: recording-date is not a valid value for MetadataProperty.

@cybergurke @scapix
tone 0.1.6 is out. Since it is the first release after a long time, this issue may have been fixed with the new atldotnet release. I would love to get feedback, please backup your files.

I'm on version 0.1.8 and just ran into this problem. I try to clean an m4b file of all tags first, before setting only the tags that I want. So now I have only the title tag left, and the part and movement tags. Then I run
tone tag --taggers="remove" --meta-remove-property=part test.m4b

And output shows that part as well as movement tags are set to null. After that, a dump shows the file still has part and movement tags with their previous values. So either I'm trying to do something the program doesn't expect, or something else is wrong.
I also have mp3tag on a Windows pc, to check which tags are still present. Strangely mp3tag shows no tags at all after removing with tone.

@vincentkoevoets Thanks for reporting. Yeah part is one of tone's meta fields, that might be broken. I'll check this again.
Regarding mp3tag, this might be a really serious problem, because mp3tag is a reference tool - hopefully tone does not break anything. I'm going to look for this as soon as possible.

Yes that's how I also use mp3tag. As far as I can tell tone does not break anything. I did some more testing. Some things that stood out:

When using --meta-movement="17", --meta-part is also set to the same number. This also happens when using --meta-remove-property for one of these two tags (but, removing doesn't work as we know. But the output shows both these values set to null).
Once one of these is set (and thus both are set, effectively), they cannot be removed anymore.
I was able to start over by wiping all tags with exiftool, and was able to confirm something else: after using exiftool, the dump shows only the title tag, with the name of the file as title value. Then after using one or both of --meta-movement= or --meta-part, the dump shows both these tags with the correct value. But at this point, mp3tag does still only show the title tag.

Those were my findings so far. I'm not an expert, but if there is anything I can do, just say the word. Tone seems like a very promising and versatile application!

@vincentkoevoets
Thanks for your detailed report. I think I might have found the problem, movement is a specified property (for ID3 and M4A), which is an integer. This results in a problem - how would you store part 2.5 or part 2a, it's not possible. Therefore I created PART as a meta-property, that does not exist in the specification. Everytime you try to specify a part, it checks for an integer, and if it is not an integer, it stores the value "as good as possible" either only in part or in part AND movement.
The problem is that it has to create an additional property (which is not in the specification) and this can only be removed when handled correctly. There is an issue with that, I'll try to fix this asap.

@vincentkoevoets
Update: I found the problem. A change in atldotnet combined with an issue in tone led to this problem. tone 0.1.9 will potentially fix this, but I have to do some tests to ensure the correct behaviour. There is much stuff to test and I don't want to run in regression bugs :-)

@vincentkoevoets Awaiting fix of https://github.com/Zeugma440/atldotnet/issues/285
This must be fixed before 0.1.9, otherwise I would release a bug.

Hey @sandreas, so sorry for not responding anymore, I've been very busy. But now I see you've been busy too! I'm no expert but I think I can understand what you're describing. In fact I came here to suggest it might have had something to do with an update or change in atldotnet. Glad you found it, and that this problem is solved (or at least will be in future release). Thanks!


hostnames in /etc/hosts don't work

Apparently if no DNS server is specified then baresip  actually parses /etc/resolv.conf (through the re library) to get the name of a DNS server.
Baresip should use getaddrinfo(3) to look up names when no nameserver is specified.  That way the system's libc determines how hostnames are resolved, enabling the user to specify names with /etc/hosts or other db type specified in /etc/nsswitch.conf.
The actual code that does lookups appears to reside in re in the file src/dns/client.c in the function query().  The re library provides functions that baresip uses to generate a struct dnsc representing the DNS client, but that value is only ever passed back to re to be used in various functions that call query() (such as sip_alloc()).

we use the DNS resolver from libre, which is asynchronous.
the whole system is running in an async I/O run-loop, using e.g. epoll or select.
we cannot block the system by calling getaddrinfo and wait for the DNS response.

In the past I encountered the same problem. Now I use outbound to force a destination. Of course outbound need to be a resolved IP.
I use this a lot when testing on a computer without dns server.

baresip and multiple protocols in libre is using the libre DNS client.
re-writing the DNS client to use getaddrinfo_a is not an option.
closing this issue as "Not going to fix".

I reported this in re here: https://github.com/creytiv/re/issues/232


Future Warning importing SparkDatasetConverter.

The warning:
/home/hadoop/.local/lib/python3.7/site-packages/petastorm/spark/spark_dataset_converter.py:28: FutureWarning: pyarrow.LocalFileSystem is deprecated as of 2.0.0, please use pyarrow.fs.LocalFileSystem instead.
  from pyarrow import LocalFileSystem

jumps when the line:
from petastorm.spark.spark_dataset_converter import SparkDatasetConverter
is introduced in a pyspark shell.
spark-version: 3.2.1-amzn-0
python-version: 3.7.10
petastorm-version: 0.12.0
pyarrow-version: 9.0.0

This is actually tricky. Appears that we need to support new pyarrow dataset API, which is tricky, to upgrade the filesystem. See #613.

Thanks a lot @selitvin


Merge improvements for 2021-W50

Several enhancements needed for MESSAGEix-Transport code (iiasa/message_data#272).
How to review
Note that CI checks all pass.
PR checklist

[x] Continuous integration checks all ✅
[x] Add or expand tests; coverage checks both ✅
[x] Add, expand, or update documentation.
[x] Update doc/whatsnew.

@LauWien FYI see 5d0868f81d5ae7870600659f8f531ebb0ae516db
I happened to notice that it's no longer necessary to set access_token: ${{ github.token }}, as this is default. This is a change we can apply to all other workflows that use this action, whenever we happen to make modifications to those.


Add stages status

Fix https://github.com/Skyscanner/argocd-progressive-rollout/issues/8
In addition:

Fix a re-declaration issue of err
Rename FilterAppsBySyncStatusCode to GetAppsBySyncStatusCode to be consistent with the others GetXYZ functions naming.
Use the same approach with Status.Conditions and port the functions logic from https://github.com/kubernetes/apimachinery/blob/v0.21.0-alpha.0/pkg/api/meta/conditions.go#L25

To be able to have it as nil so you can have only the startedAt and
omit the completedAt
On Thu, May 6, 2021, 17:56 Sebastien Le Digabel @.***>
wrote:

@.**** commented on this pull request.
In api/v1alpha1/progressiverollout_types.go
https://github.com/Skyscanner/argocd-progressive-rollout/pull/60#discussion_r627550720
:

@@ -100,6 +102,34 @@ func (in *ProgressiveRollout) Owns(owners []metav1.OwnerReference) bool {
return false
}

+// SetStageStatus sets the corresponding StageStatus in stageStatus to newStatus
+// - If a stage doesn't exist, it will be added to StageStatus slice
+// - If a stage already exists it will be updated
+func (in *ProgressiveRollout) SetStageStatus(newStatus StageStatus, updateTime *metav1.Time) {
we briefly mentioned it earlier, but is there a reason behind the pointer
semantics of metav1.Time?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Skyscanner/argocd-progressive-rollout/pull/60#pullrequestreview-653623700,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEZHCFD56LZUZ6RR2TA7ETTMK34BANCNFSM42666CNQ
.


Optimize Node#parent_module_name

Related - https://github.com/rubocop/rubocop/pull/11240
There is no need to do all the complex traversing if there is no parent.

Thanks for the PR.
I am not convinced this will make any difference, like ever.
You would need a single and top-level def node for this to be the case, otherwise there will be a parent (begin).
I'm closing, but we can reopen if I'm missing something.

Agreed. Retested - you are right! Probably I was mistaken by something else back then 😄


피드백 - hr 버그 수정

🤔 해결하려는 문제가 무엇인가요?

close #337

🎉 변경 사항
fixed로 선언해 스크롤이 발생하는 개별 결과 페이지에서 발생하던 퍼블리싱 버그를 수정했어요
🌄 스크린샷

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d379be5). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage        ?   90.81%
=======================================
  Files           ?       42
  Lines           ?      294
  Branches        ?       52
=======================================
  Hits            ?      267
  Misses          ?       27
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


RenewLock API missing?

I couldn't find any API in the ruby sdk to renew or extend the lock for a given message.  In C# it is this.
Also, is there any support for a AutoRenewTimeout property like we have in C# sdk?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e5d9aaf6-1dd6-bb09-bb52-ddd1bc9a2719
Version Independent ID: 2ad3512c-f825-b34c-e1c6-d982e90a534d
Content: How to use Azure Service Bus queues with Ruby
Content Source: articles/service-bus-messaging/service-bus-ruby-how-to-use-queues.md
Service: service-bus-messaging
GitHub Login: @axisc
Microsoft Alias: aschhab

@axisc  Appreciate your inputs in this.

@GiriB I have assigned this to content author for further review and update as appropriate.

@GiriB - Looks like there is no support for it in the Ruby SDK. The SDK isn't actively being worked on either. Apologize for the delay is responding to you. I have been through the backlog as fast as I could. Thanks.
#please-close


Parser treats missing required elements inconsistently

First noticed in https://github.com/osrf/sdformat/pull/389#discussion_r533927085:

Do required fields need defaults? When would the default be used?

After writing that comment, I saw below that leaving this element out is supposed to still go through, but generates an error... I haven't looked, but is this kind of behaviour documented?

In researching how to respond to this comment I found some inconsistent code (code links from 10.0.0)

Near the beginning of readXml() in parser.cc, there is a block of code that looks like it fails hard whenever a required element is missing

Later in the function (parser.cc:1131-1156), there is code that generates errors if any required child elements are missing, but only for joints that aren't of type ball! This seems to apply to //joint/parent and //joint/child. But for anything else, required elements are simply inserted with default values and no error message.

I'll try to make examples that illustrate the different types of behavior here.

Near the beginning of readXml() in parser.cc, there is a block of code that looks like it fails hard whenever a required element is missing

this check has no test coverage as of c1e703d8fc8e4594023eba69048f5c873d0a249c. it may be dead code

I've added some example files with missing //joint/child elements in https://github.com/scpeters/sdformat/commit/3e7f4756a21717074ec2bc8105935181c7b84937.
fixed_joint_child_missing.sdf has a hard failure when trying to print it:
$ ign sdf --print fixed_joint_child_missing.sdf
Error Code 7 Msg: XML Missing required element[child], child of element[joint]
Error Code 8 Msg: Error reading element <joint>
Error Code 8 Msg: Error reading element <model>
Error Code 8 Msg: Error reading element <sdf>
Error: SDF parsing the xml failed.

ball_joint_child_missing.sdf is able to print successfully, with the //joint/child element populated by the default value __default__:
$ ign sdf --print ball_joint_child_missing.sdf
<sdf version='1.7'>
  <model name='ball_joint_child_missing'>
    <link name='link'>
      <pose>0 0 1 0 -0 0</pose>
    </link>
    <joint name='joint' type='ball'>
      <pose>0 0 3 0 -0 0</pose>
      <parent>link</parent>
      <child>__default__</child>
    </joint>
  </model>
</sdf>

This is an invalid value, though, so ign sdf --check fails:
$ ign sdf --check ball_joint_child_missing.sdf
Error: Child link with name[__default__] specified by joint with name[joint] not found in model with name[ball_joint_child_missing].
Error: FrameAttachedToGraph error, Non-LINK vertex with name [joint] is disconnected; it should have 1 outgoing edge in MODEL attached_to graph.
Error: Graph has __model__ scope but sink vertex named [joint] does not have FrameType LINK OR MODEL when starting from vertex with name [joint].
Error: Child link with name[__default__] specified by joint with name[joint] not found in model with name[ball_joint_child_missing].
Error: PoseRelativeToGraph error, Vertex with name [joint] is disconnected; it should have 1 incoming edge in MODEL relative_to graph.
Error: PoseRelativeToGraph frame with name [joint] is disconnected; its source vertex has name [joint], but its source name should be __model__.

The required attribute in the specification maps to two different behaviors that I can reproduce:

Hard parsing failure if //joint/parent or //joint/child are missing and //joint/@type != ball
Silently populating the missing field with a default value if missing.

If we want the parser to perform both of these behaviors, I would propose creating a new attribute like autofill_if_missing (but with a better name) and update the spec accordingly. Currently I believe this is why certain fields get added to an SDFormat file when you print it even if they weren't in the original document.

I would propose creating a new attribute like autofill_if_missing

Would this be an attribute that the person writing the SDF file would set? I'm not sure about the use case for this, could you write an example?
Just checking my understanding about default values. I'm not sure what the current behaviour is, but maybe something like this could work?

When value is missing
has default
no default

optional (required == 0)
Default is used
Field is omitted

required (required == 1)
Default is used, error is printed?
Fail hard?

This way, the SDF spec could define whether to fail softly with an error message or hard by not parsing, by defining a default value or not.

Having a required attribute with a default value can be useful when an SDFormat element or attribute changes from being optional to being required and we want to tick-tock the change by assigning a default value. So, what @chapulina suggested in the table sounds good to me.
I would support removing the default values we currently have, but I'm afraid it might break some things.


feat: implement gitlab release webhook

https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html#release-events

coverage: 89.765% (+0.05%) from 89.716% when pulling 220b666666d3e39316f14bbedf5380386b3701a1 on xNok:impl-gitlab-release into 69430a8f014ebee576e196aea419391556f6036c on go-playground:master.

Sorry kinda forgot about this one, I reverted the indentation changes in the test

@xNok Thanks!


Add a Node.create_timer method

Issue made in godot-proposals#4908
Adds a new method to the Node class to make timer creation more streamlined.
Node.create_tween() exists, so adding Node.create_timer() will make timer creation more intuitive.
CHANGED:
Node.h
Node.cpp
Node.xml

Bugsquad edit, closes: https://github.com/godotengine/godot-proposals/issues/4908

The problem is that, unlike Tweens, this does not bind the Timer to the node calling this method, and the timer will play regardless of the Node's current process mode. As is, the PR only saves 10 characters (get_tree().) and breaks expectations. It's not useful.

I agree, this is a useful shortcut but I would expect Node.create_timer() to be aware of the node's lifecycle


docs: Fix constraints example in enum how_to

The Code Snippet gave me a compile error, telling me that one_of was not a valid option
Contributor checklist

[ ] Bug fixes include regression tests
[ ] Features include unit/acceptance tests

🚀 Thank you for your contribution! 🚀


Excessive BNB balance recommended for Warp Route Deployment

Hi team,
When creating a new warp route from BSC to Base, got informed by Hyperlane CLI  that my owner address has a low balance on bsc, and "At least 0.6 BNB recommended". At that actual BNB rate, 0.6 BNB = $344 which sounds very excessive for gas :-)
Maybe that should be 0.006 BNB instead ?

@niskaka this is the registry repo. You're looking for the hyperlane monorepo if you're trying to report a cli bug: https://github.com/hyperlane-xyz/hyperlane-monorepo


Able to create service bus with the same name with the Fluent SDK

I'm using this to create a service bus using the Fluent SDK:
var serviceBusNamespace = azure.ServiceBusNamespaces
                            .Define(serviceBusName)
                            .WithRegion(Region)
                            .WithExistingResourceGroup(resourceGroup)
                            .WithSku(NamespaceSku.Standard)
                            .Create();

If I run this code for two different resource groups using the same serviceBusName, I get a service bus created in both resources groups without error. However when I go to the Azure portal the first service bus opens fine, but I get an error saying 'Not Found' when trying to open the second.
I understand that servicebus names must be unique across all of Azure, but why is the Fluent SDK allowing me to create the second service bus with the same name?

@KeishaW are you running the snippet above concurrently when running into this issue?

@SeanFeldman no I am not. I run the snippet the first time, to the get the first service bus. And after it is created and I see it in the Azure portal, I run it again without error.

Sounds like a bug.
If only issues were triaged here in a timely mannor...

Maybe @shahabhijeet @hovsepm @cormacpayne can help here.

@KeishaW please reopen the issue in the Fluent SDK repo here https://github.com/Azure/azure-libraries-for-net/


MarginPadding axis

I'm not against Horizontal and Vertical properties, but they should only be settable, and they should be separate from TotalHorizontal imho.


How to find the azure spark pool availability in synapse analytics dynamically

Hi ,
I want to schedule azure synapse notebooks from the pipeline, So the pipeline should dynamically pick the available azure spark pool from the list. How to get that list and fetch the available spark pool?
Thanks,
Satya

You can list spark pool by calling this API:
rest api: https://learn.microsoft.com/en-us/rest/api/synapse/resourcemanager/big-data-pools/list-by-workspace?view=rest-synapse-resourcemanager-2021-06-01-preview&tabs=HTTP
python sdk: https://learn.microsoft.com/en-us/python/api/azure-mgmt-synapse/azure.mgmt.synapse.operations.bigdatapoolsoperations?view=azure-python#azure-mgmt-synapse-operations-bigdatapoolsoperations-list-by-workspace

Feel free to reopen this issue if you have further question, thanks.


Escape key and clicking outside the reporter (on the app) should hide the reporter

A little improvement :)

implemented in ctrl-v show/hide


Rules with the same port_range but different protocols are treated as identical

I'm trying to open a range of ports on both udp and tcp. The second rule is never added since it's detected as already existing ("X  already exists -- nothing to do").
My workaround is to specify slightly different port ranges so that they don't overlap...but that's awkward:)

Same issue here.


Hard Crash with FFXII The Zodiac Age

The app just crashes when trying to export the game to Steam

FFXII lists a invalid path as it's icon path causing the app to crash before exporting
C:\Program Files\WindowsApps\39EA002F.FFXIITZA-MSstore_<IP_ADDRESS>_x64__n746a19ndrrjg\Assets\Logo.png Assets


feat: csv to oscal component definition

Types of changes

[ ] Hot fix (emergency fix and release)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Documentation (change which affects the documentation site)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Release (develop -> main)

Quality assurance (all should be covered).

[x] My code follows the code style of this project.
[ ] Documentation for my change is up to date?
[ ] My PR meets testing requirements.
[ ] All new and existing tests passed.
[ ] All commits are signed-off.

Summary
Key links:

Sonar coverage

Before you merge

Ensure it is a 'squash commit' if not a release.
Ensure CI is currently passing
Check sonar. If you are working for a fork a maintainer will reach out, if required.

Thx Ekaterina. None of these look like show stoppers, if you wanted to download this branch as is. I’ll fix these problems tomorrow.
Sent from my iPhone

On Oct 6, 2022, at 9:00 PM, Ekaterina Nikonova @.***> wrote:
@enikonovad commented on this pull request.
In trestle/tasks/csv_to_oscal_cd.py:

   self._verbose = False

   self._ns = 'http://ibm.github.io/compliance-trestle/schemas/oscal/cd'

This should be customisable and come from the args/config?
In trestle/tasks/csv_to_oscal_cd.py:

   self._timestamp = timestamp

def print_info(self) -> None:

   """Print the help string."""

   self.csv_helper.print_info(self.name, 'component_definition')

def simulate(self) -> TaskOutcome:

   """Provide a simulated outcome."""

   return TaskOutcome('simulated-success')

def execute(self) -> TaskOutcome:

   """Provide an executed outcome."""

   try:

       return self._execute()

   except Exception:

       logger.info(traceback.format_exc())

logger.error
In trestle/tasks/csv_helper.py:

   logger.info(text1 + text2)

   text1 = '  expected columns:   '

   for text2 in self._column.help_list:

       logger.info(text1 + text2)

       text1 = '                      '

   text1 = '  output-dir        = '

   text2 = '(required) the path of the output directory for synthesized OSCAL .json files.'

   logger.info(text1 + text2)

   text1 = '  output-overwrite  = '

   text2 = '(optional) true [default] or false; replace existing output when true.'

   logger.info(text1 + text2)

def configure(self, task: TaskBase) -> bool:

   """Configure."""

   if not task._config:

       logger.warning('config missing')

error and return false/ raise exception? Otherwise the code below will fail
In trestle/tasks/csv_helper.py:

       logger.warning('"csv" not found')

       return False

   # announce csv

   if task._verbose:

       logger.info(f'input: {csv_file}')

   # load spread sheet

   self.load(csv_file)

   return True

def load(self, csv_path: pathlib.Path) -> None:

   """Load."""

   with open(csv_path, 'r', newline='') as f:

       csv_reader = csv.reader(f, delimiter=',', quoting=csv.QUOTE_MINIMAL)

       for row in csv_reader:

           self._csv.append(row)

   self._column.map_head(self._csv[0])

indexing fails if csv is empty
In trestle/tasks/csv_to_oscal_cd.py:

       title='Component definition for ' + self._get_catalog_title() + ' profiles',

       last_modified=self._timestamp,

       oscal_version=OSCAL_VERSION,

       version=get_trestle_version(),

       roles=roles,

       parties=parties,

       responsible_parties=responsible_parties,

   )

   component_definition = ComponentDefinition(

       uuid=str(uuid.uuid4()),

       metadata=metadata,

       components=self._get_components(),

   )

   # write OSCAL ComponentDefinition to file

   if self._verbose:

       logger.info(f'output: {ofile}')

should be on debug level
In trestle/tasks/csv_to_oscal_cd.py:

   index = 0

   for row in self.csv_helper.row_generator():

for row, index in enumerate(self.csv_helper.row_generator())
In trestle/tasks/csv_to_oscal_cd.py:

       Role(id='prepared-by', title='Indicates the organization that created this content.'),

       Role(id='prepared-for', title='Indicates the organization for which this content was created..'),

       Role(

           id='content-approver',

           title='Indicates the organization responsible for all content represented in the "document".'

       ),

Are these hardcoded for every cd?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.


(Question) A version containing only icons

This theme is good, maybe not for everyone, but like the icons.. the ICONS are AMAZING. So, I think it would be nice if a version was compiled that only changes the icons.

Should be easy enough

This theme is good, maybe not for everyone, but like the icons.. the ICONS are AMAZING. So, I think it would be nice if a version was compiled that only changes the icons.

If you want to use just the icons, at least in BetterDiscord, you can just do @import url('https://discordstyles.github.io/Fluent/Icons.css'); inside of custom CSS. But you can most likely also do this inside of any theme.

can someone please close this issue as it has been solved.


Refactor monitoring

Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

fixes #619 619
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #620 (0779c2e) into master (e3939c0) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #620   +/-   ##
=======================================
  Coverage   18.04%   18.04%
=======================================
  Files          64       64
  Lines        2727     2727
=======================================
  Hits          492      492
  Misses       2185     2185
  Partials       50       50

Impacted Files
Coverage Δ

pkg/ddc/alluxio/transform.go
0.00% <0.00%> (ø)

pkg/utils/dataset/lifecycle/schedule.go
23.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3939c0...0779c2e. Read the comment docs.


Add coverage reports to github actions

Uses coverage.py to produce coverage reports in CI.
Special care is given to avoid the security snafus in this article
relative_files = True is required for cross-platform compatibility when merging coverage reports generated by the run matrix.
An html report is generated and uploaded to github (retention 60 days), as well as a text summary.
The text summary and a link to the html report are added to the pull request as a comment.
Screenshots for reference:

NB: "comment" workflow file is added in a separate commit since it needs to reside on the target branch (see above link for security explanation)

I've been reviewing this one for a few hours just so we don't all review it at the same time.

A concret example of this can be found on https://github.com/remyroy/ethstaker-deposit-cli/pull/1

One non-blocking issue for this PR is the fact that the added PR comment will spam notifications (Github notifications, emails, etc) and there is no way to easily disable that notification that I could find. Some mute feature has been requested but it's still ongoing.

One non-blocking issue for this PR is the fact that the added PR comment will spam notifications (Github notifications, emails, etc) and there is no way to easily disable that notification that I could find. Some mute feature has been requested but it's still ongoing.

There is perhaps a tenable improvement to be made, wherein the previous comment is edited instead of a new comment being posted. I've seen some workflows that can do that.


[Altdorf: Crown of the Empire] Altdorf Initialize doesn't create Actors or Items

New world, activated Altdorf module, did not get any Characters or Items created. Do see them in the Compendium.From: Eyestalkfoundry: 11.304wfrp4e: 6.5.9wfrp4e-altdorf: 3.0.0wfrp4e-core: 3.1.4wfrp4e-middenheim: 3.0.2wfrp4e-rnhd: 3.0.7wfrp4e-starter-set: 3.1.5Active Modules:

Intentional


Fix TG creation when using named targetPorts

What type of PR is this?
bugfix
Which issue does this PR fix:
Addresses #86. Currently named targetPorts cause error because it triggers CreateTargetGroup request with port 0. With this PR it will trigger request with port 80 instead.
What does this PR do / Why do we need it:

TargetPort actually does not matter at all. To understand this we need to understand how ports are working in Lattice TGs. Ports defined in Lattice TGs only acts as a "default port" when no port is specified in RegisterTargets API. Since we always populate port when creating targets, the port on TG does nothing. We do not need an accurate number on this field.

But can't we still query the endpoint and find the port name? This path seems complicated. For example, there could be multiple pods using the same port name but different port numbers. In this case picking any of the port number will be technically wrong. This way also requires an (practically unnecessary) update on targetGroup when just targets are changing.

Setting to port 80 matches Lattice documentation as well.

Overall I would treat this as a bugfix and deploy the simplest mitigation, unless we need this field in some way later.
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:

make e2etest
Gateway conformance tests
manual testing to confirm service targetPort (either named or unnamed) does not matter on target registration.

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 22 (40.91%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 31.949%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/gateway/model_build_targetgroup.go
9
22
40.91%

Totals

Change from base Build<PHONE_NUMBER>:
0.008%

Covered Lines:
3201

Relevant Lines:
10019

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 31.909%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
3189

Relevant Lines:
9994

💛  - Coveralls


feat: support cache expiration & improve admin speed

resolves #213
resolves #306

By having our own nuxthub unstorage driver , we can now

The cache entry metadata in KV metadata
Set the expiration of the item so Cloudflare will remove it automatically (works in development too!)

The Cache admin dashboard is now much faster for new cache entries as it will read the metadata from the list instead of fetching the cache entry for each item 🚀
I also updated the module to always run the Cloudflare platform proxy in development, this is needed for storing the cache in local KV as it support expiration and bring consistency with production. Also, we don't support (and won't) remote storage for cache entries for performance reasons.
This brings a powerful feature from Cloudflare as we can now access event.context.cf from the server and API routes:
export default eventHandler(event => {
  export default eventHandler(async (event) => {
  const { isEUCountry, continent, city, timezone, country, region, latitude, longitude, botManagement } = event.context.cf
  return {
    continent,
    isEUCountry,
    country,
    region,
    city,
    timezone,
    latitude,
    longitude,
    botManagement
  }
})

I think something in this just broke this:
https://github.com/nuxt-hub/core/issues/316


Add Postgres source

@mgrauer No action associated with this source, it also stealth fixes a bug where jade would flip out if your source had no icon/action.
Very simple source, just meant to be used as an input to analyses.

Is this a WIP, or all you wanted to do here?  It doesn't actually create a postgres connection of any kind.

it also stealth fixes a bug where jade would flip out if your source had no icon/action.

the first rule of stealth fixes...
:speak_no_evil:

It doesn't create a connection, if you want me to include psycopg2 and setup some basic functionality for executing a query from user input or something, I can. However this is what I had remaining from #122, where a PG source was just used as input to an analysis.

No need to do that.  I was curious about how much you intended to add with this PR.

Sure - this is set on my end.

I made three changes.

Rebased on master

2)Reverted the girderModal, b/c this was causing a flash b/w the first dialog (add source) and the next (add postgres source).  I'll need to clarify when to use girderModal in the docs, but I think it is better not to in this case because we have already called girderModal on the first dialog, then the container just gets re-used by the second dialog.

Changed the icon to the recently added 'icon-database'.

This branch LGTM if these changes are OK by you.


Warning and version update

Using Angular 4.0
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed. npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed
Can we also have a release version with the latest changes instead of referencing master

Done (version 6.1.4)


Synchronuous vs. asynchronuous scanning in ORT scanner

It should be possible to run fresh scan asynchronously instead of a synchronuous run.
Reason: In a CI environment, the ORT scan is executed frequently. In these cases, it makes sense to not run the build for a very long time, but to provide information to the user fast by a report that states also the open components which have not been reviewed so far.
This enables the following use cases:

The scan is outsourced to an external provider like Clearly Defined with an undefined resonse behavior
The review can be extended by, e.g., manual steps, so that the scan result is assessed and approved by an compliance office.

Acceptance Criteria:

[ ] Scans can be executed asynchronuously switched by a parameter in the cli
[ ] The scan result is stored in the storage backend as usual and retrieved from there, e.g., in the next run, if already available

Open Question: Is there a feedback needed somehow, that retriggers the scan step automatically, as soon as the asynchronuous scans have been completed.

I believe the correct way to implement this is via https://github.com/oss-review-toolkit/ort/issues/4688. In particular, I don't see how this could be implemented in the CLI frontend with a good UX. So I'm closing this in favor of addressing this as part of the ORT server epic.


After going through dcoumentation not abel to find answers to a couple of issues

I am learning Openshift and installed it on a Hyper-V machine. I asked in this forum the following questions, all waht I get  "Please read documentation..."
I did read but still not able to find what I need to know.
At thread https://github.com/crc-org/crc/issues/3925 access https://console-openshift-console.apps-crc.testing remotely
The response I got is to visit https://crc.dev/crc/getting_started/getting_started/networking/, which I did which talks only about linux whereas all details I gave indicated that my setup was on Hyper-V.
2nd, I searched the documentation/googles to access the openshift VM called CRC using ssh as follows
ssh -i ~/.crc/machines/crc/id_ecdsa<EMAIL_ADDRESS>getting

ssh: connect to host api.crc.testing port 22: Connection refused

There is no hint in the documentation on how to allow access to port 22 or how to do it!
Why I need to use ssh? Because I am trying to deploy an app and getting the following

The node was low on resource: ephemeral-storage. Threshold quantity:<PHONE_NUMBER>, available: 4652132Ki.

in spite of the fact that I have a lot of space disk on my drive, googled/searched the documentation so not really clear straight forward explanation of the root cause and a fix or any idea on how to solve the issue that is why I wanted to access the VM and see its disk space.
Can somebody help? And please dont respond again by "Please read the documentation " and close the thread.
Of course documentation should be read which cant be read all when you are trying to setup and want to go a little bit faster than the music. I am working in computers and servers world since 25 years, used github and forums and people editors of a software when asked respond for the specific demande and pointing to the issue if it exists in the documentation.
Thanks for your help

Do NOT file multiple issues in a single one... 👎 This does not help with offering you a consistent answer.

ssh: connect to host api.crc.testing port 22: Connection refused

On Windows and macOS the VM is hosted with port 2222 as it is based on a userspace networkin stack to allow co-existence with VPN connectivity.
The answer to remote access has been given: https://github.com/crc-org/crc/issues/3925#issuecomment-1825188191. We ONLY offer a setup that works on Linux. For a Windows based setup, using Hyper-V, we can not help you with a solution. This is something you have to figure out yourself, perhaps using a proxy, IIS, etc. This is NOT something we can help with as this is based on your setup. We are a small team and can only provide assistance with what is in the documentation. Since Windows uses a userspace netwpring stack, all is bound on localhost, which differs from the Linux setup. If you want remote setup... use Linux. Most people we deal with have this setup for CI/CD on Linux. Can't help you on Windows.\

disk space

crc status would tell you. About storage, you already have an issue: https://github.com/crc-org/crc/issues/3923 so let's use this to handle the case you enable Monitoring and see issues with PV.

specific demande and pointing to the issue if it exists in the documentation.

The issue is that you demand an answer from the engineers and sound impatient. We have pointed out the location, and answered what we can offer, and still you want to have more. As said, we do not offer a remote solution on Windows.

There is no hint in the documentation on how to allow access to port 22 or how to do it!

@praveenkumar @themr0c Something we could consider describing, however the whole topic of userspace/usermode networking has not been described. The last time this was discussed was before Kevin moved teams, which is now over a year and a half? Perhaps we should offer that crc ssh command?

There is no hint in the documentation on how to allow access to port 22 or how to do it!

This is covered here https://github.com/crc-org/crc/wiki/Debugging-guide

I am learning Openshift and installed it on a Hyper-V machine. I asked in this forum the following questions, all waht I get "Please read documentation..."

First, this is not a forum but an issue tracker for filling ISSUES. It would have made more sense if you had filed a discussion topic instead. Your learning can probably be better served at:  https://stackoverflow.com/questions/tagged/openshift or any of the other StackExchange related websites at: https://stackexchange.com/search?q=openshift
Second, we are NOT in the business of educating people about the use of OpenShift. For this you have a lot of resources on the internet, such as the aforementioned forum sites, or developer.redhat.com, and others. Please refrain from using our issue tracker as a discussion forum.

Thanks for all of you for your help. @gbraad Ok, I will be patient regarding #3923 and agree to your suggestion.

@cfergeau would it help to mention this difference as part of the generic documentation we have on the portal? It is not something that has come up often, but it is a noticeable difference... or otherwise, since we do not have someone for documentation, we might resolve this as a crc ssh command like we had done in Minishift to start a session? However, this was very problematic on Windows as most of the client were non-compliant/faulty.

@gbraad I was able to ssh to the VM uisng the port 2222.

@eliassal Thanks for the report. We usually do not describe this as it is not a very common scenario. Most people do not need to SSH into the VM, as most of the actions can happen from the webconsole. This is why it is part of the debug description.

@gbraad OK great and thanks. So lets concentrate on the issue #3923  as it is my main issue now as almost you responded to all my requests, thanks again. In fact while I was googling for the issue of monitoring I came across a thread where it talked about using commands like df to check space free on drive and I have 12G free space in the VM

some engineers are on PTO, so that issue will not see responses until after next week/next release.


Upgrade express session

In Chrome 80, the SameSite property of cookies will begin defaulting to Lax (https://www.chromestatus.com/feature/5088147346030592). To avoid this, you need to set the SameSite property to None. However, support for this property was not added until the most recent version of express-session. Thus, this upgrades the dependency on express-session so we can use this new value.

Hey @mpneuried! Would love to have this PR looked at! The AppVeyor build is failing on Node 10 due to a weird Could not find any Visual Studio installation to use error. Do you have any idea what could be causing this? Thanks.


Update LocalProcessor to support CASE feathub expression

What is the purpose of the change
Update LocalProcessor to support CASE feathub expression. And Update LocalProcessor error handling.
Brief change log

Update LocalProcessor to support CASE feathub expression.
Update LocalProcessor error handling.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@yunfengzhou-hub Could you review this PR?

Thanks for the update. LGTM. @lindong28 could you please take a look at this PR?

Thanks for the PR. LGTM.


deny #practice-room-chat permissions for muted + deafened users

More specifically, muted + self deafened users, who aren't meaningfully participating in a practice room but just camping practice rooms to get speaking privileges.

PR #39 merged


v4.5.12 release version bump

Changes since last release: https://github.com/github/linguist/compare/v4.5.11...359f40fb00140bdad29daaa7b0d6086f6467a14a
Merged Pull Requests

Grammar updates #2547 (arfon)
Make regex for vim modeline more lenient #2546 (ammaraskar)
YAML extensions for TextMate and Sublime Text grammars #2545 (pchaigno)
Highlight Brewfile as Ruby #2542 (josh)
Filename Makefile.inc for Makefile #2540 (pchaigno)
Updates for the Puppet language #2539 (rji)
Add codemirror's demo directory #2538 (BerkeleyTrue)
#2504 - xBase aliases and extension .prw #2537 (imsys)
Adding Slim tm_scope #2536 (arfon)
Case-insensitive extension match for heuristic rules #2535 (pchaigno)
Split on comma in language name if no match is found #2447 (Ryman)

Closing in favour of https://github.com/github/linguist/pull/2552


CSV User import fails on big datasets

For an event I wanted to import all our members into the DB to then be able to select the people present. I created a CSV file with all 1800 names and selected to import it and the preview is correct, but when importing it, it takes several minutes and then a timeout error is displayed at the top. The import is not done, at least not at that time. I wouldn't consider a CSV file with 1800 rows of first and last name particularly big and would expect it to import all of this in a matter of maybe a minute or less.
I'm using this on the OpenSlides 2.3 Windows portable package on a quite potent 8-core i5 system with more than enough RAM (16GB).

It also resulted in the process crashing and the sqlite DB later on being corrupted after killing the process.

SQLite will find it's limits for that amount of data (>500). The use of a "real" database and caching is required for more than 1000 users. SQLite is really just to play around and developing OpenSlides.
The easiest thing for you to do is to setup OpenSlides BigMode
Please see:
https://github.com/OpenSlides/OpenSlides#installation-for-big-assemblies
and:
https://github.com/OpenSlides/OpenSlides/blob/master/DEVELOPMENT.rst#openslides-in-big-mode

I've used the script by @ostcar to set this up on a raspi with the bigmode setup (and provided some fixes for that script) and that had the same issue. It honestly actually looks more like the import is having problems with reading the data.

We don't support sqlite anymore


https://xref.learn.microsoft.com links not working for me

🚨 Looks like you arrived from the internal review site
🚨 Do not enter Microsoft confidential information here
The https://xref.learn.microsoft.com links to the autocomplete site are not working for me (they return "This site can't be reached" error message).
Are these links supposed to start with "https://xref.docs.microsoft.com..." instead?
For example, if I change:

https://xref.learn.microsoft.com/query?uid=System.String

to

https://xref.docs.microsoft.com/query?uid=System.String

the latter "docs" link fetches data.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fcff0d60-cd99-d88d-9e21-bee20c17a4de
Version Independent ID: ff9c4a5e-f283-9c95-b8fb-a3adb87460cc
Content: How to use links in documentation - Contributor guide
Content Source: Contribute/how-to-write-links.md
Product: non-product-specific
GitHub Login: @gewarren
Microsoft Alias: gewarren

Good catch @v-jbasden. I guess these URLs were mistakenly updated as part of a bulk update.


logging_util: Fix timezone-naive datetime being compared to aware dat…

…etime.
Fixes regression in 3d07ac0.

Automated message from Dropbox CLA bot
@rishig, it looks like you've already signed the Dropbox CLA. Thanks!

Merged, thanks @rishig!  I'm also going to add a test suite for that file as a follow-up, since it's a particularly annoying place to have bugs.


Sim support for Makey Makey extension

Request from Makey Makey for simulator support of a Makey Makey extension.
Idea would be that a student could use their Makey Makey board as a game controller for playing Arcade games on the computer.

This is duplicate of https://github.com/microsoft/pxt-arcade/issues/4738


Feature: add option formatToMp4 to convert .mov to .mp4 in iOS

Motivation (required)
When iOS records a video, the format is .mov.
When we upload this .mov, we can't play it in Chrome browser and some Android devices.
That's why, this .mov needs to be converted to .mp4
Test Plan (required)
Tried recording, picking video from gallery, and uploading video from iOS. No crash happened. And the video could be played in Chrome.

so is not being merged?

not merged yet??

Any news here?


[release-v0.41.x] picking up latest changes in knative 1.8

Changes
This PR is a result of:
go get<EMAIL_ADDRESS>./hack/update-codegen.sh

knative.dev/pkg was recently updated to include a performance fix which helped reduced the CPU usage by 61% and memory usage by 44% for huge pipelines. This PR is updating the tekton controllers to include that fix such that our LTS release can take advantage of this performance improvement.
The same fix was cherry picked in knative.dev/pkg 1.9. Tekton pipeline was updated to use knative 1.9 post 0.45 in PR #6062. We have another PR https://github.com/tektoncd/pipeline/pull/6194 open to update pipeline controllers in the main branch.

/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Bring the latest performance fix in knative/pkg which helps reduce CPU/Memory usage for huge pipelines.

/retest

/retest
/approve

/retest
/lgtm

/test pull-tekton-pipeline-beta-integration-tests

the beta test failure is constant in all the attempts so far 😞:
Default change: During creation of nodepools or autoscaling configuration changes for cluster versions greater than 1.24.1-gke.800 a default location policy is applied. For Spot and PVM it defaults to ANY, and for all other VM kinds a BALANCED policy is used. To change the default values use the `--location-policy` flag.
Note: Your Pod address range (`--cluster-ipv4-cidr`) can accommodate at most 1008 node(s).
ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=400, message=
	(1) Creation of node pools using node images based on Docker container runtimes is not supported in GKE v1.23. This is to prepare for the removal of Dockershim in Kubernetes v1.24. We recommend that you migrate to image types based on Containerd (examples). For more information, contact Cloud Support
	(2) Creation of node pools using node images based on Docker container runtimes is not supported in GKE v1.24+ clusters as Dockershim has been removed in Kubernetes v1.24.
2023/02/22 16:38:20 process.go:155: Step 'gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-7 --region=us-central1 --machine-type=n1-standard-4 --image-type=cos --num-nodes=1 --network=tpipeline-e2e-net1628433604[252](https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/6201/pull-tekton-pipeline-beta-integration-tests/1628433604252012544#1:build-log.txt%3A252)01[254](https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/6201/pull-tekton-pipeline-beta-integration-tests/1628433604252012544#1:build-log.txt%3A254)4 --cluster-version=1.24.9-gke.2000 tpipeline-e2e-cls1628433604252012544' finished in 2.8496[255](https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/6201/pull-tekton-pipeline-beta-integration-tests/1628433604252012544#1:build-log.txt%3A255)75s
2023/02/22 16:38:20 main.go:319: Something went wrong: starting e2e cluster: error creating cluster: error during gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-7 --region=us-central1 --machine-type=n1-standard-4 --image-type=cos --num-nodes=1 --network=tpipeline-e2e-net1628433604252012544 --cluster-version=1.24.9-gke.2000 tpipeline-e2e-cls1628433604252012544: exit status 1

I am having hard time deciphering the failure but looks like a cluster is being created with 1.24, could that be an issue? 🤔
Also, I checked two latest commits in release-v0.41.x and noticed the beta tests were not part of the CI, wondering why?

@linux-foundation-easycla[bot]
EasyCLA EasyCLA check passed. You are authorized to contribute.
Details
@tekton-robot
check-github-tasks-completed Job Successful.
Details
@tekton-robot
check-pr-has-kind-label Job Successful.
Details
@tekton-robot
pull-tekton-pipeline-alpha-integration-tests Job succeeded.                     BaseSHA:9ee839025241dcaf1dc3b9086e3c5fdb0c4126c1
Details
@tekton-robot
pull-tekton-pipeline-build-tests Job succeeded.                     BaseSHA:9ee839025241dcaf1dc3b9086e3c5fdb0c4126c1
Details
@tekton-robot
pull-tekton-pipeline-go-coverage Job succeeded.                     BaseSHA:9ee839025241dcaf1dc3b9086e3c5fdb0c4126c1
Details
@tekton-robot
pull-tekton-pipeline-integration-tests Job succeeded.                     BaseSHA:9ee839025241dcaf1dc3b9086e3c5fdb0c4126c1
Details
@tekton-robot
pull-tekton-pipeline-unit-tests Job succeeded.                     BaseSHA:9ee839025241dcaf1dc3b9086e3c5fdb0c4126c1
Details
@tekton-robot
tide In merge pool.

the beta test failure is constant in all the attempts so far 😞:
Default change: During creation of nodepools or autoscaling configuration changes for cluster versions greater than 1.24.1-gke.800 a default location policy is applied. For Spot and PVM it defaults to ANY, and for all other VM kinds a BALANCED policy is used. To change the default values use the `--location-policy` flag.
Note: Your Pod address range (`--cluster-ipv4-cidr`) can accommodate at most 1008 node(s).
ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=400, message=
	(1) Creation of node pools using node images based on Docker container runtimes is not supported in GKE v1.23. This is to prepare for the removal of Dockershim in Kubernetes v1.24. We recommend that you migrate to image types based on Containerd (examples). For more information, contact Cloud Support
	(2) Creation of node pools using node images based on Docker container runtimes is not supported in GKE v1.24+ clusters as Dockershim has been removed in Kubernetes v1.24.
2023/02/22 16:38:20 process.go:155: Step 'gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-7 --region=us-central1 --machine-type=n1-standard-4 --image-type=cos --num-nodes=1 --network=tpipeline-e2e-net1628433604[252](https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/6201/pull-tekton-pipeline-beta-integration-tests/1628433604252012544#1:build-log.txt%3A252)01[254](https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/6201/pull-tekton-pipeline-beta-integration-tests/1628433604252012544#1:build-log.txt%3A254)4 --cluster-version=1.24.9-gke.2000 tpipeline-e2e-cls1628433604252012544' finished in 2.8496[255](https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/6201/pull-tekton-pipeline-beta-integration-tests/1628433604252012544#1:build-log.txt%3A255)75s
2023/02/22 16:38:20 main.go:319: Something went wrong: starting e2e cluster: error creating cluster: error during gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-7 --region=us-central1 --machine-type=n1-standard-4 --image-type=cos --num-nodes=1 --network=tpipeline-e2e-net1628433604252012544 --cluster-version=1.24.9-gke.2000 tpipeline-e2e-cls1628433604252012544: exit status 1

I am having hard time deciphering the failure but looks like a cluster is being created with 1.24, could that be an issue? 🤔
Also, I checked two latest commits in release-v0.41.x and noticed the beta tests were not part of the CI, wondering why?

@linux-foundation-easycla[bot]
EasyCLA EasyCLA check passed. You are authorized to contribute.
Details
@tekton-robot
check-github-tasks-completed Job Successful.
Details
@tekton-robot
check-pr-has-kind-label Job Successful.
Details
@tekton-robot
pull-tekton-pipeline-alpha-integration-tests Job succeeded.                     BaseSHA:9ee839025241dcaf1dc3b9086e3c5fdb0c4126c1
Details
@tekton-robot
pull-tekton-pipeline-build-tests Job succeeded.                     BaseSHA:9ee839025241dcaf1dc3b9086e3c5fdb0c4126c1
Details
@tekton-robot
pull-tekton-pipeline-go-coverage Job succeeded.                     BaseSHA:9ee839025241dcaf1dc3b9086e3c5fdb0c4126c1
Details
@tekton-robot
pull-tekton-pipeline-integration-tests Job succeeded.                     BaseSHA:9ee839025241dcaf1dc3b9086e3c5fdb0c4126c1
Details
@tekton-robot
pull-tekton-pipeline-unit-tests Job succeeded.                     BaseSHA:9ee839025241dcaf1dc3b9086e3c5fdb0c4126c1
Details
@tekton-robot
tide In merge pool.

The beta integration test was introduced and held to be merged after V1 CRD release, which could be the reason why it was not in v0.41.

As for the cluster versioning https://github.com/tektoncd/plumbing/pull/1348 and https://github.com/tektoncd/plumbing/pull/1332 should be both in the last release, which I am not sure if that should be the case? cc @XinruZhang @vdemeester  🤔

One more thing I noticed, we are running go 1.19:
go version
go version go1.19 linux/amd64

This might not be causing issue here but our pipelines repo is compliant with 1.18 as par go.mod.

An interesting comparison of logs from beta tests in this PR and one of the recent PRs:

Beta tests from this PR is missing setting up the KIND cluster and running ./test/presubmit-tests.sh --integration-tests instead of running test/e2e-tests.sh.

@pritidesai
ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=400, message=
	(1) Creation of node pools using node images based on Docker container runtimes is not supported in GKE v1.23. This is to prepare for the removal of Dockershim in Kubernetes v1.24. We recommend that you migrate to image types based on Containerd (examples). For more information, contact Cloud Support
	(2) Creation of node pools using node images based on Docker container runtimes is not supported in GKE v1.24+ clusters as Dockershim has been removed in Kubernetes v1.24.

The error comes from the param we specified during the container creation --image-type=cos when creating the cluster using the following command, but not sure why the error only occurs in this PR
gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-7 --region=us-central1 --machine-type=n1-standard-4 --num-nodes=1 --cluster-version=1.24.9-gke.2000 tpipeline-e2e

thanks @XinruZhang 👍
I am also wondering why is the GKE being provisioned instead of KIND?

Could it be because this env. setting is missing from this branch (release-v0.41.x)?

Do we need to cherry pick this PR which added prow env. for beta tests?

Could it be because this beta env. setting is missing from this branch (release-v0.41.x)?

It was introduced in 0.45 and not part of branches from release-v0.41.x through release-v0.44.x. Just checked the latest commit in release-v0.44.x, the beta test did not run on that branch.

One more follow up PR which we might have to cherry pick? https://github.com/tektoncd/pipeline/pull/6031 🤔

Wondering if there's other modifications we need to cherrypick to ensure our CI works for previous releases. 🤔

It looks llike we are good to go based on the comparison between this branch with the latest branch:  https://gist.github.com/XinruZhang/8a631aaa69457d53b96ce71ca1d5c428

It looks llike we are good to go based on the comparison between this branch with the latest branch: https://gist.github.com/XinruZhang/8a631aaa69457d53b96ce71ca1d5c428

Cherrypick PR #6031 and #5737? Any other PRs I am missing to cherrypick?

It looks llike we are good to go based on the comparison between this branch with the latest branch: https://gist.github.com/XinruZhang/8a631aaa69457d53b96ce71ca1d5c428

oh no, the gist has many more changes 😞 but the larger results was introduced in 0.43 which does not need to be cherrypicked. Also, we do need to cherrypick one more PR - https://github.com/tektoncd/pipeline/pull/5726

So to make 0.41 releasable, we need to cherrypick the following PRs:

https://github.com/tektoncd/pipeline/pull/5726
https://github.com/tektoncd/pipeline/pull/5737
https://github.com/tektoncd/pipeline/pull/6031

Please correct me if I am wrong or add anything I am missing.

I wonder do we need to run pull-tekton-pipeline-beta-integration-tests for the releases before v0.43.x

I wonder do we need to run pull-tekton-pipeline-beta-integration-tests for the releases before v0.43.x? Because this is introduced tektoncd/plumbing#1256 for testing beta features after V1 CRDs are released.
cc @tektoncd/core-collaborators @lbernick @JeromeJu

I think that we should not what it does should be only for those integration tests that require beta gates, so should not be a problem even if it is ran against them 🤔

Yup, I have been trying to see if it's possible to disable beta integration tests before 0.43 (or the release when v1 CRDs were introduced). There should not be any harm in running beta but its equivalent to running pull-tekton-pipeline-integration-tests and does not add any value. 0.41 is LTS which makes it crucial to have a working CI for that branch. I will cherrypick those three PRs and we can take it from there. Thoughts?

Yup, I have been trying to see if it's possible to disable beta integration tests before 0.43 (or the release when v1 CRDs were introduced). There should not be any harm in running beta but its equivalent to running pull-tekton-pipeline-integration-tests and does not add any value. 0.41 is LTS which makes it crucial to have a working CI for that branch. I will cherrypick those three PRs and we can take it from there. Thoughts?

SGTM! Thank you @pritidesai !

Hey @JeromeJu @XinruZhang @vdemeester @lbernick, I have a separate PR opened to fix the CI failure for the release-v0.41.x branch: https://github.com/tektoncd/pipeline/pull/6213
The beta tests succeeded in that PR, hoping to see the rest of the checks succeed as well 🤞

/retest


RequestLogger works weird with concurrency >= 2 and CDP

What is your Scenario?
Trying to log the requests using RequestLogger and from time to time it shows incorrect data. I'm not able to reproduce the issue with concurrency = 1.
What is the Current behavior?
It does not log the correct requests.
I get the following error
1) TypeError: Cannot read properties of undefined (reading 'response')
I do log ne
What is the Expected behavior?
It have to
What is your public website URL? (or attach your complete example)
Sent the details to the<EMAIL_ADDRESS>What is your TestCafe test code?
Sent the details to the<EMAIL_ADDRESS>Your complete configuration file
const requestLogger = require("./tests/requestLogger");

module.exports = {
    screenshots: {
        path: "./artifacts/screenshots",
        takeOnFails: true,
        pathPattern: "${DATE}_${TIME}/${TEST}/${FILE_INDEX}_${QUARANTINE_ATTEMPT}.png",
        thumbnails: false
    },
    disableMultipleWindows: true,
    browsers: "chrome:headless",
    concurrency: 1,
    skipJsErrors: true,
    pageLoadTimeout: 40000,
    pageRequestTimeout: 45000,
    selectorTimeout: 15000,
    quarantineMode: false,
    hooks: {
        request: requestLogger,
    },
    disableNativeAutomation: false,

}

Your complete test report
No response
Screenshots
No response
Steps to Reproduce
Run the tests which I send to<EMAIL_ADDRESS>TestCafe version
3.3.0-rc.1
Node.js version
v18.17.0
Command-line arguments
npx testcafe
Browser name(s) and version(s)
No response
Platform(s) and version(s)
No response
Other
No response

When do you plan to release the fix?

At present, we can't give you an exact date as to when the next version will be released.

but, it's a critical issue.... at least by my opinion...

We consider this issue important. That's why we tried to fix it as soon as possible. However, we cannot consider it critical because it does not affect a really big number of users. It is not a security issue, and it is not a crash. We still do not have the date of the next release. However, we usually try to release a new version every three/four weeks, so I hope it will be soon enough.

@vasilyevi
We are still working on the new version. I hope it will be ready soon. However, I cannot give you the exact time frames.


Taking into account fully qualified image URLs

You can specify the image as $REGISTRY/$NS/$IMAGE:$TAG but you can
also specify an image as $REGISTRY/$NS/$IMAGE@$SHA_ALGO:$SHA_STR e.g.
how they are set in release.txt: "Pull From: $IMAGE"
If the image is fully qualified then there will be an @ character in
the URL, if that happens then there is no need to re-inspect the image
to get the signature.

@arjuhe do you think there are more changes needed here?


Using create_database_nat_gateway_route=false still creates the NAT GW route in DB RT

Description
When using the flag create_database_nat_gateway_route = false I was expecting that the database subnets to not have a <IP_ADDRESS>/0 route to a NAT GW.
Versions

Module version: v3.4.12

Terraform version: v1.1.9

Provider version(s):

provider registry.terraform.io/hashicorp/aws v4.22.0

Reproduction Code
module "vpc" {
  source = "terraform-aws-modules/vpc/aws"

  cidr = "<IP_ADDRESS>/16"

  azs              = ["us-east-1a", "us-east-1b"]
  private_subnets  = ["<IP_ADDRESS>/24", "<IP_ADDRESS>/24"]
  public_subnets   = ["<IP_ADDRESS>/24", "<IP_ADDRESS>/24"]
  database_subnets = ["<IP_ADDRESS>/24", "<IP_ADDRESS>/24"]

  enable_nat_gateway                = true
  enable_vpn_gateway                = false
  enable_dns_hostnames              = true
  enable_dns_support                = true

  create_database_nat_gateway_route = false
  create_database_internet_gateway_route = false

Steps to reproduce the behavior:
Just execute the TF code above.
Expected behavior
When using the flag create_database_nat_gateway_route = false I was expecting that the database subnets to not have a route to a NAT GW.
Actual behavior
The database subnets route tables have a route to the NAT GW.
By not specifiying create_database_subnet_route_table=true, the db subnet is being associated with a private route table which has NAT GW route rule.
This might just be a question of adding the use case to the documentation? Or a improvement needed in https://github.com/terraform-aws-modules/terraform-aws-vpc/blob/master/main.tf#L1092

Same issue here...

Still a problem as of now.  Commenting here to remove the stale flag.

Still a problem as of now. Commenting here to remove the stale flag.


Increases clickable area for nav buttons in top bar

Description
Fixes #1700
Notes (out of scope, known isues, hints for reviewing code, ...)  (optional)
Clickable area on mobile

Clickable area (green) on desktop

Test cases

[ ] Case 1:

Given I am the usual user
When I go to this page
And I hover on nav arrow in top bar
Then I see the clickable area increased

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/enlarge-clickable-zone-for-navigation-arrows/playwright-report/index.html


Git changelogs only shows a single item

Not sure if this is the intended behaviour.
I was expecting something like a list of commit messages since the last tag or something, making it easier to write changelogs.
If single item is the intended behaviour, I'd like to offer this as a suggestion / enhancement.

Hi, @traveaston thanks for your suggestion,
you can update last version and then you can use updated output "Git changelogs"
ps:
use export _GIT_LIMIT=20 if you can change limit output


compilation issues on osx

I fist had to specify LIBS=/opt/local/lib to get configure to complete. Then I had to install the argp-standalone library, and specify "-largp" in LIBS. i also had to add the following to src/brd.h:
#ifdef __APPLE__
#  define off64_t off_t
#  define lseek64 lseek
#endif

fixed


Adds run at the clip start, infinite loop mid-clip

Script version
3.2
Describe the bug
Sometimes Adds run at the beginning of the clip
Adds mid-clip stay in an infinite loop on multiple occasions, workaround via F5
Desktop (please complete the following information):

OS: Windows 10 Pro V.10.0.19045 Build 19045
Browser: Chrome V.120.0.6099.217

Check out 3.3, This should now be fixed.
(Closed as a duplicate issue)


[Task]: Sync the conformance test branch with master

Description
$title. There are a few test failures.
Describe your task(s)
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Done in https://github.com/ballerina-platform/ballerina-spec/pull/1324 and updates to the conformance test branch.


feat: IsROrC.toStarOrderedRing as a scoped instance

With open scoped ComplexOrder, we current have StarOrderedRing Complex. With this PR, that scope puts the same order on K where IsROrC K.
There is an ongoing discussion about whether opening the scope should be required, but there is no need to address that concern simultaneously with improving behavior when the scope is already open. There also seems to be fewer downstream instance resolution issues to resolve by leaving it in the scope.

This is a more conservative version of #6210, which does not simultaneously remove the ComplexOrder scope.

bors d+

This still LGTM after the changes. Feel free to merge.

bors merge
I'm pretty confident the instance line won't make any difference


Fix sum type to double

Summary

Fix https://github.com/nifcloud/nifcloud-sdk-python/issues/67

Test

[x] Successful RDB nifty-get-metric-statistics
[x] Successful NAS get-metric-statistics

🆗 🚀


AWS RDS - StartTime and EndTime never change for all scrape requests

Hi,
I installed YACE (v0.31.0-alpha) to scrape AWS RDS metrics. My config is the following:
apiVersion: v1
kind: ConfigMap
metadata:
  name: yace-rds
data:
  config.yml: |-
    ---
    apiVersion: v1alpha1
    discovery:
      jobs:
      - type: rds
        regions:
          - eu-west-1
        enableMetricData: true
        decoupled-scraping: false
        metrics:
          - name: WriteIOPS
            statistics:
            - Average
            length: 120
            period: 60

From logs I see a very weird behavior, YACE is correctly asking AWS API each 300s (default value for scrape-interval) but interval of data is always the same, as you can see bellow EndTime and StartTime:
First API request:
2021/09/29 16:54:05 DEBUG: Request monitoring/GetMetricData Details:
Action=GetMetricData&EndTime=2021-09-29T16%3A50%3A00Z&MetricDataQueries.member.1.Id=id_5577006791947...StartTime=2021-09-29T16%3A48%3A00Z&Version=2010-08-01

then 300s after new API Request
2021/09/29 16:59:06 DEBUG: Request monitoring/GetMetricData Details:
Action=GetMetricData&EndTime=2021-09-29T16%3A50%3A00Z&MetricDataQueries.member.1.Id=id_5465989353755...StartTime=2021-09-29T16%3A48%3A00Z&Version=2010-08-01

Then 300s after new API Request
2021/09/29 17:04:06 DEBUG: Request monitoring/GetMetricData Details:
Action=GetMetricData&EndTime=2021-09-29T16%3A50%3A00Z&MetricDataQueries.member.1.Id=id_6100275367158...StartTime=2021-09-29T16%3A48%3A00Z&Version=2010-08-01

and so on.
On Response I see always the same result, this:
      <member>
        <Timestamps>
          <member>2021-09-29T16:49:00Z</member>
          <member>2021-09-29T16:48:00Z</member>
        </Timestamps>
        <Values>
          <member>1.500175020419049</member>
          <member>1.433428895259684</member>
        </Values>
        <Label>my-rds WriteIOPS</Label>

Can this be related with the fact that period=60s and length=120s?
Thanks.

I think it should only effect the first 5 minutes and afterwards this should be fixed.
This is to avoid gaps in prometheus. Currently refactoring parts of it but I need to double check if I do not break
more things then I repair.

Hi @thomaspeitz, thanks for replying. This behaviour is happening always (not only first 5min). Let me know if you need me to do any additional test to help on this debug.

Hi @thomaspeitz I tested with previous version (v0.29.0-alpha) and here its not happening this behaviour.

Thanks this is a good hint.

@tru-cstavares  I recollect we ran into a similar issue if the length was less than scrape interval  I thought I had a check-in for it.
Hi @thomaspeitz  seems during code refactoring we have caused the regression.  I don't seem to find a reference to the these code lines.


[stable/fluent-bit] Update fluent-bit to 1.0.6

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md

/assign @kfox1111

/lgtm


feat: support custom style for middleware layout selector

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 6.49%. Comparing base (6cbf767) to head (e2eaa25).
Report is 131 commits behind head on main.

Files
Patch %
Lines

...ckages/core/src/middleware/layout-selector/util.ts
0.00%
18 Missing :warning:

...kages/core/src/middleware/layout-selector/index.ts
0.00%
6 Missing :warning:

packages/idraw/src/config.ts
0.00%
2 Missing and 1 partial :warning:

packages/idraw/src/mode.ts
0.00%
3 Missing :warning:

packages/figma/src/figma-node/node.ts
0.00%
1 Missing and 1 partial :warning:

...ages/core/src/middleware/layout-selector/config.ts
0.00%
1 Missing :warning:

packages/figma/src/figma-object/index.ts
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #333      +/-   ##
========================================
+ Coverage   6.47%   6.49%   +0.01%
========================================
  Files        108     108
  Lines       6976    6960      -16
  Branches    1388    1381       -7
========================================
  Hits         452     452
+ Misses      5193    5184       -9
+ Partials    1331    1324       -7

Flag
Coverage Δ

unittests
6.49% <0.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


inconsistent values returned in 'playback-track-changed' event when skipping and finishing tracks

Configuration
System:
OS: macOS Mojave 10.14.6
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 984.05 MB / 32.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 13.1.0 - /usr/local/bin/node
npm: 6.13.3 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 28, 29
Build Tools: 28.0.3, 29.0.2
System Images: android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.5 AI-191.8<IP_ADDRESS>77832
Xcode: 11.3.1/11C504 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: ^0.61.5 => 0.61.5
using react-native-track-player 1.18 with few patches from pull requests
Issue
When listening to playback-track-changed in iOS in two scenarios the parameters means different things:

when skipping to a different track: track - current track, nextTrack - the track that will start play
when finishing the track and continuing to the next one: track - newly played track, nextTrack the next track in the queue

not sure if the same applies to android as well.

In android the behaviour is different.
in both cases: track - current track, nextTrack - the track that will start play

after upgrading to 1.2.2 I don't experience this anymore. seems fixed


Link to CSV missing

[Enter feedback here]
The link to the CSV is missing,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 705f89ed-97f2-cb71-28f7-c35f55cce879
Version Independent ID: c6b41e73-0db7-89ff-59cb-84d51df02394
Content: Migrating from Box to Microsoft 365 - Migrate to SharePoint and OneDrive
Content Source: migration/mover-box-to-o365.md
Service: sharepoint-online
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

Adding in all the migration paths into the CSV as examples would be helpful,
Source Path,Destination Path,Tags
user1@example.com,user__1@corp.example.com,"Pilot, IT"
user2@example.com,user__2@corp.example.com,"Pilot, Sales"
<EMAIL_ADDRESS>dir,user3@example.com/migrated,"Pilot, IT"
Source Shared<EMAIL_ADDRESS>Folder,"Pilot, Sales"
https://TENANT02.sharepoint.com/sites/SiteName/Shared Documents,user5@example.com,"Marketing, Sales"

@Silversurfer79 Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hello @Silversurfer79 How are you?
The article you opened the issue for as been replaced, you can find more information here
https://docs.microsoft.com/en-us/sharepointmigration/mover-box
https://docs.microsoft.com/en-us/sharepointmigration/mover-create-migration-csv
content index https://docs.microsoft.com/en-us/sharepointmigration/mover-plan-migration
Hope this helps you,

@Silversurfer79  Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Plugins - Update documentation after major refactor

Recent plugin refactor has changed the plugin interface.

@matmair this one really needs to be addressed before we can release the docs for 0.7.0 - can you jump on this?


strictBounds preventing updates to nodes that are inViewPort

I have an element InViewPort and tried changing the color and it didn't update. I had to set strictBounds=false and then it updated the color. All the parent nodes are also inViewPort. It didn't update the color until I set the strictBounds to false

Hmmm. I'm not sure why nodes aren't updating. I disabled strictBounds globally as well and still didn't update. When I toggle strictBounds on the node it then triggers an update.

PS - I think the same thing is happening with Alpha - in some cases it's failing to update the nodes properly

OK - looks like the renderer doesn't update the isRenderable on the coreNode when the color changes. So with 0 the isRenderable is false and then when you change it it doesn't update isRenderable to true


draft for v1.0 [PyPI release]

Potentially, version 1.0 of survshap could be published as a separate package on PyPI.
What needs to be done?

[ ] adding unit tests
[ ] adding missing and refactoring existing documentation
[ ] adding a notebook (vignette) other than experiments with an use case
[ ] #17

Adding at least 1 unit test is mandatory if you want to encourage contributions. For example, if I want to add an Approximate Shapley , how to be sure I did not break the Exact version ?
Creating a PyPi  file is well documented : https://packaging.python.org/en/latest/tutorials/packaging-projects/


Add Countdown Timer

Countdown to Close Presale & Airdrop

Closed in https://github.com/kamawinga/lol/commit/586b55864532358a033db6b2ef3e243903e7ccb4


Include remaining inventory and err-code in error response if purchase fails due to insufficient inventory

for example:
{
  reason: "not enough inventory",
  code: "ERR_INSUFFICIENT_INVENTORY", // allows us to show a translatable message
  remainingInventory: "100", // allows us to update the UI so the user can't enter a value above 100 just to have it fail on the server
}

So this should really only apply to online nodes. If we have to fetch the inventory for offline nodes on each offline purchase, it will double the amount of time it will take to complete an offline purchase... which is already takes upwards of 30 seconds to fetch the peerinfo from the DHT and attempt connection on each address.

So this should really only apply to online nodes.

ok, I don't have a strong opinion on that. But, I think it should apply any time you are failing the purchase because of insufficient inventory. If that's only on online orders, so be it.


German translation fixes in security form

Description
Fixed some German translation in de.json5.
Instructions for Reviewers
List of changes in this PR:

some translation keys were added
some obsolete translation keys which are not present in en.json5 were removed

Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[ ] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[ ] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[ ] If my PR fixes an issue ticket, I've linked them together.

Additionally, the default minimum password length was changed to 8 characters with commit https://github.com/DSpace/DSpace/commit/a31bb4bf6198fa6abaa918edd9368a7fb43f75b7. We should better remove the length value in translated messages.


setInterval with delay 0 runs indefinitely, other scheduled tasks never execute

FakeTimers version : 14.0.0
Environment : node (standalone and used as part of jest fake timers)
Example URL : reproduction repo
Other libraries you are using: Not necessary to reproduce, but issue is worse when used with jest and react testing library

What did you expect to happen?
If an interval and multiple timers are all scheduled to execute at the same time, I would expect all of them to execute once, prior to intervals executing again
What actually happens
The interval with a delay of 0 runs repeatedly, and timeouts that are due to run are never executed.
This is especially problematic when used in conjunction with jest and react testing library.
RTL's waitFor method, when used with fake timers, relies on calling an immediate setTimeout and the advancing timers by 0.
If the code under test uses a setInterval with a delay of 0, the test hangs forever. The spec in the reproduction repo demonstrates this without the use of RTL.
How to reproduce
The following code using fake timers
const FakeTimers = require("@sinonjs/fake-timers");

var clock = FakeTimers.install();

let intervalCount = 0;
const intervalId = setInterval(() => {
  console.log("interval");
  if (++intervalCount > 4) {
    clearInterval(intervalId);
  }
}, 0);
setTimeout(() => console.log("timeout"), 0);

clock.tick(0);

prints
interval
interval
interval
interval
interval
timeout

An example without fake timers, such as
let intervalCount = 0;
const intervalId = setInterval(() => {
  console.log("interval");
  if (intervalCount++ > 4) {
    clearInterval(intervalId);
  }
}, 0);

setTimeout(() => console.log("timeout"), 0);

prints
interval
timeout
interval
interval
interval
interval
interval

Additional Information
In debugging this, it seems that the issue is that when intervals are executed, their callAt time is adjusted by the interval, but their position in the list of timers is not adjusted, so the interval continues to be the first timer to run.
https://github.com/sinonjs/fake-timers/blob/48f089fdc830e39fcec31dd23099cc360da0bab2/src/fake-timers-src.js#L794

Excellent report! Thanks for taking the time. This seems doable, but not in the immediate future. Unless you can see a quick fix (which it seemed lik you did) and can supply a PR, I can only say I'll have a look at this in the start of January. Bit busy now just before X-mas :)

I started working on this last night, moving our current hashmap approach into one using lists instead. The idea being that I could then pop a timer of the list for the current time and add it to the end of a (sub)list to avoid the issue above. Before getting to fixing that, I first need to get to feature parity with the current approach - basically making the test suite pass. I got mosts of the internal tests to work, but pretty much all the /tests/issue*.js tests still breaks, so still some more work to do. I could not immediately see what was wrong, so if anyone has some time to have a look, it's here:
https://github.com/sinonjs/fake-timers/tree/522-tasks-not-adjusted-on-settimeout-0


Clear vCenter VM extraConfig attributes

Description
This is needed to perform a clean --delete-db of a VM and reimport it again as a Wild VM
Use case
Refresh OpenNebula representation of a VM
Interface Changes
Add subcommand to onevcenter

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Code: 600e6cd95d541f781bec7a2576e089de0a554738
Documentation: https://github.com/OpenNebula/docs/commit/a765615600b857a7fb771307a0fd177ac14d607f


Generate Synthetic data for object detection

Script Title - Generate Synthetic data by combining 2 images for object detection with boundary boxes as well
what will change -
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md in your folder for program Instructions
add requirements.txt if needed
add pytest/unittest if possible

Please add/delete options that are not relevant.

[x] Adding New Code
[x] Improving Documentation

Programming Language

[x] Python

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server  - https://discord.gg/FXyh2S3
Happy Coding,

PR Merged, Closing the issue now.


Enable text, lines, and json to pull from stderr or combined buffers

There's been a few times where I've needed to grab info from stderr and the ergonomics of doing so are much worse than stdout given the lack of helpers for it. I've updated some of the original helpers for stdout to also optionally be used for stderr or both streams combined.
There's probably a few more tests to write here and I may have missed something.
Let me know what you think!

If there's anything I should update let me know!