Feat/5463 mr new design refactor

closes: https://issues.redhat.com/browse/RHOAIENG-5463
Description
several design changes
new emptystate images:

breadcrumbs/titles/icons:

model location parts

with uri

view details is back

on archived as well

How Has This Been Tested?
locally, mr cluster
Test Impact
updated tests where necessary
Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[x] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

Hi @gitdallas, thanks for all the updates! It looks good! Just several comments -
Regarding the empty state of the versions table, it looks like the spacing above and below the image is larger than on other screens. I just checked the source file, and it turns out the white spaces of the source image are bigger than in other images... My apologies for that. I'll follow up with the visual designer and see if we can get an image with less white space to you by Tuesday.
Regarding the model location,

I can't see how the long text behaves from the screenshots. Just a quick reminder that the text should be truncated by one line if it exceeds the container length.

For the S3 type of model location, would it be possible to group 'endpoint, region, bucket, and path' all under a single 'Model Location' section and assign the group a smaller spacing value? That would help clearly distinguish it from the following attributes and make the grouping more apparent. Check the mockup here.

@gitdallas checking the model location fields, if the text is longer than the container width it does wrap to multiple lines instead of truncating:

I was looking at the ClipboardCopy component docs though, and I don't think there's a way to make the inline variant truncate to one line. We could instead switch to the expandable variant, but it might be overkill if these values will usually fit on one line. What do you think @yih-wang ? I'm thinking maybe if there's no quick solution here we should create a post-MVP issue to follow up on this.

@mturley - would something like this be okay? little hacky and you gotta override the oncopy https://codesandbox.io/p/sandbox/red-wind-zdgyqf?file=%2Findex.js%3A20%2C37

Oh, interesting... yeah @gitdallas I think that solution looks good to me. I wonder if we should open an issue with PF to propose adding a prop or other variant for this, like inline-compact-truncate or something. Maybe for now let's factor out a. ClipboardCopyInlineTruncate component in src/components (or whatever you want to name it) and let's put a comment on that inline style line explaining that it's a workaround.

@yih-wang - regarding the "smaller spacing", that feels off to me personally and i don't really notice it myself... if i do, it just seems like some sort of accident. if it's what is decided on, i can do it.
seems sort of like it might make sense to do a left margin, similar to how form sections work. although being a split screen already it's a bit low on horizontal space.

@gitdallas thanks for sharing your thoughts! I had the same worry before about whether it was clear enough to group things in different spaces. Seems it definitely needs better ways to convey that. I'd like to think more about this so let's keep it as is. We have another post-MVP issue to add another new field 'source model format version' on this page and we can address this layout enhancement with that together.

@yih-wang - with truncated clipboard copy:


Home

Before merging this, could we remove the .env file so its not committed to main? Should be .gitignored so may just need to redo the PR and it will be hidden.


tio: 2.8 -> 3.5; migrate to by-name and modernize

Description of changes

Update to 3.5
Modernize by

using finalAttrs over rec
moving to pkgs/by-name
formatting using nixfmt

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4286

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 328294 run on x86_64-linux 1

1 package built:

tio

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 328294 run on aarch64-darwin 1

1 package built:

tio

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1843

Thanks for the review and approval, @gador, much appreciated 🙂

Thanks for merging this, @marcusramberg, much appreciated 🎉

Thanks for merging this, @marcusramberg, much appreciated 🎉

Thanks for the contribution 🙂


Automated cherry pick of #11442

Cherry pick of #11442 on release-7.5.
/cc  @ConorMacpherson
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 7d114a2d30d6b0f244ac0c1ff7ce5887e41b5584


Type error in Verifying FIDO2 Challenge Response

When attempting to sign in using the passkey stored in the AuthenticatorsTable in the following format and algorithm RS256, a TypeError occurs.
  "jwk": {
    "M": {
      "alg": {
        "S": "RS256"
      },
      "e": {
        "B": "AQAB"
      },
      "kty": {
        "S": "RSA"
      },
      "n": {
        "B": "{omission}"
      }
    }
  },

Use Library Version: v0.13.1
and we confirm that this issue is observed in the following device:

Device: Surface Laptop 5
OS: Windows11 (23H2)
Passkey Store: Windows Hello

The traceback is as follows:
TypeError [ERR_INVALID_ARG_TYPE]: The "key.n" property must be of type string. Received an instance of Uint8Array
    at new NodeError (node:internal/errors:405:5)
    at validateString (node:internal/validators:162:11)
    at getKeyObjectHandleFromJwk (node:internal/crypto/keys:497:3)
    at prepareAsymmetricKey (node:internal/crypto/keys:549:22)
    at createPublicKey (node:internal/crypto/keys:613:5)
    at verifyChallenge (file:///var/task/index.mjs:177:96)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async addChallengeVerificationResultToEvent (file:///var/task/index.mjs:114:5)
    at async Runtime.handler (file:///var/task/index.mjs:1713:7) {
  code: 'ERR_INVALID_ARG_TYPE'
}

We specified only RS256 as the allowed algorithm at this line, but it seems that there are terminals where it is successfully saved as a base64url string on DynamoDB.
https://github.com/aws-samples/amazon-cognito-passwordless-auth/blob/main/cdk/custom-auth/fido2-credentials-api.ts#L67

If it's acceptable to directly address the point of error, you may want to insert the following code to rectify the issue.
https://github.com/aws-samples/amazon-cognito-passwordless-auth/blob/main/cdk/custom-auth/fido2.ts#L356:L358
  if(storedCredential.jwk.n instanceof Uint8Array) {
    storedCredential.jwk.n = Buffer.from(storedCredential.jwk.n).toString('base64url');
  }
  if(storedCredential.jwk.e instanceof Uint8Array) {
    storedCredential.jwk.e = Buffer.from(storedCredential.jwk.e).toString('base64url');
  }

Hi mate!
This should have been fixed in https://github.com/aws-samples/amazon-cognito-passwordless-auth/pull/148/files
So that is since https://github.com/aws-samples/amazon-cognito-passwordless-auth/releases/tag/v0.12.2
What version are you on?
But you're right that that fix stops new cases from arising, but for existing records in the DB you'd need code similar to yours or do a one time DB fix: update records when n and e are stored as bindary and base64url them

Thank you for answering!

but for existing records in the DB you'd need code similar to yours or do a one time DB fix: update records when n and e are stored as bindary and base64url them

Certainly, the credentials mentioned in the issue may have been created at the time of v0.10.0
I also reviewed that PR, but I overlooked the impact on existing records... X(
Given the responsibilities of this repository, we believe there is no need to be overly sensitive to backward compatibility.
Or should I create a PR?
If it's not necessary, I will close this issue after confirming its operation.

Ok thanks for the confirmation
Agreed, don't think a PR is necessary.
Thanks for reporting anyway!


Automatic logout - reset

Please check if we support automatic-logout (e.g. after an application connection timeout).
In this case, the server pushes a refresh and the response of the refresh request will return the Login View.
It should be guaranteed that the client clears all caches, like in case of a manual logout.

Just tested with <Application.connection.timeout>1</Application.connection.timeout>, I'm getting logged out, and I'm calling the reset function of my contentstore.


fix: Add missing option for adding Device Camera

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/developer-scripts/blob/master/.github/Contributing.md.
What is the current behavior?
No option to build custom compose with Device Camera included
Issue Number: #344
What is the new behavior?
ds-camera option now available to build custom compose with Device Camera included
Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information

recheck


Fix regression for optional JSDoc types which throws TS2463 in typescript@next

Bug Report

🔎 Search Terms

optional jsdoc regression
🕗 Version & Regression Information
This started occurring in nightly after #50094 was merged to fix #49869 and still happens (see these cron job type checks in pony-cause which retests against nightly three times a week).
This does not happen in 4.8 beta

This changed between versions 4.8-beta and nightly

⏯ Playground Link

Since the Playground is for TS code, not JS code, here's a link to a piece of code: https://github.com/voxpelli/pony-cause/blob/4009048a41d772cb29673f1c45cc55e9717e523f/lib/error-with-cause.js#L5-L9
And more in this thread: https://github.com/voxpelli/pony-cause/issues/45
💻 Code

   /**
    * @param {{ cause?: string }} [options]
    */
   function foo ({ cause } = {}) {

🙁 Actual behavior
Explicitly specifying the options as  optional ([options] )  causes this error as it is already implicitly marked as optional by having been set a default value ({ cause } = {}):
error TS2463: A binding pattern parameter cannot be optional in an implementation signature.

🙂 Expected behavior
One of:

Preferably that TypeScript keep accepting arguments that's been explicitly marked as optional, even if that is redundant
At least change the error message to something that makes more sense in a JSDoc context than "A binding pattern parameter cannot be optional in an implementation signature."

See more in this thread: https://github.com/voxpelli/pony-cause/issues/45 and in https://github.com/microsoft/TypeScript/pull/50094#issuecomment-1201502045, where @sandersn said that he is in favor the current new behavior.

Seems like this is actually affecting TS 4.8.2

Any update on this?

Here is a TS playground link showing it's still a problem in 4.9.0-dev.20220921 (Nightly). Also 4.8.2, and not 4.7.4.


Trying to Create Custom Jython

Hello,
I'm trying to utilize the UserScript component of DocGen, so I've created a stereotype that extends UserScript, and a .py file by the same name as my stereotype to compile when the document is generated. I've been able to run scripts, so I know my python script is set up appropriately. However, it seems like in order to write to the DocGen report, the script requires the function DBParagraph, which is located in gov.nasa.jpl.mgss.docgen.docbook. Is this package available so we can run UserScripts?
Thanks.

if you're using the zip uploaded in the past month, go into plugins/gov.nasa.jpl.mbee.docgen/ and set the ownClassloader attribute in plugin.xml to false instead of true. this should restore the use of userscripts, but may generate errors when using ocl

to use both, you'll need to replace the ocl libs in magicdraw's lib folder with the ones from this repo, and edit bin/magicdraw.properties's classpath to include the updated libs accordingly.

Unfortunately, the first step you suggested did not work. The second step crashed my MagicDraw, so I reinstalled, at which point I couldn't even get scripts to run at all through MagicDraw now. There are 7 ocl jar files in the CSM 18.1 lib, and there are 4 in your repo. Are you suggesting that I delete all 7 of CSM's ocl jars now and replace them with just the 4 in your repo? Is there another way I can get DBParagraph?

try just taking out any ocl reference in our plugin.xml (so you won't be able to use ocl for docgen) and make ownClassloader false. (the second step was assuming you're using md 18.0, the replacement jars just replace their corresponding jar in md's lib, not all of them)

I've made these changes and DocGen is working with its internal commands (like it has all along), but I still can't generate from my Python script. Plus, I'm one step back from where I was at the beginning because at that point, I could establish a connection between a stereotyped action and its corresponding Python script. I can no longer establish that connection, let alone generate text from my Python code.

can you check the import is gov.nasa.jpl.mgss.mbee.docgen.docbook (your first comment is missing mbee)
just tested the following on magicdraw 18.0 sp4 and should work:
put ownClassloader as false and comment out ocl lib imports in plugin.xml

So here are the steps I've tried on both Cameo Systems Modeler 18.0 SP2 and Cameo Systems Modeler 18.1:

Download the zip file docgen-18.0.zip.
In CSM, under Resource/Plugin Manager, click Import to import docgen-18.0.zip. Restart CSM.
In /plugins/gov.nasa.jpl.mbee.docgen/plugin.xml, change ownClassloader to false. When this doesn't work, go back in and comment out ocl lib imports.
In the model, create a stereotype <<Test.MakeParagraph>> that extends UserScript. The reason I chose this is because there is already a MakeParagraph.py test script in /DocGenUserScripts/Test that is supposed to print "Hello World".
Create a document, view, and viewpoint. The for the viewpoint method diagram attached to the viewpoint, create an "other" activity and apply the <<Test.MakeParagraph>> stereotype. Give it a beginning and ending node.
From the document element, generate the report. I assume at this point, "Hello World" is supposed to be written to my script. It isn't.
I tried changing the working directory to my Python script, but that didn't fix the problem either.

I'm not sure if this is the problem of finding the DBParagraph (which is located, according to MakeParagraph.py, in gov.nasa.jpl.mgss.mbee.docgen.docbook, as you said), if I am expecting the wrong output, or if something else is going on here. Also, I was originally able to run scripts from MakeParagraph.py, such as generating pop-up windows, so I knew DocGen was at least reading my scripts, but now I can't even duplicate that, so I'm not even sure DocGen is still reading the scripts. Either way, I have not yet had success using Python UserScripts to write to my xml documents and am hoping this list of steps I took will help identify why that isn't happening.

can you attach screenshots showing your activity model and custom stereotype hookups, your steps all look right, the only thing i can think of is maybe a typo in your stereotype (name should be "Test.MakeParagraph"), or there's some differences between plain magicdraw and csm (docgen hasn't been tested on csm variant), but you mentioned you've been able to run from it before, so that's unlikely

The first screenshot shows my View Diagram. The second screenshot shows the Viewpoint Method Diagram for my second viewpoint, Bulk Document Viewpoint. The second screenshot also shows part of the specification for the Test.MakeParagraph stereotype.
The first time I was able to get a connection between CSM and DocGen userscripts was when I was using a version of DocGen that a colleague had packaged to better interact with our version of CSM. The second time, when I was not able to establish that connection, was when I was using the DocGen zip file from your site that was uploaded a few weeks back. Therefore, I wouldn't be surprised if the issue is the packaging for CSM vs. MagicDraw.

turns out the MakeParagraph example is slightly wrong, you'll need to put
scriptOutput = {'DocGenOutput': [DBParagraph("hello world")]}
the DocGenTest.py has a better example (comment out references to sproperty)

That did it! Thank you so much for all of the assistance.

So I have been able to link my model and DocGen to my python scripts, but is there any additional documentation on the UserScripts other than the last few pages of the user manual? I am having luck with the directives getName() and getOwner(), but I am not having luck getting element type (such as block, use case, etc.) or with getStereotype(). Additionally, I am not having luck with the Collect/Filter UserScript example in 3.8.2 of the manual. If there are other locations where I can look for resolutions, or additional capabilities and directives for the UserScripts, I would love to be pointed in those directions. Thanks!

the elements being passed in are magicdraw's java api elements, so you can use md's openapi/javadoc for available methods

I assumed that was the case, but using elt.getName() and using the api made me think that elt.getDocumentation() would work as well. Unfortunately, it does not. Maybe I am using api incorrectly; otherwise, please let me know how I can resolve this. Thanks.

for documentation, use com.nomagic.uml2.ext.jmi.helpers.ModelHelper.getComment(element), for working with stereotypes and tagged values, use com.nomagic.uml2.ext.jmi.helpers.StereotypesHelper

Thanks, this has been so helpful. I noticed in your DocGen manual that the only way to expose a diagram is to use a special diagram view. This brings up a few questions:

I have a package containing many use cases, each of which contains an interaction, and then each of which contains a diagram. If I want to display all of those diagrams, do I have to manually expose each diagram, each with its own diagram view?
If I want to display the use case documentation before each diagram, is there a way to intersperse the view from the use case's documentation with the view from the diagram, or does the view exposing the use case documentation have to come wholly before the diagram view?
If I decide to do this with UserScripts, I believe the proper call to display a diagram is diagram.getDiagramPresentationElement. Do I feed this into the output array? If so, does it then get fed into DBParagraph, or is there another way to display it?

Thanks,
Julie

the diagram view is only a shortcut (if a view exposes a diagram and have no viewpoint, it'll print the diagram)
with a viewpoint, you can expose the package with the use cases, and do something like the following:

collect and filter the use cases
make a structured query that loops through the use cases, inside the structured query, use a paragraph action to print the use case documentation, then collect and filter your way to the use case diagram, use diagram action to print the diagram (with loop, the 'context' for the structure query would be a single use case)

in script, there's also a DBImage that takes a md diagram object
https://github.com/Open-MBEE/MDK/blob/2.2/src/main/java/gov/nasa/jpl/mgss/mbee/docgen/docbook/DBImage.java

Thanks. When I do output.append(DBImage(dia)), the diagram is printed twice, once as an SVG, and once as a PNG. The same thing happens when I expose the diagram using an <> action on a viewpoint diagram. Is there a way to prevent both from being printed?
Slightly unrelated, in my document block, I removed JPL's name as well is its distribution statements from the legal notices and other attributes, but that information still shows up on my document. Is it stored in an xml file somewhere where I can remove that information?
Thanks.

One other question in the meantime...I am trying to use a Python package docx in my user script. Where would be the proper place to store this package so the DocGen UserScript can find it?
Thanks,
Julie

for image being printed twice, it's not really twice since one is for html and one is for pdf transform, so if you use oxygen or docbook stylesheets it should use only one of them
the legal info can be deleted from the generated docbook xml file, it should be near the top, (it may be using the default values in the profile if they're not filled in, so you can also delete them from the stereotype in the profile)
you may be able to drop the package as a module either in the same directory as the userscript, at the DocGenUserscript directory, or in the python modules directory under plugins/com.nomagic.magicdraw.jpython/jython/Lib


Edit policy configuration

When editting an existing policy, it's impossible to change the Assigned group to another group. If this is intended behaviour might want to update the docs with that info.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dfa63a94-daaa-9491-213e-f0329f6299b1
Version Independent ID: 47fe5a3a-ee7c-a7f7-b913-ca0ac3c063e0
Content: Overview of the Office cloud policy service for Office 365 ProPlus
Content Source: DeployOffice/overview-office-cloud-policy-service.md
Service: o365-proplus-itpro
GitHub Login: @jwhit-MSFT
Microsoft Alias: jwhit

Thank you for the feedback.  This is behavior that is part of the initial design.  Currently you can create a copy of a policy configuration and edit the new copy to change targeting of groups.  For our next feature update we are working on improvements to the group targeting functionality to make this easier.


Log Errors, Skipped, and Discovery separate from Job Log

Which version of the AzCopy was used?
AzCopy V10
Note: The version is visible when running AzCopy without any argument
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
Azcopy copy
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
Genearated the exact command through Storage Explorer
What problem was encountered?
Feature Request
How can we reproduce the problem in the simplest way?
Create a job that has existing files, or write permissions issues. Generate several UPLOADFAILED log entries.
Have you found a mitigation/solution?
Parsing the Job Log Using Powershell
Scenario:
In many file Migrations, it is necessary to reconcile the number of Discovered versus Successful, Failed, Skipped. Instead of parsing job log using SELECT-STRING, if we could generate a separate Log when the discovery completes, and also when the items fail. I realize this can do if we lower the log level, it would be nice to have all the information in the normal jobid.log and then the related in .error.log .discovery.log etc.

Thanks @mrisaac for the feature request! Our PM @rishabpoh will look into this scenario and get back to you shortly.

If log level is set to log-error then failure related logs will be dumped into log file and parsing that you can get list of files that failed to transfer. In addition you can resume the job again and only the files that failed to transfer will be retried. There is no need to explicitly parse them and create another job to complete what was left over.


Server crash on MC 1.20.1

This message appears right before the crash:
Suppressed: net.minecraftforge.fml.ModLoadingException: Flower Seeds 2 (flowerseeds) encountered an error during the common_setup event phase
§7java.lang.NullPointerException: Registry Object not present: flowerseeds:dandelion_seed

Using MC 1.20.1
Forge 47.2.1
Flowerseeds2-1.20.1-1.1.0

Can you please provide a full debug log usually found logs/debug.log, using one of these sites
https://gist.github.com/:      [Free] [SignUp] 100MB
https://paste.gemwire.uk/:  [Free] 10MB
https://paste.ee/:                   [Free] 1MB, [SignUp] 6MB
https://pastebin.com/:          [Free] 512KB, [SignUp] [Paid] 10MB
https://hastebin.com/:          [Free] 400KB
https://gist.github.com/:      [Free] [SignUp] 100MB

I'm very sorry, but i do not have these files anymore with the crash.
It's already overwritten.
I reported this here, removed the mod and went on with my server.
I can only say, it doesn't happen clientsided.
As far as i understand it the code wants to access flowerseeds:dandelion_seed, but it hasn't been registered. Could be misspelled or forgotten to register it...

Using MC 1.20.1
Forge 47.2.1
Flowerseeds2-1.20.1-1.1.0
and here is the debug.log: https://pastebin.com/32JeRgCW
and here the latest.log: https://pastebin.com/7HwJi4k6
Hopefully it helps.

should be fixed in latest version https://legacy.curseforge.com/minecraft/mc-mods/flower-seeds/files/4788826

crash-2023-10-30_20.16.05-client.txt
Hi ! I'm still having this crash in 1.1.2


module(panel): refactors and small fixes

This PR refactors the logic used in generating the desktop script for panels to make it more readable, and adds a lengthMode setting that allows Plasma 6 users to configure their panels' length mode.
Additionally, there was a small bug in the desktop script generation logic — if you have two consecutive single quotes in the script, the escaped sequence will produce an invalid Bash script, for whatever reason. I've changed it to use a heredoc instead, which should be much more resilient.

It appears that some command returns a non-zero exit-code in the 2_desktop_script_apply_panels.sh script leading the success variable to be set to 0 and no last_run_desktop_script_apply_panels file will be created (even though the script seems to be working just fine). I'll see if this is caused by something here or if this is a general problem.

It seems to be the read command which is the problem. I'll see if we can create a layout.js file in the data-directory and just cat that file instead.

That's done the trick :). Will merge now, thanks for this.


Option for downloading paper.

It would be great if we download the paper for the website itself instead of redirecting the client to the GitHub repo. for instance what I mean to say is described below using snapshots.

Hope you got the context.
@goyal-sidd  @yashovardhanagrawal  @nimbus1212 @punit-agarwal  any suggestions?
@yashovardhanagrawal  side-bar is missing from other pages.
here we are missing framework because if we had leveraged a framework than we could have leveraged the power of templates and here are we are violating DRY principle and reinventing the wheel.

Sure sir,
We can proceed with it. We will now have to provide a download link on the website itself.

@goyal-sidd I am creating side version of this project in angular JS. :+1:

Made 16 HTML files, 2 for each semester. Shall I pull request for all of them?
I forgot to change patch while creating files, and now ended up with many patches :/

I have improved the folder structure, but the thing of downloading papers cannot be directly done from the website unless a script is written that can trace the newly added papers and map them into a page which allows us to download the papers.
for now, the last path of downloading papers is still our GitHub repository unless someone commits that script.

@yashovardhanagrawal Well I think we can just add a GitHub link to page
It would allow us to download
Check punitagarwal.me

@punit-agarwal you might view the current system which I introduced in the latest merged PR. This is the best possible solution according to me in the current scenario.
Don't you think downloading pdf for every link would be cumbersome?

@punit-agarwal  for now let's leave it as it is we will think about it in the future.

@divyanshu-rawat What I got to know from this issue is when we will click for papers for a particular branch like CSE then it should show list of all papers on the same page and just in front of it there should be download button to download the respective paper. Am I right? If no then let me know better insights of the project in order to proceed with the issue.

Hi, @amisha2016  I am glad that you want to contribute what do you want to know about the project?

@divyanshu-rawat Thanks for your appreciation. Actually, I was trying to understand the purpose of this issue and explained in the previous message.
I can explain it in more detail now.
Currently, In master branch
When we will reach to the page http://your-ip__address/paper.lnmiit/year1/sem1/sem1.html
There are options of all branches like CSE.
After modification
In the same page it will display list of uploaded papers and just adjacent to each paper there will be download button to download paper.
So, I was just asking Am I right in understanding the issue you created.

@amisha2016  I guess you are right but It would be great if you implement the working prototype. we would be more than happy to merge it.
Thanks 👍

What formats do you accept for question papers like pdf, docx. I mean to say is there any restriction on particular type formats of question papers are accepted.

@amisha2016  @aasthasona79 @Parulshandilya can help you they both are maintainers.

@amisha2016  I guess there is no restriction pdf, docs format will work.

yes one can upload in docs format its not been checked


Community page update proposal

Hey, I just made a Pull Request!
As suggested by Jen Kelly, I'm proposing a change in the Community page to include Backstage's commercial partners. I decided to go a step further and propose a new layout/copy for the page to make it more in line with the homepage.
Might be a PR for @suuus to check out as she created the original page.

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

This was a much needed overhaul 😍. Thank you 🙏

Thanks for the review @benjdlambert !

@jorgelainfiesta think we need prettier running on some files here 🙏

@jorgelainfiesta need DCO signature for the last commit here! 🙏

@benjdlambert Weird I could read it on the commit history here, but I guess I did it wrong. I rebased with --signoff to ensure all the commits are right 🤞


how does it work?

im kind of confused how this works, do both my friends need to download the same file or does it have some sort of P2P way to send them it?

Syncplay relies on users having the same files as one another. It is not a file sharing programme, and has nothing to do with P2P.
If you all have mpv and youtube-dl it does support streaming YouTube videos.

https://www.youtube.com/watch?v=OuyYLOZBLI4 is quite a good guide on how to use Syncplay.


Taints and Tolerations

The documentation mentions
To remove the taint added by the command above, you can run:
kubectl taint nodes node1 key1=value1:NoSchedule-
However the correct command, based on my testing seems to be
kubectl taint nodes node1 key1/value1:NoSchedule-

/assign

hey pnarayanan01 can you please link the document here and where to make the changes

https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/
Under the Concepts heading, the second code snippet

I have opened a PR. #32042

@pnarayanan01 Kindly share kubernetes verson and output of kubectl describe node <your tainted node> | grep Taints
/triage needs-information

@mk46 I no longer have access to this environment. However I think the syntax isn't version dependent. Sorry, I couldn't be of more help at the moment.

I tried in minikube version: v1.18.0
Kubernetes version:
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.4", GitCommit:"e87da0bd6e03ec3fea7933c4b5263d151aafd07c", GitTreeState:"clean", BuildDate:"2021-02-18T16:12:00Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:20:00Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
and observed that

if taint by kubectl taint nodes node1 key1=value1:NoSchedule then kubectl taint nodes node1 key1=value1:NoSchedule- is valid to untaint
if taint by kubectl taint nodes node1 key1/value1:NoSchedule then kubectl taint nodes node1 key1/value1:NoSchedule- is valid to untaint

/assign


Use release namespace

What this PR does / why we need it
Related to https://github.com/giantswarm/teleport-tbot/pull/11
Checklist

[x] Update changelog in CHANGELOG.md.

@ssyno do you think it makes sense to get this one still merged?

@ssyno do you think it makes sense to get this one still merged?

I think yes let me check and I will merge


Refactor user console.log to use logger

As a backend developer, I will want to enable logging to view important information about the data transactions occurring.
Is your feature request related to a problem? Please describe.
I'm always frustrated when I can't see why something is not working and console.logs are not completely cutting it.
Describe the solution you'd like
Logs that will more accurately depict what is happening with the data.
Include link(s) to relevant tutorial(s)
https://docs.nestjs.com/techniques/logger
Describe alternatives you've considered
None.
Is this issue related to any other issues?
This issue relates to issue #19
Additional context\

Story Points
2-4 story points

Started research on the built in logging for NestJS as well as two external logging modules, Winston and Pino.


[CP] Convert the ImpellerC command line arguments to UTF-8 on Windows

Note this is a follow up to https://github.com/flutter/flutter/issues/111689, which was already merged to the RC branch. It was discovered that there was an additional issue when trying to update CI to include a unicode char in the path: https://flutter-review.googlesource.com/c/recipes/+/34140
issue_link
https://github.com/flutter/flutter/issues/107590
Commit Hash
6d0f53a33532b1c5a426776fe52afb178f8a58dd
Target
stable
pr_link
https://github.com/flutter/engine/pull/36451
Impacted Users
Flutter developers on Windows developing in non-ascii file paths
Impact Description
While building a flutter app on Windows in a file path with non-ascii characters, the tool will crash.
Workaround
Rename directory to not contain unicode characters.
Risk
low
Test Coverage
no
Validation Steps
To validate, on a Windows machine, introduce a unicode character into the project path and try to run flutter run -d windows.

This seems like it should be merged to beta and stable.  Am I wrong here?

SGTM. I'm guessing we should also include https://github.com/flutter/flutter/issues/111689

@zanderso can I get an approval for this CP?

or @chinmaygarde ?

CP lgtm

Released in https://github.com/flutter/flutter/releases/tag/3.3.3


getCurrentPose() does not verify TF2 pose information

I am working on so simple Moveit2 tutorial. I am trying to just get robot position and orientation information by using Moveit2 Script .
I am getting robot pose information by using ( getCurrentPose() method). When I tried to verify the getCurrentPose information, I found that it was inconsistent with TF information.
Your environment

ROS Distro: [|Humble|]
OS Version: e.g. Ubuntu 22.04
Binary build

Steps to reproduce
#include <moveit/move_group_interface/move_group_interface.h>

#include <geometry_msgs/msg/pose.hpp>
#include <rclcpp/rclcpp.hpp>

int main(int argc, char* argv[]) {
// Initialize ROS
rclcpp::init(argc, argv);

// Declare Node
std::shared_ptrrclcpp::Node node =
std::make_sharedrclcpp::Node("get_current_pose",
rclcpp::NodeOptions().automatically_declare_parameters_from_overrides(
true));

// We spin up a SingleThreadedExecutor for the current state monitor to get
// information about the robot's state.
rclcpp::executors::SingleThreadedExecutor executor;
executor.add_node(node);
std::thread spinner = std::thread(&executor { executor.spin(); });

// Create the MoveIt MoveGroup Interface
moveit::planning_interface::MoveGroupInterface move_group_interface =
moveit::planning_interface::MoveGroupInterface(node, "ur_manipulator");

// print current pose
geometry_msgs::msg::Pose current_pose =
move_group_interface.getCurrentPose().pose;

// Print the current pose of the end effector
RCLCPP_INFO(node->get_logger(), "Current pose: X:%f Y:%f Z:%f x:%f y:%f z:%f w:%f",
current_pose.position.x,
current_pose.position.y,
current_pose.position.z,
current_pose.orientation.x,
current_pose.orientation.y,
current_pose.orientation.z,
current_pose.orientation.w);

// Shutdown ROS
rclcpp::shutdown();
spinner.join();
return 0;
}

Expected behaviour
TF Gui Output
tool0, wrist_3_link
Position: X: 0.382871 Y:0.351937 Z:0.808952
Orientation X:-0.70715 Y:0.0057097 Z: 0.00065606 W: 0.70709
Actual behaviour
Moveit2 Output
Current pose: pos.X:0.193414 pos.Y:0.286017 pos.Z:0.546773 ori.x:-0.707120 ori.y:0.000571 ori.z:0.000656 ori.w:0.707093
Why they are different from each other between Moveit2 Console and TF in Rviz GUI ?
Backtrace or Console output
Use gist.github.com to copy-paste the console output or segfault backtrace using gdb.

You didn't specify a concrete link for getCurrentPose(). Probably MoveIt reports the pose of a different link than the one you looked up in rviz' TF. Another reason could be a different base transform. MoveIt reports poses relative to the planning frame, which is usually the robot's root link. If you introduced a virtual joint or the robot is otherwise offset w.r.t. (0,0,0), a different pose will be reported. In that case, change rviz' fixed frame to the same frame too.


Adding "yaml-cpp" to Mediapipe

How can i use yaml-cpp in Mediapipe?
After successful installation of yaml-cpp i've got /usr/local/include/yaml-cpp/ dir
with *.h-headers and /usr/local/lib/libyaml-cpp.a.
Then i ran successfully some test examples of yaml-cpp.
But when i tried running it in Mediapipe hand_tracking example like:
add this code to WORKSPACE:
new_local_repository(
    name = "linux_yaml",
    build_file = "@//third_party:yaml_cpp_linux.BUILD",
    path = "/usr/local",
)

third_party/yaml_cpp_linux.BUILD:
exports_files(["LICENSE"])
cc_library(
    name = "yaml_cpp",
    srcs = glob(
        [
            "lib/libyaml-cpp.a",
        ],
    ),
    hdrs = glob(["include/yaml_cpp/*.h"]),
    includes = ["include/yaml_cpp/"],
    linkopts = [
       "-lyaml-cpp",
    ],
    linkstatic = 1,
    visibility = ["//visibility:public"],
)

Add to demo_run_graph_main.cc code that i was successfully running in previous:
...
#include <yaml-cpp/yaml.h>
...

std::ifstream fin_undistor("utils//undistort//calibr.yaml");
YAML::Node doc_undistor = YAML::Load(fin_undistor);

cv::Mat cameraMatrix = cv::Mat(3,3, cv::DataType<double>::type);
cv::Mat distortionCoeffs = cv::Mat(4,1, cv::DataType<double>::type);
cameraMatrix.at<double>(0, 0) = doc_undistor["csi_cam_0"]["intrinsics"][0].as<double>();

After that build with command bazel build -c opt --define MEDIAPIPE_DISABLE_GPU=1 mediapipe/examples/desktop/hand_tracking:hand_tracking_cpu. But then i've got an error:
ERROR: /home/ivanpiskun/mediapipe-iomicoml/mediapipe/examples/desktop/hand_tracking/BUILD:27:10: Linking of rule '//mediapipe/examples/desktop/hand_tracking:hand_tracking_cpu' failed (Exit 1): gcc failed: error executing command /usr/bin/gcc @bazel-out/k8-opt/bin/mediapipe/examples/desktop/hand_tracking/hand_tracking_cpu-2.params

Use --sandbox_debug to see verbose messages from the sandbox gcc failed: error executing command /usr/bin/gcc @bazel-out/k8-opt/bin/mediapipe/examples/desktop/hand_tracking/hand_tracking_cpu-2.params

Use --sandbox_debug to see verbose messages from the sandbox
bazel-out/k8-opt/bin/mediapipe/examples/desktop/_objs/demo_run_graph_main/
demo_run_graph_main.o:demo_run_graph_main.cc:function YAML
::TypedBadConversion<double>::~TypedBadConversion(): error: undefined reference to 'YAML::BadConversion::~BadConversion()'
bazel-out/k8-opt/bin/mediapipe/examples/desktop/_objs/demo_run_graph_main/
demo_run_graph_main.o:demo_run_graph_main.cc:typeinfo for YAML::TypedBadConversion<double>: error: undefined reference to 'typeinfo for YAML::BadConversion'
collect2: error: ld returned 1 exit status
Target //mediapipe/examples/desktop/hand_tracking:hand_tracking_cpu failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 5.487s, Critical Path: 5.33s
INFO: 3 processes: 2 internal, 1 processwrapper-sandbox.
FAILED: Build did NOT complete successfully

How should I include yaml-cpp in Mediapipe?
Thanks.

Hi @ivanpiskun123, Could you please provide the steps to reproduce the above with use case details. Thanks!

Clone and build yaml-cpp as described on the site
Add following code to WORKSPACE:    new_local_repository(
        name = "linux_yaml",
        build_file = "@//third_party:yaml_cpp_linux.BUILD",
        path = "/usr/local",
    )

Create third_party/yaml_cpp_linux.BUILD and add following code to it:          exports_files(["LICENSE"])
  cc_library(
      name = "yaml_cpp",
      srcs = glob(
          [
              "lib/libyaml-cpp.a",
          ],
      ),
      hdrs = glob(["include/yaml_cpp/*.h"]),
      includes = ["include/yaml_cpp/"],
      linkopts = [
         "-lyaml-cpp",
      ],
      linkstatic = 1,
      visibility = ["//visibility:public"],
  )

Add includes to /mediapipe/examples/desktop/demo_run_graph_main.cc:    ...
     #include <yaml-cpp/yaml.h>
     #include <fstream>
   ...

Add this code to /mediapipe/examples/desktop/demo_run_graph_main.cc
in body of absl::Status RunMPPGraph() function:     std::ifstream fin_undistor("utils//undistort//calibr.yaml");
     YAML::Node doc_undistor = YAML::Load(fin_undistor);

, where calibr.yaml - just .yaml file with some data inside it.

Build mediapipe/examples/desktop/hand_tracking:hand_tracking_cpu with command:    bazel build -c opt --define MEDIAPIPE_DISABLE_GPU=1 mediapipe/examples/desktop/hand_tracking:hand_tracking_cpu

throws error:

    INFO: Analyzed target //mediapipe/examples/desktop/hand_tracking:hand_tracking_cpu (0 packages loaded, 0 targets configured).
   INFO: Found 1 target...
   ERROR: /home/ivanpiskun/mediapipe-iomicoml/mediapipe/examples/desktop/hand_tracking/BUILD:27:10: Linking of rule '//mediapipe/examples/desktop/hand_tracking:hand_tracking_cpu' failed (Exit 1): gcc failed: error executing command /usr/bin/gcc @bazel-out/k8-opt/bin/mediapipe/examples/desktop/hand_tracking/hand_tracking_cpu-2.params

   Use --sandbox_debug to see verbose messages from the sandbox gcc failed: error executing command /usr/bin/gcc @bazel-out/k8-opt/bin/mediapipe/examples/desktop/hand_tracking/hand_tracking_cpu-2.params

   Use --sandbox_debug to see verbose messages from the sandbox
   bazel-out/k8-opt/bin/mediapipe/examples/desktop/_objs/demo_run_graph_main/demo_run_graph_main.o:demo_run_graph_main.cc:function RunMPPGraph(): error: undefined reference to 'YAML::Load(std::istream&)'
   collect2: error: ld returned 1 exit status
   Target //mediapipe/examples/desktop/hand_tracking:hand_tracking_cpu failed to build
   Use --verbose_failures to see the command lines of failed build steps.
   INFO: Elapsed time: 8.904s, Critical Path: 8.30s
   INFO: 3 processes: 2 internal, 1 processwrapper-sandbox.
   FAILED: Build did NOT complete successfully

Do you add your yaml cc_library into the deps field of https://github.com/google/mediapipe/blob/ecb5b5f44ab23ea620ef97a479407c699e424aa7/mediapipe/examples/desktop/BUILD#L38?

Hi @ivanpiskun123, Could you please try the above comment. Thanks!


Fix typos, broken link, image placement in Testing

Fixes a basic typo
Fixes a link to where the map names used to be (link checker likely can't catch these as they're valid links; they just redirect to the file they originate from)
Fixes a misplaced image in the page for manually downloading development Northstar code

If you don't mind I'll split this up a bit for my own sake ^^


Fix color transition on icon-button and icon-link

The color transition for d2l-icon-button and d2l-icon-link on hover/focus isn't getting applied. Seems to be related to the transition CSS property being applied to something with the class ..d2l-icon-button-icon, but nothing has that class.

Doh!


persistent startup options for window-state

My Setup

Operating System: Windows 10 Pro 1809
App Version: 2.15.1
Installation type: exe silent install

[X] I have tested with the latest version
[X] I can simulate the issue easily

Description
When opening RocketChat client, the window-state-main.json file is read and last window state applied.
Current Behavior
when having client hidden, it starts hidden, irritating users, who call IT to report non working program.
Expected Behavior
We would like to have a gui option to setup startup preference (hidden, minimized, normal, maximised). This should be in a persistent saved state, unless changed through the GUI settings.
Many thanks.

@rschoell Is the window getting hidden without a tray icon appearing?

The tray icon is there. But my users get irritated, when an app they start is not showing. That's where the request comes from.
Thanks Ralph
Von meinem Samsung Galaxy Smartphone gesendet.
-------- Ursprüngliche Nachricht --------
Von: Tasso Evangelista<EMAIL_ADDRESS>Datum: 31.03.19 23:31 (GMT+01:00)
An: "RocketChat/Rocket.Chat.Electron"<EMAIL_ADDRESS>Cc: rschoell<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Re: [RocketChat/Rocket.Chat.Electron] persistent startup options for window-state (#1160)
@rschoellhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frschoell&data=02|01||b3628937e9624d14cf4208d6b6204ab1|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636896647133226616&sdata=M%2BPMXDYJyNGCH8ZVT9d8cPlvNk3eYOsPJu4HAN1%2BpYc%3D&reserved=0 Is the window getting hidden without a tray icon appearing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRocketChat%2FRocket.Chat.Electron%2Fissues%2F1160%23issuecomment-478387048&data=02|01||b3628937e9624d14cf4208d6b6204ab1|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636896647133236639&sdata=lZ4XmbwzXNLcOFbfdccTX70u9ULd4ZBoQhbuXt5i8cQ%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAmlR88N0aFmFCLgF6Llfu07aRWULEMB3ks5vcSlHgaJpZM4cK36W&data=02|01||b3628937e9624d14cf4208d6b6204ab1|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636896647133246638&sdata=1TXGKQFB4HCc3Krdrj77cgpE%2ByMiZUP%2BWEc%2Fk0UfjRI%3D&reserved=0.

@rschoell I got it. It is by design persisting the last window state for reuse on startup, but I understand how this could be confusing for some users and why there must be a preference to handle it.

Thank you very much Tasso. My users will appreciate it.
Von: Tasso Evangelista<EMAIL_ADDRESS>Gesendet: Montag, 1. April 2019 18:43
An: RocketChat/Rocket.Chat.Electron<EMAIL_ADDRESS>Cc: rschoell<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Re: [RocketChat/Rocket.Chat.Electron] persistent startup options for window-state (#1160)
@rschoellhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frschoell&data=02|01||4e60cc0c95ea4f34ee3808d6b6c116ae|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636897337759103739&sdata=qV%2BN%2BTgFGCX7PA9OxYqAmeV8AReOCG5n8SoSuLgTlFQ%3D&reserved=0 I got it. It is by design persisting the last window state for reuse on startup, but I understand how this could be confusing for some users and why there must be a preference to handle it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRocketChat%2FRocket.Chat.Electron%2Fissues%2F1160%23issuecomment-478654913&data=02|01||4e60cc0c95ea4f34ee3808d6b6c116ae|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636897337759113738&sdata=gz2RKRtXMLBZfTikTrayN5r1xdrXeulRCR4CVNTj2RQ%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAmlR8yel6pY0skJgS-cTKesQDEgQVg3Iks5vcjcOgaJpZM4cK36W&data=02|01||4e60cc0c95ea4f34ee3808d6b6c116ae|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636897337759123744&sdata=K2ZeXL4j0xN6G%2FskAvoRafYQM5hBY4j0pN3dJsHWLYg%3D&reserved=0.

Hello, we have recently starting rolling out Rocket.Chat in our department and we have been getting similar complaints that rocket.chat is no opening when they launch the desktop app. After investigating a little, I found  the window-state-main JSON file and why this is occurring. Is there a way to ensure that 'isHidden" stays = true, for at least at startup or launching the app?

a problem link with yours : do you know where/how i can manage the option for RC desktop launhc at windows startup ?

As a workaround you could run a powershell script before Rocket.Chat starts to change the isHidden value.
$a = Get-Content "$($ENV:AppData)\Rocket.Chat\window-state-main.json" | ConvertFrom-Json
$a.isHidden = $false
$a | ConvertTo-Json | set-content "$($ENV:AppData)\Rocket.Chat\window-state-main.json"

Not fixed after this time?

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.
Thank you!

the last version didn't resolve that because there is no flag in auto install to add the autostart option !
Or no communication on this features !!!!

This issue has nothing to do with auto install and autostart option.
The state of window is persisted everytime it changes.

the last version didn't resolve that because there is no flag in auto install to add the autostart option !
Or no communication on this features !!!!


Accounts suspended when created using the bot

I have created 2 accounts using the bot and they were suspended immediately.   Have you experienced something similar?  Is there any thing I should do to prevent this?

I forgot to mention, I have created manual accounts with the same proxy and they worked ok after that.

Hi! Seems like your IP address is black-listed.


The plugin installs npm in my local node_modules

Expected Behaviour
The 2.0.0-rc3 version of the plugin explicitly depends on the npm package (link). This needlessly adds complications to my node_modules/ folder.
Is this an intended change?
Actual Behaviour
Plugin should not depend on npm as that is a global package.
Reproduce Scenario (including but not limited to)

Steps to Reproduce

Install plugin
npm ls npm

Platform and Version (eg. Android 5.0 or iOS 9.2.1)

(Android) What device vendor (e.g. Samsung, HTC, Sony...)

Cordova CLI version and cordova platform version

Plugin version
v2.0.0-rc3
Sample Push Data Payload

Sample Code that illustrates the problem

Logs taken while reproducing problem

Nope, that looks like a mistake that I will remedy shortly.

Thanks for that! When is it getting released to npm?

@macdonst Is this likely to see a release soon? This is a major blocker for our project as it breaks npm shrinkwrap

@linguamachina let me see if I can post a RC4 on hotel wifi.

@linguamachina I bumped a rc4 you can use.


Sort by count subquery

I want to select some columns of user table and a subquery on another table. The subquery contains a count. I want to use that count to sort the rows. So I am using order_by(count.asc()) But this is giving compilation errors.
select(
    users.id,
    users.first_name,
    users.last_name,
    select(count(zones.id))
        .from(zones)
        .where(zones.user == users.id)
)
.from(users)
.order_by(count.asc())
.unconditionally()

So I aliased count as entries
SQLPP_ALIAS_PROVIDER(entries);
select(
    users.id,
    users.first_name,
    users.last_name,
    select(count(zones.id))
        .from(zones)
        .where(zones.user == users.id)
        .as(entries)
)
.from(users)
.order_by(entries.asc())
.unconditionally()

This is also giving compilation errors
error: ‘sqlpp::no_select_column_list_t::_base_t<sqlpp::detail::statement_policies_t<void, sqlpp::no_with_t, sqlpp::select_t, sqlpp::no_select_flag_list_t, sqlpp::no_select_column_list_t, sqlpp::no_from_t, sqlpp::no_where_t<true>, sqlpp::no_group_by_t, sqlpp::no_having_t, sqlpp::no_order_by_t, sqlpp::no_limit_t, sqlpp::no_offset_t, sqlpp::no_union_t, sqlpp::no_for_update_t> >::_new_statement_t<sqlpp::assert_selected_colums_are_selectable_t, sqlpp::select_column_list_t<void, sqlpp::column_t<wee::TabUser, wee::TabUser_::Id>, sqlpp::column_t<wee::TabUser, wee::TabUser_::FirstName>, sqlpp::column_t<wee::TabUser, wee::TabUser_::LastName>, sqlpp::table_alias_t<entries_t, sqlpp::select_pseudo_table_t<sqlpp::statement_t<void, sqlpp::no_with_t, sqlpp::select_t, sqlpp::no_select_flag_list_t, sqlpp::select_column_list_t<void, sqlpp::expression_alias_t<sqlpp::count_t<sqlpp::noop, sqlpp::column_t<wee::Zones, wee::Zones_::Id> >, sqlpp::count_alias_t> >, sqlpp::from_t<void, wee::Zones>, sqlpp::where_t<void, sqlpp::binary_expression_t<sqlpp::column_t<wee::Zones, wee::Zones_::User>, sqlpp::op::equal_to, sqlpp::column_t<wee::TabUser, wee::TabUser_::Id> > >, sqlpp::no_group_by_t, sqlpp::no_having_t, sqlpp::no_order_by_t, sqlpp::no_limit_t, sqlpp::no_offset_t, sqlpp::no_union_t, sqlpp::no_for_update_t>, sqlpp::expression_alias_t<sqlpp::count_t<sqlpp::noop, sqlpp::column_t<wee::Zones, wee::Zones_::Id> >, sqlpp::count_alias_t> >, sqlpp::select_column_spec_t<sqlpp::statement_t<void, sqlpp::no_with_t, sqlpp::select_t, sqlpp::no_select_flag_list_t, sqlpp::select_column_list_t<void, sqlpp::expression_alias_t<sqlpp::count_t<sqlpp::noop, sqlpp::column_t<wee::Zones, wee::Zones_::Id> >, sqlpp::count_alias_t> >, sqlpp::from_t<void, wee::Zones>, sqlpp::where_t<void, sqlpp::binary_expression_t<sqlpp::column_t<wee::Zones, wee::Zones_::User>, sqlpp::op::equal_to, sqlpp::column_t<wee::TabUser, wee::TabUser_::Id> > >, sqlpp::no_group_by_t, sqlpp::no_having_t, sqlpp::no_order_by_t, sqlpp::no_limit_t, sqlpp::no_offset_t, sqlpp::no_union_t, sqlpp::no_for_update_t>, sqlpp::expression_alias_t<sqlpp::count_t<sqlpp::noop, sqlpp::column_t<wee::Zones, wee::Zones_::Id> >, sqlpp::count_alias_t> > > > >’ {aka ‘struct sqlpp::assert_selected_colums_are_selectable_t’} has no member named ‘from’

Sub queries as named values are not well supported, I am afraid. select(...).as(something) creates a sub-select that can be used as a table. The selected columns are the columns of that table, e.g.
  auto rowCount = select(t.alpha, count(t.alpha)).from(t).unconditionally().group_by(t.alpha).as(sqlpp::alias::a);
  db(select(f.omega, rowCount.count)
         .from(f.join(rowCount).on(f.omega == rowCount.alpha))
         .unconditionally()
         .order_by(rowCount.count));

This is not exactly what you want, but probably the closest the library can get you without serializing sub expressions and using them as verbatim strings.


Added tailgating as example

Added a (short description) of tailgating under the Some examples of Social Engineering hacks, as it is another form of these.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


[BEAM-222] Don't advance beyond last valid value

Turns out there was a bug with allowing 'advanced beyond last element' to be a valid counter state.
Only an internal reload test caught it.
Included unit test for that case.

R: @dhalperi

R: @lukecwik

LGTM


Add a test for progress messages

Hi @Xiaohongt, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft Open Technologies, Inc. and real humans are currently evaluating your PR.
TTYL, MSOTBOT;

:ship::it:


InterfacesClient.Get() results with network.Interface containing nil for public IP

Bug Report

import path of package in question:
.../services/compute/mgmt/2018-10-01/network

What happened?
I'm trying to mitigate throttling of ARM requests.
I need to retrieve private and public IP for a NIC.
However, InterfacesClient.Get() returns nil for ipConfigurations[].publicIpAddress.ipAddress

The workaround is to make another API call PublicIPAddressesClient.Get(). However, given large number of VMs and periodicity of the checks (along with API calls for other resources), we are exceeding ARM limit of read API requests.

What did you expect or want to happen?
I would expect that specifying "ipConfigurations" (or something similar) as the expand parameter in InterfacesClient.Get() would populate array of InterfaceIPConfiguration with PublicIPAddress

How can we reproduce it?
Make a call to azure-sdk-for-go/services/network/mgmt/2018-10-01/network/interfacesgroup.go:InterfacesClient.Get() and examine the Interface structure.

Thank you for opening this issue! We are routing it to the appropriate team for follow up.

any updates on this issue?

Hello again, any updates on this issue?

I need this fix too

Hi @dmitsh sorry for the delay.
I tried with the rest api.
Its response does not contains a field of publicIpAddress, therefore in SDK the value of publicIpAddress is nil.
This problem lies in the service side. I added a Service Attention tag to inform them. Please also feel free to submit an issue in the rest api repo.

I believe this is part of the networking APIs not the VM APIs. So I have routed to the appropriate networking team.

I believe this is part of the networking APIs not the VM APIs. So I have routed to the appropriate networking team.

Thanks!

@jhendrixMSFT can you look into this please?
seems to be related to this:
https://github.com/Azure/azure-sdk-for-go/blob/master/services/network/mgmt/2018-10-01/network/publicipaddresses.go

@dmitsh, thanks for the feedback - I'm tracking the issue and we'll followup soon

Hi, any progress on this?

Hi, do you have any progress on timeline on this?

@dmitsh, @szymon3 , @jaydrue,  this issue has been here for years and as this is a feature request for the virtual network service, could you post your question directly in https://docs.microsoft.com/en-us/answers/topics/azure-virtual-network.html

Any solution on this issue? Any fix would be helpful to me


Don't need anymore the --enable-cloud-console-aks-browse parameter

With the Azure CLI 2.0.50 already integrated in the Azure Cloud Shell, we don't need anymore the --enable-cloud-console-aks-browse parameter from there. Otherwise we get an error unrecognized arguments.
Breaking change logged here: https://github.com/Azure/azure-docs-cli-python/blob/master/docs-ref-conceptual/release-notes-azure-cli.md#acs
Fix proposed here: https://github.com/MicrosoftDocs/azure-docs/pull/18462

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2ba1dad2-9792-2a7b-cdb6-68da0524cff3
Version Independent ID: 42736112-f6db-d241-e89b-48fd2c35ceb7
Content: Manage an Azure Kubernetes Service cluster with the web dashboard
Content Source: articles/aks/kubernetes-dashboard.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Thanks, @mathieu-benoit. I've signed off on the PR so it should merge and publish today.
#please-close


Test distributed-workloads for FIPS compliance

Investigate and implement the FIPS compliance testing for the Distributed Workloads stack, ensuring that it adheres to the required security standards mandated by FIPS .
References:
https://docs.openshift.com/container-platform/4.12/installing/installing-fips.html

Downstream tests with cluster FIPS enabled mode looks good https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/distributed-workloads/job/rhods-dw-smoke/22/
While running upstream tests against the cluster in codeflare operator with FIPS Enabled mode Noticed below warnings

    mnist_raycluster_sdk_test.go:70: Created ConfigMap test-ns-mdmdq/mnist-raycluster-sdk successfully
W1011 14:41:01.398608   41981 warnings.go:70] would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "test" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "test" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "test" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "test" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
    mnist_raycluster_sdk_test.go:205: Created Job test-ns-mdmdq/sdk successfully

Pending things:

Static scanning  for operator images check-payload
Run Instascale upstream tests


Update to jsonwebtoken 9.0.0

Fixes #94.

I didn't see this PR in time and created another one in parallel with passing builds: https://github.com/iTwin/auth-clients/pull/96 . Merge that one?


add minimum versions to requirements

Certain libraries need specific versions

Minimum requirements so far:

[ ] numpy >= 1.20


Unexpected token: name (table) [D:/Workspace/ice_Internal_git/ice_ui/node_modules/es-tabify/index.js:7,0][vendor.aae2af8e580b661ab799.bundle.js:28289,8]

While building this module with ng build --prod I get the above mentioned error.

No idea. How to reproduce? Seems unrelated to this module.


Rename convention plugin to io.github.gradle

@bot-gradle test and merge

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


leaflet map is added

commit: c85932bcc3cc11740b4a0ae9b8e9996eb1db8cef

leaflet map is added, haven't finished. Couldn't implement the getting location coordinates parts and sending the data from backend.

solved: 9292681c5f41f5837ac4f998ec55a7f0f5fda502


import SQLite giving "Missing required module 'CSQLite'

Hi there - just trying to get this project working with Carthage and hit up against a snag.
Xcode 7.3, brand new iOS  single view project.
Cartfile contains github "stephencelis/SQLite.swift" ~> 0.10.1
carthage update compiled the builds OK. Dragged the SQLite.framework to Linked Frameworks and Libraries, added the Build Phases run script with /usr/local/bin/carthage copy-frameworks and the Input Files set to $(SRCROOT)/Carthage/Build/iOS/SQLite.framework
I build the project and it does so fine at this stage. Now I add a swift class with import SQLite and the project no longer compiles with Missing required module 'CSQLite at the import line.
I note that Xcode does auto-complete SQLite for the import - if I type import SQL and auto-complete it shows Module SQLite as if it knows about it - but then it errors on that line.
Have double-checked my steps with https://www.raywenderlich.com/109330/carthage-tutorial-getting-started and I don't think I've missed anything.
Apologies if I have missed a point of detail.

I followed my steps again and 2nd time worked a charm. Put this one down to computer gremlins.


Fixed #82

Added information about ChangeSet with information
about paths, author etc.
I have implemented the things like BuildChangeSet etc. but at the moment i have not a really good idea to implement a real test, cause i have tested with the JenkinsChangeSetTest.
Can you make a good suggestion how to implement a better test?

Thanks. This looks good. I don't think I have any better ideas for testing at this point.


Can't log in after running the logoutOtherDevices function

Laravel Version: 6.4.0
PHP Version: 7.3.9

Description:
After following the Laracasts tutorial on how to invalidate all other sessions for a user's account, I have found that when attempting to log in again after the session has been successfully invalidated, the credentials no longer work meaning the user cannot log in again.
Steps To Reproduce:
Un-comment the following line in app/Http/Kernel.php class' web middleware group:
\Illuminate\Session\Middleware\AuthenticateSession::class,
Add the following route in routes/web.php - this is exactly what is typed in the Laracast episode:
Route::get('/logoutOthers', function() {
   auth()->logoutOtherDevices('password');

   return redirect('/');
});

Open two browsers (Safari & Chrome) and then log into the same account on both. On one of the browsers, go to /logoutOthers
Then on the other browser refresh the page. As expected, the user has been signed out. But when the user tries to sign in again, using the password that has been hardcoded in the route above, they receive the following message:

These credentials do not match our records.

Everything seems to be working for me just fine.
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to report back and I'll gladly help you out and re-open this issue.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Thanks!


On enter activate top level link if it has no panel

In situations where a megamenu top level link doesn't have a corresponding sub panel, it would be better behaviour to allow an in focus top level link to go to that URL on pressing the enter key.

Merged via pull request #66.


Please Release a New Version

Sorry to file an issue for what is really more of a request, but I didn't see another forum for discussing this library's development schedule and release process.
I am really excited to see the support for CMake added in this change: unittest-cpp/unittest-cpp@e88121f
I would like to see it become part of a stable release of the library including having it installed by Homebrew on Mac OS X.  Does this project also create the Homebrew releases when it is time?

As of today I am starting on getting 2.0 released; you can expect it in the next few weeks. I have in the past and will hopefully remember to issue a pull request to Homebrew.

I am still a bit mystified as to what 2.x is going to give us over 1.7.
Usually you change the major number if you are going to make breaking
changes and I believe that would be a bad idea. You are threatening to
strand a lot of people on 1.6.x.
The only thing I could see that might warrant a 2.x is a total rewrite
making it less macro based but since c++ doesn't have reflection I think
(like so many other attempts) that it would be doomed to failure.
GR
Sent from my Nexus 6P
On 13 Jan 2017 19:00, "Patrick Johnmeyer"<EMAIL_ADDRESS>wrote:

As of today I am starting on getting 2.0 released; you can expect it in
the next few weeks. I have in the past and will hopefully remember to issue
a pull request to Homebrew.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/unittest-cpp/unittest-cpp/issues/140#issuecomment-272518855,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEy9nIWdhhLhZdVZ6JoC6uROvA-dBNGCks5rR8nLgaJpZM4LNc7t
.

@grahamreeds :
Back in January I announced that the project would start using Semantic Versioning after 1.5.0.
In July you wrote this issue which finally gave me the driver to make the change suggested in this request. That change, per Semantic Versioning, required me to change the major version number. I wrote about this in August, explaining why it was a breaking change, and explaining how minor the changes were. Your issue was labeled 2.0.0 around that same time.
In the one month that the pull request remained open, nobody raised any concerns. In the nearly five months between its merge and release, nobody raised any concerns.
In short, 2.0 implements an enhancement requested before the project was even on GitHub, in order to fix an issue you requested be fixed, in a manner which will not break 99% of users, and will possibly make tests run faster for others, after months of silence from the community on the matter.
I would be shocked if these changes "strand" anybody, but they are potentially breaking. It would be incorrect to call this 1.7, and I have no interest in rolling the changes back as they are architecturally sound changes. Everyone is welcome to use 1.6.x for as long as they like -- it's not going anywhere -- but the project is moving forward.


[ACR] Rename ArtifactManifestProperties.Size->SizeInbytes

The one other potential rename we wanted to investigate was for RegistryArtifact.GetTagPropertiesCollection().
From the feedback I got, we can use the Collection suffix as we have now. Another option is to use All, giving us GetTagProperties() and GetAllTagProperties() as the two variants.
So, the choice is between GetTagPropertiesCollection() and GetAllTagProperties() for the pageable version of the method.
I like what we have currently, want to get feedback to update in this PR.

API changes have been detected in Azure.Containers.ContainerRegistry. You can review API changes here
API changes
-         public long? Size { get; }
+         public long? SizeInBytes { get; }
-         public static ArtifactManifestProperties ArtifactManifestProperties(string registryLoginServer = null, string repositoryName = null, string digest = null, long? size = null, DateTimeOffset createdOn = default, DateTimeOffset lastUpdatedOn = default, ArtifactArchitecture? architecture = null, ArtifactOperatingSystem? operatingSystem = null, IEnumerable<ArtifactManifestPlatform> relatedArtifacts = null, IEnumerable<string> tags = null, bool? canDelete = null, bool? canWrite = null, bool? canList = null, bool? canRead = null);
+         public static ArtifactManifestProperties ArtifactManifestProperties(string registryLoginServer = null, string repositoryName = null, string digest = null, long? sizeInBytes = null, DateTimeOffset createdOn = default, DateTimeOffset lastUpdatedOn = default, ArtifactArchitecture? architecture = null, ArtifactOperatingSystem? operatingSystem = null, IEnumerable<ArtifactManifestPlatform> relatedArtifacts = null, IEnumerable<string> tags = null, bool? canDelete = null, bool? canWrite = null, bool? canList = null, bool? canRead = null);

So, the choice is between GetTagPropertiesCollection() and GetAllTagProperties() for the pageable version of the method. I like what we have currently, want to get feedback to update in this PR.

Were you able to look into what others HLC libraries do when we have this plural situation?  I believe @KrzysztofCwalina's guidance was to be consistent with the existing precedent if there is one.  In LLC, we use the All to disambiguate.

So, the choice is between GetTagPropertiesCollection() and GetAllTagProperties() for the pageable version of the method. I like what we have currently, want to get feedback to update in this PR.

Were you able to look into what others HLC libraries do when we have this plural situation? I believe @KrzysztofCwalina's guidance was to be consistent with the existing precedent if there is one. In LLC, we use the All to disambiguate.

I didn't find any instance of this particular case. There are several places where we use the Collection suffix, not necessarily for this reason though. That is to clarify that the method returns a collection or an instance of a type that represents a collection.

If we go with the Collection suffix over including All, we'll want to change LLC to adopt this convention as well.  Let's get @KrzysztofCwalina's perspective on this.

Per @KrzysztofCwalina:

I prefer the GetAll convention. The "Collections" suffix sounds like a Hungarian convention, i.e. refers to .NET type name as opposed to API semantics.
Also, I think the "All" convention is used in some .NET APIs, but not the "Collections" convention.
Having said that the "All" convention does not work in all cases. For example, imagine an API that returns a collection of items/resources but takes a filter as a parameter. It might be misleading to call the method GetAll(string filter) given it won't return all items unless the filter is "*".
It would be good to think what we would use if we ran into such APIs with a filter.

API changes have been detected in Azure.Containers.ContainerRegistry. You can review API changes here

@annelo-msft, @KrzysztofCwalina - I have updated the API names as per our discussion.
I will add an entry to the guidelines to the effect of -
GetAll<resource_name> when <resource_name> is itself in plural form, like Properties.


chore: add SM when SR cant send due to size

Add a SM when the SR feature cannot send due to DOM size

Overview

Related Issue(s)
https://issues.newrelic.com/browse/NR-163032

Testing

Needs Angler PR as follow up

I could argue this should be a feature since SR has already been put into the release notes as a feature and this could help customers understand why they may not see SRs. Also, maybe this should be an error so it shows up on the customer's error dashboard? Not sure there though.


Examples of modules

Hi, I'm new to backbone and I'm giving this boilerplate a shot and I love it so far. Do you have any examples on how javascript files in app/modules folder gets included? It's not automatically compiled with the app/*.js files during the requirejs task.

It uses AMD, check out RequireJS or Google around for information on how to require and build these modules.
An example application that has modules included and built: https://github.com/tbranyen/github-viewer


[audit 4.0] [SPARK-48479]Support creating scalar and table SQL UDFs in parser

Is your feature request related to a problem? Please describe.
Spark added a new way to create UDFs, commit:
https://github.com/apache/spark/commit/0d9f8a107f5
issue: https://issues.apache.org/jira/browse/SPARK-48479
I don't think this will affect us directly but we may want to add some testing with the rapids udf stuff and we may want to look to make sure the tools can recognize this the same as defining udfs the other methods.

@tgravescs to file corresponding issue for spark-rapids-tools to handle UDF naming with Spark 4.0.


Add better UI for keywords

Summary
This PR implements better UI for keywords
I struggled a lot with css, so please take a good look on it. Suggestions are appreciated ^_^
https://user-images.githubusercontent.com/2340127/123255368-cfec0580-d500-11eb-8595-5c9b1644ae56.mp4
Checklist

[ ] Telemetry updated
[ ] Gated by experimental feature flag
[ ] Unit tests updated

@iomodo, can you help share next steps for this PR? Are there outstanding questions to be resolved?


laravel 5 install

When I try to install in l5 throws this error:
Uncaught exception 'ReflectionException' with message 'Class log does not exist'.....

Yeah, not ready for Laravel 5 yet. Will look into it soon.

It now supports Laravel 5!


Make --column and --context mutex

The --column doesn't make sense with --context because only the matching line has a column, not the context lines.  It's already mutex with --passthru.

It's OK if we have this.  We already handle the lack of context.


Add SHA1 suffix to intermediaries

Different intermediary URLs break in a multi-platform setup (like preprocessor), so we use this to differentiate between intermediaries.

This looks like it should go upstream. It doesn't look like it's related legacy forge support and would be an issue even with vanilla fabric-loom. Once it's accepted upstream, we can consider backporting it if you do not wish to maintain your own loom fork.


[NEW-FEATURE] Create library for generic pneumatic components

/cib

Branch 173-_NEW-FEATURE_Create_library_for_generic_pneumatic_components created!


"Adding a Service Worker and Offline into your Web App" missing link to repository

Step 2 makes references to the master branch without having provided a link to the git repo to be cloned.

Additionally, there is no mentioning of npm install before running the server.


Wallet connection manager fixes

PR-Codex overview
This PR removes the feature of setting another connected wallet as active upon disconnecting the current active wallet. It also avoids saving the personal wallet separately in the connected wallets list.
Detailed summary

Removed feature to set another connected wallet as active upon disconnecting current active wallet
Personal wallet no longer saved separately in connected wallets list

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

/release-pr


[SPARK-16515][SQL][FOLLOW-UP] Fix test script on OS X/Windows...

Problem
The current sed in test_script.sh is missing a $, leading to the failure of script test on OS X:
== Results ==
!== Correct Answer - 2 ==   == Spark Answer - 2 ==
![x1_y1]                    [x1]
![x2_y2]                    [x2]

In addition, this script test would also fail on systems like Windows where we couldn't be able to invoke bash or echo | sed.
What changes were proposed in this pull request?
This patch

fixes sed in test_script.sh
adds command guards so that the script test would pass on systems like Windows

How was this patch tested?

Jenkins
Manually verified tests pass on OS X

Test build #62586 has started for PR 14280 at commit dc39c98.

It appears that the existing sed command works if you write sed $'...' on both Linux and OS X. Is that easier?

Test build #62587 has started for PR 14280 at commit f12b43f.

sed $'...' works on both Linux & OS X! So let's switch back to sed. @srowen thanks a lot for the $!

Test build #62588 has started for PR 14280 at commit 372ef5c.

Test build #62586 has finished for PR 14280 at commit dc39c98.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62586/
Test PASSed.

Merged build finished. Test PASSed.

Test build #62587 has finished for PR 14280 at commit f12b43f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62587/
Test PASSed.

Test build #62588 has finished for PR 14280 at commit 372ef5c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62588/
Test PASSed.

Maybe this is ready to go?

LGTM

OK merged to master/2.0 to match related changes


make this app scalable

Because we require a single NODE_NAME and NODE_SECRET envvar in the container which relates to a single worker node in jenkins, this application is unable to scale higher than 1. Instead of creating single applications for each jenkins node, it'd be more "12 factorish" to allow this app to scale proportionately to the number of nodes we want in Jenkins.

fixed via refactoring this to be a JNLP slave.


Polish translations + 2 issues fixed: #58, #59

Generally good polish translations. As polish langague is quite complicated and I didn't want to change the parser and resource-set, there will be some not-so-polish descriptions like: "co drugi sobota". It's understandable, but gramatically correct should be "co druga sobota". But it's an exception. Other cases are all right.
Also fixed two issues I've found around days of week expression part with intervals.

Thank you @foka !  I am planning on getting a new release out on the next few days to NuGet.


Make Traffic Router ignore ANY_MAP Delivery Services

Delivery Services of type ANY_MAP should be completely ignored by
Traffic Router, even if they're set to 'active'. An active ANY_MAP DS is
treated like an HTTP DS to the Traffic Router (which is bad).
In practice ANY_MAP DSes have been set to inactive (which makes them
ignored by TR but still able to add "raw remap text" lines to
remap.config), but this makes it so that even if they're set to active
they're still ignored by TR.

Fixes #1121

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/811/
Test PASSed.


Github api requests now require User-Agent field in header

see https://developer.github.com/v3/#user-agent-required for details ... initial fix will be in metacello-work, but similar patch should apply to metacello (looks the patch was applied here)

The use of github tags and patterns is obviously not being used in projects, since this facility has been non-functional for at least 3 months and due to api limitation issues, it has always been a dicey proposition ... so at this point I'm going to to mark the failing tests as expected failures ...


0.11.0

Awesome Thanks! Hope this gets released soon. Also @iRoachie I just started to use your material-tab package and it works great thanks!.

Awesome @jeffreymendez1993 will release this week


boards: weact: Add support for WeAct stm32g474 core board

STM32G4 series development board with minimum hardware.
Signed-off-by: Ahmet Adin<EMAIL_ADDRESS>

Squash commits

Squash commits

Does commits look squashed now?

Squash commits

Does commits look squashed now?

Commits are, commit message is not, just have one commit message saying adding the board with one sign off

Merge commit needs to be removed


Getting Error: Sorry, cannot inject CampaignsService because the injector is not ready yet. Please call mox.run()

Getting this error in my terminal:
	Error: Sorry, cannot inject CampaignsService because the injector is not ready yet. Please call mox.run() or inject()
My test block:
describe("CampaignsService", function () {
    beforeEach(function () {
        mox.mockServices('CampaignsService');
        mox.run();
    });

    it("should initialize correctly", function () {
        var CampaignsService  = mox.inject('CampaignsService');
        expect(CampaignsService).toBe(mox.get.CampaignsService);
    });
});

Any ideas why I'd be getting this error?

If you want to inject services in Angular, you have to load a module, just as you would do without Mox. So you have to call mox.module('myApp')...... This is the equivalent of module or angular.mock.module.
Note that you can chain the mox call. It saves you some lines of code.
mox
  .module('myApp')
  .mockServices('CampaignsService')
  .run();

Does this solve your problem?

I'll close this for now. If you have any issues, please let me know.


HIVE-24602: Retry compaction after configured time

What changes were proposed in this pull request?
Automatic compaction initiation stops if compaction fails for a given partition two consecutive time. The Initiator should retry after some time elapses.
Why are the changes needed?
Compaction not running for a table / partition can have serious performance impact
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added unittest.

@klcopp can I ask you for a review?

@klcopp can I ask you for a review?


wire/dojo/dom and wire/jquery/dom should also support "dom!" resolution

@scothis and I both got tripped up by this.  It seems that the wire/dojo/dom and wire/jquery/dom plugins should also support dom! resolution.  This also makes it easier to switch.

Yeah, interesting.  Right now, you'd have to include both plugins, or do dom.query!#<id>.

Do you think it's just a documentation issue?  There are pages on the wiki for each of the dom plugins, but the docs may be confusing, or hard to find:

wire/dom
wire/dojo/dom
wire/jquery/dom

Or, do you feel like it's just more convenient to have both "dom" and "dom.query" provided by a single plugin, so you don't have to include two plugins?
There's one potential snag, but I don't think it's major.  If two plugins provide the same reference resolver, in this case "dom", in the same spec, wire will yell at you, telling you that you can only use one of them.  That seems ok, though, since if you need both "dom" and "dom.query", you just go with wire/dojo/dom or wire/jquery/dom over wire/dom.
It might be interesting to allow multiple resolvers with the same name, and whichever one resolves the reference first wins.  But that could also lead to confusion if you accidentally had include two competing resolvers, and they turn out to resolve refs different, and the winner turns out to be non-deterministic!  Yikes, after typing that out, it actually sounds dreadful ...
Anyway, let me know what you think about docs vs. adding "dom!" functionality to the dojo, jquery, and sizzle dom plugins.

Even though the wire/dom plugin is especially tiny, might devs think it's a wasted download?  If they're already using jquery or dojo, why load another plugin that does what jquery and dojo already do well?

I would expect wire/dojo/dom and wire/jquery/dom to be supersets of wire/dom.  The wire/dom functionality is easy to implement in dojo or jquery.

The wire/dom plugin currently supports some additional options for adding/removing classes on the <html> during wiring--a nice hook for transitions or spinners, etc.  There's a simple example on the [[wire/dom]] wiki page.  The problem that creates is if, for example, wire/dojo/dom provides dom!, and you wanted to also use wire/dom's add/remove class feature, wire will yell at you if you try to include both plugins.
One option is for wire/dojo/dom to be a true subtype of wire/dom ... basically inheriting the add/remove class functionality, and overriding the dom! resolver with it's own implementation, which could use dojo.byId (or not, it doesn't really matter).
The downside might be that it negates the advantage of loading only a single plugin.  Even though you'd only include wire/dojo/dom in your spec, wire/dojo/dom would need to load wire/dom in order to inherit from it.
Another option might be to split the add/remove class functionality out into its own plugin, or maybe it's own supertype/mixin/utility module that wire/dom, wire/dojo/dom, etc. all use or inherit from.  That still ends up with 2 module loads (e.g. wire/classUtility + wire/dom or wire/classUtility + wire/dojo/dom), but if you're doing a build, who cares?
Thoughts?  Other alternatives?

All the dom plugins now implement dom!, and where possible dom.all! (and its synonym dom.query), and dom. first!, and the ability to add/remove classes during wiring.


feat(healthcheck): Add healthchecks as separate configuration

Summary of Changes
Consume health checks as separate configuration.
Issue(s) that this PR Closes
fixes #603
Associated End To End Test PR(s)
Associated Documentation PR(s)
https://github.com/deis/workflow/pull/322
Associated Design Document(s)
Testing Instructions
https://github.com/deis/workflow/pull/322
Pull Request Hygiene TODOs
Please make sure the below checklist is complete.

[x] Your pull request is concise and to the point (make another PR for refactoring nearby code)
[x] Your commits are squashed into logical units of work
[x] Your commits follow the commit style guidelines

:cherry_blossom: Thank you! :cherry_blossom:

[Current coverage][cc-pull] is 86.42%

Merging [#823][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.22%

@@             master       #823   diff @@
==========================================
  Files            30         30
  Lines          2712       2741    +29
  Methods           0          0
  Messages          0          0
  Branches        441        453    +12
==========================================
+ Hits           2350       2369    +19
- Misses          240        246     +6
- Partials        122        126     +4

Powered by Codecov. Last updated by [4974584...fcc0aa9][cc-compare]
[cc-base-branch]: https://codecov.io/gh/deis/controller/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/deis/controller/compare/49745842cd81b1fb217958dca78a7d326ffcf4bc...fcc0aa97457b977d22ca8d7b4559dd414443cfca
[cc-pull]: https://codecov.io/gh/deis/controller/pull/823?src=pr

closing this PR. Will re-open once I've got it back in a working state.


Create 0000-01-02-Donovan-M.md

Created a branch, a new file,  and Added a second slide

ended at 2:01pm


Syncing with upstream ipfs-service-provider

:tada: This PR is included in version 1.10.5 :tada:
Your semantic-release bot :package::rocket:


[Feature Request:] Helm chart overhaul

Contact Details
InputObject2 (github), InputObject (discord)
Is your feature request related to a problem? Please describe.
I was looking at the helm chart and I was wondering why some choices were made, for example using pods directly for the hub and front (instead of a deployment or statefulset) or the services using nodeports when we're also exposing via an ingress.
There's a fair bit of changes I'd like to contribute that wouldn't all be backwards compatible with the current value file. I see that it is used a lot in the go code so I might have to change some of it to match.
Original Thread
Discord #kubernetes
Describe the solution you'd like to see
In no particular order, here are some of the things I was considering:

using deployments instead of single pods for hub and front, allowing updates and rollouts
splitting the front and hub configs out of the tap block
using resource and tolerations blocks everywhere instead of making them separate fields
allow customizing the services for hub and front
splitting the ingress block out of the tap block
reworking the ingress class
giving each component it's own optional labels and annotations inside their own block
group and isolate the app config options (like namespaces or packetcapture) inside the tap block so that they are not mixed in with the kubernetes options (like resources or storage)

Provide additional context
I think it could be a net gain overall. I found the current setup is kinda hard to grasp without going deep into the code.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Here are several steps we need to take in order to achieve these desired outcomes. I'm listing them in a sequence that I believe will minimize any disruptions caused by necessary adjustments to the Go lang code.

Adding labels to all resources. Currently, resources are identified by their names in the CLI, hub, and workers, but they should be sorted by labels. By adding labels to all resources, we can modify the types and structures of the helm chart without affecting the CLI's functionality.
Replacing pods with deployments. Without utilizing labels or name prefixes, this step becomes challenging to execute without causing communication breakdowns among services.
Loading application options/configurations from secrets/configmaps, with the option to specify an existing secret/configmap's name. This approach should simplify the subsequent step and enable the secure passage of parameters such as licenses or flags.
Separating the tap block configurations from Kubernetes configurations. This step is crucial for achieving a cleaner values.yaml file.
Removing the ingress class manifest by using a pre-defined ingress class specified by the user.
Distinctly labeling, annotating, allocating resources, and setting tolerations for each component within the values.yaml file.


CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

ISSUE :
createSnapshotPolicy API create multiple entries in DB for same parameters, if multiple threads are executed in parallel.
STEPS TO REPRODUCE :

Created a new machine having root and data disk.
Make sure that no existing snapshot policy is present for the volume.
Execute multiple threads in parallel for createSnapshotPolicy API having all required parameters exactly same.
Verify table snapshot_policy in DB, will get multiple entries for same policy.
Once again execute same multiple threads, by changing any API parameter, will see that existing entries are getting modified in DB and no new entries are added.

I'm not convinced that such a fix is needed. In what scenario do you need to send multiple identical requests?

@marcaurele : One of our customer have reported this scenario, where they have multiple management servers and when parallel request comes for snapshot policy creation for same volume, then multiple entries are created in DB for same volume.
As per the code, only one snapshot policy entry should be created in database for each volume. Whenever, another request of snapshot policy comes for the same volume, then existing entry should be updated. Same behavior is observed, when volume have existing snapshot policy and parallel threads are executed, then only single entry is getting updated every time. This is because, we have lock available in code in else block. Whereas, in case of first snapshot policy creation for volume, DB lock is not available, hence it creates multiple DB entries.
As multiple management servers might send API requests in parallel for same volume, we should handle this from our code and allow to create only one entry in DB for each volume.
Also, I apologize for confusing title of the PR, I have updated the same, to make it more clear and relevant to the fix.

I have experienced the same problem some time ago. I did not manage to reproduce it though. One of the volumes had two "daily snapshots" in the database.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1488

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1504

@rhtyd : Can you please re-run the test cases again ?

sure @niteshsarda
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@rhtyd : Thank you.

Packaging result: ✔centos6 ✔centos7 ✔debian.  I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1516

@rhtyd : Can you please re-run the test cases again as results for previous execution is not posted yet?

Tests haven't been kicked yet.
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1532

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1961)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30588 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2373-t1961-kvm-centos7.zip
Smoke tests completed. 66 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File


Create a DataTable for displaying transform logs

Purpose and background context
Display the transform logs for a given run in an organized, navigable format on the 'Run' page of the web app.
How can a reviewer manually see the effects of these changes?
The following screenshots should be sufficient for the review.

See DataTable in 'Run' page.

See message in 'Run' page if no log files found.

See rendered plaintext of sample log file (web app opens new tab in your browser).

Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?

https://mitlibraries.atlassian.net/browse/TIMX-368

Developer

[x] All new ENV is documented in README
[ ] All new ENV has been added to staging and production environments
[x] All related Jira tickets are linked in commit message(s)
[x] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

[ ] The commit message is clear and follows our guidelines (not just this PR message)
[ ] There are appropriate tests covering any new functionality
[ ] The provided documentation is sufficient for understanding any new functionality introduced
[ ] Any manual tests have been performed or provided examples verified
[ ] New dependencies are appropriate or there were no changes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

3 of 10 (30.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 86.321%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

abdiff/webapp/app.py
3
10
30.0%

Totals

Change from base Build<PHONE_NUMBER>8:
-0.5%

Covered Lines:
833

Relevant Lines:
965

💛  - Coveralls


View All Links with Right arrow don't display.

They do once I inspect them in chrome, very strange

These will only show up if you are using something that is considered a "touch" device, in a desktop viewport.