pilot: "What to test is required" when passing "\n" as the changelog parameter

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Pilot upload and build processing succeeds (iTunes Connect sends the "build finished processing" email, even pilot itself logs that "Successfully finished processing the build"), but pilot still fails with an error in the end, probably during setting the changelog afterwards. Also I remember successfully using pilot without passing a changelog parameter at all (though it is already ~2 weeks and iTunes Connect could have changed since then).
Please note that READ_CHANGELOG_SECTION_CONTENT=>"\n", i.e. changelog variable is most probably set to one newline, which is then passed to pilot as the changelog argument. Previous same pilot invocations where changelog was set to some actual non-empty text (i.e. a few sentence) worked fine and fastlane (pilot) did not complain about anything.
If this is really due to the empty (or more precisely "\n") value passed as the changelog parameter, I could work around this by defaulting to e.g. "Bug fixes and stability improvements." value for changelog. I haven't tried that yet however.
Complete output when running fastlane, including the stack trace and command used
[11:47:06]: -------------------
[11:47:06]: --- Step: pilot ---
[11:47:06]: -------------------
[11:47:06]: Login to iTunes Connect<EMAIL_ADDRESS>[11:47:09]: Login successful
[11:47:09]: Ready to upload new build to TestFlight (App: xxxxxxxxxx)...
[11:47:10]: Going to upload updated app to iTunes Connect
[11:47:10]: This might take a few minutes. Please don't interrupt the script.
[11:55:43]: iTunes Transporter successfully finished its job
[11:55:43]: ------------------------------------------------------------------------------------------------------
[11:55:43]: Successfully uploaded package to iTunes Connect. It might take a few minutes until it's visible online.
[11:55:43]: ------------------------------------------------------------------------------------------------------
[11:55:43]: Successfully uploaded the new binary to iTunes Connect
[11:55:43]: If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option
[11:55:43]: Waiting for iTunes Connect to process the new build
[11:56:27]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[11:57:05]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[11:57:44]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[11:58:23]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[11:59:36]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[12:00:14]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[12:00:53]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[12:01:36]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[12:02:14]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[12:02:58]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[12:03:38]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[12:04:20]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[12:05:18]: Waiting for iTunes Connect to finish processing the new build (1.0.0 - 72)
[12:05:48]: Successfully finished processing the build
[12:05:48]: You can now tweet:
[12:05:48]: iTunes Connect #iosprocessingtime 10 minutes
[12:05:50]: Variable Dump:
[12:05:50]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios internal", :GIT_REPO_WAS_CLEAN_ON_START=>true, :BUILD_NUMBER=>"72", :READ_CHANGELOG_SECTION_CONTENT=>"\n", :VERSION_NUMBER=>"1.0.0", :CERT_FILE_PATH=>"/path/to/XXXXXXXXXX.cer", :CERT_CERTIFICATE_ID=>"XXXXXXXXXX", :SIGH_PROFILE_PATH=>"/path/to/AppStore_id.bundle.domain.reverse.mobileprovision", :SIGH_PROFILE_PATHS=>["/path/to/AppStore_id.bundle.domain.reverse.mobileprovision"], :SIGH_UDID=>"xxxxxxxx-0000-1111-2222-yyyyyyyyyyyy", :SIGH_PROFILE_TYPE=>"app-store", :IPA_OUTPUT_PATH=>"/path/to/appname.ipa", :DSYM_OUTPUT_PATH=>"/path/to/appname.app.dSYM.zip", :XCODEBUILD_ARCHIVE=>"/path/to/appname 2016-09-19 11.44.42.xcarchive", :GET_INFO_PLIST_VALUE_CUSTOM_VALUE=>nil}
[12:05:50]: What to Test is required. What to Test is required.

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | ensure_git_status_clean             | 0           |
| 4    | cocoapods                           | 5           |
| 5    | Switch to ios submit lane           | 0           |
| 6    | is_ci                               | 0           |
| 7    | increment_build_number              | 5           |
| 8    | read_changelog                      | 0           |
| 9    | get_version_number                  | 0           |
| 10   | get_build_number                    | 0           |
| 11   | stamp_changelog                     | 0           |
| 12   | git_add                             | 0           |
| 13   | get_build_number                    | 0           |
| 14   | commit_version_bump                 | 0           |
| 15   | add_git_tag                         | 0           |
| 16   | cert                                | 7           |
| 17   | sigh                                | 16          |
| 18   | get_version_number                  | 0           |
| 19   | get_build_number                    | 0           |
| 20   | badge                               | 2           |
| 21   | gym                                 | 132         |
| 22   | upload_symbols_to_crashlytics       | 12          |
| 23   | pilot                               | 1124        |
+------+-------------------------------------+-------------+

[12:05:50]: fastlane finished with errors

Looking for related GitHub issues on fastlane/fastlane...

➡  Pilot external testing validation errors
   https://github.com/fastlane/fastlane/issues/5733 [open] 16 💬
   5 days ago

➡  Generic error: [!] The request could not be completed because: Unexpected Error (I suspect it's due to user error.)
   https://github.com/fastlane/fastlane/issues/5594 [closed] 8 💬
   4 weeks ago

➡  Pilot distribute requiring extra metadata — where to set it?
   https://github.com/fastlane/fastlane/issues/5686 [open] 6 💬
   4 weeks ago

and 20 more at: https://github.com/fastlane/fastlane/search?q=The%20request%20could%20not%20be%20completed%20because:%0A%09What%20to%20Test%20is%20required.%20What%20to%20Test%20is%20required.&type=Issues&utf8=✓

[!] The request could not be completed because:
	What to Test is required. What to Test is required.

ERROR: Build failed: exit status 1

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
    ...
    changelog = read_changelog
    ...
    pilot_args = {
      internal: { distribute_external: false, changelog: changelog },
      beta:     { distribute_external: true },
    }[lane]

    gym(scheme: "biblio", include_bitcode: lane != :internal)
    upload_symbols_to_crashlytics
    pilot_args.nil? ? deliver : pilot(pilot_args)
    git_push_to_remote ...

Environment
fastlane version (run fastlane -v): fastlane 1.103.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? yes
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? yes (rbenv)

@dusek Can you add the --verbose flag to your lane? Are you providing a changelog in deliver?

@dusek I also get the error "What to Test is required. What to Test is required", did you solve it?


fix races in in-memory cache system

Scope & Purpose
Backport of https://github.com/arangodb/arangodb/pull/18243
Partially address https://arangodb.atlassian.net/browse/BTS-1255:
Fix shutdown races (shutdown of a cache could overlap with spawned FreeMemory and Migrate tasks for the same cache, leading to assertion failures because the amount of allocated memory went below zero). This fixes errors we have seen in cache unit tests in devel recently, although the race conditions have been for longer.
In order to prevent the races, a new per-cache _shutdownLock is introduced, which is acquired in exclusive mode by the shutdown, and acquired in shared mode while FreeMemory or Migrate tasks execute. That way the shutdown is mutually exclusive with a cache's task execution.
Note: the shutdown() function of a cache will be called only when the cache manager is being shut down (shutdown of the entire cache subsystem) or when the cache manager's static destroyCache(cache) function is called for a particular cache. The latter happens during index destructors (for indexes with in-memory caches), after truncate() calls (when the caches can be wiped and recreated) and after unload() calls.
Also added more assertions for verifying some of the cache subsystem's memory usage invariants.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[x] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[x] Backport for 3.10: https://github.com/arangodb/arangodb/pull/18265
[x] Backport for 3.9: this PR
[ ] Backport for 3.8: -

Related Information

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

Discussed today whether we should attempt merging this PR into 3.9.10 or delay its merging.
To mitigate risk, we opted for merging it only after 3.9.10 was cut.


where do I install the symbols-0.56.1.zip ?

Provide a description of requested docs changes
where do I install the symbols-0.56.1.zip ?

You don't need them. They are for debugging. Or dou younlike to debug something?

Symbols are for debugging but are closely coupled to the build. Some people want them and they help us debug issues too


Gap between app and bottom edge of screen when maximized

This is a screenshot from Windows 7 where the app is placed on a screen without a taskbar and maximized.

(The red lines were added by a user)
This is a screenshot from Windows 8.1. Weirdly, there seems to be a border before the gap too. i.e. the actual Windows application border / frame. Keep in mind, my app is frameless and transparency is not enabled.

Might be related to #2374 but I doubt it.

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

To be clear, this is what the bottom of my app looks like when not maximized (with my wallpaper behind):

As I said in #3290, this causes the resize cursor to be shown as well (in Windows 8) when moving your mouse over the bottom edge of the app touching the taskbar.
I disabled the show taskbar on all screens setting and maximized it. This is what I saw (while using Window's Magnifier):

The light grey border is noticeable.
We're now using 0.11.6, not sure which version the original report was based on to be honest.

I'm also experiencing the same problem with frameless window when maximized. Problem exists even on second (and third) monitor where is no taskbar. Just 1px tall gap on the bottom of app with vertical resize cursor.
OS: Win 7.
NWJS: 12.0, 12.1, 12.2
screenshot (see red line)


Add Dot component

Description
This PR adds a new component, SageDot, for adding a small colored dot distinctly into a layout or pattern, such as what is currently in the Legend and Statbox.
Screenshots

Testing in sage-lib
See Components > Dot and the same in React
Testing in kajabi-products

(N/A) Adds new SageDot component.

@monicawheeler mind another look now? I've added a comment regarding the Figma spec and fixed the missing color.


Fixing exception handling of GfacServerHandler

@DImuthuUpe looks good! Can you make the changes on your develop branch instead, so we can merge this into develop?

@machristie, this is specific to group-based-auth branch. In develop branch there is no RuntimeException thrown unless you haven't merged group-based-auth to develop. I only have to improve the logs. Shall I do that change or do you expect to merge group-based-auth to develop in future?

@DImuthuUpe the RuntimeException change is on the develop branch: https://github.com/apache/airavata/commit/f5aaf3305418c72856f6927556ae78be6398963d. The develop branch was then merged into the group-based-auth branch at a later point in time which is why the RuntimeException change is also on the group-based-auth branch.
The plan is to periodically merge develop into group-based-auth and then eventually, once the group based auth work is done, merge group-based-auth back into develop.  So for now let's fix this on develop branch.

Closing as this was applied on develop branch


Filter trying to write invalid characters

Even though a Node name may not meet the JCR specification, it is still possible (especially for content migrated from old CQ instances) for bad data to come over.
Grabbit should either filter (not write) bad nodes while logging the error, rewrite the name/property to something legal while logging the error, or fail with a clearer error message.
See GH-114

https://jackrabbit.apache.org/api/1.4/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String) Potentially for reference

Hi @jbornemann
I've tried rewriting the name in ProtoNodeDecorator#getOrCreateNode(Session) method, using https://jackrabbit.apache.org/api/1.4/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String), as well as with https://docs.adobe.com/content/docs/en/cq/5-6-1/javadoc/com/day/cq/commons/jcr/JcrUtil.html#createValidName(java.lang.String)
One issue i found with Text#escapeIllegalJcrChars is it will escape colon(:) as well, so a jcr:content node will be written as jcr%3Acontent in repository.
Additionally, JcrUtil#createValidName will not be much useful either, as it converts a dot(.) and colon(:) into an underscore(_), as in a default.groovy will become default_groovy.
Should i write my own method which will filter only the needed characters viz "[, ]" as given in #114 and may be some others as well ?

Funny enough, that method isn't wrong, in fact ':' is technically an invalid name character according to the spec, and Jackrabbit even admits so in https://wiki.apache.org/jackrabbit/EncodingAndEscaping; however in AEM we freely use it in things like jcr:content, and Jackrabbit seems to not restrict it's use. According to the spec, if you want to use ':', or '[' in your JCR implementation, you are supposed to be map these restricted characters to special private-use code points defined in the spec.
Anyways, since we don't really understand the root cause of this issue, or really if there is a practical issue at all; since we support > CQ 5.6; I would vote no-action on this issue.

@jdigger, @sagarsane what's your take on this one ?

@sagarsane , @jdigger : Should this just be closed?

I think its ok to keep this issue open (in-case we have cases where there is bad data already in AEM 6.x instances and then Grabbit is used to sync) .. but as Jeff said, we may probably not take any action on this right now ..

FYI, #175 is another case of this this happening (like we saw in #114)


Make sure to wait for idle on changeKernel

We aren't waiting for idle when changing kernels.
If we believe idle state is necessary for execution, we should wait for idle.

Codecov Report

Merging #9196 into master will decrease coverage by 0.01%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master    #9196      +/-   ##
==========================================
- Coverage   57.45%   57.44%   -0.02%
==========================================
  Files         551      551
  Lines       29367    29388      +21
  Branches     4445     4450       +5
==========================================
+ Hits        16874    16883       +9
- Misses      11550    11558       +8
- Partials      943      947       +4

Impacted Files
Coverage Δ

src/client/datascience/types.ts
100% <ø> (ø)
:arrow_up:

...ascience/jupyter/liveshare/guestJupyterNotebook.ts
10.47% <0%> (ø)
:arrow_up:

src/client/datascience/jupyter/jupyterNotebook.ts
4.84% <0%> (ø)
:arrow_up:

.../datascience/interactive-common/interactiveBase.ts
17.82% <0%> (ø)
:arrow_up:

src/client/datascience/jupyter/jupyterSession.ts
66.49% <80%> (-0.85%)
:arrow_down:

src/client/common/utils/platform.ts
70.58% <0%> (-5.89%)
:arrow_down:

...ient/datascience/interactive-ipynb/nativeEditor.ts
56.54% <0%> (-0.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f745d...d7f3bf7. Read the comment docs.


BREAKING: Overhaul HTTP headers (make case-insensitive, allow for multiples)

According to spec, HTTP header field names should be treated in a case-insensitive way.
However, so far this was not the case with Weblink. This meant a bunch of things were silently very broken. For example, a Node.js fetch() client could not send POST request bodies: the server was expecting a Content-Length header, but got content-length instead.
This implementation introduces a new abstract HeaderName (and a companion HeaderValue). When implicitly assigning a String to a HeaderName, it simply gets converted to lowercase (plus some ASCII validation). This way it can be used as a key even in default standard library collections and the comparisons would be case-insensitive.
Of course, this means the original string casing is lost – but given that HTTP/2 (not supported currently) forces sent header names to be lowercase, I deemed it an acceptable loss.

Also according to spec, multiple header values with the same name can coexist. They can be either set as separate key-value pairs (i.e. Set-Cookie) or as a comma-separated list (e.g. Accept-Language, If-Match).
Request did not support that usecase. Response did, but made it difficult to query. Both classes now use a specialized collection, a HeaderMap, that allows for multiple values to be associated with one key.

This PR has ballooned more than I expected, so it's time for me to give you a quick status update.
What should work (as I understand it):

[x] Incoming and outgoing headers' names are compared in a case-insensitive way.
[x] Incoming and outgoing headers' names are checked for non-ASCII bytes.
[x] Incoming and outgoing headers' values are checked for control characters.
[x] Incoming headers which are known to have list-type values separate them.
[x] Outgoing headers which are known to have list-type values merge them together.
[x] Outgoing headers which are known to be unique are checked for the existence of multiple values.

What's not done yet, but I'm not sure if I want to cram it into the same patch:

[ ] Incoming header values with "quoted text" do not get recognized and unquoted
[ ] Incoming header values with line continuations ("LWS" in RFC 2616) do not get recognized as a single header.
[ ] Incoming data is not treated as ISO-8859-1, but always as UTF8 (both headers and payload, no matter the MIME type)

This PR has ballooned more than I expected, so it's time for me to give you a quick status update.
What should work (as I understand it):

[x]  Incoming and outgoing headers' names are compared in a case-insensitive way.
[x]  Incoming and outgoing headers' names are checked for non-ASCII bytes.
[x]  Incoming and outgoing headers' values are checked for control characters.
[x]  Incoming headers which are known to have list-type values separate them.
[x]  Outgoing headers which are known to have list-type values merge them together.
[x]  Outgoing headers which are known to be unique are checked for the existence of multiple values.

What's not done yet, but I'm not sure if I want to cram it into the same patch:

[ ]  Incoming header values with "quoted text" do not get recognized and unquoted
[ ]  Incoming header values with line continuations ("LWS" in RFC 2616) do not get recognized as a single header.
[ ]  Incoming data is not treated as ISO-8859-1, but always as UTF8 (both headers and payload, no matter the MIME type)

I'd say split it up, you can group it, back I think we can merge this in, is there any other things you'd like to include in it?

Nah; if there was something I desperately needed to include, I'd set the PR as draft :sweat_smile: How would you like to proceed?

I'll take a look today and most likely merge it.


[BUG] access to _actions

https://github.com/facebookresearch/nle/issues/369

it's fixed by installing the github repo rather than pypi


fix phrase prefix query

it would fail spectacularly when no doc in the segment would match the phrase part of the query

Codecov Report

Merging #2043 (9f8502b) into main (2dfe379) will increase coverage by 0.01%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #2043      +/-   ##
==========================================
+ Coverage   94.43%   94.44%   +0.01%
==========================================
  Files         319      319
  Lines       59633    59651      +18
==========================================
+ Hits        56313    56337      +24
+ Misses       3320     3314       -6

Impacted Files
Coverage Δ

.../query/phrase_prefix_query/phrase_prefix_scorer.rs
72.46% <100.00%> (+0.93%)
:arrow_up:

.../query/phrase_prefix_query/phrase_prefix_weight.rs
83.63% <100.00%> (+3.34%)
:arrow_up:

... and 1 file with indirect coverage changes


PR for #40: Upgrade to storybook v7

Upgrade Storybook (#40)
Seems like the auto loading is still not doing perfect and some views might need a reload of the page some times, but seems to work quite well.

The auto loading though was nothing introduced with the Storybook upgrade, as the issue is also present on the deployed version:

Thank you so much for review and merge!


[TRIAGE] Context Menu document formatting not addressing E501 line too long

When trying to use autopep8 with -> Right click on the python file while open and select Format Document with...  option, nothing happens to the file, meaning it's not getting edited, yet the output of the trace shows the event of formatting,
To use as a double confirmation, I ensure that the issue still exists by checking with pycodestyle.
WINDOWS INFO
Edition	Windows 11 Home Single Language
Version	22H2
Installed on	11/27/2023
OS build	22621.2715
Experience	Windows Feature Experience Pack 1000.22677.1000.0

PYTHON INFO
PS C:\Users\<USER>\Documents\GitHub\tse> py.exe --version
Python 3.12.0

with virtual environment activated
(.venv) PS C:\Users\<USER>\Documents\GitHub\tse> py.exe --version
Python 3.12.0

VSCODE INFO
_Version: 1.84.2 (user setup)
Commit: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e
Date: 2023-11-09T10:51:52.184Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621_

PEP8 ISSUE
`(.venv) PS C:\Users\<user>\Documents\GitHub\tse> pycodestyle --first .\servicioelectoral.py
.\servicioelectoral.py:13:80: E501 line too long (85 > 79 characters)
(.venv) PS C:\Users\<user>\Documents\GitHub\tse> `

Output option for autopep8 shows:

2023-12-06 09:33:57.235 [info] [Trace - 9:33:57 AM] Sending request 'textDocument/formatting - (1)'.
2023-12-06 09:33:57.257 [info] [Trace - 9:33:57 AM] Received notification 'window/logMessage'.
2023-12-06 09:33:57.257 [info] c:\Users<user>\Documents\GitHub\tse.venv\Scripts\python.exe -m autopep8 -
2023-12-06 09:33:57.257 [info] [Trace - 9:33:57 AM] Received notification 'window/logMessage'.
2023-12-06 09:33:57.257 [info] CWD Server: c:\Users<user>\Documents\GitHub\tse
2023-12-06 09:33:57.387 [info] [Trace - 9:33:57 AM] Received response 'textDocument/formatting - (1)' in 152ms.

Restarted VSCODE and enabled Developer Set Log level to Debug for autope8, yet the results when formatting are the same.
Retried additionally with VSCODE as Run as Administrator

2023-12-06 10:25:31.045 [info] c:\Users<user>\Documents\GitHub\tse.venv\Scripts\python.exe -m autopep8 --version
2023-12-06 10:25:31.090 [info] CWD Server: c:\Users<user>\Documents\GitHub\tse
2023-12-06 10:25:31.095 [info] Version info for formatter running for C:\Users<user>\Documents\GitHub\tse:
autopep8 2.0.4 (pycodestyle: 2.11.1)
2023-12-06 10:25:31.132 [info] SUPPORTED autopep8>=1.7.0
FOUND autopep8==2.0.4
2023-12-06 10:27:14.235 [info] [Trace - 10:27:14 AM] Sending request 'textDocument/formatting - (1)'.
2023-12-06 10:27:14.256 [info] [Trace - 10:27:14 AM] Received notification 'window/logMessage'.
2023-12-06 10:27:14.256 [info] c:\Users<user>\Documents\GitHub\tse.venv\Scripts\python.exe -m autopep8 -
2023-12-06 10:27:14.257 [info] [Trace - 10:27:14 AM] Received notification 'window/logMessage'.
2023-12-06 10:27:14.257 [info] CWD Server: c:\Users<user>\Documents\GitHub\tse
2023-12-06 10:27:14.390 [info] [Trace - 10:27:14 AM] Received response 'textDocument/formatting - (1)' in 156ms.

@thecircleoflifefree We run autopep8 and provide whatever it returns to VS Code. This seems like an issue with autopep8. You can verify this by running this.
> type .\servicioelectoral.py | python -m autopep8 -

Be sure to have autopep8 installed in your environment when running it from terminal. The builtin autopep8 is not available to the terminal.


[ENG-4536] Add create_parameterized_notebook method to NoteableClient

Codecov Report

Merging #35 (67c69b5) into main (7d87bc5) will decrease coverage by 0.07%.
The diff coverage is 69.44%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   71.85%   71.78%   -0.08%
==========================================
  Files          10       11       +1
  Lines        1169     1205      +36
==========================================
+ Hits          840      865      +25
- Misses        329      340      +11

Impacted Files
Coverage Δ

origami/client.py
55.17% <37.50%> (-0.36%)
:arrow_down:

origami/types/jobs.py
78.57% <78.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d87bc5...67c69b5. Read the comment docs.


script/system to refresh active browser window (esp on file change)

firefox doesn't really provide these tools - look into utilities that interact with the window manager like ydotool

useful for web dev when you don't have a fun dev server

this is done already i think?


Smaller feature requests

Hi,
I had some ideas and a smaller issue.
Currently its not possible to let the table fill up the full height right?

IsExpanded (fill available full height and width)
Styling for header area
Footer with paging
Actionbar (would be nice to have only. Maybe a default widget where you can add actions like on appbar)

If it would be possible the actionbar on top and footer with paging would be even cooler.

Hi @Sesa1988 !
The table follows the layout constraints like any other Flutter widget ok? Or at least it should :-). So, the table will fill in height depending on your layout constraints. For example, if you put it inside an Expanded in Column, it will fill all the available height.
About the Footer and Actionbar, maybe you can do it yourself using your layout and controller. I still don't have an opinion on how much it's worth leaving this free for everyone to do on their own or if it's worth making the API more complex and providing something ready.
And about styling, I will do it soon.

@Sesa1988, I'm doing some customizations on #18 ok?

@Sesa1988, I'm doing some customizations on #18 ok?

@caduandrade okay, lets close this one then.


WSGL: Create a shim layer to call slang Compilation API from RUST

Since we probably have to use compute toys https://compute.toys as the tempale for our slang palyground, we need to add support of compiling slang code into WGSL. However, the compile engine of compute toys is written in Rust, we need to add some code to be able to call slang library by Rust.

You can also call JS code from Rust, right? That may be another way. I don't know which way is cleaner/faster for this project.

Close this issue as we will not go this way.


Separate about contact

closes #386
Before

After

mobile

@ijemmao In the last repo I had tried the fetch upstream feature on GitHub to pull in the changes
I think that's what caused the tests to fail. This time round I decided to use Git instead.

@ijemmao I tried to trigger github actions by making small changes but it seems
the linters are somehow stuck. Been like this for a whole week

@inezabonte merged! The hanging ESLint actions don't seem to be related to your changes. Good work!


added java and properties feature documentation and examples for MicroProfile

Added Java and .properties feature documentation and examples for "Tools for MicroProfile".
Fixes #64
Signed-off-by: Alexander Chen<EMAIL_ADDRESS>

Adding Java features


how to select specific audio when there are multiple audios ?

how to select specific audios when there are multiple audios ? like curiosity stream in some site they have multi audio options, so i want to know how to download with multi audios or any specific audio ?

Try using some audio parameters in the -f parameter string, such as acodec or abr: see FORMAT SELECTION in the manual.

can you tell what string will for for different and different audio ? here is the log,
hls-audio_group-Audio_media_FMP4__audio_preview_en  mp4        audio only [en] hls-audio_group-Audio_media_FMP4__audio_preview_es  mp4        audio only [es] dash-d286aa05-e5bd-4230-820e-d2f64c0f8f64           m4a        audio only [Español] DASH audio  160k , m4a_dash container, mp4a.40.2 (48000Hz) dash-de29ad97-b193-4f9f-864d-97f1a151ab18           m4a        audio only [English] DASH audio  160k , m4a_dash container, mp4a.40.2 (48000Hz) dash-9d49bead-51c0-4c45-b6c3-8ec8a6d8bf26           mp4        640x360    DASH video  145k , mp4_dash container, avc1.64001E, video only dash-24c609d6-83c0-4638-93dc-8a09403224b0           mp4        640x360    DASH video  253k , mp4_dash container, avc1.64001E, video only hls-308                                             mp4        640x360     308k , avc1.64001E, video only hls-415                                             mp4        640x360     415k , avc1.64001E, video only dash-1e0891ea-de46-4652-a7c0-b5cd822a2dba           mp4        960x540    DASH video  468k , mp4_dash container, avc1.64001F, video only hls-633                                             mp4        960x540     633k , avc1.64001F, video only dash-d801d607-3aaf-42b2-bade-22bfbd0fc717           mp4        1280x720   DASH video  890k , mp4_dash container, avc1.64001F, video only hls-1026                                            mp4        1280x720   1026k , avc1.64001F, video only dash-c2b36b3a-1b74-4166-bb1a-1ca82fb117da           mp4        1920x1080  DASH video 1691k , mp4_dash container, avc1.640032, video only hls-1888                                            mp4        1920x1080  1888k , avc1.640032, video only dash-57491a53-9f51-47c6-871b-e5a18eed4dc3           mp4        1920x1080  DASH video 2825k , mp4_dash container, avc1.640032, video only hls-3026                                            mp4        1920x1080  3026k , avc1.640032, video only dash-58da607d-715a-4598-9b97-488cb5c601bf           mp4        2560x1440  DASH video 4929k , mp4_dash container, avc1.640032, video only hls-5202                                            mp4        2560x1440  5202k , avc1.640032, video only dash-e234d7fd-432e-4751-b8dd-1bd60fb9d838           mp4        2560x1440  DASH video 8598k , mp4_dash container, avc1.640032, video only hls-9080                                            mp4        2560x1440  9080k , avc1.640032, video only dash-27c82869-93e4-4a12-8791-5f7f9678c5b3           mp4        3840x2160  DASH video 15000k , mp4_dash container, avc1.640033, video only hls-15674                                           mp4        3840x2160  15674k , avc1.640033, video only (best)

So the question is a good one: how do you select one out of several alternative audio tracks, when the tracks are not just different versions (quality, encoding, eg) of the same audio?
The manual is silent on selecting by language but a general solution is to run yt-dl with -F first to get a list like the one you posted and find the format_ids for the video and audio that you want, then run yt-dl with-f video_id+audio_id (supposing you want a combined media file with video and audio). In the above case:
-f hls-3026+dash-de29ad97-b193-4f9f-864d-97f1a151ab18
If the selection criterion between the two runs could be codified, there could be a script to do the whole thing.
By all means provide a test URL.
It would seem to be a reasonable feature request to add lang to the set of audio parameters that can be filtered on for format selection like acodec) -- if it's not supported already.


stop old containers before starting new ones

auto-cleanup process required
@ejr004 wanna take a look at this? I'll merge issue_27 into master and you can take it from here. I am almost done with the main deploy stage logic

docker nw needs take down with the containers. How to do it ?

docker network rm simple

If we do a
docker swarm leave

on all nodes, the network will be automatically deleted.

I am working on this @ejr004 . I'll create two types of rollbacks. One for deploy stage rollback and other for a full rollback to the install stage

The following commands can be used on the CM to rollback to a particular stage. The rollbacks also do the needful on LC nodes.
puppet apply -e "simple_grid::deploy::config_master::rollback"

puppet apply -e "simple_grid::pre_deploy::config_master::rollback"

puppet apply -e "simple_grid::config::config_master::rollback"


[Bug]: Invalid compilation error given when creating a new error value from an error type with intersection in an imported module

Description
$title
Note that this works if we don't use the error-type-reference in the error constructor. It should work with that also.
Because of this issue, autocompletion also does not work with that particular case. Need to see to that also.
For example after the :, the error-type-reference is not suggested.
LibTest:InvalidDocumentError err44 = error LibTest:

Steps to Reproduce
Create a package having a type defined like the below in the main.bal.
public type DocumentError distinct error;

public type InvalidDocumentError distinct (DocumentError & error<record {| string[]? errors; |}>);

Say the Ballerina.toml is like this for the above package.
[package]
org = "nadeeshand"
name = "LibTest"
version = "0.1.0"

Publish that to the local Ballerina repository using the below commands.
bal pack
bal push --repository local

Then create another package and try to create an error value using the imported error type.
Balleriana.toml
[package]
org = "nadeeshand"
name = "testPrj"
version = "0.1.0"

[[dependency]]
org = "nadeeshand"
name = "LibTest"
version = "0.1.0"
repository = "local"

Code in the main.bal which gives the compilation error.
import ballerina/io;
import nadeeshand/LibTest;

public function main() {
    LibTest:InvalidDocumentError err4 = error("err", errors = []); // works
    io:println(err4);

    LibTest:InvalidDocumentError err44 = error LibTest:InvalidDocumentError("err", errors = []); // does not work
    io:println(err44);
}

The above gives compilation error.
Compiling source
        nadeeshand/testPrj:0.1.0
ERROR [main.bal:(8:48,8:76)] cannot create a new error value from 'LibTest:InvalidDocumentError'
error: compilation contains errors

Affected Version(s)
Ballerina 2201.3.2 (Swan Lake Update 3)
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

After fixing this can add tests here.

Duplicate of https://github.com/ballerina-platform/ballerina-lang/issues/38346?

Duplicate of #38346?

It seems so. Hence I will close this issue. Thank you very much for pointing this out!


fix(versions): update Activiti/example-runtime-bundle versions into master

UpdateBot pushed maven dependency: org.activiti.cloud.rb:activiti-cloud-runtime-bundle-dependencies to: 7.1.163

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.rb:activiti-cloud-runtime-bundle-dependencies 7.1.163


added name to contributors

can u please add some comments and also have u checked the output of the code


Adding Datastax support for Metadata and TestIO

Adding Datastax support for MetadataIO
Creating TestIO for Astyanax & Datastax as required by tests

Coverage increased (+0.3%) to 75.572% when pulling ee790c7d5c1424d933a5f137745093d05e60497c on usnavi:metadata_datastax2 into 1844cef53754e40289752af104e7f2f3247e2374 on rackerlabs:master.

Can you also remove the AstyanaxReader.getMetadataValues() and AstyanaxWriter.writeMetadataValue() methods? Replace all calls to these methods with the corresponding MetadataIO methods.

@shintasmith  - updated PR

Coverage increased (+0.1%) to 75.606% when pulling c96c026e0d106a07a4d50d6c75ea80ca1097cbff on usnavi:metadata_datastax2 into b061dc28509bfe563edb38ee4795760d3b174b01 on rackerlabs:master.

Coverage increased (+0.3%) to 75.725% when pulling c96c026e0d106a07a4d50d6c75ea80ca1097cbff on usnavi:metadata_datastax2 into b061dc28509bfe563edb38ee4795760d3b174b01 on rackerlabs:master.

@shintasmith @VinnyQ @ChandraAddala - all updates save improving the queries with async queries & prepared statements.

:+1:  \0/ :dancers:

Coverage increased (+0.2%) to 75.678% when pulling 5bb886112c65e27cf4d05e2e3445e1c7aec513dc on usnavi:metadata_datastax2 into b061dc28509bfe563edb38ee4795760d3b174b01 on rackerlabs:master.


Fix middleware error handling

Design notes for this version:
The RequestValidationError mostly shouldn't happen unless we've made a programming error (mismatch between the frontend form and the backend Pydantic request model). If it does happen, we are rendering the "validation_error.html" file.
The PasswordValidationError is a bit more mission critical, because users may occasionally encounter this, and we want the logic to be re-usable for validation of inputs to other forms. As much as possible in all such cases, we should prevent invalid inputs with HTML and Javascript pattern-matching on the frontend so that users don't reach "validation_error.html".
Previously I was manually handling this validation in the body of the API endpoint. Now I am handling validation with a Pydantic-powered dependency in the function signature. I like how this separates concerns, and it allows me to handle the redirect behavior centrally from middleware.
In the previous version, I was redirecting back to the page with an error toast. The good thing about that pattern is that the user doesn't have to navigate back to the page. The bad thing is that it clears the form data and doesn't separate out validation from other concerns. Now I am rendering a separate error page, "validation_error.html". The disadvantage of this is that the user has to click "Go Back" to return to the page and try again. The advantage is that this back-navigation preserves the user's form inputs.
I experimented with some approaches to using error toasts in a way that would preserve form data. It's possible, but unfortunately you can't pass context in a redirect. If you are redirecting from the body of the API endpoint, you could pass the form inputs as query parameters. But this will expose the user's password inputs in the URL, which is bad. And you can't use this approach from our Pydantic field validators anyway. A better approach would be to use session middleware to get the form data from the session request object. But that requires an additional dependency, so I skipped it for now.


Updated fully_connected kernel to work with embARC MLI Library 2.0 for ARC

[3/11]
This PR brings updates for ARC fully connected kernel to support embARC MLI Library 2.0 as an experimental feature.
BUG=#86

@advaitjain Updated this one, thank you.


Could you possibly mentioned version number?

I am using Windows 10 Version IIS version 20H2 for x64 Systems. and when I am trying PoC and perdform manually using burpsuit. It is showing 400 response.
Could you help me out?
Version details

PoC

If you Google the OS build number, it shows up as being the May 2021 update
which patches the issue.
Le sam. 22 mai 2021 à 02:02, PunitTailor55 @.***> a
écrit :

I am using windows 10 and when I am trying PoC it is showing 400 response.
[image: image]
https://user-images.githubusercontent.com/38101321/119220911-609e8280-bb0a-11eb-8cac-e2f069bca7e2.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/0vercl0k/CVE-2021-31166/issues/5, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALIORIIXBBVEZNLGXC7I3DTO5XKHANCNFSM45KOEPIA
.

It is vulnerable to Windows 7 I have tested on same.

Ha interesting - thanks for sharing :)
Le dim. 23 mai 2021 à 12:17, PunitTailor55 @.***> a
écrit :

It is vulnerable to Windows 7 I have tested on same.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/0vercl0k/CVE-2021-31166/issues/5#issuecomment-846611362,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALIORO45RK6QSKG3BE4ZD3TPFIFHANCNFSM45KOEPIA
.


steps aren't scrollable

I'm trying to add many horizontal steps but I can't because steps aren't scrollable
@shang1219178163
@Michele-x98

ListView is a better choose!

@YahyaYousef i open about it.

Still giving me overflow in horizontal

@gabrieloliv96 I opened a Pull Request with the ListView feature for the Horizontal Stepper, i hope it will merge it.
Before the merge, try it my version.
@shang1219178163


Travis CI is sadly not what it was before maybe it should be removed

I suggest that you remove the Travis CI config file as it is now an expensive product that cost 69$ per month or more...
Your documentation examples could show how to use Azure DevOps Services CI/CD or other third parties examples, some are suggested by Adam Gordon Bell in the blog link below:

January 7, 2021 · Many open-source projects are still using Travis and open-source maintainers are notoriously overworked.  Time spent migrating builds is time not spent on other things.  Large well-maintained projects will likely quickly transition but for many smaller projects, an abrupt change in a service they depend on is a huge challenge.
― Adam Gordon Bell https://earthly.dev/blog/migrating-from-travis/

Azure DevOps Services
When you sign up for Azure DevOps, you get the following tier of free services:

First five users free (Basic license)
Azure Pipelines:

One Microsoft-hosted CI/CD (one concurrent job, up to 30 hours per month)
One self-hosted CI/CD concurrent job

Azure Boards: Work item tracking and Kanban boards
Azure Repos: Unlimited private Git repos
Azure Artifacts: Two GiB free per organization

― Maybe duplicate of rushstack #3646

I agree 👍

Fixed in https://github.com/microsoft/rushstack-websites/pull/105


Fixes to scrolling on annotations page

fixed text alignment problem (Use ctrl to zoom in..)
filling of the empty space on Y axis (before only free space on X axis was used when zooming)
domtoimage browser dependency warning(works on Firefox/Chrome, warns on other browsers)

@LachlanStuart thank you for the review, I actually just saw that you left it, as there was surprisingly no message to my email. Will change the alert message to native element-ui style.

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   81.01%   81.01%
=======================================
  Files          28       28
  Lines        2007     2007
=======================================
  Hits         1626     1626
  Misses        381      381

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2186e9...a3a4b29. Read the comment docs.

@Ren22 We are introducing a new team policy. The creator of a PR is responsible for merging it. If you need a confirmation or help, you ask for a review.

@intsco got it, thanks for letting me know!

@Ren22 Oh, and we also agreed to do "Squash and Merge" instead of just "Merge"

@Ren22 this too


Avoid model overfitting

I adapted this model to a text classification problem, where my text is concated as:
[start] text1 [delimiter] text2 [delimiter] text3 [classify]
and it is just a binary classification problem. So use F.softmax for the model output and use BCE loss.
I have 120,000 training examples, and 10,000 evaluation examples. n_ctx is set to be 500. For one epoch, it takes about 7 hours (1 GPU).
When I use lm_coef = 0.5, I found that the training accuracy on my training dataset is 0.9, but dev accuracy is just 0.66. More epochs doesn't improve the accuracy for evaluation dataset.
So this is exactly overfitting. I am looking for suggestions about what I can tune to make it not overfit, in either model of training settings?

After fixed some data processing issue, my current performance is:
Epoch 1: train accuracy: 0.8593   dev accuracy: 0.7004, train_loss: 13.87, dev_loss: 20.79
Epoch 2: train accuracy: 0.9206   dev accuracy: 0.7157, train_loss: 10.63, dev_loss: 22.20
With more epochs, the dev_loss will keep growing, and accuracy is similar.
I found that the model has 116,531,713 trainable parameters. So I thought maybe the network is too big and remembers even 120,000 training examples. However, as the ROCStories only has less than 2000 examples, it doesn't get overfit. I don't know why my own data will get overfitting.

Had the same issue with imdb sentiment analysis. Would appreciate some pointers here...

Have you found any good way to regularize the network?

Add smoothing and dropouts

Any answer on this. How to avoid overfitting on smaller data-points. Is dropout only option?


Add multitouch support for zoom while editing in Edge and IE11

Multitouch support works when viewing the map on openstreetmap.org, but when you go into edit the map, multitouch no longer works. It would be wonderful for editing on touch compatible devices to enable the following:

Single finger drag - pans the map around
Double finger drag - Zoom in and out of the map. Snaps to the closest zoomlevel on release.
Single finger tap - On an object, selects that object. On empty space, deselects any selected objects.

@omgitsgela Thanks for opening this! iD already supports these gestures, at least on iOS devices. If it's not working for you then it might be a device- or browser-specific bug. Can you give more details about your setup?

Hmm it looks like iD doesn't support touch gestures on IE 11 or Edge, that must be what you mean. This could be fixed via #5505.

For me this problems also happens on chrome though (77.0.3865.105 (Official Build) (64-bit))  on a chromebook with a touch screen

So I'm pretty sure I fixed this but I don't have a touchscreen Chromebook or Windows device to test on.
@omgitsgela @thibaultmol Would you mind seeing if pan and zoom touch interactions work for your devices on our development preview site? https://2-x--ideditor.netlify.com/

On chromebook (ChromeOS 120), no matter one finger or two, we can drag east, west etc. but at the same time we end up also zooming.


Make hostname in moma admin tab table bold

use  for row header
use <th scope"col"> for col headers
add  - sectin in additon to head and body


Auto-restart scheduler in shoot maintenance

How to categorize this PR?

/area ops-productivity robustness
/kind enhancement
/priority normal
What this PR does / why we need it:
The kube-scheduler is now auto-restarted in the shoot maintenance time window, similar to other controllers.
Which issue(s) this PR fixes:
Fixes #2722
Special notes for your reviewer:
As #2731 is still in discussion, I'm making this change now separately and rebase the PR later if necessary.
Release note:

The `kube-scheduler` is now auto-restarted in the shoot maintenance time window, similar to other controllers.

/invite @timuthy

We initially stared with restart for cloud-controller-manager, then we did the same for kcm and mcm, now we do it also the kube-scheduler in this PR. This sounds like we bury/workaround issues? Are there occurrences of kube-scheduler Pod which "hangs" for some reason? If yes, shouldn't we rather try to understand the root cause?

@ialidzhikov I don't think there are clear steps to reproduce the problems that we see (luckily very rarely). If you can help here it's highly appreciated to tackle the root cause in the first place, sure, but until then this one-time auto-restart in the maintenance time window is a simply thing to improve the ops experience.


Display bug -- foldcolumn + non-ASCII-expansion

(Tested with Vim 8.0.124)
A nonzero foldcolumn interacts badly with expanded (e.g. non-ASCII) characters to produce incorrect screen display.
To reproduce, using test file demo.txt:
  % vim
  :vsp demo.txt
  :set foldcolumn=2
  :vert resize 100

All good so far.  But now do:
  :vert resize 105

Result:

the first screen line is still displayed correctly
but the second screen line has disappeared
If you type $, the cursor goes to somewhere that looks way off in never-never land -- but in fact it's just where it should be, i.e. where the final "t" in "output" would be if it were visible

Additional notes:

The bug manifests if the line wraps after either the "<" or "8" of the "<82>" expansion.

If you use ^W< and ^W> to play with the window's width, you'll see that second line blinking in and out of visibility as the wrap point scans across the characters of the "<82>" expansion
With foldcolumn=2 as described until now, wrapping after the "2" displays correctly, but if you :set foldcolumn=3, then readjust to wrap after the "2", the problem recurs

If I replace the 0x82 character in the buffer with a literal string "<82>", the bug no longer manifests.  It's expanding one buffer character into several screen characters, not the specific screen characters chosen, that seems to matter

This does not seem to be a termcap/terminfo problem:

It's not the case that the missing text is output by vim but not displayed by the terminal; rather, vim doesn't output it at all.  Proof:

demo.txt contains exactly one instance each of "!", "#", and "%"
I've reproduced the bug under script(1), and verified that the captured output does not contain any "!", "#", or "%" characters; ergo, vim didn't write them to stdout
N.B.: The recipe shown above won't allow such a simple test, since the file is displayed correctly on first loading, but the variant that's attached as bug-script.txt will do so -- it postpones loading the file until the window has been adjusted to a "bad" configuration

in fact, the problem occurs in gvim too

I cannot reproduce this problem. It works as expected. Try running with vim -u NONE -N --noplugin Also see the faq

I hadn't tried that; should have done; thanks for the reminder.  (BTW, the FAQ doesn't mention --noplugin, but does suggest a couple of other options.  So I tested with the union of them:
vim -u NONE -U NONE -N -i NONE --noplugin.)
Testing that way, I do still see the problem, in both text and graphic modes.

Since it's not trivially reproducible, I'll dig deeper -- I have a couple of VMs I can try it on (Ubuntu 16.04; FreeBSD 11.0).  I'll get to that this afternoon.
Also, here's the output from vim --version on the already-tested 12.04 system.

So, I was afraid I might have done something embarrassingly dumb re. encodings.  I'm now pretty sure that's not the case -- but convincing myself of that took quite a while...
Suffice to say (and since you're the FAQ's author, I doubt I'm telling you anything new, but I'll say it anyway):

The demo.txt file I've provided is in UTF-8, so obviously vim needs to be convinced to treat it as such
The bug only manifests if Vim's internal encoding is UTF-8, i.e. :set encoding=utf-8; if instead you set it to ISO 8859-1, the file's U+0082 gets converted to a single-byte 0x82 in the buffer, which gets displayed as ~B, which vim handles perfectly

(This digression means I haven't done the cross-platform tests I mentioned.  If they'd still be helpful, please let me know.)

ah yes I can reproduce it. Will look into it. thanks.

posted a patch here

That fixes it.  (Plus, the test passes :) )
Danke schön.


Bug in latest module

I just picked up the HS300. Using 1.1.0.
instance(plug-vc): Error checking feedback: Cannot read property 'state' of undefined
Feedback works OK. The actions (on/off/toggle) do NOT work

Do you get the error when trying to run the action?

Power On and Power Off sometimes work.
Power Toggle gives the error.

I pushed a fix for this in the feedbacks, let me know if it still persists.

looks good, thanks!


fix(registry): recorganise registry tests order and fix a should(say()) call

@helgi code LGTM, although e2e failed :(


Don't Merge! PR real time test for target branch full build

Docs Build status updates of commit fb1ebd0:
:clock10: Full build: the average full build time is 7 min(s) 34 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit fb1ebd0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


fix(errors): we should be checking the result.Error as well as tags

Related - https://github.com/ar-io/ar-io-network-process/pull/205

:tada: This PR is included in version 2.5.0-alpha.8 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[vm/ffi] Support unions

The FFI currently only supports structs, we should add support for unions as well.

Untagged unions should be fairly easy to add in a manner similar to structs:
class MyUnion extends Union {
  @Int8()
  int a;

  Pointer<MyStruct> b;

  @Float()
  double c;
}

For them to be useful, we might want to add nested structs (#37271) and inline fixed-size arrays (#35763) first though.
cc @mkustermann

Any update for this feature? Right now I'd like to implement the SendInput function from the winapi, which requires an INPUT array structured as such
typedef struct tagINPUT {
  DWORD type;
  union {
    MOUSEINPUT    mi;
    KEYBDINPUT    ki;
    HARDWAREINPUT hi;
  } DUMMYUNIONNAME;
} INPUT, *PINPUT, *LPINPUT;

and seems like right now this is not possible.

No update yet.
For the example you provided, you would actually need a union nested in a struct, which requires the nested structs/unions feature in addition (https://github.com/dart-lang/sdk/issues/37271).

Brief summary of offline discussion @sstrickl @askeksa-google @mraleph:

In our API and error messages use 'struct' or 'union' as that's what the C spec does and what the C grammar does.
In our implementation have a shared _Compound superclass for conceptual sharing and implementation sharing. (Use 'compound' over 'composite', because composite has a different meaning in the C standard.)

@alexlapa bugs in dart:ffi can be reported here. Bugs with package:ffi can be reported in dart-lang/ffi. I've opened a new issue to investigate this.


Multi Children Node

<books>
  <book>
    <title>book1</title>
    <price>10</price>
  </book>
  <book>
    <title>book2</title>
    <price>20</price>
  </book>
</books>

I try to parse this xml, yet I get something very peculiar
{ books:
   { book:
      [ { title: [ 'book1' ], price: [ '10' ] },
        { title: [ 'book2' ], price: [ '20' ] }
      ]
   }
}

The array title: [ 'book1' ] is kinda annoying to read, so I try to build a xml with a similar json
{ books:
   { book:
      [ { title: 'book1', price: '10' },
        { title: 'book2', price: '20' }
      ]
   }
}

and xml2js yields the xml string exactly the same as the one I given before.
So is it possible to optimize the parsing xml process?
My test code:
var xml2js = require('xml2js');
var parseString = xml2js.parseString;
var builder = new xml2js.Builder();

var obj = {
  'books': {
    'book': [
      { 'title': 'book1', 'price': 10 },
      { 'title': 'book2', 'price': 20 }
    ],
  }
};
var xml = builder.buildObject(obj);
console.log(xml);

parseString(xml, function(err, data) {
  if (err) throw err;
  console.dir(data, {depth: null});
});

I found that to be slightly annoying as well. I found the plural -> singular -> actual values annoying too.
But the codebase works wonders and I 100% understand why it's done like that.
That being said, I didn't sit still:
let cleanXML = (xml) => {
	let isInt = /^-?\s*\d+$/,
		isDig = /^(-?\s*\d+\.?\d*)$/,
		radix = 10;

	Object.keys(xml).forEach((node) => {
		let value, singulars,
			l = -1, i = -1, s = -1, e = -1;

		if(xml[node] instanceof Array && xml[node].length === 1){
			xml[node] = xml[node][0];
		}

		if(xml[node] instanceof Object){
			value = Object.keys(xml[node]);

			if(value.length === 1){
				l = node.length;

				singulars = [
					node.substring(0, l - 1),
					node.substring(0, l - 3) + 'y'
				];

				i = singulars.indexOf(value[0]);

				if(i !== -1){
					xml[node] = xml[node][singulars[i]];
				}
			}
		}

		if(typeof(xml[node]) === 'object'){
			xml[node] = cleanXML(xml[node]);
		}

		if(typeof(xml[node]) === 'string'){
			value = xml[node].trim();

			if(value.match(isDig)){
				if(value.match(isInt)){
					l = parseInt(value, radix);

					if(Math.abs(l) <=<PHONE_NUMBER>740991){
						xml[node] = l;
					}
				}else{
					l = value.length;

					if(l <= 15){
						xml[node] = parseFloat(value);
					}else{
						for(i = 0, s = -1, e = -1; i < l && e - s <= 15; ++i){
							if(value.charAt(i) > 0){
								if(s === -1){
									s = i;
								}else{
									e = i;
								}
							}
						}

						if(e - s <= 15){
							xml[node] = parseFloat(value);
						}
					}
				}
			}else{
				xml[node] = value;
			}
		}
	});

	return xml;
};

This will turn xml[books][book] into xml[books], xml[nightlies][nightly] into xml[nightlies].
This will safely convert integer and floats that JavaScript can handle into integers or floats. (I know there are already options for this, but they would convert out-of-bounds integers into integers and that can really mess up the data.
RE: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_SAFE_INTEGER

It works as intended.
To use it then like that
var title = obj.books.book[0].title.[0];

Imagine you have some config file, you don't want to read it, you need to work with it, access the values from any place.


gui: add filter to Charts based on Start/End path type

Resolve #5000

@oharboe @maliberty Would you happen to know a design in which we'd have all the path start/end type for a more consistent test?

@oharboe @maliberty Would you happen to know a design in which we'd have all the path start/end type for a more consistent test?

Try designs/asap7/mock-array/Element

@maliberty I tried on mock-array/Element:

Why are IO to REG listed with clock and reg to io listed with ?
IO - IO have no clock. This isn't entirely surprising, it is a max delay path only. Can this path be shown in the endpoint slack histogram? If so, under what clock, if any? Add "" to endpoint histogram?
register to register paths exist with "clock".
"No filter" and "Register to register" show the same. The other filters show now end-paths.

No endpoints shown in histogram:

When it first loads I see:

which appears to be equivalent to

Would you set the initial state to "No Filter"

@AcKoucher is looking at the lack of IO related paths

The set of clocks is not filter dependent and just shows what are defined in the design.

If I click on one of the buckets, I get a filtered list in Timing Report. I think the same dropdown filter would be useful in the Timing Report.
I am sure this raises some questions to sort through...

If I choose "Register to register" (or any non-filtered), I get a crash:
untar gui-crash.tar.gz
$ ./run-me-mock-array_Element-asap7-base.sh
OpenROAD v2.0-13792-g7457e3a7e
Features included (+) or not (-): +Charts +GPU +GUI +Python
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
read_spef ./results/asap7/mock-array_Element/base/6_final.spef
Signal 11 received
Stack trace:
 0# 0x00006335527B8693 in openroad
 1# 0x0000729FC5C42990 in /lib/x86_64-linux-gnu/libc.so.6
 2# std::_Rb_tree_increment(std::_Rb_tree_node_base const*) in /lib/x86_64-linux-gnu/libstdc++.so.6
 3# gui::ChartsWidget::fetchConstrainedPins(std::set<sta::Pin const*, std::less<sta::Pin const*>, std::allocator<sta::Pin const*> >&, bool) in openroad
 4# gui::ChartsWidget::changeStartEndFilter() in openroad
 5# 0x0000729FC6F06312 in /lib/x86_64-linux-gnu/libQt5Core.so.5
 6# QComboBox::currentIndexChanged(int) in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
 7# 0x0000729FC7C732E6 in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
 8# 0x0000729FC7C76C5B in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
 9# 0x0000729FC7C76ECB in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
10# 0x0000729FC6F0602D in /lib/x86_64-linux-gnu/libQt5Core.so.5
11# QComboBoxPrivateContainer::itemSelected(QModelIndex const&) in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
12# QComboBoxPrivateContainer::eventFilter(QObject*, QEvent*) in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
13# QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) in /lib/x86_64-linux-gnu/libQt5Core.so.5
14# QApplicationPrivate::notify_helper(QObject*, QEvent*) in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
15# QApplication::notify(QObject*, QEvent*) in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
16# QCoreApplication::notifyInternal2(QObject*, QEvent*) in /lib/x86_64-linux-gnu/libQt5Core.so.5
17# QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
18# 0x0000729FC7BC886A in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
19# 0x0000729FC7BCB12F in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
20# QApplicationPrivate::notify_helper(QObject*, QEvent*) in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
21# QCoreApplication::notifyInternal2(QObject*, QEvent*) in /lib/x86_64-linux-gnu/libQt5Core.so.5
22# QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) in /lib/x86_64-linux-gnu/libQt5Gui.so.5
23# QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) in /lib/x86_64-linux-gnu/libQt5Gui.so.5
24# 0x0000729FC1EF9F7E in /lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
25# 0x0000729FC5F13B2C in /lib/x86_64-linux-gnu/libglib-2.0.so.0
26# 0x0000729FC5F6F46F in /lib/x86_64-linux-gnu/libglib-2.0.so.0
27# g_main_context_iteration in /lib/x86_64-linux-gnu/libglib-2.0.so.0
28# QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) in /lib/x86_64-linux-gnu/libQt5Core.so.5
29# QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) in /lib/x86_64-linux-gnu/libQt5Core.so.5
30# QCoreApplication::exec() in /lib/x86_64-linux-gnu/libQt5Core.so.5
31# gui::startGui(int&, char**, Tcl_Interp*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool) in openroad
32# ord::tclAppInit(Tcl_Interp*) in openroad
33# Tcl_MainEx in /lib/x86_64-linux-gnu/libtcl8.6.so
34# main in openroad
35# 0x0000729FC5C28150 in /lib/x86_64-linux-gnu/libc.so.6
36# __libc_start_main in /lib/x86_64-linux-gnu/libc.so.6
37# _start in openroad
./run-me-mock-array_Element-asap7-base.sh: line 7: 11889 Segmentation fault      (core dumped) openroad -no_init -gui ${SCRIPTS_DIR}/gui.tcl

@oharboe The changes is this draft are neither ready for testing nor review.

@oharboe Results for the the element test case of your previous comment:
All endpoints:

Filters:

@AcKoucher Perfect! Ready for testing?

@oharboe Yes. Go ahead :)

@AcKoucher Should the same dropdown filter be available from the Timing Report menu?
Of course I can click on one column in the filtered histogram, which gives me the top paths in for that filter in that slack range, so I have what I need.
I'm unsure if that complication to the GUI is worth the potential benefit.

@oharboe Well, something to have in mind is that we're dealing with an endpoint slack histogram. The report that you get from clicking in a certain range gives you the paths of those endpoints, but that doesn't mean you'll get only the paths within that filter.
An endpoint shown in the reg2reg filter might as well appear in the io2reg filter. That's why the "no filter" option - which presents all the endpoints - is not necessarily a superposition of the filtered ones.

@AcKoucher My domain knowledge isn't up to the task of saying what exactly would be useful here. The limited case that I am interested in and think I understand is that every macro must have timing closure for all reg2reg paths, because those paths are no longer visible where the macro is used as the .lib file doesn't contain information about those paths anymore.

@AcKoucher But from a usability point of view, it is surprising that clicking on an empty column can show paths in the Timing Report. And purely from a usability point of view, surprises should be minimized...

Hmm.... choosing a filter is much slower than showing the no-filter version of the histogram. Is that expected.
Still running minutes later....
A few suspend in debugger shows no debug info(so release build) and the code is gnawing on the same bone:

@oharboe That is expected, because for and endpoints we just get the worst slack to show in the histogram. For the filters we have to query the paths from sta based on the start/end combination which can be slow if there are a lot of endpoints.
As for the empty column I agree with you and I think it shouldn't be that way either, I'll wait for @maliberty 's input.

@AcKoucher Thanks for the clarification. So how much slower could it be? Looks stuck here. I'm thinking 1 minute for the first one and still running after 20 minutes or so.

@oharboe I need to make some more testing to confirm. Perhaps there's more to it.

The filter did complete in the end, perhaps an hour compared to 1 minute with no filter?

Let's prove the viability of this before we worry about adding it to the timing report.

Viability in the sense that it needs to be fast enough or something else?

"No filter", less than a second. reg2reg, 1 hour?

@oharboe Do you have any idea of how much time does the Timing Report update on the GUI takes in this test case you're using?

I tried on make DESIGN_CONFIG=designs/sky130hd/microwatt/config.mk cts gui_cts and the filter is acceptably fast. Less than a minute.
So I think that the performance problem is for large designs, such as ours and possibly megaboom. Those designs are known to have serious performance problems that must be carefully worked around already, such as disabling timing reports in builds, skipping timing repair in cts, disable power analysis/fixing, etc.

@maliberty @AcKoucher  I think this is ready to merge, it is fast on the larges sky130hd/microwatt design.
That it is slow on larger designs is a separate concern from this PR.


Create firmware status message

Software please merge ❤
Thanks,
Firmware

Makes sense. This should be ready to merge now. Let me know if there any other issues.


if shut down handray  .then air tap is not able to do .

Describe the bug
A clear and concise description of what the bug is.
To reproduce
Steps to reproduce the behavior:

Go to build simple  example just close HandRay
air tap  no enable  event to clicked method

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Your setup (please complete the following information)

Unity Version 2019.4.6f and 2020.1.0f1c1
MRTK Version  2.4  and 2.5

Target platform (please complete the following information)

HoloLens 2

Additional context
Add any other context about the problem here.

Are you expecting HoloLens 1 style interaction (cursor always in the middle, air tap to select) after turning off the hand rays? Also you can reply in Chinese if you prefer.

是的，我希望那样做。因为手射线选择不够准确。希望头来选择点。然后手势确定是这个点。

如果您程序中所有的交互都希望不使用hand ray的话，可以在MixedRealityToolkit GameObject -> Inspector -> Input -> Pointers -> Pointer Options里找到Prefab为DefaultControllerPointer的项目（应该在最上面），然后在controller type下拉菜单中去除Articulated hand。之后再在这个列表的最下方找到Prefab为GGVPointer的项目，然后在controller type下拉菜单中添加Articulated hand。如果您不知道如何修改profile的话请参阅https://microsoft.github.io/MixedRealityToolkit-Unity/Documentation/Profiles/Profiles.html和https://microsoft.github.io/MixedRealityToolkit-Unity/Documentation/MixedRealityConfigurationGuide.html
更多信息请见这篇文档：https://microsoft.github.io/MixedRealityToolkit-Unity/Documentation/Input/Pointers.html#pointer-options-configuration


Re-hash files on commit

This PR re-hashes every entry—we could look at the file metadata for modification timestamps if we want, but I wasn't sure how reliable those are + the actual hashing step doesn't seem too costly (since oxen add is typically very fast) - but open to handling differently!

Looks great to me!


-OutImod 1 causes a segfault

Hi Shawn,
I am running AreTomo2 with the following command -
AreTomo2 -InMrc in.mrc -AngFile in.rawtlt -VolZ 0 -OutBin 0 -TiltAxis 84.7 -AlignZ 250 -TiltCor 1 -OutImod 1 -DarkTol 0 -OutMrc out.mrc -Gpu 0
which results in a segfault error. Any idea why this is thecase? -OutImod 2 works
I am on version
AreTomo2 version 1.0.0
Built on Oct 02 2023

This does not happen in
AreTomo2 version 1.1.3
Built on Aug 19 2024
BUT the tlt angle values are all 0.

I met the same error, but strangely the same command sometimes reported the error and sometimes worked well.


inlineStyleThreshold does not create a style tag with adapter-static

Describe the bug

While #2620 created an option to inline CSS, the config does not currently add style tags when using adapter-static. I've created a minimum reproducible repo and added some initial exploration notes to #962. Although the value for inlineStyleThreshold gets read, it gets overwritten by the options function in kit/src/core/config/index.js.
Reproduction
https://github.com/newsroomdev/sveltekit-static-no-inline-styles contains two commits:

First: Initial commit generated by npm create svelte@latest
Second: Removes Sverdle and adds adapter-static

Logs
No response
System Info
System:
  OS: macOS 12.6.1
  CPU: (10) arm64 Apple M1 Pro
  Memory: 2.88 GB / 32.00 GB
  Shell: 3.5.1 - /opt/homebrew/bin/fish
Binaries:
  Node: 16.18.0 - ~/.nvm/versions/node/v16.18.0/bin/node
  Yarn: 1.22.19 - ~/.nvm/versions/node/v16.18.0/bin/yarn
  npm: 8.19.2 - ~/.nvm/versions/node/v16.18.0/bin/npm
Browsers:
  Brave Browser: <IP_ADDRESS>
  Chrome: 107.0.5304.87
  Firefox: 105.0.1
  Safari: 16.1
npmPackages:
  @sveltejs/adapter-auto: next => 1.0.0-next.86
  @sveltejs/adapter-static: next => 1.0.0-next.47
  @sveltejs/kit: next => 1.0.0-next.532
  svelte: ^3.46.0 => 3.52.0
  vite: ^3.1.0 => 3.2.2

Severity
serious, but I can work around it
Additional Information
No response

The inlineStyleThreshold is a SvelteKit specific option, so it shouldn't be at the top level, but inside config.kit. @newsroomdev can you check again with that?

Good catch; user error on my part. Thank you @gtm-nayan


Using split reduction to convert an inner-reduction into outer reduction + inner-parallel dimension, followed by simple inner reduction.

Hey @pzread @hanhanW , do you know why benchmarks are not triggering for this PR? Should @vmurali be granted some extra permissions or something?

Hey @pzread @hanhanW , do you know why benchmarks are not triggering for this PR? Should @vmurali be granted some extra permissions or something?

Yeah... There is a weird issue on buildkite that I haven't had time to look. Invited @vmurali to our buildkite team as a work around.

Thanks Jerry; I don't think I have received the invite yet.
On Thu, Sep 29, 2022 at 10:37 PM Jerry Wu @.***> wrote:

Hey @pzread https://github.com/pzread @hanhanW
https://github.com/hanhanW , do you know why benchmarks are not
triggering for this PR? Should @vmurali https://github.com/vmurali be
granted some extra permissions or something?
Yeah... There is a weird issue on buildkite that I haven't had time to
look. Invited @vmurali https://github.com/vmurali to our buildkite team
as a work around.
—
Reply to this email directly, view it on GitHub
https://github.com/iree-org/iree/pull/10537#issuecomment-1263123662, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABZURPLYGCKOESKKJVU3GDWAZ37DANCNFSM6AAAAAAQU5G7JE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks @pzread

I've seen that you keep pushing commits. Is the PR ready for review? If not, you can convert it to a draft PR.

It was ready, but issues propped up. I have made it a draft for now.

@vmurali broad comment before I look into details. Please add a flag to guard the split-reduction. It associatively reorders the computation (even if the guard is always true for now). There might be better ways to do this in the long term, but at least adding a flag for now would be useful.

Hey @pzread @hanhanW , do you know why benchmarks are not triggering for this PR? Should @vmurali be granted some extra permissions or something?

Yeah... There is a weird issue on buildkite that I haven't had time to look. Invited @vmurali to our buildkite team as a work around.

Thanks! Is there a way to retrigger the benchmark pipelines? They don't seem to be running even after pushing new commits.

@vmurali broad comment before I look into details. Please add a flag to guard the split-reduction. It associatively reorders the computation (even if the guard is always true for now). There might be better ways to do this in the long term, but at least adding a flag for now would be useful.

It could be the same as https://github.com/iree-org/iree/issues/10279

Hey @pzread @hanhanW , do you know why benchmarks are not triggering for this PR? Should @vmurali be granted some extra permissions or something?

Yeah... There is a weird issue on buildkite that I haven't had time to look. Invited @vmurali to our buildkite team as a work around.

Thanks @pzread

The benchmarks run now, but I am not able to see the results table.

The benchmarks run now, but I am not able to see the results table.

It failed at build. Seems that there are compilation errors in some models: https://buildkite.com/iree/iree-benchmark-android/builds/4327#01838ce6-6a2f-4d8c-96be-9721c6307eb2
You can build models locally:
# Enable -DIREE_BUILD_BENCHMARKS in cmake
cmake src/ -DIREE_BUILD_BENCHMARKS
cmake --build . --target iree-benchmark-suites

The benchmarks run now, but I am not able to see the results table.

It failed at build. Seems that there are compilation errors in some models: https://buildkite.com/iree/iree-benchmark-android/builds/4327#01838ce6-6a2f-4d8c-96be-9721c6307eb2
You can build models locally:
# Enable -DIREE_BUILD_BENCHMARKS in cmake
cmake src/ -DIREE_BUILD_BENCHMARKS
cmake --build . --target iree-benchmark-suites

Where did you get that link from? I now see buildkite running with the following two links (both are pending): https://buildkite.com/iree/iree-benchmark-android/builds/4347 and https://buildkite.com/iree/iree-benchmark-linux/builds/1559

The benchmarks run now, but I am not able to see the results table.

It failed at build. Seems that there are compilation errors in some models: https://buildkite.com/iree/iree-benchmark-android/builds/4327#01838ce6-6a2f-4d8c-96be-9721c6307eb2
You can build models locally:
# Enable -DIREE_BUILD_BENCHMARKS in cmake
cmake src/ -DIREE_BUILD_BENCHMARKS
cmake --build . --target iree-benchmark-suites

Where did you get that link from? I now see buildkite running with the following two links (both are pending): https://buildkite.com/iree/iree-benchmark-android/builds/4347 and https://buildkite.com/iree/iree-benchmark-linux/builds/1559

yeah, I re-triggered it because I did not see the benchmarks in checks.
You can click Details on

And clicking the branch name (e.g., vmurali:murali_iree) leads you to previous results.

@vmurali After you push the next commit, if the benchmarks don't run, can you try to remove the labels and add them again?

It looks like I am still not able to generate the benchmark tables after running the checks @pzread, @hanhanW

Looks like they are running now
https://buildkite.com/iree/iree-benchmark-android/builds/4411
https://buildkite.com/iree/iree-benchmark-linux/builds/1630

Performance results:
https://gist.github.com/iree-github-actions-bot/09a2bb55a134d210206d0d3c4abf01ff

Wow, 8-10% improvement is a lot, taking into account that this only triggers for reductions in generic ops! Well done!
I would expect the only regression on Pixel to be noise? It's also suspicious that we don't see changes in RVV dispatch sizes. I would expect some variation there. I'll give it a try once integration lands.

Wow, 8-10% improvement is a lot, taking into account that this only triggers for reductions in generic ops! Well done! I would expect the only regression on Pixel to be noise? It's also suspicious that we don't see changes in RVV dispatch sizes. I would expect some variation there. I'll give it a try once integration lands.

I just added the android one (the previous two were both linux). Not sure if linux+Pixel is run in the linux benchmark.

Thanks for addressing all the feedback. I added a few more comments. LGTM once you address those! Thanks

Thanks for the LGTM. I have made the changes that you had asked (except for renaming the option). I will wait till you and Jakub finish integration of llvm-fork before I push this.

PR itself is fine. Could you split the PR to have the cherry pick separate.

I don't think there's any cherry pick here.

PR itself is fine. Could you split the PR to have the cherry pick separate.

I don't think there's any cherry pick here.

The changes to LLVM project need to go into a separate PR?

PR itself is fine. Could you split the PR to have the cherry pick separate.

I don't think there's any cherry pick here.

The changes to LLVM project need to go into a separate PR?

I am not going to push this PR until integrate happens (and that includes my PR in LLVM), @hanhanW

https://github.com/iree-org/iree/issues/9981


Map16 Tiles

This PR introduces parsing and displaying Map16 tiles which are the building blocks of Objects out of which levels in SMW are built.
So far, most tiles are correctly assembled from tileset data:

However, most of it looks a bit weird. For comparison, here's Lunar Magic's Map16 viewer:

As you can see, our Map16 viewer maps most of the colours incorrectly and doesn't properly support animated tiles. That's what we'll be focusing on in the next commits to this PR.

Colours are fixed for most tiles. Berries and animated blocks are still broken.

Tiles with animated colours are displayed correctly!

I'll get this merged and eventually get back to work on animations in a separate PR.


Update with changes made in fuel v2 contracts

There have been a few changes made to this library on fuel-v2-contracts.

Solidity updated to 0.8.9
Added explicit imports
Missing MockCryptography
Bugfix in Utils.sol

For the cryptography stuff, only the hashing function is actually used, right? Since this is a pure library there's no need for all the signature stuff.

For the cryptography stuff, only the hashing function is actually used, right? Since this is a pure library there's no need for all the signature stuff. IMO the Cryptography.sol here and in v2 are different libs for different use cases.

So we want to remove all the signature code from this library? I figured the signature logic and it's tests would be helpful in this library.

Can you file a follow-up issue to make a CI workflow test with solc v0.8.4 in addition to the current v0.8.9? Should test the minimum version.

I reverted the CI workflow to test with solc v0.8.4 like it was before this PR. Testing with v0.8.9 would happen in fuel-v2-contracts CI workflow. You're saying the CI workflow for this project should test two solidity version?

You're saying the CI workflow for this project should test two solidity version?

It should at least test the minimum version supported by the SPDX identifier, along with the latest Solidity version. This could be done in a separate PR since it's unrelated.


Missing folder /Config/Presets/Lightroom

Huh, for some reason git didn't notice that folder. Should be there now...


GraphQL integer filtering on Zero

Environment

Nautobot version (Docker tag too if applicable): 2.3.x
Python version: 3.11
Database platform, version: postgres
Middleware(s): N/A

Steps to Reproduce

Set an MTU on an interface on a device, such as  ams01-edge-01 / Ethernet1/1 link

In igraphql put in the below request

{
  interfaces(mtu:0) {
    name
    device {
      name
    }
  }
}

Expected Behavior
Filter out integers that are 0 (all other ones work.
Issue is likely from graphql reacting differently to this line then the api does. It seems to work correctly in rest api

Observed Behavior
It does not filter on anything

Alternate test
{
  prefixes(prefix_length: 0) {
    network
  }
}

working in API: https://demo.nautobot.com/api/ipam/prefixes/?prefix_length=0


Replace the jump [src] text with an icon

before:

after:

@crowlKats
I changed to use the default text hover style. It looks subtle but okay? (or do we need add background color?)

hm seems a bit too subtle, so maybe yea, a background color would be nice

@crowlKats done! PTAL:


Fix mesh library remove selected item menu option

Fixes #45969. The "Remove Selected Item" in the Mesh Library menu now removes the selected item from the MeshLibrary item list inspector list.

Thanks!

@akien-mga I think something went wrong during the rebase. The original changes are lost, so the merged pr fixes nothing.
I haven't verified in depth that your change of p.get_slice_count("/") >= 3 to 2 is required, but it works. Essentially it just requires that no field needed to be selected (item/0) instead of item/0/name or something like that. I don't know if it is possible to select only the item/0 in the tree without selecting a field below it.
At least this diff is required to the current master (a4c2d8d) to make it work (these are the original changes).
--- a/editor/plugins/mesh_library_editor_plugin.cpp
+++ b/editor/plugins/mesh_library_editor_plugin.cpp
@@ -232,8 +232,8 @@ void MeshLibraryEditor::_menu_cbk(int p_option) {
                } break;
                case MENU_OPTION_REMOVE_ITEM: {
                        String p = InspectorDock::get_inspector_singleton()->get_selected_path();
-                       if (p.begins_with("/MeshLibrary/item") && p.get_slice_count("/") >= 2) {
-                               to_erase = p.get_slice("/", 3).to_int();
+                       if (p.begins_with("item") && p.get_slice_count("/") >= 2) {
+                               to_erase = p.get_slice("/", 1).to_int();
                                cd_remove->set_text(vformat(TTR("Remove item %d?"), to_erase));
                                cd_remove->popup_centered(Size2(300, 60));
                        }

Indeed, I messed up the rebase. I'll push a fix tomorrow, or feel free to make a PR now with that change.

@akien-mga If you haven't already, I made a PR: #73150

Cherry-picked for 3.6.

Cherry-picked for 3.5.3.


Recommended aproach for building external conan recipes in CI

I'd like to build a package from Conan Center in CI with custom choice of CONAN_OPTIONS and compilers. Is it there any easy way to make CPT build, test, and upload binaries of that external package instead of "local" conanfile.py? Or is there any other recommended approach for this case?

CPT is used to generate a matrix of builds. If you are looking for a set of builds, I strongly recommend using lockfiles instead: https://docs.conan.io/en/latest/versioning/lockfiles.html#how-to-use-lockfiles-in-ci

No, i think I need to generate build matrix. Otherwise I don't understand how can I obtain such lock files in the first place

To clarify : this is not about local builds, but about generating matrix of binary packages in ci for uploading to repository

I'm using CPT to generate matrix of builds, for example in my fork of ICU recipe I use this matrix  for ICU, and this one for libxml2. Now both packages are in Conan Center and it's not possible to synchronize with upstream by rebasing my branch, so I wonder what migration path should be chosen.

In this case no. CPT is projected for local builds. You will need a script to download all files, build and upload.


Set an env variable to write the docker volume names

Docker volume names should be a parameter of the project.
See EUDAT-B2STAGE/http-api#15

I should do this on the base template (pdonorio/restapi-template) and then pull it from the original repo, back here

Available from fec8070935e65597ee4b00fbcecdfca523470945


lxd/projects: Use expanded devices/config when checking for limits

Signed-off-by: Stéphane Graber<EMAIL_ADDRESS>

Added a simple test now.

Thanks!


Permission Denied error when running su -c command

I've got a hook that looks like this:
  {
    "id": "test",
    "execute-command": "/bin/su",
    "pass-arguments-to-command": [
      {
        "source": "string",
        "name": "gitbot"
      },
      {
        "source": "string",
        "name": "-c"
      },
      {
        "source": "string",
        "name": "'~/typeit/updateAndRedeploy.sh'"
      }
    ]
  }

When the hook is executed I get this error:

[webhook] 2019/09/19 13:13:05 [5e3873] executing /bin/su (/bin/su) with arguments ["/bin/su" "gitbot" "-c" "'~/typeit/updateAndRedeploy.sh'"] and environment [] using  as cwd
[webhook] 2019/09/19 13:13:05 [5e3873] command output: bash: ~/typeit/updateAndRedeploy.sh: Permission denied
[webhook] 2019/09/19 13:13:05 [5e3873] error occurred: exit status 126
[webhook] 2019/09/19 13:13:05 [5e3873] finished handling test

However I'm able to execute this command when running as root:

su gitbot -c '~/typeit/updateAndRedeploy.sh'

How can I execute the command successfully via a hook?

I doubt this is an issue with webhook, but... What user is webhook running as?  What are the permissions on ~/typeit/updateAndRedeploy.sh?

webhook is running as root.

root      9543  1714  0 13:20 pts/0    00:00:00 webhook -hooks /etc/webhook/hoo s.json -verbose

the script file is executable by all

-rwxrwxr-x 1 gitbot gitbot   67 Sep 19 12:47 updateAndRedeploy.sh

Try prepending the command parameter with bash (ie. -c '/usr/bin/bash /home/gitbot/typeit/...').  I'm also a fan of using absolute paths instead of the tilde.

Removing the tilde seems to have helped and I can now run the command.  However I need to change the working directory and my attempt at doing so breaks things again.
From the command line this works:
su gitbot -c 'cd /home/gitbot/typeit ; /home/gitbot/typeit/updateAndRedeploy.sh'
However prepending the change directory command:
{
    "id": "test",
    "execute-command": "/bin/su",
    "pass-arguments-to-command": [
      {
        "source": "string",
        "name": "gitbot"
      },
      {
        "source": "string",
        "name": "-c"
      },
      {
        "source": "string",
        "name": "'cd /home/gitbot/typeit ; /home/gitbot/typeit/updateAndRedeplo$
      }
    ]
  }

Results in permission denied again.

[webhook] 2019/09/19 14:24:48 [9a5d0f] executing /bin/su (/bin/su) with arguments ["/bin/su" "gitbot" "-c" "'cd /home/gitbot/typeit ; /home/gitbot/typeit/updateAndRedeploy.sh'"] and environment [] using  as cwd
[webhook] 2019/09/19 14:24:48 [9a5d0f] command output: bash: cd /home/gitbot/typeit ; /home/gitbot/typeit/updateAndRedeploy.sh: Permission denied

I've worked around my latest issue by modifying the updateAndRedeploy script to deal with running from any path.
Thanks very much for your help.


Add infinite scrolling prompt generation

What

Use the babble package to infinitely generate words for the target string.
Modify the view to display a page consisting of the last x lines of y target words (x and y are configurable), scrolling as the user completes lines.

Demo

Why
A time-based typing test should never run out of words before the time runs out. It should also test the user with a wide variety of words.
Additionally, the user should always be able to see some number of words ahead of the word that they are typing so that they may read ahead while typing. Having words to type shouldn't be a limiting factor in the speed at which they type.
Notes

Generating words is possibly costly since for each generation, we need to filter ALL the words used by babble by the configured max length. This will be addressed in a follow-up adding another word source.
This also addresses the edge case of deleting the first word in a page. The behavior is that the user can only scroll forwards, not backwards. They cannot delete past the first word of the current page, even if there is a previous word which is not correct.

The babble docs mention this, but in case anyone hits it: you need /usr/share/dict/words present on your system o/w you get a panic

the paging is so 🤌

@kartik-s Yeah I'm not a huge fan of the dependency on the unix words being present, it's also funny because babble on windows just defines an array with all the dictionary words 🥲
Maybe we can pivot away from it in the future or copy that list of words, https://github.com/ideapeople/stronglytyped/pull/17 adds a common words file too that will probably end up being the default words we use.


[Spring]validate path exist before all steps

Verify that artifact-path and source-path exist before all steps in az spring app deploy, az spring app deployment create and az spring job deploy commands.
Related command

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[ ] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Spring

close for not merge


Patch mistake made in patchDuplicateKeyUsage

What this PR does / why we need it:
Patch mistake made in patchDuplicateKeyUsage and write tests for it for the case of a double signing key usage.
Which issue this PR fixes:
fixes https://github.com/jetstack/cert-manager/issues/3274
Special notes for your reviewer:
Was made before some error in the logic made it not fully functional.
/cherry-pick v1.0
Release note:

Fix logic in patchDuplicateKeyUsage when signing and digital signature were set

/kind bug

/unhold

/cherry-pick v1.0

/cherry-pick release-1.0


It seems that comfyui-reactor-node, ComfyUI_LayerStyle, and comfyui_controlnet_aux, the three plugins, cannot work together perfectly no matter what. The issue lies in the opencv dependency package.

No matter how I adjust the version of the opencv dependency package, the three plugins, comfyui-reactor-node, ComfyUI_LayerStyle, and comfyui_controlnet_aux, cannot work together simultaneously. For more details, please refer to https://github.com/chflame163/ComfyUI_LayerStyle/issues/5.

It seems that they sloved this issue.
Please update your comfyui-reactor-node and make sure your opencv-python, opencv-contrib-python, opencv-python-headless and opencv-contrib-python-headless are in the same version.


[RE] feature/Claudia-4395

Reviewers
@jesuspg  @hmunfru
Description
Rename the name property of the pom files: CLAUDIA-4395
Minor changes
Testing
Locally

package names should be in lowercase

it looks ok, mainly you have change the group id and the package name. I have already assembly the project and it seems it works

LGTM


[AST 6.0] Exaltation to CDDT

I'll start on this one

this should have been closed with PR#1397 I believe

this should have been closed with PR#1397 I believe


Is External authorization able to monitor internal traffic ?

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
Hi Recently we are trying to build a external authorization model followed by this link
https://istio.io/latest/docs/tasks/security/authorization/authz-custom/
We notice that by config the authorization on the app istio-ingressgateway it will make sure all the request outside of the cluster will be redirected to external auth server. but we also want to control the A&A within the cluster.
meaning service A will consume service B . this request will also redirect to external auth server.
How can we do that ?
We thought the by changing the name space and matchLabels we can apply the auth internally
for example
apiVersion: security.istio.io/v1beta1
kind: AuthorizationPolicy
metadata:
  name: ext-authz-internal-01
  namespace: our own namespace
spec:
  selector:
    matchLabels:
      auth: authz
  action: CUSTOM
  provider:
    name: "ext-authz-http"
  rules:
  - to:
    - operation:
    -

but using label doesn't work and by changing the name space all internal request become 403 and didn't even handled by authz .
Do you know where is the problem is ?
Describe alternatives you've considered
Affected product area (please put an X in all that apply)
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

Also looks like authorization policy only work with label with app:  when we want to class several service into one label with auth=true it does not work

It works with any label selector -- your config specified app: service B. You could have specified auth: "true"

@howardjohn Sorry the comment auth=true is the kubectl command I refer. the config file is configured as auth: "true" .

I change the content to avoid confusion . We are choosing a different label and in the authrizationPolicy we try to use that label to control multiple applications by adding same label. But like what I stated. The authorization policy setting seems only recognize label with app

The 403 code means the request is rejected by the authorization policy, please follow the troubleshooting guide (https://istio.io/latest/docs/ops/common-problems/security-issues/#ensure-proxies-enforce-policies-correctly) to get the envoy logs to understand why the request is rejected by authorization policy.

Closing as there is no followup


Adjust scroll behavior when elements resize

fix https://github.com/microsoft/vscode/issues/193231
The previous behavior changed depending on whether the resizing element was only partially visible.
This will drop that variability and instead, just prevent the resizing element from leaving the view entirely.

@joaomoreno - could you take a look at the change to listview.updateElementHeight here? I don't think there's a better way to manually adjust the scroll top at the same time that an element is resized, but I'm open to suggestions.

with https://github.com/microsoft/vscode/pull/193833 to take care of the inconsistent anchor behavior, this will take care of https://github.com/microsoft/vscode/issues/193835 instead, which is not as impactful

Now that https://github.com/microsoft/vscode/pull/193833 is merged and https://github.com/microsoft/vscode/issues/193231 is fixed, what is the actual bug that this PR fixes? Can you show me a repro video, so I can repro myself locally?

Holding off review until https://github.com/microsoft/vscode/issues/193231 is stabilized.

closing this for now after the improvements from https://github.com/microsoft/vscode/issues/194516.
We'll see if we get any feedback that makes us revisit.


add git hooks

the issue is #22 .

[x] add git hooks when commit

I think add some eslint config, and then modify the precommit script.

👍


docs(recipes): prisma usage

Resolves #38
Work In Progress
Also waiting for full compatibility.

Prisma has just released a Nuxt module today so the guide could be updated to use that :) https://www.prisma.io/blog/introducing-prisma-nuxt

Everything looks good here from us @prisma. Let me know if I can help any further!

Hey @atinux & @smarroufin: can we help with anything to merge this PR? Thanks!