Remove exception on traceIds of length 15

References https://github.com/openzipkin/zipkin/pull/3249#discussion_r553047076
From the linked PR it seems this exception was incorrectly added as the code would prepend a trace of length 15 with a single leading zero (just like it would add two leading zeros for a trace of length 14).

thanks for the fix @rogierslag!

Shall we release a patch?

yeah and then have zipkin-reporter-java consume it. I'm not sure if something else should go into the release here or not (ex if the docker images which seem to have been updated recently, should be consumed here)


NIFI-9854: Include slf4j-api as runtime scope for nifi-stateless-syst…

…em-test-suite; When constructing the classes to block for the stateless ClassLoader, allow through any classes that come from Java Home's lib/ directory

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

reviewing...


DOM duplication with component in {{#each}} block and unshift

Prepending an item to a list that is rendered as a bunch of inline components seems to get an offset wrong somewhere: with each new unshift, one more item from the tail of the list stops being rendered, and instead, you get two, then three, ... copies of the first item (the one you just unshifted).
Minimum demo: https://jsfiddle.net/h2Lufo38/3/
Everything works fine if you append instead (using push).
PS. Tested with 0.7.3 (broken), dev branch 9766109ca (works)

Fixed on edge http://jsfiddle.net/h2Lufo38/4/

Funnily enough, it works with <Breaky bar="{{.bar}}" />
https://jsfiddle.net/h2Lufo38/6/

I believe this is pretty similar:
https://github.com/ractivejs/ractive/issues/2147


Add an option to resize CtrlItemSlot icons

CtrlItemSlot icons can only be displayed in their original size. It would be nice to have the option to scale them to any size.

The icon_scaling property has been added to CrtlItemSlot in v2.3.8


Added a function to delete a symlinked file recursively.

Pull Request Test Coverage Report for Build 5804

8 of 16 (50.0%)  changed or added relevant lines in 1 file are covered.
30 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.06%) to 43.322%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-exec-server/src/main/java/azkaban/container/FlowContainer.java
8
16
50.0%

Files with Coverage Reduction
New Missed Lines
%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractJob.java
2
37.93%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractProcessJob.java
3
54.64%

azkaban-exec-server/src/main/java/azkaban/execapp/JobRunner.java
4
76.55%

azkaban-exec-server/src/main/java/azkaban/execapp/event/JobCallbackRequestMaker.java
21
56.25%

Totals

Change from base Build 5795:
-0.06%

Covered Lines:
15942

Relevant Lines:
36799

💛  - Coveralls

Pull Request Test Coverage Report for Build 5804

8 of 16 (50.0%)  changed or added relevant lines in 1 file are covered.
30 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.06%) to 43.322%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-exec-server/src/main/java/azkaban/container/FlowContainer.java
8
16
50.0%

Files with Coverage Reduction
New Missed Lines
%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractJob.java
2
37.93%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractProcessJob.java
3
54.64%

azkaban-exec-server/src/main/java/azkaban/execapp/JobRunner.java
4
76.55%

azkaban-exec-server/src/main/java/azkaban/execapp/event/JobCallbackRequestMaker.java
21
56.25%

Totals

Change from base Build 5795:
-0.06%

Covered Lines:
15942

Relevant Lines:
36799

💛  - Coveralls


Update Node to current LTS (12.13.1)

Merged! Don't forget to sync to master and redeploy your apps at your leisure


BGP not working in 1.10.10

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

Install cilium 1.10.10 using the documented helm command https://docs.cilium.io/en/v1.10/gettingstarted/bgp/
Create the configmap with the required addresses and peers
deploy a service of type loadbalancer

Expected:
The service gets an IP assigned
A BGP session is created between peers
Routes to the service are propagated
Actual:
The service gets an IP assigned
A BGP session is created between peers
Routes are NOT propagated
Cilium Version
1.10.10
Kernel Version
5.10.102
Kubernetes Version
1.21
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

By the way, this works perfectly fine in 1.11.4

@ldelossa might this be related to https://github.com/cilium/cilium/pull/18358, looks like it went to 1.11 but potentially not marked for 1.10?


Add toolchain file

Describe the feature
The rustfmt.toml file currently implement some formatting rules that are only available in nightly.

<-- snip -->
Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `comment_width = 100`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `binop_separator = Back`, unstable features are only available in nightly channel.
Warning: can't set `trailing_semicolon = false`, unstable features are only available in nightly channel.
Warning: can't set `trailing_comma = Vertical`, unstable features are only available in nightly channel.
Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `comment_width = 100`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `binop_separator = Back`, unstable features are only available in nightly channel.
Warning: can't set `trailing_semicolon = false`, unstable features are only available in nightly channel.
Warning: can't set `trailing_comma = Vertical`, unstable features are only available in nightly channel.
Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `comment_width = 100`, unstable features are only available in nightly channel.

Proposed Solution
Add a rust-toolchain.toml file to select the nightly toolchain.
[toolchain]
channel = "nightly"

Additional context
No response

This is not planned; our code is supposed to work on stable only, but our lints are nightly. This is also outlined in the contributing docs:

cargo +nightly fmt -- --check
cargo +nightly clippy --all --all-features -- -D warnings

https://github.com/paradigmxyz/reth/blob/main/CONTRIBUTING.md#resolving-an-issue

Apologies should have read that. Thanks!

Why does Reth need nightly for formatting and lints?
This approach is somewhat non-standard, and introduces a bit of friction with some people's Rust tooling. Previously when contributing to Reth I was manually reverting the semicolon changes made by my editor running stable rustfmt, where the trailing_semicolons = false setting was ignored. To make matters worse, the semicolons introduced by stable rustfmt are not removed when running rustfmt +nightly (I guess because the lint is unstable and conservative). I've finally got a better setup now by hardcoding an exception for Reth in my vimrc:
if expand('%:p:h') =~ 'reth'
  let g:rustfmt_command = "rustfmt +nightly"
endif


Make sure to define order of execution

Maps in Go are by definition
unordered (https://golang.org/ref/spec#Map_types). This ensures steps
are done in order.

nice, this makes sense. don't know why i didn't think of that


Solo self hosting

I'm trying to create a single instance of sync using the solo approach without creating OAuth apps. I added the LINEAR_API_KEY and GITHUB_API_KEY to the .env file.
The app is still taking me to the OAuth pages of both Github and Linear. Is there  a way to trigger the sync and automatically create the webhooks?

Created OAuth apps and deployed the app.


Potential new data source for 7.2.1

From Olaide:

The source only has one data point but there are 2 data points in the GIF. The data point found (2018) is different from the one quoted in the GIF. There is a need to verify the data point. Here is a potential data source - https://trackingsdg7.esmap.org (Renewable energy share in the total final energy consumption - 22.2%, 22.8%, 22.3%, 22.6% in 2018, 2017, 2016 & 2016 respectively).

Use CIF 7.3.1 data source


Restic maintenance is failing

Output of restic version
restic version
restic 0.9.6 compiled with go1.13.4 on linux/amd64

How did you run restic exactly?
Running from inside restic pod in velero setup.
restic prune --repo=s3:https://HOST:PORT/prd-icp-ahs-backup-bucket/restic/kube-system
enter password for repository:  repository f29a6b48 opened successfully, password is correct created new cache in /root/.cache/restic counting files in repo building new index for repo [4:06] 100.00%  25088 / 25088 packs repository contains 25088 packs (199502 blobs) with 97.956 GiB processed 199502 blobs: 0 duplicate blobs, 0 B duplicate load all snapshots find data that is still in use for 132 snapshots [0:02] 100.00%  132 / 132 snapshots found 138297 of 199502 data blobs still in use, removing 61205 blobs will remove 0 invalid files will delete 6773 packs and rewrite 1947 packs, this frees 29.891 GiB Save(<data/18997d80df>) returned error, retrying after 626.286518ms: client.PutObject: Error response code QuotaExceeded. Save(<data/18997d80df>) returned error, retrying after 529.936996ms: client.PutObject: Error response code QuotaExceeded. Save(<data/18997d80df>) returned error, retrying after 1.53600189s: client.PutObject: Error response code QuotaExceeded. Save(<data/18997d80df>) returned error, retrying after 2.019463592s: client.PutObject: Error response code QuotaExceeded. Save(<data/18997d80df>) returned error, retrying after 2.59154515s: client.PutObject: Error response code QuotaExceeded. Save(<data/18997d80df>) returned error, retrying after 2.005900769s: client.PutObject: Error response code QuotaExceeded. Save(<data/18997d80df>) returned error, retrying after 3.749385269s: client.PutObject: Error response code QuotaExceeded. Save(<data/18997d80df>) returned error, retrying after 9.459231532s: client.PutObject: Error response code QuotaExceeded. Save(<data/18997d80df>) returned error, retrying after 18.904414573s: client.PutObject: Error response code QuotaExceeded. Save(<data/18997d80df>) returned error, retrying after 10.747238066s: client.PutObject: Error response code QuotaExceeded. Error response code QuotaExceeded.tten client.PutObject github.com/restic/restic/internal/backend/s3.(*Backend).Save         /restic/internal/backend/s3/s3.go:255 github.com/restic/restic/internal/backend.(*RetryBackend).Save.func1         /restic/internal/backend/backend_retry.go:56 github.com/cenkalti/backoff.RetryNotify         /restic/vendor/github.com/cenkalti/backoff/retry.go:37 github.com/restic/restic/internal/backend.(*RetryBackend).retry         /restic/internal/backend/backend_retry.go:36 github.com/restic/restic/internal/backend.(*RetryBackend).Save         /restic/internal/backend/backend_retry.go:50 github.com/restic/restic/internal/cache.(*Backend).Save         /restic/internal/cache/backend.go:54 github.com/restic/restic/internal/repository.(*Repository).savePacker         /restic/internal/repository/packer_manager.go:106 github.com/restic/restic/internal/repository.(*Repository).SaveAndEncrypt         /restic/internal/repository/repository.go:270 github.com/restic/restic/internal/repository.(*Repository).SaveBlob         /restic/internal/repository/repository.go:704 github.com/restic/restic/internal/repository.Repack         /restic/internal/repository/repack.go:87 main.pruneRepository         /restic/cmd/restic/cmd_prune.go:278 main.runPrune         /restic/cmd/restic/cmd_prune.go:85 main.glob..func18         /restic/cmd/restic/cmd_prune.go:25 github.com/spf13/cobra.(*Command).execute         /restic/vendor/github.com/spf13/cobra/command.go:762 github.com/spf13/cobra.(*Command).ExecuteC         /restic/vendor/github.com/spf13/cobra/command.go:852 github.com/spf13/cobra.(*Command).Execute         /restic/vendor/github.com/spf13/cobra/command.go:800 main.main         /restic/cmd/restic/main.go:86 runtime.main         /usr/local/go/src/runtime/proc.go:203 runtime.goexit         /usr/local/go/src/runtime/asm_amd64.s:1357

What backend/server/service did you use to store the repository?
Expected behavior

Actual behavior

Steps to reproduce the behavior

Do you have any idea what may have caused this?
Do you have an idea how to solve the issue?
Did restic help you today? Did it make you happy in any way?

It was because of the space limit issue on my s3. Closing the issue.


unify of project creation import and import plugin feature

we have currently three "import" features of a flightpath
a) on project creation
b) import feature can use plugins
c) work locally import
all three should have same code and same features
the import could also get extended by a textbox where we can copy paste a flightpath.

We also have kml import in the kml dockingwidget for topview.
probably also other formats e.g. ftml are interesting to be used for this import in the dockingwidget. the data needs to be converted to be visualized by the kml toolkit.

resolved by gsoc2021


Use apmon package

There is no point of maintaining same code in multiple locations. Reuse apmon package from here:
https://github.com/MonALISA-CIT/apmon_java

Greetings From Gen.david jeffrey,please contact me at, (davidjeffrey801@gmail.com)or you you send me your email here to contact you OK


Autologin on an existing user account?

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.20.4
Expected results
Hi all,
If I want to add a token to my URL to autologin to a specific user
superset/dashboard/3?standalone=true&token=123456789
Where in the codes should I add a check on the token to login and force a user login action?
something like :
if request.args.get('token') == '123456789':
login user xxx
How can I autologin ?
I see lots of g.user being called but I don't see where the actual login process is being made.
Where did the username/password/csrf_token get used to authenticate the user?

It's provided by Flask Appbuilder.
http://flask-appbuilder.readthedocs.io/en/latest/security.html#supported-authentication-types

Thanks,
I will have to go though one of the four types of authentication methods supported.
Closing this issue


Compatibility check before release

As we have more releases and some public API is already used by customers, will there be some checks in the release process such that we know public signatures or members are removed but they are public API?  Similarly, can the check reports potential compatiblity issue?
One solution is https://github.com/lvc/japi-compliance-checker
which compares the previous release jar and the snapshot jar you intend to release.
The report shows compatibility items for review.
Other ideas?

cc @ejanei

Can we maybe use this or something similar? Maybe a component of it? https://abi-laboratory.pro/

I think so because https://abi-laboratory.pro/ uses the same JAPICC japi-compliance-checker according to https://abi-laboratory.pro/index.php?view=binary-compatibility
I'm just wondering what is extra in abi-laboratory but not in japi-compliance-checker.


docker top breaks when showing thread information after processes

Description
Attempting to show threads after process in top command (m flag) returns
Error response from daemon: Unexpected pid '-': strconv.ParseInt: parsing "-": invalid syntax
Steps to reproduce the issue:

Pull any image
Run a new container
Run docker top <container-id> m

Describe the results you received:
Error response from daemon: Unexpected pid '-': strconv.ParseInt: parsing "-": invalid syntax
Describe the results you expected:
ps information such as:
PID TTY      STAT   TIME COMMAND
  173 ?        -      0:00 /bin/bash
    - -        Ss     0:00 -
  190 ?        -      0:00 ps m
    - -        R+     0:00 -

Additional information you deem important (e.g. issue happens only occasionally):
Combining m flag with any other causes the problem (such as ps muax)
This error seems related to ps output parsing function implemented in https://github.com/docker/docker/blob/master/daemon/top_unix.go
Output of docker version:
Client:
 Version:      1.13.0
 API version:  1.25
 Go version:   go1.7.3
 Git commit:   49bf474
 Built:        Tue Jan 17 09:58:26 2017
 OS/Arch:      linux/amd64

Server:
 Version:      1.13.0
 API version:  1.25 (minimum version 1.12)
 Go version:   go1.7.3
 Git commit:   49bf474
 Built:        Tue Jan 17 09:58:26 2017
 OS/Arch:      linux/amd64
 Experimental: false

Output of docker info:
Containers: 1
 Running: 1
 Paused: 0
 Stopped: 0
Images: 4
Server Version: 1.13.0
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 23
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 03e5862ec0d8d3b3f750e19fca3ee367e13c090e
runc version: 2f7393a47307a16f8cee44a37b262e8b81021e3e
init version: 949e6fa
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.4.0-59-generic
Operating System: Ubuntu 16.04.1 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.659 GiB
Name: rsilva-note
ID: G3OH:BUGW:Z6RR:6BVO:YSAV:QYEE:6VVL:FJQ4:Q7LW:OXIJ:LUHT:Q2VJ
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Additional environment details (AWS, VirtualBox, physical, etc.):
Ubuntu 16.10

@resilva87, refer here https://docs.docker.com/engine/reference/commandline/top/, you need provide "ps" command available option, for instance: "docker top 67ca37486c63 -aef" (make sure "-" ahead of the option).
However, it seems a little mis-understanding, to give feedback when there is no such option for command "ps", say:
[root@c9t23123 docker]# docker top 67ca37486c63 -m
Error response from daemon: Unexpected pid '-': strconv.ParseInt: parsing "-": invalid syntax
Recommend to give more meaningful message, such as "Please provide valid 'ps' command option" or whatever proper.

The problem can also be reproduced in latest version, which was caused here in the code(~/daemon/top_unix.go):
60   // loop through the output and extract the PID from each line
66     p, err := strconv.Atoi(fields[pidIndex])
67     if err != nil {
68       return nil, fmt.Errorf("Unexpected pid '%s': %s", fields[pidIndex], err)
69     }
When using the "ps m" command whose output like:
PID TTY      STAT   TIME COMMAND
321 pts/16   -      0:00 bash
- -        Ss+    0:00 -
805 pts/2    -      0:00 bash
- -        Ss+    0:00 -
1651 pts/23   -      0:12 go tool tour
The line with invalid pid "  - -        Ss+    0:00 -" will lead to the problem (not able to convert the "-" to "int")
Any suggestions on how to fix it ( I intend to create a PR for this ).

The problem can also be reproduced in latest version, which was caused here in the code(~/daemon/top_unix.go):
60   // loop through the output and extract the PID from each line
66     p, err := strconv.Atoi(fields[pidIndex])
67     if err != nil {
68       return nil, fmt.Errorf("Unexpected pid '%s': %s", fields[pidIndex], err)
69     }
When using the "ps m" command whose output like:
PID TTY      STAT   TIME COMMAND
321 pts/16   -      0:00 bash
- -        Ss+    0:00 -
805 pts/2    -      0:00 bash
- -        Ss+    0:00 -
1651 pts/23   -      0:12 go tool tour
The line with invalid pid "  - -        Ss+    0:00 -" will lead to the problem (not able to convert the "-" to "int")
Any suggestions on how to fix it ( I intend to create a PR for this ).

Hi,
After messing around a bit with both code and unit tests, I wonder, is it still necessary to verify that the number of header  titles match the number of fields in ps output?
I mean, I'm more than favor for such validation specially when it depends on system tools but I can't see any example of ps showing extra headers (or fields) than required.
The unit tests for top daemon command (https://github.com/docker/docker/blob/master/daemon/top_unix_test.go) don't seem to test clearly this expectation, so I'd like to understand if this still has its points or maybe it should be simpler enough to only format ps output in tabular format (after removing the validation code below unit tests still passed):
for _, pid := range pids {
    if pid == p {
        // Make sure number of fields equals number of header titles
        // merging "overhanging" fields
        process := fields[:len(procList.Titles)-1]
        process = append(process, strings.Join(fields[len(procList.Titles)-1:], " "))
        procList.Processes = append(procList.Processes, process)
    }
}

Thanks.

Checking "ps" command's output, it seems only option "-m" having set column "PID" as "-" in the output,  so in PR #30669,  fixing the bug through ignoring the thread line when found "PID" column being "-".

Hi,
Don't know if just ignoring thread information lines is the best option here. It's valid output and one I'm interested checking.
I still wonder, is there such case that the number of header titles won't match the number of fields? I can't find a way to reproduce such problem.
Thanks.

@resilva87,  the number of header titles should match the number of fields, they are generated from "ps" output, why are you worried in this regard.
From checking the source code, the "docker top" command on purpose checking the PID, so only the lines with matching PID should be returned, so currently not all the information is intended to be exposed by such command.

@catinthesky No worries. What I'm saying is that if this validation is not necessary, than the complete output of ps command should be returned, which is not happening due to the code above:
for _, pid := range pids {
    if pid == p {
        // Make sure number of fields equals number of header titles
        // merging "overhanging" fields
        process := fields[:len(procList.Titles)-1]
        process = append(process, strings.Join(fields[len(procList.Titles)-1:], " "))
        procList.Processes = append(procList.Processes, process)
    }
}

Also, docker top not only checks one PID. All processes running inside a container are listed, which is kind the point of this command in a host system (of course you can filter a given PID)

@resilva87 I probably wrong but it feels like the current implementation of top is problematic when specifying number of ps options such as -L and m.

Hi,
@ripcurld0 I understand. Don't get me wrong, I think this a very nice feature to have for monitoring my containers, but it would be even cooler to have the same kind of information I can get with my host ps :). That's why I don't think skipping these problematic lines in the output would be great... The info is there, it's only a matter of formatting.

@ripcurld0,  I checked the option "L":
when command like: "docker top  L", its output without column "PID" will make it fail.
What's the problem of "T" option,  can you share the problem you found.
@thaJeztah, is there some suggestion or resource to ping, it looks the problem of "docker top" command in regard of "TmL" (thread related)  is problematic, in summary, command fails in:
1) when "pid" column (being "-") not able to be converted into "int"
2) when output not containing "pid" column.
Which is caused by "pid" checking, can it be ignored ?
or if keep "pid" checking what's the proper strategy to deal with the above situation?

I dig a little further to find that, current implementation kind of like: (in daemon/top_unix.go), first using:
pids, err := daemon.containerd.GetPidsForContainer(container.ID)
to get the container contained process ids, then using this statement:
output, err := exec.Command("ps", strings.Split(psArgs, " ")...).Output()
to get all the "ps"'s output, ten filtered based on the above contained pids to get the right output.
So, the strategy I think of so far:
1) keep current, PID filtering, for "docker top" with "-m" option,  can get the following threads lines added until encounter next process, but it can not solve the "L" exclusive option (which to my checking, no way to make PID added to the output).
2)  Directly using command: exec.Command("docker-runc", args...).CombinedOutput() in table format to get the output, but this also having problem when it comes to "m" "L" option, so need to raise bug to "runc" project to see if it can be fixed.
[root@c9t23123 containerd]# docker-runc ps --format=table  "7dced85bcbdf633d04ae0fca848628613fe2c2ed1843910076f51fd8050c7afb" L
couldn't find PID field in ps output
[root@c9t23123 containerd]# docker-runc ps --format=table  "7dced85bcbdf633d04ae0fca848628613fe2c2ed1843910076f51fd8050c7afb" m
PID TTY      STAT   TIME COMMAND
unexpected pid '-': strconv.ParseInt: parsing "-": invalid syntax
[root@c9t23123 containerd]# docker-runc ps --format=table  "7dced85bcbdf633d04ae0fca848628613fe2c2ed1843910076f51fd8050c7afb" -m
PID TTY          TIME CMD
unexpected pid '-': strconv.ParseInt: parsing "-": invalid syntax
I would recommend the second option to raise bug to "runc" project.

I left a suggestion on the PR https://github.com/docker/docker/pull/30669#issuecomment-277181577
We're aware that the docker top implementation is far from ideal, because it relies on commands on the host (which is not standardized, and differs  between distros)

@thaJeztah , thanks a lot.

I'm having this error too. I'm using Windows 10 Pro x64 in English. Happens to me on every container I try. I hope I'm reporting this where it belongs. If not, let me know. Thanks.
PS D:\node\docker> docker ps -a
CONTAINER ID        IMAGE               COMMAND                  CREATED             STATUS              PORTS               NAMES
f44a78a520df        mongo               "docker-entrypoint..."   6 minutes ago       Up 6 minutes        27017/tcp           mongo
PS D:\node\docker> docker top mongo
Error response from daemon: Unexpected pid '113361root': strconv.Atoi: parsing "113361root": invalid syntax
PS D:\node\docker> docker inspect mongo
[
    {
        "Id": "f44a78a520df8f5458d4c67ed7d452119d8b7a51388243622f758b819a8de561",
        "Created": "2017-07-08T00:33:26.1265152Z",
        "Path": "docker-entrypoint.sh",
        "Args": [
            "mongod"
        ],
        "State": {
            "Status": "running",
            "Running": true,
            "Paused": false,
            "Restarting": false,
            "OOMKilled": false,
            "Dead": false,
            "Pid": 123355,
            "ExitCode": 0,
            "Error": "",
            "StartedAt": "2017-07-08T00:33:26.690844Z",
            "FinishedAt": "0001-01-01T00:00:00Z"
        },
        "Image": "sha256:57c67caab3d8f9ed1fbffe159b10be52e0a0610122c16b3efea50a90ff435584",
        "ResolvConfPath": "/var/lib/docker/containers/f44a78a520df8f5458d4c67ed7d452119d8b7a51388243622f758b819a8de561/resolv.conf",
        "HostnamePath": "/var/lib/docker/containers/f44a78a520df8f5458d4c67ed7d452119d8b7a51388243622f758b819a8de561/hostname",
        "HostsPath": "/var/lib/docker/containers/f44a78a520df8f5458d4c67ed7d452119d8b7a51388243622f758b819a8de561/hosts",
        "LogPath": "/var/lib/docker/containers/f44a78a520df8f5458d4c67ed7d452119d8b7a51388243622f758b819a8de561/f44a78a520df8f5458d4c67ed7d452119d8b7a51388243622f758b819a8de561-json.log",
        "Name": "/mongo",
        "RestartCount": 0,
        "Driver": "overlay2",
        "MountLabel": "",
        "ProcessLabel": "",
        "AppArmorProfile": "",
        "ExecIDs": null,
        "HostConfig": {
            "Binds": null,
            "ContainerIDFile": "",
            "LogConfig": {
                "Type": "json-file",
                "Config": {}
            },
            "NetworkMode": "default",
            "PortBindings": {},
            "RestartPolicy": {
                "Name": "no",
                "MaximumRetryCount": 0
            },
            "AutoRemove": false,
            "VolumeDriver": "",
            "VolumesFrom": null,
            "CapAdd": null,
            "CapDrop": null,
            "Dns": [],
            "DnsOptions": [],
            "DnsSearch": [],
            "ExtraHosts": null,
            "GroupAdd": null,
            "IpcMode": "",
            "Cgroup": "",
            "Links": null,
            "OomScoreAdj": 0,
            "PidMode": "",
            "Privileged": false,
            "PublishAllPorts": false,
            "ReadonlyRootfs": false,
            "SecurityOpt": null,
            "UTSMode": "",
            "UsernsMode": "",
            "ShmSize": 67108864,
            "Runtime": "runc",
            "ConsoleSize": [
                32,
                159
            ],
            "Isolation": "",
            "CpuShares": 0,
            "Memory": 0,
            "NanoCpus": 0,
            "CgroupParent": "",
            "BlkioWeight": 0,
            "BlkioWeightDevice": null,
            "BlkioDeviceReadBps": null,
            "BlkioDeviceWriteBps": null,
            "BlkioDeviceReadIOps": null,
            "BlkioDeviceWriteIOps": null,
            "CpuPeriod": 0,
            "CpuQuota": 0,
            "CpuRealtimePeriod": 0,
            "CpuRealtimeRuntime": 0,
            "CpusetCpus": "",
            "CpusetMems": "",
            "Devices": [],
            "DeviceCgroupRules": null,
            "DiskQuota": 0,
            "KernelMemory": 0,
            "MemoryReservation": 0,
            "MemorySwap": 0,
            "MemorySwappiness": -1,
            "OomKillDisable": false,
            "PidsLimit": 0,
            "Ulimits": null,
            "CpuCount": 0,
            "CpuPercent": 0,
            "IOMaximumIOps": 0,
            "IOMaximumBandwidth": 0
        },
        "GraphDriver": {
            "Data": {
                "LowerDir": "/var/lib/docker/overlay2/302a2f49532595c7a2bfe1211a78f098fbdf942db79464671880fc217f18d017-init/diff:/var/lib/docker/overlay2/495b4d6f7203b379099772e27ba9199131537500c4fcf318b8f31681c0278eba/diff:/var/lib/docker/overlay2/f5bede3e06314f50788134c830535671f66b56269be42caa994ddb0bb84fd325/diff:/var/lib/docker/overlay2/7b7cbbb405ba617884c42ccd743dfa495bb9f7684ff852146a153f53345689b5/diff:/var/lib/docker/overlay2/7bc2cb44d6e5d7c7893609b58414d2763dbd42918b598bb8ac9bad6595bab223/diff:/var/lib/docker/overlay2/0e92416422a8d0ac51548f1c8be476a8e9946dced9b4532780f2679cb405f679/diff:/var/lib/docker/overlay2/d4e2c0c6242649c00c14ad5006a6cebedff5cba7c40a76447fd56e745e17f3f0/diff:/var/lib/docker/overlay2/74b6840937f06d0d59fa33d86886f75580a4716dd09d5927e906b4b74f7cd031/diff:/var/lib/docker/overlay2/02ad9da337f519dd8b770777e2a9c5fc4141f2793af2b267637247f8085269f2/diff:/var/lib/docker/overlay2/e1c8d3db225a407d0b88cb25561000169330e2b71b34aa36ebd44c5f5412b634/diff:/var/lib/docker/overlay2/a9ce056cd169e484f72577c940dc8cc00c1b2b0e1ee579a044306a93e2908ed3/diff:/var/lib/docker/overlay2/4a4af9ecca54098e7cdc0633e219e6f3d88ff512188acbd5f5c4e922f3982448/diff",
                "MergedDir": "/var/lib/docker/overlay2/302a2f49532595c7a2bfe1211a78f098fbdf942db79464671880fc217f18d017/merged",
                "UpperDir": "/var/lib/docker/overlay2/302a2f49532595c7a2bfe1211a78f098fbdf942db79464671880fc217f18d017/diff",
                "WorkDir": "/var/lib/docker/overlay2/302a2f49532595c7a2bfe1211a78f098fbdf942db79464671880fc217f18d017/work"
            },
            "Name": "overlay2"
        },
        "Mounts": [
            {
                "Type": "volume",
                "Name": "6e87a2248b88217fc78ea4089178bb2dde759092890e7568c5a82c6c8437c904",
                "Source": "/var/lib/docker/volumes/6e87a2248b88217fc78ea4089178bb2dde759092890e7568c5a82c6c8437c904/_data",
                "Destination": "/data/configdb",
                "Driver": "local",
                "Mode": "",
                "RW": true,
                "Propagation": ""
            },
            {
                "Type": "volume",
                "Name": "e0596cf37fa6783363654f916148806269c40c3a72da623d92938da8a18afc5e",
                "Source": "/var/lib/docker/volumes/e0596cf37fa6783363654f916148806269c40c3a72da623d92938da8a18afc5e/_data",
                "Destination": "/data/db",
                "Driver": "local",
                "Mode": "",
                "RW": true,
                "Propagation": ""
            }
        ],
        "Config": {
            "Hostname": "f44a78a520df",
            "Domainname": "",
            "User": "",
            "AttachStdin": false,
            "AttachStdout": false,
            "AttachStderr": false,
            "ExposedPorts": {
                "27017/tcp": {}
            },
            "Tty": false,
            "OpenStdin": false,
            "StdinOnce": false,
            "Env": [
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
                "GOSU_VERSION=1.7",
                "GPG_KEYS=0C49F3730359A14518585931BC711F9BA15703C6",
                "MONGO_PACKAGE=mongodb-org",
                "MONGO_REPO=repo.mongodb.org",
                "MONGO_MAJOR=3.4",
                "MONGO_VERSION=3.4.6"
            ],
            "Cmd": [
                "mongod"
            ],
            "ArgsEscaped": true,
            "Image": "mongo",
            "Volumes": {
                "/data/configdb": {},
                "/data/db": {}
            },
            "WorkingDir": "",
            "Entrypoint": [
                "docker-entrypoint.sh"
            ],
            "OnBuild": null,
            "Labels": {}
        },
        "NetworkSettings": {
            "Bridge": "",
            "SandboxID": "aa886946f63adf9c466fa7fc15792641da701cdd229fa9d45572e6fb85e95d91",
            "HairpinMode": false,
            "LinkLocalIPv6Address": "",
            "LinkLocalIPv6PrefixLen": 0,
            "Ports": {
                "27017/tcp": null
            },
            "SandboxKey": "/var/run/docker/netns/aa886946f63a",
            "SecondaryIPAddresses": null,
            "SecondaryIPv6Addresses": null,
            "EndpointID": "b30bbb8f45b9ee82534b1d5ff19a6c9d68371f0938c7cff80fea73617e6bca29",
            "Gateway": "<IP_ADDRESS>",
            "GlobalIPv6Address": "",
            "GlobalIPv6PrefixLen": 0,
            "IPAddress": "<IP_ADDRESS>",
            "IPPrefixLen": 16,
            "IPv6Gateway": "",
            "MacAddress": "02:42:ac:11:00:02",
            "Networks": {
                "bridge": {
                    "IPAMConfig": null,
                    "Links": null,
                    "Aliases": null,
                    "NetworkID": "453e4a328572e1c96e29b7e9feef3e01e55e1a88f4c9f0a7ab8565672969f325",
                    "EndpointID": "b30bbb8f45b9ee82534b1d5ff19a6c9d68371f0938c7cff80fea73617e6bca29",
                    "Gateway": "<IP_ADDRESS>",
                    "IPAddress": "<IP_ADDRESS>",
                    "IPPrefixLen": 16,
                    "IPv6Gateway": "",
                    "GlobalIPv6Address": "",
                    "GlobalIPv6PrefixLen": 0,
                    "MacAddress": "02:42:ac:11:00:02",
                    "DriverOpts": null
                }
            }
        }
    }
]
PS D:\node\docker>


Add /processValue/ to datamodel and kafka-to-postgres

Is your feature request related to a problem? Please describe.
When having hundreds of processValues it is hard to view them in tools like MQTT Explorer, as they all come in the same topic
Describe the solution you'd like
An option to append something to the topic name (e.g., ia/factoryinsight/testlocation/testasset/processvalue/temperature). Payload should be the same (for now), so that it is easily implemented.
Describe alternatives you've considered
We could duplicate everything in ia/raw/.., but that is just duplication of data
Additional context

This is already possible in kafka-to-postgres.
It uses
ia\.([\w]*)\.([\w]*)\.([\w]*)\.([\w]*)

and regexp.FindStringSubmatch and will therefor match the new topic name.
See image below, for an example:

For the documentation change see #985


feat(scene): Scene Tutorial feature parity

This binds enough of the datoviz C Api to make a 'pure' Haskell version of the standalone scene
other notable changes

Copy upstream file structure
newtype wrapper on linear.{V2, V3, V4} for emulating c-typedefs
Use CApiFFI for all new foreign imports


Path for the data files is incorrect in subcorpus.yaml

I didn't raise a PR because I'm not sure if I'm right.
For the bench-marking task:
After running the gather.yaml, (and unzipping the files on the data-disk machines)
If I run subcorpus.yaml, it fails to find the zip files because the path to it is probably incorrect:
https://github.com/owainkenwayucl/coursework-c0235/blob/cbb353581177c284c34425a49ca936b4c4ef9329/lecture4a_dataengexample/subcorpus.yaml#L30
The source path should be /home/almalinux/...
Instead of the current /data/almalinux/...
It gets the benchmarks correctly after this change ("on my machine").
EDIT: This was probably because of my own misconfiguration

HI,
Both /home/almalinux/data and /data/almalinux should point to the same place as the former should be a sym-link to the latter.
Cheers,
Owain


⚠ GitLab Server has degraded performance

In 8d3a892, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6948 ms

Resolved: GitLab Server performance has improved in 4b73d6a.


[Example] ggml: add model not found test

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


7 months passed, the weights is still unavailable...

As for the model pretrained weight release, please see this note


Allow customization of descriptions and examples in the OpenAPI endpoint

It would be nice if the automatic OpenAPI endpoint could be customized to show descriptions and example usages of the APIs being documented.
An idea would be to use PostgreSQL comments for that.

Nice idea, seems to have a lot of interest.
Closing this issue though as it's a duplicate of #222


Document concrete steps needed for contributing

I found myself a bit lost and had to dig around the project to see how to run the tests, this change should make this process a bit easier for newcomers.

Do we really need contributors who need instructions like Clone your fork?

I am ok on having instructions like Clone your fork. You would be suprised to see how many people don't know those things.

I just noticed you do not have a PR template yet. I took the liberty to move parts of the guidelines that relate to completeness of the PR there.
This kind of templating has worked great for me in https://github.com/nuwave/lighthouse, the amount and quality of contributions has been quite good.

Thank you!


uppgrading from php 7.4 to php 8.1.5. Fields contatining åäö FPDF-Merge Error: field Månader not found

After uppgrading from php 7.4 to php 8.1.5. Fields contatining åäö do not work
FPDF-Merge Error: field Månader not found
Anyone else with this issue?

Same problem here with äöü.

Workaround, worked when replacing äö with ?

I can not replace the äo...
I want to make fdpm PHP 8.1 compatible.
Can you help to do so?

Sorry, I can’t. Just told you how I manage to do a workaround. Hope you find a solution.

What would be the workaround?
Maybe there are more PHP 8.1 compatibility problems not only the special characters.

For me it was to replace "ä" with "?".

But if you have to switch back to PHP 7.4 (maybe temporally) this will not work.
I still want want to make fdpm PHP 8.1 compatible.

You can try using https://github.com/williamgall/fpdm/ fork.
It is working for me under php 8.1


eslint: exhaustive-deps false positive for optional chain

Describe the bug
declare function sendQuery(address: string): Promise<any>
function useTest(data?: any) {
    return useQuery({
        // The following dependencies are missing in your queryKey: data
        queryKey: ['query-name', data?.address],
        queryFn: async () => sendQuery(data!.address),
        enabled: !!data?.address,
    })
}

declare function sendQuery(address: string): Promise<any>
function useTest(data?: any) {
    return useQuery({
        // The following dependencies are missing in your queryKey: data.address
        queryKey: ['query-name', data?.address],
        queryFn: async () => sendQuery(data.address),
        enabled: !!data?.address,
    })
}

Your minimal, reproducible example
...
Steps to reproduce

enable rule @tanstack/query/exhaustive-deps

Expected behavior
No error
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

"@tanstack/eslint-plugin-query": "^5.61.4"

Tanstack Query adapter
None
TanStack Query version
not applicable
TypeScript version
5.7.2
Additional context
No response

@Newbie012 can you take a look please? I added this test case and indeed, it fails:
{
  name: 'should pass with optional chaining',
  code: `
  function useTest(data?: any) {
    return useQuery({
      queryKey: ['query-name', data?.address],
      queryFn: async () => sendQuery(data.address),
      enabled: !!data?.address,
    })
  }
  `,
},

Fixed in https://github.com/TanStack/query/issues/8357
As a side note, I think you may want to use skipToken.


Issues on a very long and slow page

This is:

Question

Specifications

AOS version: 3
OS: any
Browser: any

Expected Behavior

I would like to use AOS on a very, very long page, fully loaded after 5-10 secs.

Possible Solution

To avoid this I simply moved the init code and css / js links from the  to the end, just before  tag:
  <link<EMAIL_ADDRESS>rel="stylesheet">
  <script<EMAIL_ADDRESS>  <script>
    AOS.init({offset: 60, once: false,  disable: 'phone', duration: 300,
      initClassName: 'aos-init',
      animatedClassName: 'aos-animate',
      useClassNames: false,
      disableMutationObserver: false,
      debounceDelay: 50,
      throttleDelay: 99,
      });
  </script>

It works better, elements are visible cause AOS is loading and initializing when DOM is almost ready,
but there is another small issue: AOS triggers animation when the DOM is fully loaded and elements with "data-aos" attribute, visible on the screen, are "blinking" (animating).
Is there a solution to avoid triggering animation on visible, rendered, presented in viewport elements? I don't want to animate any elements user has already scrolled to, during page load.
Or maybe there is a way to init AOS earlier, before DOM is ready and trigger animations DURING page loading?

I ended up with this solution: I moved imports and initialization to the bottom of the page, just before  and added before this simple code:
function isElementInViewport (el) {
  if (typeof jQuery === "function" && el instanceof jQuery) {
      el = el[0];
  }
  var rect = el.getBoundingClientRect();
  return (
      rect.top >= 0 &&
      rect.left >= 0 &&
      rect.bottom <= (window.innerHeight || document.documentElement.clientHeight) && /* or $(window).height() */
      rect.right <= (window.innerWidth || document.documentElement.clientWidth) /* or $(window).width() */
  );
}
$("[data-aos]").each(function() {
  if (isElementInViewport($(this))) {
    $(this).removeAttr("data-aos");
  }
});

Comments?

I have the same problem as you.
I just used a simple setTimeout, very ugly but it works. 1s was enough to fix my page
        setTimeout(function () {           AOS.init();         }, 1000);

Bump, also having this issue.

Why not just use $(document).ready(() => {...} from the jQuery library or write own wrapper based on stack overflow?
That's the known issue with really big amount of js libraries and I don't understand why you guys don't know the really basic solution for the basic problem.


conda install much easier (or only possible) without premature python install

The current conda installation instructions say that one should do:
conda env create -n asp python=3.6

But this creates unresolvable obstacles during the dependency solving in the next step (don't ask me why, but it's something to do with that conda and mamba work much better when they get all the dependencies in one step).
The ISIS team has also realized that and changed their instructions to do this:
conda create -n isis

and the required python version simply comes in later when installing the meta-package isis or stereo-pipeline.
So, I'd recommend to change the instructions to that here as well:
conda create -n asp
conda activate asp
conda config --env --add channels usgs-astrogeology
conda config --env --add channels nasa-ames-stereo-pipeline

Note that the defaults channel isn't required to resolve your dependencies, and I had no issues installing everything using mamba either.

Note that this statement is not true:

We do not recommend using the --prepend channels argument, as that will add the nasa-ames-stereo-pipeline to your default ~/.condarc file and will have consequences for all of your conda environments, which you don't want.

--prepend works in whatever env I have the conda config instructed to work in.
So, if I do:
conda config --env --prepend nasa-ames-stereo-pipeline

conda will simply put the nasa ames channel as the top most in the current environment.
As the instructions at this point have already activated the asp env, a --env --prepend would not change all other envs of the conda setup.

Thank you for noticing these. I never had a problem installing as our doc was saying, but given that the ISIS folks switched to doing it that way, it makes sense to follow them. I verified that "conda create -n asp" (so without setting the python version) works, and I will update the doc in a short time.
Aso to the "--prepend" option, I will let Ross comment. There's no harm with the current text, I guess.

Well, as Michael points out, the statement we have isn't globally true, it doesn't always write to the over-arching ~/.condarc file.  I suspect that only happens if you haven't activated an environment.  If you have, then it works as expected, and desired.
Our paragraph about --prepend is a warning.  Our instructions never tell a user to use --prepend but this is clearly here because someone tried to at some point and things got screwed up.
We can either (1) delete the paragraph entirely (because patterns around channel loading may be fluid enough that we shouldn't give advice when people should really go and look up and understand what conda commands they're issuing).  (2) Or we could modify the para to say that if a user is contemplating using conda config --prepend that they ensure that they are either already in a loaded conda environment or make sure to also use the --env command to specify a specific environment that is not loaded.

Ross, you can edit that text as you see fit, I think you added it to start with.

Can't say I remember that, but that's not surprising.  I'll take care of it.

Could have been Scott then. I remember vaguely only that at some point you made some additions around that area but I can't say for sure what was put in.

(2) Or we could modify the para to say that if a user is contemplating using conda config --prepend that they ensure that they are either already in a loaded conda environment

Just to be clear (maybe this was a typo?), but conda config --prepend does indeed change the global config ALWAYS!
Only conda config --env --prepend respects the currently activated env.


Correct DbContext class name in documentation

I'm not sure what you're asking for, I'm not used to github, adding another file change into this pull request.  Can you just do it?


Sort arrows disappeared, in filters: no text is displayed(2.6.3)

Expected Behavior
Before 2.6.3 it was possible to see sort arrows and written text in filters.
Current Behavior
Sort arrows disappeared, in filters: no text is displayed and it rememebers only the first letter. It happens only when serverSide is enabled + passing onTableChange, but i need both these options. I've noticed that after updating to 2.6.3 from 2.4.0.
Also, if selectableRowsOnClick is enabled --> can't click on checkbox.
Please help, i'm having deploy today
Your Environment

Tech
Version

Material-UI
4.1.1

MUI-datatables
2.6.3

React
16.8.6

browser
Chrome( 75.0.3770.100 )

Found out that there are many changes between these two versions, found solution

Interesting, I was not aware it was ever possible to have sort arrows in filters. As far as I know, such a thing only recently became possible via custom filters in 2.6.0.

Sorry, incorrectly expressed my thoughts. Sort arrows disappeared not in filters.They disappeared in the table heading. Previously i used version 2.4.0. in my project and i've had server side pagination, custom filtering and sorting. And before updating, table remembered filter text and which columns were sorted. After updating its disappeared. So, now every new request table forgets everything. Later I found this information and refactored these things(every column has option with sortDirecton and filterList). I needed update because there was a problem with selectableRowsOnClick: true and isRowSelectable(the first override the second one), and now this problem is gone , but if selectableRowsOnClick is enabled , you can't click on checkbox.Can it be fixed? Thank you

Have you verified the select issue on 2.6.4? I just fixed a bug there that may have been causing the selection problem.

not yet, I'll try

Yes, it fixed.Thank you


Add ms high contrast support for icons

In https://github.com/IBM/carbon-elements/pull/388 we landed support for high contrast mode for icons when being used in a Microsoft browser. This issue is to integrate the mixin available in the latest versions of elements.

@joshblack Any update for this issue?

First part: https://github.com/IBM/carbon-elements/pull/461
Will trigger a minor release for elements, 10.1.0.

@shinytoyrobots - would you please have someone add an ETA to resolving this issue.  This is holing up AVT exit.

@dakahn - you're putting this into the reset file for v9 today and pushing today, correct?

@shinytoyrobots Donezo! v9 has received the relevant changes here 🤠

@dakahn Is the new Carbon version for V9 ready to verify this issue?

looks like I'm still not seeing the icon in the latest v9 <Icon description={this.props.t('locked')} name='locked'/>

@joshblack @dakahn Could you help look at it. The issue is not resolved in the latest v9.

@icemanlily are you all using the CSS reset from carbon? It was included in that block.
File<EMAIL_ADDRESS>At the bottom:

@joshblack yes we have imported @import '../../node_modules/carbon-components/scss/globals/scss/css--reset';
here is the compiled css file running on  https://dev.console.test.cloud.ibm.com/iam/

Testing IBM Cloud login flow in high contrast mode on Windows 10 using latest build of Firefox:

As you can see most iconography seems to be taking the reset, but notably not the arrow on our Dropdown component.

Compare to the Dropdown in Carbon Design System v9 in high contrast mode:

The problem seems to not be on the library side. 👍🏽

@dakahn I think the login page didn't update to the latest Carbon v9. I tried it in IAM and the arrow should be OK.

But in https://dev.console.test.cloud.ibm.com/iam/apikeys . The lock icons are still missing.

@joshblack sorry, maybe a dumb question, why is the compiled css file not a hex but a string? in the scss file it's fill: ButtonText but not $ButtonText if it's a variable?

Hi @nicoxxie! 👋 As far as I understand (@dakahn discovered it) this is a system color variable defined in CSS2. This variable is used to help with rendering the icons in high contrast mode on windows (I believe).

on a side note, the ButtonText system color is deprecated. it seems to be supported by the major browsers still but it may cause issues on some systems

@joshblack @dakahn Seems it doesn't work for the radio button. Could you help check it?


ServerInterface::PayloadAsyncRequest does not work with ByteBuffer

Should this be an issue in the gRPC issue tracker?
Yes
What version of gRPC and what language are you using?
gRPC 1.10; C++
What operating system (Linux, Windows, …) and version?
Windows 10 (1709)
What runtime / compiler are you using (e.g. python version or version of gcc)
Visual Studio 2015
What did you do?
Updated grpc::SerializationTraits<bond::bonded<T>>::Deserialize to use grpc::ByteBuffer instead of grpc_byte_buffer.
What did you expect to see?
No compilation errors.
What did you see instead?
Compilation error at grpc::ServerInterface::PayloadAsyncRequest<Message>::FinalizeResult, since it expects grpc_byte_buffer* instead of grpc::ByteBuffer*.
Anything else we should know about your project / environment?

Thanks. Can you include the full compiler output?

Here is the actual error:
E:\depot\bond\thirdparty\grpc\include\grpcpp/impl/codegen/server_interface.h(194): error C2664: 'grpc::Status grpc::SerializationTraits<R,void>::Deserialize(grpc::ByteBuffer *,bond::bonded<bond::Void,bond::ProtocolReader> *)': cannot convert argument 1 from 'grpc_byte_buffer *' to 'grpc::ByteBuffer *'.


Mobile Javascript menus does not work

Symptom
When accessing http://dnollk.se/om/sektionen for instance, the navigation menu does not retract itself into the clickable orange bar. Also sidebar is not visible since it is beneath the navigation menu.
Steps to reproduce

Open http://dnollk.se/om/sektionen or any other view in the "om" path.

Reproducibility
Always, at least on my phone with both Chrome and Firefox.

@Jassob merge with master and pull to website to make it live after checking it.

This issue was moved to Jassob/DNollK.se#24


chore(package): update eslint to version 4.13.1

Closes #117

Coverage remained the same at 99.396% when pulling a55df8a9c588b81fcba74633d6f23b4a9735904b on greenkeeper/eslint-4.13.1 into c828962a6691e750128da4f60e79de6b9957e8b6 on master.


ENURoot.dic

New words added to Root:
bytecode -> [.1bYt.2kod]
counterfeit -> [.1kWn.0tR.2fIt]
the "fit" part was problematic.
fortiori -> `[.2fcr.0Si.1cr.2Y]
Part of the phrase a fortiori
inferrible -> `[.0Xn.1fR.0x.0bxl]
Alternate spelling for inferable.
apriority -> [.2e.2prY.1cr.0X.0Fi]
foudre -> [.1fu.0drx]
Part of the phrase "coup de foudre" defined by many dictionaries.
countercurrents -> `[.1kWn.0tR.2kR.0Xnts]
#Countercurrent was already corrected, but the plural form also needed an entry.
papabile -> [.0px.1pa.0bX.2le]
cantabile -> [.0kan.1ta.0bX.2le]

Moved "mosen" from Main to Root to have one entry instead of two.
Added "ancom" and "ancap" from the project Root file.
Removed "absolute" and most of its inflections.
Altered "labile" to have it pronounced as [.1le.2bYl] -- it was added as [.1le.0bxl]. The original Eloquence pronunciation is incorrect anyway. The new modification is both more popular and in line with almost all US dictionary recommendations.
Added a couple of words from the very first project Root file.
Corrected asshat as it was also problematic in the original project Root file.

Folks, is this PR good? Can this be pushed/accepted on your part?

Okay, I'm going to try and sort these conflicts. Are you having trouble pushing to the master branch? As stated previously, you do not need to submit pull requests if you are a collaborator, you can simply push or merge your changes directly from your local copy. Has GitHub messed with your collaborator status again? You appear as a contributor in the access page.

Question: Are you aware of how the Git process actually works? You seem to be trying to do this backward. For example, you have manually put the words 'ancom' and 'ancap' in your own commit, but this isn't necessary, they're already there in the master. The project files under version control are the files you should be modifying.
The process in brief:

You "git pull" the latest version of the project.
You modify the files in whatever way you see fit.
You "git add" the files you modified (this is known as staging them for commit).
If you like, run a "git status" before committing your changes to make sure everything's ready."

Are you having trouble doing any of this? Let me know if I can help with anything.

The subsequent merge conflict generated by trying to bring these two together results in a file that's actually twice the size. I had to use a script to go through and fix it, and then remove the absolute varriants. There may be some duplicates...

Fixed duplicates, thankfully there were only 3.

Question: Are you aware of how the Git process actually works? You seem to be trying to do this backward. For example, you have manually put the words 'ancom' and 'ancap' in your own commit, but this isn't necessary, they're already there in the master. The project files under version control are the files you should be modifying.
The process in brief:

You "git pull" the latest version of the project.
You modify the files in whatever way you see fit.
You "git add" the files you modified (this is known as staging them for commit).
If you like, run a "git status" before committing your changes to make sure everything's ready."

Are you having trouble doing any of this? Let me know if I can help with anything.

No, to be absolutely honest! ! My interactions with Github have been mostly NVDA bug reports in the arena of issue creation which is apparently and radically different from PR generation.
So may I ask if I need to install the so-called Desktop version of Github in order to achieve these? Or can the web interface take care of it? I really want to get the hang of it if it's not super-technical.

Folks, I now have the Desktop version of Github up and running. Now I know what you were talking about ! I just have one question: should I just clone IBMTTSDictionaries? Or should I clone my own forked version of IBMTTSDictionaries? I think I can figure out the rest after moving past this stage as the menus and dialogs are quite logical and understandable. I also want to push my ENUmain.dic and ENURoot.dic.
Thanks.

@amirsol81 That's awesome! You got it right the first time, just clone the version that already exists.  It's not as permanent as it sounds, that's the other great part of GitHub. It doesn't just make talking about code easier, it also makes editing and sharing it easier, without the worry of messing something up.
A few things to remember, if you don't mind a little advice. If you do, feel free to stop reading!  This updates your local copy of the repository so that whatever you do to it now, you're doing to the version everyone else has. If you forget to do this, we get merge conflicts. As you've seen, they're fixable, but a bit of a pain, and they'll be a pain for you too!
I'm not sure how the desktop client works as I use the command line interface, but there will probably be an option to pull the repository. You don't need to clone it every time, that makes a fresh copy. You're just pulling, or updating your copy.
You might have already done this, but make sure the program knows your GitHub username and email, and is aware of any SSH keys you're using. This will save you lots of annoying, and will make sure you're properly credited for your commits and that they appear on your profile.
Your email address is not shared with us.
Committing is not pushing. I am seriously not meaning to condescend here, this is legitimate advice. I don't know how many people would say this, but when I was new to Git, I kept forgetting to push my commits. When they're done, they look so final and neat in the project, I would completely forget that no one would be able to see them if I just left them there. Committing means saving your changes. Pushing means uploading your changes.
You're not going to break it. Seriously, go to town. That's what version control, and issues, and monthly releases are for. I hope you have as much fun with this as I do!

@thunderdrop As a neophyte at Github, you can't imagine how much I love and admire your comments and suggestions! Please kindly keep them coming -- I never find them condescending or prosaic.

@thunderdrop Courtesy of your suggestions I started pushing files to the repo. Please let me know if I should change my style of sending/pushing/committing. Cheers.


Try faster fade-out on mark-as-read button

This is a followup to:

#562
#565

See chat thread.

I've been noticing this one when I use the app.

Specifically, per Vlad's suggestion yesterday:

Let's have it fade out in 100ms, rather than 2000ms.
Let's also try having the animation scale the button down, as well as reducing opacity.

In the future it would be good to have the button respond optimistically, without waiting for an ack from the server. (I'll file an issue for that.) Then we can make the animation longer again, because there won't be the built-in delay from waiting for the server.


Make dcmtk pass sanity check

We couldn't build it with Bioconda-utils using its own recipe.

This package is filtered out by the CI chain


[AutoPR] containerregistry/resource-manager

Created to accumulate context: containerregistry/resource-manager

This functionality was added by PR https://github.com/Azure/azure-sdk-for-java/pull/2148


Dockerfile not being located

Upon running the compose.sh script, executing docker-compose up yields a successful build process up (last successful task was pulling azurite:latest) until it fails to find 'Dockerfile'

Operating System:
Ubuntu (WSL 2 for Windows 10)
Node Version:
Not Relevant (Docker Build)
(I believe that it might have something to do with a variable not being set or a directory issue with WSL 2, but I'm not sure to which I'm looking for a reproduction of the issue.)

use bash compose.sh instead


muxer needs guard on Close() if caching is disabled

See summary - we want to avoid a nil-reference as well as not to delete any potential tagcache file so a guard is needed.

Closed by #15


11979 oracle mutex

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
no

Tests pass?
yes

Fixed issues

composer.lock should NOT be commited.

Merged manually 9d5bf60a8927c1ccfd9c5c7ab02dd24166b318dc f1af3133c9488d73aaa28f922bc34eb61886d806


Possibility to capture element if it's hidden during page load

My config:
 gemini.suite('popup ' , function (child) {
            child
                .setUrl('url/to/page')
                .before(function (actions, find) {
                    actions.setWindowSize(1200, 800);
                    actions.click(find('.show-popup'));
                    actions.waitForElementToShow('.popup', 2000);
                })
                .setCaptureElements('.popup')
                .capture('plain');
        });

result:
StateError: Area with css selector : .popup is hidden
expected behavior:
captured popup.

Do you really need to change your window size from the test, not from the config? And more correctly to do some action in this way:
gemini.suite('popup' , function (child) {
    child
        .setUrl('url/to/page')
        .setCaptureElements('.popup')
        .capture('plain', function(actions) {
            actions
                .click('.show-popup')
                .waitForElementToShow('.popup', 2000);
        });
});

Also, to capture popup with some element you can wrap them with some extra div and set it as captureElement

Thanks for the response!
I tried your snipped, but result is the same:
StateError: Area with css selector : .popup is hidden
It's because popup is hidden during page load, I suppose. Feels like a bug.

I'm not sure but it seems like I have this bug too. The test below is doesn't work:
gemini.suite('test-name', function(suite) {
    suite.setUrl('test-url')
    	.setCaptureElements('[data-ix=eventappear]')
        .capture('plain', function(actions) {
        	actions.waitForElementToShow('[data-ix=eventappear]', 30000);
        });
});

Result is Area with css selector : [data-ix=eventappear] is hidden. And it appears after 5-7 seconds of running gemini update.
But the next test suite works fine:
gemini.suite('test-name', function(suite) {
    suite.setUrl('test-url')
    	.before(function(actions) {
        	actions.wait(30000);
        })
    	.setCaptureElements('[data-ix=eventappear]')
        .capture('plain');
});

Can you provide your page for testing (also we need info for your environment)? I can't reproduce your problem. waitForElementToShow method will wait for showing of your selector exactly for timeout period specified in argument.

@sipayRT
Env: OS X 10.11.6, node v.4.5.0, npm v.2.15.9
Gemini: v.4.11.0
PhantomJS: 2.1.12
.gemini.yml:
rootUrl: http://dev2dev.ru/
browsers:
  PhantomJS:
    compositeImage: true
    desiredCapabilities:
      browserName: phantomjs

test.js:
gemini.suite('dev2dev', function(suite) {
    suite.setUrl('/')
    	.setCaptureElements('[data-ix="eventappear"]')
        .capture('plain', function(actions) {
        	actions.waitForElementToShow('[data-ix="eventappear"]', 30000)
        });
});

Console log:
 ~/Projects/test$ gemini update
WARNING
Running local gemini from /Users/dante/Projects/test/node_modules/gemini
Version: 4.11.0
Global: 4.9.0

✘ dev2dev plain [PhantomJS]
Area with css selector : [data-ix="eventappear"] is hidden
Total: 1 Passed: 0 Failed: 1 Skipped: 0 Retries: 0

It looks strange that error is about invisibility of element, but there is no info like not shown after 30000ms.

@tormozz48 ☝

@apsavin I have reproduced your case on my localhost.

Hi all. Any solution to this problem?

☝ Also having this problem.. =\

Can you provide some minimal-case html page to test? I've tried many different combinations of how element should appear and still can't reproduce this error locally.

Same issue I am facing .
Area with css selector : .headerimage-component is hidden
Total: 1 Passed: 0 Failed: 1 Skipped: 0 Retries: 0
Any work around for this. ?


Always log caught exceptions when logging warn messages.

We faced some connection problems that would have been easier to diagnose if caught exceptions would have been logged. Almost of the code already does this, so I changed the few places where this is handled differently.

Thanks!

Thanks for merging!


Make generator only fetch response from route if method is GET

Codecov Report

Merging #279 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #279   +/-   ##
=========================================
  Coverage     79.58%   79.58%
- Complexity      226      227    +1
=========================================
  Files             7        7
  Lines           720      720
=========================================
  Hits            573      573
  Misses          147      147

Impacted Files
Coverage Δ
Complexity Δ

.../Mpociot/ApiDoc/Commands/GenerateDocumentation.php
68.67% <100%> (ø)
57 <0> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0925f83...0dcb277. Read the comment docs.

Hi @rhys-vanhouten thanks for this. I'd like to merge, but do you think you could add some tests that  ensure we can always stay on top of this?


Dynamic pagination does not work if the limit is changed and the active page is not the first

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

This bug affects both client-side and server-side pagination, I've tested on both.
Current behavior
If you change the [limit] of items per page when you are at page 1 then it works fine, but if you do the same action while being in the last page and set a higher [limit] then it will not work and an empty table will be shown just empty.
Expected behavior
The limit of the items per page should always work, regardless of which page you are currently.
Reproduction of the problem
Using this plunker:
http://plnkr.co/edit/2X96Y1PJKAJM3lolcy2s?p=preview

select the limit of 5 items per page
go to the last page (page 20)
select the limit of 10 items per page

then the table will be empty, which is a bug.

Table version: 0.8.x
10.2.3

Angular version: 2.0.x
4.3.6

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Chrome

Language: [all | TypeScript X.X | ES6/7 | ES5]
TypeScript 2.4.1

@wizarrc can you take a look at this?

@ShinDarth That's cause the offset is too high for a higher limit, therefore showing empty.

@amcdnl @wizarrc thanks a lot!


[Spark] Refactor IcebergCompatV1

Which Delta project/connector is this regarding?

[x] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[ ] Other (fill in here)

Description

This PR refactors IcebergCompatV1 's check logic to make it can be reused by IcebergCompatV2
How was this patch tested?
This PR is tested via existing unit tests.

Does this PR introduce any user-facing changes?
No

lgtm ! super excited to see better iceberg compat support coming up.


improvement(generate:typetests,list): Only write output file when contents differs

Adds a utility function to write to files only if the contents you're writing is different from what's already there. This function is used in the type test generation and flub list to ensure we only write changes when needed.
This function may be useful for other commands as well, but those changes are left for separate PRs.
I also opportunistically replaced some synchronous function calls with async counterparts.

I think the motive I had for suggesting this work (avoid needless file churn as it could invalidate incremental build state) was flawed for multiple reasons:

We don't use modification time of inputs vs outputs to do our incremental build
If we did use the input vs output build times, tasks which consume other outputs could end up forever dirty due to this change, which is what I was thinking it might fix.

In conclusion: If I was right about how our build worked (and I wasn't) this would be really bad. Since I don't actually know how this part of our build works, someone else should probably make the judgement on if we want to do this.


Add 3.3 release notes

Version(s):

Issue:

Link to docs preview:

QE review:

[ ] QE has approved this change.

Additional information:

I'll apply the requested changes manually.


Doc string generation broken

Merge request #40 to fix the doc string generation. It works on my system and should be a good fix for read the docs. Read the docs isn't picking up the bug branch, so I think we should merge branch 39 into master to test it.

Issue is still present. Read the docs picked up branch 39 though, so I can test with that now. I'll keep troubleshooting.


Features/outline

Basic outline support based on @alexvdev's work.

Great that you finalised my work and put the feature to trunk!
How can we test it?

I updated the code that generates the guide so that it has outline bookmarks. I also added a short section on how to use the feature.
Is this an adequate method of testing? I didn't see any unit tests setup.

Ping @alafr

Unfortunatelly I don't have enough time to install, test, and merge pull requests right now.
Did you try to make the changes requested here: https://github.com/devongovett/pdfkit/pull/216#issuecomment-39674038 ?

@alafr I just modified my changes to follow the referenced comment. More closely. I didn't implement the addSection method and just return the PDFOutline object from the addItem method instead.

Should be ready to go now. I've updated the documentation to reflect the new methods. Let me know if anything else needs updated.

Thanks, it works great.
Just a few details:

In my opinion the outline panel should be opened by default if the document has outlines. It can be done with @_root.data.PageMode = 'UseOutlines'.
The expanded option is not described in the documentation.
Is the require('assert') module in lib/mixins/outline.coffee still used?

@alafr, I've made the requested changes.

When is the next planned version release? I'd like to be able to use this with npm.

I don't have access to npm, in the meantime you can replace with npm install pdfkit with npm install https://github.com/devongovett/pdfkit/tarball/master


feat: Add MANIFEST.in

Add a MANIFEST.in to the project that adds all the initially adds nothing (prunes everything), then adds only the files in src and tests, and then adds all "default" files for a sdist in MANIFEST.in. Additionally add a GHA based workflow to test building a package using build that also checks the package manifest and will list the contents of the resulting sdist and wheel for visual checks of the CI logs.
For additional context c.f. https://github.com/scikit-hep/pyhf/pull/1449
Suggested squash and merge commit message
* Add a MANIFEST.in to tell packagers what to include when building a package
* Use `prune **` to remove all files from the sdist
   - c.f. https://packaging.python.org/guides/using-manifest-in/#manifest-in-commands
   - "Setuptools also has undocumented support for ** matching zero or more characters including forward slash, backslash, and colon."
* Manually include all "default" files for a sdist in MANIFEST.in
   - c.f. https://packaging.python.org/guides/using-manifest-in/#how-files-are-included-in-an-sdist
* Add package publishing build test CI
   - Add list of sdist and wheel contents which allows for easier checking of the sdist contents in CI logs

@alexander-held this is ready for review and you have the ability to make any edits to it. :+1:
Example output from the CI that ran on my fork

where the visual spot checks give
$ python -m tarfile --list dist/cabinetry-*.tar.gz
cabinetry-0.2.3/
cabinetry-0.2.3/LICENSE
cabinetry-0.2.3/MANIFEST.in
cabinetry-0.2.3/PKG-INFO
cabinetry-0.2.3/README.md
cabinetry-0.2.3/pyproject.toml
cabinetry-0.2.3/setup.cfg
cabinetry-0.2.3/setup.py
cabinetry-0.2.3/src/
cabinetry-0.2.3/src/cabinetry/
cabinetry-0.2.3/src/cabinetry/__init__.py
cabinetry-0.2.3/src/cabinetry/_typing.py
cabinetry-0.2.3/src/cabinetry/cli/
cabinetry-0.2.3/src/cabinetry/cli/__init__.py
cabinetry-0.2.3/src/cabinetry/configuration.py
cabinetry-0.2.3/src/cabinetry/contrib/
cabinetry-0.2.3/src/cabinetry/contrib/__init__.py
cabinetry-0.2.3/src/cabinetry/contrib/histogram_creation.py
cabinetry-0.2.3/src/cabinetry/fit/
cabinetry-0.2.3/src/cabinetry/fit/__init__.py
cabinetry-0.2.3/src/cabinetry/fit/results_containers.py
cabinetry-0.2.3/src/cabinetry/histo.py
cabinetry-0.2.3/src/cabinetry/model_utils.py
cabinetry-0.2.3/src/cabinetry/py.typed
cabinetry-0.2.3/src/cabinetry/route.py
cabinetry-0.2.3/src/cabinetry/schemas/
cabinetry-0.2.3/src/cabinetry/schemas/config.json
cabinetry-0.2.3/src/cabinetry/smooth.py
cabinetry-0.2.3/src/cabinetry/tabulate.py
cabinetry-0.2.3/src/cabinetry/template_builder.py
cabinetry-0.2.3/src/cabinetry/template_postprocessor.py
cabinetry-0.2.3/src/cabinetry/visualize/
cabinetry-0.2.3/src/cabinetry/visualize/__init__.py
cabinetry-0.2.3/src/cabinetry/visualize/plot_model.py
cabinetry-0.2.3/src/cabinetry/visualize/plot_result.py
cabinetry-0.2.3/src/cabinetry/visualize/utils.py
cabinetry-0.2.3/src/cabinetry/workspace.py
cabinetry-0.2.3/src/cabinetry.egg-info/
cabinetry-0.2.3/src/cabinetry.egg-info/PKG-INFO
cabinetry-0.2.3/src/cabinetry.egg-info/SOURCES.txt
cabinetry-0.2.3/src/cabinetry.egg-info/dependency_links.txt
cabinetry-0.2.3/src/cabinetry.egg-info/entry_points.txt
cabinetry-0.2.3/src/cabinetry.egg-info/requires.txt
cabinetry-0.2.3/src/cabinetry.egg-info/top_level.txt
cabinetry-0.2.3/tests/
cabinetry-0.2.3/tests/__init__.py
cabinetry-0.2.3/tests/cli/
cabinetry-0.2.3/tests/cli/test_cli.py
cabinetry-0.2.3/tests/conftest.py
cabinetry-0.2.3/tests/contrib/
cabinetry-0.2.3/tests/contrib/test_histogram_creation.py
cabinetry-0.2.3/tests/fit/
cabinetry-0.2.3/tests/fit/test_fit.py
cabinetry-0.2.3/tests/fit/test_results_containers.py
cabinetry-0.2.3/tests/test_backends.py
cabinetry-0.2.3/tests/test_cabinetry.py
cabinetry-0.2.3/tests/test_configuration.py
cabinetry-0.2.3/tests/test_histo.py
cabinetry-0.2.3/tests/test_integration.py
cabinetry-0.2.3/tests/test_model_utils.py
cabinetry-0.2.3/tests/test_route.py
cabinetry-0.2.3/tests/test_smooth.py
cabinetry-0.2.3/tests/test_tabulate.py
cabinetry-0.2.3/tests/test_template_builder.py
cabinetry-0.2.3/tests/test_template_postprocessor.py
cabinetry-0.2.3/tests/test_workspace.py
cabinetry-0.2.3/tests/visualize/
cabinetry-0.2.3/tests/visualize/reference/
cabinetry-0.2.3/tests/visualize/reference/correlation_matrix.pdf
cabinetry-0.2.3/tests/visualize/reference/data_mc.pdf
cabinetry-0.2.3/tests/visualize/reference/data_mc_log.pdf
cabinetry-0.2.3/tests/visualize/reference/limit.pdf
cabinetry-0.2.3/tests/visualize/reference/pulls.pdf
cabinetry-0.2.3/tests/visualize/reference/ranking.pdf
cabinetry-0.2.3/tests/visualize/reference/scan.pdf
cabinetry-0.2.3/tests/visualize/reference/templates.pdf
cabinetry-0.2.3/tests/visualize/test_plot_model.py
cabinetry-0.2.3/tests/visualize/test_plot_result.py
cabinetry-0.2.3/tests/visualize/test_utils.py
cabinetry-0.2.3/tests/visualize/test_visualize.py

and
python -m zipfile --list dist/cabinetry-*.whl
File Name                                             Modified             Size
cabinetry/__init__.py                          2021-09-07 23:30:36          828
cabinetry/_typing.py                           2021-09-07 23:30:36          232
cabinetry/configuration.py                     2021-09-07 23:30:36        10350
cabinetry/histo.py                             2021-09-07 23:30:36         9436
cabinetry/model_utils.py                       2021-09-07 23:30:36        20378
cabinetry/py.typed                             2021-09-07 23:30:36            0
cabinetry/route.py                             2021-09-07 23:30:36        14370
cabinetry/smooth.py                            2021-09-07 23:30:36         4260
cabinetry/tabulate.py                          2021-09-07 23:30:36         8282
cabinetry/template_builder.py                  2021-09-07 23:30:36        16828
cabinetry/template_postprocessor.py            2021-09-07 23:30:36         7391
cabinetry/workspace.py                         2021-09-07 23:30:36        18103
cabinetry/cli/__init__.py                      2021-09-07 23:30:36        10242
cabinetry/contrib/__init__.py                  2021-09-07 23:30:36           85
cabinetry/contrib/histogram_creation.py        2021-09-07 23:30:36         3437
cabinetry/fit/__init__.py                      2021-09-07 23:30:36        30708
cabinetry/fit/results_containers.py            2021-09-07 23:30:36         3278
cabinetry/schemas/config.json                  2021-09-07 23:30:36        14525
cabinetry/visualize/__init__.py                2021-09-07 23:30:36        24055
cabinetry/visualize/plot_model.py              2021-09-07 23:30:36        13538
cabinetry/visualize/plot_result.py             2021-09-07 23:30:36        14032
cabinetry/visualize/utils.py                   2021-09-07 23:30:36         1449
cabinetry-0.2.3.dist-info/LICENSE              2021-09-07 23:31:12         1528
cabinetry-0.2.3.dist-info/METADATA             2021-09-07 23:31:12         8181
cabinetry-0.2.3.dist-info/WHEEL                2021-09-07 23:31:12           92
cabinetry-0.2.3.dist-info/entry_points.txt     2021-09-07 23:31:12           55
cabinetry-0.2.3.dist-info/top_level.txt        2021-09-07 23:31:12           10
cabinetry-0.2.3.dist-info/RECORD               2021-09-07 23:31:12         2330

I think this Issue is relevant for the check-manifest parts that I put in: https://github.com/mgedmin/check-manifest/issues/144

Thanks a lot for preparing this @matthewfeickert! To me this all looks good. I added *.png files to the excludes, which are built on-the-fly during tests from the pdf reference files from comparisons (and the pdf files are included in the sdist to allow running the tests).


Add Picture to Picture Project

This project has the functionality to stream some other tab's video in your particular tab in which you are working. This will be more clear if you just watch the video.
Its working video,
https://user-images.githubusercontent.com/75881393/115789762-45453800-a3e3-11eb-935d-7b609c60969b.mp4

Please @ridsuteri @urvashi-code1255 review this issue.


⚠ ClamAV has degraded performance

In ce1a113, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 225 ms

Resolved: ClamAV performance has improved in 2e6ebaa after 7 minutes.


Changes in Brush/Eraser Tools? Delay in screen updating?

I just updated acdc to version 22, and I noticed a change in the brush tool. Previously with the brush tool, it draws the mask of the cell that is in the center of the brush tool circle. However, now it seems to draw the mask of a cell that is not in the center of the circle.
The eraser tool looks like it has the same problem, but when you actually erase, it erases the cell that's actually in the center, and not the color the circle is. The brush tool doesn't behave this way.
Also, I noticed that sometimes there are delays in the screen updating after using the tool. The brush tool won't update the mask until you let go of the mask. And when you have the eraser tool on and you change frames, the masks don't update until you turn off the eraser tool.
Brush tool problems:

Eraser Tool problems:

Hi Jacob,
You are right, we changed the brush/eraser behaviour because I thought it makes more sense to modify the mask touched by the circle but if you prefer the old way I can add a choice in the settings so you choose which behaviour you want.
For the eraser behaviour instead you are right I didn't realise that it was still erasing in the center instead of the touching ID (if it is touching two IDs then it chooses the highest ID but actually it should choose the one that has the highest number of pixels in the circle?). Anyway that's a bug and I will fix it.
For the delay I will do some tests because I didn't see that behaviour.
For the problem with updating the mask with the active eraser that should have been fixed in the latest release because Jordan actually already reported it and he said it's fixed? See issue #42, can you actually double check you have v22? It should be written both on the terminal when you launch cell-acdc or from the Help --> About menu on the top of the main launcher.
Thanks and I will keep you updated.

I prefer the old way because when I draw a new bud, I just use the brush tool to create a partial circle off the mother. But with this update, I can't create a new cell id this way.

and yes, the update fixed the eraser mask problem.

I would prefer if both the brush and eraser tools had an option to revert to the original setting of choosing the mask in the center of the circle.

Absolutely no problem, I will add a setting that you can toggle. The setting will be saved and you will not have to change it anymore (unless you want the other mode of course)

So I released v1.2.4rc23 where the GUI has a  new option in the Settings menu called Brush/eraser cursor hovering mode and the default now is to use the centre of the circle, like in previous releases. Update with pip install --upgrade cellacdc. Let me know if it works, thanks!

Thanks it works!


bookmarks

first without auth - just being able to share links

Is this just having bookmarkable URLs that when revisited show the same item... like how webpages normally work? Or is there more to it than that?

I think the idea was that you could favorite a bunch of objects on the website, and then share those as a collection. So like, an on-site bookmarker and viewer of said objects. Think 'pinning' results of a search and then being able to bring those up.


Ignored exceptions are still built

I have a microservice that calls an external API. Sometimes, this external API will timeout, and my application will create a GatewayTimeoutException, with a NoResponseException as previous exception, with a Http\Client\Exception\NetworkException as previous exception, with a GuzzleHttp\Exception\ConnectException. It's 4 level deep.
I found that a lot of time was spent handling those in Sentry, so I added them to the list of ignored exceptions. This did not result in an improvement, because it seems the exceptions are still handled by Sentry, even if they are ultimately not sent to the server. I mitigated the issue by not setting the NoResponseException as a previous exception when not in debug mode, it resulted in a 100ms improvement. I won't share the blackfire trace because I can't redact things in it, but here is a screenshot of the interesting part, which does not involve code in my application:

Using
sentry/sdk                          2.1.0   This is a metapackage shipping sentry/sentry with a recommended http client.
sentry/sentry                       2.3.2   A PHP SDK for Sentry (http://sentry.io)
sentry/sentry-symfony               3.5.1   Symfony integration for Sentry (http://getsentry.com)

It seems to me that the issue is bound to #928, which introduced the IgnoreErrorsIntegration; due to that, the check for ignored exceptions is no longer performed at the top of the stack here: https://github.com/getsentry/sentry-php/blob/f28c0e1942de6621d75402f69a2c932d0c413a9c/src/Client.php#L96-L98
...but later, after the whole stacktrace is extracted, which is obviously costly with a 4-levels-deep exception chain...
@ste93cry WDYT?

I remember debugging through that code and being a bit confused by line 97 not being executed… I also saw there is an integrations config node, but I didn't figure how I should configure it, so I stuck with excluded_exceptions

so I stuck with excluded_exceptions

If you don't have the IgnoreErrorsIntegration integration enabled and you configured correctly that option then the code should exit at line 97 so it sounds strange to me that it's not executed.

but later, after the whole stacktrace is extracted, which is obviously costly with a 4-levels-deep exception chain

As can be seen from the screenshot at the beginning, the problems seems to be that for each frame we read the source code from the disk and this is pretty I/O intensive. @greg0ire you should try to see if with #1003 (not released yet) the issue goes away

it sounds strange to me that it's not executed.

It does, right? I just booted my work PC because I remember it being enabled in some sort of BC layer, and that's indeed the case, just not in this package. Here is the culprit:
https://github.com/getsentry/sentry-symfony/blob/6c3f3236504c2722eb5a8b26a10a2596bee62494/src/DependencyInjection/SentryExtension.php#L131-L137

So I suppose it's as if I have both the option and the integration enabled?

Yes, excluded_exceptions option is not being unsetted and thus both the legacy code and the new integration get executed: it's a bug and should be fixed

I don't fully understand what this done

While in the documentation it was mentioned that the context_lines option would have accepted null value to skip sending the source code of the frames of the stacktrace in reality it never worked, so I fixed it.

Yes, excluded_exceptions option is not being unsetted and thus both the legacy code and the new integration get executed: it's a bug and should be fixed

Woops, my bad, yes, that's a bug! I've opened https://github.com/getsentry/sentry-symfony/issues/345 to track this.

@greg0ire you should try to see if with #1003

I' trying it right now, for science, but as I understand it, this implies setting context_lines to null for all exceptions, including of course exceptions that are actually sent. I don't think I really want to do that.

Ah it looks like a change is needed on the Symfony bundle for null to be accepted :thinking:

Probably too laxist, but redefining the configuration node as a scalar node (as opposed to an integer node) allows null.

I managed to do it:

I hope this architecture is something you can change and not something that is forced upon you across SDKs

It is something requested to all SDK, but we have some leeway.
In this case, maybe we can fix this by putting the IgnoreErrorsIntegration first, so it will stop the execution early?

If you mean "first in the array of integrations", I doubt it will change anything. What this integrations does is register itself as a global event processor in the Scope. Then the scope calls it in a loop of event processing, but way, way too late (after the event is built, obviously).

I managed to do it, looks like you did a great job with that PR, -27% improvement! :

Well the improvement is not thanks to me: it's just that you are not reading anymore the source files to extract the context lines to send along with each frame, so there is less I/O which is eavy by nature.

this implies setting context_lines to null for all exceptions, including of course exceptions that are actually sent. I don't think I really want to do that.

It was just a test to see if it was the culprit of the problem, I didn't mean that it was the solution :wink:

Probably too laxist, but redefining the configuration node as a scalar node (as opposed to an integer node) allows null.

@Jean85 this is another bug to be fixed related to #1003

What this integrations does is register itself as a global event processor in the Scope. Then the scope calls it in a loop of event processing, but way, way too late (after the event is built, obviously)

I think that #1011 can definitely help because it will move this task to an integration itself, and if configured to run later than the aforementioned integration it will solve all problems. If you are willing to test the branch and see if it helps you it would be cool

Sure! Can you please run this gist from your local repo, with your branch checked out, then post the results on the PR? It will help me do the test. https://gist.github.com/greg0ire/a404831add1247d2bc20fa11107c5d5e

Here you go:
composer config repositories.ste93cry vcs https://github.com/ste93cry/sentry-php
composer require sentry/sentry "dev-feature/add-frame-contextifier-integration as 2.3.2"

Nice job here too, that's a 50% improvement!

Are these changes sufficient for your use-case? If so, feel free to close the issue

They are, thanks


ui.panel_conditional() within a module assumes namespaced inputs

AFAICT, it isn't possible for users to escape the automatic module namespacing for the conditional input. In the example below, input.switch is intended to refer to a global "switch" input, but because ui.panel_conditional() is called within a module it always namespaces the condition expression to the module.
from shiny import App, module, reactive, render, ui

@module.ui
def counter_ui():
    return ui.card(
        ui.card_header("Conditional Panel"),
        ui.panel_conditional("input.switch", ui.card("Test")),
        ui.output_ui("dynamic_card")
    )

@module.server
def counter_server(input, output, session, global_switch):
    @render.ui()
    @reactive.event(global_switch)
    def dynamic_card():
        print(f"Switch: global_switch()")
        return ui.card("Dynamic Card") if global_switch() else None

app_ui = ui.page_fluid(
    ui.input_switch("switch", "Switch", value=False),
    counter_ui("counter1"),
)

def server(input, output, session):
    counter_server("counter1", global_switch=input.switch)

app = App(app_ui, server)

Example on shinylive
Reported on Discord

I think we could address this by adding a namespace argument to panel_conditional() and allow something like namespace=None to effectively mean namespace=shiny._namespaces.Root?

Also more generally it'd be nice to have some documentation on how to "escape" auto-namespacing in modules. In other places, I'm pretty sure you do that by wrapping your ids in ResolvedId(), but at moment, I don't think we make that part of the public API.

I think I have a similar issue where I get a client error when trying to use a reactive input in the ui.panel_conditional() in the main app that I have returned from a module UI.
This example shows a ui.panel_conditional() responding to input within the module but it doesn't work when I try to pass that value to the main app and use in another ui.panel_conditional(), even though I can access the value in my server.
Any advice would be appreciated!
Link to shinylive example


Production-ready policy service

Is your feature request related to a problem? Please describe.
Policy service concept has been proven and a fully functional file-based policy service prototype has been completed but now we need a production-ready policy service.
Describe the solution you'd like
Make a production-ready policy service:

[x] policy service using atServer for persistence
[ ] policy service using PostgreSQL for persistence
[x] policy dashboard GUI MVP
[x] policy dashboard API MVP
[x] Modify build scripts so that the policy service is included in the release tarball
[ ] Add end-to-end tests which exercise the policy service (one positive, one negative)

Still a bunch more work to do on this

Lot of progress this sprint. Reducing SP for next sprint to 5

Almost done, reducing SP for this sprint to 3

During PR97, split out the core policy framework into its own package, and made it generic - i.e. no hard or soft (semantic) dependency on noports. Refactored noports code accordingly. Added
During PR98, will
. publish core policy package
. ensure noports works with new policy-related requests and responses
. ensure new policy service supports the requests which were supported by the alpha, since we have some alpha policy services in the field
. get noports pull request with all of the new policy stuff reviewed and merged

Almost, but still not quite, completed. Last two weeks was a sprintus horribilis for me. About 4SP effort remaining.

About 5SP worth of improvements last sprint, will be completed in PR100

No progress in PR100 during which most of my time was spent on this PR and the remainder investigating and/or fixing other bugs

Feature-complete; aiming to get everything published and released this week

[ ] standalone generic at_policy package with documentation and basic code samples (Monday)
[ ] revised NoPorts policy implementation using the new package, plus backwards compatibility (Thursday)


[FEATURE] Remove automatic assignees to issue templates, keep them in PR

What needs to be done
Currently @bradtaniguchi and @nhcarrigan are automatically assigned as Assignees to most it not all issues created. This should be changed, to incentivies other user's to contribute to the bot. 😄  This will also fit with the workflow that stuff people work on is assigned to those working on it at that time.
Additional context
However the PR template should keep these two people as assignees, as they should review any PR's made.
PS. This issue is written in the third person, which is kinda funny haha

The PR template doesn't actually assign anyone. That's handled by a CODEOWNERS file which we don't have - easy enough to add though.
LHLloyd has been eager to contribute to the bot and this seems like a good place to start. I'll ping him when he's next online and see if he's interested.

I'll look into how to fix this! Thanks guys!!!


Removed duplicate word (inside)

How to categorize this PR?

/area documentation
/kind cleanup
/priority normal
What this PR does / why we need it:
It removes a redundant word and fixes the documentation to be more easy to read/understand.
Which issue(s) this PR fixes:
Fixes #
The PR does not fix a bug, but the documentation.
Special notes for your reviewer:
Release note:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you @ScheererJ for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

CLA needs to be signed. 👀
/author-action


release new build with web: 1.0.0

Thanks for the reminder.
I will release it soon, I just try to fix some smaller issues that have pilled up beforehand.


Update Olric to latest version 0.5.x

Observed a data race when fetching stats after upgrade to 0.5.3.
I have opened an issue on olric repo - https://github.com/buraksezer/olric/issues/219


MPTTModelAdmin does not work with ModelAdmin

MPTT admin does not compatible with django-unfold. Could you please help me to fix this?
code:
from mptt.admin import MPTTModelAdmin
from unfold.admin import ModelAdmin, TabularInline
@admin.register(ProductCategory)
class ProductCategoryAdmin(MPTTModelAdmin, ModelAdmin):
    list_display = ("title", "parent", "display_attributes", "display_tax_groups")
    search_fields = ("title",)
    mptt_level_indent = 20
    list_filter = ("parent",)
    inlines = [ProductCategoryAttributesInline, ProductCategoryTaxGroupsInline]

result:

Hi, this is duplicate of #366 so I'm closing this ticket.