[Support]

Hi team,
There is no issue here, meanwhile since my first ticket wireguard and pivpn run fine.
However, since I managed to configure a basic install, I would like to add a subnet,
to be able to separate client groups and prevent 'client to client' LAN activity, not all users should be able to visit other clients networks.
I managed to configure a subnet  wg1  with <IP_ADDRESS>  same as wg0 <IP_ADDRESS>.
Same firewall rules, same config, just another port and subnet.
But Unfortunately,  when i do #wg to list all wireguard interfaces, I see wg0 with all peers, but wg1 has no peers at all. I tried a lot of 'wg set' and 'wg-quick' commands to have the peer listed on wg1,
but without success. it is just not listing the peer I tried to add.
Even if i would manage, it would stay a manual procedure to create every single new  user peer .conf file.
Why does pivpn support only a default wg0 subnet?  It would be very handy to build client peer
conf files for other subnets on the wireguard server.
Or is there another way to approach?

Converting this to discussion.


enh(cpp) Improve C++ class template headers

This fixes #2716 and it fixes #21021. In order to parse class and function headers correctly, it is insufficient to just skip greedily (or, worse, non-greedily) over /<.*>/, since C++ template declarations as well as template instantiations can contain nested template parameter lists. As a further complication, they can even contain the operators <, >, << and >> (as part of non-type template parameters or their defaults (in declarations)).
This PR attempts to be a minimal change — a much more comprehensive refactor of the C and C++ language definitions is somewhat overdue (see #2173 and #2146). But this will take time, and in the meantime the improvement from this PR is probably “good enough”.
This PR is a WIP: there are some open issues that I’ve commented inside the changes.

1 The failing code from the second issue isn’t added as a test case because hljs still fails to highlight it as a function declaration, but that’s unrelated to templates and rather because hljs currently doesn’t recognise operator overload definitions at all.

Closing this in favor of #2752.  Thanks for all the hard work on this though - it's been appreciated!  Hopefully you've learned a bit about the grammars and parser that will help you if you continue to contribute. :-)
If we find more failure cases we can always re-review, but this was getting way to complicated.

Yes, I’m definitely in favour of closing this for now and re-submitting another PR later (in particular, after splitting the definitions for C and C++), I just need to find some time …


add: adw-gtk3

This merge is trying to carry in the previous package you had merged in. Please rebase your branch, it currently has conflicts.

This merge is trying to carry in the previous package you had merged in. Please rebase your branch, it currently has conflicts.

done, i think


Sticky Scroll Support

VS Code has a sticky scroll feature which shows the context of the code as you scroll. It doesn't work for ActionScript code. How difficult would it be to enable it for ActionScript?

This may be useful: https://stackoverflow.com/questions/73420407/sticky-scroll-with-custom-language

Wow that was fast! Amazing! 🎉


Chronological based on quality

Well I have found this repo to be very useful but it seems to me that the items in the list are not in any chronological order. Correct me if wrong.
And I feel that it should have something like top 3 that are very much essential and should not be left out.

Yes, they're not on chronological order list. What would be your suggestion for a top 3? Maybe we could do that in the future.

Its the top 3 of resources(articles/videos) that I was thinking and not the top 3 topics. As I have seen that sometimes the most valuable resources are at the bottom and will be left out by the most of the people.

@rohitmi0023 The problem is who get's to decide which resources are the most valuable? I would guess the 3 most valuable to you could easily the 3 least valuable to someone else.
I do think there are far too many resources for some of these topics, and would love to see a "top 5" for all the concepts. But this would have to be what the community thinks are the most valuable as a whole.

@zeitchef I agree with you. I think that an important topic for a developer depends on what problem he/she is trying to solve in that specific moment. I'm planning to do a repagination in the repo and filter some topics that have too many resources, and maintain only the most high-quality resources.

@zeitchef What I am trying to point about the top 3/5 resources is kinda similar to what we have editor's choice in google playstore. Those apps are the preferred ones by the editor's and doesn't comments on the others apps.
Yes, I agree with you totally that it is the community that eventually will decide about the more valuable resources.


Error: Failed to choose a D3D11 Adapter.

I looked at the logs, I saw this:
A D3D11-compatible GPU (Feature Level 11.0, Shader Model 5.0) is required to run the engine.
I think the default instance doesn't have a compatible GPU. I don't know how to proceed.

Thus, the build is not running. Please note the webserver does start:

What instance are you running?
I was using g4ad.xlarge. Even though it was not necessary I installed the vGaming drivers instead of workstation drivers that are default. That was only to get RTX, not necessary for streaming unless your project has RTX ON.

What instance are you running?
I was using g4ad.xlarge. Even though it was not necessary I installed the vGaming drivers instead of workstation drivers that are default. That was only to get RTX, not necessary for streaming unless your project has RTX ON.

What instance are you running?

I am using the default values of the CloudFormation template. So the instance is g4dn.xlarge.

I was using g4ad.xlarge. Even though it was not necessary I installed the vGaming drivers instead of workstation drivers that are default. That was only to get RTX, not necessary for streaming unless your project has RTX ON?
I remember getting similar errors when running RTX-stuff on the default instance.

Very interesting @sebrk. Can you tell me how to install those drivers? Maybe that'll help me solve my issue.
@kashman-amzn I think this shows a pattern with the default configuration. BTW, I am trying to deploy the pixel streaming demo, nothing special.

What instance are you running?

I am using the default values of the CloudFormation template. So the instance is g4dn.xlarge.

I was using g4ad.xlarge. Even though it was not necessary I installed the vGaming drivers instead of workstation drivers that are default. That was only to get RTX, not necessary for streaming unless your project has RTX ON?
I remember getting similar errors when running RTX-stuff on the default instance.

Very interesting @sebrk. Can you tell me how to install those drivers? Maybe that'll help me solve my issue.
@kashman-amzn I think this shows a pattern with the default configuration. BTW, I am trying to deploy the pixel streaming demo, nothing special.

Do you have RTX on?
instructions here: https://docs.aws.amazon.com/AWSEC2/latest/WindowsGuide/install-nvidia-driver.html#nvidia-gaming-driver

Do you have RTX on?
instructions here: https://docs.aws.amazon.com/AWSEC2/latest/WindowsGuide/install-nvidia-driver.html#nvidia-gaming-driver

@sebrk Amazing!, you fixed it! I am not sure if I required RTX or not but this was the solution. I followed the steps you linked until step 3 and that was enough. Do you know how to automate this process or put it in the CloudFormation template?

@sebrk Amazing!, you fixed it! I am not sure if I required RTX or not but this was the solution. I followed the steps you linked until step 3 and that was enough. Do you know how to automate this process or put it in the CloudFormation template?

@sebrk Amazing!, you fixed it! I am not sure if I required RTX or not but this was the solution. I followed the steps you linked until step 3 and that was enough. Do you know how to automate this process or put it in the CloudFormation template?

Great! You probably had a bad case of drivers from the start. I have not automated this but googling around should help you find information on it.

@sebrk Amazing!, you fixed it! I am not sure if I required RTX or not but this was the solution. I followed the steps you linked until step 3 and that was enough. Do you know how to automate this process or put it in the CloudFormation template?

Great! You probably had a bad case of drivers from the start. I have not automated this but googling around should help you find information on it.

@kashman-amzn could you modify the CloudFormation template to include the aforementioned drivers?

@kashman-amzn could you modify the CloudFormation template to include the aforementioned drivers?

Thank you for your collaboration on this issue and working through and identifying the need for the NVIDIA gaming driver. The GRID drivers are installed as part of the NICE DCV installation, and works for many UE4 projects but we will modify the CloudFormation to switch to the gaming driver. Again thanks for digging into this.

Thank you for your collaboration on this issue and working through and identifying the need for the NVIDIA gaming driver. The GRID drivers are installed as part of the NICE DCV installation, and works for many UE4 projects but we will modify the CloudFormation to switch to the gaming driver. Again thanks for digging into this.

Excellent @kashman-amzn!

Excellent @kashman-amzn!

@kashman-amzn thank you very much! When do you think we'll have the new CloudFormation?

@kashman-amzn thank you very much! When do you think we'll have the new CloudFormation?

@kashman-amzn I saw your recent commit. If I wanted to use the NVIDIA gaming driver what steps should I take to modify the CloudFormation template?

I am planning to get to this but it may not happen until next week. One way you can do this is to add a silent install of the latest NVIDIA EC2 gaming driver in the bootstrap script. You could also execute it in the CFn script by adding the file to the download items and executing the silent install. Documentation on NVIDIA driver installation can be found here: https://docs.aws.amazon.com/AWSEC2/latest/WindowsGuide/install-nvidia-driver.html

I have added the installation of the .NET Framework and run the UE4PrereqSetup that is bundled with the build by the engine. This should ensure current and future dependencies are resolved before running the pixel streaming build. As far as the NVIDIA gaming driver, I have added a note on how to install that driver if desired, but with the prerequisite installed the Unreal Engine Pixel Streaming demo that failed before now succeeds and streams as expected at 60fps.

Hey @kashman-amzn, I used the latest scripts and I still get the same issue trying to deploy the pixel streaming demo. Are you sure you were able to deploy it?

I was able to deploy it by changing the DiskSize to 45GB.

That is great. I will be increasing the default storage value to 50GB so that larger sized projects will work by default.


Breadcrumbs css fix for kie-distributions

https://github.com/kiegroup/kie-wb-distributions/pull/521

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.


Gravatar Helper with Attribs Method

Hi
Conventionally, the method to configure attributes in Zend Framework is setAttributes. Gravatar helper uses setAttribs and the docs for Gravatar describes the helper with a setAttributes method. What is the correct form?
I'm questioning because I'll create a patch for it, dependending of your decision.

@wandersonwhcr
Sorry for the late response.

What is the correct form?

It should be setAttributes.

I'll create a patch for it

We must mark the setAttribs method as deprecated and use this method as proxy to the new setAttributes.
Good catch! 👍

@froschdesign Thanks. I'll create a PR.

We must call a trigger_error with an E_USER_WARNING level?

Go for it!

Fixed with version 2.10.0


Better file naming for AppVeyor artifacts

This builds upon https://github.com/godotengine/godot/pull/38625 and improves the file name format as mentioned in https://github.com/godotengine/godot/pull/38189#issuecomment-626585363
The resulting file stored has the name godot.windows.opt.tools.64-$(VERSION_HASH).zip where VERSION_HASH is obtained from it rev-parse --short=9 HEAD , the zip file contains the built exe file.

IMO it would be good to also change the name of the .exe, so that users can remember what extracted binary corresponds to.
Might also be good to add the $env:APPVEYOR_REPO_BRANCH (that's in PS, would have to check how to get it in cmd or convert the script to ps:) which could be 3.2 or master.
E.g. some naming like: godot_${APPVEYOR_REPO_BRANCH}-${COMMIT}_win64.exe.
BTW there's also APPVEYOR_REPO_COMMIT in the env that gives the commit hash, though I don't know if it's the full version or a shortened one.

IMO it would be good to also change the name of the .exe, so that users can remember what extracted binary corresponds to.
Might also be good to add the $env:APPVEYOR_REPO_BRANCH (that's in PS, would have to check how to get it in cmd or convert the script to ps:) which could be 3.2 or master.
E.g. some naming like: godot_${APPVEYOR_REPO_BRANCH}-${COMMIT}_win64.exe.
BTW there's also APPVEYOR_REPO_COMMIT in the env that gives the commit hash, though I don't know if it's the full version or a shortened one.
https://www.appveyor.com/docs/environment-variables/

COMMIT is the full hash , i suggest we still use git rev-parse --short=9 HEAD for that, but APPVEYOR_REPO_BRANCH works fine,
Here's the filenames after my updates PR:
godot_3.2-6abcde465_win64.exe
inside
godot_3.2-6abcde465_win64.zip

Could you squash commits into one?
See PR workflow.

I think i did squash them into one commit - https://github.com/Ashesh3/godot/commit/18d71fad6b022802ca1877db1659f19e323f8dc3
Is that correct?

Is that correct?

Not exactly, as you also included 6 unrelated commits that you rebased (that's partly due to my rebase instructions in the doc being not optimal). You should rebase with git rebase -i upstream/master to fix it.

Oh i might have done something work, anyways, it should be fine now.
Thanks @Technohacker for helping me making this work.

Thanks!

Cherry-picked for 3.2.2.


Workflow to Update with Upstream

A workflow that opens a PR whenever the upstream makes a new release or if there are conflicts, opens an issue.

@proffapt


__declspec 'empty_bases' or 'emptyBases' isn't documented

This blog post talks about the __declspec(emptyBases) annotation:
https://devblogs.microsoft.com/cppblog/compiler-improvements-in-vs-2015-update-2/
This blog post talks about the __declspec(empty_bases) annotation:
https://devblogs.microsoft.com/cppblog/optimizing-the-layout-of-empty-base-classes-in-vs2015-update-2-3/
Getting the correct syntax documented here, along with an explanation of what the annotation does would be great.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0b97db02-7e53-f7b2-c1b3-d406b6e293b7
Version Independent ID: a97cb658-b551-7324-4d44-6f6d676c3870
Content: __declspec
Content Source: docs/cpp/declspec.md
Product: visual-cpp
Technology: cpp-language
GitHub Login: @mikeblome
Microsoft Alias: mblome

@mschofie
It looks like __declspec(empty_bases) is the correct spelling. We'll look into it.

investigating

We are in the process of moving away from GitHub issues for C++ documentation (we still accept pull requests). For details, please see Announcing a new way to give feedback on Microsoft Learn This issue will be closed after it is copied to an internal tracking system.


bug: ion-textarea autoGrow=“true” on modal, work only the first time

Expected behaviour:
Each time the ion-textarea should be the same size.
Actual behaviour:
I have a strange behaviour with ion-textarea autoGrow="true" that was introduced in ionic 4.4, the first time the autoGrow is made correctly. The 2nd time the textarea is less than 1 row. We can't even see the text. This bug is only on "modal".
I open the modal like this
displayModal(data) {
this.modalCtrl.create({
 component: EventDetailModalComponent, componentProps: {
   event: data.appointmentData,
   timeFormat: this.timeFormat,
   dateFormat: this.dateFormat
 }
}).then(modalElement => {
 modalElement.present();
});  }

And close like this :
onCancel() { this.modalCtrl.dismiss(); }
View contains :
 <ion-item lines="none">
        <ion-label position="floating">{{'DESCRIPTION' | translate }}</ion-label>
        <ion-textarea readonly disabled autoGrow="true" class="ion-text-justify" value="{{ description }}" ></ion-textarea>
 </ion-item>

For info, the text is inserted manually by the programme in value="x", not entered by the user.
I'm running the last version of ionic ("@ionic-native/core": "^5.11.0") and Angular (8.2).
Same problem tested on last version of Chrome, Safari and FireFox on Mac.
You can test here :
https://stackblitz.com/edit/ionic-v4-angular-ion-textarea-autogrowth
This was already reported on "stackoverflow":
https://stackoverflow.com/questions/57336796/ion-textarea-autogrow-true-on-modal-work-only-the-first-time
They came to the conclusion that should be a bug.

Confirmed. Still present in @ionic/angular: 4.11.1

Hello, this issue is still present in @ionic/angular: 5.0.5.

For some reason or another, I am only seeing this on md, not ios.

Thanks for the issue. This has been resolved via https://github.com/ionic-team/ionic/pull/20971, and a fix will be available in an upcoming release of Ionic Framework.


Is vsock designed as the only access in kata using firecracker?

As kata users in k8s, we focused on firecracker for a long time and I knew that it must with vsock support. The kernel version >= 4.8 is really an obstructive limitation in cloud production ENV, most vendors are still using 3.x kernel.
Does the community have a plan like kata-proxy for firecracker?

@clarklee92 can we close this issue ?

@clarklee92 can we close this issue ?

Of course yes. Thanks again.


Milestone report is blank

The Milestone report is blank for some sections but not others

This is due to a serialization issue in the GetGroupLifeResultModel class where the Milestone status_updated may be null. Will fix and raise PR

No permissions to push, but happy for you to fix. Change is to make Milestone.status_updated a nullable DateTime type

Thanks Mark,
Have added you as a contributor.
Could you send through a response with this condition so I can process it correctly?

Hi Mark,
Can you check to see if the SIA report works or has a similar issue in the deserialization?
Thanks.

PR https://github.com/NomisNostab/Topo/pull/15 to fix this issue.
SIA report is also blank but not cause by a deserialization exception. This looks to be a different issue


Please release the source code

A source code release would make it easier for others to contribute and increase the audience since many people don't appear comfortable running modified "exe"s without knowing what was modified.

The disclaimer from the development thread still applies, I have every intention to release the source code, but it's hobbled together from several other projects and needs to be cleaned up first:

Source Code
>Source code ***will*** be available in the future, I literally threw this thing together using bits and pieces from my other mods in about an hour's work. When I get things cleaned up, check back on the GitHub repository.

Code has been checked-in.


Reporting Additions and Deletions separately

Currently, sccdiff shows cumulative lines of code changed (sum of additions and deletions).
For our purposes we really need to know how many lines changed. Would it be possible to break out lines added and deleted separately, in the GH Action text?
For example
Code: 8010 (+233, -150)

In the end a superior dev to me (DrGorillaMD) figured out a git command to do this. Closing the issue.
git diff --shortstat main...audit/revisions -- '***.sol' ':!*system_tests*'


soapy source fix: message handler sample_rate port

sample_rate message handler is now properly added to soapy sink

thanks!


Incorrect output: Jagged outlines and no holes

Hi, thanks a lot for your work on this package.
I tried to reproduce tracing the sample image from the readme.
The outlines look jagged and it seems that there are no holes at all in the image.

I tried using both gotrace.Trace and gotraceb.Trace
I'm on Ubuntu 22.04 using WLS2 from a Windows 11 host and I tried both go1.19.3 and go1.10.
When I use the potrace command line tool, the output looks fine.
package main

import (
	"fmt"
	"image"
	"image/color"
	_ "image/png"
	"os"

	"github.com/dennwc/gotrace"
	gotraceb "github.com/dennwc/gotrace/bindings"
)

func main() {
	imgPath := "/home/jakob/tmp/potrace/stanford-orig2.png"

	rdr, err := os.Open(imgPath)
	check(err)
	defer rdr.Close()

	img, _, err := image.Decode(rdr)
	check(err)

	thresholdFunc := func(_, _ int, cl color.Color) bool {
		r, g, b, _ := cl.RGBA()
		return r+g+b < 128
	}
	bm := gotrace.NewBitmapFromImage(img, thresholdFunc)

	paths, err := gotrace.Trace(bm, nil)
	//paths, err := gotraceb.Trace(bm, nil)

	f, err := os.Create("/home/jakob/tmp/trace.svg")
	check(err)
	defer f.Close()

	gotrace.WriteSvg(f, image.Rect(0, 0, img.Bounds().Dx(), img.Bounds().Dy()), paths, "red")
}

func check(err error) {
	if err != nil {
		fmt.Println(err)
		panic(err)
	}
}

No holes problem is apparently same as https://github.com/dennwc/gotrace/issues/6, as WriteSvg() function does not process the path recursively.
Regarding jagged edges, I suggest to add Params struct to Trace() call. Default values can be found here https://github.com/dennwc/gotrace/blob/v1.0.3/gotrace.go#L95 and by tweaking them you should get better results (parameters are explained in original potrace library, for example in this document: https://potrace.sourceforge.net/potracelib.pdf, chapter 2.3).

This library is deprecated, so I'm closing this now and will archive the repository. See gotranspile/gotrace instead. Its output matches potrace 1:1.


Refactoring pane: wierd selection box focus behaviour

Only cpp extension active which is needed for refactoring.
Steps to Reproduce:

Refactor any (c? didn't test other languages) code that brings up said pane and tick some boxes.

Result:

Look at that focus box around the selection boxes.

VS Code Version: 1.63.2

OS Version: Win10 21H1 19043.1415

@jrieken I think this follows the same pattern in the the breakpoints view, though it also appears to react differently in the settings gui:
https://user-images.githubusercontent.com/35271042/148124743-6e7d1c82-a2f8-4d0d-b0d5-9c75f136641c.mp4

We could do a better job at reusing templates for renders.

Verification

Open Debug view
Click the Caught Exceptions breakpoint checkbox

🐛 The Uncaught Exceptions breakpoint checkbox is now focused. It shouldn't be.


How I compile FFmpeg with zscale in Ubuntu?

Its possible?

Please direct FFmpeg questions to the ffmpeg-devel mailing list.
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Composer Conflict with AWS SDK

I'm getting a dependency conflict because you are requiring the guzzlehttp version 4.*.  The aws/aws-sdk-php requires guzzlehttp/guzzle: ~5.3|~6.0.1|~6.
Could you update your dependency library?
See below:
`Your requirements could not be resolved to an installable set of packages.
Problem 1
- Installation request for 2amigos/yii2-google-maps-library ^1.0 -> satisfiable by 2amigos/yii2-google-maps-library[1.0.0].
- Conclusion: remove guzzlehttp/guzzle 6.1.1`

done here: https://github.com/2amigos/yii2-google-maps-library/pull/49
waiting to have some free time to merge and check if there are any conflicts or if its working correctly

@jonrobinson have updated the master branch, mind checking if it works for you? if it does will update tag revision. Thanks.

Sure.  I will check it tomorrow.
Thanks!
Jon Robinson, PhD
Johns Hopkins Institute of Genetic Medicine
Lead Developer
SamCart
site: samcart.com
Brewber
site: brewberapp.com
On Tue, Mar 8, 2016 at 7:47 PM, Antonio Ramirez<EMAIL_ADDRESS>wrote:

@jonrobinson https://github.com/jonrobinson have updated the master
branch, mind checking if it works for you? if it does will update tag
revision. Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/2amigos/yii2-google-maps-library/issues/51#issuecomment-194041496
.


Update deployment instructions

Lets do regular installs from now on to avoid painful Python things.

I'm curious if there are specific pain points you ran into with editable installs, but I can see the attraction of having the main deployment be as boring as possible, so LGTM.

TL;DR: I screwed up the beta environment and tried to fix it by cloning the stable module environment, but that copied over a file from the editable install of the old amore_mid_prototype package, which led to this beauty:
wrigleyj@max-exfl462 ~ % module load exfel amore/beta
wrigleyj@max-exfl462 ~ % pip show damnit
WARNING: Package(s) not found: damnit
wrigleyj@max-exfl462 ~ % python
Python 3.10.4 (main, Mar 31 2022, 08:41:55) [GCC 7.5.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import damnit
>>> damnit.__file__
'/gpfs/exfel/sw/software/xfel_anaconda3/amore-mid/damnit/__init__.py'

And then @RobertRosca fixed it and said there were other potential murky issues with editable installs, so I figured it's better to stick with a regular install :upside_down_face:


Rework isCSSColor check

This PR makes the code in color.js slightly more complex, but gets rid of a dependency both in the main Shields server and the NPM package.
I ran a micro-benchmark to check that performance wasn't affected negatively (careful, you have to change to badge URL in scripts/benchmark-performance.js to be a non-standard Shields colour): the new isCSSColor is actually ~10% faster on my machine - though as we're only talking about a few μs, I wouldn't treat this as a strong argument in favour of the PR.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @PyvesB!

  Generated by :no_entry_sign: dangerJS against 0bc2973c34f352b05dffa54536d21489d9883104

Are there any cases which are covered in the is-css-color test suite https://github.com/princejwesley/is-css-color/blob/master/test.js that we should add to our tests for normalizeColor() just to make sure we're not regressing on a corner case by making this change?

@chris48s good point!
As far as I can tell from comparing with those unit tests, two edge cases are regressing within normalizeColor:

when the specified color has leading white space. This could be solved with a trim() call if we think we should still handle such cases.
RGBA colors such as rgba(-100, 20, 111, 1), but they don't actually seem to work today anyway, at least on our running Shields.io server: https://img.shields.io/badge/hello-world-rgba(--100%2C 20%2C 111%2C 1). Maybe it's simply not supported by SVGs?

Okay, this has gotten more involved than I expected, I've had to consult the CSS color specifications. After the latest commit and with some further digging:

colors with trailing or leading whitespace now pass normalisation. No change in behaviour then.
hex colors with four or eight digits (e.g. #fffe are now accepted), whereas they weren't previously. This seems to comply with the new CSS draft spec, and renders fine in badges, seems like a good addition to me.
RGB colors with negative numbers (rgb(-100, 20, 111)) now fail normalisation. The current CSS spec talks about clipping, the new CSS draft spec seems to think they're invalid. They don't render properly today anyway (https://img.shields.io/badge/hello-world-rgb(--100%2C 20%2C 111)), so I would say this is a good thing.
unlike what I said above, RGBA colors do work. The examples used in https://github.com/princejwesley/is-css-color/blob/master/test.js all have a negative value for one of the components, which is why they were failing when I tried them yesterday. Same as RGB colors then.
RBG colors with a mix of percentages and absolute values now pass normalisation, but render weirdly in an SVG. According to the CSS specification, I don't think this should be allowed, I've raised https://github.com/andyjansson/css-color-converter/issues/4 but wouldn't treat it as a blocker.

this has gotten more involved than I expected

The devil is in the detail  :japanese_goblin:
Basically happy to merge this. I think the test failures are unrelated to the changes in this PR but I tried restarting the build and they still failed.

oh yes the same test failures are being discussed in https://github.com/badges/shields/pull/5509


beginner got an error i wonder if my folder files is correct or something is wrong?

Hi thanks for making this gem. this is absolutely wonderful.
anyway i just try to play with the gem when i tried to run apps i got an error
Facebook::Messenger::Error: An active access token must be used to query information about the current user.
i wonder if my folder structure file is correct
https://github.com/ferryphang/SleepingForest
./bot.rb
./facebook/messenger.rb
./config.ru

@ferryphang hey, I think it's naming collision or something like that in your case. Can you try to rename folder "facebook/messenger" to something different? When you do require facebook/messenger you're actually requiring stuff from this gem, not your code.

@nashby ooh okay my bad i just tried to replace and require on the bot.rb for the Facebook configuration token. Thanks its working now. 👍

@ferryphang glad I could help! :)


HW W07 D02- Pixart Assignment

Comfort: 4
Completeness: 4
Took me a week but I think I've got it down now (conceptually). The only thing I don't understand is how we actually set the mouse to being the brush. As in I understand that we have a div called brush; but don't understand how we can have that brush be equatable to a mouse. If you could speak to that I'd really appreciate it!

Don't worry about my question! Figured it out; tis a silly question. Thank you


Renamed pathToJest to jestCommandLine in ProjectWorkspace

Should close #44

Fails

:no_entry_sign:

No CHANGELOG added. If this is a small PR, or a bug-fix for an unreleased bug add #trivial to your PR message and re-run CI.

  Generated by :no_entry_sign: dangerJS against c14be7c74d41813b3bbf4c33f95be19ad0d4a3fa

I've updated the changelog, bumping the major version since there a breaking change in the public API.

@rossknudsen thanks for the PR 👍 , I will cut a beta soon so we can start to play with the new changes

Sounds good, I was starting to see some parsing issues around it.each, so I'm keen to see how the new one works. I'll update my other TS PR too - whether it makes this release it the next one.


Actions.find overlaps the first 2 lines of code

VSCode Version: 1.23.1
OS Version: Windows Server 2016

Steps to Reproduce:

Open actions.find ctrl+f
Open new tab ctrl+n

Does this issue occur when all extensions are disabled?: Yes

@rebornix I remember it used to be Cmd+F always give space to first 2 lines...Now this only applies to untitled files but not other files. Was that intentional?

We didn't re-adjust the position of the find widget when you switch editors, otherwise you will see flickering over often. You can scroll down the editor a bit and then the first two lines will not be covered.


Add tm blog

Cheers Paul, great idea.

sweet. the gde page didn't list this.... I mean I could have guessed it I suppose :)

I had you pinned as a frequent subscriber anyway!! ;)


Component is getting overlapped in mat-list?

Bug, feature request, or proposal:
Content of my component is getting overlapped inside mat-list-item.. But if I will use any string in  it is working fine? Is this behavior expected and we need to fix with CSS.
<mat-drawer-container class="app-sidenav-container" autosize>
  <mat-drawer #drawer class="app-sidenav mat-elevation-z10" mode="side" opened="true">
    <mat-toolbar color="primary">Stack Chat</mat-toolbar>
    <mat-list role="list">
      <mat-list-item role="listitem" class="circleList">
        <app-circle></app-circle>
      </mat-list-item>
      <mat-list-item role="listitem" class="userList">
        <app-user></app-user>
      </mat-list-item>
    </mat-list>
  </mat-drawer>
</mat-drawer-container>

"dependencies": {
    "@angular/animations": "^5.2.5",
    "@angular/cdk": "^5.2.1",
    "@angular/common": "^5.2.0",
    "@angular/compiler": "^5.2.0",
    "@angular/core": "^5.2.0",
    "@angular/forms": "^5.2.0",
    "@angular/http": "^5.2.0",
    "@angular/material": "^5.2.1",
    "@angular/platform-browser": "^5.2.0",
    "@angular/platform-browser-dynamic": "^5.2.0",
    "@angular/router": "^5.2.0",
    "bootstrap": "^4.0.0",
    "classlist.js": "^1.1.20150312",
    "core-js": "^2.4.1",
    "hammerjs": "^2.0.8",
    "rxjs": "^5.5.6",
    "zone.js": "^0.8.19"

What is the expected behavior?
No overlapping.
What is the current behavior?

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.

Why it isn't a bug? The expected behavior is not the current so that's the bug definition


fix: clean path to solve crashes on Mac

When launching sagefile with double slashes, e.g. with
/Users/user/git/repo/subfolder//../.sage/bin/sagefile, Go crashes when
fetching tools. Cleaning the path by calling it without double slashes
does not produce the crash.
I cannot imagine any reason why it is like this, perhaps a bug to be
filed to Go upstream. The crash reports are very long, so not including
in the commit message.

I filed https://github.com/golang/go/issues/54590, let's see if someone can figure out why this happens 😅


The examples should work - should they not? They should at least compile.

Neither does. Download the C# example, open in VS - nothing works. Lots of errors. Try to upgrade NuGet packages and things get worse.
A little better with the Node example: Hoek.inherits is not a function. OK, we can probably track this down easily enough.
Teams is a popular application. The QA for the examples is not up to par.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c4fa27cb-544f-f8a2-97a7-4b31528c1b80
Version Independent ID: fa69cd6f-1ef4-706d-2816-aa709714b0aa
Content: Get started with App Studio and Node.js - Teams
Content Source: msteams-platform/tutorials/get-started-nodejs-app-studio.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

@tabinnorway , Sorry for your inconvenience, Could you please take a look at latest Bot Builder SDK V4 sample code? Let me know if this doesn't help you out.

@tabinnorway Regarding the NodeJS sample, try uninstalling gulp from global scope npm uninstall -g gulp, then re-install all the dependencies from the sample-project npm install and run the app npm start.
I had the same problem and this worked for me. Cheers :)

@kosset, I've tried that and I get a whole slew of errors.  If I delete node_modules and package-lock.json I get farther as everything installs with npm install.  However, when I run npm start I get sh: nodemon: command not found.  So I install nodemon. npm install --save-dev nodemon  Then with npm start I get

Warning: To load an ES modeul, set "type": "module" in the package.json or use the .mjs extension.
app.js:4
import path from 'path';

I am getting following error while running the code.
import path from 'path';
^^^^^^
SyntaxError: Cannot use import statement outside a module
at wrapSafe (internal/modules/cjs/loader.js:1047:16)
at Module._compile (internal/modules/cjs/loader.js:1097:27)
at loader (C:\SourceCode\msteams-app\node_modules\babel-register\lib\node.js:144:5)
at Object.require.extensions. [as .js] (C:\SourceCode\msteams-app\node_modules\babel-register\lib\node.js:154:7)
at Module.load (internal/modules/cjs/loader.js:977:32)
at Function.Module._load (internal/modules/cjs/loader.js:877:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12)
at Object. (C:\SourceCode\msteams-app\node_modules\babel-cli\lib_babel-node.js:154:22)
at Module._compile (internal/modules/cjs/loader.js:1133:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1153:10)
Can anyone please help to resolve.

I was having this same issue. I ended up cloning a forked repo. https://github.com/jrkerns/msteams-samples-hello-world-nodejs
This one works after you install the necessary dependencies (npm install).
You will run into an issue with gulp 3 syntax issues when trying to create the app package but I got this resolved asking around on StackOverflow. Check out this:
https://stackoverflow.com/questions/61642647/i-get-assertionerror-err-assertion-task-function-must-be-specified-when-i-r


[T4A3][F09-B3] Chu Ying Yu

Ready for review.

@azoic0 Some comments added. Please close the PR after reading comments. Good job!


root: 6.32.06 -> 6.32.08, fix on darwin, move to pkgs/by-name

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 355981 run on x86_64-linux 1

13 packages built:

hepmc3
herwig
ns-3
python311Packages.hepmc3
python311Packages.rivet
python312Packages.hepmc3
rivet (python312Packages.rivet)
root
root.debug
sherpa
thepeg
xfitter
yoda-with-root

Result of nixpkgs-review pr 355981 run on x86_64-linux 1

13 packages failed to build:

hepmc3
herwig
ns-3
python311Packages.hepmc3
python311Packages.rivet
python312Packages.hepmc3
rivet (python312Packages.rivet)
root
root.debug
sherpa
thepeg
xfitter
yoda-with-root

Result of nixpkgs-review pr 355981 run on x86_64-darwin 1

3 packages marked as broken and skipped:

apfelgrid
applgrid
root5

3 packages failed to build:

herwig
sherpa
thepeg

9 packages built:

hepmc3
ns-3
python311Packages.hepmc3
python311Packages.rivet
python312Packages.hepmc3
rivet (python312Packages.rivet)
root
xfitter
yoda-with-root

Result of nixpkgs-review pr 355981 run on x86_64-linux 1

3 packages failed to build:

apfelgrid
applgrid
root5

13 packages built:

hepmc3
herwig
ns-3
python311Packages.hepmc3
python311Packages.rivet
python312Packages.hepmc3
rivet (python312Packages.rivet)
root
root.debug
sherpa
thepeg
xfitter
yoda-with-root

Result of nixpkgs-review pr 355981 run on x86_64-linux 1

16 packages built:

apfelgrid
applgrid
hepmc3
herwig
ns-3
python311Packages.hepmc3
python311Packages.rivet
python312Packages.hepmc3
rivet (python312Packages.rivet)
root
root.debug
root5
sherpa
thepeg
xfitter
yoda-with-root

Result of nixpkgs-review pr 355981 run on x86_64-darwin 1

3 packages marked as broken and skipped:

apfelgrid
applgrid
root5

3 packages failed to build:

herwig
sherpa
thepeg

9 packages built:

hepmc3
ns-3
python311Packages.hepmc3
python311Packages.rivet
python312Packages.hepmc3
rivet (python312Packages.rivet)
root
xfitter
yoda-with-root

Result of nixpkgs-review pr 355981 run on x86_64-darwin 1

3 packages marked as broken and skipped:

apfelgrid
applgrid
root5

3 packages failed to build:

herwig
sherpa
thepeg

9 packages built:

hepmc3
ns-3
python311Packages.hepmc3
python311Packages.rivet
python312Packages.hepmc3
rivet (python312Packages.rivet)
root
xfitter
yoda-with-root


⚠ Bofrost.at has degraded performance

In 86f241a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1204 ms

Resolved: Bofrost.at performance has improved in b8d0418.


Harvester.update() breaks existing camera connections

Describe the Issue
The existing connection to my camera gets broken when using harvester.update() to check for newly connected devices.
To Reproduce

My application uses harvester.update() to check every 10 seconds if a new device has been connected.
The existing connection to my camera gets broken when using harvester.update().

Sample Code
h = Harvester()
while True:
    h.update()
    time.sleep(10)

If applicable, please paste the actual output (its whole traceback, etc) here:
 :: harvesters.core :: ERROR :: GenTL exception: Given handle does not support the operation. (Message from the source: Unsupported info parameter) (ID: -1006)
Traceback (most recent call last):
  File "\venv\lib\site-packages\harvesters\core.py", line 2435, in _fetch
    monitor.update_event_data(self.timeout_period_on_update_event_data_call)
  File "\venv\lib\site-packages\genicam\gentl.py", line 1296, in update_event_data
    return _gentl.EventManagerNewBuffer_update_event_data(self, timeout)
_gentl.InvalidHandleException: GenTL exception: Given handle does not support the operation. (Message from the source: Unsupported info parameter)

Expected Behavior
I expect that harvester.update() will only update the device_info_list and not break existing connections to devices like my camera.
As I understood the harvester.update() method description already mentions this might happen, which is why I am not sure if this shouldn't have been a feature request.
Screenshots
None
Configuration

OS: Windows 10
Python: 3.10.8
Harvester: 1.4.2
GenTL Producer: libbgapi 2.13.2
Camera: Baumer VCXG-25M.I.XT &  VCXG.2-51M

Reproducibility
This phenomenon can be stably reproduced.
Actions You Have Taken
I have created my own broadcasting service to be able to check if a new camera has been connected, which is working now but I am not able to connect since the harvester.update() has to be done in the final step.
I tried to create multiple harvester objects but as mentioned here (https://github.com/genicam/harvesters/issues/344) this is not the way to use it. I also tried broadcasting services, which is working now.
I also tried to comment each of the release() in the harvester.update() method
def update(self) -> None:
        """
        ...
        Please note that the update method call will eventually turn the
        existing ImageAcquire objects immediately obsolete even if the object
        is still owned by someone. The owner should drop those obsolete
        objects and create another ImageAcquisition object by calling
        the Harvester.create_image_acquire method.
        """
        global _logger

        #self._release_acquires()
        #self._release_gentl_producers()

        try:

But this is going to result in the error:
_gentl.ResourceInUseException: GenTL exception: Requested resource is already in use. (Message from the source: ) (ID: -1004)```

Additional Context
I really hope to find at least a workaround to be able to continue using harvesters.
Thank you for your help!
Update:
I did try the same with harvesters 1.4.3 and this resulted in a different behavior:
For a basic test I tried it with a single camera. First connected to the camera and then unplugged it. After ia.destroy() in my error handling I tried to do
harvester.update(), which results in the error message below. With a single camera this was working on 1.4.2 for a basic error recovery.
self._harvester.update()   File "\venv\lib\site-packages\harvesters\core.py", line 3447, in update     self._release_acquires()   File "\venv\lib\site-packages\harvesters\core.py", line 3352, in _release_acquires     ia.destroy()   File "\venv\lib\site-packages\harvesters\core.py", line 1877, in destroy     self._release_data_streams()   File "\venv\lib\site-packages\harvesters\core.py", line 2720, in _release_data_streams     self._release_buffers()   File "\venv\lib\site-packages\harvesters\core.py", line 2739, in _release_buffers     _ = data_stream.revoke_buffer(buffer)     return getattr(self._source_object, attribute)(*args)   File "\venv\lib\site-packages\genicam\gentl.py", line 3690, in revoke_buffer   File "\venv\lib\site-packages\genicam\gentl.py", line 3695, in _revoke_buffer     return _gentl.DataStream__revoke_buffer(self, py_obj) _gentl.BusyException: GenTL exception: Operation cannot be performed. Responsible module is busy. (Message from the source: The buffercount must not change while acquisition is active!) (ID: -1022)

I'm glad I was able to find a solution that works for me. However, I still hope to see this feature included in a future main release. The changes can be found here.
https://github.com/MYCL94/harvesters/tree/feature/update-device-list-without-release
def update(self) -> None:
        global _logger

        try:
            self._open_gentl_producers()
            self._open_systems()
            for system_proxy in self._systems:
                system_proxy.update_interface_info_list(self.timeout_for_update)

                for i_info in system_proxy.interface_info_list:
                    try:
                        if i_info.id_ not in self._i_info_id:
                            raw_iface = i_info.create_interface()
                            self._i_info_id.append(i_info.id_)
                            self._raw_ifaces.append(raw_iface)
                            raw_iface.open()
                            _logger.debug('opened: {0}'.format(_family_tree(raw_iface)))
                            iface_ = Interface(module=raw_iface, parent=system_proxy)
                            if iface_ not in self._ifaces:
                                self._ifaces.append(iface_)
                    except GenTL_GenericException as e:
                        _logger.error(e, exc_info=True)
                self._device_info_list = []
                for raw_iface, iface_ in zip(self._raw_ifaces, self._ifaces):
                    raw_iface.update_device_info_list(self.timeout_for_update)
                    for dev_info in raw_iface.device_info_list:
                        self.device_info_list.append(
                                DeviceInfo(module=dev_info, parent=iface_))

        except GenTL_GenericException as e:
            _logger.warning(e, exc_info=True)
            self._has_revised_device_list = False
        else:
            self._has_revised_device_list = True

        _logger.info('updated: {}'.format(self))

I also had to introduce new lists to check for already opened interfaces. This makes it possible to continuously use harvester.update() without losing the (working) ImageAcquirers. If a new device is attached, it is also found and connected by checking the device_info_list before harvester.create(). I wasn't sure if I should have created a new method for that, but for now I changed the update() method since it's fine in my use case. I don't add or remove interfaces, and I'm just using the one cti Producer mentioned above; which is why I don't see why I should release the GenTL Producer at all. This change also worked with harvesters 1.4.3.
Thanks!


Vanilla JS PATCH request

why send all of zepto up to the client when this can be converted to a Vanilla JS PATCH?
https://github.com/winduptoy/ampersand-json-patch/blob/master/index.js#L116

concern for users who do not use zepto but care about overall app weight

good refs http://stackoverflow.com/questions/8567114/how-to-make-an-ajax-call-without-jquery

@gdibble Yeah I was planning to get to it, but I never found the time. If you submit a PR I'll be happy to merge it.

ok, i'll see what i can do ;)


Reverse Linked List Nodes in K-Groups in C++

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Given N, Linked List and K,
Reverse the Node of Linked List in Groups of K and return
example:
N=5
Linked list: 1 2 3 4 5
K=2
Answer 2 1 4 3 5
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
fixes #6427

@ankitaggarwal23 Please review


Inhibition rules evaluation performance on many target alerts

Context
Requesting /alerts from my organizations alertmanager returns a reply in 4-6 seconds.
The alertmanager has consistently

between 10k-13k alerts and
86 inhibition rules.

Given this scale, I was a bit surprised that fetching the alerts takes multiple seconds.
Taking a trace via pprof revealed that at least 4 seconds are spent calculating inhibited alerts.
Furthermore, a few hundred milliseconds are spent serializing the json response, which is expected due to the size of ~20 MiB in our case.
The structure of my organizations inhibition rules can lead to ~10k alerts matching a target matcher and ~1k alerts matching the source matcher.
Currently the benchmarks only consider cases with a single alert satisfying a target matcher.
Calling /alerts results basically in the following algorithm being executed at the moment:

For each T in all alerts (calls into Mutes here):

For each R in all inhibition rules:

Continue if T is not valid target
For each S in source alerts cached by R:

Check for label equality
Prevent two-sided match

Memoize source cache target match evaluations
The Prevent two-sided match step evaluates r.TargetMatchers.Matches(a.Labels), where a is from the cached source alerts.
It's invoked over and over again for each alert that is a valid target (potentially evaluating regular expressions), but it is not dependent on a specific target alert.
Assuming I did not miss a side effect, the result of r.TargetMatchers.Matches(a.Labels) is only dependent on a specific inhibition rule and that rule's source alert cache.
By memoizing that expression, a performance gain can be achieved when many alerts are valid targets.
Constructing indices
Checking for label equality between the set of valid source alerts and valid target alerts runs in quadratic time.
By maintaining an index per label, which maps that label's values to an "index into a slice of all alerts", alerts that have a label with a specific value can found by a map lookup.
For multiple labels that need to be checked for equality, multiple slices of indices can be intersected in linear time.
This would be a larger change though.

I implemented the memoization in #3933.

Hi! 👋 I thought GET /alerts read the data in the marker, rather than re-calculate inhibitions, so unless I've misunderstood the code, I'm surprised that GET /alerts is slow because of inhibitor.Mutes? Could you share a pprof perhaps?

Hi! 👋 I thought GET /alerts reads the data in the marker, rather than re-calculate inhibitions, so unless I've misunderstood the code, I'm surprised that GET /alerts is slow because of inhibitor.Mutes? Could you share a pprof perhaps?

Hey, alertFilter calls setAlertStatus, which is set via Update here. The anonymous function for setAlertStatus calculates inhibitions and silences.

Friendly reminder, that I would still appreciate some feedback. Likely this got lost in between other things.


ISSUE #198: Added WildGuard Logo in the footer

As mentioned in the issue, I have added the WildGuard Logo in the footer and removed Terms and Privacy&Policy which was showing twice before.

Conflicting files
assets/css/style.css
index.html
Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


InvalidPathException with message 'Unable to read the environment file at .env

Dotenv\Exception\InvalidPathException with message 'Unable to read the environment file at .../vendor/nicklasw/pkm-go-api/src/Kernels/../../.env.'

Why does the package use an .env file for the config variables? It makes it impossible to install the package with "composer require nicklasw/pkm-go-api". The only workaround to prevent this error is to modify files in composers vendor dir. Or do I miss something?

see #6

@arianrashidi: You are right, I will reconsider this.

There is also a problem with the facades if you use it as an composer package. You could consider prefixing them with a namespace.

@ArianR Due to the class alias?

The environment file is now optional, and is referenced by file path.

I wonder if it would be easier to just pass an array of options to the constructor instead of a file path?
Then everyone could decide for himself if he wants a dotenv file, real environment variables, store the config in a php array or anything else when bootstrapping the Kernel.

@NicklasWallgren Yes, for example "src/Services/RequestService.php:38".

@Ni42 Good idea, I will consider this for a upcoming release.

I'm closing this issue. I will fix the Facades in upcoming commit.


getUserInfo implements wrong endpoint

I get a slack.api.ApiError: unknown_method exception from SlackApiClient's getUserInfo(). I think the right endpoint is "users.info", not "users.getInfo".
This project is awesome, thanks!

Thanks for reporting this issue, and I'm glad you like the project! Just fixed this in master, I'll be publishing a new version to maven central before long.


How to set translation model

Hi
In google translate API it is possible to specify translation model and set it to NMT (neural mt) or PBT(phrase based MT). Is it possible to set translation model in this API?
Thanks

I'm sorry
No way：(


Assigning to type constructors gives weird behavior

Hi,
When walking through a problem with someone (very inexperienced), I noticed that assigning
to a type constructor (when there is only one constructor of a type) compiles:
import Html exposing (..)

type Msg = A

A = 5

main =
  text "Hello, World!"

When there are multiple type constructors, the compiler will fail complaining about an
incomplete pattern match:
import Html exposing (..)

type Msg = A  | B  | C
C = 6

main =
  text "Hello World!"

fails with
-- PARTIAL PATTERN -------------------------------------------------------------

The pattern used here does not cover all possible values.

5| C = 6
   ^
You need to account for the following values:

    Temp1473684102728286.A
    Temp1473684102728286.B

Switch to a `case` expression to handle all possible patterns.

Using elm-lang.org/try on linux/chrome 50
Assigning to a constuctor that does not exist fails too. The compiler will give
an incorrect hint in this case
import Html exposing (..)

type Msg = A | B | C
D = 6

main =
  text "Hello World!"

gives
-- NAMING ERROR ----------------------------------------------------------------

Cannot find pattern `D`

6| D = 6
   ^
Maybe you want one of the following?

    A
    B
    C

Using elm-lang.org/try on linux/chrome 50
Whilst no-one who understands what type constructors are would attempt such things, a novice might
and would then run into very weird behavior.

Can you move this to https://github.com/elm-lang/error-message-catalog/issues in the future? It looks like someone just reported it actually!

Does it belong there? The later ones are certainly poor errors, but the first one is a typechecker bug, an ill typed program that compiles...

New issue with better title and http://sscce.org/ if that's the case

New issue here: https://github.com/elm-lang/elm-compiler/issues/1487


Sort by popularity please!

Impossible to read all of the titles...

by keyword relevance / by usage? by trending?
hard to define technically what is popular / and by what time frame? last 2 years ? last 20 days?

-github star/forks
-google search result counts
-total paper citation
are these reasonable?


The bookkeeper ledger no honoring the retention period and causing for the more disk usage.

Describe the bug
The bookkeeper ledger no honoring the retention period and causing for the more disk usage.
During my test execution i set defaultRetentionTimeInMinutes is 6 and noticed that bookie ledger is no honoring the retention period and eating up more disk space and causing for failures due to "Not enough non-faulty bookie available". When drilled down to disk and see, most of message are retaining even after retention period is completed in ledger disk. The below are the list of broker paramter settins
broker:
configData:
managedLedgerMinLedgerRolloverTimeMinutes: "1"
managedLedgerCursorRolloverTimeInSeconds: "60"
managedLedgerMaxLedgerRolloverTimeMinutes: "2"
managedLedgerMaxEntriesPerLedger: "50000"
defaultRetentionTimeInMinutes: "6"
defaultRetentionSizeInMB: "1000"
ttlDurationDefaultInSeconds: "3600"
To Reproduce
Steps to reproduce the behavior:

Use 2.5.0 Pulsar
Create 100 topics with three partitions and 100 producers and consumers
By using pulsar perf client send data for an hour continuously ( message size is 50 kb) and observe whether disk is flushing out or not after completion of the retention period
I got the below ERROR message in broker logs
"Not enough non-faulty bookie available"

Expected behavior
As per retentionperiod the data should get flushed out and make disk space free
Screenshots
n/a
Desktop (please complete the following information):

OS: CentOS 7.7

Additional context
Currently we have 100 GB for each bookie
Below is the disk calculation as per my messages/sec.
a=msg/sec -844.023/sec=844.02350 kb =42201.2 msgs/sec in KB
b=aretention period = 42201.2*360(6 minutes)=15192414 msg/sec =14.4 GB (3 bookies) is required for 6 minutes duration.
c= 100 GB each bookie (300 GB for 3 bookies)
so b<c
as per above calculation. i have enough disk space but still facing issues

Currently, the bookkeeper uses a lazy garbage collection mechanism to reclaim disk spaces after ledgers/segments are deleted. So there will be a gap between ledgers are deleted and the disk space is reclaimed. So please use large disk capacity if you are sending fair amount of traffic to the cluster. This allows the bookie garbage collector has enough time to reclaim the disk space.

We are experiencing a similar issue, with huge disk space usage even when we explicitly delete all the topics. Normally, we limit both the backlog quota and the retention period. However, it does not seem to have much impact. Is there any way to trigger garbage collection or any other way to reclaim disk space or set a bound on it? Thanks

@orbang Can you describe more about what you are experiencing?

@prasad-reddyk @orbang As sijie mentioned, how about try to set the gc to be more frequently in bookkeeper.conf?
The default gc time is 1 hour and 1 day:
# Threshold of minor compaction
# For those entry log files whose remaining size percentage reaches below
# this threshold will be compacted in a minor compaction.
# If it is set to less than zero, the minor compaction is disabled.
minorCompactionThreshold=0.2

# Interval to run minor compaction, in seconds
# If it is set to less than zero, the minor compaction is disabled.
minorCompactionInterval=3600

# Threshold of major compaction
# For those entry log files whose remaining size percentage reaches below
# this threshold will be compacted in a major compaction.
# Those entry log files whose remaining size percentage is still
# higher than the threshold will never be compacted.
# If it is set to less than zero, the minor compaction is disabled.
majorCompactionThreshold=0.5

# Interval to run major compaction, in seconds
# If it is set to less than zero, the major compaction is disabled.
majorCompactionInterval=86400

@jiazhai ,
Currently i set one minute of gcWaitTime as recommended bu Sijie. Please Let us know if need to change anthing around these parameter values. Thanks !!
How long the interval to trigger next garbage collection, in milliseconds
Since garbage collection is running in background, too frequent gc
will heart performance. It is better to give a higher number of gc
interval if there is enough disk capacity.
gcWaitTime=60000
If it is set to less than zero, the minor compaction is disabled.
minorCompactionThreshold=0.2
Interval to run minor compaction, in seconds
If it is set to less than zero, the minor compaction is disabled.
Note: should be greater than gcWaitTime.
minorCompactionInterval=3600  //1 Hour

I am affected by this also - we're trying to reclaim disk for two reasons

Security / customer requirements to NOT retain data
Cost

What I have done so far inspired by @addisonj
i) Lowered majorCompactionInterval from 86400 (1 day) to 7200 (2 hours)
ii) Lowered managedLedgerMaxLedgerRolloverTimeMinutes from 240 (4 hours) to 90 (1.5 hours)
Open question on whether I should change majorCompactionThreshold from the (Pulsar) default of 0.5 as I don't fully understand if lower values mean more or less disk space usage.
Thanks in advance


Dataloader not loading data

hi @anhquancao
Can you please help here why Dataloader is not picking up the data
Command
python monoscene/scripts/generate_output.py     +output_path=$MONOSCENE_OUTPUT     dataset=NYU     NYU_root=$NYU_ROOT     NYU_preprocess_root=$NYU_PREPROCESS     n_gpus=1 batch_size=1

Result
NYU ROOT /monoscene/nyu/NYU_dataset/depthbin/
NYU PREPROCESS ROOT /monoscene/nyu/NYU_dataset/depthbin/preprocess
NYU FRUSTUM SIZE 8
NYU BATCH SIZE 1
NYU NUM WORKERS 1
n_relations 4
Using cache found in /root/.cache/torch/hub/rwightman_gen-efficientnet-pytorch_master
Loading base model ()...Done.
Removing last two layers (global_pool & classifier).
Building Encoder-Decoder model..Done.
0it [00:00, ?it/s]
(monoscene) root@d0a

Hi @SohaibAnwaar,
Can you check what is the values of  self.scan_names in this line
https://github.com/astra-vision/MonoScene/blob/master/monoscene/data/NYU/nyu_dataset.py#L46
and if the folder self.root contains any ".bin" files?

sorry, mistake in my root path. Thanks for fask response.
I made a docker file and setup all required installment, Can you merge that docker file in this git. Please it will be help full for people. I will update commands in readme.

@SohaibAnwaar,
Amazing! Thank you a lot! Could you please make a pull request?

sure sure @anhquancao

@anhquancao Now I am trying with just 1 gpu_process, segmentation fault issue occurs again.
    raise RuntimeError('DataLoader worker (pid(s) {}) exited unexpectedly'.format(pids_str)) from e
RuntimeError: DataLoader worker (pid(s) 1464) exited unexpectedly

Can you try to traverse the dataset with a code like this?
 ds = NYUDataset(
        "train",
        root, # change to NYU_root
        preprocess_root, # change to NYU_preprocess_root
    )
    for i in range(len(ds)):
        ds[i]

see my gpu is empty (left bottom window)
My CPU is empty (left top window)
Python space not left error when try to fetch from data_loader (right bottom window)

The problem is out of machine RAM, not the GPU memory.

Ahh, as you can see left bottom terminal is 'htop'
In that you can see that used memory is 14GB total memory is 32GB.
I dont think its ram issue 🙌

I saw the error message "no space left on device". Any thoughts on why this happened? I don't think any data is written in the dataloader.

Can you test the dataset alone, without the dataloader? like this code
ds = NYUDataset(
        "train",
        root, # change to NYU_root
        preprocess_root, # change to NYU_preprocess_root
    )
for i in range(len(ds)):
      ds[i]

Emm, let me debug it. Also let me test dataset without loader ✅🙌

hi @anhquancao I debug the problem. from torch.utils.data.dataloader import DataLoader is creating a problem because of multi-processing
https://github.com/astra-vision/MonoScene/blob/32898e734caa50b9f78b04596a30f4bfa2b28964/monoscene/data/NYU/nyu_dm.py#L73
by removing the num_workers param from data loader the issue is fixed.

The num_workers is required for faster training, I don't think it should be removed

yes for that multi-GPUs are needed. not working on single GPU machine 😅

It is the number of CPU processes to process data. I don't see how it is related to number of GPUs?

I am not sure, But when-ever I try to give num_worker even 1. it fails saying segmentation error.

@anhquancao this is issue in pytorch 1.7.1.
https://github.com/pytorch/pytorch/issues/54752

The code was fine with pytorch 1.7.1, I think you should use the same version

yes, you are right, I use the same commands for installation. but don't know how version miss-match occurs. Thank for helping @anhquancao


message_list: Extract update_message_container_vars function.

The message container vars did not update when a single message
was updated. Extracted function from _render_group function
and use it in _get_single_template too.

Thanks, @vrongmeal! We'll probably just want to squash the last couple commits, since the sum of those commits are still pretty small, and the intermediate commits don't work in all cases until your patch.

@vrongmeal it looks like you did something wrong with your rebase -- you're now re-adding the message_content.handlebars which I had renamed to message_body.handlebars.  I think actually the first ~3 commits were already merged properly with Git automatically handling that rename.
I highly recommend reviewing your changes with gitk or a similar tool to see whether they match what you intended after doing a rebase.


feat(plugin-local-electron): add plugin-local-electron

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] The changes are appropriately documented (if applicable).
[ ] The changes have sufficient test coverage (if applicable).
[x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Used to run a local version of electron instead of the version the electron module downloads

Documented on v6.electronforge.io


Overlapping keyframes arent calculated by property

Fixed in b0bc9b7f6c4e7c642bebb3ccd9c6f52493b42b60. Cheeky of me to add a feature in a commit labelled 'tests', but oh well.


incorrect log directory created

Describe the bug
A directory named '${sys:AUDIT_LOG_ROOT} is created during a run of audit tool.
It sometimes contains directories.
To Reproduce

Use the 21022-05-11 or 2022-05-12 version of audit-tool in an empty directory

/dev/tmp/audit-test$ audit-tool -version
Version 1.0Beta_2022_05_12
/dev/tmp/audit-test$ ls -l
total 0

Launch audit test with any syntax

~/dev/tmp/audit-test$audit-tool -h
usage: audit-tool [options] { - | PathToWork PathToWork ..... }
where:
...

You will see this directory created after the run

~/dev/tmp/audit-test$ ls -l
total 4
drwxr-xr-x 4 jimk jimk 4096 May 12 16:17 '${sys:AUDIT_LOG_ROOT}'

Expected behavior

~/dev/tmp/audit-test$ audit-tool -h
usage: audit-tool [options] { - | PathToWork PathToWork ..... }
where:
...
$ ls -l
total 0

an empty directory

Fixed with 3fd3ae


merge package template from Kronos-Tools/npm-package-template

Updated standard to latest version

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   58.33%   58.33%
=======================================
  Files           1        1
  Lines          12       12
=======================================
  Hits            7        7
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a7a8dd...01cfc4f. Read the comment docs.


Fix compilation on Linux and Mac

Hi, thanks for this library! This fixes compilation on Linux and Mac (#2).

Hi, sorry for the late reply. Your PR has been accepted and merged into the main branch. Thank you for your contribution.

Thanks @ShinobuAmasaki!


Reduce esc calibration pwm timeout

Hobbywing xrotor series needs this in 3 seconds.
Perhaps a user defined timeout from QGC would work better

My feeling is that 3s is fine the ESCs I know of. I'd say go ahead and merge.


WASI docs

Lapce Version
nightly
System information
Manjaro
Describe the bug
I'm go developer who want to create an extensions which calls Tabnine API.
I need some additional information about how to create plugin with WASI

duplicate of #123


historical data restore: only load march 2021 to start with

Changing default index to restore.
Similar PRs will follow to keep the migration going.

/cc @osherdp


Add Evidence: Show Output shortcut command to display extension output

that was added in #50.

New Evidence: Show Output command in Command Palette... and Evidence extension output display in the standard VS Code Output view:


Unused Chunks are included as dependency in entrypoints

Bug report
What is the current behavior?
We are using two entrypoints FilterReact, MenuSideBarReact in our application. In FilterReact application we import redux and react-redux from node_modules. These are used only in FilterReact application.
However when generate the bundles using splitchunks these redux and react-redux modules are added as dependency for both application.
here is the output
Entrypoint MenuSidebarReact = VendorReact.js?e44ca5a005a14db4d1d7 VendorReact.js.map?e44ca5a005a14db4d1d7 GenericReact.js?9b139fdbe962e4ebe576 GenericReact.js.map?9b139fdbe962e4ebe576 VendorRedux.js?9213e1761fe92c5f8f70 VendorRedux.js.map?9213e1761fe92c5f8f70 MenuSidebarReact.js?9bfd70dd5eac39115e81 MenuSidebarReact.js.map?9bfd70dd5eac39115e81
Entrypoint FilterReact = VendorReact.js?e44ca5a005a14db4d1d7 VendorReact.js.map?e44ca5a005a14db4d1d7 VendorRedux.js?9213e1761fe92c5f8f70 VendorRedux.js.map?9213e1761fe92c5f8f70 FilterReact.js?ae6b0ee94612780f4e71 FilterReact.js.map?ae6b0ee94612780f4e71
you can see that VendorRedux is added as dependency in both application. But it is not required for MenuSideBarReact application
If the current behavior is a bug, please provide the steps to reproduce.
here is the sample application
reactbug.zip
please unzip and run the script ScriptDevWebPack to see the above mentioned result
you can see the VendorRedux chunk is a dependency for both applications.
if i remove the VendorRedux module from generated MenuSideBarReact.js bundle
deferredModules.push(["./React/UserControls/MenuSidebar/App.tsx","VendorReact","GenericReact","VendorRedux"]);
the application works without any problem.  so there no need to include VendorRedux bundle in MenuSideBarReact application.
What is the expected behavior?
VendorRedux chunk should only be included as entrypoint for FilterReact application and not for MenuSideBarReact application.

Other relevant information:
webpack version:  4.29.3
Node.js version:  10.15.0
Operating System:  Windows 10
Additional tools:

We have removed redux from our project and started using contexts from react.


document how to release Python packages (including checks, timeline etc.) - aim for January release

Packaging a Python package:   https://py-pkgs.org/03-how-to-package-a-python#how-to-package-a-python
Package Distribution and Installation:  https://py-pkgs.org/04-package-structure
Releasing and Versioning:  https://py-pkgs.org/07-releasing-versioning.html

no checks on the PyPI, looks like


Cant Connect

Hi,
Probably not an issue in the script, but do you have any experience of this?
root@raspberrypi:/home/pi/pycalima# python3 cmdline.py -m 58:2b:db:02:37:64 -p 7926XXXX
Traceback (most recent call last):
  File "cmdline.py", line 134, in <module>
    main()
  File "cmdline.py", line 80, in main
    fan = Calima(mac_address, pincode)
  File "/home/pi/pycalima/pycalima/Calima.py", line 79, in __init__
    self.conn = ble.Peripheral(deviceAddr=addr)
  File "/usr/local/lib/python3.7/dist-packages/bluepy/btle.py", line 391, in __init__
    self._connect(deviceAddr, addrType, iface)
  File "/usr/local/lib/python3.7/dist-packages/bluepy/btle.py", line 439, in _connect
    raise BTLEDisconnectError("Failed to connect to peripheral %s, addr type: %s" % (addr, addrType), rsp)
bluepy.btle.BTLEDisconnectError: Failed to connect to peripheral 58:2b:db:02:37:64, addr type: public
Exception ignored in: <function Calima.__del__ at 0x7650fae0>
Traceback (most recent call last):
  File "/home/pi/pycalima/pycalima/Calima.py", line 83, in __del__
    self.conn.disconnect()
AttributeError: 'Calima' object has no attribute 'conn'

This, sadly, don't say more than that the bluez stack failed to connect with the BLE device. If you retry a few times does it ever work? Does it work with the App in the phone?

I had similar error messages when the device was too faar away from the fan.
Try moving it closer, it worked for me.

I have the same problem on Armbian Bullseye.
The setup worked for some time on Armbian Buster.
But after switching to Bulsseye I cant connect to the fan.
Tried different bluepy versions from pip repo.
The fan is visible via scanning. The distance between the devices is the same as before.
python3 cmdline.py -m 58:2b:db:34:2c:e0 -p 9XXXXXXX

Traceback (most recent call last):
  File "/usr/share/hassio/homeassistant/custom_components/pycalima/pycalima/cmdline.py", line 134, in <module>
    main()
  File "/usr/share/hassio/homeassistant/custom_components/pycalima/pycalima/cmdline.py", line 80, in main
    fan = Calima(mac_address, pincode)
  File "/usr/local/lib/python3.9/dist-packages/Calima-2.0.0-py3.9.egg/pycalima/Calima.py", line 79, in __init__
    self.conn = ble.Peripheral(deviceAddr=addr)
  File "/usr/local/lib/python3.9/dist-packages/bluepy/btle.py", line 353, in __init__
    self._connect(deviceAddr, addrType, iface)
  File "/usr/local/lib/python3.9/dist-packages/bluepy/btle.py", line 401, in _connect
    raise BTLEException(BTLEException.DISCONNECTED,
bluepy.btle.BTLEException: Failed to connect to peripheral 58:2b:db:34:2c:e0, addr type: public
Exception ignored in: <function Calima.__del__ at 0xb66326a0>
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/Calima-2.0.0-py3.9.egg/pycalima/Calima.py", line 83, in __del__
AttributeError: 'Calima' object has no attribute 'conn'

I can confirm this as well. Tried on both raspberry os on a pi zero and ubuntu server on a rpi 4.

I have the same exact issue as described, running on a pi zero with Raspbian Bullseye.
Moreover, the thoughts on closing the distance and making several attempts have no impact.
The cmdline.py -l command works fine and lists my one device, so logically it should be in range to connect. Connecting via the Android app also works fine.

I have the same exact issue as described, running on a pi zero with Raspbian Bullseye. Moreover, the thoughts on closing the distance and making several attempts have no impact. (My Pi zero is within a few feet and has been moved in different directions in the same range. I have also made 20+ attempts to connect, without success.)
The cmdline.py -l command works fine and lists my one device, so logically it should be in range to connect. Connecting via the Android app also works fine.

I finally managed to resolve my connect issue, though I'm not sure what was the key step:

I performed the extra installation step listed for the Bluepy repo https://github.com/IanHarvey/bluepy (sudo apt-get install python-pip libglib2.0-dev)
A sequence of apt-get update etc
A reboot


S3  I/O twice as costly for smaller objects.

When using the TransferManager::DownloadFile,  you issue a HEAD to get the size of the object to decide if, yes or no, you should use multipart download. This is has the effect that smaller blobs are twice as costly to download as much larger blobs, on average.
What platform/OS are you using?
All.
Which version of the SDK?
e8a7e7263e900983921e95363026efaa494622ab

Hi @aghiles ,
So, transfer manager is kind of a wrapper for S3 operations meant to make things easier for you when handling big data transfers, but if you know you're doing a lot of smaller sized object operations, it's probably better to just use the S3 getObject.

OK. But please note that the TransferManager is probably what most of your customers will use. And they will see you service as more expensive than it should be (compared to your competition maybe). I highly recommend to at Document this behaviour, to the very least.
I understand it's a "wrapper". But if you told me that the wrapper will cost twice as much ... I would say the wrapper has a problem! :)

@aghiles,
I see your point, and I agree that we could/should mention the downsides of transfer manager against simple s3 service operations.
But also keep in mind, this is not what transfer manager is there for, it is meant to simplify larger data transfer, not to optimize smaller ones.
As you mention, there is a reason for getting the headers and the increased operation cost, but if you don't need that (you know what kind of objects you're getting for example), you can not-have it and use the s3 service operations directly instead of using transfer manager.
So I'd argue you're using the wrong tool for the scenario you're describing.
Let me know what you think though, or if you have a change in mind to approach this issue, we are definitely open for suggestions.


Version 22 on Powershell Gallery but no details here

https://www.powershellgallery.com/packages/SqlServer/22.0.59 has a changelog that links here but there's no recent commits. Can anyone provide more detail? We had some issues using it and wanted to check we were holding it right.

Hi @cailyoung, that's expected. As per roadmap, for v22 the plan was to just open this repo for issues/wiki/discussions, but no source code. v23 is when I plan to have the source code also added here.
I'm just not quite ready to go OSS due to the dependencies that various parts of the module have. Essentially, I need to work with a bunch of (now internal) contributors and see if/when they are willing to release the sources here + make the (internal) nuget package dependencies available on nuget.org.
It is possible we may have to settle for a compromise, where the final module would be: (1) mostly here with source (2) most dependent packages available on nuget.org (3) a handful of cmdlet still "proprietary", at least until the work is done to make those public as well. That means that, for a few areas of the module, external users would not be able to contribute. It does not seem like a terrible model, IMHO...
If you ran into issue, please reach out to me here by logging issues (or maybe start a discussion). I can look into it and see what may be up.

Is there at last a more detailed changelog and/or examples of how to handle the breaking changes?

Since they don't appear in any major search engine's results can I suggest that the PSGallery page and this repo's README.md both mention that the release notes can be found in the wiki?


allow mixer configs through create/replace/delete commands

What this PR does / why we need it:
With this PR, mixer configs can be pushed through istioctl create -f, or replace or delete subcommand. We want this for filling namespace field if missing, and also useful for invoking validation as long as the admission webhook is alpha status (validation is not yet ready, it's a TODO right now).
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
Special notes for your reviewer:
Release note:

none

@mandarjog , this is what we've talked yesterday, right?

@jmuk: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
d83191e01411f6b11e045196ad3b9832b89539fb
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jmuk: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
e971c254b7db7327215d35f00ecf2deee55a5111
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Kube config can be generated. The consul setup uses kubectl only to
generate kube config which I am getting rid of very soon by adding the
necessary code into istioctl.
Use of kube API server is an implementation detail and spilling
implementation details into ux is bad design imho. If we claim that istio
by design requires a working kubernetes installation that is the users
responsibility to setup, then we might as well dump istioctl and go all in
on kubectl. That would have a different set of repercussions, optics wise.
On Sat, Sep 16, 2017 at 12:28 AM Laurent Demailly<EMAIL_ADDRESS>wrote:

@ldemailly commented on this pull request.
In cmd/istioctl/main.go
https://github.com/istio/pilot/pull/1285#discussion_r139277954:

deleteCmd.PersistentFlags().AddFlag(postCmd.PersistentFlags().Lookup("file"))

deleteCmd.PersistentFlags().AddFlag(postCmd.PersistentFlags().Lookup("kubectl"))

in 0.2 (though I am curious how does the consul setup configures/accesses
the api server)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/pilot/pull/1285#discussion_r139277954, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH0qd50kUhURYr3ZeWE7MlnYw70xsUL9ks5si06AgaJpZM4PZjh7
.

--
~shriram

At this point istioctl gets some niceties like implicit apigroup, setting namespace beyond what plain  kubectl gives. Beyond that we do not need istioctl.
If kubeconfig generation can also be done without kubectl, then I can change my position. Istioctl just submits crds to API server. We will not emphasize kubectl at all.
What this means is that we have to support additional features like lookup based on labels.
And istioctl should get out of the pilot repo asap and stop having compile time Deps on it.
@jmuk we should drop binary dep on kubectl and use the k8s client API like the rest of istioctl

@jmuk: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
6de4f617534c78efe0bc92c8f90ba2fc35604db1
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jmuk: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
63829f91a21c27fc6435ab8d8f3d7525dad1ea6e
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

It would beneficial to align pre-processing between mixer and pilot configs, but that can be done in a follow-up.
@rshriram the new PR removes binary dependencies and uses client-go to process mixer configs. Does that address your comment?

@jmuk: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
b3ecd2b1c5c63b6e947a634f506f55f60e9277c7
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sorry just seeing this. Yes. Thanks a lot for removing the binary dependency. @GregHanson is taking a crack at kube config generation.

Can someone merge this?  I don't have the write access to pilot.


Context Refactor

This patch is designed to simplify the interaction with the Context object as well as to ensure that the logs contain the correct contextual identification information. An itemized list of changes include:

A refactored reference implementation of the Context interface with few helper functions in order to make things more straight-forward

The reference implementation of the Store interface now implements fmt.Stringer in order to print itself as a string using the underlying map

The executor now emits the instance ID and local devices as text instead of JSON

$ lsx-darwin mock instanceid
mock=12345,false,eyJtYXgiOjEwLCJtaW4iOjAsInJhZCI6ImNvb2wiLCJ0b3RhbGx5IjoidHVidWxhciJ9

$ lsx-darwin mock localdevices quick
mock=/dev/xvda:/var/log,/dev/xvdb:/home,/dev/xvdc:/net/share,/dev/xvdd:/var/lib/backup

The headers sent to the server, including the instance ID(s) and local devices, are calculated and sent for each individual request and not cached up front. This requires each request to indicate whether the headers should be a part of the request. This is achieved by adding either one or more instance IDs and local device maps to the context prior to calling the remote function.

[Current coverage][cc-pull] is 41.89%

Merging [#113][cc-pull] into [v0.1.0-rc2][cc-base-branch] will decrease coverage by -4.01%

2 files in api/utils were modified. more

Partials +14
Hits -14

2 files (not in diff) in api/utils were modified. more

Partials +20
Hits -20

2 files (not in diff) in api/types were created. more
File .../mock/mock_driver.go was modified. more

Misses 0
Partials +6
Hits -6

File ...lient/vbox_client.go (not in diff) was modified. more

Misses 0
Partials +11
Hits -11

@@           v0.1.0-rc2       #113   diff @@
============================================
  Files              24         33     +9
  Lines            1791       1979   +188
  Methods             0          0
  Messages            0          0
  Branches            0          0
============================================
+ Hits              822        829     +7
- Misses            969       1081   +112
- Partials            0         69    +69

Powered by Codecov. Last updated by [ee03576...3c341cb][cc-compare]
[cc-base-branch]: https://codecov.io/gh/emccode/libstorage/branch/v0.1.0-rc2?src=pr
[cc-compare]: https://codecov.io/gh/emccode/libstorage/compare/ee035762fed4e487926d3a42e9637e0c72a9d04b...3c341cb0d4efbc6d33cc18efc2edbb100ff674d8
[cc-pull]: https://codecov.io/gh/emccode/libstorage/pull/113?src=pr


feat: default value example working

Working example for the default-value pull request: https://github.com/socotecio/django-socio-grpc/pull/255
( Issue: Fix/default value #255 )

Merci @AMontagu,
this is good news ;) - I already used a pre-release version (0.21.5).
There is one issue, left, which I would like to discuss with you:
When one uses an abstract model, then the the child classes do not
Example: In
https://gitlab.com/LARAsuite/lara-django-base/-/blob/master/lara_django_base/models.py?ref_type=heads
I defined the ExtraDataAbstr model with two optional fields, data_type and media_type (which are both optional == blank=True and null=True).
When I subclass ExtraDataAbstr, the ForeignKey fields  are generated as non-optional in the .proto file. This is not the case with optional ForeignKeys of non-abstract models.
Do you have an idea, why ? I guess it has something to do with the depth of recursion to explore the model structure in the .proto generator, or that it currently does not fully support abstract models.


Add convex point set

@ajpmaclean : Thank you for your inputs. i'll get back with all the changes suggested.

@ajpmaclean: The Arrow1 example works fine. i'll rework for all the examples.

@chakravarthi589 Great, much appreciated.

@ajpmaclean : Please review the changes as suggested.

Looks good, thankyou.


prometheus-config-reloader - can't update  / apply rules (main.go:214 | 500)

What did you do?
run Prometheus
What did you expect to see?
prometheus-config-reloader working
What did you see instead? Under which circumstances?
Config & Rules not applied.
Environment
branched from ./contrib/kube-prometheus

Kubernetes version information:
v1.7.5

Kubernetes cluster kind:
kops, AWS

Manifests:

apiVersion: monitoring.coreos.com/v1
kind: Prometheus
metadata:
  name: k8s
  labels:
    prometheus: k8s
spec:
  replicas: 2
  version: v1.7.1
  externalUrl: https://monitoring.mydomain.net/prometheus  # needs to be absolute with v1.7.1
  serviceAccountName: prometheus-k8s
  serviceMonitorSelector:
    matchExpressions:
    - {key: k8s-app, operator: Exists}
  ruleSelector:
    matchLabels:
      role: prometheus-rulefiles
      prometheus: k8s
  resources:
    requests:
      # 2Gi is default, but won't schedule if you don't have a node with >2Gi
      # memory. Modify based on your target and time-series count for
      # production use. This value is mainly meant for demonstration/testing
      # purposes.
      memory: 500Mi
      cpu: 100m
    limits:
      memory: 500Mi
      # cpu: 500m
  alerting:
    alertmanagers:
    - namespace: monitoring
      name: alertmanager-main
      port: web

Prometheus Operator Logs:

ts=2017-09-01T12:33:01Z caller=main.go:214 component=volume-watcher msg="Reloading Prometheus temporarily failed." err="Received response code %!s(int=500), expected 200" next-retry=1m18.352306053s
...

Hi, seems to have been an issue with Decoding / Parsing the rules configmap - by slowly adding rulefiles within one by one I've been able to get it all applied - strange enough in the end I didn't really need to change anything - edited the configmap manifest manually in IntelliJ though - which changed some whitespaces, ..? unsure if the generate script file has any issues (run on MacOS)
Overall - nothing wrong with the prometheus-config-reloader - while more detailed error log may've been helpful.

As the prometheus-config-reloader doesn't and shouldn't know anything about the syntax of rule files, what do you think we can maybe improve around the error message displayed? Always happy to improve.
If the script doesn't work on OS X (although initially developed on OS X) then this is certainly something we need to fix. In other places, however, where we had difficulties around inconsistencies between Linux/unix and OS X when generating things we've automated this environment with containers, even if not yet necessary here I'd be happy about PRs in this regard as I'm sure it will be a problem at one point and it would be nice to just generate consistently right now. If you'd like to contribute this, I'd be more than happy :slightly_smiling_face: .
I believe Prometheus itself should have logged, that the rules did not have the correct syntax, and there is an alert for when Prometheus could not reload properly (which is typically due to invalid config/rules).

Hi @brancz - we didn't get an alert - for no alerts had been configured .. not rules at all had been accepted / applied since we upgraded to 1.7.x and re-applied kube-prometheus... :-)
Prometheus didn't show any logs - there's only been the log I provided above - hinting at a 500 error code.. so I ended up reading the source code which lead me to the issue with parsing the rule -> configmap and allowed me to slowly get more and more rules applied.

Hi @brancz - we didn't get an alert - for no alerts had been configured .. not rules at all had been accepted / applied since we upgraded to 1.7.x and re-applied kube-prometheus... :-)

In that case I'd suggest to implement a dead mans switch :wink: .
Generally maybe we can just add a hint to the log message, that whenever the status code returned is 500, then it is likely be because of an invalid rule files. I think this would be a useful addition. Would you like to open a PR to add this @hartmut-pq?

Why not verify the rules with promtool before calling reload. At least that way you can say which rule is failing?

@brancz I am also facing this. I would like to contribute to this by using promtool or something to verify and make it clear what exactly is breaking reload.

Even things that fail promtool can fail at runtime, but the nice thing about failing to reload is that prometheus has a metric for that so when that happens we can actually alert on it.

But why did it fail will that alert tell. Should i make a PR with promtool?

Sorry I'm not sure I understand.

@alok87 In regards to validating rule files before triggering a reload on Prometheus. I am working on https://github.com/coreos/prometheus-operator/pull/1333 which introduces rule file crds with creation time validation via OpenAPI specs.

Generally maybe we can just add a hint to the log message, that whenever the status code returned is 500, then it is likely be because of an invalid rule files. I think this would be a useful addition. Would you like to open a PR to add this @hartmut-pq?

But I think the error message improvement is still greatly appreciated.

This should now be possible to be validated at create/update time through the validating webhooks. Should this still be possible when using the validating webhook, then please open a new issue! :)


Handle the case of a Multi-Release Jar not actually containing Multi-Release Classes

Seen a couple of people encounter this in mod dev (when adding dependencies):
SJH considers a Jar to be Multi-Release based on the Manifest
https://github.com/McModLauncher/securejarhandler/blob/96a7b6a8fe1f1117e01dfd94c640757154372a68/src/main/java/cpw/mods/jarhandling/impl/Jar.java#L124
If it is then it resolves a path to /META-INF/versions
https://github.com/McModLauncher/securejarhandler/blob/96a7b6a8fe1f1117e01dfd94c640757154372a68/src/main/java/cpw/mods/jarhandling/impl/Jar.java#L126
And tries to walk it
https://github.com/McModLauncher/securejarhandler/blob/96a7b6a8fe1f1117e01dfd94c640757154372a68/src/main/java/cpw/mods/jarhandling/impl/Jar.java#L127
This works for most Jars, however it does not consider the case where a Jar is erroneously marked as Multi-Release, with /META-INF/versions not existing.
If this is the case, Files.walk will throw a UnionFileSystem$NoSuchFileException which is then wrapped and rethrown as a UncheckedIOException
https://github.com/McModLauncher/securejarhandler/blob/96a7b6a8fe1f1117e01dfd94c640757154372a68/src/main/java/cpw/mods/jarhandling/impl/Jar.java#L138
Attached Example Stacktrace, https://gist.github.com/AterAnimAvis/35ded98d52a78c2f257d59173c86366c

Current implementation of a fix is from a bit of spitballing in Discord

Why not use Files.isDirectory() instead of relying on an exception being thrown?

That's definitely an option (and probably the superior one), A few of us went through several options over on Discord fairly quickly, but I don't think that was raised.
It would require to change the code flow slightly around the setting of the final this.nameOverrides which I was personally hoping to avoid, but may be worth it.

This needs to be updated after the recent refactor of this code to JarContentsImpl.


Components modify.

Summary of the changes (Less than 80 chars)
1, EditorForm add Category support (ShowCategory = true, and Add CategoryAttribute on model)
2, Use NullSwitch as default component for type  bool?
3, Add double click support for DateTimePicker.
4, Add component TimespanPicker for type Timespan
Addresses #bugnumber (in this specific format)

@gruan01 thanks for your contribution. I think it would be better to submit a PR for each function/feature