Inconsistent behavior for related entities in AddOrUpdate depending on whether root entity is new or existing

Working with a common many-to-many scenario, code first, EF 6.02.
Product >-< Category

I have a context with MigrateDatabaseToLatestVersion initializer. In the configurations's Seed method I add a few products and categories and establish the many to many by adding products to Category.Products.
The essential code (where db is a DbContext):
db.Products.AddOrUpdate(x => x.Name, p1, p2, p3, p4, p5, p6); // p1 etc. are products
var shoes = db.Categories.Create();
// set properties

shoes.Products.Add(p1);
shoes.Products.Add(p4);
shoes.Products.Add(p6);

// More categories

db.Categories.AddOrUpdate(x => x.CategoryName, sports, accessories, shoes);

When the database is created everything is fine.
With an existing database I try to add a new product in an existing category. This code runs after the code above, before the SaveChanges call.
var p7 = db.Products.Create();
db.Products.AddOrUpdate(x => x.Name, p7);
shoes.Products.Add(p7)

The result is that the new product is saved, but not the many to many association. This is because at this point, shoes is in a Detached state, so the change tracker doesn't notice the addition.
Now if instead of shoes.Products.Add I do
p7.Categories.Add(shoes);

the association is saved, but all existing products in shoes are duplicated. I understand that this is because shoes, and all its products, are marked as Added.
If I do
db.Entry(shoes).State = EntityState.Unchanged;

I get a duplicate key exception, which I don't understand, because shoes is Detached.
The only way I'm aware of to get this working is
shoes = db.Categories.Single(c => c.CategoryName == shoes.CategoryName);
shoes.Products.Add(p7);

So, finally, my question. You guys probably have good reasons not to attach existing entities in an AddOrUpdate call. However, the above scenario would become much more transparent and intuitive if it did attach existing entities.
It's probably a big issue to change this behavior, but could it be an optional feature of AddOrUpdate, as a third parameter attachExisting?

Ported from CodePlex https://entityframework.codeplex.com/workitem/2128

comments
RoMiller wrote Mar 7, 2014 at 4:09 PM [x]
Hey PlexGear,
Any chance you could provide a complete code listing that demonstrates the issue (or even better attach a project). That would be easier for us to understand your situation than trying to piece together the information from the issue.
Many Thanks,
Rowan
PlexGear wrote Mar 9, 2014 at 9:12 AM [x]
Hi Rowan,
Attached a project containing the issue. Thanks for looking into it!
Gert Arnold
ajcvickers wrote Mar 19, 2014 at 1:22 PM [x]
Note for triage: This appears to be due to the way AddOrUpdate is implemented. A query for an entity that matches is performed which, if one exists, will return a new entity instance. Property values are applied to this new instance and it is this instance that will ultimately be saved. The instance passed into the AddOrUpdate method is essentially discarded. However, the application code is still using this discarded instance, which leads to the kind of unexpected behavior seen in this bug.
The workaround is to somehow obtain the queried instance and use it instead for all operations following the AddOrUpdate call. One way to do this is to query for it from the local cache:
shoes = db.Categories.Local.Single(c => c.CategoryName == shoes.CategoryName);
A fix for this would be to:
◾Query using NoTracking to obtain an existing instance
◾Save the property values from the supplied instance
◾Apply the property values from the existing instance to the supplied instance
◾Attach the supplied instance
◾Apply the saved property values back to the supplied instance so that changes are detected and registered
Note that this approach will still have issues with independent associations because the information about these will not be obtained or applied from the entity obtained by the NoTracking query
PlexGear wrote Mar 20, 2014 at 2:00 AM [x]
Thanks for the feedback, Arthur. I never suspected this would be a bug. EF is a great product (still is :) ) and I always expect the things I find to be by design. The work-around should be OK, but then, so far I never used the Seed method in real production code. It's an issue I found out at StackOverflow.
RoMiller wrote Mar 24, 2014 at 8:48 AM [x]
EF Team Triage: It would be good to make the behavior consistent. Marking as UpForGrabs and placing in Future release.
divega wrote Aug 31, 2015 at 11:10 AM [x]
New reports of this issue at:
◾https://github.com/aspnet/EntityFramework/issues/2960
◾http://stackoverflow.com/questions/20300035/
The behavior is unexpected and affects very simple scenarios. Clearing up release field to bring it back to triage so that we can consider our options.
PlexGear wrote Aug 31, 2015 at 12:31 PM [x]
Probably the easiest way to offer a solution (of sorts) is returning the tracked objects from AddOrUpdate, i.e. either the entities fetched by set.SingleOrDefault or the original entities, now in an Added state. This could be documented in the public method's XML doc.
The inner method would look like
private static IEnumerable AddOrUpdate(
this DbSet set, IEnumerable identifyingProperties,
InternalSet internalSet, params TEntity[] entities)
where TEntity : class
{
DebugCheck.NotNull(set);
DebugCheck.NotNull(identifyingProperties);
DebugCheck.NotNull(entities);
var keyProperties = GetKeyProperties(typeof(TEntity), internalSet);
var parameter = Expression.Parameter(typeof(TEntity));

foreach (var entity in entities)
{
    var matchExpression
        = identifyingProperties.Select(
            pi => Expression.Equal(
                Expression.Property(parameter, pi.Single()),
                Expression.Constant(pi.Last().GetValue(entity, null))))
                               .Aggregate<BinaryExpression, Expression>(
                                   null,
                                   (current, predicate)
                                   => (current == null)
                                          ? predicate
                                          : Expression.AndAlso(current, predicate));

    var existing
        = set.SingleOrDefault(Expression.Lambda<Func<TEntity, bool>>(matchExpression, new[] { parameter }));

    if (existing != null)
    {
        foreach (var keyProperty in keyProperties)
        {
            keyProperty.Single().GetPropertyInfoForSet().SetValue(entity, keyProperty.Single().GetValue(existing, null), null);
        }

        internalSet.InternalContext.Owner.Entry(existing).CurrentValues.SetValues(entity);
        yield return existing;
    }

    else
    {
        internalSet.Add(entity);
        yield return entity;
    }
}

}
RoMiller wrote Sep 1, 2015 at 11:25 AM [x]
Moving to 6.2.0 for us to look at

ManyToMany.CodeFirst.zip

EF Team Triage: This issue is not something that our team is planning to address in the EF6.x code base.  This does not mean that we would not consider a community contribution to address this issue.
Moving forwards, our team will be fixing bugs, implementing small improvements, and accepting community contributions to the EF6.x code base. Larger feature work and innovation will happen in the EF Core code base (https://github.com/aspnet/EntityFramework).
Closing an issue in the EF6.x project does not exclude us addressing it in EF Core. In fact, a number of popular feature requests for EF have already been implemented in EF Core (alternate keys, batching in SaveChanges, etc.).
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


react-dom version conflict with RN 0.45.1

The CLI's hardcoded version of react-dom is incompatible with the version of React installed by RN 0.45.1.
Reproduction
# install latest RN
npm install -g react-native-cli

# create RN app
react-native init MyApp

# add storybook
cd MyApp
getstorybook

# try running storybook
npm run storybook

You will get an error due to incompability between<EMAIL_ADDRESS>and<EMAIL_ADDRESS>ERROR in ./~/react-dom/lib/ReactMount.js
Module not found: Error: Can't resolve 'react/lib/React' in '/private/tmp/TesterMeTester/node_modules/react-dom/lib'
 @ ./~/react-dom/lib/ReactMount.js 17:12-38
 @ ./~/react-dom/lib/ReactDOM.js
 @ ./~/react-dom/index.js
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS> @ multi ./storybook/addons.js<EMAIL_ADDRESS>
...etc..

Update the reference of react-dom in package.json and it should run again (modulo https://github.com/storybooks/storybook/pull/1280)

@tmeasday I have confirmed the problem and the fix. 👍

OK, I guess we should figure out the version of react-dom based on the react version in package.json?

Is it fixed? I still get the error when running 3.1.4.

Hi @Fanghao, no, but it is easily fixed on a case-by-case basis. Just run npm upgrade react-dom in your app.

Fixed in 3.1.6!


improve docs for writing attribute procedural macros that parse ItemFn

The signature of these procedural macros is fn cool_fn_macro(attr: TokenStream, item: TokenStream) -> TokenStream and they usually start with let mut function = parse_macro_input!(item as ItemFn);. The attr argument that the macro receives includes only the inner part of the attribute:
#[cool_fn_macro(category = "suite", name = "task_long")]
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                            attr: TokenStream

The way to parse this attr is with parse_macro_input!(attr as Vec<NestedMeta>) or equivalently parse_macro_input!(attr as AttributeArgs). But this was hard to discover on my part.
I suggest including this last bit of information in the AttributeArgs, Meta, and any related pages so that future authors will have an easier time than I did. In particular, it would be nice to find the correct type in the doc index by searching for similar syntax, similarly to how the short docs for the other types is written out.

Seems like this is not valid for v2.


Add renovate config for SAO chart now that the app has versions

closed by https://github.com/graphops/launchpad-charts/commit/a8e94565a8e75f0313f3d7ed44a16a861dd57608


When used in conjunction with nix-direnv, build dependencies are not protected from garbage collection.

Normally, when I use mkShell, nix-direnv will symlink the resulting derivation into gcroots, preventing it from being garbage collected, but this functionality seems to be absent when using devshell.

I had a quick look at the implementation but it's hard to know what didn't work. The pinning logic over here should work all of the same:  https://github.com/nix-community/nix-direnv/blob/52996098653a97b2ed2dbcccb191e9ed38505a47/direnvrc#L199


ci: support automatically creating github release

[x] PR title and description conform to Pull Request guidelines.

Description of changes:

support automatically creating github release

How did you test these changes?
tested by GitHub action
Documentation update required?

[ ] No
[ ] Yes (Please include a PR link for the documentation update)

General Checklist

[ ] Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Patch coverage has no change and project coverage change: -0.07% :warning:

Comparison is base (2b29c60) 86.61% compared to head (a5fc631) 86.54%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #41      +/-   ##
============================================
- Coverage     86.61%   86.54%   -0.07%
+ Complexity      396      395       -1
============================================
  Files            39       39
  Lines          1434     1434
  Branches        125      125
============================================
- Hits           1242     1241       -1
- Misses          118      119       +1
  Partials         74       74

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update reflection doc

The API mentioned previously was unnecessary and deprecated.

Come check out my yt.
Link: https://www.youtube.com/channel/UCd7FQCQXAfUqgqjbAkO9Oug


Fixed spelling

What this PR does / why we need it:
Update ensuring every node within the MNG will have the asociated labels and taints configured automatically.  to ensuring every node within the MNG will have the associated labels and taints configured automatically.
Quality checks

[x] My content adheres to the style guidelines
[ ] I ran make test or make e2e-test and it was successful

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks @chiukapoor !


failed to find plugin "loopback"

Running into the following error on ARM when attempting to create an app:
sctl --addr <IP_ADDRESS>:9000 apps create -f example.conf
FATA[0000] rpc error: code = Unknown desc = failed to find plugin "loopback" in path [/usr/local/bin /usr/local/bin/cni]

Here's my stellar.conf
{
    "ConnectionType": "local",
    "ClusterAddress": "<IP_ADDRESS>:7946",
    "AdvertiseAddress": "<IP_ADDRESS>:7946",
    "Debug": false,
    "NodeID": "rpi-cluster-03",
    "GRPCAddress": "<IP_ADDRESS>:9000",
    "TLSServerCertificate": "",
    "TLSServerKey": "",
    "TLSClientCertificate": "",
    "TLSClientKey": "",
    "TLSInsecureSkipVerify": false,
    "ContainerdAddr": "/run/containerd/containerd.sock",
    "Namespace": "default",
    "DataDir": "/var/lib/stellar",
    "StateDir": "/run/stellar",
    "Bridge": "stellar0",
    "UpstreamDNSAddr": "<IP_ADDRESS>:53",
    "ProxyHTTPPort": 80,
    "ProxyHTTPSPort": 443,
    "ProxyTLSEmail": "",
    "GatewayAddress": "<IP_ADDRESS>:9001",
    "EventsAddress": "<IP_ADDRESS>:4222",
    "EventsClusterAddress": "<IP_ADDRESS>:5222",
    "EventsHTTPAddress": "<IP_ADDRESS>:4322",
    "CNIBinPaths": [
        "/usr/local/bin",
        "/usr/local/bin/cni"
    ],
    "Peers": [],
    "Subnet": "<IP_ADDRESS>/12",
	"ProxyHealthcheckInterval": "5s"
}

The example config's CNIBinPaths appeared to specify containerd and cni binaries. I grabbed the latest release of cni for ARM and your ARM build of containerd. Here's my /usr/local/bin:
|-- cni
|   |-- cnitool
|   `-- noop
|-- containerd
|-- containerd-shim
|-- containerd-shim-runc-v1
|-- containerd-shim-runc-v2
|-- ctr
|-- sctl
|-- stellar
`-- stellar-cni-ipam

Am I missing a cni plugin for this to work? Thanks for all of your help so far!

You've to download the plugins binaries from this repository: https://github.com/containernetworking/plugins/releases and then place them into the /usr/local/bin/cni directory.

Hmm that should have been included in the package.  I'll check the build.

@ehazlett I experienced the same thing, but it was resolved with @unixfox 's comment.

@unixfox: The folder should be /usr/local/lib/cni :)


jsdoc error function as parameter for callback

I have object with function like this
db.query({ /* queryParameter */ },function(err,data) {  });

So I write jsdoc for pass this object in my function. And it got error

Also jsdoc is not support both @typedef and @callback so I got stuck here

PR pending

Fixed in TypeScript@next. Thanks!

@RyanCavanaugh I was install TypeScript@next and got 1.9.0-dev.20160308
Still not fixed

Can you post the exact code to repro? Thanks!

@RyanCavanaugh
/** @param {function({string,string}):void} onFinish
 *	@param {function({string}):void} onError */
function GetData(onFinish,onError) {

}

Actually it is #7254 that you was closed because you think it duplicate with this. It is difference

Also this is nearly similar. 2 functions in same class with multiple function with parameter also make the same problem
var asyncLib	= {
/**
* @template T
* @param {T[]} array
* @param {function(T,number,function():void):void} action
* @param {function():void} onFinish
/
ForEach: function(array, action, onFinish) {
/* @type number */
var i = arguments[3];
if (!(i > 0))
i = 0;
	if (i >= array.length)
		return onFinish();

	action(array[i], i, function () {
		setImmediate(asyncLib.ForEach, array, action, onFinish, i + 1);
	});
},

/**
 * @template T,U
 * @param {T[]} array
 * @param {function(T,number,function():U):U} func
 * @param {function(U):void} onFinish
 */
Map: function (array, func, onFinish) {
	/** @type {[]} */
	var result = arguments[3];
	if (!result && !(result.length > 0))
		result = [];

	if (result.length >= array.length)
		return onFinish(result);

	func(array[result.length], result.length, function (res) {
		result.push(res);
		setImmediate(asyncLib.Map, array, func, onFinish, result);
	});
}

};

Thanks!

@Thaina what's the intended meaning of {function({string,string}):void} ? To me this looks like a function taking one argument whose type is an object with two properties which are both named string, which should be an error

@RyanCavanaugh I was actually use
/** @param {function(string,string):void} onFinish
 *  @param {function(string):void} onError */
function GetData(onFinish,onError) {
}

That thing you see is I try to hack by random syntax to see if it fix. And it not related, it was still cause the same error

OK, makes sense. Looks like the real problem is that the fix for this went into release-1.8 branch and not master, I'll port it over.


Run two files(mp3) one after another without pause

I use your plugin in my app. It's a great job. But I have a question. I need to run two files one after the other, without pause. It must
play cyclically - no pause. is it possible?
Now i play the first file, when the event fires(onPlayerCompletion) I fire the second one - but i have a little pause. I will be grateful for any advice.

@FetFrumos I believe its default with every music player, It takes time to load the next song into memory and all of that. By little pause how long is the wait time probably "seconds". Also it depends if you are loading from local or a remote source and internet connectivity comes into play. So IMO, I think you are doing just well maybe try to do things like load lighter files, and load locally maybe that will suit your use case.


Refactor Kubeflow Orchestrator - Disentangle K3d

Describe changes
I think the kubernetes_context should return the active stack if one is set in the system Kubernetes configuration, only if it's not set to return to the k3d k8s cluster.
Pre-requisites
Please ensure you have done the following:

[X] I have read the CONTRIBUTING.md document.
[X] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

Also, one of the kfp unit tests it failing

I'm guessing this also breaks all existing stacks with local kubeflow orchestrators because of the new flavor name?
In which case this needs also some comments on how to migrate these


SAK-30095 Course Offering provider doesn't work properly

I think this is wrong. What you exposed in the jira is the right behaviour of Course Offering. If you have one role at Course Offering level you have it for all the sections below the Course Offering, no matter if you are member or not. If the role has only sense in a Section you must grant the role in the Section not in the Course Offering. I have a diagram with the relation between Section, Course Offering, Canonical Courses and Course Set.

I think Juanjo is right. The desired behavior is provide that role to all the sections below.

Ok, thank you both. It's a pity because that scheme was very suited to our needs.

You are able to do the same granting this role at section level (only in the section that the instructor is member). Granting roles at CO level lets you create supervisor roles, for example one person acting as  coordinator in all sections without being member of them. We would like to know your usecase to see if we can help to find a different solution. Please, join the next S2U Open Call on wednesday (in spanish), we will send the connection details to the<EMAIL_ADDRESS>mailing list, see you there, Thanks!!


Update test dialer to use ip when available

With the changes to https://github.com/knative-extensions/net-gateway-api/pull/685 where it is possible to have the ingress's public loadbalancer point to an IP instead of domain, we should use the value provided.
Changes

:bug: Don't expect there to only be domains, sometimes it might be an IP

/kind bug
/king cleanup

@dprotaso is it ok to include this PR (once is merged) in the already created release-1.14 branch?

Yeah I think it's fine to cherry pick once this merges since it's just some networking conformance test code

codegen timedout hitting go module cache
/retest

@andrew-su see the linter error

the linter is still going off

/lgtm
/approve
@izabelacg feel free to cherry-pick

/cherry-pick release-1.14


Improve test coverage

Is your feature request related to a problem? Please describe.
Project is well covered in tests but some options are not properly covered.
Describe the solution you'd like
We should add some more tests to consolidate behaviors.

[x] Missing test for diskette_dump --no-archive;
[x] Missing test for some options in load handler;
[x] Missing test for some options in dump handler;

Done in v0.3.2-pre.3


update and set ruby version, add style and spec ci

Updating some dependencies.
Adding rubocop style checks and rspec CI
Updating bundler: bundle update --bundler

With your change to the gem name, I think we should rename the repo too.  What do you think?

With your change to the gem name, I think we should rename the repo too. What do you think?

The gem name is still
gem.name = 'omniauth-azure-devops'


[Feature request] sb3-burn as Godot4 GDExtension

Currently there is an active Godot4 RL frameworks using pytorch Stable-baselines3. See the 3D gym compatible examples
Godot4 support RUST through addon:

https://github.com/godot-rust/gdext

The Godot4 RL's need to communicate with pytorch Sb3 could be substituted with Rust sb3-burn.
The Godot4 Rust community is often active to look for Rust frameworks to be integrated into Godot Rust community projects.
I shall contact them to get their feedback on this collaboration.

Hi,
Thanks for taking an interest in sb3-burn! At this point, there's too many changes being made to the structure of the project to start thinking about integration with other projects. Maybe this could be an idea in a few months when the project is a bit more stable :)


added user and group for the example app

if either user or group is missing, the actool validation would remind that's required:
$ actool -debug validate manifest.json
manifest.json: invalid ImageManifest: User is required
manifest.json: invalid ImageManifest: Group is required
Signed-off-by: Derek Ch<EMAIL_ADDRESS>

Ah, thank you, LGTM!


MPJPE from my own evaluating is inconsistent with that given in the paper

Hello! Thank you for this great job! After I train the model according to the parameters you gave, I use the trained model to evaluate the MPJPE in the stage 3, but the results obtained are inconsistent with the results given in the paper.
This is the MPJPE of my own training by using ground truth key points as input, but the MPJPE given in the paper is 30.1 mm.

my pytorch version is 1.9.0, torchvision is 0.10.0,  batch size is 1024, channels is 256, checkpoint_frequency is 10, downsample is 1, dropout is 0.2, epochs is 80, latent_features_dim is 256, learing_rate is 0.001, lr_decay is 0.95.
If you have time, can you reply as soon as possible, thank you very much!

Experiments were conducted in the following environment.

OS: Ubuntu 20.04.1 LTS
GPU: GeForce GTX 3080
CUDA version: 11.1
Pytorch version: 1.7.1

All these settings may affect the results. In addition, you also need to ensure that the seeds are the same at runtime.

Experiments were conducted in the following environment.

OS: Ubuntu 20.04.1 LTS
GPU: GeForce GTX 3080
CUDA version: 11.1
Pytorch version: 1.7.1

All these settings may affect the results. In addition, you also need to ensure that the seeds are the same at runtime.
Thanks for your reply! My seed is 4321, is your seed the same as mine?

The seed is the same. Make sure the settings of the networks are the same as those of gt_pretrained.bin. If the result is still not good, it might be caused by the difference between your experimental environment and the environment mentioned above.

Thanks for your reply! i will check it.

After I conducted the experiment of stage 2 and stage 3, I found that the MPJPE of the two steps is the same. I want to know if the command you gave (python run.py -k gt --stage 3 -lfd 256 -r stage_2_epoch_80.bin -lr 0.0005) did not conduct the fine-tuning network of stage 3, because the code enter the evaluation stage (Evaluating...) directly when stage 3 is conducted. In addition, I took a look at the pre-trained model about ground truth key points you gave , the number of epochs in it is 39, but the epochs of the fine-tuning network you gave on github is 20.
If you have time, can you reply as soon as possible, thank you very much!

This line of code ensures that the training process will not be skipped in the third stage, please make sure you did not delete it.
You can increase the number of epochs to get better performance, but basically, the results will not be much different.

Because your command in the stage 3 is 'python run.py -k gt --stage 3 -lfd 256 -r stage_2_epoch_80.bin -lr 0.0005'. -r means resume, so when the program runs the stage 3, it will conduct 290 lines and 291 lines of code, so the epoch is assigned the value 80 (the number of epochs saved in the stage 2). Therefore, when the code is conducted to the judgment of line 304, because the value of epoch is equal to the value of args.epoch, the following training process will not be conducted, and it will jump directly to the evaluation stage. I want to know what operations were performed in the fine-tuning phase of the third stage. Could you please tell me, thank you!

It is a bug, and I have fixed it. Thanks for pointing it out! Please check the latest code. In the third stage of optimization, the entire network will be trained for another 20 epochs for fine-tuning. The code snippet in your figure should not be run in this stage.

I want to know if you use the last saved model when you test, or the best model in training, because I train the network according to the code and environment you give, but I can’t gain the same results as you (30.1mm).😂

If the performance is still poor, you can just use the pre-trained models we provide.


Upgrade various packages for better handling behind shared proxy

It turns out that the newer version of requests doesn't work out of the box unless you also add a requests_toolbelt monkeypatch thing (see https://stackoverflow.com/a/37304524). I've gone ahead and pushed a commit to your PR to add that in.
It looks like there might also be a few changes to the JIRA client's API. For example, they renamed one of the parameters to transition_issue: https://github.com/pycontribs/jira/commit/cee6276c32c9813b2bfa6dcd78f282dbae8a60b0#diff-12827fc5aab7f1c957381e453bdfe85aR931
  File "/base/data/home/apps/s~spark-prs/live.412305397895741793/lib/jira/client.py", line 126, in wrapper
    result = func(*arg_list, **kwargs)
TypeError: transition_issue() takes at least 3 arguments (2 given)

Tested this out on the live site and it's successfully linking JIRA tickets and updating issue state, so I've now merged this set of fixes. Thanks!


[ZEPPELIN-1195] Unbind interpreter error.

What is this PR for?
This PR fixes unbind interpreter fail.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1195
How should this be tested?
Try to unbind any bind interpreter on your note.
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

It is duplicate with #1191

Oh sorry.


Enable SET deparsing

Enables set command deparsing for commands like:
SET statement_timeout TO 10000;
SET LOCAL statement_timeout TO 10000;
SET schema_path TO 'public','production';

@Winslett Looks good, thanks for contributing!


Add missing access keys (mnemonics) for menu items

Add missing access keys (mnemonics) for:

Update menu items (i.e. Restart to Update etc.)
Add Configuration
Enable All Breakpoints
Auto Save

When I was looking at the improvements done by @sbatten with regards to #54349, I noticed some access keys were missing. I added those in this pull request.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: rik-smeets sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @rik-smeets, I've added the mnemonics to the native menu system for consistency.

I believe this change is causing issues on the most recent Code Insiders (Version 1.28.0-insider (1.28.0-insider).

As you can see, some & is being displayed on Check for Updates option. This is also occuring in other Menu Options.

@joaosamouco I think so too, see #58603 for my quick analysis.


Published API docs incomplete

Likely due to crategen being in progress and https://github.com/rusoto/rusoto/pull/623 specifically.
Frustrating for users since they can't see the documentation at https://rusoto.github.io/rusoto/rusoto/ .
Hopefully when https://github.com/rusoto/rusoto/pull/628 lands this will go away.
Workarounds for end users:

check out Rusoto and run cargo doc --features (features here) --open to create docs locally and open them.
ask a maintainer to manually run the github pages publish step to get the regular location working again 😉

Highly recommend just using https://docs.rs/rusoto/0.24.0/rusoto/ to use the documentation for the released version being used instead of whatever's merged into master!
But yes, improving the documentation is on the crategen roadmap.

Sadly docs.rs doesn't have our complete documentation due to https://github.com/onur/docs.rs/pull/73 .  The above workaround should cover us until we land the much-needed crategen.

Oops, good call. That makes sense since the default feature is to include no services.

Ensuring this is fixed is now my highest priority, since crategen has landed.

I ran a manual doc upload.  Our API docs link needs to change to https://rusoto.github.io/rusoto in both the README and our crate description.
travis-cargo behavior needs to be changed to use this redirect url: echo '<meta http-equiv=refresh content=0;url=rusoto_core/index.html>' > target/doc/index.html.

Still not working, not sure if it's cached somewhere.  But we should update the crates to use https for the documentation address.

Geeze I do some other tasks and this fixes itself.  Hooray!  Still going to make a PR updating links to use https because we should.

Of course I find something new: we lost the fancy landing page from the root rusoto: https://github.com/rusoto/rusoto/blob/master/src/lib.rs .

Ah, that's a fairly simple fix. Can just copy the docs over into rusoto_core's lib.rs.


upgrade package dependencies

Upgrades nbconvert which now uses the newest version of mistune thereby resolving the mistune security concern

Codecov Report

Merging #70 (d42aa6d) into main (b0c4db0) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   94.02%   94.07%   +0.05%
==========================================
  Files          13       13
  Lines        1639     1654      +15
==========================================
+ Hits         1541     1556      +15
  Misses         98       98

Impacted Files
Coverage Δ

gnss_lib_py/utils/constants.py
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


glib: Remove ending NUL when converting Variant to OsString.

Fixes #620.

Makes sense to me but now I'm wondering if maybe we should add NULs when serializing those types into variants. I wonder what C code making use of paths in variants is expecting.
Might make sense bringing that up as a GLib issue if this is not documented anywhere.

...but now I'm wondering if maybe we should add NULs when serializing those types into variants.

I was just thinking about that!

I wonder what C code making use of paths in variants is expecting. Might make sense bringing that up as a GLib issue if this is not documented anywhere.

I think it is documented if you look deep enough:
In GApplication:

for G_OPTION_ARG_FILENAME, use ^&ay

With ay being an array of bytes, that would be read with g-variant-get-bytestring, that says:

If the array does not end with a nul terminator character, the empty string is returned. For this reason, you can always trust that a non-NULL nul-terminated string will be returned by this function.

So my guess is that the NUL byte is mandatory. Should I update this pull-request or create a new one, as this is technically a different issue?
What I don't quite understand here is why the Windows version stores WCHAR (u16) values instead of bytes. Nothing in the GLib source code that I saw suggests that an array of WCHAR should be used there. Maybe I'm missing something?
I don't have a Windows machine around to try, maybe I'll try with Wine and let you know.

That does look like it should probably always get converted to utf8, to match what glib always does. Exposing the utf16 is a rust thing

That does look like it should probably always get converted to utf8, to match what glib always does. Exposing the utf16 is a rust thing

The "local options" in GApplication are using a non-UTF-8 string for filename options though. It would be in local encoding (except on Windows where it's always UTF-8?).

What I don't quite understand here is why the Windows version stores WCHAR (u16) values instead of bytes. Nothing in the GLib source code that I saw suggests that an array of WCHAR should be used there. Maybe I'm missing something?

That was because OsString uses u16 on Windows, but probably does not make much sense considering the above, and should probably always use UTF-8 on Windows. (This means it would have to work similar to ToGlibPtr / FromGlibPtr for OsString / Path which also special-cases Windows).

With ay being an array of bytes, that would be read with g-variant-get-bytestring, that says:

ay is a byte array that doesn't have to end on NUL but get_bytestring() is a helper function that assumes that for "byte strings" (i.e. not byte arrays), AFAIU.
I think your analysis is correct in that regard and it should indeed be assuming / putting a NUL at the end for Path / OsString conversions.

Hmm, yes it does look like the "local encoding" on windows is supposed to be utf8: g_win32_get_command_line

Ok, I'm trying to fix everything in one go. I've just added a new commit and squashed the PR.
I've added changes to OsString::from_variant() and OsStr::to_variant(), both for Unix and Windows variants, pushing and popping the NUL byte appropriately.
I'm not totally sure about the lossy conversions in Windows... But then, if you have a Windows file name that is not UTF-8 valid, I think that you have already lost: Rust can handle that with the internal WTF-8 encoding of OsString, but AFAIK glib uses pure UTF-8. The alternative to lossy conversion would be to replace them with an empty string, as Variant does with the missing NUL.
I have tested my example from the original bug report, both in Linux and in Windows (tricky!) and now it seems to work great. (previously Windows failed with something about the type of variant being "aq" instead of "ay").

I would go with how it's implemented in glib/src/translate.rs in c_to_path_buf and path_to_c.

I have force-pushed a new version of this PR.
Funnily, using translate.rs makes the code shorter: (23 insertions(+), 54 deletions(-)).

The implementation looks all good to me, just needs a little bit of cleanup and then this can go in.

Funnily, using translate.rs makes the code shorter: (23 insertions(+), 54 deletions(-)).

That's nice :)

I've just force-pushed a new version.
Also, now that these functions call into translate.rs I've fully separated the impls of Path/PathBuf and OsStr/OsString.


Email Verification done

Description
Added email verification

Fixes #72

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes
[x] I have maintained a clean commit history by using the necessary Git commands
[x] I have checked that my code does not cause any merge conflicts

Screenshots

Make smtp server on gmail or brevo or sendgrid and put the details in .env file . I have added .env.example file to explain which details are required
https://www.youtube.com/watch?v=kTcmbZqNiGw
You may get your credentials here
Please add hacktoberfest-accepted tag.

Also please ensure that before login the email is verified else it won't work

This branch has conflicts that must be resolved

Pls don't commit node_modules they can be installed with the package.json file. Its not possible to solve node_modules conflicts as it contains all the dependencies


BREAKING: web/resource: fixed Resource[T] to not force pointers.

things like *any are nasty. use T instead of *T  and let the user choose if they want a pointer or not.

LGTM

<EMAIL_ADDRESS>tagged


Boombox in weapon test saves 0.6 turns

Tested in mafia CLI with ashq.
Can see it correctly changes to weapon damage when meat song is on. Does not do anything if weapon damage is already on

ashq if (item_amount($item[songboom™ boombox]) > 0 && get_property('boomBoxSong') != "These Fists Were Made for Punchin'") cli_execute('boombox damage');

Preference choiceAdventure1312 changed from 0 to 4
Using 1 SongBoom™ BoomBox...
Preference lastEncounter changed from horrible tourist family to Choose a Soundtrack
Encounter: Choose a Soundtrack
Preference boomBoxSong changed from Total Eclipse of Your Meat to
Preference boomBoxSong changed from to Total Eclipse of Your Meat
Preference boomBoxSong changed from Total Eclipse of Your Meat to These Fists Were Made for Punchin'
Preference _boomBoxSongsLeft changed from 8 to 7
Setting soundtrack to These Fists Were Made for Punchin'
Preference _concoctionDatabaseRefreshes changed from 874 to 875
Finished using 1 SongBoom™ BoomBox.
Preference choiceAdventure1312 changed from 4 to 0

ashq if (item_amount($item[songboom™ boombox]) > 0 && get_property('boomBoxSong') != "These Fists Were Made for Punchin'") cli_execute('boombox damage');

boombox meat

Preference choiceAdventure1312 changed from 0 to 5
Using 1 SongBoom™ BoomBox...
Encounter: Choose a Soundtrack
Preference boomBoxSong changed from These Fists Were Made for Punchin' to
Preference boomBoxSong changed from to These Fists Were Made for Punchin'
Preference boomBoxSong changed from These Fists Were Made for Punchin' to Total Eclipse of Your Meat
Preference _boomBoxSongsLeft changed from 7 to 6
Setting soundtrack to Total Eclipse of Your Meat
Preference _concoctionDatabaseRefreshes changed from 875 to 876
Finished using 1 SongBoom™ BoomBox.
Preference choiceAdventure1312 changed from 5 to 0

ashq if (item_amount($item[songboom™ boombox]) > 0 && get_property('boomBoxSong') != "These Fists Were Made for Punchin'") cli_execute('boombox damage');

Preference choiceAdventure1312 changed from 0 to 4
Using 1 SongBoom™ BoomBox...
Encounter: Choose a Soundtrack
Preference boomBoxSong changed from Total Eclipse of Your Meat to
Preference boomBoxSong changed from to Total Eclipse of Your Meat
Preference boomBoxSong changed from Total Eclipse of Your Meat to These Fists Were Made for Punchin'
Preference _boomBoxSongsLeft changed from 6 to 5
Setting soundtrack to These Fists Were Made for Punchin'
Preference _concoctionDatabaseRefreshes changed from 876 to 877
Finished using 1 SongBoom™ BoomBox.
Preference choiceAdventure1312 changed from 4 to 0

Modtrace

> c2t_hccsCCS set to c2t_hccsafterAdventureScript
    => c2t_hccs_postAdv.ashPreference afterAdventureScript changed from
    to c2t_hccs_postAdv.ashbetweenBattleScript => c2t_hccs_preAdv.ashPreference
    betweenBattleScript changed from to c2t_hccs_preAdv.ashchoiceAdventureScript
    => c2t_hccs_choices.ashPreference choiceAdventureScript changed
    from to c2t_hccs_choices.ashhpAutoRecovery => 0.6Preference
    hpAutoRecovery changed from -0.05 to 0.6hpAutoRecoveryItems =>
    cannelloni cocoon;tongue of the walrus;disco napPreference
    hpAutoRecoveryItems changed from free rest;cannelloni cocoon;relaxing hot
    tub to cannelloni cocoon;tongue of the walrus;disco naphpAutoRecoveryTarget
    => 0.9Preference hpAutoRecoveryTarget changed from 0.75 to 0.9manaBurningThreshold
    => -0.05Preference manaBurningThreshold changed from 0.8 to -0.05mpAutoRecoveryItems
    =>Preference mpAutoRecoveryItems changed from free rest;csa
    all-purpose soap;tonic water;knob goblin superseltzer;cloaca-cola;mountain
    stream soda;magical mystery juice;knob goblin seltzer;doc galaktik's
    invigorating tonic;cherry cloaca cola;soda water;notes from the
    elfpocalypse, chapter i;notes from the elfpocalypse, chapter ii;notes from
    the elfpocalypse, chapter iii;notes from the elfpocalypse, chapter
    iv;notes from the elfpocalypse, chapter v;notes from the elfpocalypse,
    chapter vi;oscus's neverending soda torecoveryScript =>Preference
    recoveryScript changed from Universal_recovery toChecking
    test 11: Coil WireChecking test 4: Feed
    ConspiratorsChecking test 3: Build
    Playground MazesChecking test 2: Feed The
    ChildrenChecking test 1: Donate BloodChecking
    test 9: Make MargaritasChecking test 8: Be a
    Living StatueChecking test 10: Clean Steam
    TunnelsChecking test 5: Breed More ColliesChecking
    test 6: Reduce Gazelle PopulationRunning
    wanderer fightPutting PVPHax the Baby Bugged Bugbear back into
    terrarium...Taking Gabediah the Melodramedary out of terrarium...Preference
    nextAdventure changed from None to The Neverending PartyMaximizer:
    mainstat,exp,6 bonus designer sweatpants,-equip garbage shirt,exp,equip
    kramco,equip dromedary drinking helmetMaximizing...2080
    combinations checked, best score 1,261.69Taking off Fourth of May
    Cosplay Saber...Preference _concoctionDatabaseRefreshes changed from
    174 to 175Equipment changed.Wielding Fourth of May Cosplay Saber...Equipment
    changed.Holding Kramco Sausage-o-Matic™...Equipment changed.Encounter:
    Adjust your ParkaPreference parkaMode changed from kachungasaur to
    spikolodonYour parka is now set to spikolodon mode.Putting on
    Jurassic Parka...Equipment changed.Putting on designer
    sweatpants...Equipment changed.Putting on dorky glasses...Preference
    _concoctionDatabaseRefreshes changed from 175 to 176Equipment changed.Putting
    on backup camera...Equipment changed.Putting on Retrospecs...Preference
    _concoctionDatabaseRefreshes changed from 176 to 177Equipment changed.Putting
    on dromedary drinking helmet...Equipment changed.Visit to
    Neverending Party: The Neverending Party in progress...(Latte Monster
    counter expired)Preference lastAdventure changed from The Haunted
    Conservatory to The Neverending Party[101] The Neverending PartyPreference
    lastEncounter changed from Adjust your Parka to sausage goblinEncounter:
    sausage goblinPreference _lastCombatStarted changed from
<PHONE_NUMBER>1122 to<PHONE_NUMBER>1229Preference _sausageFights changed from
    4 to 5Preference _lastSausageMonsterTurn changed from 507420 to 507459Round
    0: Prusias wins initiative!Round 1: You lose 25 hit pointsc2t_bb
    macro: scrollwhendone;if hasskill 7341;skill 7341;endif;if hasskill
    7320;skill 7320;endif;if hasskill 7289;skill 7289;endif;if sealclubber ||
    turtletamer || discobandit || accordionthief;if hasskill 4034;skill
    4034;endif;if discobandit || accordionthief;if hasskill 4014;skill
    4014;endif;endif;if hasskill 7297;skill 7297;endif;if hasskill 7319;skill
    7319;endif;while !pastround 20;attack;endwhile;endif;if pastamancer;if
    hasskill 7319;skill 7319;endif;if hasskill 3007;skill 3007;endif;if
    hasskill 7297;skill 7297;endif;endif;if sauceror;if hasskill 4034;skill
    4034;endif;if hasskill 7297;skill 7297;endif;if hasskill 7319;skill
    7319;endif;if hasskill 4012;skill 4012;endif;if hasskill 4012;skill
    4012;endif;endif;Round 1: Prusias executes a macro!Round 1:
    Prusias casts DETECT WEAKNESS!Round 2: sausage goblin drops 36 attack
    power.Round 2: sausage goblin drops 38 defense.Round 2: Prusias
    casts MICROMETEORITE!Round 3: sausage goblin drops 32 attack power.Round
    3: sausage goblin drops 35 defense.Preference _micrometeoriteUses
    changed from 25 to 26Round 3: Prusias casts STUFFED MORTAR SHELL!Round
    4: You lose 19 hit pointsRound 4: Prusias casts SING ALONG!Round
    5: sausage goblin takes 786 damage.Round 5: Prusias wins the fight!After
    Battle: Gabediah kicks you in the face, in just the right place to be very
    effective chiropracty. If that's a word.After Battle: You gain 30 hit
    pointsAfter Battle: You gain 24 Mana PointsYou gain 230 MeatPreference
    camelSpit changed from 97 to 100After Battle: You hear a loud
    schlurrrrrk! You hear a loud schlurrrrrk! noise, and turn to see Gabediah
    sucking the liquid out of a rusty canteen he found somewhere. (100% full)After
    Battle: Gabediah is starting to make audible sloshing noises as he walks
    around.You acquire an item: magical sausage casingAfter Battle:
    Gabediah smiles a smile that communicates the opposite of every emotion
    you've ever seen anyone smile about. (+11 Stats)After Battle: Gabediah
    adjusts his little Oliver Cromwell glasses and makes some helpful
    adjustments to your to-do list. (+4 Mysticality Stats)After Battle:
    You gain 102 FortitudeYou gain a Muscle point!After Battle: You
    gain 234 WizardlinessAfter Battle: You gain 112 SmarmAfter Battle:
    You remember, from the map in your mind, an area under a pile of empty
    beer bottles with a cache of meat!You gain 99 Meat.Preference
    sweat changed from 66 to 68Preference encountersUntilNEPChoice changed
    from 4 to 3Preference lastCopyableMonster changed from fluffy bunny to
    sausage goblinThis combat did not cost a turnPreference
    _lastCombatWon changed from false to truePreference familiarSweat
    changed from 55 to 56Preference _concoctionDatabaseRefreshes
    changed from 177 to 178Putting Gabediah the Melodramedary back into
    terrarium...Taking PVPHax the Baby Bugged Bugbear out of terrarium...Maximizer:
    familiar weightMaximizing...3744 combinations checked, best score
    68.00Wielding fish hatchet...Preference
    _concoctionDatabaseRefreshes changed from 178 to 179Equipment changed.Holding
    Fourth of May Cosplay Saber...Equipment changed.Putting on
    Stephen's lab coat...Equipment changed.Putting on Cargo Cultist
    Shorts...Preference _concoctionDatabaseRefreshes changed from 179 to
    180Equipment changed.Putting on Brutal brogues...Equipment
    changed.Putting on hewn moon-rune spoon...Equipment changed.Putting
    on Beach Comb...Equipment changed.Putting PVPHax the Baby Bugged
    Bugbear back into terrarium...Taking Wafferson the Hovering Sombrero
    out of terrarium...Running pre-Reduce Gazelle
    Population stuff...Preference choiceAdventure1312 changed from
    0 to 4Using 1 SongBoom™ BoomBox...Preference lastEncounter
    changed from sausage goblin to Choose a SoundtrackEncounter: Choose a
    SoundtrackPreference boomBoxSong changed from Total Eclipse of Your
    Meat toPreference boomBoxSong changed from to Total Eclipse of Your
    MeatPreference boomBoxSong changed from Total Eclipse of Your Meat to
    These Fists Were Made for Punchin'Preference _boomBoxSongsLeft changed
    from 10 to 9Setting soundtrack to These Fists Were Made for Punchin'Finished
    using 1 SongBoom™ BoomBox.Preference choiceAdventure1312 changed
    from 4 to 0Putting on Powerful Glove...Preference
    _concoctionDatabaseRefreshes changed from 180 to 181Equipment changed.You
    acquire an effect: Triple-Sized (20)Preference
    _powerfulGloveBatteryPowerUsed changed from 10 to 15CHEAT CODE: Triple
    Size was successfully cast.Putting on Beach Comb...Preference
    _concoctionDatabaseRefreshes changed from 181 to 182Equipment changed.Casting
    The Ode to Booze 1 times...You acquire an effect: Ode to Booze (5)The
    Ode to Booze was successfully cast.You gain 10 AdventuresYou
    acquire an effect: In a Lather (25)You gain 2 DrunkennessYou lose
    some of an effect: Ode to Booze (-2)You lose 500 MeatPreference
    _speakeasyDrinksDrunk changed from 1 to 2Preference
    _concoctionDatabaseRefreshes changed from 182 to 183Casting Carol of
    the Bulls 1 times...You acquire an effect: Carol of the Bulls (10)Carol
    of the Bulls was successfully cast.Casting Rage of the Reindeer 1
    times...You acquire an effect: Rage of the Reindeer (10)Rage of
    the Reindeer was successfully cast.Info: don't have the skill "Blood
    Frenzy" to get the "Frenzied, Bloody" effectCasting
    Scowl of the Auk 1 times...You acquire an effect: Scowl of the Auk (10)Scowl
    of the Auk was successfully cast.Casting Tenacity of the Snapper 1
    times...You acquire an effect: Tenacity of the Snapper (5)Tenacity
    of the Snapper was successfully cast.Casting Song of the North 1
    times...You acquire an effect: Song of the North (10)Song of the
    North was successfully cast.[101] Combing (muscle) Beach HeadPreference
    _beachHeadsUsed changed from 1,10,11 to 1,6,10,11Preference
    _freeBeachWalksUsed changed from 3 to 4You acquire an effect: Lack of
    Body-Building (50)Approaching pool table with an aggressive stance.You
    acquire an effect: Billiards Belligerence (10)Preference _poolGames
    changed from 1 to 2You lost. Boo hoo.Putting Wafferson the
    Hovering Sombrero back into terrarium...Taking Gabediah the
    Melodramedary out of terrarium...Preference nextAdventure changed
    from The Neverending Party to ThugnderdomeCasting Cannelloni Cocoon 1
    times...You gain 1,000 hit pointsCannelloni Cocoon was
    successfully cast.Visit to MoxSign: Thugnderdome in progress...Preference
    lastAdventure changed from The Neverending Party to Thugnderdome[101]
    ThugnderdomePreference lastEncounter changed from Choose a Soundtrack
    to gnu jack gnomeEncounter: gnu jack gnomePreference
    _lastCombatStarted changed from<PHONE_NUMBER>1229 to<PHONE_NUMBER>1247Round
    0: Prusias wins initiative!c2t_bb macro: scrollwhendone;pickpocket;if
    hasskill 7291;skill 7291;endif;if hasskill 7340;skill 7340;endif;Round
    1: Prusias executes a macro!Round 1: Prusias casts METEOR SHOWER!You
    acquire an effect: Meteor Showered (1)Preference _meteorShowerUses
    changed from 1 to 2Round 2: Prusias casts %FN, SPIT ON ME!!Preference
    camelSpit changed from 100 to 0Round 3: Gabediah obligingly -- maybe
    too obligingly -- spits in your face.You acquire an effect: Spit Upon
    (15)c2t_bb macro: if hasskill 7311;skill 7311;endif;Round 3:
    Prusias executes a macro!Preference lastEncounter changed from gnu
    jack gnome to Using the ForceEncounter: Using the ForceSubmitting
    option 3 for choice 1387Preference _saberForceUses changed from 2 to 3You
    acquire an item: springYou acquire an item: sprocketYou acquire an
    item: flangePreference _concoctionDatabaseRefreshes changed from
    183 to 184Using 1 corrupted marrow...You acquire an effect:
    Cowrruption (30)Preference _concoctionDatabaseRefreshes changed from
    184 to 185Finished using 1 corrupted marrow.Putting on designer
    sweatpants...Equipment changed.Purchasing Meleegra™ pills (1 @
    270)...You spent 270 MeatYou acquire an item: Meleegra™ pillsPreference
    _concoctionDatabaseRefreshes changed from 185 to 186Putting on Cargo
    Cultist Shorts...Preference _concoctionDatabaseRefreshes changed from
    186 to 187Equipment changed.Purchases complete.Using 1
    Meleegra™ pills...You acquire an effect: Engorged Weapon (5)Finished
    using 1 Meleegra™ pills.Casting Blessing of the War Snapper 1
    times...You acquire an effect: Disdain of the War Snapper (10)Blessing
    of the War Snapper was successfully cast.Casting Bow-Legged Swagger 1
    times...You acquire an effect: Bow-Legged Swagger (1)Preference
    _bowleggedSwaggerUsed changed from false to trueBow-Legged Swagger was
    successfully cast.Folding umbrellaPreference lastEncounter changed
    from Using the Force to Configure Your Unbreakable UmbrellaEncounter:
    Configure Your Unbreakable UmbrellaPreference umbrellaState changed
    from cocoon to pitchfork styleMaximizer: weapon damage,switch
    left-hand manMaximizing...2610 combinations checked, best score
    1,175.50Putting on seal-skull helmet...Equipment changed.You
    acquire an item: broken champagne bottleWielding broken champagne
    bottle...Equipment changed.Holding fish hatchet...Preference
    _concoctionDatabaseRefreshes changed from 187 to 188Equipment changed.Preference
    lastEncounter changed from Configure Your Unbreakable Umbrella to Adjust
    your ParkaEncounter: Adjust your ParkaPreference parkaMode changed
    from spikolodon to kachungasaurYour parka is now set to kachungasaur
    mode.Putting on Jurassic Parka...Equipment changed.Putting on
    Kremlin's Greatest Briefcase...Preference _concoctionDatabaseRefreshes
    changed from 188 to 189Equipment changed.Putting on Powerful
    Glove...Preference _concoctionDatabaseRefreshes changed from 189 to 190Equipment
    changed.Putting Gabediah the Melodramedary back into terrarium...Taking
    Talk to the Hand the Left-Hand Man out of terrarium...Putting on
    unbreakable umbrella...Equipment changed.OU
    pizza skippedInspecting Cargo Cultist Shortspicking pocket
    284Preference cargoPocketsEmptied changed from to 284Preference
    _cargoPocketEmptied changed from false to trueYou acquire an item:
    Yeg's Motel toothbrushUsing 1 Yeg's Motel toothbrush...You acquire
    an effect: Rictus of Yeg (50)Finished using 1 Yeg's Motel toothbrush.

type
source
Weapon Damage
Weapon Damage Percent

Item
seal-skull helmet
+1.00
= +1.00

Item
broken champagne bottle

Item
15% weapon power
+7.50
= +8.50

Item
fish hatchet
+50.00
= +58.50

Item
15% weapon power
+30.00
= +88.50

Item
Brutal brogues

Item
Kremlin's Greatest Briefcase

Item
Powerful Glove

UnbreakableUmbrella
pitchfork style
+25.00
= +113.50

Skill
Claws of the Walrus
+7.00
= +120.50

Effect
Meteor Showered

Effect
Engorged Weapon
+10.00
= +130.50

Effect
Tenacity of the Snapper
+8.00
= +138.50

Effect
Billiards Belligerence

Effect
Carol of the Bulls

Effect
Disdain of the War Snapper
+5.00
= +143.50

Effect
Rage of the Reindeer
+10.00
= +153.50

Effect
Scowl of the Auk
+10.00
= +163.50

Effect
Song of the North

Effect
Spit Upon

Effect
In a Lather
+20.00
= +183.50

Effect
In a Lather

Effect
Cowrruption

Effect
Lack of Body-Building

Effect
Rictus of Yeg

BoomBox
These Fists Were Made for Punchin'
+17.00
= +200.50

Pre-Reduce Gazelle Population (weapon) test fail.
Currently only can complete the test in 5 turns.

�

I'm fairly certain the boombox song does not affect the weapon test. It's the reason I initially removed it: https://github.com/C2Talon/c2t_hccs/commit/f8d7cace26dd8ceb01d0f48e6d1575d475493f04#diff-23a85e40bf658d721253442c54251273eaf658a28d91efa85591d76b7be69d09L1510-L1512
The modtrace of course will show it, but the modtrace does not entirely reflect how the tests are calculated in-game. I can check again though.


Allow setting the keybind for interaction

Since users can rebind it in the game, it should be editable without having to compile. Might only be used in the pathing module at the moment; that's where I noticed it.
https://github.com/blish-hud/Blish-HUD/blob/279c620296327bea48a2583046da1085cfb06c73/Blish HUD/Common/Gw2/KeyBindings.cs#L15
Referred to from here: https://github.com/blish-hud/Pathing/blob/f8bb925c33b7d13dcd6c77ad469a7a3d616b41dd/State/SharedPackState.cs#L50

Yes, this is definitely on the roadmap as plenty of folks do have this rebound.
We also hope to expose in-game keybindings automatically over the bridge DLL at some time in the future to help automate this and keep it in sync.


Update README.md

There is a trailing whitespace in line 16 of README.md so the lint is failed

There is a trailing whitespace in line 16 of README.md so the lint is failed


New version: DFTforge v1.0.1

Registering package: DFTforge
Repository: https://github.com/KAIST-ELST/DFTforge.jl
Created by: @bluehope
Version: v1.0.1
Commit: 36a0349dddad67fcfe9a7845208b3ef3e46b9439
Git reference: master

@JuliaRegistrator [noblock]


CLOUD-663: New image for openstack

@keyki pls

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1577/

I believe in you !


adding models/Spaces/datasets to Huggingface Hub

Hi, would you be interested in adding frame-interpolation to Hugging Face Hub? The Hub offers free hosting, and it would make your work more accessible and visible to the rest of the ML community. There is already a google AI organization on huggingface with models or we could setup a organization for the frame-interpolation team to add the models, spaces and datasets
Example from other organizations:
Keras: https://huggingface.co/keras-io
Microsoft: https://huggingface.co/microsoft
Facebook: https://huggingface.co/facebook
Example spaces with repos:
github: https://github.com/salesforce/BLIP
Spaces: https://huggingface.co/spaces/akhaliq/BLIP
github: https://github.com/facebookresearch/omnivore
Spaces: https://huggingface.co/spaces/akhaliq/omnivore
and here are guides for adding spaces/models/datasets to your org
How to add a Space: https://huggingface.co/blog/gradio-spaces
how to add models: https://huggingface.co/docs/hub/adding-a-model
uploading a dataset: https://huggingface.co/docs/datasets/upload_dataset.html
Please let us know if you would be interested and if you have any questions, we can also help with the technical implementation. Thanks

Hi, thanks and it'd be great to create a space for frame-interpolation!
Using the existing Google AI organization sounds good, and help with the technical implementation is highly appreciated.
Happy to review and accept if a PR is needed for this.

@fitsumreda greats i have added the models here https://huggingface.co/akhaliq/frame-interpolation will look into setting up a space

Hey @AK391! Thanks for setting it up!
As we usually aim for 1 model per 1 repo, would it make sense to split things a bit? We would end up with 4 repos

film_vgg
film_l1
film_style
film-imagenet-vgg-verydeep-19

We have from_pretrained_keras in huggingface_hub that allows loading SavedModel and in theory, we could use it here. Finally, in the Interpolator constructor, we could allow loading the model from the Hub as well (A simple approach could be by loading from the hub when there is a hf prefix, that is, when model_path="hf:/ak/film_vgg"). WDYT? Is this something that makes sense?

@osanseviero thanks, set up the models as 4 separate repos and the space is up here https://huggingface.co/spaces/akhaliq/frame-interpolation


Fix thick scrollbar on filter menu

Before:

After:

Unsure what happened with CI here, looks like some UTF-8 issue?

@CirnoT What browser did you see this on?

@go-gitea/mergers feel free to dismiss my request changes if I have missed something here.

@CirnoT What browser did you see this on?

Firefox, Windows 10

We should really be ensuring that a scrollbar doesn't need to be shown I think...

That might be little un-intuitive as there would be no indication to user that the area is scrollable.

If content overflows unexpectedly, it's better to fix the underlying root issue why it overflows in first place than to use overflow: hidden which I see as a last-ditch effort. Based on the screenshot, I think some style might limit the horizontal width of the popup. Try removing that limit and let it naturally expand based on content.

scrollbar-width is Firefox-only currently. There are ways to do it on webkit browsers too but it's very finicky and I would not recommend it there. That said, I think I'd be slightly in favor of adding site-wide thin scrollbars, e.g.

*:not(select) {
  scrollbar-width: thin;
}

(taken from https://github.com/StylishThemes/Overlay-Scrollbars/blob/master/github-overlay-scrollbars.user.css)

If content overflows unexpectedly, it's better to fix the underlying root issue why it overflows in first place than to use overflow: hidden which I see as a last-ditch effort. Based on the screenshot, I think some style might limit the horizontal width of the popup. Try removing that limit and let it naturally expand based on content.

I am afraid that would be hard to achieve, the width is decided by browser dynamically and I see no direct CSS stylesheet that would limit it. It is properly calculated based on the content, however the vertical scrollbar eats away at the pixels causing the element body inside to overflow.
The one solution I could see helping it would be to remove width: 100px from .ui.menu .ui.dropdown.item .menu .item as well as override Fomantic's own margin: 0; on .ui.menu .ui.dropdown .menu > .item
If you believe this is worth blocking this PR for, I fully understand that and step down - this was supposed to be a quick fix for visual glitch with rather deep roots, I have no intentions on digging any deeper into trying to hack unfamiliar to me framework.

For what it's worth, from quick check it does seem to be Firefox specific and partially caused by white-space: nowrap; applied by Fomantic to these menu elements as well.

Don't sweat about the CI failing. It happens from time to time. I've just restarted the task.

Codecov Report

Merging #10835 into master will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10835      +/-   ##
==========================================
+ Coverage   43.56%   43.81%   +0.24%
==========================================
  Files         589      590       +1
  Lines       82700    83387     +687
==========================================
+ Hits        36031    36535     +504
- Misses      42192    42331     +139
- Partials     4477     4521      +44

Impacted Files
Coverage Δ

modules/auth/repo_form.go
41.29% <0.00%> (-3.16%)
:arrow_down:

services/pull/check.go
52.43% <0.00%> (-3.05%)
:arrow_down:

modules/git/command.go
86.95% <0.00%> (-2.61%)
:arrow_down:

modules/indexer/issues/indexer.go
56.19% <0.00%> (-1.33%)
:arrow_down:

services/pull/temp_repo.go
31.62% <0.00%> (ø)

models/migrations/v132.go
0.00% <0.00%> (ø)

modules/convert/convert.go
75.65% <0.00%> (+0.81%)
:arrow_up:

services/pull/pull.go
35.88% <0.00%> (+0.88%)
:arrow_up:

models/error.go
30.16% <0.00%> (+0.93%)
:arrow_up:

routers/repo/setting_protected_branch.go
42.45% <0.00%> (+1.02%)
:arrow_up:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52cfd27...3c0417a. Read the comment docs.

I can't seem to quite replicate the horizontal scrollbar. For some reason, this Use alt.. hint does not show for me and. What I do see is that items are limited to 250px via this:
.repository .select-label .item {
    max-width: 250px;
    overflow: hidden;
    text-overflow: ellipsis;
}

This seems to be the rule that eliminates the horizontal on these. I think one solution could be to just ensure the .item class is present on all children.
Alternatively, can you post the HTML you see when the horizontal scrollbar is visible?

The rule you linked does not apply to these elements as they are never inside container with class select-label.
If you looked at screenshots you would see that the issue happens on "Assignee" where hint is not shown at all, as such it is red herring.
Have HTML as requested, tho i have no idea why it would be necessary as it can be easily replicated.

  All assignees
   *****
   *****
   *****
   *****
   *****
   *****
   *****

Looking at it, it would seem that ensuring select-label on container div does solve the issue everywhere except on Label search where hint is shown.
Because the hint uses , adding item on it and ensuring select-label on parent does solve the issue, however at the same time it results in hint being partially hidden.
Use alt + click/enter to exclude labels

I think we can use this general approach to limit width of all direct children to .menu on the sidebar:
.metas .menu > * {
  max-width: 250px;
  overflow: hidden;
  text-overflow: ellipsis;
}

Remove the .repository .select-label .item after adding that.

This seems to work for me:
.metas .menu.transition > *, #issue-filters .menu.transition > * {
  max-width: 250px;
  overflow: hidden;
  text-overflow: ellipsis;
}

Fomantic-UI does not seem to have a distinct class for dropdowns, so hopefully the .transition class addition will help with only matching those.

This does seem to work everywhere aside for the hint.
Use alt + click/enter to exclude labels

Is there any reason why we can't ensure select-label to be present on container for these dropdowns?

I would aim for a more general solution for all dropdowns. According to this a dropdown is defined by .dropdown > .menu, so I think we can just use:
.dropdown > .menu > * {
  max-width: 300px;
  overflow-x: hidden;
  text-overflow: ellipsis;
}

I'm pretty sure there are no dropdowns around that would require more width. Note I bumped the width by 50px as I think we can show a bit more of overly long labels. The .info needs a width adjustment to stretch the parent:
.repository .filter.menu.labels .label-filter .menu .info {
  width: 100%;
}

It does work, however the tip ends up like this:

Hold alt while selecting to exclude

Sounds good to me

Should I close this PR and you will open new one with changes? @silverwind

Yes, I'll open a new one soon.

See #10897


Add current stacktrace log

Hi! Special thanks for ecto_sql and contributers.
AR has powerfull debug log output when sql called. I like it.
I implemented it to ecto_sql. If you don't mind check it.
How about incorporating this feature?

@tashirosota this looks nice, thanks for pinging! How would you configure it in your app?

@josevalim @v0idpwn
Thanks for response！！I will reply after thinking！

@tashirosota this looks nice, thanks for pinging! How would you configure it in your app?

Hi @tashirosota! Thanks for the work so far, I am discussing with @v0idpwn the best way to provide this, which may require some changes in Ecto too.

Hey, @tashirosota! I tried to move the get stacktrace part to ecto, and only turn it into a log in ecto_sql.  My goal is to avoid the traces of ecto insides so we don't need to process the stacktrace.

@v0idpwn
Thanks！That's great！


Fixing small typo

Changing from dsa to dss in error message.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1641/
Test PASSed.

was surprised to see this; found http://security.stackexchange.com/questions/51567/why-are-dsa-keys-referred-to-as-dss-keys-when-used-with-ssh; I actually think ssh is contributing to confusion here.  I'd advise using "or ssh-dss (DSA)"  to avoid confusing people with a similar level of partial knowledge, since the key types are really RSA and DSA, despite the label ssh-dss.
What do you think?

I think either is fine, as long as there's consistency between the message
and the config. I agree that DSA makes more sense but changing it will
break existing yaml config files.
On Wed, Jul 8, 2015 at 6:17 PM Dan Mick<EMAIL_ADDRESS>wrote:

was surprised to see this; found
http://security.stackexchange.com/questions/51567/why-are-dsa-keys-referred-to-as-dss-keys-when-used-with-ssh;
I actually think ssh is contributing to confusion here. I'd advise using
"or ssh-dss (DSA)" to avoid confusing people with a similar level of
partial knowledge, since the key types are really RSA and DSA, despite the
label ssh-dss.
What do you think?
—
Reply to this email directly or view it on GitHub
https://github.com/ceph/teuthology/pull/565#issuecomment-119776229.

?  No, I'm talking about changing the error message from your suggested 'keytype must be ssh-rsa or ssh-dss' to 'keytype must be ssh-rsa or ssh-dss (DSA)'

Sorry Dan, I somehow misread your first message (too tired I guess). I
agree, will change it the way you suggest.
On Wed, Jul 8, 2015 at 8:38 PM Dan Mick<EMAIL_ADDRESS>wrote:

? No, I'm talking about changing the error message from your suggested
'keytype must be ssh-rsa or ssh-dss' to 'keytype must be ssh-rsa or ssh-dss
(DSA)'
—
Reply to this email directly or view it on GitHub
https://github.com/ceph/teuthology/pull/565#issuecomment-119804844.

done

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1643/
Test PASSed.


When set setBaselineDistance() after connet(), layout result not correct.

Hello, i'm creating constraintlayout for WPF, i want create constraint rely on baseline for some text control, the step of creating constraint  is:

user load ConstraintWidget.connect() to define constraint
wpf auto measure some text control, calculate baseline position and setBaselineDistance() in WPF measure cycle
load ConstraintWidgetContainer.layout() to calculate control position in WPF measure cycle

but the result not correct.
I open this java project find test about baseline, in constraintlayout\core\src\test\java\androidx\constraintlayout\core\OptimizationsTest.java, i move setBaselineDistance() after connet(), the test failed.
@Test
    public void testBasicBaseline() {
        ConstraintWidgetContainer root = new ConstraintWidgetContainer(0, 0, 600, 600);
        ConstraintWidget A = new ConstraintWidget(100, 20);
        ConstraintWidget B = new ConstraintWidget(100, 20);
        root.setDebugName("root");
        A.setDebugName("A");
        B.setDebugName("B");
        //A.setBaselineDistance(8);
        //B.setBaselineDistance(8);
        root.add(A);
        root.add(B);
        A.connect(ConstraintAnchor.Type.TOP, root, ConstraintAnchor.Type.TOP);
        A.connect(ConstraintAnchor.Type.BOTTOM, root, ConstraintAnchor.Type.BOTTOM);
        A.connect(ConstraintAnchor.Type.LEFT, root, ConstraintAnchor.Type.LEFT);
        B.connect(ConstraintAnchor.Type.LEFT, A, ConstraintAnchor.Type.RIGHT);
        B.connect(ConstraintAnchor.Type.BASELINE, A, ConstraintAnchor.Type.BASELINE);

        A.setBaselineDistance(8);
        B.setBaselineDistance(8);

        Metrics metrics = new Metrics();
        root.fillMetrics(metrics);
        root.setOptimizationLevel(Optimizer.OPTIMIZATION_STANDARD);
        root.layout();
        System.out.println("1) root: " + root + " A: " + A + " B: " + B);
        System.out.println(metrics);
        assertEquals(A.getTop(), 290);
        assertEquals(B.getTop(), A.getTop());
    }

Is it necessary to setBaselineDistance before connect ？I don't know it ‘s bug or feature. Is there any way to change？

I asked @camaelon hopefully he has time.
but I suspect it just needs to be non 0 before the connect.
i.e.  you can have
A.setBaselineDistance(1);
B.setBaselineDistance(1);
before the connect
Than after set it to what ever comes from the WPF engine.
(Same thing applies if you change the size of the font)
Just to say that those widgets have baselines.

Yeah that's a bug -- setBaselineDistance() should set the margin on the baseline anchor if it's set. IIRC setBaselineDistance is only used by the direct solver though, in the android xml case we simply pass the baseline margin to connect()

So basically -- seems to be working as intended, and you shouldn't use that method and instead set the baseline margin in connect().

I asked @camaelon hopefully he has time.
but I suspect it just needs to be non 0 before the connect. i.e. you can have A.setBaselineDistance(1); B.setBaselineDistance(1); before the connect Than after set it to what ever comes from the WPF engine. (Same thing applies if you change the size of the font) Just to say that those widgets have baselines.

@jafu888  This can let test passed,thank you! I like this tips.

Just to say that those widgets have baselines.

@camaelon
Sorry, i don't know what you mean.
I found set baseline way is:
First i need set setBaselineDistance(1) before connect(),like @jafu888 say

Just to say that those widgets have baselines.

Then set  measure.measuredBaseline in ConstraintLayout.innerMeasure .
What you mean is just set widgetA.connect(BASELINE,widgetA,TOP, margin) ? But measure.measuredBaseline in ConstraintLayout.innerMeasure must set, i found it will let widget.BaselineDistance aways be 0 if i don't set.


Resolves #4633.

Fixes broken vagrant ssh commands.
Also renames the inner scope 'config' to 'c' so there is not a name collision with the outer scoped variable.

Hm, my CLA should be on file. I'll look into that.

/cc @thockin @brendandburns. an one of you suggest a reviewer?

I will try this in morning.
Can you tell me what version of vagrant you tested this against?  I was not seeing ssh problems earlier this week, so
I want to know if there is a drift somewhere.

@jameskyle - I am confused by this change.  Were you actually seeing errors when invoking:
$ vagrant ssh master

I had never received an error in the past, so I am confused on the issue that is being resolved.

Reread the issue, just remove the WARNING log output, then this will be good to go.
Thanks!

Will do, but to answer the other questions:
$ vagrant version
Installed Version: 1.7.2
Latest Version: 1.7.2

Warning removal incoming.

I'm curious about you not seeing an error with 'vagrant ssh' though. Was that accurate?

@jameskyle - I was not seeing an error.
$ uname -a
Linux localhost.localdomain 3.18.7-100.fc20.x86_64 #1 SMP Wed Feb 11 19:01:50 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
$ VBoxManage -version
4.3.22r98236
$ vagrant version
Installed Version: 1.7.2
Latest Version: 1.7.2

You're running an up-to-date version of Vagrant!

@jameskyle - you build a release before trying to up the boxes, right?

Oh, I have an idea. Do you set your KUBE_TEMP variable? If you do, then the temp directory and generated scripts persist and the error won't appear.

Yes, they're all built. the error comes from vagrants inability to find the specified provision script (which is deleted at the end of a kube-up.sh run). It doesn't just happen with 'vagrant ssh', but with any command as it's a syntax error. The provisioner is set to: ENV['KUBE_TEMP']/master-start.sh. But since KUBE_TEMP is only set in the $KUBE_PROVIDER/util.sh script and the master-start.sh is deleted after the kube-up.sh script runs, $KUBE_TEMP is not set.
$ vagrant ssh master
There are errors in the configuration of this machine. Please fix
the following errors and try again:

shell provisioner:
* `path` for shell provisioner does not exist on the host system: /master-start.sh

Running:
$ env | grep KUBE_TEMP

returns nothing.
Either way, I am good with this PR now, but stumped why I was not seeing it.
@smarterclayton - can you merge this now assuming his CLA with googlebot is fine.

I unfortunately can't check the CLA - would need one of the others to do that.

@jameskyle I haven't been able to find a CLA, can you see it at: https://cla.developers.google.com/clas

@vmarmol We've signed the CLA, but it was before they changed the CLA system. dbsmith, on #google-containers chan in freenode, looked into it and said he saw the cla in the 'old' system and was inquiring what it would take to move it to the 'new' system (if possible).
I'm waiting for word back from smith in the mean time.

Aaaah this is a corporate CLA, now I found it. Looks good :) thanks for letting me know! and thanks for double checking @smarterclayton. Merging.


richError cause empty

Hi
from time to time I got error on action-umami-report.
result is
Run boly38/action-umami-report@main
ERROR: Error: Could not get websites
Options: {}
Stacktrace:
Error: Error: Could not get websites
Options: {}
Stacktrace:

I expect to see the root cause of the error.
I think that for Could not get websites : the richError method doesn't work well in all cases.
We may try to JSONify it or simply remove toString ?
If I reproduce the way to get this error, then I will amend this issue.
thanks 🙏

I'm able to reproduce this error on removing internet connection

Same kind of test with the fix:
ERROR: Error: Could not get websites
Options: {}
Stacktrace:Error: Login failed
Options: {"server":"umami.myexemple.fr","username":"admin"}
Stacktrace:Error: getaddrinfo ENOTFOUND umami.myexemple.fr


⚠ GitLab Server has degraded performance

In 75c99f2, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 9330 ms

Resolved: GitLab Server performance has improved in b4fd3f6.


refactor(firebase_performance): create interface plugin that federates the main plugin

Description
Creates the Firebase Performance interface plugin including method channels, and have the main plugin use that.  No behavior changes -- the API of main plugin remains the same. Motivation of the change is to have the plugin follow the recommended federated plugin structure.
Specifically:

Removed attribute classes, so the http metric classes and trace classes no longer extends them, and the common methods are moved to http metric classes and trace classes. This simplifies the refactoring work a lot and makes the code less convoluted and error-prone.
Added e2e tests to the example app covering the entire API of the plugin. They provides high degree of confidence if they all pass.
Removed google-services.json and GoogleService-Info.plist from version control. They are used by the example app which should be generated by the user's app. It's never recommended by Firebase to check in them.

Note: the main plugin depends on the published version of the new interface plugin (0.0.1). So we will need to publish the interface plugin first ASAP to make sure the dependency works.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

@googlebot I consent.


Simplify (*Client).Dial handling of network type

This isn't a functional change, but it does leave (*Client).Dial cleaner and more readable IMHO.

Codecov Report

Merging #737 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
- Coverage   55.74%   55.69%   -0.06%
==========================================
  Files          39       39
  Lines       10722    10712      -10
==========================================
- Hits         5977     5966      -11
  Misses       3665     3665
- Partials     1080     1081       +1

Impacted Files
Coverage Δ

client.go
58.41% <100%> (-0.39%)
:arrow_down:

msg.go
78.71% <0%> (-0.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a34f54...160886d. Read the comment docs.


"Error" aocl program

Good morning people,
I come to try to clear a doubt with you, because you are the one who understands most of this matter.
I have 1 linux image on my fpga and I have the fpga connected to a screen via the vga output.
When I do:
aocl / dev / program conv.aocx
The screen is turned off and never turned on again.
Does anyone know why this happened, and what is the solution?
Thanks again to all.

it seems to be a BSP problem


[v3.6-branch] doc: services: device_mgmt: mcumgr: Correct license for tool

Corrects an incorrect license for a tool
Fixes #78927

This needs to go in as a backport of #78923 once it is merged.

The backport will not work because the whole table is different in main vs 3.x

This needs to go in as a backport of #78923 once it is merged.

The backport will not work because the whole table is different in main vs 3.x

It still needs to go into main first. If the automatic backport fails, a manual backport must be done.

This needs to go in as a backport of #78923 once it is merged.

The backport will not work because the whole table is different in main vs 3.x

It still needs to go into main first. If the automatic backport fails, a manual backport must be done.

Sure, the main one needs accepting first, but this is fully compliant with the process on https://github.com/zephyrproject-rtos/zephyr/wiki/Change-Control-and-Backports-to-stable-branches

Changes can be submitted to a stable and a released branch in 2 ways:
Directly submitted to the branch as a pull request with the Backport label

Sure, but not like this. This provides no traceability on where this change occurred in main.

Sure, but not like this. This provides no traceability on where this change occurred in main.

Nothing is required to go back to main that I've ever seen, it just needs to link to an issue. @nashif can you comment on what is needed?

As an example of a manually submitted PR against a release branch that maintains traceability to main:

https://github.com/zephyrproject-rtos/zephyr/pull/78860

Notice how both the PR description and the Git commit log (produced with git cherry-pick -x ... contains references to the corresponding commits to main.

As an example of a manually submitted PR against a release branch that maintains traceability to main:
* [[Backport v3.6-branch] Bluetooth: RFCOMM: check the validity of received frame #78860](https://github.com/zephyrproject-rtos/zephyr/pull/78860)

Notice how both the PR description and the Git commit log (produced with git cherry-pick -x ... contains references to the corresponding commits to main.

So top commit from v3.6-branch https://github.com/zephyrproject-rtos/zephyr/commit/2c2540ee463868dd0a5b2ebe8cfafeeecf1c74d7
    zephyr: Add zero-len check for utf8_trunc

    The function did not check if the provided string had a zero
    length before starting to truncate, which meant that last_byte_p
    could possible have pointed to the value before the string.

    Signed-off-by: Emil Gydesen<EMAIL_ADDRESS>
What here does any of that?

What here does any of that?

That commit was a result of having to modify the original commit as per the discussion in #78286 (which does contain a reference to the original PR introducing the change on main).

Exactly, so I reference the issue here, the issue itself references all 3 items, the backport here is done manually because the table in main has moved on - just as the PR you referenced there, so what is different here?


"erb-formatter not found by bundler" when using asdf

I have gem "erb-formater" in my Gemfile but I'm constantly getting a popup every time I save an ERB file saying bundler couldn't find erb-formatter. I believe this is because I'm using asdf as a version manager.
The shopify-lsp VS Code extension has "rubyLsp.rubyVersionManager": "asdf" to know where to look. Could we do something similar here?

Same issue.

+1 Same issue as well.

I made a "working for now" solution (I'm using rtx to version controll my ruby). Using the https://github.com/formulahendry/vscode-code-runner extension I can format it when I run code on .erb files by this vscode setting:
    "code-runner.executorMap": {
        "erb": "~/.local/share/rtx/installs/ruby/3.2.2/bin/erb-formatter $dir/$fileName --write"
    },
    "code-runner.enableAppInsights": false

+1 same issue

I am using rbenv, but still get the same issue.

Just when I thought I had found an ERB formatter.. 😂

I just merged #7 which fixes an issue for which it was erroneously showing that message whenever an ERB or HTML error was encountered, v0.3.0 will contain it. In case some of the issues you've seen were related to that.

It seems the plugin is using the system ruby regardless of what is set by the users environment, aka asdf. I had 3.0.6 installed by Arch and it was using that instead of the 3.3.0 my project was using from asdf. When I removed the system ruby the plugin complained that it couldn't find ruby even though any other terminal I used was working fine.


Fetching dependencies assumes python2

Specifically, see this line:
https://github.com/google/containerregistry/blob/60a61ec7eedfbda72be52dbfa287df225ca59d9d/def.bzl#L20
The httplib2 package ships two separate trees for python 2/3 compat, and we are exclusively using the python2 tree.  This means that if a user is trying to run this code under python 3, it will fail, since that tree is not compatible with python3.
I'm not sure the right answer here.  In an ideal world, Bazel would expose the python version to us, and we could include the right tree based on that.  Perhaps we could fix bazelbuild/rules_python#33 and then use pip to import these dependencies, rather than fetching the archives directly.
Alternatively, we could move from httplib2 to urllib (or the python 2/3 compatible version in six.moves.urllib), but it turns out that oauth2client also uses httplib2, so we'd still need it for transitive dependency resolution.
Until this is fixed, it is unlikely that python 3 users can use these rules.

Fun fact: According to https://github.com/google/oauth2client, "oauth2client is now deprecated."  And one of the reasons for deprecation is the dependency on httplib2!
The recommended replacement is google-auth.  I'd dig in and do the replacement, but there seems to be enough Google-specific sauce going on that somebody on the core team might want to take a look.

Do you know when python3 will be officially supported? We're stuck on a really old version of Bazel since the newer versions of Bazel run these rules with whatever you have your py_runtime set to.

@mytran actually that helped only for building the image, but it still failed while trying to push the image. Here's another workaround:
mkdir ~/path-for-python2-default
cd ~/path-for-python2-default
ln -s /usr/bin/python2 python

export PATH=~/path-for-python2-default:$PATH
bazel [...]

By putting that hacky path first in the PATH variable, bazel and all it's dependency will see the symling python which is python2.

I've run into that urlparse error, as well, when trying to build containers with bazel's rules_docker library. (See https://github.com/bazelbuild/rules_docker/issues/293)

https://github.com/google/containerregistry/pull/85 brought python 3 support and there is a PR for rules_docker (https://github.com/bazelbuild/rules_docker/pull/449), so can this be closed now?

@Globegitter I do not believe this should be closed yet, as the puller.par is still produced with the python2-only httplib2 mentioned in the body of the issue:
https://github.com/google/containerregistry/blob/2f1cfd3cbbf1895cc29d18af837d37df31046c8e/def.bzl#L20
Despite #85 and bazelbuild/rules_docker#449, users that attempt to run bazel with Python 3 will still be unable to pull images. For example, I get the following:
  File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/cache/bazel/_bazel_root/c0b43bcf2fdefc559ca549fb22bb7e37/external/puller/file/downloaded/__main__.py", line 30, in <module>
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 656, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 626, in _load_backward_compatible
  File "/cache/bazel/_bazel_root/c0b43bcf2fdefc559ca549fb22bb7e37/external/puller/file/downloaded/containerregistry/client/__init__.py", line 23, in <module>
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 656, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 626, in _load_backward_compatible
  File "/cache/bazel/_bazel_root/c0b43bcf2fdefc559ca549fb22bb7e37/external/puller/file/downloaded/containerregistry/client/docker_creds_.py", line 31, in <module>
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 951, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 894, in _find_spec
  File "<frozen importlib._bootstrap_external>", line 1157, in find_spec
  File "<frozen importlib._bootstrap_external>", line 1131, in _get_spec
  File "<frozen importlib._bootstrap_external>", line 1112, in _legacy_get_spec
  File "<frozen importlib._bootstrap>", line 441, in spec_from_loader
  File "<frozen importlib._bootstrap_external>", line 544, in spec_from_file_location
  File "/cache/bazel/_bazel_root/c0b43bcf2fdefc559ca549fb22bb7e37/external/puller/file/downloaded/httplib2/__init__.py", line 942
    print "connect: (%s, %s) ************" % (self.host, self.port)
                                         ^
SyntaxError: invalid syntax (/usr/bin/python /cache/bazel/_bazel_root/c0b43bcf2fdefc559ca549fb22bb7e37/external/puller/file/downloaded --directory /cache/bazel/_bazel_root/c0b43bcf2fdefc559ca549fb22bb7e37/external/ubuntu/image --name index.docker.io/library/ubuntu@sha256:30e04ddada6eb09c12330c7df72cad1573916c7100168c34076808169ff6d805) and referenced by '//image:image'


add get_count for tqueue

/azp run

/azp run

/azp run

Note: plans exist to extend this queue into a growable queue.

should list the devops item that tracks this effort.

Refers to: devdoc/tqueue_requirements.md:59 in ed43dc9. [](commit_id = ed43dc9774268ae5413f522d0c2438414b227586, deletion_comment = False)

/azp run

/azp run

/azp run


Investigate moving documentation to ReadTheDocs

Currently there is a make docs command that will generate a PDF. We need to investigate how to port the information to ReadTheDocs.
Also worth investigating is whether the Sphinx code that created autodocs from python docstrings will do the same for C++ docstrings/comments.

Also note that there seems to be some hard coded paths in the notebooks. For those to be rendered correctly in the documentation, we'll need to address that.
See the first cell here: https://github.com/lincc-frameworks/lephare-dev/blob/main/docs/notebooks/Building_list_of_onesources.ipynb

yes it is the same story as mentioned elsewhere, about these 2 basic env var that LePHARE has been depending on : LEPHAREDIR and LEPHAREWORK : the first one needs to point to the root directory, or in case of binary install, to the directory where needed files are located, and LEPHAREWORK points to an arbitrary place where intermediary and final outputs are located.

To make a navigable hierarchy programmatically, we need to use Exhale (https://exhale.readthedocs.io/en/latest/index.html) in combination with Breathe. The PR linked to this issue shows how they are used together.
Roughly speaking the documentation should start to look something like this:


Added handling for decoding failed

Improved error handling on api

Pull Request Test Coverage Report for Build 348

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.371%

Totals

Change from base Build 345:
0.0%

Covered Lines:
4105

Relevant Lines:
4131

💛  - Coveralls


[WIP] Adding support for redis6 ACL

Draft - Adding redis 6 ACL support

@Daniel-B-Smith I added a bunch of unit tests and addressed all of the code review comments.


Update to React 16

i'm looking to make new friends to try and pair program to port Crudl to Material-UI + Next.JS

It turns out our frontend team already has experience with ant.design and I didn't know about it, so we'll reconsider that.
PouchDB: Ok we will make the connector an external package.
Nextjs: i understand your point, but in django it's been such a misery that all features were added to the admin and that we always had to start from scratch when building user facing cruds. I don't want to fall in the same trap, and have a crud framework that can at least do SSR for list and detail pages that can be open to public. But if that doesn't work well
Thanks for the heads up, really useful !

About Next: I fully agree with what you're saying about Django. But with regards to CRUDL it comes down to Next vs React and I don't quite see the benefits here.

What do you mean Next vs. React ? Next depends on react and react-dom it's
fully React oriented.

I thought your idea is to use Next instead of React with CRUDL (I know that Next is based on React, but it still means switching the technology). Isn't that your proposal? Did I miss someting?

The proposal is rather changing from gulp to webpack, but instead of
removing gulpfile and adding webpack.config, just remove gulpfile, and have
this work by running command "next" because nextjs bundles a pretty cool
webpack config, with hot module reload, ssr, link prefetching ...

Now I see. We planned to use create-react-app in order to go with webpack.

Yes it's either create-react-app either nextjs, but you have to go through
quite some steps to have SSR:
https://medium.com/bucharestjs/upgrading-a-create-react-app-project-to-a-ssr-code-splitting-setup-9da57df2040a
So, if you're bundling crudlio as dependency in your project bundle you
have to go through this again. I'm open on CRA, Next, or other, but for me
SSR for me is a must, as is content prefechting which i don't know if CRA
supports, but Next does for sure with the Link component.
That said, I need to try CRA to compare, probably you want to try NextJS
too (it's pretty amazing how it gets you started in minutes !).

I already tried Next and I do like it. As said before, I'm just not convinced (yet) that it has benefits (e.g. compared to CRA). What I don't like about Next is the strict folder structure.
But I'm not so sure if we agree on why the switch to either CRA/Next is necessary.

You mention SSR and I don't quite get why this is useful with CRUDL!?
You say "bundling crudlio as a dependency". Why do you want to do that (because implementing CRUDL usually means to use the js from the CDN)?

Just a guess: Do you plan to use CRUDL within one of your projects where you need SSR (not because of CRUDL, but because of the rest of your code)?

I think SSR is a requirement because I want to reuse crudl stuff in public frontend, bots to index them properly, link sharing to work as expected by the internet, who's not evaluating javascript every time they fetch a page programatically after the user provided a link (even though personnaly I have a receipe for this with fetch+jsdom). For me not having SSR feels like only having ipv6 if that makes any sense ^^

When we make a new project, we will likely want to add more than crudl views, like new Forms, or Actions (that can be executed on a single object or multiple objects (from the list view)). In "another project", I want to be able to import the crud router, and redefine it for a particular model, add views, forms, actions to it. I expect the crud to provide a nice UI by default, allow tweaking variables such as table columns etc, but oalso to be able to completely override the crud object which means importing it, extending it, and registering it to crudl.

So really, i'm not looking for a new django admin app, but rather a new framework that provides with modern CRUD experience OOTB. Does that make sense to you ?

I see what you mean (at least I think so).
+1 for overridable, reusable.
I'd say go ahead with the fork and we'll see what we finally use with CRUDL. I still have my doubts about Next, but that doesn't mean switching is unlikely. In general, anything which makes CRUDL more customizable (and easier to maintain) is appreciated.