Test contribution guide

General information

OS: Linux / macOS / Windows
Hypervisor: KVM / Hyper-V / hyperkit
Did you run crc setup before starting it (Yes/No)? - NA

CRC version
# Put the output of `crc version`

I am on master branch
CRC status
# Put the output of `crc status`

NA
CRC config
# Put the output of `crc config view`

VA
Host Operating System
# Put the output of `cat /etc/os-release` in case of Linux
# put the output of `sw_vers` in case of Mac
# Put the output of `systeminfo` in case of Windows

NA
Steps to reproduce
No test contribution guide is available on master branch
Expected
There should be a test contribution guide on master branch that should touch like how to setup the test env (both unit and integration) and run it.
Actual
No doc i can see for integration test on master
Logs
You can start crc with crc start --log-level debug to collect logs.
Please consider posting this on http://gist.github.com/ and post the link in the issue.

@amitkrout https://github.com/code-ready/crc/blob/master/developing.adoc doesn't this help, if not can you please let us know which step didn't work or their is any missing info in this doc.

@praveenkumar My bad i was searching it in docs/ dir. Thanks for sharing the the link. I was looking thsi doc for setting up the crc test env and run a basic test scenario just to understand how it works with https://github.com/code-ready/clicumber.
I will open up new issue in case i found any difficulty to setup the test env or for any missing steps.


added service "pvinverter"

Adding support for the service "pvinverter".

This has been successfully tested with V0.3.1 on my production system. As far as I can tell it's enough to write a power value to one of the phases to work as expected.


image_picker issue with bitcode when building release for ios

Steps to reproduce
add image_picker plugin to project
run flutter build ios --release
Error Thrown
`Error output from Xcode build:
↳
** BUILD FAILED **
Xcode's output:
↳
Command CompileSwift failed with a nonzero exit code
Command CompileSwift failed with a nonzero exit code
/Users/mozesong/Developer/flutter/.pub-cache/hosted/pub.dartlang.org/image_picker-0.6.7+11/ios/Classes/FLTImagePickerPlugin.m:149:20: warning: 'UIAlertView' is deprecated:
first deprecated in iOS 9.0 - UIAlertView is deprecated. Use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead [-Wdeprecated-declarations]
[[[UIAlertView alloc] initWithTitle:@"Error"
^
In module 'UIKit' imported from /Users/mozesong/Documents/GitHub/Green-Hero-Apps-2.0/green_hero_vendor/ios/Pods/Target Support Files/image_picker/image_picker-prefix.pch:2:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.0.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIAlertView.h:27:12
: note: 'UIAlertView' has been explicitly marked deprecated here
@interface UIAlertView : UIView
^
1 warning generated.
/Users/mozesong/Developer/flutter/.pub-cache/hosted/pub.dartlang.org/image_picker-0.6.7+11/ios/Classes/FLTImagePickerPlugin.m:149:20: warning: 'UIAlertView' is deprecated:
first deprecated in iOS 9.0 - UIAlertView is deprecated. Use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead [-Wdeprecated-declarations]
[[[UIAlertView alloc] initWithTitle:@"Error"
^
In module 'UIKit' imported from /Users/mozesong/Documents/GitHub/Green-Hero-Apps-2.0/green_hero_vendor/ios/Pods/Target Support Files/image_picker/image_picker-prefix.pch:2:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.0.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIAlertView.h:27:12
: note: 'UIAlertView' has been explicitly marked deprecated here
@interface UIAlertView : UIView
^
1 warning generated.
ld: bitcode bundle could not be generated because '/Users/mozesong/Documents/GitHub/Green-Hero-Apps-2.0/green_hero_vendor/ios/Flutter/Flutter.framework/Flutter' was built
without full bitcode. All frameworks and dylibs for bitcode must be generated from Xcode Archive or Install build file
'/Users/mozesong/Documents/GitHub/Green-Hero-Apps-2.0/green_hero_vendor/ios/Flutter/Flutter.framework/Flutter' for architecture armv7
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Command CompileSwift failed with a nonzero exit code
Command CompileSwift failed with a nonzero exit code
note: Using new build system
note: Building targets in parallel
note: Planning build
note: Constructing build description
`
Flutter Doctor
`[✓] Flutter (Channel stable, 1.22.1, on Mac OS X 10.15.7 19H2, locale en-MY)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
[✓] Android Studio (version 3.4)
[!] VS Code (version 1.50.0)
✗ Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[✓] Connected device (1 available)
`
Note:
Works perfectly fine when building to ios simulator

@momoDragon
Tried the official image_picker plugin example on iPhone 6s and was able to build a release version without any issues.
dhs@Dhss-MacBook-Pro example % flutter build ios --release
Building io.flutter.plugins.imagePickerExample for device (ios-release)...
Warning: Missing build name (CFBundleShortVersionString).
Warning: Missing build number (CFBundleVersion).
Action Required: You must set a build name and number in the pubspec.yaml file version field before submitting to the App Store.
Found saved certificate choice "Apple Development: Darshan Kawar (HJWLFNL782)". To clear, use "flutter config".
Signing iOS app for device deployment using developer identity: "Apple Development: Darshan Kawar (HJWLFNL782)"
Running Xcode build...
 └─Compiling, linking and signing...                        11.1s
Xcode build done.                                           18.4s
Built /Users/dhs/Documents/NCFlutter/plugins/packages/image_picker/image_picker/example/build/ios/iphoneos/Runner.app.
dhs@Dhss-MacBook-Pro example %

flutter doctor -v
[✓] Flutter (Channel master, 1.23.0-8.0.pre.221, on Mac OS X 10.15.4 19E2269
    x86_64, locale en-IN)
    • Flutter version 1.23.0-8.0.pre.221 at
      /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 0d8d4f77aa (4 days ago), 2020-10-08 09:26:30 +0200
    • Engine revision 2eac514f26
    • Dart version 2.11.0 (build 2.11.0-186.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (5 available)
    • Darshan's iphone (mobile)           •
      21150b119064aecc249dfcfe05e259197461ce23 • ios            • iOS 14.0
    • iPhone SE (2nd generation) (mobile) • 6C85835D-FBFD-4AB3-8DE8-B4FAD35E5367
      • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-0 (simulator)
    • macOS (desktop)                     • macos
      • darwin-x64     • Mac OS X 10.15.4 19E2269 x86_64
    • Web Server (web)                    • web-server
      • web-javascript • Flutter Tools
    • Chrome (web)                        • chrome
      • web-javascript • Google Chrome 86.0.4240.75

• No issues found!

Can you provide a minimal complete code sample that shows the issue ? Also please try the official plugin example and see if it works for you or throw same error.
Thanks.

I am able to produce the same warning:
/Users/jason/Development/frameworks/flutter/.pub-cache/hosted/pub.dartlang.org/image_picker-0.6.7+10/ios/Classes/FLTImagePickerPlugin.m:149:20: 'UIAlertView' is deprecated: first deprecated in iOS 9.0 - UIAlertView is deprecated. Use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead
In order to do this, I modified the Podfile to target a minimum of iOS 9.0 using the following:
post_install do |installer|   installer.pods_project.targets.each do |target|     target.build_configurations.each do |config|       config.build_settings['ENABLE_BITCODE'] = 'NO'       config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '9.0'     end   end end
Note that this is only a warning and not an error.  Perhaps it is time to move to using UIAlertControllerStyleAlert?

I get the same issue :/

This is happening to me as well, doesn't work on both the emulator or an iphone 8 with all the latest updates... Don't close this issue!
`Launching lib/main.dart on iPhone 12 Pro Max in debug mode...
Running Xcode build...
Xcode build done.                                           125.0s
Failed to build iOS app
Error output from Xcode build:
↳
** BUILD FAILED **
Xcode's output:
↳
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/image_picker-0.6.7+17/ios/Classes/FLTImagePickerPlugin.m:149:20: warning: 'UIAlertView' is deprecated: first deprecated in iOS 9.0 - UIAlertView is deprecated. Use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead [-Wdeprecated-declarations]
[[[UIAlertView alloc] initWithTitle:NSLocalizedString(@"Error", nil)
^
In module 'UIKit' imported from /Users/jpetro/Documents/GitHub/test-flutter-app/ios/Pods/Target Support Files/image_picker/image_picker-prefix.pch:2:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.2.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIAlertView.h:27:12: note: 'UIAlertView' has been explicitly marked deprecated here
@interface UIAlertView : UIView
^
1 warning generated.
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+RoundedCorner.m:60:1: warning: category is implementing a method which will also be implemented by its primary class [-Wobjc-protocol-method-implementation]
- (void)addRoundedRectToPath:(CGRect)rect context:(CGContextRef)context ovalWidth:(CGFloat)ovalWidth ovalHeight:(CGFloat)ovalHeight {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+RoundedCorner.m:11:1: note: method 'addRoundedRectToPath:context:ovalWidth:ovalHeight:' declared here
- (void)addRoundedRectToPath:(CGRect)rect context:(CGContextRef)context ovalWidth:(CGFloat)ovalWidth ovalHeight:(CGFloat)ovalHeight;
^
1 warning generated.
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:96:99: warning: enum values with underlying type 'NSInteger' should not be used as format arguments; add an explicit cast to 'long' instead [-Wformat]
[NSException raise:NSInvalidArgumentException format:@"Unsupported content mode: %d", contentMode];
~~   ^~~~~~~~~~~
%ld  (long)
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:155:13: warning: enumeration values 'UIImageOrientationUp' and 'UIImageOrientationUpMirrored' not handled in switch [-Wswitch]
switch (self.imageOrientation) {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:155:13: note: add missing switch cases
switch (self.imageOrientation) {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:175:13: warning: 4 enumeration values not handled in switch: 'UIImageOrientationUp', 'UIImageOrientationDown', 'UIImageOrientationLeft'... [-Wswitch]
switch (self.imageOrientation) {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:175:13: note: add missing switch cases
switch (self.imageOrientation) {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:110:1: warning: category is implementing a method which will also be implemented by its primary class [-Wobjc-protocol-method-implementation]
- (UIImage *)resizedImage:(CGSize)newSize
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:12:1: note: method 'resizedImage:transform:drawTransposed:interpolationQuality:' declared here
- (UIImage *)resizedImage:(CGSize)newSize
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:152:1: warning: category is implementing a method which will also be implemented by its primary class [-Wobjc-protocol-method-implementation]
- (CGAffineTransform)transformForOrientation:(CGSize)newSize {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:16:1: note: method 'transformForOrientation:' declared here
- (CGAffineTransform)transformForOrientation:(CGSize)newSize;
^
5 warnings generated.
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Alpha.m:97:1: warning: category is implementing a method which will also be implemented by its primary class [-Wobjc-protocol-method-implementation]
- (CGImageRef)newBorderMask:(NSUInteger)borderSize size:(CGSize)size {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Alpha.m:10:1: note: method 'newBorderMask:size:' declared here
- (CGImageRef)newBorderMask:(NSUInteger)borderSize size:(CGSize)size;
^
1 warning generated.
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/FlutterNativeImagePlugin.m:77:19: warning: unused variable 'fileName' [-Wunused-variable]
NSString *fileName = [[fileArgument lastPathComponent] stringByDeletingPathExtension];
^
1 warning generated.
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/assets_audio_player-2.0.13+1/ios/Classes/Music.swift:612:25: warning: initialization of variable 'error' was never used; consider replacing with assignment to '_' or removing it
var error = item.error
^
_
../../../.pub-cache/hosted/pub.dartlang.org/flutter_widgets-0.1.12/lib/src/tagged_text/tagged_text.dart:295:36: Error: No named parameter with the name 'nullOk'.
MediaQuery.of(context, nullOk: true)?.textScaleFactor ??
^^^^^^
../../../flutter/packages/flutter/lib/src/widgets/media_query.dart:818:25: Context: Found this candidate, but the arguments don't match.
static MediaQueryData of(BuildContext context) {
^^
Command PhaseScriptExecution failed with a nonzero exit code
note: Using new build system
note: Building targets in parallel
note: Planning build
note: Constructing build description

Could not build the application for the simulator.
Error launching application on iPhone 12 Pro Max.`

This is happening to me as well, doesn't work on both the emulator or an iphone 8 with all the latest updates... Don't close this issue!
`Launching lib/main.dart on iPhone 12 Pro Max in debug mode...
Running Xcode build...
Xcode build done.                                           125.0s
Failed to build iOS app
Error output from Xcode build:
↳
** BUILD FAILED **
Xcode's output:
↳
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/image_picker-0.6.7+17/ios/Classes/FLTImagePickerPlugin.m:149:20: warning: 'UIAlertView' is deprecated: first deprecated in iOS 9.0 - UIAlertView is deprecated. Use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead [-Wdeprecated-declarations]
[[[UIAlertView alloc] initWithTitle:NSLocalizedString(@"Error", nil)
^
In module 'UIKit' imported from /Users/jpetro/Documents/GitHub/test-flutter-app/ios/Pods/Target Support Files/image_picker/image_picker-prefix.pch:2:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.2.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIAlertView.h:27:12: note: 'UIAlertView' has been explicitly marked deprecated here
@interface UIAlertView : UIView
^
1 warning generated.
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+RoundedCorner.m:60:1: warning: category is implementing a method which will also be implemented by its primary class [-Wobjc-protocol-method-implementation]
- (void)addRoundedRectToPath:(CGRect)rect context:(CGContextRef)context ovalWidth:(CGFloat)ovalWidth ovalHeight:(CGFloat)ovalHeight {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+RoundedCorner.m:11:1: note: method 'addRoundedRectToPath:context:ovalWidth:ovalHeight:' declared here
- (void)addRoundedRectToPath:(CGRect)rect context:(CGContextRef)context ovalWidth:(CGFloat)ovalWidth ovalHeight:(CGFloat)ovalHeight;
^
1 warning generated.
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:96:99: warning: enum values with underlying type 'NSInteger' should not be used as format arguments; add an explicit cast to 'long' instead [-Wformat]
[NSException raise:NSInvalidArgumentException format:@"Unsupported content mode: %d", contentMode];
~~   ^~~~~~~~~~~
%ld  (long)
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:155:13: warning: enumeration values 'UIImageOrientationUp' and 'UIImageOrientationUpMirrored' not handled in switch [-Wswitch]
switch (self.imageOrientation) {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:155:13: note: add missing switch cases
switch (self.imageOrientation) {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:175:13: warning: 4 enumeration values not handled in switch: 'UIImageOrientationUp', 'UIImageOrientationDown', 'UIImageOrientationLeft'... [-Wswitch]
switch (self.imageOrientation) {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:175:13: note: add missing switch cases
switch (self.imageOrientation) {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:110:1: warning: category is implementing a method which will also be implemented by its primary class [-Wobjc-protocol-method-implementation]
- (UIImage *)resizedImage:(CGSize)newSize
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:12:1: note: method 'resizedImage:transform:drawTransposed:interpolationQuality:' declared here
- (UIImage *)resizedImage:(CGSize)newSize
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:152:1: warning: category is implementing a method which will also be implemented by its primary class [-Wobjc-protocol-method-implementation]
- (CGAffineTransform)transformForOrientation:(CGSize)newSize {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Resize.m:16:1: note: method 'transformForOrientation:' declared here
- (CGAffineTransform)transformForOrientation:(CGSize)newSize;
^
5 warnings generated.
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Alpha.m:97:1: warning: category is implementing a method which will also be implemented by its primary class [-Wobjc-protocol-method-implementation]
- (CGImageRef)newBorderMask:(NSUInteger)borderSize size:(CGSize)size {
^
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/UIImage+Alpha.m:10:1: note: method 'newBorderMask:size:' declared here
- (CGImageRef)newBorderMask:(NSUInteger)borderSize size:(CGSize)size;
^
1 warning generated.
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/flutter_native_image-0.0.5+3/ios/Classes/FlutterNativeImagePlugin.m:77:19: warning: unused variable 'fileName' [-Wunused-variable]
NSString *fileName = [[fileArgument lastPathComponent] stringByDeletingPathExtension];
^
1 warning generated.
/Users/jpetro/.pub-cache/hosted/pub.dartlang.org/assets_audio_player-2.0.13+1/ios/Classes/Music.swift:612:25: warning: initialization of variable 'error' was never used; consider replacing with assignment to '_' or removing it
var error = item.error
^
_
../../../.pub-cache/hosted/pub.dartlang.org/flutter_widgets-0.1.12/lib/src/tagged_text/tagged_text.dart:295:36: Error: No named parameter with the name 'nullOk'.
MediaQuery.of(context, nullOk: true)?.textScaleFactor ??
^^^^^^
../../../flutter/packages/flutter/lib/src/widgets/media_query.dart:818:25: Context: Found this candidate, but the arguments don't match.
static MediaQueryData of(BuildContext context) {
^^
Command PhaseScriptExecution failed with a nonzero exit code
note: Using new build system
note: Building targets in parallel
note: Planning build
note: Constructing build description

Could not build the application for the simulator.
Error launching application on iPhone 12 Pro Max.`

I am getting the same exact errors as jpetro, please reopen this issue

I am getting the same exact errors as jpetro, please reopen this issue

Same exact issue here, please reopen.

Same exact issue here, please reopen.

The same issue occurs for me!

The same issue occurs for me!

I fixed this on my build:

I uncommenting this line in ios/Podfile and updated to '10.0':
`platform :ios, '10.0'

Lots of warnings but one error indicated an issue with Firebase.  Running this command fixed that error and allowed the build to work:
pod update Firebase/Firestore

I fixed this on my build:

I uncommenting this line in ios/Podfile and updated to '10.0':
`platform :ios, '10.0'

Lots of warnings but one error indicated an issue with Firebase.  Running this command fixed that error and allowed the build to work:
pod update Firebase/Firestore


user topics: Rename visibility_policy_inherit -> inherit.

This makes our code less verbose, and makes this name consistent with the names of other visibility policies (which do not have the VISIBILITY_POLICY prefix).
This change does not change the database schema.
Tested manually that topic muting works like before from the UI.

@timabbott could you take a look?

I think the JS changes are great -- there's no reason to write .visibility_policy.VISIBILITY_POLICY_INHERIT. But on the backend, I think it'd be better to prefix all the values -- e.g. VISIBILITY_POLICY_MUTED; we've been moving to that pattern with the fields in Realm and UserProfile, and given that we expect UserTopic to over time develop more fields (which might have an INHERIT concept that is unrelated and may need a different numeric value); and usually there we're doing comparisons like visibility_policy == UserTopic.VISIBILITY_POLICY_INHERIT, which doesn't look unreasonable.
Thoughts?

For the backend, then maybe it would be better to have a class like so?
class VisibilityPolicies():
    INHERIT = 1
    UNMUTED = 2
    FOLLOWED = 3

class UserTopic():
    # ...

So that we get better auto-complete etc?
(This is similar to the class for Notification triggers, for example)

I started a topic for this : https://chat.zulip.org/#narrow/stream/3-backend/topic/models.2Epy.20.3A.20settings.20constants

I've split the frontend and backend changes, and push a revision using the Django choices feature.

I've separted the frontend and backend changes into different commits, and pushed a revision using the Django choices feature.

Rebased the PR, and addressed the above comments.

@timabbott Adding the "integration review" label, since you've been reviewing this PR and your feedback has been addressed.

I think this lgtm pending the naming question I just posted in https://chat.zulip.org/#narrow/stream/3-backend/topic/models.2Epy.20.3A.20settings.20constants/near/1523695.

Merged, thanks @abhijeetbodas2001!


SDK phase 1: Create swap SDK package in web repo

Overview
Our goal is to perform swaps using our exchange API (aka "dogfooding"), a process which involves relocating api calls from react and into the exchange API project. This task involves multiple steps, the first of which is to place all of the code into a single gathering point, the "SDK" directory in @shapshift/web.
References and additional details
The code moved into packages/exchange-sdk should be:

All shared types, enums, constants
Functions required to get, update, execute swaps
Future API endpoints that will eventually be relocated to the exchange API

Acceptance Criteria

Web consumes packages/exchange-sdk as though it's an external package
No api calls to unchained are made from the client - all of this should be abstracted by the sdk package
SDK calls API functions as though they are http methods

There's some gotchas relating to asset filtering being coupled to redux - be pragmatic.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
3 days

current plan:

implement centralized class for swaps
split up api.ts into types, constants and utils
remove redux from swapper completely
move swapper to package


Making UI cfd actions more understandable

At the moment actions that can be taken on a cfd are somewhat hard to understand for users.
Especially the difference between settle (non-collaborative close) and close (collaboratively close) are hard to understand.
Proposed changes:

Tooltips (or other form of textual description that can be triggered) for all actions that describe what an action does.
Pop-up for settle (non-collaborative close action) that asks the user if the user is sure that they want to go on chain, and potentially display

IMHO these should be text buttons - relying on iconography for such a fundamental thing puts unnecessary burden on the user.

also @da-kami : are you sure that settle is the term non-collaborative settlement?
Last Friday, when you rolled out actions on the taker side, you connected it to my collaborative one....
https://github.com/comit-network/hermes/blob/master/daemon/src/routes_taker.rs#L120

Closing this for now as the taker UI will be deprecated soon and there will be more ui improvements needed for the new UI


travis-ci: add production test suit to PY3 env testing

Add production testing to .travis.yml file for PY3 env

Fixes #1710

Automated message from Dropbox CLA bot
@kkanahin, it looks like you've already signed the Dropbox CLA. Thanks!

@kkanahin thanks for working on this!  It looks like you've still got some linter failures (missing newlines at end-of-file) to clean up.  Also, to what extent have you confirmed that the production system is actually using Python 3?

Regarding environment yes I'm sure cause script creates environment based on python version which we use to launch script.
According production installation test logs there is no python2 using and virtual environment was created with python3.
I will fix file with no new line in the end.

Merged, thanks @kkanahin!  One note: I reordered the commits to add the commits that create the Python 3 virtualenv before the commit that adds the .travis.yml changes.

pip install flup=1.0.2 fails on a python3 virtualenv.
So I think the code for creating a python3 virtualenv is not being run.

I added
import subprocess
subprocess.check_call(["which", "python"])

to the beginning of scripts/lib/create-production-virtualenv and let it run on travis (build link).
The output was /usr/bin/python, which means my suspicion was correct. A python2 production virtualenv is being created instead of a python3 virtualenv.

Seems so, let me fix it

Let's try to use  https://pypi.python.org/pypi/flup/1.0.3.dev20151210 for this lib

Sure, feel free to try changing that in requirements.txt.
Would we still be using flup once we do https://github.com/zulip/zulip/issues/1121?  It's possible we should instead direct effort towards that upgrade.

I've changed requirements for PY3 prod, but we need to change production deployment to use virtualenv cause it use system python 2 in his installation and change it  to system python 3 impossible. Also there are to many switching between users which not save environment through installation process.


PAPP-24690: De-certifying and releasing as a community app

PAPP-24690: De-certifying and releasing as a community app
Note: Static job failing for python version failure but as previously discussed, we will not add that in expected failure so the contributor can see the failure and update python version in future when raising PR

Note: Static job failing for python version failure but as previously discussed, we will not add that in expected failure so the contributor can see the failure and update python version in future when raising PR


Invisiable diff signs (+/-) in high contrast on Windows

Gogs version (or commit ref): <IP_ADDRESS>1
Git version: 1.7.1
Operating system:  Windows 10.0 build 14903
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
When using Windows High Contrast mode the '+' and '-' icons in diffs are not being shown. The most probable cause of this issue is that most major browsers working with the windows high contrast mode hide background images. The easiest solution is to either replace the images with actual text or using a font to display the icons. I know this is a very specific problem but still hope that it can be tackled.

Hi, I can't understand this without screenshots.

Here is a screenshot of the diff window.

The problem can most probably be found and fixed in the file gogs.css. After taking a closer look i noticed that you are not using '+/-' to show which lines are changed. Instead, you are using two different colors to display these lines. However, in windows high contrast mode these colors are removed. I can't really think of a solution except for replacing the colors with '+' and '-'.
# gogs/public/css/gogs.css
1981| .repository .diff-file-box .code-diff tbody tr.del-code td.add-code {
1982|   background-color: #eaffea !important;
1983|   border-color: #c1e9c1 !important;
1984| }
1985| .repository .diff-file-box .code-diff tbody tr.del-code td.add-code pre {
1986|   background-color: #eaffea !important;
1987|   border-color: #c1e9c1 !important;
1988| }
1989| .repository .diff-file-box .code-diff tbody tr.del-code td,
1990| .repository .diff-file-box .code-diff tbody tr.del-code pre {
1991|   background-color: #ffecec !important;
1992|   border-color: #f1c0c0 !important;
1993| }
1994| .repository .diff-file-box .code-diff tbody tr.del-code td.halfwidth {
1995|   width: 50%;
1996| }
1997| .repository .diff-file-box .code-diff tbody tr.add-code td,
1998| .repository .diff-file-box .code-diff tbody tr.add-code pre {
1999|   background-color: #eaffea !important;
2000|   border-color: #c1e9c1 !important;
2001| }
2002| .repository .diff-file-box .code-diff tbody tr.add-code td.halfwidth {
2003|   width: 50%;
2004| }
2005| .repository .diff-file-box .code-diff tbody tr .removed-code {
2006|   background-color: #ff9999;
2007| }
2008| .repository .diff-file-box .code-diff tbody tr .added-code {
2009|   background-color: #99ff99;
2010| }

Good point.
cc @andreynering

I don't think we could fix this with CSS (but I may be wrong).
@Unknwon Re-adding the + and - signs would be very simple, so let's go to this solution? I just noticed GitHub also shows it.

@andreynering agree.
I remember we do have signs (checking with disabling HighlightJS)

Committed wrong file in first mention commit... 0.0

Patch has pushed to fix this issue, please test on develop branch or https://try.gogs.io/gogs/gogs/commit/2625193a4820a89355ca1b8b7c910f0f4243baab.

Thumbs up for the quick response and solution. Seems to be working the way I would expect it to.


Upgrade parser to version <IP_ADDRESS>

Libraries.io has found that there is a newer version of parser that this project depends on.
More info: https://libraries.io/rubygems/parser/<IP_ADDRESS>

Dup #2073?


AutoScaling: update smoke test and consider db upgrade from a fork

Description
This PR fixes the smoke test as per Daan's comments (see https://github.com/apache/cloudstack/pull/6571#pullrequestreview-1204572347).
This PR also fixes an issue that "supports_vm_autoscaling" needs to be updated only if all network offerings has supports_vm_autoscaling = 0 .
(this might be an issue if upgrade from a fork to community version)

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4862

@blueorangutan test

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4874

@blueorangutan package

Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4893

Trillian test result (tid-5489)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47861 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6977-t5489-kvm-centos7.zip
Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
3643.26
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.07
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
74.06
test_kubernetes_clusters.py

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4945

@blueorangutan test rocky8 kvm-rocky8

@DaanHoogland a Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

Trillian test result (tid-5520)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 383 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6977-t5520-kvm-rocky8.zip
Smoke tests completed. 2 look OK, 0 have errors, 79 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

all_test_deploy_vm
Skipped
---
test_deploy_vm.py

all_test_escalations_templates
Skipped
---
test_escalations_templates.py

all_test_vm_ha
Skipped
---
test_vm_ha.py

all_test_vm_sync
Skipped
---
test_vm_sync.py

all_test_accounts
Skipped
---
test_accounts.py

all_test_router_dnsservice
Skipped
---
test_router_dnsservice.py

all_test_affinity_groups
Skipped
---
test_affinity_groups.py

all_test_projects
Skipped
---
test_projects.py

all_test_affinity_groups_projects
Skipped
---
test_affinity_groups_projects.py

all_test_async_job
Skipped
---
test_async_job.py

all_test_routers
Skipped
---
test_routers.py

all_test_certauthority_root
Skipped
---
test_certauthority_root.py

all_test_over_provisioning
Skipped
---
test_over_provisioning.py

all_test_create_list_domain_account_project
Skipped
---
test_create_list_domain_account_project.py

all_test_public_ip_range
Skipped
---
test_public_ip_range.py

all_test_deploy_vgpu_enabled_vm
Skipped
---
test_deploy_vgpu_enabled_vm.py

all_test_pvlan
Skipped
---
test_pvlan.py

all_test_deploy_virtio_scsi_vm
Skipped
---
test_deploy_virtio_scsi_vm.py

all_test_routers_network_ops
Skipped
---
test_routers_network_ops.py

all_test_deploy_vm_iso
Skipped
---
test_deploy_vm_iso.py

all_test_regions
Skipped
---
test_regions.py

all_test_deploy_vm_root_resize
Skipped
---
test_deploy_vm_root_resize.py

all_test_reset_vm_on_reboot
Skipped
---
test_reset_vm_on_reboot.py

all_test_deploy_vm_with_userdata
Skipped
---
test_deploy_vm_with_userdata.py

all_test_privategw_acl
Skipped
---
test_privategw_acl.py

all_test_deploy_vms_with_varied_deploymentplanners
Skipped
---
test_deploy_vms_with_varied_deploymentplanners.py

all_test_diagnostics
Skipped
---
test_diagnostics.py

all_test_scale_vm
Skipped
---
test_scale_vm.py

all_test_direct_download
Skipped
---
test_direct_download.py

all_test_secondary_storage
Skipped
---
test_secondary_storage.py

all_test_disk_offerings
Skipped
---
test_disk_offerings.py

all_test_resource_accounting
Skipped
---
test_resource_accounting.py

all_test_domain_disk_offerings
Skipped
---
test_domain_disk_offerings.py

all_test_resource_detail
Skipped
---
test_resource_detail.py

all_test_domain_network_offerings
Skipped
---
test_domain_network_offerings.py

all_test_router_dhcphosts
Skipped
---
test_router_dhcphosts.py

all_test_domain_service_offerings
Skipped
---
test_domain_service_offerings.py

all_test_service_offerings
Skipped
---
test_service_offerings.py

all_test_domain_vpc_offerings
Skipped
---
test_domain_vpc_offerings.py

all_test_snapshots
Skipped
---
test_snapshots.py

all_test_global_settings
Skipped
---
test_global_settings.py

all_test_templates
Skipped
---
test_templates.py

all_test_guest_vlan_range
Skipped
---
test_guest_vlan_range.py

all_test_host_annotations
Skipped
---
test_host_annotations.py

all_test_usage
Skipped
---
test_usage.py

all_test_usage_events
Skipped
---
test_usage_events.py

all_test_hostha_simulator
Skipped
---
test_hostha_simulator.py

all_test_internal_lb
Skipped
---
test_internal_lb.py

all_test_iso
Skipped
---
test_iso.py

all_test_vm_snapshots
Skipped
---
test_vm_snapshots.py

all_test_list_ids_parameter
Skipped
---
test_list_ids_parameter.py

all_test_loadbalance
Skipped
---
test_loadbalance.py

all_test_login
Skipped
---
test_login.py

all_test_metrics_api
Skipped
---
test_metrics_api.py

all_test_migration
Skipped
---
test_migration.py

all_test_vm_deployment_planner
Skipped
---
test_vm_deployment_planner.py

all_test_multipleips_per_nic
Skipped
---
test_multipleips_per_nic.py

all_test_router_dns
Skipped
---
test_router_dns.py

all_test_nested_virtualization
Skipped
---
test_nested_virtualization.py

all_test_network
Skipped
---
test_network.py

all_test_network_acl
Skipped
---
test_network_acl.py

all_test_nic
Skipped
---
test_nic.py

all_test_vm_life_cycle
Skipped
---
test_vm_life_cycle.py

all_test_nic_adapter_type
Skipped
---
test_nic_adapter_type.py

all_test_volumes
Skipped
---
test_volumes.py

all_test_non_contigiousvlan
Skipped
---
test_non_contigiousvlan.py

all_test_vpc_redundant
Skipped
---
test_vpc_redundant.py

all_test_outofbandmanagement
Skipped
---
test_outofbandmanagement.py

all_test_outofbandmanagement_nestedplugin
Skipped
---
test_outofbandmanagement_nestedplugin.py

all_test_password_server
Skipped
---
test_password_server.py

all_test_vpc_router_nics
Skipped
---
test_vpc_router_nics.py

all_test_portable_publicip
Skipped
---
test_portable_publicip.py

all_test_vpc_vpn
Skipped
---
test_vpc_vpn.py

all_test_portforwardingrules
Skipped
---
test_portforwardingrules.py

all_test_primary_storage
Skipped
---
test_primary_storage.py

all_test_ssvm
Skipped
---
test_ssvm.py

all_test_routers_iptables_default_policy
Skipped
---
test_routers_iptables_default_policy.py

all_test_host_maintenance
Skipped
---
test_host_maintenance.py

all_test_hostha_kvm
Skipped
---
test_hostha_kvm.py

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5032

@blueorangutan test

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-5583)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42346 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6977-t5583-kvm-centos7.zip
Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
568.46
test_kubernetes_clusters.py


Write first UI element

What it says on the tin

Which one is first? The popup? Or the big boy one in the devtools? Or what

Do the one that you want and rename this issue.


fix: moved code-prettify from app.html to project component

@samtstern
This seems to do it. https://github.com/firebase/firebaseopensource.com/issues/155

Moved code-prettify from app.html to project component

So everytime the project component(page) gets loaded, this script also runs. And it doesn't get loaded on all the other pages, so there's even some performance benefit to this approach.

Also seems to work much more reliably now.

@lupas oh nice!


Aug 4 - Dive into Azure Blockchain Service

Event Information

Category
Details

Reactor Topic
Emerging Technologies

Monthly Topic (if applicable)
Powerful APIs and Power Platform

Weekly Topic (if applicable)
Blockchain

Stream Date
Aug 4, 2020

Stream Time
4PM PT

Stream Duration
60 min

Title
Dive into Azure Blockchain Service

Description
Let’s take a deeper look at Azure Blockchain Service, a fully managed ledger service that helps users grow and operate blockchain networks at scale. In this session, we'll use the Azure Blockchain Service API to build and manage blockchain networks and deploy our smart contracts. Next, we'll explore how to capture contract and transaction data in the cloud with the Blockchain Data Manager. Along the way, we'll use VS Code to code, test, and deploy Ethereum smart contracts.

A basic knowledge of blockchain foundations will be helpful. If you plan to follow along with the session, you'll also need an Azure account.

Speaker
@meaghanlewis

Moderator
TBD

Event ID
7845

Additional Resources:

Event Checklist
10 Weeks Prior

[X] Reactor Content Team (RCT) or Speaker opens a new issue for an upcoming stream filling in the Event Information table. Both RCT and Speaker are marked as assignees.
[X] RCT and Speaker discuss details of the event in the comments of this issue. RCT adds a confirmed-event label and global-twitch-event tag to the issue and adds event to the Global Live Streams project. Issue will appear in the Upcoming Streams column
[X] Speaker adds a ready-for-marketing-edit label so the RCT can review title and description

8 Weeks Prior

[X] RCT does a review of title and description and removes the ready-for-marketing-edit label
[X] RCT moves the issue to the Ready for SharePoint column
[x] RCT informs the Reactor Marketing Team of the new event information
[x] RCT provides speaker with assets (e.g. slides, overlays) and the survey data for the event
[x] RCT moves the issue to the MONTH Streams Prep column (according to the month it will be streamed in)

2 Weeks Prior (Done in /microsoft/Reactors)

[ ] Speaker opens a PR with the new content for the stream on the customer-facing Reactor repository and adds the content-development and global-twitch-event tag to the PR.
[ ] Speaker adds to the same PR a modification to the Streaming README to include their stream information.
[ ] Speaker adds the RCT assigned to the issue as the reviewer when it is ready for review/merge
[ ] RCT reviews, approves, and merges the changes

1 Week Prior

[ ] Speaker and Moderator test setup for streaming (instructions coming soon)
[ ] RCT checks in with the speaker and moves the issue to the Ready to Stream column

During and After Stream

[ ] Speaker and Moderator run the stream
[x] RCT submits recording to be uploaded to the Reactor YouTube and to be made available on LearnTV
[x] RCT moves issue to the Stream Complete column

Session completed and recording uploaded to YouTube: https://youtu.be/wEAMjU3K9-U. Closing issue.


Responsive border color

When you set a responsive border prop, you have to set the "borderColor" twice, even if it's the same colour. For example:
<Column
borderRight={["0", "1px solid"]}
borderColor={["grey.0", "grey.0"]}
width={[1, 1 / 2]}

To reproduce try something like:
<Column
borderRight={["0", "1px solid"]}
borderColor="white"
width={[1, 1 / 2]}

Closing in favor of #1058


Nvim_lsp showing unknown source

My cmp config

Cmp status

If your want my full configuration
https://www.github.com/Iamafnan/my-nvimrc

Sorry. nvim_lsp is lazy source (lazy for InsertEnter). So it is no problem.

My autocompletion is not working too


Slow video connection to Win2016

Ive tried to use last build of freerdp on linux. And Ive got the problem.
When I connect to Win2016 I can`t watch any action content.
It looks like slide show with broken pixels.
Connection to win2012 works good and I can watch even videos without problem.
build from 48163a27dbbaa73c149c7df2c1a3e9afb3d3c34a works with win2016 good
2.0.0-rc0 and last master have this problem
my build options
cmake -C /var/tmp/portage/kraftway/freerdp-<IP_ADDRESS>7250000/work/freerdp-<IP_ADDRESS>7250000_build/gentoo_common_config.cmake -G Unix Ma
kefiles -DCMAKE_INSTALL_PREFIX=/usr -DWITH_ALSA=yes -DWITH_CLIENT=yes -DWITH_CUPS=yes -DWITH_DEBUG_ALL=no -DWITH_MANPAGES=no -DWITH_F
FMPEG=yes -DWITH_LIBAVCODEC=yes -DWITH_GSTREAMER_1_0=no -DWITH_JPEG=yes -DWITH_NEON=no -DWITH_PULSE=yes -DWITH_SERVER=no -DWITH_PCSC=
yes -DWITH_LIBSYSTEMD=no -DWITH_SSE2=yes -DCHANNEL_URBDRC=yes -DWITH_X11=yes -DWITH_XINERAMA=yes -DWITH_XV=yes -DBUILD_TESTING=no -DW
ITH_WAYLAND=no -DWITH_OPENH264=no -DWITH_X264=no
my connect options
xfreerdp /cert-ignore /f /bpp:16 -sec-nla /sound:sys:alsa /microphone:sys:alsa /rfx  /gfx /u:user /p:pass /v:IP

This is issue in win2016 instead of FreeRDP. Win2016 seems no longer support avc420 for unknown reason, regardless how you configure the group policy.
So for this guy, use /gfx:AVC444 instead.

I don`t think so.
The build of xfreerdp from the end of May still works good with /gfx:RDP and win2016
New builds ALL have the same problem

and  /gfx:AVC444 or /gfx:AVC420 did not fix the problem

looks like the problem is in 88fa1312480cc1c6061d06bcb2a077af8cd90e4e commit
git log says:

commit 88fa1312480cc1c6061d06bcb2a077af8cd90e4e
Author: Armin Novak<EMAIL_ADDRESS>Date:   Wed Jul 19 11:36:28 2017 +0200

    Fixed variable assignment.

commit<PHONE_NUMBER>562b5120c6591bded6f74ca125c1ca
Merge: f0fb219 3893058
Author: Bernhard Miklautz<EMAIL_ADDRESS>Date:   Wed Jul 19 11:24:57 2017 +0200

    Merge pull request #4047 from akallabeth/win_gfx_fix

    Always use software GFX for windows client.

4137282491562b5120c6591bded6f74ca125c1ca works good
88fa1312480cc1c6061d06bcb2a077af8cd90e4e already broaken
but reverting this patch in last builds brakes the h264 context
[14:53:30:172] [20139:20140] [ERROR][com.freerdp.core.codecs] - Failed to create h264 codec context
[14:53:30:172] [20139:20140] [ERROR][com.freerdp.gdi] - failed to initialize gdi
[14:53:30:172] [20139:20140] [ERROR][com.freerdp.core] - freerdp_post_connect failed
[14:53:30:172] [20139:20140] [ERROR][com.freerdp.core] - freerdp_set_last_error ERRCONNECT_POST_CONNECT_FAILED [0x00020003]
[14:53:30:172] [20139:20140] [ERROR][com.freerdp.client.x11] - Freerdp connect error exit status 1

I will test latest master these days. I'm still using version of Jun 10

@maddeer The referenced commit only affects connections with AVC420/AVC444, the command line you provided uses RFX/GFX codec.
Could you post the output of xfreerdp /buildconfig your configuration options look weird (does CMake allow useing yes/no?)

This is FreeRDP version 2.0.0-dev (git n/a)
Build configuration: BUILD_TESTING=no BUILTIN_CHANNELS=ON HAVE_AIO_H=1 HAVE_EVENTFD_H=1 HAVE_EXECINFO_H=1 HAVE_FCNTL_H=1 HAVE_INTTYPES_H=1 HAVE_MATH_C99_LONG_DOUBLE=1 HAVE_POLL_H=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK=ON HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL= HAVE_SYSLOG_H=1 HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H=1 HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_TIMERFD_H=1 HAVE_TM_GMTOFF=1 HAVE_UNISTD_H=1 HAVE_XI_TOUCH_CLASS=1 WITH_ALSA=yes WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLIENT=yes WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CUPS=yes WITH_DEBUG_ALL=no WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DIRECTFB=OFF WITH_EVENTFD_READ_WRITE=1 WITH_FFMPEG=yes WITH_GFX_H264=ON WITH_GPROF=OFF WITH_GSM=OFF WITH_GSTREAMER_0_10=OFF WITH_GSTREAMER_1_0=no WITH_IPP=OFF WITH_JPEG=yes WITH_KRB5=OFF WITH_LIBAVCODEC=yes WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=no WITH_MACAUDIO=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=no WITH_MBEDTLS=OFF WITH_NEON=no WITH_OPENH264=no WITH_OPENSLES=OFF WITH_OPENSSL=ON WITH_OSS=ON WITH_PCSC=yes WITH_PROFILER=OFF WITH_PULSE=yes WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_LEAK=OFF WITH_SANITIZE_LEAK_AVAILABLE=1 WITH_SERVER=no WITH_SERVER_INTERFACE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SSE2=yes WITH_THIRD_PARTY=OFF WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_WAYLAND=no WITH_X11=yes WITH_X264=no WITH_XCURSOR=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=yes WITH_XKBFILE=ON WITH_XRENDER=ON WITH_XSHM=ON WITH_XV=yes WITH_ZLIB=ON
Build type:          Gentoo
CFLAGS:              -Os -mtune=i686 -march=i686 -pipe  -march=i686 -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -g -msse2
Compiler:            GNU, 4.9.3
Target architecture: x86

the cmake options made by gentoo ebuild and cmake.eclass

@maddeer Only difference in GFX channel I can spot is that with the newer version the more recent capability sets are announced. Could you try if the issue persists if you edit channels/rdpgfx/client/rdpgfx_main.c:127 and add pdu.capsSetCount = 2;?

@akallabeth As my understanding, we have another difference:
Originally, if we don't have AVC444, the cap sets will not include version10 with AVC disabled flag.
Now, if we don't have AVC444 in the commandline argument, the capset will have version103 with AVC disabled flag.
Not sure whether it is expected, and whether it impacts the codec chosen by windows server.
@maddeer
I would recommend to have /log-level:DEBUG and grep RecvWireToSurface1Pdu to check what codec is used.

@realjiangms
root@ktl-188[16:39]:~/KTL/scripts# grep RecvWireToSurface1Pdu ~/error2
[16:36:14:857] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 0 top: 1024 right: 64 bottom: 1080 bitmapDataLength: 35
[16:36:14:993] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 0 top: 1024 right: 64 bottom: 1080 bitmapDataLength: 35
[16:36:14:070] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 0 top: 1024 right: 64 bottom: 1080 bitmapDataLength: 35
[16:36:14:141] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 704 top: 512 right: 768 bottom: 576 bitmapDataLength: 134
[16:36:14:141] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 832 top: 512 right: 1216 bottom: 640 bitmapDataLength: 6176
[16:36:14:145] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 768 top: 576 right: 832 bottom: 640 bitmapDataLength: 1674
[16:36:14:145] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 0 top: 1024 right: 64 bottom: 1080 bitmapDataLength: 35
[16:36:15:204] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 968 top: 542 right: 969 bottom: 543 bitmapDataLength: 32
[16:36:15:204] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 953 top: 543 right: 961 bottom: 551 bitmapDataLength: 235
[16:36:15:204] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 963 top: 543 right: 972 bottom: 552 bitmapDataLength: 72
[16:36:15:206] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 943 top: 539 right: 951 bottom: 549 bitmapDataLength: 283
[16:36:15:206] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 942 top: 543 right: 943 bottom: 549 bitmapDataLength: 47
[16:36:15:206] [28160:28175] [DEBUG][com.freerdp.channels.rdpgfx.client] - RecvWireToSurface1Pdu: surfaceId: 0 codecId: RDPGFX_CODECI
D_CLEARCODEC (0x0008) pixelFormat: 0x20 destRect: left: 953 top: 543 right: 961 bottom: 551 bitmapDataLength: 67
@akallabeth I don't have time right now to build. I'll try it some time later.

@akallabeth
maybe I did some thing wrong but for the commit 1648deb435ad52206f7aa2afe4b4dff71d9329bc
your patch did not gave me to connect
[19:46:01:398] [28720:28721] [INFO][com.freerdp.core] - ERRINFO_GRAPHICS_SUBSYSTEM_FAILED (0x0000112F):The server-side graphics subsystem is in an error state and unable to continue graphics encoding.
[19:46:01:398] [28720:28721] [ERROR][com.freerdp.core.transport] - BIO_read returned a system error 104: Connection reset by peer
[19:46:01:398] [28720:28721] [ERROR][com.freerdp.core] - freerdp_check_fds() failed - 0
[19:46:01:398] [28720:28721] [ERROR][com.freerdp.client.x11] - Failed to check FreeRDP file descriptor

now looks like a server configuration issue. does this setup work with gfx and another client?

@realjiangms True, but since the only server os family supporting AVC420 is based on windows 8.1 (earlier and later do not support it) it won't make a real difference.
@maddeer So, you added the line in the current master and that is the error you get? Seems like something is not working correct on the server side as well. I assume your original command line is the one you tried?

@akallabeth
xfreerdp /cert-ignore /f /bpp:16 -sec-nla /sound:sys:alsa /microphone:sys:alsa /rfx /gfx /u:user /p:pass /v:IP
yes, just added your line

--- channels/rdpgfx/client/rdpgfx_main.c.old    2017-08-10 12:05:48.746145880 +0300
+++ channels/rdpgfx/client/rdpgfx_main.c        2017-08-09 19:43:31.378935252 +0300
@@ -124,7 +124,7 @@

        if ((error = rdpgfx_write_header(s, &header)))
                goto fail;
-
+       pdu.capsSetCount = 2;
        /* RDPGFX_CAPS_ADVERTISE_PDU */
        Stream_Write_UINT16(s, pdu.capsSetCount); /* capsSetCount (2 bytes) */

without this line everything connects
with this line doesn't connect even to the win2012

but it connects to the win2008r2

@maddeer The patch lets the client announce only GFX windows 8 and 8.1 capabilities. Looks like there is some server setup broken (RFX graphics adapter working correctly?)

This servers are vmware VPS with default settings.

@maddeer Ok, got it, the patch must be before header.pduLength is set, that is line 114. damned typo :/

@akallabeth  now it works but nothing changes
Now I see this ERROR in log
[18:27:28:452] [1602:1603] [INFO][com.winpr.clipboard] - initialized POSIX local file subsystem
[18:27:28:455] [1602:1603] [INFO][com.freerdp.channels.drdynvc.client] - Loading Dynamic Virtual Channel audin
[18:27:28:455] [1602:1603] [INFO][com.freerdp.channels.audin.client] - Loaded alsa backend for audin
[18:27:28:455] [1602:1603] [INFO][com.freerdp.channels.drdynvc.client] - Loading Dynamic Virtual Channel urbdrc
[18:27:28:455] [1602:1603] [ERROR][com.freerdp.channels.urbdrc.client] - error processing arguments
[18:27:28:455] [1602:1614] [INFO][com.freerdp.channels.rdpsnd.client] - Loaded alsa backend for rdpsnd

maybe it nothing meters.
But I don't see it in win2012

@maddeer so you added /usb to the command line with an invalid syntax? Please try to focus on the RFX/GFX issue here, eliminate all unnecessary command line options for your tests.

Sorry, but with minimal options that I showed up here  nothing changed. Slide show and broken pixels.

@maddeer Looks like we're missing some essentail detail. Just tried a connection to a Windows-Server-2016-Essentials with AVC444 and GFX (client is current master) and there have been no screen artifacts and the performance was quite good (video, etc).
The whole thing is on a virtualized environment (proxmox)
Same with every other machine I've tried (windows 10 enterprise, server 2012).
Maybe your setup is requiring bandwidth measurement enabled for graphics quality estimation or something similar?

Sorry I used 2.0-rc0 tag.
Now I get master and your patch is fixes speed and quality

@maddeer Ah :) Good to know, can this issue be seen as solved?

Will this patch get in master? or it's the hardcode
I can use it like patch but I don't think that it is wright

@maddeer Well, not really. It was only meant to eliminate other sources of errors.
This looks like a configuration issue (bandwidth measurement et al are necessary for newer windows versions). So you can try with /network:auto or similar.
Since this works with the old caps announced, the client decoder path can not be at fault as the same path is used, only a different protocol support level is announced to the server.

Closing since the source of the problem is a configuration issue.


chore: Optimize Travis test order

Start the slow Jython test first since it takes the longest to
complete; other tests can run in parallel. Also, run the relatively
quick pep8 and pylint jobs in parallel with the slower Jython and
py26 jobs.

:+1:


Consider removal of winston-mail dependency

The mail transport in the Bedrock logging framework has not seen usage in recent years.
The winston-mail module has not had a release in approximately 3 years.  The maintainers are not keeping up with dependency updates.
https://github.com/wavded/winston-mail/commits/master
Specifically, the package is still using emailjs@2 while emailjs@4 is the current release:
https://github.com/eleith/emailjs/commits/main
The emailjs@2 dependency graph includes a version of the ramda module which has a ReDoS vulnerability:
https://security.snyk.io/vuln/SNYK-JS-RAMDA-1582370
I propose that the mail transport be removed along with the winston-mail dependency.

I'd be very happy to see this go -- and I would have removed it earlier when we went to 5.x if I had known it wasn't used. @davidlehn -- is it true we don't use this at all?

I don't think we have anything currently actively using it.  I think that was added long ago mainly as a critical error warning fallback for monolith applications.  But we, and others, are all trending to other system designs now.   It looks like it would be easy to add back to an application if needed as either a new bedrock module or just a few bits of app level code.  So I'm guessing removing it would be fine.

@mattcollier,
If we're going to require a major breaking change for this -- I'd like us to figure out if there is anything else that should be removed at the same time to save on churn. Breaking here requires every package to be updated.
I'm ok with removing this unused and disabled by default feature without a major breaking change since we just recently released 5.x.

Addressed by #102.

Closing, removed in v6.


Sync published with master

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit df078d9732939a2df37ae16181da80cd796c41d4
https://deploy-preview-8673--docsdocker.netlify.com


No Quarkus projects were detected in this folder

Hello,
I have a Quarkus project that runs when I do mvn quarkus:dev.
But when trying to debug from VSCode using the Quarkus: Debug current Quarkus Project command, I get this error:
No Quarkus projects were detected in this folder

Do I need to add any additional metadata for the detection?
Thanks!

@jeanabraham is it possible to share your project?

@jeanabraham is it possible to share your project?

@angelozerr Thanks, works now.  Seem to have been missing the below config:
{
    "version": "0.2.0",
    "configurations": [
        {
            "preLaunchTask": "quarkus:dev",
            "type": "java",
            "request": "attach",
            "hostName": "localhost",
            "name": "debug quarkus-project",
            "port": 5005
        }
    ]
}


Discord disconnecting randomly

I'm having disconnecting problems, i'm normally talking with my friends then randomly i can't do anything else, see other servers or type in any chat, they don't load, every other thing im doing works fine, i can still play and my internet speed is totally fine, once it 'disconnects' i can still talk and hear my friends and they can also hear me normally, and it stays like that for 1 or 2 mins and it sends me to loading screen... help please!

you do know this isnt Discord github right this is discord.net a library used to make bots for discord

You're going to want to get a hold of Discord's Support Team. This is not an issue related to Discord.Net.

Oh someone linked me here for support, sorry!


How to Sort Entities

I'm using EnTT for my game and I'm trying to render some objects in a particular order, specifically by their distance to the camera. I need to create a view in which the entities are in a specific order. I read  the docs and I wrote this:
void systems::piece_render(entt::registry& registry, entt::entity hovered_entity, entt::entity camera_entity) {
    auto& camera_transform = registry.get<TransformComponent>(camera_entity);

    auto func = [&camera_transform](const TransformComponent& lhs, const TransformComponent& rhs) {
        float distance1 = glm::length(camera_transform.position - lhs.position);
        float distance2 = glm::length(camera_transform.position - rhs.position);
        return distance1 < distance2;
    };

    registry.sort<TransformComponent>(func);

    auto view = registry.view<TransformComponent, MeshComponent,
                              MaterialComponent, TextureComponent,
                              OutlineComponent, PieceComponent>();

    for (entt::entity entity : view) {
        auto [transform, mesh, material, textures, outline, piece] = view.get(entity);
        // Render code here
    }
}

But it doesn't seem to do what I want. Looks like the objects are still rendered like before. I think I'm using sort wrongly. The docs aren't clear to me for some reason. My question is: How can I achieve what I want?

You probably want to add a view.use<TransformComponent>() before iterating the view. It guarantees that the order of your TransformComponent is respected.

You probably want to add a view.use<TransformComponent>() before iterating the view. It guarantees that the order of your TransformComponent is respected.

Ok. I'll try when I will be back home. Thank you.

Wow! I tried what you said and it works now. It renders the objects back to front.
I didn't know the use method before.

You're welcome.

@skypjack Who fast (or slow) registry.sort is? Since it is called every frame.

It sorts a sparse set. Slower than sorting a vector because it also has to update the sparse array. The packed array is a single packed array that is sorted using std::sort or any other function you pass to it instead (it's configurable, probably an insertion sort is faster in many cases but this really depends on the application).
Everything happens in-place. No allocations nor anything else. I also wrote an extensive post on the blog about this topic.
I use it in real world applications, the reason for which it's there
This doesn't make it blazing fast automatically but at least confirms that it's not there just because. :)

When I want to render my objects; I use a vector to save vertex buffer data before rendering them using a batch renderer.
Is sorting that vector is faster than sorting entities?

Well, sorting a pool literally sorts a vector (similar cost) and updates the sparse array associated to it (additional cost).
It doesn't matter how small the second cost is, its existence is already the answer you're looking for.

Got it

I have a similar use case of sorting entities. But I am not able to use the view.use() function.
It keeps giving me error
No member named 'use' in 'entt::basic_view<entt::entity, entt::get_t<Shutter::SortComponent>, entt::exclude_t<>>'

I am using v3.9.0 and below is my usage.
m_Registry.sort<SortComponent>([](const auto &lhs, const auto &rhs) {
            return lhs.sortOrder > rhs.sortOrder;
        }, entt::insertion_sort());
        auto view = m_Registry.view<SortComponent>();
        view.use<SortComponent>();

Please help me with this issue.

@sourabh-gupta-dev view::use is only available for multi-type views. It tells to the view what pool to use to drive the iteration.
It wouldn't make much sense for a single type view actually since you don't really have a choice there. 😅

Got it. Thanks for the quick reply.


Armok Vision not running in Ubuntu because of case sensitive names

Platform: Ubuntu 64 bits.
Downloaded from github. Started, nothing happens, only a blank screen, no map showed nor blocks received from DF.
After checking the log file in
/home/.config/unity3d/DefaultCompany/Armok Vision/Player.log
It was found that the problem was the asset WindMill.obj that needs to be renamed to Windmill.obj.
After renaming the asset. Armok Vision works ok

This actually raises another issue that it shouldn't break if a file isn't found. Just log an error.

Fixed in 14fda759b756a2334359258f0d432e80e8112f7b


[FABC-874] Add HSM changes to Fabric CA docs

Add updates to use HSM with Docker Compose to
Fabric CA docs
Signed-off-by: NIKHIL E GUPTA<EMAIL_ADDRESS>

This is a cherry pick of this PR that went into 1.4 into master:https://github.com/hyperledger/fabric-ca/pulls?q=is%3Apr+is%3Aclosed


Add jsonp on develop

Add jsonp support to RouterResponse send()
Description
Added a new overload to send(jsonp:callbackParam:="callback") which writes a JSONP response.
Throws a JSONPError if no valid parameter is provided by the request that matches the JSONP callback param name.
Motivation and Context
Issue #310
How Has This Been Tested?
The changes include a test route and 3 test cases that check the generated response.
I ran these tests on Linux using the Kitura vagrant image, with Swift snapshot 2016-05-09.
There should probably be some testing in the browser before this is landed.
Checklist:

[ ] I have submitted a CLA form
[ ] If applicable, I have updated the documentation accordingly.
[x] If applicable, I have added tests to cover my changes.

@tunniclm looks good, just please fix the compilation errors from using the latest the codebase.

Updated.

So the test I added fails on OSX because it checks for a specific JSON serialized string value to be returned in the response. However, it looks like NSJSONSerialization does slightly different "pretty" serialization on OSX and Linux (the OSX implementation puts a space before the : character in maps and whereas the Linux implementation doesn't).
The doc for NSJSONSerialization is not specific about the exact spacing requirements, so both implementations match the "spec". Nevertheless, I think it would be good for them to match exactly, so I'll raise a PR against swift-corelibs-foundation for that.
This does raise the question of whether or not we want to send(json:) and send(jsonp:) to produce pretty JSON by default, and/or whether we want to make it a configurable option (like Express, which has an application setting "json spaces").

Should add a test to check invalid JS characters get correctly encoded
Should add a test that checks changing callbackParameter works
Should manually test out in a basic browser app that uses JSONP

Pushed a new commit with tests for the callback parameter name and the character encoding.

I ran some manual tests with a browser and it seems to be working correctly.
Here is the test server code:
import Kitura
import SwiftyJSON

let router = Router()

router.get("/test") { req, res, next in
    do {
        try res.send(jsonp: JSON([ "hello": "world}" ]))
    } catch (JSONPError.invalidCallbackName) {
        res.status(.badRequest)
    }
    next()
}

Kitura.addHTTPServer(onPort: 8090, with: router)
Kitura.run()

And here is the client html page:
<!DOCTYPE html>

Loading...

The expected output is for the page to show { "hello": "world" }.
I also ran a couple of extra tests:

modified server to send JSON containing U+2028 and checked it came out correctly in the data the client received
modified html client to request from http://localhost:8090/test?callback__wrongname=process to ensure HTTP 400 Bad Request was returned (server expects a parameter called callback which is missing in this request)
modified html client to request from http://localhost:8090/test?callback=proc!ess to ensure HTTP 400 Bad Request was returned (server expects the value of the callback parameter to only contain certain valid characters -- consistent with describing a valid javascript identifier -- this request passes pro!cess which is not valid as ! is not one of the allowed character)

@shmuelk @dfirsht : I think this is ready to merge provided the latest code changes look good.
Highlights of the most recent changes:

After much fiddling with inconsistencies in JSON handling between Linux/macOS, I just settled on conditionally compiling the code with #if
I changed  JSONPError to be a public enum since it gets thrown up to user code (this didn't show up as a problem in the tests because they are local to Kitura, but did give an error from a separate server project.)

Another quick update to the code as I spotted I was using mime type application/json when it should have been application/javascript. Fixed that and added some asserts to the tests to test for it as well.

Updated the doc comment and @ianpartridge reviewed it. I don't think there are any other documentation updates required so I'm going to check off that task as complete.

Hey we are actually moving all development to be PRs against master. Please reopen your PR against the master branch.


Fixed code sample

Fixed code to retrieve the IHubContext from middleware

Thank you for fixing this, @davidfowl!


Upgrade faiss to 12b92e9fa5d8e8fb3da53c57af9ff007c826b1ee

Overview
For #1507, we need to upgrade faiss to atleast: https://github.com/facebookresearch/faiss/commit/12b92e9fa5d8e8fb3da53c57af9ff007c826b1ee. This is a commit or 2 after the 1.8 release.
Therefore, for 2.13, we will upgrade to this commit: 12b92e9fa5d8e8fb3da53c57af9ff007c826b1ee.
Checklist

[x] Upgrade patches to work with latest. Remove patches no longer required
[x] Update build process to work with latest
[x] Build/test succeeds
[x] BWC tests pass
[ ] no performance regression

Forgot for perf test. Will wait for release

Closing as perf will be covered in release testing.


le pods

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master      #5   +/-   ##
======================================
  Coverage    90.9%   90.9%
======================================
  Files           5       5
  Lines         176     176
======================================
  Hits          160     160
  Misses         16      16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b760626...27b00af. Read the comment docs.

closing temporarily.


Possible regression bug on reconnect after RabbitMQ node is disconnected

We have logstash connect to a load-balancer host that proxies to a pool of backend RabbitMQ hosts.
When we disable one of the backend hosts at the load-balancer, logstash 1.5.0 and logstash 1.5.1 do not reconnect, if they were connected to that post.
If we try same setup with logsatsh 1.3.3 it is able to reconnect.
This is our output block:
output {
rabbitmq {
host => "$LOADBALANCER"
port => "$PORT"
exchange => "amq.direct"
exchange_type => "direct"
key => "test"
}
}
For 1.5.x version, we just get below error message (and it is NOT able to reconnect).
::ChannelAlreadyClosed>, :backtrace=>["/app/infra/working/logstash-1.5.1/vendor/bundle/jruby/1.9/gems/march_hare-2.5.1-java/lib/march_hare/exceptions.rb:121:in convert_and_reraise'", "/app/infra/working/logstash-1.5.1/vendor/bundle/jruby/1.9/gems/march_hare-2.5.1-java/lib/march_hare/channel.rb:965:in converting_rjc_exceptions_to_ruby'", "/app/infra/working/logstash-1.5.1/vendor/bundle/jruby/1.9/gems/march_hare-2.5.1-java/lib/march_hare/channel.rb:595:in basic_publish'", "/app/infra/working/logstash-1.5.1/vendor/bundle/jruby/1.9/gems/march_hare-2.5.1-java/lib/march_hare/exchange.rb:77:in publish'", "/app/infra/working/logstash-1.5.1/vendor/bundle/jruby/1.9/gems/logstash-output-rabbitmq-0.1.5-java/lib/logstash/outputs/rabbitmq/march_hare.rb:40:in publish_serialized'", "org/jruby/RubyProc.java:271:in call'", "/app/infra/working/logstash-1.5.1/vendor/bundle/jruby/1.9/gems/logstash-codec-json-0.1.7/lib/logstash/codecs/json.rb:44:in encode'", "/app/infra/working/logstash-1.5.1/vendor/bundle/jruby/1.9/gems/logstash-output-rabbitmq-0.1.5-java/lib/logstash/outputs/rabbitmq/march_hare.rb:31:in receive'", "/app/infra/working/logstash-1.5.1/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.1-java/lib/logstash/outputs/base.rb:88:in handle'", "(eval):24:in output_func'", "/app/infra/working/logstash-1.5.1/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.1-java/lib/logstash/pipeline.rb:243:in outputworker'", "/app/infra/working/logstash-1.5.1/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.1-java/lib/logstash/pipeline.rb:165:in start_outputs'"], :level=>:error}

This looks like it may actually be connected to #12 . I'm going to try and get a fix for that out soon, I think it should fix this issue. It looks like the failure to reset the @x instance var on exception is the root cause here.

@seang-es I've just published a new version of this plugin 1.0.1, can you see if that helps?
I'm also going to do some significant rework of this gem over the next week.

@seang-es since I haven't heard back from you I'm going to close this ticket. If you're still having issues please re-open this ticket or open a new issue.


serve the raw results in /results endpoint

This will serve the raw results from the scanners in the /results endpoint.
It seems that it was meant to be that way a long time ago as ResultAPIUrlPath already exists and is set with the default value of /results.
The output from an OpenSCAP scan will look like this after json formatting (python -m json.tool):
results_output_example_openscap.txt
This seems especially helpful for the clamav scanner which doesn't produce reports.
Aims to fix #84

@legionus @mfojtik @zgalor @rhdedgar Can you please take a look?

Example output:
{
    "apiVersion": "v1alpha",
    "imageID": "sha256:92fa4a4bde07cd62556eeffd37b692e89dbc227a14eb4ea0842d29a3b5eacfc5",
    "imageName": "<IP_ADDRESS>:5000/test/origin-ruby-sample@sha256:54d0286de3dd7f22a92ff77398ebe8c3d8ae4ab9b8612a700cbe415e59dae2ca",
    "results": [
        {
            "description": "RHSA-2017:0372: kernel-aarch64 security and bug fix update (Important)",
            "name": "openscap",
            "reference": "https://cve.mitre.org/cgi-bin/cvename.cgi?name==CVE-2016-5195",
            "scannerVersion": "1.2",
            "summary": [
                {
                    "Label": "high"
                }
            ],
            "timestamp": "2017-12-19T19:27:19.1951513Z"
        },
        {
            "description": "RHSA-2017:1308: kernel security, bug fix, and enhancement update (Important)",
            "name": "openscap",
            "reference": "https://cve.mitre.org/cgi-bin/cvename.cgi?name==CVE-2016-10208",
            "scannerVersion": "1.2",
            "summary": [
                {
                    "Label": "high"
                }
            ],
            "timestamp": "2017-12-19T19:27:19.246107217Z"
        },
        {
            "description": "RHSA-2017:1365: nss security and bug fix update (Important)",
            "name": "openscap",
            "reference": "https://cve.mitre.org/cgi-bin/cvename.cgi?name==CVE-2017-7502",
            "scannerVersion": "1.2",
            "summary": [
                {
                    "Label": "high"
                }
            ],
            "timestamp": "2017-12-19T19:27:19.30038206Z"
        },
        {
            "description": "RHSA-2017:1481: glibc security update (Important)",
            "name": "openscap",
            "reference": "https://cve.mitre.org/cgi-bin/cvename.cgi?name==CVE-2017-1000366",
            "scannerVersion": "1.2",
            "summary": [
                {
                    "Label": "high"
                }
            ],
            "timestamp": "2017-12-19T19:27:19.351633337Z"
        },
...


Docs: Create persistent file example provides incorrect code

Bug Report
Problem
https://github.com/apache/cordova-plugin-file#create-a-persistent-file-
LocalFileSystem.PERSISTENT does not exists. It should be window.PERSISTENT, as confirmed by a support ticket https://github.com/apache/cordova-plugin-file/issues/369
The documentation should be updated to window.PERSISTENT. Note that, the window namespace is also used in create temporary file example
Command or Code

LocalFileSystem.PERSISTENT
Environment, Platform, Device

All platforms
Version information
cordova-plugin-file 6.0.3-dev - not sure when the documentation was written however.
Checklist

[x] I searched for existing GitHub issues
[x] I updated all Cordova tooling to most recent version
[x] I included all the necessary information above

Upon further testing, I can actually confirm that both LocalFileSystem.PERSISTENT & window.PERSISTENT exists.
Still I feel like the docs should be consistent. Is there a reason why this is replicated? is window.PERSISTENT/TEMPORARY legacy?


2 modules gets the same ID with expose-loader

In my project I expose React with the following code
{
            test: require.resolve('react'),
            loader: 'expose?React'
        }

When I use this plugin, I end up with a bad webpack file:
/***/<PHONE_NUMBER>248615:
/***/ function(module, exports, __webpack_require__) {

	'use strict';

	module.exports = __webpack_require__(6285320399463177);

/***/ },

/***/<PHONE_NUMBER>248615:
/***/ function(module, exports, __webpack_require__) {

	/* WEBPACK VAR INJECTION */(function(global) {module.exports = global["React"] = __webpack_require__(5896763357248615);
	/* WEBPACK VAR INJECTION */}.call(exports, (function() { return this; }())))

/***/ },

You can see that 2 modules have the same ID, which messes up all the require of react.

@florian-bd
Like #2 , exactly as you description, using this plugin with 'expose' may lead to this terrible problem.
I have read expose plugin source code and can't find the behind problem at once.
Sorry for that.

Ok thank you for your answer. I will see what I can do

@florian-bd
Thank your remind. I have specified that in README.
I have tried to fix it and made some experiment (mentioned in#4 ), however time limited.
Hope you can fix it. ^_^


Tester: calling a method on random address returns true

I have two contract files:
contract Account {
       function has_funds() constant returns (bool) {
                  return false;
       }
}

and
import "./Account.sol";

contract Bank {
       function withdraw(Account account) {
                  if (!account.has_funds())
                             throw;
       }
}

When I perform withdraw() passing in a random address (that is definitely not an account instance) I expect, that since the random address does not have a has_funds() method, it should return false (that is what happens in solidity in the browser) or throw an exception. In reality calling has_funds() on a random address returns true.
This is a simple test to reproduce the error:
import os
import binascii

import pytest
from ethereum import tester
from ethereum.tester import TransactionFailed

def random_address():
    return '0x' + binascii.b2a_hex(os.urandom(20))

def get_path(contract_name):
    contract_path = os.path.join(os.path.dirname(__file__), 'contracts', contract_name + '.sol')
    return os.path.realpath(contract_path)

def do_test():
    state = tester.state()
    account = state.abi_contract(open(get_path("Account")).read(), language='solidity', sender=tester.k0)
    bank = state.abi_contract("", path=get_path("Bank"), contract_name="Bank", language='solidity', sender=tester.k0)

    with pytest.raises(TransactionFailed):
        bank.withdraw(account.address)

    # should throw, but does not
    bank.withdraw(random_address())

if __name__ == '__main__':
    do_test()

Tested and it returns 0 / fails for me


Remove extra dependencies to avoid dead loop of page re-rendering

Description

Remove extra dependencies for 'useEffect' and 'useCallback'. These dependencies can cause page re-rendering in a dead loop and infinite console errors would be printed.
Add the eslint disable mark to avoid warnings from eslint for these lines

How was this PR tested?

Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to clarify your proposed changes.

It requires us setting some variables as dependencies. Some of them are not necessary and can cause infinite page re-rending in a dead loop. So the console will keep printing that error message which may cause serious problem.


Backport 12254

builds on #3415, currently failing. Will rebase after #3415
Backports bitcoin#12254 and bitcoin#14073

functional tests looking good, code looks good to me however Unit Tests fail with
FAIL: test/test_dash
====================

Running 303 test cases...
test/blockfilter_tests.cpp(137): error: in "blockfilter_tests/blockfilters_json_test": check computed_filter_basic.GetFilter().GetEncoded() == filter_basic has failed
test/blockfilter_tests.cpp(140): error: in "blockfilter_tests/blockfilters_json_test": check computed_header_basic == filter_header_basic has failed
test/blockfilter_tests.cpp(137): error: in "blockfilter_tests/blockfilters_json_test": check computed_filter_basic.GetFilter().GetEncoded() == filter_basic has failed
test/blockfilter_tests.cpp(140): error: in "blockfilter_tests/blockfilters_json_test": check computed_header_basic == filter_header_basic has failed
test/blockfilter_tests.cpp(137): error: in "blockfilter_tests/blockfilters_json_test": check computed_filter_basic.GetFilter().GetEncoded() == filter_basic has failed
test/blockfilter_tests.cpp(140): error: in "blockfilter_tests/blockfilters_json_test": check computed_header_basic == filter_header_basic has failed
test/blockfilter_tests.cpp(137): error: in "blockfilter_tests/blockfilters_json_test": check computed_filter_basic.GetFilter().GetEncoded() == filter_basic has failed
test/blockfilter_tests.cpp(140): error: in "blockfilter_tests/blockfilters_json_test": check computed_header_basic == filter_header_basic has failed
test/blockfilter_tests.cpp(137): error: in "blockfilter_tests/blockfilters_json_test": check computed_filter_basic.GetFilter().GetEncoded() == filter_basic has failed
test/blockfilter_tests.cpp(140): error: in "blockfilter_tests/blockfilters_json_test": check computed_header_basic == filter_header_basic has failed
test/blockfilter_tests.cpp(120): fatal error: in "blockfilter_tests/blockfilters_json_test": critical check DecodeHexBlk(block, test[pos++].get_str()) has failed

*** 11 failures are detected in the test module "Bitcoin Test Suite"
FAIL test/test_dash (exit status: 201)

I'm not sure if this is dependant on earlier PRs. I can't find any. This is low priority for review.

Cherry-picked :+1: That makes sense


Paths won't be ignored correctly

Correct me if I'm wrong, but afaik one may exclude a specific file / path by using the path in the repository with a leading slash, i.e. tests would ignore all files and directories named tests, while /tests would just ignore /tests but not /fancy/tests.
However, paths will be checked without leading slash, so the pattern /tests will never match.

Should simple to check with vanilla git archive.

PR #45 should make git-archive-all to follow git exclusion rules.


API origin as country attribute

We have national API catalogue PoC at apisuomi.fi and we would love to use apis.io as base for all APIs and pull Finland origin APIs to catalogue via apis.io API. I took a look at the spec but I was not able to find any attribute that would be something like origin or country. Such attribute (not mandatory) would enable API listing filtering.

Perhaps this could be applied http://problem-xml.sourceforge.net/schemaReference/schemas/vcard_xsd/elements/ADR.html
    <vCard:street>Perston House</vCard:street>
    <vCard:locality>Perston</vCard:locality>
    <vCard:region>Perstonshire</vCard:region>
    <vCard:pcode>P1 0NS</vCard:pcode>
    <vCard:country>Finland</vCard:country>
  </vCard:adr>```

This is definitely something I will be considering for inclusion in next release. Doing review for it this week. Thanks for suggesting.

Excellent, thanks.

I'm going to reopen until i get into spec.


[examples] Add price sim

@Chepelau please rename the "sim" dir to something more explanatory... thanks :)

@Chepelau can you make a summary at the end of the notebook that will say something
for strike 1000 and current price 800, CALL pool size 20_000ETH
the premium shifts by ...% when we trade option of size 50ETH (0.25% of the pool)
the premium shifts by ...% when we trade option of size 100ETH (0.5% of the pool)
the premium shifts by ...% when we trade option of size 200ETH (1% of the pool)
the premium shifts by ...% when we trade option of size 500ETH (2.5% of the pool)

for strike 1000 and current price 800, PUT pool size 20_000_000 USD
the premium shifts by ...% when we trade option of size 50ETH (0.25% of the pool)
the premium shifts by ...% when we trade option of size 100ETH (0.5% of the pool)
the premium shifts by ...% when we trade option of size 200ETH (1% of the pool)
the premium shifts by ...% when we trade option of size 500ETH (2.5% of the pool)

*for higher detail (buy vs sell, different impacts in maturities, etc) adjust the parameters in the notebook

Just pushed some changes, let's talk about this tommorrow


[FLINK-9493] Forward cause when releasing a TaskManager at the SlotPool

What is the purpose of the change
This PR is to propagate original cause from components calling SlotPoolGateway::releaseTaskManager
Brief change log

adjust SlotPoolGateway::releaseTaskManager to accept cause
propagate cause in SlotPool from other components
generate cause in case of SlotPool::postStop

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

cc @tillrohrmann


Fix layout problem #35

Fix for layout problem #35
Just the event list height adjustment.

:+1:

:+1:


Support downstream roundTripTimeoutSeconds for combined read and write of request, including upstream time.

Is your feature request related to a problem? Please describe.
Jabba needs a timeout for downstream roundtrip that covers downstream request, response time, including times waiting for upstream.
Describe the solution you'd like
connection.downstream.roudTripTimeoutSeconds should terminate connected sockets between user agent and Jabba  even if they're still writing in progress
Tasks

[ ] log aborted request due to roundTripTimeoutSeconds
[ ] implement integration tests

i need two separate jabba configs for the integration test here.
Test downstream roundTripTimeoutSeconds
one where downstream roundTripTimeoutSeconds is < upstream readTimeoutSeconds so I can test downstream roundTripTimout fires.
Test upstream readTimeoutSeconds
downstream roundTripTimeoutSeconds > upstream readTimeoutSeconds so I can test upstream readTimeoutSeconds fires.