How best to insert/specify id_generator ?

Hi, I'm new to Axum and OpenTelemetry in general and currently attempting to learn/work on a proof of concept webapp that wire as follows:
[webapp] -- OPTL --> [AWS OpenTelemetry Collector] --> AWS XRay
I am able to compile and run a bare minimum webapp as follows:
#[tokio::main]
async fn main() {
    axum_tracing_opentelemetry::tracing_subscriber_ext::init_subscribers().unwrap();
    let app = Router::new()
        .route("/hello", get(hello))
        .layer(opentelemetry_tracing_layer())
    ;

    let addr = SocketAddr::from(([127, 0, 0, 1], 3000));
    axum::Server::bind(&addr)
        .serve(app.into_make_service())
        .await
        .unwrap();
}

Environment variables used when running the above webapp:
OTEL_EXPORTER_OTLP_PROTOCOL=grpc OTEL_TRACES_SAMPLER=always_on OTEL_EXPORTER_OTLP_ENDPOINT=http://<IP_ADDRESS>:4317 OTEL_PROPAGATORS=xray cargo run
It generate a trace and subsequently received by aws-opentelemetry-collector. All seems well except aws-opentelemetry-collector is complaning:
{"kind": "exporter", "data_type": "traces", "name": "awsxray", "error": "invalid xray traceid: d040dc9e21029c1fc14e0244330b0314"}
Upon some research it seems that for AWS Xray to accept the trace it need to be convert from OpenTelemetry Trace Id format to AWS Xray Trace Id format, and can be done so by specifying a Id Generator, in this case the XrayIdGenerator:

https://docs.rs/opentelemetry/latest/opentelemetry/sdk/trace/struct.XrayIdGenerator.html

I am seeking for opinion/advice how best to insert the Id Generator, is the following code location the best way to do it?

https://github.com/davidB/axum-tracing-opentelemetry/blob/main/src/tools/otlp.rs#L39

Will the alteration as follows do the trick?
        .tracing()
        .with_exporter(exporter)
        .with_trace_config(
            opentelemetry::sdk::trace::config()
                .with_id_generator(XrayIdGenerator::default())   <--- added this new line. Probably to also check for OTEL_PROPAGATORS=xray otherwise default generator `sdk::IdGenerator::default()` ?
                .with_resource(resource)
                .with_sampler(read_sampler_from_env()),
        );

Any guidance/hint appreciated. Many thanks!

I guessed that the conversion is done by the collector+exported. Else it means that for incoming request that use B3/ZipKing or W3C TraceContext, it is not possible to preserve them (and to propagate).

there is also a bug in the current implementation of axum-tracing-opentelemetry that generates a random TraceId regardless of which default tracer is defined. So changing the id_generator of the tracer will be ignored.
To change the config you don't need to modify the otlp.rs file. But you have to setup the subscriber more manually (aka replace axum_tracing_opentelemetry::tracing_subscriber_ext::init_subscribers() by your own code). Into your own code change the setup of tracer, by create it directly or by providing using init_tracer function and provide your own transform function.

I see, thanks for the guidance!


Descriptive error message for invalid types in components and message fields

[messages.player_command.fields]
mvx = { type = "I8" }
mvy = { type = "I8" }

The error message that results from this message field definition (in ambient.toml) is currently the following:
called `Result::unwrap()` on an `Err` value: invalid primitive type

Instead it should say something like this:
Message field type definition in ambient.toml (line 7) is invalid (type "I8" is unsupported by Ambient protocol)

As many of the below as possible, to assist the user in understanding the user error aspect of the issue, so that they can resolve it quickly by themselves

Refer to problematic filename (e.g. 'ambient.toml')
Refer to line number in file (not that important, but nice if it is possible)
Describe the problem at the user error level (e.g. 'message field type definition is invalid') rather than in terms of the backend problem (i.e. I have not written any Result::unwrap code so I have no idea what it is referring to, or how to fix it)
Use language that indicates that the issue is not a bug, but known and intentional ('unsupported by Ambient')

related here: https://github.com/AmbientRun/Ambient/issues/524#issuecomment-1600939634

All these bullet points are possible to one extent or another.
Returning the line of the error is something we already do in some places (like pipeline custom components) and is really only limited by the toml parser.
The issue is that the chain stops and slams into a wall where it can't peek through if we don't support it all the way through, which js why you gets the "hand waving: somewhere around here"

This is improved with #417:
[ember]
id = "dependencies"
organization = "ambient"
name = "dependencies"
version = "0.0.1"

[messages.hello]
name = "Hello"
fields = { text = "i8" }

results in
Error: Failed to resolve type `i8` for field `text` of message `hello`

It would be nice to get a filename and line number in there. I'll see what I can do at some point...


[SPARK-14258]change scope of functions in KafkaCluster

What changes were proposed in this pull request?
changing scopes of some functions to minus.
How was this patch tested?
unit tests in Jenkins.

Test build #54483 has started for PR 12053 at commit d91f36f.

Test build #54483 has finished for PR 12053 at commit d91f36f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54483/
Test PASSed.

Merged build finished. Test PASSed.

I don't think we're going to do this, or else, it's being subsumed in other changes to the Kafka API anyway


Feature/chrome user agent

Summary
Adds support for user defined User-Agent strings for Chrome/Headless via the HEADLESS_USER_AGENT environment variable/configuration variable.
Related to #180
Changes these areas

[x] Config
[ ] Bugfixes
[ ] Command line interface
[x] Feature behavior
[ ] Internal design
[ ] Archived data layout on disk

Roadmap Goals
This PR does not specifically address any of the currently posted roadmap goals but I believe it adds robustness to the core feature set of ArchiveBox and ensures a larger percentage of websites are supported with minimal changes to the code base.

Just wanted to add that in the spirit of letting websites choose to restrict scraping/crawling this PR does not change the default behavior of ArchiveBox, unless the HEADLESS_USER_AGENT variable is set Chrome Headless will use its default User-Agent string

This looks great, thanks for submitting it.  Do you mind renaming it from HEADLESS_USER_AGENT to CHROME_USER_AGENT to be consistent with the other Chrome config options?


MultiClass Training

Trying to train LGBM for a multiclass dataset. The below is the function
trainAndTestLGBM=function(nrounds=800, depth=8, leaves=200,  col_sample=0.5,
                          row_sample=0.5, learn_rate=0.025, seed=1234, ltrain, lval, ltest){
  set.seed(seed)
  lxgb_params = list( objective = "multiclass", metric  = "multi_logloss",
                      learning_rate = learn_rate,
                      num_leaves=leaves, max_depth = depth,
                      bagging_fraction = row_sample, bagging_freq=1, bagging_seed = seed,
                      feature_fraction = col_sample, feature_fraction_seed = seed)

  lxgb_model = lgb.train(params=lxgb_params, data=ltrain, nrounds=nrounds,
                valids=list(test = lval),
                record=T, eval_freq = 50, num_class=3)

  all_predictions = predict(lxgb_model, data=ltest)
}

Getting the following Error:
Error in lgb.call(fun_name, ret = buf, ..., buf_len, act_len) :
  api error: Number of classes should be specified and greater than 1 for multiclass training
Called from: lgb.call(fun_name, ret = buf, ..., buf_len, act_len)

I think lgb.train doesn't have num_class parameter.
you should set it in the lxgb_params  .

tried that as well, same error

sorry. I thought it was in python package.
@Laurae2 any idea about this ?

@melwinjose1991 Without a reproducible example, will be difficult to troubleshoot this as I cannot reproduce it. Make sure you are using lgb.unloader(wipe = TRUE) to wipe LightGBM (and all its objects) from R before creating your matrices, it is a mandatory step if you messed up a training just before.
This demo works:
library(lightgbm)

data(iris)

# We must convert factors to numeric
# They must be starting from number 0 to use multiclass
# For instance: 0, 1, 2, 3, 4, 5...
iris$Species <- as.integer(as.factor(iris$Species)) - 1

train <- as.matrix(iris[c(1:40, 51:90, 101:140), ])
test <- as.matrix(iris[c(41:50, 91:100, 141:150), ])
dtrain <- lgb.Dataset(data = train[, 1:4], label = train[, 5])
dtest <- lgb.Dataset.create.valid(dtrain, data = test[, 1:4], label = test[, 5])
valids <- list(test = dtest)

params <- list(objective = "multiclass", metric = "multi_logloss", num_class = 3)
model <- lgb.train(params,
                   dtrain,
                   100,
                   valids,
                   min_data = 1,
                   learning_rate = 1,
                   early_stopping_rounds = 10)

trainAndTestLGBM=function(nrounds=800, depth=8, leaves=200,  col_sample=0.5,
                          row_sample=0.5, learn_rate=0.025, seed=1234, ltrain, lval, ltest){
  set.seed(seed)
  lxgb_params = list( objective = "multiclass", metric  = "multi_logloss",
                      learning_rate = learn_rate,
                      num_leaves=leaves, max_depth = depth,
                      bagging_fraction = row_sample, bagging_freq=1, bagging_seed = seed,
                      feature_fraction = col_sample, feature_fraction_seed = seed)

  lxgb_model = lgb.train(params=lxgb_params, data=ltrain, nrounds=nrounds,
                         valids=list(test = lval),
                         record=T, eval_freq = 50, num_class=3)

  all_predictions = predict(lxgb_model, data=ltest)
}

print(trainAndTestLGBM(nrounds = 3, ltrain = dtrain, lval = dtest, ltest = test))

Result (works even if using dtest <- lgb.Dataset(data = test[, 1:4], label = test[, 5])):
> print(trainAndTestLGBM(nrounds = 3, ltrain = dtrain, lval = dtest, ltest = test))
[LightGBM] [Info] Total Bins 64
[LightGBM] [Info] Number of data: 120, number of used features: 4
[LightGBM] [Info] No further splits with positive gain, best gain: -inf
[LightGBM] [Info] Trained a tree with leaves=2 and max_depth=1
[LightGBM] [Info] No further splits with positive gain, best gain: -inf
[LightGBM] [Info] Trained a tree with leaves=2 and max_depth=1
[LightGBM] [Info] No further splits with positive gain, best gain: -inf
[LightGBM] [Info] Trained a tree with leaves=2 and max_depth=1
[1]:	test's multi_logloss:1.08058
[LightGBM] [Info] No further splits with positive gain, best gain: -inf
[LightGBM] [Info] Trained a tree with leaves=2 and max_depth=1
[LightGBM] [Info] No further splits with positive gain, best gain: -inf
[LightGBM] [Info] Trained a tree with leaves=2 and max_depth=1
[LightGBM] [Info] No further splits with positive gain, best gain: -inf
[LightGBM] [Info] Trained a tree with leaves=2 and max_depth=1
[LightGBM] [Info] No further splits with positive gain, best gain: -inf
[LightGBM] [Info] Trained a tree with leaves=2 and max_depth=1
[LightGBM] [Info] No further splits with positive gain, best gain: -inf
[LightGBM] [Info] Trained a tree with leaves=2 and max_depth=1
[LightGBM] [Info] No further splits with positive gain, best gain: -inf
[LightGBM] [Info] Trained a tree with leaves=2 and max_depth=1
[3]:	test's multi_logloss:1.03655
 [1] 0.3655953 0.3162812 0.3181235 0.3655953 0.3162812 0.3181235 0.3655953 0.3162812 0.3181235 0.3376158 0.3347418 0.3276424 0.3655953 0.3162812
[15] 0.3181235 0.3655953 0.3162812 0.3181235 0.3655953 0.3162812 0.3181235 0.3655953 0.3162812 0.3181235 0.3655953 0.3162812 0.3181235 0.3655953
[29] 0.3162812 0.3181235 0.3312695 0.3472469 0.3214836 0.3196981 0.3473304 0.3329716 0.3312695 0.3472469 0.3214836 0.3312695 0.3472469 0.3214836
[43] 0.3312695 0.3472469 0.3214836 0.3312695 0.3472469 0.3214836 0.3312695 0.3472469 0.3214836 0.3233882 0.3513394 0.3252725 0.3312695 0.3472469
[57] 0.3214836 0.3312695 0.3472469 0.3214836 0.3095121 0.3362640 0.3542240 0.3095121 0.3362640 0.3542240 0.3172138 0.3325133 0.3502730 0.3095121
[71] 0.3362640 0.3542240 0.3095121 0.3362640 0.3542240 0.3095121 0.3362640 0.3542240 0.3095121 0.3362640 0.3542240 0.3095121 0.3362640 0.3542240
[85] 0.3095121 0.3362640 0.3542240 0.3095121 0.3362640 0.3542240

Even works when the number of classes do not match, like this:
train <- as.matrix(iris[c(1:40, 51:90, 141:150), ])

Or this:
test <- as.matrix(iris[c(41:50, 91:100), ])

@Laurae2 i just restart R studio and it worked. Maybe lgb.unloader() would also have worked.
One last question, how to turn off just the [info] part of the verbose ?


Re-routing & No Viable Path

When a link goes down, router(s) report a fault to the controller, which provokes the controller to re-route any affected sessions.
In cases where there is no viable alternate path, it's not clear if sessions will eventually be re-routed when a new viable path arrives.
Reproduce and investigate.

We now kill circuits if they can't be rerouted


feat: lazy loaded DM harvester

This avoids loading the telemetry-api (dimensional metrics) harvester right away. It'll be lazy loaded on its first usage instead.

add thread safe lazy load (reminder)


[PoC] How to use active inference to evolve into a reflection guide

PoC of a Multi-Agent System (MAS) with agents using Bayesian methods and Markov decision processes to facilitate reflective conversations with CrewAI as MAS platform.

[ ] what's the goal?
[ ] design agent structure
[ ] design separate agents
[ ] implement tasks

Archived. Out of scope for now.


[release-v1.106] [GEP-26] Fix bug where shoot care controller uses outdated credentials config

/area ipcei security
/kind bug
/label ipcei/workload-identity
This is a manual partial cherry-pick of #10672 and #10681
Fix a bug where the shoot care controller cannot reconcile shoots with `spec.maintenance.confineSpecUpdateRollout=true` and migrated between `secretBindingName` and `credentialsBindingName` until the shoot is reconciled..

/retest-required

/test pull-gardener-e2e-kind-operator-seed-release-v1-106


make mainnet (hash) prefixes the default

Once mainnet hits, we have to make sure that all default (hash) prefixes are set to mainnet. Currently, the default is set to testnet
some examples
in src/lib/mina.ts
let minaNetworkId: NetworkId = 'testnet';

in src/mina-signer/mina-signer.ts
let signature = sign({ fields }, privateKey_, network ?? 'testnet');

why is mainnet the better default?

I feel like less configuration effort would lead to a more seamless integration with the main network you want to interact with and interacting with a different network should require an explicit configuration to do so - but both works

relevant: #1492

I think I have changed my mind - I believe having testnet as default is better

Closing for now, can reopen if relevant again


bug: Injected formatter removing necessary white spaces

Neovim version (nvim -v)
NVIM v0.9.5
Operating system/version
Arch Linux
Add the debug logs

[X] I have set log_level = vim.log.levels.DEBUG and pasted the log contents below.

Log file
10:22:14[DEBUG] Running formatters on /home/micah/Documents/conform/test.md: { "prettier", "injected" }
10:22:14[INFO] Run prettier on /home/micah/Documents/conform/test.md
10:22:14[TRACE] Input lines: { "
", "  Hello World", "
", "", "# Test" }
10:22:14[DEBUG] Run command: { "prettier", "--stdin-filepath", "/home/micah/Documents/conform/test.md" }
10:22:14[DEBUG] prettier exited with code 0
10:22:14[TRACE] Output lines: { "
", "  Hello World", "
", "", "# Test" }
10:22:14[TRACE] prettier stderr: { "" }
10:22:14[INFO] Run injected on /home/micah/Documents/conform/test.md
10:22:14[TRACE] Input lines: { "
", "  Hello World", "
", "", "# Test" }
10:22:14[TRACE] Injected formatter regions { { "html", 1, 0, 5, 0 } }
10:22:14[DEBUG] Injected format html:1:5: { "prettier" }
10:22:14[TRACE] Injected format lines { "
", "  Hello World", "
", "", "" }
10:22:14[INFO] Run prettier on /home/micah/Documents/conform/test.md.1.html
10:22:14[TRACE] Input lines: { "
", "  Hello World", "
", "" }
10:22:14[DEBUG] Run command: { "prettier", "--stdin-filepath", "/home/micah/Documents/conform/test.md.1.html" }
10:22:14[DEBUG] prettier exited with code 0
10:22:14[TRACE] Output lines: { "
Hello World
" }
10:22:14[TRACE] prettier stderr: { "" }
10:22:14[TRACE] Injected html:1:5 formatted lines { "
Hello World
" }
10:22:14[TRACE] Applying formatting to /home/micah/Documents/conform/test.md
10:22:14[TRACE] Comparing lines { "
", "  Hello World", "
", "", "# Test" } and { "
Hello World
", "# Test" }
10:22:14[TRACE] Diff indices { { 1, 4, 1, 1 } }
10:22:14[TRACE] Applying text edits: { {
    newText = "Hello World
",
    range = {
      ["end"] = {
        character = 0,
        line = 3
      },
      start = {
        character = 3,
        line = 0
      }
    }
  } }
10:22:14[TRACE] Done formatting /home/micah/Documents/conform/test.md

Describe the bug
One of the best use cases of the injected formatter is for use with Markdown and markup languages that embed code blocks or intertwine different languages together.
What is the severity of this bug?
breaking (some functionality is broken)
Steps To Reproduce

save the repro.lua and test.md into a folder
nvim -u repro.lua test.md, start up the minimal reproduction environment and open the minimal example file. Wait for plugins to install and treesitter to install the html and markdown parsers
run :InspectTree and see that there is html_block as well as a separate section recognized as markdown
:lua require("conform").format(), run the formatter and see that the white space is clobbered surrounding the HTML code block which breaks the markdown parsing
:InspectTree, Inspect the tree post processing and see that now the entire block without whitespace is considered the html_block because white space is removed.

In larger example files, like if there was a paragraph below the header, continuing to run require("conform").format() will continuously clobber the file since the treesitter parser now considers this new block as "HTML"
Expected Behavior
Injected formatter shouldn't destroy the file and should preserve the white space around the content since white space in a mixed language document is typically very important.
Minimal example file

  Hello World

Test
Minimal init.lua
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs { "config", "data", "state", "cache" } do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system {
    "git",
    "clone",
    "--filter=blob:none",
    "--single-branch",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  }
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  {
    "stevearc/conform.nvim",
    config = function()
      require("conform").setup {
        log_level = vim.log.levels.TRACE,
        -- add your config here
        formatters_by_ft = {
          ["*"] = { "injected" },
          html = { "prettier" },
          markdown = { "prettier" },
        },
      }
    end,
  },
  -- add any other plugins here
  {
    "nvim-treesitter/nvim-treesitter",
    config = function()
      require("nvim-treesitter.configs").setup {
        ensure_installed = { "markdown", "html" },
      }
    end,
  },
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme "tokyonight"
-- add anything else here

Additional context
No response

I have an identical config to @mehalter, and I've been facing the same issue.
Version: NVIM v0.9.5
OS: Arch Linux


feat(Checkbox): Indeterminate checkbox

Github Issue or Trello Card
This PR addresses this issue: https://github.com/palmetto/palmetto-components/issues/599

What type of change is this?
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Updating documentation.
[ ] Updating deployment/build pipeline.
[ ] Updating Project Dependencies
[ ] Improving or adding to Test Coverage

Completeness Checklist

[X] TESTS: My changes maintain the baseline required test coverage, as specified by code climate analysis.
[X] DOCS: All new component work is covered in that component's Overview docs.
[X] DOCS: All new component work is covered in a component Playground.
[X] DOCS: All new visual changes or options are covered under relevant components' VisualTests.
[X] My code has no linting or typescript compile warnings.
[X] My work is tied to a Github issue and satisfies the acceptance criteria (if applicable) of the corresponding issue.

Quality Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

UI Checklist

[X] I have conducted visual UAT on my changes/features.
[X] My solution works well on desktop, tablet, and mobile browsers.

For the new isIndeterminate prop, in the playground set the UI element to a boolean instead of text input

.


DO NOT MERGE - draft snyk integration

This PR tests whether or not integration with a snyk GHA will work out of the box. It will be closed soon.

Coverage remained the same at 100.0% when pulling 39ef326025fdac5e85e8cc32a56967600612e093 on nori/test-snyk-integration into f94a0240f4cdfb70e87a8c275e26b6cb4d0ee9d2 on main.


Pr/1718

Nice try  :D
(assuming user error and closing this PR)

Hey. I swear i don't even know what I'm doing. Ive been downloading and
running them with god knows what. I really thought its as simple as
downloading and running the codes in terminal. Im totally lost. But i just
wanna figure ot out and learn myself. Sorry mate. Btw did post my personal
information or what? Im banned already. Dammit. Its been an adventure.
Gonna try to get back my account. Cheers bro
On Thu, 25 Feb 2021, 23:04 Marcin Rataj<EMAIL_ADDRESS>wrote:

Nice try :D
(assuming user error and closing this PR)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ipfs-shipyard/ipfs-webui/pull/1723#issuecomment-785969159,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS55N4AJI5C2HTQRRTYI3K3TAZRJTANCNFSM4YF7MPIA
.

@sheixkh no worries, everyone learns :+1:
If you are looking for a structured tutorial about GitHub try starting with https://guides.github.com/activities/hello-world/


singleton last dimension gives surprising display (squeeze last dimension?)

🐛 Bug
if you open an N x M x 1 image, napari displays a single-pixel wide line with a slider for the first dimension:
napari.view_image(np.random.rand(64,64,1))

I stumbled upon this when I had data that was sometimes RGB, but sometimes not (leaving a singleton in the last dimension).  Certainly, the user could just remember to squeeze the last dimension, but that seems like something we could do for them?

I just want to chime in to say that this conversation makes me rather nervous! 😅 Magical behaviour almost always comes back to bite us in the butt. So I'd be very cautious here and would prefer to find a solution that involved a user-specified switch, e.g. going from rgb=True to using channel_axis= to specify "RGB" or "RGB-like" behaviour (since we are thinking of dropping the layer splitting anyway).

I definitely get that... that's why the title of this topic has a question mark in it.  But I find it hard to imagine a scenario in which a user providing a MxNx1 image really wanted to see an Nx1 image with a slider of M spaces :joy:  ... that doesn't really feel like magic to me, and if a user-specified switch is involved, i think it should be the user who does want the 1 column image who needs to provide the switch

find it hard to imagine a scenario in which a user providing a MxNx1 image really wanted to see an Nx1 image with a slider of M spaces

It's not so hard... It could be the face of a cube, and you would be adding (M, N, 1) data in the context of a pipeline intended to hold (M, N, P) data. Now napari squeezes that dimension that you carefully added following NumPy broadcasting rules as the docs suggest, and we go and remove them?
To be honest I got a bit worked up even writing that! :joy:


support for WOL on multiple NICS

When used on a machine with multiple NICS WOL fails
ie:
eth0: <IP_ADDRESS>
eth1: <IP_ADDRESS>
TV is on subnet <IP_ADDRESS> so the broadcast address must be set to <IP_ADDRESS> it was hardcoded to  which is equal to "<IP_ADDRESS>"

@mm7d, thanks for your PR.
Just to be sure; you added a function which makes it possible to use another broadcast address than <IP_ADDRESS>?
And the default broadcast is still <IP_ADDRESS>, so nothing changes if you don't enter another broadcast address in the configuration file?
If so, I will implement your PR in the development branch and will also update the module on PyPi.
Can you then test that version once I have implemented this?

Indeed, if you do nothing there is no effects for current users.
One small thing, there is a lot of “problems” with the home-assistant braviarc. I do not really like the downloading of that line every time you start Hass. As a custom component is not really different to a normal component I think it makes sense to get this merged.
I am not really sure but I guess the pin code pairing also still works with the updated braviarc too right? Basically a PR to Braviarc and to the Bravia homeassistant component would be a proper solution.
Fijne avond
Martijn

Allright, I will implement your PR so you can test it. As I already made some changes after your PR I have to check if Github can handle that correctly, otherwise I will copy/paste your proposed changes.

I am not really sure but I guess the pin code pairing also still works with the updated braviarc too right?

No, that's not going to work. I have made some changes in braviarc so the connection with the TV is done via PSK instead of the PIN.
That's also one of the points I need to change if I want to merge the current version with my custom component.

Ah ok. I guess If there is a psk in the config, run the psk stuff, if not default to pin/read the “cookie”
I have not looked into that as I only patch WakeOnLan to take the parameter, and the turn_on routines to pass the broadcast config all the way down to that. Defaulting to “<IP_ADDRESS>” on every place where needed not to break things, for stand alone braviarc users.

Closing this PR as it is being taken care of in https://github.com/gerard33/sony-bravia-ha.


Shouldn't need to specify +c/+j/+o for interfaces

Right now interfaces can be {Java,ObjC}->C++ or C++->{Java,ObjC}, but the same interface can't be both, and the role is fixed at codegen time. We should be more flexible.

I'm not 100% sure I agree with this. It seems at first to make sense, however this only really applies to C++ code because the same type can be used both-ways. However in both Java and Objective-C (or more specifically Android and Cocoa) there is a clear idiom what to use for which direction of information flow.
Concrete types are implemented with class/@interface and callback or delegate types with interface/@protocol. For one, it is the only way to implement something akin to multiple inheritence, and tw,o it makes it clear in what direction information flows.
I think keeping up with this idiom is a good idea. +c interfaces fill the role of concrete classes and are more like a class/@interface where as +o +j interfaces are more likely to be used as callbacks or delegates and go more in line with interface/@class. This separation makes it easier to explain to people how to use the generated types as they follow the conventions used in those frameworks/languages. It furthermore gives even more flexibility because the Java/Obj-C developers can for themselves determine how to integrate these interfaces in their type system.

So here are my current thoughts on this:

The original phrasing of this bug is wrong. We actually do want to specify which sides an interface is implemented on, since the resulting code is sometimes different, e.g. protocol vs class after the recent refactor. And there's no need to spit out code to go in both directions if only one is used.
But, we do need the ability to have an interface that's +c +j +o. (There's at least one place in Carousel where we fake this with two nearly-identical interfaces, one +c and one +j +o, and a lot of glue code to use the right one. It's ugly.) There's already support for bidirectional interface translation and wrapping/unwrapping in Java - see b08c54a0caad27ee144ade35a57f60cf4485ed8f .

Since the direction has changed, I'm closing this and have opened #81.

I think having to declare +c/+j/+o is mental overhead.  I guess you have to weigh this mental overhead against the advantages we get:

We can generate different APIs for +o vs +o +c..
The code can be more efficient if we know that it's just +o or just +j.

Generating different APIs: At a high level it seems better to generate the same API for +o and +o +c +j.  For example, let's say you have a +o interface.  Later on, you realize you need to implement it on the C++ side and change it to a +o +c interface.  This breaks existing code.  Also, there's only one style do document and only one style for users to be aware of.
Again, I'm not familiar with the specifics, so maybe there's a strong reason to continue generating two different APIs (strong enough to justify the overhead of +c/+j/+o).
Efficiency: There are runtime efficiency considerations and code size considerations.  I haven't looked at this in a while, but I vaguely remember the runtime efficiency difference to be small when compared with the JNI overhead.  Not sure what the situation is for Objective-C.
For space efficiency, it's a matter of how much dead code the build process can eliminate.  Again, I only vaguely remember the details, but I think it's not straightforward to automatically eliminate unused JNI glue code from the final build.  This adds bloat to the APK.  Unused Java classes won't be JITed (I don't think, at least), so there's no memory cost there.  But unused C++/JNI code still takes up space in memory.
But I guess my broader point is that the +c/+j/+o thing is placing a higher burden on the programmer to make up for a deficiency in the build process.  And that's a reasonable position to take, but I wouldn't consider it ideal.
Summary:  I think the goal described in the bug is a good one.  But I'm also fine closing the bug since a bug tracker may not be the right place to track these vague/long-term things.  And supporting +c +j +o interfaces is a useful step towards that goal, so I think we're in good shape.


br: failed to backup to s3 due to the limit of request rate.

Dup: pingcap/tidb#30087

/type bug

/assign MoCuishle28


Bug fix: Complex type transformer should not be created for empty config

Currently, if someone specifies empty complexTypeConfig in table config, we create a transformer for it. This can cause unintended issues in flows such as parsing JSON data in schema which starts returning null instead of proper value. Currently the only solution is to just remove the config key from the table config if not required.  This PR however fixes this issue.
Sample config which can be used to reproduce the issue
{
    "tableName": "myObjects",
    "tableType": "REALTIME",
    "segmentsConfig": {
      "timeType": "MILLISECONDS",
      "schemaName": "myObjects",
      "retentionTimeUnit": "DAYS",
      "retentionTimeValue": "365",
      "timeColumnName": "lastModified",
      "allowNullTimeValue": false,
      "replicasPerPartition": "1"
    },
    "tenants": {
    },
    "tableIndexConfig": {
      "rangeIndexVersion": 2,
      "jsonIndexColumns": [
        "jsonObject"
      ],
      "autoGeneratedInvertedIndex": false,
      "createInvertedIndexDuringSegmentGeneration": false,
      "loadMode": "MMAP",
      "noDictionaryColumns": [
        "lastModified",
        "jsonObject"
      ],
      "enableDefaultStarTree": false,
      "enableDynamicStarTreeCreation": false,
      "segmentPartitionConfig": {
        "columnPartitionMap": {
          "objectId": {
            "functionName": "Murmur",
            "numPartitions": 2
          }
        }
      },
      "aggregateMetrics": false,
      "nullHandlingEnabled": false
    },
    "metadata": {
      "customConfigs": {}
    },
    "ingestionConfig": {
      "streamIngestionConfig": {
        "streamConfigMaps": [
          {
            "streamType": "kafka",
            "stream.kafka.consumer.type": "lowlevel",
            "stream.kafka.topic.name": "my_objects",
            "stream.kafka.decoder.class.name": "org.apache.pinot.plugin.inputformat.json.JSONMessageDecoder",
            "stream.kafka.consumer.factory.class.name": "org.apache.pinot.plugin.stream.kafka20.KafkaConsumerFactory",
            "stream.kafka.broker.list": "localhost:19092",
            "realtime.segment.flush.threshold.rows": "0",
            "realtime.segment.flush.threshold.time": "24h",
            "realtime.segment.flush.threshold.segment.size": "200M",
            "realtime.segment.flush.autotune.initialRows": "2000000",
            "stream.kafka.consumer.prop.auto.offset.reset": "smallest"
          }
        ]
      },
      "transformConfigs": [],
      "complexTypeConfig": {}
    },
    "isDimTable": false
  }

Schema -
{
  "schemaName": "myObjects",
  "dimensionFieldSpecs": [
    {
      "name": "objectId",
      "dataType": "STRING"
    },
    {
      "name": "jsonObject",
      "dataType": "JSON"
    }
  ],
  "dateTimeFieldSpecs": [
    {
      "name": "lastModified",
      "dataType": "LONG",
      "format": "1:MILLISECONDS:EPOCH",
      "granularity": "1:DAYS"
    }
  ]
}

Record
{ "lastModified":1651001043557, "objectId": "00000000-0000-0000-0000-000000000000",   "jsonObject": {"values": [ {"id": "bob", "names": ["a","b","c","d","e"] } ] }}

Codecov Report

Merging #8600 (bf05f43) into master (b0144cf) will decrease coverage by 34.00%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #8600       +/-   ##
=============================================
- Coverage     70.65%   36.65%   -34.01%
+ Complexity     4314       84     -4230
=============================================
  Files          1692     1692
  Lines         88751    88752        +1
  Branches      13468    13469        +1
=============================================
- Hits          62708    32532    -30176
- Misses        21657    53592    +31935
+ Partials       4386     2628     -1758

Flag
Coverage Δ

integration1
27.23% <0.00%> (-0.01%)
:arrow_down:

integration2
25.65% <0.00%> (-0.04%)
:arrow_down:

unittests1
?

unittests2
14.17% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89836a5...bf05f43. Read the comment docs.

I don't think this is the correct fix.
It is valid to have fieldsToUnnest as null when we don't want to unnest any field.
I don't think this is a bug, but a user config error. When user puts the config, it means user wants to flatten the json field, but unnest is optional. I don't see a good way to prevent this. One option is to add a flag to enable the map flattening, but that is backward incompatible change, and IMO that should be implicit when user puts the complex config.
cc @yupeng9

@KKcorps let's revert this change, until we find a better way to fix. As per docs, https://docs.pinot.apache.org/basics/data-import/complex-type#handle-the-complex-type-with-ingestion-configurations basic flattening is triggered by having complexConfig, and fieldsToUnnest is just an addition for collections.
I don't remember what was the exact issue the user was facing, maybe we can address it in a different way in the code within ComplexTransformer

yup, @Jackie-Jiang is right that this means users want to enable the flattening

Ohh. I wasn't aware of the basic flattening. I will revert this.

That being said. Isn't an empty config doing something incorrect choice in itself? I guess there at least should be an 'enabled' / 'disabled' field.


Increment SwiftArgumentParser dependency to 1.0.3

Increment SwiftArgumentParser dependency to 1.0.3 to pull in a bug fix that would cause subcommand arguments to be folded into the parent command
Motivation:
We'd like to get the fix in https://github.com/apple/swift-argument-parser/pull/397 in order to fix issues with swift run and swift plugin arguments.  For example, swift package plugin foo --verbose would cause the --verbose to be applied to the parent command and not the plugin.

@swift-ci please smoke test

Coordinating the related toolchain repositories as well.

This is awaiting a coordinated merge by @shahmishal since the toolchain also needs to be updated to use the same version.


Predict on new data

Is your feature request related to a problem? Please describe.
Predicting using existing trained model on new data
Describe the solution you'd like
Something just as easy as training and testing, preferably easily readable.
Describe alternatives you've considered
Just like cleaner to call external files but again that leaves access to the database open which is undesirable.
Additional context
Part of v1 specification

https://github.com/DreamingRaven/Nemesyst/pull/21


Use Spatial shader as default for PrimitiveMesh

Fixes #57418

Is a Spatial shader a Basematerial3D, StandardMaterial3D or something else?

Ok changed to Mesh.

Thanks!


Disable tracebacks by default

Python exception tracebacks should be disabled by default, so that error messages are much simpler and not overwhelming. A user option needs to be provided to turn tracebacks on if desired.

#639 implements the support necessary for this issue, but the default is still to log tracebacks. Leaving this issue open until the default is changed.


Add alias support for OCI Charts

Helm charts can have dependencies to other charts.
The root chart and those other charts may come from OCI "repositories" (registries) which the charts have to reference directly currently.
However in the datacenters we have to operate and during the development of our helm charts (dev, staging and production environments) the repositories where those charts are stored change. With the legacy helm repositories we could use repository aliases to avoid global references to other charts.
OCI charts can't currently use repository aliases to point to other helm charts in their dependencies.
Please add alias support for OCI dependencies.
Explaining this using bitnami as an example:
bitnami recommends to use
helm repo add bitnami https://charts.bitnami.com/bitnami

Using bitnamis Drupal chart as an example: https://github.com/bitnami/charts/blob/041766798ed98af83465cab490bb63b73720a79a/bitnami/drupal/Chart.yaml
...
dependencies:
  - condition: mariadb.enabled
    name: mariadb
    repository: https://charts.bitnami.com/bitnami
    version: 9.x.x
  - name: common
    repository: https://charts.bitnami.com/bitnami
    tags:
      - bitnami-common
    version: 1.x.x
...

bitnami would need to patch every Chart to support co-existence of traditional and OCI charts... or use repo aliases:
# bitnais Drupal helm chart
...
dependencies:
  - condition: mariadb.enabled
    name: mariadb
    repository: alias:bitnami
    version: 9.x.x
  - name: common
    repository: alias:bitnami
    tags:
      - bitnami-common
    version: 1.x.x
...

with that change, the helm chart can be used in both tar.gz and OCI formats with dependencies that come from the appropriate repository. Alias support for OCI registries would also make migration to OCI easier.
AND most importantly for our usecase: The repository may be different in every datacenter: it may be hosted inside said datacenter without access to the internet (yes, this is a thing - it's non negotiable actually)

I appreciate this issue and I've talked with others about it in the past.
Repositories are easy to alias. When they are added you know the URL and you get an index.  You can't get anything like an index file and there is no ability to search them. The way we would need to handle those are different.
At the same time, it could be nice to be able to override something like https://charts.bitnami.com/bitnami without the upstream author making a change or the need to patch each chart. I wonder if there is an opportunity for an overrides file.
In any case, I think the change would need to be written up as a Helm Improvement Proposal.

I don't consider this a feature request actually, I guess I wrote the issue to positively. This is a regression in functionality! (and yes I am aware that OCI is still experimental)
I disagree about the complexity tough: the repository format/api is completely unrelated to the complexity of implementing alias functionality.
I agree that adding the ability to override the repository URL as you suggest would need a HIP. That would be an interesting alternative to the alias functionality! I think that the alias functionality is sufficient for my usecase.
Care to write a Helm Improvement Proposal for your idea?

The issue is closed as completed, but I haven't found this to be implemented. Am I missing something?
I have a similar issue. Dev, Stage, and Prod environments use different registries and dev cannot access prod (and visa versa) so previously I used an alias to reference a base chart from the repository added to my environment. But with OCI I would need to build and push a chart 3 times with a different target OCI Registry (for each env), which is not an option.
This is the only thing preventing me from migrating to OCI.

This has to be reopened , something essential!

@gjenkins8 , The HIP already exists https://github.com/helm/community/pull/259 , However the issue is marked completed

This is blocking my ability to use aliases and deploy across multiple environments using aliases - is it possible to reopen this issue please or provide guidance if it has been implemented?

There is PR that seems to do the job: https://github.com/helm/helm/pull/11771
This issue seems to be closed but with no fix, while the proposal done to implement the fix is still being ignored.
Is this feature request/improvement being disregarded for a particular reason? We are moving our charts to an OCI repository and this limitation had put our migration into a stop.

@gjenkins8 This is necessary feature. HIP and code changes are waiting to be merged and released, can this be prioritized for upcoming release

It would be a great relief for lot of peopled when this feature is released considering the PR already exist from more than an error to be Merged

I believe the issue got closed by the bot because it was stale. Its still a valid issue. I'll follow up to see if it can be reopened.

Reopened. Thanks @banjoh for adding as an agenda item for the next Helm project meeting.
For future ref – for everone – there are so many issues it's not always easy to keep up with all comments. Bringing up at the weekly Helm project meeting is a valid and useful thing to do.

Is there any update for the feature?


New JSON format for v4.0 is not working

Hi,
I've tried implementing an example of the JSON format (#113) for v4.0 of this solution. However, I cannot get an image to display: it simply returns a 404.
My example page is visible at http://<IP_ADDRESS>/ and you can see the image returns a 404.
The image object exists in the bucket at https://image-handler-testing.s3.amazonaws.com/subfolder/4simon.jpg
Any thoughts?
Some background:
I'm using the Serverless Image Handler on a number of production websites. In the last few days a slightly older version of the code seems to have stopped working due to issue #70. That problem was resolved in v4.0, which then gave rise to issue #112. The suggested workaround for that one seems to be using a JSON request, but now that gives rise to this issue. As I mentioned, this is in use on production websites and I'm urgently seeking some sort of resolution.
Thanks,
Conor

Hi Conor,
I had a similar problem (ie was using the old version in production and had to quickly update to the new version). In my case, it was because AWS updated the lambda execution environment which caused the old version to break.
I can't help you with your specific issue that you mention here, but I have managed to get the new v4.0 version working with the old Thumbor request style. In order to achieve it I had to fix the following

make it work with subfolders
add the security hash functionality
fix it so that it would provide webp automatically for browsers that support it
fix the way thumbor requests were translated into json requests

If you decide you want to go down the Thumbor request route, I could give you some pointers.
john

Hi John,
Yes, any pointers would be hugely appreciated. Ideally I want to stick with the Thumbor request route as far as possible, as there is a lot of code to change on the websites otherwise.
Conor

Sure. Probs best by email rather than here. Contact me on bosley (dot) john
@ gmail
On Tue, 23 Jul 2019, 18:21 lithium-oxide<EMAIL_ADDRESS>wrote:

Hi John,
Yes, any pointers would be hugely appreciated. Ideally I want to stick
with the Thumbor request route as far as possible, as there is a lot of
code to change on the websites otherwise.
Conor
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/serverless-image-handler/issues/124?email_source=notifications&email_token=ACMDTIO4V2DC2JSAZVIK3B3QA443FA5CNFSM4IGGVW32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2T2UZY#issuecomment-514304615,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACMDTIOF2NW75IER3UGXGDTQA443FANCNFSM4IGGVW3Q
.

Thanks John. I've popped you an email.
Conor

Same problem here :( production system down with older pre-v4 version because of underlying Lambda changes apparently. Also need to stick to Thumbor for now as UI changes would take more time...  If you could post pointers on how to get v4 to work with thumbor without changes to the URL it would be great.
Thanks !

@samlll42-github @lithium-oxide
I have created a post on stackoverflow with some information on how I got the new version working with Thumbor style requests. Hope it is useful :-)
John.

Hey all, the patch for the Lambda Execution Environment update affecting v3.x has been published and is available at (#127): https://solutions-reference.s3.amazonaws.com/serverless-image-handler/v3.1.1/serverless-image-handler.template
Hope this resolves the issue!

We are closing this issue, but please feel free to open the issue again if you any other support.


Add checkbox in region creation form that allows to not copy languages and translations of the source region

Motivation
Add a checkbox that allows to not copy the language nodes and translations upon region creation using the copy functionality, because they are often not needed.
Proposed Solution
Add a default-checked checkbox that upon unchecking prevents the languages nodes and translations of the source region to be copied to the new region.
Alternatives
None
User Story
As a Service Team memeber I need the translations of copied regions in the Malte App in order to fulfill the requirements of the Malteser, but I don't want that functionality always.

This would also be a workaround of #3048

@charludo While testing the checkbox I had one case where not all pages were copied.
I tried to reproduce it, but wasn't able to:

New checkbox was checked (to include translations)
Region that pages were copied from: Testumgebung
https://cms-test.integreat-app.de/regions/2991-1/edit/
https://cms-test.integreat-app.de/2991-1/pages/de/

Is that the known issue of the process timing out when copying pages with translations or something else?

I assume it's the same problem we've been having with the old process - it simply times out while trying to copy everything. For Integreat generally we will need the checkbox unchecked so that no translations get copied. Nevertheless, for Malte we do need the translations, so if the problem persists, especially within Malte, that content only gets partially copied, we need to investigate further :)


Issue #20 - Adds Cocoapods support

This pull request adds Cocoapods support.
Additionally tested and working with carthage as well.
I pushed a tag called 0.0.1.
to test:
target 'Foo' do
  use_frameworks!
  platform :ios, '11'

  # Pods for Foo
  pod 'RSParser', :git => 'git@github.com:dcilia/RSParser.git', :branch => 'issue_20'

  target 'FooTests' do
    inherit! :search_paths
    # Pods for testing
  end

end

Carthage:
$ carthage build --no-skip-current

or add to your Cartfile
github "dcilia/RSParser" "issue_20"

I’d definitely like to add Cocoapod support. But I notice that a whole bunch of files are being moved in this pull request. Is the new location a requirement of Cocoapod support? (Because I’d rather not move them if we don’t have to.)

Not a requirement for Cocoapods - but there is a line in the pod spec to specify your source code locations.  I thought it would be a bit cleaner that all the source files were inside of a Sources folder (the actual tree structure has not changed, just that I grouped them inside of Sources).  Additionally, if you want to add Swift Package Manager support at a later time, the Sources folder structure is a requirement.
Feel free to make changes or close this if you want to tackle at a later time 👍

I totally did not know about the Sources requirement for the Swift Package Manager (which I do want to support).

Thanks for doing this!
I just merged, and then I updated the podspec. Would you check to make sure I updated the spec correctly?

@brentsimmons looks good - except I have a typo in there - we should remove
s.platforms
s.homepage     = "https://github.com/brentsimmons/RSParser"
  s.license      = { :type => "MIT", :file => "LICENSE" }
  s.author             = { "Brent Simmons" =><EMAIL_ADDRESS>}

  s.platforms

  #  When using multiple platforms
  s.ios.deployment_target = "9.3"
  s.osx.deployment_target = "10.10"
  s.watchos.deployment_target = "2.0"
  s.tvos.deployment_target = "9.0"

also, need to to push the tag 0.0.1 or, update the podspec version and push the appropriate tag. 👍

When you run $ pod spec lint in terminal and you get a valid output (including pushing the tag) I believe you can simply push to the pod spec repo by following:
How do I update an existing Pod?
Create your Podspec as described above.
Run pod spec lint to check for errors.
Submit your Podspec to Trunk with pod trunk push NAME.podspec

see
https://guides.cocoapods.org/making/specs-and-specs-repo.html


Create a release/latest branch to automatically deploy stable versions on render.com

Is your feature request related to a problem?
I currently have auto-deploy enabled on render.com, which is monitoring the main branch. However, the main branch is less stable compared to the release/* branches. If I switch to the release/0.11.0 branch for stability purposes, auto-deploy will not function since no changes will be made to that particular branch.
Describe the solution you'd like
Create a release/latest branch that mirrors the latest release branch. This way, switching to the release/latest branch will automatically trigger deployment whenever a new version of memos is released.
Additional context
No response

Sounds like easy implementation, high value.


[Go Live][May 31]

Docs Build status updates of commit 85cbcd0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/feed.atom
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


i3lock-blur: pull patch pending upstream inclusion for -fno-common to…

…olchain support
Without the change build on upstream gcc-10 fals as:
ld: i3lock-unlock_indicator.o:/build/source/x86_64-pc-linux-gnu/../../source/unlock_indicator.c:39:
  multiple definition of `input_position'; i3lock-i3lock.o:/build/source/x86_64-pc-linux-gnu/../../source/i3lock.c:73: first defined here

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 173121 run on x86_64-linux 1

1 package built:

i3lock-blur


(refactor)(ci): triggers additional pipeline for infra chaos on aws platform

Triggers a separate pipeline for infra chaos on AWS.

Signed-off-by: ksatchit<EMAIL_ADDRESS>

@ksatchit , Are the infra chaos litmus tests running from a different branch?

yes @yudaykiran


mongoose issues

os - ubuntu 14.04
node version - 6.9.4
stack trace from error -
appoptics:warn ao.bind - no context Error: CLS NOT ACTIVE
at Object.exports.bind (//node_modules/appoptics-apm/lib/index.js:638:17)
at Query._wrapCallback (//node_modules/appoptics-apm/lib/probes/mongoose.js:91:37)
at Query.findOne (//node_modules/mquery/lib/mquery.js:1811:19)
at Query._findOne (//node_modules/mongoose/lib/query.js:1522:22)
at //node_modules/kareem/index.js:250:8
at //node_modules/kareem/index.js:23:7
at _combinedTickCallback (internal/process/next_tick.js:67:7)
at process._tickDomainCallback (internal/process/next_tick.js:122:9)

every mongoose call
we use mongodb 3.4 with following npm packages:
"mongodb": "2.2.34",
"mongodb-migrate": "2.0.2",
"mongoose": "4.13.14",
"mongoose-deep-populate": "2.0.3",
"mongoose-field-encryption": "0.0.5"
"appoptics-apm": "5.9.0"

thank you. i appreciate your help.
are you using mongoose with promises as opposed to callbacks?

thanks, I"ll try this version next week

still same issue :
2018-12-27T12:30:37.043Z appoptics:warn ao.bind() - no context Error: CLS NOT ACTIVE
at Object.exports.bind (/var/www/techsee-api/node_modules/appoptics-apm/lib/index.js:638:17)
at model.Query._wrapCallback (/var/www/techsee-api/node_modules/appoptics-apm/lib/probes/mongoose.js:112:37)
at model.Query.Query.findOne (/var/www/techsee-api/node_modules/mquery/lib/mquery.js:1811:19)
at model.Query.Query._findOne (/var/www/techsee-api/node_modules/mongoose/lib/query.js:1522:22)
at /var/www/techsee-api/node_modules/kareem/index.js:250:8
at /var/www/techsee-api/node_modules/kareem/index.js:23:7
at _combinedTickCallback (internal/process/next_tick.js:132:7)
at process._tickDomainCallback (internal/process/next_tick.js:219:9)
same error also on node v8.12 ...

I see warnings also on 'mongoose-deep-populate' related queries :
2018-12-27T12:45:10.468Z appoptics:warn ao.bind(anonymous) - no context Error: CLS NOT ACTIVE
at Object.exports.bind (/var/www/techsee-api/node_modules/appoptics-apm/lib/index.js:638:17)
at model.Query. (/var/www/techsee-api/node_modules/appoptics-apm/lib/probes/mongoose.js:102:42)
at model.Query.Query.exec (/var/www/techsee-api/node_modules/mongoose-deep-populate/lib/plugin.js:49:20)
at model.Query.Query.then (/var/www/techsee-api/node_modules/mongoose/lib/query.js:3147:15)
at Object.getById (/var/www/techsee-api/server/models/room.js:581:14)

@Igor-Techsee - thanks for checking this out and I'm sorry it didn't fix the issue for you. I have a couple questions:

/var/www/techsee-api/node_modules/kareem/index.js:250:8
could you expand a bit on how you're using kareem? we test findOne specifically and, at least in our tests, we manage to maintain context. So, based on the stack trace, it seems that context has been lost before Query.Query._findOne() is being called.

also, are you seeing these only on findOne() calls or are you seeing them on add() calls as well?

I see warnings also on 'mongoose-deep-populate' related queries
thanks for this. we currently don't test any plug-ins for mongoose. I'll add a test and see if I can find a problem. If you have any details on how you use it I'll try to test for that specific case.

it happens on every call

I just want to confirm that this is running in an http/https server context.

It happens on every findOne, in dashboard I can see find/update queries


Fix parseFill to check for fill ident before attempting to parse an expression

The previous parseFill would try to parse an expression and only unscan
one token when it failed. This caused it to not put back the correct
number of tokens with some expression.
Now it has been modified to check for the fill ident ahead of time and
then use ParseExpr() to parse the call. If the expression fails to parse
into a call, it will send an error instead of trying to continue with an
invalid parser state.
Fixes #6543.

@benbjohnson

:+1:  lgtm


RFC 0015 inconsistency with RFC 0008 in ~thread decorator

https://github.com/hyperledger/aries-rfcs/tree/5cc750f0fe18e3918401489066566f22474e25a8/features/0015-acks#explicit-acks uses fields named myindex and lrec but https://github.com/hyperledger/aries-rfcs/tree/64e5e55c123b2efaf38f4b0911a71a1c40a7f29d/concepts/0008-message-id-and-threading#threaded-messages uses sender_order and received_orders for these field names.
I think RFC 0008 is correct and RFC 0015 should be corrected.  Agree?

Correct - thanks for that.  Please go ahead with a PR.  Perhaps add a change log and a mention there, but it is a typo in an example, not a version-worthy change. Very unlikely anyone will be affected by the change.

See PR https://github.com/hyperledger/aries-rfcs/pull/458

closing this. Merged in PR #459


browser index items for Storage, localStorage and sessionStorage are not correct

The index is completely missing the Storage interface, which localStorage and sessionStorage are implementations of. They are also missing clear(), length, get and removeItem.
I'll open a PR to update the index.

Resolved via #878


Malformed configuration file

Hello,
Thanks for your script!
I followed your instructions and the the following error. Any thoughts?
osmc@osmc-rpi:~/TV Shows$ /usr/local/bin/flexget exec
2015-11-25 14:20 CRITICAL manager                       mapping values are not allowed here in "", line 14, column 55: ... s.info/rss.php?user_id=284950rss: http://showrss.info/rss.php?us ... ^

Malformed configuration file (check messages above). Common reasons:
o Indentation error
o Missing : from end of the line
o Non ASCII characters (use UTF8)
o If text contains any of :[]{}% characters it must be single-quoted (eg. value{1} should be 'value{1}')
Reason: mapping values are not allowed here
----> MOST LIKELY REASON: Missing : from end of the line!
Check configuration near line 13, column 54
Fault is almost always in this or previous line
2015-11-25 14:20 CRITICAL manager                       Failed to load config file: Config file is not valid YAML
Could not start manager: Config file is not valid YAML

Thank you for reporting @megrimm . Can you please verify if the URL you used contains the character &? I'll work in a fix for that. In the mean time you might want to edit manually the file .raspberry-osmc-automated/flexget/config.yml and correct the URL for your RSS. I believe this is the reason.

Problem is fixed now, when an URL contained the symbol & the substitution was going wild (& is a special char in sed command).
To test the solution the install script should be executed again, although in your case it will be much cheaper if you just edit the file .raspberry-osmc-automated/flexget/config.yml and edit the line 14 to leave rss: http://showrss.info/rss.php?user_id=284950 (important to respect the spaces for identation, don't use tabs)

pulled 541e708 but still getting similar error?: i can keep running the script instead of editting .raspberry-osmc-automated/flexget/config.yml to nail the bugs if you want...
error: Couldn't find a setup script in /home/osmc/Scripts/raspberry-osmc-automated/flexget
2015-11-25 17:04 CRITICAL manager                       mapping values are not allowed here in "", line 14, column 55: ... s.info/rss.php?user_id=284950rss: http://showrss.info/rss.php?us ... ^

Malformed configuration file (check messages above). Common reasons:
o Indentation error
o Missing : from end of the line
o Non ASCII characters (use UTF8)
o If text contains any of :[]{}% characters it must be single-quoted (eg. value{1} should be 'value{1}')
Reason: mapping values are not allowed here
----> MOST LIKELY REASON: Missing : from end of the line!
Check configuration near line 13, column 54
Fault is almost always in this or previous line
2015-11-25 17:04 CRITICAL manager                       Failed to load config file: Config file is not valid YAML
Could not start manager: Config file is not valid YAML

hmmmmmm .... here is my line 14:
rss: http://showrss.info/rss.php?user_id=284950rss: http://showrss.info/rss.php?user_id=284950rss: http://showrss.info/rss.php?user_id=284950rss: Deleting default OSMC folders.hd=nullrss: http://sho...... continued for as many times i ran script
seems line 14 is not "replaced" when script is run more than once it is just "added" to?

The placeholder variable CONFIG_RSS_FEED is replaced in the first execution of the script. There is no way that executing it more times will fix anything unless you restore the config.yml at its original state.


docs: standardize folder structue indicators

Fix the misalignment on README.md
Standardize the folder structure indicator on CONTRIBUTING.md

Do I've to do something extra to have this PR merged?


Remove pre-commit-uv and uv from environment definition

https://github.com/ComPWA/policy/issues/407 has resulted in a subtle bug: pre-commit-uv pulls in uv into the virtual environment, which results in caching problems if the environment is installed through a global installation of uv (a global uv installation is required since https://github.com/ComPWA/policy/issues/333).
It should instead be recommended to install pre-commit-uv globally as well once with
uv tool install pre-commit --with pre-commit-uv --force-reinstall

(see these instructions.

Actually, the caching problems may originate from the fact that the version of packages that are installed in editable mode with a dynamic version through setuptools-scm.
The problem pops up irregularly, so I'm not sure yet. It could also be caused by packages that do not have a src/ folder.


xGroup fails on group 'Users'

Very simple resource:
 Node $NodeName
 {
    xGroup GroupUsers
    {
        Ensure = "Present"
        GroupName = "Users"
    }
 }

In Version <IP_ADDRESS> this gets me the exception:
Exception calling ".ctor" with "2" argument(s): "Server names cannot contain a space character."
Interestingly enough, trying the same with Resource Group (MSFT_GroupResource) gives the error:
Credentials are required to resolve the domain account INTERACTIVE
this happened on non-Domain machines.
So I can not check whether any user is a member of the users group.

Hi @hahndorf  - I'm looking into some other issues with this Resource ATM so I'll take a look at this as well.

@hahndorf Odd. I can't reproduce this error with xGroup. Added a unit test with an empty group just in case.
What value did you use for $NodeName? Did that have a space?
@PlagueHO Have you been able to repro this error?

@kwirkykat - I haven't looked at this one yet. I'll take a look tomorrow (Saturday) and see if I can replicate.

What I tried:
New fresh VM 2012 R2
Install-Module -Name xPSDesiredStateConfiguration

Created a file: userstest.ps1:
 Configuration MyUserConfig
 {

    Import-DscResource –ModuleName 'xPSDesiredStateConfiguration'
    Node "localhost"
    {
          xGroup GroupUsers
          {
              Ensure = "Present"
              GroupName = "Users"
          }
    }
 }

 MyUserConfig

then run the script to create the MOF
.\userstest.ps1

then:
 Start-DscConfiguration -Wait -Verbose -Path .\MyUserConfig

results in:
 Exception calling ".ctor" with "2" argument(s): "Server names cannot contain a
 space character."
     + CategoryInfo          : InvalidOperation: (:) [], CimException
     + FullyQualifiedErrorId : ConstructorInvokedThrowException,Microsoft.Power
    Shell.Commands.NewObjectCommand
     + PSComputerName        : localhost

tested on non-AD connected servers. I tried different servers, but they may all have the same underlying  OS base image. I just tried again on my Windows 10 (10586.494) workstation, same error.

I see this issue now. Looking into it


Add STREAM_LENGTH and POOL_SIZE to test_constants

Only one of these is used, and in only one place, as of this commit,
but they will be used widely after further development.

While the test failures in the other languages look bona fide, this is Python-green. Merge with the rationale that changes under src/python/src/grpc can't possibly affect the other languages?


Not able to show toastr at bottom of page

Adding
 #toast-container{
   top: 70px;
 }

by default will not allow toastr to be show at bottom of the page. It would be difficult to override the css and show toast-container to bottom of the page. But instead we could inform the user to paste the css code as shown in toastr placement of my README.md file

As I said in the Readme, this is an opinioted gem and it assumes you have a navbar.
If you want it to be at the bottom, you will need to edit that #toas-container


I cant see the pull requests I make

My confusion
I created the group norms on collaboration/readme. made a branch called group_norms and uploaded to the project github. I opened a pull request. However, when I check the group project, ET6-foundations-group-11, I don't see the pull request, but sees it on ET6-practice-code-review/pull/7. Any clarification please? see the links below:

expected to see my pull request here

sees it here instead

Confusion solved. Mustafa suggested I close the initial  pull request and open one in the main group project repository. I have done this, and can now see my pull request in the right place


The library consumes a lot of ram (the garbage collector is useless.) and tesseract 5 update is required.

Hello there
i am using the project to make an api.
Even though I use a garbage collector, the ram usage does not decrease.
the last 1.3gb ram usage stopped, but this value is too high.

Finally, the project needs tesseract 5 update. Currently we cannot use tesseract 5 assemblies in the project.
thanks @charlesw @peters @grimmi .

Tesseract 5 had a compatibility issue up until last week. It works again but you have to build it yourself. That team encourages the use of the latest builds.

With tesseract 4 the ram usage of the library is very bad.
I think this can be solved with tesseract 5. Currently tesseract 5 compilations give binding errors on this library.
I hope there will be an update soon.

Yes, I confirm. With tesseract 4.1 and .Net5 in a linux container the ram usage does not decrease.
Pods restarts due to memory limit.


WIP: fix suppression of 'make test_e2e' in Jenkins

Closing in favor of https://github.com/intel/pmem-csi/pull/1023


v1.0.0-rc3 gives "Only React Components can be mounted."

Hi, sorry if this issue might be duplicate, but I did not see anything similar.
I just updated to React 0.14 and React-Router 1.0.0-rc3 and I get a very annoying error that I cannot seem to solve.
Here is a code snippet:
import React from 'react'
import ReactDOM from 'react-dom'
import { Router, Route } from 'react-router'

(function () {
    class Yoghurt extends React.Component{
        constructor() {
            super();
        }
       render() {
           return (
Hello World
)
       }
    };

    var routes = (
        <Route path="/" component={Yoghurt}></Route>
    );

    ReactDOM.render(<Router routes={routes} />, document.getElementById('app'));
})();

And the error message is:
Warning: Only React Components can be mounted.
Uncaught TypeError: instance.construct is not a function

What is the cause for this? I know that it may be something trivial, but It's bugging me for some time now.
Thanks in advance.

You're using JSX as an argument - use the following;
var routes = (
  <Router>
    <Route path="/" component={Yoghurt}></Route>
  </Route>
);

ReactDOM.render(routes, document.getElementById('app'));

Nope, that doesn't solve it :(

as you just upgraded, try this first:
rm -rf node_modules && npm install

Wow, that actually solved it, but I know for sure I deleted node_modules and reinstalled them.
Thanks very much!

you're welcome


Update version: Git.Git version 2.46.0

Pull request has been created with komac v2.5.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

@wingetbot run

https://github.com/microsoft/winget-pkgs/pull/165183#issuecomment-2266143950

@wingetbot run

@wingetbot run

@wingetbot run

@wingetbot run

This package installs and launches normally in a Windows 10 VM.

This package installs and launches normally in a Windows 10 VM.

This package installs and launches normally in a Windows 10 VM.


Stream still publishing after on_publish callback fail

Using the latest 2.0.263 release
Seems that SRS does not reject publisher if on_publish says to decline it:
gcore_srs.1.lyw11xmjlckg@docker-desktop    | [2019-04-23 19:37:17.240][error][1][107][11] error response code=400. ret=3064(Resource temporarily unavailable)
gcore_srs.1.lyw11xmjlckg@docker-desktop    | [2019-04-23 19:37:17.240][error][1][107][11] http post on_publish uri failed. client_id=107, url=http://admin:3001/api/srs/on_publish, request={"action":"on_publish","client_id":107,"ip":"<IP_ADDRESS>","vhost":"__defaultVhost__","app":"in","tcUrl":"rtmp://localhost:1935/in","stream":"12","param":"?adsfqwe"}, response={"code, code=200, ret=3064(Resource temporarily unavailable)
gcore_srs.1.lyw11xmjlckg@docker-desktop    | [2019-04-23 19:37:17.240][error][1][107][11] hook client on_publish failed. url=http://admin:3001/api/srs/on_publish, ret=3064(Resource temporarily unavailable)
gcore_srs.1.lyw11xmjlckg@docker-desktop    | [2019-04-23 19:37:17.240][error][1][107][11] http hook on_publish failed. ret=3064(Resource temporarily unavailable)
gcore_srs.1.lyw11xmjlckg@docker-desktop    | [2019-04-23 19:37:17.240][error][1][107][11] stream service cycle failed. ret=3064(Resource temporarily unavailable)

Looks like there is just a lag between denial and client disconnect


Deployment from app catalog to site collection: "An unexpected error has occurred"

Category

[x] Bug

Describe the bug
Attempting to deploy bcameron1231's module from https://github.com/bcameron1231/SharePoint-Framework/tree/master/react-hubsite-securitytrim-navbar, During deployment from App Catalog, receive:
"Sorry, something went wrong
An unexpected error has occurred.
Technical Details
Troubleshoot issues with Microsoft SharePoint Foundation.
Correlation ID: 4a64499f-10e8-b000-0c6a-7ac518357843
Date and Time: 4/16/2020 10:44:49 AM"
Steps to reproduce

Download https://github.com/bcameron1231/SharePoint-Framework/tree/master/react-hubsite-securitytrim-navbar
Build and deploy per instructions on README.md, to include CDN hosting and proper bundling and packaging of sppkg
Encounter error

Expected behavior
App deploys to site collection successfully.
Developer environment

OS: Win 10 Pro x64 2004
Framework: React / TypeScript, node 12
Browsers: Chrome v80, Firefox Developer 76.0b5
Tooling: VS Code

Additional context
App Catalog is about 48 hours old by now. I have no issues building this app and running it from the local dev server for CDN against a live tenant sharepoint site within the target hub.

Node 12 isn't supported with SPFx... not sure if that's related. As it's a custom solution provided by someone else, suggest you submit the issue to their REPO.


Plugin project :path_provider_macos not found. Please update settings.gradle.

I just upgrade project file (android/ios folder) by create new project and got this warning.
[✓] Flutter (Channel dev, 1.19.0-1.0.pre, on Mac OS X 10.15.4 19E287, locale
    en-VN)
    • Flutter version 1.19.0-1.0.pre at /Users/tbm/dev/flutter_sdk/flutter
    • Framework revision 456d80b9dd (12 days ago), 2020-05-11 11:45:03 -0400
    • Engine revision d96f962ca2
    • Dart version 2.9.0 (build 2.9.0-7.0.dev 092ed38a87)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/tbm/Library/Android/sdk
    • Platform android-R, build-tools 29.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.9.1

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[!] IntelliJ IDEA Community Edition (version 2020.1.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] VS Code (version 1.44.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1

[✓] Connected device (1 available)
    • iPhone 11 Pro • CDE77D0C-DF86-4F52-9E87-F3F4B92FB0B8 • ios •
      com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)

! Doctor found issues in 1 category.

Possibly related to #57846.

my case is run code normal

Hi @tbm98
can you please provide your flutter run --verbose,
your pubspec.yaml
and a reproducible minimal code sample.
Thank you

@tbm98
Please add in your flutter app -> android -> settings.gradle and it should solve
def flutterProjectRoot = rootProject.projectDir.parentFile.toPath()

def plugins = new Properties()
def pluginsFile = new File(flutterProjectRoot.toFile(), '.flutter-plugins')
if (pluginsFile.exists()) {
    pluginsFile.withReader('UTF-8') { reader -> plugins.load(reader) }
}

plugins.each { name, path ->
    def pluginDirectory = flutterProjectRoot.resolve(path).resolve('android').toFile()
    include ":$name"
    project(":$name").projectDir = pluginDirectory
}

if you disagree please write in the comments and I will reopen it
Thank you

duplicate of https://github.com/flutter/flutter/issues/46304

I just ran again and it no longer has an error. even though I haven't changed anything.


Advance ASFF report #8462

Description
Advance the ASFF report according to the linked issue description.

@Maffooch and @madchap please review.

Isn't it easier to use this?
if item.get("Remediation"):
    mitigation=item.get("Remediation").get("Recommendation").get("Text")
    references=item.get("Remediation").get("Recommendation").get("Url")
else:
    mitigation=None
    references=None
result.append(
    Finding(
        title=item.get("Title"),
        description=item.get("Description"),
        date=dateutil.parser.parse(item.get("CreatedAt")),
        mitigation=mitigation,
        references=references,
        severity=self.get_severity(item.get("Severity")),
        active=True,  # TODO manage attribute 'RecordState'
        unique_id_from_tool=item.get("Id"),
    )
)

I thought also like this, but I did not want to write "None" into the mitigation as it could be interpreted wrong from developers who fix it.

I thought also like this, but I did not want to write "None" into the mitigation as it could be interpreted wrong from developers who fix it.

In my opinion, mitigated and references are defined as models.XXXField(..., null=True, blank=True, ...) so they are None by default. But I understand where your note is going. I would like to know the opinions also other people from the community.

I tested it, works fine.

Please review @madchap, @Maffooch

Please review @cneill


custom fields: use elasticsearch field abstractions

closes https://github.com/inveniosoftware/invenio-records-resources/issues/356

WIP: Would be nice to not need the to_dict. Creating a layer of abstraction (in invenio-search?) for this would make later changes due to compatibility/opensearch migrations transparent at this level.

It was decided to block the PR until the compatibility layer has been implemented (merged) in the other layers. Then the extra layer in invenio-search will be implemented.

closed in favour of Mapping clases


Message Passing with SparseTensors

[x] Remove tracing in __collect__
[x] Add support for SparseTensor in MessagePassing
[x] Better handling of overloads
[x] Bipartite graph support
[x] Improved SparseTensor JIT functionality (tests currently need torch-sparse from master)

The following GNN operators have been already adjusted to support the points above:

[ ] AGNNConv
[ ] APPNP
[ ] ARMAConv - NB: no MessagePassing module yet
[ ] CGConv
[ ] ChebConv
[ ] DNAConv
[x] EdgeConv
[ ] DynamicEdgeConv - NB: this needs to wait on https://github.com/rusty1s/pytorch_cluster/pull/68
[ ] FeaStConv
[x] GATConv
[ ] GatedGraphConv
[x] GCNConv
[x] GINConv
[x] GINEConv
[ ] GMMConv
[ ] GraphConv
[ ] GravNetConv - NB: this needs to wait on https://github.com/rusty1s/pytorch_cluster/pull/68
[ ] HypergraphConv - NB: needs overall refactoring
[x] NNConv
[x] PointConv
[ ] PPFConv
[ ] RGCNConv - NB: this needs to wait for better handling of multiple propagate types
[x] SAGEConv
[ ] SGConv
[ ] SignedConv
[x] SplineConv
[ ] TAGConv
[ ] XConv - NB: this needs to wait on https://github.com/rusty1s/pytorch_cluster/pull/68

Codecov Report

Merging #1309 into master will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #1309      +/-   ##
==========================================
- Coverage   87.92%   87.91%   -0.01%
==========================================
  Files         165      165
  Lines        6441     6446       +5
==========================================
+ Hits         5663     5667       +4
- Misses        778      779       +1

Impacted Files
Coverage Δ

torch_geometric/nn/conv/sage_conv.py
97.29% <85.71%> (-2.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a934e8e...b12e8fc. Read the comment docs.

This is starting to look really crisp. :-)
I think one additional thing that should be done is to expand the docstring for jittable() to include the important points of how to implement a jittable class, but that can come later.

I feel like that deserves its own tutorial in the documentation. It's on my TODO.


Button missing in wunderlist

From a user:

toggl with wunderlist not working. I just install Sierra on my mac and make all that I need to use this feature, but no "Start" button near ticket... What to do?

Environment details

User Agent: 5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.98 Safari/537.36
Extension version: 1.1.3

Can't seem to reproduce this on Chrome/Sierra.
I'm running 1.1.4. Maybe they just need to update the extension.
Here's what it looks like for me

Working on 1.1.4.
Went back to tag 1.1.3. Not working there. Apparenly just needs to update.


MM-47879 - add telemetry track to open/close onboarding task list act…

Summary
This PR adds telemetry to the open/close events over the onboarding task list item.
Ticket Link
https://mattermost.atlassian.net/browse/MM-47879
Related Pull Requests
n/a
Screenshots

Release Note
NONE

@marianunez @amyblais this is a cloud cherry-pick candidate, a small PR for adding some telemetry, no functionality affected at all.

@stevemudie @dontoisme this track events additions can be validated post merge 👍

@dontoisme - Is there Telemetry documentation impact for this PR, or is this a change we're making that doesn't need to be communicated externally?

Friendly follow-up on this, @dontoisme. Is there telemetry documentation updates we'd like to see made associated with this change? My read of this is that telemetry updates aren't needed.

@cwarnermm I don't think this warrants external communication but I don't know the principles we apply to make sure we are communicating tracking changes. This change is small and the intent is to measure interactions of the onboarding experience so we can make a future decision on how to improve the feature.

Thank you for confirming, @dontoisme, and I agree that we need clear principles in place to know when to communicate tracking changes. Revisiting the telemetry documentation is on the docs roadmap this year, and this gap will be addressed as part of that effort.


Update tutorial006.py

The size parameter was not appended into the results.

📝 Docs preview for commit 4254b2cfe5e8589bd396a38c5c5da2e879daa539 at: https://dcbd9b93.fastapitiangolo.pages.dev

📝 Docs preview for commit 83684dfb1519c0664e8900607eb5c185d42c28fe at: https://7abfa613.fastapitiangolo.pages.dev

📝 Docs preview for commit e31090dec27ecf0b4b0e9ed43fd6e6d3d9f1fb01 at: https://9d7f0a09.fastapitiangolo.pages.dev

Cool, thanks @MuhammadAshiqAmeer! :coffee:
And thanks @svlandeg :cake:

@svlandeg , @tiangolo  Thanks and looking forward to contribute more : )


Human friendly interface for duration=* tag

It would be nice if ID parsed the duration=* tag and made a more human readable interface for it, converting to and from the ISO 8601 standard (for example). Currently it's just a text field where people add whatever they want. The motivation behind this is better standardization for the OSM database especially since ID is used by occasional mappers. It would be a similar idea as is being discussed in #974 for opening_hours=*. I could imagine it being as simple as text boxes for each years, months, (weeks), days, hours, minutes and seconds for the user to fill out.

It's ok to track this on an issue, but we don't currently support the duration=* tag on any presets, so the field wouldn't show up anywhere as of today.
iD does support these similar tags:

aerialway:duration on several aerialway presets, which seems to prefer minutes, not ISO 8610.
maxstay=* on amenity=parking which seems to prefer human readable values like HH:MM with units, not ISO 8601.

But the reason why non ISO 8601 is preferred is probably the lack of UI. Using proper UI (for reading or editing) you don't need a human readable duration stored in the database but a duration. Easier for computation (standard, ready to use parsers and UI).

Closing this for now.. I might reopen if we ever add a duration field to iD that actually uses ISO 8601.  (Maybe ferries or alternating oneways work like this?  I don't know.)

Yes, ferry route durations are expressed in ISO 8601 (example).

Long hiking trails have usually durations in days 😉


Add license header lint rules

Making sure that the header is properly added

@jstudler I think we can merge this for now, as our conclusion regarding license header compliance basically dictates that we need to have an Apache license on top of all source files in all source files.
WDYT?


Fix: update main workflow that use argument to send token instead of env

Summary :memo:
Fix the CI workflow issue that fails to send code coverage result to codecov
Details
Describe more what you did on changes.

use with: token instead of env: CODECOV_TOKEN

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (cfb392f) to head (91ba9f6).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines           88        88
=========================================
  Hits            88        88

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Null hypothesis significance testing - Z-Test / Gauss-Test

Is your feature request related to a problem? Please describe.
I can not find a function to do a Z-Test in https://docs.scipy.org/doc/scipy/reference/stats.html.
For reference of Z-Test: https://en.wikipedia.org/wiki/Z-test
Describe the solution you'd like
I would want to make a feature request for this hypothesis test method. If possible, the following test methods can be included:

One sample Z-Test
Two-independent-sample Z-Test
Two-dependent-sample Z-Test

It would not be hard to implement. Most of the time would go into documentation and testing. If you're not comfortable writing the code, you could help by designing the interface, drafting documentation, and writing tests that should pass once the function is implemented.
Is this function implemented in other languages (e.g. R, Matlab, SASS)? Does it ever go by another name? Can you give a particular example of a situations it is used in? I would suggest emailing the SciPy developer mailing llist with this sort of information to see if others are interested in such a function being in SciPy.

Hi, if no one is currently working on it, I would like to help implement the Z-test! I'm familiar with hypothesis significance testing :)

Hi @charlotte12l , I don't think there is anyone working on it. All new functions need an email to the mailing list before they can be merged, so you might want to email the mailing list first to see if there is enough interest in such a function before starting. You could also email the list after submitting a PR, but then there's the chance that there's not interest.
Ideally, the email would include information like examples of when the test is used and evidence that the test is popular (e.g. highly cited paper).
When you get started, I'd recommend taking a look at a recent PR, gh-12873 for an example of a new hypothesis test with a good example, good tests, and a really readable implementation.
Also, since the Z-test uses the normal distribution, you can use _normtest_finish to get the p-value from the Z statistic. gh-13008 shows an example use, and it also has good testing and documentation of the alternative parameter.

Thanks for your suggestions! That's very helpful! I'll write a proposal first this weekend and email it to the mailing list. :)

Hi @charlotte12l, in #13938 another attempt has been started hence would you like to join forces or review or any other way be involved if you can still spare some time ?

Sorry for the delayed reply. Sure, I'll join the reviews!


doc/kernel: Remove incorrect kernel priority illustration

Carles discovered that this graph is actually incorrect, it shows priority zero as a cooperative priority, when in fact only negative priorities are cooperative.
Fixing documentation graphics isn't something anyone should trust me to do, so just remove it for now pending rework.  It isn't otherwise referenced in the text.
There's some thought that the "Idle Thread (cooperative)" indicator is confusing also, as it might be taken to imply that the idle thread can have a higher priority than other threads, which is impossible by construction.  (The meaning seems to be more "This is where the idle thread priority would be if there were no preemptible priorities configured")

ok, this is weird, if I open the same svg file it is shown correctly in the editor, not in the docs though, hmmm:

think it was a bug in draw.io or something, I just saved it the same picture again and it seems to put the arrow in the right place.

Closing, obviated by diagram fix


initialize_floorplan fails without -site option

Describe the bug
The - site is supposed to be optional. A warning is printed but an error occurs later.
% initialize_floorplan -utilization 10
[WARNING IFP-0011] use -site to add placement rows.
TypeError in method 'init_floorplan_util', argument 7 of type 'odb::dbSite *'
% initialize_floorplan -die_area {0 0 10 10} -core_area {0 0 10 10}
[WARNING IFP-0011] use -site to add placement rows.
TypeError in method 'init_floorplan_core', argument 9 of type 'odb::dbSite *'
Is -site option really to be optional? Seems the contrary. In that case the warning should be turn into an error and doc updated.
Expected Behavior
No error.
Environment
Lastest git.

To Reproduce
Type:
initialize_floorplan -utilization 10
or
initialize_floorplan -die_area {0 0 10 10} -core_area {0 0 10 10}
Relevant log output
No response
Screenshots
No response
Additional Context
No response

It looks like it should be an error.  Do you want to make a PR?

Yes. I'll do it. Assign this issue to me.

Sent PR https://github.com/The-OpenROAD-Project/OpenROAD/pull/6069

The PR has been merged. Closing.


Collapsed components that are references

Attempt to fix #415
This is only partial fix.  It does ensure that the object model is valid however, due to the way references are resolved we lose the fact that in the original document the reference was to AllPets as it gets collapsed down to Pets.  More investigation is required.

This partial fix should be merged because it is better than not having it there.  I still don't know how we can make these references to references actually roundtrip.


Fix submessages

@faddat to fix wasmer build error, I downgraded to 1.0.0-beta2. : /
Submitted a PR against your repo: https://github.com/notional-labs/wasmd/pull/10
Largely making this PR so I can test and see if it solves the submessages issue.

NOTE: don't merge this.


Minor language improvements in Readme files

Corrected slight grammar and spelling errors here and there to provide improved documentation.

Please see #41

Wasn't aware of this. Would agree to any resolution then.


Rename all sqnc non deps

Rename all instances of dscp to sqnc in non-dependencies

Needs fixing and rebasing


Adds Garuda to the monster list

Removes the ronsos and adds the new raid boss.
Please tell me if this works well, or if you need any changes.

Thanks a lot !


[Forwardport v2.9] [Feature] K8s 1.28 Support

Forwardport of https://github.com/rancher/rancher/issues/43109, see details on the linked issue.

[x] rancher/rancher:

https://github.com/rancher/rancher/pull/45082

Validated on rancher v2.9-head(f26d988)

Provisioned  RKE1, RKE2 and K3s node driver and custom clusters using below k8s versions :

v1.28.8-rancher1-1
v1.28.8+rke2r1
v1.28.8+k3s1

All clusters came up successfully with all the pods up and running.

Cluster provisioning using k8s v1.28 is working fine, hence closing this issue.


close/drain an specific connection

Is there a way to close an specific connection from the pool and not drain all the connections? E.g.:
r.getPoolMaster().drain(<pool_coonection>);

I need to cancel some query if the server memory pass some limit, so I need to cancel the current query (can also cancel all the connections but I would prefer just close that connection) and run it again later in the future (after some defined time).
This an example of what I'm trying to do:
setInterval(function () {
  mem = getServerMem();
  if (mem < limit - delta && running) {
    query.run();
    running = true;
  }
  if (mem >= limit && !running) {
    query.drain();
    runing = false;
  }
}, 1000);

Hum, in this case you can't just use run.


[Bug] Update of table duplicated all the Table Media

Describe the bug
update of table duplicated all the Table Media
To Reproduce
Table: https://vpuniverse.com/files/file/21686-short-circuit-rober-benoriginal-2024/
I had version 0.9.1 of this table installed.  The zip comes with PUP, Backglass, Media Pack, etc.  I went to upgrade it to 0.9.3 like this (I am just showing the panel -- it is already upgraded):

all the media files were doubled up:

Expected behavior
I am not sure what I expect exactly, but not what happened.  Probably one of these:

ignore the media on the upload & replace
remove the old media before replacing
ask me what I want to do (or have the option in the upload panel)

Fixed with 3.7.2.


Add Go version configuration for Linuxkit project

Adding Go version configuration for Linuxkit project. This will be used to detect the correct Go version to use when upgrading to the latest upstream release.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


More UI fixes

Bugs Description

mac users have bugged emojis
context menu is poorly coloured

Bugs Fix Description

rearranged and changed emojis

add colour formatting for context menu

Additional Features

reformatted help button

add spacing in reminderCard for UX purposes

Codecov Report
Base: 72.15% // Head: 75.49% // Increases project coverage by +3.33% :tada:

Coverage data is based on head (274de6c) compared to base (77a32bf).
Patch coverage: 65.09% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
+ Coverage     72.15%   75.49%   +3.33%
- Complexity      399      526     +127
============================================
  Files            70       90      +20
  Lines          1232     1718     +486
  Branches        125      196      +71
============================================
+ Hits            889     1297     +408
- Misses          311      343      +32
- Partials         32       78      +46

Impacted Files
Coverage Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)

...rc/main/java/seedu/address/logic/LogicManager.java
85.71% <0.00%> (+10.71%)
:arrow_up:

.../seedu/address/logic/commands/ReminderCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
84.21% <0.00%> (-15.79%)
:arrow_down:

...u/address/logic/parser/InsuranceCommandParser.java
0.00% <0.00%> (ø)

...du/address/logic/parser/ReminderCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

src/main/java/seedu/address/ui/CenterPanel.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/CommandBox.java
90.00% <ø> (+90.00%)
:arrow_up:

src/main/java/seedu/address/ui/HelpWindow.java
75.00% <ø> (+75.00%)
:arrow_up:

... and 48 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add a directory for the tasmota library with an example countdown timer

An example of how the playground could be structured.
A directory created for each library, in this case tasmota. In the directory should be small examples of using the tasmota.xxxx functions.
I have included an example countdown timer

Thx!


any way to delete entries from this list?

any way to delete entries from this list? when you push ctrl+R?

Answer here
https://github.com/junegunn/fzf/issues/3522#issuecomment-1872415948

@joshskidmore do you think you can look at this and see if you can officially support it, as mine is kind of hacky


[FEATURE] Add a FAQ page

Add a FAQ page and add link to menu
Example:
use this questions.
1. What is HackerBoi website?
It's an open-source project. By participate here, you are participating in HECKTOBEFEST 2022
Screenshot:

i want to do this, please assign me

i want to do this, please assign me

good luck

I want to do this please assign me

I want to do this please assign me

assinged

@codemeop  unassigned due to no response

Only one question is to added in the FAQ section ?
the one you have mentioned ?

Only one question is to added in the FAQ section ?
the one you have mentioned ?

no, its a demo, we will add more

This is not included in hacktoberfest??
The spelling of your hacktoberfest is wrong.
Kindly check it please and merge my request
On Fri, 21 Oct 2022, 17:14 DevvSakib, @.***> wrote:

Only one question is to added in the FAQ section ?
the one you have mentioned ?
no, its a demo, we will add more
—
Reply to this email directly, view it on GitHub
https://github.com/devvsakib/hackerboi/issues/2#issuecomment-1286848480,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUQTHBDKM2ZIONQCAM3CGGLWEJ63FANCNFSM6AAAAAARCLHGGI
.
You are receiving this because you were assigned.Message ID:
@.***>

This is not included in hacktoberfest??
The spelling of your hacktoberfest is wrong.
Kindly check it please and merge my request
On Fri, 21 Oct 2022, 17:14 DevvSakib, @.***> wrote:

Only one question is to added in the FAQ section ?
the one you have mentioned ?
no, its a demo, we will add more
—
Reply to this email directly, view it on GitHub
https://github.com/devvsakib/hackerboi/issues/2#issuecomment-1286848480,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUQTHBDKM2ZIONQCAM3CGGLWEJ63FANCNFSM6AAAAAARCLHGGI
.
You are receiving this because you were assigned.Message ID:
@.***>

all issues and pr has hacktoberfest label, check your pr