Problems encountered in the Full Defect Workflow Example (w/GGA) section

Sorry to bother you in your busy schedule! I was having trouble learning the Parse host structure in the Full Defect Workflow Example (w/GGA) section, the python script was having trouble executing and the subsequent kgrid package was not successfully installed on the server. Please give me a precious answer at your convenience, thank you!

Hi @zhangweiteng. Thanks for your interest in doped.
What type of errors did you get when parsing the structure and installing kgrid? Providing the error messages you got helps us to understand what might be causing the issue.

I just tried installing kgrid on a new environment and worked fine so the installation issue might be related to the server you're using?
Regarding parsing the structure, I just tried the tutorial and worked fine once I installed the package emmet-core, as automatically suggested by doped once you try to run the following cell:

from doped.utils.symmetry import get_primitive_structure
prim_struc = get_primitive_structure(mgo_entry.structure)  # get a clean primitive structure

which outputs:
Your Materials Project (MP) API key (either ``api_key`` parameter or 'PMG_MAPI_KEY' in ``~/.pmgrc.yaml`` or ``~/.config/.pmgrc.yaml``) corresponds to the new MP API, which requires emmet-core and mp-api as dependencies, but these are not both installed. Please install with ``pip install -U mp-api emmet-core``!
and then runs fine once you install emmet-core.
To run the tutorial, I'd recommend installing doped from the develop branch, since there are some updates to this tutorial that haven't been published in the main branch yet (see related issue). You can install the develop branch as mentioned here by doing:
git clone https://github.com/SMTG-Bham/doped.git
git checkout develop
conda activate <your_conda_environment>
pip install -e .

Hi @zhangweiteng. Thanks for your interest in doped. What type of errors did you get when parsing the structure and installing kgrid? Providing the error messages you got helps us to understand what might be causing the issue.

I just tried installing kgrid on a new environment and worked fine so the installation issue might be related to the server you're using?
Regarding parsing the structure, I just tried the tutorial and worked fine once I installed the package emmet-core, as automatically suggested by doped once you try to run the following cell:

from doped.utils.symmetry import get_primitive_structure
prim_struc = get_primitive_structure(mgo_entry.structure)  # get a clean primitive structure

which outputs: Your Materials Project (MP) API key (eitherapi_keyparameter or 'PMG_MAPI_KEY' in~/.pmgrc.yamlor~/.config/.pmgrc.yaml) corresponds to the new MP API, which requires emmet-core and mp-api as dependencies, but these are not both installed. Please install with pip install -U mp-api emmet-core!  and then runs fine once you install emmet-core.
To run the tutorial, I'd recommend installing doped from the develop branch, since there are some updates to this tutorial that haven't been published in the main branch yet (see related issue). You can install the develop branch as mentioned here by doing:
git clone https://github.com/SMTG-Bham/doped.git
git checkout develop
conda activate <your_conda_environment>
pip install -e .

Thank you very much for your valuable reply! I have successfully installed the kgrid package after publishing the issue. I tried installing doped from the develop branch, but it was unsuccessful. If the main in the doped package is going to be updated soon, I can wait for the doped update. Meanwhile, I am looking forward to the update of the version and would like to express my sincere gratitude once again for your reply!

Great! If you've successfully installed kgrid now then your issue should be solved. You don't need to wait for a doped update as it seems your issue is not related to any version updates.
Happy coding, and thanks @ireaml for handling this!


TypeScript 'include' with nested 'select' produced very strict defined array type, even when it can be []

Bug description
const customers = await prisma.customer.findMany({
    include: {
        staff: {
            select: {
                user: true,
            },
            take: 1,
        },
    },
})

customers has a type of:
const customers: (Customer & {
    staff: {
        user: User;
    }[];
})[]

The issue is that customers.staff can be []. customer.staff[0] should be therefore undefined, but the above type lets it be always defined as User.
How to reproduce
See above
Expected behavior
Type type of customer should be:
const customers: (Customer & {
    staff: ({
        user: User;
    } | undefined)[];
})[]

customers.staff should be an array, whose items can be undefined.
Prisma information

Environment & setup

OS: macOS
Database: MongoDB
Node.js version: v16.15.1

Prisma Version
3.15.2

@DrJume this is a general limitation with array (not tuple) signatures in TypeScript.
You can enable noUncheckedIndexedAccess in your TypeScript settings to enfore stricter checks, here's an example.

Thanks @driimus! Going to close this issue since it seems to be working as expected.

Thanks @driimus! Going to close this issue since it seems to be working as expected.


[SUPPORT]Hoodie clean operation result explanation

Hi,
I have following simple code that do upsert 100 times(The code is at the end of the question description), and I disable the auto clean during writes. When the writes is done, there are about 100 parquets in the hoodie table folder.
After I run cleans run in the hudi-cli, there are only 11 parquets file  left in the hoodie table folder, that means, old version files has been cleaned up after clean.
Then I run the `select count(1) from hudi_hive_read_write_cow_disable_cleaner_1' and the result is still 101, looks like no data is lost after clean.I would like to make sure whether there is no data lost after cleaning old version files. Data Loss,  In my case, I mean have written 101 letters since the table is created and still get back 101 letters after clean
Another obervation is:
When I run select _hoodie_file_name from hudi_hive_read_write_cow_disable_cleaner_1;  the result shows the parquest file name, but some of them have been deleted after cleaning, not sure whether it is a bug that it shows the file name that is deleted（I think it should show the file name where the data resides）, and also this leads to another question, since the corresponding file has been deleted, where does the data in hive query result come from
import org.apache.hudi.DataSourceWriteOptions
import org.apache.hudi.config.{HoodieCompactionConfig, HoodieIndexConfig, HoodieWriteConfig}
import org.apache.hudi.index.HoodieIndex
import org.apache.spark.sql.{DataFrame, SaveMode, SparkSession}

object COWDisableCleanerTest {
  val spark = SparkSession.builder.appName("COWDisableCleanerTest")
    .config("spark.serializer", "org.apache.spark.serializer.KryoSerializer")
    .config("spark.sql.warehouse.dir", "hdfs:///user/hive/warehouse")
    .enableHiveSupport().getOrCreate()

  val hudi_table = "hudi_hive_read_write_cow_disable_cleaner_1"

  val base_path = s"/data/hudi_demo/$hudi_table"

  def run(df: DataFrame, round: Int) = {
    val saveMode = round match {
      case 0 => SaveMode.Overwrite
      case _ => SaveMode.Append
    }

    df.write.format("hudi")
      .option(DataSourceWriteOptions.RECORDKEY_FIELD_OPT_KEY, "name")
      .option(DataSourceWriteOptions.PRECOMBINE_FIELD_OPT_KEY, "creation_date")
      .option(DataSourceWriteOptions.HIVE_DATABASE_OPT_KEY, "xyz")
      .option(DataSourceWriteOptions.HIVE_TABLE_OPT_KEY, hudi_table)
      .option(DataSourceWriteOptions.HIVE_SYNC_ENABLED_OPT_KEY, "true")
      .option(HoodieIndexConfig.BLOOM_INDEX_UPDATE_PARTITION_PATH, "true")
      .option(DataSourceWriteOptions.PARTITIONPATH_FIELD_OPT_KEY, "dt")
      .option(DataSourceWriteOptions.HIVE_URL_OPT_KEY, "jdbc:hive2://<IP_ADDRESS>:10000")
      .option(HoodieWriteConfig.TABLE_NAME, hudi_table)
      .option(DataSourceWriteOptions.HIVE_PARTITION_EXTRACTOR_CLASS_OPT_KEY, "org.apache.hudi.hive.MultiPartKeysValueExtractor")
      .option(HoodieIndexConfig.INDEX_TYPE_PROP, HoodieIndex.IndexType.GLOBAL_BLOOM.name())
      .option(DataSourceWriteOptions.HIVE_PARTITION_FIELDS_OPT_KEY, "dt")
      .option(HoodieWriteConfig.HOODIE_AUTO_COMMIT_PROP, "false")

      //在100次commit过程中不做clean
      .option(HoodieCompactionConfig.AUTO_CLEAN_PROP, "false")
      .option("hoodie.insert.shuffle.parallelism", "2")
      .option("hoodie.upsert.shuffle.parallelism", "2")
      .mode(saveMode)
      .save(base_path);
  }

  def main(args: Array[String]): Unit = {
    import spark.implicits._
    val order = MyOrder("Key-0", "Price-0", "2020-11-18 14:43:00", "2020-11-19")

    //Create table and insert 1 row
    run(spark.createDataset(Seq(order)).toDF(), 1)

    //Run 100 times and insert 100 rows ,one row per commit
    (1 to 100).foreach {
      i =>
        val order = MyOrder("Key-" + i, "Price-" + i, "2020-11-18 14:43:" + i, "2020-11-19")
        val insertData = spark.createDataset(Seq(order)).toDF()
        run(insertData, i)
    }

  }
}

Yeah, cleans are supposed to only delete old versions of the files safely. No data loss is expected as you have noticed.
The observation regarding hudi_file_name is expected. We usually use it to see the file-id and not the physical file name. For records that are untouched, the row retains the last file name where the record got changed.

Thanks @bvaradar  for the great answer. I am closing this.


Integrate applications insight into logging

Telemetry can be very useful.
Changes proposed in this pull request:

Integrate application insights into qcodes
Make it explicitly opt-in for the user to send any information anywhere

@QCoDeS/core

@QCoDeS/core a question: I included the benchmark notebook for you to look at, but should we include it in the docs? It could be good for users to know at least something about the impact of enabling telemetry.

You could also put the notebook in the reports repo

Re the notebook: I'll put it in the reports repo in a separate PR.


pull request for e2e test at 01/09/2017 09:45:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


In convit.py file, where does ConVit come from, really?

https://github.com/xxxnell/how-do-vits-work/blob/8752f4e330a38877c628dfa40d57fa9404bb3131/models/convit.py#L1-L6
You said it's not the same with ConVit by d'Ascoli, Stéphane, et al. Then where does this ConVit come from? I ask because if I reuse this code, I want to know whom I should cite.

Hi,
I was inspired by "Convolutional Self-Attention Networks" [2], and implemented the two-dimensional ConViT model for vision tasks from scratch. Yang et al. [2] mainly proposed one-dimensional convolutional transformers for natural language tasks. As far as I know, no official implementation of [2] is provided.
I will add the reference [2] to convit.py. Thank you for your feedback!
[2] Baosong Yang, Longyue Wang, Derek F Wong, Lidia S Chao, and Zhaopeng Tu. "Convolutional self-attention networks". NAACL, 2019.

@xxxnell Uhm so what are the differences between these two attention mechanism?
https://github.com/xxxnell/how-do-vits-work/blob/8752f4e330a38877c628dfa40d57fa9404bb3131/models/attentions.py#L68-L101
and
https://github.com/xxxnell/how-do-vits-work/blob/8752f4e330a38877c628dfa40d57fa9404bb3131/models/convit.py#L19-L66

Attention2d in models/attentions.py is traditional global self-attention. ConvAttention2d in models/convit.py is convolutional self-attention, and it is a kind of local self-attention. ConvAttention2d calculates self-attention only between tokens in convolutional receptive fields (e.g., 3x3) after unfolding the tokens like Conv2d.

I think I understand now. Just one more question, if I use Attention2D in models/attentions.py, I should cite your paper,right?

Yes. I'd really appreciate it if you would cite my paper.

@xxxnell Quick question, which part of your publication mentioned Attention2D in models/attentions.py? From what I read, you only mentioned MSA from vanilla transformer.

@dinhanhx Oh! Sorry for the confusion. Attention2d in models/attentions.py is almost identical to traditional MSA in vanilla ViT, so I think you should cite the original ViT paper. Please cite my paper only if you have used or modified my code and implementation directly.

@xxxnell well I found that your Attention2D in models/attentions.py is kinda similar to this one https://github.com/lucidrains/vit-pytorch/blob/c2aab05ebfb01b9740ba4dae5b515fce1140e97d/vit_pytorch/cvt.py#L70-L102 from CvT: Introducing Convolutions to Vision Transformers. From my understanding, the major difference is the number of CNN layers to project qkv.

@dinhanhx Ah, I think now I understand what you pointed out! I initially used two Convs for qkv to improve the performance of AlterNet. So there was an experiment and discussion on stride k in self.to_kv in the first draft, but they were removed in the final revision for better readability. As a result, in the context of my paper, I didn't take advantage of the two Convs and the stride attribute for the sake of simplicity, and it also looks good to me to use one Conv instead of two Convs. In addition, since a lot of my implementations are based on https://github.com/lucidrains/vit-pytorch, I think it's also great to cite the original project to use the code.

@xxxnell It was confusing to me since there are few similar convolution attention mechanism like yours. I did have a hard time trying to differentiate them.
if I AlterNet (theory), I cite your paper.
if I use AlterNet (code), I cite your paper, and the original project https://github.com/lucidrains/vit-pytorch.
if I only use Attention2D in models/attentions.py, I cite your paper, that CvT paper, and the original project.
Right?

@dinhanhx Right. I think what you said is one of the best practices.

Thanks for supporting me!

Thanks for your comments on our "Convolutional SANs" (https://arxiv.org/abs/1904.03107). We are also very happy to see this can inspire your work. The paper on analyzing Vision Transformers is really insightful and interesting.

Hi,
I was inspired by "Convolutional Self-Attention Networks" [2], and implemented the two-dimensional ConViT model for vision tasks from scratch. Yang et al. [2] mainly proposed one-dimensional convolutional transformers for natural language tasks. As far as I know, no official implementation of [2] is provided.
I will add the reference [2] to convit.py. Thank you for your feedback!
[2] Baosong Yang, Longyue Wang, Derek F Wong, Lidia S Chao, and Zhaopeng Tu. "Convolutional self-attention networks". NAACL, 2019.

We have implemented various SANs including "Convolutional SANs" at:
https://github.com/baosongyang/Context-Aware-SAN/blob/main/layers/attention_conv.py.

Hi @longyuewangdcu ,
Thank you for the great paper and your kind words. And sorry I missed that implementation. I'll take a closer look!


Documentation > Inverse Relationships > Invalid code sample

https://realm.io/docs/objc/latest/#relationships
Inverse Relationships
@interface Dog : RLMObject
@property NSString *name;
@property NSInteger age;
@property RLMLinkingObjects *owners;
@end

to
@interface Dog : RLMObject
@property NSString *name;
@property NSInteger age;
@property (readonly) RLMLinkingObjects *owners;
@end

Thanks for reporting this, I just pushed a fix, it should be live in a few minutes.


How to calculate the Matching Score in the code

Hello
I have no idea about how to calculate the Matching Score in the code.
Any help would be appreciated.

We use their code: https://github.com/lzx551402/ASLFeat/blob/master/utils/evaluator.py


Adding disposition IDs for WAF events & Descriptions for IDs missing descriptions.

Adding additional disposition IDs Captcha & Challenge to handle the application of the firewall profile to web logs
Update other disposition IDs with proper descriptions.

@adplotzk I'd like to propose some changes to the disposition_id values, and that will affect this PR.
Currently, the disposition_id enum values are defined in the dictionary, which more or less means that all classes will share the same values. This approach is not very practical, for example most of the current disposition_id values are not applicable to the alert and incidents.
If that proposal gets accepted, then you can define specific disposition_id values for the network events.


iOS 9.2.1 + Chrome 50 => Physical web widget not showing

Hello,
I have installed Chrome 50 on my iPhone 5s with iOS 9.2.1 and when I add chrome to the "Today" menu, the physical web option is not showing up. I have bluetooth turned on. Anyone has seen that issue? Thanks
Hang

Sorry my mistake. I did not know you actually need to have an active eddystone nearby to opt-in. I would be nice to be able to opt-in without. Thanks


org.ehcache.internal.store.heap.ByRefOnHeapValueHolderTest#testEquals broken

With the current equals contract of the org.ehcache.spi.cache.AbstractValueHolder this test passes only when creation happens at the same millisecond.

Problem might exist in similar tests.


The FranceConnect Kit does not appear in TopBar in JPlatform 10

Steps to Reproduce the Problem

As an administrator
Go to the Plugin manager and click in France Connect Plugin
Activate Kit FranceConnect property
Connect as a FranceConnect user

Actual Behavior
The FranceConnect Kit does not appear in TopBar

Resolved, cf d3d9b57aa987af5c03ee55c352006be71eb9bb39

Validated in FranceConnect Plugin 1.9 (#40)


Updating geo ip database does not work

It seems the host geolite.maxmind.com, defined in etc/di.xml:33 is no longer accessible:
$ curl -I http://geolite.maxmind.com/download/geoip/database/GeoLite2-Country.mmdb.gz
curl: (6) Could not resolve host: geolite.maxmind.com

Is there a new working url?
This may be related to #10.

It seems like the new host is download.maxmind.com and the download urls can be found at https://www.maxmind.com/en/accounts/191911/geoip/downloads
Seems indeed to be related to #10, this would require significant changes to the module and the way it handles downloads.


Fix gun code

I think this is the intended way to do it?

Fixed in https://github.com/space-wizards/RobustToolbox/commit/ef22842b90403fb69fd4559410bd321c8c97c815.


Fix deployment error messaging.

When an invalid Cloud SDK path is specified but the deployment log output states the app-engine-java component is missing.

I gotta run. I'll let you guys duke this out. please address my remaining comments

lgtm on my end if all of @patflynn comments were addressed

Should be fine now. PTAL


Report fields - Blank list is shown briefly after deleting all report fields

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to workspace chat
Go to Report fields (enable in More features if not yet)
Add a report field
Click on the report field
Click Delete
Delete the report field

Expected Result:
The report field page will show the empty state screen immediately (like it does on Categories and Tags page)
Actual Result:
The report field shows blank first briefly before showing empty state screen
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/3eaffdeb-a291-4df9-8377-3d1a3c77d0db
View all open jobs on GitHub

@francoisl  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

This is probably from https://github.com/Expensify/App/pull/44493, not going to block on this as it's not breaking anything.

Going to handle this with @rezkiy37 and @waterim as we are working on the project

The report fields is behind beta still

Hello, Im Artem and would like to help with this issue!
This issue will be fixed here

PR reviewed and merged


GAN models vs Shaders?

Can someone explain the difference between the trained GAN models and the shaders provided? Are the shaders converted from the GAN models? Generally, how are they different?

The GAN ones will be heavier on the GPU, which is why they're only available on larger shaders.


Enable volume plugin dir configuration for kubelet

What this PR does / why we need it:
End-users can now configure .spec.kubernetes.kubelet.volumePluginDir the directory in which to search for additional third party volume plugins.
Which issue(s) this PR fixes:
Fixes #725
Special notes for your reviewer:
If possible I would also like to backport this to v0.28.0
Release note:

It is now possible to set the directory in which to search for additional third party volume plugins by configuring `.spec.kubernetes.kubelet.volumePluginDir` in the `Shoot` specification.

We statically configure this because one of our system components (namely Calico, requires access to write to this path), please refer to: https://github.com/gardener/gardener/pull/1414

Should we make https://github.com/gardener/gardener-extensions/blob/77d0e042590450faa9c6ac7babef89ddaf5cdf3d/controllers/networking-calico/charts/internal/calico/templates/calico.yaml#L287 then configurable in the calico config as well?

What is the use case to reconfigure the volume plugin dir? Is /var/lib/kubelet/volumeplugins not good enough for all scenarios?

We statically configure this because one of our system components (namely Calico, requires access to write to this path), please refer to: #1414

We can, but this is more of a hard dependency (that should be fixed in Calico itself), I don't like that we statically configure it but if we expose this onto Calico configuration it would still be a temporary solution (since its not networking specific, more of a hack but exposed). I would rather wait till this is fixed in Calico: https://github.com/projectcalico/calico/issues/2712

/var/lib/kubelet/volumeplugins is actually fine for me, since that is also what Rook recommends. Sorry for the confusion, got a bit excited about my first contribution 😛

/var/lib/kubelet/volumeplugins is actually fine for me, since that is also what Rook recommends. Sorry for the confusion, got a bit excited about my first contribution 😛

Please stay excited, I hope this didn't de-excite you :)

@muenchdo is it okay if we close this now, and wait for the fix in Calico? we can then later re-open it.

As discussed above, let's close it for now and reopen once needed/supported. For now, I guess /var/lib/kubelet/volumeplugins should be good enough for most scenarios.
Though, thanks for the PR @muenchdo :) Feel free to get on some other issue if you like :)


Gitea fails to start because of non-translated string

Description
On gitea service startup (using systemd):
Unable to register cron task update_migration_poster_id Error: translation is missing for task "update_migration_poster_id", please add translation for "admin.dashboard.update_migration_poster_id"
This fails the service start.
I’ve setup gitea with:
[i18n]
LANGS = fr-FR
NAMES = Français

Adding english makes it work.
I don’t think it should hard fail for a missing translated string…
Gitea Version
1.17.2
Operating System
Arch Linux
How are you running Gitea?
Systemd package using provided systemd service.
Database
PostgreSQL

Thanks for this report, and all of the details you did, it is very appreciated.
That's an interesting fail condition, as i haven't been in the translation part of the code recently, but I believe things fall back to English since it has all of the translations, but by having only French I guess it has nothing to fall back to.
I guess if the translation isn't available we could just have it print the translation key, although that might run into issues with when we printf into the variables.

Those were exactly my thoughts (i.e. it likely falls back to English if possible, and currently fails if not), but not knowing gitea code base nor Go, I could not say whether falling back to the translation key was desirable. I should have mentioned all this in my first post. ^^

Some backgrounds here:

The "default language": at the moment, the first language in the setting is used as "fallback language" and "UI default language" at the same time. If a language is used as a fallback language, then it's expected that it must contain all translations.
The "fatal error for missing keys": in history, there are not only one issue reporting that the locale key is missing (especially for the tasks), so the cron task module checks its locale keys when initializing and reports fatal error (because nobody cares error logs if the program can run ....)

When these two mechanisms come together, and you set an incomplete translation as default language, then this issue happens.
Some possible solutions:

Use a customized fr-FR locale file, or merge the missing keys from en-US into it on your side (a workaround without code change)
Separate the  "fallback language" and  "UI default language"  setting, instead of just using one "default language" setting
When initialize the locale keys, always fill en-US keys first and then fill the default language keys
(maybe more other mechanisms)

This PR #21200 implements solution 3


View Governance Initiated Transfer Proposals

Story
As a vega user
I want to be able to find Governance Initiated Transfer Proposals in the Governance Proposals list in Block Explorer and see the details
So that I can understand what proposals are being submitted to the network (find out more about the implications of the proposals and participate in governance on Vega)
Acceptance Criteria

[ ] I can see Governance Initiated Transfer Proposals in the Governance Proposals list in Block Explorer
[ ] I can identify Governance Initiated Transfer Proposals in list by type
[ ] I can view key details of the Governance Initiated Transfer Proposals

[ ] Title
[ ] Type
[ ] State
[ ] Voting
[ ] Closing Date
[ ] Enactment Date
[ ] Terms (Raw JSON) in a modal

[ ] I can click to view the proposal details on the Governance dapp (in a new window/tab)

Tasks

[ ] UX (if needed)
[ ] Design (if needed)
[ ] Team and stakeholder review
[ ] Specs reviewed and created or adjusted
[ ] Implementation
[ ] Testing (unit and/or e2e)
[ ] Code review
[ ] QA review

Sketch
Additional details / background info

We think this will happen for free based on the existing governance views in block explorer. Moving to in review.

Waiting for docs to be updated in order to get the details on how to submit transfer proposal
https://github.com/vegaprotocol/documentation/pull/698/files


Install issue on Mac OS X 10.12.6

Hi,
I tried installing BrainIAK on a new Mac. It did not finish with "Successfully Installed". I am attaching the log for your reference.
biak_nstall_fail.txt
Thanks,
Manoj

Hello, Manoj!
It looks like you are using a combination of Brew and Conda packages. I think it would be best to try one or the other, not a combination. I suggest you try Brew, since we already provide step-by-step instructions in the BrainIAK README. In case you actually installed Python from Brew and intended to use that for the BrainIAK installation, I suggest you use change your PATH so Brew is first or use the full path when calling python3, i.e.:
/usr/local/bin/python3 -m pip install -U brainiak

Okay thanks. I'll give this a shot.
I had used Anaconda for using Jupyter notebooks, so maybe thats why the mixup.

Hi Mihai,
I got one additional error (something about TFA, see below) but the end status said, "Successful Install". Is this good?
Install Log:
brainiak/factoranalysis/tfa_extension.cpp:24:10: fatal error: 'pybind11/pybind11.h' file not found
#include <pybind11/pybind11.h>
^~~~~~~~~~~~~~~~~~~~~
1 error generated.
error: command '/usr/local/opt/llvm/bin/clang' failed with exit status 1

Failed building wheel for brainiak
Running setup.py clean for brainiak
Running setup.py bdist_wheel for nitime ... done
Stored in directory: /Users/manojkumar/Library/Caches/pip/wheels/05/0f/4b/63bba7a487d3cfb165c7ec095fe0d9135e8ba5a126ce25b0e2
Successfully built nitime
Failed to build brainiak
Installing collected packages: cython, mpi4py, numpy, six, python-dateutil, pytz, cycler, pyparsing, matplotlib, scipy, nitime, scikit-learn, pymanopt, theano, pybind11, nibabel, typing, brainiak
Running setup.py install for brainiak ... done
Successfully installed brainiak-0.5 cycler-0.10.0 cython-0.27.2 matplotlib-2.1.0 mpi4py-2.0.0 nibabel-2.2.0 nitime-0.7 numpy-1.13.3 pybind11-2.2.1 pymanopt-0.2.3 pyparsing-2.2.0 python-dateutil-2.6.1 pytz-2017.3 scikit-learn-0.19.1 scipy-1.0.0 six-1.11.0 theano-0.9.0 typing-3.6.2
========================================

Yes, the installation was successful. Closing the issue.


Generate bug reports in the App

Proposal
Hackathon idea: Generate bug reports via the App
We've decided to move forward with it
https://expensify.slack.com/archives/C01GTK53T8Q/p1678998180957189
Tasks
We decided we just need a small pre-design to determine which word triggers and animations this happens on

[x] Host a pre-design meeting (example) in #expensify-open-source to discuss any necessary details in public before filling out the High-level of proposed solution section.
[ ] Host another pre-design meeting in #expensify-open-source to ask for engineering feedback on the technical solution.
[ ] Implement the changes

High level pre-design is happening here!

We've figured out most of what we need in the pre-design, but I'm holding off on moving forward with anything for the time being since I have some other higher priority projects that are happening.

Have other higher priority projects in the works, going to see if anyone is willing to take this off my hands

Assigning myself. Asked if someone can help me craft the high level design doc.

@stephanieelliott @strepanier03 I'm so sorry
Here is the link to the design doc: https://docs.google.com/document/d/1ljqdFi2FJcJRDASBQZK881frmAllvguiCb6V9Sky3wI/edit?usp=sharing

Got it, thanks so much @hayata-suenaga!

I have reviewed this design doc!

still waiting for reviews

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

I have read and reviewed this Design Doc!

still waiting for design doc reviews.

I have read and reviewed this Design Doc! Please ensure that this project is tracked for capitalized software during the development phase (phase 2-4).

I haven't started the implementation. So this probably goes into June CAP if it qualifies

I'll prepare to hand off this to contributors

The guide's team will start reporting bugs: https://expensify.slack.com/archives/C036S0BVAHH/p1687988421861679
will work on this project so that potentially they can also utilize bug report functionality of NewDot

Changing the priority of this issue to monthly as this is a non-blocker project that doesn't belong to any wave.

I'll check back on this after Hybrid Web is done

I gonna start handing off issues next week

oops I didn't mean to close the issue

I'll ask in wave 9 if we need this one or not. they might already planning similar feature

actually asking in the #product channel


[ARM] Fixed the returned data when tagging multiple resources

Fix the returned data when tagging multiple resources for 15106
Another problem is that it's not easy to fix it in a short time, so just do this for the time being
Description

The data returned after the resource is tagged is LROPoller, which needs to be wrapped by LongRunningOperation to get the actual result.
When only one resource is tagged, it is handled here link.
However, the process of parsing the results will be omitted when multiple resources are tagged, so add the logic of processing.
Testing Guide

Run az resource tag --tags key=value --ids resource-id1 resource-id2
Before:
[
  {},
  {}
]

After:
[
  {
     "id":"xxx",
      ....
   },
   {
     "id":"xxx",
      ....
   },
]

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

ARM

will this also fix the issue in az resource update?

will this also fix the issue in az resource update?

It only fix the returned data when tagging multiple resources
Updated the description.


add serviceAccountName to buildrun status

Changes

This PR aims to add the service account name to the buildrun status.

Submitter Checklist

[ ] Includes tests if functionality changed/was added
[x] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
The name of the used service account is now reflected in the status of the BuildRun

@jkhelil can you double check if you re using the right controller-gen version pls?, as the new lines you are introducing in the crds are something I would like to avoid, we recently changed from new lines to single lines, this pr reverts that. @imjasonh fyi

@jkhelil can you double check if you re using the right controller-gen version pls?, as the new lines you are introducing in the crds are something I would like to avoid, we recently changed from new lines to single lines, this pr reverts that. @imjasonh fyi

I am using v0.5.0 on mac os, switch to generate crds on ubuntu, now we have single lines

@jkhelil can you double check if you re using the right controller-gen version pls?, as the new lines you are introducing in the crds are something I would like to avoid, we recently changed from new lines to single lines, this pr reverts that. @imjasonh fyi

I am using v0.5.0 on mac os, switch to generate crds on ubuntu, now we have single lines

yeah my experience has been that just using v0.5.0 is not sufficient wrt the single lines @qu1queee @imjasonh @adambkaplan  .... I'm seeing the same thing on my fedora box wrt new lines
my last attempt to launch an ubuntu container with my local clone mounted in so I could run the command got about half a dozen dependency download issues in before some go mod stuff got me frustrated enough that I punted for now.
But I've since remembered that this was pervasive enough with RH'ers here at openshift that the core API repo created a generate-with-container make directive.  See https://github.com/openshift/api/blob/master/Makefile#L61-L63
I'll see if I can approximate something similar for shipwright-build .... side bar, openshift has already moved up to v0.6.0 of controller-gen.  We'll see if my attempts here to get consistency require that bump for us as well.

But I've since remembered that this was pervasive enough with RH'ers here at openshift that the core API repo created a generate-with-container make directive. See https://github.com/openshift/api/blob/master/Makefile#L61-L63
I'll see if I can approximate something similar for shipwright-build .... side bar, openshift has already moved up to v0.6.0 of controller-gen. We'll see if my attempts here to get consistency require that bump for us as well.

I'd love to avoid having to run controller-gen in a container if we can avoid it. Equivalent versions of the tool should emit the same results regardless of platform. If that's some expected behavior or unavoidable known issue in controller-gen then we can work around it, but I'd prefer not to just paper over it.
If there's a v0.6.0 we could see if that fixes the issue as well. 🤞

But I've since remembered that this was pervasive enough with RH'ers here at openshift that the core API repo created a generate-with-container make directive. See https://github.com/openshift/api/blob/master/Makefile#L61-L63
I'll see if I can approximate something similar for shipwright-build .... side bar, openshift has already moved up to v0.6.0 of controller-gen. We'll see if my attempts here to get consistency require that bump for us as well.

I'd love to avoid having to run controller-gen in a container if we can avoid it. Equivalent versions of the tool should emit the same results regardless of platform. If that's some expected behavior or unavoidable known issue in controller-gen then we can work around it, but I'd prefer not to just paper over it.

I understand the sentiment, but given the length of time this has been cited and not fully resolved upstream, I feel we are getting close to moving past preferences and unblocking frustrated non-ubuntu users like myself :-)

If there's a v0.6.0 we could see if that fixes the issue as well. crossed_fingers

Not optimistic there but sure I'll try that unless someone beats me to it when I circle back to this.

I understand the sentiment, but given the length of time this has been cited and not fully resolved upstream, I feel we are getting close to moving past preferences and unblocking frustrated non-ubuntu users like myself :-)

Is there an upstream issue I can watch for updates? I couldn't find one but maybe I wasn't searching in the right places.

I understand the sentiment, but given the length of time this has been cited and not fully resolved upstream, I feel we are getting close to moving past preferences and unblocking frustrated non-ubuntu users like myself :-)

Is there an upstream issue I can watch for updates? I couldn't find one but maybe I wasn't searching in the right places.

I only know of the one you cited in https://github.com/shipwright-io/build/pull/786 where it was marked closed, and then several folks responded after its closure that it was still broke .... item 514 over in kubernetes-sigs/controller-tools

Thank you for the enhancement. Just a small code change suggestion. Please add a unit or integration test that covers this aspect.

done

Hi @jkhelil, there was a problem with our KinD-based tests (integration and e2e) which has been resolved. May you rebase your changes on the current main branch so that we can get the tests green? Thank you in advance.

Just checking (not blocking this PR), we talked at some point about removing service account generation from Shipwright, since it requires the controller to request permissions to create/update/delete (and act as) any Service Account on the cluster, which is a pretty huge request. I can't find an issue that covers that though, so maybe I'm making it up?
In any case, if we decide to remove that ability, we'll also remove this new .status.serviceAccountName field, since it will always be the same as the user's specified .spec.serviceAccountName.

@jkhelil in the failure in https://github.com/shipwright-io/build/pull/826/checks?check_run_id=3085343835 I see a panic in buildrun_tests.go ... I believe it is in your new unit test:
•! Panic [0.001 seconds]
Reconcile BuildRun
/home/runner/work/build/build/pkg/reconciler/buildrun/buildrun_test.go:39
  Reconciling
  /home/runner/work/build/build/pkg/reconciler/buildrun/buildrun_test.go:119
    from an existing TaskRun resource
    /home/runner/work/build/build/pkg/reconciler/buildrun/buildrun_test.go:120
      register the serviceaccount name in the buildrun status [It]
      /home/runner/work/build/build/pkg/reconciler/buildrun/buildrun_test.go:250

      Test Panicked
      runtime error: invalid memory address or nil pointer dereference
      /opt/hostedtoolcache/go/1.15.13/x64/src/runtime/panic.go:212

      Full Stack Trace
      github.com/shipwright-io/build/pkg/reconciler/buildrun_test.glob..func<IP_ADDRESS>()
      	/home/runner/work/build/build/pkg/reconciler/buildrun/buildrun_test.go:265 +0x65c
      github.com/shipwright-io/build/pkg/reconciler/buildrun_test.TestBuildrun(0xc000001b00)
      	/home/runner/work/build/build/pkg/reconciler/buildrun/buildrun_suite_test.go:16 +0x109
      testing.tRunner(0xc000001b00, 0x2266e68)
      	/opt/hostedtoolcache/go/1.15.13/x64/src/testing/testing.go:1123 +0x203
      created by testing.(*T).Run
      	/opt/hostedtoolcache/go/1.15.13/x64/src/testing/testing.go:1168 +0x5bc


Support for custom media types for Repository contents

This is a proof-of-concept of how we can extend support for custom mime types across all services.
Reviews, suggestions, and discussions on the implementation are welcome.

[x] GetReadme supports html, raw and object(default) media types
[ ] GetContents supports custom media types
[ ] DownloadContents supports custom media types
[x] GetArchiveLink should support only the ref parameter.

Fixes #727
NOTE: This change breaks the backward compatibility of GetArchiveLink as the new opt is of type RepositoryContentsGetParameters instead of RepositoryContentsGetOptions. One way to overcome this issue is to revert the naming change and rename the new RepositoryContentsGetOptions to something else.
Ping @gmlewis @sahildua2305

Closing as there did not seem to be much discussion or demand for this from contributors or users (in addition to having several open questions).


melt: init at 0.2.0

Description of changes
Add melt, a tool to backup and restore Ed25519 SSH keys with seed words to the nixpkgs collection.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 164439 run on x86_64-linux 1

1 package built:

melt

Result of nixpkgs-review pr 164439 run on x86_64-linux 1

1 package built:

melt


doc: net: Update network overview chapter

Fixing typos and missing features in network overview
chapter.
Signed-off-by: Jukka Rissanen<EMAIL_ADDRESS>

Codecov Report

Merging #13711 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13711      +/-   ##
==========================================
- Coverage   52.28%   52.24%   -0.04%
==========================================
  Files         307      307
  Lines       45413    45413
  Branches    10508    10508
==========================================
- Hits        23742    23726      -16
- Misses      16886    16898      +12
- Partials     4785     4789       +4

Impacted Files
Coverage Δ

subsys/testsuite/ztest/include/ztest_assert.h
35% <0%> (-35%)
:arrow_down:

subsys/testsuite/ztest/src/ztest.c
65.28% <0%> (-7.44%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b6cc8...994ea37. Read the comment docs.

This PR depends on #13679 so I will re-submit this one after that PR is merged.

Rebased so that net_shell reference is now found.


suggestion

[x] Docs / tests

suggestion

We are preparing a while showcase page, we should link to that when it's ready!


Instagram and Spotify won’t start

I’m on the iPhone 7 11.3.1 v1.1.0 and while in a jail broken state my instagram and Spotify apps freeze on the startup screen

i did use rollectra before i switch to uncover, but still, instagram and spotify crashes. help?


Centos CI networking fix

eth0 is already set to dhcp, so we don't have to mess with /etc/sysconfig/network-scripts. Rather, we can just do what the debian network config accomplishes manually on hosts in the 'network' group: enable IP forwarding and configure NAT.

👍

Closed in favor of #2374.


Can't clone tables

Hey man, very excited to use your software, I am getting into an issue when cloning repo:
`Cloning into '/home/goran/aax-to-mp3/tables'...
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
`
Any ideas?
Thanks!

Hi there, I see. I should have used https instead of ssh for one the submodules.
I fixed it, please try again and feel free to reopen this issue if there are any other "cloning" problems!


Partial Templates and AST

PR enables these ideas.

[x] Support Partial Template
[x] AST Parsing/ HTML compatible
[x] Slot Based Transforms
[x] Allow custom parent/child template caching

Just to clarify some things about partial templates. To make it more compatible with the spec. If you want fragment or slot to be in the head, then you need to define them by this way
<script type="slot" name="head"></script>
<script type="fragment" public src="https://mosaic01.ztat.net/base-assets/fragment.html">
</script>

if you don't need it in the head, you can also define them by this way
 <body>
      <slot name="before-body"></slot>
      <fragment src="http://localhost:8088" primary fallback-src="http://localhost:8081"></fragment>
</body>

👍

addressed the concerns @mo-gr


How to update manifest request retry configuration

Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.3
Please ask your question
I tried to update the manifest request retry parameter when encounter a specific error. But since there is no configure method in network_engine.js as in streaming_engine.js, I was not able to do it. I am wondering if there is any function can be used to update manifest request retry parameters, or this is not supported.

You can simply call the player.configure method and refer the configuration provided here https://shaka-player-demo.appspot.com/docs/api/tutorial-config.html no need for the full, you can just pass in the new arguments and the config will be updated, to reset you can call resetConfiguration


Manual Review Required For GIGCO (GQO -> GIG)

I'm submitting a ...
[ ] bug report
[] feature request
[] question about the decisions made in the repository
[*] question about how to use this project

Summary
We changed our companies name together with our token name / ticker. We would like to update to the new info in the pull request.

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)
https://github.com/solana-labs/token-list/pull/5979

can confirm gigqo.com redirects to gigco.com, merging


TNBPAY - Milestone 6

Link to original project proposal.
#172
Link to most recent milestone payout request.
#357
Milestone Description
PrestaShop Plugin development
How long do you estimate this milestone will take to complete?
1 month
Project Wallet
86ee75d4cea77ca8339cc97f5e7426a3434d9f91465cd441c0c7593bd852e955

Approved.


feat(Router): permit overriding the registered route path for custom service implementation

Motivation
I am writing a generic service handler that can operate over a number of known routes (not using prost compile grpc services, but forwarding to service handlers elsewhere in the stack).
The route builder methods all require NamedService to be implemented, and this trait is used to derive the route. This approach doesn't work for a generic service that needs to be routed many different routes.

Solution
Move the derivation of route path from router into the a trait method of NamedService, to change no behaviour for normal services, but allow custom services to override the method and implement it's own routing scheme.

Alternative approach that is worth considering. This means changing the signatures of the router to accept a new supertrait RoutedService Since it is a supertrait this is not a breakign change to the public API:
pub trait RoutedService {

    /// The route path that gets registered with the underlying Axum router. This trait method
    /// can be overridden by implementors of RoutedService in order to customise the http path
    /// routing to the service.
    fn route_path() -> String;
}

/// A trait to provide a static reference to the service's
/// name. This is used for routing service's within the router.
pub trait NamedService: RoutedService {
    /// The `Service-Name` as described [here].
    ///
    /// [here]: https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md#requests
    const NAME: &'static str;

}

impl<T> RoutedService for T
where
    T: NamedService,
{
    fn route_path() -> String {
        format!("/{}/*rest", Self::NAME)
    }
}

What does this get you that can't be achieved by into_axum_router(), at which point you can do whatever you'd like with routing?

Unless I'm mistaken, I would have to reimplement a lot of what tonic does in it's own router like the large method serve_with_shutdown, unless there is a way to turn an axum router back into a tonic router?

Unless I'm mistaken, I would have to reimplement a lot of what tonic does in it's own router like the large method serve_with_shutdown, unless there is a way to turn an axum router back into a tonic router?

tonic's Routes has both into_axum_router() and From<axum::Router> (I think) implemented. Would that be sufficient?

Thanks yes I was able to work around it, some fiddling with boxing of response types needed to make it the right kind for service for axum, but otherwise neat enough. I think that is good enough to not warrant a change in tonic (plus gives me more flexibility), so I'll close this.


RDF Download from Query builder does not work

The RDF2Any that is integrated into the workbench, specifically into the Query Builder, returns no result when trying to download the RDF of a query.
See for instance:
http://linda.epu.ntua.gr/query-designer/84/

Just to clarify, is this within the Query builder (UBONN) or the query designer (NTUA)? The link of the query you sent is within the query designer.


Stop disabling RPATH on Mac?

Why do you intentionally disable RPATH for Mac here:
https://github.com/zlib-ng/zlib-ng/blob/afd2a0c323c5c787c1f8a0597568be85f41ab281/CMakeLists.txt#L1136-L1137
@kislinsk reported it as a bug in ITK: https://github.com/InsightSoftwareConsortium/ITK/issues/4084. I would prefer this to be fixed here, as opposed to patching ITK's bundled version.

The issues discussed there do not mention RPath directly. Having configure and CMake build systems behaving similarily is not an issue. But then we should switch both to using RPath, instead of both not using it. Do you agree?

As long as both configure and cmake produce identical binary, changing build parameters is not an issue. Anyone is free to submit a pull request. Not all the long-time contributors have or run MacOS so we have to rely on CI to catch any issues and regressions.

I agree, both configure and CMake should be changed to support RPATH. Any takers?

Regarding the CMake script, all that's necessary can be seen here: https://github.com/MITK/ITK/commit/a08465464b83fb6413e0266369723eb5d2b962b3
Regarding the configure script, the install name seems to be set here: https://github.com/zlib-ng/zlib-ng/blob/develop/configure#L516
So I guess the solution could be to change the line from:
LDSHAREDFLAGS="-dynamiclib -install_name $libdir/$SHAREDLIBM -compatibility_version $VER1 -current_version $VER3"
to:
LDSHAREDFLAGS="-dynamiclib -install_name @rpath/$libdir/$SHAREDLIBM -compatibility_version $VER1 -current_version $VER3"
I didn't really work with configure files before, though.

The issue I see is that in configure the path can be either absolute or relative and we can only enable RPATH when the path is relative.

This change breaks the downstream build for the Perl zlib bindings in https://github.com/pmqs/Compress-Raw-Zlib
I have a github action that builds and tests the perl bindings with all versions of zlib-ng (starting at version 2.0.0). I'm currently using the zlib-ng configure script to build zlib-ng.
All build fine apart from the develop branch and 2.1.3
The error does appears to be RPATH related. For example in https://github.com/pmqs/Compress-Raw-Zlib/actions/runs/5415662654/jobs/9875112580 I see this
"/Users/runner/hostedtoolcache/perl/5.36.1/x64/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- Zlib.bs blib/arch/auto/Compress/Raw/Zlib/Zlib.bs 644
PERL_DL_NONLAZY=1 "/Users/runner/hostedtoolcache/perl/5.36.1/x64/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
# Running Perl version  5.036001
Can't load '/Users/runner/work/Compress-Raw-Zlib/Compress-Raw-Zlib/blib/arch/auto/Compress/Raw/Zlib/Zlib.bundle' for module Compress::Raw::Zlib: dlopen(/Users/runner/work/Compress-Raw-Zlib/Compress-Raw-Zlib/blib/arch/auto/Compress/Raw/Zlib/Zlib.bundle, 0x0002): Library not loaded<EMAIL_ADDRESS>  Referenced from: '/Users/runner/work/Compress-Raw-Zlib/Compress-Raw-Zlib/blib/arch/auto/Compress/Raw/Zlib/Zlib.bundle'
Error:   Reason: tried: '/Users/runner/upstream-zlib-install-2.1.3/lib/Users/runner/upstream-zlib-install-2.1.3/lib/libz-ng.2.dylib' (no such file), '/Users/runner/upstream-zlib-install-2.1.3/lib/Users/runner/upstream-zlib-install-2.1.3/lib/libz-ng.2.dylib' (no such file), '/usr/local/lib/libz-ng.2.dylib' (no such file), '/usr/lib/libz-ng.2.dylib' (no such file) at /Users/runner/hostedtoolcache/perl/5.36.1/x64/lib/5.36.1/darwin-2level/DynaLoader.pm line [21](https://github.com/pmqs/Compress-Raw-Zlib/actions/runs/5415662654/jobs/9875112580#step:10:22)0.
 at t/000prereq.t line 69.
Error: Compilation failed in require at t/000prereq.t line 69.

Note the path /Users/runner/upstream-zlib-install-2.1.3/lib/Users/runner/upstream-zlib-install-2.1.3/lib/libz-ng.2.dylib that has duplicated the directory where the zlib-ng library is stored, namely /Users/runner/upstream-zlib-install-2.1.3/lib/ and the reference to @rpath/Users/runner/upstream-zlib-install-2.1.3/lib/libz-ng.2.dylib
I don't do any Mac programming, so will need to have a dig into RPATH to see what the fix is.
Any hints welcome.

Sorted my build issue.
I had been building zlib-ng with configure, like this
./configure --prefix /some/directory

Adding libdir to the configure commandline sorted it out
./configure --prefix /some/directory --libdir /some/directort/lib

@kislinsk is running into issues with the fix from #1524, as described here: https://github.com/InsightSoftwareConsortium/ITK/issues/4084#issuecomment-1628412935

I would strongly recommend to stick to CMake 3's default of CMP0042 to avoid surprises.
The point of setting an install name (or dylib name) like @rpath/libz.dylib is so that the linker copies this string verbatim into a load command for the executable/library that needs it when linking (no magic here, just a string copy). So this ultimately affects dependents, not zlib-ng the package itself.
Without the @rpath/ prefix in a load command, you can set whatever -Wl,-rpath,/path/to/my/zlib-ng/lib you want on the dependent, but they won't be considered by the dynamic loader.
The only possible issue you can run into is when system zlib has an install name of libz.dylib, and zlib-ng has an install name of @rpath/libz.dylib, and for some reason the dynamic loader attempts to load both, then possibly it will load both system libz and libz-ng because the install name is used as a unique identifier.
I don't know for a fact if that's the case on macOS (I only know glibc well).
But in any case, I don't think that would be necessarily problematic, since when your application is somehow mixing system libz and zlib-ng, you're in trouble anyways since it's unclear what library to use...
The bottom line is: if you drop the default CMake behavior, it's much more likely that application end up using system libz, because their rpaths are ignored. That's a much bigger issue in my opinion.

@haampie Personally I know too little about rpath and how to handle it to really understand what is correct, what is not and what needs to be improved. I think you are saying that #1524 is incorrect/incomplete/not optimal.
If you have time for a PR, then it would be easier to see what you mean specifically and make sure everyone is on the same page when reviewing it.
I was a little confused that we needed to handle rpath differently in osx compared to linux, but for all I know that is just due to a difference between the two os.
It does sound like something we might want to have a regression test for.

I'll have a look later what the implications are on macOS when you're in a situation where system libz and zlib-ng's libz are mixed, and their install names are not identical.
Regarding rpaths, it works more or less the same on Linux and macOS: you embed extra library search paths in the binary.
The difference is that on macOS you need to say: this binary needs @rpath/libz.dylib for rpaths to be considered -- they're substituted. On Linux that's not necessary, you say it needs libz.so and it will look for it in the rpaths.
So, on macOS you can control what libraries are located in rpaths, and which are not. I guess Apple considers that helpful.
The downside is that you have to somehow put this @rpath/libz.dylib string in the binary, and sometimes people do that after linking, by patching the binary using install_name_tool. They replace libz.dylib with @rpath/libz.dylib. It might not even be part of the build system...
CMake solves this Apple weirdness in a nice and hacky way 🙃 given that the linker always copies the install name of the library into the binary, why not put the @rpath/ prefix in the install name... then however links to your library can automatically use rpaths, no further patching necessary.
Hope that explains something.


about reproducible

When using Mamba1, I found that even after fixing all random seeds, the experiments were still not reproducible. Does Mamba include any non-deterministic atomic operations?

How to solve the non-reproducible problem?

With mamba1, there is nothing that can be done unless you change the GPU kernel, which would require a lot of work. I can't remember if Mamba2 has atomics for the delta_A parameter, but if it doesn't then you should be good. I would say that it would be simpler to make Mamba2 reproducible, but then it might be slower.


fix: allow removal of mailing address

2de28612c - fix: add error message for incorrect listing approval (#4134)
0418793b6 - fix: allow removal of mailing address (#4130)

This is blocked until this PR is merged as it uses the new toast setup: https://github.com/metrotranscom/doorway/pull/651

This has been unblocked and can be reviewed


[feat] Reserve Auction v1.0

New Module Proposal
Description
This module outlines a way for any ERC-721 token holder to create a permissionless reserve auction.

Motivation and Context
ReserveAuctionV1 is an update to ZORA V2 Auction House. NFTs are taken into escrow after the reserve price is met, as well as the current highest bid. After an auction has ended, anyone can settle to payout respective parties and transfer the NFT to the winning bidder.
How has this been tested?
Relevant tests have been included via Foundry.
Checklist:

[x] The module includes tests written for Foundry
[x] The module is documented with NATSPEC
[x] The documentation includes UML Diagrams for external and public functions
[x] The module is a Hyperstructure

👋 @kulkarohan -- I see some updates being pushed 👀
Is it best to hold off from further review until those settle? 💭

hey @almndbtr sorry about that haha we found a few small tweaks earlier that we wanted to make. feel free to further review!

hey! are there outstanding tasks required for this to be considered deploy-ready? my team is working on auction support for media tokens interfacing w/ the zora V3 asks module & it would be amazing to support V3 reserve auctions as well.
thank you for pushing the space forward. ⚡

hey @reefloretto ! we're just restructuring a couple things that we'll push today. planning to deploy Friday!

planning to deploy Friday!

🙏 Hoping the deploy goes well! Godspeed, Zora team 🚀

@everyone
I've restructured Reserve Auction into four gas-optimized variants:

Core ETH
Core ERC-20
Finders ETH
Finders ERC-20

'Core' are minimal reserve auctions and 'Finders' add support for finders fee.
An important note: while ETH variants are ETH-only, the ERC-20 variants are still compatible with ETH via setting address(0) as the currency.
So if you'd like the simplicity of interacting with a sole contract, the Finders ERC-20 variant will support all four use-cases (ETH, ERC20s, no finders fee, finders fee) as initially designed. But if you'd like to optimize per use-case, you'll now be able to do so as well.
Lemme know if there are any Qs -- thanks for your patience.


Add ability to open file/file diff from source control context menu

[x] Added an entry to CHANGELOG.md if this change could be valuable to users

Codecov Report

Merging #1590 (59246b7) into master (c40d82b) will increase coverage by 0.03%.
The diff coverage is 0.00%.

 Learn more


fix: 🐛 Drop foreign key constraint for Leg.assetId

Description
As of now, chain doesn't validate the Legs to have a valid Asset ticker. This will be handled in on of the chain's future releases. To solve this now, we are dropping the foreign key constraint on the asset attribute of Leg entity.
This problem was found in block 6101310 on testnet, erring as follows -
2022-12-13T12:28:25.053Z <sandbox> ERROR Received an error in handleEvent while handling the event 'settlement.InstructionCreated': Error
    at Query.run (/usr/local/lib/node_modules/@subql/node/node_modules/sequelize/lib/dialects/postgres/query.js:50:25)
    at /usr/local/lib/node_modules/@subql/node/node_modules/sequelize/lib/sequelize.js:313:28
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async PostgresQueryInterface.upsert (/usr/local/lib/node_modules/@subql/node/node_modules/sequelize/lib/dialects/abstract/query-interface.js:330:12)
    at async Function.upsert (/usr/local/lib/node_modules/@subql/node/node_modules/sequelize/lib/model.js:1501:20)
    at async Object.set (/usr/local/lib/node_modules/@subql/node/dist/indexer/store.service.js:299:17)
2022-12-13T12:28:25.055Z <fetch> ERROR failed to index block at height 6101310 handleEvent() SequelizeForeignKeyConstraintError: insert or update on table "legs" violates foreign key constraint "legs_asset_id_fkey"

Breaking Changes
NA
JIRA Link
NA
Checklist

[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 8.5.0-alpha.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 8.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: