Only report runtime isa support if we also have compiler support

If the CPU supports AVX-512 but Corrfunc was only compiled with AVX support (for example), we end up using the fallback kernel by default.  The correct behavior is to use the highest instruction set that has both compile-time and runtime support.
In this PR, I implemented that behavior by modifying instrset_detect().  That fixes the problem globally.  But if we really want instrset_detect() to remain a pure runtime detector, we could fix the dispatch functions in each of the kernels, or wrap instrset_detect() in another function.
Should we warn the user about having runtime support but not compile-time support?  That's a strange situation that's usually caused by using an old compiler.  But with the binutils bug, we have a legitimate situation in which we do not compile against the maximum runtime instruction set.

@lgarrison We should leave instr_detect() as purely a runtime feature detector and perhaps add a separate function that finds the highest isa with both runtime and compile-time support. That should solve the problem of offloading to the fallback kernel instead of the next highest isa.
We should also warn the user if the compile time support is lower than runtime support if we are not working around the GAS bug.

Okay, how about I rename instr_detect() to instr_detect_runtime() and make a new instr_detect() that checks both runtime and compile-time support?

@lgarrison That sounds good. Would it make sense to rename this new instr_detect to get_max_usable_isa()?

@lgarrison Once this is merged in, are you fine with releasing v2.3.2?

Yes!  Will push the changes in a few minutes.
On Fri, Oct 11, 2019 at 12:47 PM Manodeep Sinha<EMAIL_ADDRESS>wrote:

@lgarrison https://github.com/lgarrison Once this is merged in, are you
fine with releasing v2.3.2?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/manodeep/Corrfunc/pull/200?email_source=notifications&email_token=ABLA7S234SAYSWSVHWCQO7LQOCUZ7A5CNFSM4I6GED52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBASGVI#issuecomment-541139797,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLA7S7J55HAKXWO7RJHZX3QOCUZ7ANCNFSM4I6GED5Q
.

--
Lehman Garrison<EMAIL_ADDRESS>Flatiron Research Fellow, Cosmology X Data Science Group
Center for Computational Astrophysics, Flatiron Institute
lgarrison.github.io

@lgarrison Do you want to add in fallback_offset = highest_isa; as well -- that way the code will default to the highest supported ISA rather than the fallback kernel? That would also mean replacing the last default option with num_functions - 1 (rather than fallback_option).

Yes, that's a good idea.  But the fallback_offset index isn't just the isa number, unfortunately.  We need to know the index in the function array.  I'll have to think about whether there's a clean way to do that.

The highest compiled kernel will always be at index 0. However, since the compiled kernels might not correspond to the runtime available isa, the required index will be different. Would something like this work:
int highest_available_isa = fallback_offset;
if (iset >=9)

Just pushed another version, does it look okay?  I will port it to the other CFs if so.  I tested it, and it seems to work.

@lgarrison Pinging. We should be able to release v2.3.2 with this and the few small changes in the docs.

Agreed!  The porting to the other CFs will take an hour or so, I'll try to finish it on Thursday or Friday.

@manodeep All done!  Can you look over the diff one more time?  If Travis passes, I think we're ready to merge & release.

@lgarrison I left a couple of minor comments.
Also, will you please confirm that get_max_usable_isa returns the fastest available function (or prints appropriate warning) for the following 4 combinations between (compiler_unsupported_isa, compiler_supported_isa) and (runtime_unsupported_isa, runtime_supported_isa)?

// cpu_features_test.c
#include <stdio.h>
#include "utils/cpu_features.c"

int main(void){
	printf("get_max_usable_isa(): %d\n", get_max_usable_isa());
	return 0;
}

Compiler supported, runtime supported:
$ gcc -mavx2 -std=c99 cpu_features_test.c -o cpu_features_test -I$HOME/corrfunc
$ ./cpu_features_test
get_max_usable_isa(): 8

Compiler supported, runtime unsupported:
$ gcc -mavx512f -std=c99 cpu_features_test.c -o cpu_features_test -I$HOME/corrfunc
$ ./cpu_features_test
get_max_usable_isa(): 8

This is right because -mavx512f implies -mavx2 and lower.
Compiler unsupported, runtime supported:
$ gcc -mavx -std=c99 cpu_features_test.c -o cpu_features_test -I$HOME/corrfunc
$ ./cpu_features_test
[Warning] The CPU supports AVX2 but the compiler does not.  Can you try another compiler?
get_max_usable_isa(): 7

Look okay?

@lgarrison This is on my list for today

@lgarrison Everything looks good. I have one suggestion - we should move the instruction set enums into cpu_features.h and include cpu_features.h within defs.h. That way cpu_features.h does not need to include defs.h.
We should probably also rename defs.h to corrfunc.h :)

Done!
And I agree with the renaming suggestion for v3.0.

@lgarrison Should I go ahead and "squash-merge"? Was there anything else to update on this PR?

Yes, I think it is ready to squash & merge!


Add homarr-iframes project note in the iframes widget docs

Category

Documentation.

Overview

I made a post on reddit showing my Homarr dashboard with iframes of my project, homarr-iframes. A Homarr dev asked me if I wanted to link the project on the official documentation, so there is.

I don't know if the iframe widget page is the best place to put it, or if the note I added is too big, so you can change it if you decide to add it.

Screenshot

Thanks for your feedback, I updated the docs.


每次刷新都会跳到聊天的第一条信息

如题。我记得以前的版本没有这个问题

me too

回退之前的版本没问题

有的人喜欢刷新跳第一条，有的人则喜欢跳最新的一条。 众口难调。

如题。我记得以前的版本没有这个问题

回退倒什么版本没问题，我前两天也遇到了，但是自己用的不是最新的，我昨天更新到最新好像没出现过

如题。我记得以前的版本没有这个问题

回退倒什么版本没问题，我前两天也遇到了，但是自己用的不是最新的，我昨天更新到最新好像没出现过

我更新了今天的版本，依然会跳到第一条消息

Yes this bug exists. On local run this bug isn't happening. but on remote host this bug occurred.
Here's what I found:
When initially access the site that is hosted on remote server, this isn't occurred but after refreshing the page or close the browser and again go to site, this bug keeps appearing.
Possible reason:
scrollToBotton implemented on sider, which is the main reason of this bug. Maybe there is a  chat data sync delay and during that time scrollToBottom is triggered.

As the title. I remember that the previous version did not have this problem

It’s okay to go back to any version. I also encountered it two days ago, but I’m not using the latest version. I updated to the latest version yesterday and it didn’t seem to appear.

Yes this bug exists. On local run this bug isn't happening. but on remote host this bug occurred.
Here's what I found:
When initially access the site that is hosted on remote server, this isn't occurred but after refreshing the page or close the browser and again go to site, this bug keeps appearing.
Possible reason:
scrollToBotton implemented on sider, which is the main reason of this bug. Maybe there is a  chat data sync delay and during that time scrollToBottom is triggered.

貌似这个统计功能也并未生效

貌似这个统计功能也并未生效

新发一些聊天对话试试看 应该会有 旧的可能没有

我发现我反代之后就会跳到第一条消息，不反代就是正常的

a6f7bc0ec12e4e8967697e2bf376ec1796f5851f
这个提交尝试修复了下，如果有人自己 pull了，没问题 记得这里说下
I tried to fix this submission, but if someone pulled it themselves, there's no problem. Remember to mention it here

a6f7bc0
这个提交尝试修复了下，如果有人自己 pull了，没问题 记得这里说下
I tried to fix this submission, but if someone pulled it themselves, there's no problem. Remember to mention it here

如果数据库部署在另外的服务器上，这个问题依旧存在。当数据库和项目在同一服务器上，该问题的确得到了修复。


check if we can record videos while running the tests

https://playwright.dev/docs/videos
looks like playwrigth allows to record videos - would be good to see if this works together with codeceptjs
alternative: https://github.com/qawolf/playwright-video

It looks like you can access the browser.newContext options like this:

I was able to successfully produce videos with that-
The only issue seems to be: every test overwrites the existing video (I wasn't able to confirm this but it seems at the end only 1 video exists)
Example Video:
f78ed2646acf82e3a99d49d7a9805871.zip


Bypass block

I was able to get this to work intermittently by modifying some driver configurations and retrying on failure.
I followed instructions here:

https://stackoverflow.com/questions/53039551/selenium-webdriver-modifying-navigator-webdriver-flag-to-prevent-selenium-detec
https://stackoverflow.com/a/53040904

Unfortunately, this doesn't work 100% of the time.  I'm not sure why it only sometimes works.

Approved to merge. Partial functionality is better than not working at all :)


02-load-data-with-power-query-in-power-bi-desktop.md

Source:
six columns
four column
Current Translation:
sei colonne
quattro colonne
Suggested Translation:
6 colonne
4 colonne

Run bugfix tool and waiting for result.


If network connection goes down during loading, it is possible to get endless spinners

To repro:
Open Home and wait until rail titles load, then cut network connectivity.
This will result in individual rails failing to load even when network connectivity has been restored and the user pulls-to-refresh:

Current behaviour is that now, these rails will be set to null. Closing this for now, and opening a new ticket for improved behaviour (#366).


Demonstrate kotlin gazelle plugin parser failure

Reproduce parser failure in kotlin gazelle plugin. Maybe this is a result of outdated Kotlin grammer in go-tree-sitter?.

Type of change

Bug fix (change which fixes an issue)

For changes visible to end-users
TODO

Breaking change (this change will force users to change their own code or config)
Relevant documentation has been updated
Suggested release notes are provided below:

Test plan

New test cases added

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Can you update treesitter via go.mod to fix the validation error?

Can you update treesitter via go.mod to fix the validation error?

I think there is still a at least one bug upstream (for value classes). It should be fixed by https://github.com/fwcd/tree-sitter-kotlin/pull/104. I can update this once that PR is merged.

Ok, lets wait for that 👍

Related issue: https://github.com/aspect-build/aspect-cli/issues/530

I pulled in the https://github.com/fwcd/tree-sitter-kotlin/pull/104 and go-tree-sitter change into https://github.com/aspect-build/aspect-cli/pull/536. I'm still waiting on review of https://github.com/fwcd/tree-sitter-kotlin/pull/104.


implement asset pipelining

cf. Rails' asset pipeline
Per IRC convo with @pjz, one suggestion for Aspen would be to implement this as a library that one would use in a simplate:
from aspen.assets import cat, minify
^L
files = ['first.js', 'second.js']
response.headers.set('Last-Modified', 'blahblahblah')
response.headers.set('ETag', 'deadbeef')
^L
{{ minify(cat(files)) }}

This strikes me as overly verbose, however, especially configuring the response headers for caching. We also need to gzip these.
I suggest we introduce a new simplate variant, the Pipeline Simplate. This would apply to *.min.js and *.min.css files and would look like this:
./file1.js
/path/to/file2.js
/assets/%version/file3.js

That's a newline-separated listing of filesystem paths. We should use / on all platforms and convert to \ transparently. Paths are relative to the location of the *.min.js file itself. Absolute paths start at the website root.
How do we support version tokens in the filename? To date I've done this by storing assets in a virtual directory. That's probably fine.
How do we vary the <script> elements to import the right files? How about a helper method on website that takes the URL path of a pipeline simplate and spits out script tags based on a website.version attribute?
<!doctype html>
<html>
  <head>
    {{ website.scripts('assets/%version/myapp.min.js') }}
  </head>
</html>

With website.version = '1.0.1' this would result in:
<!doctype html>
<html>
  <head>
    <script src="/assets/1.0.1/myapp.min.js"></script>
  </head>
</html>

And with website.version = None:
<!doctype html>
<html>
  <head>
    <script src="/assets/-/file1.js"></script>
    <script src="/path/to/file2.js"></script>
    <script src="/assets/-/file3.js"></script>
  </head>
</html>

See also Fanstatic, BowerStatic, and WebAssets.


Refactor blob load related error handling in multiple places.

Use Promise.allSettled() to capture failures.
Refactor _applyOriginal() and _applyBlob() to a single
method _applyElement() that fails over the element to the
original URL if the blob is null.
Make _getObject() return a dummy data{} object with null blob
instead of a reject() in case of failed DB+HTTP fetch so that
_applyElement() gracefully fails over to the original URL.
Rename _getBlob() to _getDBblob() for clarity.
Add <script>.onerror() to not break the load chain in case
a script fails to load.

Great!
This PR resolves the issue #7
Also dissolved PR #8

WIP. Strange issues on Safari continue to persist.

Fixed in https://github.com/knadh/indexed-cache/commit/fa7a6504deeb0ed7e96868f5169fcea6f7e43b32


Enable route pre-rendering / cacheing via fastboot mechanisms.

I've hit many use cases on mobile where optimized routes will still have rendering times > 100ms.  Sometimes these routes, such as index route, are heavily trafficked by a single user, being entered and left often.
I've tried various non-ember centric methods of pre-rendering and cacheing views and their html, but these approaches' reliance on private APIs inevitably leaves them heavily susceptible to internal api churn.
It would be a huge benefit for apps that need to highly optimize rendering if the fastboot work resulted in additional hooks for connecting and disconnecting rendered html to any view, but especially the primary view/component for a route.
Something such as .on('viewWillDisconnect') which could receive the current state and DOM for a view and .on('viewWillConnect') which could be provided a state and a DOM that's either been cached previously or pre-rendered via an ajax call to the server running fastboot.  The ultimate goal being that rendering could be optimally balanced between client and server as needed.
It's possible this is already part of the plan for Fastboot, but I haven't seen this particular use case of feature set discussed.  If it is part of the plan, I'd love to read more about it.

I was wondering about caching myself. If you had 1000 users all hitting a route at once, you don't want the node server rendering 1000 requests, but passing a static cached version. Is that how it will work?
Sorry, I'm hijacking a little.

@jimmyjamieson I'm referring to "fastbooting" and pre-rendering routes AFTER the app has already booted, sometimes that's desired.
As for your idea, you're going to have that problem no matter what if it's behind a login and user specific data.  I don't know if this is on their radar, but being able to specify whether a route is user/session specific or not would go a long way to allowing that request to cache.

Interesting idea but I think it's out of scope for FastBoot 1.0. Let's revisit this again once we ship rehydration, as that's still the largest unknown.


error when clicking on chromecast button?

Getting this error when clicking on chromecasts icon:
index.js:267 Uncaught TypeError: Cannot read property 'removeClass' of null

error not in 38e56fd (before the recent CSS changes)

@jbenet have you updated the modules? npm i

Ah, that was it. tanks


Is this project in use by anyone?

At this time, the kubernetes project is considering archiving this project. It may still be forked and maintained externally, however there does not appear to be enough momentum in project to keep it going.
If you are a user of this project, please chime in on this thread.

@mrbobbytables I am currently exploring the possibility of using this project. I'm not familiar with k8s community procedures for archival, but considering the merged PR above, should I assume a decision has been made to archive it?

@danicat yup, the repos will be archived. People will be free to fork and maintain their own copy and if an authoritative fork pops up we can update descriptions pointing to it 👍

Thanks for the clarification!

This project is being archived, closing open issues and PRs.
Please see this PR for more information: https://github.com/kubernetes/community/pull/6632


Fix debounce issue (not updating)

This stackoverflow question had a very good explanation of what is going on (the highest voted answer) : http://stackoverflow.com/questions/23123138/perform-debounce-in-react-js
I discovered the bug when I had two instances of react-codemirror on the same page, and when the first instance got new props it didn't rerender.
When I put a breakpoint in the debounced function I saw that it was newer called with the first instance's props, it was called with the other instances props.

Thanks @Hatlen! Much appreciated, I'll get this published asap.

Nice! And thanks a lot for making/maintaining this super useful component!


Copy FreeCEN1 Scotland PARMS to FreeCEN2

In order to move forward with searching we need to be able to compare the Scotland vld civil parish entries with the PARMS and make sure that they match.
As I believe that we cannot download the PARMS structure from the Scotland Archives we need to create our own somehow. The easiest way is to copy the manually compiled Scotland PARMS from FreeCEN1 to FreeCEN2. That will cover all the entries that we have to date.
We can then extend the matching process that we are doing for the vld entries in England and Wales to Scotland and clean the data.
Margaret Singleton will do the reconciliation.
Geoff

Anne will take a look (Vino to send info on updates)

Just started looking at this and I am a bit confused - sorry.
If I look in FreeCen2 at ABD for example, there are FC1 Pieces (ie PARMS) for census years 1841 - 1871 and there are also FC2 Pieces (ie PARMS) for the same years.
@geoffj-FUG Can you please clarify what we are trying to achieve here.

I have had a look at the PARMS spreadsheet for the Scotland Counties and I belive that the necessary changes can be done by Rhoda.
If we use the same principal as we have for Shipping the civil parish is the same as the piece name. We can then test for mis-matching civil parishes and Margaret Singleton can make the decision as to whether they re added or changed. Margaret still has the capability of amending vld files and will need it until we have finalised the Scotland spreadsheet testing.
Geoff

Being done inn conjunction with #1565


Build llvm 14.0.0.rc1

After the release is before the release...

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This seems to be hitting https://github.com/llvm/llvm-project/issues/53281

@conda-forge/llvmdev, this now builds everywhere (thanks for adding the workaround @xhochy and cleaning up the ninja-vs-make situation!).
Since this PR is only pushing to llvm_rc, I don't think there should be big concerns even if the details might not be perfect, but just for completeness: MSVC and MACOSX_SDK are being bumped in this PR.

@isuruf @xhochy
Just noticed that the CI didn't trigger upon merging. Could someone trigger/restart it please?

Pushed an empty commit

Pushed an empty commit

OK thanks, I'll just do that then next time (where I have maintainer rights...


middleware.go:75:38: multiple-value uuid.NewV1() in single-value context

Hi,
When execute go get github.com/gambol99/keycloak-proxy today.
It showed me with this error.
github.com/gambol99/keycloak-proxy
.\middleware.go:75:38: multiple-value uuid.NewV1() in single-value context

It's trying to compile off the master of github.com/satori/go.uuid where  as the vendor is locked the latest v1.2.0 tag (about 3 commits behind) .. Looks like 0ef6afb introduced an error in return. Perhaps better to
$ go get -u go get github.com/gambol99/keycloak-proxy
$ dep ensure -v

Still not success using above solution.
I had to checkout specified release tag v2.2.2 and build, it works.


GPIO is broken

I don't know why, but the raspi-io is broken now. Pin modes are not being set correctly via calls to pinMode() in the C++ side of things within raspi-gpio. I've been investigating to see if a new version of Wiring Pi caused it, but that doesn't appear to be the case.
Unfortunately, I'm completely stumped why this is happening. I'll keep digging though. Worse comes to worse, I'll dump Wiring Pi completely and switch to pigpio for everything, which is already used in part of Raspi.js

That sounds really annoying. Let me know if there's anything I can do to lend a hand.

Whew, Raspi IO 8.0.0 is out! It should fix this issue because we no longer rely on Wiring Pi!
@andrewn, if you have a chance, could you take 8.0.0 for a spin and make sure it still works for you?

I've just tried Raspi IO 8.0.1 on a Pi Zero W with one of my PCBs that has a few RGB LEDs (soft PWM) and push-buttons. It's all working fine for me.
Thanks so much for the rapid rewrite!

Thanks for testing @andrewn! I'm going to go ahead and close this now, I think we've managed to find all the regressions.


Frontend/feature/transfer status label

This is a small change according to the design which becomes handy for the upcoming expiration handling of transfers.
But this PR contains some additional commits that help to clean up some parts around the transfer information components to keep things tight. Read the commit messages to get some help with the not so easy git diff here.

Please note that main is currently broken. I'll rebase once this got resolved.

Fixed. ✔

Disclaimer:
In result of the current personnel shortage, management has decided to empower me to merge less critical pull requests on my own without further reviews. This can be seen especially critical since we still have not enough test coverage. Especially a safety net with end-to-end tests is missing. I'll do my best job to find a balance between making progress and working secure as a single developer for the majority of the upcoming pull requests that are frontend related.


Chokidar (fs.watch?) seems to lock parent of the watched

Chokidar seems to lock parent directory on Windows 7 when being watched?
Is this expected? Is this an artifact of the iojs fs.watch() method? Are there any possible work arounds?

Is this an artifact of the iojs fs.watch() method?

Yes

Is this expected?

I've heard it reported before; it certainly isn't deliberate

Are there any possible work arounds?

usePolling: true perhaps

https://github.com/joyent/node/issues/8371
https://github.com/joyent/node/issues/3963
Closing this issue as there does not appear to be anything chokidar could do to have an impact on this. Plus it appears to be the intended behavior of the windows file system.

Hey, it seems they have fixed this recently: https://github.com/nodejs/node/issues/375, https://github.com/nodejs/node/blob/master/deps/uv/ChangeLog#L277, https://github.com/nodejs/node/commit/a338eb3c3e712fcaacdb475cc6f3378259a3d534


Support type safety for string types in vscode-languageserver-protocol

vscode-languageserver-protocol is a great package for writing type-safe tests for language servers. I.e.:
import test from 'tape'
import {
  createProtocolConnection,
  InitializeRequest,
  IPCMessageReader,
  IPCMessageWriter
} from 'vscode-languageserver-protocol/node.js'

test(async (t) => {
  const proc = spawn(
    'node',
    [pathToLanguageServer, '--node-ipc'],
    { cwd, stdio: [null, 'inherit', 'inherit', 'ipc'] }
  )
  const connection = createProtocolConnection(
    new IPCMessageReader(proc),
    new IPCMessageWriter(proc)
  )
  t.teardown(() => {
    connection.end()
    proc.kill()
  })
  connection.listen()

  const initializeResponse = await connection.sendRequest(
    InitializeRequest.type,
    {
      processId: null,
      rootUri: null,
      capabilities: {},
      workspaceFolders: null
    }
  )
});

However, I personally prefer to make calls looks closer to the actual protocol:
  const initializeResponse = await connection.sendRequest(
-   InitializeRequest.type,
+   'initialize',
    {
      processId: null,
      rootUri: null,
      capabilities: {},
      workspaceFolders: null
    }
  )

This is allowed by vscode-languageserver-protocol, but at the cost of type safety.
I suggest to make requests and notifications for known types type-safe if they are passed as strings. This would work the same was as for example HTMLElementTagNameMap and document.createElement() in TypeScript’s builtin dom lib.

If we go down that route we should basically deprecate the old RequestType based approach. The current approach got chosen when TS didn't offer a signature overload on string constants :-).

I’d like to do this.
My suggested approach is to make 4 interfaces:
export interface ClientToServerRequests {
  /**
   * The initialize request is sent from the client to the server.
   * It is sent once as the request after starting up the server.
   * The requests parameter is of type [InitializeParams](#InitializeParams)
   * the response if of type [InitializeResult](#InitializeResult) of a Thenable that
   * resolves to such.
   */
  initialize: [InitializeParams, InitializeResult];

  // …
}

export interface ServerToClientRequests {
  /**
   * The show message request is sent from the server to the client to show a message
   * and a set of options actions to the user.
   */
  'window/showMessageRequest': [ShowMessageRequestParams, MessageActionItem | null];

  // …
}

export interface ClientToServerNotifications {
  /**
   * The document open notification is sent from the client to the server to signal
   * newly opened text documents. The document's truth is now managed by the client
   * and the server must not try to read the document's truth using the document's
   * uri. Open in this sense means it is managed by the client. It doesn't necessarily
   * mean that its content is presented in an editor. An open notification must not
   * be sent more than once without a corresponding close notification send before.
   * This means open and close notification must be balanced and the max open count
   * is one.
   */
  'textDocument/didOpen': DidOpenTextDocumentParams;
  // XXX I don’t understand what TextDocumentRegistrationOptions means in the original code.

  // …
}

export interface ServerToClientNotifications {
  /**
   * The show message notification is sent from a server to a client to ask
   * the client to display a particular message in the user interface.
   */
  'window/showMessage': ShowMessageParams;

  // …
}

How would you deprecate the RequestType based approach?
The simplest approach would be to just make the following change.
  /**
   * The initialize request is sent from the client to the server.
   * It is sent once as the request after starting up the server.
   * The requests parameter is of type [InitializeParams](#InitializeParams)
   * the response if of type [InitializeResult](#InitializeResult) of a Thenable that
   * resolves to such.
+  *
+  * @deprecated
   */
  export namespace InitializeRequest {
  	export const method: 'initialize' = 'initialize';
  	export const messageDirection: MessageDirection = MessageDirection.clientToServer;
  	export const type = new ProtocolRequestType<InitializeParams, InitializeResult, never, InitializeError, void>(method);
  }

This means documentation is duplicated though. It could be removed.
  /**
-  * The initialize request is sent from the client to the server.
-  * It is sent once as the request after starting up the server.
-  * The requests parameter is of type [InitializeParams](#InitializeParams)
-  * the response if of type [InitializeResult](#InitializeResult) of a Thenable that
-  * resolves to such.
+  * @deprecated
   */
  export namespace InitializeRequest {
  	export const method: 'initialize' = 'initialize';
  	export const messageDirection: MessageDirection = MessageDirection.clientToServer;
  	export const type = new ProtocolRequestType<InitializeParams, InitializeResult, never, InitializeError, void>(method);
  }

It would even be possible to replace type with their respective methods. Because they are constants strings, this still provides the same level of type safety when invoking onNotification, sendNotification, onRequest, or sendRequest. However, this may be breaking in ways I don’t understand. I.e. are people allowed to define their own request types?
  export namespace InitializeRequest {
  	export const method: 'initialize' = 'initialize';
  	export const messageDirection: MessageDirection = MessageDirection.clientToServer;
- 	export const type = new ProtocolRequestType<InitializeParams, InitializeResult, never, InitializeError, void>(method);
+ 	export const type = method;
  }

There is also a script to generate protocol/metaModel.json. It looks like it also depends on the explicit current code layout. However, this file is unpublished and appears to be unused. Is this file used somehow? Should this keep working?

The current approach got chosen when TS didn't offer a signature overload on string constants :-).

I don’t even remember this. This must have been a while ago. :sweat_smile:

Can you please outline how we would do this on the calling side and how we ensure type safety there.
We also need to keep in mind that we have three layers of API. protocol, client & server. Would that mean that we need to define these string overloads on all three levels?
And the jsonrpc package currently uses the request types as well to allow usages outside of LSP to have a type save calling interface. What will we recommend to these clients what they should do?

You might want to look at TS mapped types and this to get some inspiration how an different approach could look like. Here is an example on how to use it: https://github.com/microsoft/lsif-node/blob/af85b765aa3d1a0ecfa1e0b796ae372a5c31ed87/tsc/src/common/writerMessages.ts#L6

I was thinking of something like this (playground):
/**
 * Stripped down version of LSP initialize parameters for demo purposes.
 */
export interface InitializeParams {
	/**
	 * Information about the client
	 *
	 * @since 3.15.0
	 */
	clientInfo?: {
		/**
		 * The name of the client as defined by the client.
		 */
		name: string;

		/**
		 * The client's version as defined by the client.
		 */
		version?: string;
	};
}

/**
 * Stripped down version of LSP result returned from an initialize request.
 */
export interface InitializeResult<T = any> {
	/**
	 * Information about the server.
	 *
	 * @since 3.15.0
	 */
	serverInfo?: {
		/**
		 * The name of the server as defined by the server.
		 */
		name: string;

		/**
		 * The server's version as defined by the server.
		 */
		version?: string;
	};
}

export interface ClientToServerRequests {
  /**
   * The initialize request is sent from the client to the server.
   * It is sent once as the request after starting up the server.
   * The requests parameter is of type [InitializeParams](#InitializeParams)
   * the response if of type [InitializeResult](#InitializeResult) of a Thenable that
   * resolves to such.
   */
  initialize: [InitializeParams, InitializeResult];

  // …
}

interface ProtocolConnection {
	sendRequest<T extends string>(
		type: T,
		params: T extends keyof ClientToServerRequests ? ClientToServerRequests[T][0] : unknown
	): Promise<T extends keyof ClientToServerRequests ? ClientToServerRequests[T][1] : any>;
}

namespace InitializeRequest {
	export const method = 'initialize';
	export const type = method;
}

// Below would be client code.

declare const connection: ProtocolConnection;

{
	const { serverInfo, invalid } = await connection.sendRequest('initialize', {
		clientInfo: {
			name: 'VSCode',
			version: '1.2.3'
		},
		invalid: 'This option is not allowed'
	})
}

{
	// This still works
	const { serverInfo, invalid } = await connection.sendRequest(InitializeRequest.type, {
		clientInfo: {
			name: 'VSCode',
			version: '1.2.3'
		},
		invalid: 'This option is not allowed'
	})
}

const thisIsAny = await connection.sendRequest('unknown string', 'Anything is allowed here')

It would work in a very similar way when using a mapped type as you linked. Either way is fine IMO.
If customized connection types are needed for vscode-jsonrpc, then MessageConnection could accept a generic to make it typed. This would have the added benefit that all method invocations of that instance would be typed.
interface MessageConnection<ClientToServerRequest, ServerToClientRequest, ClientToServerNotification, ServerToClientNotification> {
	sendRequest<T extends string>(
		type: T,
		params: T extends keyof ClientToServerRequest ? ClientToServerRequest[T][0] : unknown
	): Promise<T extends keyof ClientToServerRequest ? ClientToServerRequest[T][1] : any>;
}

In this case ProtocolConnection could be typed as:
interface ProtocolConnection extends MessageConnection<LSPClientToServerRequest, LSPServerToClientRequest, LSPClientToServerNotification, LSPServerToClientNotification> {}

Actually that all goes into the right direction. I would actually prefer a solution that  is more in line with what I liked to. Especially since I use the same approach here now as well: https://github.com/microsoft/vscode-wasm/blob/86da64653a6234f3dfe78ed4f609347ed10f4a28/sync-api-common/src/common/connection.ts#L598
Makes things overall more consistent.

I gave this a try, but I’m having an issue dealing with unknown methods.

interface InitializeParams {
    foo: 'bar';
    fooz?: 'baz';
}

interface InitializeResult {
    ready: true
}

export interface InitializeRequest {
	method: 'initialize';
	params: InitializeParams;
	result: InitializeResult;
}

export interface ShutdownRequest {
	method: 'shutdown';
    result: 'shutdown success';
}

export interface CancellationToken {
    readonly isCancellationRequested: boolean;
}

export type ClientToServerRequest = InitializeRequest | ShutdownRequest;

declare function sendRequest<U, M extends string>(
    method: M,
    params: M extends Extract<ClientToServerRequest, { method: M }>['method'] ? Extract<ClientToServerRequest, { method: M, params: any }>['params'] : unknown,
    token?: CancellationToken
): Promise<M extends Extract<ClientToServerRequest, { method: M }>['method'] ? Extract<ClientToServerRequest, { method: M, params: any }>['result'] : unknown>;
declare function sendRequest<U, M extends string>(
    method: M extends Extract<ClientToServerRequest, { method: M, params: any }>['method'] ? never : M,
    token?: CancellationToken
): Promise<M extends Extract<ClientToServerRequest, { method: M }>['method'] ? Extract<ClientToServerRequest, { method: M }>['result'] : unknown>;
declare function sendRequest<R>(
    type: string,
    params: unknown,
    token?: CancellationToken
): Promise<R>;

sendRequest('initialize', {foo: 'bar', }, { isCancellationRequested: true })
// @ts-expect-error
sendRequest('initialize', { isCancellationRequested: true })
// @ts-expect-error
sendRequest('shutdown', {foo: 'bar'}, { isCancellationRequested: true })
sendRequest('shutdown')
sendRequest('shutdown', { isCancellationRequested: true })
// @ts-expect-error
sendRequest('initialize', {fpp: 'bar'})
sendRequest('asd')

playground link
In this case if the params are invalid, the type definition falls through to the one that accepts any string and unknown params. I tried a couple of things, but couldn’t figure it out. Do we still need this signature?

I need to think a little about this. Out of the box I have no good idea and we can't remove the string signature easily since it is used for custom untyped message.

I noticed the same issue I was encountering applies to the usage of ProtocolRequestType.
const result = await connection.sendRequest(InitializeRequest.type, 'This can be anything')

Just like with my fiddling in the playground, it means result is of type any. So this doesn’t really have to block this issue.

I do get a proper error from TS (at least on the client):

I can do
void clientConnection!.sendRequest(InitializeRequest.type, 'this can be anything');

on a protocol connection however, this is a typing oversight. The signatures
sendRequest<R>(method: MessageSignature | string, token?: CancellationToken): Promise<R>;

is actually bogus since MessageSignature is not very usefull since it is an interface without any params and return value typing. I  should fix this on the RPC layer.

Opened https://github.com/microsoft/vscode-languageserver-node/issues/1130


Implement an in-memory cache of aggregate instances.

Fixes #185
This PR introduces a highly-use-case-specific cache to the aggregate.Sink. Each handler has its own cache instance, and each record in the cache represents an aggregate instance.
Records are "acquired" from the cache, locking them so that no other goroutine can acquire them at the same time. This ensures that only one goroutine handles a message for a given instance at a time, reducing the likelihood of OCC failures without any IO. (This approach made #187 redundant, which is why I closed it).
When a cache record has been acquired, the acquirer must explicitly call a KeepAlive() method in order to retain that record in the cache when it's released. This approach feels a little unusual to me, but seems to work well in practice because it automatically invalidates the cache record whenever there is a failure condition, which for aggregates includes several very intentional panic().
Some other notes:

I used sync.Map. I will need to benchmark to know that this is the right choice, but the intent is definitely that the cache should remain quite stable which suits sync.Map performance profile. This could definitely change to map + mutex with little issue.

I tried to keep manipulations of the underlying map to a minimum. This is another request I chose the acquire/release approach, rather than get/set like you might normally have in a cache. When a record is manipulated and marked with KeepAlive() the same record simply stays in the map, there is no update of the map at all in the happy-path.

As best I can tell the code changes are complete. The existing test suite is passing, after some modifications that make it care less about HOW the aggregate state is loaded, and rather just ensure that it has the right state.
The aggregate.Sink type needs explicit tests to ensure that the cache is invalidated after a failure, and the cache package itself has no tests yet.


Fix test cases for middleware_bench

Fix case issues for
•test_postgresql
•test_orion_raid
•test_terasort
•test_zookeeper (only fail against AWS)
•test_terasort on AWS platform need interaction when run command apt upgrade -y procps

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: lilidengostc sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[Bug-FE][UI Next][V1.0.0-Alpha] The input box is not cleared and the last entered data is retained

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
The input box is not cleared and the last entered data is retained

What you expected to happen
Clean up local data in time after clicking submit
How to reproduce
1、Click New Project
2、Enter the project name, notes
3、Click submit
4、Click New Project
Input box will appear the last new content is not cleared
Anything else
No response
Version
dev
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thank you for your feedback. Please check this issue https://github.com/apache/dolphinscheduler/issues/9024. I will close this issue.


Refatory/fix all methods find by

Coverage remained the same at 100.0% when pulling 162117d066b99b8e7a8746ba9c9d74532878bd46 on Refatory/fix-all-methods-find_by into 4d3df85f01d3b97ed7e5db496c83985261ee6bc4 on V3.

Coverage remained the same at 100.0% when pulling 4e6e0090090ccf91e398460dffeb1481776d87d6 on Refatory/fix-all-methods-find_by into 4d3df85f01d3b97ed7e5db496c83985261ee6bc4 on V3.

Coverage remained the same at 100.0% when pulling 4e6e0090090ccf91e398460dffeb1481776d87d6 on Refatory/fix-all-methods-find_by into 4d3df85f01d3b97ed7e5db496c83985261ee6bc4 on V3.

Coverage remained the same at 100.0% when pulling 218579ae5d1c7137f2a98e7bf5657112f62edf41 on Refatory/fix-all-methods-find_by into 4d3df85f01d3b97ed7e5db496c83985261ee6bc4 on V3.


MINOR: Rename GitHub Action job name to Build and test

What changes were proposed in this pull request?
This PR aims to rename the job name of build_and_test.yml file to Build and test.
Why are the changes needed?
Currently, this has a branch name.

In master branch, master is the job name
In branch-1.6 branch, branch-1.6 is the job name.

The correct usage is having the same name for the same jobs.
Note that GitHub Action log view page has a filtering feature by branch names because of this.
How was this patch tested?
Pass the GitHub Action.

Could you review this, @pgaref ?

Could you review this, @pgaref ?

LGTM +1 !

LGTM +1 !

Wow. Thanks, @pgaref ! 😄

Wow. Thanks, @pgaref ! 😄

GitHub Action passed. I'll merge this

GitHub Action passed. I'll merge this


[BUG][opensearch-dashboards] configMap can't be rendered from map

Describe the bug
Configuration for opensearch-dashboard configuration files can't be defined as map anymore, but only as string. It means that configuration for specific file can't be changed incrementally by overriding some specific value, but only by replacing of whole content of configuration file is required.
Those behaviour was introduced by pull request: https://github.com/opensearch-project/helm-charts/pull/212 and merge: https://github.com/opensearch-project/helm-charts/pull/214 as fix to bug report: https://github.com/opensearch-project/helm-charts/issues/156
To Reproduce
Steps to reproduce the behavior:

create value files:

1.yaml
config:
  opensearch_dashboards.yml:
    opensearch.hosts: ["https://opensearch-cluster-master:9200"]
    opensearch.ssl.verificationMode: none
    opensearch.username: "kibanaserver"
    opensearch.password: "change-me"
    opensearch.requestHeadersWhitelist: [ authorization,securitytenant ]
    server.ssl.enabled: true
    server.ssl.certificate: certs/tls.crt
    server.ssl.key: certs/tls.key
    opensearch.ssl.certificateAuthorities: certs/ca.crt
    opensearch_security.multitenancy.enabled: true
    opensearch_security.multitenancy.tenants.preferred: ["Private", "Global"]
    opensearch_security.readonly_mode.roles: ["kibana_read_only"]
    opensearch_security.cookie.secure: true

2.yaml
config:
  opensearch_dashboards.yml:
    opensearch.password: "CHANGED"

Validating manifest rendered by latest version of opensearch-dashbords helm chart
helm template opensearch/opensearch-dashboards -f 1.yaml -f 2.yaml --validate

See error for k8s
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(ConfigMap.data.opensearch_dashboards.yml): invalid type for io.k8s.api.core.v1.ConfigMap.data: got "map", expected "string"

Expected behavior
Validating rendering with chart version before the fix:
helm template opensearch/opensearch-dashboards -f 1.yaml -f 2.yaml --validate --version 1.2.0
...
# Source: opensearch-dashboards/templates/configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: release-name-opensearch-dashboards-config
  labels:
    helm.sh/chart: opensearch-dashboards-1.2.0
    app.kubernetes.io/name: opensearch-dashboards
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "1.2.0"
    app.kubernetes.io/managed-by: Helm
data:
  opensearch_dashboards.yml: |
    opensearch.hosts:
    - https://opensearch-cluster-master:9200
    opensearch.password: CHANGED
    opensearch.requestHeadersWhitelist:
    - authorization
    - securitytenant
    opensearch.ssl.certificateAuthorities: certs/ca.crt
    opensearch.ssl.verificationMode: none
    opensearch.username: kibanaserver
    opensearch_security.cookie.secure: true
    opensearch_security.multitenancy.enabled: true
    opensearch_security.multitenancy.tenants.preferred:
    - Private
    - Global
    opensearch_security.readonly_mode.roles:
    - kibana_read_only
    server.ssl.certificate: certs/tls.crt
    server.ssl.enabled: true
    server.ssl.key: certs/tls.key
...

Config map rendered and validated correctly.
Chart Name
opensearch-dashboards
Screenshots
Host/Environment (please complete the following information):

Helm Version:

version.BuildInfo{Version:"v3.9.0", GitCommit:"7ceeda6c585217a19a1131663d8cd1f7d641b2a7", GitTreeState:"clean", GoVersion:"go1.18.2"}

Kubernetes Version:

Client Version: v1.24.2
Kustomize Version: v4.5.4
Server Version: v1.21.12-eks-a64ea69

Additional context

Hey @bkomraz1  Closing this issue, please feel free to reopen.
Thank you


fix(build): Suppress warnings about doc links pointing to private items

Motivation
I was checking if things work before the upcoming release, and I noticed compiling the docs with
cargo doc --no-deps --document-private-items --all-features

produces lots of warnings because our documentation for some public items contains links to private items. We thought we had these warnings suppressed in Cargo.toml, but it wasn't correct. Note that these warnings show up only locally because CI uses its own config.
Solution
This PR (hopefully) correctly suppresses the warnings and updates CI.
Reviewer Checklist

[x] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[x] Are the PR labels correct?
[x] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

[x] How do you know it works? Does it have tests?

I don't know whether it's worth merging this PR before the stable release. I preemptively labeled it as do-not-merge.

Good catch!


C-k does not work

Status line shows (Ctrl+K) was pressed. Waiting for second key of chord...
VS Code 1.16.0/Windows

Found the problem: my keybindings.json contained custom user chord starting from C-k


Add Dev Branch Deployment Pipeline

We need to create a new format for our deployments to NPM - each deployment that does not contain breaking changes should be automatically updated uploaded to both a v1.0.2 version and also v1.0.2.dev-0.1

[ ] research the syntax and specifics for how to create dev branch versions based on other npm repos
[ ] build github action to perform this update on all non v_.0.2 versions - major versions should likely have a slight delay in the dev package deployments

here is an example npm package with different versions that they are releasing: https://www.npmjs.com/package/react-dom?activeTab=versions

So, as per I got it we must follow Semantic Versioning (SemVer) to create two types of releases:

Stable releases (e.g., v1.0.2): These are regular releases for production, typically without breaking changes.
Development pre-releases (e.g., v1.0.2-dev.0.1): These are for ongoing development or testing purposes and use the -dev.x pre-release tag.

GitHub Action Workflow for Automatic Deployment:

Deploy stable versions when a patch or minor update is made.
Deploy a development version using a dev pre-release tag for the same release.

We can also implement logic to delay the dev version for major releases, which can be manual or delayed by a time period as required.
Here’s a GitHub Action you can use:
name: NPM Publish

# This workflow is triggered automatically when code is pushed to the 'main' branch
# or when a pull request is made against 'main'. It can also be triggered manually.
on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main
  workflow_dispatch:  # Allows manual trigger of the workflow

jobs:
  publish:
    runs-on: ubuntu-latest

    steps:
      # Step 1: Check out the latest code from the repository
      - name: Checkout code
        uses: actions/checkout@v3

      # Step 2: Set up Node.js environment to run NPM commands
      # We're using Node.js version 16, which is a stable LTS version
      - name: Set up Node.js
        uses: actions/setup-node@v3
        with:
          node-version: '16'
          registry-url: 'https://registry.npmjs.org/'  # Set NPM registry

      # Step 3: Install project dependencies from package.json
      # This ensures we have everything needed to run the project
      - name: Install dependencies
        run: npm install

      # Step 4: Determine the current version of the package from package.json
      # We check if it's a major version (e.g., 1.0.0) to decide whether to delay the dev release
      - name: Determine version
        id: version_check
        run: |
          # Get the current version from package.json
          CURRENT_VERSION=$(node -p "require('./package.json').version")
          echo "Current Version: $CURRENT_VERSION"

          # If it's a major or minor version (e.g., 1.0.0 or 1.1.0), delay dev release
          # You could add more advanced logic here if needed
          if [[ "$CURRENT_VERSION" =~ ^[0-9]+\.[0-9]+\.0$ ]]; then
            echo "Major or minor version change detected. Delay dev release."
            echo "::set-output name=delay_dev_release::true"
          else
            echo "::set-output name=delay_dev_release::false"
          fi

      # Step 5: Publish the stable version to NPM
      # This step will always run to upload the latest stable version
      - name: Publish stable version to NPM
        run: npm publish
        env:
          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}  # NPM token stored as a GitHub secret

      # Step 6: Conditionally publish the dev version to NPM
      # This only happens if the current version is NOT a major or minor release
      - name: Publish dev version to NPM
        if: steps.version_check.outputs.delay_dev_release == 'false'
        run: |
          # Increment the prerelease version with a 'dev' tag, e.g., 1.0.2 -> 1.0.2-dev.0
          npm version prerelease --preid=dev
          # Publish the prerelease version with the 'dev' tag
          npm publish --tag dev
        env:
          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}  # NPM token stored as a GitHub secret


Fix for inline tags being treated as block elements

Addresses Issue #2

Fix works perfectly for me and solves my issue with this awesome snippet.
Please merge this pull request.


install packages using pip

pip version 21.3.1 (the latest) is needed, otherwise you will meet errors while installing packages using pip.

cd DNABERT python3 -m pip install --editable . cd examples python3 -m pip install -r requirements.txt
You can try several times to ensure you successfully install all packages required.

cd DNABERT
python3 -m pip install --editable .
cd examples
python3 -m pip install -r requirements.txt
You can try several times to ensure you successfully install all packages required.

git clone https://github.com/NVIDIA/apex
cd apex
pip install -v --no-cache-dir --global-option="--cpp_ext" --global-option="--cuda_ext" ./
python version >= 3.7 is needed. However, the instruction specifies python version 3.6


build: Update to header 1.3.217

Update known-good
Generate source

CI Vulkan-Tools build # 743 running.


Reflection and other services

[x] include ReflectionService
[x] proper naming for ServiceClientImpl in bundle

https://github.com/osmosis-labs/telescope/pull/243


Modify ConfigFiles.pm for cachegroup-based MSO ordering

Currently we have no way to set the primary/secondary servers for multisite configurations by anything other than a static rank value.  I propose the following change in logic during parent configuration at the mid:

Check primary/secondary parent cachegroups for mid.
If any of the assigned origins have cachegroups matching the primary cachegroup (if any), write these entries first, using rank as a secondary sort factor if more than one origin is in this primary cachegroup.
Repeat for mid's secondary cachegroup (if any).
Process remaining by rank (if any).
Process remaining.

By creating origin server cachegroups for each region and selecting these as the primary and secondary parent cachegroup for each mid's cachegroup, we could then have cachegroup-specific primary and secondary preferences.  This will allow the system to automatically generate a parent config for each mid that uses the origin sort order most optimal for its location in MSO primary/secondary configurations.  On the delivery service side, we need only create a delivery service with a primary/secondary MSO config and make certain that the origin servers, if needed, are put in the appropriate origin cachegroups.  The DB and UI requirements are already in place for such a modification.

So digs us deeper in to the current, very confusing paradigm where the origins are in a cg and the origin cg is a parent of the mid cg... Should we consider going back to the drawing board and try to come up with something else?

I think that this is a pretty simple change to make, since it can be done with the one file and section of code.  This functionality is needed ASAP.  In the longer term, I agree - MSO should get a ground-up redesign.

Which exact feature is this about? MSO algorithm with Primary/Backup selection? I believe I tested that in the past, worked for the MSO config, but not for the default dest_domain=*. Do you have an example configuration used and the results?

This is to provide primary/backup selection that is cachegroup sensitive.  The idea is to assign origin servers to location-based cachegroups, and set these cachegroups as the primary or secondary cachegroups for the mid cachegroups.
In cases where these exist, we would evaluate by primary/secondary cachegroup for each mid's parent config, and then rank.  This would allow us to use either or both.  Rank works at the delivery service level, where cachegroup would work per-mid for location specific primary/secondary/tertiary configuration.
This is needed for cases where you want one group of mids to use a specific origin over another, more distant origin.
At this point we're only getting one origin.  From the looks of things, that's because the parent_data sub gives different data for mid servers.  Not sure how to resolve that yet, any help would be appreciated.

I think this should have been closed with #1822.  If not, please re-open...


Blank lines inserted when formatting html files

VSCode Version: Code 1.10.1 (653f8733dd5a5c43d66d7168b4701f94d72b62e5, 2017-03-02T00:33:15.706Z)
OS Version: Windows_NT ia32 10.0.10586
Extensions:

Extension
Author
Version

vscode-refresh-html
bajdzis
0.0.2

vscode-instant-markdown
dbankier
0.2.0

python
donjayamanne
0.5.5

vscode-npm-script
eg2
0.1.8

mssql
ms-mssql
0.1.5

csharp
ms-vscode
1.7.0

Steps to Reproduce:

Edit an html file which includes css within a

I think this has been fixed in VS Code 1.10.2.
See https://github.com/Microsoft/vscode/issues/21717
Please verify!

You are correct.  Just upgraded  from 1.10.1 to 1.10.2 and it now works
correctly.
Thanks
On Mon, Mar 13, 2017 at 9:39 AM, Andre Weinand<EMAIL_ADDRESS>wrote:

@DavidBetteridge https://github.com/DavidBetteridge I think this has
been fixed in VS Code 1.10.2.
See #21717 https://github.com/Microsoft/vscode/issues/21717
Please verify!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/22507#issuecomment-286057710,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIP2e5Zp2ottxSw5jmflbbVnYo5yNtETks5rlQ6-gaJpZM4Ma8H3
.

@DavidBetteridge Thanks for verifying.


getfastq OSError: [Errno 5] Input/output error:

$amalgkit getfastq --id SRR11196121
AMALGKIT version: 0.9.18
AMALGKIT command: /home/tet/miniconda3/bin/amalgkit getfastq --id SRR11196121
AMALGKIT bug report: https://github.com/kfuku52/amalgkit/issues
amalgkit getfastq: start
pigz found. It will be used for compression/decompression in read name formatting.
--id is specified. Downloading SRA metadata from Entrez.
Entrez search term: SRR11196121
Number of SRA records: 1
processing SRA records: 0 - 1
2023-06-23 14:53:12: Converting 0th sample from XML to DataFrame
2023-06-23 14:53:12: Finished converting 1 samples
Filtering SRA entry with --layout: auto
Individual SRA size of SRR11196121: 5,215,532,212.0 bp
Number of SRAs to be processed: 1
Total target size (--max_bp): 999,999,999,999,999 bp
The sum of SRA sizes: 5,215,532,212.0 bp
Target size per SRA: 999,999,999,999,999 bp
Processing SRA ID: SRR11196121
spot_length cannot be obtained directly from metadata. Using total_bases/total_spots instead: 293
Traceback (most recent call last):
File "/home/tet/miniconda3/bin/amalgkit", line 376, in
args.handler(args)
File "/home/tet/miniconda3/bin/amalgkit", line 34, in command_getfastq
getfastq_main(args)
File "/home/tet/miniconda3/lib/python3.9/site-packages/amalgkit/getfastq.py", line 790, in getfastq_main
ext = get_newest_intermediate_file_extension(sra_stat, sra_stat['getfastq_sra_dir'])
File "/home/tet/miniconda3/lib/python3.9/site-packages/amalgkit/util.py", line 437, in get_newest_intermediate_file_extension
files = os.listdir(work_dir)
OSError: [Errno 5] Input/output error: '/media/tet/56D80A6E7A225267/Transcriptome/getfastq/SRR11196121'

AMALGKIT version: 0.9.18
AMALGKIT command: /Users/kf/Dropbox/repos/amalgkit/amalgkit/amalgkit getfastq --id SRR11196121
AMALGKIT bug report: https://github.com/kfuku52/amalgkit/issues
amalgkit getfastq: start
pigz found. It will be used for compression/decompression in read name formatting.
--id is specified. Downloading SRA metadata from Entrez.
Entrez search term: SRR11196121
Number of SRA records: 1
processing SRA records: 0 - 1
2023-06-25 11:40:00: Converting 0th sample from XML to DataFrame
2023-06-25 11:40:00: Finished converting 1 samples
Filtering SRA entry with --layout: auto
Individual SRA size of SRR11196121: 5,215,532,212.0 bp
Number of SRAs to be processed: 1
Total target size (--max_bp): 999,999,999,999,999 bp
The sum of SRA sizes: 5,215,532,212.0 bp
Target size per SRA: 999,999,999,999,999 bp

Processing SRA ID: SRR11196121
spot_length cannot be obtained directly from metadata. Using total_bases/total_spots instead: 293
Library layout: paired
Number of reads: 17,772,385
Single/Paired read length: 293 bp
Total bases: 5,215,532,212 bp
Processing SRR11196121 as publicly available data from SRA.
Previously-downloaded sra file was not detected. New sra file will be downloaded.
Trying to fetch SRR11196121 from AWS: https://sra-pub-run-odp.s3.amazonaws.com/sra/SRR11196121/SRR11196121
SRA file was downloaded with urllib.request from AWS
Total sampled bases: 5,207,308,805 bp
Command: parallel-fastq-dump -t 1 --minReadLen 25 --qual-filter-1 --skip-technical --split-3 --clip --gzip --outdir /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121 --tmpdir /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121 --minSpotId 1 --maxSpotId 17772385 -s /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121.sra
parallel-fastq-dump stdout:
Rejected 76708 READS because of Quality-Filtering
Read 17772385 spots for /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121.sra
Written 17770362 spots for /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121.sra

parallel-fastq-dump stderr:
2023-06-25 11:44:34,121 - SRR ids: ['/Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121.sra']
2023-06-25 11:44:34,121 - extra args: ['--minReadLen', '25', '--qual-filter-1', '--skip-technical', '--split-3', '--clip', '--gzip']
2023-06-25 11:44:34,121 - tempdir: /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/pfd_27jsypzt
2023-06-25 11:44:34,121 - CMD: sra-stat --meta --quick /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121.sra
2023-06-25 11:44:34,217 - /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121.sra spots: 17772385
2023-06-25 11:44:34,217 - blocks: [[1, 17772385]]
2023-06-25 11:44:34,217 - CMD: fastq-dump -N 1 -X 17772385 -O /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/pfd_27jsypzt/0 --minReadLen 25 --qual-filter-1 --skip-technical --split-3 --clip --gzip /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121.sra

Command: fastp --thread 1 --length_required 25 -j /dev/null -h /dev/null --in1 /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121_1.fastq.gz --out1 /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121_1.fastp.fastq.gz --in2 /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121_2.fastq.gz --out2 /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121_2.fastp.fastq.gz
fastp stdout:

fastp stderr:
Read1 before filtering:
total reads: 17697700
total bases:<PHONE_NUMBER>
Q20 bases:<PHONE_NUMBER>(97.7326%)
Q30 bases:<PHONE_NUMBER>(93.5639%)

Read2 before filtering:
total reads: 17697700
total bases:<PHONE_NUMBER>
Q20 bases:<PHONE_NUMBER>(96.2293%)
Q30 bases:<PHONE_NUMBER>(90.7117%)

Read1 after filtering:
total reads: 17442117
total bases:<PHONE_NUMBER>
Q20 bases:<PHONE_NUMBER>(97.8442%)
Q30 bases:<PHONE_NUMBER>(93.7161%)

Read2 after filtering:
total reads: 17442117
total bases:<PHONE_NUMBER>
Q20 bases:<PHONE_NUMBER>(96.9689%)
Q30 bases:<PHONE_NUMBER>(91.5888%)

Filtering result:
reads passed filter: 34884234
reads failed due to low quality: 507806
reads failed due to too many N: 3360
reads failed due to too short: 0
reads with adapter trimmed: 75960
bases trimmed due to adapters: 2502806

Duplication rate: 11.8111%

Insert size peak (evaluated by paired-end reads): 147

JSON report: /dev/null
HTML report: /dev/null

fastp --thread 1 --length_required 25 -j /dev/null -h /dev/null --in1 /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121_1.fastq.gz --out1 /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121_1.fastp.fastq.gz --in2 /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121_2.fastq.gz --out2 /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121_2.fastp.fastq.gz
fastp v0.23.2, time used: 269 seconds

Deleting intermediate file: /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121_1.fastq.gz
Deleting intermediate file: /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121_2.fastq.gz
Time elapsed for 1st-round sequence extraction: SRR11196121, 1,859.0 sec

--- getfastq 1st-round sequence generation report ---
Individual target size: 999,999,999,999,999 bp
Sum of fastq_dump dumped reads: 5,207,308,805 bp
Sum of fastq_dump rejected reads: 22,475,444 bp
Sum of fastq_dump written reads: 5,206,716,066 bp
Sum of fastp input reads: 5,193,510,178 bp
Sum of fastp output reads: 5,115,289,870 bp

0.00% of reads were obtained in the 1st-round sequence generation: 5,115,289,870 bp out of the individual target amount of 999,999,999,999,999 bp
Time elapsed for 1st-round sequence extraction: SRR11196121, 1,586.1 sec

Enough data were obtained in the 1st-round sequence extraction. Proceeding without the 2nd round.
2nd round read extraction improved % bp from 0.00% to 0.00%

Deleting: /Users/kf/Dropbox/repos/amalgkit/data/debug/getfastq/SRR11196121/SRR11196121.sra

--- getfastq final report ---
Target size (--max_bp): 999,999,999,999,999 bp
Sum of fastq_dump dumped reads: 5,207,308,805 bp
Sum of fastq_dump rejected reads: 22,475,444 bp
Sum of fastq_dump written reads: 5,206,716,066 bp
Sum of fastp input reads: 5,193,510,178 bp
Sum of fastp output reads: 5,115,289,870 bp
Individual SRA IDs: SRR11196121
Individual fastq_dump dumped reads (bp): 5,207,308,805
Individual fastq_dump rejected reads (bp): 22,475,444
Individual fastq_dump written reads (bp): 5,206,716,066
Individual fastp input reads (bp): 5,193,510,178
Individual fastp output reads (bp): 5,115,289,870

Time elapsed: 1,863 sec
amalgkit getfastq: end


AOT build error

`
ERROR in ./node_modules/ng2-smart-table/ng2-smart-table.component.scss
Module parse failed: Unexpected token (1:0)
You may need an appropriate loader to handle this file type.
| :host {
|   font-size: 1rem;
|
Child node_modules\ng2-smart-table\components\tbody\tbody.component.scss:
1 asset
1 module
ERROR in ./node_modules/ng2-smart-table/components/tbody/tbody.component.scss
Module parse failed: Unexpected token (1:0)
You may need an appropriate loader to handle this file type.
| :host {
|   .ng2-smart-row {
|     &.selected {

`

Hello Did you found workaround this issue?? I am still stuck at it.


HOTFIX: handle commit failed exception on stream thread's suspend task

Capture CommitFailedException in StreamThread#suspendTasksAndState; also fix log4j outputs for error and warn.

Minor fixes on StreamTask class for comments alignment etc.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6335/
Test FAILed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6320/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6322/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6337/
Test FAILed (JDK 7 and Scala 2.11).

ping @mjsax @dguy to take a look. It contains the hotfix of the suspend-task not handling commit failed exception, also I added a bunch of TODOs for the exception handling issues while making a pass over the class for this fix.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6339/
Test FAILed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6324/
Test FAILed (JDK 8 and Scala 2.12).

@guozhangwang There is a checkstyle error:

:streams:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk8-scala2.12/streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java:30:8: Unused import - org.apache.kafka.streams.state.internals.ThreadCache. [UnusedImports]
FAILED

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6384/
Test FAILed (JDK 8 and Scala 2.12).

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6396/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6381/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6400/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6385/
Test PASSed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6416/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6401/
Test FAILed (JDK 8 and Scala 2.12).

@mjsax @dguy call for review again.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6407/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6422/
Test FAILed (JDK 7 and Scala 2.11).

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6428/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6413/
Test PASSed (JDK 8 and Scala 2.12).

@dguy Addressed the comment.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6459/
Test FAILed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6444/
Test FAILed (JDK 8 and Scala 2.12).

@guozhangwang, LGTM though there are a couple of compilation errors. Might need to rebase:
scala2.11/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:1487: error: cannot find symbol
        final KStreamBuilder builder = new KStreamBuilder();
              ^
  symbol:   class KStreamBuilder
  location: class StreamThreadTest
/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk7-scala2.11/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:1487: error: cannot find symbol
        final KStreamBuilder builder = new KStreamBuilder();
                                           ^
  symbol:   class KStreamBuilder
  location: class StreamThreadTest

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6473/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6458/
Test PASSed (JDK 8 and Scala 2.12).

Thanks @dguy . Merged to trunk and cherry-picked to 0.10.2 after resolving the conflicts.


update for v2

Make sure you've checked off all these things before submitting:

[ ] This pull request contains 100% test coverage.
[ ] This pull request is completely documented. All available fields are listed in the docs with description.
[ ] Each public facing function should include at least one @example in the jsdoc.
[ ] Run npm test before committing.

DO NOT MERGE


Migrate over 4.4 lib dom and webworker

Finalizes changes from the beta to RC.

@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this

The node12 is from a timeout, which Seems unrelated. Will re-trigger. A lot of the RWC errors seems to have come from the addition of abort to AbortSignal which https://github.com/DefinitelyTyped/DefinitelyTyped/pull/54944 might fix -
There's a good question of if we want to ship that change, given that it would force quite a few projects to update their node types version which isn't great.

We're giving Saschanaz a bit of time to see:

https://github.com/microsoft/TypeScript-DOM-lib-generator/pull/1093
https://github.com/microsoft/TypeScript-DOM-lib-generator/pull/1092

and a revised:

https://github.com/microsoft/TypeScript-DOM-lib-generator/pull/1089

For now I've cherry-picked those 3 PRs into this PR. We can change the types further in the final release of 4.4.


[GLUTEN-3108][CH] Fix parsing failure when row serde is org.apache.hadoop.hive.serde2.OpenCSVSerde

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #3108)

LGTM

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3125_time.csv
log/native_master_09_13_2023_1dc14126a_time.csv
difference
percentage

q1
44.71
43.54
-1.175
97.37%

q2
24.32
24.58
0.258
101.06%

q3
37.78
37.58
-0.205
99.46%

q4
41.38
41.77
0.388
100.94%

q5
69.68
69.36
-0.311
99.55%

q6
5.16
6.35
1.196
123.19%

q7
85.29
85.84
0.548
100.64%

q8
79.43
79.11
-0.323
99.59%

q9
115.16
118.08
2.923
102.54%

q10
48.46
45.32
-3.148
93.50%

q11
19.29
19.61
0.320
101.66%

q12
25.12
26.16
1.035
104.12%

q13
50.67
50.61
-0.057
99.89%

q14
13.21
16.64
3.427
125.94%

q15
28.82
26.80
-2.026
92.97%

q16
16.42
15.83
-0.591
96.40%

q17
121.40
120.95
-0.456
99.62%

q18
161.02
162.53
1.512
100.94%

q19
12.16
13.26
1.101
109.06%

q20
29.14
29.37
0.231
100.79%

q21
239.86
235.96
-3.893
98.38%

q22
15.51
15.92
0.410
102.64%

total
1283.99
1285.15
1.165
100.09%


[SPARK-47354][SQL] Add collation support for variant expressions

What changes were proposed in this pull request?
Introduce collation awareness for variant expressions: parse_json, try_parse_json, is_variant_null, variant_get, try_variant_get, variant_explode, schema_of_variant, schema_of_variant_agg.
Why are the changes needed?
Add collation support for variant expressions in Spark.
Does this PR introduce any user-facing change?
Yes, users should now be able to use collated strings within arguments for format functions: parse_json, try_parse_json, is_variant_null, variant_get, try_variant_get, variant_explode, schema_of_variant, schema_of_variant_agg.
How was this patch tested?
E2e sql tests.
Was this patch authored or co-authored using generative AI tooling?
No.

note: collation awareness for these pass-through Spark expressions required modifying query plans in query-tests/explain-results/… in order to accommodate using StringTypeAnyCollation instead of StringType

thanks, merging to master!


Missing AADSTS900384

This page is missing AADSTS900384

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a826ee6f-f457-7109-9f77-67c57977d4e7
Version Independent ID: 11766f27-492e-a579-dced-8a42528cbb47
Content: Microsoft Entra authentication & authorization error codes - Microsoft Entra
Content Source: articles/active-directory/develop/reference-error-codes.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@641i130
Thanks for your feedback! We will investigate and update as appropriate.

@641i130
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.
@rwike77
Can you please check and add your comments on this doc update request as applicable.

@641i130  I'm adding the error message to the list.  There's not a lot of additional info I can provide, since there are different causes for the error.  The runtime message would have more information.

Content updates merged.  #please-close


Stats not working

Django 1.7.8
Phthon 2.7.8
psycopg2==2.6.1 -> Postgres database
Everything is working great, with the exception of the stats screens, they remain at 0, for all stats.
have tried these settings, to no avail
HELPDESK_NAVIGATION_STATS_ENABLED = True
HELPDESK_ENABLE_PER_QUEUE_MEMBERSHIP = True

When switching to english language I get partial stats, all stats not assigned to a user are showing up.

Andre,
Unless you intend to restrict users to only be able to see those queues you have explicitly granted them access to, you do not want:

On 3 พ.ย. 2558, at 03:42, André Cooke<EMAIL_ADDRESS>wrote:
Django 1.7.8
Phthon 2.7.8
psycopg2==2.6.1 -> Postgres database
Everything is working great, with the exception of the stats screens, they remain at 0, for all stats.
have tried these settings, to no avail
HELPDESK_NAVIGATION_STATS_ENABLED = True
HELPDESK_ENABLE_PER_QUEUE_MEMBERSHIP = True
—
Reply to this email directly or view it on GitHub.

Thanks for the quick response, ok, switched to
HELPDESK_ENABLE_PER_QUEUE_MEMBERSHIP = False
Still not wroking as intended as en example
LANGUAGE_CODE = 'fr-CA'

LANGUAGE_CODE = 'en-US'

I'm thinking perhaps an encoding issue, then again this is a guess, I have not looked deeper in the issue.

The next step then would be to install the django-debug-toolbar and compare the debug output (esp. SQL queries) generated by the English and French versions. Bon chance! :)

Changed my name in the admin file, removed the utf-8 characters, André switch to Andy
and voila, I have some stats to my name, the Queries under django-debug-toolbar are identical.
LANGUAGE_CODE = 'en-US'

LANGUAGE_CODE = 'fr-CA'

Thanks for narrowing this down. I'll try to investigate in the next 24 hours.

In the light of this and https://github.com/rossp/django-helpdesk/pull/356 we should probably add some tests for non-unicode stats generation.

I believe this has been addressed with the introduction of Python 3 support in django-helpdesk (see #290). Thanks, @flinz


Collaboration with MMDetection3D

Hi, developers of BRNet,
Excited to find your project is reimplemented based on mmdet3d. It's good news that this framework benefits this community in terms of easier usage and development of research ideas.
I believe your work could bring great insights to this field, so I am wondering whether you have the willingness to contribute an implementation to MMDetection3D. I believe it could increase the impact of your work and also leave a mark on a fair and comprehensive benchmark.
We welcome any kind of contributions, so please feel free to ask us for help needed from our team. Thanks.
On behalf of the MMDet3D Development Team
Best,
Tai

Hi, Tai,
I am willing to contribute an implementation to MMDetection3D, and could you please give some guidance on how to do this.
Best,
Bowen

Great! After a brief review of the difference of this repo with mmdet3d, I think the basic structure is ok.
In my opinion, the main changes are focused on a class agnostic VoteHead, an RoI head for back-tracing and revisiting representative points and further detection as well as specific configs for your model, right? Then we can just split these important modules into different small Pull Requests (maybe about 3 PRs for above components and 1 for benchmark (readme page)) and clean them one by one.
So next, you just need to migrate the related code to mmdet3d and refine some docstrings/code styles. We can help you review your codes. Here is a basic guidance to leverage the pre-commit tool to refine your codes and contribute to open-mmlab codebases. You can also refer to our codes for the basic style and code standards. Let's get together to make the codes clearer and easier to use~

Thanks for your helpful guidance!
I will begin this work once I have time. I have a lot of work recently, sorry for the late contribution.
Keep in touch.


v2.5.11-master-40-g6b11f1ec HLS Playback Failure

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v2.5.11-master-40-g6b11f1ec
Can you reproduce the issue with our latest release version?
Playback works on 2.5.11 stable release
Can you reproduce the issue with the latest code from master?
Yes
Are you using the demo app or your own custom app?
Custom
If custom app, can you reproduce the issue using our demo app?
Yes.  Plays in public release but not nightly on browsers where HLS is not natively supported.
What browser and OS are you using?
Chrome, webOS, Tizen, and others
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Tizen 2.3, 2.4, 3.0, 3.2, 4.0, 5.0, 5.5
What are the manifest and license server URIs?
URLs sent to Joey Parrish via email
What did you do?

Load player in app with latest nightly build.  Will send link to test scenario by email.
What did you expect to happen?
Video playback without issue
What actually happened?
The player is stable on 2.5.11 master for VOD content without discontinuities but we were testing the nightly build to fix support for HLS with discontinuities on live/linear streams.  We have linear streams that constantly stall / fail on discontinuities.  Per suggestion from Joey Parrish, we tested 2.5.11-master-40-g6b11f1ec and playback will not start at all.  Sorry for limited details but content is sensitive and will be sent by email.

Does this discontinuity-based HLS stream work on desktop browsers (other than Safari, which uses Apple's native HLS)?

In other players yes.  It also works on other TVs using native players.  As mentioned, it played in production versions of ShakaPlayer just with failures on discontinuities.  The nightly build won't play start the stream at all.

So it fails equally on Tizen and on desktop browsers?  I'm trying to determine if we need to a Tizen device to debug it.  We currently have no access to Tizen for debugging.

It fails on Chrome as well.  I sent links by email to an HTML5 app you can test in Chrome with auto-play security turned off.  The primary case we are using ShakaPlayer for is Chrome and LG WebOS

Great, thanks.  That will simplify things for us.

For reference, I'm running Chrome in this manner to avoid any typical security blocks that wouldn't exists on a TV.
open -a Google\ Chrome --args --disable-web-security --user-data-dir=/Users/youruser/ChromeOfflineData --autoplay-policy=no-user-gesture-required

@michellezhuogg could you take a look at this?

Sure, looking at it now.

This was broken with commit Remove position from SegmentReference .
Looking into how we can fix this.

Hi.  The player now starts but it is having very frequent rebuffering issues in testing on LG WebOS on linear streams.  We aren't seeing this issue on VOD playback.  You should have two test streams from us sent by email previously.  Is there an updated version of mux.js that should be used with this update?

NOTE:  I pulled master and built using all.py which output shaka-player.compiled.js in dist folder.  Is this the correct way to get the latest change?  I want to make sure that I'm not missing something that would affect this.

Yes, that correct.  If you use mux.js, you may also want to "npm install" to make sure that is up-to-date, as well.

We currently depend on mux.js as "^5.6.3"

Ok.  Ran npm install and confirmed that I have the correct version of mux.min.js and still having frequent freeze / buffering.

Buffering on a live stream may be reasonably considered a different issue than failure to play.  Can you try some things for us to help us determine if this is a separate issue?

Does the same live stream have buffering issues on a desktop browser (not counting Safari, which uses a native HLS implementation)?
Does the same live stream behave badly with an increased presentation delay?  That could be a useful clue.  Try this before calling player.load():

player.configure('manifest.defaultPresentationDelay', 30);

If you are testing in our demo app, you can set that in the config before clicking "PLAY" on custom content.  Click the "three bars" icon in the top-left, then click "Manifest", then find "Default Presentation Delay".
Thanks!

Yes, the linear stream is stopping every 10-20 seconds and freezing / buffering even on Chrome 83.  The example was sent via email the other day you can test against.
My understanding was that defaultPresentationDelay was only for MPEG-DASH.  This is HLS.  With that said, I tried it and didn't have any improvement.  Here is our current configuration overrides for reference:

var configuration = { 'abr': { 'defaultBandwidthEstimate' : 500000 }, 'streaming': { 'bufferingGoal' : 10, 'rebufferingGoal': 4 } };

In the master branch and upcoming release, presentation delay can now be applied to both DASH & HLS.
If the buffering behavior is not improved by an increased presentation delay, then it is not caused by playback too close to the live edge.  If it's buffering badly in desktop Chrome as well as WebOS, then it's not a performance issue specific to embedded devices.
Can you please open a new issue and send logs?  With the playback failure, we found and fixed a core issue in the our recently-refactored StreamingEngine.  That part of the code doesn't seem to explain the buffering behavior, so I think we should consider this playback failure issue closed and start a new one.
Thanks!

I don't have an easy way to send details logs as we use the compiled version and would require a significant refactor to use the uncompiled version.  Additionally, getting these logs on TVs is quite difficult.  This buffering issue was not occurring on previous master branch builds (such as 2.5.11).  I've sent examples for you to test on your end which should be sufficient for you to re-create and evaluate.  The issue seems to be caused by recent changes on your end.

The issue seems to be caused by recent changes on your end.

I completely agree.  I'm just asking for a little assistance finding the issue.  If you would please file a new issue for the buffering problem, which appears to be completely independent of the original issue here, that would be helpful.  Thanks!

Additionally, getting these logs on TVs is quite difficult.

I can empathize with that, but you told us the issue can also be seen on desktop Chrome.  Could you collect logs there?

This buffering issue was not occurring on previous master branch builds (such as 2.5.11).

v2.5.11 was never a master branch build, and did not support discontinuities.  No release version today supports discontinuities.  So this content with discontinuities could never have played correctly in existing releases.  I'm sure the buffering issue is related to refactoring in prep for what was planned as v2.6 and is now v3.0, but v3.0 will be the first release with HLS discontinuity support.

we use the compiled version and would require a significant refactor to use the uncompiled version

What about the debug build?  It's a single file, so that should be a drop-in replacement for the fully-compiled build, right?  You don't need the uncompiled version to get logs.

Ok.  Created this ticket with logs using shaka-player.compiled.debug.js
https://github.com/google/shaka-player/issues/2605
Is there an ETA for a release version with discontinuity support?  This is preventing release of several services on LG TVs.

Someone is working on in actively, and we intend to have it fixed in v3.0.  The root of these issues seems to have been introduced in refactors for new v3.0 features (such as discontinuities), so it doesn't affect v2.5.  I'm currently holding v3.0 until we have this fixed, since it seems like a serious issue in a key feature.

Thank you for the update.  Is there an ETA on this?  Are we talking days or weeks or months?  We are really looking to get these products out this month.

You're asking how long it will take to solve a problem we don't know the cause of yet.  We simply don't know.  I'm sure you can relate, as an engineer.
I can say for certain, though, that if it takes more than days, we will release v3.0 without the fix.  We're only holding the release on the assumption that we can address it quickly.  But are, for now, assuming that we can address it quickly.

The fix has been made.  See #2605 and e63813c363ce54ac8682c777906b4ba5d96ae33b for details.  The root cause did not affect v2.5.x, so the fix will not be cherry-picked.

Thanks.  This seems to be streaming well now.  I am noticing "switch" calls more often than I would expect which sometimes leads to brief buffering / audio drop.  The bandwidth measurement seems unchanged when this occurs.


Add remove feature

Awesome books project

Installed linters.
Added HTML to the project.
Implemented the add and remove books feature.
Added Local Storage feature.

Hi @Rebelzob and @As1imwe-Mark, you are currently missing the Stylelint   config in your linter setup, please add it 👍🏿

Hi @Rebelzob and @As1imwe-Mark, you are currently missing the Stylelint config in your linter setup, please add it 👍🏿

the linter appears to be added in our project as you can see in the image.

HI please add the webhint config not stylelint, I updated the comment 👍🏿

@prolajumokeoni Linter added successfully, thanks a mil!

I think the linters are added now


Redirect R&D/core committers to handbook

Added a forwarding link to Handbook for now (301 redirect hopefully to follow).
This may be a somewhat controversial change - however the goal is to have a single, manageable source of truth for community and staff members to reference.
WRT 301 redirects, Hugo is quite convoluted in that respect so this is the next best option.

/check-cla


Uncaught ReferenceError: d8 is not defined

Uncaught ReferenceError: d8 is not defined. How can I use crashed js in real chrome browser.

The d8 builtin provides a bunch of functions that are not part of the core JavaScript runtime environment. Some of them emulate features available in Chrome (e.g. the serializer emulates the structured clone algorithm). You'll have to figure out which feature is used and how that can be reached in Chrome.


options/selectors_from_uri handles only queries and not complete uris

Hi,
there is a bug at https://github.com/Openwsman/openwsman/blob/master/src/lib/wsman-client.c#L561
2nd argument needs to be only a query. Here is provided the complete uri.
That's the cause of https://bugzilla.opensuse.org/show_bug.cgi?id=947422

See my comment in your commit. Next create a pull request please !

Request merged.


code not highlighted

Hey! We intentionally didn't add highlighting here, but thank you for considering it 🙏

@leerob Hi Lee, I wonder why my code doesn't work since I want to add code highlight? Thanks!

Not meant to be a PR, it is more a question


UnixPB: Make nasm pickup gcc7.5, revert opensuse gcc4.3 install task

Issues noticed when running the VagrantPlaybookCheck job.
nasm was looking for gcc7.3, which has been taken out of the playbooks since #1158 ,
The OpenSUSE role had to be reverted back from #1190 , as replacing the shell module for the zypper module means the --force-resolution argument can't be put in. The skip_ansible_lint tag has been put in, with a comment for justification.

@Willsparker change looked good but Travis failures?

My bad :) should be good now


[$1000] HTML entities like ' ' and '' are converted to blank space in LHN

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Type HTML entities like ' ' and '' and send the message
Observe message in LHN

Expected Result:
If ' ' is used in message or sent as it is, it should be displayed as it is in LHN similar to the way displayed in report.
Actual Result:
If ' ' is used in message or sent as it is, it gets converted to space in LHN. App does similar formatting with ''
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.83-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/224824255-f8dbb6bc-edc4-4ab5-a6e3-f2104e8d8175.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678635370638939
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018de6d2835489d607
Upwork Job ID:<PHONE_NUMBER>662573568
Last Price Increase: 2023-03-27

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Commented in the linked thread. I'm not convinced this is a bug.

I'm OOO the next two days, and I don't think this is a priority, so I'll circle back on it when I return.

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Alright, back in the mix now!

Hmm, yeah this one is weird. It actually shows up in the LHN initially like so...

...but then when we process the markdown it appears like a space again.

Let's start with external label to get this kicked off.

Job added to Upwork: https://www.upwork.com/jobs/~018de6d2835489d607

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

@JmillsExpensify @mountiny @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Proposal
Please re-state the problem that we are trying to solve in this issue.
Messaged are decoded HTML elements in LHN so that ' ' and '' are converted to blank space.
What is the root cause of that problem?
it shouldn't decode HTML entities in this line.
https://github.com/Expensify/App/blob/e275b9b5fa99bb587a3e5e2fe1eee6ecbf1d203c/src/libs/ReportUtils.js#L901
What changes do you think we should make in order to solve the problem?
We can remove Str.htmlDecode in this line.
https://github.com/Expensify/App/blob/e275b9b5fa99bb587a3e5e2fe1eee6ecbf1d203c/src/libs/ReportUtils.js#L901
Instead, we need to add Str.htmlDecode in this line.
https://github.com/Expensify/App/blob/8321d5eb5a56351af7906767190d8996990ed770/src/libs/ReportUtils.js#L901
like this.
: Str.htmlDecode(parser.htmlToText(htmlForNewComment));
This is test video after I changed code.
https://www.screenpresso.com/cloud/QlaOc/

📣 @podrascanindragan47! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/draganpodrascanin

⚠ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~019f94d0f86b8dea1d

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@pecanoro I'm still able to reliably reproduce this one. I just tested on the latest staging version Version 1.2.89-0 and reproduced the result I got yesterday.

This is being fixed by this PR https://github.com/Expensify/App/pull/15340

Hi @mountiny, let me know if it is eligible for reporting bonus or not

I think this issue had a same root cause and it was reported before this one https://github.com/Expensify/App/issues/15131 so I would err towards no reporting bonus as its a symptom of the same bug, but curious for @JmillsExpensify opinion here.

Ah yes, I agree that if we already had a pre-existing report of the issue then the previous report is eligible for the bonus. It's a shame we didn't catch it before GH issue creation, and that I missed it in the repo when I finally got to this issue. But regardless, we do have a policy that the first report is compensated.

Then related, given that this is ultimately a duplicate report, I'm inclined to close this issue. Please re-open if you disagree.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.91-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15340

If no regressions arise, payment will be issued on 2023-04-05. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@0xmiroslav / @mountiny] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@0xmiroslav / @mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@0xmiroslav / @mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@JmillsExpensify] Determine if we should create a regression test for this bug.
[ ] [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:


Fix duplicate text of items in username menu

Screenshot

Coverage remained the same at 39.149% when pulling 1989ccd3eb0a1bd806d6b1c7df04e96ac29e7dbf on thevoiceofzeke:menu into 004fd7f8a1bfcc1cf8eede4eea1c0fe68af70ec7 on UW-Madison-DoIT:master.