controller: Remove dup code and use k8s.io/kubernetes/controller

Close #591
/assign @ScorpioCPH

This change is

We could just review https://github.com/kubeflow/tf-operator/pull/594/commits/4804a2a4850e756dab6a897ff9f984c3010032ed

Travis tests have failed
Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
2nd Build

     gometalinter --config=linter_config.json ./cmd/...

cmd/tf-operator.v2/app/server.go:106:9:warning: error return value not checked (tc.Run(opt.Threadiness, stopCh)) (errcheck)
cmd/tf-operator/app/server.go:95:17:warning: error return value not checked (controller.Run(1, stopCh)) (errcheck)

     gometalinter --config=linter_config.json ./pkg/...

pkg/controller.v2/controller_test.go:398:82:warning: unused variable or constant undeclared name: NoResyncPeriodFunc (varcheck)
pkg/controller.v2/controller_test.go:50:128:warning: unused variable or constant undeclared name: ResyncPeriodFunc (varcheck)
pkg/controller.v2/controller_test.go:278:120:warning: unused variable or constant undeclared name: NoResyncPeriodFunc (varcheck)
pkg/controller.v2/controller_test.go:314:21:warning: unused variable or constant controller.podControl (variable of type github.com/kubeflow/tf-operator/vendor/k8s.io/kubernetes/pkg/controller.PodControlInterface) cannot have dynamic type *invalid type (missing method CreatePods) (varcheck)
pkg/controller.v2/controller_test.go:316:16:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method Templates (varcheck)
pkg/controller.v2/controller_test.go:327:115:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method ControllerRefs (varcheck)
pkg/controller.v2/controller_test.go:55:27:warning: unused variable or constant undeclared name: FakePodControl (varcheck)
pkg/controller.v2/controller_test.go:323:112:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method DeletePodName (varcheck)
pkg/controller.v2/controller_test.go:330:33:warning: unused variable or constant cannot range over fakePodControl.ControllerRefs (invalid operand) (varcheck)
pkg/controller.v2/controller_test.go:50:128:warning: undeclared name: ResyncPeriodFunc (gosimple, staticcheck)
pkg/controller.v2/controller_test.go:55:26:warning: unused variable or constant cannot use &(FakePodControl literal) (value of type *invalid type) as github.com/kubeflow/tf-operator/vendor/k8s.io/kubernetes/pkg/controller.PodControlInterface value in assignment: missing method CreatePods (varcheck)
pkg/controller.v2/controller_test.go:314:45:warning: unused variable or constant undeclared name: FakePodControl (varcheck)
pkg/controller.v2/controller_test.go:317:112:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method Templates (varcheck)
pkg/controller.v2/controller_test.go:322:16:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method DeletePodName (varcheck)
pkg/controller.v2/controller_test.go:330:33:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method ControllerRefs (varcheck)
pkg/controller.v2/controller_pod_test.go:97:101:warning: unused variable or constant undeclared name: NoResyncPeriodFunc (varcheck)
pkg/controller.v2/controller_service_test.go:83:101:warning: unused variable or constant undeclared name: NoResyncPeriodFunc (varcheck)
pkg/controller.v2/controller_test.go:326:10:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method ControllerRefs (varcheck)
pkg/controller.v2/controller_test.go:430:82:warning: unused variable or constant undeclared name: NoResyncPeriodFunc (varcheck)

     gometalinter --config=linter_config.json ./test/e2e/...

test/e2e/main.go:233:21:warning: should use time.Until instead of t.Sub(time.Now()) (S1024) (gosimple)

     goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/apis/tensorflow/*/zz_generated.*.go"

=== RUN   TestAddAccelertor
--- PASS: TestAddAccelertor (0.00s)
PASS
coverage: 2.5% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper	0.311s
=== RUN   TestSetDefaults_TFJob
--- PASS: TestSetDefaults_TFJob (0.00s)
PASS
coverage: 2.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1	0.085s
=== RUN   TestSetDefaultTFJob
--- PASS: TestSetDefaultTFJob (0.00s)
PASS
coverage: 2.0% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2	0.143s
=== RUN   TestValidate
--- PASS: TestValidate (0.00s)
PASS
coverage: 3.4% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation	0.097s
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/controller	[no test files]
FAIL	github.com/kubeflow/tf-operator/pkg/controller.v2 [build failed]
exit status 2: warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/controller
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/trainer
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/k8sutil
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/signals
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/train
# github.com/kubeflow/tf-operator/pkg/controller.v2
pkg/controller.v2/controller_pod_test.go:97:101: undefined: NoResyncPeriodFunc
pkg/controller.v2/controller_service_test.go:83:101: undefined: NoResyncPeriodFunc
pkg/controller.v2/controller_test.go:50:128: undefined: ResyncPeriodFunc
pkg/controller.v2/controller_test.go:55:27: undefined: FakePodControl
pkg/controller.v2/controller_test.go:278:120: undefined: NoResyncPeriodFunc
pkg/controller.v2/controller_test.go:314:45: undefined: FakePodControl
pkg/controller.v2/controller_test.go:398:82: undefined: NoResyncPeriodFunc
pkg/controller.v2/controller_test.go:430:82: undefined: NoResyncPeriodFunc

3rd Build

     gometalinter --config=linter_config.json ./cmd/...

cmd/tf-operator.v2/app/server.go:106:9:warning: error return value not checked (tc.Run(opt.Threadiness, stopCh)) (errcheck)
cmd/tf-operator/app/server.go:95:17:warning: error return value not checked (controller.Run(1, stopCh)) (errcheck)

travis_time:end:08341ab8:start=1526037522299195028,finish=1526037601243657184,duration=78944462156

     gometalinter --config=linter_config.json ./pkg/...

pkg/controller.v2/controller_test.go:317:112:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method Templates (varcheck)
pkg/controller.v2/controller_test.go:430:82:warning: unused variable or constant undeclared name: NoResyncPeriodFunc (varcheck)
pkg/controller.v2/controller_test.go:55:27:error: undefined: FakePodControl (vet)
pkg/controller.v2/controller_test.go:55:26:warning: unused variable or constant cannot use &(FakePodControl literal) (value of type *invalid type) as github.com/kubeflow/tf-operator/vendor/k8s.io/kubernetes/pkg/controller.PodControlInterface value in assignment: missing method CreatePods (varcheck)
pkg/controller.v2/controller_test.go:316:16:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method Templates (varcheck)
pkg/controller.v2/controller_test.go:330:33:warning: unused variable or constant cannot range over fakePodControl.ControllerRefs (invalid operand) (varcheck)
pkg/controller.v2/controller_test.go:50:128:warning: undeclared name: ResyncPeriodFunc (gosimple, staticcheck)
pkg/controller.v2/controller_test.go:398:82:error: undefined: NoResyncPeriodFunc (vet)
pkg/controller.v2/controller_pod_test.go:97:101:warning: unused variable or constant undeclared name: NoResyncPeriodFunc (varcheck)
pkg/controller.v2/controller_test.go:314:21:warning: unused variable or constant controller.podControl (variable of type github.com/kubeflow/tf-operator/vendor/k8s.io/kubernetes/pkg/controller.PodControlInterface) cannot have dynamic type *invalid type (missing method CreatePods) (varcheck)
pkg/controller.v2/controller_test.go:50:128:error: undefined: ResyncPeriodFunc (vet)
pkg/controller.v2/controller_test.go:314:45:error: undefined: FakePodControl (vet)
pkg/controller.v2/controller_test.go:55:27:warning: unused variable or constant undeclared name: FakePodControl (varcheck)
pkg/controller.v2/controller_test.go:278:120:warning: unused variable or constant undeclared name: NoResyncPeriodFunc (varcheck)
pkg/controller.v2/controller_test.go:322:16:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method DeletePodName (varcheck)
pkg/controller.v2/controller_test.go:398:82:warning: unused variable or constant undeclared name: NoResyncPeriodFunc (varcheck)
pkg/controller.v2/controller_service_test.go:83:101:error: undefined: NoResyncPeriodFunc (vet)
pkg/controller.v2/controller_test.go:278:120:error: undefined: NoResyncPeriodFunc (vet)
pkg/controller.v2/controller_test.go:314:45:warning: unused variable or constant undeclared name: FakePodControl (varcheck)
pkg/controller.v2/controller_test.go:326:10:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method ControllerRefs (varcheck)
pkg/controller.v2/controller_pod_test.go:97:101:error: undefined: NoResyncPeriodFunc (vet)
pkg/controller.v2/controller_test.go:323:112:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method DeletePodName (varcheck)
pkg/controller.v2/controller_test.go:50:128:warning: unused variable or constant undeclared name: ResyncPeriodFunc (varcheck)
pkg/controller.v2/controller_service_test.go:83:101:warning: unused variable or constant undeclared name: NoResyncPeriodFunc (varcheck)
pkg/controller.v2/controller_test.go:330:33:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method ControllerRefs (varcheck)
pkg/controller.v2/controller_test.go:430:82:error: undefined: NoResyncPeriodFunc (vet)
pkg/controller.v2/controller_test.go:327:115:warning: unused variable or constant invalid operation: fakePodControl (variable of type *invalid type) has no field or method ControllerRefs (varcheck)

travis_time:end:025851f5:start=1526037601249655361,finish=1526037660736121093,duration=59486465732

     gometalinter --config=linter_config.json ./test/e2e/...

test/e2e/main.go:233:21:warning: should use time.Until instead of t.Sub(time.Now()) (S1024) (gosimple)

travis_time:end:1d6f2956:start=1526037660739967959,finish=1526037722293113066,duration=61553145107

     goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/apis/tensorflow/*/zz_generated.*.go"

=== RUN   TestAddAccelertor
--- PASS: TestAddAccelertor (0.00s)
PASS
coverage: 8.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper	0.094s	coverage: 8.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train
=== RUN   TestSetDefaults_TFJob
--- PASS: TestSetDefaults_TFJob (0.00s)
PASS
coverage: 6.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1	0.103s	coverage: 6.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train
=== RUN   TestSetDefaultTFJob
--- PASS: TestSetDefaultTFJob (0.00s)
PASS
coverage: 8.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2	0.102s	coverage: 8.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train
=== RUN   TestValidate
--- PASS: TestValidate (0.00s)
PASS
coverage: 14.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation	0.102s	coverage: 14.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/train
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/controller	[no test files]
FAIL	github.com/kubeflow/tf-operator/pkg/controller.v2 [build failed]
exit status 2: warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/controller
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/trainer
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/k8sutil
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/signals
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/train
# github.com/kubeflow/tf-operator/pkg/controller.v2
pkg/controller.v2/controller_pod_test.go:97:101: undefined: NoResyncPeriodFunc
pkg/controller.v2/controller_service_test.go:83:101: undefined: NoResyncPeriodFunc
pkg/controller.v2/controller_test.go:50:128: undefined: ResyncPeriodFunc
pkg/controller.v2/controller_test.go:55:27: undefined: FakePodControl
pkg/controller.v2/controller_test.go:278:120: undefined: NoResyncPeriodFunc
pkg/controller.v2/controller_test.go:314:45: undefined: FakePodControl
pkg/controller.v2/controller_test.go:398:82: undefined: NoResyncPeriodFunc
pkg/controller.v2/controller_test.go:430:82: undefined: NoResyncPeriodFunc

travis_time:end:00215204:start=1526037722299800830,finish=1526037744365895375,duration=22066094545

I forgot to update the test 😟 Will do it later (After 5.15)

Travis tests have failed
Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
2nd Build

     gometalinter --config=linter_config.json --vendor ./...

pkg/controller.v2/controller_test.go:51::warning: line is 251 characters (lll)

3rd Build

     gometalinter --config=linter_config.json --vendor ./...

pkg/controller.v2/controller_test.go:51::warning: line is 251 characters (lll)

travis_time:end:0077a0b0:start=1526554100377033105,finish=1526554182912609806,duration=82535576701

Coverage increased (+6.3%) to 55.55% when pulling 97391c7e6b1b8b69c031e9c17cee5b1550416529 on gaocegege:kubernetes into e984dd2328c871b1831a3ca2fec25906001a8c66 on kubeflow:master.

Travis tests have failed
Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
2nd Build

     gometalinter --config=linter_config.json --vendor ./...

pkg/controller.v2/controller_test.go:51::warning: line is 241 characters (lll)

3rd Build

     gometalinter --config=linter_config.json --vendor ./...

pkg/controller.v2/controller_test.go:51::warning: line is 241 characters (lll)

travis_time:end:00acb9c0:start=1526555501554629244,finish=1526555593178455425,duration=91623826181

LGTM

/approve


1.23.1

Bug fixes

Fix a bug breaking Eyes of the Past
Better handle when a mod tries using DLC props when the DLC is not installed

Gonna see if eotp can just fix itself instead of this


Microbit refactor + feather mesh

Add the DFU model for mesh.
Refactor the BLE examples for microbit
Add bt-mesh example for feather with bootloader (DFU model to be enabled in next iteration)

bors r+

bors r+


Update installation instructions

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Fix the ccm manifest file and RBAC definition

What this PR does / why we need it:
Remove the dependency of KCM's kubeconfig file and modify the RBAC roles for CCM.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

/lgtm
/approve


Update READ.me to make part of mockery more clear

Kind of related to issue #70

Register mock node-fetch instead of fetch, since node-fetch is used in the code, which is more straightforward.
Move deregisterMock call to afterEach hook, since current implementation might cause mock leak if test code failed
Add the instruction to use require rather than import

I've just merged some biggish refactors and changes to documentation, including a lot more on use with mockery. I think all your points are addressed, but feel free to open another PR if you can think of any improvements

OK
Cheers,
TimNew
Geek | FullStack Developer | Mobile Developer | NightTime Photographer | Hardware Amateur
Blog:        timnew.me (http://timnew.me)
Github:    github.com/timnew (http://github.com/timnew)
LinkedIn: linkedin.com/in/timwen (http://linkedin.com/in/timwen)
Twitter:    @timnew (http://twitter.com/timnew)
On Thursday, March 17, 2016 at 7:14 PM, Rhys Evans wrote:

I've just merged some biggish refactors and changes to documentation, including a lot more on use with mockery. I think all your points are addressed, but feel free to open another PR if you can think of any improvements

I still think current implementation might cause mock leak when test failed.
Since when assertion failed, the mockery.deregisterMock('node-fetch') will never get executed.
An easy and safe way to solve the issue is to move this call into afterEach hook, which is guaranteed to be executed after every test, whether it is passed or not.
And there is a typo: mockery.deregisterMock('fetch') should be mockery.deregisterMock('node-fetch')


[ARROW] Fix Spark session timezone format in arrow-based result format

Why are the changes needed?

this PR introduces a new configuration called kyuubi.operation.result.arrow.timestampAsString, when true, arrow-based rowsets will convert timestamp-type columns to strings for transmission.

kyuubi.operation.result.arrow.timestampAsString default setting to false for better transmission performance

the PR fixes timezone issue in arrow based result format described in #3958

How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #4326 (38c7fc9) into master (8fe7947) will increase coverage by 0.07%.
The diff coverage is 32.00%.

@@             Coverage Diff              @@
##             master    #4326      +/-   ##
============================================
+ Coverage     53.53%   53.61%   +0.07%
  Complexity       13       13
============================================
  Files           562      562
  Lines         30704    30804     +100
  Branches       4142     4153      +11
============================================
+ Hits          16438    16515      +77
- Misses        12721    12732      +11
- Partials       1545     1557      +12

Impacted Files
Coverage Δ

...he/kyuubi/jdbc/hive/KyuubiArrowBasedResultSet.java
0.00% <0.00%> (ø)

...he/kyuubi/jdbc/hive/KyuubiArrowQueryResultSet.java
0.00% <0.00%> (ø)

.../kyuubi/jdbc/hive/arrow/ArrowColumnarBatchRow.java
0.00% <0.00%> (ø)

...a/org/apache/kyuubi/jdbc/hive/KyuubiStatement.java
22.28% <11.11%> (-0.49%)
:arrow_down:

...g/apache/spark/sql/kyuubi/SparkDatasetHelper.scala
78.57% <75.00%> (-1.43%)
:arrow_down:

...uubi/engine/spark/operation/ExecuteStatement.scala
76.92% <100.00%> (+2.23%)
:arrow_up:

...kyuubi/engine/spark/operation/SparkOperation.scala
76.47% <100.00%> (+0.15%)
:arrow_up:

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
97.45% <100.00%> (-0.06%)
:arrow_down:

.../apache/kyuubi/jdbc/hive/JdbcColumnAttributes.java
83.33% <100.00%> (ø)

.../org/apache/kyuubi/server/trino/api/v1/dto/Ok.java
46.15% <0.00%> (-23.08%)
:arrow_down:

... and 25 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks, merged to master/1.7


Added missing "Times new Roman" font to build pipeline and projects

In the windows build, the example did not run because it could not load the "Time new roman size 9" asset. This commit addresses this, as well as for other platforms.

You set Times New Roman as your default font for the OS I guess. Adding that font to project solves that issue.
That said I'm not going to merge this, because anyone can set whatever default font they want in the OS. So it does not solve anything.

In which case the examples should be explicitly setting one of the fonts already included

Unfortunately there is no "correct" way to set default font like that. I would have to set font of your OS and that's very bad idea.

Think I will just remove generation of default font from UI Generator. That makes more sense. Closing this as I already have plan for that.


Pilot export includes internal testers

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
When performing an export using pilot export, internal testers are included in the output, not just external.
Complete output when running fastlane, including the stack trace and command used
pilot export
[10:38:23]: Successfully exported CSV to ./testers.csv
Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
N/A
Environment
fastlane version (run fastlane -v):
fastlane 1.91.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)?
No
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)?
No

Thanks for the report, we'll take a look.

@colinhumber I tested this on my own account and you are correct, it does return both internal and external testers. We will need to either figure out why iTunesConnect is returning all testers or else adjust the documentation for the feature. We'll look into getting this fixed on our end (no promises of when we will be able to get to it, I'm afraid), but if you feel so inclined and want to try your hand at fixing the issue yourself, we're happy to accept pull requests. :)

@colinhumber Actually, I continued digging into this a bit more - it does appear that pilot is doing the right thing for my account, at least by some definition of "right".  If, in iTunesConnect, I select Users and Roles, and then  click on the TestFlight Beta Testers tab and then click the External tab, the list I see is exactly what is exported when I do pilot export. However, these external testers do not correspond to the external testers for any of my apps - they appear to be the combination of internal and external testers for all of my apps. This is odd behavior for sure (maybe an iTC bug?), but it does appear that pilot is respecting this behavior.
Does my observation what you are seeing?

Yes, I’m seeing the same thing. I hadn’t actually noticed that was the case before. I was just looking at the External users on the app I was wanting to export users for. When looking at the list in Users and Roles > TestFlight Beta Testers > External, I see the same combined list you are. I tried to delete one of my internal users from the external list but they can’t be deleted for some reason. Seems like TestFlight is forcefully grouping internal testers as external ones.
On June 2, 2016 at 4:34:35 PM, mpirri<EMAIL_ADDRESS>wrote:
@colinhumber Actually, I continued digging into this a bit more - it does appear that pilot is doing the right thing for my account, at least by some definition of "right". If, in iTunesConnect, I select Users and Roles, and then click on the TestFlight Beta Testers tab and then click the External tab, the list I see is exactly what is exported when I do pilot export. However, these external testers do not correspond to the external testers for any of my apps - they appear to be the combination of internal and external testers for all of my apps. This is odd behavior for sure (maybe an iTC bug?), but it does appear that pilot is respecting this behavior.
Does my observation what you are seeing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Okay, yeah, that all makes sense. I also saw the weird behavior where you couldn't actually delete internal testers from that external list - another aspect that makes me suspect that this might be an iTC bug.
I'm going to close this issue with a rather-uncomfortable "works as intended", since it does actually export what iTC considers the "External Tester" list. We'll keep our eyes open for changes in behavior and reach out to Apple to see if they have any thoughts on this.
Thanks!


SwitchListTile border overlaps

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
I have a set up with NestedScrollView and in it is a SwitchListTile with a border when I set the state for the border position doesn't update, but the content does
on mobile this happens as soon as you click the button in the example, but in web you have to first position your cursor on top of where the submit button will be right after you click run to see it
Expected results
for the border to update its position
Actual results
it doesn't update position instead it overlaps content
Code sample
https://dartpad.dev/?id=107ebf6e90732df2040124820daa7eee
Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.10.5, on macOS 13.3 22E252 darwin-arm64, locale
    en-SA)
    • Flutter version 3.10.5 on channel stable at /Users/moneeroctedia/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 796c8ef792 (4 weeks ago), 2023-06-13 15:51:02 -0700
    • Engine revision 45f6e00911
    • Dart version 3.0.5
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/moneeroctedia/Library/Android/sdk
    • Platform android-33-ext5, build-tools 33.0.2
    • Java binary at: /opt/homebrew/opt/openjdk/bin/java
    • Java version OpenJDK Runtime Environment Homebrew (build 20)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      11.0.15+0-b2043.56-8887301)

[✓] VS Code (version 1.78.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] VS Code (version 1.77.1)
    • VS Code at /Users/moneeroctedia/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (3 available)
    • Moneer’s iPhone (mobile) • 33e67783c46f4b0f249148f1ac77b4b3118c7950 • ios            • iOS 16.5.1
      20F75
    • macOS (desktop)          • macos                                    • darwin-arm64   • macOS 13.3
      22E252 darwin-arm64
    • Chrome (web)             • chrome                                   • web-javascript • Google
      Chrome 114.0.5735.198

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @Octedia,
Can you please be more specific on the Steps to reproduce. I can't reproduce the issue, the border is rendering as expected:

Demo
https://github.com/flutter/flutter/assets/104349824/ebfd2a0f-2468-4764-9ffe-dcded71f81ac

On the web it's not consistent but it does happen.  I found that if you click the run button and then quickly place your cursor on the location where the submit button will be and click it when the app shows up it happens but as soon as you move the cursor it resets as expected.
If it doesn't work on dartpad please try on mobile

Thanks for the update. Now I can reproduce the issue with the sample code above (I see it's modified from NestedScrollView example by adding SwitchListTile into slivers).
This seems to be caused/related to NestedScrollView. If I use SingleChildScrollView with same children in the example (TextField, SwitchListTile), issue is not reproducible.

Sample code (has issue, from DartPad link above)

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/material.dart';

/// Flutter code sample for [NestedScrollView].
void main() => runApp(const NestedScrollViewExampleApp());

class NestedScrollViewExampleApp extends StatelessWidget {
  const NestedScrollViewExampleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: NestedScrollViewExample(),
    );
  }
}

class NestedScrollViewExample extends StatefulWidget {
  const NestedScrollViewExample({super.key});

  @override
  State<NestedScrollViewExample> createState() => _NestedScrollViewExampleState();
}

class _NestedScrollViewExampleState extends State<NestedScrollViewExample> {
  bool showErrors = false;

  @override
  Widget build(BuildContext context) {
    final List<String> tabs = <String>['Tab 1', 'Tab 2'];
    return DefaultTabController(
      length: tabs.length, // This is the number of tabs.
      child: Scaffold(
        body: NestedScrollView(
          headerSliverBuilder: (BuildContext context, bool innerBoxIsScrolled) {
            // These are the slivers that show up in the "outer" scroll view.
            return <Widget>[
              SliverOverlapAbsorber(
                // This widget takes the overlapping behavior of the SliverAppBar,
                // and redirects it to the SliverOverlapInjector below. If it is
                // missing, then it is possible for the nested "inner" scroll view
                // below to end up under the SliverAppBar even when the inner
                // scroll view thinks it has not been scrolled.
                // This is not necessary if the "headerSliverBuilder" only builds
                // widgets that do not overlap the next sliver.
                handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context),
                sliver: SliverAppBar(
                  title: const Text('Books'), // This is the title in the app bar.
                  expandedHeight: 150.0,
                  // The "forceElevated" property causes the SliverAppBar to show
                  // a shadow. The "innerBoxIsScrolled" parameter is true when the
                  // inner scroll view is scrolled beyond its "zero" point, i.e.
                  // when it appears to be scrolled below the SliverAppBar.
                  // Without this, there are cases where the shadow would appear
                  // or not appear inappropriately, because the SliverAppBar is
                  // not actually aware of the precise position of the inner
                  // scroll views.
                  forceElevated: innerBoxIsScrolled,
                  bottom: TabBar(
                    // These are the widgets to put in each tab in the tab bar.
                    tabs: tabs.map((String name) => Tab(text: name)).toList(),
                  ),
                ),
              ),
            ];
          },
          body: TabBarView(
            // These are the contents of the tab views, below the tabs.
            children: tabs.map((String name) {
              return SafeArea(
                top: false,
                bottom: false,
                child: Builder(
                  // This Builder is needed to provide a BuildContext that is
                  // "inside" the NestedScrollView, so that
                  // sliverOverlapAbsorberHandleFor() can find the
                  // NestedScrollView.
                  builder: (BuildContext context) {
                    return CustomScrollView(
                      // The "controller" and "primary" members should be left
                      // unset, so that the NestedScrollView can control this
                      // inner scroll view.
                      // If the "controller" property is set, then this scroll
                      // view will not be associated with the NestedScrollView.
                      // The PageStorageKey should be unique to this ScrollView;
                      // it allows the list to remember its scroll position when
                      // the tab view is not on the screen.
                      key: PageStorageKey<String>(name),
                      slivers: <Widget>[
                        SliverOverlapInjector(
                          // This is the flip side of the SliverOverlapAbsorber
                          // above.
                          handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context),
                        ),
                        SliverPadding(
                            padding: const EdgeInsets.all(8.0),
                            // In this example, the inner scroll view has
                            // fixed-height list items, hence the use of
                            // SliverFixedExtentList. However, one could use any
                            // sliver widget here, e.g. SliverList or SliverGrid.
                            sliver: SliverToBoxAdapter(
                                child: Column(
                                    children: [
                                      TextField(
                                        decoration: InputDecoration(
                                          errorText: showErrors ?
                                          'some error' : null,
                                        ),
                                      ),
                                      const SizedBox(height: 24),
                                      TextField(
                                        decoration: InputDecoration(
                                          errorText: showErrors ?
                                          'some error' : null,
                                        ),
                                      ),
                                      SwitchListTile(
                                        shape: RoundedRectangleBorder(
                                            borderRadius: BorderRadius.circular(40),
                                            side: BorderSide(color: Colors.black)),
                                        // dense: true,
                                        // contentPadding: const EdgeInsets.all(
                                        //    Spacing.small),
                                        value: false,
                                        title: Text('stuff',
                                            ),
                                        onChanged: (value) {},
                                      ),

                                      const SizedBox(height: 24),
                                      FilledButton(
                                          onPressed: () {
                                            setState(
                                                    () {
                                                  showErrors = true;
                                                }
                                            );
                                          },
                                          child: Text('Submit')
                                      )
                                    ]
                                )
                            )
                        ),
                      ],
                    );
                  },
                ),
              );
            }).toList(),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.10.5, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.10.5 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 796c8ef792 (3 weeks ago), 2023-06-13 15:51:02 -0700
    • Engine revision 45f6e00911
    • Dart version 3.0.5
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.79.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.66.0

[✓] Connected device (4 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D                         • android-arm64  • Android 11 (API 30)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.7.2 19H218
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 114.0.5735.198

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.13.0-2.0.pre.51, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.13.0-2.0.pre.51 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c8906bbd49 (46 minutes ago), 2023-07-11 20:55:18 -0400
    • Engine revision d00590fde1
    • Dart version 3.1.0 (build 3.1.0-297.0.dev)
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.79.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (4 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D                         • android-arm64  • Android 11 (API 30)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.7.2 19H218
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 114.0.5735.198

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

This is similar to https://github.com/flutter/flutter/issues/122678.
The issue should be resolved by wrapping SwitchListTile with a Material.
Let me know if you can still reproduce this issue with Material


Branch or event not found

Are you experiencing an issue with...
shields.io
🐞 Description
Trying to update to the new URL:

🔗 Link to the badge
https://img.shields.io/github/actions/workflow/status/web3-storage/w3up-client/test.yml?branch=main
💡 Possible Solution
No response

The reason why this one isn't finding anything is because your test.yml workflow only runs on pull requests
https://github.com/web3-storage/w3up-client/blob/d26664c15f6ca17e91dbf3860c7c8fea72047f61/.github/workflows/test.yml#L2-L5
so there are no runs on main itself
https://github.com/web3-storage/w3up-client/actions/workflows/test.yml?query=branch%3Amain
This is actually one of the situations where the old badge had confusing behaviour - what you were probably seeing before was the status of the last run of test.yml on whatever pull request last triggered it.
My guess would be this either flags that you really want to be running test.yml on pushes to main, or maybe you wanted to be reporting the status of one of your workflows that does run on your main branch, like release.yml
https://github.com/web3-storage/w3up-client/blob/d26664c15f6ca17e91dbf3860c7c8fea72047f61/.github/workflows/release.yml#L1-L4
https://github.com/web3-storage/w3up-client/actions/workflows/release.yml?query=branch%3Amain
I'd be interested to understand this one more.

We've just merged https://github.com/badges/shields/pull/8738 and deployed to production. This would allow you to omit the branch param, which may or may not be what you want. Either way I'm going to close this as I think the original query is answered.


suppressing sensitive properties

make use of the sensitive property to suppress sensitive output from converge_if_changed.
this matches the PR at https://github.com/chef/chef/pull/4054

i am going to close this PR as you can just copy this file from chef once it is merged in. ill open an issue for this though.


update Alexandria, VA and Colorado Springs

Awesome. Thanks, David! Let's chat sometime soon when you're free if you'd like about a roadmap going forward?


Require 'sends' literal only once

Instead of
agent Thing concerning Foo {
  sends go
  sends stop
  sends flip
  sends reverse
}

allow
agent Thing concerning Foo {
  sends go stop flip reverse
}

Make sure this does not break the generator of documentation...
Message typed on an iPhone.
Spelling errors are likely...

On Sep 28, 2016, at 9:08 AM, Matthew Adams<EMAIL_ADDRESS>wrote:
Instead of
agent Thing concerning Foo {
sends go
sends stop
sends flip
sends reverse
}
allow
agent Thing concerning Foo {
sends go stop flip reverse
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@pgraff, all changes will preserve existing functionality, except where we're intentionally breaking backward compatibility, usually where the prior capability didn't make sense.  This issue, along with #15, #17 & #18 were discussed ad nauseum with @jkamke.


Cannot Generate Molecule From MolFile - No Examples?

Hi,
I can generate molecules using 'get_mol()' and SMILES quite easily.
I have a need to generate via MolFiles or MolBlocks - the documentation says it takes them in as an input but I am tearing my hair out trying to get one to work?
I have the files stored locally, I assume a file path is not right? I have used a http client in Angualr to load the content of the file as a string and pass that, no luck. I have also just created the contents of the mol file as a var and passed that in and that does not work.
Has anyone had any joy with MolFiles?

This is not an issue - could  you please ask this question in the Discussions tab so it is more easily searchable? Thank you.


Addon blueprint should point to lib/index.js manifest file as pkg main

Addons don't currently have a lib folder, should that be the app folder renamed?

Moved to CLI repo


was/plugins

Contains changes related to search method implementation for was/plugins
The WAS Search method and iterator depends upon #69

Covered in #91

Closing this PR as changes are covered in #91


As a developer, I need to refactor/improve syncing code and implement logic for staying synced

DIdn't refactor much, just improve the logic to avoid extra requesting of best tip along with chain proof from peer.
Doing proper refactor requires more time and more thought to it to not increase complexity too much, while optimizing as much as possible to avoid requesting data we shouldn't be needing in some edge cases.
Before undergoing such refactor we'll need to have testing framework ready, along with bunch of tests prepared to ensure we don't introduce bugs after refactor.


Trying to set redirect uri in instagram but I get an error

You must enter an absolute URI that starts with http:// or https://
trying to set the redirect_uri to my application url

@aaronksaunders I have the same issue. It's possible redirect to the app? What url you add into instagram developer page if you must enter an absolute URI that starts with http:// or https://.
I don't understand, can you share an example?
Thanks!


Cannot boot to a VM after changing shell to fish on openSUSE Tumbleweed

Description

limactl start template://experimental/opensuse-tumbleweed
limactl shell opensuse-tumbleweed
sudo zypper in fish
sudo chsh --shell /usr/bin/fish $USER
limactl stop opensuse-tumbleweed
limactl start opensuse-tumbleweed
BUG: Infinite Waiting for the essential requirement 1 of 2: "ssh"

Macbook Air M1 (2020)
$ sw_vers
ProductName:            macOS
ProductVersion:         15.0.1
BuildVersion:           24A348

$ limactl --version
limactl version 1.0.1

$ cat .lima/opensuse-tumbleweed/serial*.log

Welcome to openSUSE Tumbleweed 20241105 - Kernel 6.11.6-2-default (hvc0).

eth0: <IP_ADDRESS> fe80::5055:55ff:feea:74c3

lima-opensuse-tumbleweed login: ⏎

This is fixed in #2874 and will be in Lima 1.0.2.
$ limactl shell opensuse-tumbleweed
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish
jan@lima-opensuse-tumbleweed /U/jan>


Add 'Natsværmeren'

'Natsværmeren' has now been jailed by DR too, please add it to feed :)

@pinkfloydhomer Isn't it still available at https://api.dr.dk/podcasts/v1/feeds/natsvaermeren ?

Why not just add all possible DR Lyd podcasts to the feed?
On Wed, 6 Nov 2024, 11.32 drpodcastnu, @.***> wrote:

@pinkfloydhomer https://github.com/pinkfloydhomer Isn't it still
available at https://api.dr.dk/podcasts/v1/feeds/natsvaermeren ?
—
Reply to this email directly, view it on GitHub
https://github.com/drpodcastnu/DR1ommer/issues/7#issuecomment-2459318655,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASYEFLKOHIESEA5ILPXN5F3Z7HV45AVCNFSM6AAAAABQOZ7ZSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJZGMYTQNRVGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Ah okay, thanks for the info. Yes, I might consider just doing that, stay tuned :)

I see you added a lot of new podcasts but not Natsværmeren?


style(api): Revise execute/simulate reference docstrings

Overview
Minor adjustments to the reference docstrings in opentrons.simulate and opentrons.execute.
Test Plan and Hands on Testing
I've skimmed the generated docs and made sure this doesn't introduce any flagrant formatting problems.
Changelog

Note, for a couple of arguments, that they are only intended for internal Opentrons use.
Adjust indentation so we don't have to describe every parameter with ~50-character-long lines. (No user-visible difference, just changing the formatting in the .py file.)
A couple other tiny fixups, like Python instead of python.

Review requests
Is chore_release-8.0.0 the correct merge target?
Risk assessment
No risk.

Maybe the rare opportunity for "style(api)" in the PR title.

oooo rare commit tag, gimme


Set up Connect for Chinese-language EWs

For Chinese-language CalFresh EWs at SF HSA

Shipped to food bank outreach workers


Rides

Should we offer ride coordinator functionality, too? It's somewhat analogous to housing stuff and it actually does seem strange to me to have one and not the other.

Here's an example of an org ad hocking a solution to this problem: https://sites.google.com/a/oberlin.edu/dandelionromp/home
It could be as simple as providing a rideboard like that where people can post information. I think even having it integrated into the same tool as registration would make it more likely to be used and therefore easier for organizers. Might be worth doing some research with people who have done rides coordination for events, though.

(Basically it's just a simple google spreadsheet.) +1 that something this simple could probably be easy for people to use, and could be great if we implemented it right. Big +1 on doing research. I'd love to treat this similar to housing; if the redesigned checkout process & form management interfaces could accommodate this kind of thing it would be great.

Yeah. With both this and housing, I'm increasingly interested in the idea of separating them from the registration process. Like maybe you do your registration and pay and then you get access to an "attendees area" where you can do things like request housing, arrange rides, maybe someday socialize with other attendees pre-event...
But yeah, research would be good.

I think that for housing and rides we would probably still want to include them in the registration process so that people who needed it didn't miss it, BUT also have a very clear way to update your status post-registration.

Talked with an organizer this weekend who was also really into the idea of ride share handling, even if it were really simple.


CocoaPods support

Adding a podspec and making some stuff public.

+1

Hi @marcelofabri, thank you for adding CocoaPods support. Quick question 'cause I'm not entirely familiar with the pod authoring process. If someone adds Reachability through CocoaPods, does it get added as a framework or as a static library?

@ararog @marcelofabri Thank you both. I merged it. I also tested it with a test project and it works fine.
Do I have to do anything else? For example for the library to be indexed in the cocoapods site?

Please refer to http://cocoapods.org/#create_a_pod for more details.

Yeah, you'd need to add a tag and submit to CocoaPods. However, I'd only do that after 0.36 is officially released.

Got it. Thanks.

Hello again,
I made some changes to the project. I renamed the repo, removed the old Xcode sample project and pushed a new one. I also modified the .podspec file to reflect the changes I made.
But I tried adding the library through CocoaPods now, but it doesn't seem to be working properly.
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '8.0'

pod 'IJReachability', :git => 'https://github.com/Isuru-Nanayakkara/IJReachability.git'

When I run pod install, the following line gets outputted in the Terminal.
fatal: Not a git repository (or any of the parent directories): .git
However the pod installation succeeds and the .workspace file is created. I open that, import IJReachability on a file (compiles fine) but if I try to call a method (for example isConnectedToNetwork()), I get the following error.
'IJReachability.Type' does not have a member named 'isConnectedToNetwork'
I've been trying to resolve this but no luck so far. Do you guys have any idea what might have gone wrong?


Fix logging fields in ElasticSearch

When we upgraded Docker, it appears that the same logging fields do not make it into ElasticSearch, in particular the stdout/stderr information appears to be lost. This is probably due to the Docker syslog output changing slightly and then not being parsed correctly by our logstash configuration. Investigate and correct.

I've identified this as an issue with Docker engine. This has been broken between 1.12.6 and 17.03 of Docker. I'm working to identify where exactly this issue was introduced in order to file an issue with them.
Reproduction steps:
docker run -it -p 8000:8000 --rm logstash:2.4-alpine -e 'input { syslog { port => 8000 } } output { stdout { codec => rubydebug } }'
# Need to remove tty as that redirects all output to stdout
docker run --rm --log-driver syslog --log-opt syslog-format=rfc3164 --log-opt syslog-address=tcp://localhost:8000 python:2-alpine python -c 'from __future__ import print_function; import sys; print("stderr", file=sys.stderr); print("stdout", file=sys.stdout)'

On 4.7.3-coreos-r3 with Docker 1.12.6 I get severity:3 and severity_label=Error for stderr and severity:6 and severity_label=Informational for stdout
On CentOS 7 kernel vs 3.10.0-514.16.1.el7.x86_64 with Docker 1.12.6 from centos repos I get severity:3 and severity_label=Error for stderr and severity:6 and severity_label=Informational for stdout
On CentOS 7 kernel vs 3.10.0-514.16.1.el7.x86_64 with Docker 17.06.0-ce from docker repo I get severity:6 and severity_label=Informational for BOTH stderr and stdout

Here is the relevant Moby issue: https://github.com/moby/moby/issues/33834. PR is in: https://github.com/moby/moby/pull/33832. Doesn't appear to have made it in a Docker release yet though... https://github.com/docker/docker-ce/pull/95

Our options are to use either Docker 12 / 13 or wait until 17 receives a patch release for this.

All right, let's wait for the patch. No sense going back to earlier Docker versions for this.

Closing...


ERROR (Kamal::ConfigurationError): unknown keys

I think a case like this should be valid.

Yes I had a same issue

Just to add a little bit of context, it seems that the anchors (&) and aliases (*) are a way to share common configuration settings across multiple services on the Compose spec; it is an extension when the key starts with x-, as node labels on screenshot above.
It's raising the ConfigurationError per this validation, since the parsed configuration keys starting with x- are unknown to Kamal.

Oh nice idea @ruyrocha, we can add similar support to Kamal


Fix keyvalue on awake loop

@luongngocminh can you add more test for covering the 5 missing lines?


[question] Embedded nats for java projects?

In other solutions (eg mongo: https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo) there are libraries that allow to run embedded version of server in order to write integration tests that check things like serialization, correct setup of subjects etc. So my question is - is there such library available for nats?
It would be a great idea to have such library - now in my tests just need to mock whole java-nats which does not give me any clue whether this logic works :)

The tests use this class - https://github.com/nats-io/java-nats/blob/master/src/test/java/io/nats/client/NatsTestServer.java which hopefully does what you want. It runs a gnatsd - see the env var for setting the path if necessary - and can be set to debug mode, or to take a config file or custom config settings.
There is also https://github.com/nats-io/java-nats/blob/master/src/test/java/io/nats/client/NatsServerProtocolMock.java which is a fake server but performs some of the protocol so we can test raw protocol messages.

Yes, it's a nice wrapper but it requires gnatsd to be installed on host machine. Ideally a hypothetical library would download gnatsd and call NatsTestServer.java in order to start it.

I will take a look, but would be open to a PR also :-)
I think if i was doing something that did the pull and everything I might change the API a bit, thoughts there?

Sorry, I didn't follow (maybe because I'm not native english speaker ;) ). How pulling the binaries will affect API?

Sorry, i was asking if there are other API changes that would be useful if I get a chance to do the binary pull code.

My impression is (just by brief glance at the code) that pulling binaries could be just implemented without affecting other parts (maybe only adding pull option to NatsTestServer).

Embedded Mongo is built on top of https://github.com/flapdoodle-oss/de.flapdoodle.embed.process which has all the necessary abstractions including multi-version support (i.e. select the version of the executable you want to run in your test).  Quite a handy framework and I've used it successfully to run integration tests with different versions of mongo.  Might be useful here too.

The tests use this class - https://github.com/nats-io/java-nats/blob/master/src/test/java/io/nats/client/NatsTestServer.java which hopefully does what you want. It runs a gnatsd - see the env var for setting the path if necessary - and can be set to debug mode, or to take a config file or custom config settings.
There is also https://github.com/nats-io/java-nats/blob/master/src/test/java/io/nats/client/NatsServerProtocolMock.java which is a fake server but performs some of the protocol so we can test raw protocol messages.

May it be that NatsTestServer.java is no longer working?
It still uses the gnatsd command, but according to the release notes https://github.com/nats-io/nats-server/releases/tag/v2.0.0 and my current MacOS setup the command is now named nats-server.
Is my analysis correct?

I haven't updated the test class yet to the new executable name. But the code will work if you make a copy of the executable with the old name gnatsd' or set the environment variable nats_server_path to the point at the executable.

One can also use NATS inside a testcontainer.
Here is how NATS Streaming Server can be run inside a testcontainer: https://github.com/testcontainers/testcontainers-java/issues/1733#issuecomment-520593092.

Changed the reference to nats-server in 2.6.1.

@kkocel  check this library. I recently created this. It is based on https://github.com/flapdoodle-oss/de.flapdoodle.embed.process

@madansp I that covers my use case :)


Attributing eps consistently

I have noticed an incosistency in the input of eps for the holding class FiniteTempBasisSet. Different to IRbasis or FiniteTempBasis, it does not have eps=None as standard input. For ease of use this should probably be consistent.
On the same note, I noticed that eps is added as an attribute in FiniteTempBasisSet (line 53), but not in the original  IRbasis/FiniteTempBasis instances. Would it not be more consistent to add it there instead or even pass it from the SVE decomposition (and then add eps as a property in the holding class)?
It has the advantage that eps could be saved in/reused from metadata of calculation files more easily. Then, eps should be saved after SVD, so that it can be looked up after not setting eps/using eps=None as an input.
I would have created a PR to fix the inconsistency in FiniteTempBasisSet, but I am not sure about your thoughts on the rest.

Summarizing the discussion in #20 (citing Markus):

I would suggest instead to replace the tuple u, s, v we return as sve_result with a structure SVEResult, which has u, s, v as members but also the kernel, eps, work dtype. This way we can store this with any higher-level object and expose it to the user.


build: merge main branch to dev

Codecov Report
Attention: Patch coverage is 69.23077% with 156 lines in your changes are missing coverage. Please review.

Please upload report for BASE (dev@57df0ef). Learn more about missing BASE report.

Additional details and impacted files

@@          Coverage Diff           @@
##             dev     #177   +/-   ##
======================================
  Coverage       ?   29.33%
======================================
  Files          ?       70
  Lines          ?     4305
  Branches       ?       88
======================================
  Hits           ?     1263
  Misses         ?     3042
  Partials       ?        0

Files
Coverage Δ

src/azure/ApiCenter/contracts.ts
100.00% <100.00%> (ø)

src/constants.ts
100.00% <100.00%> (ø)

src/test/unit/commands/generateHttpFile.test.ts
100.00% <100.00%> (ø)

src/test/unit/commands/registerApi.test.ts
100.00% <100.00%> (ø)

src/uiStrings.ts
100.00% <100.00%> (ø)

src/commands/searchApi.ts
0.00% <0.00%> (ø)

src/tree/ApiTreeItem.ts
65.21% <50.00%> (ø)

src/tree/ApiVersionDefinitionTreeItem.ts
80.64% <50.00%> (ø)

src/tree/ApiVersionDefinitionsTreeItem.ts
45.90% <50.00%> (ø)

src/tree/ApiVersionTreeItem.ts
60.00% <50.00%> (ø)

... and 17 more


⚠ Cioos Pacific CKAN Sitemap has degraded performance

In f9cb369, Cioos Pacific CKAN Sitemap (https://catalogue.cioospacific.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 6071 ms

Resolved: Cioos Pacific CKAN Sitemap performance has improved in e4681cf after 12 minutes.


docs: improve Finite docstring

@eric-wieser Are we happy to merge this yet?

LGTM
bors d=eric-wieser


Error if '=' in funtion name

If there is an '=' in the name of a function, the "objcopy" command fail

Lol I'll fix this today... funny bug originally discovered by @zolutal is at play here.


Edit readme, change foreman nf start to pm2 start rackhd.yml

use PM2 instead of foreman to  manage rackhd process.
see GG https://groups.google.com/forum/#!topic/rackhd/UfyZ1v9Gdc4
This PR should be merged at the same time with https://github.com/RackHD/docs/pull/357  after new version vagrant box be updated.
Related PR

https://github.com/RackHD/RackHD/pull/478  edit packer script, change foreman to pm2.
https://github.com/RackHD/docs/pull/357 docs change
https://github.com/RackHD/on-build-config/pull/31 edit Vagrantfile for smoke-test
@panpan0000

:+1:


Update docs to make generate block and remote_state.generate the official method

See https://github.com/gruntwork-io/terragrunt/pull/1050#issuecomment-586714536 for context.

Wasn't this done already?


Update information on already registered devices

Hi,
I have used Netbox v2.2.2.
I would like to update information such as tenant or platform.
When I tried to use the import function, I found error messages because of the duplicated device name.

If I want to update information on multiple devices, what do you think I should do?

Thank you for your interest in NetBox. GitHub issues are intended for reporting reproducible bugs and requesting features, and must be submitted using the template provided here. For general discussion, questions, or assistance with installation issues, please post to our mailing list.


Replace all occurrences of (&x)->Print with x.Print

Aims to simplify the code.

Ah, I now see that first commit is for library code, and second for tests. Indifferent about squashing now.

Have you tried to figure out why this syntax was used in the first place? To work around some compiler bug or limitation, or some other reason?

Good question! Honestly I have no idea. But obviously the dot operator (to access a member of an object) has been used extensively already in throughout the ITK source base. Specifically, Print calls of the form x.Print(y) occur many places already in ITK. So this PR would improve overall code consistency  😄
My (uneducated) guess is that some contributors in the past might just have felt more comfortable with the arrow -> than the dot. While I actually feel less conformable with the arrow, as it might be used on a pointer that could be null.


[RMP] Benchmarking Session-Based Models

Problem:
We want to benchmark session-based (transformer-based) architectures in respect of speed-up, costs, inference, latency, etc. to provide guidance to our community.
Goal:
Provide guidance to our community about the performance (computational) and costs oof transformer-based models for training and inference.
Starting Point:
Let's start with inference.
Background
[ ] Define experiments: Which dataset, which architecture, which hyperparameters (e.g. sequence length, etc.)
Inference
What questions do we want to answer:

What is the throughput of Transformer-Based Model (request/s responded)?
What is the latency (p50, p90, p99)
What are the costs per request with maximal utilization?
for following environments:
CPU and GPUs (T4, A10, V100, A100)
OnPrem (without network) and Cloud (including network)
different model architectures (e.g seq len, embedding width, heads, etc.)

Transformer4Rec (PyTorch)
[ ] Benchmark Inference of Transformer4Rec model without NVTabular (Python Model) like this example Ticket: https://github.com/NVIDIA-Merlin/Transformers4Rec/issues/610
[ ] Benchmark Inference of Transformer4Rec model without NVTabular (TorchScript Model) like this example
Merlin Models (TensorFlow)
[ ] TBD (waiting for implementation)
Training
TBD
We should use JMeter for load testing

A detailed view is available here:
https://docs.google.com/document/d/1g5FUrdhZQzef1OWwiQLfNNGdHr4a71Cr-jqndl-SoQg/edit#

Collecting results in a google spreadsheet (details) + some slides as a summary


Update only elements that subscribe to given contextType

I use this to update components that use context to get translation strings after the language was switched.
I know this uses internal APIs, but using this is much nicer than either constantly managing 100+ listeners or force-rerendering the app through a key on the root element.
It would be even nicer if it would only update components that use the context in the first place. Would that be difficult to do? Would you accept a PR that does this?

Exact use case

Fixed by #6

Fixed by #6

@neoziro wouldn't it be nicer to provide a reference implementation of the shouldUpdate function for contextName-only updates?

I was about to write an implementation but then realized there is a problem with #6. I filed https://github.com/gaearon/react-deep-force-update/issues/8 for it.


Update Fornax to .NET Core 3.0

Also update build dependencies to leverage .NET Core 3 local tools.

Closed by #23


confine relocate component to playspace area

The relocate at intervals component frequently sends units outside the playspace area.
Modify it so it's confined with playspace area constraints.

implemented and tested


Convert the grid stack widgets to PDF is not working

Please provide more details. Not sure that this is the problem with gridstack. Does your HTML to PDF library work fine with absolute positioned blocks?


Building OpenSFM on Windows

Hello,
would you share how to install and run OpenSFM on windows ?  Has anyone successfully done it before?
sincerely

Try https://gist.github.com/jack06215/878a2cc8f0c1f111313ba0a1cfd86bb3 for the instructions.

Jesus.  Those instructions...


Integrate Alles ID for avatar usage

set my avatar [alles user id]

https://avatar.alles.cc/allesuserid

From Archie:

also if you wanted you could make it slightly easier so instead of putting in the id you could just do set my alles Archie Baer#0001, then fetch the id using https://horizon.alles.cc/nametag?name=Archie Baer&tag=0001, but that'd be more work lol

Another option would be to use QuickAuth. I don't know if that would be too complicated but with QuickAuth, you can get the user id while verifying that the user doesn't enter a random id/name.

Yeah, and you could use it as an optional authentication method

Yeah, "log in with alles"

QuickAuth is implemented! (try set my allesid, then log out, and then login [username]). And avatars are now displayed on the Compendium person pages for anyone who has set an AllesID. Woot!

Alles integration has been removed. Looking forward to implementing other authentication and avatar integrations with more established, stable entities.


Upgrade to the latest jenkinsslave Alpine

This will start with using Go 1.7.3

Tested with local Jenkins and a Go project


Movable: Setting enabled as function does not work

When using the Movable plugin I would like to control when tasks can be moved and is using a function for the enabled property of the movable directive. Can't get this to work! If I switch back to using a property then it works as expected.
I'm also using the Draw Task plugin and in that using a function for enabled works.
...
<gantt-movable
	enabled="calendar.options.canMove"
	allow-moving="true"
	allow-resizing="true"
	allow-row-switching="false">
</gantt-movable>
...

I can't get this to work...
$scope.calendar.options = {
...
   canMove: function (e) {
	// ignore e for now (just return false for testing purposes)
	return false;
   },
...
}

...but this on the other hand works as it should!
$scope.calendar.options = {
...
   canMove: false,
...
}

gantt: v1.2.6
angularjs: v1.3.15

I'm not sure it's supposed to work with a function. Why not using a scope variable ?

According to the docs it should be possible to use a function.
"Enable moving and resizing of tasks. Can also be a function (fn(event)) which has one parameter for the event. Such a function can be used to only activate the moving when a certain mouse button is pressed or the task is in a certain condition."
I need to be able to evaluate a function to disallow/allow moving dependent on application state.

Ok sorry, I forgot about that feature ... Thanks for pointing out the docs ! :p

No worries! :-)

It's now fixed in master, and also I've added an additional Task parameter to access the internal task of the future (or not) moving task.


Add cp module

@gwaybio This is ready for review!

@gwaybio This PR is ready for review again! Ty!

@gwaybio All fixed! I am going to merge!


added fix for https://github.com/zeit/next.js/issues/8893

Added in the env variable as identified in the issue comments

Thanks!


Do not search for comments when no pr_id

Rename was_last_build_successful and don't fail when no pr_id.
Fixes https://github.com/packit-service/packit-service/issues/646 but probably not the real cause.

I am going to merge manually since regular tests passed.
Thanks for the review.


mra music identifier/finder

Description of the new feature / enhancement
music identifier or finder by listening to desktop or microphone audio
Scenario when this would be used?
to find music name
Supporting information
mra - https://mra.jadquir.com/
like this.

Neat idea but not something powertoys team has the resources to do.