🐛 [firebase_auth] D/FirebaseAuth(11291): Notifying id token listeners about a sign-out event. Getting call in auth state change multiple times or constantly.

Bug report
Describe the bug
I am using FirebaseAuth.instance.userChanges stream to listen sign in and sign out events. I have sign in without verified email and then logged out. Not I am getting sign out call again and again without any changes.
Steps to reproduce
Steps to reproduce the behavior:
My app handles authentication using a Bloc, which emits the current authentication status (Logged in / Logged out). On startup, the Bloc initializes the user repository which listens to authStateChanges.
authStream.onData((firebaseUser) {
        if (firebaseUser != null) {
          listenUserChange(firebaseUser.uid);
          UI.showLoader(true);
          userRepository.setUser(
            user: firebaseUser,
            onLogin: (UserModelNew value) {
              UI.showLoader(false);
              add(OnLoginSuccess(user: value));
            },
            onRegister: (UserModelNew value) {
              UI.showLoader(false);
              add(OnRegisterSuccess(user: value));
            },
            onSentEmail: (UserModelNew value) {
              UI.showLoader(false);
              add(OnRegisterSuccess(user: value));
            },
          );
        } else {
          add(SignOut());
        }
    });

Expected behavior
event should not have to be occurs or called without any change, it should have to be called once.
Sample project
Providing a minimal example project which demonstrates the bug in isolation from your main App greatly enhances the chance of a timely fix.
Please link to the public repository URL.

Additional context
firebase_auth: ^4.2.5

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
/Users/apple/Documents/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel stable, 3.3.10, on macOS 13.0.1 22A400 darwin-arm, locale en-IN)
    • Flutter version 3.3.10 on channel stable at /Users/apple/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 135454af32 (5 weeks ago), 2022-12-15 07:36:55 -0800
    • Engine revision 3316dd8728
    • Dart version 2.18.6
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/apple/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = /Users/apple/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/apple/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Ultimate Edition (version 2022.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] Connected device (3 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64  • Android 13 (API 33) (emulator)
    • macOS (desktop)             • macos         • darwin-arm64   • macOS 13.0.1 22A400 darwin-arm
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 109.0.5414.87

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!
Process finished with exit code 0

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.18.6
Flutter SDK 3.3.10
ultra 1.3.4+35

dependencies:
- agora_rtc_engine 5.3.1 [flutter flutter_web_plugins js json_annotation]
- algolia 1.1.1 [meta http uuid universal_io]
- aligned_dialog 0.0.6 [flutter]
- audio_waveforms 0.1.5+1 [flutter]
- audioplayers 1.1.1 [audioplayers_android audioplayers_darwin audioplayers_linux audioplayers_platform_interface audioplayers_web audioplayers_windows flutter http path_provider uuid]
- bottom_picker 2.0.1 [flutter]
- cached_network_image 3.2.3 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web]
- camera 0.10.1 [camera_android camera_avfoundation camera_platform_interface camera_web flutter flutter_plugin_android_lifecycle quiver]
- clipboard 0.1.3 [flutter]
- cloud_firestore 4.3.1 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutter meta]
- cloud_functions 4.0.7 [cloud_functions_platform_interface cloud_functions_web firebase_core firebase_core_platform_interface flutter]
- connectivity_plus 3.0.2 [flutter flutter_web_plugins connectivity_plus_platform_interface js meta nm]
- cron 0.5.1 [clock]
- cupertino_date_textbox 1.0.1 [flutter intl]
- custom_image_crop 0.0.4 [flutter gesture_x_detector vector_math]
- easy_localization 3.0.1 [flutter shared_preferences intl args path easy_logger flutter_localizations]
- equatable 2.0.5 [collection meta]
- extended_image 6.3.4 [extended_image_library flutter meta]
- firebase_analytics 10.1.0 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_auth 4.2.5 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_crashlytics 3.0.10 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_messaging 14.2.1 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- firebase_performance 0.9.0+10 [firebase_core firebase_core_platform_interface firebase_performance_platform_interface firebase_performance_web flutter]
- firebase_performance_platform_interface 0.1.1+29 [_flutterfire_internals firebase_core flutter plugin_platform_interface]
- firebase_storage 11.0.10 [firebase_core firebase_core_platform_interface firebase_storage_platform_interface firebase_storage_web flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutter_advanced_drawer 1.3.2 [flutter]
- flutter_bloc 8.1.1 [flutter bloc provider]
- flutter_callkit_incoming 1.0.3+1 [flutter json_annotation]
- flutter_dotenv 5.0.2 [flutter]
- flutter_downloader 1.9.1 [flutter]
- flutter_email_sender 5.2.0 [flutter]
- flutter_inappwebview 5.7.2+3 [flutter]
- flutter_keyboard_visibility 5.4.0 [meta flutter_keyboard_visibility_platform_interface flutter_keyboard_visibility_linux flutter_keyboard_visibility_macos flutter_keyboard_visibility_web flutter_keyboard_visibility_windows flutter]
- flutter_launcher_icons 0.11.0 [args checked_yaml cli_util image json_annotation path yaml]
- flutter_linkify 5.0.2 [flutter linkify]
- flutter_login_facebook 1.7.0 [flutter list_ext]
- flutter_native_splash 2.2.16 [args flutter flutter_web_plugins js html image meta path universal_io xml yaml]
- flutter_rating_bar 4.0.1 [flutter]
- flutter_screenutil 5.6.0 [flutter]
- flutter_slidable 2.0.0 [flutter]
- flutter_speed_dial 6.2.0 [flutter]
- flutter_svg 1.1.6 [flutter meta path_drawing vector_math xml]
- flutter_switch 0.3.2 [flutter]
- get 4.6.5 [flutter]
- get_storage 2.0.3 [flutter get path_provider]
- go_router 6.0.1 [collection flutter flutter_web_plugins logging meta]
- google_fonts 3.0.1 [flutter http path_provider crypto]
- google_sign_in 5.4.2 [flutter google_sign_in_android google_sign_in_ios google_sign_in_platform_interface google_sign_in_web]
- http 0.13.5 [async http_parser meta path]
- image_picker 0.8.6 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_platform_interface]
- in_app_purchase 3.1.0 [flutter in_app_purchase_android in_app_purchase_platform_interface in_app_purchase_storekit]
- intl 0.17.0 [clock path]
- jiffy 5.0.0 [intl]
- loading_animations 2.2.0 [flutter]
- lottie 2.1.0 [archive flutter path vector_math]
- mixpanel_flutter 2.0.0 [flutter flutter_web_plugins js]
- open_mail_app 0.4.5 [platform url_launcher flutter]
- paginate_firestore 1.0.3+1 [flutter bloc flutter_bloc cloud_firestore provider]
- path_provider 2.0.11 [flutter path_provider_android path_provider_ios path_provider_linux path_provider_macos path_provider_platform_interface path_provider_windows]
- percent_indicator 4.2.2 [flutter]
- permission_handler 10.2.0 [flutter meta permission_handler_android permission_handler_apple permission_handler_windows permission_handler_platform_interface]
- photo_manager 2.5.2 [flutter]
- photo_view 0.14.0 [flutter]
- qr_code_scanner 1.0.1 [js flutter flutter_web_plugins]
- qr_flutter 4.0.0 [flutter qr]
- screenshot 1.3.0 [flutter]
- share_plus 6.3.0 [cross_file meta mime flutter flutter_web_plugins share_plus_platform_interface file url_launcher_web url_launcher_windows url_launcher_linux url_launcher_platform_interface ffi win32]
- shared_preferences 2.0.16 [flutter shared_preferences_android shared_preferences_foundation shared_preferences_linux shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- shimmer 2.0.0 [flutter]
- sign_in_with_apple 4.3.0 [flutter meta sign_in_with_apple_platform_interface sign_in_with_apple_web]
- simple_email_sender 0.0.5 [flutter plugin_platform_interface]
- sliding_switch 1.1.0 [flutter]
- social_share 2.3.1 [flutter path_provider]
- syncfusion_flutter_datepicker 20.4.42 [flutter intl syncfusion_flutter_core]
- toggle_switch 2.0.1 [flutter]
- translator 0.1.7 [http]
- twitter_login 4.2.3 [flutter crypto http]
- uni_links 0.5.1 [flutter uni_links_platform_interface uni_links_web]
- upgrader 5.0.0 [flutter device_info_plus html http os_detect package_info_plus shared_preferences url_launcher version xml]
- url_launcher 6.1.7 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- uuid 3.0.7 [crypto]
- video_compress 3.1.2 [flutter]
- video_editor 2.1.0 [flutter ffmpeg_kit_flutter_min_gpl path_provider video_player video_thumbnail path transparent_image]
- video_player 2.4.10 [flutter html video_player_android video_player_avfoundation video_player_platform_interface video_player_web]
- visibility_detector 0.3.3 [flutter]

dev dependencies:
- flutter_lints 2.0.1 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]

transitive dependencies:
- _flutterfire_internals 1.0.12 [collection firebase_core firebase_core_platform_interface flutter meta]
- archive 3.3.5 [crypto path pointycastle]
- args 2.3.1
- async 2.9.0 [collection meta]
- audioplayers_android 1.1.1 [audioplayers_platform_interface flutter]
- audioplayers_darwin 1.0.3 [audioplayers_platform_interface flutter]
- audioplayers_linux 1.0.1 [audioplayers_platform_interface flutter]
- audioplayers_platform_interface 2.0.0 [flutter plugin_platform_interface]
- audioplayers_web 2.0.1 [audioplayers_platform_interface flutter flutter_web_plugins]
- audioplayers_windows 1.1.0 [audioplayers_platform_interface flutter]
- bloc 8.1.0 [meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- cached_network_image_platform_interface 2.0.0 [flutter flutter_cache_manager]
- cached_network_image_web 1.0.2 [flutter flutter_cache_manager cached_network_image_platform_interface]
- camera_android 0.10.2 [camera_platform_interface flutter flutter_plugin_android_lifecycle stream_transform]
- camera_avfoundation 0.9.10 [camera_platform_interface flutter stream_transform]
- camera_platform_interface 2.3.2 [cross_file flutter plugin_platform_interface stream_transform]
- camera_web 0.3.1 [camera_platform_interface flutter flutter_web_plugins stream_transform]
- characters 1.2.1
- checked_yaml 2.0.1 [json_annotation source_span yaml]
- cli_util 0.3.5 [meta path]
- clock 1.1.1
- cloud_firestore_platform_interface 5.10.1 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 3.2.1 [_flutterfire_internals cloud_firestore_platform_interface collection firebase_core firebase_core_web flutter flutter_web_plugins js]
- cloud_functions_platform_interface 5.1.26 [firebase_core flutter meta plugin_platform_interface]
- cloud_functions_web 4.3.15 [cloud_functions_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- collection 1.16.0
- connectivity_plus_platform_interface 1.2.3 [flutter meta plugin_platform_interface]
- convert 3.1.1 [typed_data]
- cross_file 0.3.3+2 [js meta]
- crypto 3.0.2 [typed_data]
- csslib 0.17.2 [source_span]
- dbus 0.7.8 [args ffi meta xml]
- device_info_plus 8.0.0 [device_info_plus_platform_interface ffi file flutter flutter_web_plugins meta win32]
- device_info_plus_platform_interface 7.0.0 [flutter meta plugin_platform_interface]
- easy_logger 0.0.2 [flutter]
- extended_image_library 3.4.1 [crypto flutter http_client_helper path path_provider]
- fake_async 1.3.1 [clock collection]
- ffi 2.0.1
- ffmpeg_kit_flutter_min_gpl 5.1.0 [ffmpeg_kit_flutter_platform_interface flutter]
- ffmpeg_kit_flutter_platform_interface 0.2.1 [flutter plugin_platform_interface]
- file 6.1.4 [meta path]
- firebase_analytics_platform_interface 3.3.17 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.5.1+8 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- firebase_auth_platform_interface 6.11.7 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 5.2.4 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core 2.4.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_core_platform_interface 4.5.2 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.1.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_crashlytics_platform_interface 3.3.10 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_platform_interface 4.2.10 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 3.2.11 [_flutterfire_internals firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- firebase_performance_web 0.1.1+18 [_flutterfire_internals firebase_core firebase_core_web firebase_performance_platform_interface flutter flutter_web_plugins js]
- firebase_storage_platform_interface 4.1.26 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_storage_web 3.3.19 [_flutterfire_internals async firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http js meta]
- flutter_blurhash 0.7.0 [flutter]
- flutter_cache_manager 3.3.0 [clock collection file flutter http path path_provider pedantic rxdart sqflite uuid]
- flutter_keyboard_visibility_linux 1.0.0 [flutter_keyboard_visibility_platform_interface flutter]
- flutter_keyboard_visibility_macos 1.0.0 [flutter_keyboard_visibility_platform_interface flutter]
- flutter_keyboard_visibility_platform_interface 2.0.0 [flutter meta plugin_platform_interface]
- flutter_keyboard_visibility_web 2.0.0 [flutter_keyboard_visibility_platform_interface flutter_web_plugins flutter]
- flutter_keyboard_visibility_windows 1.0.0 [flutter_keyboard_visibility_platform_interface flutter]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path vector_math]
- flutter_plugin_android_lifecycle 2.0.7 [flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- gesture_x_detector 1.1.1 [flutter vector_math]
- google_sign_in_android 6.1.4 [flutter google_sign_in_platform_interface]
- google_sign_in_ios 5.5.1 [flutter google_sign_in_platform_interface]
- google_sign_in_platform_interface 2.3.0 [flutter plugin_platform_interface quiver]
- google_sign_in_web 0.10.2 [flutter flutter_web_plugins google_sign_in_platform_interface js]
- html 0.15.1 [csslib source_span]
- http_client_helper 2.0.3 [http]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- image 3.2.2 [archive meta xml]
- image_picker_android 0.8.5+4 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- image_picker_for_web 2.1.10 [flutter flutter_web_plugins image_picker_platform_interface]
- image_picker_ios 0.8.6+4 [flutter image_picker_platform_interface]
- image_picker_platform_interface 2.6.2 [cross_file flutter http plugin_platform_interface]
- in_app_purchase_android 0.2.3+7 [collection flutter in_app_purchase_platform_interface json_annotation]
- in_app_purchase_platform_interface 1.3.2 [flutter plugin_platform_interface]
- in_app_purchase_storekit 0.3.4 [collection flutter in_app_purchase_platform_interface json_annotation]
- js 0.6.4
- json_annotation 4.7.0 [meta]
- linkify 4.1.0
- lints 2.0.1
- list_ext 1.0.6 [quiver collection]
- logging 1.1.0
- matcher 0.12.12 [stack_trace]
- material_color_utilities 0.1.5
- meta 1.8.0
- mime 1.0.3
- nested 1.0.0 [flutter]
- nm 0.5.0 [dbus]
- octo_image 1.0.2 [flutter flutter_blurhash]
- os_detect 2.0.1
- package_info_plus 3.0.2 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface win32]
- package_info_plus_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- path 1.8.2
- path_drawing 1.0.1 [vector_math meta path_parsing flutter]
- path_parsing 1.0.1 [vector_math meta]
- path_provider_android 2.0.22 [flutter path_provider_platform_interface]
- path_provider_ios 2.0.11 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.7 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_macos 2.0.6 [flutter path_provider_platform_interface]
- path_provider_platform_interface 2.0.5 [flutter platform plugin_platform_interface]
- path_provider_windows 2.1.3 [ffi flutter path path_provider_platform_interface win32]
- pedantic 1.11.1
- permission_handler_android 10.2.0 [flutter permission_handler_platform_interface]
- permission_handler_apple 9.0.7 [flutter permission_handler_platform_interface]
- permission_handler_platform_interface 3.9.0 [flutter meta plugin_platform_interface]
- permission_handler_windows 0.1.2 [flutter permission_handler_platform_interface]
- petitparser 5.1.0 [meta]
- platform 3.1.0
- plugin_platform_interface 2.1.3 [meta]
- pointycastle 3.6.2 [collection convert js]
- process 4.2.4 [file path platform]
- provider 6.0.5 [collection flutter nested]
- qr 2.1.0 [meta]
- quiver 3.2.1 [matcher]
- rxdart 0.27.7
- share_plus_platform_interface 3.2.0 [cross_file flutter meta mime plugin_platform_interface path_provider uuid]
- shared_preferences_android 2.0.14 [flutter shared_preferences_platform_interface]
- shared_preferences_foundation 2.1.1 [flutter shared_preferences_platform_interface]
- shared_preferences_linux 2.1.2 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.1.0 [flutter plugin_platform_interface]
- shared_preferences_web 2.0.4 [flutter flutter_web_plugins shared_preferences_platform_interface]
- shared_preferences_windows 2.1.2 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- sign_in_with_apple_platform_interface 1.0.0 [flutter plugin_platform_interface meta]
- sign_in_with_apple_web 1.0.1 [flutter flutter_web_plugins sign_in_with_apple_platform_interface js]
- sky_engine 0.0.99
- source_span 1.9.0 [collection path term_glyph]
- sqflite 2.2.2 [flutter sqflite_common path]
- sqflite_common 2.4.0+2 [synchronized path meta]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- stream_transform 2.1.0
- string_scanner 1.1.1 [source_span]
- syncfusion_flutter_core 20.4.42 [vector_math flutter]
- synchronized 3.0.0+3
- term_glyph 1.2.1
- test_api 0.4.12 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- transparent_image 2.0.0
- typed_data 1.3.1 [collection]
- uni_links_platform_interface 1.0.0 [flutter plugin_platform_interface]
- uni_links_web 0.1.0 [flutter flutter_web_plugins uni_links_platform_interface]
- universal_io 2.0.4 [collection crypto meta typed_data]
- url_launcher_android 6.0.22 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.0.17 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.0.1 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.0.1 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.1.1 [flutter plugin_platform_interface]
- url_launcher_web 2.0.13 [flutter flutter_web_plugins url_launcher_platform_interface]
- url_launcher_windows 3.0.1 [flutter url_launcher_platform_interface]
- vector_math 2.1.2
- version 3.0.2
- video_player_android 2.3.10 [flutter video_player_platform_interface]
- video_player_avfoundation 2.3.8 [flutter video_player_platform_interface]
- video_player_platform_interface 6.0.1 [flutter plugin_platform_interface]
- video_player_web 2.0.13 [flutter flutter_web_plugins video_player_platform_interface]
- video_thumbnail 0.5.3 [flutter]
- win32 3.1.3 [ffi]
- xdg_directories 0.2.0+2 [meta path process]
- xml 6.1.0 [collection meta petitparser]
- yaml 3.1.1 [collection source_span string_scanner]

Sorry It was my mistake I have putted sign out event in listener 😅.


[GitHub Issues] Tell people to make sure that they are subscribed to their issue

Sometimes people just creates an issue and will not respond to the team later.
Some of them creates a GitHub account just for creating an issue in this repo and will not bother to check on their issues later.
We should add a comment in the issue templates to tell them to make sure that they are subscribed to their issues

You get auto subscribed to stuff you respond to / file


Hiding iter8 gen exp command

Resolves #1108

we will need an issue for iter8 gen k8s, won't we?

Yes, absolutely. I think we need to do a bit more for launching experiments into Kubernetes (in particular, what happens when you launch experiments repeated for the same app)... we need an issue/design discussion. Will open these shortly.


Initial attempt at glusterfs support.

This doesn't work except for the fuse mount case. You're welcome.

I just realised I need to make a new pull request because this one is against master not develop (it predates develop I think).


Add moduleDetection compiler flag to allow for changing how modules are parsed

The default setting is 'auto', where JSX containing files under react-jsx and react-jsxdev are
always parsed as modules, and esm-format files under module: node12+ are always parsed as modules,
in addition to the 'legacy' detection mode's conditions for other files. (Declaration files are exempt from
these new conditions)
The 'legacy' mode preserves TS's behavior prior to the introduction of this flag - a file is
parsed as a module if it contains an import, export, or import.meta expression.
In addition, there is a 'force' mode that forces all non-declaration files to be parsed as modules.
(Declaration files are still only modules if they contain a top-level import or export.)
This technically breaks the parser API, but it's kinda-sorta backwards compatible so long
as you don't need the functionality associated with more recent compiler flags.
While "auto" is a mostly backwards compatible new default (technically it breaks react-jsx output, but it does so in a case where the output was nonfunctional and fixes it, so it's fine), most people probably just want to use "force" unless they intend to have script files in their compilation.
"moduleDetection": "auto" (the new default):
Fixes #46723
Fixes #40501
"moduleDetection": "force":
Fixes #18232
Fixes #14279

Can you add an explanation to the PR description of why 'legacy' is needed -- basically, what you expect to break if everybody were upgraded to 'auto' with no escape hatch.

Hm, I alluded to it, but it would break people with global script files using react-jsx or react-jsxdev with jsx tags in them that somehow were post-processing them to actually work (since they didn't by default, but also weren't an error).

esm-format files under module: node12+

Does this include .ts files when there’s a package.json with "type": "module"?

Yep.

esm-format files under module: node12+ are always parsed as modules

I’m unclear on what constitutes an “esm-format file” if it’s not based on the presence of import/export, seeing as ESM mode is controlled by the runtime, not the file contents.  Does this mean node.js semantics, i.e. .mts is always a module, .ts is a module only if "type": "module", etc.?
If the above is the case it sounds like I probably want to use force when targeting ESM in the browser.

Yes and yes. Esm mode modules are the only ones which transpile to esm output, to whit (cjs mode files transpile to cjs). Honestly, if you're targeting browser modules you probably want moduleDetection: force and module: esnext, rather than nodenext, since you don't want cjs in your compilation at all.

In addition, there is a 'force' mode that forces all non-declaration files to be parsed as modules.
(Declaration files are still only modules if they contain a top-level import or export.)

@weswigham Does having a .cts extension override "moduleDetection": "force"?

A .cts module is still a module, just a cjs format one instead of an esm one. The flag on force disables script mode files, which are like, the old global browser global-type scripts.

Ah okay, the script mode stuff doesn't refer to cjs but old-fashioned browser scripts. Thanks.


A problem caused az storage explorer to start with GPU acceleration disabled [macOS]

Storage Explorer Version: 1.10.0
AzCopy Version: 10.2.1
Platform: macOS
Architecture: x64
Build Number: 20190912.8
Commit: 3e75e006f
Support ID: c286dcb1-3630-4aa3-6859-88fbbde126a3
Copyright © 2019 Microsoft. All rights reserved.
Bug Description

Steps to Reproduce

Long running processes. uploaded 3TB image file

Expected Experience

Actual Experience

Additional Context

I am also experiencing this issue on Win10. The below is the version of Azure Storage explorer I am using:

@masters3d @Judyll Can you please provide more detailed repro steps? It's not clear what you mean by "long running processes". Did this error occur at launch, or sometime later?

Thanks for replying @craxal . For me, the issue happens during launch:

I just click OK and forget about it. It does not disrupt any Azure Storage functions I'm using though.

@Judyll Interesting, I've never seen this occur on Windows or Mac before. What version of Windows are you running?
@masters3d What version of Mac are you running?

@craxal Here is the version of Windows I am running:

macOS 10.14.6

Can you please provide more detailed repro steps? It's not clear what you mean by "long running processes". Do you mean to say that the error occurred while uploading a 3TB file? Or did the the error occur at launch?

I set it to copy a big file. I came back to the machine the next day to see the error.

Also, what's the result of the issue? Does it disrupt any long-running tasks, such as a download or upload, of do they continue as normal?

The GUI said that it was still going but then the azcopy cancelled but I am not sure if there are directly related. This was an upload. I ended up retrying using the command line but I like the GUI and prefer to use that if available.

I hit this same error.  I ran the updated software on a Windows 2012 R2 Server, I wanted to see how fast the new AzCopy feature was, as the old copy speed was a big limitation of hosting backups remotely.
Anyway - The download was going, blazing fast, suddenly everything froze, I got kicked off RDP, all of my websites that were using that DB went down, and I was unable to get back on RDP for about 5m.  Once I was able to get back on, I was met w/ the  same dialogu @Judyll posted.
I don't think the download finished either, once I got on I closed all of it because it was an important server.

I think I just spotted the same error this morning. Either it happens after leaving the application running for a while (and I wasn't even doing anything) or it happens when you try to RDP (which I also did once). I'll need to investigate.
@masters3d Are you remoting into your Mac at all? How long does the app/operation run before you get the error message? I assume you had to wake the machine up?
While we look into this, have you tried running AzCopy from the command line for a quick workaround? Storage Explorer lets you copy the command it uses to run your operation so you can try it on the command line yourself.

If y'all run Storage Explorer with the gpu disabled, are your downloads/uploads able to finish?

Are you remoting into your Mac at all?

No

How long does the app/operation run before you get the error message?

Don’t know.

I assume you had to wake the machine up?

No sure.

While we look into this, have you tried running AzCopy from the command line for a quick workaround?

Yes but it did not work. My whole experience has been poor. My test file is 3T. Too much effort to get this to work but that is probably another issue. Just give me rsync :) I might have to just go back to Samba shares. Good luck.

@masters3d is this problem still repro'ing for you?

I don't have the bandwidth to test this. I haven't used the tool since last year. Please feel free to close as fixed if you believe it has been addressed.


Create additional button in the menu scene

New button, due player may play remotely with another one.

Finished, Sadeg :(


Address resource leak

On shutdown there's a warning:
UserWarning: resource_tracker: There appear to be 168 leaked semaphore objects to clean up at shutdown

Might be lingering queue items.
This that is the fix what causes the warning.

Done in #14


Add +1 on strlen to account for null-terminator

In the addUrl function of core/pageProcessor/user_api.c the url being copied wasn't accounting for the space to null terminate the destination string.

Thank you so much for your PR.


Ηοw setup sign in with React-Isomorphic App Using  identityServer as Provider?

Is there any example to for this?

Here's a sample of the client-side library: https://github.com/openid/AppAuth-JS


REQUEST: New membership for lakshmimsft

@lakshmimsft
Requirements

[x] I have reviewed the community membership guidelines
[x] I have enabled 2FA on my GitHub account, see https://github.com/settings/security
[x] I have subscribed to the Radius community Discord server
[x] I am contributing (any of the following apply: issues, discussions, PRs, reviews) to 1 or more Radius repositories

List of contributions to the Radius project

PRs reviewed / authored

/radius: MAINTAINER
Authored [101 PRs]
Reviewed [269 PRs]
Opened [58 issues]

PRs reviewed / authored

/samples: MAINTAINER/APPROVER
Authored [8 PRs]
Reviewed [20 PRs]
Opened [ 7 issues]

PRs reviewed / authored

/docs: APPROVER
Authored [11 PRs]
Reviewed [18 PRs]
Opened [ 6 issues]

PRs reviewed / authored

/recipes: MAINTAINER
Authored [2 PRs]
Reviewed [6 PRs]
Opened [ 0 issues]

AB#13529

+1 APPROVER on /radius until more evidence of long-term planning/influence is demonstrated
+1 APPROVER on /samples
+1 APPROVER on /docs
Need more substantial contributions to the /recipes repo specifically before consideration for APPROVER role.

+1 APPROVER on /radius until more evidence of long-term planning/influence is demonstrated
+1 APPROVER on /samples
+1 APPROVER on /docs

+1 for APPROVER on radius, samples, and docs. For maintainer on Radius, I'd want to see more strategic or direction-setting work. I think you're on a good path to grow into this.


Implement a new Figma design

Currently there is a left panel and right panel for the importers/exporters and the configuration width is very limited. This makes the flow of editing configuration not user friendly.
The configuration of each importer/exporter should open in a popup modal that is large enough to edit the configuration comfortably.
Perhaps we should use this to replace the left/right panel ui with the ui currently used for the progress indication.
So each account will have a card that will have a settings icon. Clicking that settings icon will open a popup modal.
When running the scraping, the settings icon will be replaced with the progress indication.

I think it is a good and easy improvement, and that is why we can consider to implement it even before we are consulting with a UX expert.

There is a request from old users the validate the importer when it added. https://github.com/baruchiro/israeli-bank-scrapers-desktop/issues/56
I'm putting it here to think if we want to handle it with this issue, or to open an issue after this finished.

There is a request from old users the validate the importer when it added. baruchiro/israeli-bank-scrapers-desktop#56
I'm putting it here to think if we want to handle it with this issue, or to open an issue after this finished.

I can assist with planning a user friendly UX

@Moshet AMAZING!
You're welcome to download and install the application and give us feedback.
To download, for now until we will have a release (soon!), select the latest action from this link:
https://github.com/brafdlog/budget-tracking/actions?query=workflow%3ABuild%2FRelease+branch%3AunifyRepos
And after entering the item, you will find artifacts on the bottom, download the right one depends on your system.
If you need out assistant, open a discussion here.
And here are the UI related issues.

I downloaded the software and I'll begin with the operational stuff:

What's the purpose of the upper horizontal menu?
I couldn't get any info scraped.
A. On the first attempt, I was just waiting and nothing happened (therefore I think it's better to add some kind of active status bar that communicates what happens now instead of a spinning circle - actually two circles, which is also unnecessary).
B. On the second attempt I got an error message that said "ENOTDIR, not a directory.". On this note - I think the error messages should be more informative.

UI remarks:

Colors should be match flat UI style. I'd go for a green theme (for example #2ecc71 - see more here: https://flatuicolors.com/)
Logo (new name first)
Buttons could use a more flat UI style - you can refer here for an example: https://uxdesign.cc/ui-cheat-sheets-buttons-7329ed9d6112

UX remarks are in the attached photo.
Let me know what you think

Thanks!
Regarding the issues you have, I would like to understand the problem. There is an issue: #170 for the ENOTDIR. @baruchiro This should work in the latest version right? So @Moshet you can try downloading the latest version and see if there are still issues. If there are could you open an issue with how to reporuce?
Regarding the design and ux I just did a session with a designer that contributed some time to make a basic design for the near future. See here.
The logo and name are not up to date and there are two color palette options there.
I suggest that we base the discussion on that design because clearly the current ux is far from what we want.
WDYT?

@brafdlog, I tried downloading again and the ENOTDIR error is still there. Maybe someone forgot to upload the newer version?
Regarding the UI - Looks great! I'd go for a greenish color which is more money related.
Also good to see that we thought about a similar UX flow:) However, I'd go for a "less clicks"-design which is more similar to what I proposed.
I.e. the user is entering the app, so it's clear that he wants to sync some financial data. So why should we make the user click on "add accounts" instead of just showing the user all the available financial institutions?
Also, there is no screen showing the scraped data.
I can talk to the designer too if you'd like me to.

@brafdlog, I tried downloading again and the ENOTDIR error is still there. Maybe someone forgot to upload the newer version?
Regarding the UI - Looks great! I'd go for a greenish color which is more money related.
Also good to see that we thought about a similar UX flow:) However, I'd go for a "less clicks"-design which is more similar to what I proposed.
I.e. the user is entering the app, so it's clear that he wants to sync some financial data. So why should we make the user click on "add accounts" instead of just showing the user all the available financial institutions?
Also, there is no screen showing the scraped data.
I can talk to the designer too if you'd like me to.

Hi, @Moshet I'm working on it, we need to wait for #178 to finish. And please note I updated the link to the artifacts (https://github.com/brafdlog/budget-tracking/actions?query=workflow%3ABuild%2FRelease+branch%3Amaster)

Hi, @Moshet I'm working on it, we need to wait for #178 to finish. And please note I updated the link to the artifacts (https://github.com/brafdlog/budget-tracking/actions?query=workflow%3ABuild%2FRelease+branch%3Amaster)

Hi, we have a complete Figma design to implement. If you want to help and get access to Figma, please contact.

Implemented in new UI


Determine peak heap usage when using mimalloc_reserve_os_memory

I'm testing the dev-slice branch and it seems to work really well when used in conjunction with mimalloc_limit_os_alloc and mimalloc_reserve_os_memory when you want to minimize page faults for predictable allocation workload. Nice work!
I'd like to find an optimal value for the mimalloc_reserve_os_memory option without having to perform trial-and-error. If I were to specify a large value for mimalloc_reserve_os_memory could I somehow determine the actual heap size used by my workload (e.g. via some runtime stat) so that I could then reduce the size of the mimalloc_reserve_os_memory to minimize RSS used by the process?

Ah interesting. I think if you call mi_process_info at the end of your run you can get the peak workload (rss) which should be a good estimate.  Perhaps it is also possible to return such info for a specific reserved area but I need to think a bit about that.
ps. Here is how to call mi_process_info (or use NULL for parameters you don't need):
mi_msecs_t elapsed;
  mi_msecs_t user_time;
  mi_msecs_t sys_time;
  size_t current_rss;
  size_t peak_rss;
  size_t current_commit;
  size_t peak_commit;
  size_t page_faults;
  mi_stat_process_info(&elapsed, &user_time, &sys_time, &current_rss, &peak_rss, &current_commit, &peak_commit, &page_faults);

Thanks, I'm able to dump the stats on process exit via mimalloc_show_stats=1 and I do see the peak rss as reported by getrusage(). However, this isn't helpful for my particular use case.
I'm trying to use mimalloc in a soft realtime setting where pages faults are minimized. I'm using mlockall() to lock all pages on process startup which causes the reported RSS to be less useful since it's always at least mimalloc_reserve_os_memory.
So I guess my real questions is whether one can determine the actual heap size used by mimalloc and not the pages touched/locked as reported by Linux.

Ah I see. I could give a reasonable approximation by scanning the committed bits in the reserved arenas. It is in arena.c. I will try to look into it but may not have much time at the moment.


Adds ability to import sitemaps to include a website

Adds sitemap.py, a new menu link in main.py for sitemaps, and refactors link.py to reuse its link parsing in sitemap.y
Allows one to provide a link to a sitemap url as a list of links to include.

I have added the comment with the example sitemap as requested.


Adding Stacked font support

Hi,
I've been using your directive for some time, and I was missing the stacked fonts capability.
I think it's quite clear, not sure if you had this specific implementation in mind.
Let me know what you think.

Great work! I like it. We'll cut a minor version too.


Support and features in angular webchat

Hi Team,
I have gone through multiple blogs and found out that angular webchat is having a very less support and features included. As webchat version 4 is purely based on react (as per my knowledge) which is not having much compatibility with angular. I want to know the list of the features which is available in angular webchat and also if there any plans for including features which are available for other frameworks.

@Bradrajkumar, can you elaborate on what features you feel are missing when using Web Chat in an Angular project?


Unclear relationships between intermolecular exclusions, 1-4 pairs, proper torsions, and improper torsions in Amber files

A section in the only prmtop documentation I can find reads:

If the third atom is negative, then the 1-4 non-bonded interactions for
this torsion is not calculated. This is required to avoid double-counting these
non-bonded interactions in some ring systems and in multi-term torsions.
If the fourth atom is negative, then the torsion is improper.

I don't know how to implement this and have gotten some inconsistent results when testing on some ring systems.

Should the third atom be negative if that (proper) torsion's first and fourth atom already appear as the first and fourth atoms in an earlier torsion? What if that atom pair is a 1-2 or 1-3 interaction from a different traversal of the bond graph - shouldn't that be handled by the general atom exclusions?
If an atom pair is the 1-4 pair of multiple (proper) torsions, does it matter which one has its third atom listed positive, or can it be any?
What about with impropers? I can find files with the third and fourth atoms negative, which doesn't make much sense to me. Atoms in improper torsions shouldn't have intermolecular interactions at all, scaled or not.

It can be assumed that the function writing the DIHEDRALS_INC_HYDROGEN, DIHEDRALS_WITHOUT_HYDROGEN, etc. sections knows

the atom indices of each atom in each torsion
whether a given torsion is proper or improper
whether this (proper) torsion's first and fourth also comprise an intramolecular pair in another torsion

More context: https://github.com/openforcefield/openff-interchange/issues/682#issuecomment-1526161825

#686 is probably similar; possibly I'm making a single mistake here that is causing both issues

#1 The answer is yes, 1:4 non-bonded pairs should appear in one and only one torsion, so the third atom should be negative in any other torsion that would imply the same 1:4 non-bonded pair.  There have been Amber prmtop writers that double-counted 1:4 interactions, most often a problem in 6-membered rings.  When multiple torsions span the same four atoms, the parameter file (the source of information in the prmtop) will also have negative values of the torsion's periodicity for all but the final term: http://ambermd.org/FileFormats.php

#2 I think that any of the torsions can indicate the 1:4 interaction.  One weakness that I've always felt the Amber format has is the need to couple 1:4 interactions to some torsion.  There is a practical basis, which is that the torsions modify the potential after 1:4 interactions have been applied, and in most Amber models there are torsions spanning every possible 1:4 interaction.  But often when people tried to fit torsion parameters with mdgx, they would run into trouble, and the root of the problem was that there are no torsions of the sort they expected incorporated into the model.  Even if the torsion parameters are present in something like gaff.dat and the right sequence of atom types appears in the model, it doesn't mean that the antechamber program is going to choose those parameters and apply them.  I think it's quite possible to create models that have no torsions spanning a particular bond, and thus have no 1:4 interactions, although this is not the case with the common protein force fields.  1:4 interactions should be detected by bonding patterns, assigned a generic scaling factor, and then have this scaling factor modified by specific torsion interactions if specified.

Number 3 I think that impropers will never have 1:4 interactions, so marking the fourth atom index with a negative sign will eliminate the interactions regardless of whether the third is also negative.


Proactive Installation Sample App - Cannot get it to work

I do get a error in the log when running the sample,
System.AggregateException: Failed to acquire token for client credentials. (AADSTS700016: Application with identifier 'Application (client) ID' was not found in the directory 'Bot Framework'. This can happen if the application has not been installed by the administrator of the tenant or consented to by any user in the tenant. You may have sent your authentication request to the wrong tenant.
Im using the client id from my Azure bot - Configuration - Microsoft App ID in the azure portal.
The instruction is a little unclear, perhaps im doing it wrong...
I joined the first and second step, since I do not see any use for the second app registration, and use the app registration with the API permissions when creating the azure bot service.

@mrhub - From the error message it seems like the app id is not available in directory. Please verify if you are using correct client/app id. Also are you using C# sample or teamsfx sample?
When you set up the bot do it through the CLI, don't try to do it through the web interface.
Please refer similar issue here and let us know if this helps.

Yes, I do have the permissions, but I did not that instructions, I asked our admin to approve it manually. Does it matter?

The permissions seem to be correctly configured only. But please do follow the instruction mentioned and verify if you have added proper ids and secret details in appsettings.json file as well. Make sure to upload the app at org level, so that you can get AppCatalogTeamAppId and after that try to add the app in either personal or team scope.
FYI, we have tried this sample and it works properly at our end.

Okay, the instruction says to upload a custom app, that do not get in our "org directory". So I did upload the zip file to our org and I can see it now in teams.
And I can see the app using the graph endpoint
https://graph.microsoft.com/v1.0/appCatalogs/teamsApps?$filter=distributionMethod eq 'organization'
to get the AppCatalogTeamAppId.
But I do not get that far, exception thrown when calling
var currentPage_Memebers = await TeamsInfo.GetPagedMembersAsync(turnContext, 10, null, cancellationToken);
exception text:
AdalServiceException: AADSTS700016: Application with identifier 'AppId' was not found in the directory 'Bot Framework'. This can happen if the application has not been installed by the administrator of the tenant or consented to by any user in the tenant. You may have sent your authentication request to the wrong tenant.
I do not have any control over the tenantId, it is read from the "turncontext" that is sent from teams.
What am I doing wrong??

There is some issue with the app id/tenant id you created and configured. Could you please retry the steps by following the guidelines step by step creating new app id? https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/graph-proactive-installation

I checked the Nodejs installation guide, and there it says
4. Supported account types: Select "Accounts in any organizational directory"
there is no mention of multitenant in the csharp guide...
Now it works, changed from single tenant to multitenant.
Thanks for your support!


Update ebayclass.py

This should fix #13

Is it correct that you started your branch from the branch of #14?

I think you need also to update test files:

https://github.com/vinc3PO/ebayKleinanzeigenAlert/blob/master/test/test.html
https://github.com/vinc3PO/ebayKleinanzeigenAlert/blob/master/test/test_article.html

Is it correct that you started your branch from the branch of #14?

Oh I see what I did wrong here. Why is GitHub so difficult I thought it will only keep my change to ebayclass.py here...

I think i need to do this with branches...

The easiest way would be to cherry-pick your commit:
git checkout origin/main
git checkout -b fix-price
git cherry-pick 52037f0bb783c38bf0a265d9caac617ca5af7147


Numerical error messages: real problem or just terminal noise?

I'm running a very simple model inferring a Gamma distribution over response times in a memory task.
When I run HMC (or NUTS) I get hundreds, maybe thousands of Warning: The current proposal will be rejected due to numerical error(s). messages. As a new user, coming from pymc, this was quite disconcerting. Is something terribly wrong with my model?
But upon looking further, it seems that these are showing up all over the place, even in one of the official tutorials (without any explanation). So this makes me think that some amount of numerical error is really not something to worry about. But then, maybe we shouldn't be filling up the user's scrollback history with these messages? For example, maybe a running tally should be kept and reported once along with the other diagnostics? Or maybe this should be set a @debug level message?

The messages are caused by AdvancedHMC which unfortunately does not respect the verbosity levels of Turing. The errors can be real and indicate a problem with the model and/or the sampler settings but they can be ignored in the initial phase when the step size is tuned - depending on the model and the initialization, it can happen that a too large step size results in a non-finite gradient of the log density.
Related: https://github.com/TuringLang/Turing.jl/issues/1398, https://github.com/TuringLang/AdvancedHMC.jl/issues/217, https://github.com/TuringLang/Turing.jl/issues/1493

Thanks! It sounds like the AdvancedHMC devs don't want to fix this, so maybe the solution is (as @xukai92 suggested in TuringLang/AdvancedHMC.jl#217) to wrap the logging messages in Turing? Ideally Turing would do some diagnostics to figure out if the errors are safe to ignore (I have no idea they're happening in the initial tuning phase or not) and print a warning message if they aren't.
If one of the first thing a user encounters when using a library is a huge wall of cryptic warnings, they are less likely to continue using that library. So there is a very real cost here, beyond just the inconvenience of having to wrap your sample calls in a Logging.with_logger call.

explain more clearly in the message what these warnings indicate, what causes them, when they can be ignored, and how to disable them (maybe the longer explanation only shown once, similar to deprecation warnings)

I'm worried that explaining it in the warning thoroughly can be hard.
How about we add a page in our doc to explain this and link to that from the warning message.
We can give more detailed guides via this way.

by default ignore the warnings when the step size is tuned

That's a good idea.

Silencing warnings by default during during tuning is a good idea.  The running tally and summary message is also a good idea; R prints out There were 50 or more warnings (use warnings() to see the first 50) in similar situations.
In practice, I totally ignore these warnings when there are just a few of them, but if there's a cascading wall of text while sampling, I take it to mean there's something wrong with my model.  Maybe capture them during sampling, then on completion print out a message like
Warning: 666 proposed samples were rejected due to numerical errors (80% of total).
Too many numerical errors may reflect problems in the model and/or sampler (increasing the number of tuning samples
or reducing step size may help).  Type xxxxx for details, or yyyyy to disable future warnings.

Silencing warnings by default during during tuning is a good idea. The running tally and summary message is also a good idea; R prints out There were 50 or more warnings (use warnings() to see the first 50) in similar situations.
In practice, I totally ignore these warnings when there are just a few of them, but if there's a cascading wall of text while sampling, I take it to mean there's something wrong with my model. Maybe capture them during sampling, then on completion print out a message like
Warning: 666 proposed samples were rejected due to numerical errors (80% of total).
Too many numerical errors may reflect problems in the model and/or sampler (increasing the number of tuning samples
or reducing step size may help).  Type xxxxx for details, or yyyyy to disable future warnings.

I think this is a great message, though it would be good to break down by tuning/sampling.

Duplicate of https://github.com/TuringLang/Turing.jl/issues/1891


Update webjars-play to 2.8.8-1

Updates org.webjars:webjars-play from 2.6.3 to 2.8.8-1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.webjars", artifactId = "webjars-play" } ]

labels: library-update, semver-minor

Superseded by #95.


Numeric on-disk write and search for SAI

This patch includes the following:

The disk/v1/kdtree package containing the kdtree writer and reader and associated classes
The implementation code to tie these into the existing read and write paths. The main parts of this are the NumericIndexWriter and the NumericIndexSegmentSearcher
Additional testing for the new code

We can re-target this to https://github.com/apache/cassandra/tree/cep-7-sai whenever we like.

Closed in favor of https://github.com/apache/cassandra/pull/2409


New API key is seen as unauthorized when used for POST,PATCH, and DELETE

I decided to create a new API key and remove the previous. That was successful but now when I make API calls for POST,PATCH, or DELETE I receive "message": "Unauthorized". This was working with the previous API key but as part of a rotation process we rest it. Any suggestion on where to look at to why the new API is rejected and how to verify it is validating against the new key generated by the application stack?

I've just run the api test using the new API key and it passes without issues. So I'm not really sure why it happens.
This console page lists the available keys. Does the page include your new key? If so, is the key associated with a usage plan?

The admin view does show the new key and that the old one has been removed.
I am not sure about the key associated to a usage plan. I have reviewed the API’s created by the stack and see no reference to this key in any of the configuration nor the old key.
I can execute a list components, incidents, and maintenances items with the API and passing the key in the header with x-api-key but when I perform any other operation is return unauthorized. Could the key be good but permissions some where we not updated properly for the new key created?

On Nov 15, 2018, at 6:01 AM, Kishin Yagami<EMAIL_ADDRESS>wrote:
I've just run the api test https://github.com/ks888/LambStatus/tree/master/packages/lambda/api_test using the new API key and it passes without issues. So I'm not really sure why it happens.
This console page https://console.aws.amazon.com/apigateway/home?#/api-keys lists the available keys. Does the page include your new key? If so, is the key associated with a usage plan?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/ks888/LambStatus/issues/142#issuecomment-439032351, or mute the thread https://github.com/notifications/unsubscribe-auth/ABqbCzdhNi3sxs4aQ9y4B8ffsOq5528Eks5uvWWlgaJpZM4YeE_R.

The red square below indicate a usage plan.

APIs to get a list components, incidents, and maintenances items need no permission. So it works even if the api key is wrong.

It does not show me a usage plan but an association to the release. Is this something I need to create on my own?

On Nov 15, 2018, at 6:37 AM, Kishin Yagami<EMAIL_ADDRESS>wrote:
The red square below indicate a usage plan.
https://user-images.githubusercontent.com/8448120/48556200-a1f4bc80-e926-11e8-919d-4f6b391733d0.png
APIs to get a list components, incidents, and maintenances items need no permission. So it works even if the api key is wrong.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/ks888/LambStatus/issues/142#issuecomment-439042337, or mute the thread https://github.com/notifications/unsubscribe-auth/ABqbC3ITHIVt4p4KTcwf2MtCiQEqEgZMks5uvW4HgaJpZM4YeE_R.

Correction on my last response as it appears I was one level to deep in the Api section. I have two usage plans associated with the API key which both associate to the same stage

On Nov 15, 2018, at 6:37 AM, Kishin Yagami<EMAIL_ADDRESS>wrote:
The red square below indicate a usage plan.
https://user-images.githubusercontent.com/8448120/48556200-a1f4bc80-e926-11e8-919d-4f6b391733d0.png
APIs to get a list components, incidents, and maintenances items need no permission. So it works even if the api key is wrong.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/ks888/LambStatus/issues/142#issuecomment-439042337, or mute the thread https://github.com/notifications/unsubscribe-auth/ABqbC3ITHIVt4p4KTcwf2MtCiQEqEgZMks5uvW4HgaJpZM4YeE_R.


GoogleCamera Orientation error

Bug Report
Problem
googleCamera Photo rotation angle is always 0
I find CameraLauncher.java
private int exifToDegrees(int exifOrientation) {
if (exifOrientation == ExifInterface.ORIENTATION_ROTATE_90) {
return 90;
} else if (exifOrientation == ExifInterface.ORIENTATION_ROTATE_180) {
return 180;
} else if (exifOrientation == ExifInterface.ORIENTATION_ROTATE_270) {
return 270;
} else {
return 0;
}
}
when exifOrientation = 6 [ExifInterface.ORIENTATION_ROTATE_90] ,  the return 0
fix
CameraLauncher.java
-->  line: 844
private int exifToDegrees(int exifOrientation) {
int retVal = 0;
switch (exifOrientation) {
case ExifInterface.ORIENTATION_ROTATE_90:
retVal = 90;
break;
case ExifInterface.ORIENTATION_ROTATE_180:
retVal = 180;
break;
case ExifInterface.ORIENTATION_ROTATE_270:
retVal = 270;
break;
default:
retVal = 0;
}
return retVal;
}

You're switch-case seems the same as the current if-else - I don't understand what the change should change. Without proper code formatting with `` it is very hard to read the statements.
Also, the issue template exists for a reason. 😊.
It helps us to debug the issue further and to provide a solution much faster. With important information missing, we unfortunately can't help you.
Therefore, please edit this issue accordingly or close and create a new one and make sure to provide all the required information.


To write test to cover lines in ijit.py

Fixes
@Qbiwan Can you try writing a test or modifying existing tests to cover these lines (in red) in ijit.py?

(https://codecov.io/gh/einsteinpy/einsteinpy/pull/547/src/src/einsteinpy/ijit.py?before=src/einsteinpy/ijit.py)
Perhaps you can test for the returned function's name to differentiate between _jit and f above?! Let me know, if you need some assistance.
Originally posted by @JeS24 in https://github.com/einsteinpy/einsteinpy/issues/547#issuecomment-754143844

@JeS24

Hello @Qbiwan! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tests/test_ijit/test_ijit.py:

Line 4:1: W391 blank line at end of file

Hello @Qbiwan! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tests/test_ijit/test_ijit.py:

Line 4:1: W391 blank line at end of file

@Qbiwan Also, you can pip install pytest pytest-cov and run pytest --cov-report=term-missing --cov=einsteinpy <replace with path/to/files.py> to check coverage for individual tests or groups of tests. You can drop the path to run all tests and obtain coverage information for all files. This way, you can know the coverage before pushing. Do keep in mind that, when you run it on a single (or a subset of) test(s), the coverage information that pytest-cov returns, is correct for only that (those) test(s).
We will need to squash these commits though. Perhaps, this can help with that.

@Qbiwan Also, you can pip install pytest pytest-cov and run pytest --cov-report=term-missing --cov=einsteinpy <replace with path/to/files.py> to check coverage for individual tests or groups of tests. You can drop the path to run all tests and obtain coverage information for all files. This way, you can know the coverage before pushing. Do keep in mind that, when you run it on a single (or a subset of) test(s), the coverage information that pytest-cov returns, is correct for only that (those) test(s).
We will need to squash these commits though. Perhaps, this can help with that.

my bad, its probably because I made changes to master instead of a new branch in the first PR, then created this branch. Let's go back to the first PR and continue there, and I'll close this branch cos itg getting messy?

my bad, its probably because I made changes to master instead of a new branch in the first PR, then created this branch. Let's go back to the first PR and continue there, and I'll close this branch cos itg getting messy?

continue fixing  tests/test_ijit/test_ijit_without_numba.py on on this branch

continue fixing  tests/test_ijit/test_ijit_without_numba.py on on this branch


Dim uninstalled Python keys in uv python list

Attempted to improve the experience in https://github.com/astral-sh/uv/issues/9830 by dimming the key as well as the <download available> bit

I like styling both columns in each line the same -- that strengthens the relationship.
I think I like sorting available-but-not-yet-installed to the bottom, but that will be a "visually breaking change".
This discussion is helping me focus on what my main root issue is with uv installations. uv divides the python-sources into two worlds (managed & system), but "system", to me (and I think a lot of prior python install discussions), means "installed & managed by the OS". (This was certainly true during the python 2 to 3 migration era.)
So, where does that leave the user installed versions, such as those handled by pyenv or manual installs from python.org?
Which is a long winded way of saying that, on reflection, I think the "does uv consider this installed python managed or system" question is more important than "is this installed yet". Knowing that distinction is a requirement to choosing the correct --python-preference option for my current use case. (I'm unaware of any other command that shows that information. afaik, you have to guess, then confirm, by setting an option to uv python list)
Even more succinct, I would prefer addressing the (just opened) #9847 to this issue. (Sorry for the churn, but thanks for helping me think this through.)

We've been intentionally avoiding tables here, they're harder to parse and I don't think the complexity is merited. It's tough to definitely tough the information density / simplicity right though.

I like keeping them sorted as-is. I think it's easy to be disoriented if there are two different groups, each sorted, in the output.
I don't mind using color to dim things that are uninstalled. From the screenshot, I wonder if the color here is a little too dim. But I like the idea.

I like separate "installed" and "download available" sections, this would make it easier to skim what is actually installed and what's only in the list.
We could also reduce some duplication, e.g. those are all one python interpreter on my machine:
cpython-3.12.3-linux-x86_64-gnu                 .local/bin/python3.12 -> .pyenv/versions/3.12.3/bin/python
cpython-3.12.3-linux-x86_64-gnu                 .local/bin/python3 -> python3.12
cpython-3.12.3-linux-x86_64-gnu                 .local/bin/python -> python3.12

For reference, that's what my list currently looks like:

separate "installed" and "download available" sections, this would make it easier to skim what is actually installed and what's only in the list.

This is intentional though, like, you can use those versions automatically even if they're not explicitly installed yet. That's why they're listed in the first place. There's --only-installed if you don't want to see them.

We could also reduce some duplication, e.g. those are all one python interpreter on my machine ..

This is also intentional, so you can see what each executable on your path refers to. If we collapsed these, you'd lose that python and python3 are aliases for python3.12.


Don't split the community

I see some problems with the current approach for feature requests, bug reports and other discussions. There are currently three (four?) places where feature requests get posted:

the old feature request forum
the new ideas (which apparently isn't known that well, see last post in feature request vs last post in ideas)
this issue tracker (see #123, #113 or #114 for example)
the codewars-runner tracker.

This produces an unnecessary split in the community, and makes it hard for you to know the current needs. From a usability point of view, the old feature request forum is bad. There's no search, old posts are unavailable and it's hard to track the status of the request. Tracking the request seems much easier on ideas, but requires an additional account, and the communication on ideas has been… low.
The GitHub tracker doesn't provide voting (except for :+1: or :-1:), but the response time (either via an actual response or a label) is (subjectively) faster, which isn't a bad thing either. Still, it's an external site, so it doesn't generate any more page views (but also doesn't put any load on the forums).
And the codewars runner tracker,… well, let's forget about that one for a while.
So however you decide, make sure that the other ones get read-only (or in case of GitHub closed with a reference to the correct place). Otherwise the same requests will be put at different places to different times.

:+1:

Closing since GitHub is the only recommended place to log issues now.


Modify the project structure and add cross-platform support.

Brief explanation:

Modify Util namespace to EngineUtil: Reduce the potential for name duplication.
Move serializeEngineOptions() to EngineUtil namespace
Modify getDeviceNames() to getGpuDeviceNames() and move it to EngineUtil namespace: Users can easily view their GPUs indexes.
Change build() to a static function: Users do not need to create an Engine object in order to build the ONNX file.
Change "m_logger" to  static member: To adapt to the 4th point.
Remove m_calibrator and m_engineName: To adpat to the 4th point.
Modify loadNetwork(): Users can switch between different TensorRT engine files at any time.
Modify the constructor: To adapt to the 7th point.
Modify m_engineOptions to non-const: To adapt to the 7th point.
Add the function 'doesDirectoryExist()': Using 'doesFileExist()' to check if a folder exists is not feasible, so I need to modify it to a method that works universally on both Windows and Linux platforms (Linux platform not tested).

Tested only on the Windows platform; I may need your help to test it on Linux.

Great thank you for putting this together. I will review in the next few days.

Hi, any plan to merge this code?

Thank you for these great updates. I think it would have been helpful if you also updated the readme to provide the guide to set up the project in the Windows platform.

Can we close this PR?

Can we close this PR?

Yes let's close this for now. I however would like to add Windows support at some point. With this particular PR, I never had a chance to test it on Windows, and I didn't like that many of the CMake dependency paths were hard coded, and the build also failed on Linux b/c the author failed to test on that platform (which is the main platform we support).


Improve docs on Modals, Alerts, Offcanvas and Toasts close triggers examples

Description

"Dismissal can be achieved with the data attribute on a button" changed to "Dismissal can be achieved with the data-bs-dismiss attribute on a button" for more understandable indication
"using the data-bs-target" changed to "using the additional data-bs-target" for more complete indication
change outside button class from btn-close to btn btn-primary since an outside button is unlikely to be a cross button

Motivation & Context

Makes the documentation more understandable and precise.
Type of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[x] I have read the contributing guidelines
[x] My code follows the code style of the project (using npm run lint)
[x] My change introduces changes to the documentation
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Live previews

https://deploy-preview-38182--twbs-bootstrap.netlify.app/
For alerts for example: https://deploy-preview-38182--twbs-bootstrap.netlify.app/docs/5.3/components/alerts/#triggers

Thanks!


Setup deployments at railway

Create dev/prod environments on Railway. Setup env vars and railway deployments in github actions.

Completed


Add Recording API

Record steps and distance without the need for third-party apps.  Simply call GoogleFit.startRecording()  after authorizing.
The function need only be called once but can be called multiple times (Perhaps every time the app is opened).  Once called, the Recording API is initialized for selected fitness data types and will be reinitialized when the mobile device reboots.

All seems really good!
Thanks, @reboss !!!

Awesome, thanks!  I would like to continue working on this when I get time.  In the future I'll continue to make an issue beforehand to get your approval before attempting any additions/changes.
Cheers!


How to: Change engine sounds for different vehicles

Currently I can only change the engine sounds by changing the .mr file in the explorer.
How can we be able to for example, pre configure a few cars with different engine sounds?
For me they won't even have to be in the level at the same time, but how can we make this possible ?

I've found a way to do it via the editor. Will Post a Pull Request on this later on


Bug in StrechFillRect transform invocation

It seems that the parameters in Graphic.Transform have been accidentally swapped. The code reads:
public Transform Transform {
  get {
    return Transform.StretchFillRect (ViewBox, new Rect (Point.Zero, Size));
  }
}

but should be:
public Transform Transform {
  get {
    return Transform.StretchFillRect (new Rect (Point.Zero, Size), ViewBox);
  }
}

As a result, the canvas transformation applied by Graphic.Draw (which takes into account the Graphic.ViewBox) does not work correctly.

Ahhh, thank you. I need to write a test for this.

I'm not so sure if the parameters are backwards. Can you provide a test for this?


Edge versions 1 or 12?

Throughout the docs and code base there are examples and tests documenting different versions of the Microsoft Windows 10 browser Edge, these values can be 1, 11, or 12
• The original commit via https://github.com/ai/browserslist/commit/e7c56e8df8a194ed1cb74b9d3b8fbb7371927cd2 ~3 months ago in https://github.com/ai/browserslist/issues/29 all reference edge 1
• The commit via https://github.com/ai/browserslist/commit/e105a4aac857d5d0da2e9e21b7e00bf81f6e594e ~16 days ago uses edge 12 in README.md and tests.js
So, should it be edge 1 or edge 12?

@ntwb Browserslist just uses data from Can I Use. It has 1 before and 12 right now.

Thanks for the clarification Andrey, I added a PR to update the tests to match the "real world" versons and remove any traces of edge 1 :)


Website

Ready/Rotating button doesn't work

Clicking on "Manual" mode button hides the input field


Improve error message for 'forget'

$ bin/restic forget /d 7 /w 4 /m 12
argument "/d" is not a snapshot ID, ignoring
argument "7" is not a snapshot ID, ignoring
argument "/w" is not a snapshot ID, ignoring
argument "4" is not a snapshot ID, ignoring
argument "/m" is not a snapshot ID, ignoring
cound not find a snapshot for ID "12", ignoring

Closes #640

Current coverage is 51.47% (diff: 0.00%)

Merging #641 into master will decrease coverage by 0.05%

@@             master       #641   diff @@
==========================================
  Files            93         93
  Lines          7430       7438     +8
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           3829       3829
- Misses         3051       3059     +8
  Partials        550        550

Powered by Codecov. Last update 6f72164...250b36e


webdriverio refresh() is not working

After each test, I'm trying to refresh my app but it's not working. It used to work, so I'm afraid a dependency was updated and it doesn't work anymore.
after(function () {
    return this.app.client.refresh().pause(shortPause())
})

spectron version: 3.7.2
webdriverio version: 4.8.0
  simple test
    ✓ my test
    1) "after all" hook

  1) my test "after all" hook:
     Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

This issue appears on spectron >= 3.6
It fails too with a JS code doing a window.location.reload() or window.location.href = '...'
Webdriverio seems not be the problem because spectron 3.5.0 + webdriverio 4.8.0 works fine. Maybe a chromedriver issue ?

I've just ran into the same problem with Spectron 3.8.0, going back to 3.5.0 solved it for me.

Any plan to fix this? I don't want to use old spectron  But refreshing app is a killer feature for me.

For some reason, it started to work for me again. Currently on those versions:
"spectron": "3.8.0",
  ⌞"webdriverio": "4.12.0"
  ⌞"electron-chromedriver": "1.8.0",
"electron": "2.0.7",


Template review feedback

Thanks for submitting a template to the gallery, there were a few issues in your template that needed to be resolved ahead of approving the template for the gallery.

We are seeing error "An unknown error has occurred, please try again." when we try to run the tests.

Hey @praveena-pappu,
It looks like that error is caused by the default value on the debugMode field. The tests seem to have some kind of dependency on the template preview. If you clear the default value then all the tests should succeed.
Do you want me to modify the template to remove the default value altogether? I included it there to help the user, so they won't have to type it because it's always fixed.

Before
After


Front page Elements with rego rules

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce

Edit cvat/apps/iam/rules/projects.rego with :
allow {
utils.is_business
}
Rebuild and start docker
Connect with User in Business group.
Projet are not show in front page (but the rules work when we try to access with directly link to project)

Expected Behavior
I want to show all projects/tasks/jobs in frontpage with user in group Business.
Possible Solution
No response
Context
No response
Environment
No response

Hello,
Try to setup Django Query object at the same file, it used to receive correct objects list from the database.

Thanks Bsekachev!


[JA] Fix broken link of TensorBoard notebooks.

This PR fixes broken links in two notebooks.

Visualizing Data using the Embedding Projector in TensorBoard
Hyperparameter Tuning with the HParams Dashboard

Hyperlinks in these two notebooks are valid in English but broken in Japanese, so I fixed them.

@lamberta I think we can merge this Pull Request safely without any translator's review because this Pull Request doesn't contain any changes about translated texts.

@lamberta Sorry, but please DO NOT MERGE. GitHub Actions overwrote my fix and break the link again.

Probably, I was able to solve the issue that the bot break the hyperlink.
I found three issues. The first is about this repo. The second one causes that CI breaks hyperlinks. It is related to both tensorflow/docs and tensorflow/tensorboard. The third one is about GitHub Actions.
The first one is only a typo. I fixed it in this PR https://github.com/tensorflow/docs-l10n/pull/499
Second, each notebook must have the "download notebook" button on the top of the notebook, however, notebooks of Tensorboard don't have the button. This condition is described in the nbfmt tool and checked in CI
https://github.com/tensorflow/docs/blob/16082db0a6299f381978e1a183fa9f3ec65652a0/tools/tensorflow_docs/tools/nblint/style/tensorflow.py#L181[…]-L184
Third, GitHub Action always applies both commands to changed files.
$ python3 -m tensorflow_docs.tools.nbfmt <changed_notebook.ipynb>
$ python3 -m tensorflow_docs.tools.nblint --fix --verbose --arg=repo:tensorflow/docs-l10n  --styles=tensorflow,tensorflow_docs_l10n <changed_notebook.ipynb>

Even if the commands described in the bot's interaction are passed without any issues, after making a pull request, GitHub action might make a change the files included pull request.
In this repo, GitHub Action breaks hyperlinks by the command python3 -m tensorflow_docs.tools.nblint --fix --verbose --arg=repo:tensorflow/docs-l10n  --styles=tensorflow,tensorflow_docs_l10n <changed_notebook.ipynb>. To avoid this, we have to following conditions;

The table that has class "tfo-notebook-buttons" must have four buttons; "View on TensorFlow.org", "Run in Google Colab", "View source on GitHub", and "Download notebook"
For each td element, HTML tags must follow the ordering as Button Name>

@lamberta I guess this PR is ready for merge. The same issue can happen in other languages including en, I will fix the docs in tensorflow/tensorboard.


RHMAP-11411 - WFM template - Wrong repo in package.json

Please, check and do the merge.
https://issues.jboss.org/browse/RHMAP-11411


[Bug]: [Auto layout] - Not able to fully resize widgets that are hug content type

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When we dnd a hug content type widget and try to resize the width, we are able to increase the size to only and extent and we have to resize it fully only when we enlarge it thrice or more
https://user-images.githubusercontent.com/104895602/224321855-2c9b42bc-08ee-45f4-b909-6c6e2e0b11c8.mp4
Steps To Reproduce

Dnd a hug content type widget
Try to resize it
Observe that we are not able to fully resize at once

Public Sample App
No response
Environment
Deploy Preview
Issue video log
No response
Version
Appsmith Community v1.9.11-SNAPSHOT

Able to resize hug type widgets in one go, raised a separate issue for a bug related the same. QA done for the original issue. @marks0351


mwc-tab does not allow you to left justify tabs

Describe the bug
I have a  with  inside of it. The tab itself displays as I expect but it is in the middle of the screen rather than left justified in the tab-bar. Looking at the CSS, .mdc-tab-bar is set to 100% width and mwc-tab :host is set to justify-content:center, flex: 1 0 auto.
If we could change that justify-content: center to justify-content: flex-start and flex: 1 0 auto to flex: 0 0 auto when minWidth is set then it would work as I would expect.
Expected behavior
When adding tabs set to minWidth I expect them to be left justified and not take up the entire width of the div it is contained in.
Screenshots
Current:

Expected:

Like this? https://jsbin.com/fivokowice/edit?html,output
Set the width of the <mwc-tab-bar> explicitly. Setting it to min-content will collapse it to the natural width of the tabs with their labels.

Well that was easy! Just tested and that works. Thanks.


:warning: Remove TMC bootstrap assets

Summary
Removes Locations, Placement, Synctarget related API resources from bootstrap process to avoid unmanaged APIS being present.
part of https://github.com/kcp-dev/kcp/issues/2954
Remove TMC APIS from bootstrap process

Related issue(s)
Fixes #
Signed-off-by: mjudeikis<EMAIL_ADDRESS>

/retest

/retest

/test all

/retest

/override ci/prow/e2e
/override ci/prow/e2e-shared
/override ci/prow/e2e-sharded
/override ci/prow/e2e-multiple-runs

@xrstf @sttts would like some rubber stamp on this :)

/approve
/lgtm


split addOrDeleteRules

addRule(), deleteRule()
vs
addOrDeleteRules()
It just makes sense. Even the shape of the request is different. With deleting I have to send an array of strings, but with adding I have to send an array of objects with value and tag properties.

OR, (which would be great), allow us to delete a rule by tag as well as id.


Translation

Isn't there a plan to translate in a simpler way like translating with weblate?

Hello, thank you for the idea. I've created the Transifex project.


APS-616 Remove ‘NAT’ option when defining app ap area

We want to remove the National AP Area. As a precursor to this we need to ensure no applicaiton exist in the system with this AP Area.
Context
See https://dsdmoj.atlassian.net/browse/APS-616
Changes in this PR
Screenshots of UI changes
Before

After

@yndajas that's fantastic, thankyou. I'll pull it into this branch


Support Unicode quotes as alternatives to ASCII quotes

Curly quotes “ (U+201C) and ” (U+201D) should be supported for opening and closing quotes respectively, and also japanese quotes 「 (U+300C) and 」 (U+300D), and so on.
I'm not quite sure how to handle all the differences without allowing weird things (opening with a closing quote, closing with an opening quotes), but there's no need to support nesting. All Unicode quotes should be backslash-escapable.
I'm only asking this because I had my fair share of end users complaining that their config files and stuff stopped working after they edited them with notepad.exe and the OSX text editor.

should be supported

Why?

@SimonSapin the motivation was given:

I'm only asking this because I had my fair share of end users complaining that their config files and stuff stopped working after they edited them with notepad.exe and the OSX text editor.

This suggestion was met with ridicule on IRC as well, but I do think it's a reasonable suggestion. At least we shouldn't pretend there is no possible motivation. Other mainstream languages don't support smart quotes, but other mainstream languages also don't support statically assured data race freedom!
Real world example: the code examples in this blog post (from reddit) will not compile if simply copy-pasted, because they contain smart quotes. This is arguably the blog author's fault, but hey.
Now, there are disadvantages too, like adding complexity and making it hard to read someone else's code (if your editor can't display the smart quotes) or edit it (if you don't know how to type them).

Now, there are disadvantages too, like adding complexity and making it hard to read someone else's code (if your editor can't display the smart quotes) or edit it (if you don't know how to type them).

To avoid too much complexity we should just have an opening list and a closing list. Things that can be used as both would be in both, such as ASCII ", and according to wikipedia also “ (U+201C) (german uses this as closing quote), and so on. To avoid not being able to type them, we shouldn't force the opening script to match the closing script.

@SimonSapin the motivation was given

(That paragraph was added after I wrote my comment.)

Is this actually a common problem? Worth mention that we already display help text when one uses 'smart' quotes instead of 'dumb' quotes:
fn main() {
    let a = “foo”;
}

<anon>:2:13: 2:14 error: unknown start of token: \u{201c}
<anon>:2     let a = “foo”;
                     ^
<anon>:2:13: 2:14 help: unicode character '“' (Left Double Quotation Mark) looks much like '"' (Quotation Mark), but it's not
<anon>:2     let a = “foo”;
                     ^

(playpen)

@SimonSapin ok, sorry for jumping to conclusions!
On Sun, Jun 19, 2016 at 7:11 PM, Simon Sapin<EMAIL_ADDRESS>wrote:

@SimonSapin https://github.com/SimonSapin the motivation was given
(That paragraph was added after I wrote my comment.)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/rfcs/issues/1655#issuecomment-227026195,
or mute the thread
https://github.com/notifications/unsubscribe/AAC3nyPJnkUA8uQZwFB1-UmTdrAngffVks5qNcySgaJpZM4I5OnH
.

One major disadvantage to supporting multiple codepoints for opening/closing characters: bulk edits using CLI tools could be significantly more difficult. Granted, Rust shouldn't be stringly-typed, but if I have a &str literal (or pattern of literals) in various places, and I was to grep/sed around for them, allowing fancy quotes (more likely even if unintentional if they compile successfully) into a codebase could cause that edit to miss instances of the string.

@dikaiosune \q or [[:quotation_mark:]] or something? (does POSIX have a "quotation mark" character class yet?)

Only laziness has prevented me from making such an RFC before.
My suggestion, upon consideration: support curly quotes (at least “” and ‘’, others I personally don’t mind about) with a warning. And then don’t worry too much about syntax highlighters (they can add it if they want, or not as the case may be).
See, the main time this comes up is with newcomers; this is a feature to make things a bit easier for people when they’re copying from slideshows. Most cases where it occurs will be one-off code which is immediately thrown away after the point is demonstrated. If we can make it easier for people at low cost, that’s good. Public opinion seems to be against supporting curly quotes as a first-class syntactic element (though personally I’d be rather interested to see a language which only supported curly quotes!), perhaps this form (accepted as a discouraged form with a warning to match) might be acceptable?

@SoniEx2 Quite possibly, but I don't think I've ever seen anything other than s/\"foo\"/\"bar\"/ or similar in use before. Supporting non-ASCII quotes seems like a bit of a footgun to me, and only has a tiny marginal benefit.

@dikaiosune It would however make Rust stand out. First language to break strings or something.

What about having a compiler mode/flag (e.g. --convert-quotes, or default mode) that silently converts UTF-8 quotes to dumb quotes whenever it feels like it’s necessary?

@phoenixenero People that already know how to add a compiler flag don’t need curly quote support. Think of the children (in Rust experience)!

That string literals always use the same delimiter (with not even a choice of double or single quotes like some languages) make them much easier to grep.
Grepping for strings that you see in a program’s output is an important technique for navigating a large or unfamiliar code base. I’ve done it for example when reporting a Cargo bug, to find the relevant code.

It's not like adding these different quotes to Rust can solve

end users complaining that their config files and stuff stopped working

since it is those config languages that do not support other quotes.

@louy2 It would set precedent.

@SoniEx2
It is too irrelevant a precedent to be set. You are much better off changing the parser of whatever config language you are using, or write a setting UI for your users instead of requiring them editing the config files by hand. If you are facing true end-users that is. If you are facing semi-technical people, it is better they learn the differences between different quotes.

@chris-morgan I think children generally have no problem learning about different quotes...... Think of the seniors!

Switching quoting styles could be used to avoid escaping quotes (think alternation of double- and single-quotes in English nested quotations).

@Ericson2314 In english nested quotes and surrounding quotes are visually different but semantically identical. In programming language escaped quotes and surrounding quotes are visually identical but semantically different. Escape is not replaceable by switching quoting style.

We have raw strings for quote nesting problem already: r#"<as "many" as you want unescaped "quotes" go "here">"#

While I definitely don't want to see Unicode curly-quotes allowed in code, I'd suggest that we could do a bit more to help with the original motivation here:

I'm only asking this because I had my fair share of end users complaining that their config files and stuff stopped working after they edited them with notepad.exe and the OSX text editor.

To make it easier to catch this kind of error, how about having the compiler detect Unicode open and close quotes, and produce a more specific error telling the user to use " instead?

@joshtriplett that already happens:
error: unknown start of token: \u{201c}
 --> a.rs:2:13
  |
2 |     let a = “a”;
  |             ^
  |
help: unicode character '“' (Left Double Quotation Mark) looks much like '"' (Quotation Mark), but it's not
 --> a.rs:2:13
  |
2 |     let a = “a”;
  |             ^

Would "smart english quotes do string interpolation" be a better idea?

@SimonSapin Perfect, thanks.
@SoniEx2 Having curly quotes delineate a different kind of string seems even worse and more surprising behavior than having them delineate a standard quoted string.

@joshtriplett What about "japanese quotes do string interpolation"?

But, why? I mean, why would you do this, and is it worth the loss? What do you get from fancy interpolation when you got format!?

I just tested the bracket-quotes mentioned in the initial issue, and they produce the following:
test.rs:2:14: 2:15 error: unknown start of token: \u{300c}
test.rs:2     println!(「Hello world!」);
                       ^
test.rs:2:14: 2:15 help: unicode character '「' (Left Corner Bracket) looks much like '[' (Left Square Bracket), but it's not
test.rs:2     println!(「Hello world!」);
                       ^

If people commonly use these to quote strings, it might help to improve the help string here, to not just mention square brackets but also mention string quoting.

@ticki Well... When I mentioned it on IRC (a while ago) I came up with being able to call macros in strings...
It's nicer/less messy than format, altho more magicky...

I do think it'd be nice to have a shorthand for string interpolation, similar to Python's new format-strings (f""); I'd love to see an RFC for that.  But I don't think that shorthand should use Unicode delimiters that most people won't have their keyboard configured to type.
In addition, those particular bracket delimiters, as double-width characters, take up multiple columns in a fixed-width terminal, which further increases confusion and inconvenience.

I'd prefer this problem is solved with tooling, rather than changing the language.

@rustlang/lang I'd like to propose putting this RFC in FCP, with disposition to close.
Based on the extensive discussion of this already, and the existing diagnostics in rustc to help detect the copy/paste scenario, I don't see much support for this proposal.

@joshtriplett Just a procedural note: since this is an issue rather than an RFC PR, we don't have any FCP procedure; the issue can just be closed.

Eh, I still think it'd be neat, but alright. Farewell Unicode.


feat: notify group members for the new assignment in the group

Is your feature request related to a problem? Please describe.

All group members of a group should get notify regarding the new assignment in the group.

Describe the solution you'd like

Create a new notification in app/notifications(we are using the noticed gem, documentation)
When group mentors click the submit button in the form for a new assignment, the notifications should be delivered to all group members as recipients.

Are you working on this? (Yes/No)
No

@vedant-jain03  i would like to work on this.

@omsurase Sure go ahead!

@vedant-jain03 could you please tell me what type of notification is expected?
Currently, group members are getting notifications in emails regarding new assignments.

@vedant-jain03 could you please tell me what type of notification is expected? Currently, group members are getting notifications in emails regarding new assignments.

@omsurase we are expecting the web platform notification.
Currently, we have two notification events

when someone stars a project, notify the author
when someone forks a project, notify the author

We want to notify all the group members for new assignment published by group mentor!

Hi , is anybody currently working on this issue? If not ... I would like to contribute.

hey @VaibhavUpreti I'm still working on it, feel free to come over to slack and we can work on this together

Oops I missed checking slack... well thanks for the heads up 👍

@vedant-jain03 unassigning myself because i cant seem to fix this issue.

@VaibhavUpreti are you interested to work on this issue?

Yes ... I think I can make it work. Kindly assign me the issue.

Hi @vedant-jain03, @VaibhavUpreti I'd also like to work on this.
@VaibhavUpreti  Can we work together?


Inline JSDoc tags don't work in comments that start with plain text

TS mostly supports inline tags, even though they're not standard, but the implementation is quirky since it's best-effort, not really a committed feature. Specifically, an inline tag works if the line starts with a non-inline tag, or is a line following such a line:
/** @param foo @see foo.bar */

or
/** @param foo - a long description
 * also @see foo.bar */

This is all down to the state machine we use for parsing, so it could be improved to also support
/** for more info @see foo.bar */

Based on discussion in #5802

@NoelAbrahams you were interested in seeing this work, I believe. I marked it Awaiting More Feedback because I don't remember this usage being widespread in the earlier survey I did. However, the fix is likely quite contained to the central JSDoc parsing state machine, so it might be easy to fix even if it's not widely used.

@sandersn
Thanks for following up on this.
I certainly see the fact of @see not working inline as an unnecessary restriction that can surprise the user.
The C# see comment allows specifying the tag inline. And my instinct was to write it like that.
We have a common use case for this where there are constructor option objects that create a certain type, eg
interface Foo {
}

/** Creates an instance of @see Foo */
type FooOptions = { bar: string; };

There is no easy way to break up the comment into a newline in a meaningful way.

Yep, JSDoc is subtly different from C#, and the spec tag for that is @link. But TS doesn't support @link at all right now and besides, a language service should be flexible and match expectations of multiple groups of users.


Add an example of loading another scene and stay connected

I developed a change-room component that loads another scene by fetching the html, selecting a specific entity and replacing another entity on the current page and changing the easyrtc room. Add an example in this repo.

I previously did this with htmx, it actually works great!
But this doesn't handle changing the room id, so I created a new component for this.
But if you want to load a part of a scene when you click on some 3d button, that may be a nice way to do it.
Here is a snippet changing a scene when you click on a portal:
<script<EMAIL_ADDRESS>...
<a-entity
  id="scene"
  environment="preset:forest;shadow:true"
>
  <a-link
    hx-trigger="click once"
    hx-get="japan.html"
    hx-select="#scene"
    hx-target="#scene"
    hx-swap="outerHTML"
    link="on:dontcare"
    href="japan"
    position="-3.5 1.5 -1.0"
    image="#thumbJapan"
  ></a-link>
</a-entity>


Incorrect result when numpy broadcasting in parallel

I stumbled into an incorrect behavior with jit parallel=True when writing into a numpy array using broadcasting.
I reduced my code to the following minimal example to demonstrate the incorrect behavior:
import numpy as np
from numba import jit
N=3
nxy=np.zeros((N,1))
@jit(nopython=True,parallel=True)
def example(nxy):
    count=0
    for n in range(nxy.shape[0]):
        #Pointless if statement that does nothing. If I remove it, it works ok.
        if n:
            n
        #writting to array:
        nxy[count,:]=1
        print(nxy[count,:]) #nxy[count,:] should contain [1.]
        count+=1
example(nxy)

The expected result would be:
[1.]
[1.]
[1.]

however the example prints:
[1.]
[0.]
[0.]

I understand that the example seems weird with having a counter in a for loop, but it is only meant to demonstrate an issue.
If I run it non-jitted or jitted with parallel=False it works ok.
If I remove the pointless if statement, it works ok.
If I replace nxy[count,:]=1 with nxy[count,...]=1  it works ok, because that part then does not seem to get parallelized. I am currently using that as my solution, because I get parallelization elsewhere, however, it makes me uneasy to not know why it behaves incorrectly in the demonstrated case.

Thanks for the report. I suspect that this is using unsupported broadcast semantics with parallel=True,  https://numba.readthedocs.io/en/stable/user/parallel.html#supported-operations (see item 5).
CC @DrTodd13 please could you confirm that is this the case? Thanks.

Just responding to prevent a stall. Issue still active.

Broadcast when one operation involves arrays of different shapes.  nxy[count,:] is just a slice.  This was just a bug.